Timeline

Sep 1, 2020:

11:57 PM Changeset in webkit [266451] by Nikita Vasilyev

• 4 edits
  2 adds in trunk

REGRESSION(r243264): Web Inspector: Style pane doesn't update after toggling CSS class
​https://bugs.webkit.org/show_bug.cgi?id=202065
<rdar://problem/55149141>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype.refresh.fetchedMatchedStyles):
(WI.DOMNodeStyles.prototype.refresh.fetchedComputedStyle):
(WI.DOMNodeStyles.prototype.refresh):
(WI.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
r243264 introduced this bug by never clearing _styleMap making it impossible to diff old
and new style declarations. Create and clear _styleMap at the same place as it was before r243264.

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.layout):
Layout now always re-layouts everything. Rules with modified selectors are now preserved by
exiting layout early.

(WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionSelectorWillChange):
Remove logic that tried to preserve indexes of CSS rules with modified selectors that
don't match (SectionIndexSymbol and everything related to it). Instead, avoid re-layout after
editing a selector.

LayoutTests:

Added a test to verify that WI.DOMNodeStyles.Event.Refreshed fires with appropriate
significantChange flag.

• inspector/css/node-styles-refreshed-expected.txt: Added.
• inspector/css/node-styles-refreshed.html: Added.

9:50 PM Changeset in webkit [266450] by Diego Pino Garcia

• 2 edits in trunk/Tools

[Flatpak SDK] Adapt clean-webkit script to flatpak
​https://bugs.webkit.org/show_bug.cgi?id=216044

Reviewed by Philippe Normand.

Keep relevant directories in WebKitBuild/ when using flatpak.

• Scripts/clean-webkit:

(usesFlatpak):
(listWebKitBuildFiles):
(removeFiles):
(main):

8:13 PM Changeset in webkit [266449] by commit-queue@webkit.org

• 4 edits in trunk/Source

[CG] REGRESSION (Big Sur): A GIF image with a finite loopCount loops an extra cycle
​https://bugs.webkit.org/show_bug.cgi?id=216018
<rdar://problem/66660579>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-09-01
Reviewed by Tim Horton.

Source/WebCore:

Remove the extra 'one' we used to add to the GIF loopCount since it is
now added by the underlying frameworks. But make sure we are compatible
with the older versions of macOS and iOS.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::repetitionCount const):

Source/WTF:

Add a new macro for the new accurate behavior of CGImageSource.

Unrelated change: Fix the conditions for enabling the WebP images.

• wtf/PlatformHave.h:

7:54 PM Changeset in webkit [266448] by commit-queue@webkit.org

• 26 edits in trunk

Align ISO-2022-JP and Shift_JIS encodings with Chrome, Firefox, and the specification
​https://bugs.webkit.org/show_bug.cgi?id=216052

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-csshiftjis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms932-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms_kanji-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-shift-jis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-sjis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-windows-31j-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-x-sjis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• platform/text/TextCodecCJK.cpp:

(WebCore::TextCodecCJK::TextCodecCJK):
(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucJPEncode):
(WebCore::TextCodecCJK::iso2022JPEncode):
(WebCore::shiftJISEncode):
(WebCore::big5Encode):
(WebCore::TextCodecCJK::big5Decode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode):

• platform/text/TextCodecCJK.h:
• platform/text/TextCodecICU.cpp:

7:18 PM Changeset in webkit [266447] by ysuzuki@apple.com

• 6 edits in trunk

Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=216043
<rdar://problem/66394369>

Reviewed by Mark Lam.

Source/JavaScriptCore:

• tools/JSDollarVM.cpp:

(JSC::functionIsGigacageEnabled):
(JSC::JSDollarVM::finishCreation):

LayoutTests:

The test is stressing Gigacage Exhaustion. So without Gigacage, this test is meaningless.
GuardMalloc behaves differently from usual Malloc / bmalloc: which crashes when exhausting memory.
As a result, we observe test crash when GuardMalloc is enabled. Since our test harness does not support
GuardMalloc annotation in TestExpectations, we needed a workaround to avoid this crash.

• TestExpectations:
• fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
• fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:

(vm.isGigacageEnabled.useAllMemory.try.get Object):
(vm.isGigacageEnabled.useAllMemory.try.foo):
(vm.isGigacageEnabled):
(useAllMemory.try.get Object): Deleted.
(useAllMemory.try.foo): Deleted.
(): Deleted.
(catch): Deleted.

6:56 PM Changeset in webkit [266446] by Hector Lopez

• 51 edits in trunk

Unreviewed, reverting r266408.

Revision caused constant crashes on iOS and macOS

Reverted changeset:

"Convert runtime flag to setting for lazy image loading"
​https://bugs.webkit.org/show_bug.cgi?id=215610
​https://trac.webkit.org/changeset/266408

6:55 PM Changeset in webkit [266445] by ddkilzer@apple.com

• 3 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] InternalFormat::blendSupport is uninitialized by constructor
<​https://webkit.org/b/216053>
<rdar://problem/68166032>

Reviewed by Kenneth Russell.

• changes.diff: Add this patch.
• src/libANGLE/formatutils.cpp:

(gl::InternalFormat::InternalFormat):

• Initialize blendSupport to NeverSupported.

6:51 PM Changeset in webkit [266444] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.5

Tag Safari-610.1.28.0.5.

6:46 PM Changeset in webkit [266443] by dino@apple.com

• 8 edits
  4 adds in trunk

REGRESSION(r262366): MotionMark1.1 | macOS | Some devices | 1-3% overall regression
​https://bugs.webkit.org/show_bug.cgi?id=215989
<rdar://problem/66845937>

Reviewed by Darin Adler.

Source/WebCore:

The new approach to compositing WebGL caused a slowdown in some
canvas performance tests. They were notifying the Document
of all drawing commands, even on 2d canvases that didn't need
to prepare before compositing.

The solution is to only add the Document as an observer
when necessary. This recovers the performance hit - measured
using the Canvas Lines MotionMark test.

Tests: fast/canvas/webgl/move-canvas-in-document-while-clean.html

fast/canvas/webgl/move-canvas-in-document.html

• dom/Document.cpp:

(WebCore::Document::prepareCanvasesForDisplayIfNeeded): Leave a FIXME
indicating that we should try to avoid the copyToVector if we
can ensure that the prepareForDisplay call will not mutate the HashSet.

• html/CanvasBase.cpp: Remove some copyToVector calls. It should be

fine to iterate over the HashSet for these notification functions.
(WebCore::CanvasBase::notifyObserversCanvasChanged):
(WebCore::CanvasBase::notifyObserversCanvasResized):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Don't add the Document as
a canvas observer. Wait until we know it is a context that needs observing.
(WebCore::HTMLCanvasElement::createContextWebGL): Now we can add it as an
observer.
(WebCore::HTMLCanvasElement::didMoveToNewDocument): Swap observation to the new
Document.
(WebCore::HTMLCanvasElement::insertedIntoAncestor): Ditto, but also be aware that
we might be in a "dirty" state, and thus need to immediately tell the new
document that the canvas needs preparation.
(WebCore::HTMLCanvasElement::removedFromAncestor): Remove the observer.
(WebCore::HTMLCanvasElement::needsPreparationForDisplay): Use a virtual function
on the context instead of checking the type.
(WebCore::HTMLCanvasElement::prepareForDisplay): Ditto.

• html/canvas/CanvasRenderingContext.h: New virtual functions to avoid type checking

in HTMLCanvasElement.
(WebCore::CanvasRenderingContext::compositingResultsNeedUpdating const):
(WebCore::CanvasRenderingContext::needsPreparationForDisplay const):
(WebCore::CanvasRenderingContext::prepareForDisplay):

• html/canvas/WebGLRenderingContextBase.cpp: Implementations of the virtual functions

that tell HTMLCanvasElement that it needs to prepareForDisplay.
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver):
(WebCore::WebGLRenderingContextBase::didComposite):

• html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

• fast/canvas/webgl/move-canvas-in-document-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean.html: Added.
• fast/canvas/webgl/move-canvas-in-document.html: Added.

6:31 PM Changeset in webkit [266442] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WTF

Cherry-pick r266145. rdar://problem/68179384

[Win] Assert failure under RunLoop::RunLoop
​https://bugs.webkit.org/show_bug.cgi?id=215812

Reviewed by Brent Fulgham.

The assert 'ASSERT(::IsWindow(m_runLoopMessageWindow))' under RunLoop::RunLoop will fail if the JSC API JSGlobalContextCreate*()
is being called by a client before WTF::initializeMainThread() has been called. The assertion fails because the method
RunLoop::registerRunLoopMessageWindowClass() has not been called yet, since it is only called when initializing the main thread.
This patch addresses this issue by making sure the window class has been registered before being referenced in RunLoop::RunLoopl
The method call is also removed from the main thread initialization, since the window class is only used in RunLoop::RunLoop,
making it sufficient to only be registered there. Also change the debug assert to a release assert, so we can catch similar
issues in release builds.

• wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
• wtf/win/RunLoopWin.cpp: (WTF::RunLoop::registerRunLoopMessageWindowClass): (WTF::RunLoop::RunLoop):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:30 PM Changeset in webkit [266441] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: WebSockets should be reported as type 'websocket' in Network Tab
​https://bugs.webkit.org/show_bug.cgi?id=216055
<rdar://problem/68171040>

Reviewed by Darin Adler.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.shortDisplayNameForResourceType):

6:19 PM Changeset in webkit [266440] by Alan Coon

• 5 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266280. rdar://problem/68177624

REGRESSION (r263506): scale transform transitions won't overshoot
​https://bugs.webkit.org/show_bug.cgi?id=215826
<rdar://problem/67759310>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html

In r263506 we made a change where accelerated animations would set their animation-wide
timing functions using PlatformCAAnimation::setTimingFunction() instead of setting it
on individual keyframes. This change was required to support the unique ability of
JS-originated animations to specify both an animation-wide timing function as well as
per-keyframe timing functions.

In the case of CSS Transitions, this meant that instead of setting a per-keyframe timing
function, this change would set the animation-wide timing function since CSS Transitions
should map the transition-timing-function property to the "easing" property of the Animation
object exposed by the Web Animations API, not as the timing function of the single keyframe
interval.

However, this change surfaced a bug in Core Animation on macOS and iOS where a cubic-bezier()
timing function with y values above 1 get clipped when applied to a CAKeyframeAnimation using
the timingFunction property (singular) instead of the timingFunctions property (plural).

To work around this issue, we set Animation::property() on the generated Animation object passed
to GraphicsLayerCA to make it possible to detect when we're dealing with a CSS Transition and
set the timing function on the keyframe interval rather than on the animation itself.

Alas, this does not fix the case where a JS-originated animation will specify an animation-wide
timing function with a cubic-bezier() timing function with y values above 1. There is no known
workaround at this time for this case and this is covered by bug 215918.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):
• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

LayoutTests:

Add a new test that checks that a CSS Transition using a cubic-bezier() timing function with
a y value beyond 1 does not get clipped.

• platform/win/TestExpectations:
• webanimations/accelerated-css-transition-with-easing-y-axis-above-1-expected.html: Added.
• webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266439] by Alan Coon

• 5 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266241. rdar://problem/68177624

REGRESSION (r263506): timing of CSS Animation on ​https://animate.style is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=215807
<rdar://problem/66770136>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-animation-with-easing.html

In r263506, we added a way for accelerated animations to adhere to both a timing function set on the
animation, affecting the timing of the entire animation, as well as a timing function set on individual
keyframes, affecting the timing of the animation in a given interval. Alas, this change broke handling
of timing functions with implicit animation-timing-function on keyframes.

That code change assumed that the Animation object ultimately passed to GraphicsLayerCA::setupAnimation()
would return the animation-wide timing function through Animation::timingFunction(). This was correct for
JS-originated animations, but not for CSS Animations, since that value was set based on the computed CSS
property animation-timing-function for the target element. However, that CSS property does not specify
the animation-wide timing function, but rather the default timing function to use for keyframes should
they fail to specify an explicit timing function.

To fix this, first, we ensure that the animation-wide timing function is set on the Animation object,
changing KeyframeEffect::backingAnimationForCompositedRenderer() to always generate an Animation object
based on the effect, divorcing itself from the Animation object created through CSS.

Then, we add a new member to Animation to specify the default timing function for keyframes, allowing
GraphicsLayerCA to use it to determine the timing function when building keyframes.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const): Always generate an Animation object based on the effect's properties, also setting the new defaultTimingFunctionForKeyframes in the case of a CSS Animation object.
• platform/animation/Animation.h: (WebCore::Animation::defaultTimingFunctionForKeyframes const): (WebCore::Animation::setDefaultTimingFunctionForKeyframes):
• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationHasStepsTimingFunction): Use the optional defaultTimingFunctionForKeyframes to determine whether a keyframe uses a steps timing function. (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue): Use the optional defaultTimingFunctionForKeyframes to determine the timing function for a keyframe.

LayoutTests:

Add a new test that checks that a CSS Animation with implicit and explicit animation-timing-function
values behave the same when running accelerated.

• webanimations/accelerated-css-animation-with-easing-expected.html: Added.
• webanimations/accelerated-css-animation-with-easing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266438] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266301. rdar://problem/68177648

[macOS] Fix iokit-get-properties sandbox violations
​https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Brent Fulgham.

Add iokit-property to WebContent sandbox that should have been a part of r266282.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266437] by Alan Coon

• 6 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266291. rdar://problem/68177666

No need to run full can-use-for (fast inline layout codepath) check on every style change.
​https://bugs.webkit.org/show_bug.cgi?id=215937
<rdar://problem/67951360>

Reviewed by Antti Koivisto.

Let's use the StyleDifference to figure out how extensive the can-use-for check should be.
We can certainly skip some relatively expensive content checks when we know that the style change only triggers repaint or positioned-movement-only changes.

• layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::canUseForAfterStyleChange):
• layout/integration/LayoutIntegrationLineLayout.h:
• rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::styleDidChange):
• rendering/SimpleLineLayout.cpp: (WebCore::SimpleLineLayout::canUseForAfterStyleChange):
• rendering/SimpleLineLayout.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266436] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266282. rdar://problem/68177648

[macOS] Fix iokit-get-properties sandbox violations
​https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Darin Adler.

A few iokit properties needs to be added to the WebContent process' sandbox after observing these being in use.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266435] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266281. rdar://problem/68177575

Remove adopted node from TextManipulationController
​https://bugs.webkit.org/show_bug.cgi?id=215914

Reviewed by Wenson Hsieh.

Remove Node from TextManipulationController when it gets adopted to a new document.

• dom/Node.cpp: (WebCore::Node::moveNodeToNewDocument):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266434] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266099. rdar://problem/68176073

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called, instead of when deciding to dispatch to the main thread. (WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread. (WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when (WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is safe to do after destroy(), up until the very end when we get into pluginView() derefencing. So it seems prudent to add another check here. (WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument, so for added coverage it seems like a prudent place to add the check.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266433] by Alan Coon

• 19 edits in branches/safari-610-branch/Source

Cherry-pick r266214. rdar://problem/68164557

Resource Load Statistics data summary does not report data which is held up in the web content process.
​https://bugs.webkit.org/show_bug.cgi?id=215822
<rdar://problem/66682044>

Reviewed by Chris Dumez.

Source/WebCore:

Send empty lambda when calling updateCentralStatisticsStore() because
in these cases we don't care about timing.

• loader/ResourceLoadObserver.h: (WebCore::ResourceLoadObserver::updateCentralStatisticsStore):
• page/DOMWindow.cpp: (WebCore::DOMWindow::close):
• testing/Internals.cpp: (WebCore::Internals::notifyResourceLoadObserver):

Source/WebKit:

No new tests, this fixes a timing bug that is flaky to reproduce, so I
was unable to write a test case. Non-regressed behavior is confirmed
with existing API testing.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated): Most of the time, the completion handler will be an empty function, but we should handle it in the network process so we fix the case where we wait to send the full data summary until the update has finished.

(WebKit::WebResourceLoadStatisticsStore::aggregatedThirdPartyData):
Delete extra space.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated):
• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::sendResourceLoadStatisticsDataImmediately):
• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary): Don't ask the network process for data until any lingering data in the web content process has been sent first.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleResourceLoadStatisticsNotifyObserver):
• WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp: (WebKit::WebResourceLoadObserver::WebResourceLoadObserver): (WebKit::WebResourceLoadObserver::~WebResourceLoadObserver): (WebKit::WebResourceLoadObserver::updateCentralStatisticsStore):
• WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::flushResourceLoadStatistics): (WebKit::WebProcess::sendResourceLoadStatisticsDataImmediately):
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266432] by Alan Coon

• 8 edits
  1 add in branches/safari-610-branch

Cherry-pick r266178. rdar://problem/68164567

[JSC] Add ASCII comparison fast path for IntlCollator
​https://bugs.webkit.org/show_bug.cgi?id=215798

Reviewed by Darin Adler, Ross Kirsling, and Saam Barati.

JSTests:

• stress/string-locale-compare-uca-ducet.js: Added. (shouldBe):
• stress/string-localeCompare.js: (data.sort):

Source/JavaScriptCore:

The idea behind this change is the following: ICU Collator's comparison is too slow. We should have fast path for ASCII strings when we know this equals to ICU Collator's result.
The problem is that even for ASCII strings, collation is super complicated!

1. Unicode defines Unicode Collation Algorithm (UCA). To perform collation, it uses collation element tables which defines weights on various levels per code point. UCA also offers the Default Unicode Collation Element Table (DUCET). This UCA with DUCET is used when using ICU Root Collator.
2. UCA collation consists of rules, which defines how collation works. And ICU locales define customized collations by adding special rules to that.
3. UCA behaves differently by using different options.

Based on that, our observation is that some of major locales are not defining additional rules in (2). This means that they behaves the same to UCA with DUCET.
This patch implements a simplified version of comparison which generates the same results for ASCII strings (excluding control characters) to UCA with DUCET. This fast path can be usable only when the following conditions are met.

1. The collator does not have additional rules to ICU Root Colator.
2. The collator is using default options.

These checks are very important since there are a lot of edge-case locales. For example,

1. th (Thai language) ignores punctuations (even including ASCII punctuations) by default. This is defined as ignore-punctuations option is enabled by default, so without (2)'s check, th comparison becomes wrong.
2. There are contraction concept (multiple letters behave as a single letter). "ch" letters are ordered interestingly in Czech language. So even in ASCII, Czech shows very interesting collation behavior.

So we cannot safely take this fast path without carefully querying the information to ICU.

This shows 37% improvement in JetStream2/cdjs in en-US environment.

• runtime/IntlCollator.cpp: (JSC::IntlCollator::initializeCollator): (JSC::IntlCollator::compareStrings const): (JSC::canDoASCIIUCADUCETComparisonWithUCollator): (JSC::IntlCollator::updateCanDoASCIIUCADUCETComparison const): (JSC::IntlCollator::checkICULocaleInvariants):
• runtime/IntlCollator.h:
• runtime/IntlObject.cpp: (JSC::intlCollatorAvailableLocales):
• runtime/IntlObject.h:
• runtime/IntlObjectInlines.h: (JSC::canUseASCIIUCADUCETComparison): (JSC::compareASCIIWithUCADUCET):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266431] by Alan Coon

• 4 edits in branches/safari-610-branch/Source

Cherry-pick r266143. rdar://problem/68164547

Trying to lookup when WebView is in a popover causes process to hang. Fix for Legacy WebView.
​https://bugs.webkit.org/show_bug.cgi?id=215792

Reviewed by Tim Horton.

Source/WebKit:

Update code based on Darin's suggestion for mirror fix in legacy webkit.

• UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

Source/WebKitLegacy/mac:

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=214773 also needed in legacy WebView.
The Lookup framework does not populate the menus that it vends with the option to 'lookup'
words that are selected in popovers. WebKit should follow the pattern and not put the
item in the menu as Lookup is not able to handle this situation. Also if Lookup is disabled
via defaults, we should not show it in the menu.

• WebView/WebHTMLView.mm: (customMenuFromDefaultItems):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266430] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266140. rdar://problem/68164582

Fix read-after-free introduced in r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::packageFormData): Keep the CString in scope while we are using it.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266429] by Alan Coon

• 4 edits
  1 add in branches/safari-610-branch

Cherry-pick r266134. rdar://problem/68164543

[Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=215660
<rdar://problem/65263150>

Reviewed by Darin Adler.

Source/WebKit:

API Test: Fullscreen.Focus.

The default behavior of NSWindow is to change its -keyViewSelectionDirection to NSSelectingNext when activating
and changing the firstResponder. This causes WKWebView to change it's focus in response to becoming first responder.
The cheap fix is to ensure WKWebView is already the firstResponder when the window is activated. Then NSWindow won't
try to change the firstResponder in response to activation.

• UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/FullscreenFocus.mm: Added. (-[FullscreenFocusUIDelegate _webViewDidEnterFullscreen:]): (-[FullscreenFocusUIDelegate _webViewDidExitFullscreen:]): (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266428] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/ThirdParty/libwebrtc

Cherry-pick r266064. rdar://problem/68164535

Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder
​https://bugs.webkit.org/show_bug.cgi?id=215765
<rdar://problem/67677285>

Reviewed by Eric Carlson.

Following ​https://webrtc-review.googlesource.com/c/src/+/177335 upstream, let's enable VP9D_SET_LOOP_FILTER_OPT for improved performances.

• Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266427] by Alan Coon

• 15 edits in branches/safari-610-branch/Source

Cherry-pick r266268. rdar://problem/68107183

Remove the feature flag for capped cookies set in 3rd-party CNAME cloaked HTTP responses and add ITP debug logging
​https://bugs.webkit.org/show_bug.cgi?id=215902
<rdar://problem/66699731>

Reviewed by Brent Fulgham.

This change removes the feature flag, effectively turning the feature on.
It also adds log output of cookie names that have been capped when ITP
Debug Mode is enabled.

Source/WebCore:

WebCore::NetworkStorageSession now has a member flag for ITP debug logging.

No new tests. This feature already has tests.

• page/Settings.yaml:
• platform/network/NetworkStorageSession.cpp: (WebCore::NetworkStorageSession::setResourceLoadStatisticsDebugLoggingEnabled): (WebCore::NetworkStorageSession::resourceLoadStatisticsDebugLoggingEnabled const):

New function to be able to conditionalize log output in the new feature.

• platform/network/NetworkStorageSession.h:

Source/WebKit:

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode):

Now sets the flag in WebCore::NetworkStorageSession through the new function
WebCore::NetworkStorageSession::setResourceLoadStatisticsDebugLoggingEnabled().

• NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::resetParametersToDefaultValues): (WebKit::NetworkProcess::setIsRunningResourceLoadStatisticsTest):
• NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::NetworkSession): (WebKit::NetworkSession::setFirstPartyHostCNAMEDomain): (WebKit::NetworkSession::firstPartyHostCNAMEDomain):
• NetworkProcess/NetworkSession.h: (WebKit::NetworkSession::setCNAMECloakingMitigationEnabled): Deleted. (WebKit::NetworkSession::cnameCloakingMitigationEnabled const): Deleted.
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::updateFirstPartyInfoForSession): (WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):
• Shared/ResourceLoadStatisticsParameters.h: (WebKit::ResourceLoadStatisticsParameters::encode const): (WebKit::ResourceLoadStatisticsParameters::decode):
• Shared/WebPreferences.yaml:
• UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess):
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::platformSetNetworkParameters):
• UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::parameters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266426] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266238. rdar://problem/68161715

Unreviewed, add missing double quote in r266216.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266425] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266229. rdar://problem/68161195

Animation are invalidating too much
​https://bugs.webkit.org/show_bug.cgi?id=215849

Reviewed by Antoine Quint.

• animation/KeyframeEffect.cpp: (WebCore::invalidateElement):

Changes due to animations can't affect sibling elements so we can use internal invalidation.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266424] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266216. rdar://problem/68161715

[macOS] Stop logging sandbox violations of com.apple.CoreDisplay.Notification
​https://bugs.webkit.org/show_bug.cgi?id=215869

Reviewed by Darin Adler.

On macOS, stop logging mach-lookup sandbox violations of com.apple.CoreDisplay.Notification for performance reasons.

No new tests, since there is no change in behavior. The service was already being denied in the sandbox.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266423] by Alan Coon

• 2 edits in branches/safari-610-branch/Tools

Cherry-pick r266102. rdar://problem/68160088

Fix TLSVersion.DefaultBehavior on Mojave
​https://bugs.webkit.org/show_bug.cgi?id=215791

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave. Enable it for newer OSes.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266422] by Alan Coon

• 4 edits in branches/safari-610-branch/Tools

Cherry-pick r266100. rdar://problem/68160088

Make TLSVersion.DefaultBehavior more robust
​https://bugs.webkit.org/show_bug.cgi?id=215791

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

After r265573 sometimes it would assert, which is not a problem because it was failing the first connection
then succeeding the second connection as intended and as happens in the real internet.
Use HTTPServer which accepts a variable number of connections to keep the test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):
• TestWebKitAPI/cocoa/HTTPServer.h:
• TestWebKitAPI/cocoa/HTTPServer.mm: (TestWebKitAPI::HTTPServer::respondWithChallengeThenOK): (TestWebKitAPI::HTTPServer::respondWithOK):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266421] by Alan Coon

• 5 edits
  6 adds in branches/safari-610-branch

Cherry-pick r266118. rdar://problem/68160083

Fonts lie about being monospaced
​https://bugs.webkit.org/show_bug.cgi?id=162546
<rdar://problem/28494654>

Reviewed by Darin Adler.

Source/WebCore:

When a font reports itself to be monospace, we use this as a
signal that we can perform width computations by assuming all
characters have the same width as the space character. However,
some fonts erroneously claim to be monospaced. We can't know
this ahead of time without measuring a bunch of characters at
font load time, which would be too slow, so even though the
optimization would be nice there is no practical way to do it
correctly. Firefox and Chrome both do not use this signal, so
therefore they both correctly render these fonts. We should
ignore this bit in the font as well. Also, CJK fonts generally
do not have this bit set (because they usually have at least
one character which is not fullwidth) so this isn't a concern
there.

Our Page Load Test shows this is not a performance regression.

Tests: fast/text/font-erroneous-monospace.html

fast/text/font-monospaced-lie.html

• rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache const):

LayoutTests:

Add two tests for fonts which claim to be monospaced but actually aren't.

• fast/text/font-erroneous-monospace-expected.html: Added.
• fast/text/font-erroneous-monospace.html: Added.
• fast/text/font-monospaced-lie-expected.txt: Added.
• fast/text/font-monospaced-lie.html: Added.
• fast/text/line-break-after-question-mark-expected.txt:
• fast/text/line-break-after-question-mark.html:
• fast/text/resources/Ahem-fixed-pitch.ttf: Added.
• fast/text/resources/AhemErroneousMonospace.ttf: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266420] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.4

5:54 PM Changeset in webkit [266419] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 ] fast/scrolling/latching/latched-scroll-remove-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216059

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:56 PM Changeset in webkit [266418] by Kate Cheney

• 2 edits in trunk/Source/WebKit

Pass the correct data size for the SharedMemory::Handle in WebCompiledContentRuleListData::encode
​https://bugs.webkit.org/show_bug.cgi?id=216049
<rdar://problem/60758278>

Reviewed by Alex Christensen.

No new tests, validated by existing API tests.

• Shared/WebCompiledContentRuleListData.cpp:

(WebKit::WebCompiledContentRuleListData::encode const):

4:11 PM Changeset in webkit [266417] by Chris Dumez

• 46 edits in trunk

Make sure BiquadFilterNode tail is getting processed
​https://bugs.webkit.org/show_bug.cgi?id=216050

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt:

Source/WebCore:

Some nodes have have a significant tail-time and shouldn't be disconnected simply because
they no longer have any input connections. We used to deal with this by hard-coding
node types in AudioNode::disableOutputsIfNecessary() which was not ideal. We now use
a AudioNode::requiresTailProcessing() virtual function instead, similarly to what Blink
is doing.

This patch fixes tail processing for BiquadFilterNode.

No new tests, rebaselined existing test.

• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::requiresTailProcessing const):

• Modules/webaudio/AnalyserNode.h:
• Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::requiresTailProcessing const):

• Modules/webaudio/AudioBasicProcessorNode.h:
• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):

• Modules/webaudio/AudioNode.h:
• Modules/webaudio/AudioScheduledSourceNode.h:
• Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::requiresTailProcessing const):

• Modules/webaudio/BiquadDSPKernel.h:
• Modules/webaudio/ChannelMergerNode.h:
• Modules/webaudio/ChannelSplitterNode.h:
• Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::requiresTailProcessing const):

• Modules/webaudio/ConvolverNode.h:
• Modules/webaudio/DefaultAudioDestinationNode.h:
• Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::requiresTailProcessing const):

• Modules/webaudio/DelayDSPKernel.h:
• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::requiresTailProcessing const):

• Modules/webaudio/DynamicsCompressorNode.h:
• Modules/webaudio/GainNode.h:
• Modules/webaudio/IIRDSPKernel.cpp:

(WebCore::IIRDSPKernel::requiresTailProcessing const):

• Modules/webaudio/IIRDSPKernel.h:
• Modules/webaudio/MediaElementAudioSourceNode.h:
• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/MediaStreamAudioSourceNode.h:
• Modules/webaudio/OfflineAudioDestinationNode.h:
• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::requiresTailProcessing const):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::requiresTailProcessing const):

• Modules/webaudio/ScriptProcessorNode.h:
• Modules/webaudio/StereoPannerNode.h:
• Modules/webaudio/WaveShaperDSPKernel.cpp:

(WebCore::WaveShaperDSPKernel::requiresTailProcessing const):

• Modules/webaudio/WaveShaperDSPKernel.h:
• Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::requiresTailProcessing const):

• Modules/webaudio/WebKitAudioPannerNode.h:
• platform/audio/AudioDSPKernel.h:
• platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::requiresTailProcessing const):

• platform/audio/AudioDSPKernelProcessor.h:
• platform/audio/AudioProcessor.h:
• platform/audio/DynamicsCompressor.h:
• platform/audio/EqualPowerPanner.h:
• platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::requiresTailProcessing const):

• platform/audio/HRTFPanner.h:
• platform/audio/Panner.h:

3:56 PM Changeset in webkit [266416] by Kate Cheney

• 2 edits in trunk/Source/WebKit

WebPasteboardProxy::getPasteboardStringsForType() and WebPasteboardProxy::readURLFromPasteboard() should check return value of SharedMemory::createHandle()
​https://bugs.webkit.org/show_bug.cgi?id=211002
<rdar://problem/60103950>

Reviewed by Wenson Hsieh.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
Check result of SharedMemory::createHandle() and return early
on failure.

3:54 PM Changeset in webkit [266415] by Alan Coon

• 5 edits in branches/safari-610.1.28.0-branch/Source/WebKit

Cherry-pick r266411. rdar://problem/68111667

[iOS] AGX compiler service sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=216042
<rdar://problem/68111667>

Reviewed by Brent Fulgham.

For a set of devices, mach-lookup sandbox violations have been observed for an AGX compiler service. For these devices,
we currently issue an extension for one AGX compiler service, but this is not sufficient since there is a similar
service name that needs to be added as well.

• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::agxCompilerServices): (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:53 PM Changeset in webkit [266414] by Alan Coon

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.5

3:41 PM Changeset in webkit [266413] by Alan Coon

• 1 copy in tags/Safari-610.2.3

Tag Safari-610.2.3.

2:49 PM Changeset in webkit [266412] by Hector Lopez

• 6 edits in trunk/Source/WebKit

Unreviewed, reverting r266384.

Revision is causing 5 API faliures/timeouts and build failures
on macOS

Reverted changeset:

"Webpages flash when switching between windows"
​https://bugs.webkit.org/show_bug.cgi?id=216012
​https://trac.webkit.org/changeset/266384

2:25 PM Changeset in webkit [266411] by pvollan@apple.com

• 5 edits in trunk/Source/WebKit

[iOS] AGX compiler service sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=216042
<rdar://problem/68111667>

Reviewed by Brent Fulgham.

For a set of devices, mach-lookup sandbox violations have been observed for an AGX compiler service. For these devices,
we currently issue an extension for one AGX compiler service, but this is not sufficient since there is a similar
service name that needs to be added as well.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::agxCompilerServices):
(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

1:45 PM Changeset in webkit [266410] by Chris Dumez

• 2 edits in trunk/Source/WebCore

<video> element prevents screen from sleeping even after playback finishes
​https://bugs.webkit.org/show_bug.cgi?id=216017
<rdar://problem/66665846>

Reviewed by Darin Adler.

When video playback would finish (due to reaching end of file), HTMLMediaElement::mediaPlayerRateChanged()
would get called, which would call updateSleepDisabling(). The idea was that updateSleepDisabling() would
destroy the SleepDisabler to allow the display to sleep again. However, updateSleepDisabling() would not
destroy the SleepDisabler because it does not know yet that the media has been paused. We only learned
about it later on, when MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange() gets called.
To address the problem, we now call updateSleepDisabling() when
MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange() is called too.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange):

12:52 PM Changeset in webkit [266409] by Chris Dumez

• 8 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky Web Audio WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

12:24 PM Changeset in webkit [266408] by commit-queue@webkit.org

• 51 edits in trunk

Convert runtime flag to setting for lazy image loading
​https://bugs.webkit.org/show_bug.cgi?id=215610

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-01
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Remove changes done to the lazy image loading tests as we enable the setting in testharnessreport.js.
The new expected results are improvements.

• web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:

Source/WebCore:

Convert runtime flag to setting for lazy image loading. Settings are
preferred over RuntimeEnabledFeatures as they are not global singletons
and are automatically accessible in layout tests via InternalSettingsGenerated.

• loader/ImageLoader.cpp:

Source/WebKit:

Remove lazy image loading runtime flag.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Remove lazy image loading runtime flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Enable lazy image loading setting in resources/testharnessreport.js. Update test expectations
and adjust the tests in http/tests/lazyload/ to enable the setting. Fow WK1 list more tests
that should be skipped.

• TestExpectations:
• http/tests/lazyload/attribute.html:
• http/tests/lazyload/js-image.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
• http/tests/lazyload/lazy.html:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk1/TestExpectations:
• platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• resources/testharnessreport.js:

11:51 AM Changeset in webkit [266407] by timothy_horton@apple.com

• 6 edits in trunk/Source

Some apps linked beyond iOS 13.4 don't respect mouse events, only touch events
​https://bugs.webkit.org/show_bug.cgi?id=216021
<rdar://problem/64830335>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isFIFACompanion):
(WebCore::IOSApplication::isNoggin):
(WebCore::IOSApplication::isOKCupid):
Add some more bundle checks.

Source/WebKit:

• UIProcess/Cocoa/VersionChecks.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(applicationIsKnownToIgnoreMouseEvents):
(-[WKContentView shouldUseMouseGestureRecognizer]):
Remove Feedly from the list, they are no longer affected.
Add a once-per-app-launch error-level log message to warn developers
of the impending behavior change.
Add three new apps with a later linked-on target.

11:51 AM Changeset in webkit [266406] by mark.lam@apple.com

• 6 edits in trunk/Source

Remove some PtrTag debugging code from release builds.
​https://bugs.webkit.org/show_bug.cgi?id=216025
<rdar://problem/68098263>

Reviewed by Saam Barati.

Source/JavaScriptCore:

Removed PtrTag name lookup debugging utility from release builds.

• runtime/JSCPtrTag.cpp:
• runtime/JSCPtrTag.h:

Source/WTF:

Converted uses of PtrTagAction::ReleaseAssert to PtrTagAction::DebugAssert.
These assertions serve a purpose during development (hence, PtrTagAction::DebugAssert),
but is no longer needed for release builds. Previously, we use these assertions
to verify that pointers are tagged correctly in release build. Clang takes care
of that automatically now.

Also removed PtrTag name lookup debugging utility from release builds.

• wtf/PtrTag.cpp:
• wtf/PtrTag.h:

(WTF::untagCodePtr):
(WTF::retagCodePtrImpl):
(WTF::assertIsCFunctionPtr):
(WTF::assertIsNotTagged):
(WTF::assertIsTagged):
(WTF::assertIsTaggedWith):

11:19 AM Changeset in webkit [266405] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Crashtracer in SubresourceLoader::didCancel.
<rdar://problem/32831629> and ​https://bugs.webkit.org/show_bug.cgi?id=216020

Reviewed by Alex Christensen.

No new tests (Despite spotting theoretical ways this is possible, unable to construct a reproduction)

It's possible for a newly created SubresourceLoader to be cancelled right after creation.
In this case, m_resource will be null inside of SubresourceLoader::didCancel.

Other parts of SubresourceLoader null check m_resource, so it's reasonable to state ::didCancel should as well.

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didCancel): Early return if reachedTerminalState(), and ASSERT(m_resource) after.

11:13 AM Changeset in webkit [266404] by Megan Gardner

• 4 edits in trunk/Source

Switch to class method for smart insert/delete
​https://bugs.webkit.org/show_bug.cgi?id=215871
<rdar://problem/67281776>

Reviewed by Darin Adler.

No process changes. Covered by existing tests.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/TextCheckerIOS.mm:

(WebKit::TextChecker::isSmartInsertDeleteEnabled):

10:48 AM Changeset in webkit [266403] by Antti Koivisto

• 8 edits
  2 adds in trunk

EventRegion paint should respect layer's foreground and background painting phases
​https://bugs.webkit.org/show_bug.cgi?id=216031
<rdar://problem/67282372>

Reviewed by Simon Fraser.

Source/WebCore:

We are currently painting event region for the box background to the foreground layer, which can cause
foreground layer to wrongly catch scroll events. Similarly we are unnecessarily painting foreground for
layers that don't need it.

Test: fast/scrolling/mac/negative-z-index-overflow-scroll.html

• rendering/PaintPhase.h:

Add two new event region specific PaintBehaviors for foreground and background paint. This essentially duplicates
foreground/background PaintPhases but since event region paint is itself a paint phase we can't use those.
This should be reconciled at some point.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents):

Add the background flag when painting contents as the descendant backgrounds are part of the layer foreground.

(WebCore::RenderBlock::paintObject):

Respect the new flags.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

Setup the flags based on what we are supposed to be painting on this layer.

(WebCore::RenderLayer::collectEventRegionForFragments):

Flag filtering moves to paintLayerContents.

LayoutTests:

• editing/editable-region/text-field-inside-composited-negative-z-index-layer-expected.txt:
• fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt: Added.
• fast/scrolling/mac/negative-z-index-overflow-scroll.html: Added.
• pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer-expected.txt:
• pointerevents/ios/touch-action-region-backing-sharing-expected.txt:

10:15 AM Changeset in webkit [266402] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.6

Tag Safari-610.1.28.1.6.

10:12 AM Changeset in webkit [266401] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266189. rdar://problem/68145716

Flickering on sedona.dev
​https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

• html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

• fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
• fast/canvas/webgl/compositing-without-drawing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:09 AM Changeset in webkit [266400] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit

Upstream PencilKit text input support
​https://bugs.webkit.org/show_bug.cgi?id=216030

Reviewed by Anders Carlsson.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _shouldSimulateKeyboardInputOnTextInsertion]):
(-[WKContentView setUpScribbleInteraction]):
(-[WKContentView cleanUpScribbleInteraction]):
(-[WKContentView _textInputContextByScribbleIdentifier:]):
(-[WKContentView _elementForTextInputContextIsFocused:]):
(-[WKContentView indirectScribbleInteraction:requestElementsInRect:completion:]):
(-[WKContentView indirectScribbleInteraction:isElementFocused:]):
(-[WKContentView indirectScribbleInteraction:focusElementIfNeeded:referencePoint:completion:]):
(-[WKContentView indirectScribbleInteraction:frameForElement:]):
(-[WKContentView indirectScribbleInteraction:willBeginWritingInElement:]):
(-[WKContentView indirectScribbleInteraction:didFinishWritingInElement:]):

9:42 AM Changeset in webkit [266399] by commit-queue@webkit.org

• 44 edits in trunk

Update URL fragment percent encode set
​https://bugs.webkit.org/show_bug.cgi?id=216022

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-origin-expected.txt:
• web-platform-tests/url/a-element-origin-xhtml-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/failure-expected.txt:
• web-platform-tests/url/resources/setters_tests.json:
• web-platform-tests/url/resources/urltestdata.json:

Also add some new tests from upstream. Some of them are failing now. That's fine for now.

• web-platform-tests/url/url-constructor-expected.txt:
• web-platform-tests/url/url-origin-expected.txt:
• web-platform-tests/url/url-setters-expected.txt:

Source/WTF:

It now matches the behavior of Chrome and Firefox, as well as the spec at
​https://url.spec.whatwg.org/#fragment-percent-encode-set

• wtf/URLParser.cpp:

(WTF::isInFragmentEncodeSet):
(WTF::URLParser::parse):

Tools:

• TestWebKitAPI/Tests/WTF/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

• fast/dom/DOMURL/set-href-attribute-hash-expected.txt:
• fast/dom/DOMURL/set-href-attribute-hash.html:
• fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
• fast/dom/HTMLAnchorElement/set-href-attribute-hash.html:
• fast/url/anchor-expected.txt:
• fast/url/anchor.html:
• fast/url/segments-expected.txt:
• fast/url/segments-from-data-url-expected.txt:
• fast/url/segments-from-data-url.html:
• fast/url/segments-from-data-url2-expected.txt:
• fast/url/segments-from-data-url2.html:
• fast/url/segments.html:
• fast/url/standard-url-expected.txt:
• fast/url/standard-url.html:
• fast/url/url-tojson-expected.txt:
• fast/url/url-tojson.html:
• fetch/fetch-url-serialization-expected.txt:
• fetch/fetch-urls.json:
• http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
• http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
• svg/dom/viewspec-parser-1-expected.txt:
• svg/dom/viewspec-parser-3-expected.txt:
• svg/dom/viewspec-parser-4-expected.txt:
• svg/dom/viewspec-parser-5-expected.txt:
• svg/dom/viewspec-parser-6-expected.txt:
• svg/dom/viewspec-parser-7-expected.txt:

9:39 AM Changeset in webkit [266398] by Chris Dumez

• 13 edits in trunk

Add proper k-rate automation support for BiquadFilterNode
​https://bugs.webkit.org/show_bug.cgi?id=216027

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:

Source/WebCore:

Add proper k-rate automation support for BiquadFilterNode. This patch is
based on Chromium's implementation.

No new tests, rebaselined existing tests.

• Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::hasConstantValues):
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
(WebCore::BiquadDSPKernel::updateCoefficients):
(WebCore::BiquadDSPKernel::process):
(WebCore::BiquadDSPKernel::getFrequencyResponse):
(WebCore::BiquadDSPKernel::tailTime const):
(WebCore::BiquadDSPKernel::updateTailTime):

• Modules/webaudio/BiquadDSPKernel.h:
• Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::checkForDirtyCoefficients):
(WebCore::BiquadProcessor::getFrequencyResponse):

• Modules/webaudio/BiquadProcessor.h:
• platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):
(WebCore::Biquad::process):
(WebCore::Biquad::processFast):
(WebCore::Biquad::reset):
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setNormalizedCoefficients):
(WebCore::Biquad::setLowShelfParams):
(WebCore::Biquad::setHighShelfParams):
(WebCore::Biquad::setPeakingParams):
(WebCore::Biquad::setAllpassParams):
(WebCore::Biquad::setNotchParams):
(WebCore::Biquad::setBandpassParams):
(WebCore::Biquad::getFrequencyResponse):
(WebCore::repeatedRootResponse):
(WebCore::rootFinder):
(WebCore::Biquad::tailFrame):

• platform/audio/Biquad.h:

9:02 AM Changeset in webkit [266397] by commit-queue@webkit.org

• 21 edits
  1 copy
  1 add in trunk

Align Big5 decoding with spec, Chrome, and Firefox
​https://bugs.webkit.org/show_bug.cgi?id=216016

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-big5-hkscs-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-cn-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-csbig5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-errors-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-extra-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-x-x-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-big5-hkscs-expected.txt:

Source/WebCore:

I also introduce a new class TextCodecCJK instead of duct taping this into TextCodecICU.
Covered by web platform tests.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/text/EncodingTables.cpp:
• platform/text/EncodingTables.h:
• platform/text/TextCodecCJK.cpp: Added.

(WebCore::TextCodecCJK::TextCodecCJK):
(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucJPEncode):
(WebCore::big5Encode):
(WebCore::appendDecimal):
(WebCore::urlEncodedEntityUnencodableHandler):
(WebCore::entityUnencodableHandler):
(WebCore::questionMarkUnencodableHandler):
(WebCore::Function<void):
(WebCore::big5DecodeIndex):
(WebCore::TextCodecCJK::big5Decode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode):

• platform/text/TextCodecCJK.h: Added.
• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::encode):
(WebCore::eucJPEncode): Deleted.
(WebCore::big5Encode): Deleted.
(WebCore::uncheckedAppendDecimal): Deleted.
(WebCore::urlEncodedEntityUnencodableHandler): Deleted.
(WebCore::entityUnencodableHandler): Deleted.
(WebCore::questionMarkUnencodableHandler): Deleted.
(WebCore::Function<void): Deleted.

• platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

Source/WTF:

• wtf/text/CodePointIterator.h:

8:44 AM Changeset in webkit [266396] by Aditya Keerthi

• 31 edits
  1 copy
  7 adds in trunk

[macOS] Handle events for date inputs with editable components
​https://bugs.webkit.org/show_bug.cgi?id=215938

Reviewed by Darin Adler.

Source/WebCore:

This patch adds actual editability to date inputs with editable
components, as the individual components now respond to keyboard
events. Number keys can be used to enter a day, month, or year. The
left and right arrow keys, as well as the tab key, can be used to
traverse the various components. Finally, the backspace and delete keys
can be used to clear the value of a particular component.

To match the behavior of NSDatePicker, a typeahead buffer with a
timeout is used when editing. For example, entering "2" and "3" in
immediate succession will result in a year of "0023", but a one second
gap between the two characters will result in a year of "0003".

Finally, this patch ensures that "focus", "blur", "input", and "change"
events are dispatched appropriately.

Tests: fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html

fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html
fast/forms/date/date-editable-components/date-editable-components-mouse-events.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleFocusEvent):

Override this method so that any attempt to focus the date input
element will focus the appropriate editable component.

(WebCore::BaseChooserOnlyDateAndTimeInputType::hasCustomFocusLogic const):

Override this method and return false if editable components are
present so that the element can be a FocusScopeOwner. This is needed to
be able to tab through individual components.

(WebCore::BaseChooserOnlyDateAndTimeInputType::didBlurFromControl):
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChangeValueFromControl):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::isKeyboardFocusable const): Date inputs should be keyboard focusable on all platforms.

• html/BaseDateAndTimeInputType.h:
• html/DateInputType.cpp:

(WebCore::DateInputType::formatDateTimeFieldsState const): Serialize the state of the edit control into a valid HTML date string.

• html/DateInputType.h:
• html/DateTimeFieldsState.h: Added.

DateTimeFieldsState is used to serialize and deserialize the contents of
DateTimeEditElement. In the future, this class will also be used to
save form state on forward/backward navigation.

• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState const):

• html/DateTimeLocalInputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::formatDateTimeFieldsState const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::formatDateTimeFieldsState const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::formatDateTimeFieldsState const):

• html/WeekInputType.h:
• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::fieldIndexOf const):
(WebCore::DateTimeEditElement::blurFromField):

If a field is blurred, ensure the owner is notified if none of the
other fields are focused.

(WebCore::DateTimeEditElement::fieldValueChanged):
(WebCore::DateTimeEditElement::focusOnNextFocusableField):
(WebCore::DateTimeEditElement::focusByOwner):
(WebCore::DateTimeEditElement::focusOnNextField):
(WebCore::DateTimeEditElement::focusOnPreviousField):
(WebCore::DateTimeEditElement::value const):
(WebCore::DateTimeEditElement::valueAsDateTimeFieldsState const):

• html/shadow/DateTimeEditElement.h:
• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
(WebCore::DateTimeFieldElement::dispatchBlurEvent):
(WebCore::DateTimeFieldElement::didBlur):
(WebCore::DateTimeFieldElement::updateVisibleValue): Add EventBehavior parameter to dispatch "input" and "change" events accordingly.

• html/shadow/DateTimeFieldElement.h:
• html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeSymbolicMonthFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
(WebCore::DateTimeYearFieldElement::populateDateTimeFieldsState):

• html/shadow/DateTimeFieldElements.h:
• html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::Range::clampValue const):
(WebCore::DateTimeNumericFieldElement::Range::isInRange const):
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue const):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::didBlur):

• html/shadow/DateTimeNumericFieldElement.h:

(WebCore::DateTimeNumericFieldElement::Range::Range):

• html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::setValueAsInteger):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent):

• html/shadow/DateTimeSymbolicFieldElement.h:
• platform/DateComponents.cpp:

(WebCore::DateComponents::parseYear):
(WebCore::withinHTMLDateLimits):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):

• platform/DateComponents.h: Partial revert of changes made in r265126, to ensure the minimumYear and maximumYear are accessible.

(WebCore::DateComponents::minimumYear):
(WebCore::DateComponents::maximumYear):

LayoutTests:

Added tests to verify correctness for keyboard and mouse inputs in date
inputs with editable components. These tests also ensure that the
appropriate events are dispatched: "click", "blur", "focus", "input"
and "change".

• TestExpectations:
• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events-expected.txt: Added.
• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html: Added.
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt: Added.
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html: Added.
• fast/forms/date/date-editable-components/date-editable-components-mouse-events-expected.txt: Added.
• fast/forms/date/date-editable-components/date-editable-components-mouse-events.html: Added.
• platform/mac-wk2/TestExpectations:

8:42 AM Changeset in webkit [266395] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Fix crash during WebPage constructor
​https://bugs.webkit.org/show_bug.cgi?id=216028
<rdar://problem/67781279>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Timothy Hatcher.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureNetworkProcessConnection):

7:06 AM Changeset in webkit [266394] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r265722 - RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text content
​https://bugs.webkit.org/show_bug.cgi?id=215516
<rdar://problem/64739768>

Reviewed by Simon Fraser.

Normally the RenderBox::content*, border*, padding* and scroll* functions grab the geometry information from the renderer itself.
The clients of these functions expect the geometry data to be consistent with the rest of the rendering context
(e.g coordinates are in the coordinate system of the containing block, paint time operations are not applied etc).
Also these functions are supposed to be const. They should not mutate the geometry or the render tree itself.
Forwarding ::scroll* calls to Element::scroll* can't guarantee neither of these above.

• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scrollWidth const):
(WebCore::RenderTextControlSingleLine::scrollHeight const):
(WebCore::RenderTextControlSingleLine::scrollLeft const):
(WebCore::RenderTextControlSingleLine::scrollTop const):

7:06 AM Changeset in webkit [266393] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r265630 - Add RenderTreeMutationDisallowedScope to track intrusive render tree mutations
​https://bugs.webkit.org/show_bug.cgi?id=215463
<rdar://problem/67012831>

Reviewed by Simon Fraser.

RenderLayer::enclosingScrollableLayer should not mutate the render tree accidentally.
This is related to <rdar://problem/64739768>.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderTreeMutationDisallowedScope.cpp: Added.
• rendering/RenderTreeMutationDisallowedScope.h: Added.

(WebCore::RenderTreeMutationDisallowedScope::RenderTreeMutationDisallowedScope):
(WebCore::RenderTreeMutationDisallowedScope::~RenderTreeMutationDisallowedScope):
(WebCore::RenderTreeMutationDisallowedScope::isMutationAllowed):

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::destroy):

6:54 AM Changeset in webkit [266392] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GLIB] Add expected image failure after r266387

Unreviewed test gardening.

• platform/glib/TestExpectations:

5:53 AM Changeset in webkit [266391] by youenn@apple.com

• 10 edits in trunk/Source

Enable inspection of WebSocket when opening Web Inspector in the middle of the connection like done for the legacy WebSocket implementation
​https://bugs.webkit.org/show_bug.cgi?id=215928

Reviewed by Devin Rousso.

Source/WebCore:

Retrofit API used by Inspector from WebCore::WebSocketChannel to ThreadableWebSocketChannel.
Make Inspector code work with ThreadableWebSocketChannel.
Add a dummy implementation for Worker WebSocket (not supported currently by Web Inspector).

Covered by http/tests/websocket/tests/hybi/inspector with NSURLSession WebSocket code path enabled.

• Modules/websockets/ThreadableWebSocketChannel.h:
• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::clientHandshakeRequest const):

• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WorkerThreadableWebSocketChannel.h:
• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::webSocketForRequestId):

• inspector/agents/page/PageNetworkAgent.cpp:

Source/WebKit:

Implement inspector related API and add additional messages for WebSocket frames.

• WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::close):
(WebKit::WebSocketChannel::didClose):
(WebKit::WebSocketChannel::didSendHandshakeRequest):
(WebKit::WebSocketChannel::didReceiveHandshakeResponse):
(WebKit::WebSocketChannel::clientHandshakeRequest const):
(WebKit::WebSocketChannel::serverHandshakeResponse const):
(WebKit::WebSocketChannel::handshakeMode const):

• WebProcess/Network/WebSocketChannel.h:

2:51 AM Changeset in webkit [266390] by Chris Lord

• 13 edits in trunk/Source/WebCore

[GTK][WPE] Add support for smooth scrolling animation with async scrolling
​https://bugs.webkit.org/show_bug.cgi?id=210382

Reviewed by Carlos Garcia Campos.

This removes the dependency on ScrollableArea from
ScrollAnimationSmooth, which allows its use as a utility class for
smooth scrolling. This class is then used in the Nicosia async layer
composition scrolling code to provide smooth scrolling, when the
feature is enabled. This mirrors the work done in bug 209230 for
kinetic scrolling.

No new tests, enabling existing functionality in more situations.

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::scrollTo):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ScrollingTreeFrameScrollingNodeNicosia):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ScrollingTreeOverflowScrollingNodeNicosia):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
• platform/ScrollAnimation.h:

(WebCore::ScrollAnimation::serviceAnimation):

• platform/ScrollAnimationKinetic.cpp:
• platform/ScrollAnimationKinetic.h:
• platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::stop):
(WebCore::ScrollAnimationSmooth::updateVisibleLengths):
(WebCore::ScrollAnimationSmooth::animationTimerFired):

• platform/ScrollAnimationSmooth.h:
• platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

• platform/generic/ScrollAnimatorGeneric.cpp:

(WebCore::ScrollAnimatorGeneric::ScrollAnimatorGeneric):
(WebCore::ScrollAnimatorGeneric::ensureSmoothScrollingAnimation):

1:58 AM Changeset in webkit [266389] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[GTK][WPE] Do not use the default WebsiteDataStore for downloads
​https://bugs.webkit.org/show_bug.cgi?id=216001

Reviewed by Adrian Perez de Castro.

Use the web context one instead.

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextStartDownload):

1:55 AM Changeset in webkit [266388] by Carlos Garcia Campos

• 12 edits in trunk/Source

[Linux] Web Inspector: show per thread cpu usage
​https://bugs.webkit.org/show_bug.cgi?id=215883

Reviewed by Adrian Perez de Castro.

Source/JavaScriptCore:

Remove platform specific getter machThread() and add thread() to return the Thread instead. The caller knows how
to get the machThread or id from a Thread.

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopBytecodes):
(JSC::SamplingProfiler::machThread): Deleted.

• runtime/SamplingProfiler.h:

(JSC::SamplingProfiler::thread):

Source/WebCore:

Get per thread CPU usage and information to fill ResourceUsageData in Linux.

• page/ResourceUsageThread.h:
• page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting): Update to new API in SamplingProfiler.

• page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting): Initialize m_samplingProfilerThreadID.
(WebCore::threadInfoMap):
(WebCore::threadCPUUsage):
(WebCore::collectCPUUsage):
(WebCore::ResourceUsageThread::platformCollectCPUData):
(WebCore::cpuUsage): Deleted.

Source/WTF:

Add API to get the thread ID in Linux platform.

• wtf/Threading.cpp:

(WTF::Thread::initializeInThread):

• wtf/Threading.h:

(WTF::Thread::id const):

• wtf/ThreadingPrimitives.h:
• wtf/posix/ThreadingPOSIX.cpp:

(WTF::Thread::currentID):

Aug 31, 2020:

11:56 PM Changeset in webkit [266387] by mmaxfield@apple.com

• 6 edits
  2 adds in trunk

Ahom text is still busted
​https://bugs.webkit.org/show_bug.cgi?id=216024
<rdar://problem/60571257>

Reviewed by Zalan Bujtas.

Source/WebCore:

r259533 didn't actually solve the problem becasue I made a typo.
Luckily, iOS 14 and macOS Big Sur include a font with which this patch can be tested!
So this patch actually fixes it for real.

Test: fast/text/ahom.html

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::characterRangeCodePath):

LayoutTests:

• fast/text/ahom-expected-mismatch.html: Added.
• fast/text/ahom.html: Added.
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/ios-13/TestExpectations:

10:19 PM Changeset in webkit [266386] by commit-queue@webkit.org

• 19 edits
  1 delete in trunk/LayoutTests

Unreviewed, reverting r266378 and r266381.
​https://bugs.webkit.org/show_bug.cgi?id=216029

rebaselined tests for new OS without leaving old baselines
behind

Reverted changesets:

"[ BigSur+ ] media/media-source/media-source-webm.html"
​https://trac.webkit.org/changeset/266378

"[ BigSur+ ] platform/mac/media/media-source/is-type-
supported-vp9-codec-check.html"
​https://trac.webkit.org/changeset/266381

9:08 PM Changeset in webkit [266385] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WPE][WebDriver] Gardening a few more failures

Unreviewed test gardening.

• TestExpectations.json:

8:59 PM Changeset in webkit [266384] by sihui_liu@apple.com

• 6 edits in trunk/Source/WebKit

Webpages flash when switching between windows
​https://bugs.webkit.org/show_bug.cgi?id=216012

Reviewed by Darin Adler.

Based on patches from Tim Horton. To avoid flash, we need to make sure view to be selected updates its content
before UI process commits its transaction. We did this by making UI process block until receiving a reply
DidUpdateActivityState from web process. However, web process did not make sure the reply would be sent after
normal rendering update and corresponding transasction commit. Instead, it flushed transactions in progress and
replied. To fix this, now we make web process reply in transaction commit handler after rendering update.

In the switching case, view to be unselected will detach from root layer in its web process, which makes its
content empty. This change is independent from the UI process commit, so we want this to happen after UI process
commits (which submits the view hierachy change). Otherwise, empty content(white flash) on the unselected view
will be displayed. To fix this, we let UI process send the activity state update message in transaction commit
handler.

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::scheduleActivityStateUpdate):

• UIProcess/WebPageProxy.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPageProxy::setSuppressVisibilityUpdates):
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::dispatchActivityStateChange):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::handleActivityStateChangeCallbacksIfNeeded):
(WebKit::TiledCoreAnimationDrawingArea::updateRendering):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::didUpdateActivityStateTimerFired): Deleted.

7:45 PM Changeset in webkit [266383] by mark.lam@apple.com

• 3 edits
  2 adds in trunk

Missing exception check while handling the onbeforeunload event.
​https://bugs.webkit.org/show_bug.cgi?id=216015
<rdar://problem/66324934>

Reviewed by Saam Barati.

Source/WebCore:

Test: js/dom/missing-exception-check-while-handling-onbeforeunload.html

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

LayoutTests:

• js/dom/missing-exception-check-while-handling-onbeforeunload-expected.txt: Added.
• js/dom/missing-exception-check-while-handling-onbeforeunload.html: Added.

6:18 PM Changeset in webkit [266382] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html
rdar://65188503

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

6:10 PM Changeset in webkit [266381] by Karl Rackler

• 1 edit
  2 adds in trunk/LayoutTests

Rebaseline after macOS build progression.
Add for Big-Sur

Unreviewed test gardening.

• platform/mac/fast/forms/date/date-input-rendering-basic-expected.txt: Added.

5:48 PM Changeset in webkit [266380] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] platform/mac/media/media-source/is-type-supported-vp9-codec-check.html
rdar://65188503

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:04 PM Changeset in webkit [266379] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] media/media-source/media-source-webm.html is a constant failure
rdar://problem/66487888

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:01 PM Changeset in webkit [266378] by Karl Rackler

• 19 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Add for Big-Sur

Unreviewed test gardening.

• platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
• platform/mac/fast/css/continuationCrash-expected.txt:
• platform/mac/fast/css/text-overflow-input-expected.txt:
• platform/mac/fast/forms/button-positioned-expected.txt:
• platform/mac/fast/forms/button-sizes-expected.txt:
• platform/mac/fast/forms/input-button-sizes-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/input-text-word-wrap-expected.txt:
• platform/mac/fast/forms/listbox-bidi-align-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/select-selected-expected.txt:
• platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
• platform/mac/fast/parser/document-write-option-expected.txt:
• platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/mac/tables/mozilla/bugs/bug33855-expected.txt:

4:36 PM Changeset in webkit [266377] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.6

4:36 PM Changeset in webkit [266376] by Hector Lopez

• 2 edits in trunk/LayoutTests

Unreviewed, reverting r266374.

Revision set up incorrect expectation

Reverted changeset:

"[ BigSur+ ] media/media-source/media-source-webm.html"
​https://trac.webkit.org/changeset/266374

4:34 PM Changeset in webkit [266375] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Avoid computing metadata for idempotent text autosizing on macOS
​https://bugs.webkit.org/show_bug.cgi?id=216011

Reviewed by Darin Adler.

Avoids an unnecessary call to adjustForTextAutosizing during style resolution on macOS, where idempotent text
autosizing is disabled. This function call populates the AutosizeStatus fields on RenderStyle that are used
by the idempotent text autosizing heuristic. This function call appears consistently in traces taken while
running the Multiply subtest of MotionMark, if only for a relatively small number of samples. While
AutosizeStatus::computeStatus is designed to be very cheap, it ends up being called around 1.6 million times
over the course of the subtest.

• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

4:24 PM Changeset in webkit [266374] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] media/media-source/media-source-webm.html
rdar://66487888

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:19 PM Changeset in webkit [266373] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the unused variable build warning since r238538.

No new tests, no new behaviors.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::copyNonAttributePropertiesFromElement):

4:16 PM Changeset in webkit [266372] by Jonathan Bedard

• 5 edits in trunk/Tools

[webkitcorepy] Register another package in the WebKit repository
​https://bugs.webkit.org/show_bug.cgi?id=216013
<rdar://problem/68097461>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.register): If a package is also checked into the webkit repository,
we prefer the checked in version to the auto-installed version.

• Scripts/webkitpy/init.py: Add webkitscmpy dependency.
• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path): Handle case where the autoinstalled
directory is no the first in the Python path.

3:16 PM Changeset in webkit [266371] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
​https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

• platform/mac/TestExpectations: correction

3:04 PM Changeset in webkit [266370] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html
rdar://problem/66492801

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

2:18 PM Changeset in webkit [266369] by jeffm@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix after ​http://trac.webkit.org/changeset/266364/webkit.

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:

Regenerated these files.

2:14 PM Changeset in webkit [266368] by Lauro Moura

• 5 edits in trunk/LayoutTests

[GLIB] Gardening some failures and flakies

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/gtk-wayland/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

1:25 PM Changeset in webkit [266367] by youenn@apple.com

• 4 edits in trunk/LayoutTests

Update imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https.html so that it no longer times out if first test fails
​https://bugs.webkit.org/show_bug.cgi?id=216009

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https.html:

Wrap internal asserts in first test in its own test wrapper.
Migrate all promise tests to simple synchronous tests.

LayoutTests:

• TestExpectations:

12:54 PM Changeset in webkit [266366] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, address flakiness of imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum.html

LayoutTests/imported/w3c:

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:

LayoutTests:

• TestExpectations:

12:37 PM Changeset in webkit [266365] by Karl Rackler

• 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=215909
Removed test expectations

Unreviewed test gardening.

• platform/wincairo/TestExpectations:

11:59 AM Changeset in webkit [266364] by commit-queue@webkit.org

• 13 edits
  3 adds in trunk/Source

Implement WEBGL_compressed_texture_s3tc_srgb extension
​https://bugs.webkit.org/show_bug.cgi?id=215973

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

• src/libANGLE/renderer/gl/formatutilsgl.cpp:

(rx::nativegl::ExtAndVersionOrExt):
(rx::nativegl::BuildInternalFormatInfoMap):

Source/WebCore:

Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html

• CMakeLists.txt:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• html/canvas/WebGLCompressedTextureS3TCsRGB.cpp: Added.

(WebCore::WebGLCompressedTextureS3TCsRGB::WebGLCompressedTextureS3TCsRGB):
(WebCore::WebGLCompressedTextureS3TCsRGB::getName const):
(WebCore::WebGLCompressedTextureS3TCsRGB::supported):

• html/canvas/WebGLCompressedTextureS3TCsRGB.h: Added.
• html/canvas/WebGLCompressedTextureS3TCsRGB.idl: Added.
• html/canvas/WebGLExtension.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/ExtensionsGL.h:

11:51 AM Changeset in webkit [266363] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Wheel event region code is not fully disabled
​https://bugs.webkit.org/show_bug.cgi?id=216008
<rdar://problem/68086333>

Reviewed by Simon Fraser.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::maintainsEventRegion const):

Use the relevant ENABLE flag rather than !PLATFORM_IOS to compile out the code.

11:28 AM Changeset in webkit [266362] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

WebGL goes in a bad state where glContext.createProgram() returns null
​https://bugs.webkit.org/show_bug.cgi?id=215844

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Kenneth Russell.

Added test webgl/2.0.0/conformance/canvas/render-after-resize-test.html

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshape):

11:23 AM Changeset in webkit [266361] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit

Upstream support for image picker confirmation and downscaling
​https://bugs.webkit.org/show_bug.cgi?id=215997

Reviewed by Anders Carlsson.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showRunOpenPanel:frameInfo:resultListener:]):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
(-[WKFileUploadPanel _configureImagePicker:]): Deleted.

11:16 AM Changeset in webkit [266360] by weinig@apple.com

• 103 edits in trunk/Source

Many settings in RuntimeEnabledSettings should autogenerated Settings: Part 1
​https://bugs.webkit.org/show_bug.cgi?id=215981

Reviewed by Darin Adler.

This moves an initial chunk of RuntimeEnabledSettings settings to Settings.yaml, focusing
on settings that don't require substantial refactoring or new features to work in Settings.yaml.
Source/WebCore:

The one "substantial" change to Settings generation was to switch the conditional key, to require
the complete conditional form (e.g. require ENABLE(FOO) rather than FOO), which matches
WebPreferences.yaml in WebKit, and is more versitile allowing non-ENABLE based conditionals.

• Modules/credentialmanagement/BasicCredential.idl:
• Modules/credentialmanagement/CredentialsContainer.idl:
• Modules/credentialmanagement/NavigatorCredentials.idl:
• Modules/encryptedmedia/MediaKeyMessageEvent.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeyStatusMap.idl:
• Modules/encryptedmedia/MediaKeySystemAccess.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/encryptedmedia/NavigatorEME.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeySession.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
• Modules/gamepad/Gamepad.idl:
• Modules/gamepad/GamepadButton.idl:
• Modules/gamepad/GamepadEvent.idl:
• Modules/gamepad/NavigatorGamepad.idl:
• Modules/mediarecorder/BlobEvent.idl:
• Modules/mediarecorder/MediaRecorder.idl:
• Modules/mediarecorder/MediaRecorderErrorEvent.idl:
• Modules/mediastream/MediaDevices.idl:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):

• Modules/mediastream/NavigatorMediaDevices.idl:
• Modules/webauthn/AuthenticatorAssertionResponse.idl:
• Modules/webauthn/AuthenticatorAttestationResponse.idl:
• Modules/webauthn/AuthenticatorResponse.idl:
• Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable):

• Modules/webauthn/PublicKeyCredential.idl:
• Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb:
• Scripts/SettingsTemplates/Settings.cpp.erb:
• Scripts/SettingsTemplates/Settings.h.erb:
• WebCore.xcodeproj/project.pbxproj:
• css/DOMCSSCustomPropertyDescriptor.idl:
• css/DOMCSSRegisterCustomProperty.idl:
• dom/BeforeLoadEvent.idl:
• dom/CustomElementRegistry.idl:
• dom/DataTransfer.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/Document.cpp:

(WebCore::createUpgradeCandidateElement):

• dom/Document.idl:
• dom/Element.idl:
• dom/InputEvent.idl:
• dom/Node.cpp:

(WebCore::Node::dispatchBeforeLoadEvent):

• dom/StaticRange.idl:
• editing/Editor.cpp:

(WebCore::Editor::registerCustomUndoStep):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isSystemPreviewLink):
(WebCore::HTMLAnchorElement::parseAdClickAttribution const):
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::HTMLAnchorElement::referrerPolicy const):

• html/HTMLAnchorElement.idl:
• html/HTMLAreaElement.idl:
• html/HTMLButtonElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLFormElement.idl:
• html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::referrerPolicy const):

• html/HTMLIFrameElement.idl:
• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::attributeChanged):
(WebCore::HTMLImageElement::isSystemPreviewImage const):
(WebCore::HTMLImageElement::referrerPolicy const):

• html/HTMLImageElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as const):
(WebCore::HTMLLinkElement::referrerPolicy const):

• html/HTMLLinkElement.idl:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateShouldContinueAfterNeedKey):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::webkitSetMediaKeys):
(WebCore::HTMLMediaElement::keyAdded):
(WebCore::HTMLMediaElement::mediaPlayerInitializationDataEncountered):

• html/HTMLMediaElement.idl:
• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

• html/HTMLObjectElement.idl:
• html/HTMLOutputElement.idl:
• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::isSystemPreviewImage):

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::referrerPolicy const):

• html/HTMLScriptElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTextAreaElement.idl:
• html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):
(WebCore::LinkRelAttribute::isSupported):

• html/MediaEncryptedEvent.idl:
• html/WebKitMediaKeyError.idl:
• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::resourceType const):
(WebCore::TokenPreloadScanner::scan):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::createLinkPreloadResourceClient):
(WebCore::LinkLoader::isSupportedType):
(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::prefetchIfNeeded):

• loader/LinkLoader.h:
• page/DOMWindow.idl:
• page/IntersectionObserver.idl:
• page/IntersectionObserverEntry.idl:
• page/Navigator.cpp:

(WebCore::Navigator::canShare):
(WebCore::Navigator::share):

• page/Navigator.h:
• page/NavigatorShare.idl:
• page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::touchEventsEnabled const): Deleted.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::setBlankAnchorTargetImpliesNoOpenerEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::blankAnchorTargetImpliesNoOpenerEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPreloadEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPreloadEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPrefetchEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPrefetchEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaPreloadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaPreloadingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInputEventsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::inputEventsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setCustomElementsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::customElementsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebShareEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webShareEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAuthenticationEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationLocalAuthenticatorEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAuthenticationLocalAuthenticatorEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDisabledAdaptationsMetaTagEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::disabledAdaptationsMetaTagEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setCSSCustomPropertiesAndValuesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssCustomPropertiesAndValuesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setSyntheticEditingCommandsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::syntheticEditingCommandsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaRecorderEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaRecorderEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaDevicesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaDevicesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::screenCaptureEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setScreenCaptureEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDownloadAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::downloadAttributeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setIntersectionObserverEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::intersectionObserverEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setUndoManagerAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::undoManagerAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setEncryptedMediaAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::encryptedMediaAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLegacyEncryptedMediaAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyEncryptedMediaAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setSystemPreviewEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::systemPreviewEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLegacyBeforeLoadEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyBeforeLoadEventEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::adClickAttributionEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setAdClickAttributionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setTouchEventsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::referrerPolicyAttributeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setReferrerPolicyAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::interruptAudioOnPageVisibilityChangeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInterruptAudioOnPageVisibilityChangeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPreloadResponsiveImagesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPreloadResponsiveImagesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setLazyImageLoadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::lazyImageLoadingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setIsInAppBrowserPrivacyEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::isInAppBrowserPrivacyEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setNeedsInAppBrowserPrivacyQuirks): Deleted.
(WebCore::RuntimeEnabledFeatures::needsInAppBrowserPrivacyQuirks const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebShareFileAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webShareFileAPIEnabled const): Deleted.

• page/Settings.yaml:
• page/UndoItem.idl:
• page/UndoManager.idl:
• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setScreenCaptureEnabled): Deleted.

• testing/InternalSettings.h:
• testing/InternalSettings.idl:
• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setShouldInterruptAudioOnPageVisibilityChange):
(WebCore::Internals::addPrefetchLoadEventListener):

Source/WebKit:

In WebKit, this means mostly removing now unnecessary use of the webcoreBinding key in
WebPreferences.yaml and removing now superfluous cases in InjectedBundle::overrideBoolPreferenceForTestRunner.

• Shared/WebPreferences.yaml:

Removing now unnecessary use of the webcoreBinding key and fix indentation of a few cases.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Remove now superfluous cases, as each boolean Settings based setting gets handled automatically.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Remove explicit setting of setInteractiveFormValidationEnabled now that we don't have the
RuntimeEnabledSettings variant being set by the generator.

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Update changed settings to use Settings rather than RuntimeEnabledSettings.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::notifyPreferencesChanged):
Update changed settings to use Settings rather than RuntimeEnabledSettings.

10:43 AM Changeset in webkit [266359] by ysuzuki@apple.com

• 21 edits in trunk/Source/JavaScriptCore

[JSC] StructureStubInfo / CallLinkInfo / ByValInfo should set CodeOrigin or BytecodeIndex at construction
​https://bugs.webkit.org/show_bug.cgi?id=215987
<rdar://problem/66370323>

Reviewed by Mark Lam.

We had race condition during construction of StructureStubInfo and CodeOrigin field setting.

1. The thread creates StructureStubInfo by calling CodeBlock::addStubInfo. This is guarded by the lock. But at this point we are not setting StructureStubInfo::codeOrigin.
2. Then (1)'s thread attempts to set StructureStubInfo::codeOrigin. But at this point, it is not guarded by the lock.
3. Before (2) is executed, DFG ByteCodeParser calls CodeBlock::getICStatusMap. It creates HashMap<CodeOrigin, StructureStubInfo*>.
4. Since StructureStubInfo*'s codeOrigin is not configured yet, (3) sees invalid CodeOrigin. And storing invalid CodeOrigin as a HashMap key is not correct.

We should configure CodeOrigin at construction of StructureStubInfo, which is guarded by the lock. We have the same problem for CallLinkInfo and ByValInfo. This patch fixes them.
To reproduce this, we need to execute a script 2~ days repeatedly. So it is difficult to add a test.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• bytecode/ByValInfo.h:

(JSC::ByValInfo::ByValInfo):
(JSC::ByValInfo::setUp):

• bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::CallLinkInfo):

• bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::setUpCall):
(JSC::CallLinkInfo::setCodeOrigin): Deleted.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::addStubInfo):
(JSC::CodeBlock::addByValInfo):
(JSC::CodeBlock::addCallLinkInfo):

• bytecode/CodeBlock.h:
• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::StructureStubInfo):

• bytecode/StructureStubInfo.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):

• jit/JIT.cpp:

(JSC::JIT::link):

• jit/JITCall.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

• jit/JITInlineCacheGenerator.cpp:

(JSC::garbageStubInfo):
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):

• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

10:22 AM Changeset in webkit [266358] by Hector Lopez

• 56 edits in trunk

Unreviewed, reverting r266350.

Revision is causing a constant crash on both macOS and iOS

Reverted changeset:

"Convert runtime flag to setting for lazy image loading"
​https://bugs.webkit.org/show_bug.cgi?id=215610
​https://trac.webkit.org/changeset/266350

9:56 AM Changeset in webkit [266357] by stephan.szabo@sony.com

• 2 edits in trunk

[PlayStation] Build fix for intermittent copy errors
​https://bugs.webkit.org/show_bug.cgi?id=215951

Reviewed by Ross Kirsling.

• Source/cmake/OptionsPlayStation.cmake:

When copying platform specific files into the binary
directory post build on executable targets, we'd
intermittently get copy errors in parallel builds.

9:47 AM Changeset in webkit [266356] by jh718.park@samsung.com

• 3 edits
  80 copies
  22 adds
  1 delete in trunk/LayoutTests

Import css-conditional tests.
​https://bugs.webkit.org/show_bug.cgi?id=216000

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/conditional/LICENSE: Renamed from LayoutTests/css3/conditional/w3c/LICENSE.
• web-platform-tests/css/conditional/META.yml: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-001-expected.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-001.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-002-expected.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-002.html: Added.
• web-platform-tests/css/conditional/at-supports-001-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-001.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-001.html.
• web-platform-tests/css/conditional/at-supports-002-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-002.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-002.html.
• web-platform-tests/css/conditional/at-supports-003-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-003.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-003.html.
• web-platform-tests/css/conditional/at-supports-004-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-004.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-004.html.
• web-platform-tests/css/conditional/at-supports-005-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-005.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-005.html.
• web-platform-tests/css/conditional/at-supports-006-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-006.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-006.html.
• web-platform-tests/css/conditional/at-supports-007-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-007.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-007.html.
• web-platform-tests/css/conditional/at-supports-008-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-008.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-008.html.
• web-platform-tests/css/conditional/at-supports-009-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-009.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-009.html.
• web-platform-tests/css/conditional/at-supports-010-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-010.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-010.html.
• web-platform-tests/css/conditional/at-supports-011-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-011.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-011.html.
• web-platform-tests/css/conditional/at-supports-012-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-012.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-012.html.
• web-platform-tests/css/conditional/at-supports-013-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-013.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-013.html.
• web-platform-tests/css/conditional/at-supports-014-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-014.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-014.html.
• web-platform-tests/css/conditional/at-supports-015-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-015.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-015.html.
• web-platform-tests/css/conditional/at-supports-016-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-016.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-016.html.
• web-platform-tests/css/conditional/at-supports-017-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-017.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-017.html.
• web-platform-tests/css/conditional/at-supports-018-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-018.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-018.html.
• web-platform-tests/css/conditional/at-supports-019-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-019.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-019.html.
• web-platform-tests/css/conditional/at-supports-020-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-020.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-020.html.
• web-platform-tests/css/conditional/at-supports-021-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-021.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-021.html.
• web-platform-tests/css/conditional/at-supports-022-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-022.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-022.html.
• web-platform-tests/css/conditional/at-supports-023-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-023.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-023.html.
• web-platform-tests/css/conditional/at-supports-024-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-024.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-024.html.
• web-platform-tests/css/conditional/at-supports-025-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-025.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-025.html.
• web-platform-tests/css/conditional/at-supports-026-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-026.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-026.html.
• web-platform-tests/css/conditional/at-supports-027-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-027.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-027.html.
• web-platform-tests/css/conditional/at-supports-028-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-028.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-028.html.
• web-platform-tests/css/conditional/at-supports-029-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-029.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-029.html.
• web-platform-tests/css/conditional/at-supports-030-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-030.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-030.html.
• web-platform-tests/css/conditional/at-supports-031-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-031.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-031.html.
• web-platform-tests/css/conditional/at-supports-032-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-032.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-032.html.
• web-platform-tests/css/conditional/at-supports-033-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-033.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-033.html.
• web-platform-tests/css/conditional/at-supports-034-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-034.html: Added.
• web-platform-tests/css/conditional/at-supports-035-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-035.html: Added.
• web-platform-tests/css/conditional/at-supports-036-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-036.html: Added.
• web-platform-tests/css/conditional/at-supports-037-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-037.html: Added.
• web-platform-tests/css/conditional/at-supports-038-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-038.html: Added.
• web-platform-tests/css/conditional/at-supports-039-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-039.html: Added.
• web-platform-tests/css/conditional/at-supports-040-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-040.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-040.html.
• web-platform-tests/css/conditional/at-supports-041-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-041.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-041.html.
• web-platform-tests/css/conditional/at-supports-042-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-042.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-042.html.
• web-platform-tests/css/conditional/at-supports-043-expected.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-043.html: Added.
• web-platform-tests/css/conditional/idlharness-expected.txt: Added.
• web-platform-tests/css/conditional/idlharness.html: Added.
• web-platform-tests/css/conditional/js/001-expected.txt: Added.
• web-platform-tests/css/conditional/js/001.html: Added.
• web-platform-tests/css/conditional/reference/background-lime.html: Added.
• web-platform-tests/css/conditional/test_group_insertRule-expected.txt: Added.
• web-platform-tests/css/conditional/test_group_insertRule.html: Added.

LayoutTests:

• TestExpectations:
• css3/conditional/w3c/at-supports-001-expected.html: Removed.
• css3/conditional/w3c/at-supports-002-expected.html: Removed.
• css3/conditional/w3c/at-supports-003-expected.html: Removed.
• css3/conditional/w3c/at-supports-004-expected.html: Removed.
• css3/conditional/w3c/at-supports-005-expected.html: Removed.
• css3/conditional/w3c/at-supports-006-expected.html: Removed.
• css3/conditional/w3c/at-supports-007-expected.html: Removed.
• css3/conditional/w3c/at-supports-008-expected.html: Removed.
• css3/conditional/w3c/at-supports-009-expected.html: Removed.
• css3/conditional/w3c/at-supports-010-expected.html: Removed.
• css3/conditional/w3c/at-supports-011-expected.html: Removed.
• css3/conditional/w3c/at-supports-012-expected.html: Removed.
• css3/conditional/w3c/at-supports-013-expected.html: Removed.
• css3/conditional/w3c/at-supports-014-expected.html: Removed.
• css3/conditional/w3c/at-supports-015-expected.html: Removed.
• css3/conditional/w3c/at-supports-016-expected.html: Removed.
• css3/conditional/w3c/at-supports-017-expected.html: Removed.
• css3/conditional/w3c/at-supports-018-expected.html: Removed.
• css3/conditional/w3c/at-supports-019-expected.html: Removed.
• css3/conditional/w3c/at-supports-020-expected.html: Removed.
• css3/conditional/w3c/at-supports-021-expected.html: Removed.
• css3/conditional/w3c/at-supports-022-expected.html: Removed.
• css3/conditional/w3c/at-supports-023-expected.html: Removed.
• css3/conditional/w3c/at-supports-024-expected.html: Removed.
• css3/conditional/w3c/at-supports-025-expected.html: Removed.
• css3/conditional/w3c/at-supports-026-expected.html: Removed.
• css3/conditional/w3c/at-supports-027-expected.html: Removed.
• css3/conditional/w3c/at-supports-028-expected.html: Removed.
• css3/conditional/w3c/at-supports-029-expected.html: Removed.
• css3/conditional/w3c/at-supports-030-expected.html: Removed.
• css3/conditional/w3c/at-supports-031-expected.html: Removed.
• css3/conditional/w3c/at-supports-032-expected.html: Removed.
• css3/conditional/w3c/at-supports-033-expected.html: Removed.
• css3/conditional/w3c/at-supports-040-expected.html: Removed.
• css3/conditional/w3c/at-supports-042-expected.html: Removed.

9:13 AM Changeset in webkit [266355] by weinig@apple.com

• 4 edits in trunk/Source/WebCore

DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow() is not actually a setting, so should not be in DeprecatedGlobalSettings
​https://bugs.webkit.org/show_bug.cgi?id=215978

Reviewed by Darin Adler.

Move behavior quirk defined by DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow() to its
only call site in CommonVM.cpp

• bindings/js/CommonVM.cpp:

(WebCore::globalConstRedeclarationShouldThrow):
(WebCore::commonVMSlow):

• page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow): Deleted.

• page/DeprecatedGlobalSettings.h:

8:51 AM Changeset in webkit [266354] by achristensen@apple.com

• 20 edits
  1 add in trunk

Make Big5 encoder conform to the specification and behavior of Chrome and Firefox
​https://bugs.webkit.org/show_bug.cgi?id=215983

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/big5-encoder-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-cn-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-csbig5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-pua-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-x-x-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-expected.txt:

Source/WebCore:

Covered by web platform tests.

• platform/text/EncodingTables.cpp:
• platform/text/EncodingTables.h:
• platform/text/TextCodecICU.cpp:

(WebCore::eucJPEncode):
(WebCore::big5Encode):
(WebCore::uncheckedAppendDecimal):
(WebCore::urlEncodedEntityUnencodableHandler):
(WebCore::entityUnencodableHandler):
(WebCore::questionMarkUnencodableHandler):
(WebCore::Function<void):
(WebCore::TextCodecICU::encode):

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/URLParser.cpp:

(WTF::CodePointIterator::CodePointIterator): Deleted.
(WTF::CodePointIterator::operator== const): Deleted.
(WTF::CodePointIterator::operator!= const): Deleted.
(WTF::CodePointIterator::atEnd const): Deleted.
(WTF::CodePointIterator::codeUnitsSince const): Deleted.
(WTF::CodePointIterator<LChar>::operator const): Deleted.
(WTF::CodePointIterator<LChar>::operator): Deleted.
(WTF::CodePointIterator<UChar>::operator const): Deleted.
(WTF::CodePointIterator<UChar>::operator): Deleted.

• wtf/text/CodePointIterator.h: Added.

(WTF::CodePointIterator::CodePointIterator):
(WTF::CodePointIterator::operator== const):
(WTF::CodePointIterator::operator!= const):
(WTF::CodePointIterator::atEnd const):
(WTF::CodePointIterator::codeUnitsSince const):
(WTF::CodePointIterator<LChar>::operator const):
(WTF::CodePointIterator<LChar>::operator):
(WTF::CodePointIterator<UChar>::operator const):
(WTF::CodePointIterator<UChar>::operator):

8:14 AM Changeset in webkit [266353] by Wenson Hsieh

• 4 edits in trunk/Source/WebCore

Optimize the implementation of TransformationMatrix::rotate(double)
​https://bugs.webkit.org/show_bug.cgi?id=215994

Reviewed by Tim Horton.

TransformationMatrix::rotate(angle) currently just calls TransformationMatrix::rotate3d(0, 0, 1, angle), which
has a fast path for the case where we're rotating about the z-axis. However, we can make this *slightly* faster
by omitting the hypotenuse computation, several floating point comparisons, and several assignments in this case
because we already know that we're just rotating about the z-axis.

This is a small (but measurable) improvement on the Multiply subtest of MotionMark, which applies a little over
3 million rotation transformations over the course of 30 seconds.

• platform/graphics/transforms/RotateTransformOperation.h:

Instead of calling rotate3d, just have rotate directly call multiply with the following
TransformationMatrix:
`
[[ cos(z) sin(z) 0 0 ]

[ -sin(z) cos(z) 0 0 ]
[ 0 0 1 0 ]
[ 0 0 0 1 ]]

`
...where z is the angle of rotation, in radians.

• platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::rotate):

• platform/graphics/transforms/TransformationMatrix.h:

(WebCore::TransformationMatrix::rotate): Deleted.

8:12 AM Changeset in webkit [266352] by Karl Rackler

• 1 edit
  4 adds in trunk/LayoutTests

Windows baselines after r266228 and r266273.
Add wincairo

Unreviewed test gardening.

• platform/wincairo/streams/reference-implementation/transform-stream-errors-expected.txt: Added.
• platform/wincairo/streams/reference-implementation/transform-stream-expected.txt: Added.

7:25 AM Changeset in webkit [266351] by Aditya Keerthi

• 20 edits
  14 adds in trunk

[macOS] Date inputs should contain editable components
​https://bugs.webkit.org/show_bug.cgi?id=215155

Reviewed by Devin Rousso.

Source/WebCore:

Currently, users are unable to edit the values in date and time input types.
To match system date controls, users should be able to select and edit
individual components of the input. For example, <input type="date"> should
contain an editable year, month, and day control.

Note that this functionality was present in WebKit, up until it was removed
in r150876. Previously known as "INPUT_MULTIPLE_FIELDS_UI", the feature was
removed as it was only used by Chromium port. However, much of the removed
logic remains useful and is resurfaced in this patch. Modifications were made
to update the code to follow current WebKit practices.

DateTimeEditElement is a wrapper element that contains individual fields.
The fields are all DateTimeFieldElements. Note that DateTimeFieldElements
are further specialized into DateTimeNumericFieldElement (for integral
values) and DateTimeSymbolicFieldElement (for symbolic values such as A.M
and P.M). DateTimeEditElement builds the control using the visitor pattern
and existing parsing logic contained in DateTimeFormat.

In order to reduce the patch size, this patch only sets up the rendering
and layout of multiple fields for <input type="date">. Upcoming patches will
add rendering for other date/time input types and introduce editability.

Test: fast/forms/date/date-pseudo-elements.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/html.css:

(input::-webkit-datetime-edit):
(input::-webkit-datetime-edit-fields-wrapper):
(input::-webkit-datetime-edit-year-field,):
(input::-webkit-datetime-edit-year-field:focus,):
(input::-webkit-datetime-edit-text):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::DateTimeFormatValidator::visitField):
(WebCore::DateTimeFormatValidator::validateFormat):
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseChooserOnlyDateAndTimeInputType::destroyShadowSubtree):
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseChooserOnlyDateAndTimeInputType::valueForEditControl const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::localeIdentifier const):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/BaseDateAndTimeInputType.h:
• html/DateInputType.cpp:

(WebCore::DateInputType::isValidFormat const):
(WebCore::DateInputType::setupLayoutParameters const):

• html/DateInputType.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isValidFormat const):
(WebCore::DateTimeLocalInputType::setupLayoutParameters const):

• html/DateTimeLocalInputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::isValidFormat const):
(WebCore::MonthInputType::setupLayoutParameters const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat const):
(WebCore::TimeInputType::setupLayoutParameters const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::isValidFormat const):
(WebCore::WeekInputType::setupLayoutParameters const):

• html/WeekInputType.h:
• html/shadow/DateTimeEditElement.cpp: Added.

(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::build):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
(WebCore::DateTimeEditElement::fieldsWrapperElement const):
(WebCore::DateTimeEditElement::addField):
(WebCore::DateTimeEditElement::create):
(WebCore::DateTimeEditElement::layout):
(WebCore::DateTimeEditElement::localeIdentifier const):
(WebCore::DateTimeEditElement::resetFields):
(WebCore::DateTimeEditElement::setValueAsDate):
(WebCore::DateTimeEditElement::setEmptyValue):
(WebCore::DateTimeEditElement::value const):

• html/shadow/DateTimeEditElement.h: Added.
• html/shadow/DateTimeFieldElement.cpp: Added.

(WebCore::DateTimeFieldElement::DateTimeFieldElement):
(WebCore::DateTimeFieldElement::initialize):
(WebCore::DateTimeFieldElement::localeForOwner const):
(WebCore::DateTimeFieldElement::localeIdentifier const):
(WebCore::DateTimeFieldElement::updateVisibleValue):
(WebCore::DateTimeFieldElement::supportsFocus const):

• html/shadow/DateTimeFieldElement.h: Added.
• html/shadow/DateTimeFieldElements.cpp: Added.

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeDayFieldElement::setValueAsDate):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeMonthFieldElement::setValueAsDate):
(WebCore::DateTimeSymbolicMonthFieldElement::DateTimeSymbolicMonthFieldElement):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::setValueAsDate):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
(WebCore::DateTimeYearFieldElement::create):
(WebCore::DateTimeYearFieldElement::setValueAsDate):

• html/shadow/DateTimeFieldElements.h: Added.
• html/shadow/DateTimeNumericFieldElement.cpp: Added.

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue const):
(WebCore::DateTimeNumericFieldElement::hasValue const):
(WebCore::DateTimeNumericFieldElement::initialize):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::value const):
(WebCore::DateTimeNumericFieldElement::valueAsInteger const):
(WebCore::DateTimeNumericFieldElement::visibleValue const):

• html/shadow/DateTimeNumericFieldElement.h: Added.
• html/shadow/DateTimeSymbolicFieldElement.cpp: Added.

(WebCore::makeVisibleEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::hasValue const):
(WebCore::DateTimeSymbolicFieldElement::initialize):
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::setValueAsInteger):
(WebCore::DateTimeSymbolicFieldElement::value const):
(WebCore::DateTimeSymbolicFieldElement::valueAsInteger const):
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue const):
(WebCore::DateTimeSymbolicFieldElement::visibleValue const):

• html/shadow/DateTimeSymbolicFieldElement.h: Added.

(WebCore::DateTimeSymbolicFieldElement::symbolsSize const):

LayoutTests:

Added a test to verify styling of pseudo elements within date inputs.
Rebaselined existing tests to match new appearance.

• fast/forms/date/date-pseudo-elements-expected.txt: Added.
• fast/forms/date/date-pseudo-elements.html: Added.
• platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:
• platform/mac-wk2/fast/forms/date/date-pseudo-elements-expected.txt: Added.
• platform/mac-wk2/fast/forms/time/time-appearance-basic-expected.txt: Added.
• platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt:

4:51 AM Changeset in webkit [266350] by commit-queue@webkit.org

• 56 edits in trunk

Convert runtime flag to setting for lazy image loading
​https://bugs.webkit.org/show_bug.cgi?id=215610

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-31
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Remove changes done to the lazy image loading tests as we enable the setting in testharnessreport.js.
The new expected results are improvements.

• web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:

Source/WebCore:

Convert runtime flag to setting for lazy image loading.

• html/HTMLImageElement.idl:
• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setLazyImageLoadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::lazyImageLoadingEnabled const): Deleted.

• page/Settings.yaml:

Source/WebKit:

Remove lazy image loading runtime flag.

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Remove lazy image loading runtime flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Enable lazy image loading setting in resources/testharnessreport.js. Update test expectations
and adjust the tests in http/tests/lazyload/ to enable the setting. Fow WK1 list more tests
that should be skipped.

• TestExpectations:
• http/tests/lazyload/attribute.html:
• http/tests/lazyload/js-image.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
• http/tests/lazyload/lazy.html:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk1/TestExpectations:
• platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• resources/testharnessreport.js:

2:45 AM Changeset in webkit [266349] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak] SDK branch upgrade path is broken
​https://bugs.webkit.org/show_bug.cgi?id=215927

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-08-31
Reviewed by Adrian Perez de Castro.

The development environment (flatpak install) needs to be performed before attempting to
rebuild toolchain archives. In most cases this wasn't an issue, but when the SDK needs to be
upgraded to a new ABI/branch, the previous version needs to be removed, that triggers a new
flatpak install and toolchain archives update, which need then to be done in the right
order.

• flatpak/flatpakutils.py:

(WebkitFlatpak.main):

2:01 AM Changeset in webkit [266348] by youenn@apple.com

• 35 edits
  5 adds in trunk

Add support for TextDecoderStream
​https://bugs.webkit.org/show_bug.cgi?id=215919

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/streams/backpressure.any-expected.txt:
• web-platform-tests/encoding/streams/backpressure.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-attributes.any-expected.txt:
• web-platform-tests/encoding/streams/decode-attributes.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/decode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-ignore-bom.any-expected.txt:
• web-platform-tests/encoding/streams/decode-ignore-bom.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-incomplete-input.any-expected.txt:
• web-platform-tests/encoding/streams/decode-incomplete-input.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-split-character.any-expected.txt:
• web-platform-tests/encoding/streams/decode-split-character.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any.worker-expected.txt:
• web-platform-tests/encoding/streams/realms.window-expected.txt:

Source/WebCore:

Implement TextEncoderStream as a JS built-in.
It is enabled by transform stream runtime flag.

TextDecoderStream takes a TransformStream and TextDecoderStreamEncoder as private slots.
Add TextDecoderStreamEncoder to implement the actual UTF-8 encoding steps, as a wrapper around TextDecoder.

Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/TextDecoderStream.idl: Added.
• dom/TextDecoderStream.js: Added.

(initializeTextDecoderStream):
(getter.encoding):
(getter.fatal):
(getter.ignoreBOM):
(getter.readable):
(getter.writable):

• dom/TextDecoderStreamDecoder.cpp: Added.

(WebCore::TextDecoderStreamDecoder::create):
(WebCore::TextDecoderStreamDecoder::TextDecoderStreamDecoder):
(WebCore::TextDecoderStreamDecoder::decode):
(WebCore::TextDecoderStreamDecoder::flush):

• dom/TextDecoderStreamDecoder.h: Added.

(WebCore::TextDecoderStreamDecoder::encoding const):

• dom/TextDecoderStreamDecoder.idl: Added.

LayoutTests:

• TestExpectations:

Unskipping encoding tests except legacy-* tests which are big and slow.

1:58 AM Changeset in webkit [266347] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

[Cocoa] Disable sniffing for WebSocket handshakes
​https://bugs.webkit.org/show_bug.cgi?id=215932

Reviewed by Darin Adler.

Covered by http/tests/websocket/tests/hybi/handshake-error.html no longer timing out with NSURLSession WebSocket code path.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::createWebSocketTask):

12:23 AM Changeset in webkit [266346] by ysuzuki@apple.com

• 5 edits in trunk

[JSC] @defaultPromiseThen fast path should check species constructor
​https://bugs.webkit.org/show_bug.cgi?id=215996

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml:

Source/JavaScriptCore:

When executing @defaultPromiseThen fast path, we assumed that this execution is not observable.
This is wrong only for species constructor part: this @@species access & derived constructor calls
can be observable. In this patch,

1. We extract part of Promise#then as @performPromiseThen, which corresponds to the spec's PerformPromiseThen.
2. In promise fast path, we check @speciesConstructor is @Promise or @InternalPromise. If it is not, then we go to the slow path.

This fixes Promise#finally failures in test262.

• builtins/PromiseOperations.js:

(globalPrivate.promiseResolveThenableJobFast):
(globalPrivate.promiseResolveThenableJobWithoutPromiseFast):
(globalPrivate.promiseResolveThenableJobWithDerivedPromise):
(onFulfilled):
(onRejected):
(globalPrivate.performPromiseThen):

• builtins/PromisePrototype.js:

(then):
(onFulfilled): Deleted.
(onRejected): Deleted.