Timeline

Sep 3, 2020:

11:10 PM Changeset in webkit [266579] by rniwa@webkit.org

• 2 edits in trunk/Source/WTF

GTK+ build fix attempt after r266573.

• wtf/CompactUniquePtrTuple.h:

10:58 PM Changeset in webkit [266578] by rniwa@webkit.org

• 6 edits in trunk/Source/WebCore

Store all styling flags in m_rendererWithStyleFlags
​https://bugs.webkit.org/show_bug.cgi?id=216069

Reviewed by Darin Adler.

This patch moves all remaining styling flags and Style::Validity from m_nodeFlags
to m_rendererWithStyleFlags since CSS JIT no longer rely on these flags directly
and CompactPointerTuple has been expanded to store up to 16 bits of data as opposed
to just 8 bits.

No new tests since there should be no behavioral change.

• dom/ContainerNode.h:

(WebCore::ContainerNode::directChildNeedsStyleRecalc const):
(WebCore::ContainerNode::setDirectChildNeedsStyleRecalc):

• dom/Element.cpp:

(WebCore::Element::resetStyleRelations):

• dom/Element.h:

(WebCore::Element::styleAffectedByEmpty const):
(WebCore::Element::descendantsAffectedByPreviousSibling const):
(WebCore::Element::childrenAffectedByFirstChildRules const):
(WebCore::Element::childrenAffectedByLastChildRules const):
(WebCore::Element::childrenAffectedByForwardPositionalRules const):
(WebCore::Element::descendantsAffectedByForwardPositionalRules const):
(WebCore::Element::childrenAffectedByBackwardPositionalRules const):
(WebCore::Element::descendantsAffectedByBackwardPositionalRules const):
(WebCore::Element::childrenAffectedByPropertyBasedBackwardPositionalRules const):
(WebCore::Element::affectsNextSiblingElementStyle const):
(WebCore::Element::styleIsAffectedByPreviousSibling const): Moved here from Node.
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::setDescendantsAffectedByPreviousSibling):
(WebCore::Element::setChildrenAffectedByFirstChildRules):
(WebCore::Element::setChildrenAffectedByLastChildRules):
(WebCore::Element::setChildrenAffectedByForwardPositionalRules):
(WebCore::Element::setDescendantsAffectedByForwardPositionalRules):
(WebCore::Element::setChildrenAffectedByBackwardPositionalRules):
(WebCore::Element::setDescendantsAffectedByBackwardPositionalRules):
(WebCore::Element::setChildrenAffectedByPropertyBasedBackwardPositionalRules):
(WebCore::Element::setAffectsNextSiblingElementStyle):
(WebCore::Element::setStyleIsAffectedByPreviousSibling):

• dom/Node.cpp:

(WebCore::Node::adjustStyleValidity):

• dom/Node.h:

(WebCore::Node::styleValidity const):
(WebCore::Node::styleResolutionShouldRecompositeLayer const):
(WebCore::Node::childNeedsStyleRecalc const):
(WebCore::Node::styleIsAffectedByPreviousSibling const): Moved to Element.
(WebCore::Node::setChildNeedsStyleRecalc):
(WebCore::Node::flagChildrenAffectedByFirstChildRulesFlag): Deleted.
(WebCore::Node::flagChildrenAffectedByLastChildRulesFlag): Deleted.
(WebCore::Node::flagAffectsNextSiblingElementStyle): Deleted.
(WebCore::Node::flagStyleIsAffectedByPreviousSibling): Deleted.
(WebCore::Node::NodeStyleFlag): Added. Moved most of flags from m_nodeFlags here.
(WebCore::Node::DynamicStyleRelationFlag): Renamed from ElementStyleFlag.
(WebCore::Node::StyleBitfields): Added. A helper struct to read and manipulate
bit-fields stored in m_rendererWithStyleFlags.
(WebCore::Node::StyleBitfields::fromRaw): Added.
(WebCore::Node::StyleBitfields::toRaw): Added.
(WebCore::Node::StyleBitfields::styleValidity const): Added.
(WebCore::Node::StyleBitfields::setStyleValidity): Added.
(WebCore::Node::StyleBitfields::dynamicStyleRelations const): Added.
(WebCore::Node::StyleBitfields::setDynamicStyleRelation): Added.
(WebCore::Node::StyleBitfields::clearDynamicStyleRelations): Added.
(WebCore::Node::StyleBitfields::flags const): Added.
(WebCore::Node::StyleBitfields::setFlag): Added.
(WebCore::Node::StyleBitfields::clearFlag): Added.
(WebCore::Node::StyleBitfields::clearDescendantsNeedStyleResolution): Added.
(WebCore::Node::styleBitfields const): Added.
(WebCore::Node::setStyleBitfields): Added.
(WebCore::Node::hasStyleFlag const):
(WebCore::Node::setStyleFlag):
(WebCore::Node::clearStyleFlags): Deleted.
(WebCore::Node::hasDynamicStyleRelationFlag const): Added.
(WebCore::Node::setHasValidStyle): Moved here from the class declaration.
(WebCore::Node::setDynamicStyleRelationFlag): Added.
(WebCore::Node::clearChildNeedsStyleRecalc): Added.
(WebCore::Node::setHasValidStyle):

10:19 PM Changeset in webkit [266577] by Carlos Garcia Campos

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. [GLIB] Add missing return

There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak.

• API/glib/JSCValue.cpp:

(jsc_value_object_invoke_methodv):

10:13 PM Changeset in webkit [266576] by Carlos Garcia Campos

• 14 edits in trunk

[GTK] Unexpected User-Agent on redirect
​https://bugs.webkit.org/show_bug.cgi?id=191858

Reviewed by Youenn Fablet.

Source/WebKit:

Clear the user agent on new request after a redirect to ensure a new one is computed taking into account the
quirks if needed. Also ensure quirks are applied for downloads started in the UI process.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Clear the user agent on new request.

• UIProcess/API/glib/WebKitDownloadClient.cpp:
• UIProcess/WebPageProxy.h: Add userAgentForURL().
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download): Use userAgentForURL() instead of userAgent().

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::userAgentForURL): Implement it to apply quirks if needed.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::userAgentForURL): Just return the web page user agent.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

• UIProcess/playstation/WebPageProxyPlayStation.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

• UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

• UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

Tools:

Add unit tests to check the user agent is sent in headers and preserved after a redirect for both main resource
and subresources.

• TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(serverCallback):
(testDownloadUserAgent):
(beforeAll):

• TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(testUserAgent):
(serverCallback):
(beforeAll):

8:07 PM Changeset in webkit [266575] by Chris Dumez

• 13 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky Web Audio tests.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

8:03 PM Changeset in webkit [266574] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Catalina debug wk2 ] html5lib/generated/run-template-data.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=216164

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:01 PM Changeset in webkit [266573] by rniwa@webkit.org

• 6 edits
  2 adds in trunk

Add CompactUniquePtrTuple
​https://bugs.webkit.org/show_bug.cgi?id=215936

Reviewed by Darin Adler.

Source/WTF:

Added a new template class, CompactUniquePtrTuple, which stores a pointer and up to 16-bits of
a POD type using CompactPointerTuple.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/CompactUniquePtrTuple.h: Added.

(WTF::makeCompactUniquePtr): Added. Like makeUnique, creates an object of the specified type
and returns CompactUniquePtrTuple.
(WTF::CompactUniquePtrTuple): Added.
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Move constructor.
(WTF::CompactUniquePtrTuple::~CompactUniquePtrTuple):
(WTF::CompactUniquePtrTuple::operator=):
(WTF::CompactUniquePtrTuple::pointer):
(WTF::CompactUniquePtrTuple::moveToUniquePtr): Clears this pointer and returns unique_ptr.
(WTF::CompactUniquePtrTuple::setPointer): Like CompactPointerTuple sets the pointer component
of this tuple, freeing the old object if there is already one stored.
(WTF::CompactUniquePtrTuple::type):
(WTF::CompactUniquePtrTuple::setType):
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Constructor which takes unique_ptr&&.
(WTF::CompactUniquePtrTuple::deletePointer):

Tools:

Added basic unit tests for CompactUniquePtrTuple.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp: Added.

(TestWebKitAPI::A): Adde.
(TestWebKitAPI::A::A):
(TestWebKitAPI::A::~A):
(WTF_CompactUniquePtrTuple.Basic):

8:01 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:59 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:59 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:49 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:40 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:33 PM Changeset in webkit [266572] by Hector Lopez

• 1 edit
  2 deletes in trunk/LayoutTests

Correction for Rebasline at changeset ​https://trac.webkit.org/changeset/266500/webkit

Unreviewed test gardening.

• platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt: Removed.
• platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt: Removed.

7:33 PM Changeset in webkit [266571] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, fix debug build after r266570.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::periodicWave):

7:07 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:00 PM Changeset in webkit [266570] by Chris Dumez

• 9 edits in trunk

Tests using OscillatorNode are flaky
​https://bugs.webkit.org/show_bug.cgi?id=216152

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

Source/WebCore:

OscillatorNode was caching the different kind of PeriodicWaves in global static
variables. However, the PeriodicWaves are specific to a given sample rate.
As a result, we would sometimes use a cached periodic wave that was using the
wrong sample rate, leading to flaky failures. To address the issue, we now
cache the periodic waves per audio context instead.

No new tests, rebaselined existing tests and unskip them.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::periodicWave):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::setType):

• Modules/webaudio/OscillatorNode.h:

6:56 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:54 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:54 PM Changeset in webkit [266569] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 Debug ] imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=216162

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

6:52 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:51 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:11 PM Changeset in webkit [266568] by commit-queue@webkit.org

• 10 edits
  5 adds in trunk

Web Inspector fails to preview response from XHR requests
​https://bugs.webkit.org/show_bug.cgi?id=215852

Patch by Patrick Angle <Patrick Angle> on 2020-09-03
Reviewed by Devin Rousso.

Source/WebCore:

Test: http/tests/inspector/network/fetch-response-body.html

Added workaround for 304 XHR/Fetch requests so that the mimeType and content are correctly set, otherwise the
frontend does not have the information it needs to preview the response.

• inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived): Storing new ResourceData members
(WebCore::NetworkResourcesData::dataForURL): Support for finding a previous non-304 response for a URL.

• inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::httpStatusText const):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusText):
(WebCore::NetworkResourcesData::ResourceData::mimeType const):
(WebCore::NetworkResourcesData::ResourceData::setMIMEType):
(WebCore::NetworkResourcesData::ResourceData::responseTimestamp const):
(WebCore::NetworkResourcesData::ResourceData::setResponseTimestamp):

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::willSendRequest): Fixed issue where it was possible that we would inform the

frontend that a request was of type Other even though we had request information indicating it was XHR
or Fetch.

(WebCore::InspectorNetworkAgent::didReceiveResponse): Added code path to work around underlying issue where

XHR/Fetch 304s are not cached, and end up not passing necessary information to the frontend as a result.

Source/WebInspectorUI:

Responses with a no content error and a status code of 304 now show a Resource has no cached content message instead

of a generic error. Also responses with empty content and no mime type now show a Resource has no content
message.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Models/Resource.js: More consistant error handling model - previously some paths rejected on

failure and some resolved with an error property.

(WI.Resource.prototype.requestContent):
(WI.Resource.prototype._requestContentFailure):

• UserInterface/Views/ResourceContentView.js: Error messages

(WI.ResourceContentView.prototype.async showGenericNoContentMessage): Text now consistent with other messages.
(WI.ResourceContentView.prototype.showNoCachedContentMessage):
(WI.ResourceContentView.prototype._contentAvailable):

LayoutTests:

Added new test cases and associated resources to test handling of 304 Not Modified responses to XHR requests.
We test both XHR for a PHP page as well as for a text file, as they behaved differently (incorrectly) before
this patch.

• http/tests/inspector/network/fetch-response-body-304-expected.txt:
• http/tests/inspector/network/fetch-response-body-304.html:
• http/tests/inspector/network/resources/.htaccess: Cache-Control header for fetch-cachable.txt
• http/tests/inspector/network/resources/fetch-cachable.php:
• http/tests/inspector/network/resources/fetch-cachable.txt:
• platform/mac-wk1/TestExpectations: Tests rely on disk-cache which is not present in WK1

6:03 PM Changeset in webkit [266567] by ysuzuki@apple.com

• 15 edits
  2 moves
  9 adds in trunk

[JSC] Cache toString / valueOf / @@toPrimitive for major cases
​https://bugs.webkit.org/show_bug.cgi?id=216061

Reviewed by Saam Barati.

JSTests:

• stress/delete-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

• stress/delete-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

• stress/delete-cached-value-of-property.js: Added.

(shouldBe):
(shouldThrow):
(object.proto.valueOf):

• stress/hide-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

• stress/hide-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

• stress/hide-cached-value-of-property.js: Added.

(shouldBe):
(object.proto.valueOf):

• stress/replace-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

• stress/replace-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

• stress/replace-cached-value-of-property.js: Added.

(shouldBe):
(object.proto.valueOf):

Source/JavaScriptCore:

When toPrimitive is called, we need to look-up three properties at most to perform operation. And these special properties do not have caching mechanism at all.
We found that Speedometer2/EmberJS-Debug-TodoMVC is using very much time for this property look-up. We should have caching mechanism in StructureRareData, which
should be similar to @@toStringTag & Object#toString caching mechanism.

This patch generalizes @@toStringTag & Object#toString caching mechanism as SpecialPropertyCache. And we accelerate toString / valueOf / @@toPrimitive look-ups in
toPrimitive with this caching mechanism.

This patch improved Speedometer2/EmberJS-Debug-TodoMVC by 10%.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• bytecode/Watchpoint.cpp:
• bytecode/Watchpoint.h:
• runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.cpp: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp.

(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::CachedSpecialPropertyAdaptiveStructureWatchpoint):
(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::install):
(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::fireInternal):

• runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.h: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.h.
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::objectProtoToStringFunction const):

• runtime/JSObject.cpp:

(JSC::callToPrimitiveFunction):
(JSC::JSObject::ordinaryToPrimitive const):
(JSC::JSObject::toPrimitive const):

• runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):
(JSC::objectProtoFuncToString):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::cacheSpecialProperty):
(JSC::Structure::setObjectToStringValue): Deleted.

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):
(JSC::StructureRareData::ensureSpecialPropertyCacheSlow):
(JSC::StructureRareData::giveUpOnSpecialPropertyCache):
(JSC::StructureRareData::cacheSpecialPropertySlow):
(JSC::StructureRareData::clearCachedSpecialProperty):
(JSC::StructureRareData::finalizeUnconditionally):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::isValid const):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::handleFire):
(JSC::StructureRareData::setObjectToStringValue): Deleted.
(JSC::StructureRareData::clearObjectToStringValue): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::ObjectToStringAdaptiveInferredPropertyValueWatchpoint): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::isValid const): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire): Deleted.

• runtime/StructureRareData.h:
• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::cachedSpecialProperty const):
(JSC::StructureRareData::canCacheSpecialProperty):
(JSC::StructureRareData::ensureSpecialPropertyCache):
(JSC::StructureRareData::cacheSpecialProperty):
(JSC::StructureRareData::objectToStringValue const): Deleted.

6:02 PM Changeset in webkit [266566] by Hector Lopez

• 1 edit in trunk/LayoutTests/ChangeLog

REGRESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216160

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

5:59 PM Changeset in webkit [266565] by Hector Lopez

• 2 edits in trunk/LayoutTests

RERESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216160

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

5:58 PM Changeset in webkit [266564] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] webgpu/whlsl/ensure-proper-variable-lifetime.html is flaky ImageOnlyFailure.
​https://bugs.webkit.org/show_bug.cgi?id=207267

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

5:43 PM Changeset in webkit [266563] by Hector Lopez

• 3 edits in trunk/LayoutTests

REGRESSION(r266511): [ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216159

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

5:13 PM Changeset in webkit [266562] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Mojave+ debug wk2 ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216155

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

5:00 PM Changeset in webkit [266561] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/misc/script-async.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216156

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

3:47 PM Changeset in webkit [266560] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Sampling profiler should dump hash as part of the top function key to prevent incorrectly grouping nameless functions together
​https://bugs.webkit.org/show_bug.cgi?id=216087

Reviewed by Tadeu Zagallo.

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopFunctions):

2:43 PM Changeset in webkit [266559] by Chris Dumez

• 23 edits in trunk

AudioDestinationNode.maxChannelCount always returns 0
​https://bugs.webkit.org/show_bug.cgi?id=216127

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/ctor-waveshaper-expected.txt:

Source/WebCore:

Update AudioDestinationNode.maxChannelCount to return a sane value on both macOS
and iOS. Also make sure the proper exceptions are thrown when trying to create
an AudioNode with an invalid number of channels.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioDestinationNode.h:
• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::setChannelCount):

• Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::setChannelCount):

• platform/audio/AudioSession.cpp:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

• platform/audio/AudioSession.h:
• platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestination::maxChannelCount):

• platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

• platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

2:42 PM Changeset in webkit [266558] by Chris Dumez

• 4 edits in trunk

Make AudioParam.cancelScheduledValues() standards compliant
​https://bugs.webkit.org/show_bug.cgi?id=216132

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt:

Source/WebCore:

Align our implementation of AudioParam.cancelScheduledValues() with Chromium's
to give us a few more passes on WPT tests. In particular, this adds special
handling for when the cancelTime lands in the middle of a SetValueCurve event.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::cancelScheduledValues):

2:38 PM Changeset in webkit [266557] by Darin Adler

• 76 edits in trunk/Source

Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType
​https://bugs.webkit.org/show_bug.cgi?id=216102

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::characterOffsetForTextMarkerData): Use Affinity.

• accessibility/AXObjectCache.h: Ditto.
• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::performTextOperation): Ditto.
(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions const): Ditto.
(WebCore::AccessibilityObject::visiblePositionRangeForRange const): Ditto.
(WebCore::AccessibilityObject::replaceTextInRange): Ditto.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine const): Removed unneeded
call to Position::equal, simplified code.
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const): Use Affinity.
(WebCore::AccessibilityRenderObject::visiblePositionForIndex const): Ditto.
(WebCore::AccessibilityRenderObject::doAXRangeForLine const): Ditto.

• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject): Use Affinity.
(wordAtPositionForAtkBoundary): Ditto.
(sentenceAtPositionForAtkBoundary): Ditto.
(lineAtPositionForAtkBoundary): Ditto.

• accessibility/atk/WebKitAccessibleUtil.cpp:

(objectFocusedAndCaretOffsetUnignored): Rely on default affinity.

• dom/Element.cpp:

(WebCore::Element::updateFocusAppearance): Rely on default affinity.

• dom/Position.cpp:

(WebCore::Position::previousCharacterPosition const): Use Affinity.
(WebCore::Position::nextCharacterPosition const): Ditto.
(WebCore::Position::leadingWhitespacePosition const): Ditto.
(WebCore::Position::trailingWhitespacePosition const): Ditto.
(WebCore::Position::inlineBoxAndOffset const): Ditto.

• editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::formatSelection): Ditto.

• editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply): Ditto.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphWithClones): Rely on default affinity.
(WebCore::CompositeEditCommand::moveParagraphs): Ditto.

• editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply): Use Affinity.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::smartDeleteParagraphSpacers): Ditto.
(WebCore::DeleteSelectionCommand::doApply): Ditto.

• editing/Editing.cpp:

(WebCore::firstInSpecialElement): Rely on default affinity.
(WebCore::lastInSpecialElement): Ditto.
(WebCore::visiblePositionBeforeNode): Ditto.
(WebCore::visiblePositionAfterNode): Ditto.
(WebCore::visiblePositionForIndexUsingCharacterIterator): Use Affinity.

• editing/Editor.cpp:

(WebCore::Editor::selectionForCommand): Use Affinity.
(WebCore::Editor::canDeleteRange const): Rely on default affinity.
(WebCore::Editor::applyStyle): Use isNone and isCaret.
(WebCore::Editor::applyParagraphStyle): Ditto.
(WebCore::Editor::setComposition): Use Affinity.
(WebCore::Editor::advanceToNextMisspelling): Rely on default affinity.
(WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
(WebCore::Editor::markAndReplaceFor): Ditto. Use isCaret.
(WebCore::Editor::transpose): Rely on default affinity.
(WebCore::Editor::insertTextPlaceholder): Ditto.
(WebCore::Editor::removeTextPlaceholder): Ditto.
(WebCore::Editor::firstRectForRange const): Ditto. Also simplify
rectangle calculation at the end of the function.
(WebCore::Editor::shouldChangeSelection const): Use Affinity.
(WebCore::Editor::findString): Rely on default affinity.

• editing/Editor.h: Use Affinity.
• editing/EditorCommand.cpp:

(WebCore::executeDeleteToMark): Ditto.
(WebCore::executeSelectToMark): Ditto.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo): Ditto.
(WebCore::FrameSelection::modify): Ditto.
(WebCore::FrameSelection::setBase): Ditto.
(WebCore::FrameSelection::setExtent): Ditto.
(WebCore::FrameSelection::setSelectedRange): Ditto.
(WebCore::FrameSelection::revealSelection): Use isNone and isCaret.
(WebCore::FrameSelection::setSelectionFromNone): Rely on default affinity.
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection): Ditto.

• editing/FrameSelection.h: Use Affinity.

• editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentRegion): Rely on default affinity.

• editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply): Use Affinity.

• editing/InsertNestedListCommand.cpp:

(WebCore::InsertNestedListCommand::doApply): Ditto.

• editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Use Affinity.

• editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab): Rely on default affinity.

• editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::RenderedPosition): Use Affinity.

• editing/RenderedPosition.h: Ditto.

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Rely on default affinity.
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
Use VisibleSelection::defaultAffinity.

• editing/TextAffinity.h: Removed EAffinity, UPSTREAM, DOWNSTREAM.

• editing/TextIterator.cpp:

(WebCore::TextIterator::shouldRepresentNodeOffsetZero): Rely on
default affinity.

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::makeEditableRootEmpty): Use Affinity.
(WebCore::TypingCommand::deleteKeyPressed): Use isCaretOrRange and isRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::VisiblePosition): Use Affinity.
(WebCore::VisiblePosition::previous const): Rely on default affinity.
(WebCore::VisiblePosition::left const): Ditto.
(WebCore::VisiblePosition::right const): Ditto.
(WebCore::operator<<): Use Affinity.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::VisibleSelection): Use Affinity. Also use
initialize in the class definition.
(WebCore::VisibleSelection::selectionFromContentsOfNode): Rely on
default affinity.
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
Rename from "pos" to "position".
(WebCore::VisibleSelection::updateSelectionType): Update from
m_selectionType to m_type and use Affinity.
(WebCore::VisibleSelection::validate): Use isRange.
(WebCore::VisibleSelection::setWithoutValidation): Use Affinity and
m_type.

• editing/VisibleSelection.h: Removed SEL_DEFAULT_AFFINITY, replacing

it with VisibleSelection::defaultAffinity. Removed both
VisibleSelection::SelectionType and VisibleSelection::selectionType,
replacing with private VisibleSelection::Type. Also renamed
m_selectionType to m_type.

• editing/VisibleUnits.cpp:

(WebCore::logicallyPreviousBox): Use Affinity.
(WebCore::logicallyNextBox): Ditto.
(WebCore::previousLinePosition): Rely on default affinity.
(WebCore::nextLinePosition): Ditto.
(WebCore::startOfParagraph): Ditto.
(WebCore::endOfParagraph): Ditto.
(WebCore::withinTextUnitOfGranularity): Use Affinity.
(WebCore::enclosingTextUnitOfGranularity): Ditto.

• editing/cocoa/DictionaryLookup.mm:

(WebCore::DictionaryLookup::rangeAtHitTestResult): Use isRange.

• loader/EmptyClients.cpp: Use Affinity.
• page/DOMSelection.cpp:

(WebCore::DOMSelection::collapse): Ditto.
(WebCore::DOMSelection::collapseToEnd): Ditto.
(WebCore::DOMSelection::collapseToStart): Ditto.
(WebCore::DOMSelection::setBaseAndExtent): Ditto.
(WebCore::DOMSelection::setPosition): Ditto.
(WebCore::DOMSelection::extend): Ditto.

• page/EditorClient.h: Ditto.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):
Rely on default affinity.

• page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):
Use constructor that takes a single Position and Affinity.

• page/Page.cpp:

(WebCore::replaceRanges): Use Affinity.

• page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use isNone.

• rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries): Use Affinity.
(WebCore::RenderBlock::positionForPoint): Ditto.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForPointWithInlineChildren): Ditto.

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::positionForPoint): Ditto.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::positionForPoint): Ditto.
(WebCore::RenderObject::createVisiblePosition const): Ditto.

• rendering/RenderObject.h: Ditto.
• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint): Ditto.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::positionForPoint const): Ditto.

• rendering/RenderTreeAsText.cpp:

(WebCore::writeSelection): Ditto.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::positionForPoint): Ditto.

Source/WebKit:

• WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h:

(API::InjectedBundle::EditorClient::shouldChangeSelectedRange): Use Affinity.

• WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::toAPI): Dito.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Ditto.

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange): Ditto.

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: Ditto.
• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldChangeSelectedRange): Ditto.

• WebProcess/WebCoreSupport/WebEditorClient.h: Ditto.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::insertDictatedTextAsync): Rely on default affinity.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::insertTextAsync): Ditto.
(WebKit::WebPage::setCompositionAsync): Ditto.
(WebKit::WebPage::deleteSurrounding): Ditto.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDrag): Use Affinity.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::selectTextWithGranularityAtPoint): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPoint): Ditto.
(WebKit::WebPage::replaceSelectedText): Ditto.
(WebKit::WebPage::replaceDictatedText): Ditto.
(WebKit::WebPage::applyAutocorrectionInternal): Ditto.
(WebKit::WebPage::updateSelectionWithDelta): Ditto.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]): Use Affinity.
(-[WebFrame smartExtendRangedSelection:]): Use visibleStart/End/Extent so we don't
need to write explicit code to handle affinity.

• WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition setAffinity:]): Use Affinity.

Source/WebKitLegacy/mac:

• DOM/DOMUIKitExtensions.mm:

(-[DOMNode rangeOfContainingParagraph]): Rely on default affinity.

• WebCoreSupport/WebEditorClient.h:

(kit): Use Affinity.
(core): Ditto.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldChangeSelectedRange): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame _caretRectAtPosition:affinity:]): Ditto.
(-[WebFrame _selectNSRange:]): Rely on default affinity.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use isNone.

• WebView/WebHTMLView.mm:

(-[WebHTMLView insertText:]): Rely on default affinity.

Source/WebKitLegacy/win:

• WebCoreSupport/WebEditorClient.cpp:

(toWebSelectionAffinity): Added.
(WebEditorClient::shouldChangeSelectedRange): Use Affinity.

• WebCoreSupport/WebEditorClient.h: Ditto.

2:35 PM Changeset in webkit [266556] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Unreviewed, reverting r266498.
​https://bugs.webkit.org/show_bug.cgi?id=216143

crashes in debug

Reverted changeset:

"Simplify some editing code"
​https://bugs.webkit.org/show_bug.cgi?id=216097
​https://trac.webkit.org/changeset/266498

2:31 PM Changeset in webkit [266555] by Alan Coon

• 22 edits in branches/safari-610-branch

Cherry-pick r266265. rdar://problem/68168939

[iOS] provide a way to get previously inserted alternatives for the selected text
​https://bugs.webkit.org/show_bug.cgi?id=215816
<rdar://problem/66646042>

Reviewed by Darin Adler.

Source/WebCore:

• editing/cocoa/AlternativeTextUIController.h:
• editing/cocoa/AlternativeTextUIController.mm: (WebCore::AlternativeTextUIController::alternativesForContext): Return the raw NSTextAlternatives * and let the caller create the Vector<String> if they need to so that callers that don't can use the actual NSTextAlternatives *.

• editing/Editor.h:
• editing/Editor.cpp: (WebCore::Editor::applyDictationAlternative): Added. (WebCore::Editor::applyDictationAlternativelternative): Deleted.
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Drive-by: fix typo.

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView alternativesForSelectedText]):

• UIProcess/WebPageProxy.h:
• UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::platformDictationAlternatives): Added.
• UIProcess/PageClient.h:
• UIProcess/Cocoa/PageClientImplCocoa.h:
• UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::dictationAlternatives): (WebKit::PageClientImplCocoa::platformDictationAlternatives): Added. Provide a way to get the raw NSTextAlternatives * for a given WebCore::DictationContext.

• Shared/EditorState.h:
• Shared/EditorState.cpp: (WebKit::EditorState::PostLayoutData::encode const): (WebKit::EditorState::PostLayoutData::decode):
• WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getPlatformEditorState const): Include a Vector<WebCore::DictationContext> as part of the EditorState that contains all of the WebCore::DictationContext that exist in the currently selected range (or the range of the word containing the cursor if nothing is selected).

• Platform/spi/ios/UIKitSPI.h:

Source/WebKitLegacy/mac:

• WebView/WebView.mm: (-[WebView _dictationAlternatives:]): Create a Vector<String> from the returned NSTextAlternatives * now that the member WebCore::AlternativeTextUIController::alternativesForContext returns it.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm: (InsertTextAlternatives.Simple):

• TestWebKitAPI/ios/UIKitSPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266554] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266218. rdar://problem/68168930

REGRESSION: touchbar controls don't reflect video state in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=215873
<rdar://problem/66723354>

Reviewed by Eric Carlson.

• platform/mac/WebPlaybackControlsManager.h:
• platform/mac/WebPlaybackControlsManager.mm: (-[WebPlaybackControlsManager setPlaying:]): (-[WebPlaybackControlsManager isPlaying]): Create an actual ivar _playing for holding the play/pause state. This is needed because AVTouchBarScrubber uses KVO to update the state of the play/pause button whenever the related video controller (in this case AVTouchBarPlaybackControlsControlling) changes using an NSValueBinding. KVO needs an actual ivar in order to function properly.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266553] by Alan Coon

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266156. rdar://problem/68168945

Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
​https://bugs.webkit.org/show_bug.cgi?id=215719
<rdar://problem/66411757>

Reviewed by Simon Fraser.

Source/WebCore:

While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
account so that scrolling matches their final positions.
e.g.

<div style="width: 100px; height: 100px;"></div>
<div style="position: relative; top: -20; width: 50px; height: 50px;"></div>

While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
by the layout geometry (where the 2 boxes are placed vertically after each other).

While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
as they are not stationary boxes.

Test: fast/css/scrollable-overflow-with-sticky-positioning.html

• rendering/RenderBox.cpp: (WebCore::RenderBox::layoutOverflowRectForPropagation const):

LayoutTests:

• fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
• fast/css/scrollable-overflow-with-sticky-positioning.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266552] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266144. rdar://problem/68168942

When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
​https://bugs.webkit.org/show_bug.cgi?id=215821

Reviewed by Eric Carlson.

We should ignore the request to paint the current video frame when we are using airplay.
It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
will block the web process for a long time if the video is airplaying.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266551] by Alan Coon

• 5 edits
  4 adds in branches/safari-610-branch

Cherry-pick r266158. rdar://problem/67812825

Web Share API Level 2 functions even when its experimental feature flag is disabled
​https://bugs.webkit.org/show_bug.cgi?id=215831
<rdar://problem/67760687>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/web-share/canShare-with-files-feature-disabled.html

fast/web-share/share-with-files-feature-disabled.html

We had a feature flag for Web Share API Level 2, but it isn't actually
consulted anywhere in the implementation.

• page/Navigator.cpp: (WebCore::Navigator::canShare): Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag.

(WebCore::Navigator::share):
Since canShare (per the spec) will return true if we have files and other content,
even if files are not shareable, check the feature flag again before loading the files.

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): If the Web Content process sends us files, but the Level 2 feature flag is disabled, something fishy is happening, so fire a MESSAGE_CHECK.

LayoutTests:

• fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/canShare-with-files-feature-disabled.html: Added.
• fast/web-share/share-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/share-with-files-feature-disabled.html: Added. Add some tests that ensure that disabling the feature actually works.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266550] by Alan Coon

• 8 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266151. rdar://problem/68168950

Web Share API can share non-HTTP(S) URLs
​https://bugs.webkit.org/show_bug.cgi?id=215823
<rdar://problem/62083130>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/web-share/share-disallows-file-urls.html

• page/Navigator.cpp: (WebCore::shareableURLForShareData): (WebCore::Navigator::canShare): (WebCore::Navigator::share): Factor out the code to complete and check the scheme of the URL. Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs.

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): Ensure that only HTTP family or data: URLs are shared.

LayoutTests:

• fast/web-share/share-disallows-file-urls-expected.txt: Added.
• fast/web-share/share-disallows-file-urls.html: Added.
• fast/web-share/share-transient-activation-expired.html:
• fast/web-share/share-transient-activation.html:
• fast/web-share/share.html: Add a test that ensures that sharing a non-HTTP-family URL fails, and fix the existing tests to share HTTP-family URLs.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266549] by Alan Coon

• 16 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266292. rdar://problem/67963525

Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results)
​https://bugs.webkit.org/show_bug.cgi?id=215641
<rdar://problem/67430532>

Reviewed by Tim Horton.
Source/WebCore:

There are two parts to this fix. First, findEnclosingScrollableContainer() needs
to use the same vertical-biasing delta fixup that we use in other places, to bias towards
vertical scrolling.

Second, when we've determined that the main frame should perform the scroll and dispatch
the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling
thread and and try to send the event to a scroller which we already know should not handle
it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from
that node.

Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html

• page/FrameView.cpp: (WebCore::FrameView::wheelEvent):
• page/mac/EventHandlerMac.mm: (WebCore::findEnclosingScrollableContainer):
• page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::handleWheelEvent):
• page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent): (WebCore::ScrollingTree::handleWheelEventWithNode):
• page/scrolling/ScrollingTree.h:
• page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):
• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/mac/ScrollingCoordinatorMac.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::handleWheelEvent):
• page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: (WebCore::ScrollingCoordinatorNicosia::handleWheelEvent):
• page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:

LayoutTests:

After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor
would get stuck with a "content scrolling" defer region, due to begin/end wheel
events not getting both sent to the iframe. But the test was actually broken; logging shows
that it reset latching state anyway, and it's not testing the shipping configuration of
async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid
rubber-banding, so that latching is not cleared due to elapsed time.

• fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
• fast/scrolling/latching/iframe-latch-small-deltas.html:
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added.
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266548] by Alan Coon

• 4 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266262. rdar://problem/67963581

Scrolling on select element doesn't work after scrolling the page
​https://bugs.webkit.org/show_bug.cgi?id=215900
Source/WebCore:

<rdar://problem/67766032>

Reviewed by Tim Horton.

The scrolling thread could use a node that was latched some time ago; we need to
check the freshness of the latched node before using it.

Test: fast/scrolling/latching/latching-stuck-to-main-page.html

• page/scrolling/ScrollingTreeLatchingController.cpp: (WebCore::ScrollingTreeLatchingController::receivedWheelEvent): (WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): (WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const):
• page/scrolling/ScrollingTreeLatchingController.h:

LayoutTests:

Reviewed by Tim Horton.

• fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added.
• fast/scrolling/latching/latching-stuck-to-main-page.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266547] by Alan Coon

• 7 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266248. rdar://problem/67963541

Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString
​https://bugs.webkit.org/show_bug.cgi?id=215892
<rdar://problem/67731156>

Reviewed by Tim Horton.

Source/WebCore:

While reverting the replaced string in Editor::changeBackToReplacedString, it's possible for text replacement
(Editor::replaceSelectionWithText) to cause the text checking paragraph range to become orphaned (if for no
reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to
expand the checking range to paragraph boundaries underneath TextCheckingParagraph::paragraphRange will result
in a null dereference, since the boundary points computed underneath the expandToParagraphBoundary helper will
be nullopt.

Mitigate this (and any other potentially similar crashes) by making expandToParagraphBoundary robust in the
case where expanding to the start and end fails, and just fall back to returning the original text checking
range instead.

Test: editing/mac/input/change-back-to-replaced-string.html

• editing/Editor.h:
• editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary):

See above for more details.

• testing/Internals.cpp: (WebCore::Internals::changeBackToReplacedString):
• testing/Internals.h:
• testing/Internals.idl:

Add a simple internal testing hook to change the currently selected text back to the given replaced string.

LayoutTests:

Add a layout test to exercise the crash.

• editing/mac/input/change-back-to-replaced-string-expected.txt: Added.
• editing/mac/input/change-back-to-replaced-string.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266546] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266240. rdar://problem/67963550

REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
​https://bugs.webkit.org/show_bug.cgi?id=215861

Reviewed by Eric Carlson.

Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
here without running the +instancesRespondToSelector: check.

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageScreenProperties):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266545] by Alan Coon

• 3 edits
  3 adds in branches/safari-610-branch

Cherry-pick r266239. rdar://problem/67963562

REGRESSION (r258215): Title preview movie isn't displayed at www.thismmalife.com
​https://bugs.webkit.org/show_bug.cgi?id=215774
<rdar://problem/67707957>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-as-img-output-pts.html

Use CMSampleBufferGetOutputPresentationTimeStamp() for sample PTS.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: (WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

LayoutTests:

• media/content/video-as-img.mp4: Added.
• media/video-as-img-output-pts-expected.txt: Added.
• media/video-as-img-output-pts.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266544] by Alan Coon

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266189. rdar://problem/68145721

Flickering on sedona.dev
​https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

• html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

• fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
• fast/canvas/webgl/compositing-without-drawing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266543] by Alan Coon

• 5 edits
  1 add in branches/safari-610-branch

Cherry-pick r266159. rdar://problem/67951883

[JSC] FTL should use m_origin instead of m_node->origin since m_node can be nullptr
​https://bugs.webkit.org/show_bug.cgi?id=215833

Reviewed by Mark Lam.

JSTests:

• stress/ftl-entry-osr-exit-has-nullptr-node.js: Added. (foo):

Source/JavaScriptCore:

While we are using m_node->origin, m_node can be nullptr (at the entry of the FTL function).
m_origin is always pointing appropriate origin. We should use it instead.

• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileToThis): (JSC::FTL::DFG::LowerDFGToB3::compileValueAdd): (JSC::FTL::DFG::LowerDFGToB3::compileValueSub): (JSC::FTL::DFG::LowerDFGToB3::compileValueMul): (JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC): (JSC::FTL::DFG::LowerDFGToB3::compileStrCat): (JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub): (JSC::FTL::DFG::LowerDFGToB3::compileArithClz32): (JSC::FTL::DFG::LowerDFGToB3::compileValueDiv): (JSC::FTL::DFG::LowerDFGToB3::compileValueMod): (JSC::FTL::DFG::LowerDFGToB3::compileArithAbs): (JSC::FTL::DFG::LowerDFGToB3::compileArithUnary): (JSC::FTL::DFG::LowerDFGToB3::compileValuePow): (JSC::FTL::DFG::LowerDFGToB3::compileArithRandom): (JSC::FTL::DFG::LowerDFGToB3::compileArithRound): (JSC::FTL::DFG::LowerDFGToB3::compileArithFloor): (JSC::FTL::DFG::LowerDFGToB3::compileArithCeil): (JSC::FTL::DFG::LowerDFGToB3::compileArithTrunc): (JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt): (JSC::FTL::DFG::LowerDFGToB3::compileArithFRound): (JSC::FTL::DFG::LowerDFGToB3::compileIncOrDec): (JSC::FTL::DFG::LowerDFGToB3::compileValueNegate): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitOr): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitRShift): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitLShift): (JSC::FTL::DFG::LowerDFGToB3::compileGetById): (JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis): (JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis): (JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis): (JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis): (JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite): (JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree): (JSC::FTL::DFG::LowerDFGToB3::compileDefineDataProperty): (JSC::FTL::DFG::LowerDFGToB3::compileDefineAccessorProperty): (JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage): (JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf): (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById): (JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById): (JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal): (JSC::FTL::DFG::LowerDFGToB3::compileDeleteById): (JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal): (JSC::FTL::DFG::LowerDFGToB3::compileArrayPush): (JSC::FTL::DFG::LowerDFGToB3::compileArraySlice): (JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf): (JSC::FTL::DFG::LowerDFGToB3::compileArrayPop): (JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope): (JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation): (JSC::FTL::DFG::LowerDFGToB3::compileNewFunction): (JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateArgumentsButterfly): (JSC::FTL::DFG::LowerDFGToB3::compileCreateRest): (JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames): (JSC::FTL::DFG::LowerDFGToB3::compileObjectCreate): (JSC::FTL::DFG::LowerDFGToB3::compileNewSymbol): (JSC::FTL::DFG::LowerDFGToB3::compileNewArray): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread): (JSC::FTL::DFG::LowerDFGToB3::compileCreateThis): (JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise): (JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject): (JSC::FTL::DFG::LowerDFGToB3::compileSpread): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize): (JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray): (JSC::FTL::DFG::LowerDFGToB3::compileToNumber): (JSC::FTL::DFG::LowerDFGToB3::compileToNumeric): (JSC::FTL::DFG::LowerDFGToB3::compileCallNumberConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf): (JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive): (JSC::FTL::DFG::LowerDFGToB3::compileToPropertyKey): (JSC::FTL::DFG::LowerDFGToB3::compileMakeRope): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt): (JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode): (JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset): (JSC::FTL::DFG::LowerDFGToB3::compileGetGlobalThis): (JSC::FTL::DFG::LowerDFGToB3::compileGetArgument): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): (JSC::FTL::DFG::LowerDFGToB3::compileSameValue): (JSC::FTL::DFG::LowerDFGToB3::compileCallEval): (JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength): (JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs): (JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs): (JSC::FTL::DFG::LowerDFGToB3::compileSwitch): (JSC::FTL::DFG::LowerDFGToB3::compileThrow): (JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError): (JSC::FTL::DFG::LowerDFGToB3::mapHashString): (JSC::FTL::DFG::LowerDFGToB3::compileMapHash): (JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket): (JSC::FTL::DFG::LowerDFGToB3::compileSetAdd): (JSC::FTL::DFG::LowerDFGToB3::compileMapSet): (JSC::FTL::DFG::LowerDFGToB3::compileTypeOfIsObject): (JSC::FTL::DFG::LowerDFGToB3::compileIsCallable): (JSC::FTL::DFG::LowerDFGToB3::compileIsConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileInByVal): (JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty): (JSC::FTL::DFG::LowerDFGToB3::compileParseInt): (JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom): (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty): (JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty): (JSC::FTL::DFG::LowerDFGToB3::compileHasStructurePropertyImpl): (JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname): (JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator): (JSC::FTL::DFG::LowerDFGToB3::compileToIndexString): (JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation): (JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps): (JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp): (JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName): (JSC::FTL::DFG::LowerDFGToB3::compileStringReplace): (JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail): (JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength): (JSC::FTL::DFG::LowerDFGToB3::getCurrentCallee): (JSC::FTL::DFG::LowerDFGToB3::getArgumentsStart): (JSC::FTL::DFG::LowerDFGToB3::compare): (JSC::FTL::DFG::LowerDFGToB3::compileStringSlice): (JSC::FTL::DFG::LowerDFGToB3::compileToLowerCase): (JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithRadix): (JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant): (JSC::FTL::DFG::LowerDFGToB3::compileResolveScopeForHoistingFuncDeclInEval): (JSC::FTL::DFG::LowerDFGToB3::compileResolveScope): (JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar): (JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar): (JSC::FTL::DFG::LowerDFGToB3::compileCallDOM): (JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter): (JSC::FTL::DFG::LowerDFGToB3::compileLoopHint): (JSC::FTL::DFG::LowerDFGToB3::genericJSValueCompare): (JSC::FTL::DFG::LowerDFGToB3::stringsEqual): (JSC::FTL::DFG::LowerDFGToB3::allocateJSArray): (JSC::FTL::DFG::LowerDFGToB3::boolify): (JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined): (JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds): (JSC::FTL::DFG::LowerDFGToB3::switchStringSlow): (JSC::FTL::DFG::LowerDFGToB3::buildTypeOf): (JSC::FTL::DFG::LowerDFGToB3::lazySlowPath): (JSC::FTL::DFG::LowerDFGToB3::masqueradesAsUndefinedWatchpointIsStillValid): (JSC::FTL::DFG::LowerDFGToB3::codeOriginDescriptionOfCallSite const): (JSC::FTL::DFG::LowerDFGToB3::callCheck): (JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):
• jsc.cpp: (runJSC):
• runtime/OptionsList.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:04 PM Changeset in webkit [266542] by commit-queue@webkit.org

• 11 edits
  8 adds in trunk

CoreImage Implementation of SourceGraphic and saturate(), hue-rotate(), grayscale() and sepia()
​https://bugs.webkit.org/show_bug.cgi?id=213673

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-09-03
Reviewed by Darin Adler, Simon Fraser.

Source/WebCore:

Tests: css3/filters/effect-grayscale-square.html

css3/filters/effect-hue-rotate-square.html
css3/filters/effect-saturate-square.html
css3/filters/effect-sepia-square.html

Added CoreImage implementation of SourceGraphic and partial of FEColorMatrix,
which is used to implement sepia(), grayscale() hue-rotate() and saturate().
Also added CIFilter caching, by storing CIFilters in a hash map, where the key
is the level of traversal (an integer).

• platform/graphics/coreimage/FilterEffectRendererCoreImage.h:

Imported FEColorMatrix.h and SourceGraphic.h; added function getCIContext()
that returns a static copy of CIContext.

• platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:

(WebCore::FilterEffectRendererCoreImage::getCIContext): Creating a

CIContext is expensive. Instead of creating a CIContext on each frame
update, we just use a static singleton on every draw

(WebCore::FilterEffectRendererCoreImage::supportsCoreImageRendering):

the function now returns true if the filter chain contains SourceGraphic
and FEColorMatrix of TYPE_MATRIX, TYPE_SATURATE and TYPE_HUEROTATE

(WebCore::FilterEffectRendererCoreImage::connectCIFilters):

Made slight changes to wrap Obj-C pointers in RetainPtr

(WebCore::FilterEffectRendererCoreImage::imageForSourceGraphic):

Use the source image to create a CIImage and return it. If the source image
is backed by IOSurface, we create a CIImage directly from the IOSurface; otherwise
we create a CIImage by getting the NativeImagePtr from source image.

(WebCore::FilterEffectRendererCoreImage::imageForFEColorMatrix):

Based on the type of the matrix and input parameter,
create different types of CIColorMatrix filers that are used to implement
sepia, grayscale, hue-rotate, saturate

(WebCore::FilterEffectRendererCoreImage::output const):

Added a logging line

(WebCore::FilterEffectRendererCoreImage::renderToImageBuffer):

Minor refactors

(WebCore::FilterEffectRendererCoreImage::clearResult):
(WebCore::FilterEffectRendererCoreImage::FilterEffectRendererCoreImage):

• platform/graphics/filters/FEColorMatrix.h:

(isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to FEColorMatrix

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::requestedRegionOfInputImageData const): removed

ASSERT(hasResult()); from the function, because CoreImage path wouldn't create
image buffers inside FilterEffect, but CI path still needs to consult this function
to obtain geometry info

• platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filterEffectClassType const): Made the function a const
(WebCore::FilterEffect::normalizedFloats): Changed this function to public since it is

consulted in FilterEffectCoreImageRenderer.

(WebCore::FilterEffect::filterEffectClassType): Deleted.

• platform/graphics/filters/SourceGraphic.h:

(isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to SourceGraphic

• rendering/CSSFilter.cpp:

(WebCore::CSSFilter::build):

Checks whether m_filterRenderer is already created, no need to re-create if the pointer
is non-null

(WebCore::CSSFilter::allocateBackingStoreIfNeeded):

If we are using m_filterRenderer, which is currently using CoreImage and relies on
IOSurfaces, we ask source image to use IOSurface for performance concerns.

LayoutTests:

• css3/filters/effect-grayscale-square-expected.html: Added.
• css3/filters/effect-grayscale-square.html: Added.
• css3/filters/effect-hue-rotate-square-expected.html: Added.
• css3/filters/effect-hue-rotate-square.html: Added.
• css3/filters/effect-saturate-square-expected.html: Added.
• css3/filters/effect-saturate-square.html: Added.
• css3/filters/effect-sepia-square-expected.html: Added.
• css3/filters/effect-sepia-square.html: Added.
• fast/filter-image/background-filter-image-expected.html:

This is the expected result for the background image filter. The background image
is not upsampled for retina screens due to a bug, so the test runner is comparing
an unscaled image with an upscaled-then-downscaled image. CoreImage handles upscaling
and downscaling differently, so the pixel diff will fail. Thus, turning off CI for this
particular test case until the background image filter not upsampling bug is fixed.

• fast/filter-image/background-filter-image.html:

ditto

1:54 PM Changeset in webkit [266541] by Chris Dumez

• 4 edits in trunk

BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies
​https://bugs.webkit.org/show_bug.cgi?id=216130

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:

Source/WebCore:

BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies.

No new tests, rebaselined existing test.

• platform/audio/Biquad.cpp:

(WebCore::Biquad::getFrequencyResponse):

1:43 PM Changeset in webkit [266540] by Lauro Moura

• 2 edits in trunk/Tools

[GTK][WPE] generate-bundle: Remove the zip extension from the uploaded checksum filename
​https://bugs.webkit.org/show_bug.cgi?id=216137

Reviewed by Jonathan Bedard.

• Scripts/generate-bundle:

1:32 PM Changeset in webkit [266539] by commit-queue@webkit.org

• 11 edits
  2 adds in trunk

Mark uniform samplers in an array unused per element
​https://bugs.webkit.org/show_bug.cgi?id=215630

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-09-03
Reviewed by Dean Jackson.

Mark uniform samplers in an uniform sampler array unused per
element, if driver informs the element being unused.
Before, one element would mark the whole array as being
unused, and samplers that were in use would not be updated.

Source/ThirdParty/ANGLE:

• src/libANGLE/Context.cpp:

(gl::StateCache::updateActiveImageUnitIndices):

• src/libANGLE/Program.cpp:

(gl::SamplerBinding::SamplerBinding):
(gl::ImageBinding::ImageBinding):
(gl::Program::getSamplerUniformBinding const):
(gl::Program::getImageUniformBinding const):
(gl::Program::linkSamplerAndImageBindings):
(gl::Program::updateSamplerUniform):
(gl::Program::serialize const):
(gl::Program::deserialize):

• src/libANGLE/ProgramExecutable.cpp:

(gl::ProgramExecutable::updateActiveSamplers):
(gl::ProgramExecutable::updateActiveImages):
(gl::ProgramExecutable::setSamplerUniformTextureTypeAndFormat):

• src/libANGLE/ProgramExecutable.h:
• src/libANGLE/renderer/gl/ProgramGL.cpp:

(rx::ProgramGL::markUnusedUniformLocations):

• src/libANGLE/renderer/metal/ProgramMtl.mm:

(rx::ProgramMtl::updateTextures):

• src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp:

(rx::ProgramExecutableVk::updateImagesDescriptorSet):
(rx::ProgramExecutableVk::updateTexturesDescriptorSet):

• src/tests/gl_tests/ComputeShaderTest.cpp:
• src/tests/gl_tests/UniformTest.cpp:

LayoutTests:

• fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt: Added.
• fast/canvas/webgl/glsl-sampler-array-unused-element.html: Added.

1:07 PM Changeset in webkit [266538] by Devin Rousso

• 24 edits
  7 adds in trunk

Web Inspector: allow url breakpoints to be configured
​https://bugs.webkit.org/show_bug.cgi?id=215793

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/DOMDebugger.json:

Add an options parameter to DOMDebugger.setURLBreakpoint to allow configuration.
Add an isRegex parameter to DOMDebugger.removeURLBreakpoint so that we know what
type of URL breakpoint is being removed.

Source/WebCore:

Tests: inspector/dom-debugger/url-breakpoints.html

inspector/dom-debugger/url-breakpoints-all-requests.html
inspector/dom-debugger/url-breakpoints-containing.html
inspector/dom-debugger/url-breakpoints-matching.html

• inspector/agents/InspectorDOMDebuggerAgent.h:
• inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::setURLBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeURLBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::breakOnURLIfNeeded):

Source/WebInspectorUI:

• UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint.get editable): Added.
(WI.URLBreakpoint.fromJSON):
(WI.URLBreakpoint.prototype.get editable):

• UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.initializeTarget):
(WI.DOMDebuggerManager.prototype.addURLBreakpoint):
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint):
(WI.DOMDebuggerManager.prototype._setURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._removeURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._handleURLBreakpointDisabledStateChanged):
(WI.DOMDebuggerManager.prototype._handleURLBreakpointEditablePropertyChanged): Added.
(WI.DOMDebuggerManager.prototype._handleURLBreakpointActionsChanged): Added.
(WI.DOMDebuggerManager.prototype._updateURLBreakpoint): Deleted.

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialBreakpoint): Added.
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialEventBreakpoint): Deleted.

• UserInterface/Views/URLBreakpointPopover.js:

(WI.URLBreakpointPopover.get editable):

• UserInterface/Base/Setting.js:

LayoutTests:

• inspector/debugger/resources/breakpoint-options-utilities.js:

(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases):

• inspector/dom-debugger/resources/url-breakpoint-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.URLBreakpoint.teardown):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.createBreakpoint):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.addBreakpoint):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.request):

• inspector/dom-debugger/url-breakpoints.html:
• inspector/dom-debugger/url-breakpoints-expected.txt:
• inspector/dom-debugger/url-breakpoints-all-requests.html: Added.
• inspector/dom-debugger/url-breakpoints-all-requests-expected.txt: Added.
• inspector/dom-debugger/url-breakpoints-containing.html: Added.
• inspector/dom-debugger/url-breakpoints-containing-expected.txt: Added.
• inspector/dom-debugger/url-breakpoints-matching.html: Added.
• inspector/dom-debugger/url-breakpoints-matching-expected.txt: Added.

Split the one URL breakpoint test into four so they run quicker.

• inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases): Deleted.

• inspector/dom-debugger/event-animation-frame-breakpoints.html:
• inspector/dom-debugger/event-animation-frame-breakpoints-expected.txt:
• inspector/dom-debugger/event-interval-breakpoints.html:
• inspector/dom-debugger/event-interval-breakpoints-expected.txt:
• inspector/dom-debugger/event-listener-breakpoints.html:
• inspector/dom-debugger/event-listener-breakpoints-expected.txt:
• inspector/dom-debugger/event-timeout-breakpoints.html:
• inspector/dom-debugger/event-timeout-breakpoints-expected.txt:

Use InspectorTest.BreakpointOptions.addTestCases instead of duplicating the logic.

12:17 PM Changeset in webkit [266537] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: record button disappears when UI is narrow
​https://bugs.webkit.org/show_bug.cgi?id=216133

Reviewed by Devin Rousso.

The record button is one of the most important items on Timelines toolbar.
It should always be visible.

• UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView):

11:42 AM Changeset in webkit [266536] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, reverting r266507.
​https://bugs.webkit.org/show_bug.cgi?id=216135

Broke JSC EWS

Reverted changeset:

"kill-old-processes: Remove stale Apache2 shm segments"
​https://bugs.webkit.org/show_bug.cgi?id=216068
​https://trac.webkit.org/changeset/266507

11:21 AM Changeset in webkit [266535] by achristensen@apple.com

• 1 edit
  1 delete in trunk/LayoutTests/imported/w3c

Remove unused test expectations file.

• web-platform-tests/encoding/textdecoder-labels-expected.txt: Removed.

10:53 AM Changeset in webkit [266534] by Devin Rousso

• 35 edits
  1 add in trunk

Web Inspector: allow special JavaScript breakpoints to be configured
​https://bugs.webkit.org/show_bug.cgi?id=215794

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/Debugger.json:

Add an options parameter to the following commands for configuring the related breakpoint:

• Debugger.setPauseOnDebuggerStatements
• Debugger.setPauseOnExceptions
• Debugger.setPauseOnAssertions
• Debugger.setPauseOnMicrotasks

• debugger/Debugger.h:

(JSC::Debugger::needsExceptionCallbacks const):
(JSC::Debugger::pauseOnAllExceptionsBreakpoint const): Added.
(JSC::Debugger::setPauseOnAllExceptionsBreakpoint): Added.
(JSC::Debugger::pauseOnUncaughtExceptionsBreakpoint const): Added.
(JSC::Debugger::setPauseOnUncaughtExceptionsBreakpoint): Added.
(JSC::Debugger::setPauseOnDebuggerStatementsBreakpoint): Added.
(JSC::Debugger::pauseOnExceptionsState const): Deleted.
(JSC::Debugger::setPauseOnDebuggerStatements): Deleted.

• debugger/Debugger.cpp:

(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::TemporarilyDisableExceptionBreakpoints): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::~TemporarilyDisableExceptionBreakpoints): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::replace): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::restore): Added.
(JSC::Debugger::Debugger):
(JSC::Debugger::breakProgram):
(JSC::Debugger::exception):
(JSC::Debugger::didReachDebuggerStatement):
(JSC::Debugger::setPauseOnExceptionsState): Deleted.
Add JSC::Breakpoint member variables for the Debugger Statements and Exceptions
breakpoints. Split the Exceptions breakpoint into two JSC::Breakpoint now that
All Exceptions and Uncaught Exceptions can be independently configured (the All
Exceptions breakpoint still takes precedence).

• debugger/DebuggerCallFrame.h:
• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
If there is no CallFrame, climb the backtrace until the first valid CallFrame is reached.
This is needed when pausing in native code, such as for assertions/exceptions.

• debugger/Breakpoint.h:

Export JSC::Breakpoint::create so that other parts of WebKit can create breakpoints.

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::handleConsoleAssert):
(Inspector::InspectorDebuggerAgent::setPauseOnDebuggerStatements):
(Inspector::InspectorDebuggerAgent::setPauseOnExceptions):
(Inspector::InspectorDebuggerAgent::setPauseOnAssertions):
(Inspector::InspectorDebuggerAgent::setPauseOnMicrotasks):
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):
(Inspector::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):
(Inspector::InspectorDebuggerAgent::willRunMicrotask):
(Inspector::InspectorDebuggerAgent::didRunMicrotask):
(Inspector::InspectorDebuggerAgent::breakProgram):
Add JSC::Breakpoint member variables for the Assertion Failures and All Microtasks
breakpoints. Pass them to the JSC::Debugger when they are hit.

• inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):
(Inspector::setPauseOnExceptionsState): Deleted.
Use TemporarilyDisableExceptionBreakpoints to save, override, and restore the exceptions
breakpoints now that they've been separated into two JSC::Breakpoint instead of an enum.

Source/WebInspectorUI:

• UserInterface/Models/Breakpoint.js:

(WI.Breakpoint.prototype.reset): Added.
Provide a way to consistently clear the current configuration.

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.supportsMicrotasks): Added.
(WI.JavaScriptBreakpoint.supportsDebuggerStatements): Added.
(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.toJSON):
(WI.JavaScriptBreakpoint.prototype.get editable):
(WI.JavaScriptBreakpoint.prototype._isSpecial):

• UserInterface/Models/SourceCodeLocation.js:

(WI.SourceCodeLocation.get specialBreakpointLocation): Added.
Add a helper for the special null:Infinity:Infinity breakpoint location for consistency.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.async initializeTarget):
(WI.DebuggerManager.prototype.createAssertionFailuresBreakpoint): Added.
(WI.DebuggerManager.prototype.createAllMicrotasksBreakpoint): Added.
(WI.DebuggerManager.prototype.set breakpointsEnabled):
(WI.DebuggerManager.prototype.addBreakpoint):
(WI.DebuggerManager.prototype.removeBreakpoint):
(WI.DebuggerManager.prototype._setPauseOnExceptions): Added.
(WI.DebuggerManager.prototype._createSpecialBreakpoint): Added.
(WI.DebuggerManager.prototype._updateSpecialBreakpoint): Added.
(WI.DebuggerManager.prototype._breakpointDisabledStateDidChange):
(WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
(WI.DebuggerManager.prototype._updateBreakOnExceptionsState): Deleted.
Maintain a WI.Setting for the configuration of each special WI.JavaScriptBreakpoint.
Have a common path for updating all special WI.JavaScriptBreakpoint to avoid duplicated
code.
Add methods for creating the Assertion Failures and All Microtasks WI.JavaScriptBreakpoint
since they can be removed (in addition to being disabled) and re-added.

• UserInterface/Views/BreakpointPopover.js:

(WI.BreakpointPopover.appendContextMenuItems):

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):
If the WI.Breakpoint is not removable, make sure to reset it in addition to disabling
it so that no configuration persists if the WI.Breakpoint is later enabled.

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointTreeOutlineElementRemoved): Added.
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved): Deleted.
Eliminate the need to listen for when breakpoints are added to the WI.TreeOutline, which
was previously used to update the WI.Setting for whether special WI.JavaScriptBreakpoint
are visible.
Don't assume that a WI.Breakpoint exists for each special WI.JavaScriptBreakpoint.

• UserInterface/Base/Setting.js:

(WI.Setting):
(WI.Setting.migrateValue):
(WI.Setting.reset):
(WI.Setting.prototype.get value):
(WI.Setting.prototype.save):
(WI.Setting._localStorageKeyPrefix): Added.
(WI.Setting._localStorageKey): Deleted.
Eagerly compute the key prefix as it shouldn't change through the lifetime of Web Inspector
and is used early on too.
Add a static member isFirstLaunch which can be used by other WI.Setting to adjust their
value when Web Inspector is in a clean state (e.g. show the Assertion Failures breakpoint by
default, but only for the first launch). This is needed because WI.Setting clears the key
from localStorage if the current value matches the _defaultValue.

• UserInterface/Models/ProbeSet.js:

(WI.ProbeSet):
(WI.ProbeSet.prototype.willRemove):
(WI.ProbeSet.prototype._sampleCollected):
(WI.ProbeSet.prototype._breakpointResolvedStateDidChange): Deleted.
Drive-by: remove an unused event.

• Localizations/en.lproj/localizedStrings.js:

Source/WebKitLegacy/mac:

• WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):

LayoutTests:

• inspector/debugger/resources/breakpoint-options-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases):
(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases.removeBreakpoint):

• inspector/debugger/break-on-exception.html:
• inspector/debugger/break-on-exception-expected.txt:
• inspector/debugger/break-on-uncaught-exception.html:
• inspector/debugger/break-on-uncaught-exception-expected.txt:
• inspector/debugger/setPauseOnAssertions.html:
• inspector/debugger/setPauseOnAssertions-expected.txt:
• inspector/debugger/setPauseOnDebuggerStatements.html:
• inspector/debugger/setPauseOnDebuggerStatements-expected.txt:
• inspector/debugger/setPauseOnMicrotasks.html:
• inspector/debugger/setPauseOnMicrotasks-expected.txt:

Add tests for global JavaScript breakpoint configuration options.

10:53 AM Changeset in webkit [266533] by achristensen@apple.com

• 11 edits
  1 delete in trunk

Implement TextEncoder's encodeInto()
​https://bugs.webkit.org/show_bug.cgi?id=193274

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/encodeInto.any-expected.txt:
• web-platform-tests/encoding/encodeInto.any.worker-expected.txt:
• web-platform-tests/encoding/idlharness-expected.txt: Removed.
• web-platform-tests/encoding/idlharness.any-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• bindings/js/JSDOMConvertBufferSource.h:

(WebCore::JSConverter<IDLUint8Array>::convertNewlyCreated):

• dom/TextEncoder.cpp:

(WebCore::TextEncoder::encodeInto):

• dom/TextEncoder.h:
• dom/TextEncoder.idl:

10:39 AM Changeset in webkit [266532] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Finish comment describing the various *Stack SSA nodes in DFG
​https://bugs.webkit.org/show_bug.cgi?id=216110

Reviewed by Sam Weinig.

• dfg/DFGNodeType.h:

10:22 AM Changeset in webkit [266531] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r237835): WebCore::TextDecorationThickness constructor fails to initialize m_length
<​https://webkit.org/b/216092>

Reviewed by Tim Horton.

• rendering/style/TextDecorationThickness.h:

(WebCore::TextDecorationThickness):

• Add default initializer for m_length.

10:20 AM Changeset in webkit [266530] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

AbstractMacroAssembler::Jump class has uninitialized instance variables
<​https://webkit.org/b/216082>

Reviewed by Michael Saboff.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump):

• Switch to default constructor syntax.
• Provide defaults for instance variables.

10:04 AM Changeset in webkit [266529] by Ross Kirsling

• 19 edits
  1 add in trunk

[JSC] Add missing detached buffer errors for DataView
​https://bugs.webkit.org/show_bug.cgi?id=216062

Reviewed by Yusuke Suzuki.

JSTests:

• stress/detached-buffer-typeerror.js:

Add new test.

• stress/dataview-jit-neuter.js:
• stress/native-constructors-length.js:

Update existing tests.

• test262/expectations.yaml:

Mark 74 test cases as passing.

Source/JavaScriptCore:

DataView methods are often expected to throw a TypeError if the underlying ArrayBuffer is detached
(or neutered, in older terminology) -- this patch adds a slew of missing cases from the following spec section:

• ​https://tc39.es/ecma262/#sec-properties-of-the-dataview-prototype-object

At the same time:

• get rid of JSDataView::getOwnPropertySlot, which was turning dataViewProtoGetterByte{Length,Offset} into mostly unreachable code and erroneously causing byte{Length,Offset} to have property descriptors
• perform some simple cleanup of neighboring error calls / messages
• fix value of DataView.length (our only other DataView spec bug)

• runtime/JSDataView.cpp:

(JSC::JSDataView::create):
(JSC::JSDataView::getOwnPropertySlot): Deleted.

• runtime/JSDataView.h:
• runtime/JSDataViewPrototype.cpp:

(JSC::getData):
(JSC::setData):
(JSC::dataViewProtoGetterByteLength):
(JSC::dataViewProtoGetterByteOffset):

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):

LayoutTests:

• fast/canvas/webgl/arraybuffer-transfer-of-control.html:
• js/dom/constructor-length.html:
• js/script-tests/typedarray-constructors.js:
• js/typedarray-constructors-expected.txt:
• platform/glib/js/dom/constructor-length-expected.txt:
• platform/ios/js/dom/constructor-length-expected.txt:
• platform/mac/js/dom/constructor-length-expected.txt:
• platform/win/js/dom/constructor-length-expected.txt:
• platform/wincairo/js/dom/constructor-length-expected.txt:

Update tests and expectations.

9:57 AM Changeset in webkit [266528] by achristensen@apple.com

• 10 edits in trunk

TextDecoder should ignore byte-order-mark like other browsers and spec
​https://bugs.webkit.org/show_bug.cgi?id=216108

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/streams/decode-ignore-bom.any-expected.txt:
• web-platform-tests/encoding/textdecoder-ignorebom.any-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• dom/TextDecoder.cpp:

(WebCore::TextDecoder::ignoreBOMIfNecessary):
(WebCore::TextDecoder::decode):
(WebCore::TextDecoder::prependBOMIfNecessary): Deleted.

• dom/TextDecoder.h:

9:33 AM Changeset in webkit [266527] by achristensen@apple.com

• 18 edits
  2 adds in trunk

Align ISO-8859-{3,6,7,8,8-I} and windows-{874,1253,1255,1257} encodings with Chrome, Firefox, and the specification
​https://bugs.webkit.org/show_bug.cgi?id=216094

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/single-byte-decoder-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-single-byte.any-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/text/TextCodec.h:
• platform/text/TextCodecCJK.cpp:

(WebCore::Function<void):

• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerCodecs):

• platform/text/TextCodecSingleByte.cpp: Added.

(WebCore::tableForDecoding):
(WebCore::tableForEncoding):
(WebCore::TextCodecSingleByte::encode):
(WebCore::TextCodecSingleByte::decode):
(WebCore::TextCodecSingleByte::TextCodecSingleByte):
(WebCore::TextCodecSingleByte::registerEncodingNames):
(WebCore::TextCodecSingleByte::registerCodecs):

• platform/text/TextCodecSingleByte.h: Copied from Source/WebCore/platform/text/TextCodec.h.

LayoutTests:

• fast/encoding/char-decoding-expected.txt:
• fast/encoding/char-decoding.html:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

9:31 AM Changeset in webkit [266526] by graouts@webkit.org

• 4 edits
  2 adds in trunk

Consecutive requestAnimationFrame callbacks may be passed the same timestamp
​https://bugs.webkit.org/show_bug.cgi?id=216122
<rdar://problem/68269445>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/animation/request-animation-frame-unique-timestamp.html

Ensure that the page only sees increasing timestamps in requestAnimationFrame() callbacks.

• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::shouldRescheduleRequestAnimationFrame const):

LayoutTests:

Add a test that two subsequent animation frames as identified via requestAnimationFrame() callbacks
are provided increasing timestamps.

Also removing flaky expectation for two WPT animations tests which pass reliably after this fix.

• fast/animation/request-animation-frame-unique-timestamp-expected.txt: Added.
• fast/animation/request-animation-frame-unique-timestamp.html: Added.
• platform/mac-wk2/TestExpectations:

9:28 AM Changeset in webkit [266525] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION(r266466): [ iOS wk2 ] fast/encoding/charset-replacement.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216126

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

9:28 AM Changeset in webkit [266524] by Aditya Keerthi

• 10 edits in trunk

[macOS] Support stepping using keyboard in date inputs
​https://bugs.webkit.org/show_bug.cgi?id=216090

Reviewed by Darin Adler.

Source/WebCore:

Users should be able to step through dates using the up and down arrow
keys, matching the functionality of NSDatePicker. To achieve this
functionality, stepUp and stepDown methods were added to
DateTimeFieldElement, incrementing and decrementing the value of the
focused field on an up arrow keypress and a down arrow keypress
respectively. If the currently focused field is empty during the
keypress, stepping up will start from the minimum value and stepping
down will start from the maximum value.

Covered by a new test case in an existing test file.

• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):

• html/shadow/DateTimeFieldElement.h:
• html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::setValueAsIntegerByStepping):
(WebCore::DateTimeNumericFieldElement::stepDown):
(WebCore::DateTimeNumericFieldElement::stepUp):

• html/shadow/DateTimeNumericFieldElement.h:
• html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::stepDown):
(WebCore::DateTimeSymbolicFieldElement::stepUp):

• html/shadow/DateTimeSymbolicFieldElement.h:

LayoutTests:

Added a new test case to the existing set of keyboard testcases for editable date inputs.

• fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:

9:27 AM Changeset in webkit [266523] by weinig@apple.com

• 78 edits
  1 move
  2 adds in trunk/Source/WebCore

Update WebIDL parser to more closely align with current WebIDL spec
​https://bugs.webkit.org/show_bug.cgi?id=216089

Reviewed by Chris Dumez.

Major changes are:

• 'implements' keyword is now called 'includes' (this is the only observable change).
• Added support for parsing namespaces, async iterable, partial mixins and ObservableArray, though the code generators don't support them yet, so they just clearly error out.
• Update list of keywords that can be used as argument names.
• Update parser to use the current terminology from WebIDL.
• Added more comments to be clear what next steps to take such as removing legacy constructs like serializer, exception, legacycaller and moving synthetic operation additions from the parser to the code generators.

• Modules/fetch/FetchRequest.idl:
• Modules/fetch/FetchResponse.idl:
• bindings/scripts/IDLParser.pm:

(Parse):
(applyTypedefs):
(parseDefinition):
(parseCallbackOrInterfaceOrMixin):
(parseCallbackRestOrInterface):
(parseInterfaceOrMixin):
(parseInterface):
(parseNamespace):
(parseNamespaceMembers):
(parseNamespaceMember):
(parsePartialDefinition):
(parsePartialInterfaceOrPartialMixin):
(parsePartialInterface):
(parsePartialInterfaceMembers):
(parsePartialInterfaceMember):
(parseInterfaceMember):
(parsePartialDictionary):
(parseIncludesStatement):
(parseInheritAttribute):
(parseOperation):
(parseRegularOperation):
(parseSpecial):
(parseAsyncIterable):
(parseOptionalIterableInterface):
(parseArgumentNameKeyword):
(parseDistinguishableType):
(parseConstType):
(parsePrimitiveType):
(applyMemberList):
(parseCallbackOrInterface): Deleted.
(parseImplementsStatement): Deleted.
(parseOperationOrReadWriteAttributeOrMaplike): Deleted.
(parseReadWriteAttribute): Deleted.
(parseInherit): Deleted.

• bindings/scripts/preprocess-idls.pl:

(getIncludedInterfacesFromIDL):
(getImplementedInterfacesFromIDL): Deleted.

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::jsTestInterfaceConstructorIncludesStaticReadOnlyAttrGetter):
(WebCore::jsTestInterfaceConstructorIncludesStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorIncludesStaticAttrGetter):
(WebCore::jsTestInterfaceConstructorIncludesStaticAttr):
(WebCore::setJSTestInterfaceConstructorIncludesStaticAttrSetter):
(WebCore::setJSTestInterfaceConstructorIncludesStaticAttr):
(WebCore::jsTestInterfaceIncludesStr1Getter):
(WebCore::jsTestInterfaceIncludesStr1):
(WebCore::jsTestInterfaceIncludesStr2Getter):
(WebCore::jsTestInterfaceIncludesStr2):
(WebCore::setJSTestInterfaceIncludesStr2Setter):
(WebCore::setJSTestInterfaceIncludesStr2):
(WebCore::jsTestInterfaceIncludesStr3Getter):
(WebCore::jsTestInterfaceIncludesStr3):
(WebCore::setJSTestInterfaceIncludesStr3Setter):
(WebCore::setJSTestInterfaceIncludesStr3):
(WebCore::jsTestInterfaceIncludesNodeGetter):
(WebCore::jsTestInterfaceIncludesNode):
(WebCore::setJSTestInterfaceIncludesNodeSetter):
(WebCore::setJSTestInterfaceIncludesNode):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod1Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod1):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod2Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod2):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod3Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod3):
(WebCore::jsTestInterfaceConstructorFunctionIncludesMethod4Body):
(WebCore::jsTestInterfaceConstructorFunctionIncludesMethod4):
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttrGetter): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticAttrGetter): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr): Deleted.
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttrSetter): Deleted.
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr): Deleted.
(WebCore::jsTestInterfaceImplementsStr1Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr1): Deleted.
(WebCore::jsTestInterfaceImplementsStr2Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr2): Deleted.
(WebCore::setJSTestInterfaceImplementsStr2Setter): Deleted.
(WebCore::setJSTestInterfaceImplementsStr2): Deleted.
(WebCore::jsTestInterfaceImplementsStr3Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr3): Deleted.
(WebCore::setJSTestInterfaceImplementsStr3Setter): Deleted.
(WebCore::setJSTestInterfaceImplementsStr3): Deleted.
(WebCore::jsTestInterfaceImplementsNodeGetter): Deleted.
(WebCore::jsTestInterfaceImplementsNode): Deleted.
(WebCore::setJSTestInterfaceImplementsNodeSetter): Deleted.
(WebCore::setJSTestInterfaceImplementsNode): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4Body): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4): Deleted.

• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/SupplementalDependencies.dep:
• bindings/scripts/test/TestImplements.idl: Removed.
• bindings/scripts/test/TestIncludes.idl: Copied from Source/WebCore/bindings/scripts/test/TestImplements.idl.
• bindings/scripts/test/TestInterface.idl:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestOperationConditional.idl:
• dom/CharacterData.idl:
• dom/DeviceMotionEvent.idl:
• dom/DeviceOrientationEvent.idl:
• dom/Document.idl:
• dom/DocumentFragment.idl:
• dom/DocumentType.idl:
• dom/Element.idl:
• dom/ShadowRoot.idl:
• dom/Text.idl:
• html/HTMLAnchorElement.idl:
• html/HTMLAreaElement.idl:
• html/HTMLBodyElement.idl:
• html/HTMLElement.idl:
• html/HTMLFrameSetElement.idl:
• html/canvas/CanvasRenderingContext2D.idl:
• html/canvas/OffscreenCanvasRenderingContext2D.idl:
• html/canvas/PaintRenderingContext2D.idl:
• html/canvas/Path2D.idl:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLRenderingContext.idl:
• page/DOMWindow.idl:
• page/Navigator.idl:
• page/WorkerNavigator.idl:
• svg/SVGAElement.idl:
• svg/SVGAltGlyphElement.idl:
• svg/SVGAnimationElement.idl:
• svg/SVGCursorElement.idl:
• svg/SVGElement.idl:
• svg/SVGFEBlendElement.idl:
• svg/SVGFEColorMatrixElement.idl:
• svg/SVGFEComponentTransferElement.idl:
• svg/SVGFECompositeElement.idl:
• svg/SVGFEConvolveMatrixElement.idl:
• svg/SVGFEDiffuseLightingElement.idl:
• svg/SVGFEDisplacementMapElement.idl:
• svg/SVGFEDropShadowElement.idl:
• svg/SVGFEFloodElement.idl:
• svg/SVGFEGaussianBlurElement.idl:
• svg/SVGFEImageElement.idl:
• svg/SVGFEMergeElement.idl:
• svg/SVGFEMorphologyElement.idl:
• svg/SVGFEOffsetElement.idl:
• svg/SVGFESpecularLightingElement.idl:
• svg/SVGFETileElement.idl:
• svg/SVGFETurbulenceElement.idl:
• svg/SVGFilterElement.idl:
• svg/SVGGlyphRefElement.idl:
• svg/SVGGradientElement.idl:
• svg/SVGGraphicsElement.idl:
• svg/SVGImageElement.idl:
• svg/SVGMPathElement.idl:
• svg/SVGMarkerElement.idl:
• svg/SVGMaskElement.idl:
• svg/SVGPatternElement.idl:
• svg/SVGSVGElement.idl:
• svg/SVGScriptElement.idl:
• svg/SVGSymbolElement.idl:
• svg/SVGTRefElement.idl:
• svg/SVGTextPathElement.idl:
• svg/SVGUseElement.idl:
• svg/SVGViewElement.idl:
• svg/SVGViewSpec.idl:
• workers/Worker.idl:
• workers/WorkerGlobalScope.idl:
• workers/service/ServiceWorker.idl:

9:14 AM Changeset in webkit [266522] by achristensen@apple.com

• 1 edit
  1 copy in trunk/LayoutTests

Rebase Windows test expectations after r266466

9:11 AM Changeset in webkit [266521] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

Rebase iOS test results after r266399
​https://bugs.webkit.org/show_bug.cgi?id=216022

• platform/ios/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt:

9:06 AM Changeset in webkit [266520] by achristensen@apple.com

• 12 edits in trunk

Align EUC-KR encoding with Chrome, Firefox, and specification
​https://bugs.webkit.org/show_bug.cgi?id=216081

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-errors-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-misc-expected.txt:

Source/WebCore:

Covered by web platform tests.

• platform/text/EncodingTables.cpp:
• platform/text/EncodingTables.h:
• platform/text/TextCodecCJK.cpp:

(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucKREncodingIndex):
(WebCore::eucKREncode):
(WebCore::TextCodecCJK::eucKRDecode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode):

• platform/text/TextCodecCJK.h:
• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerCodecs):

9:05 AM Changeset in webkit [266519] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION(266399?): [ iOS wk2 ] imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216124

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

8:33 AM Changeset in webkit [266518] by Chris Dumez

• 11 edits in trunk

Make our implementation of ChannelMergerNode standards compliant
​https://bugs.webkit.org/show_bug.cgi?id=216113

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that they are passing.

• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-non-default-expected.txt:

Source/WebCore:

This aligns our implementation of ChannelMergerNode with Chromium's, allowing us
to pass more web platform tests.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):
(WebCore::AudioNode::disableOutputs):

• Modules/webaudio/AudioNode.h:

Split disableOutputs() out of disableOutputsIfNecessary() so that it can be called
directly.

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::connect):

• Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::isEnabled const):
When connected to an output, AudioNodeInput keeps the output either in m_outputs when
the output is enabled, m_disabledOutputs when it is disabled. AudioNodeInput's enable()
& disable() take care of moving the output from one map to another. However, connect()
would assume that the output we're connecting to is enabled and add it to m_outputs
unconditionally. This was causing an assertion to get hit in enable() later on because
the output we're trying to enable was not in m_disabledOutputs (because it was already
in m_outputs). This change is needed because the ChannelMergerNode now disables its
output right away, before it is connected.

• Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::ChannelMergerNode):
Make sure that the output has a number of channels equal to the number of inputs.
Initially disable outputs so that we output a single silent channel until something
is connected.

(WebCore::ChannelMergerNode::process):

• Modules/webaudio/ChannelMergerNode.h:

Simplify code now that the number of inputs is equal to output's number of channels.

8:29 AM Changeset in webkit [266517] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Use unicode macros instead of manual range checks in TextCodecUTF16
​https://bugs.webkit.org/show_bug.cgi?id=216098

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-03
Reviewed by Darin Adler.

No change in behavior. Just responding to feedback from bug 216058.

• platform/text/TextCodecSingleByte.cpp: Added.

(WebCore::tableForDecoding):
(WebCore::tableForEncoding):
(WebCore::TextCodecSingleByte::encode):
(WebCore::TextCodecSingleByte::decode):
(WebCore::TextCodecSingleByte::TextCodecSingleByte):
(WebCore::TextCodecSingleByte::registerEncodingNames):
(WebCore::TextCodecSingleByte::registerCodecs):

• platform/text/TextCodecSingleByte.h: Added.
• platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

7:56 AM Changeset in webkit [266516] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][IFC] Add support for vertical-align: text-bottom
​https://bugs.webkit.org/show_bug.cgi?id=215538
<rdar://problem/67613372>

Reviewed by Antti Koivisto.

Source/WebCore:

See ​https://www.w3.org/TR/css-inline-3/#propdef-alignment-baseline
(align with the baseline + descent of the parent inline box)

Test: fast/layoutformattingcontext/vertical-align-bottom-nested.html

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

LayoutTests:

• fast/layoutformattingcontext/vertical-align-bottom-nested-expected.html: Added.
• fast/layoutformattingcontext/vertical-align-bottom-nested.html: Added.

7:51 AM Changeset in webkit [266515] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][IFC] Add support for vertical-align: text-top
​https://bugs.webkit.org/show_bug.cgi?id=215545
<rdar://problem/67629969>

Reviewed by Antti Koivisto.

Source/WebCore:

See ​https://www.w3.org/TR/css-inline-3/#propdef-alignment-baseline
(align with the baseline + ascent of the parent inline box)

Test: fast/layoutformattingcontext/vertical-align-top-nested.html

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

LayoutTests:

• fast/layoutformattingcontext/vertical-align-top-nested-expected.html: Added.
• fast/layoutformattingcontext/vertical-align-top-nested.html: Added.

7:40 AM Changeset in webkit [266514] by Aditya Keerthi

• 15 edits in trunk

[macOS] Add disabled and readonly behaviors to date inputs
​https://bugs.webkit.org/show_bug.cgi?id=216005

Reviewed by Devin Rousso.

Source/WebCore:

Added methods to EditControlOwner and FieldOwner so that
DateTimeEditElement and DateTimeFieldElement are aware of the readonly
and disabled states of their containing element.

Disabled inputs should not be focusable and should not respond to any
keyboard events. On the other hand, readonly inputs should respond to
some keyboard events (such as left arrow, right arrow, and the tab
key), but should not be editable.

• css/html.css: Updated to add GrayText color for disabled fields.

(input[disabled]::-webkit-datetime-edit-year-field,):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::isEditControlOwnerDisabled const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::isEditControlOwnerReadOnly const):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::isFieldOwnerDisabled const):
(WebCore::DateTimeEditElement::isFieldOwnerReadOnly const):

• html/shadow/DateTimeEditElement.h:
• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):

If the owning element is disabled or readonly, elide a call to
handleKeyboardEvent, which is implemented by subclasses to achieve
editability.

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Disabled inputs should not respond to any events.
(WebCore::DateTimeFieldElement::isFieldOwnerDisabled const):
(WebCore::DateTimeFieldElement::isFieldOwnerReadOnly const):
(WebCore::DateTimeFieldElement::isFocusable const): Disabled inputs should not be focusable.

• html/shadow/DateTimeFieldElement.h:

LayoutTests:

Added tests for disabled and readonly date inputs in existing test files.

• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html:
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:
• fast/forms/date/date-editable-components/date-editable-components-mouse-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-mouse-events.html:

7:20 AM Changeset in webkit [266513] by Wenson Hsieh

• 3 edits in trunk/Source/WebCore

Make TransformationMatrix::inverse() faster in the case of affine transformation matrices
​https://bugs.webkit.org/show_bug.cgi?id=216101

Reviewed by Tim Horton.

The Multiply subtest of MotionMark places a large number of elements that are all rotated by some angle; when
painting these, we currently spend about 7% of the time under RenderLayer::paintLayerByApplyingTransform just
inverting the transformation matrix (underneath TransformationMatrix::inverse()) so that we can map the bounds
of the dirty rect through this inverse.

TransformationMatrix::inverse() currently has a fast path for identity and translation matrices that avoids
having to fall back to the generalized 4-by-4 matrix inverse equation; this generalized algorithm works by
dividing the entire adjoint matrix by the determinant, a process that involves nearly 1000 floating point
additions and multiplications.

However, in this case, all of the matrices are a combination of translations and rotations, which all result in
affine transformations. As such, there's no need to fall back to the generalized algorithm for computing the
inverse; instead, we can bail early with simpler strategy that only requires 15 floating point additions and
multiplications.

We can also take advantange of the fact that we currently go through most of the entries in the 4x4 matrix to
determine whether the matrix is an identity or translation matrix, by introducing a new helper method that
returns not only whether the matrix is the identity matrix or translation, but also whether the matrix is affine
(by the definition of TransformationMatrix::isAffine()). Since most of the entries that need to be 1 or 0 in
order for a matrix to be a translation matrix vs. just an affine transformation matrix are the same, this helps
avoid some redundant checks in TransformationMatrix::inverse().

We also apply a similar optimization to TransformationMatrix::isInvertible(), reducing the multiplications and
additions from roughly 200 to just 3.

I measured this locally to be a (statistically significant) 2% improvement on Multiply.

• platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::isInvertible const):
(WebCore::TransformationMatrix::inverse const):

• platform/graphics/transforms/TransformationMatrix.h:

(WebCore::TransformationMatrix::type const):

7:19 AM Changeset in webkit [266512] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Mark more convolver related tests as flaky crash.

• platform/gtk/TestExpectations:

6:24 AM Changeset in webkit [266511] by youenn@apple.com

• 14 edits in trunk

Expose RTCPeerConnection.restartIce
​https://bugs.webkit.org/show_bug.cgi?id=216072

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-restartIce.https-expected.txt:
• web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Add plubming code to expose restartIce.
Covered by rebased test.

• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::restartIce):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::restartIce):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

LayoutTests:

• TestExpectations:

4:22 AM Changeset in webkit [266510] by Alan Bujtas

• 5 edits
  4 adds in trunk

Source/WebCore:
[LFC][IFC] Add support nested inline box sizing and positioning
​https://bugs.webkit.org/show_bug.cgi?id=215748

Reviewed by Antti Koivisto.

This patch splits the line box construction process into a few distinct steps.

1. Construct the inline boxes as needed. There's always a root inline box.
2. Size them by taking the vertical alignment into account
   • child inline boxes stretch their parent inline boxes in most cases (depending on the vertical-align property value).
3. Position the inline boxes relative to the line box.

Test: fast/layoutformattingcontext/vertical-align-middle-nested.html

fast/layoutformattingcontext/vertical-align-middle-simple.html

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::m_inlineFormattingContext):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineHeight):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const): Deleted.
(WebCore::Layout::LineBox::alignVertically): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::setLogicalTop):
(WebCore::Layout::LineBox::InlineBox::setLogicalWidth):
(WebCore::Layout::LineBox::InlineBox::setLogicalHeight):
(WebCore::Layout::LineBox::InlineBox::setBaseline):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox):

LayoutTests:
[LFC][IFC] Fix nested inline box sizing and positioning
​https://bugs.webkit.org/show_bug.cgi?id=215748

Reviewed by Antti Koivisto.

• fast/layoutformattingcontext/vertical-align-middle-nested-expected.html:
• fast/layoutformattingcontext/vertical-align-middle-nested.html:
• fast/layoutformattingcontext/vertical-align-middle-simple-expected.html:
• fast/layoutformattingcontext/vertical-align-middle-simple.html:

3:15 AM Changeset in webkit [266509] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

[LFC][IFC] Finalize InlineBox alignment in LineBox
​https://bugs.webkit.org/show_bug.cgi?id=215410

Reviewed by Antti Koivisto.

This patch completes the InlineBox transition.

LineBox now has a dedicated root inline box and additional inline boxes as needed.
Both horizontal and vertical alignments are performed on the inline boxes as opposed to on the runs.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::initialLineHeight const):

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::collectHangingContent):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::halfLeadingMetrics):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_inlineFormattingContext):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::alignVertically):
(WebCore::Layout::LineBox::rectForRun const): Deleted.
(WebCore::Layout::LineBox::alignHorizontally): Deleted.
(WebCore::Layout::LineBox::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineBox::collectHangingContent const): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::AscentAndDescent::height const):
(WebCore::Layout::LineBox::InlineBox::logicalRect const):
(WebCore::Layout::LineBox::InlineBox::logicalTop const):
(WebCore::Layout::LineBox::InlineBox::logicalLeft const):
(WebCore::Layout::LineBox::InlineBox::logicalWidth const):
(WebCore::Layout::LineBox::InlineBox::logicalHeight const):
(WebCore::Layout::LineBox::InlineBox::baseline const):
(WebCore::Layout::LineBox::InlineBox::descent const):
(WebCore::Layout::LineBox::InlineBox::setLogicalTop):
(WebCore::Layout::LineBox::InlineBox::setLogicalWidth):
(WebCore::Layout::LineBox::InlineBox::isAtomicInlineLevelBox const):
(WebCore::Layout::LineBox::InlineBox::setHasStrut):
(WebCore::Layout::LineBox::InlineBox::hasStrut const):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::AscentAndDescent::height const): Deleted.
(WebCore::Layout::LineBox::ascentAndDescent const): Deleted.
(WebCore::Layout::LineBox::setScrollableOverflow): Deleted.
(WebCore::Layout::LineBox::InlineBox::InlineBox): Deleted.
(WebCore::Layout::LineBox::setLogicalHeightIfGreater): Deleted.
(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater): Deleted.
(WebCore::Layout::LineBox::setAscentIfGreater): Deleted.
(WebCore::Layout::LineBox::setDescentIfGreater): Deleted.
(WebCore::Layout::LineBox::halfLeadingMetrics): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::Run::logicalRight const):

1:38 AM Changeset in webkit [266508] by youenn@apple.com

• 6 edits in trunk

calling transceiver setCodecPreferences doesn't change the order of codecs in the offer/answer generated by the browser
​https://bugs.webkit.org/show_bug.cgi?id=215567
<rdar://problem/67277554>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences-expected.txt:
• web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences.html:

Source/WebCore:

Make sure to serialize sdpFmtp information so that setCodecPreferences succeeds.
Also make sure to throw the exception if there is any.

Covered by updated imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences.html.

• Modules/mediastream/RTCRtpTransceiver.idl:
• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::toRTCRtpCapabilities):

1:07 AM Changeset in webkit [266507] by Diego Pino Garcia

• 2 edits in trunk/Tools

kill-old-processes: Remove stale Apache2 shm segments
​https://bugs.webkit.org/show_bug.cgi?id=216068

Reviewed by Alexey Proskuryakov.

When Apache2 terminates abruptely, it may not free up allocated shared
memory segments. When later Apache2 is started again, if its pid
matches the pid of orphan shm segments it fails believing there's
already an Apache2 instance running. To avoid this situation, after
killing Apache2 we check for potential conflicting shm segments and
remove them.

• BuildSlaveSupport/kill-old-processes:

(listAllWebKitPrograms):
(removeOrphanShmSegmentsOf):
(removeShmSegments):
(removeShmSegment):
(cmd):
(allShmSegments):
(main):

12:48 AM Changeset in webkit [266506] by rniwa@webkit.org

• 2 edits in trunk/Tools

Static assert the return type of compactMap
​https://bugs.webkit.org/show_bug.cgi?id=216119

Reviewed by Darin Adler.

Added static_assert for the return types of compactMap in varoius unit tests.

(WTF_Vector.CompactMapStaticFunctionReturnOptional):
(WTF_Vector.CompactMapStaticFunctionReturnRefPtr):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRef):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRefPtr):
(WTF_Vector.CompactMapLambdaReturnOptional):
(WTF_Vector.CompactMapLambdaCopyVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaMoveVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaReturnRefPtr):
(WTF_Vector.CompactMapLambdaReturnRefPtrFromMovedRef):
(WTF_Vector.CompactMapLambdaReturnOptionalRefPtr):

Sep 2, 2020:

11:20 PM Writing testharness Tests edited by Fujii Hironori

(diff)

10:51 PM Changeset in webkit [266505] by achristensen@apple.com

• 1 edit
  2 deletes in trunk/LayoutTests/imported/w3c

Remove some unused old expectations files

• web-platform-tests/encoding/textdecoder-fatal-single-byte-expected.txt: Removed.
• web-platform-tests/encoding/textdecoder-utf16-surrogates-expected.txt: Removed.

10:27 PM Changeset in webkit [266504] by achristensen@apple.com

• 1 edit
  1 copy in trunk/LayoutTests

Rebase Windows test expectations after r266466
​https://bugs.webkit.org/show_bug.cgi?id=216063

• platform/win/fast/encoding/charset-replacement-expected.txt: Copied from fast/encoding/charset-replacement-expected.txt.

A document with just one replacement character is 2 pixels different on Windows.

10:24 PM Changeset in webkit [266503] by ysuzuki@apple.com

• 8 edits
  1 copy
  4 adds in trunk/JSTests

[JSC] Update test262
​https://bugs.webkit.org/show_bug.cgi?id=216116

Reviewed by Ross Kirsling.

Rebaseline test262.

• test262/expectations.yaml:
• test262/harness/compareArray.js:

(assert.compareArray):

• test262/harness/testIntl.js:

(regExpPropertiesDefaultValues):

• test262/latest-changes-summary.txt:
• test262/test/annexB/language/expressions/object/proto-poisoned-object-prototype.js: Added.
• test262/test/built-ins/Array/prototype/push/length-near-integer-limit-set-failure.js: Added.
• test262/test/built-ins/Object/defineProperty/redefine-length-with-various-values-and-configurable-true.js: Added.
• test262/test/harness/compare-array-falsy-arguments.js: Added.

(assertThrows):

• test262/test/intl402/DateTimeFormat/constructor-options-order-fractionalSecondDigits.js:
• test262/test/language/expressions/object/proto-permitted-dup-shorthand.js: Copied from JSTests/test262/test/language/expressions/object/proto-permitted-dup.js.
• test262/test/language/expressions/object/proto-permitted-dup.js:

(obj.proto):
(obj.async proto):

• test262/test262-Revision.txt:

10:20 PM Changeset in webkit [266502] by Lauro Moura

• 4 edits
  2 adds in trunk/LayoutTests

[GLIB] Rebaseline and garden some tests

Unreviewed test gardening.

• platform/glib/fast/encoding/charset-replacement-expected.txt: Added.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

8:22 PM Changeset in webkit [266501] by Chris Dumez

• 12 edits in trunk

Choose adequate number of channels for ConvolverNode's output
​https://bugs.webkit.org/show_bug.cgi?id=216099

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:

Source/WebCore:

Choose adequate number of channels for ConvolverNode's output. We were using 2 channels for
the output no matter what but we're supposed to use a single channel if both the input
and the response buffer are mono.

This is based on the following Blink change by Raymond Toy:

• ​https://codereview.chromium.org/2732523003

No new tests, rebaselined existing tests.

• Modules/webaudio/ConvolverNode.cpp:

(WebCore::computeNumberOfOutputChannels):
(WebCore::ConvolverNode::create):
Set the shouldNormalize flag *before* we set the buffer since setBuffer() relies on
the flag. This gives us a few more test passes.

(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::setBuffer):
(WebCore::ConvolverNode::checkNumberOfChannelsForInput):

• Modules/webaudio/ConvolverNode.h:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::Reverb):
(WebCore::Reverb::initialize):
(WebCore::Reverb::process):

• platform/audio/Reverb.h:

7:59 PM Changeset in webkit [266500] by Hector Lopez

• 2 edits
  2 copies
  6 adds in trunk/LayoutTests

Rebaseline after macOS build progression.
Copy current test expectations to Catalina and Mojave and update Big Sur

Unreviewed test gardening.

• platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:

7:08 PM Changeset in webkit [266499] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r251254): Web Inspector: Text insertion point is invisible when editing DOM nodes
​https://bugs.webkit.org/show_bug.cgi?id=210197
<rdar://problem/61485409>

Reviewed by Devin Rousso.

r251254 promoted the selection area into a layer on top the the tree outline item.
Combined with the existing WebKit bug (​https://webkit.org/b/213501), it introduced the regression.

This patch is largely a workaround for the WebKit bug.

Revert r251254 and instead change the background color of the shadow DOM items from
the semi-transparent gray to black (white in the dark mode) with 5% transparency, which
produced the same gray color overlayed on top of the white background of the DOM tree outline.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom):
(.tree-outline.dom li .selection-area):

(.tree-outline.dom li > :not(.selection-area)): Deleted.
Don't introduce a layer for every DOM node.

(.tree-outline.dom li.parent.shadow::after):
(.tree-outline.dom li.parent.shadow + ol.children.expanded):
(@media (prefers-color-scheme: dark) .tree-outline.dom):
(@media (prefers-color-scheme: dark) .tree-outline.dom .shadow):

6:32 PM Changeset in webkit [266498] by Darin Adler

• 6 edits in trunk/Source/WebCore

Simplify some editing code
​https://bugs.webkit.org/show_bug.cgi?id=216097

Reviewed by Sam Weinig.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildrenWithNewText):
If string is empty, don't add a text node. Turns out all callers wanted
this behavior.

• dom/Node.cpp:

(WebCore::Node::setTextContent): Simplify by relying on new behavior
of replaceAllChildrenWithNewText when passed an empty string.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Use
replaceAllChildrenWithNewText instead of the unnecessarily complicated
code that was here. Also simplify the VisibeSelection manipulation at
the end of the function.

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText): Simplify by relying on new
behavior of replaceAllChildrenWithNewText when passed an empty string.

• page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument): Simplify by using the
selection function that takes a SimpleRange rather than the one that
takes two containers and offsets.

6:04 PM Changeset in webkit [266497] by Jon Davis

• 3 edits in trunk/Websites/webkit.org

Add an STP callout to Web Inspector documentation
​https://bugs.webkit.org/show_bug.cgi?id=216105

Reviewed by Devin Rousso.

• wp-content/themes/webkit/single-web_inspector_page.php:
• wp-content/themes/webkit/style.css:

(article .meta .icon):

4:58 PM Changeset in webkit [266496] by msaboff@apple.com

• 4 edits
  1 add in trunk

ASSERTION FAILED: value.isCell() && value.asCell()->type() == CustomGetterSetterType ./bytecode/ObjectPropertyConditionSet.cpp
​https://bugs.webkit.org/show_bug.cgi?id=216103

Reviewed by Saam Barati.

JSTests:

New teset.

• stress/custom-get-set-override.js: Added.

(overrideFunction.o.customFunction):
(overrideFunction):

Source/JavaScriptCore:

Changed the ASSERT to an if statement. This checks to see if, the likely newly changed,
property is still a custom getter setter before caching its access as such.

• bytecode/ObjectPropertyConditionSet.cpp:

(JSC::generateConditionsForPrototypePropertyHitCustom):

• tools/JSDollarVM.cpp: Added test helper function.

4:34 PM Changeset in webkit [266495] by dino@apple.com

• 2 edits in trunk/Tools

Update Kimmo's email.

• Scripts/webkitpy/common/config/contributors.json:

4:23 PM Changeset in webkit [266494] by Karl Rackler

• 2 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Rebaseline fast/block/margin-collapse/103 for Mojave

Unreviewed test gardening.

• platform/mac-mojave/fast/block/margin-collapse/103-expected.txt:

3:44 PM Changeset in webkit [266493] by wilander@apple.com

• 2 edits in trunk/Source/WebKit

Remove custom domain from SameSite=strict jail protection
​https://bugs.webkit.org/show_bug.cgi?id=216083
<rdar://problem/68220223>

Reviewed by Alex Christensen.

No new tests. This was a site-specific opt-in rule. The feature
itself has tests.

• NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:

(WebKit::ResourceLoadStatisticsStore::shouldEnforceSameSiteStrictForSpecificDomain const):

3:11 PM Changeset in webkit [266492] by Chris Dumez

• 10 edits
  2 adds in trunk

Don't modify the response when creating a ConvolverNode
​https://bugs.webkit.org/show_bug.cgi?id=216093

Reviewed by Eric Carlson.

Source/WebCore:

When creating a ConvolverNode with normalization (the default), the
ConvolverNode was modifying the supplied AudioBuffer containing the
desired impulse response. This happens because the normalization
factor was applied to the buffer, convolver stages were computed, and
then the normalization was undone. Due to floating-point roundoff,
this can (and does) modify the buffer.

Instead, compute the scale factor and pass it into the various
routines so that the scaling can be done there. For stages using an
FFT, the resulting FFT is scaled by the factor. For the direct
convolver, the response is modified there. (The direct convolver
makes a copy of the reponse, so this is safe.)

This is a cherry-pick of the following Blink change by Raymond Toy:

• ​https://chromium-review.googlesource.com/c/chromium/src/+/1623457

Test: webaudio/convolvernode-unmodified-buffer.html

• platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::scaleFFT):

• platform/audio/FFTFrame.h:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::Reverb):
(WebCore::Reverb::initialize):

• platform/audio/Reverb.h:
• platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

• platform/audio/ReverbConvolver.h:
• platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

• platform/audio/ReverbConvolverStage.h:

LayoutTests:

Import layout test from Blink.

• webaudio/convolvernode-unmodified-buffer-expected.txt: Added.
• webaudio/convolvernode-unmodified-buffer.html: Added.

3:07 PM Changeset in webkit [266491] by Chris Dumez

• 4 edits in trunk

Fix rounding for DelayDSPKernel's buffer size calculation
​https://bugs.webkit.org/show_bug.cgi?id=216091

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/maxdelay-rounding-expected.txt:

Source/WebCore:

Fix rounding for DelayDSPKernel's buffer size calculation. The DelayNode needs to buffer
|maxDelayTime| sample frames, plus one frame for interpolation. If |maxDelayTime| isn't
an integer, we have to round it up or the buffer would end up one frame short.

No new tests, rebaselined existing test.

• Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::bufferLengthForDelay const):

2:25 PM Changeset in webkit [266490] by Karl Rackler

• 2 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Rebaseline fast/block/margin-collapse/103 for Catalina

Unreviewed test gardening.

• platform/mac-catalina/fast/block/margin-collapse/103-expected.txt:

2:24 PM Changeset in webkit [266489] by Darin Adler

• 14 edits in trunk/Source

Change Affinity into an enum class
​https://bugs.webkit.org/show_bug.cgi?id=216096

Reviewed by Wenson Hsieh.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::localCaretRectForCharacterOffset): Use prefix.

• dom/Position.cpp:

(WebCore::Position::rendersInDifferentPosition const): Ditto.
(WebCore::Position::inlineBoxAndOffset const): Ditto.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): Ditto.

• editing/TextAffinity.h: Use an enum class.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::VisiblePosition): Use prefix.

• editing/VisiblePosition.h: Ditto.
• editing/VisibleUnits.cpp:

(WebCore::visualWordPosition): Ditto.
(WebCore::nextBoundary): Ditto.
(WebCore::endPositionForLine): Ditto.
(WebCore::atBoundaryOfGranularity): Ditto.
(WebCore::nextLineBoundaryInDirection): Ditto.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::createVisiblePositionForBox): Ditto.
(WebCore::RenderTextLineBoxes::positionForPoint const): Ditto.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition positionByMovingInDirection:amount:withAffinityDownstream:]):
Use prefix.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.h:

(kit): Use prefix.
(core): Ditto.

2:16 PM Changeset in webkit [266488] by rniwa@webkit.org

• 4 edits in trunk

Add a variant of map which filters items to Vector.h
​https://bugs.webkit.org/show_bug.cgi?id=215879

Reviewed by Darin Adler and Yusuke Suzuki.

Source/WTF:

This patch adds WTF::compactMap, which calls a function on each item in an iterable object like WTF::map
but also filters the returned value. The mapped function may return Optional<T> or RefPtr<T>. The value
is kept in the result if the returned value is not WTF::nullopt in the case of Optional<T> and not null
in the case of RefPtr<T>. The result will be either Vector<T> for Optional<T> or else Vector<Ref<T>>.

• wtf/Vector.h:

(WTF::CompactMapTraits:): Added. Traits to have a different behavior
(WTF::CompactMapTraits<Optional<T>>::hasValue): Added.
(WTF::CompactMapTraits<Optional<T>>::extractValue): Added.
(WTF::CompactMapTraits<RefPtr<T>>::hasValue): Added.
(WTF::CompactMapTraits<RefPtr<T>>::extractValue): Added.
(WTF::CompactMap): Added. The helper to use WTFMove on the argument to the mapped function if possible.
(WTF::compactMap): Added.

Tools:

Added unit tests.

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::evenMultipliedByFive):
(WTF_Vector.CompactMapStaticFunctionReturnOptional):
(TestWebKitAPI::RefCountedObject):
(TestWebKitAPI::RefCountedObject::create):
(TestWebKitAPI::RefCountedObject::ref):
(TestWebKitAPI::RefCountedObject::RefCountedObject):
(TestWebKitAPI::createRefCountedForOdd):
(WTF_Vector.CompactMapStaticFunctionReturnRefPtr):
(TestWebKitAPI::createRefCountedForEven):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRef):
(TestWebKitAPI::createRefCountedWhenDivisibleByThree):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRefPtr):
(WTF_Vector.CompactMapLambdaReturnOptional):
(TestWebKitAPI::CountedObject):
(TestWebKitAPI::CountedObject::CountedObject):
(TestWebKitAPI::CountedObject::value):
(TestWebKitAPI::CountedObject::count):
(WTF_Vector.CompactMapLambdaCopyVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaMoveVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaReturnRefPtr):
(WTF_Vector.CompactMapLambdaReturnRefPtrFromMovedRef):
(WTF_Vector.CompactMapLambdaReturnOptionalRefPtr):

2:01 PM Changeset in webkit [266487] by Darin Adler

• 39 edits in trunk/Source

Remove comparePositions and make VisiblePosition improvements
​https://bugs.webkit.org/show_bug.cgi?id=215982

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::localCaretRectForCharacterOffset): Updated for
inlineBoxAndOffset.

• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject): Use std::max/min instead of comparePositions.
(isWhiteSpaceBetweenSentences): Use isPointInRange instead of comparePositions.

• dom/Position.cpp:

(WebCore::Position::rendersInDifferentPosition const): Updated for
inlineBoxAndOffset.
(WebCore::Position::inlineBoxAndOffset const): Renamed from
getInlineBoxAndOffset and changed to use a return value instead of out arguments.

• dom/Position.h: Added InlineBoxAndOffset structure for the inlineBoxAndOffset

function. Update for rename of EAffinity to Affinity. Changed getInlineBoxAndOffset
to inlineBoxAndOffset and use a return value instead of out arguments. Change
<, >, <=, and >= to call documentOrder.

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd): Use <= instead of comparePositions.
Use VisiblePosition::defaultAffinity instead of VP_DEFAULT_AFFINITY.
(WebCore::ApplyStyleCommand::applyBlockStyle): Use < instead of comparePositions.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Ditto. Also added
a missing null check.
(WebCore::ApplyStyleCommand::applyInlineStyle): Ditto.
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Use <= and < instead
of comparePositions.
(WebCore::ApplyStyleCommand::removeInlineStyle): Use <= instead of comparePositions.
(WebCore::ApplyStyleCommand::nodeFullySelected const): Use >= and <= instead of
comparePositions.
(WebCore::ApplyStyleCommand::nodeFullyUnselected const): Use < and > instead of
comparePositions.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText): Use < instead of
comparePositions, in a way that handles the null case correctly.
(WebCore::CompositeEditCommand::deleteInsignificantTextDownstream): Removed
unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
Ditto. Also use < instead of comparePositions.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Use <=
instead of comparePositions.
(WebCore::CompositeEditCommand::moveParagraphs): Use <= and >= instead of
comparePositions.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::initializeStartEnd): Use >= instead of
comparePositions
(WebCore::DeleteSelectionCommand::smartDeleteParagraphSpacers):
Use VisiblePosition::defaultAffinity instead of VP_DEFAULT_AFFINITY, and
in other cases removed unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::DeleteSelectionCommand::initializePositionData): Ditto.
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Use >= instead
of comparePositions.
(WebCore::DeleteSelectionCommand::mergeParagraphs): Use >= instead of
comparePositions, also use isOrphan and merge two checks into one.

• editing/Editing.cpp:

(WebCore::comparePositions): Deleted.
(WebCore::firstEditablePositionAfterPositionInRoot): Use < instead of
comparePositions.
(WebCore::lastEditablePositionBeforePositionInRoot): Use > instead of
comparePositions.
(WebCore::isNodeVisiblyContainedWithin): Use < instead of comparePositions.
(WebCore::localCaretRectInRendererForCaretPainting): Update for
localCaretRect function that no longer uses an out argument.

• editing/Editing.h: Deleted comparePositions.

• editing/Editor.cpp:

(WebCore::Editor::adjustedSelectionRange): Use >= instead of
comparePositions.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionByMouseIfDifferent): Assign
an empty value rather than using a clear function.
(WebCore::FrameSelection::directionOfSelection): Updated for
inlineBoxAndOffset.
(WebCore::FrameSelection::contains const): Use isPointInRange instead
of comparePositions.
(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
Use Upstream instead of VP_UPSTREAM_IF_POSSIBLE.
(WebCore::FrameSelection::elementRangeContainingCaretSelection const):
Removed unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::FrameSelection::characterInRelationToCaretSelection const): Ditto.
(WebCore::FrameSelection::characterBeforeCaretSelection const): Deleted.
There is only one caller, and we can move the algorithm, now a one-liner, there.
(WebCore::FrameSelection::characterAfterCaretSelection const): Deleted. Ditto.
(WebCore::FrameSelection::selectionAtDocumentStart const): Deleted. Ditto.
(WebCore::FrameSelection::selectionAtWordStart const): Use visibleStart
inatead of creating a new position with VP_DEFAULT_AFFINITY. Also streamlined
the function a bit.
(WebCore::FrameSelection::selectRangeOnElement): Deleted.
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
Removed unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::FrameSelection::selectionAtSentenceStart const): Ditto.

• editing/FrameSelection.h: Updated for above.

• editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
Removed unnecessary explicit use of VP_DEFAULT_AFFINITY. Also tightened
up the code a bit including removing an unnecessary assertion.
(WebCore::InsertParagraphSeparatorCommand::doApply): Use <= instead of
comparePositions.

• editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::RenderedPosition): Have the VisiblePosition
constructor call through to the Position/Affinity constructor instead
of repeating the logic twice. Update for inlineBoxAndOffset. Initialize
m_offset in the class definition so we don't have to do it here.

• editing/RenderedPosition.h: Initialize all data members. Sorted a

function member above the data members.

• editing/TextAffinity.h: Renamed for modern WebKit coding style,

eliminating the use of all caps and the "E" prefix on EAffinity.
For now, old names are also still supported.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::VisiblePosition): Use member construction
rather than assignment. Rewrote the code that stores upstream affinity
only when appropriate to be more straightforward. The old code would
set to upstream and then change back. The new code sets to upstream
only after testing that it worked. Should also be faster since it
saves one call to canonicalPosition.
(WebCore::VisiblePosition::init): Deleted. Rolled into the constructor.
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate const):
Update for inlineBoxAndOffset.
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate const): Ditto.
(WebCore::VisiblePosition::localCaretRect const): Return the renderer as
part of the return value rather than an out argument. Update for
inlineBoxAndOffset and streamline logic a bit.
(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):
Update for inlineBoxAndOffset and remove unneded special cases already
covered by that function.
(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation const):
Updated for localCaretRect.
(WebCore::documentOrder): Added.

• editing/VisiblePosition.h: Added VisiblePosition::defaultAffinity

to replace VP_DEFAULT_AFFINITY. Deleted VP_UPSTREAM_IF_POSSIBLE; callers
will just use Upstream. Deleted the clear function. Renamed
getInlineBoxAndOffset to inlineBoxAndOffset and use a return value
instead of out arguments. Use a return value instead of out
arguments for localCaretRect. Made canonicalPosition a static member
function. Use documentOrder to implement <, >, <=, and >=.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::toNormalizedRange const): Use > instead
of comparePositions. Also do the comparison after calling
parentAnchoredEquivalent instead of before.
(WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents):
Use <= instead of comparePositions.
(WebCore::VisibleSelection::setWithoutValidation): Ditto.

• editing/VisibleUnits.cpp:

(WebCore::visualWordPosition): Update for inlineBoxAndOffset.
(WebCore::nextBoundary): Use Upstream instad of VP_UPSTREAM_IF_POSSIBLE.
(WebCore::endPositionForLine): Ditto.
(WebCore::previousLinePosition): Update for inlineBoxAndOffset.
(WebCore::nextLinePosition): Ditto.
(WebCore::atBoundaryOfGranularity): Use Upstream instead of
VP_UPSTREAM_IF_POSSIBLE. This is especially important here,
because setAffinity does not actually check if upstream is possible,
so it is setting to Upstream unconditionally. The old name was
misleading here.
(WebCore::nextLineBoundaryInDirection): Ditto. Same misleading use.

• editing/cocoa/HTMLConverter.mm:

(HTMLConverter::convert): Use > instead of comparePositions.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Removed unnecessary
explicit use of VP_DEFAULT_AFFINITY.

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes): Use <=
instead of comparePositions.
(WebCore::serializePreservingVisualAppearanceInternal): Use ==
and < instead of comparePositions.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick): Use <
instead of comparePositions.
(WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::createVisiblePositionForBox): Use VisiblePosition::defaultAffinity
instead of VP_DEFAULT_AFFINITY and Upstream instead of VP_UPSTREAM_IF_POSSIBLE.
(WebCore::RenderTextLineBoxes::positionForPoint const): DItto.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

Source/WebKit:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPointInRootViewCoordinates): Use <= instead of
comparePositions.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition positionByMovingInDirection:amount:withAffinityDownstream:]):
Use Upstream instead of VP_UPSTREAM_IF_POSSIBLE. Since we were calling
setAffinity here, VP_UPSTREAM_IF_POSSIBLE was misleading since that function
does not check the validity of the affinity.
(-[DOMNode startPosition]): Removed unnecessary explicit VP_DEFAULT_AFFINITY.
(-[DOMNode endPosition]): Ditto.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.h:

(kit): Update for changes to Affinity enumeration.
(core): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame characterBeforeCaretSelection]): Moved the code from
FrameSelection::characterBeforeCaretSelection because it's a one-liner now.
Added a call to updateLayout because it's unclear why we could do without it before.
Also added a null check for frame, since there's no guarantee it's not null.
(-[WebFrame characterAfterCaretSelection]): Ditto.
(-[WebFrame selectionAtDocumentStart]): Ditto.
(-[WebFrame selectNSRange:onElement:]): Ditto, but also added a comment because
this method is not useful and almost certainly not used.
(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]):
Use VisiblePosition::defaultAffinity instead of VP_DEFAULT_AFFINITY.

Source/WebKitLegacy/win:

• AccessibleTextImpl.cpp:

(AccessibleText::isInRange): Use isPointInRange instead of
comparePositions.

1:45 PM Changeset in webkit [266486] by timothy_horton@apple.com

• 2 edits in trunk/LayoutTests

RWT's lint-test-files complains about nonexistent editing/images tests

• TestExpectations:

Remove a stale expectation for a directory that has been deleted.

1:41 PM Changeset in webkit [266485] by timothy_horton@apple.com

• 5 edits in trunk/Source

iPad + Trackpad: JW Library highlighting and edit menus don't appear
​https://bugs.webkit.org/show_bug.cgi?id=216086

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isJWLibrary):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(applicationIsKnownToIgnoreMouseEvents):
Add JW Library to the list.

1:32 PM Changeset in webkit [266484] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266363. rdar://problem/68229370

Wheel event region code is not fully disabled
​https://bugs.webkit.org/show_bug.cgi?id=216008
<rdar://problem/68086333>

Reviewed by Simon Fraser.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):

Use the relevant ENABLE flag rather than !PLATFORM_IOS to compile out the code.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:21 PM Changeset in webkit [266483] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67281310 ([ Rosetta Layout Tests ] REGRESSION (r265639): [ Big Sur ] 1 canvas layout test is a constant failure)
Removing test expectations that now pass on Big Sur Rosetta 20A2364

Unreviewed test gardening.

• platform/mac/TestExpectationsRosetta:

12:53 PM Changeset in webkit [266482] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://66802945 (REGRESSION (20A2323e-20A234b): [ Layout Test] 1 canvas layout test is a constant failure)
Removing test expectations that now pass on Big Sur 20A2364

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:44 PM Changeset in webkit [266481] by Chris Dumez

• 7 edits in trunk

New AutoParam timeline events should have their startTime adjusted when they are in the past
​https://bugs.webkit.org/show_bug.cgi?id=216080

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:

Source/WebCore:

New AutoParam timeline events should have their startTime adjusted when they are in the past.
We adjust the time to be the current time when it is in the past.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioParam.cpp:

12:20 PM Changeset in webkit [266480] by Devin Rousso

• 36 edits
  1 copy
  1 move
  1 add
  1 delete in trunk

Web Inspector: allow event breakpoints to be configured when they're added
​https://bugs.webkit.org/show_bug.cgi?id=215747

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Models/Breakpoint.js:

(WI.Breakpoint):
(WI.Breakpoint.prototype.get displayName): Added.
(WI.Breakpoint.prototype.addAction): Added.
(WI.Breakpoint.prototype.removeAction):
(WI.Breakpoint.prototype._handleBreakpointActionChanged): Added.
(WI.Breakpoint.prototype.createAction): Deleted.
(WI.Breakpoint.prototype.recreateAction): Deleted.
(WI.Breakpoint.prototype.breakpointActionDidChange): Deleted.

• UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint.displayNameForType):
(WI.DOMBreakpoint.prototype.get displayName): Added.

• UserInterface/Models/EventBreakpoint.js:

(WI.EventBreakpoint.get editable): Added.
(WI.EventBreakpoint.fromJSON):
(WI.EventBreakpoint.prototype.get displayName): Added.
(WI.EventBreakpoint.prototype.get editable):

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.get displayName): Added.

• UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint.prototype.get displayName): Added.
Add a get displayName "virtual" member function.

• UserInterface/Models/BreakpointAction.js:

(WI.BreakpointAction):
(WI.BreakpointAction.fromJSON):
(WI.BreakpointAction.prototype.get type):
(WI.BreakpointAction.prototype.set type): Added.
(WI.BreakpointAction.prototype.set data): Added.
(WI.BreakpointAction.prototype.get breakpoint): Deleted.
Remove the requirement that WI.BreakpointAction be passed a WI.Breakpoint when its
constructed. Instead, have WI.BreakpointAction dispatch events when its type or data
changes.

• UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView):
(WI.BreakpointActionView.prototype._pickerChanged):
(WI.BreakpointActionView.prototype._appendActionButtonClicked):
(WI.BreakpointActionView.prototype._removeAction):
(WI.BreakpointActionView.prototype._updateBody):
(WI.BreakpointActionView.prototype._handleLogInputInput): Added.
(WI.BreakpointActionView.prototype._handleJavaScriptCodeMirrorChange): Added.
(WI.BreakpointActionView.prototype._logInputChanged): Deleted.
(WI.BreakpointActionView.prototype._codeMirrorBlurred): Deleted.
Call functions on the delegate instead of directly manipulating a WI.Breakpoint as there
is no longer a WI.Breakpoint to manipulate since WI.BreakpointAction doesn't have one.

• UserInterface/Controllers/BreakpointPopoverController.js: Removed.
• UserInterface/Views/BreakpointPopoverController.css: Removed.
• UserInterface/Views/BreakpointPopover.js: Renamed from Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css.

(WI.BreakpointPopover):
(WI.BreakpointPopover.appendContextMenuItems):
(WI.BreakpointPopover.prototype.get breakpoint):
(WI.BreakpointPopover.prototype.show):
(WI.BreakpointPopover.dismiss):
(WI.BreakpointPopover.prototype.completionControllerShouldAllowEscapeCompletion):
(WI.BreakpointPopover.prototype.breakpointActionViewAppendActionView):
(WI.BreakpointPopover.prototype.breakpointActionViewRemoveActionView):
(WI.BreakpointPopover.prototype.breakpointActionViewResized):
(WI.BreakpointPopover.prototype.populateContent):
(WI.BreakpointPopover.prototype.addRow):
(WI.BreakpointPopover.prototype.createBreakpoint):
(WI.BreakpointPopover.prototype._presentOverTargetElement):
(WI.BreakpointPopover.prototype._parseIgnoreCountNumber):
(WI.BreakpointPopover.prototype._updateIgnoreCountText):
(WI.BreakpointPopover.prototype._createAddActionButton):
(WI.BreakpointPopover.prototype._insertBreakpointActionView):
(WI.BreakpointPopover.prototype._handleEnabledCheckboxChange):
(WI.BreakpointPopover.prototype._handleConditionCodeMirrorBeforeChange):
(WI.BreakpointPopover.prototype._handleConditionCodeMirrorChange):
(WI.BreakpointPopover.prototype._handleIgnoreCountInputChange):
(WI.BreakpointPopover.prototype._handleAddActionButtonClick):
(WI.BreakpointPopover.prototype._handleAutoContinueCheckboxChange):

• UserInterface/Views/BreakpointPopover.css: Added.

(.popover .edit-breakpoint-popover-content):
(.popover .edit-breakpoint-popover-content.wide):
(.popover .edit-breakpoint-popover-content > label.toggle):
(.popover .edit-breakpoint-popover-content > table):
(.popover .edit-breakpoint-popover-content > table > tr > th):
(.popover .edit-breakpoint-popover-content > table > tr > td):
(.popover .edit-breakpoint-popover-content > table > tr.condition > td > .editor):
(.popover .edit-breakpoint-popover-content > table > tr.condition > td > .editor > .CodeMirror):
(.popover .edit-breakpoint-popover-content.wide .condition > .CodeMirror):
(.popover .edit-breakpoint-popover-content input#edit-breakpoint-popover-ignore-count):
(.popover .edit-breakpoint-popover-content input:is(#edit-breakpoint-popover-ignore-count, #edit-breakpoint-popover-auto-continue)):
(.popover .edit-breakpoint-popover-content > .reference-page-link-container):
(body[dir=ltr] .popover .edit-breakpoint-popover-content > .reference-page-link-container):
(body[dir=rtl] .popover .edit-breakpoint-popover-content > .reference-page-link-container):
(@media (prefers-color-scheme: dark) .popover .edit-breakpoint-popover-content > table > tr > th):

• UserInterface/Views/EventBreakpointPopover.js:

(WI.EventBreakpointPopover):
(WI.EventBreakpointPopover.get editable): Added.
(WI.EventBreakpointPopover.prototype.dismiss):
(WI.EventBreakpointPopover.prototype.populateContent): Added.
(WI.EventBreakpointPopover.prototype.createBreakpoint): Added.
(WI.EventBreakpointPopover.prototype._showSuggestionsView):
(WI.EventBreakpointPopover.prototype._handleDOMEventNameInputKeydown): Added.
(WI.EventBreakpointPopover.prototype._handleDOMEventNameInputInput): Added.
(WI.EventBreakpointPopover.prototype._handleDOMEventNameInputBlur): Added.
(WI.EventBreakpointPopover.prototype.get breakpoint): Deleted.
(WI.EventBreakpointPopover.prototype.show): Deleted.
(WI.EventBreakpointPopover.prototype._presentOverTargetElement): Deleted.

• UserInterface/Views/EventBreakpointPopover.css:

(.popover .edit-breakpoint-popover-content .event input): Added.
(.popover .edit-breakpoint-popover-content .event:last-child input): Added.
(.popover .edit-breakpoint-popover-content .event input::placeholder): Added.
(.popover .event-breakpoint-content): Deleted.
(.popover .event-breakpoint-content > input): Deleted.
(.popover .event-breakpoint-content > input::placeholder): Deleted.
(.popover .event-breakpoint-content .reference-page-link-container): Deleted.

• UserInterface/Views/URLBreakpointPopover.js:

(WI.URLBreakpointPopover):
(WI.URLBreakpointPopover.get editable): Added.
(WI.URLBreakpointPopover.prototype.populateContent): Added.
(WI.URLBreakpointPopover.prototype.createBreakpoint): Added.
(WI.URLBreakpointPopover.prototype._updateEditor):
(WI.URLBreakpointPopover.prototype.get breakpoint): Deleted.
(WI.URLBreakpointPopover.prototype.show): Deleted.
(WI.URLBreakpointPopover.prototype.dismiss): Deleted.
(WI.URLBreakpointPopover.prototype._createEditor): Deleted.
(WI.URLBreakpointPopover.prototype._presentOverTargetElement): Deleted.

• UserInterface/Views/URLBreakpointPopover.css:

(.popover .edit-breakpoint-popover-content .url .editor): Added.
(.popover .edit-breakpoint-popover-content .url:last-child .editor): Added.
(.popover .edit-breakpoint-popover-content .url .editor > .CodeMirror): Added.
(.popover .edit-breakpoint-popover-content .url .editor > .CodeMirror-scroll): Added.
(@media (prefers-color-scheme: dark) .popover .edit-breakpoint-popover-content .url .editor): Added.
(.popover .url-breakpoint-content): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper > .editor): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper > .editor > .CodeMirror): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper > .editor > .CodeMirror-scroll): Deleted.
(.popover .url-breakpoint-content .reference-page-link-container): Deleted.
(@media (prefers-color-scheme: dark) .popover .url-breakpoint-content > .editor-wrapper > .editor): Deleted.
Make WI.BreakpointPopoverController into a subclass of WI.Popover with a static member
function for adding context menu items. This allows both WI.EventBreakpointPopover and
WI.URLBreakpointPopover to inherit from WI.BreakpointPopover, meaning that they can show
the configuration UI when adding the breakpoint instead of as a second step after creating
the breakpoint.

• UserInterface/Models/ProbeSet.js:

(WI.ProbeSet.prototype.createProbe):
Update to use newly named WI.Breakpoint.prototype.addAction.

• UserInterface/Views/ContextMenuUtilities.js:
• UserInterface/Views/DOMBreakpointTreeElement.js:

(WI.DOMBreakpointTreeElement):
(WI.DOMBreakpointTreeElement.displayNameForType): Deleted.

• UserInterface/Views/EventBreakpointTreeElement.js:

(WI.EventBreakpointTreeElement):

• UserInterface/Views/JavaScriptBreakpointTreeElement.js:

(WI.JavaScriptBreakpointTreeElement):
(WI.JavaScriptBreakpointTreeElement.prototype.updateTitles):

• UserInterface/Views/URLBreakpointTreeElement.js:

(WI.URLBreakpointTreeElement):

• UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
Use the new WI.Breakpoint.prototype.get displayName.

• UserInterface/Base/Main.js:
• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.populateContextMenu):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
Replace WI.breakpointPopoverController with WI.BreakpointPopover.

• UserInterface/Views/Variables.css:

(:root):

• UserInterface/Views/Main.css:

(.reference-page-link):
Create a variable for the size of the reference page (?) button so it can be use elsewhere.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/LoadLocalizedStrings.js:

(WI.repeatedUIString.debuggerStatements): Added.
(WI.repeatedUIString.allExceptions): Added.
(WI.repeatedUIString.uncaughtExceptions): Added.
(WI.repeatedUIString.assertionFailures): Added.
(WI.repeatedUIString.allMicrotasks): Added.
(WI.repeatedUIString.allAnimationFrames): Added.
(WI.repeatedUIString.allIntervals): Added.
(WI.repeatedUIString.allEvents): Added.
(WI.repeatedUIString.allTimeouts): Added.
Create repeated localized string helper functions for special breakpoints.

• UserInterface/Base/ReferencePage.js: Added.

Add an enum for reference page URLs.

• UserInterface/Main.html:

LayoutTests:

• inspector/debugger/breakpoint-action-eval.html:
• inspector/debugger/breakpoint-action-log.html:
• inspector/debugger/probe-manager-add-remove-actions.html:
• inspector/debugger/stepping/stepping-through-autoContinue-breakpoint.html:
• inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.async suite):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases):

• inspector/dom/breakpoint-for-event-listener.html:

Update to use newly named WI.Breakpoint.prototype.addAction.

12:19 PM Changeset in webkit [266479] by wilander@apple.com

• 8 edits in trunk

Storage Access API: Allow requests for storage access from nested iframes
​https://bugs.webkit.org/show_bug.cgi?id=216019
<rdar://problem/68109918>

Reviewed by Alex Christensen.

It was decided browsers should support requests for storage access from nested
iframes as part of the standardization of the Storage Access API. The issue is
discussed here: ​https://github.com/privacycg/storage-access/issues/10.

Source/WebCore:

No new tests. Existing tests were changed.

• dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccessQuickCheck):

LayoutTests:

• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-database-expected.txt:
• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-database.html:

Now sets a cookie for the third party so that the test checks granted access.

• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-expected.txt:
• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe.html:

Now sets a cookie for the third party so that the test checks granted access.

• http/tests/storageAccess/resources/nesting-iframe.html:

Changed to now expect to be granted storage access.

12:15 PM Changeset in webkit [266478] by Jonathan Bedard

• 2 edits
  1 add in trunk/Tools

[webkitcorepy] Add NoAction class
​https://bugs.webkit.org/show_bug.cgi?id=216079
<rdar://problem/68216301>

Reviewed by Dewei Zhu.

This is an argparse action we've duplicated in a few Internal scripts, it should
be in a shared library.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/arguments.py: Added.

(NoAction): argparse action supporting a binary flag.

11:44 AM Changeset in webkit [266477] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: duplicate "Timeline Recording 1" on open
​https://bugs.webkit.org/show_bug.cgi?id=216060

Reviewed by Brian Burg.

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager):
(WI.TimelineManager.prototype.get recordings): Deleted.
Don't reset in the constructor as this is already done in enable and disable, which
is called whenever the Timeline Tab is added/removed.

• UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView):
There should never be any existing recordings when adding the Timelines Tab, as they should
have been removed when the tab was last removed (via WI.TimelineManager.prototype.disable).

11:32 AM Changeset in webkit [266476] by Chris Dumez

• 21 edits in trunk

OfflineAudioContext incorrectly renders at beginning of output buffer after resuming
​https://bugs.webkit.org/show_bug.cgi?id=216078

Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/adding-events-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setTargetAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

Source/WebCore:

OfflineAudioContext incorrectly renders at beginning of output buffer after resuming,
instead of rendering where it left off.

No new tests, rebaselined existing tests.

• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

• Modules/webaudio/OfflineAudioDestinationNode.h:

10:38 AM Changeset in webkit [266475] by Devin Rousso

• 4 edits in trunk/LayoutTests

REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215614
<rdar://problem/67333849>

Reviewed by Eric Carlson.

• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html:
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt:

• platform/mac/TestExpectations:

10:37 AM Changeset in webkit [266474] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.7

Tag Safari-610.1.28.1.7.

10:33 AM Changeset in webkit [266473] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.7

10:28 AM Changeset in webkit [266472] by Karl Rackler

• 52 adds in trunk/LayoutTests/platform

Rebaseline after macOS build progression.
Copy current test expectations to Catalina and Mojave and update Big Sur

Unreviewed test gardening.

• platform/mac-catalina/fast/block/margin-collapse/103-expected.txt: Added.
• platform/mac-catalina/fast/css/continuationCrash-expected.txt: Added.
• platform/mac-catalina/fast/css/text-overflow-input-expected.txt: Added.
• platform/mac-catalina/fast/forms/button-positioned-expected.txt: Added.
• platform/mac-catalina/fast/forms/button-sizes-expected.txt: Added.
• platform/mac-catalina/fast/forms/button-table-styles-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-button-sizes-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-text-word-wrap-expected.txt: Added.
• platform/mac-catalina/fast/forms/listbox-bidi-align-expected.txt: Added.
• platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt: Added.
• platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
• platform/mac-catalina/fast/forms/select-selected-expected.txt: Added.
• platform/mac-catalina/fast/forms/select/optgroup-rendering-expected.txt: Added.
• platform/mac-catalina/fast/parser/document-write-option-expected.txt: Added.
• platform/mac-catalina/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
• platform/mac-catalina/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
• platform/mac-catalina/tables/mozilla/bugs/bug33855-expected.txt: Added.
• platform/mac-catalina/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
• platform/mac-mojave/fast/block/margin-collapse/103-expected.txt: Added.
• platform/mac-mojave/fast/css/continuationCrash-expected.txt: Added.
• platform/mac-mojave/fast/css/text-overflow-input-expected.txt: Added.
• platform/mac-mojave/fast/forms/button-positioned-expected.txt: Added.
• platform/mac-mojave/fast/forms/button-sizes-expected.txt: Added.
• platform/mac-mojave/fast/forms/button-table-styles-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-button-sizes-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-text-word-wrap-expected.txt: Added.
• platform/mac-mojave/fast/forms/listbox-bidi-align-expected.txt: Added.
• platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
• platform/mac-mojave/fast/forms/select-selected-expected.txt: Added.
• platform/mac-mojave/fast/forms/select/optgroup-rendering-expected.txt: Added.
• platform/mac-mojave/fast/parser/document-write-option-expected.txt: Added.
• platform/mac-mojave/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
• platform/mac-mojave/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
• platform/mac-mojave/tables/mozilla/bugs/bug33855-expected.txt: Added.

10:28 AM Changeset in webkit [266471] by Karl Rackler

• 19 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Copy current test expectations to Catalina and Mojave and update Big Sur

Unreviewed test gardening.

• platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
• platform/mac/fast/css/continuationCrash-expected.txt:
• platform/mac/fast/css/text-overflow-input-expected.txt:
• platform/mac/fast/forms/button-positioned-expected.txt:
• platform/mac/fast/forms/button-sizes-expected.txt:
• platform/mac/fast/forms/input-button-sizes-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/input-text-word-wrap-expected.txt:
• platform/mac/fast/forms/listbox-bidi-align-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/select-selected-expected.txt:
• platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
• platform/mac/fast/parser/document-write-option-expected.txt:
• platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/mac/tables/mozilla/bugs/bug33855-expected.txt:

10:04 AM Changeset in webkit [266470] by sihui_liu@apple.com

• 3 edits in trunk

REGRESSION (r264661): Crashes in WebCore::wrap<WebCore::Blob> in CloneDeserializer
​https://bugs.webkit.org/show_bug.cgi?id=215835

Reviewed by Youenn Fablet.

Partially revert r264661 as there are cases, other than our previous IDB, where we may not use JSDOMGlobalObject
for serialization and deserialization, like the one showed in the crashlog. Therefore, we still need the check
for JSDOMGlobalObject.

API Test: WebKit.EvaluateJavaScriptThatCreatesBlob

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readRTCCertificate):
(WebCore::CloneDeserializer::readTerminal):

9:38 AM Changeset in webkit [266469] by Chris Dumez

• 4 edits in trunk

Implement event convergence for AudioParam.setTargetAtTime()
​https://bugs.webkit.org/show_bug.cgi?id=216064

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/set-target-conv-expected.txt:

Source/WebCore:

Implement event convergence for AudioParam.setTargetAtTime(). This is to match Chromium's
behavior and pass the corresponding WPT test.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::hasSetTargetConverged):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

9:19 AM Changeset in webkit [266468] by youenn@apple.com

• 53 edits
  5 copies
  2 deletes in trunk

Introduce a C++ chain of operations in RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=216006

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-timing.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-parameterless.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-rollback-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-track-stats.https-expected.txt:
• web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:
• web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Remove RTCPeerConnection JS built-ins and introduce a C++ version.
This allows to make replaceTrack part of the chain of operation.
Also update setLocalDescription to take no parameters.

Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Headers.cmake:
• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::setLocalDescription):
(WebCore::PeerConnectionBackend::setRemoteDescription):
(WebCore::PeerConnectionBackend::transceiverFromSender): Deleted.

• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):

• Modules/mediastream/RTCIceCandidate.h:
• Modules/mediastream/RTCIceCandidate.idl:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::getStats):
(WebCore::RTCPeerConnection::doClose):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):
(WebCore::RTCPeerConnection::chainOperation):
(WebCore::RTCPeerConnection::initializeWith): Deleted.
(WebCore::RTCPeerConnection::queuedCreateOffer): Deleted.
(WebCore::RTCPeerConnection::queuedCreateAnswer): Deleted.
(WebCore::RTCPeerConnection::queuedSetLocalDescription): Deleted.
(WebCore::RTCPeerConnection::queuedSetRemoteDescription): Deleted.
(WebCore::RTCPeerConnection::queuedAddIceCandidate): Deleted.

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnection.js: Removed.
• Modules/mediastream/RTCPeerConnectionInternals.js: Removed.
• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::RTCRtpSender):
(WebCore::RTCRtpSender::replaceTrack):
(WebCore::RTCRtpSender::isCreatedBy const):
(WebCore::RTCRtpSender::dtmf):
(WebCore::RTCRtpSender::currentTransceiverDirection const):

• Modules/mediastream/RTCRtpSender.h:
• Modules/mediastream/RTCRtpSender.idl:
• Modules/mediastream/RTCRtpSenderBackend.h:
• Modules/mediastream/RTCSessionDescription.cpp:

(WebCore::RTCSessionDescription::create):

• Modules/mediastream/RTCSessionDescription.h:
• Modules/mediastream/RTCSessionDescription.idl:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doSetLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::doSetRemoteDescription):
(WebCore::LibWebRTCPeerConnectionBackend::addTrack):
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiverFromTrackOrKind):
(WebCore::LibWebRTCPeerConnectionBackend::newRemoteTransceiver):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

• fast/mediastream/RTCIceCandidate-expected.txt:
• fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
• fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt:
• fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid-expected.txt:
• webrtc/libwebrtc/release-while-creating-offer-expected.txt:
• webrtc/remove-track-expected.txt:
• webrtc/remove-track.html:

Make sure we are in a stable state before going to removeTrack actual test.
Also make sure to call setRemoteDescription for second test.

9:10 AM Changeset in webkit [266467] by youenn@apple.com

• 28 edits
  1 move in trunk/Source

Introduce a ThreadableWebSocketChannel identifier
​https://bugs.webkit.org/show_bug.cgi?id=216034

Reviewed by Alex Christensen.

Source/WebCore:

Clean-up code to have a single identifier for all WebSockets.
We use a WebSocketIdentifier that is now moved from WebKit to WebCore.
Introduce CookieGetter name following comments from ​https://bugs.webkit.org/show_bug.cgi?id=215928 review.
No change of behavior.

• Headers.cmake:
• Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::ThreadableWebSocketChannel):

• Modules/websockets/ThreadableWebSocketChannel.h:

(WebCore::ThreadableWebSocketChannel::ref):
(WebCore::ThreadableWebSocketChannel::deref):
(WebCore::ThreadableWebSocketChannel::identifier const):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::clientHandshakeRequest const):

• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeRequest const):

• Modules/websockets/WebSocketHandshake.h:
• Modules/websockets/WebSocketIdentifier.h: Added.
• Modules/websockets/WorkerThreadableWebSocketChannel.h:
• WebCore.xcodeproj/project.pbxproj:
• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::webSocketForRequestId):

• page/SocketProvider.cpp:

(WebCore::SocketProvider::createSocketStreamHandle):

• page/SocketProvider.h:

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:
• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkSocketChannel.h:
• NetworkProcess/NetworkSocketStream.h:
• Scripts/webkit/messages.py:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::WebSocketChannel):

• WebProcess/Network/WebSocketChannel.h:

(WebKit::WebSocketChannel::identifier const): Deleted.

• WebProcess/Network/WebSocketChannelManager.h:
• WebProcess/Network/WebSocketIdentifier.h: Removed.
• WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

• WebProcess/Network/WebSocketProvider.h:
• WebProcess/Network/WebSocketStream.cpp:

(WebKit::WebSocketStream::create):
(WebKit::WebSocketStream::WebSocketStream):

• WebProcess/Network/WebSocketStream.h:

8:52 AM Changeset in webkit [266466] by achristensen@apple.com

• 9 edits in trunk

Allow direct creation of replacement codec
​https://bugs.webkit.org/show_bug.cgi?id=216063

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/replacement-encodings.any-expected.txt:
• web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt:

Source/WebCore:

Chrome and Firefox do.
Covered by a newly passing web platform test.

• platform/text/TextCodecReplacement.cpp:

(WebCore::TextCodecReplacement::registerEncodingNames):

• platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::TextEncoding):

LayoutTests:

• fast/encoding/charset-replacement-expected.txt:
• fast/encoding/charset-replacement.html:

8:50 AM Changeset in webkit [266465] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(?): Timelines: Frames: clicking a record bar to select it when another record bar is already selected instead removes all selections
​https://bugs.webkit.org/show_bug.cgi?id=216045
<rdar://problem/68156740>

Reviewed by Brian Burg.

• UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:

(WI.RenderingFrameTimelineOverviewGraph.prototype._mouseClicked):

8:49 AM Changeset in webkit [266464] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Graphics: reloading the page doesn't automatically deselect shaders if they are shown
​https://bugs.webkit.org/show_bug.cgi?id=216054
<rdar://problem/68167882>

Reviewed by Brian Burg.

• UserInterface/Views/GraphicsTabContentView.js:

(WI.GraphicsTabContentView.prototype._removeCanvas):

8:48 AM Changeset in webkit [266463] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: re-enabling the JavaScript Allocations timeline doesn't show previously captured heap snapshots in the table
​https://bugs.webkit.org/show_bug.cgi?id=216057
<rdar://problem/68172848>

Reviewed by Brian Burg.

• UserInterface/Views/HeapAllocationsTimelineView.js:

(WI.HeapAllocationsTimelineView):
Add a WI.HeapAllocationsTimelineDataGridNode for each WI.HeapAllocationsTimelineRecord
that already exists when the WI.HeapAllocationsTimelineView is created.

8:37 AM Changeset in webkit [266462] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Start constructing InlineBoxes for inline runs
​https://bugs.webkit.org/show_bug.cgi?id=215168

Reviewed by Antti Koivisto.

In this transitional step we start constructing inline boxes. However at this point, each run gains a dedicated inline box.
While this is somewhat incorrect from the spec point of view, this is all internal and very tempoarary at this point.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::rectForRun const):
(WebCore::Layout::LineBox::alignHorizontally):
(WebCore::Layout::LineBox::alignVertically):
(WebCore::Layout::LineBox::adjustBaselineAndLineHeight):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::inlineRectList const): Deleted.

8:35 AM Changeset in webkit [266461] by Aditya Keerthi

• 11 edits
  2 adds in trunk

[macOS] Update date picker when the inner control is edited
​https://bugs.webkit.org/show_bug.cgi?id=216004

Reviewed by Wenson Hsieh.

Source/WebCore:

The value of the attached date picker should match the value in the
inner control. In order to achieve this behavior, m_dateTimeChooser
is notified whenever didChangeValueFromControl is called.

Note that the attached date picker's value is not updated on a
programmatic edit (setting input.value), as a sudden change not
triggered by the user would result in a poor user experience.

Test: fast/forms/date/date-editable-components/date-picker-update-on-edit.html

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::didChangeValueFromControl):

Source/WebKit:

• UIProcess/mac/WebDateTimePickerMac.mm:

(WebKit::WebDateTimePickerMac::showDateTimePicker):

If showDateTimePicker is called while a picker is already being
displayed, call updatePicker: rather than showPicker:.

(-[WKDateTimePicker initWithParams:inView:]):

The NSDatePicker and NSDateFormatter should use a UTC timezone.
This is necessary as all double values passed into WKDateTimePicker
are UTC timestamps. This has no effect on the value returned to
the WebProcess on user selection, as a timezone-agnostic format
string is used.

(-[WKDateTimePicker updatePicker:]):

Set the date value of the owned NSDatePicker to the value in the
DateTimeChooserParameters.

Tools:

Added dateTimePickerValue testing hook in order to enable testing the
current value of the presented date picker. The returned value is a
UTC timestamp is milliseconds, matching the date input's valueAsNumber.

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::dateTimePickerValue const):

• WebKitTestRunner/mac/UIScriptControllerMac.h:
• WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::dateTimePickerValue const):

LayoutTests:

Added a test to verify that the date picker is updated when the user edits the control.

• fast/forms/date/date-editable-components/date-picker-update-on-edit-expected.txt: Added.
• fast/forms/date/date-editable-components/date-picker-update-on-edit.html: Added.
• resources/ui-helper.js:

(window.UIHelper.dateTimePickerValue):

8:32 AM Changeset in webkit [266460] by pvollan@apple.com

• 2 edits in trunk/Tools

[Win] The WPT server is not always starting when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=216035

Reviewed by Youenn Fablet.

The Web platform test server is not always starting when running layout tests using Cygwin. It seems that starting the WPT server
takes longer time on Windows. Currently, the timeout is set to 20 seconds with polling every second. This patch addresses this
issue by waiting up to 60 seconds with polling every 10th second.

• Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase.start):

8:30 AM Changeset in webkit [266459] by Caio Lima

• 2 edits in trunk/JSTests

[ARMv7] Skip stress/intl-segmenter.js
​https://bugs.webkit.org/show_bug.cgi?id=216074

Unreviewed Gardening.

Skipping this test for ARMv7, since some boards we have are using ICU
60 and causes issues for this test.

• stress/intl-segmenter.js:

8:03 AM Changeset in webkit [266458] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

[Win] Update test expectations for failures only seen on one specific bot
​https://bugs.webkit.org/show_bug.cgi?id=216036

Unreviewed test gardening.

• platform/win/TestExpectations:

7:45 AM Changeset in webkit [266457] by achristensen@apple.com

• 13 edits in trunk

Align UTF-16 decoder with Chrome, Firefox, and specification
​https://bugs.webkit.org/show_bug.cgi?id=216058

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/streams/decode-non-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-streaming.any-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-streaming.any.worker-expected.txt:
• web-platform-tests/encoding/textdecoder-utf16-surrogates.any-expected.txt:
• web-platform-tests/encoding/textdecoder-utf16-surrogates.any.worker-expected.txt:

Source/WebCore:

Covered by web platform tests.

• platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

• platform/text/TextCodecUTF16.h:

(): Deleted.

LayoutTests:

• imported/blink/fast/encoding/utf-16-odd-byte-expected.txt:

7:42 AM Changeset in webkit [266456] by Diego Pino Garcia

• 2 edits in trunk/Tools

Unreviewed. Follow-up r266450, fix script due to missing variable.

• Scripts/clean-webkit:

(removeFiles): Add missing argument 'fs'.
(main):

6:29 AM Changeset in webkit [266455] by Philippe Normand

• 31 edits
  4 adds
  12 deletes in trunk

[Flatpak SDK] Update to FDO 20.08
​https://bugs.webkit.org/show_bug.cgi?id=215763

Reviewed by Žan Doberšek.

.:

• .gitignore: Ignore buildstream local Flatpak repository. This is created only when

manually building the SDK.

Tools:

Highlights:

• ICU 67 (see bug 215327)
• gcc update from 9.3.0 to 10.0
• clang update from 8.0 to 10.0
• perf is now included
• usable pipewire (host needs a working daemon and recent enough xdg-desktop-portal though)
• Mesa is no longer loaded from the flathub GL extension, but included in our downstream SDK, with debug symbols

This patch only includes the build definitions updates, bumping the SDK branch to 0.3. The
actual migration will be landed in a follow-up patch.

• buildstream/elements/flatpak-platform-extensions.bst:
• buildstream/elements/flatpak-runtimes.bst:
• buildstream/elements/flatpak/platform.bst:
• buildstream/elements/flatpak/sdk.bst:
• buildstream/elements/freedesktop-sdk.bst:
• buildstream/elements/sdk-build-depends/swig.bst:
• buildstream/elements/sdk-platform.bst:
• buildstream/elements/sdk.bst:
• buildstream/elements/sdk/at-spi2-atk.bst: Removed.
• buildstream/elements/sdk/at-spi2-core.bst: Removed.
• buildstream/elements/sdk/atk.bst: Removed.
• buildstream/elements/sdk/brotli.bst: Removed.
• buildstream/elements/sdk/glib.bst:
• buildstream/elements/sdk/gobject-introspection.bst: Removed.
• buildstream/elements/sdk/graphene.bst:
• buildstream/elements/sdk/gst-plugins-bad.bst:
• buildstream/elements/sdk/gst-plugins-good.bst:
• buildstream/elements/sdk/gstreamer.bst:
• buildstream/elements/sdk/gtk+-3.bst:
• buildstream/elements/sdk/gtk.bst:
• buildstream/elements/sdk/libdrm.bst: Added.
• buildstream/elements/sdk/libgcrypt.bst:
• buildstream/elements/sdk/libsecret.bst:
• buildstream/elements/sdk/libsoup.bst:
• buildstream/elements/sdk/libsrtp2.bst: Removed.
• buildstream/elements/sdk/mesa.bst: Added.
• buildstream/elements/sdk/pygobject.bst:
• buildstream/elements/sdk/python2-pygobject.bst:
• buildstream/elements/sdk/rr.bst:
• buildstream/elements/sdk/shared-mime-info.bst:
• buildstream/elements/sdk/v4lutils.bst: Removed.
• buildstream/elements/sdk/woff2.bst:
• buildstream/elements/sdk/xorg-server.bst:
• buildstream/elements/test-infra/httpd.bst:
• buildstream/patches/fdo/0001-Pango-Bump-to-1.45-master.patch: Removed.
• buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Removed.
• buildstream/patches/gtk-meson-Bump-to-latest-version-of-the-3.24-branch.patch: Removed.
• buildstream/patches/libsecret-b53e9876f4611525b7a8f69a3110fbec51dcede0.patch: Removed.
• buildstream/patches/mesa/mesa_libdrm_deps.patch: Added.
• buildstream/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch:

Removed because a variant was landed upstream 2 years ago:
​https://gitlab.freedesktop.org/xorg/xserver/-/commit/319af6f471912160ab3eb6395ef50f9950063d43

• buildstream/project.conf:
• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): White-list a few Mesa environment variables.

2:45 AM Changeset in webkit [266454] by youenn@apple.com

• 4 edits in trunk/Source/WebCore

Safari is not able to hear audio when using WebRTC in multiple tabs
​https://bugs.webkit.org/show_bug.cgi?id=215270
<rdar://problem/66736746>

Reviewed by Eric Carlson.

Covered by manually testing that audio continues when two pages in the same process create a peer connection,
one plays audio with WebRTC and the second one is closed.
Before the patch, the closing page would stop the audio device module, even though the first page would like the module to continue playing.
Fix this by creating an audio module per page instead of process wide.

• platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::initializePeerConnectionFactoryAndThreads):
(WebCore::LibWebRTCProvider::factory):
(WebCore::LibWebRTCProvider::createPeerConnectionFactory):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:

2:31 AM Changeset in webkit [266453] by Diego Pino Garcia

• 5 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update baselines and expectations after r266452.

• platform/glib/TestExpectations:
• platform/glib/fetch/fetch-url-serialization-expected.txt: Update after r266399.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt: Update after r266398.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt: Update after r266417.

1:04 AM Changeset in webkit [266452] by Said Abou-Hallawa

• 4 edits in trunk/Source

Unreviewed, reverting r266449.

Underlying frameworks do not work correctly for loopCount >=
1.

Reverted changeset:

"[CG] REGRESSION (Big Sur): A GIF image with a finite
loopCount loops an extra cycle"
​https://bugs.webkit.org/show_bug.cgi?id=216018
​https://trac.webkit.org/changeset/266449