Timeline

Sep 9, 2020:

11:55 PM Changeset in webkit [266815] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Web Inspector: InvalidCharacterError: The string contains invalid characters.
​https://bugs.webkit.org/show_bug.cgi?id=216138

Patch by Patrick Angle <Patrick Angle> on 2020-09-09
Reviewed by Brian Burg.

Source/WebInspectorUI:

Fixed to no longer use displayName as the identifier for DOMNodeDetailsSidebarPanel when creating a
DetailsSection, which could end up with illegal characters due to the escaping done by
DOMNode.prototype.displayName.

• UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.get escapedIdSelector): Changed to use _idSelector.
(WI.DOMNode.prototype.get escapedClassSelector): Changed to use _classSelector.
(WI.DOMNode.prototype.get unescapedSelector): Added. Uses unescaped forms of _idSelector and _classSelector.
(WI.DOMNode.prototype._idSelector): Added. Supports optionally not escaping the selector.
(WI.DOMNode.prototype._classSelector): Added. Supports optionally not escaping the selector.

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByTarget): Use separate identifier
and title.

LayoutTests:

Added tests for DOMNode.prototype._idSelector(…), DOMNode.prototype._classSelector(…),
DOMNode.prototype.unescapedSelector and DOMNode.prototype.displayName.

• inspector/dom/selector-escapes-expected.txt: Added.
• inspector/dom/selector-escapes.html: Added.

10:01 PM Changeset in webkit [266814] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, update DerivedSources-output.xcfilelist after r266801

Sort the contents of the xcfilelist, and add missing entries for new wrapper objects.

• DerivedSources-output.xcfilelist:

9:47 PM Changeset in webkit [266813] by sbarati@apple.com

• 6 edits
  1 add in trunk

OutOfBoundsSaneChain operations should use their own heap locations
​https://bugs.webkit.org/show_bug.cgi?id=216328
<rdar://problem/68568039>

Reviewed by Keith Miller.

JSTests:

• stress/out-of-bounds-sane-chain-need-their-own-heap-location.js: Added.

(foo):

Source/JavaScriptCore:

There is code in local CSE that does some basic bounds check elimination
for PutByVal. It does this analysis by seeing if a particular heap location
is already defined, and if so, it eliminates the bounds check for the
PutByVal. This doesn't work for OutOfBoundsSaneChain for the obvious reason
that these GetByVals are not proven to be in bounds. So GetByVal's in the
OutOfBoundsSaneChain mode reusing non OutOfBoundsSaneChain heap locations
can lead to a bug where we mistakenly remove a bounds check. The fix is to
have all OutOfBoundsSaneChain operations use distinct heaps, and for CSE to
not query those heaps.

• dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::isAnySaneChain const): Deleted.

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

• dfg/DFGHeapLocation.h:

8:40 PM Changeset in webkit [266812] by rniwa@webkit.org

• 4 edits in trunk

Simplify OptionSet::set
​https://bugs.webkit.org/show_bug.cgi?id=216335

Reviewed by Said Abou-Hallawa.

Source/WTF:

Simplified the implementation of OptionSet::set since we've verified that both clang and gcc
generate comparable code in x86_64 and clang does the same for arm64.

• wtf/OptionSet.h:

(WTF::OptionSet::set):

Tools:

Added a unit test for OptionSet::set.

• TestWebKitAPI/Tests/WTF/OptionSet.cpp:

(WTF_OptionSet.Set):

8:15 PM Changeset in webkit [266811] by Fujii Hironori

• 2 edits in trunk/Tools

Add Visual Studio debugger custom views for NeverDestroyed, LazyNeverDestroyed, VectorBufferBase, Optional, and StringView
​https://bugs.webkit.org/show_bug.cgi?id=216304

Reviewed by Don Olmstead.

• VisualStudio/WebKit.natvis:

7:51 PM Changeset in webkit [266810] by ddkilzer@apple.com

• 3 edits
  1 add in trunk/Source/ThirdParty/libwebrtc

[WebRTC] Fix uninitialized fields in FilterAnalyzer::ConsistentFilterDetector, FilterAnalyzer::FilterAnalysisState and InterArrival::TimestampGroup
<​https://webkit.org/b/216314>

Reviewed by Youenn Fablet.

• Source/webrtc/modules/audio_processing/aec3/filter_analyzer.h:

(webrtc::FilterAnalyzer::ConsistentFilterDetector):

• Initialize fields in declarations. This matches the values set by webrtc::FilterAnalyzer::ConsistentFilterDetector::Reset().

(webrtc::FilterAnalyzer::FilterAnalysisState):

• Initialize fields in declarations. Note that the FilterAnalysis constructor calls FilterAnalyzer::Reset(), which also sets these fields, but after the FilterAnalysisState construtor is called.
• Source/webrtc/modules/remote_bitrate_estimator/inter_arrival.h:

(webrtc::InterArrival::TimestampGroup::TimestampGroup):

• Initialize field in constructor argument list.
• WebKit/0001-fix-216314.patch: Add.

7:47 PM Changeset in webkit [266809] by dino@apple.com

• 57 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::WebGLRenderingContext::getExtension
​https://bugs.webkit.org/show_bug.cgi?id=216337
<rdar://problem/68421590>

Reviewed by Sam Weinig.

Bug 215599 added IsoHeap storage to WebGLExtension, but didn't add it
to any of the subclasses. This causes a crash in ::getExtension because
allocation of the new instance fails.

Add WTF_MAKE_ISO_ALLOCATED_IMPL to the .cpp files, and
WTF_MAKE_ISO_ALLOCATED to the .h files.

This should have been detected by on-device testing, since a debug
build would have asserted because the size passed into the constructor
was different from the actual size of the class.

• html/canvas/ANGLEInstancedArrays.cpp:
• html/canvas/ANGLEInstancedArrays.h:
• html/canvas/EXTBlendMinMax.cpp:
• html/canvas/EXTBlendMinMax.h:
• html/canvas/EXTColorBufferFloat.cpp:
• html/canvas/EXTColorBufferFloat.h:
• html/canvas/EXTColorBufferHalfFloat.cpp:
• html/canvas/EXTColorBufferHalfFloat.h:
• html/canvas/EXTFragDepth.cpp:
• html/canvas/EXTFragDepth.h:
• html/canvas/EXTShaderTextureLOD.cpp:
• html/canvas/EXTShaderTextureLOD.h:
• html/canvas/EXTTextureFilterAnisotropic.cpp:
• html/canvas/EXTTextureFilterAnisotropic.h:
• html/canvas/EXTsRGB.cpp:
• html/canvas/EXTsRGB.h:
• html/canvas/OESElementIndexUint.cpp:
• html/canvas/OESElementIndexUint.h:
• html/canvas/OESStandardDerivatives.cpp:
• html/canvas/OESStandardDerivatives.h:
• html/canvas/OESTextureFloat.cpp:
• html/canvas/OESTextureFloat.h:
• html/canvas/OESTextureFloatLinear.cpp:
• html/canvas/OESTextureFloatLinear.h:
• html/canvas/OESTextureHalfFloat.cpp:
• html/canvas/OESTextureHalfFloat.h:
• html/canvas/OESTextureHalfFloatLinear.cpp:
• html/canvas/OESTextureHalfFloatLinear.h:
• html/canvas/OESVertexArrayObject.cpp:
• html/canvas/OESVertexArrayObject.h:
• html/canvas/WebGLColorBufferFloat.cpp:
• html/canvas/WebGLColorBufferFloat.h:
• html/canvas/WebGLCompressedTextureASTC.cpp:
• html/canvas/WebGLCompressedTextureASTC.h:
• html/canvas/WebGLCompressedTextureATC.cpp:
• html/canvas/WebGLCompressedTextureATC.h:
• html/canvas/WebGLCompressedTextureETC.cpp:
• html/canvas/WebGLCompressedTextureETC.h:
• html/canvas/WebGLCompressedTextureETC1.cpp:
• html/canvas/WebGLCompressedTextureETC1.h:
• html/canvas/WebGLCompressedTexturePVRTC.cpp:
• html/canvas/WebGLCompressedTexturePVRTC.h:
• html/canvas/WebGLCompressedTextureS3TC.cpp:
• html/canvas/WebGLCompressedTextureS3TC.h:
• html/canvas/WebGLCompressedTextureS3TCsRGB.cpp:
• html/canvas/WebGLCompressedTextureS3TCsRGB.h:
• html/canvas/WebGLDebugRendererInfo.cpp:
• html/canvas/WebGLDebugRendererInfo.h:
• html/canvas/WebGLDebugShaders.cpp:
• html/canvas/WebGLDebugShaders.h:
• html/canvas/WebGLDepthTexture.cpp:
• html/canvas/WebGLDepthTexture.h:
• html/canvas/WebGLDrawBuffers.cpp:
• html/canvas/WebGLDrawBuffers.h:
• html/canvas/WebGLLoseContext.cpp:
• html/canvas/WebGLLoseContext.h:

7:35 PM Changeset in webkit [266808] by Lauro Moura

• 2 edits in trunk/Tools

kill-old-processes: Avoid calling kill command with empty string with GNU xargs
​https://bugs.webkit.org/show_bug.cgi?id=216323

Reviewed by Darin Adler.

• BuildSlaveSupport/kill-old-processes:

(main):

5:30 PM Changeset in webkit [266807] by Hector Lopez

• 3 edits in trunk/LayoutTests

[ macOS iOS ] compositing/clipping/border-radius-async-overflow-stacking.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209619

Unreviewed test gardening

• platform/ios-wk2/TestExpectations: now flaky failing on iOS wk2
• platform/mac/TestExpectations: also flaky on BigSur+

4:46 PM Changeset in webkit [266806] by Alan Coon

• 1 copy in tags/Safari-610.2.5

Tag Safari-610.2.5.

4:04 PM Changeset in webkit [266805] by Andres Gonzalez

• 8 edits in trunk/Source/WebCore

Remove unused enum PostType.
​https://bugs.webkit.org/show_bug.cgi?id=216320

Reviewed by Chris Fleizach.

No functionality change.

• Removed the unused enum PostType, since all AX notifications are now

posted asynchronously.

• PostTarget is now an enum class.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postTextStateChangeNotification):

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

• accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):

• accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):

• editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

3:54 PM Changeset in webkit [266804] by timothy_horton@apple.com

• 16 edits in trunk/Source/WebKit

macCatalyst: Form controls behave strangely (like iPhone) in macOS-idiom apps
​https://bugs.webkit.org/show_bug.cgi?id=216326

Reviewed by Wenson Hsieh.

• Shared/UserInterfaceIdiom.h:
• Shared/UserInterfaceIdiom.mm:

(WebKit::userInterfaceIdiomIsPad):
(WebKit::currentUserInterfaceIdiomIsPadOrMac):
(WebKit::setCurrentUserInterfaceIdiomIsPadOrMac):
(WebKit::currentUserInterfaceIdiomIsPad): Deleted.
(WebKit::setCurrentUserInterfaceIdiomIsPad): Deleted.

• Shared/ios/WebPreferencesDefaultValuesIOS.mm:

(WebKit::defaultTextAutosizingUsesIdempotentMode):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/ios/SmartMagnificationController.mm:

(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFormInputSession setAccessoryViewCustomButtonTitle:]):
(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]):
(-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]):
(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView _updateAccessory]):
(shouldShowKeyboardForElement):
(-[WKContentView _shouldUseLegacySelectPopoverDismissalBehavior]):

• UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(WebKit::WebDataListSuggestionsDropdownIOS::show):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingSupported):

• UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker show:fromRect:]):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
(-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):

• UIProcess/ios/forms/WKFormColorControl.mm:

(-[WKFormColorControl initWithView:]):

• UIProcess/ios/forms/WKFormColorPicker.mm:

(-[WKColorPicker initWithView:inPopover:]):
(-[WKColorPicker drawSelectionIndicatorForColorButton:]):

• UIProcess/ios/forms/WKFormSelectControl.mm:

(-[WKFormSelectControl initWithView:]):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
Rename currentUserInterfaceIdiomIsPad to currentUserInterfaceIdiomIsPadOrMac,
and force it to YES on macCatalyst since internally we use it to distinguish
between iPhone and iPad behavior, and (for our behaviors, at least) macCatalyst
should always follow iPad.

We should clean this up, and make all callers make their
iPhone vs. iPad vs. macOS decisions more explicit.

3:45 PM Changeset in webkit [266803] by Alan Bujtas

• 27 edits in trunk

[Repaint] styleWillChange may call repaint on the same renderer multiple times.
​https://bugs.webkit.org/show_bug.cgi?id=216295
<rdar://problem/68538666>

Reviewed by Simon Fraser.

Source/WebCore:

RenderElement::styleWillChange is a virtual function. This function is called whenever the associated RenderStyle changes.
The subclass implementation (e.g. RenderBox::styleWillChange) calls the parent class to make sure the style change is covered properly.
Now in certain cases,

1. this may trigger multiple calls to repaint() (e.g one in each ::styleWillChange implementation)
2. paint invalidation requires absolute coordinates
3. geometry does not change during styleWillChange

it could end up being redundant/unnecessarily expensive.

This patch moves all the style-will-change-requires-repaint logic to one single function so that we can limit the number of repaints.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::issueRepaintBeforeStyleChange):
(WebCore::RenderElement::initializeStyle):
(WebCore::RenderElement::setStyle):
(WebCore::RenderElement::styleWillChange):

• rendering/RenderElement.h:
• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

• compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
• compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
• fast/css-custom-paint/delay-repaint-expected.txt:
• fast/images/async-image-multiple-clients-repaint-expected.txt:
• fast/repaint/focus-ring-repaint-expected.txt:
• fast/repaint/horizontal-bt-overflow-child-expected.txt:
• fast/repaint/horizontal-bt-overflow-parent-expected.txt:
• fast/repaint/horizontal-bt-overflow-same-expected.txt:
• fast/repaint/mutate-non-visible-expected.txt:
• fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
• fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
• fast/repaint/table-row-repaint-expected.txt:
• fast/repaint/vertical-overflow-child-expected.txt:
• fast/repaint/vertical-overflow-parent-expected.txt:
• fast/repaint/vertical-overflow-same-expected.txt:
• svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

3:32 PM WebKitGTK/2.30.x edited by Adrian Perez de Castro

(diff)

3:19 PM Changeset in webkit [266802] by Wenson Hsieh

• 8 edits in trunk/Source

Text copied and pasted from Mac Catalyst apps appears larger than expected
​https://bugs.webkit.org/show_bug.cgi?id=215971
<rdar://problem/65768907>

Reviewed by Tim Horton.

Source/WebKit:

Various pieces of platform logic in Mac Catalyst depend on the user interface idiom (i.e. Mac or iPad) of the
app, as well as the application-wide "scale factor". In the context of this bug, NSAttributedString to RTF data
conversion methods in UIFoundation consult the scale factor of UIiOSMacIdiomManager to determine whether to
emit 0 (standard) or 1 (iOS) for the \cocoatextscaling attribute. The fact that the web process' scale factor
may be out of sync with the UI process' scale factor leads to copied RTF data in the web process appearing
either larger or smaller than expected, due to an incorrect NSTextScalingType value.

To mitigate this (as well as any other issues), we add a mechanism for the UI process to forward the global
scale factor and user interface idiom to the web process inside of the web process creation parameters, and then
use new UIKit SPI to override the scale factor and idiom within the web process.

• Scripts/process-entitlements.sh:

Add a new entitlement needed to use _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

Use _UIApplicationCatalystUserInterfaceIdiom and _UIApplicationCatalystScaleFactor to grab the global user
interface idiom and scale factor, respectively.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Override the idiom and scale factor in the web process with the idiom and scale factor from the UI process,
using the new SPI _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor. As this function hasn't landed
yet, we soft link the function for now to avoid causing the web process to instantly crash on any builds without
the fix for <rdar://problem/68524148>.

Source/WTF:

Add a new flag to guard the presence of _UIApplicationCatalystUserInterfaceIdiom,
_UIApplicationCatalystScaleFactor, and _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.

• wtf/PlatformHave.h:

3:13 PM Changeset in webkit [266801] by weinig@apple.com

• 14 edits
  3 adds in trunk

[WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
​https://bugs.webkit.org/show_bug.cgi?id=216316

Reviewed by Darin Adler.

Source/WebCore:

Split GlobalEventHandlersCSSAnimations.idl, GlobalEventHandlersCSSTransitions.idl and
GlobalEventHandlersPointerEvents.idl out of GlobalEventHandlers.idl to match how they
are specified more closely.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• animation/GlobalEventHandlersCSSAnimations.idl: Added.
• animation/GlobalEventHandlersCSSTransitions.idl: Added.
• dom/GlobalEventHandlers.idl:
• dom/GlobalEventHandlersPointerEvents.idl: Added.

LayoutTests:

• js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

Update for slight enumeration ordering change.

3:11 PM Changeset in webkit [266800] by weinig@apple.com

• 47 edits in trunk/Source/WebCore

[WebIDL] Stop automatically applying the ImplementedBy extended attribute to all partial interfaces/dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=216322

Reviewed by Darin Adler.

When partial interfaces were originally introduced, there were grand ambitions to modularize
and isolate parts of interfaces completely, mostly using the Supplemental<> pattern. As time
has passed, more and more specs have usedd partial just to group things together, and having
it implicitly mean using a class named after the IDL file with some static functions is not
always the right choice. With this change, partial interfaces that want the supplemental style
behavior must opt in, using the extended attribute "ImplementedBy", which is what the code
generators already called this concept internally.

• bindings/scripts/CodeGenerator.pm:

(ProcessInterfaceSupplementalDependencies):
(ProcessDictionarySupplementalDependencies):

• bindings/scripts/CodeGeneratorJS.pm:

(GetFullyQualifiedImplementationCallName):
(AddAdditionalArgumentsForImplementationCall):

• bindings/scripts/IDLAttributes.json:

Remove special casing of partial interfaces / dictionaries automatically getting "ImplementedBy"
applied to all members. Maintain the behavior that "ImplementedBy" is silently ignored when
an attribute has been marked as "Reflect".

• Modules/async-clipboard/NavigatorClipboard.idl:
• Modules/beacon/NavigatorBeacon.idl:
• Modules/cache/DOMWindowCaches.idl:
• Modules/cache/WorkerGlobalScopeCaches.idl:
• Modules/credentialmanagement/NavigatorCredentials.idl:
• Modules/encryptedmedia/NavigatorEME.idl:
• Modules/entriesapi/HTMLInputElementEntriesAPI.idl:
• Modules/fetch/DOMWindowFetch.idl:
• Modules/fetch/WorkerGlobalScopeFetch.idl:
• Modules/gamepad/NavigatorGamepad.idl:
• Modules/geolocation/NavigatorGeolocation.idl:
• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl:
• Modules/mediacapabilities/NavigatorMediaCapabilities.idl:
• Modules/mediasession/HTMLMediaElementMediaSession.idl:
• Modules/mediasource/AudioTrackMediaSource.idl:
• Modules/mediasource/DOMURLMediaSource.idl:
• Modules/mediasource/TextTrackMediaSource.idl:
• Modules/mediasource/VideoTrackMediaSource.idl:
• Modules/mediastream/NavigatorMediaDevices.idl:
• Modules/pictureinpicture/DocumentPictureInPicture.idl:
• Modules/pictureinpicture/HTMLVideoElementPictureInPicture.idl:
• Modules/quota/DOMWindowQuota.idl:
• Modules/quota/NavigatorStorageQuota.idl:
• Modules/quota/WorkerNavigatorStorageQuota.idl:
• Modules/remoteplayback/HTMLMediaElementRemotePlayback.idl:
• Modules/speech/DOMWindowSpeechSynthesis.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdriver/NavigatorWebDriver.idl:
• Modules/webgpu/NavigatorGPU.idl:
• Modules/webgpu/WebGPUDeviceErrorScopes.idl:
• Modules/webgpu/WebGPUDeviceEventHandler.idl:
• Modules/webgpu/WorkerNavigatorGPU.idl:
• Modules/webxr/NavigatorWebXR.idl:
• css/DOMCSSPaintWorklet.idl:
• css/DOMCSSRegisterCustomProperty.idl:
• dom/DocumentFullscreen.idl:
• dom/DocumentStorageAccess.idl:
• dom/DocumentTouch.idl:
• page/NavigatorIsLoggedIn.idl:
• svg/SVGDocument.idl:

Update existing partials to opt into "ImplementedBy" bevahior. A future pass
will go through these and see which ones can be simplified by removing the
indirection without introducing unnecessary modularization changes.

2:30 PM Changeset in webkit [266799] by aakash_jain@apple.com

• 3 edits in trunk/Tools

ews might mark build as successful if tests fail to run
​https://bugs.webkit.org/show_bug.cgi?id=215944

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeLayoutTestsResults.retry_build):
(AnalyzeLayoutTestsResults.start):

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestAnalyzeLayoutTestsResults.test_test_fail_to_runs):

12:56 PM Changeset in webkit [266798] by beidson@apple.com

• 6 edits in trunk

Make sure WKWebsiteDataStore operations reuse existing process pools even when all WKWebViews have closed.
<rdar://problem/62978295> and ​https://bugs.webkit.org/show_bug.cgi?id=216317

Reviewed by Geoffrey Garen.

Source/WebKit:

Covered by new API test.

When WebsiteDataStores are gathering all the NetworkProcesses they might need to message, they miss some
obvious candidates if there are no longer any related WKWebViews.

Fix that by tracking which sessions a NetworkProcess knows about.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::addSession):
(WebKit::NetworkProcessProxy::hasSession const):
(WebKit::NetworkProcessProxy::removeSession):

• UIProcess/Network/NetworkProcessProxy.h:

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::isAssociatedProcessPool const):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

12:47 PM Changeset in webkit [266797] by Chris Dumez

• 5 edits in trunk/Source

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

• platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

• UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::addObserver):
(WebKit::DisplayLink::removeObserver):
(WebKit::DisplayLink::removeObservers):
(WebKit::DisplayLink::displayLinkCallback):
(WebKit::DisplayLink::hasObservers const): Deleted.

• UIProcess/mac/DisplayLink.h:

12:42 PM Changeset in webkit [266796] by commit-queue@webkit.org

• 2 edits in trunk/Tools

run-jsc-stress-test: fix escaping for --gnu-parallel-runner
​https://bugs.webkit.org/show_bug.cgi?id=215887

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-09-09
Reviewed by Keith Miller.

Change the GNU parallel invocation to use double quotes, to be consistent with
the invocation of ssh by the make runner. This should unbreak
--gnu-parallel-runner after the fix in r265204.

• Scripts/run-jsc-stress-tests:

12:41 PM Changeset in webkit [266795] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

BigInt should PACCage its data pointer
​https://bugs.webkit.org/show_bug.cgi?id=216319

Reviewed by Yusuke Suzuki.

• runtime/JSBigInt.h:

11:46 AM Changeset in webkit [266794] by Chris Dumez

• 14 edits in trunk

Stop performing "de-zippering" when applying gain
​https://bugs.webkit.org/show_bug.cgi?id=216288

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:

Source/WebCore:

Stop performing "de-zippering" when applying gain. The latest specification does not indicate we
should perform de-zippering and Blink does not either. This is causing us to fail a WPT test.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::reset):

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::process):
(WebCore::GainNode::reset):

• Modules/webaudio/GainNode.h:
• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::reset):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::process):
(WebCore::WebKitAudioPannerNode::reset):

• Modules/webaudio/WebKitAudioPannerNode.h:
• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyWithGainFrom):

• platform/audio/AudioBus.h:

11:41 AM Changeset in webkit [266793] by Chris Dumez

• 2 edits in trunk/Source/WebCore

ASSERTION FAILED: m_finishedNodes.isEmpty() in AudioContext destructor
​https://bugs.webkit.org/show_bug.cgi?id=105870

Reviewed by Darin Adler.

This assertion indicates that BaseAudioContext::derefFinishedSourceNodes() was not
called before the BaseAudioContext destructor. Normally, derefFinishedSourceNodes()
gets called from BaseAudioContext::handlePostRenderTasks() at the end of rending.
However, BaseAudioContext::handlePostRenderTasks() only calls derefFinishedSourceNodes()
if tryLock() succeeds. Therefore, in case of lock contention, it was possible we would
end up destroying the BaseAudioContext without derefFinishedSourceNodes() having been
called at the end of the rendering.

To address the issue, we now call derefFinishedSourceNodes() after the audio thread is
gone and before the BaseAudioContext gets destroyed, in BaseAudioContext::uninitialize().

No new tests, covered by existing tests that are flaky crashing.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::uninitialize):

11:23 AM Changeset in webkit [266792] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266756. rdar://problem/68584247

Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/68474062> and ​https://bugs.webkit.org/show_bug.cgi?id=216286

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::createScrollbar): Plugin hasn't been destroyed, and there's still a PluginView, but the PluginView isn't in a frame. So null check that.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:23 AM Changeset in webkit [266791] by Alan Coon

• 6 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266616. rdar://problem/68584190

REGRESSION(macOS Big Sur) ​https://magenta.github.io/lofi-player/ is broken
​https://bugs.webkit.org/show_bug.cgi?id=216163
<rdar://problem/68198173>

Reviewed by Eric Carlson.

Source/WebCore:

Address a crash and a backward-compatibility issue on ​https://magenta.github.io/lofi-player/.

Test: webaudio/webkitofflineaudiocontext-startRendering-crash.html

• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/OscillatorNode.idl: Even after fixing the crash, the game would fail to load because it expected window.OscillatorNode to exist. When we started working on modern Web Audio, we renamed the non-standard oscillator node to WebKitOscillatorNode and added a new standards compliant OscillatorNode behind a runtime flag (off by default). As a result, window.OscillatorNode no longer existed on Big Sur, which is not backward compatible. To address the issue, we now expose window.OscillatorNode even if modern unprefixed WebAudio is not enabled and we merely disable its constructor at runtime. The same policy applies to AudioBufferSourceNode & AudioListener because we did the exact same thing for these interfaces.

• Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::startRendering): Make sure we call lazyInitialize() before we start offline rendering. The context may not be initialized yet if no audio nodes were created for this context. This is similar to what is done in our modern Web Audio code in OfflineAudioContext::startOfflineRendering(), which is why the crash was not reproducible when enabling the Modern Web Audio experimental feature.

LayoutTests:

Add layout test that was reproducing the crash on ​https://magenta.github.io/lofi-player/.

• webaudio/webkitofflineaudiocontext-startRendering-crash-expected.txt: Added.
• webaudio/webkitofflineaudiocontext-startRendering-crash.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:21 AM Changeset in webkit [266790] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.5

11:12 AM Changeset in webkit [266789] by graouts@webkit.org

• 5 edits
  4 adds in trunk

REGRESSION (r264856): updating easing on accelerated animation results in incorrect playback
​https://bugs.webkit.org/show_bug.cgi?id=215853
<rdar://problem/67815853>

Reviewed by Simon Fraser.

Source/WebCore:

Stop accelerated animations if the timing function has changed in a way that makes it so that it should
no longer play accelerated, but otherwise simply update their timing properties such that may keep
playing.

Test: webanimations/accelerated-animation-easing-update-after-pause.html

webanimations/accelerated-animation-easing-update-steps-after-pause.html

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::canBeAccelerated const):
(WebCore::KeyframeEffect::updateAcceleratedActions):
(WebCore::KeyframeEffect::animationDidChangeTimingProperties):

• animation/KeyframeEffect.h:

LayoutTests:

Add new tests that check that updating an animation's easing does not stop it.

• platform/win/TestExpectations:
• webanimations/accelerated-animation-easing-update-after-pause-expected.html: Added.
• webanimations/accelerated-animation-easing-update-after-pause.html: Added.
• webanimations/accelerated-animation-easing-update-steps-after-pause-expected.html: Addded.
• webanimations/accelerated-animation-easing-update-steps-after-pause.html: Addded.

11:00 AM Changeset in webkit [266788] by Chris Dumez

• 8 edits in trunk

AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event
​https://bugs.webkit.org/show_bug.cgi?id=216284

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:

Rebaseline test that is now failing because of the fix. The test was not actually running as intended because
it relies on AudioParam.linearRampToValueAtTime(), which was not working until now. I have investigated this
failure and it is actually due to a bug in our AudioBus::copyWithGainFrom() implementation. I will land a
follow-up fix for this.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:

Rebaseline test now that output is different (still passing).

• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:

Rebaseline test that is passing thanks to the fix.

Source/WebCore:

AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event
in the timeline. This is incorrect. We should insert an implicit SetValue event in the timeline if the ramp event is
the first one.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioParam.cpp:
• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::linearRampToValueAtTime):
(WebCore::AudioParamTimeline::exponentialRampToValueAtTime):

• Modules/webaudio/AudioParamTimeline.h:

10:42 AM Changeset in webkit [266787] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

AccessibilityMenuList and MenuListPopup notifications need to be posted asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=216309
<rdar://problem/68108824>

Reviewed by Chris Fleizach.

MenuList notifications were posted synchronously which triggers a DOM
layout and style update in the middle of an ongoing DOM mutation update.
This is unnecessary and, furthermore, causes crashes since the DOM
layout update cannot be re-entrant. This change makes these
notifications asynchronous.

• accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):

9:52 AM Changeset in webkit [266786] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/css/css-text/line-break/line-break-{strict,normal}-015a.xht are a constant ImageOnlyFailure
​https://bugs.webkit.org/show_bug.cgi?id=216315

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:26 AM Changeset in webkit [266785] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

Skip newly imported test that times out sometimes.
​https://bugs.webkit.org/show_bug.cgi?id=216301

• TestExpectations:

imported/w3c/web-platform-tests/selection/dir-manual.html times out. It says it's a manual test. Maybe it should stay skipped forever.

9:14 AM Changeset in webkit [266784] by achristensen@apple.com

• 3 edits
  92 adds in trunk/LayoutTests

Import selection web platform tests
​https://bugs.webkit.org/show_bug.cgi?id=216301

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/selection: Added.
• web-platform-tests/selection/Document-open-expected.txt: Added.
• web-platform-tests/selection/Document-open.html: Added.
• web-platform-tests/selection/META.yml: Added.
• web-platform-tests/selection/addRange-00-expected.txt: Added.
• web-platform-tests/selection/addRange-00.html: Added.
• web-platform-tests/selection/addRange-04-expected.txt: Added.
• web-platform-tests/selection/addRange-04.html: Added.
• web-platform-tests/selection/addRange-08-expected.txt: Added.
• web-platform-tests/selection/addRange-08.html: Added.
• web-platform-tests/selection/addRange-12-expected.txt: Added.
• web-platform-tests/selection/addRange-12.html: Added.
• web-platform-tests/selection/addRange-16-expected.txt: Added.
• web-platform-tests/selection/addRange-16.html: Added.
• web-platform-tests/selection/addRange-20-expected.txt: Added.
• web-platform-tests/selection/addRange-20.html: Added.
• web-platform-tests/selection/addRange-24-expected.txt: Added.
• web-platform-tests/selection/addRange-24.html: Added.
• web-platform-tests/selection/addRange-28-expected.txt: Added.
• web-platform-tests/selection/addRange-28.html: Added.
• web-platform-tests/selection/addRange-32-expected.txt: Added.
• web-platform-tests/selection/addRange-32.html: Added.
• web-platform-tests/selection/addRange-36-expected.txt: Added.
• web-platform-tests/selection/addRange-36.html: Added.
• web-platform-tests/selection/addRange-40-expected.txt: Added.
• web-platform-tests/selection/addRange-40.html: Added.
• web-platform-tests/selection/addRange-44-expected.txt: Added.
• web-platform-tests/selection/addRange-44.html: Added.
• web-platform-tests/selection/addRange-48-expected.txt: Added.
• web-platform-tests/selection/addRange-48.html: Added.
• web-platform-tests/selection/addRange-52-expected.txt: Added.
• web-platform-tests/selection/addRange-52.html: Added.
• web-platform-tests/selection/addRange-56-expected.txt: Added.
• web-platform-tests/selection/addRange-56.html: Added.
• web-platform-tests/selection/addRange-expected.txt: Added.
• web-platform-tests/selection/addRange.htm: Added.
• web-platform-tests/selection/addRange.js: Added.

(testAddRange):
(testAddRangeSubSet):

• web-platform-tests/selection/addRange.tentative-expected.txt: Added.
• web-platform-tests/selection/addRange.tentative.html: Added.
• web-platform-tests/selection/collapse-00-expected.txt: Added.
• web-platform-tests/selection/collapse-00.html: Added.
• web-platform-tests/selection/collapse-15-expected.txt: Added.
• web-platform-tests/selection/collapse-15.html: Added.
• web-platform-tests/selection/collapse-30.html: Added.
• web-platform-tests/selection/collapse-45-expected.txt: Added.
• web-platform-tests/selection/collapse-45.html: Added.
• web-platform-tests/selection/collapse-expected.txt: Added.
• web-platform-tests/selection/collapse.htm: Added.
• web-platform-tests/selection/collapse.js: Added.

(testCollapse):
(testCollapseSubSet):

• web-platform-tests/selection/collapseToStartEnd-expected.txt: Added.
• web-platform-tests/selection/collapseToStartEnd.html: Added.
• web-platform-tests/selection/common.js: Added.

(setupRangeTests):
(getNodeLength):
(furthestAncestor):
(isAncestorContainer):
(nextNode):
(previousNode):
(nextNodeDescendants):
(ownerDocument):
(isAncestor):
(isDescendant):
(getPosition):
(isContained):
(isPartiallyContained):
(indexOf):
(myExtractContents):
(myInsertNode):
(assertNodesEqual):
(getDomExceptionName):
(rangeFromEndpoints):
(setSelectionForwards):
(setSelectionBackwards):
(assertSelectionNoChange):
(isSelectableNode):

• web-platform-tests/selection/deleteFromDocument-expected.txt: Added.
• web-platform-tests/selection/deleteFromDocument.html: Added.
• web-platform-tests/selection/dir-manual-expected.txt: Added.
• web-platform-tests/selection/dir-manual.html: Added.
• web-platform-tests/selection/extend-00-expected.txt: Added.
• web-platform-tests/selection/extend-00.html: Added.
• web-platform-tests/selection/extend-20-expected.txt: Added.
• web-platform-tests/selection/extend-20.html: Added.
• web-platform-tests/selection/extend-40-expected.txt: Added.
• web-platform-tests/selection/extend-40.html: Added.
• web-platform-tests/selection/extend.js: Added.

(testExtendSubSet):
(testExtend):

• web-platform-tests/selection/getRangeAt-expected.txt: Added.
• web-platform-tests/selection/getRangeAt.html: Added.
• web-platform-tests/selection/getSelection-expected.txt: Added.
• web-platform-tests/selection/getSelection.html: Added.
• web-platform-tests/selection/idlharness.window.js: Added.
• web-platform-tests/selection/isCollapsed-expected.txt: Added.
• web-platform-tests/selection/isCollapsed.html: Added.
• web-platform-tests/selection/removeAllRanges-expected.txt: Added.
• web-platform-tests/selection/removeAllRanges.html: Added.
• web-platform-tests/selection/removeRange-expected.txt: Added.
• web-platform-tests/selection/removeRange.html: Added.
• web-platform-tests/selection/script-and-style-elements-expected.txt: Added.
• web-platform-tests/selection/script-and-style-elements.html: Added.
• web-platform-tests/selection/selectAllChildren-expected.txt: Added.
• web-platform-tests/selection/selectAllChildren.html: Added.
• web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt: Added.
• web-platform-tests/selection/selection-select-all-move-input-crash.html: Added.
• web-platform-tests/selection/setBaseAndExtent-expected.txt: Added.
• web-platform-tests/selection/setBaseAndExtent.html: Added.
• web-platform-tests/selection/stringifier.tentative-expected.txt: Added.
• web-platform-tests/selection/stringifier.tentative.html: Added.
• web-platform-tests/selection/test-iframe-expected.txt: Added.
• web-platform-tests/selection/test-iframe.html: Added.
• web-platform-tests/selection/toString-ff-bug-001-expected.txt: Added.
• web-platform-tests/selection/toString-ff-bug-001.html: Added.
• web-platform-tests/selection/type-expected.txt: Added.
• web-platform-tests/selection/type.html: Added.

LayoutTests:

• TestExpectations:
• platform/ios/imported/w3c/web-platform-tests/selection: Added.
• platform/ios/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt: Added.

9:05 AM Changeset in webkit [266783] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder::rebuildLine should just re-initialize the current line
​https://bugs.webkit.org/show_bug.cgi?id=216260

Reviewed by Antti Koivisto.

Now that LineBuilder manages the Line, it can properly reset it when we need it clean for the "rebuild" case.
This patch also makes "line closing" more explicit by calling collapse trailing content + apply run expansion separately.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::open):
(WebCore::Layout::Line::moveLogicalLeft):
(WebCore::Layout::Line::moveLogicalRight):
(WebCore::Layout::Line::clearContent): Deleted.
(WebCore::Layout::Line::availableWidth const):
(WebCore::Layout::Line::lineLogicalWidth const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):
(WebCore::Layout::LineBuilder::rebuildLine):

• layout/inlineformatting/InlineLineBuilder.h:

9:00 AM Changeset in webkit [266782] by svillar@igalia.com

• 7 edits
  1 add in trunk

[WebXR] Implement XRSession end event
​https://bugs.webkit.org/show_bug.cgi?id=216181

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webxr/xrSession_end.https-expected.txt: Added.

Source/WebCore:

Implemented the end event dispatched by the XRSession whenever the shutdown process is executed.

• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::shutdown): Added end event dispatch.

• Modules/webxr/XRSessionEvent.cpp:

(WebCore::XRSessionEvent::create): New method receiving a XRSession.
(WebCore::XRSessionEvent::XRSessionEvent): New constructor receiving a XRSession.
(WebCore::XRSessionEvent::eventInterface const): New. Overrides the Event method.

• Modules/webxr/XRSessionEvent.h: Ditto.

LayoutTests:

• platform/wpe/TestExpectations: Added a new test that passes now.

8:16 AM Changeset in webkit [266781] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Line should not know about floats
​https://bugs.webkit.org/show_bug.cgi?id=216278

Reviewed by Antti Koivisto.

Floats are not part of the line (they only constrain the horizontal space).

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::setHasIntrusiveFloat): Deleted.
(WebCore::Layout::Line::hasIntrusiveFloat const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::commitFloats):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):

• layout/inlineformatting/InlineLineBuilder.h:

7:55 AM Changeset in webkit [266780] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Line::lineLogicalWidth is really the horizontal constraint value
​https://bugs.webkit.org/show_bug.cgi?id=216277

Reviewed by Antti Koivisto.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::open):
(WebCore::Layout::Line::moveLogicalLeft):
(WebCore::Layout::Line::moveLogicalRight):

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::horizontalConstraint const):
(WebCore::Layout::Line::availableWidth const):
(WebCore::Layout::Line::lineLogicalWidth const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):

7:48 AM Changeset in webkit [266779] by Aditya Keerthi

• 31 edits
  9 adds in trunk

[macOS] Add editability to input type=time
​https://bugs.webkit.org/show_bug.cgi?id=216188

Reviewed by Devin Rousso.

Source/WebCore:

This patch adds editability to input type=time by leveraging existing
logic to add editable components to date/time inputs.

DateTime{Hour|Minute|Second|Millisecond|Meridiem}FieldElements were
created to represent the new editable fields. By default, only the
hour and minute fields are displayed. However, the millisecond
and second fields may be added depending on the initial value of
the element, or the value of the step attribute.

Tests: fast/forms/time/time-editable-components/time-editable-components-focus-and-blur-events.html

fast/forms/time/time-editable-components/time-editable-components-keyboard-events.html
fast/forms/time/time-editable-components/time-editable-components-mouse-events.html
fast/forms/time/time-editable-components/time-editable-components-second-and-millisecond-field.html

• css/html.css:

Update stylesheet to handle hour, minute, second, millisecond and meridiem fields.

(input::-webkit-datetime-edit-fields-wrapper):
(input::-webkit-datetime-edit-year-field,):
(input::-webkit-datetime-edit-year-field:focus,):
(input[disabled]::-webkit-datetime-edit-year-field,):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::DateTimeFormatValidator::visitField):
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseChooserOnlyDateAndTimeInputType::attributeChanged):

The step attribute can determine whether the second and/or millisecond
fields are displayed. Consequently, we should update the fields in
m_dateTimeEditElement when the step attribute is changed.

• html/BaseChooserOnlyDateAndTimeInputType.h:

setupLayoutParameters() now takes an additional DateComponents argument.
This argument is needed to determine whether the second and/or
millisecond field is displayed.

• html/BaseDateAndTimeInputType.h:
• html/DateInputType.cpp:

(WebCore::DateInputType::setupLayoutParameters const):

• html/DateInputType.h:
• html/DateTimeFieldsState.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters const):

• html/DateTimeLocalInputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::setupLayoutParameters const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat const):
(WebCore::TimeInputType::formatDateTimeFieldsState const):
(WebCore::TimeInputType::setupLayoutParameters const):

The millisecond field is displayed if the date has a non-zero value for
milliseconds, or if the step attribute has sub-second precision. The
second field is displayed if the millisecond field is displayed, if the
date has a non-zero value for seconds, or if the step attribute has
sub-minute precision.

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::setupLayoutParameters const):

• html/WeekInputType.h:
• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField): Updated to add new field types to the element.

• html/shadow/DateTimeEditElement.h:
• html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHourFieldElement::setValueAsDate):
(WebCore::DateTimeMeridiemFieldElement::DateTimeMeridiemFieldElement):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMeridiemFieldElement::setValueAsDate):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMillisecondFieldElement::setValueAsDate):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMinuteFieldElement::setValueAsDate):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSecondFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeSecondFieldElement::setValueAsDate):

• html/shadow/DateTimeFieldElements.h:
• html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::maximum const):

• html/shadow/DateTimeNumericFieldElement.h:
• html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent): Implement editing using the same typeahead behavior as <select> elements.
(WebCore::DateTimeSymbolicFieldElement::indexOfSelectedOption const):
(WebCore::DateTimeSymbolicFieldElement::optionCount const):
(WebCore::DateTimeSymbolicFieldElement::optionAtIndex const):

• html/shadow/DateTimeSymbolicFieldElement.h:
• platform/text/PlatformLocale.cpp:

(WebCore::Locale::localizedDecimalSeparator):

Added method to ensure the correct decimal separator is displayed
depending on the user's locale. This separator is used when
the millisecond field is present.

• platform/text/PlatformLocale.h:

LayoutTests:

• TestExpectations:
• fast/forms/time/time-editable-components/time-editable-components-focus-and-blur-events-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-focus-and-blur-events.html: Added.
• fast/forms/time/time-editable-components/time-editable-components-keyboard-events-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-keyboard-events.html: Added.
• fast/forms/time/time-editable-components/time-editable-components-mouse-events-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-mouse-events.html: Added.
• fast/forms/time/time-editable-components/time-editable-components-second-and-millisecond-field-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-second-and-millisecond-field.html: Added.
• platform/mac-wk2/TestExpectations:
• platform/mac-wk2/fast/forms/time/time-appearance-basic-expected.txt: Rebaselined for new appearance.
• platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt: Rebaselined for new appearance.

6:37 AM Changeset in webkit [266778] by Alexey Shvayka

• 4 edits in trunk

Don't emitDirectBinding() if there is a [...rest] element binding
​https://bugs.webkit.org/show_bug.cgi?id=216228

Reviewed by Darin Adler.

JSTests:

• test262/expectations.yaml: Mark 12 test cases as passing.

Source/JavaScriptCore:

emitDirectBinding() is up for removal due to not respecting overriden or removed
Array.prototype[Symbol.iterator]. However, dropping it slows down popular swap pattern
[a, b] = [b, a] by 40% with DFG/FTL, and by a factor of 6 with baseline JIT only.

Until we figure out the best way to preserve common case performance, this patch
prevents let [...rest] = [1] from ending up as a number instead of an array,
aligning JSC with V8 and SpiderMonkey.

• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::emitDirectBinding):

4:33 AM Changeset in webkit [266777] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Add Philippe Normand to EWS emails unsubscribe list

Unreviewed.

• BuildSlaveSupport/ews-build/emails.json:

2:03 AM Changeset in webkit [266776] by rniwa@webkit.org

• 10 edits in trunk/Source

Node flags should be an OptionSet
​https://bugs.webkit.org/show_bug.cgi?id=216305

Reviewed by Antti Koivisto.

Source/WebCore:

This patch renames NodeFlags to NodeFlag and turns into an enum class and changes the type of
m_nodeFlags from uint32_t to OptionSet<NodeFlag> as there is no state stored there after r266769.

This patch also introduces two new NodeFlag for identifying CharacterData and DocumentFragment
to simplify the type check conditions for these nodes now that we have plenty of free bits.

No new tests since there should be no behavioral change.

• dom/CharacterData.h:

(WebCore::CharacterData::CharacterData): Sets NodeFlag::IsContainerNode via CreateCharacterData.
(WebCore::CharacterData::virtualIsCharacterData): Deleted.

• dom/Comment.cpp:

(WebCore::Comment::Comment): Ditto.

• dom/Element.cpp:

(WebCore::Element::setHasFocusWithin):
(WebCore::Element::removedFromAncestor):
(WebCore::Element::setContainsFullScreenElement):
(WebCore::Element::createElementIdentifier):

• dom/Element.h:

(WebCore::Element::hasFocusWithin const):
(WebCore::Element::hasPendingResources const):
(WebCore::Element::setHasPendingResources):
(WebCore::Element::clearHasPendingResources):
(WebCore::Element::hasCSSAnimation const):
(WebCore::Element::setHasCSSAnimation):
(WebCore::Element::clearHasCSSAnimation):
(WebCore::Element::containsFullScreenElement const):

• dom/Node.cpp:

(WebCore::Node::insertedIntoAncestor):
(WebCore::Node::removedFromAncestor):

• dom/Node.h:

(WebCore::Node::isElementNode const):
(WebCore::Node::isContainerNode const):
(WebCore::Node::isTextNode const):
(WebCore::Node::isHTMLElement const):
(WebCore::Node::isSVGElement const):
(WebCore::Node::isMathMLElement const):
(WebCore::Node::isStyledElement const):
(WebCore::Node::isCharacterDataNode const): Check the newly added NodeFlag::IsContainerNode.
(WebCore::Node::isDocumentNode const):
(WebCore::Node::isTreeScope const):
(WebCore::Node::isDocumentFragment const):: Check the newly added NodeFlag::IsDocumentFragment.
(WebCore::Node::isShadowRoot const):
(WebCore::Node::hasCustomStyleResolveCallbacks const):
(WebCore::Node::hasSyntheticAttrChildNodes const):
(WebCore::Node::setHasSyntheticAttrChildNodes):
(WebCore::Node::selfOrAncestorHasDirAutoAttribute const):
(WebCore::Node::setSelfOrAncestorHasDirAutoAttribute):
(WebCore::Node::isUserActionElement const):
(WebCore::Node::setUserActionElement):
(WebCore::Node::isEditingText const): Removed the check for IsTextFlag since this is no longer needed
after r266769 as no longer share the bit for IsEditingText with an unknown custom element.
(WebCore::Node::isLink const):
(WebCore::Node::setIsLink):
(WebCore::Node::hasEventTargetData const):
(WebCore::Node::setHasEventTargetData):
(WebCore::Node::isConnected const):
(WebCore::Node::isInShadowTree const):
(WebCore::Node::isInTreeScope const):
(WebCore::Node::flagIsText):
(WebCore::Node::flagIsContainer):
(WebCore::Node::flagIsElement):
(WebCore::Node::flagIsShadowRoot):
(WebCore::Node::flagIsHTML):
(WebCore::Node::flagIsLink):
(WebCore::Node::flagHasFocusWithin):
(WebCore::Node::flagIsParsingChildrenFinished):
(WebCore::Node::NodeFlag): Renamed from NodeFlags and made it an enum class, and introduced IsCharacterData
and IsDocumentFragment and removed "Flag" suffix from various flags.
(WebCore::Node::hasNodeFlag const): Renamed from getFlag for clarity.
(WebCore::Node::setNodeFlag const): Ditto from setFlag. Also merge the two versions of setFlag one of which
took a boolean arugment as the first argument by making this a second optional argument.
(WebCore::Node::clearNodeFlag const): Ditto.
(WebCore::Node::isParsingChildrenFinished const):
(WebCore::Node::setIsParsingChildrenFinished):
(WebCore::Node::clearIsParsingChildrenFinished):
(WebCore::Node::ConstructionType): This is now an alias to OptionSet<NodeFlag> instead of a separate enum.
(WebCore::Node::setHasCustomStyleResolveCallbacks):
(WebCore::Node::virtualIsCharacterData const): Deleted.

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::ProcessingInstruction): Sets NodeFlag::IsContainerNode via CharacterData's
constructor's default argument value.

Source/WTF:

• wtf/OptionSet.h:

(WTF::OptionSet::set): Added.

Sep 8, 2020:

10:14 PM Changeset in webkit [266775] by Lauro Moura

• 2 edits in trunk/Tools

kill-old-processes: Remove stale Apache2 shm segments
​https://bugs.webkit.org/show_bug.cgi?id=216068

Reviewed by Alexey Proskuryakov.

Based on original patch by Diego Pino Garcia.

When Apache2 terminates abruptely, it may not free up allocated shared
memory segments. When later Apache2 is started again, if its pid
matches the pid of orphan shm segments it fails believing there's
already an Apache2 instance running. To avoid this situation, after
killing Apache2 we check for potential orphaned shm segments and
remove them.

If any error happens during the cleanup, log the failure and continue
the script, addressing the issue that caused the initial revert in
r266536.

• BuildSlaveSupport/kill-old-processes:

(removeOrphanShmSegments):
(orphanedShmSegmentsByUser):
(main):

9:37 PM Changeset in webkit [266774] by Fujii Hironori

• 3 edits in trunk/Tools

[WinCairo] TestWTF.WTF.UniqueRef is crashing in Debug builds
​https://bugs.webkit.org/show_bug.cgi?id=216303

Reviewed by Ryosuke Niwa.

The class A of UniqueRef.cpp and CompactUniquePtrTuple.cpp are
conflicting. CRT heap threw an exception due to allocator
mismatching while deleting class A object.

• TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp: Added a new namespace CompactUniquePtrTupleTest.
• TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added a new namespace UniqueRefTest.

(TestWebKitAPI::function): Deleted an unused function.

9:32 PM Changeset in webkit [266773] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed test gardening after r266761.

• platform/mac/TestExpectations: This should have been Mojave, not HighSierra.

9:27 PM Changeset in webkit [266772] by timothy_horton@apple.com

• 3 edits in trunk/LayoutTests

[ iOS wk2 ] fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216300
<rdar://problem/68542670>

Reviewed by Wenson Hsieh.

• fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html:

shouldBecomeDifferent only works if both of the strings it evals are evaluable in the global scope.

• platform/ios-wk2/TestExpectations:

Remove the failure expectation.

9:12 PM Changeset in webkit [266771] by Chris Dumez

• 9 edits in trunk/Source/WebKit

Regression(r260614) Power usage has increased due to extra thread hopping
​https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>

Reviewed by Simon Fraser.

Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.

• UIProcess/WebPageProxy.cpp:

(WebKit::ScrollingObserver::willSendWheelEvent):
(WebKit::ScrollingObserver::ScrollingObserver):
(WebKit::ScrollingObserver::singleton):
(WebKit::WebPageProxy::sendWheelEvent):

• UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::displayLinkCallback):

• UIProcess/mac/DisplayLink.h:

(WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed):
(WebKit::EventDispatcher::displayWasRefreshed):

• WebProcess/WebPage/EventDispatcher.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::displayWasRefreshed):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

8:48 PM Changeset in webkit [266770] by ysuzuki@apple.com

• 7 edits
  1 add in trunk

[JSC] returnEarlyFromInfiniteLoopsForFuzzing should return object
​https://bugs.webkit.org/show_bug.cgi?id=216289
<rdar://problem/68496533>

Reviewed by Saam Barati.

JSTests:

• stress/construct-return-early-from-infinite-loop-for-fuzzer.js: Added.

(foo):

Source/JavaScriptCore:

When returning early with returnEarlyFromInfiniteLoopsForFuzzing, we are returning with undefined.
But this is wrong when the callee is constructor since constructor is strongly assumed that it returns an object.
We should return some object from returnEarlyFromInfiniteLoopsForFuzzing. In this patch, we return global object
associated to this callee instead of undefined

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::~CodeBlock):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileLoopHint):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_hint):

• llint/LowLevelInterpreter64.asm:

8:32 PM Changeset in webkit [266769] by rniwa@webkit.org

• 9 edits in trunk/Source/WebCore

Having an iframe as a descendent node shouldn't require ElementRareData
​https://bugs.webkit.org/show_bug.cgi?id=216264

Reviewed by Darin Adler.

Store the number of connected frames in the descendent nodes directly in Node using CompactUniquePtrTuple
in the same space as where we store the NodeRareData pointer. This avoids creating ElementRareData on every
ancestor element and shadow host / document of an iframe.

Also moved TabIndexState there to simply NodeFlags, and created CustomElementState to replace the existing
flags in NodeFlags to match the latest terminology used in the specification:
​https://dom.spec.whatwg.org/#concept-element-custom-element-state

CustomElementState has four states: "uncustomized" (default; builtin elements), "undefined" (i.e. element has
a valid custom element but it hasn't been defined or upgraded yet), "custom" (a valid custom element instance),
and "failed" (upgrading has resulted in an error). Before this patch, "uncustomized" meant that neither
IsCustomElement nor IsEditingTextOrUndefinedCustomElementFlag is set, "undefined" had IsCustomElement
and IsEditingTextOrUndefinedCustomElementFlag set, and "custom" had IsCustomElement set but
IsEditingTextOrUndefinedCustomElementFlag unset whereas "failed" had the opposite.

No new tests since there should be no observable behavioral change.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild): Mask out the bits stored in
the pointer in the 64-bit architecture. In the 32-bit architecture, the pointer is the first component
without any extra bits stored in it.

• dom/Element.cpp:

(WebCore::Node::setTabIndexState): Moved from Node.h. Updated to use the newly introduced bitfields.
(WebCore::Node::setCustomElementState): Added.
(WebCore::Element::setIsDefinedCustomElement): Now updates CustomElementState in the newly added bitfields.
(WebCore::Element::setIsFailedCustomElementWithoutClearingReactionQueue): Ditto.
(WebCore::Element::setIsCustomElementUpgradeCandidate): Ditto.

• dom/ElementRareData.cpp:
• dom/ElementRareData.h:

(WebCore::ElementRareData): Moved m_unusualTabIndex and m_childIndex to NodeRareData for better packing.

• dom/Node.cpp:

(WebCore::Node::materializeRareData):
(WebCore::Node::clearRareData):
(WebCore::Node::connectedSubframeCount const): Moved to the header file.
(WebCore::Node::incrementConnectedSubframeCount): Now updates the newly added bitfields.
(WebCore::Node::decrementConnectedSubframeCount): Ditto.

• dom/Node.h:

(WebCore::Node::isUndefinedCustomElement const): Now uses CustomElementState in the newly added bitfields.
(WebCore::Node::isCustomElementUpgradeCandidate const): Ditto.
(WebCore::Node::isDefinedCustomElement const): Ditto.
(WebCore::Node::isFailedCustomElement const): Ditto.
(WebCore::Node::isEditingText const):
(WebCore::Node::connectedSubframeCount const): Moved here from cpp file.
(WebCore::Node::rareDataMemoryOffset):
(WebCore::Node::rareDataPointerMask): Added.
(WebCore::Node::CustomElementState): Added.
(WebCore::Node::RareDataBitFields): Added.
(WebCore::Node::rareDataBitfields const): Added.
(WebCore::Node::setRareDataBitfields): Added.
(WebCore::Node::tabIndexState const): Updated to use rareDataBitfields.
(WebCore::Node::setTabIndexState): Moved to Element.cpp.
(WebCore::Node::customElementState const): Added.
(WebCore::Node::hasRareData const):
(WebCore::Node::rareData const):

• dom/NodeRareData.cpp:
• dom/NodeRareData.h:

(WebCore::NodeRareData::UseType): Removed ConnectedFrameCount.
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::useTypes const):
(WebCore::NodeRareData::connectedSubframeCount const): Deleted.
(WebCore::NodeRareData::incrementConnectedSubframeCount): Deleted.
(WebCore::NodeRareData::decrementConnectedSubframeCount): Deleted.
(WebCore::NodeRareData): Moved m_unusualTabIndex and m_childIndex here for better packing in 64-bit architecture.

8:14 PM Changeset in webkit [266768] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

WebCore UnifiedSource81 builds for upwards of 10 minutes
​https://bugs.webkit.org/show_bug.cgi?id=216297

Reviewed by Simon Fraser.

• bindings/js/WebCoreBuiltinNames.h:

(WebCore::WebCoreBuiltinNames::WebCoreBuiltinNames):
Work around an LLVM regression by disabling debugging in the
WebCoreBuiltinNames constructor. This is tracked by <rdar://68246686>.

This drops the WebCore release build time on my iMac Pro from 14 minutes to 6.

6:35 PM Changeset in webkit [266767] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 ] fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216300

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

6:00 PM Changeset in webkit [266766] by Megan Gardner

• 2 edits in trunk/Source/WebKit

Removed unneeded respondsToSelector checks on UIWKTextInteractionAssistant in WKContentViewInteraction.
​https://bugs.webkit.org/show_bug.cgi?id=216204

Reviewed by Wenson Hsieh.

Over the years, we have had many selection and text interaction assistants, that may not have all
responded to the selectors we expect them to. This has left many respondsToSelector checks around that
should be removed, as they are unnecessary and an unneeded performance hit.

No behavior change, covered by existing tests.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _willStartScrollingOrZooming]):
(-[WKContentView _didEndScrollingOrZooming]):

5:52 PM Changeset in webkit [266765] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215353

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-09-08
Reviewed by Geoffrey Garen.

This patch reverts r265780 and goes in the opposite direction: allocating
lots and lots of objects, then proving that the number of live objects
did not grow a lot.

GCController can be conservative sometimes and leaves some objects here
and there. So we should not be checking that *all* the objects were freed
to verify there was no leak in allocating the SVG properties objects.

Instead we can check for an end-to-end test the memory did not grow a lot
despite the huge number of allocations.

• svg/animations/smil-leak-element-instances-noBaseValRef.svg:

5:41 PM Changeset in webkit [266764] by Hector Lopez

• 3 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/IndexedDB/blob-valid-after-deletion.any.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216298

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac/TestExpectations:

5:23 PM Changeset in webkit [266763] by Chris Dumez

• 4 edits
  2 adds in trunk

Drop non-standard name / units attributes from AudioParam
​https://bugs.webkit.org/show_bug.cgi?id=216290

Reviewed by Geoffrey Garen.

Source/WebCore:

Drop non-standard name / units attributes from AudioParam:

• ​https://www.w3.org/TR/webaudio/#AudioParam

Blink does not have them either.

Test: webaudio/audioparam-obsolete-api.html

• Modules/webaudio/AudioParam.h:
• Modules/webaudio/AudioParam.idl:

LayoutTests:

Add layout test coverage.

• webaudio/audioparam-obsolete-api-expected.txt: Added.
• webaudio/audioparam-obsolete-api.html: Added.

5:16 PM Changeset in webkit [266762] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Drop unnecessary AudioParam::m_smoothingConstant data member
​https://bugs.webkit.org/show_bug.cgi?id=216291

Reviewed by Geoffrey Garen.

Drop unnecessary AudioParam::m_smoothingConstant data member. This constant is never changed.

No new tests, no web-facing behavior change.

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::smooth):

• Modules/webaudio/AudioParam.h:

4:47 PM Changeset in webkit [266761] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Update imported/w3c/web-platform-tests/css/css-text/line-break/line-break-{strict,normal}-015.xht
​https://bugs.webkit.org/show_bug.cgi?id=209250

Unreviewed test gardening.

• platform/mac/TestExpectations: Limit image failure expectation to High Sierra & Catalina.

4:41 PM Changeset in webkit [266760] by Ryan Haddad

• 2 edits in trunk/LayoutTests

[ Mac ] fast/history/page-cache-webdatabase-pending-transaction.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=207010

Unreviewed test gardening.

• platform/mac/TestExpectations: The test isn't consistently timing out,

so mark it as flaky instead.

4:39 PM Changeset in webkit [266759] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Release ] imported/w3c/web-platform-tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216292

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:32 PM Changeset in webkit [266758] by Ryan Haddad

• 4 edits in trunk/LayoutTests

http/tests/history/back-with-fragment-change.php fails
​https://bugs.webkit.org/show_bug.cgi?id=68278

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: Mark test as consistently failing for macOS WK1.
• platform/mac-wk2/TestExpectations: Mark test as flaky for macOS WK2.
• platform/mac/TestExpectations: Remove general Mac expectation.

4:03 PM Changeset in webkit [266757] by Lauro Moura

• 2 edits in trunk/Source/WebKit

NetworkProcess: Check for invalid handle before writing salt file
​https://bugs.webkit.org/show_bug.cgi?id=216285

Reviewed by Sihui Liu.

Covered by existing tests.

Fixes crashes in GTK/WPE after r266742.

• NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::readOrMakeSalt):

3:58 PM Changeset in webkit [266756] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/68474062> and ​https://bugs.webkit.org/show_bug.cgi?id=216286

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::createScrollbar): Plugin hasn't been destroyed, and there's still a PluginView,

but the PluginView isn't in a frame. So null check that.

3:09 PM Changeset in webkit [266755] by Alan Coon

• 1 copy in tags/Safari-610.1.28.10.1

Tag Safari-610.1.28.10.1.

2:51 PM Changeset in webkit [266754] by Chris Dumez

• 19 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky webaudio WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:

2:46 PM Changeset in webkit [266753] by weinig@apple.com

• 40 edits
  1 move
  9 adds
  2 deletes in trunk/Source/WebCore

[WebIDL] Add support for partial interface mixins
​https://bugs.webkit.org/show_bug.cgi?id=216255

Reviewed by Darin Adler.

Add support for WebIDL 'partial interface mixins' and adopt them for a few
supplements of the DocumentOrShadowRoot mixin.

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• dom/DocumentOrShadowRoot.idl:
• css/DocumentOrShadowRootStyleSheets.idl: Added.
• dom/DocumentOrShadowRootPointerLock.idl: Added.
• Modules/pictureinpicture/DocumentOrShadowRootPictureInPicture.idl: Added.
• animation/DocumentOrShadowRootAnimations.idl: Added.

Add new split-out IDLs.

• bindings/scripts/CodeGenerator.pm:

(GenerateEmptyHeaderAndCpp):
Move empty file generation here (from generate-bindings.pl), allowing
for a simplified compilation model, where all IDLs given to generate-bindings.pl
now instantiate the CodeGenerator and it is the CodeGenerators job to figure
out if the file needs anything generated. This allows the dependencies file
to get out of the business of indicating that an IDL doesn't need generation,
and stick to just listing dependencies. This is important now that dependencies
like interface mixins can now have depencies of their own, partial interface mixins.

(ProcessInterfaces):
(ProcessDictionaries):
Move logic to avoid generation of mixins and partials here.

(ProcessInterfaceSupplementalDependencies):
Support recursively processing supplemental dependencies for partial interface
mixins. Ensure that we don't evaluate exposure when doing this, as that should
only happen on the final interface.

(shouldPropertyBeExposed):
Move all logic for exposure here, rather than splitting it up between here
and ProcessInterfaceSupplementalDependencies/ProcessDictionarySupplementalDependencies

• bindings/scripts/generate-bindings.pl:

(generateBindings):
(generateEmptyHeaderAndCpp): Deleted.
Remove support for unused additionalIdlFiles option and simplify things
by having CodeGenerator work out whether it should generate an empty set of
files based on the files themselves rather than inferring it from the dependency
information.

• bindings/scripts/preprocess-idls.pl:

(getPartialNamesFromIDL):
Add support for properly parsing partial interface mixins and stop disallowing
dependencies, like a mixin interface, from having its own dependences.

• bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:
• bindings/scripts/test/JS/JSTestConditionalIncludes.h:
• bindings/scripts/test/JS/JSTestIncludes.cpp: Removed.
• bindings/scripts/test/JS/JSTestIncludes.h: Removed.
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/JS/JSTestMixinInterface.cpp: Added.
• bindings/scripts/test/JS/JSTestMixinInterface.h: Added.
• bindings/scripts/test/JS/JSTestPartialMixinInterface.cpp: Added.
• bindings/scripts/test/JS/JSTestPartialMixinInterface.h: Added.
• bindings/scripts/test/SupplementalDependencies.dep:
• bindings/scripts/test/TestConditionalIncludes.idl:
• bindings/scripts/test/TestIncludes.idl: Removed.
• bindings/scripts/test/TestInterface.idl:
• bindings/scripts/test/TestMixinInterface.idl: Added.
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestPartialMixinInterface.idl: Added.

Rename TestIncludes to TestMixinInterface (since that is what it is testing)
and add TestPartialMixinInterface to test partial interface mixins.

2:40 PM Changeset in webkit [266752] by Peng Liu

• 2 edits in trunk/Source/WebCore

Web process crashes at WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby
​https://bugs.webkit.org/show_bug.cgi?id=216283

Reviewed by Alex Christensen.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby):

2:33 PM Changeset in webkit [266751] by Jonathan Bedard

• 3 edits in trunk/Tools

[webkitcorepy] Register another package in the WebKit repository (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=216013
<rdar://problem/68097461>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.register): Use pypiname instead of the package name.

2:10 PM Changeset in webkit [266750] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Null check m_layerHostingContext in TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=216282
<rdar://problem/64933878>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-08
Reviewed by Tim Horton.

There's no reason to dereference null here. Let's not crash.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded):

2:10 PM Changeset in webkit [266749] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION(r266681) [GTK] constexpr build failure in LTS/Debian with GCC 8
​https://bugs.webkit.org/show_bug.cgi?id=216280

Patch by Lauro Moura <Lauro Moura> on 2020-09-08
Reviewed by Darin Adler and Alex Christensen.

• platform/text/TextCodecSingleByte.cpp:

(WebCore::tableForDecoding):

2:08 PM Changeset in webkit [266748] by achristensen@apple.com

• 8 edits in trunk

new URL("#") should throw an error
​https://bugs.webkit.org/show_bug.cgi?id=216115

Reviewed by Yusuke Suzuki and Darin Adler.

Source/WebCore:

This aligns the DOM URL object with the specification and Firefox.
Covered by adding to fast/dom/DOMURL/url-constructor.html.

• html/DOMURL.cpp:

(WebCore::DOMURL::create):

• html/DOMURL.h:

LayoutTests:

• fast/dom/DOMURL/url-constructor-expected.txt:
• fast/dom/DOMURL/url-constructor.html:
• inspector/unit-tests/url-utilities.html:
• inspector/unit-tests/url-utilities-expected.txt:

1:32 PM Changeset in webkit [266747] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

re-enable TCSM on all OSs
​https://bugs.webkit.org/show_bug.cgi?id=216281

Reviewed by Tadeu Zagallo.

• runtime/Options.cpp:

(JSC::defaultTCSMValue):

1:24 PM Changeset in webkit [266746] by Chris Dumez

• 17 edits in trunk

Fix precision issues in AudioParamTimeline when event times are very close
​https://bugs.webkit.org/show_bug.cgi?id=216279

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-close-expected.txt:

Rebaseline test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-exponentialRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:

Rebaseline tests whose output has changed very slightly.

Source/WebCore:

Fix precision issues in AudioParamTimeline when event times are very close. To achieve this,
AudioParamTimeline::valuesForTimeRange() now uses frames for the range instead of time.
frames have the benefit of being more exact.

This change is based on audio_param_timeline.cc from Blink:

• ​https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc

No new tests, rebaselined existing test.

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateTimelineValues):

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
(WebCore::AudioParamTimeline::isEventCurrent const):

• Modules/webaudio/AudioParamTimeline.h:

LayoutTests:

Rebaseline tests whose output has changed very slightly.

• webaudio/audioparam-cancel-and-hold-expected.txt:
• webaudio/oscillator-custom-expected.wav:
• webaudio/oscillator-sawtooth-expected.wav:
• webaudio/oscillator-square-expected.wav:
• webaudio/oscillator-triangle-expected.wav:

1:24 PM Changeset in webkit [266745] by youenn@apple.com

• 12 edits in trunk/Source

Tighten checks when creating an audio buffer list
​https://bugs.webkit.org/show_bug.cgi?id=216237
<rdar://problem/68271376>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add a routine to check there is no multiplication integer overflow.

• platform/audio/cocoa/WebAudioBufferList.cpp:

(WebCore::computeBufferSize):
(WebCore::WebAudioBufferList::isSupportedDescription):
(WebCore::WebAudioBufferList::setSampleCount):

• platform/audio/cocoa/WebAudioBufferList.h:

Source/WebKit:

Add message checks to verify that no message integer overflows happen when processing audio buffer list messages.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::audioTrackRendererManager):

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:

(WebKit::RemoteAudioMediaStreamTrackRenderer::RemoteAudioMediaStreamTrackRenderer):
(WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):
(WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesAvailable):

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp:

(WebKit::RemoteAudioMediaStreamTrackRendererManager::RemoteAudioMediaStreamTrackRendererManager):
(WebKit::RemoteAudioMediaStreamTrackRendererManager::createRenderer):

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
• GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
(WebKit::RemoteMediaRecorder::audioSamplesAvailable):

• GPUProcess/webrtc/RemoteMediaRecorder.h:
• WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

(WebKit::RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable):

12:49 PM Changeset in webkit [266744] by Fujii Hironori

• 2 edits in trunk/Tools

[Win] MiniBrowser URL bar can't insert a longer text than the window width
​https://bugs.webkit.org/show_bug.cgi?id=216252

Reviewed by Per Arne Vollan.

• MiniBrowser/win/MainWindow.cpp:

(MainWindow::createToolbar): Set ES_AUTOHSCROLL and for the URL
bar edit control. Removed ES_AUTOVSCROLL for it since it doesn't
scroll vertically.

12:47 PM Changeset in webkit [266743] by timothy_horton@apple.com

• 20 edits
  3 adds in trunk

iOS: <attachment>'s QuickLook thumbnails can appear squished
​https://bugs.webkit.org/show_bug.cgi?id=216209
<rdar://problem/67817706>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html

• html/HTMLAttachmentElement.idl:
• testing/Internals.cpp:

(WebCore::Internals::attachmentThumbnailInfo):

• testing/Internals.h:
• testing/Internals.idl:

Expose the attachment thumbnail size via Internals.

• rendering/RenderThemeIOS.mm:

(WebCore::RenderAttachmentInfo::RenderAttachmentInfo):
Allow the thumbnail aspect ratio to vary, instead of assuming it is always square.

Source/WebKit:

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::convertPlatformImageToBitmap):
Propagate an image of the same aspect ratio that QuickLook provided,
instead of squishing it to square.

• UIProcess/QuickLookThumbnailLoader.mm:

(-[WKQLThumbnailLoadOperation start]):
Only request full thumbnails; we do not want the icon form, since <attachment>
already has one without QuickLook's help; if we can't get a full thumbnail,
we'll just leave it alone.

Tools:

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::insertAttachmentForFilePath):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::currentTestURL const):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::insertAttachmentForFilePath):
Make it possible to insert an attachment wrapping a file on disk
via UIScriptController.

LayoutTests:

• fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
• fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: Added.
• fast/attachment/resources/400x200-circle.png: Added.
• platform/ios/fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
• resources/ui-helper.js:

(window.UIHelper.insertAttachmentForFilePath):
Add a test that dumps the thumbnail size for a 400x200 attachment.
We only run it on iOS, because on macOS, QuickLook always returns
an image of the size we ask for (400x400), padded with whitespace,
so the problem does not reproduce and the test doesn't work right there.
On iOS, the result used to be 400x400 and now is 400x200.

I tried and failed to make a more useful test (a ref test, actually
testing the presentation) because it's quite hard to match the
native <attachment> painting.

12:37 PM Changeset in webkit [266742] by sihui_liu@apple.com

• 8 edits in trunk/Source

Remove storage WorkQueue in NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=216199

Reviewed by Youenn Fablet.

Source/WebCore:

Move origin fetching code from NetworkProcess to IDBServer.

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::collectOriginsForVersion const):
(WebCore::IDBServer::IDBServer::getOrigins const):

• Modules/indexeddb/server/IDBServer.h:

Source/WebKit:

The only meaningful usage of this WorkQueue is iterating IndexedDB directories and collecting origins, while
there can be some IDB thread accessing the same directories. To remove the race, Let's just drop this WorkQueue
and fetch origins via WebIDBServer.

• NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::getOrigins):

• NetworkProcess/IndexedDB/WebIDBServer.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::addSessionStorageQuotaManager):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::addIndexedDatabaseSession):
(WebKit::NetworkProcess::addServiceWorkerSession):
(WebKit::NetworkProcess::ensurePathExists): Deleted.
(WebKit::NetworkProcess::postStorageTask): Deleted.
(WebKit::NetworkProcess::performNextStorageTask): Deleted.
(WebKit::NetworkProcess::collectIndexedDatabaseOriginsForVersion): Deleted.
(WebKit::NetworkProcess::indexedDatabaseOrigins): Deleted.

• NetworkProcess/NetworkProcess.h:

12:29 PM Changeset in webkit [266741] by aakash_jain@apple.com

• 3 edits in trunk/Tools

EWS should set cq- flag when a patch fails to build or introduces layout-test failures
​https://bugs.webkit.org/show_bug.cgi?id=214194

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.start): Set cq- on patch when patch fails to build.
(AnalyzeLayoutTestsResults.report_failure): Set cq- on patch when patch introduces layout-test failures.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

12:25 PM Changeset in webkit [266740] by commit-queue@webkit.org

• 5 edits
  8 adds in trunk

CoreImage Implementation of CSS Filters invert(), opacity(), brightness(), contrast()
​https://bugs.webkit.org/show_bug.cgi?id=215956

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-09-08
Reviewed by Darin Adler.

Source/WebCore:

Adding CoreImage support for 4 more CSS filters, invert, opacity, brightness, contrast,
which all uses FEComponentTransfer and the linear transfer function. Partially implemented
FEComponentTransfer to support linear function type so that the 4 CSS filters work properly

Tests: css3/filters/effect-brightness-square.html

css3/filters/effect-contrast-square.html
css3/filters/effect-invert-square.html
css3/filters/effect-opacity-square.html

• platform/graphics/coreimage/FilterEffectRendererCoreImage.h:
• platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:

(WebCore::FilterEffectRendererCoreImage::isNullOrLinearComponentTransferFunction):

currently CoreImage can only render FEComponentTransfer filters if the transfer funtion
is only linear. A FEComponentTransfer filter using only linear function would have it's
red, green, blue, alpha functions types either be linear or null.

(WebCore::FilterEffectRendererCoreImage::supportsCoreImageRendering):

currently CoreImage can only render FEComponentTransfer filters if the transfer funtion
is only linear.

(WebCore::FilterEffectRendererCoreImage::connectCIFilters):

now returns image for FEComponentTransfer

(WebCore::FilterEffectRendererCoreImage::imageForFEComponentTransfer):

function that uses CIFilters to render FEComponentTransfer.

• platform/graphics/filters/FEComponentTransfer.h:

(isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to FEComponentTransfer

LayoutTests:

• css3/filters/effect-brightness-square-expected.html: Added.
• css3/filters/effect-brightness-square.html: Added.
• css3/filters/effect-contrast-square-expected.html: Added.
• css3/filters/effect-contrast-square.html: Added.
• css3/filters/effect-invert-square-expected.html: Added.
• css3/filters/effect-invert-square.html: Added.
• css3/filters/effect-opacity-square-expected.html: Added.
• css3/filters/effect-opacity-square.html: Added.

12:22 PM Changeset in webkit [266739] by Aditya Keerthi

• 4 edits
  2 adds in trunk

[macOS] Date/time inputs should preserve focus on value change
​https://bugs.webkit.org/show_bug.cgi?id=216272

Reviewed by Wenson Hsieh.

Source/WebCore:

When the value of a date/time input is changed programmatically, the
inner elements of the input are rebuilt. Removing an inner element
that is focused results in the document's activeElement being nulled
out, and the date/time input loses focus.

To fix this issue, check to see whether the input has a focused field
prior to rebuilding. If there is a focused field, make an attempt to
focus the new field with the matching pseudo identifier. This ensures
that the focused field is preserved. If no matching identifier is found,
focus the first field to ensure the date/time input retains focus. The
second case can occur when the new value has different fields than the
old value, for example the presence/lack of a millisecond field in a
time input.

Test: fast/forms/date/date-preserve-focus-value-change.html

• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::focusedFieldElement const):
(WebCore::DateTimeEditElement::layout):

• html/shadow/DateTimeEditElement.h:

LayoutTests:

• fast/forms/date/date-preserve-focus-value-change-expected.txt: Added.
• fast/forms/date/date-preserve-focus-value-change.html: Added.

12:11 PM Changeset in webkit [266738] by youenn@apple.com

• 2 edits in trunk/LayoutTests

Fix Internals::supportsVCPEncoder on BigSur
​https://bugs.webkit.org/show_bug.cgi?id=216174
<rdar://problem/66492801>

Reviewed by Geoffrey Garen.

• platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:

Increase timeout.

12:03 PM Changeset in webkit [266737] by youenn@apple.com

• 2 edits in trunk/LayoutTests

Do not use mouse events in http/wpt/html/dom/elements/images/hover-image-change.html
​https://bugs.webkit.org/show_bug.cgi?id=216265

Reviewed by Antti Koivisto.

• http/wpt/html/dom/elements/images/hover-image-change.html:

Mouse events do not work in iOS. Instead, use style change through changing class of an element.

11:55 AM Changeset in webkit [266736] by Megan Gardner

• 4 edits in trunk/Source

Switch from deprecated secondarySelectedControlColor to unemphasizedSelectedContentBackgroundColor.
​https://bugs.webkit.org/show_bug.cgi?id=216207

Reviewed by Darin Adler.

Source/WebCore:

No behavior change.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::systemColor const):

Source/WebKitLegacy/mac:

• Plugins/WebPluginController.mm:

(-[WebPluginController webPlugInContainerSelectionColor]):

11:49 AM Changeset in webkit [266735] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Incorrect decimal separator in Network web inspector
​https://bugs.webkit.org/show_bug.cgi?id=216177

Patch by Patrick Angle <Patrick Angle> on 2020-09-08
Reviewed by Brian Burg.

Removed separate bytes and suffix pieces for resources sizes, allowing the suffix to be localized and the number
to be correctly formatted for the locale.

• UserInterface/Base/Utilities.js: Number.bytesToString(...) now accepts a byte threshold to support

ResourceSizesContentView where we want less jitter between B and KB as you up/down through resources.

• UserInterface/Views/ResourceSizesContentView.css:

(.resource-sizes > .content > section.network .bytes): Adopted text-align from .bytes-group.
(.resource-sizes > .content > section.network .bytes-group): Deleted.
(.resource-sizes > .content > section.network .suffix): Deleted.

• UserInterface/Views/ResourceSizesContentView.js: No longer using a separate suffix element for sizes.

(WI.ResourceSizesContentView.prototype.initialLayout.createSizeComponents):
(WI.ResourceSizesContentView.prototype.initialLayout):
(WI.ResourceSizesContentView.prototype._formattedSizeComponent): Replaces _sizeComponents.
(WI.ResourceSizesContentView.prototype._refreshResourceSizeSection):
(WI.ResourceSizesContentView.prototype._sizeComponents): Deleted.

11:33 AM Changeset in webkit [266734] by Alan Coon

• 8 edits in branches/safari-610.1.28.10-branch/Source

Versioning.

WebKit-7610.1.28.10.1

11:29 AM Changeset in webkit [266733] by Alan Coon

• 1 copy in branches/safari-610.1.28.10-branch

New branch.

11:07 AM Changeset in webkit [266732] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.8

Tag Safari-610.1.28.1.8.

11:03 AM Changeset in webkit [266731] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.8

10:56 AM Changeset in webkit [266730] by aakash_jain@apple.com

• 6 edits in trunk/Tools

Use https urls instead of http in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=216276

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/checkout/scm/scm_mock.py:
• Scripts/webkitpy/common/config/urls.py:
• Scripts/webkitpy/common/config/urls_unittest.py: Changed few http urls to https, leaving a mix of http and https for testing.
• Scripts/webkitpy/common/config/watchlist:
• Scripts/webkitpy/style/checkers/cpp.py:

10:51 AM Changeset in webkit [266729] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Derive big5, jis0208 and jis0212 tables from ICU
​https://bugs.webkit.org/show_bug.cgi?id=216253

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-08
Reviewed by Darin Adler.

This substantially reduces the size of WebCore's binary data without changing behavior.
The EUC-KR table has so many differences from ICU it isn't worth the extraction.
Verified by many assertions and web platform tests.

• platform/text/EncodingTables.cpp:

(WebCore::jis0208):
(WebCore::jis0212):
(WebCore::big5):
(WebCore::eucKR):
(WebCore::checkEncodingTableInvariants):

• platform/text/EncodingTables.h:

(WebCore::stableSortByFirst):
(WebCore::findLastInSortedPairs): Deleted.

• platform/text/TextCodecCJK.cpp:

(WebCore::jis0208EncodeIndex):
(WebCore::codePointJIS0208):
(WebCore::codePointJIS0212):
(WebCore::eucJPEncode):
(WebCore::iso2022JPEncode):
(WebCore::shiftJISEncode):
(WebCore::eucKREncodingIndex):
(WebCore::TextCodecCJK::eucKRDecode):
(WebCore::big5EncodeIndex):
(WebCore::big5Encode):
(WebCore::TextCodecCJK::big5Decode):
(WebCore::jis0208DecodeIndex): Deleted.
(WebCore::big5DecodeIndex): Deleted.

10:38 AM Changeset in webkit [266728] by Peng Liu

• 21 edits in trunk/Source

Clean up functions and state variables related to the picture-in-picture implementation
​https://bugs.webkit.org/show_bug.cgi?id=215972

Reviewed by Jer Noble.

Source/WebCore:

This patch cleans up variables and functions related to changing video presentation mode
in HTMLVideoElement and HTMLMediaElement. It cleans up some event-related code as well.

This patch also simplifies the process of entering the picture-in-picture mode.
The XPC message VideoFullscreenManagerProxy::DidEnterFullscreen from the UI process
will provide the picture-in-picture window size if the video is entering picture-in-picture,
so that we can get rid of the intermediate state (waiting for the initial picture-in-picture
window frame).

With this patch, all presentation mode change requests need to go through the HTMLVideoElement.
Normally, video presentation mode change requests come from the web process where a page
calls the fullscreen/picture-in-picture API or a user interacts with the modern media controls.
However, through gestures, the UI process may request to change the presentation mode
(e.g., from fullscreen to picture-in-picture). The web process side will be like a dry run
because the tasks in the UI process are mostly completed before the web process receives
the request. The motivation to do that is to guarantee correct events are fired.
All scenarios sharing the same code path also help us avoid regressions because we don't
have a good way to create regression tests for the scenarios where presentation mode change
requests come from the UI process.

Covered by existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::dispatchEvent):
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
(WebCore::HTMLMediaElement::setVideoFullscreenStandby):
(WebCore::HTMLMediaElement::willBecomeFullscreenElement):
Simplify the implementation.
(WebCore::HTMLMediaElement::willStopBeingFullscreenElement):
(WebCore::HTMLMediaElement::isVideoLayerInline):
(WebCore::HTMLMediaElement::setVideoFullscreenFrame):
(WebCore::HTMLMediaElement::setFullscreenMode):
Delete function HTMLVideoElement::fullscreenModeChanged() and move its code
to this function.
(WebCore::HTMLMediaElement::fullscreenModeChanged): Deleted.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::fullscreenMode const):
Replace fullscreenModeChanged() with a private function setFullscreenMode().
Change "void setVideoFullscreenFrame(FloatRect)" to "void setVideoFullscreenFrame(const FloatRect&)".

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitDisplayingFullscreen):
(WebCore::HTMLVideoElement::toPresentationMode):
(WebCore::HTMLVideoElement::webkitSetPresentationMode):
(WebCore::HTMLVideoElement::setPresentationMode):
(WebCore::HTMLVideoElement::didEnterFullscreenOrPictureInPicture):
(WebCore::HTMLVideoElement::didExitFullscreenOrPictureInPicture):
(WebCore::HTMLVideoElement::didBecomeFullscreenElement):
(WebCore::HTMLVideoElement::setVideoFullscreenFrame):
(WebCore::toPresentationMode): Deleted.
(WebCore::HTMLVideoElement::setFullscreenMode): Deleted.
(WebCore::HTMLVideoElement::fullscreenModeChanged): Deleted.
(WebCore::HTMLVideoElement::didStopBeingFullscreenElement): Deleted.

• html/HTMLVideoElement.h:

Only HTMLVIdeoElement::setPresentationMode() can be used by other modules (PlaybackSessionManager
or VideoFullscreenManager) to change the video presentation mode.
This patch defines different callbacks regarding the fullscreen mode change transition
for FullscreenManager and VideoFullscreenManager.

• didBecomeFullscreenElement for FullscreenManager.
• didEnterFullscreenOrPictureInPicture and didExitFullscreenOrPictureInPicture for

VideoFullscreenManager.
This patch removes m_isWaitingForPictureInPictureWindowFrame and renames m_isChangingPresentationMode
to m_isChangingVideoFullscreenMode.

• platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::togglePictureInPicture):

• platform/cocoa/VideoFullscreenChangeObserver.h:

• platform/cocoa/VideoFullscreenModelVideoElement.mm:

(WebCore::VideoFullscreenModelVideoElement::requestFullscreenMode):
(WebCore::VideoFullscreenModelVideoElement::fullscreenModeChanged):
(WebCore::VideoFullscreenModelVideoElement::setHasVideo):
(WebCore::VideoFullscreenModelVideoElement::setVideoDimensions):
(WebCore::VideoFullscreenModelVideoElement::willEnterPictureInPicture):
(WebCore::VideoFullscreenModelVideoElement::didEnterPictureInPicture):
(WebCore::VideoFullscreenModelVideoElement::failedToEnterPictureInPicture):
(WebCore::VideoFullscreenModelVideoElement::willExitPictureInPicture):
(WebCore::VideoFullscreenModelVideoElement::didExitPictureInPicture):
Iterate a copy of the HashSet of VideoFullscreenModelClient pointers because a callback may
remove the client itself during the iteration.

• platform/ios/VideoFullscreenInterfaceAVKit.h:
• platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer calculateTargetVideoFrame]):
(-[WebAVPlayerLayer layoutSublayers]):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
(VideoFullscreenInterfaceAVKit::cleanupFullscreen):
(VideoFullscreenInterfaceAVKit::didStartPictureInPicture):
(VideoFullscreenInterfaceAVKit::failedToStartPictureInPicture):
(VideoFullscreenInterfaceAVKit::doSetup):
(VideoFullscreenInterfaceAVKit::doEnterFullscreen):
(VideoFullscreenInterfaceAVKit::willEnterStandbyFromPictureInPicture): Deleted.
(VideoFullscreenInterfaceAVKit::setWillEnterStandbyFromPictureInPicture): Deleted.
Add a property isPictureInPicture to WebAVPlayerLayer, which will set to YES if
a layer is created for picture-in-picture.
This property is used in -[WebAVPlayerLayer layoutSublayers] to skip
the unnecessary calculation of "targetVideoFrame" because the PiP window will
always have the same aspect ratio as the video content, so we can set
"targetVideoFrame" to be the bounds of the layer. Moreover, the calculation may
lead to rounding errors for some numbers and the errors may trigger unnecessary
picture-in-picture window resize events.

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

This file has been moved to WebCore so we don't need to include WebCore headers
in a way like "#include <WebCore/XXX.h>".

• platform/mac/VideoFullscreenInterfaceMac.mm:

(-[WebVideoFullscreenInterfaceMacObjC enterPIP]):
(-[WebVideoFullscreenInterfaceMacObjC boundsDidChangeForVideoViewContainer:]):
(WebCore::VideoFullscreenInterfaceMac::enterFullscreen):
Add PIPState::EnteringPIP. Notify the observer that the video has entered
picture-in-picture after the PiP window size is finalized.

Source/WebKit:

This patch adds an optional FloatSize parameter to the VideoFullscreenManager::DidEnterFullscreen message.
Also, it enables the picture-in-picture and fullscreen events when a video element enters picture-in-picture
from the fullscreen mode.

• UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenModelContext::didEnterFullscreen):
(WebKit::VideoFullscreenModelContext::prepareToExitFullscreen):
(WebKit::VideoFullscreenModelContext::willEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::didEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::failedToEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::willExitPictureInPicture):
(WebKit::VideoFullscreenModelContext::didExitPictureInPicture):
(WebKit::VideoFullscreenManagerProxy::ensureClientForContext):
(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::VideoFullscreenManagerProxy::enterFullscreen):
(WebKit::VideoFullscreenManagerProxy::didEnterFullscreen):
Use ensureClientForContext() instead of addClientForContext() in setupFullscreenWithID()
to avoid leaking VideoFullscreenInterfaceAVKit instances.
Iterate a copy of the HashSet of VideoFullscreenModelClient pointers because a callback may
remove the client itself during the iteration.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController prepareToExitPictureInPicture]):

• UIProcess/mac/WKFullScreenWindowController.h:
• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController didExitPictureInPicture]):
Fix leaking of VideoFullscreenInterfaceMac.

• WebProcess/cocoa/VideoFullscreenManager.h:
• WebProcess/cocoa/VideoFullscreenManager.messages.in:
• WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::fullscreenModeChanged):
We need to change the fullscreen mode in the VideoFullscreenInterfaceContext instance as well.
(WebKit::VideoFullscreenManager::didEnterFullscreen):
(WebKit::VideoFullscreenManager::didCleanupFullscreen):
Call didExitFullscreenOrPictureInPicture() instead of didStopBeingFullscreenElement(), which
is for the FullscreenManager.

9:46 AM Changeset in webkit [266727] by Simon Fraser

• 1 edit
  3 adds in trunk/LayoutTests

Add a standalone version of the test runtime tree map viewer, that can accept stats.json from a local test run
​https://bugs.webkit.org/show_bug.cgi?id=189396

Reviewed by Darin Adler.

Add the viewer and a sample stats.json file. Devs can drag a stats.json file into test-duration-treemap.html to
see the map (or specify it as a url parameter).

A future patch will hook this up to results.html.

• fast/harness/stats.json: Added.
• fast/harness/test-duration-treemap-expected.txt: Added.
• fast/harness/test-duration-treemap.html: Added.

8:25 AM Changeset in webkit [266726] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK] AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo
​https://bugs.webkit.org/show_bug.cgi?id=216254

Patch by Mike Gorse <​mgorse@suse.com> on 2020-09-08
Reviewed by Adrian Perez de Castro.

• UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::tryInitializeSHM): Return false for wpebackend-fdo < 1.7.0.

8:16 AM Changeset in webkit [266725] by Chris Lord

• 2 edits in trunk/LayoutTests

[GStreamer] Some convolvernode tests are flaky crashing
​https://bugs.webkit.org/show_bug.cgi?id=216118

Unreviewed test gardening.

Some tests are causing random, subsequently run tests to crash. Skip
these tests on affected platforms.

• platform/glib/TestExpectations:

7:53 AM Changeset in webkit [266724] by commit-queue@webkit.org

• 8 edits
  4 adds in trunk/Tools

[Flatpak SDK] Follow-up fixes for 0.3 branch
​https://bugs.webkit.org/show_bug.cgi?id=216239

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-09-08
Reviewed by Žan Doberšek.

• buildstream/elements/filtered.bst: Enable sccache on aarch64 too.
• buildstream/elements/flatpak/sdk.bst: Enable the rust extension, can be useful eg, when

using gst-build to have the Rust plugins enabled.

• buildstream/elements/freedesktop-sdk.bst: Switch to tracking branch instead of tags.
• buildstream/elements/sdk-build-depends/rapidjson.bst: Bump to current git master and add a

patch fixing aarch64 build.

• buildstream/elements/sdk-platform.bst: Add procps, needed at least for test-webkitpy
• buildstream/elements/sdk/gst-plugin-dav1d.bst: Added.
• buildstream/elements/sdk/gst-plugins-bad.bst: Fix build for aarch64.
• buildstream/elements/sdk/sccache.bst: Disable dist server, we need the client only. The

server builds only on x86_64 anyway.

• buildstream/files/gst-plugin-dav1d/Cargo.lock: Added.
• buildstream/patches/rapidjson-0001-Fix-build-warnings-emitted-by-GCC-10-on-Aarch64.patch: Added.

7:24 AM Changeset in webkit [266723] by Karl Rackler

• 2 edits in trunk/LayoutTests

Removed 6 forms and 3 tables test expectations for Big Sur
rdar://68372418

Unreviewed test gardening.

• platform/mac/TestExpectations:

6:26 AM Changeset in webkit [266722] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] Remove redundant FormattingContext::Quirks::lineDescentNeedsCollapsing
​https://bugs.webkit.org/show_bug.cgi?id=216259

Reviewed by Antti Koivisto.

This function is not needed anymore. InlineBoxes start collapsed by default and they get stretched when they gain content
(and the root inline box has no imaginary strut in non-standard mode).

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const): Deleted.

6:18 AM Changeset in webkit [266721] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[GStreamer] Follow-up of "Convert custom GObject subclasses to WEBKIT_DEFINE_TYPE"
​https://bugs.webkit.org/show_bug.cgi?id=204673
<rdar://problem/68455348>

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2020-09-08
Reviewed by Carlos Garcia Campos.

This a continuation of 204673 since a post-merge review came up: it
was also needed to remove g_type_class_add_private() calls.

No new tests needed.

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(_WebKitWebAudioSrcPrivate::_WebKitWebAudioSrcPrivate):
(webkit_web_audio_src_class_init):

• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_class_init):

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_class_init):

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkit_media_common_encryption_decrypt_class_init):

• platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp:

(webkit_media_thunder_decrypt_class_init):

4:59 AM Changeset in webkit [266720] by commit-queue@webkit.org

• 8 edits in trunk

Fix crash in image-loading-lazy-slow.html WPT test
​https://bugs.webkit.org/show_bug.cgi?id=215998

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-08
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Adjust image-loading-lazy-slow.html to enable lazy image loading.

• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html:

Source/WebCore:

When setting images to an empty src, make sure
to reset any lazy image load information.

• html/LazyLoadImageObserver.h:
• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::elementDidMoveToNewDocument):
(WebCore::ImageLoader::resetLazyImageLoading):

• loader/ImageLoader.h:

(WebCore::ImageLoader::isDeferred const):

LayoutTests:

Mark image-loading-lazy-slow.html as ImageOnlyFailure.

• TestExpectations:

3:49 AM Changeset in webkit [266719] by Diego Pino Garcia

• 2 edits in trunk/Tools

[GTK] Unreviewed gardening. Mark several API-GTK tests as failures after r266697.

• TestWebKitAPI/glib/TestExpectations.json:

1:52 AM Changeset in webkit [266718] by Pablo Saavedra

• 11 edits
  2 adds in trunk/Source/WebKit

[GLIB] RemoteInspectorServer is not started if WebKitWebContext is not created already created
​https://bugs.webkit.org/show_bug.cgi?id=216120

Reviewed by Carlos Garcia Campos.

Added a WebKit/UIProcess/API/glib/WebKitInitialize what implements
its own webkitInitialize() to ensure the inspector server is
initialized as early as possible, before other api calls that would
depend on the inspector server being running.

The RemoteInspectorServer initialization is not longer
asociated to the initialization of the WebProcessPoolGLib.

The webkitInitialize() extends the shared InitializeWebKit2();
and also includes the initialization of the RemoteInspectorServer
so the initialization of the remote inspector server can be now
triggered by the initialization of many other API objects too:
WebKitInputMethodContext, WebKitSettings, WebKitUserContentManager,
WebKitWebContext, WebKitWebsiteDataManager,
WebKitUserContentFilterStore, WebKitWebViewBase.

• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/API/glib/WebKitInitialize.cpp: Added.

(WebKit::initializeRemoteInspectorServer):
(WebKit::webkitInitialize):

• UIProcess/API/glib/WebKitInitialize.h: Added.
• UIProcess/API/glib/WebKitInputMethodContext.cpp:

(webkit_input_method_context_class_init):

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):

• UIProcess/API/glib/WebKitUserContentFilterStore.cpp:

(webkit_user_content_filter_store_class_init):

• UIProcess/API/glib/WebKitUserContentManager.cpp:
• UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_class_init):

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkit_website_data_manager_class_init):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

• UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitialize):
(WebKit::initializeRemoteInspectorServer): Deleted.

1:48 AM Changeset in webkit [266717] by Antti Koivisto

• 6 edits in trunk/Source/WebCore

Comparing styles with large but identical custom property maps is slow
​https://bugs.webkit.org/show_bug.cgi?id=216241
<rdar://problem/67946605>

Reviewed by Darin Adler.

In a full style rebuild we lose sharing of equal StyleCustomPropertyDatas between the old and the new style.
Custom properties are usually defined in document element and this lack of sharing inherits to all elements.
Without sharing equality comparisons end up requiring deep comparisons, which can be slow if there are thousands of properties.

Fix by deduplicating identical property maps between the old the new style. All the descendants that inherit the properties will
now be cheap to compare.

The patch also contains some other basic custom property optimizations.

Going to full screen and back on youtube, this patch reduces time in the longest style update from ~460ms to ~90ms.

• css/CSSCustomPropertyValue.cpp:

(WebCore::CSSCustomPropertyValue::equals const):

Check for pointer equality first.

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::deduplicateInheritedCustomProperties):

Deduplicate if the properties are equal but not shared.

(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):

Check if the value is already in the map before triggering copy-on-write.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setInheritedCustomPropertyValue): Deleted.
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue): Deleted.

• style/StyleBuilder.cpp:

(WebCore::Style::Builder::applyCustomProperty):

Don't create unnecesary copies of CSSCustomPropertyValue.

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Try to deduplicate before comparing the styles.

12:35 AM Changeset in webkit [266716] by svillar@igalia.com

• 6 edits in trunk

[css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=216249

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Fixed the (FAIL) expectations of two WPT tests that are now passing.

• web-platform-tests/css/css-flexbox/percentage-size-quirks-expected.txt: Replaced FAIL with PASS.
• web-platform-tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item-expected.txt: Ditto.

Source/WebCore:

We shouldn't skip flexboxes with height:auto when going up the ancestor chain as we do with other types as grid.

Apart from that, we force flexible box to follow strict mode even when document is in quirks mode as flexbox
was invented way after quirky browsers. This matches Chromium, Edge (pre-Chromium) and Firefox behaviour.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation const): Don't skip flexboxes.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const): Ignore quirks mode for flexboxes.

12:21 AM Changeset in webkit [266715] by ysuzuki@apple.com

• 6 edits
  4 adds in trunk

[JSC] Special property caching should check Structure's cacheability
​https://bugs.webkit.org/show_bug.cgi?id=216222

Reviewed by Saam Barati.

JSTests:

• stress/module-namespace-object-caching.js: Added.

(shouldBe):
(async fn):

• stress/not-cache-over-uncacheable-dictionary.js: Added.

(shouldBe):

• stress/resources/to-string-module.js: Added.

(export.toString):

• stress/resources/value-of-module.js: Added.

(export.valueOf):

Source/JavaScriptCore:

While StructureRareData::cacheSpecialPropertySlow caches properties, the way it takes is incomplete.
It is not checking Structure's cacheability. We were caching miss condition even if structure is !propertyAccessesAreCacheableForAbsence.
We should perform the same check done in IC case. Strictly speaking, we can cache value for uncacheable-dictionary because we are setting
property change watchpoint (which will fire). But it sounds not so profitable if this structure is uncacheable.

• runtime/JSObject.cpp:

(JSC::JSObject::convertToUncacheableDictionary):

• runtime/JSObject.h:
• runtime/StructureRareData.cpp:

(JSC::StructureRareData::cacheSpecialPropertySlow):

• tools/JSDollarVM.cpp:

(JSC::functionToUncacheableDictionary):
(JSC::JSDollarVM::finishCreation):