Timeline

Sep 10, 2020:

11:58 PM Changeset in webkit [266913] by Fujii Hironori

• 6 edits
  2 adds in trunk

Protect this object in ValidationMessage::buildBubbleTree
​https://bugs.webkit.org/show_bug.cgi?id=211832

Reviewed by Ryosuke Niwa.

Source/WebCore:

ValidationMessage::buildBubbleTree is doing layout which can run a
script detaching the owner form element, and this
ValidationMessage object can be destroyed. Don't do layout in
buildBubbleTree. Call adjustBubblePosition by using
queuePostLayoutCallback and a weak pointer of ValidationMessage.

ValidationMessage::deleteBubbleTree was causing
ASSERT_WITH_SECURITY_IMPLICATION failures in
ContainerNode::removeNodeWithScriptAssertion due to re-entrant of
removeNodeWithScriptAssertion. UA shadow roots are never exposed
to author scripts so this is safe. Use
ScriptDisallowedScope::EventAllowedScope in it.

Test: fast/forms/validation-bubble-disappears-during-layout.html

• html/ValidationMessage.cpp:

(WebCore::ValidationMessage::adjustBubblePosition):
(WebCore::ValidationMessage::buildBubbleTree):
(WebCore::ValidationMessage::deleteBubbleTree): Use ScriptDisallowedScope::EventAllowedScope.
(WebCore::adjustBubblePosition): Changed to a member function.

• html/ValidationMessage.h: Inherit CanMakeWeakPtr.

LayoutTests:

• fast/forms/validation-bubble-disappears-during-layout-expected.txt: Added.
• fast/forms/validation-bubble-disappears-during-layout.html: Added.
• platform/ios-wk1/TestExpectations: Marked validation-bubble-disappears-during-layout.html as Skip.
• platform/win/TestExpectations: Ditto.

11:41 PM Changeset in webkit [266912] by ysuzuki@apple.com

• 3 edits
  2 adds in trunk

JSDOMConvertSequences should have exception checks appropriately
​https://bugs.webkit.org/show_bug.cgi?id=216390
<rdar://problem/68631333>

Reviewed by Mark Lam.

Source/WebCore:

Test: js/dom/frozen-array-exception-check.html

Add appropriate exception checks to JSDOMConvertSequences.

• bindings/js/JSDOMConvertSequences.h:

(WebCore::Detail::NumericSequenceConverter::convert):
(WebCore::JSConverter<IDLSequence<T>>::convert):
(WebCore::JSConverter<IDLFrozenArray<T>>::convert):

LayoutTests:

• js/dom/frozen-array-exception-check-expected.txt: Added.
• js/dom/frozen-array-exception-check.html: Added.

11:37 PM Changeset in webkit [266911] by ysuzuki@apple.com

• 3 edits
  2 adds in trunk

[JSC] customGetterSetterFunctionCall should have proper exception checking
​https://bugs.webkit.org/show_bug.cgi?id=216391
<rdar://problem/68631643>

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add appropriate exception checking to customGetterSetterFunctionCall.

• runtime/JSCustomGetterSetterFunction.cpp:

(JSC::JSCustomGetterSetterFunction::customGetterSetterFunctionCall):

LayoutTests:

• js/dom/custom-getter-setter-exception-check-expected.txt: Added.
• js/dom/custom-getter-setter-exception-check.html: Added.

11:25 PM Changeset in webkit [266910] by ysuzuki@apple.com

• 3 edits
  2 adds in trunk

[JSC] Add exception checks to JSCallbackObject
​https://bugs.webkit.org/show_bug.cgi?id=216384
<rdar://problem/68632190>

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch adds necessary exception checks to JSCallbackObject to suppress exception verifier crash in Debug build.

• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::getOwnPropertySlot):
(JSC::JSCallbackObject<Parent>::defaultValue):
(JSC::JSCallbackObject<Parent>::put):
(JSC::JSCallbackObject<Parent>::putByIndex):
(JSC::JSCallbackObject<Parent>::deleteProperty):
(JSC::JSCallbackObject<Parent>::staticFunctionGetter):

LayoutTests:

• js/dom/to-primitive-exception-in-callback-object-expected.txt: Added.
• js/dom/to-primitive-exception-in-callback-object.html: Added.

11:10 PM Changeset in webkit [266909] by Megan Gardner

• 8 edits
  2 adds in trunk

Source/WebCore:
Text replacements at the beginning of a second line are replaced too early
​https://bugs.webkit.org/show_bug.cgi?id=216327
<rdar://problem/68170353>

Reviewed by Darin Adler.

In the changes in r258871, using SimpleRanges instead of Range causing some side effects
when the replacements at the beginning of lines. The ranges that we are counting are backwards
and the return characters are being counted instead of being ignored. There is almost
certainly a better fix than this, but this patch restores the original logic that
was present when Range was being used, until a better fix can be worked out.

Test: editing/spelling/text-replacement-first-word-second-line.html

• editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

• editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::automaticReplacementStart const):
(WebCore::TextCheckingParagraph::automaticReplacementLength const):

• editing/TextCheckingHelper.h:

LayoutTests:
Overlapping text replacements at the beginning of a line are replaced too early
​https://bugs.webkit.org/show_bug.cgi?id=216327

Reviewed by Darin Adler.

• editing/spelling/text-replacement-first-word-second-line-expected.txt: Added.
• editing/spelling/text-replacement-first-word-second-line.html: Added.

11:04 PM Changeset in webkit [266908] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] agent start function should move isolated copy of source
​https://bugs.webkit.org/show_bug.cgi?id=216383
<rdar://problem/66371008>

Reviewed by Saam Barati.

JSTests:

• stress/stress-agent.js: Added.

Source/JavaScriptCore:

We are calling isolatedCopy() and setting it to variable in caller thread. And we are copying it to the thread.
This means that ref-count will happen in caller thread and callee thread, this is wrong.
We should pass isolatedCopy string directly to the callee thread.

• jsc.cpp:

(functionDollarAgentStart):

11:02 PM Changeset in webkit [266907] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] unshift / shift should take structure lock
​https://bugs.webkit.org/show_bug.cgi?id=216378
<rdar://problem/68496096>

Reviewed by Mark Lam.

JSTests:

• stress/unshift-and-concurrent-access.js: Added.

Source/JavaScriptCore:

When unshifting / shifting butterfly, we need to move property storage values too.
If property storage values are moved while concurrent JIT compiler is accessing it, it could include garbage value.

For example, concurrent JIT compiler is accessing [2] property storage.

1 2 3

[ JSValue ][ JSValue ][ Header ]

But unshift moved it like this.

1 2 3

[ JSValue ][ JSValue ][ Header ]

Since butterfly pointer held by JSObject is not updated yet, concurrent JIT compiler will read [ Header ] as JSValue and crash.
In this patch, we take structure lock when shifting existing butterfly since this affect on property storage. Since JSObject::getDirectConcurrently
takes a structure lock, this locking prevents concurrent compilers from getting an invalid value.

• runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::unshiftCountWithArrayStorage):

10:31 PM Changeset in webkit [266906] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Garden consistent reftest-wait timeouts after r266817.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

7:03 PM Changeset in webkit [266905] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Release ] fast/selectors/text-field-selection-stroke-color.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216394

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

6:51 PM Changeset in webkit [266904] by mmaxfield@apple.com

• 8 edits in trunk/Source/WebCore

Small cleanup in RenderTheme
​https://bugs.webkit.org/show_bug.cgi?id=216293

Reviewed by Darin Adler.

See the discussion in ​https://bugs.webkit.org/show_bug.cgi?id=213332 for background.
More comments below.

No new tests because there is no behavior change.

• platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformCreateScaledFont const): Use auto instead of RetainPtr.

• platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::matchSystemFontUse): Use std::binary_search instead of std::find,
because it's faster and we expect this function to be called very often.

• platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Use auto instead of RetainPtr.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::cachedSystemFontDescription const): Move the local variables
into an array.

• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::cachedSystemFontDescription const): Ditto.
(WebCore::cssWeightOfSystemFont):
(WebCore::RenderThemeCocoa::updateCachedSystemFontDescription const): Use auto
instead of RetainPtr.

• rendering/RenderThemeIOS.mm:

(WebCore::attachmentTitleFont): Ditto.

• rendering/RenderThemeMac.mm:

(WebCore::AttachmentLayout::layOutTitle): Ditto.
(WebCore::AttachmentLayout::layOutSubtitle): Ditto.

5:50 PM Changeset in webkit [266903] by Karl Rackler

• 3 edits in trunk/LayoutTests

Update test expectations for imported/blink/fast/gradients/gradient-transparency.html
rdar://32800095

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:

5:41 PM Changeset in webkit [266902] by jh718.park@samsung.com

• 12 edits in trunk/Source

Unreviewed. Remove the build warning below since r266885.
warning: redundant move in return statement [-Wredundant-move]

Because return statement already returns rvalue reference,
we don't need WTFMove at return.

Source/JavaScriptCore:

• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::InspectorRuntimeAgent::getBasicBlocks):

Source/WebCore:

No new tests, no new behaviors.

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getSupportedSystemFontFamilyNames):

• inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::requestClientNodes):

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getSupportedEventNames):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):

• inspector/agents/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

• inspector/agents/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

• inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

• inspector/agents/page/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::getLoggingChannels):

Source/WebKit:

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::getSessionPermissions):

5:32 PM Changeset in webkit [266901] by Alan Bujtas

• 6 edits in trunk

[Repaint] RenderLayerModelObject::styleWillChange may issue redundant repaint
​https://bugs.webkit.org/show_bug.cgi?id=216374
<rdar://problem/68657490>

Reviewed by Simon Fraser.

Source/WebCore:

Move the repaintIncludingDescendants() calls to repaintBeforeStyleChange() to avoid redundant repaints on the same renderer.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::repaintBeforeStyleChange):

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

• css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
• platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:

5:09 PM Changeset in webkit [266900] by ysuzuki@apple.com

• 1 edit in branches/safari-610-branch/Source/JavaScriptCore/runtime/IntlCollator.h

Unreviewed, including wtf/unicode/icu/ICUHelpers.h in IntlCollator.h
<rdar://problem/68673729>

• runtime/IntlCollator.h:

5:01 PM Changeset in webkit [266899] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Address a post-commit review comment after r266887
​https://bugs.webkit.org/show_bug.cgi?id=216257

Reviewed by Darin Adler.

Remove a check that currently makes us conditionally set IsComputedStyleInvalidFlag if there is a computed
style in rare data. There should be no change in behavior; this just makes the code a bit simpler.

• dom/Element.cpp:

(WebCore::Element::invalidateStyle):
(WebCore::Element::storeDisplayContentsStyle):

4:52 PM Changeset in webkit [266898] by Ben Nham

• 10 edits
  1 copy in trunk/Source

Disable hardware JPEG decoding on x86 Mac
​https://bugs.webkit.org/show_bug.cgi?id=216377

Reviewed by Geoff Garen.

Source/WebCore/PAL:

Add wrappers for a new MediaToolbox SPI that allows us to disable HW JPEG decoding.

• PAL.xcodeproj/project.pbxproj:
• pal/PlatformMac.cmake:
• pal/cocoa/MediaToolboxSoftLink.cpp:
• pal/cocoa/MediaToolboxSoftLink.h:

Source/WebKit:

In Big Sur, ImageIO uses hardware JPEG decoding automatically for certain JPEGs. This caused
a small regression in our battery life benchmark since the one-time setup cost for the
decoder (~20-30 ms per process) was higher than the per-decode win we got from the HW decoder.

For now, we're reverting to the Catalina behavior of not using hardware JPEG on x86 Macs by
calling a MediaToolbox SPI. (The tradeoffs for Apple Silicon are different so we use
ImageIO's default heuristics on that architecture.) We plan to revisit this decision once we
move to a GPUProcess world.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Add macros to disable HW JPEG decoding on x86 Macs and indicate the presence of a new MediaToolbox SPI.
(The latter is to prevent unnecessary dlopen/dlsym calls since we soft-link MediaToolbox.)

• wtf/PlatformEnableCocoa.h:
• wtf/PlatformHave.h:

4:25 PM Changeset in webkit [266897] by Karl Rackler

• 2 edits in trunk/LayoutTests

Remove test expectation now that test is passing.
rdar://61833551

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:02 PM Changeset in webkit [266896] by Alexey Shvayka

• 6 edits in trunk

Promise.prototype.finally should perform PromiseResolve
​https://bugs.webkit.org/show_bug.cgi?id=176006

Reviewed by Yusuke Suzuki.

JSTests:

• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch extracts @promiseResolve global private function and utilizes it in
Promise.prototype.finally then/catch functions [1] to avoid creating an extra
Promise Capability. Aligns JSC with V8 and SpiderMonkey.

[1]: ​https://tc39.es/ecma262/#sec-thenfinallyfunctions (step 7)

• builtins/PromiseConstructor.js:

(resolve):

• builtins/PromiseOperations.js:

(globalPrivate.promiseResolve):

• builtins/PromisePrototype.js:

(globalPrivate.getThenFinally):
(globalPrivate.getCatchFinally):

3:57 PM Changeset in webkit [266895] by Chris Dumez

• 21 edits in trunk

Unreviewed, reverting r266842 and r266883.

Causes some assertions to be hit in debug builds

Reverted changesets:

"Some WebAudio tests give different output on different
machines"
​https://bugs.webkit.org/show_bug.cgi?id=216371
​https://trac.webkit.org/changeset/266842

"Unreviewed Windows build fix after r266842."
​https://trac.webkit.org/changeset/266883

3:26 PM Changeset in webkit [266894] by Alexey Shvayka

• 238 edits
  275 adds in trunk/JSTests

Update test262 to commit 323905b70e64
​https://bugs.webkit.org/show_bug.cgi?id=216379

Reviewed by Yusuke Suzuki.

• test262/config.yaml: Skip "legacy-regexp" feature and unskip 2 passing tests.
• test262/expectations.yaml:
• test262/latest-changes-summary.txt:
• test262/test/*: Updated.
• test262/test262-Revision.txt:

3:24 PM Changeset in webkit [266893] by Alan Coon

• 1 copy in tags/Safari-610.2.4.0.1

Tag Safari-610.2.4.0.1.

3:21 PM Changeset in webkit [266892] by Chris Dumez

• 3 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline a couple of flaky WebAudio WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:

2:52 PM Changeset in webkit [266891] by Alan Coon

• 9 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266771. rdar://problem/68666453

Regression(r260614) Power usage has increased due to extra thread hopping
​https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>

Reviewed by Simon Fraser.

Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.

• UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
• UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
• WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
• WebProcess/WebPage/EventDispatcher.h:
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:40 PM Changeset in webkit [266890] by BJ Burg

• 22 edits
  1 move in trunk

Web Inspector: _WKInspectorDelegate should be attached to _WKInspector not WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=215961

Reviewed by Devin Rousso.

Source/WebKit:

Move _WKInspectorDelegate to be a property of _WKInspector. If there
is no _WKInspector available (i.e. for iOS), the delegate cannot be set.

As part of this change, move -didAttachLocalInspector: back to UIDelegatePrivate.
This delegate method is called just as the inspector is shown, so there would
be no way to act upon this message if it were part of _WKInspectorDelegate.
Now, -didAttachLocalInspector: is the designated time to attach _WKInspectorDelegate.

Covered by existing API tests.

• UIProcess/API/APIInspectorClient.h:

(API::InspectorClient::browserDomainEnabled):
(API::InspectorClient::browserDomainDisabled):
(API::InspectorClient::didAttachLocalInspector): Deleted.

• UIProcess/API/APIUIClient.h:

(API::UIClient::didAttachLocalInspector):

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _inspectorDelegate]): Deleted.
(-[WKWebView _setInspectorDelegate:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/_WKInspector.h:
• UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector dealloc]): Added.
(-[_WKInspector delegate]): Added.
(-[_WKInspector setDelegate:]): Added. Since _WKInspector/WebInspectorProxy is always
created internally instead of via ObjC initializer, we need to initialize ivars before
using them, as there is no other place for them to be initialized.

• UIProcess/API/Cocoa/_WKInspectorDelegate.h:
• UIProcess/API/Cocoa/_WKInspectorInternal.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didAttachLocalInspector):

• UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp:

(WebKit::InspectorBrowserAgent::enable):
(WebKit::InspectorBrowserAgent::disable):

• UIProcess/Inspector/Cocoa/InspectorDelegate.h:
• UIProcess/Inspector/Cocoa/InspectorDelegate.mm:

(WebKit::InspectorDelegate::InspectorDelegate):
(WebKit::InspectorDelegate::setDelegate):
(WebKit::InspectorDelegate::InspectorClient::browserDomainEnabled):
(WebKit::InspectorDelegate::InspectorClient::browserDomainDisabled):
(WebKit::InspectorDelegate::InspectorClient::didAttachLocalInspector): Deleted.

• UIProcess/Inspector/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::inspectorClient):

• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::setInspectorClient):
(WebKit::WebInspectorProxy::openLocalInspectorFrontend):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::inspectorClient): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setInspectorClient): Deleted.
Similar to the Cocoa SPI, move InspectorClient from WebPageProxy
to WebInspectorProxy.

Tools:

Refactor the test to set the _WKInspectorDelegate correctly.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm.

(-[InspectorDelegate inspectorDidEnableBrowserDomain:]):
(-[InspectorDelegate inspectorDidDisableBrowserDomain:]):
(-[UIDelegate _webView:didAttachLocalInspector:]):
(TEST):

1:25 PM Changeset in webkit [266889] by Fujii Hironori

• 2 edits in trunk/Source/WebDriver

Unreviewed Debug build fix for WPE and WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=216302
<rdar://problem/68547649>

• Session.cpp:

(WebDriver::Session::switchToFrame): Replaced 'frameIndex' with '*frameIndex' in ASSERT expression.

1:08 PM Changeset in webkit [266888] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][IFC] Construct LineBox::InlineBoxes for nested inline level boxes when they overlap multiple lines
​https://bugs.webkit.org/show_bug.cgi?id=216369

Reviewed by Antti Koivisto.

Source/WebCore:

An inline box may not necessarily start on the current line:

<span id=outer>line break

<br>
this content's parent inline box('outer') <span id=inner>starts on the previous line</span>

</span>

We need to make sure that there's an LineBox::InlineBox for every inline box that's present on the current line.
(both 'outer' and 'inner' inline boxes have to have a corresponding LineBox::InlineBox here to be able to compute their geometry)
They normally get constructed when when we see a [container start] run, but when the nesting level > 1 at the start of the line,
we will not see those [container start] runs.
In such cases we need to create LineBox::InlineBoxes for the inline box ancestors.
We only have to do it on the first run as any subsequent inline content is either at the same/higher nesting level or
nested with a [container start] run.

Test: fast/layoutformattingcontext/inline-box-overlaps-multiple-lines.html

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::constructInlineBoxes):

LayoutTests:

• fast/layoutformattingcontext/inline-box-overlaps-multiple-lines-expected.html: Added.
• fast/layoutformattingcontext/inline-box-overlaps-multiple-lines.html: Added.

12:56 PM Changeset in webkit [266887] by Wenson Hsieh

• 4 edits
  2 adds in trunk

REGRESSION (r257839): clickpay.com - password placeholder text cannot be replaced
​https://bugs.webkit.org/show_bug.cgi?id=216257
<rdar://problem/68150686>

Reviewed by Antti Koivisto.

Source/WebCore:

On clickpay.com, the field in the login form that contains the text "Password" is actually a plain text input,
referred to by the site's script as the "null text input". The page adds a focus event listener to this null
text input, and inside of this focus event listener, it reveals a hidden password field by removing an inline
display: none; style rule on the real password input element, programmatically focuses it, and then hides the
null text input by setting it to display: none; via inline style.

However, after the changes in r257839, we no longer attempt to do a style update upon programmatic focus in the
case where the programmatically focused element does not have a renderer yet (this applies to the password field
in this scenario, because it previously had display: none;). When we determine whether the newly displayed
password field is focusable using Element::isVisibleWithoutResolvingFullStyle, we then attempt to use either
the existing computed RenderStyle on the element, or perform a partial computed style resolution using the
ResolveComputedStyleMode::RenderedOnly flag.

But in the case where ElementRareData's computed style exists, it is not guaranteed to be up to date if the
inline style changed since the computed style was last set. In the context of this bug, it's actually Safari's
AutoFill logic (embedded in the injected bundle) that ends up asking for the computed style of the password
input, forcing it to be created and set (though, as demonstrated in the layout test, simply grabbing the
computed style is sufficient to replicate the bug outside of Safari).

The end result is that we'll use this stale computed style, which still believes that the password input is not
displayed, and we end up not focusing the element due to believing that the password input is hidden. To fix
this, we would need to either check whether the element has an invalid style (i.e. needsStyleRecalc()) before
attempting to use the existing computed style, or clear out the ElementRareData computed style anytime the
element's style is invalidated. However, both of these approaches will cause us to perform partial style
resolution much more aggressively, leading to a 2-3% regression in Speedometer.

To address the bug without hampering our performance wins from r257839, we add a new node flag so that we can
remember when computed styles are no longer valid due to style invalidation, and consult this flag in
Element::isVisibleWithoutResolvingFullStyle to avoid using the existing computed style.

Test: fast/forms/programmatic-focus-after-display.html

• dom/Element.cpp:

(WebCore::Element::invalidateStyle):
(WebCore::Element::resolveComputedStyle):
(WebCore::Element::isVisibleWithoutResolvingFullStyle const):

• dom/Node.h:

(WebCore::Node::setHasValidStyle):

LayoutTests:

Add a new layout test to verify that the bug does not occur. See WebCore/ChangeLog for more details.

• fast/forms/programmatic-focus-after-display-expected.txt: Added.
• fast/forms/programmatic-focus-after-display.html: Added.

12:42 PM Changeset in webkit [266886] by Hector Lopez

• 3 edits in trunk/LayoutTests

[ macOS iOS ] media/modern-media-controls/playback-support/playback-support-autoplay.html is a flaky failure/timeout
<rdar://problem/63026283>

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac/TestExpectations:

12:23 PM Changeset in webkit [266885] by Devin Rousso

• 193 edits in trunk

Web Inspector: modernize generated backend protocol code
​https://bugs.webkit.org/show_bug.cgi?id=216302
<rdar://problem/68547649>

Reviewed by Brian Burg.

Source/JavaScriptCore:

Previously, the inspector protocol was expressed in code in a somewhat confusing way:

• the error string was the first argument
• required parameters were T or const T&
• optional parameters were const T*
• enum parameters were the underlying type requiring the backend dispatcher handler to process it instead of it being preprocessed
• required returns were T&
• optional returns were T*

This doesn't really make for easy/obvious reading of code since the order of arguments is
not weird (e.g. error string first), and that there are references/pointers to primitive
types.

This patch cleans up the generated inspector protocol code to be:

• required parameters are T or Ref<T>&&
• optional parameters are Optional<T>&& or RefPtr<T>&&
• enum parameters are preprocessed and passed to the backend dispatcher handler if valid
• synchronous commands return Expected<X, ErrorString> using the same types/rules above where X is either a single return or a std::tuple of multiple returns

The one exception to the above is String, which is already a tri-state of nullString(),
emptyString(), and something set, so there's no need to use Optional<String>.

Also use Protocol objects/typedefs wherever possible to further relate the protocol
JSON and the actual backend dispatcher handler implementation.

• inspector/scripts/codegen/generator.py:

(Generator.generate_includes_from_entries):

• inspector/scripts/codegen/cpp_generator_templates.py:
• inspector/scripts/codegen/cpp_generator.py:

(CppGenerator.helpers_namespace):
(CppGenerator.cpp_getter_method_for_type):
(CppGenerator.cpp_setter_method_for_type):
(CppGenerator.cpp_protocol_type_for_type):
(CppGenerator.cpp_type_for_type_member_argument): Added.
(CppGenerator.cpp_type_for_command_parameter): Added.
(CppGenerator.cpp_type_for_command_return_declaration): Added.
(CppGenerator.cpp_type_for_command_return_argument): Added.
(CppGenerator.cpp_type_for_event_parameter): Added.
(CppGenerator.cpp_type_for_enum): Added.
(CppGenerator.should_move_argument): Added.
(CppGenerator.should_release_argument): Added.
(CppGenerator.should_dereference_argument): Added.
(CppGenerator.cpp_protocol_type_for_type_member): Deleted.
(CppGenerator.cpp_type_for_unchecked_formal_in_parameter): Deleted.
(CppGenerator.cpp_type_for_checked_formal_event_parameter): Deleted.
(CppGenerator.cpp_type_for_type_member): Deleted.
(CppGenerator.cpp_type_for_type_with_name): Deleted.
(CppGenerator.cpp_type_for_formal_out_parameter): Deleted.
(CppGenerator.cpp_type_for_formal_async_parameter): Deleted.
(CppGenerator.cpp_type_for_stack_in_parameter): Deleted.
(CppGenerator.cpp_type_for_stack_out_parameter): Deleted.
(CppGenerator.cpp_assertion_method_for_type_member): Deleted.
(CppGenerator.cpp_assertion_method_for_type_member.assertion_method_for_type): Deleted.
(CppGenerator.should_use_wrapper_for_return_type): Deleted.
(CppGenerator.should_use_references_for_type): Deleted.
(CppGenerator.should_pass_by_copy_for_return_type): Deleted.

• inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:

(CppAlternateBackendDispatcherHeaderGenerator._generate_secondary_header_includes):
(CppAlternateBackendDispatcherHeaderGenerator._generate_handler_declaration_for_command):

• inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:

(CppBackendDispatcherHeaderGenerator.generate_output):
(CppBackendDispatcherHeaderGenerator._generate_secondary_header_includes):
(CppBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain):
(CppBackendDispatcherHeaderGenerator._generate_handler_declaration_for_command):
(CppBackendDispatcherHeaderGenerator._generate_async_handler_declaration_for_command):
(CppBackendDispatcherHeaderGenerator._generate_dispatcher_declaration_for_command):
(CppBackendDispatcherHeaderGenerator._generate_anonymous_enum_for_parameter): Deleted.

• inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator._generate_secondary_header_includes):
(CppBackendDispatcherImplementationGenerator._generate_small_dispatcher_switch_implementation_for_domain):
(CppBackendDispatcherImplementationGenerator._generate_async_dispatcher_class_for_domain):
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

• inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:

(CppFrontendDispatcherHeaderGenerator._generate_secondary_header_includes):
(CppFrontendDispatcherHeaderGenerator._generate_dispatcher_declaration_for_event):

• inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator._generate_secondary_header_includes):
(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):

• inspector/scripts/codegen/generate_cpp_protocol_types_header.py:

(CppProtocolTypesHeaderGenerator._generate_secondary_header_includes):

• inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator._generate_secondary_header_includes):
(CppProtocolTypesImplementationGenerator._generate_enum_conversion_methods_for_domain):
(CppProtocolTypesImplementationGenerator._generate_open_field_names):
(CppProtocolTypesImplementationGenerator._generate_assertion_for_enum):

• inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:

(ObjCBackendDispatcherHeaderGenerator._generate_objc_handler_declaration_for_command):

• inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:

(ObjCBackendDispatcherImplementationGenerator._generate_handler_implementation_for_command):
(ObjCBackendDispatcherImplementationGenerator._generate_success_block_for_command):
(ObjCBackendDispatcherImplementationGenerator._generate_success_block_for_command.and):
(ObjCBackendDispatcherImplementationGenerator._generate_conversions_for_command.in_param_expression):
(ObjCBackendDispatcherImplementationGenerator._generate_conversions_for_command):
(ObjCBackendDispatcherImplementationGenerator._generate_invocation_for_command):

• inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:

(ObjCFrontendDispatcherImplementationGenerator._generate_event):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters):

• inspector/scripts/codegen/objc_generator_templates.py:
• inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator.protocol_type_for_type):
(ObjCGenerator.objc_type_for_param_internal):
(ObjCGenerator.objc_protocol_import_expression_for_parameter):

• inspector/protocol/Page.json:

Now that enums are processed before being passed to backend dispacher handlers, the
appearance parameter of Page.setForcedAppearance must be marked optional as
there's no way for it to accept an empty string, as that's not possible for an enum.

• inspector/agents/InspectorAgent.h:
• inspector/agents/InspectorAgent.cpp:
• inspector/agents/InspectorAuditAgent.h:
• inspector/agents/InspectorAuditAgent.cpp:
• inspector/agents/InspectorConsoleAgent.h:
• inspector/agents/InspectorConsoleAgent.cpp:
• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:
• inspector/agents/InspectorHeapAgent.h:
• inspector/agents/InspectorHeapAgent.cpp:
• inspector/agents/InspectorRuntimeAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:
• inspector/agents/InspectorScriptProfilerAgent.h:
• inspector/agents/InspectorScriptProfilerAgent.cpp:
• inspector/agents/InspectorTargetAgent.h:
• inspector/agents/InspectorTargetAgent.cpp:
• inspector/agents/JSGlobalObjectAuditAgent.h:
• inspector/agents/JSGlobalObjectAuditAgent.cpp:
• inspector/agents/JSGlobalObjectDebuggerAgent.h:
• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
• inspector/agents/JSGlobalObjectRuntimeAgent.h:
• inspector/agents/JSGlobalObjectRuntimeAgent.cpp:
• inspector/JSGlobalObjectConsoleClient.cpp:
• inspector/JSGlobalObjectInspectorController.cpp:

Elided backend dispatcher handler changes describe above.

• bindings/ScriptValue.cpp:

(Inspector::jsToInspectorValue):

• inspector/AsyncStackTrace.h:
• inspector/AsyncStackTrace.cpp:

(Inspector::AsyncStackTrace::buildInspectorObject const):

• inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::addToFrontend):

• inspector/InjectedScriptBase.h:
• inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeEvalCall):
(Inspector::InjectedScriptBase::checkCallResult):
(Inspector::InjectedScriptBase::checkAsyncCallResult):

• inspector/InjectedScript.h:
• inspector/InjectedScript.cpp:

(Inspector::InjectedScript::execute):
(Inspector::InjectedScript::evaluate):
(Inspector::InjectedScript::callFunctionOn):
(Inspector::InjectedScript::evaluateOnCallFrame):
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapJSONString const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):

• inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptForObjectId):

• inspector/InspectorBackendDispatcher.h:
• inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::CallbackBase::sendSuccess):
(Inspector::BackendDispatcher::dispatch):
(Inspector::BackendDispatcher::sendResponse):
(Inspector::BackendDispatcher::getPropertyValue):
(Inspector::BackendDispatcher::getBoolean):
(Inspector::BackendDispatcher::getInteger):
(Inspector::BackendDispatcher::getDouble):
(Inspector::BackendDispatcher::getString):
(Inspector::BackendDispatcher::getValue):
(Inspector::BackendDispatcher::getObject):
(Inspector::BackendDispatcher::getArray):
(Inspector::castToInteger): Deleted.
(Inspector::castToNumber): Deleted.

• inspector/InspectorProtocolTypes.h:

(Inspector::Protocol::BindingTraits<JSON::ArrayOf<T>>::runtimeCast):
(Inspector::Protocol::BindingTraits<JSON::ArrayOf<T>>::assertValueHasExpectedType):

• inspector/remote/socket/RemoteInspectorConnectionClient.cpp:

(Inspector::RemoteInspectorConnectionClient::extractEvent):

• inspector/remote/socket/RemoteInspectorSocket.cpp:

(Inspector::RemoteInspector::pushListingsNow):

• runtime/TypeSet.cpp:

(JSC::StructureShape::inspectorRepresentation):
JSON classes now use Ref&& wherever possible and Optional instead of an out parameter
for get*/as* so that values can be more easily manipulated and can be confidently known
to exist.

• inspector/scripts/tests/enum-values.json:
• inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/expected/domain-debuggableTypes.json-result:
• inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/domain-targetTypes.json-result:
• inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/expected/enum-values.json-result:
• inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
• inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
• inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/expected/should-strip-comments.json-result:
• inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
• inspector/scripts/tests/expected/type-declaration-array-type.json-result:
• inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
• inspector/scripts/tests/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
• inspector/scripts/tests/expected/type-with-open-parameters.json-result:
• inspector/scripts/tests/expected/version.json-result:

Source/WebCore:

Previously, the inspector protocol was expressed in code in a somewhat confusing way:

• the error string was the first argument
• required parameters were T or const T&
• optional parameters were const T*
• enum parameters were the underlying type requiring the backend dispatcher handler to process it instead of it being preprocessed
• required returns were T&
• optional returns were T*

This doesn't really make for easy/obvious reading of code since the order of arguments is
not weird (e.g. error string first), and that there are references/pointers to primitive
types.

This patch cleans up the generated inspector protocol code to be:

• required parameters are T or Ref<T>&&
• optional parameters are Optional<T>&& or RefPtr<T>&&
• enum parameters are preprocessed and passed to the backend dispatcher handler if valid
• synchronous commands return Expected<X, ErrorString> using the same types/rules above where X is either a single return or a std::tuple of multiple returns

The one exception to the above is String, which is already a tri-state of nullString(),
emptyString(), and something set, so there's no need to use Optional<String>.

Also use Protocol objects/typedefs wherever possible to further relate the protocol
JSON and the actual backend dispatcher handler implementation.

• inspector/InspectorAuditResourcesObject.cpp:
• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:
• inspector/InspectorController.cpp:
• inspector/InspectorStyleSheet.h:
• inspector/InspectorStyleSheet.cpp:
• inspector/agents/InspectorAnimationAgent.h:
• inspector/agents/InspectorAnimationAgent.cpp:
• inspector/agents/InspectorApplicationCacheAgent.h:
• inspector/agents/InspectorApplicationCacheAgent.cpp:
• inspector/agents/InspectorCPUProfilerAgent.h:
• inspector/agents/InspectorCPUProfilerAgent.cpp:
• inspector/agents/InspectorCSSAgent.h:
• inspector/agents/InspectorCSSAgent.cpp:
• inspector/agents/InspectorCanvasAgent.h:
• inspector/agents/InspectorCanvasAgent.cpp:
• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:
• inspector/agents/InspectorDOMDebuggerAgent.h:
• inspector/agents/InspectorDOMDebuggerAgent.cpp:
• inspector/agents/InspectorDOMStorageAgent.h:
• inspector/agents/InspectorDOMStorageAgent.cpp:
• inspector/agents/InspectorDatabaseAgent.h:
• inspector/agents/InspectorDatabaseAgent.cpp:
• inspector/agents/InspectorIndexedDBAgent.h:
• inspector/agents/InspectorIndexedDBAgent.cpp:
• inspector/agents/InspectorLayerTreeAgent.h:
• inspector/agents/InspectorLayerTreeAgent.cpp:
• inspector/agents/InspectorMemoryAgent.h:
• inspector/agents/InspectorMemoryAgent.cpp:
• inspector/agents/InspectorNetworkAgent.h:
• inspector/agents/InspectorNetworkAgent.cpp:
• inspector/agents/InspectorPageAgent.h:
• inspector/agents/InspectorPageAgent.cpp:
• inspector/agents/InspectorTimelineAgent.h:
• inspector/agents/InspectorTimelineAgent.cpp:
• inspector/agents/InspectorWorkerAgent.h:
• inspector/agents/InspectorWorkerAgent.cpp:
• inspector/agents/WebConsoleAgent.h:
• inspector/agents/WebDebuggerAgent.h:
• inspector/agents/WebDebuggerAgent.cpp:
• inspector/agents/WebHeapAgent.h:
• inspector/agents/WebHeapAgent.cpp:
• inspector/agents/page/PageAuditAgent.h:
• inspector/agents/page/PageAuditAgent.cpp:
• inspector/agents/page/PageConsoleAgent.h:
• inspector/agents/page/PageConsoleAgent.cpp:
• inspector/agents/page/PageDOMDebuggerAgent.h:
• inspector/agents/page/PageDOMDebuggerAgent.cpp:
• inspector/agents/page/PageDebuggerAgent.h:
• inspector/agents/page/PageDebuggerAgent.cpp:
• inspector/agents/page/PageHeapAgent.h:
• inspector/agents/page/PageHeapAgent.cpp:
• inspector/agents/page/PageNetworkAgent.h:
• inspector/agents/page/PageNetworkAgent.cpp:
• inspector/agents/page/PageRuntimeAgent.h:
• inspector/agents/page/PageRuntimeAgent.cpp:
• inspector/agents/worker/ServiceWorkerAgent.h:
• inspector/agents/worker/ServiceWorkerAgent.cpp:
• inspector/agents/worker/WorkerAuditAgent.h:
• inspector/agents/worker/WorkerConsoleAgent.h:
• inspector/agents/worker/WorkerAuditAgent.cpp:
• inspector/agents/worker/WorkerDOMDebuggerAgent.h:
• inspector/agents/worker/WorkerDOMDebuggerAgent.cpp:
• inspector/agents/worker/WorkerDebuggerAgent.h:
• inspector/agents/worker/WorkerDebuggerAgent.cpp:
• inspector/agents/worker/WorkerNetworkAgent.h:
• inspector/agents/worker/WorkerNetworkAgent.cpp:
• inspector/agents/worker/WorkerRuntimeAgent.h:
• inspector/agents/worker/WorkerRuntimeAgent.cpp:

Elided backend dispatcher handler changes describe above.

• inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::inspect):
(WebCore::CommandLineAPIHost::clearConsoleMessages):

• inspector/InspectorFrontendHost.cpp:

(WebCore::valuePayloadFromJSONValue):
(WebCore::InspectorFrontendHost::logDiagnosticEvent):

• inspector/TimelineRecordFactory.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::appendLayoutRoot):

• Modules/applicationmanifest/ApplicationManifestParser.cpp:

(WebCore::ApplicationManifestParser::parseManifest):
(WebCore::ApplicationManifestParser::parseStartURL):
(WebCore::ApplicationManifestParser::parseDisplay):
(WebCore::ApplicationManifestParser::parseScope):
(WebCore::ApplicationManifestParser::parseGenericString):

• Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::extractKeyIDsKeyids):

• platform/encryptedmedia/CDMUtilities.cpp:

(WebCore::CDMUtilities::parseJSONObject):

• platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::parseLicenseFormat):
(WebCore::parseLicenseReleaseAcknowledgementFormat):

• platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::extractSinfData):

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::parseJSONValue):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
JSON classes now use Ref&& wherever possible and Optional instead of an out parameter
for get*/as* so that values can be more easily manipulated and can be confidently known
to exist.

Source/WebDriver:

• CommandResult.cpp:

(WebDriver::CommandResult::CommandResult):

• Session.cpp:

(WebDriver::firstWindowHandleInResult):
(WebDriver::Session::getTimeouts):
(WebDriver::Session::createTopLevelBrowsingContext):
(WebDriver::Session::handleUserPrompts):
(WebDriver::Session::reportUnexpectedAlertOpen):
(WebDriver::Session::go):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::getTitle):
(WebDriver::Session::getWindowHandle):
(WebDriver::Session::closeTopLevelBrowsingContext):
(WebDriver::Session::switchToWindow):
(WebDriver::Session::getWindowHandles):
(WebDriver::Session::newWindow):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::getToplevelBrowsingContextRect):
(WebDriver::Session::setWindowRect):
(WebDriver::Session::maximizeWindow):
(WebDriver::Session::minimizeWindow):
(WebDriver::Session::fullscreenWindow):
(WebDriver::Session::createElement):
(WebDriver::Session::extractElementID):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::getActiveElement):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::getElementProperty):
(WebDriver::Session::getElementCSSValue):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::elementIsFileUpload):
(WebDriver::Session::parseElementIsFileUploadResult):
(WebDriver::Session::selectOptionElement):
(WebDriver::Session::elementClick):
(WebDriver::Session::elementIsEditable):
(WebDriver::Session::elementClear):
(WebDriver::Session::setInputFileUploadFiles):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::getPageSource):
(WebDriver::Session::handleScriptResult):
(WebDriver::Session::executeScript):
(WebDriver::Session::performMouseInteraction):
(WebDriver::Session::performKeyboardInteractions):
(WebDriver::builtAutomationCookie):
(WebDriver::serializeCookie):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::performActions):
(WebDriver::Session::releaseActions):
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
(WebDriver::Session::takeScreenshot):

• SessionHost.cpp:

(WebDriver::SessionHost::dispatchMessage):

• WebDriverService.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::handleRequest):
(WebDriver::WebDriverService::sendResponse const):
(WebDriver::valueAsNumberInRange):
(WebDriver::deserializeTimeouts):
(WebDriver::deserializeProxy):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::findSessionOrCompleteWithError):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::mergeCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):
(WebDriver::WebDriverService::createSession):
(WebDriver::WebDriverService::deleteSession):
(WebDriver::WebDriverService::go):
(WebDriver::WebDriverService::setWindowRect):
(WebDriver::WebDriverService::closeWindow):
(WebDriver::WebDriverService::switchToWindow):
(WebDriver::WebDriverService::newWindow):
(WebDriver::WebDriverService::switchToFrame):
(WebDriver::findElementOrCompleteWithError):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::WebDriverService::getElementAttribute):
(WebDriver::WebDriverService::getElementProperty):
(WebDriver::WebDriverService::getElementCSSValue):
(WebDriver::WebDriverService::elementSendKeys):
(WebDriver::findScriptAndArgumentsOrCompleteWithError):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::processPauseAction):
(WebDriver::processNullAction):
(WebDriver::processKeyAction):
(WebDriver::processPointerAction):
(WebDriver::processPointerParameters):
(WebDriver::processInputActionSequence):
(WebDriver::WebDriverService::performActions):
(WebDriver::WebDriverService::sendAlertText):

• WebDriver/gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformMatchCapability):
(WebDriver::WebDriverService::platformValidateCapability):
(WebDriver::WebDriverService::platformParseCapabilities):

• WebDriver/win/WebDriverServiceWin.cpp:

(WebDriver::WebDriverService::platformMatchCapability):
(WebDriver::WebDriverService::platformValidateCapability):
(WebDriver::WebDriverService::platformParseCapabilities):

• WebDriver/wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformMatchCapability):
(WebDriver::WebDriverService::platformValidateCapability):
(WebDriver::WebDriverService::platformParseCapabilities):
JSON classes now use Ref&& wherever possible and Optional instead of an out parameter
for get*/as* so that values can be more easily manipulated and can be confidently known
to exist.

Source/WebInspectorUI:

• UserInterface/Controllers/CSSManager.js:

(WI.CSSManager.prototype.set forcedAppearance):
Now that enums are processed before being passed to backend dispacher handlers, the
appearance parameter of Page.setForcedAppearance must be marked optional as
there's no way for it to accept an empty string, as that's not possible for an enum.
As such, rework the frontend logic for invoking Page.setForcedAppearance to instead
not provide an appearance parameter at all when wanting to "unset" it.

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createConsoleSettingsView):
Now that all logging channels matching a Console.ChannelSource are returned instead of
just the hardcoded list, check for a matching WI.UIString before showing a <select>.

Source/WebKit:

Previously, the inspector protocol was expressed in code in a somewhat confusing way:

• the error string was the first argument
• required parameters were T or const T&
• optional parameters were const T*
• enum parameters were the underlying type requiring the backend dispatcher handler to process it instead of it being preprocessed
• required returns were T&
• optional returns were T*

This doesn't really make for easy/obvious reading of code since the order of arguments is
not weird (e.g. error string first), and that there are references/pointers to primitive
types.

This patch cleans up the generated inspector protocol code to be:

• required parameters are T or Ref<T>&&
• optional parameters are Optional<T>&& or RefPtr<T>&&
• enum parameters are preprocessed and passed to the backend dispatcher handler if valid
• synchronous commands return Expected<X, ErrorString> using the same types/rules above where X is either a single return or a std::tuple of multiple returns

The one exception to the above is String, which is already a tri-state of nullString(),
emptyString(), and something set, so there's no need to use Optional<String>.

Also use Protocol objects/typedefs wherever possible to further relate the protocol
JSON and the actual backend dispatcher handler implementation.

• UIProcess/Automation/Automation.json:

CoordinateSystem has Page and Viewport enum values, but WebAutomationSession checks
for "Page" and "LayoutViewport". Add a LayoutViewport enum value now that enums are
processed before being passed to backend dispacher handlers to preserve functionality.

• UIProcess/Inspector/Agents/InspectorBrowserAgent.h:
• UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp:
• UIProcess/Automation/WebAutomationSessionMacros.h:
• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSession.cpp:
• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

Elided backend dispatcher handler changes describe above.

• UIProcess/Inspector/socket/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::setTargetList):
JSON classes now use Ref&& wherever possible and Optional instead of an out parameter
for get*/as* so that values can be more easily manipulated and can be confidently known
to exist.

Source/WTF:

• wtf/JSONValues.h:

(WTF::JSONImpl::ObjectBase::setValue):
(WTF::JSONImpl::ObjectBase::setObject):
(WTF::JSONImpl::ObjectBase::setArray):
(WTF::JSONImpl::ArrayBase::pushValue):
(WTF::JSONImpl::ArrayBase::pushObject):
(WTF::JSONImpl::ArrayBase::pushArray):
(WTF::JSONImpl::ArrayOf::ArrayOf): Deleted.
(WTF::JSONImpl::ArrayOf::castedArray): Deleted.
(WTF::JSONImpl::ArrayOf::addItem): Deleted.
(WTF::JSONImpl::ArrayOf::create): Deleted.

• wtf/JSONValues.cpp:

(WTF::JSONImpl::Value::asValue):
(WTF::JSONImpl::Value::asObject):
(WTF::JSONImpl::Value::asArray):
(WTF::JSONImpl::Value::parseJSON):
(WTF::JSONImpl::Value::asBoolean const):
(WTF::JSONImpl::Value::asDouble const):
(WTF::JSONImpl::Value::asInteger const):
(WTF::JSONImpl::Value::asString const):
(WTF::JSONImpl::ObjectBase::asObject):
(WTF::JSONImpl::ObjectBase::memoryCost const):
(WTF::JSONImpl::ObjectBase::getBoolean const):
(WTF::JSONImpl::ObjectBase::getDouble const):
(WTF::JSONImpl::ObjectBase::getInteger const):
(WTF::JSONImpl::ObjectBase::getString const):
(WTF::JSONImpl::ObjectBase::getObject const):
(WTF::JSONImpl::ObjectBase::getArray const):
(WTF::JSONImpl::ObjectBase::getValue const):
(WTF::JSONImpl::ObjectBase::ObjectBase):
(WTF::JSONImpl::ArrayBase::asArray):
(WTF::JSONImpl::ArrayBase::writeJSON const):
(WTF::JSONImpl::ArrayBase::ArrayBase):
(WTF::JSONImpl::ArrayBase::get const):
(WTF::JSONImpl::ArrayBase::memoryCost const):
(WTF::JSONImpl::ObjectBase::openAccessors): Deleted.
Use Ref&& wherever possible and Optional instead of an out parameter for get*/as*
so that values can be more easily manipulated and can be confidently assumed to exist.
Remove unused overloads and allow subclasses to call as* instead of openAccessors as
they're effectively the same thing.

Tools:

• TestWebKitAPI/Tests/WTF/JSONValue.cpp:

LayoutTests:

• inspector/canvas/requestShaderSource-expected.txt:
• inspector/canvas/updateShader-expected.txt:
• inspector/console/webcore-logging-expected.txt:
• inspector/dom/highlightQuad-expected.txt:
• inspector/worker/dom-debugger-dom-breakpoints-expected.txt:

12:22 PM Changeset in webkit [266884] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Revert accidental hard-coding of compositing logging from r266825.

• platform/Logging.cpp:

(WebCore::initializeLogChannelsIfNecessary):

12:20 PM Changeset in webkit [266883] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Unreviewed Windows build fix after r266842.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setHardwareSampleRateOverride):

12:07 PM Changeset in webkit [266882] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266750. rdar://problem/68652608

Null check m_layerHostingContext in TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=216282
<rdar://problem/64933878>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-08
Reviewed by Tim Horton.

There's no reason to dereference null here. Let's not crash.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266881] by Alan Coon

• 20 edits
  3 adds in branches/safari-610-branch

Cherry-pick r266743. rdar://problem/68652752

iOS: <attachment>'s QuickLook thumbnails can appear squished
​https://bugs.webkit.org/show_bug.cgi?id=216209
<rdar://problem/67817706>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html

• html/HTMLAttachmentElement.idl:
• testing/Internals.cpp: (WebCore::Internals::attachmentThumbnailInfo):
• testing/Internals.h:
• testing/Internals.idl: Expose the attachment thumbnail size via Internals.

• rendering/RenderThemeIOS.mm: (WebCore::RenderAttachmentInfo::RenderAttachmentInfo): Allow the thumbnail aspect ratio to vary, instead of assuming it is always square.

Source/WebKit:

• UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::convertPlatformImageToBitmap): Propagate an image of the same aspect ratio that QuickLook provided, instead of squishing it to square.

• UIProcess/QuickLookThumbnailLoader.mm: (-[WKQLThumbnailLoadOperation start]): Only request full thumbnails; we do not want the icon form, since <attachment> already has one without QuickLook's help; if we can't get a full thumbnail, we'll just leave it alone.

Tools:

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::insertAttachmentForFilePath):
• WebKitTestRunner/TestController.cpp: (WTR::TestController::currentTestURL const):
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: (WTR::UIScriptControllerCocoa::insertAttachmentForFilePath): Make it possible to insert an attachment wrapping a file on disk via UIScriptController.

LayoutTests:

• fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
• fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: Added.
• fast/attachment/resources/400x200-circle.png: Added.
• platform/ios/fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
• resources/ui-helper.js: (window.UIHelper.insertAttachmentForFilePath): Add a test that dumps the thumbnail size for a 400x200 attachment. We only run it on iOS, because on macOS, QuickLook always returns an image of the size we ask for (400x400), padded with whitespace, so the problem does not reproduce and the test doesn't work right there. On iOS, the result used to be 400x400 and now is 400x200.

I tried and failed to make a more useful test (a ref test, actually
testing the presentation) because it's quite hard to match the
native <attachment> painting.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266880] by Alan Coon

• 6 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266717. rdar://problem/68652576

Comparing styles with large but identical custom property maps is slow
​https://bugs.webkit.org/show_bug.cgi?id=216241
<rdar://problem/67946605>

Reviewed by Darin Adler.

In a full style rebuild we lose sharing of equal StyleCustomPropertyDatas between the old and the new style.
Custom properties are usually defined in document element and this lack of sharing inherits to all elements.
Without sharing equality comparisons end up requiring deep comparisons, which can be slow if there are thousands of properties.

Fix by deduplicating identical property maps between the old the new style. All the descendants that inherit the properties will
now be cheap to compare.

The patch also contains some other basic custom property optimizations.

Going to full screen and back on youtube, this patch reduces time in the longest style update from ~460ms to ~90ms.

• css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::equals const):

Check for pointer equality first.

• rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::deduplicateInheritedCustomProperties):

Deduplicate if the properties are equal but not shared.

(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):

Check if the value is already in the map before triggering copy-on-write.

• rendering/style/RenderStyle.h: (WebCore::RenderStyle::setInheritedCustomPropertyValue): Deleted. (WebCore::RenderStyle::setNonInheritedCustomPropertyValue): Deleted.
• style/StyleBuilder.cpp: (WebCore::Style::Builder::applyCustomProperty):

Don't create unnecesary copies of CSSCustomPropertyValue.

• style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Try to deduplicate before comparing the styles.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266879] by Alan Coon

• 6 edits
  4 adds in branches/safari-610-branch

Cherry-pick r266715. rdar://problem/68652550

[JSC] Special property caching should check Structure's cacheability
​https://bugs.webkit.org/show_bug.cgi?id=216222

Reviewed by Saam Barati.

JSTests:

• stress/module-namespace-object-caching.js: Added. (shouldBe): (async fn):
• stress/not-cache-over-uncacheable-dictionary.js: Added. (shouldBe):
• stress/resources/to-string-module.js: Added. (export.toString):
• stress/resources/value-of-module.js: Added. (export.valueOf):

Source/JavaScriptCore:

While StructureRareData::cacheSpecialPropertySlow caches properties, the way it takes is incomplete.
It is not checking Structure's cacheability. We were caching miss condition even if structure is !propertyAccessesAreCacheableForAbsence.
We should perform the same check done in IC case. Strictly speaking, we can cache value for uncacheable-dictionary because we are setting
property change watchpoint (which will fire). But it sounds not so profitable if this structure is uncacheable.

• runtime/JSObject.cpp: (JSC::JSObject::convertToUncacheableDictionary):
• runtime/JSObject.h:
• runtime/StructureRareData.cpp: (JSC::StructureRareData::cacheSpecialPropertySlow):
• tools/JSDollarVM.cpp: (JSC::functionToUncacheableDictionary): (JSC::JSDollarVM::finishCreation):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266878] by Alan Coon

• 4 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266705. rdar://problem/68652668

Add memory cache with/without validation to logResourceResponseSource
​https://bugs.webkit.org/show_bug.cgi?id=216244
<rdar://problem/64184239>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-07
Reviewed by Darin Adler.

• loader/ResourceLoader.cpp: (WebCore::logResourceResponseSource):
• page/DiagnosticLoggingKeys.cpp: (WebCore::DiagnosticLoggingKeys::memoryCacheKey): (WebCore::DiagnosticLoggingKeys::memoryCacheAfterValidationKey):
• page/DiagnosticLoggingKeys.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266877] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266664. rdar://problem/68652524

REGRESSION (r260571): Scrolling on weather.com in Safari causes the gradient background to flicker (fixed backgrounds)
​https://bugs.webkit.org/show_bug.cgi?id=216192
<rdar://problem/68192010>

Reviewed by Tim Horton.

If a page has slow-scrolling reasons, like background-attachment:fixed on a non-root element,
then we should never update layer positions on the scrolling thread, since this results
in scroll position being out of sync with the painted background position.

• page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::canUpdateLayersOnScrollingThread const): (WebCore::ThreadedScrollingTree::waitForRenderingUpdateCompletionOrTimeout): (WebCore::ThreadedScrollingTree::delayedRenderingUpdateDetectionTimerFired): (WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):
• page/scrolling/ThreadedScrollingTree.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266876] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266635. rdar://problem/68652685

[Cocoa,EME] -outputObscuredDueToInsufficientExternalProtection KVO will set OutputObscured for all attached MediaKeySessions.
​https://bugs.webkit.org/show_bug.cgi?id=216185

Reviewed by Eric Carlson.

When EME clients add licenses that have, for instance, different HDCP level requirements, the keyStatus for
each key in the Session (and indeed all attached MediaKeySessions) will be marked as OutputRestricted, since
it is impossible to tell from that KVO which key or session was responsible for creating the violation.

On platforms where the more granular -willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays: query
is available, ignore the KVO from AVSampleBufferDisplayLayer, and rely entirely on the per-request query to
determine key status.

Drive-by fix: add logging when we receive the -outputObscuredDueToInsufficientExternalProtection KVO notification, and
include keyIDs in the keyStatus logging.

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WTF::LogArgument<WebCore::CDMInstanceFairPlayStreamingAVFObjC::Keys>::toString): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266875] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebInspectorUI

Cherry-pick r266624. rdar://problem/68652426

Web Inspector: Localization: typo in WAI-ARIA string ("[the] element have")
​https://bugs.webkit.org/show_bug.cgi?id=216176

Patch by Patrick Angle <Patrick Angle> on 2020-09-04
Reviewed by Devin Rousso.

Resolved element not being pluralized in some audit test descriptions.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Controllers/AuditManager.js: (WI.AuditManager.prototype._addDefaultTests): (WI.AuditManager):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266874] by Alan Coon

• 4 edits in branches/safari-610-branch/Source/WebInspectorUI

Cherry-pick r266622. rdar://problem/68652511

Web Inspector: Localization: "Low/Medium/High" strings need separate keys for different uses in the UI
​https://bugs.webkit.org/show_bug.cgi?id=216136

Reviewed by Brian Burg.

Provide enough context to understand what nouns "low/medium/high" are used with
("impact" and "priority", in our case). This is necessary to determine adjectives'
grammatical gender.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Models/Resource.js: (WI.Resource.displayNameForPriority):

• UserInterface/Views/CPUTimelineView.js: (WI.CPUTimelineView.prototype._layoutEnergyChart): Drive-by: merge two if blocks into one to minimize code repetition.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266873] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266613. rdar://problem/68652692

[macOS] Add client decoder entitlement
​https://bugs.webkit.org/show_bug.cgi?id=216175
<rdar://problem/67532128>

Reviewed by Brent Fulgham.

Add client decoder entitlement in the WebContent process on macOS.

• Scripts/process-entitlements.sh:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266872] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebInspectorUI

Cherry-pick r266612. rdar://problem/68652426

Web Inspector: Localization: typo in WAI-ARIA string ("[the] element have")
​https://bugs.webkit.org/show_bug.cgi?id=216176

Patch by Patrick Angle <Patrick Angle> on 2020-09-04
Reviewed by Brian Burg.

Resolved auxiliary verb in localizable strings having the wrong pluralization for the singular element.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Controllers/AuditManager.js: (WI.AuditManager.prototype._addDefaultTests): (WI.AuditManager):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266871] by Alan Coon

• 4 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266606. rdar://problem/68652779

WebProcessProxy::checkURLReceivedFromWebProcess() does not always need to check the back/forward list
​https://bugs.webkit.org/show_bug.cgi?id=216109
<rdar://problem/59867349>

Reviewed by Brady Eidson.

We should not need to check the back/forward list when setting a
pasteboard URL because any valid pasteboard URL will be handled
by one of the other if-statements in
WebProcessProxy::checkURLReceivedFromWebProcess(), therefore checking
again is a waste of time.

This also hardens the process against potential abuse by preventing
the possibility of an invalid URL in the back/forward list being
saved in the pasteboard property list.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::setPasteboardURL):
• UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
• UIProcess/WebProcessProxy.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266870] by Alan Coon

• 15 edits
  2 moves
  9 adds in branches/safari-610-branch

Cherry-pick r266567. rdar://problem/68652653

[JSC] Cache toString / valueOf / @@toPrimitive for major cases
​https://bugs.webkit.org/show_bug.cgi?id=216061

Reviewed by Saam Barati.

JSTests:

• stress/delete-cached-to-primitive-property.js: Added. (shouldBe): (object.proto.Symbol.toPrimitive):
• stress/delete-cached-to-string-property.js: Added. (shouldBe): (object.proto.toString):
• stress/delete-cached-value-of-property.js: Added. (shouldBe): (shouldThrow): (object.proto.valueOf):
• stress/hide-cached-to-primitive-property.js: Added. (shouldBe): (object.proto.Symbol.toPrimitive):
• stress/hide-cached-to-string-property.js: Added. (shouldBe): (object.proto.toString):
• stress/hide-cached-value-of-property.js: Added. (shouldBe): (object.proto.valueOf):
• stress/replace-cached-to-primitive-property.js: Added. (shouldBe): (object.proto.Symbol.toPrimitive):
• stress/replace-cached-to-string-property.js: Added. (shouldBe): (object.proto.toString):
• stress/replace-cached-value-of-property.js: Added. (shouldBe): (object.proto.valueOf):

Source/JavaScriptCore:

When toPrimitive is called, we need to look-up three properties at most to perform operation. And these special properties do not have caching mechanism at all.
We found that Speedometer2/EmberJS-Debug-TodoMVC is using very much time for this property look-up. We should have caching mechanism in StructureRareData, which
should be similar to @@toStringTag & Object#toString caching mechanism.

This patch generalizes @@toStringTag & Object#toString caching mechanism as SpecialPropertyCache. And we accelerate toString / valueOf / @@toPrimitive look-ups in
toPrimitive with this caching mechanism.

This patch improved Speedometer2/EmberJS-Debug-TodoMVC by 10%.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• bytecode/Watchpoint.cpp:
• bytecode/Watchpoint.h:
• runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.cpp: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp. (JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::CachedSpecialPropertyAdaptiveStructureWatchpoint): (JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::install): (JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::fireInternal):
• runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.h: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.h.
• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren):
• runtime/JSGlobalObject.h: (JSC::JSGlobalObject::objectProtoToStringFunction const):
• runtime/JSObject.cpp: (JSC::callToPrimitiveFunction): (JSC::JSObject::ordinaryToPrimitive const): (JSC::JSObject::toPrimitive const):
• runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::finishCreation): (JSC::objectProtoFuncToString):
• runtime/Structure.h:
• runtime/StructureInlines.h: (JSC::Structure::cacheSpecialProperty): (JSC::Structure::setObjectToStringValue): Deleted.
• runtime/StructureRareData.cpp: (JSC::StructureRareData::visitChildren): (JSC::StructureRareData::ensureSpecialPropertyCacheSlow): (JSC::StructureRareData::giveUpOnSpecialPropertyCache): (JSC::StructureRareData::cacheSpecialPropertySlow): (JSC::StructureRareData::clearCachedSpecialProperty): (JSC::StructureRareData::finalizeUnconditionally): (JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint): (JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::isValid const): (JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::handleFire): (JSC::StructureRareData::setObjectToStringValue): Deleted. (JSC::StructureRareData::clearObjectToStringValue): Deleted. (JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::ObjectToStringAdaptiveInferredPropertyValueWatchpoint): Deleted. (JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::isValid const): Deleted. (JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire): Deleted.
• runtime/StructureRareData.h:
• runtime/StructureRareDataInlines.h: (JSC::StructureRareData::cachedSpecialProperty const): (JSC::StructureRareData::canCacheSpecialProperty): (JSC::StructureRareData::ensureSpecialPropertyCache): (JSC::StructureRareData::cacheSpecialProperty): (JSC::StructureRareData::objectToStringValue const): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266869] by Alan Coon

• 11 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266539. rdar://problem/68652473

Mark uniform samplers in an array unused per element
​https://bugs.webkit.org/show_bug.cgi?id=215630

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-09-03
Reviewed by Dean Jackson.

Mark uniform samplers in an uniform sampler array unused per
element, if driver informs the element being unused.
Before, one element would mark the whole array as being
unused, and samplers that were in use would not be updated.

Source/ThirdParty/ANGLE:

• src/libANGLE/Context.cpp: (gl::StateCache::updateActiveImageUnitIndices):
• src/libANGLE/Program.cpp: (gl::SamplerBinding::SamplerBinding): (gl::ImageBinding::ImageBinding): (gl::Program::getSamplerUniformBinding const): (gl::Program::getImageUniformBinding const): (gl::Program::linkSamplerAndImageBindings): (gl::Program::updateSamplerUniform): (gl::Program::serialize const): (gl::Program::deserialize):
• src/libANGLE/ProgramExecutable.cpp: (gl::ProgramExecutable::updateActiveSamplers): (gl::ProgramExecutable::updateActiveImages): (gl::ProgramExecutable::setSamplerUniformTextureTypeAndFormat):
• src/libANGLE/ProgramExecutable.h:
• src/libANGLE/renderer/gl/ProgramGL.cpp: (rx::ProgramGL::markUnusedUniformLocations):
• src/libANGLE/renderer/metal/ProgramMtl.mm: (rx::ProgramMtl::updateTextures):
• src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp: (rx::ProgramExecutableVk::updateImagesDescriptorSet): (rx::ProgramExecutableVk::updateTexturesDescriptorSet):
• src/tests/gl_tests/ComputeShaderTest.cpp:
• src/tests/gl_tests/UniformTest.cpp:

LayoutTests:

• fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt: Added.
• fast/canvas/webgl/glsl-sampler-array-unused-element.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [266868] by Alan Coon

• 4 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266526. rdar://problem/68652615

Consecutive requestAnimationFrame callbacks may be passed the same timestamp
​https://bugs.webkit.org/show_bug.cgi?id=216122
<rdar://problem/68269445>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/animation/request-animation-frame-unique-timestamp.html

Ensure that the page only sees increasing timestamps in requestAnimationFrame() callbacks.

• dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::shouldRescheduleRequestAnimationFrame const):

LayoutTests:

Add a test that two subsequent animation frames as identified via requestAnimationFrame() callbacks
are provided increasing timestamps.

Also removing flaky expectation for two WPT animations tests which pass reliably after this fix.

• fast/animation/request-animation-frame-unique-timestamp-expected.txt: Added.
• fast/animation/request-animation-frame-unique-timestamp.html: Added.
• platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266867] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebInspectorUI

Cherry-pick r266499. rdar://problem/68652501

REGRESSION (r251254): Web Inspector: Text insertion point is invisible when editing DOM nodes
​https://bugs.webkit.org/show_bug.cgi?id=210197
<rdar://problem/61485409>

Reviewed by Devin Rousso.

r251254 promoted the selection area into a layer on top the the tree outline item.
Combined with the existing WebKit bug (​https://webkit.org/b/213501), it introduced the regression.

This patch is largely a workaround for the WebKit bug.

Revert r251254 and instead change the background color of the shadow DOM items from
the semi-transparent gray to black (white in the dark mode) with 5% transparency, which
produced the same gray color overlayed on top of the white background of the DOM tree outline.

• UserInterface/Views/DOMTreeOutline.css: (.tree-outline.dom): (.tree-outline.dom li .selection-area):

(.tree-outline.dom li > :not(.selection-area)): Deleted.
Don't introduce a layer for every DOM node.

(.tree-outline.dom li.parent.shadow::after):
(.tree-outline.dom li.parent.shadow + ol.children.expanded):
(@media (prefers-color-scheme: dark) .tree-outline.dom):
(@media (prefers-color-scheme: dark) .tree-outline.dom .shadow):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266866] by Alan Coon

• 4 edits
  1 add in branches/safari-610-branch

Cherry-pick r266496. rdar://problem/68652591

ASSERTION FAILED: value.isCell() && value.asCell()->type() == CustomGetterSetterType ./bytecode/ObjectPropertyConditionSet.cpp
​https://bugs.webkit.org/show_bug.cgi?id=216103

Reviewed by Saam Barati.

JSTests:

New teset.

• stress/custom-get-set-override.js: Added. (overrideFunction.o.customFunction): (overrideFunction):

Source/JavaScriptCore:

Changed the ASSERT to an if statement. This checks to see if, the likely newly changed,
property is still a custom getter setter before caching its access as such.

• bytecode/ObjectPropertyConditionSet.cpp: (JSC::generateConditionsForPrototypePropertyHitCustom):
• tools/JSDollarVM.cpp: Added test helper function.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266865] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266493. rdar://problem/68652496

Remove custom domain from SameSite=strict jail protection
​https://bugs.webkit.org/show_bug.cgi?id=216083
<rdar://problem/68220223>

Reviewed by Alex Christensen.

No new tests. This was a site-specific opt-in rule. The feature
itself has tests.

• NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: (WebKit::ResourceLoadStatisticsStore::shouldEnforceSameSiteStrictForSpecificDomain const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266864] by Alan Coon

• 5 edits in branches/safari-610-branch/Source

Cherry-pick r266485. rdar://problem/68652729

iPad + Trackpad: JW Library highlighting and edit menus don't appear
​https://bugs.webkit.org/show_bug.cgi?id=216086

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm: (WebCore::IOSApplication::isJWLibrary):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm: (applicationIsKnownToIgnoreMouseEvents): Add JW Library to the list.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266863] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebInspectorUI

Cherry-pick r266477. rdar://problem/68652841

Web Inspector: Timelines: duplicate "Timeline Recording 1" on open
​https://bugs.webkit.org/show_bug.cgi?id=216060

Reviewed by Brian Burg.

• UserInterface/Controllers/TimelineManager.js: (WI.TimelineManager): (WI.TimelineManager.prototype.get recordings): Deleted. Don't reset in the constructor as this is already done in enable and disable, which is called whenever the Timeline Tab is added/removed.

• UserInterface/Views/TimelineTabContentView.js: (WI.TimelineTabContentView): There should never be any existing recordings when adding the Timelines Tab, as they should have been removed when the tab was last removed (via WI.TimelineManager.prototype.disable).

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266862] by Alan Coon

• 4 edits in branches/safari-610-branch/LayoutTests

Cherry-pick r266475. rdar://problem/68652660

REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215614
<rdar://problem/67333849>

Reviewed by Eric Carlson.

• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html:
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt:

• platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266861] by Alan Coon

• 3 edits in branches/safari-610-branch

Cherry-pick r266470. rdar://problem/68652453

REGRESSION (r264661): Crashes in WebCore::wrap<WebCore::Blob> in CloneDeserializer
​https://bugs.webkit.org/show_bug.cgi?id=215835

Reviewed by Youenn Fablet.

Partially revert r264661 as there are cases, other than our previous IDB, where we may not use JSDOMGlobalObject
for serialization and deserialization, like the one showed in the crashlog. Therefore, we still need the check
for JSDOMGlobalObject.

API Test: WebKit.EvaluateJavaScriptThatCreatesBlob

• bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CloneDeserializer): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readRTCCertificate): (WebCore::CloneDeserializer::readTerminal):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266860] by Alan Coon

• 4 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266454. rdar://problem/68652810

Safari is not able to hear audio when using WebRTC in multiple tabs
​https://bugs.webkit.org/show_bug.cgi?id=215270
<rdar://problem/66736746>

Reviewed by Eric Carlson.

Covered by manually testing that audio continues when two pages in the same process create a peer connection,
one plays audio with WebRTC and the second one is closed.
Before the patch, the closing page would stop the audio device module, even though the first page would like the module to continue playing.
Fix this by creating an audio module per page instead of process wide.

• platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp: (WebCore::initializePeerConnectionFactoryAndThreads): (WebCore::LibWebRTCProvider::factory): (WebCore::LibWebRTCProvider::createPeerConnectionFactory):
• platform/mediastream/libwebrtc/LibWebRTCProvider.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266859] by Alan Coon

• 4 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266451. rdar://problem/68652772

REGRESSION(r243264): Web Inspector: Style pane doesn't update after toggling CSS class
​https://bugs.webkit.org/show_bug.cgi?id=202065
<rdar://problem/55149141>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Models/DOMNodeStyles.js: (WI.DOMNodeStyles.prototype.refresh.fetchedMatchedStyles): (WI.DOMNodeStyles.prototype.refresh.fetchedComputedStyle): (WI.DOMNodeStyles.prototype.refresh): (WI.DOMNodeStyles.prototype._parseStyleDeclarationPayload): r243264 introduced this bug by never clearing _styleMap making it impossible to diff old and new style declarations. Create and clear _styleMap at the same place as it was before r243264.

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js: (WI.SpreadsheetRulesStyleDetailsPanel): (WI.SpreadsheetRulesStyleDetailsPanel.prototype.layout): Layout now always re-layouts everything. Rules with modified selectors are now preserved by exiting layout early.

(WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionSelectorWillChange):
Remove logic that tried to preserve indexes of CSS rules with modified selectors that
don't match (SectionIndexSymbol and everything related to it). Instead, avoid re-layout after
editing a selector.

LayoutTests:

Added a test to verify that WI.DOMNodeStyles.Event.Refreshed fires with appropriate
significantChange flag.

• inspector/css/node-styles-refreshed-expected.txt: Added.
• inspector/css/node-styles-refreshed.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266858] by Alan Coon

• 8 edits
  4 adds in branches/safari-610-branch

Cherry-pick r266443. rdar://problem/68652756

REGRESSION(r262366): MotionMark1.1 | macOS | Some devices | 1-3% overall regression
​https://bugs.webkit.org/show_bug.cgi?id=215989
<rdar://problem/66845937>

Reviewed by Darin Adler.

Source/WebCore:

The new approach to compositing WebGL caused a slowdown in some
canvas performance tests. They were notifying the Document
of all drawing commands, even on 2d canvases that didn't need
to prepare before compositing.

The solution is to only add the Document as an observer
when necessary. This recovers the performance hit - measured
using the Canvas Lines MotionMark test.

Tests: fast/canvas/webgl/move-canvas-in-document-while-clean.html

fast/canvas/webgl/move-canvas-in-document.html

• dom/Document.cpp: (WebCore::Document::prepareCanvasesForDisplayIfNeeded): Leave a FIXME indicating that we should try to avoid the copyToVector if we can ensure that the prepareForDisplay call will not mutate the HashSet.

• html/CanvasBase.cpp: Remove some copyToVector calls. It should be fine to iterate over the HashSet for these notification functions. (WebCore::CanvasBase::notifyObserversCanvasChanged): (WebCore::CanvasBase::notifyObserversCanvasResized):

• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): Don't add the Document as a canvas observer. Wait until we know it is a context that needs observing. (WebCore::HTMLCanvasElement::createContextWebGL): Now we can add it as an observer. (WebCore::HTMLCanvasElement::didMoveToNewDocument): Swap observation to the new Document. (WebCore::HTMLCanvasElement::insertedIntoAncestor): Ditto, but also be aware that we might be in a "dirty" state, and thus need to immediately tell the new document that the canvas needs preparation. (WebCore::HTMLCanvasElement::removedFromAncestor): Remove the observer. (WebCore::HTMLCanvasElement::needsPreparationForDisplay): Use a virtual function on the context instead of checking the type. (WebCore::HTMLCanvasElement::prepareForDisplay): Ditto.

• html/canvas/CanvasRenderingContext.h: New virtual functions to avoid type checking in HTMLCanvasElement. (WebCore::CanvasRenderingContext::compositingResultsNeedUpdating const): (WebCore::CanvasRenderingContext::needsPreparationForDisplay const): (WebCore::CanvasRenderingContext::prepareForDisplay):

• html/canvas/WebGLRenderingContextBase.cpp: Implementations of the virtual functions that tell HTMLCanvasElement that it needs to prepareForDisplay. (WebCore::WebGLRenderingContextBase::markContextChanged): (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): (WebCore::WebGLRenderingContextBase::didComposite):
• html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

• fast/canvas/webgl/move-canvas-in-document-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean.html: Added.
• fast/canvas/webgl/move-canvas-in-document.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266857] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266410. rdar://problem/68652625

<video> element prevents screen from sleeping even after playback finishes
​https://bugs.webkit.org/show_bug.cgi?id=216017
<rdar://problem/66665846>

Reviewed by Darin Adler.

When video playback would finish (due to reaching end of file), HTMLMediaElement::mediaPlayerRateChanged()
would get called, which would call updateSleepDisabling(). The idea was that updateSleepDisabling() would
destroy the SleepDisabler to allow the display to sleep again. However, updateSleepDisabling() would not
destroy the SleepDisabler because it does not know yet that the media has been paused. We only learned
about it later on, when MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange() gets called.
To address the problem, we now call updateSleepDisabling() when
MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange() is called too.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266856] by Alan Coon

• 6 edits in branches/safari-610-branch/Source

Cherry-pick r266407. rdar://problem/68652645

Some apps linked beyond iOS 13.4 don't respect mouse events, only touch events
​https://bugs.webkit.org/show_bug.cgi?id=216021
<rdar://problem/64830335>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm: (WebCore::IOSApplication::isFIFACompanion): (WebCore::IOSApplication::isNoggin): (WebCore::IOSApplication::isOKCupid): Add some more bundle checks.

Source/WebKit:

• UIProcess/Cocoa/VersionChecks.h:
• UIProcess/ios/WKContentViewInteraction.mm: (applicationIsKnownToIgnoreMouseEvents): (-[WKContentView shouldUseMouseGestureRecognizer]): Remove Feedly from the list, they are no longer affected. Add a once-per-app-launch error-level log message to warn developers of the impending behavior change. Add three new apps with a later linked-on target.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266855] by Alan Coon

• 6 edits in branches/safari-610-branch/Source

Cherry-pick r266406. rdar://problem/68652786

Remove some PtrTag debugging code from release builds.
​https://bugs.webkit.org/show_bug.cgi?id=216025
<rdar://problem/68098263>

Reviewed by Saam Barati.

Source/JavaScriptCore:

Removed PtrTag name lookup debugging utility from release builds.

• runtime/JSCPtrTag.cpp:
• runtime/JSCPtrTag.h:

Source/WTF:

Converted uses of PtrTagAction::ReleaseAssert to PtrTagAction::DebugAssert.
These assertions serve a purpose during development (hence, PtrTagAction::DebugAssert),
but is no longer needed for release builds. Previously, we use these assertions
to verify that pointers are tagged correctly in release build. Clang takes care
of that automatically now.

Also removed PtrTag name lookup debugging utility from release builds.

• wtf/PtrTag.cpp:
• wtf/PtrTag.h: (WTF::untagCodePtr): (WTF::retagCodePtrImpl): (WTF::assertIsCFunctionPtr): (WTF::assertIsNotTagged): (WTF::assertIsTagged): (WTF::assertIsTaggedWith):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266854] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266405. rdar://problem/68652679

Crashtracer in SubresourceLoader::didCancel.
<rdar://problem/32831629> and ​https://bugs.webkit.org/show_bug.cgi?id=216020

Reviewed by Alex Christensen.

No new tests (Despite spotting theoretical ways this is possible, unable to construct a reproduction)

It's possible for a newly created SubresourceLoader to be cancelled right after creation.
In this case, m_resource will be null inside of SubresourceLoader::didCancel.

Other parts of SubresourceLoader null check m_resource, so it's reasonable to state ::didCancel should as well.

• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didCancel): Early return if reachedTerminalState(), and ASSERT(m_resource) after.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266853] by Alan Coon

• 8 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266403. rdar://problem/68652439

EventRegion paint should respect layer's foreground and background painting phases
​https://bugs.webkit.org/show_bug.cgi?id=216031
<rdar://problem/67282372>

Reviewed by Simon Fraser.

Source/WebCore:

We are currently painting event region for the box background to the foreground layer, which can cause
foreground layer to wrongly catch scroll events. Similarly we are unnecessarily painting foreground for
layers that don't need it.

Test: fast/scrolling/mac/negative-z-index-overflow-scroll.html

• rendering/PaintPhase.h:

Add two new event region specific PaintBehaviors for foreground and background paint. This essentially duplicates
foreground/background PaintPhases but since event region paint is itself a paint phase we can't use those.
This should be reconciled at some point.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):

Add the background flag when painting contents as the descendant backgrounds are part of the layer foreground.

(WebCore::RenderBlock::paintObject):

Respect the new flags.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):

Setup the flags based on what we are supposed to be painting on this layer.

(WebCore::RenderLayer::collectEventRegionForFragments):

Flag filtering moves to paintLayerContents.

LayoutTests:

• editing/editable-region/text-field-inside-composited-negative-z-index-layer-expected.txt:
• fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt: Added.
• fast/scrolling/mac/negative-z-index-overflow-scroll.html: Added.
• pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer-expected.txt:
• pointerevents/ios/touch-action-region-backing-sharing-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266852] by Alan Coon

• 21 edits in branches/safari-610-branch/Source/JavaScriptCore

Cherry-pick r266359. rdar://problem/68652634

[JSC] StructureStubInfo / CallLinkInfo / ByValInfo should set CodeOrigin or BytecodeIndex at construction
​https://bugs.webkit.org/show_bug.cgi?id=215987
<rdar://problem/66370323>

Reviewed by Mark Lam.

We had race condition during construction of StructureStubInfo and CodeOrigin field setting.

1. The thread creates StructureStubInfo by calling CodeBlock::addStubInfo. This is guarded by the lock. But at this point we are not setting StructureStubInfo::codeOrigin.
2. Then (1)'s thread attempts to set StructureStubInfo::codeOrigin. But at this point, it is not guarded by the lock.
3. Before (2) is executed, DFG ByteCodeParser calls CodeBlock::getICStatusMap. It creates HashMap<CodeOrigin, StructureStubInfo*>.
4. Since StructureStubInfo*'s codeOrigin is not configured yet, (3) sees invalid CodeOrigin. And storing invalid CodeOrigin as a HashMap key is not correct.

We should configure CodeOrigin at construction of StructureStubInfo, which is guarded by the lock. We have the same problem for CallLinkInfo and ByValInfo. This patch fixes them.
To reproduce this, we need to execute a script 2~ days repeatedly. So it is difficult to add a test.

• bytecode/AccessCase.cpp: (JSC::AccessCase::generateImpl):
• bytecode/ByValInfo.h: (JSC::ByValInfo::ByValInfo): (JSC::ByValInfo::setUp):
• bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::CallLinkInfo):
• bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::setUpCall): (JSC::CallLinkInfo::setCodeOrigin): Deleted.
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::addStubInfo): (JSC::CodeBlock::addByValInfo): (JSC::CodeBlock::addCallLinkInfo):
• bytecode/CodeBlock.h:
• bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::StructureStubInfo):
• bytecode/StructureStubInfo.h:
• dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::emitCall):
• dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::emitCall):
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct): (JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct): (JSC::FTL::DFG::LowerDFGToB3::compileTailCall): (JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread): (JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs): (JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
• jit/JIT.cpp: (JSC::JIT::link):
• jit/JITCall.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall):
• jit/JITCall32_64.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall):
• jit/JITInlineCacheGenerator.cpp: (JSC::garbageStubInfo): (JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
• jit/JITOpcodes.cpp: (JSC::JIT::emit_op_has_indexed_property):
• jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_has_indexed_property):
• jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_put_by_val):
• jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_put_by_val):
• wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266851] by Alan Coon

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266336. rdar://problem/68652585

REGRESSION (r266262): Scroll latching fails when scrolling into a preventDefault() region
​https://bugs.webkit.org/show_bug.cgi?id=215988
<rdar://problem/68034716>

Reviewed by Tim Horton.
Source/WebCore:

In r266262 ScrollingTreeLatchingController started to consult the "last handled wheel event"
time when deciding whether to use the latched node, but we didn't update this timestamp when
handling an event on the latched node, on the scrolling thread. So fix that.

Test: fast/scrolling/latching/latched-scroll-into-nonfast-region.html

• page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent):

LayoutTests:

• fast/scrolling/latching/latched-scroll-into-nonfast-region-expected.txt: Added.
• fast/scrolling/latching/latched-scroll-into-nonfast-region.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266850] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266329. rdar://problem/68652477

[Cocoa] MediaSample JSON strings are created for logging to disabled channels
​https://bugs.webkit.org/show_bug.cgi?id=215980
<rdar://problem/68004132>

Reviewed by Simon Fraser.

On platforms that USE(OS_LOG), DEBUG_LOG() evaluates its arguments even in production
builds. In SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID(), one DEBUG_LOG() call
involved creating a non-trivial JSON object describing a MediaSample then converting that to
a JSON string. This string was created even when debug logging was disabled at runtime.
Profiles showed this cost half a millisecond per second of video playback on netflix.com in
Safari on a MacBook Pro.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID): Rather than calling MediaSample::toJSONString() directly, let the LogArgument<MediaSample> specialization call toJSONString() iff the log channel is enabled.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [266849] by Alan Coon

• 4 edits in branches/safari-610-branch

Cherry-pick r266314. rdar://problem/68652747

Sites built with flambe.js don't work with trackpad on iPad
​https://bugs.webkit.org/show_bug.cgi?id=215954

Reviewed by Wenson Hsieh.

Source/WebKit:

New API Test: iOSMouseSupport.MouseTimestampTimebase

• UIProcess/ios/WKMouseGestureRecognizer.mm: (-[WKMouseGestureRecognizer createMouseEventWithType:]): Use the timestamp property on UITouch instead of GSCurrentEventTimestamp(). This property is in the same units as mach_absolute_time/MonotonicTime. Previously, treating a monotonic time as wall time resulted in it getting clamped to 0, breaking sites that depend on it.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm: (-[WKTestingHoverEvent locationInView:]): (-[WKTestingTouch timestamp]): (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:57 AM Changeset in webkit [266848] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Share code when constructing LineBox::InlineBox for the atomic inline-level box
​https://bugs.webkit.org/show_bug.cgi?id=216338

Reviewed by Antti Koivisto.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::createDisplayBoxesForLineContent):

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::inlineRectForTextRun const): Deleted.

• layout/inlineformatting/InlineLineBox.h:

11:50 AM Changeset in webkit [266847] by sihui_liu@apple.com

• 11 edits in trunk

Source/WebKit:
REGRESSION(r266634): [macOS release] 4 layout tests became flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=216275
<rdar://problem/68515242>

Reviewed by Tim Horton.

After r266634, activity state changes caused by adding/removing view will not be dispatched to web process until
transaction is committed in UI process. To make sure web process picks up the changes, we need to invoke the
callbacks after activity state changes are dispatched.

• UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
• UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _doAfterActivityStateUpdate:]):

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::addActivityStateUpdateCompletionHandler):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateChange):

• UIProcess/WebPageProxy.h:

Tools:
REGRESSION (r266634): [macOS release] 4 layout tests became flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=216275
<rdar://problem/68515242>

Reviewed by Tim Horton.

• WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::removeViewFromWindow):
(WTR::UIScriptControllerCocoa::addViewToWindow):

LayoutTests:
REGRESSION (r266634): [macOS release] 4 layout tests became flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=216275
<rdar://problem/68515242>

Reviewed by Tim Horton.

Add more event handlers to make test more stable, and add extra logging for debugging.

• fast/events/page-visibility-iframe-move-test-expected.txt:
• fast/events/page-visibility-iframe-move-test.html:

11:36 AM Changeset in webkit [266846] by Antti Koivisto

• 26 edits
  1 copy
  3 adds in trunk

Don't create event regions when the page has no subscrollers
​https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/mac/event-region-subscroller-frame.html

fast/scrolling/mac/event-region-subscroller-overflow.html

Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::hasSubscrollers const):

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::hasSubscrollers const):

• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):

• page/scrolling/ScrollingStateTree.h:

(WebCore::ScrollingStateTree::scrollingNodeCount const):
(WebCore::ScrollingStateTree::scrollingNodeAdded):
(WebCore::ScrollingStateTree::scrollingNodeRemoved):

Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::maintainsEventRegion const):

Don't maintain event region if there are no subscrollers and none of the other reasons were hit.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

Invalidate event regions if a subscroller appears.

(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):

• rendering/RenderLayerCompositor.h:

LayoutTests:

Add overflow scrollers to some existing tests so they still generate event regions.

• fast/scrolling/ios/border-radius-event-region-expected.txt:
• fast/scrolling/ios/border-radius-event-region.html:
• fast/scrolling/ios/event-region-float-expected.txt:
• fast/scrolling/ios/event-region-float.html:
• fast/scrolling/ios/event-region-pointer-events-expected.txt:
• fast/scrolling/ios/event-region-pointer-events.html:
• fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-scale-transform-shared.html:
• fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-translate-transform-shared.html:
• fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
• fast/scrolling/ios/event-region-visibility-hidden.html:
• fast/scrolling/mac/border-radius-event-region-expected.txt:
• fast/scrolling/mac/border-radius-event-region.html:
• fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-frame.html: Added.
• fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
• fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
• fast/scrolling/mac/event-region-visibility-hidden.html:

11:30 AM Changeset in webkit [266845] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.6

11:23 AM Changeset in webkit [266844] by jer.noble@apple.com

• 7 edits in trunk/Source

[Cocoa] PERF: Don't instantiate AVPlayer-based audio decoders or renderers if an element is initially muted.
​https://bugs.webkit.org/show_bug.cgi?id=216299

Reviewed by Eric Carlson.

Source/WebCore:

When an AVPlayer is created, even if muted, it will still instantiate an audio decoder and renderer if the
AVAsset in the current player item has an audio track. Ostensibly, this is so that an unmute operation is
instantaneous, as it's merely applying a zero gain to the decoded audio. However for web content, there's
many autoplaying, muted <video> elements which may never be un-muted before being destroyed.

Implement a policy where, if an AVPlayer is initially muted, we adopt AVFoundation SPI to forcibly prevent
audio decoding and rendering until the first time the AVPlayer is unmuted. This means the first un-mute may
not be instantaneous, as an audio decoder will have to be created and fed before any audio is rendered.

There's some incorrect caching of mute state at the MediaPlayer level; so MediaPlayer and MPPAVFoundationObjC
can get their respective m_muted states out of sync. Make sure that HTMLMediaElement always sets muted state
after creating a MediaPlayer and that, respectively, MPPAVFoundationObjC always queries it's parent MediaPlayer's
mute state when it in turn is created.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaPlayer):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setMuted):

Source/WebCore/PAL:

• pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

• wtf/PlatformHave.h:

11:22 AM Changeset in webkit [266843] by Chris Dumez

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html.

• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:

11:20 AM Changeset in webkit [266842] by Chris Dumez

• 20 edits in trunk

Some WebAudio tests give different output on different machines
​https://bugs.webkit.org/show_bug.cgi?id=216371

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline a few tests that now have a different output.

• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:

Source/WebCore:

Add function to override the value returned by AudioDestination::hardwareSampleRate().

• DerivedSources-output.xcfilelist:
• platform/audio/AudioDestination.h:
• platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::hardwareSampleRateOverride):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestination::setHardwareSampleRateOverride):

• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::hardwareSampleRateOverride):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestination::setHardwareSampleRateOverride):

Source/WebKit:

Add InjectedBundle SPI to set the hardware sample rate.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetHardwareSampleRateOverride):

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setHardwareSampleRateOverride):

• WebProcess/InjectedBundle/InjectedBundle.h:

Source/WebKitLegacy/mac:

Add WebView SPI to set the hardware sample rate.

• WebView/WebView.mm:

(+[WebView _setHardwareSampleRateOverride:]):

• WebView/WebViewPrivate.h:

Tools:

Update DRT / WRT to hardcode the hardware sample rate to 44100 so that Web Audio
test have the same output on different hardware.

• DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

11:18 AM Changeset in webkit [266841] by Darin Adler

• 3 edits in trunk/LayoutTests

Fix failing combobox-activedescendant-notifications.html test
​https://bugs.webkit.org/show_bug.cgi?id=216366

Reviewed by Sam Weinig.

• accessibility/mac/combobox-activedescendant-notifications.html:
• accessibility/mac/combobox-activedescendant-notifications.html:

Fix the listener in this test that was listening to the wrong accessibility object and
also changed it to not hide the test elements until the test is complete. I do not
understand fully why this test ever passed before at all; with this it passes consistently.

• fast/selectors/focus-within-style-update.html: Unrelated bonus: Added comments to this

test since it's one that will fail if someone changes focus behavior with display:none.
Just comments.

11:12 AM Changeset in webkit [266840] by don.olmstead@sony.com

• 4 edits in trunk/Source/WebCore

WebGL2RenderingContext should use Graphics Context types
​https://bugs.webkit.org/show_bug.cgi?id=216310

Reviewed by Kenneth Russell.

A number of declarations were using OpenGL types instead of the GCGL types.
All instances of GL types were replaced with the equivalent GCGL ones. Any
GL constants were replaced with the listing in GraphicsContext.

Renamed GraphcsContext::WAIT_FAILED to WAIT_FAILED_WEBGL to remove PLATFORM(WIN)
defining its own variant WAIT_FAILED_WIN. WAIT_FAILED conflicts with a Windows
definition.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::validateTexFuncLayer):
(WebCore::WebGL2RenderingContext::compressedTexSubImage2D):
(WebCore::WebGL2RenderingContext::clientWaitSync):
(WebCore::ValidateTransformFeedbackPrimitiveMode):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::WebGL2RenderingContext::getParameter):
(WebCore::WebGL2RenderingContext::validateClearBuffer):
(WebCore::WebGL2RenderingContext::uniform1fv):
(WebCore::WebGL2RenderingContext::uniform2fv):
(WebCore::WebGL2RenderingContext::uniform3fv):
(WebCore::WebGL2RenderingContext::uniform4fv):
(WebCore::WebGL2RenderingContext::uniform1iv):
(WebCore::WebGL2RenderingContext::uniform2iv):
(WebCore::WebGL2RenderingContext::uniform3iv):
(WebCore::WebGL2RenderingContext::uniform4iv):
(WebCore::WebGL2RenderingContext::uniformMatrix2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4fv):
(WebCore::WebGL2RenderingContext::readPixels):

• html/canvas/WebGL2RenderingContext.h:
• platform/graphics/GraphicsContextGL.h:

10:42 AM Changeset in webkit [266839] by Alan Coon

• 8 edits in branches/safari-610.2.4.0-branch/Source

Versioning.

WebKit-7610.2.4.0.1

10:40 AM Changeset in webkit [266838] by sihui_liu@apple.com

• 5 edits in trunk

REGRESSION(r266634): fast/animation/request-animation-frame-throttling-lowPowerMode.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=216261
<rdar://problem/68513429>

Reviewed by Tim Horton.

Source/WebKit:

r266634 makes a behavior change that when there is an activity state change, TiledCoreAnimationDrawingArea
schedules a rendering update. This breaks timed rendering update from ScriptedAnimationController in the
test. If rendering update happens before timer fires, the callback of ScriptedAnimationController will be
invoked earlier than expected, thus more callbacks executed in the same time frame.

To fix this, let's only schedule rendering update when we need to handle activity state change callbacks,
as before r266634, where we don't schedule activity state timer if there is no callback.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):

LayoutTests:

• fast/animation/request-animation-frame-throttling-lowPowerMode-expected.txt:
• fast/animation/request-animation-frame-throttling-lowPowerMode.html:

10:39 AM Changeset in webkit [266837] by Russell Epstein

• 1 copy in branches/safari-610.2.4.0-branch

New branch.

10:38 AM Changeset in webkit [266836] by timothy_horton@apple.com

• 4 edits in trunk/Source

Upstream additional linked-on-or-after version checks
​https://bugs.webkit.org/show_bug.cgi?id=216365

Reviewed by Sam Weinig.

Source/WebKit:

• UIProcess/Cocoa/VersionChecks.h:

Source/WTF:

• wtf/spi/darwin/dyldSPI.h:

10:32 AM Changeset in webkit [266835] by Chris Dumez

• 6 edits in trunk

Port BaseAudioContext to the HTML event loop
​https://bugs.webkit.org/show_bug.cgi?id=216331

Reviewed by Sam Weinig.

Source/WebCore:

Stop using legacy GenericEventQueue class and port BaseAudioContext to the
modern HTML event loop instead.

• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::finish):

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):
(WebCore::BaseAudioContext::setState):
(WebCore::BaseAudioContext::finishedRendering):
(WebCore::BaseAudioContext::postTask):

• Modules/webaudio/BaseAudioContext.h:

LayoutTests:

As per specification, we schedule a task to dispatch the statechange event after resolving
the promise (e.g. the resume promise). In some cases, this test moves from one subtest to
another after the promise gets resolved. When the promise gets resolved, there is still
a pending statechange event that has not been fired yet. Because the next subtest may rely
on a statechange event, I delayed the next subtest using a 0-timer to make sure any pending
statechange event has been fired before we move on to the next subtest.

• webaudio/audiocontext-state-interrupted.html:

10:31 AM Changeset in webkit [266834] by graouts@webkit.org

• 4 edits
  2 adds in trunk

REGRESSION (r260360): Ionic modal dialog doesn't animate correctly when dragged and released
​https://bugs.webkit.org/show_bug.cgi?id=216308
<rdar://problem/68567444>

Reviewed by Simon Fraser.

Source/WebCore:

We fixed seeking for animations with a reversed playback rate in r261637, the fix for bug 204717,
but only looked at the animation's playback rate. However, an animation can also play in reverse
using the "direction" property of the timing object passed to updateTiming(), so we should also
check that it's playing forwards in order to be seeked.

Test: webanimations/accelerated-animation-easing-and-direction-update.html

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::animationCanBeAccelerated const):

LayoutTests:

Add a new test that updates the "easing" and "direction" timing properties of a playing animation
and checks that it matches the display of another animation with similar timing properties from
the start.

• platform/win/TestExpectations:
• webanimations/accelerated-animation-easing-and-direction-update-expected.html: Added.
• webanimations/accelerated-animation-easing-and-direction-update.html: Added.

10:28 AM Changeset in webkit [266833] by Adrian Perez de Castro

• 8 edits in trunk

[CMake] Use imported targets in find module for libseccomp
​https://bugs.webkit.org/show_bug.cgi?id=216329

Reviewed by Don Olmstead.

.:

• Source/cmake/BubblewrapSandboxChecks.cmake: Use Libseccomp_FOUND.
• Source/cmake/FindLibseccomp.cmake: Rewrite to define the

Libseccomp::Libseccomp target, fall-back to read version from the main
header, and define variables with Libseccomp_ as prefix.

Source/WebCore:

No new tests needed.

• PlatformGTK.cmake: Take the Libseccomp::Libseccomp imported target into use.

Source/WebKit:

• PlatformGTK.cmake: Remove unneeded usage of LIBSECCOMP_INCLUDE_DIRS.
• PlatformWPE.cmake: Take the Libseccomp::Libseccomp imported target into use.

10:25 AM Changeset in webkit [266832] by youenn@apple.com

• 6 edits
  1 copy
  4 adds in trunk

Run captureCanvas-webrtc-software-encoder.html tests on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=216352

Reviewed by Eric Carlson.

Source/WebCore:

Remove no longer needed internals API.

Tests: webrtc/captureCanvas-webrtc-software-encoder.html

webrtc/captureCanvas-webrtc-software-h264-baseline.html
webrtc/captureCanvas-webrtc-software-h264-high.html

• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:

Update to not use removed internals API.
We keep this test as its history is still useful. We will remove it later on.

• webrtc/captureCanvas-webrtc-software-h264-baseline-expected.txt: Added.
• webrtc/captureCanvas-webrtc-software-h264-baseline.html: Added.
• webrtc/captureCanvas-webrtc-software-h264-high-expected.txt: Added.
• webrtc/captureCanvas-webrtc-software-h264-high.html: Added.
• webrtc/captureCanvas-webrtc-software-h264.js: Copied from LayoutTests/platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html.

10:16 AM Changeset in webkit [266831] by Truitt Savell

• 2 edits in trunk/LayoutTests

Skip 5 imported/ tests after the changes in r266817
​https://bugs.webkit.org/show_bug.cgi?id=186045

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:32 AM Changeset in webkit [266830] by Aditya Keerthi

• 14 edits
  11 adds in trunk

[macOS] Add editability to input type=datetime-local
​https://bugs.webkit.org/show_bug.cgi?id=216311

Reviewed by Devin Rousso.

Source/WebCore:

This patch adds editability to input type=datetime-local by leveraging
existing logic to add editable components to date/time inputs.

Tests: fast/forms/datetimelocal/datetimelocal-editable-components/*

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

Add shouldHaveSecondField and shouldHaveMillisecondField methods so
that the logic can be shared by TimeInputType and DateTimeLocalInputType.

(WebCore::BaseChooserOnlyDateAndTimeInputType::shouldHaveSecondField const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::shouldHaveMillisecondField const):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/DateTimeFieldsState.h:

Add method to compute the 23-hour value to avoid duplication in TimeInputType
and DateTimeLocalInputType.

(WebCore::DateTimeFieldsState::hour23 const):

• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isValidFormat const):
(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState const):
(WebCore::DateTimeLocalInputType::setupLayoutParameters const):

• html/TimeInputType.cpp:

(WebCore::TimeInputType::formatDateTimeFieldsState const):
(WebCore::TimeInputType::setupLayoutParameters const):

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::dateTimeLocalInputStyleSheet const):

Increase width to reflect the fact that this input contains more fields
than the other date/time inputs.

Source/WebKit:

• UIProcess/mac/WebDateTimePickerMac.mm:

(-[WKDateTimePicker initWithParams:inView:]):

Move initialization that relies on DateTimeChooserParameters to
updatePicker: to reduce code duplication.

(-[WKDateTimePicker updatePicker:]):
(-[WKDateTimePicker dateFormatStringForType:value:]):

datetime-local inputs can have three different formats. The default
contains hour and minute fields, but second and millisecond fields
may also be present. Update this method to return the appropriate
format string based on the current value of the input.

(-[WKDateTimePicker initialDateForEmptyValue]):

The initial value displayed on the picker when the input's value is
empty should match the user's system time. Since the date picker
maintains UTC time, return [NSDate date] with an appropriate offset.

LayoutTests:

• TestExpectations:
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-focus-and-blur-events-expected.txt: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-focus-and-blur-events.html: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events-expected.txt: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events.html: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-mouse-events-expected.txt: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-mouse-events.html: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-second-and-millisecond-field-expected.txt: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-second-and-millisecond-field.html: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-picker-update-on-edit-expected.txt: Added.
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-picker-update-on-edit.html: Added.
• platform/mac-wk2/TestExpectations:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:

9:26 AM Changeset in webkit [266829] by Kate Cheney

• 56 edits in trunk

Clean up App-Bound Domains code to only compile for iOS with its own macro
​https://bugs.webkit.org/show_bug.cgi?id=215027
<rdar://problem/63688232>

Reviewed by Darin Adler.

Source/WebCore:

App-Bound Domains code should only be compiled and run on iOS.
This patch wraps any App-Bound Domains code in #if ENABLE(APP_BOUND_DOMAINS),
which is equal to IOS_FAMILY, making sure we don't execute or compile
the code unnecessarily on macOS.

No new tests, behavior should not change so testing is covered by
all existing App-Bound Domains layout and API tests.

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeScriptInWorld):

• loader/FrameLoaderClient.h:
• page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):

• page/Page.cpp:

(WebCore::Page::injectUserStyleSheet):

• page/WebKitNamespace.cpp:

(WebCore::WebKitNamespace::messageHandlers):

• platform/network/NetworkStorageSession.cpp:
• platform/network/NetworkStorageSession.h:
• style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::initializeUserStyle):

Source/WebKit:

App-bound domains code should only be compiled on iOS, so this patch
adds additional '#if ENABLE()' checks to ensure that. Additionally,
for clarity this patch creates a new APP_BOUND_DOMAINS macro and
replaces existing IOS_FAMILY checks for App-Bound Domains code with
this new macro.

LoadParameters, PolicyDecision and WKPreferences will be in another
patch, this one is huge already.

No new tests, behavior should not change so testing is covered by
all existing App-Bound Domains layout and API tests.

• NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
• NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resetParametersToDefaultValues):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::swServerForSession):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkSession.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::filterAppBoundCookies):

• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):

• UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::ignoresAppBoundDomains const):
(API::PageConfiguration::setIgnoresAppBoundDomains):

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreHasAppBoundSession):
(WKWebsiteDataStoreSetAppBoundDomainsForTesting):
(WKWebsiteDataStoreClearAppBoundSession):
(WKWebsiteDataStoreReinitializeAppBoundDomains):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isNavigatingToAppBoundDomain:]): Deleted.
(-[WKWebView _isForcedIntoAppBoundMode:]): Deleted.
Moved to WKWebViewIOS.

• UIProcess/API/Cocoa/WKWebViewConfiguration.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration limitsNavigationsToAppBoundDomains]):
(-[WKWebViewConfiguration setLimitsNavigationsToAppBoundDomains:]):
(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Moved App-Bound Domain functions to the part of the file that only compiles
on iOS and removed macos tags for WK_API_AVAILABLE, because both the
API and SPI are iOS only.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Moved App-Bound Domain functions to the part of the file that only compiles on iOS.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _appBoundDomains:]):
(-[WKWebsiteDataStore _appBoundSchemes:]):

• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _isNavigatingToAppBoundDomain:]):
(-[WKWebView _isForcedIntoAppBoundMode:]):
Moved these from WKWebView.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getAppBoundDomains):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadData):
(WebKit::shouldTreatURLProtocolAsAppBound):
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainAndCheckIfPermitted):
(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):
(WebKit::WebPageProxy::preconnectTo):
Now that m_isNavigatingToAppBoundDomain is iOS only, I changed WebPageProxy::preconnectTo
to call the isNavigatingToAppBoundDomain() function, which is available
on all platforms but returns WTF::nullopt unless the platform is iOS.

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::creationParameters):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isNavigatingToAppBoundDomain const):
isNavigatingToAppBoundDomain() is used very frequently, it is cleaner
to have two functions -- one for iOS which returns the actual value
and one for non-iOS platforms which returns WTF::nullopt -- rather
than have #if ENABLE(APP_BOUND_DOMAIN) checks everywhere.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::appBoundDomainQueue):
(WebKit::WebsiteDataStore::platformInitialize):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::renameOriginInWebsiteData):

• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::preconnectTo):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::sendH2Ping):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebFrame.cpp:
• WebProcess/WebPage/WebFrame.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPage::loadRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::didReceivePolicyDecision):
(WebKit::WebPage::runJavaScript):
(WebKit::WebPage::updatePreferences):
Only check for the m_limitsNavigationsToAppBoundDomains flag if the
platform is iOS. Otherwise it should always be false, because it will
never be enabled on a non-iOS platform.

• WebProcess/WebPage/WebPage.h:

Source/WTF:

Define a new APP_BOUND_DOMAINS preprocessor macro to more aptly gate
App Bound Domains behavior.

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:

Tools:

Replace check for IOS_FAMILY with more aptly named APP_BOUND_DOMAINS
macro.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

LayoutTests:

These tests should be skipped on mac-wk2 because App Bound Domains
is an iOS feature only.

• platform/mac-wk2/TestExpectations:

9:12 AM Changeset in webkit [266828] by Ryan Haddad

• 3 edits in trunk/LayoutTests

ASSERTION FAILED: m_finishedNodes.isEmpty() in AudioContext destructor
​https://bugs.webkit.org/show_bug.cgi?id=105870

Unreviewed test gardening.

Remove test expectations for other tests that were hitting this crash.

• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:

8:57 AM Changeset in webkit [266827] by commit-queue@webkit.org

• 6 edits in trunk

[CG] REGRESSION (Big Sur): A GIF image with a finite loopCount loops an extra cycle
​https://bugs.webkit.org/show_bug.cgi?id=216018
<rdar://problem/68304035>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-09-10
Reviewed by Tim Horton.

Source/WebCore:

Remove the extra 'one' we used to add to the GIF loopCount since it is
now added by the underlying frameworks. But make sure we are compatible
with the older versions of macOS and iOS.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::repetitionCount const):

Source/WTF:

Add a new macro for the new accurate behavior of CGImageSource.

Unrelated change: Fix the conditions for enabling the WebP images.

• wtf/PlatformHave.h:

LayoutTests:

• platform/mac/TestExpectations:

8:28 AM Changeset in webkit [266826] by Jonathan Bedard

• 9 edits in trunk/Tools

[webkitscmpy] Add tags, branches queries on local repositories
​https://bugs.webkit.org/show_bug.cgi?id=216333
<rdar://problem/68603047>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
• Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git):
(Git.branches): List all branches associated with a local repository.
(Git.tags): List all tags associated with a local repository.

• Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm):
(Scm.branches):
(Scm.tags):

• Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn):
(Svn.list):
(Svn.branches): List all branches associated with a local repository.
(Svn.tags): List all branches associated with a local repository.

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:

(Git.init): Add 'git branch -a' and 'git tag', change default branch.

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:

(Svn.init): Add 'svn list ^{/*' commands.}

• Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit.test_branch): Change default branch to main.
(TestGit):
(TestGit.test_branches):
(TestGit.test_tags):

• Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestSvn):
(TestSvn.test_branches):
(TestSvn.test_tags):

8:22 AM Changeset in webkit [266825] by Simon Fraser

• 25 edits
  1 copy
  10 adds in trunk

REGRESSION (Async overflow scroll): Truncated scrollbars in facebook chat
​https://bugs.webkit.org/show_bug.cgi?id=216294
<rdar://problem/61918702>

Reviewed by Antti Koivisto.

Source/WebCore:

When both async overflow scroll and overlay scrollbars are enabled, it's possible for
composited layers that are later in z-order than the overflow to overlap the scrollbars
(overflow does not create stacking context, so they are later siblings to the overflow).

To fix this we have to hoist the layer that hosts the overflow controls above all later layers
which belong to contents scrolled by this overflow. We know which layers these are; they have
ancestor clippings stacks that reference the overflow layer.

This overflow controls layer hoisting happens in the context of the enclosing composited layer.

So to fix this RenderLayerCompositor::updateBackingAndHierarchy() tracks these layers that belong to
an overflow scroll. RenderLayerCompositor::adjustOverflowScrollbarContainerLayers() uses them to find
the overflow scroll layers whose controls need hoisting, and where to insert those overflow controls
hosting layers in the sublayers list of the enclosing composited layer.

An additional source of complexity occurs with overflow scroll nested inside another scroller or
overflow:hidden (in the same composited stacking context): the overflow controls reparenting is hoisting
that layer up, so that layer itself needs additional layers to clip it (essentially the overflow control
layer behaves like a later sibling that needs its own ancestor clipping stack). When this occurs,
RenderLayerBacking creates an additional "ancestor clipping stack" in m_overflowControlsHostLayerAncestorClippingStack
which is a parallel stack to m_ancestorClippingStack, but with its own set of clipping layers. At some point
this will also need scrolling tree nodes created for it. Some minor refactoring helps share code for
the two LayerAncestorClippingStacks.

This new code all runs late in the compositing update for a given layer, which is not ideal; we replicate
some code from updateGeometry() and updateInternalHierarchy(). Ideally we'd be able to know at
computeCompositingRequirements() time if we need to do layer hoisting and ancestor clipping stack duplication,
but that proves hard because of ordering dependencies.

Tests: compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic.html

compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden.html
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested.html
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar.html
compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position.html

• rendering/LayerAncestorClippingStack.cpp:

(WebCore::LayerAncestorClippingStack::compositedClipData const):

• rendering/LayerAncestorClippingStack.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::adjustOverflowControlsPositionRelativeToAncestor):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateAncestorClippingStack):
(WebCore::RenderLayerBacking::ensureOverflowControlsHostLayerAncestorClippingStack):
(WebCore::RenderLayerBacking::ensureClippingStackLayers):
(WebCore::RenderLayerBacking::removeClippingStackLayers):
(WebCore::RenderLayerBacking::connectClippingStackLayers):
(WebCore::RenderLayerBacking::updateClippingStackLayerGeometry):
(WebCore::RenderLayerBacking::updateAncestorClipping):
(WebCore::RenderLayerBacking::offsetRelativeToRendererOriginForDescendantLayers const):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::UpdateBackingTraversalState::UpdateBackingTraversalState):
(WebCore::RenderLayerCompositor::UpdateBackingTraversalState::stateForDescendants const):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::adjustOverflowScrollbarContainerLayers):
(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingProxyRole):

• rendering/RenderLayerCompositor.h:

LayoutTests:

Some new tests, and new baselines for tests that have different layer trees now.

• compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
• compositing/layer-creation/clipping-scope/overlap-constrained-inside-scroller-expected.txt:
• compositing/layer-creation/clipping-scope/scroller-with-negative-z-children-expected.txt:
• compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
• compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt:
• compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-clipped-by-scroll-expected.txt:
• compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-expected.txt:
• compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-nested-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-for-negative-z-in-scroller-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-hidden-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-visible-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-gain-clipping-layer-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-in-clipped-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-lose-clipping-layer-expected.txt:
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic-expected.txt: Added.
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic.html: Added.
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-expected.txt: Added.
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden-expected.txt: Added.
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden.html: Added.
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested-expected.txt: Added.
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested.html: Added.
• compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar.html: Added.
• compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position-expected.txt: Added.
• compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position.html: Added.
• compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller-expected.txt:
• compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:

7:39 AM Changeset in webkit [266824] by Aditya Keerthi

• 2 edits in trunk/Source/WebCore

Small cleanup in DateTimeFieldElements
​https://bugs.webkit.org/show_bug.cgi?id=216339

Reviewed by Darin Adler.

Address some post-review comments after r266779.

• html/shadow/DateTimeFieldElements.h:

Removed virtual from overridden methods, reordered declarations for
consistency, and added final keyword to all overridden methods.

7:38 AM Changeset in webkit [266823] by Diego Pino Garcia

• 2 edits in trunk/Tools

[GTK] Unreviewed test gardening. Add tests timing out after r266815.

Also update test expectations to remove test passing after r266721.

• TestWebKitAPI/glib/TestExpectations.json:

7:00 AM Changeset in webkit [266822] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baseline after r266803.

• platform/gtk/fast/repaint/focus-ring-repaint-expected.txt: Updated after r266803.

6:46 AM Changeset in webkit [266821] by Diego Pino Garcia

• 3 edits
  2 adds in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update test expectations and baselines after r266812.

• platform/glib/TestExpectations:
• platform/glib/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt: Added after r266784.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt: Update after r266746.

5:44 AM Changeset in webkit [266820] by eocanha@igalia.com

• 2 edits in trunk/Source/WebCore

[MSE][GStreamer] Support Google Dynamic Ad Insertion (DAI)
​https://bugs.webkit.org/show_bug.cgi?id=216039

Reviewed by Philippe Normand.

What happens on the DAI transitions between regular and advertisement videos
(and back) on MP4 is that each track has a different stream id, so qtdemux
doesn't reuse streams and created a new pad/stream/track for the new piece
of video. Our current code only supports a single simultaneous track per
SourceBuffer, so it "disables" the second (new) one by attaching a blackk hole
probe which drops all the buffers. Right after the new pad is created, the old
pad/stream/track is removed, so in the end only a single "disabled" track
remains.

This patch detects that situation and reattaches the single remaining pad to
the existing downstream elements of the AppendPipeline (an optional parser and
the appsink) as long as the old and new caps are compatible. For appsink to
keep working after the EOS caused by the old pad removal, it must be reset by
changing its state to NULL and then to PLAYING again.

For more info and test cases about Google DAI, have a look at:
​https://developers.google.com/interactive-media-ads/docs/sdks/html5/dai
​https://github.com/googleads/googleads-ima-html5-dai

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline): Ignore EOS when there are multiple demuxer src pads.
It likely means that one of the pads is going to be removed (EOS legitimally happens right
before that).
(WebCore::AppendPipeline::disconnectDemuxerSrcPadFromAppsinkFromAnyThread): Reconnect the
remaining demuxer pad when it's the last one remaining after some other has been removed.

5:39 AM Changeset in webkit [266819] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK][WPE] Support NTLM authentication
​https://bugs.webkit.org/show_bug.cgi?id=122952

Reviewed by Adrian Perez de Castro.

Add SoupAuthNTLM feature to the session.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):

5:19 AM Changeset in webkit [266818] by Alan Bujtas

• 24 edits in trunk

[Repaint] RenderElement::setStyle may issue redundant repaint
​https://bugs.webkit.org/show_bug.cgi?id=216324
<rdar://problem/68595896>

Reviewed by Simon Fraser.

Source/WebCore:

If we issue a repaint in ::styleWillChange, we should not need to re-issue it again in RenderElement::setStyle (see r266803 for details).

• rendering/RenderElement.cpp:

(WebCore::RenderElement::repaintBeforeStyleChange):
(WebCore::RenderElement::setStyle):

• rendering/RenderElement.h:

LayoutTests:

• compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
• compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
• fast/css-custom-paint/delay-repaint-expected.txt:
• fast/images/async-image-multiple-clients-repaint-expected.txt:
• fast/repaint/horizontal-bt-overflow-child-expected.txt:
• fast/repaint/horizontal-bt-overflow-parent-expected.txt:
• fast/repaint/horizontal-bt-overflow-same-expected.txt:
• fast/repaint/mutate-non-visible-expected.txt:
• fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
• fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
• fast/repaint/spanner-with-margin-expected.txt:
• fast/repaint/table-row-repaint-expected.txt:
• fast/repaint/vertical-overflow-child-expected.txt:
• fast/repaint/vertical-overflow-parent-expected.txt:
• fast/repaint/vertical-overflow-same-expected.txt:
• svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

4:29 AM Changeset in webkit [266817] by Darin Adler

• 16 edits in trunk

webkit-test-runner: Add support for the reftest-wait class name
​https://bugs.webkit.org/show_bug.cgi?id=186045

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt:

Expect correct length (after correctly waiting) rather than incorrect length.

Source/WebCore:

• html/LazyLoadImageObserver.cpp:

(WebCore::LazyLoadImageObserver::unobserve): Removed an incorrect assertion that was firing
when running regression tests. The code this calls correctly handles the case this was
asserting about and from examining the ImageLoader call that invokes this it's clear that
the invariant is not guaranteed by that code. The assertion can be re-added if needed later
after fixing how ImageLoader calls this function.

Tools:

Rather than implement this in a JavaScript test running, built this
support into the two test runner tools.

• DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate dumpAfterWaitAttributeIsRemoved:]): Added. Use to keep
polling until the reftest-wait attribute is gone.
(-[FrameLoadDelegate processWork:]): Call dumpAfterWaitAttributeIsRemoved
instead of calling dump directly.
(-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Ditto.

• DumpRenderTree/win/FrameLoadDelegate.cpp:

(dumpAfterWaitAttributeIsRemoved): Added. Use to keep polling until the
reftest-wait attribute is gone.
(FrameLoadDelegate::processWork): Call dumpAfterWaitAttributeIsRemoved
intead of calling dump directly.
(FrameLoadDelegate::locationChangeDone): Ditto.

• TestRunnerShared/Bindings/JSWrappable.h: Added helper functions for

dealing with JavaScript strings, values, properties, and function calls.
Also added a hasRefTestWaitAttribute function. All of these could probably
find a better home, but for now it was nice to not have to add a new source file.

• TestRunnerShared/Bindings/JSWrapper.h:

(WTR::setProperty): Use the new createJSString. A lot of other TestRunner code
could be tightened up by using these functions, but didn't do that for now.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasRefTestWaitAttribute): Added. Calls the other overload of this.
(WTR::dumpAfterWaitAttributeIsRemoved): Added. Use to keep polling until
the reftest-wait attribute is gone.
(WTR::InjectedBundlePage::frameDidChangeLocation): Call
dumpAfterWaitAttributeIsRemoved instead of done.

LayoutTests:

• TestExpectations: Expect a pass on the test that directly tests this feature.

There are multiple other tests that should now be passing. We should find them
by searching for the string "reftest-wait" and updating TestExpectations after
verifying that they are indeed passing. This is easier to do after we have some
history of results on all platforms of which ones pass after this change.
Expect failure on the video-poster-shown-preload-auto.html, which requires Ogg
Vorbis video; the pass before was a false negative because the video never
loaded, which turns into a timeout now that we support reftest-wait.

• mathml/presentation/attributes-accent-accentunder-dynamic-expected.html:
• mathml/presentation/mathvariant-dynamic-expected.html:
• mathml/presentation/mpadded-dynamic-expected.html:
• mathml/presentation/mpadded-style-change-expected.html:

Remove incorrect use of "reftest-wait". These files had the attribute set on
the <html> element, and no code to ever remove it.

1:09 AM Changeset in webkit [266816] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests/imported/w3c

Improve logging for errors from wptserve.
​https://bugs.webkit.org/show_bug.cgi?id=215829

Patch by Sam Sneddon <Sam Sneddon> on 2020-09-10
Reviewed by Jonathan Bedard.

• web-platform-tests/tools/wptserve/wptserve/handlers.py:

(FileHandler.call):
(PythonScriptHandler._set_path_and_load_file):
(AsIsHandler.call):

• web-platform-tests/tools/wptserve/wptserve/response.py:

(Response.set_error):

• imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:

Rebased according new 404 response body.

Sep 9, 2020:

11:55 PM Changeset in webkit [266815] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Web Inspector: InvalidCharacterError: The string contains invalid characters.
​https://bugs.webkit.org/show_bug.cgi?id=216138

Patch by Patrick Angle <Patrick Angle> on 2020-09-09
Reviewed by Brian Burg.

Source/WebInspectorUI:

Fixed to no longer use displayName as the identifier for DOMNodeDetailsSidebarPanel when creating a
DetailsSection, which could end up with illegal characters due to the escaping done by
DOMNode.prototype.displayName.

• UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.get escapedIdSelector): Changed to use _idSelector.
(WI.DOMNode.prototype.get escapedClassSelector): Changed to use _classSelector.
(WI.DOMNode.prototype.get unescapedSelector): Added. Uses unescaped forms of _idSelector and _classSelector.
(WI.DOMNode.prototype._idSelector): Added. Supports optionally not escaping the selector.
(WI.DOMNode.prototype._classSelector): Added. Supports optionally not escaping the selector.

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByTarget): Use separate identifier
and title.

LayoutTests:

Added tests for DOMNode.prototype._idSelector(…), DOMNode.prototype._classSelector(…),
DOMNode.prototype.unescapedSelector and DOMNode.prototype.displayName.

• inspector/dom/selector-escapes-expected.txt: Added.
• inspector/dom/selector-escapes.html: Added.

10:01 PM Changeset in webkit [266814] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, update DerivedSources-output.xcfilelist after r266801

Sort the contents of the xcfilelist, and add missing entries for new wrapper objects.

• DerivedSources-output.xcfilelist:

9:47 PM Changeset in webkit [266813] by sbarati@apple.com

• 6 edits
  1 add in trunk

OutOfBoundsSaneChain operations should use their own heap locations
​https://bugs.webkit.org/show_bug.cgi?id=216328
<rdar://problem/68568039>

Reviewed by Keith Miller.

JSTests:

• stress/out-of-bounds-sane-chain-need-their-own-heap-location.js: Added.

(foo):

Source/JavaScriptCore:

There is code in local CSE that does some basic bounds check elimination
for PutByVal. It does this analysis by seeing if a particular heap location
is already defined, and if so, it eliminates the bounds check for the
PutByVal. This doesn't work for OutOfBoundsSaneChain for the obvious reason
that these GetByVals are not proven to be in bounds. So GetByVal's in the
OutOfBoundsSaneChain mode reusing non OutOfBoundsSaneChain heap locations
can lead to a bug where we mistakenly remove a bounds check. The fix is to
have all OutOfBoundsSaneChain operations use distinct heaps, and for CSE to
not query those heaps.

• dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::isAnySaneChain const): Deleted.

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

• dfg/DFGHeapLocation.h:

8:40 PM Changeset in webkit [266812] by rniwa@webkit.org

• 4 edits in trunk

Simplify OptionSet::set
​https://bugs.webkit.org/show_bug.cgi?id=216335

Reviewed by Said Abou-Hallawa.

Source/WTF:

Simplified the implementation of OptionSet::set since we've verified that both clang and gcc
generate comparable code in x86_64 and clang does the same for arm64.

• wtf/OptionSet.h:

(WTF::OptionSet::set):

Tools:

Added a unit test for OptionSet::set.

• TestWebKitAPI/Tests/WTF/OptionSet.cpp:

(WTF_OptionSet.Set):

8:15 PM Changeset in webkit [266811] by Fujii Hironori

• 2 edits in trunk/Tools

Add Visual Studio debugger custom views for NeverDestroyed, LazyNeverDestroyed, VectorBufferBase, Optional, and StringView
​https://bugs.webkit.org/show_bug.cgi?id=216304

Reviewed by Don Olmstead.

• VisualStudio/WebKit.natvis:

7:51 PM Changeset in webkit [266810] by ddkilzer@apple.com

• 3 edits
  1 add in trunk/Source/ThirdParty/libwebrtc

[WebRTC] Fix uninitialized fields in FilterAnalyzer::ConsistentFilterDetector, FilterAnalyzer::FilterAnalysisState and InterArrival::TimestampGroup
<​https://webkit.org/b/216314>

Reviewed by Youenn Fablet.

• Source/webrtc/modules/audio_processing/aec3/filter_analyzer.h:

(webrtc::FilterAnalyzer::ConsistentFilterDetector):

• Initialize fields in declarations. This matches the values set by webrtc::FilterAnalyzer::ConsistentFilterDetector::Reset().

(webrtc::FilterAnalyzer::FilterAnalysisState):

• Initialize fields in declarations. Note that the FilterAnalysis constructor calls FilterAnalyzer::Reset(), which also sets these fields, but after the FilterAnalysisState construtor is called.
• Source/webrtc/modules/remote_bitrate_estimator/inter_arrival.h:

(webrtc::InterArrival::TimestampGroup::TimestampGroup):

• Initialize field in constructor argument list.
• WebKit/0001-fix-216314.patch: Add.

7:47 PM Changeset in webkit [266809] by dino@apple.com

• 57 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::WebGLRenderingContext::getExtension
​https://bugs.webkit.org/show_bug.cgi?id=216337
<rdar://problem/68421590>

Reviewed by Sam Weinig.

Bug 215599 added IsoHeap storage to WebGLExtension, but didn't add it
to any of the subclasses. This causes a crash in ::getExtension because
allocation of the new instance fails.

Add WTF_MAKE_ISO_ALLOCATED_IMPL to the .cpp files, and
WTF_MAKE_ISO_ALLOCATED to the .h files.

This should have been detected by on-device testing, since a debug
build would have asserted because the size passed into the constructor
was different from the actual size of the class.

• html/canvas/ANGLEInstancedArrays.cpp:
• html/canvas/ANGLEInstancedArrays.h:
• html/canvas/EXTBlendMinMax.cpp:
• html/canvas/EXTBlendMinMax.h:
• html/canvas/EXTColorBufferFloat.cpp:
• html/canvas/EXTColorBufferFloat.h:
• html/canvas/EXTColorBufferHalfFloat.cpp:
• html/canvas/EXTColorBufferHalfFloat.h:
• html/canvas/EXTFragDepth.cpp:
• html/canvas/EXTFragDepth.h:
• html/canvas/EXTShaderTextureLOD.cpp:
• html/canvas/EXTShaderTextureLOD.h:
• html/canvas/EXTTextureFilterAnisotropic.cpp:
• html/canvas/EXTTextureFilterAnisotropic.h:
• html/canvas/EXTsRGB.cpp:
• html/canvas/EXTsRGB.h:
• html/canvas/OESElementIndexUint.cpp:
• html/canvas/OESElementIndexUint.h:
• html/canvas/OESStandardDerivatives.cpp:
• html/canvas/OESStandardDerivatives.h:
• html/canvas/OESTextureFloat.cpp:
• html/canvas/OESTextureFloat.h:
• html/canvas/OESTextureFloatLinear.cpp:
• html/canvas/OESTextureFloatLinear.h:
• html/canvas/OESTextureHalfFloat.cpp:
• html/canvas/OESTextureHalfFloat.h:
• html/canvas/OESTextureHalfFloatLinear.cpp:
• html/canvas/OESTextureHalfFloatLinear.h:
• html/canvas/OESVertexArrayObject.cpp:
• html/canvas/OESVertexArrayObject.h:
• html/canvas/WebGLColorBufferFloat.cpp:
• html/canvas/WebGLColorBufferFloat.h:
• html/canvas/WebGLCompressedTextureASTC.cpp:
• html/canvas/WebGLCompressedTextureASTC.h:
• html/canvas/WebGLCompressedTextureATC.cpp:
• html/canvas/WebGLCompressedTextureATC.h:
• html/canvas/WebGLCompressedTextureETC.cpp:
• html/canvas/WebGLCompressedTextureETC.h:
• html/canvas/WebGLCompressedTextureETC1.cpp:
• html/canvas/WebGLCompressedTextureETC1.h:
• html/canvas/WebGLCompressedTexturePVRTC.cpp:
• html/canvas/WebGLCompressedTexturePVRTC.h:
• html/canvas/WebGLCompressedTextureS3TC.cpp:
• html/canvas/WebGLCompressedTextureS3TC.h:
• html/canvas/WebGLCompressedTextureS3TCsRGB.cpp:
• html/canvas/WebGLCompressedTextureS3TCsRGB.h:
• html/canvas/WebGLDebugRendererInfo.cpp:
• html/canvas/WebGLDebugRendererInfo.h:
• html/canvas/WebGLDebugShaders.cpp:
• html/canvas/WebGLDebugShaders.h:
• html/canvas/WebGLDepthTexture.cpp:
• html/canvas/WebGLDepthTexture.h:
• html/canvas/WebGLDrawBuffers.cpp:
• html/canvas/WebGLDrawBuffers.h:
• html/canvas/WebGLLoseContext.cpp:
• html/canvas/WebGLLoseContext.h:

7:35 PM Changeset in webkit [266808] by Lauro Moura

• 2 edits in trunk/Tools

kill-old-processes: Avoid calling kill command with empty string with GNU xargs
​https://bugs.webkit.org/show_bug.cgi?id=216323

Reviewed by Darin Adler.

• BuildSlaveSupport/kill-old-processes:

(main):

5:30 PM Changeset in webkit [266807] by Hector Lopez

• 3 edits in trunk/LayoutTests

[ macOS iOS ] compositing/clipping/border-radius-async-overflow-stacking.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209619

Unreviewed test gardening

• platform/ios-wk2/TestExpectations: now flaky failing on iOS wk2
• platform/mac/TestExpectations: also flaky on BigSur+

4:46 PM Changeset in webkit [266806] by Alan Coon

• 1 copy in tags/Safari-610.2.5

Tag Safari-610.2.5.

4:04 PM Changeset in webkit [266805] by Andres Gonzalez

• 8 edits in trunk/Source/WebCore

Remove unused enum PostType.
​https://bugs.webkit.org/show_bug.cgi?id=216320

Reviewed by Chris Fleizach.

No functionality change.

• Removed the unused enum PostType, since all AX notifications are now

posted asynchronously.

• PostTarget is now an enum class.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postTextStateChangeNotification):

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

• accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):

• accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):

• editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

3:54 PM Changeset in webkit [266804] by timothy_horton@apple.com

• 16 edits in trunk/Source/WebKit

macCatalyst: Form controls behave strangely (like iPhone) in macOS-idiom apps
​https://bugs.webkit.org/show_bug.cgi?id=216326

Reviewed by Wenson Hsieh.

• Shared/UserInterfaceIdiom.h:
• Shared/UserInterfaceIdiom.mm:

(WebKit::userInterfaceIdiomIsPad):
(WebKit::currentUserInterfaceIdiomIsPadOrMac):
(WebKit::setCurrentUserInterfaceIdiomIsPadOrMac):
(WebKit::currentUserInterfaceIdiomIsPad): Deleted.
(WebKit::setCurrentUserInterfaceIdiomIsPad): Deleted.

• Shared/ios/WebPreferencesDefaultValuesIOS.mm:

(WebKit::defaultTextAutosizingUsesIdempotentMode):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/ios/SmartMagnificationController.mm:

(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFormInputSession setAccessoryViewCustomButtonTitle:]):
(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]):
(-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]):
(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView _updateAccessory]):
(shouldShowKeyboardForElement):
(-[WKContentView _shouldUseLegacySelectPopoverDismissalBehavior]):

• UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(WebKit::WebDataListSuggestionsDropdownIOS::show):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingSupported):

• UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker show:fromRect:]):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
(-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):

• UIProcess/ios/forms/WKFormColorControl.mm:

(-[WKFormColorControl initWithView:]):

• UIProcess/ios/forms/WKFormColorPicker.mm:

(-[WKColorPicker initWithView:inPopover:]):
(-[WKColorPicker drawSelectionIndicatorForColorButton:]):

• UIProcess/ios/forms/WKFormSelectControl.mm:

(-[WKFormSelectControl initWithView:]):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
Rename currentUserInterfaceIdiomIsPad to currentUserInterfaceIdiomIsPadOrMac,
and force it to YES on macCatalyst since internally we use it to distinguish
between iPhone and iPad behavior, and (for our behaviors, at least) macCatalyst
should always follow iPad.

We should clean this up, and make all callers make their
iPhone vs. iPad vs. macOS decisions more explicit.

3:45 PM Changeset in webkit [266803] by Alan Bujtas

• 27 edits in trunk

[Repaint] styleWillChange may call repaint on the same renderer multiple times.
​https://bugs.webkit.org/show_bug.cgi?id=216295
<rdar://problem/68538666>

Reviewed by Simon Fraser.

Source/WebCore:

RenderElement::styleWillChange is a virtual function. This function is called whenever the associated RenderStyle changes.
The subclass implementation (e.g. RenderBox::styleWillChange) calls the parent class to make sure the style change is covered properly.
Now in certain cases,

1. this may trigger multiple calls to repaint() (e.g one in each ::styleWillChange implementation)
2. paint invalidation requires absolute coordinates
3. geometry does not change during styleWillChange

it could end up being redundant/unnecessarily expensive.

This patch moves all the style-will-change-requires-repaint logic to one single function so that we can limit the number of repaints.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::issueRepaintBeforeStyleChange):
(WebCore::RenderElement::initializeStyle):
(WebCore::RenderElement::setStyle):
(WebCore::RenderElement::styleWillChange):

• rendering/RenderElement.h:
• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

• compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
• compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
• fast/css-custom-paint/delay-repaint-expected.txt:
• fast/images/async-image-multiple-clients-repaint-expected.txt:
• fast/repaint/focus-ring-repaint-expected.txt:
• fast/repaint/horizontal-bt-overflow-child-expected.txt:
• fast/repaint/horizontal-bt-overflow-parent-expected.txt:
• fast/repaint/horizontal-bt-overflow-same-expected.txt:
• fast/repaint/mutate-non-visible-expected.txt:
• fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
• fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
• fast/repaint/table-row-repaint-expected.txt:
• fast/repaint/vertical-overflow-child-expected.txt:
• fast/repaint/vertical-overflow-parent-expected.txt:
• fast/repaint/vertical-overflow-same-expected.txt:
• svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

3:32 PM WebKitGTK/2.30.x edited by Adrian Perez de Castro

(diff)

3:19 PM Changeset in webkit [266802] by Wenson Hsieh

• 8 edits in trunk/Source

Text copied and pasted from Mac Catalyst apps appears larger than expected
​https://bugs.webkit.org/show_bug.cgi?id=215971
<rdar://problem/65768907>

Reviewed by Tim Horton.

Source/WebKit:

Various pieces of platform logic in Mac Catalyst depend on the user interface idiom (i.e. Mac or iPad) of the
app, as well as the application-wide "scale factor". In the context of this bug, NSAttributedString to RTF data
conversion methods in UIFoundation consult the scale factor of UIiOSMacIdiomManager to determine whether to
emit 0 (standard) or 1 (iOS) for the \cocoatextscaling attribute. The fact that the web process' scale factor
may be out of sync with the UI process' scale factor leads to copied RTF data in the web process appearing
either larger or smaller than expected, due to an incorrect NSTextScalingType value.

To mitigate this (as well as any other issues), we add a mechanism for the UI process to forward the global
scale factor and user interface idiom to the web process inside of the web process creation parameters, and then
use new UIKit SPI to override the scale factor and idiom within the web process.

• Scripts/process-entitlements.sh:

Add a new entitlement needed to use _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

Use _UIApplicationCatalystUserInterfaceIdiom and _UIApplicationCatalystScaleFactor to grab the global user
interface idiom and scale factor, respectively.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Override the idiom and scale factor in the web process with the idiom and scale factor from the UI process,
using the new SPI _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor. As this function hasn't landed
yet, we soft link the function for now to avoid causing the web process to instantly crash on any builds without
the fix for <rdar://problem/68524148>.

Source/WTF:

Add a new flag to guard the presence of _UIApplicationCatalystUserInterfaceIdiom,
_UIApplicationCatalystScaleFactor, and _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.

• wtf/PlatformHave.h:

3:13 PM Changeset in webkit [266801] by weinig@apple.com

• 14 edits
  3 adds in trunk

[WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
​https://bugs.webkit.org/show_bug.cgi?id=216316

Reviewed by Darin Adler.

Source/WebCore:

Split GlobalEventHandlersCSSAnimations.idl, GlobalEventHandlersCSSTransitions.idl and
GlobalEventHandlersPointerEvents.idl out of GlobalEventHandlers.idl to match how they
are specified more closely.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• animation/GlobalEventHandlersCSSAnimations.idl: Added.
• animation/GlobalEventHandlersCSSTransitions.idl: Added.
• dom/GlobalEventHandlers.idl:
• dom/GlobalEventHandlersPointerEvents.idl: Added.

LayoutTests:

• js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

Update for slight enumeration ordering change.

3:11 PM Changeset in webkit [266800] by weinig@apple.com

• 47 edits in trunk/Source/WebCore

[WebIDL] Stop automatically applying the ImplementedBy extended attribute to all partial interfaces/dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=216322

Reviewed by Darin Adler.

When partial interfaces were originally introduced, there were grand ambitions to modularize
and isolate parts of interfaces completely, mostly using the Supplemental<> pattern. As time
has passed, more and more specs have usedd partial just to group things together, and having
it implicitly mean using a class named after the IDL file with some static functions is not
always the right choice. With this change, partial interfaces that want the supplemental style
behavior must opt in, using the extended attribute "ImplementedBy", which is what the code
generators already called this concept internally.

• bindings/scripts/CodeGenerator.pm:

(ProcessInterfaceSupplementalDependencies):
(ProcessDictionarySupplementalDependencies):

• bindings/scripts/CodeGeneratorJS.pm:

(GetFullyQualifiedImplementationCallName):
(AddAdditionalArgumentsForImplementationCall):

• bindings/scripts/IDLAttributes.json:

Remove special casing of partial interfaces / dictionaries automatically getting "ImplementedBy"
applied to all members. Maintain the behavior that "ImplementedBy" is silently ignored when
an attribute has been marked as "Reflect".

• Modules/async-clipboard/NavigatorClipboard.idl:
• Modules/beacon/NavigatorBeacon.idl:
• Modules/cache/DOMWindowCaches.idl:
• Modules/cache/WorkerGlobalScopeCaches.idl:
• Modules/credentialmanagement/NavigatorCredentials.idl:
• Modules/encryptedmedia/NavigatorEME.idl:
• Modules/entriesapi/HTMLInputElementEntriesAPI.idl:
• Modules/fetch/DOMWindowFetch.idl:
• Modules/fetch/WorkerGlobalScopeFetch.idl:
• Modules/gamepad/NavigatorGamepad.idl:
• Modules/geolocation/NavigatorGeolocation.idl:
• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl:
• Modules/mediacapabilities/NavigatorMediaCapabilities.idl:
• Modules/mediasession/HTMLMediaElementMediaSession.idl:
• Modules/mediasource/AudioTrackMediaSource.idl:
• Modules/mediasource/DOMURLMediaSource.idl:
• Modules/mediasource/TextTrackMediaSource.idl:
• Modules/mediasource/VideoTrackMediaSource.idl:
• Modules/mediastream/NavigatorMediaDevices.idl:
• Modules/pictureinpicture/DocumentPictureInPicture.idl:
• Modules/pictureinpicture/HTMLVideoElementPictureInPicture.idl:
• Modules/quota/DOMWindowQuota.idl:
• Modules/quota/NavigatorStorageQuota.idl:
• Modules/quota/WorkerNavigatorStorageQuota.idl:
• Modules/remoteplayback/HTMLMediaElementRemotePlayback.idl:
• Modules/speech/DOMWindowSpeechSynthesis.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdriver/NavigatorWebDriver.idl:
• Modules/webgpu/NavigatorGPU.idl:
• Modules/webgpu/WebGPUDeviceErrorScopes.idl:
• Modules/webgpu/WebGPUDeviceEventHandler.idl:
• Modules/webgpu/WorkerNavigatorGPU.idl:
• Modules/webxr/NavigatorWebXR.idl:
• css/DOMCSSPaintWorklet.idl:
• css/DOMCSSRegisterCustomProperty.idl:
• dom/DocumentFullscreen.idl:
• dom/DocumentStorageAccess.idl:
• dom/DocumentTouch.idl:
• page/NavigatorIsLoggedIn.idl:
• svg/SVGDocument.idl:

Update existing partials to opt into "ImplementedBy" bevahior. A future pass
will go through these and see which ones can be simplified by removing the
indirection without introducing unnecessary modularization changes.

2:30 PM Changeset in webkit [266799] by aakash_jain@apple.com

• 3 edits in trunk/Tools

ews might mark build as successful if tests fail to run
​https://bugs.webkit.org/show_bug.cgi?id=215944

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeLayoutTestsResults.retry_build):
(AnalyzeLayoutTestsResults.start):

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestAnalyzeLayoutTestsResults.test_test_fail_to_runs):

12:56 PM Changeset in webkit [266798] by beidson@apple.com

• 6 edits in trunk

Make sure WKWebsiteDataStore operations reuse existing process pools even when all WKWebViews have closed.
<rdar://problem/62978295> and ​https://bugs.webkit.org/show_bug.cgi?id=216317

Reviewed by Geoffrey Garen.

Source/WebKit:

Covered by new API test.

When WebsiteDataStores are gathering all the NetworkProcesses they might need to message, they miss some
obvious candidates if there are no longer any related WKWebViews.

Fix that by tracking which sessions a NetworkProcess knows about.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::addSession):
(WebKit::NetworkProcessProxy::hasSession const):
(WebKit::NetworkProcessProxy::removeSession):

• UIProcess/Network/NetworkProcessProxy.h:

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::isAssociatedProcessPool const):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

12:47 PM Changeset in webkit [266797] by Chris Dumez

• 5 edits in trunk/Source

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

• platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

• UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::addObserver):
(WebKit::DisplayLink::removeObserver):
(WebKit::DisplayLink::removeObservers):
(WebKit::DisplayLink::displayLinkCallback):
(WebKit::DisplayLink::hasObservers const): Deleted.

• UIProcess/mac/DisplayLink.h:

12:42 PM Changeset in webkit [266796] by commit-queue@webkit.org

• 2 edits in trunk/Tools

run-jsc-stress-test: fix escaping for --gnu-parallel-runner
​https://bugs.webkit.org/show_bug.cgi?id=215887

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-09-09
Reviewed by Keith Miller.

Change the GNU parallel invocation to use double quotes, to be consistent with
the invocation of ssh by the make runner. This should unbreak
--gnu-parallel-runner after the fix in r265204.

• Scripts/run-jsc-stress-tests:

12:41 PM Changeset in webkit [266795] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

BigInt should PACCage its data pointer
​https://bugs.webkit.org/show_bug.cgi?id=216319

Reviewed by Yusuke Suzuki.

• runtime/JSBigInt.h:

11:46 AM Changeset in webkit [266794] by Chris Dumez

• 14 edits in trunk

Stop performing "de-zippering" when applying gain
​https://bugs.webkit.org/show_bug.cgi?id=216288

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:

Source/WebCore:

Stop performing "de-zippering" when applying gain. The latest specification does not indicate we
should perform de-zippering and Blink does not either. This is causing us to fail a WPT test.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::reset):

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::process):
(WebCore::GainNode::reset):

• Modules/webaudio/GainNode.h:
• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::reset):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::process):
(WebCore::WebKitAudioPannerNode::reset):

• Modules/webaudio/WebKitAudioPannerNode.h:
• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyWithGainFrom):

• platform/audio/AudioBus.h:

11:41 AM Changeset in webkit [266793] by Chris Dumez

• 2 edits in trunk/Source/WebCore

ASSERTION FAILED: m_finishedNodes.isEmpty() in AudioContext destructor
​https://bugs.webkit.org/show_bug.cgi?id=105870

Reviewed by Darin Adler.

This assertion indicates that BaseAudioContext::derefFinishedSourceNodes() was not
called before the BaseAudioContext destructor. Normally, derefFinishedSourceNodes()
gets called from BaseAudioContext::handlePostRenderTasks() at the end of rending.
However, BaseAudioContext::handlePostRenderTasks() only calls derefFinishedSourceNodes()
if tryLock() succeeds. Therefore, in case of lock contention, it was possible we would
end up destroying the BaseAudioContext without derefFinishedSourceNodes() having been
called at the end of the rendering.

To address the issue, we now call derefFinishedSourceNodes() after the audio thread is
gone and before the BaseAudioContext gets destroyed, in BaseAudioContext::uninitialize().

No new tests, covered by existing tests that are flaky crashing.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::uninitialize):

11:23 AM Changeset in webkit [266792] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266756. rdar://problem/68584247

Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/68474062> and ​https://bugs.webkit.org/show_bug.cgi?id=216286

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::createScrollbar): Plugin hasn't been destroyed, and there's still a PluginView, but the PluginView isn't in a frame. So null check that.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:23 AM Changeset in webkit [266791] by Alan Coon

• 6 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266616. rdar://problem/68584190

REGRESSION(macOS Big Sur) ​https://magenta.github.io/lofi-player/ is broken
​https://bugs.webkit.org/show_bug.cgi?id=216163
<rdar://problem/68198173>

Reviewed by Eric Carlson.

Source/WebCore:

Address a crash and a backward-compatibility issue on ​https://magenta.github.io/lofi-player/.

Test: webaudio/webkitofflineaudiocontext-startRendering-crash.html

• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/OscillatorNode.idl: Even after fixing the crash, the game would fail to load because it expected window.OscillatorNode to exist. When we started working on modern Web Audio, we renamed the non-standard oscillator node to WebKitOscillatorNode and added a new standards compliant OscillatorNode behind a runtime flag (off by default). As a result, window.OscillatorNode no longer existed on Big Sur, which is not backward compatible. To address the issue, we now expose window.OscillatorNode even if modern unprefixed WebAudio is not enabled and we merely disable its constructor at runtime. The same policy applies to AudioBufferSourceNode & AudioListener because we did the exact same thing for these interfaces.

• Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::startRendering): Make sure we call lazyInitialize() before we start offline rendering. The context may not be initialized yet if no audio nodes were created for this context. This is similar to what is done in our modern Web Audio code in OfflineAudioContext::startOfflineRendering(), which is why the crash was not reproducible when enabling the Modern Web Audio experimental feature.

LayoutTests:

Add layout test that was reproducing the crash on ​https://magenta.github.io/lofi-player/.

• webaudio/webkitofflineaudiocontext-startRendering-crash-expected.txt: Added.
• webaudio/webkitofflineaudiocontext-startRendering-crash.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:21 AM Changeset in webkit [266790] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.5

11:12 AM Changeset in webkit [266789] by graouts@webkit.org

• 5 edits
  4 adds in trunk

REGRESSION (r264856): updating easing on accelerated animation results in incorrect playback
​https://bugs.webkit.org/show_bug.cgi?id=215853
<rdar://problem/67815853>

Reviewed by Simon Fraser.

Source/WebCore:

Stop accelerated animations if the timing function has changed in a way that makes it so that it should
no longer play accelerated, but otherwise simply update their timing properties such that may keep
playing.

Test: webanimations/accelerated-animation-easing-update-after-pause.html

webanimations/accelerated-animation-easing-update-steps-after-pause.html

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::canBeAccelerated const):
(WebCore::KeyframeEffect::updateAcceleratedActions):
(WebCore::KeyframeEffect::animationDidChangeTimingProperties):

• animation/KeyframeEffect.h:

LayoutTests:

Add new tests that check that updating an animation's easing does not stop it.

• platform/win/TestExpectations:
• webanimations/accelerated-animation-easing-update-after-pause-expected.html: Added.
• webanimations/accelerated-animation-easing-update-after-pause.html: Added.
• webanimations/accelerated-animation-easing-update-steps-after-pause-expected.html: Addded.
• webanimations/accelerated-animation-easing-update-steps-after-pause.html: Addded.

11:00 AM Changeset in webkit [266788] by Chris Dumez

• 8 edits in trunk

AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event
​https://bugs.webkit.org/show_bug.cgi?id=216284

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:

Rebaseline test that is now failing because of the fix. The test was not actually running as intended because
it relies on AudioParam.linearRampToValueAtTime(), which was not working until now. I have investigated this
failure and it is actually due to a bug in our AudioBus::copyWithGainFrom() implementation. I will land a
follow-up fix for this.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:

Rebaseline test now that output is different (still passing).

• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:

Rebaseline test that is passing thanks to the fix.

Source/WebCore:

AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event
in the timeline. This is incorrect. We should insert an implicit SetValue event in the timeline if the ramp event is
the first one.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioParam.cpp:
• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::linearRampToValueAtTime):
(WebCore::AudioParamTimeline::exponentialRampToValueAtTime):

• Modules/webaudio/AudioParamTimeline.h:

10:42 AM Changeset in webkit [266787] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

AccessibilityMenuList and MenuListPopup notifications need to be posted asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=216309
<rdar://problem/68108824>

Reviewed by Chris Fleizach.

MenuList notifications were posted synchronously which triggers a DOM
layout and style update in the middle of an ongoing DOM mutation update.
This is unnecessary and, furthermore, causes crashes since the DOM
layout update cannot be re-entrant. This change makes these
notifications asynchronous.

• accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):

9:52 AM Changeset in webkit [266786] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/css/css-text/line-break/line-break-{strict,normal}-015a.xht are a constant ImageOnlyFailure
​https://bugs.webkit.org/show_bug.cgi?id=216315

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:26 AM Changeset in webkit [266785] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

Skip newly imported test that times out sometimes.
​https://bugs.webkit.org/show_bug.cgi?id=216301

• TestExpectations:

imported/w3c/web-platform-tests/selection/dir-manual.html times out. It says it's a manual test. Maybe it should stay skipped forever.

9:14 AM Changeset in webkit [266784] by achristensen@apple.com

• 3 edits
  92 adds in trunk/LayoutTests

Import selection web platform tests
​https://bugs.webkit.org/show_bug.cgi?id=216301

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/selection: Added.
• web-platform-tests/selection/Document-open-expected.txt: Added.
• web-platform-tests/selection/Document-open.html: Added.
• web-platform-tests/selection/META.yml: Added.
• web-platform-tests/selection/addRange-00-expected.txt: Added.
• web-platform-tests/selection/addRange-00.html: Added.
• web-platform-tests/selection/addRange-04-expected.txt: Added.
• web-platform-tests/selection/addRange-04.html: Added.
• web-platform-tests/selection/addRange-08-expected.txt: Added.
• web-platform-tests/selection/addRange-08.html: Added.
• web-platform-tests/selection/addRange-12-expected.txt: Added.
• web-platform-tests/selection/addRange-12.html: Added.
• web-platform-tests/selection/addRange-16-expected.txt: Added.
• web-platform-tests/selection/addRange-16.html: Added.
• web-platform-tests/selection/addRange-20-expected.txt: Added.
• web-platform-tests/selection/addRange-20.html: Added.
• web-platform-tests/selection/addRange-24-expected.txt: Added.
• web-platform-tests/selection/addRange-24.html: Added.
• web-platform-tests/selection/addRange-28-expected.txt: Added.
• web-platform-tests/selection/addRange-28.html: Added.
• web-platform-tests/selection/addRange-32-expected.txt: Added.
• web-platform-tests/selection/addRange-32.html: Added.
• web-platform-tests/selection/addRange-36-expected.txt: Added.
• web-platform-tests/selection/addRange-36.html: Added.
• web-platform-tests/selection/addRange-40-expected.txt: Added.
• web-platform-tests/selection/addRange-40.html: Added.
• web-platform-tests/selection/addRange-44-expected.txt: Added.
• web-platform-tests/selection/addRange-44.html: Added.
• web-platform-tests/selection/addRange-48-expected.txt: Added.
• web-platform-tests/selection/addRange-48.html: Added.
• web-platform-tests/selection/addRange-52-expected.txt: Added.
• web-platform-tests/selection/addRange-52.html: Added.
• web-platform-tests/selection/addRange-56-expected.txt: Added.
• web-platform-tests/selection/addRange-56.html: Added.
• web-platform-tests/selection/addRange-expected.txt: Added.
• web-platform-tests/selection/addRange.htm: Added.
• web-platform-tests/selection/addRange.js: Added.

(testAddRange):
(testAddRangeSubSet):

• web-platform-tests/selection/addRange.tentative-expected.txt: Added.
• web-platform-tests/selection/addRange.tentative.html: Added.
• web-platform-tests/selection/collapse-00-expected.txt: Added.
• web-platform-tests/selection/collapse-00.html: Added.
• web-platform-tests/selection/collapse-15-expected.txt: Added.
• web-platform-tests/selection/collapse-15.html: Added.
• web-platform-tests/selection/collapse-30.html: Added.
• web-platform-tests/selection/collapse-45-expected.txt: Added.
• web-platform-tests/selection/collapse-45.html: Added.
• web-platform-tests/selection/collapse-expected.txt: Added.
• web-platform-tests/selection/collapse.htm: Added.
• web-platform-tests/selection/collapse.js: Added.

(testCollapse):
(testCollapseSubSet):

• web-platform-tests/selection/collapseToStartEnd-expected.txt: Added.
• web-platform-tests/selection/collapseToStartEnd.html: Added.
• web-platform-tests/selection/common.js: Added.

(setupRangeTests):
(getNodeLength):
(furthestAncestor):
(isAncestorContainer):
(nextNode):
(previousNode):
(nextNodeDescendants):
(ownerDocument):
(isAncestor):
(isDescendant):
(getPosition):
(isContained):
(isPartiallyContained):
(indexOf):
(myExtractContents):
(myInsertNode):
(assertNodesEqual):
(getDomExceptionName):
(rangeFromEndpoints):
(setSelectionForwards):
(setSelectionBackwards):
(assertSelectionNoChange):
(isSelectableNode):

• web-platform-tests/selection/deleteFromDocument-expected.txt: Added.
• web-platform-tests/selection/deleteFromDocument.html: Added.
• web-platform-tests/selection/dir-manual-expected.txt: Added.
• web-platform-tests/selection/dir-manual.html: Added.
• web-platform-tests/selection/extend-00-expected.txt: Added.
• web-platform-tests/selection/extend-00.html: Added.
• web-platform-tests/selection/extend-20-expected.txt: Added.
• web-platform-tests/selection/extend-20.html: Added.
• web-platform-tests/selection/extend-40-expected.txt: Added.
• web-platform-tests/selection/extend-40.html: Added.
• web-platform-tests/selection/extend.js: Added.

(testExtendSubSet):
(testExtend):

• web-platform-tests/selection/getRangeAt-expected.txt: Added.
• web-platform-tests/selection/getRangeAt.html: Added.
• web-platform-tests/selection/getSelection-expected.txt: Added.
• web-platform-tests/selection/getSelection.html: Added.
• web-platform-tests/selection/idlharness.window.js: Added.
• web-platform-tests/selection/isCollapsed-expected.txt: Added.
• web-platform-tests/selection/isCollapsed.html: Added.
• web-platform-tests/selection/removeAllRanges-expected.txt: Added.
• web-platform-tests/selection/removeAllRanges.html: Added.
• web-platform-tests/selection/removeRange-expected.txt: Added.
• web-platform-tests/selection/removeRange.html: Added.
• web-platform-tests/selection/script-and-style-elements-expected.txt: Added.
• web-platform-tests/selection/script-and-style-elements.html: Added.
• web-platform-tests/selection/selectAllChildren-expected.txt: Added.
• web-platform-tests/selection/selectAllChildren.html: Added.
• web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt: Added.
• web-platform-tests/selection/selection-select-all-move-input-crash.html: Added.
• web-platform-tests/selection/setBaseAndExtent-expected.txt: Added.
• web-platform-tests/selection/setBaseAndExtent.html: Added.
• web-platform-tests/selection/stringifier.tentative-expected.txt: Added.
• web-platform-tests/selection/stringifier.tentative.html: Added.
• web-platform-tests/selection/test-iframe-expected.txt: Added.
• web-platform-tests/selection/test-iframe.html: Added.
• web-platform-tests/selection/toString-ff-bug-001-expected.txt: Added.
• web-platform-tests/selection/toString-ff-bug-001.html: Added.
• web-platform-tests/selection/type-expected.txt: Added.
• web-platform-tests/selection/type.html: Added.

LayoutTests:

• TestExpectations:
• platform/ios/imported/w3c/web-platform-tests/selection: Added.
• platform/ios/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt: Added.

9:05 AM Changeset in webkit [266783] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder::rebuildLine should just re-initialize the current line
​https://bugs.webkit.org/show_bug.cgi?id=216260

Reviewed by Antti Koivisto.

Now that LineBuilder manages the Line, it can properly reset it when we need it clean for the "rebuild" case.
This patch also makes "line closing" more explicit by calling collapse trailing content + apply run expansion separately.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::open):
(WebCore::Layout::Line::moveLogicalLeft):
(WebCore::Layout::Line::moveLogicalRight):
(WebCore::Layout::Line::clearContent): Deleted.
(WebCore::Layout::Line::availableWidth const):
(WebCore::Layout::Line::lineLogicalWidth const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):
(WebCore::Layout::LineBuilder::rebuildLine):

• layout/inlineformatting/InlineLineBuilder.h:

9:00 AM Changeset in webkit [266782] by svillar@igalia.com

• 7 edits
  1 add in trunk

[WebXR] Implement XRSession end event
​https://bugs.webkit.org/show_bug.cgi?id=216181

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webxr/xrSession_end.https-expected.txt: Added.

Source/WebCore:

Implemented the end event dispatched by the XRSession whenever the shutdown process is executed.

• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::shutdown): Added end event dispatch.

• Modules/webxr/XRSessionEvent.cpp:

(WebCore::XRSessionEvent::create): New method receiving a XRSession.
(WebCore::XRSessionEvent::XRSessionEvent): New constructor receiving a XRSession.
(WebCore::XRSessionEvent::eventInterface const): New. Overrides the Event method.

• Modules/webxr/XRSessionEvent.h: Ditto.

LayoutTests:

• platform/wpe/TestExpectations: Added a new test that passes now.

8:16 AM Changeset in webkit [266781] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Line should not know about floats
​https://bugs.webkit.org/show_bug.cgi?id=216278

Reviewed by Antti Koivisto.

Floats are not part of the line (they only constrain the horizontal space).

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::setHasIntrusiveFloat): Deleted.
(WebCore::Layout::Line::hasIntrusiveFloat const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::commitFloats):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):

• layout/inlineformatting/InlineLineBuilder.h:

7:55 AM Changeset in webkit [266780] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Line::lineLogicalWidth is really the horizontal constraint value
​https://bugs.webkit.org/show_bug.cgi?id=216277

Reviewed by Antti Koivisto.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::open):
(WebCore::Layout::Line::moveLogicalLeft):
(WebCore::Layout::Line::moveLogicalRight):

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::horizontalConstraint const):
(WebCore::Layout::Line::availableWidth const):
(WebCore::Layout::Line::lineLogicalWidth const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):

7:48 AM Changeset in webkit [266779] by Aditya Keerthi

• 31 edits
  9 adds in trunk

[macOS] Add editability to input type=time
​https://bugs.webkit.org/show_bug.cgi?id=216188

Reviewed by Devin Rousso.

Source/WebCore:

This patch adds editability to input type=time by leveraging existing
logic to add editable components to date/time inputs.

DateTime{Hour|Minute|Second|Millisecond|Meridiem}FieldElements were
created to represent the new editable fields. By default, only the
hour and minute fields are displayed. However, the millisecond
and second fields may be added depending on the initial value of
the element, or the value of the step attribute.

Tests: fast/forms/time/time-editable-components/time-editable-components-focus-and-blur-events.html

fast/forms/time/time-editable-components/time-editable-components-keyboard-events.html
fast/forms/time/time-editable-components/time-editable-components-mouse-events.html
fast/forms/time/time-editable-components/time-editable-components-second-and-millisecond-field.html

• css/html.css:

Update stylesheet to handle hour, minute, second, millisecond and meridiem fields.

(input::-webkit-datetime-edit-fields-wrapper):
(input::-webkit-datetime-edit-year-field,):
(input::-webkit-datetime-edit-year-field:focus,):
(input[disabled]::-webkit-datetime-edit-year-field,):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::DateTimeFormatValidator::visitField):
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseChooserOnlyDateAndTimeInputType::attributeChanged):

The step attribute can determine whether the second and/or millisecond
fields are displayed. Consequently, we should update the fields in
m_dateTimeEditElement when the step attribute is changed.

• html/BaseChooserOnlyDateAndTimeInputType.h:

setupLayoutParameters() now takes an additional DateComponents argument.
This argument is needed to determine whether the second and/or
millisecond field is displayed.

• html/BaseDateAndTimeInputType.h:
• html/DateInputType.cpp:

(WebCore::DateInputType::setupLayoutParameters const):

• html/DateInputType.h:
• html/DateTimeFieldsState.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters const):

• html/DateTimeLocalInputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::setupLayoutParameters const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat const):
(WebCore::TimeInputType::formatDateTimeFieldsState const):
(WebCore::TimeInputType::setupLayoutParameters const):

The millisecond field is displayed if the date has a non-zero value for
milliseconds, or if the step attribute has sub-second precision. The
second field is displayed if the millisecond field is displayed, if the
date has a non-zero value for seconds, or if the step attribute has
sub-minute precision.

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::setupLayoutParameters const):

• html/WeekInputType.h:
• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField): Updated to add new field types to the element.

• html/shadow/DateTimeEditElement.h:
• html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHourFieldElement::setValueAsDate):
(WebCore::DateTimeMeridiemFieldElement::DateTimeMeridiemFieldElement):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMeridiemFieldElement::setValueAsDate):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMillisecondFieldElement::setValueAsDate):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMinuteFieldElement::setValueAsDate):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSecondFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeSecondFieldElement::setValueAsDate):

• html/shadow/DateTimeFieldElements.h:
• html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::maximum const):

• html/shadow/DateTimeNumericFieldElement.h:
• html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent): Implement editing using the same typeahead behavior as <select> elements.
(WebCore::DateTimeSymbolicFieldElement::indexOfSelectedOption const):
(WebCore::DateTimeSymbolicFieldElement::optionCount const):
(WebCore::DateTimeSymbolicFieldElement::optionAtIndex const):

• html/shadow/DateTimeSymbolicFieldElement.h:
• platform/text/PlatformLocale.cpp:

(WebCore::Locale::localizedDecimalSeparator):

Added method to ensure the correct decimal separator is displayed
depending on the user's locale. This separator is used when
the millisecond field is present.

• platform/text/PlatformLocale.h:

LayoutTests:

• TestExpectations:
• fast/forms/time/time-editable-components/time-editable-components-focus-and-blur-events-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-focus-and-blur-events.html: Added.
• fast/forms/time/time-editable-components/time-editable-components-keyboard-events-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-keyboard-events.html: Added.
• fast/forms/time/time-editable-components/time-editable-components-mouse-events-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-mouse-events.html: Added.
• fast/forms/time/time-editable-components/time-editable-components-second-and-millisecond-field-expected.txt: Added.
• fast/forms/time/time-editable-components/time-editable-components-second-and-millisecond-field.html: Added.
• platform/mac-wk2/TestExpectations:
• platform/mac-wk2/fast/forms/time/time-appearance-basic-expected.txt: Rebaselined for new appearance.
• platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt: Rebaselined for new appearance.

6:37 AM Changeset in webkit [266778] by Alexey Shvayka

• 4 edits in trunk

Don't emitDirectBinding() if there is a [...rest] element binding
​https://bugs.webkit.org/show_bug.cgi?id=216228

Reviewed by Darin Adler.

JSTests:

• test262/expectations.yaml: Mark 12 test cases as passing.

Source/JavaScriptCore:

emitDirectBinding() is up for removal due to not respecting overriden or removed
Array.prototype[Symbol.iterator]. However, dropping it slows down popular swap pattern
[a, b] = [b, a] by 40% with DFG/FTL, and by a factor of 6 with baseline JIT only.

Until we figure out the best way to preserve common case performance, this patch
prevents let [...rest] = [1] from ending up as a number instead of an array,
aligning JSC with V8 and SpiderMonkey.

• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::emitDirectBinding):

4:33 AM Changeset in webkit [266777] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Add Philippe Normand to EWS emails unsubscribe list

Unreviewed.

• BuildSlaveSupport/ews-build/emails.json:

2:03 AM Changeset in webkit [266776] by rniwa@webkit.org

• 10 edits in trunk/Source

Node flags should be an OptionSet
​https://bugs.webkit.org/show_bug.cgi?id=216305

Reviewed by Antti Koivisto.

Source/WebCore:

This patch renames NodeFlags to NodeFlag and turns into an enum class and changes the type of
m_nodeFlags from uint32_t to OptionSet<NodeFlag> as there is no state stored there after r266769.

This patch also introduces two new NodeFlag for identifying CharacterData and DocumentFragment
to simplify the type check conditions for these nodes now that we have plenty of free bits.

No new tests since there should be no behavioral change.

• dom/CharacterData.h:

(WebCore::CharacterData::CharacterData): Sets NodeFlag::IsContainerNode via CreateCharacterData.
(WebCore::CharacterData::virtualIsCharacterData): Deleted.

• dom/Comment.cpp:

(WebCore::Comment::Comment): Ditto.

• dom/Element.cpp:

(WebCore::Element::setHasFocusWithin):
(WebCore::Element::removedFromAncestor):
(WebCore::Element::setContainsFullScreenElement):
(WebCore::Element::createElementIdentifier):

• dom/Element.h:

(WebCore::Element::hasFocusWithin const):
(WebCore::Element::hasPendingResources const):
(WebCore::Element::setHasPendingResources):
(WebCore::Element::clearHasPendingResources):
(WebCore::Element::hasCSSAnimation const):
(WebCore::Element::setHasCSSAnimation):
(WebCore::Element::clearHasCSSAnimation):
(WebCore::Element::containsFullScreenElement const):

• dom/Node.cpp:

(WebCore::Node::insertedIntoAncestor):
(WebCore::Node::removedFromAncestor):

• dom/Node.h:

(WebCore::Node::isElementNode const):
(WebCore::Node::isContainerNode const):
(WebCore::Node::isTextNode const):
(WebCore::Node::isHTMLElement const):
(WebCore::Node::isSVGElement const):
(WebCore::Node::isMathMLElement const):
(WebCore::Node::isStyledElement const):
(WebCore::Node::isCharacterDataNode const): Check the newly added NodeFlag::IsContainerNode.
(WebCore::Node::isDocumentNode const):
(WebCore::Node::isTreeScope const):
(WebCore::Node::isDocumentFragment const):: Check the newly added NodeFlag::IsDocumentFragment.
(WebCore::Node::isShadowRoot const):
(WebCore::Node::hasCustomStyleResolveCallbacks const):
(WebCore::Node::hasSyntheticAttrChildNodes const):
(WebCore::Node::setHasSyntheticAttrChildNodes):
(WebCore::Node::selfOrAncestorHasDirAutoAttribute const):
(WebCore::Node::setSelfOrAncestorHasDirAutoAttribute):
(WebCore::Node::isUserActionElement const):
(WebCore::Node::setUserActionElement):
(WebCore::Node::isEditingText const): Removed the check for IsTextFlag since this is no longer needed
after r266769 as no longer share the bit for IsEditingText with an unknown custom element.
(WebCore::Node::isLink const):
(WebCore::Node::setIsLink):
(WebCore::Node::hasEventTargetData const):
(WebCore::Node::setHasEventTargetData):
(WebCore::Node::isConnected const):
(WebCore::Node::isInShadowTree const):
(WebCore::Node::isInTreeScope const):
(WebCore::Node::flagIsText):
(WebCore::Node::flagIsContainer):
(WebCore::Node::flagIsElement):
(WebCore::Node::flagIsShadowRoot):
(WebCore::Node::flagIsHTML):
(WebCore::Node::flagIsLink):
(WebCore::Node::flagHasFocusWithin):
(WebCore::Node::flagIsParsingChildrenFinished):
(WebCore::Node::NodeFlag): Renamed from NodeFlags and made it an enum class, and introduced IsCharacterData
and IsDocumentFragment and removed "Flag" suffix from various flags.
(WebCore::Node::hasNodeFlag const): Renamed from getFlag for clarity.
(WebCore::Node::setNodeFlag const): Ditto from setFlag. Also merge the two versions of setFlag one of which
took a boolean arugment as the first argument by making this a second optional argument.
(WebCore::Node::clearNodeFlag const): Ditto.
(WebCore::Node::isParsingChildrenFinished const):
(WebCore::Node::setIsParsingChildrenFinished):
(WebCore::Node::clearIsParsingChildrenFinished):
(WebCore::Node::ConstructionType): This is now an alias to OptionSet<NodeFlag> instead of a separate enum.
(WebCore::Node::setHasCustomStyleResolveCallbacks):
(WebCore::Node::virtualIsCharacterData const): Deleted.

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::ProcessingInstruction): Sets NodeFlag::IsContainerNode via CharacterData's
constructor's default argument value.

Source/WTF:

• wtf/OptionSet.h:

(WTF::OptionSet::set): Added.