Timeline

Sep 12, 2020:

11:39 PM Changeset in webkit [266989] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Safely handle overly-long CSS variable values
​https://bugs.webkit.org/show_bug.cgi?id=216407

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-09-12
Reviewed by Darin Adler.

Source/WebCore:

Per spec, treat overly long CSS variable values as invalid.

​https://drafts.csswg.org/css-variables/#long-variables

Test: fast/css/variables/invalidate-overly-long-variable-values.html

• css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableReference):
Return false for any variable values greater than maxSubstitutionTokens long.

• css/CSSVariableReferenceValue.h:

Add maxSubstitutionTokens.

LayoutTests:

• fast/css/variables/invalidate-overly-long-variable-values.html: Added.
• fast/css/variables/invalidate-overly-long-variable-values-expected.html: Added.

11:21 PM Changeset in webkit [266988] by Darin Adler

• 18 edits
  4 copies in trunk

Send TestRendered event after running a test but before dumping
​https://bugs.webkit.org/show_bug.cgi?id=216428

Reviewed by Sam Weinig.

Tools:

• DumpRenderTree/CMakeLists.txt: Added the new files and directories.
• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Ditto.

• DumpRenderTree/PlatformWin.cmake: Temporarily disable precompiled headers

on WinCairo since they were not working properly with JSBasics.cpp.

• DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate readyToDumpState]): Added. Calls sendTestRenderedEvent.
(-[FrameLoadDelegate processWork:]): Call readyToDumpState.
(-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Ditto.

• DumpRenderTree/win/FrameLoadDelegate.cpp:

(readyToDumpState): Added. Calls sendTestRenderedEvent.
(FrameLoadDelegate::processWork): Call readyToDumpState.
(FrameLoadDelegate::locationChangeDone): Ditto.

• TestRunnerShared/Bindings/JSBasics.cpp: Added.

(WTR::JSValueMakeBooleanOrNull): Moved from JSWrappable.h.
(WTR::JSValueToNullableBoolean): Ditto.
(WTR::JSValueMakeStringOrNull): Ditto.
(WTR::createJSString): Ditto.
(WTR::makeValue): Ditto.
(WTR::objectProperty): Ditto.
(WTR::setProperty): Added. Sets a named property value to a boolean.
(WTR::call): Moved from JSWrappable.h.
(WTR::callConstructor): Added. Gets a global constructor and calls it.

• TestRunnerShared/Bindings/JSBasics.h: Added. Declares the above functions.

• TestRunnerShared/Bindings/JSWrappable.h:

(WTR::JSValueMakeBooleanOrNull): Deleted.
(WTR::JSValueToNullableBoolean): Deleted.
(WTR::JSValueMakeStringOrNull): Deleted.
(WTR::createJSString): Deleted.
(WTR::makeValue): Deleted.
(WTR::objectProperty): Deleted.
(WTR::call): Deleted.
(WTR::hasRefTestWaitAttribute): Deleted.

• TestRunnerShared/Bindings/JSWrapper.h: Updated includes.

• TestRunnerShared/ReftestFunctions.cpp: Added.

(WTR::sendTestRenderedEvent): Added. Creates and dispatches a TestRendered event.
(WTR::hasReftestWaitAttribute): Moved from JSWrappable.h and renamed to use a
lowercase T since that's how web-platform-tests names things.

• TestRunnerShared/ReftestFunctions.h: Added. Declares the above functions.

• WebKitTestRunner/CMakeLists.txt: Added the new files and directories.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::frameDidChangeLocation): Call sendTestRenderedEvent
before calling dumpAfterWaitAttributeIsRemoved.

• WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added a

missing include of "config.h" to fix build failures I was seeing. An alternative,
since this is a Cocoa-only source file, would be to put config.h into a
precompiled prefix header.

• WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Ditto.

• WebKitTestRunner/PlatformWin.cmake: Temporarily disable precompiled headers

on WinCairo since they were not working properly with JSBasics.cpp.

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added the new

files and directories.

LayoutTests:

• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:

Unskip two tests that no longer time out since we are sending this event.

• platform/win/TestExpectations:

Add a failure expectation for a test that has a couple non-green pixels.

9:55 PM Changeset in webkit [266987] by Darin Adler

• 6 edits in trunk/Source/WebCore

Fix root cause of problem with text replacements at the beginnings of sentences so we can remove the workaround
​https://bugs.webkit.org/show_bug.cgi?id=216450

Reviewed by Tim Horton.

• dom/SimpleRange.cpp:

(WebCore::compareByDocumentOrder): Added so we can use std::min/max.
(WebCore::unionRange): Refactored to use std::min/max.
(WebCore::intersection): Added.

• dom/SimpleRange.h: Added intersection.

• editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAfterTypingToWord): Intersect with the sentence range,
since we don't have a guarantee that moving to the start of a word and end of a word
stays within the sentence since the word and sentence algorithms are not wholly consistent.
In such cases we would like to restrict our checking to the sentence. Another way to fix
this would be to change the behavior of the word and sentence boundary functions.
(WebCore::Editor::markAndReplaceFor): Remove the boolean "true" flags that we used to
trigger our workaround for the above.

• editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::automaticReplacementStart const): Removed the boolean
argument and the workaround code that runs when it's true.
(WebCore::TextCheckingParagraph::automaticReplacementLength const): Ditto.

• editing/TextCheckingHelper.h: Removed the boolean arguments.

6:31 PM Changeset in webkit [266986] by Simon Fraser

• 18 edits in trunk/Source/WebCore

Replace formatForDebugger() which uses raw char* with debugDescription()
​https://bugs.webkit.org/show_bug.cgi?id=216447

Reviewed by Darin Adler.

formatForDebugger() relied on raw char* and buffer lengths. Replace with debugDescription()
which returns a String, and is already a convention used in various classes.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarker:]):
(formatForDebugger):

• dom/Element.cpp:

(WebCore::Element::formatForDebugger const): Deleted.

• dom/Element.h:
• dom/Node.cpp:

(WebCore::Node::debugDescription const):
(WebCore::Node::formatForDebugger const): Deleted.

• dom/Node.h:
• dom/Position.cpp:

(WebCore::Position::debugDescription const):
(WebCore::Position::formatForDebugger const): Deleted.

• dom/Position.h:
• dom/Range.cpp:

(WebCore::Range::debugDescription const):
(WebCore::Range::formatForDebugger const): Deleted.

• dom/Range.h:
• dom/Text.cpp:

(WebCore::Text::formatForDebugger const): Deleted.

• dom/Text.h:
• editing/FrameSelection.cpp:

(WebCore::FrameSelection::debugDescription const):
(WebCore::FrameSelection::formatForDebugger const): Deleted.

• editing/FrameSelection.h:
• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::debugDescription const):
(WebCore::VisiblePosition::formatForDebugger const): Deleted.

• editing/VisiblePosition.h:
• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::debugDescription const):
(WebCore::VisibleSelection::formatForDebugger const): Deleted.

• editing/VisibleSelection.h:

6:30 PM Changeset in webkit [266985] by Simon Fraser

• 5 edits in trunk/Source/WebCore

Use an OptionSet<> for LayoutBox::BaseTypeFlags
​https://bugs.webkit.org/show_bug.cgi?id=216445

Reviewed by Darin Adler.

Use an OptionSet<> for LayoutBox::BaseTypeFlags.

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::Box):

• layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isInitialContainingBlock const):
(WebCore::Layout::Box::isContainerBox const):
(WebCore::Layout::Box::isInlineTextBox const):
(WebCore::Layout::Box::isLineBreakBox const):
(WebCore::Layout::Box::isReplacedBox const):

• layout/layouttree/LayoutContainerBox.cpp:

(WebCore::Layout::ContainerBox::ContainerBox):

• layout/layouttree/LayoutContainerBox.h:

(WebCore::Layout::ContainerBox::ContainerBox):

4:44 PM Changeset in webkit [266984] by Darin Adler

• 8 edits
  2 adds in trunk

REGRESSION (r266817): ASSERTION FAILED: injectedBundle.isTestRunning() on imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html
​https://bugs.webkit.org/show_bug.cgi?id=216440

[GTK] imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=210375

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/resources/svg-target-reftest-frame.html: Added.
• web-platform-tests/service-workers/service-worker/resources/svg-target-reftest-001-frame.html: Added.

Somehow these files were missed in the web-platform-tests import, and they are both used by the
svg-target-reftest.https.html test.

• web-platform-tests/service-workers/service-worker/svg-target-reftest.https-expected.html:

Updated the path in this expected result file. The test importer script should have done this;
not sure why it did not.

Tools:

Did some hardening of the reftest-wait mechanism in WebKitTestRunner.
We can later do the same in DumpRenderTree if the same problem comes up there,
but at this time I don't have a test that reproduces the issue there so not
changing it for now. Don't want to add speculative code without testing it.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasRefTestWaitAttribute): Changed to take a WKBundlePageRef instead of
a InjectedBundlePage&.
(WTR::dumpAfterWaitAttributeIsRemoved): Changed to take a WKBundlePageRef.
Added code to handle cases where an explicit dump occurs while we are waiting
for the attribute to be removed. Identify the page with the WKBundlePageRef,
which can be retained/released.
(WTR::InjectedBundlePage::frameDidChangeLocation): Check page for null
instead of indirectly checking by asking if the pageCount is 0. Also pass
a WKBundlePageRef in to dumpAfterWaitAttributeIsRemoved.

LayoutTests:

• TestExpectations: Skip svg-target-reftest.https.html because it fails in

legacy WebKit and the symptom is a hang waiting for the reftest-wait attribute
to be removed. The failure is not new.

• platform/gtk/TestExpectations: Removed expectation that this same test will

be flaky. The addition of reftest-wait support and the subresource along with
the bug fix to WebKitTestRunner should leave this passing and non-flaky on GTK.
Feel free to add this back if that proves wrong.

• platform/wk2/TestExpectations: Expect a pass for this test. It's working fine

on modern WebKit.

4:11 PM Changeset in webkit [266983] by weinig@apple.com

• 9 edits in trunk/Source/WebCore

[WebIDL] Remove need for [MayThrowException] on named deleters
​https://bugs.webkit.org/show_bug.cgi?id=216429

Reviewed by Darin Adler.

Deduce implementation potentially thowing by introspecting the return
type of the deleters implementation. This allows us to remove another
use of [MayThrowException].

• bindings/js/JSDOMAbstractOperations.h:

(WebCore::performLegacyPlatformObjectDeleteOperation):
Add helper function to house shared implementation of the various
combinations of return types allowed.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateDeletePropertyCommon):
Convert the commented expectation that unnamed deleters return bool
or ExceptionOr<bool> into a static assertion and use the new helper
function to simplify code generation.

• storage/Storage.idl:

Remove now unneeded [MayThrowException].

• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
• bindings/scripts/test/TestNamedDeleterThrowingException.idl:

Update tests/expectations.

4:01 PM Changeset in webkit [266982] by mmaxfield@apple.com

• 13 edits in trunk

[Apple Win] Add a CTFont member to FontPlatformData
​https://bugs.webkit.org/show_bug.cgi?id=216432

Reviewed by Darin Adler.

.:

Include *CoreText.cpp files on the Apple Win port.

• Source/cmake/OptionsAppleWin.cmake:

Source/WebCore:

This is the second step on the path to replacing the Apple Win port's use of CGFont with CTFont.
This patch adds m_ctFont to FontPlatformData, and makes FontPlatformData's constructors create
this object from their existing arguments. It also enables the USE(CORE_TEXT) flag on the Apple
Win port, but manually disables each of the USE(CORE_TEXT) sites on Windows, so there isn't any
behavior change just yet. The new member, m_ctFont, is therefore still unused in this patch. The
next steps will be replacing our current Apple Win font functions with their USE(CORE_TEXT)
counterparts, one-by-one. (Replacing them one-by-one is better than doing them all at once in a
giant mondo-patch.)

No new tests because there is no behavior change yet.

• PlatformAppleWin.cmake:
• platform/graphics/Font.cpp:
• platform/graphics/FontCascade.cpp:
• platform/graphics/FontPlatformData.cpp:
• platform/graphics/FontPlatformData.h: The #defines are temporarily getting worse before they'll

be getting better. When this project is done, there will be fewer #defines, and this file will be
cleaner than it was when I started.
(WebCore::FontPlatformData::cgFont const):
(WebCore::FontPlatformData::ctFont const):

• platform/graphics/coretext/FontCascadeCoreText.cpp:
• platform/graphics/coretext/FontCoreText.cpp:
• platform/graphics/coretext/FontPlatformDataCoreText.cpp:
• platform/graphics/coretext/GlyphPageCoreText.cpp:
• platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hash const):
(WebCore::FontPlatformData::platformIsEqual const):

3:10 PM Changeset in webkit [266981] by mmaxfield@apple.com

• 1 edit
  1 delete in trunk/Source/WebCore

Remove dead code FontCascadeCGWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=216444

Reviewed by Darin Adler.

This file isn't actually referenced by any port's build system.
The Apple Win port uses FontCGWin.cpp instead, which defines the same symbols as this file.

No new tests because there is no behavior change.

• platform/graphics/win/FontCascadeCGWin.cpp: Removed.

3:02 PM Changeset in webkit [266980] by Simon Fraser

• 4 edits in trunk/Source

Convert TextStream::FormattingFlags to an OptionSet<>
​https://bugs.webkit.org/show_bug.cgi?id=216443

Reviewed by Darin Adler.
Source/WebCore:

Use an OptionSet<> for FormattingFlags.

• rendering/RenderTreeAsText.cpp:

(WebCore::externalRepresentation):
(WebCore::counterValueForElement):

Source/WTF:

Use an OptionSet<> for FormattingFlags.

• wtf/text/TextStream.h:

(WTF::TextStream::TextStream):
(WTF::TextStream::formattingFlags const):
(WTF::TextStream::setFormattingFlags):
(WTF::TextStream::hasFormattingFlag const):

12:30 PM Changeset in webkit [266979] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Simplify LineBox offset computation
​https://bugs.webkit.org/show_bug.cgi?id=216434

Reviewed by Antti Koivisto.

This is still inline with the half leading logic where the ascent + descent (LineBox height) and the line spacing are
used to position the inline content.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):

10:07 AM Changeset in webkit [266978] by Alan Bujtas

• 6 edits
  2 adds in trunk

[LFC][IFC] Add support for non-root-inline-box line spacing
​https://bugs.webkit.org/show_bug.cgi?id=216433

Reviewed by Antti Koivisto.

Source/WebCore:

While the LineBox vertically contains all the LineBox::InlineBoxes, its height value does not
include any line spacing (FontMetrics::lineSpacing).
Each LineBox::InlineBox may have a different line spacing value (this value is zero in many cases).
This patch collects line spacing values from the LineBox::InlineBoxes on the line and adjusts the final
line height value accordingly.

Test: fast/layoutformattingcontext/inline-box-with-line-spacing-simple.html

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::constructInlineBoxes):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::lineSpacing const):
(WebCore::Layout::LineBox::InlineBox::setLineSpacing):
(WebCore::Layout::LineBox::inlineBoxList const):

LayoutTests:

• fast/layoutformattingcontext/inline-box-with-line-spacing-simple-expected.html: Added.
• fast/layoutformattingcontext/inline-box-with-line-spacing-simple.html: Added.

3:37 AM Changeset in webkit [266977] by mmaxfield@apple.com

• 4 edits
  4 copies
  1 add
  1 delete in trunk/Source/WebCore

Addressing feedback on r266936
​https://bugs.webkit.org/show_bug.cgi?id=216431

Unreviewed.

I didn't follow the reviewer's advice thoroughly.

No new tests because there is no behavior change.

• PlatformMac.cmake:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/coretext/FontCascadeCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/FontCascadeCoreText.cpp.
• platform/graphics/coretext/FontCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/FontCoreText.cpp.
• platform/graphics/coretext/FontPlatformDataCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/FontPlatformDataCoreText.cpp.
• platform/graphics/coretext/GlyphPageCoreText.cpp: Renamed from Source/WebCore/platform/graphics/ct/GlyphPageCoreText.cpp.

1:35 AM Changeset in webkit [266976] by commit-queue@webkit.org

• 23 edits
  1 copy
  1 add in trunk

Implement lazy iframe loading
​https://bugs.webkit.org/show_bug.cgi?id=215442

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-12
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test result.

• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2.tentative-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url.tentative-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event.tentative-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times.tentative-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub.tentative-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative-expected.txt:

Source/WebCore:

Implement lazy iframe loading as specified [1, 2]. Lazy iframe loading
is controlled by the loading attribute on <iframe>. When the loading attribute is
not specified, the behavior is like before this patch, i.e. loading is eager.

This changes the way iframe attribute processing is handled as specified here [2].

This implementation relies on Intersection Observer and hence works on WK2 only.

[1] ​https://html.spec.whatwg.org/#attr-iframe-loading
[2] ​https://html.spec.whatwg.org/#process-the-iframe-attributes

Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2.tentative.html

imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub.tentative.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::openURL):

• html/HTMLFrameElementBase.h:

(WebCore::HTMLFrameElementBase::frameURL const):
(WebCore::HTMLFrameElementBase::setFrameURL):

• html/HTMLFrameOwnerElement.h:

(WebCore::HTMLFrameOwnerElement::shouldLoadFrameLazily):
(WebCore::HTMLFrameOwnerElement::isLazyLoadObserverActive const):

• html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):
(WebCore::HTMLIFrameElement::referrerPolicy const):
(WebCore::HTMLIFrameElement::loadingForBindings const):
(WebCore::HTMLIFrameElement::setLoadingForBindings):
(WebCore::isFrameLazyLoadable):
(WebCore::HTMLIFrameElement::shouldLoadFrameLazily):
(WebCore::HTMLIFrameElement::isLazyLoadObserverActive const):
(WebCore::HTMLIFrameElement::loadDeferredFrame):
(WebCore::HTMLIFrameElement::lazyLoadFrameObserver):

• html/HTMLIFrameElement.h:
• html/HTMLIFrameElement.idl:
• html/LazyLoadFrameObserver.cpp: Added.

(WebCore::LazyLoadFrameObserver::LazyLoadFrameObserver):
(WebCore::LazyLoadFrameObserver::observe):
(WebCore::LazyLoadFrameObserver::unobserve):
(WebCore::LazyLoadFrameObserver::intersectionObserver):
(WebCore::LazyLoadFrameObserver::isObserved const):

• html/LazyLoadFrameObserver.h: Copied from Source/WebCore/html/canvas/WebGLCompressedTextureETC1.cpp.

(WebCore::LazyLoadFrameObserver::frameURL const):
(WebCore::LazyLoadFrameObserver::referrerPolicy const):

• html/canvas/WebGLCompressedTextureETC1.cpp:
• html/shadow/DateTimeFieldElement.cpp:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::preventsParentFromBeingComplete const):
(WebCore::FrameLoader::allChildrenAreComplete const):

• loader/FrameLoader.h:

LayoutTests:

Unskip iframe-loading-lazy-to-eager.tentative.html and
disable lazy iframe loading tests for WK1.

• TestExpectations:
• platform/mac-wk1/TestExpectations:

12:09 AM Changeset in webkit [266975] by Carlos Garcia Campos

• 4 edits in trunk

[GTK] REGRESSION(r266815): Several GTK API tests are timing out
​https://bugs.webkit.org/show_bug.cgi?id=216361

Reviewed by Adrian Perez de Castro.

Source/WebInspectorUI:

Add missing trailing ';'.

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

Tools:

Unskip tests that are now passing.

• TestWebKitAPI/glib/TestExpectations.json:

12:07 AM Changeset in webkit [266974] by Carlos Garcia Campos

• 4 edits in trunk

[GTK] Timeouts after reftest-wait class enablement in r266817
​https://bugs.webkit.org/show_bug.cgi?id=216397

Reviewed by Adrian Perez de Castro.

Tools:

Tests are timing out because dumpAfterWaitAttributeIsRemoved() is called recursively from a WebCore timer, not
allowing other sources with lower priority like display refresh monitor one to be run. This patch simply adds a
1 millisecond delay between dumpAfterWaitAttributeIsRemoved tries to allow other sources to be run in the main
loop.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpAfterWaitAttributeIsRemoved):

LayoutTests:

Update expectations for tests that are now passing and failing.

• platform/gtk/TestExpectations:

Sep 11, 2020:

10:56 PM Changeset in webkit [266973] by ysuzuki@apple.com

• 20 edits in trunk

[JSC] Canonicalize "true" unicode extension type value to ""
​https://bugs.webkit.org/show_bug.cgi?id=216224

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-collator-co-extension.js:

(explicitTrueBeforeICU67): Deleted.

• stress/intl-collator.js:

(shouldBe.testCollator.Intl.Collator):
(explicitTrueBeforeICU67): Deleted.

• stress/intl-datetimeformat.js:
• stress/intl-locale.js:
• stress/intl-numberformat.js:
• stress/intl-object.js:
• stress/intl-pluralrules.js:
• stress/intl-relativetimeformat.js:
• test262/expectations.yaml:

Source/JavaScriptCore:

Unicode Technical Standard #35 defines that unicode extension type's "true" should be converged to "".
This patch implements it by extracting unicode extension subtags and replacing "true" to "".

• runtime/IntlLocale.cpp:

(JSC::LocaleIDBuilder::toCanonical):
(JSC::IntlLocale::keywordValue const):
(JSC::IntlLocale::calendar):
(JSC::IntlLocale::caseFirst):
(JSC::IntlLocale::collation):
(JSC::IntlLocale::hourCycle):
(JSC::IntlLocale::numberingSystem):
(JSC::IntlLocale::numeric):

• runtime/IntlLocale.h:
• runtime/IntlLocalePrototype.cpp:

(JSC::IntlLocalePrototypeGetterCalendar):
(JSC::IntlLocalePrototypeGetterCaseFirst):
(JSC::IntlLocalePrototypeGetterCollation):
(JSC::IntlLocalePrototypeGetterHourCycle):
(JSC::IntlLocalePrototypeGetterNumberingSystem):

• runtime/IntlObject.cpp:

(JSC::unicodeExtensionSubTags):
(JSC::canonicalizeUnicodeExtensionsAfterICULocaleCanonicalization):
(JSC::languageTagForLocaleID):
(JSC::resolveLocale):

• runtime/IntlObject.h:
• runtime/IntlObjectInlines.h:

(JSC::computeTwoCharacters16Code):

• runtime/StringPrototype.cpp:

(JSC::computeTwoCharacters16Code): Deleted.

Source/WTF:

• wtf/text/StringView.h:

(WTF::StringView::characterAt const):
(WTF::StringView::operator[] const):

10:54 PM Changeset in webkit [266972] by graouts@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION (r255383): Transition from email to password field on login.live.com stutters after going back and forth
​https://bugs.webkit.org/show_bug.cgi?id=216368
<rdar://problem/67019460>

Reviewed by Simon Fraser.

Source/WebCore:

Ensure we repaint before disconnecting from the backing provider layer.

Test: compositing/animation/repaint-after-clearing-shared-backing.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

LayoutTests:

• compositing/animation/repaint-after-clearing-shared-backing-expected.html: Added.
• compositing/animation/repaint-after-clearing-shared-backing.html: Added.

9:00 PM Changeset in webkit [266971] by sihui_liu@apple.com

• 3 edits in trunk/Tools

Assertion Failed: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion
​https://bugs.webkit.org/show_bug.cgi?id=216376

Reviewed by Tim Horton.

After completing each task, we will end UIScript if there is no remaining task. We need to make sure task is
completed asynchronously, otherwise it may finish before other tasks in the same script are scheduled as
script ends early.

• WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::completeTaskAsynchronouslyAfterActivityStateUpdate):
(WTR::UIScriptControllerCocoa::removeViewFromWindow):
(WTR::UIScriptControllerCocoa::addViewToWindow):

8:49 PM Changeset in webkit [266970] by sihui_liu@apple.com

• 3 edits in trunk/LayoutTests

[ macOS wk2 Release ] fast/events/page-visibility-iframe-move-test.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=216424

Reviewed by Tim Horton.

Remove event handler after it's called, or it can be invoked at the wrong time and produce unexpected result.

• fast/events/page-visibility-iframe-move-test-expected.txt:
• fast/events/page-visibility-iframe-move-test.html:

8:28 PM Changeset in webkit [266969] by ysuzuki@apple.com

• 10 edits
  1 add in trunk

[JSC] attribute-change transition should not pin Structure
​https://bugs.webkit.org/show_bug.cgi?id=215528

Patch by Yusuke Suzuki <​yusukesuzuki@slowstart.org> on 2020-09-11
Reviewed by Saam Barati.

JSTests:

• stress/change-attribute-structure-transition.js: Added.

(shouldBe):
(sd.let.data.vm.getStructureTransitionList.let.result.return.result.kind):
(sd):
(shouldBe.JSON.stringify.sd):
(lastStructureID):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):

Source/JavaScriptCore:

This patch avoids using pin in attribute-change transition. To achieve this, attribute-change transition is now fully supported
transition chain in forEachPropertyConcurrently etc.: we can retrieve properties with changed attributes correctly via traversing
transition chain. And we also support attribute-change transition in materializePropertyTable, so we do not need to pin structure.

The design largely mimics existing removePropertyTransition and addPropertyTransition. This patch also adds hasBeenDictionary()
check before adding structure to the transition so that we can avoid adding unnecessary structure entry to the transition table.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutStructure):

• jit/Repatch.cpp:

(JSC::tryCacheDeleteBy):

• runtime/Structure.cpp:

(JSC::Structure::materializePropertyTable):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addNewPropertyTransition):
(JSC::Structure::removePropertyTransitionFromExistingStructureImpl):
(JSC::Structure::removeNewPropertyTransition):
(JSC::Structure::attributeChangeTransitionToExistingStructure):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::nonPropertyTransitionSlow):
(JSC::Structure::attributeChange):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::forEachPropertyConcurrently):
(JSC::Structure::attributeChange):
(JSC::Structure::attributeChangeWithoutTransition):

• tools/JSDollarVM.cpp:

(JSC::JSDollarVMHelper::functionGetStructureTransitionList):

6:46 PM Changeset in webkit [266968] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: [ BigSur wk2 ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
rdar://68743466

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

6:40 PM Changeset in webkit [266967] by Hector Lopez

• 2 edits in trunk/LayoutTests

Rebaseline after r266885
​https://bugs.webkit.org/show_bug.cgi?id=216302

Unreviewed test gardening.

• inspector/timeline/setInstruments-errors-expected.txt:

5:52 PM Changeset in webkit [266966] by Alan Coon

• 6 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266901. rdar://problem/68740506

[Repaint] RenderLayerModelObject::styleWillChange may issue redundant repaint
​https://bugs.webkit.org/show_bug.cgi?id=216374
<rdar://problem/68657490>

Reviewed by Simon Fraser.

Source/WebCore:

Move the repaintIncludingDescendants() calls to repaintBeforeStyleChange() to avoid redundant repaints on the same renderer.

• rendering/RenderElement.cpp: (WebCore::RenderElement::repaintBeforeStyleChange):
• rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

• css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
• platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266965] by Alan Coon

• 26 edits
  1 copy
  3 adds in branches/safari-610.2.5.1-branch

Cherry-pick r266846. rdar://problem/68740516

Don't create event regions when the page has no subscrollers
​https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/mac/event-region-subscroller-frame.html

fast/scrolling/mac/event-region-subscroller-overflow.html

Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.

• page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
• page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
• page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):

Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):

Don't maintain event region if there are no subscrollers and none of the other reasons were hit.

• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):

Invalidate event regions if a subscroller appears.

(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):

• rendering/RenderLayerCompositor.h:

LayoutTests:

Add overflow scrollers to some existing tests so they still generate event regions.

• fast/scrolling/ios/border-radius-event-region-expected.txt:
• fast/scrolling/ios/border-radius-event-region.html:
• fast/scrolling/ios/event-region-float-expected.txt:
• fast/scrolling/ios/event-region-float.html:
• fast/scrolling/ios/event-region-pointer-events-expected.txt:
• fast/scrolling/ios/event-region-pointer-events.html:
• fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-scale-transform-shared.html:
• fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-translate-transform-shared.html:
• fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
• fast/scrolling/ios/event-region-visibility-hidden.html:
• fast/scrolling/mac/border-radius-event-region-expected.txt:
• fast/scrolling/mac/border-radius-event-region.html:
• fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-frame.html: Added.
• fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
• fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
• fast/scrolling/mac/event-region-visibility-hidden.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266964] by Alan Coon

• 24 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266818. rdar://problem/68740533

[Repaint] RenderElement::setStyle may issue redundant repaint
​https://bugs.webkit.org/show_bug.cgi?id=216324
<rdar://problem/68595896>

Reviewed by Simon Fraser.

Source/WebCore:

If we issue a repaint in ::styleWillChange, we should not need to re-issue it again in RenderElement::setStyle (see r266803 for details).

• rendering/RenderElement.cpp: (WebCore::RenderElement::repaintBeforeStyleChange): (WebCore::RenderElement::setStyle):
• rendering/RenderElement.h:

LayoutTests:

• compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
• compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
• fast/css-custom-paint/delay-repaint-expected.txt:
• fast/images/async-image-multiple-clients-repaint-expected.txt:
• fast/repaint/horizontal-bt-overflow-child-expected.txt:
• fast/repaint/horizontal-bt-overflow-parent-expected.txt:
• fast/repaint/horizontal-bt-overflow-same-expected.txt:
• fast/repaint/mutate-non-visible-expected.txt:
• fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
• fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
• fast/repaint/spanner-with-margin-expected.txt:
• fast/repaint/table-row-repaint-expected.txt:
• fast/repaint/vertical-overflow-child-expected.txt:
• fast/repaint/vertical-overflow-parent-expected.txt:
• fast/repaint/vertical-overflow-same-expected.txt:
• svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266963] by Alan Coon

• 10 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266677. rdar://problem/68740526

[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
​https://bugs.webkit.org/show_bug.cgi?id=216190

Reviewed by Darin Adler.

Source/WebCore:

In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContents due to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time via MonotonicTime::now().

We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable on Page. See below for more details, as well as
the WebKit2 ChangeLog.

• page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):

Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.

• page/Page.cpp: (WebCore::Page::updateRendering):

Update m_lastRenderingUpdateTimestamp.

• page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
• rendering/PaintFrequencyTracker.h:

Drive-by cleanup: narrow the PaintFrequency enum to bool width.

(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):

Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.

(WebCore::RenderLayer::simulateFrequentPaint):

• rendering/RenderLayer.h:

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):

In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).

Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions in SinglePaintFrequencyTracking::end(). As such, we
stick with MonotonicTime::now() in WebKit1.

• WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [266962] by Alan Coon

• 8 edits
  4 adds in branches/safari-610.2.5.1-branch

Cherry-pick r266443. rdar://problem/68740539

REGRESSION(r262366): MotionMark1.1 | macOS | Some devices | 1-3% overall regression
​https://bugs.webkit.org/show_bug.cgi?id=215989
<rdar://problem/66845937>

Reviewed by Darin Adler.

Source/WebCore:

The new approach to compositing WebGL caused a slowdown in some
canvas performance tests. They were notifying the Document
of all drawing commands, even on 2d canvases that didn't need
to prepare before compositing.

The solution is to only add the Document as an observer
when necessary. This recovers the performance hit - measured
using the Canvas Lines MotionMark test.

Tests: fast/canvas/webgl/move-canvas-in-document-while-clean.html

fast/canvas/webgl/move-canvas-in-document.html

• dom/Document.cpp: (WebCore::Document::prepareCanvasesForDisplayIfNeeded): Leave a FIXME indicating that we should try to avoid the copyToVector if we can ensure that the prepareForDisplay call will not mutate the HashSet.

• html/CanvasBase.cpp: Remove some copyToVector calls. It should be fine to iterate over the HashSet for these notification functions. (WebCore::CanvasBase::notifyObserversCanvasChanged): (WebCore::CanvasBase::notifyObserversCanvasResized):

• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): Don't add the Document as a canvas observer. Wait until we know it is a context that needs observing. (WebCore::HTMLCanvasElement::createContextWebGL): Now we can add it as an observer. (WebCore::HTMLCanvasElement::didMoveToNewDocument): Swap observation to the new Document. (WebCore::HTMLCanvasElement::insertedIntoAncestor): Ditto, but also be aware that we might be in a "dirty" state, and thus need to immediately tell the new document that the canvas needs preparation. (WebCore::HTMLCanvasElement::removedFromAncestor): Remove the observer. (WebCore::HTMLCanvasElement::needsPreparationForDisplay): Use a virtual function on the context instead of checking the type. (WebCore::HTMLCanvasElement::prepareForDisplay): Ditto.

• html/canvas/CanvasRenderingContext.h: New virtual functions to avoid type checking in HTMLCanvasElement. (WebCore::CanvasRenderingContext::compositingResultsNeedUpdating const): (WebCore::CanvasRenderingContext::needsPreparationForDisplay const): (WebCore::CanvasRenderingContext::prepareForDisplay):

• html/canvas/WebGLRenderingContextBase.cpp: Implementations of the virtual functions that tell HTMLCanvasElement that it needs to prepareForDisplay. (WebCore::WebGLRenderingContextBase::markContextChanged): (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): (WebCore::WebGLRenderingContextBase::didComposite):
• html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

• fast/canvas/webgl/move-canvas-in-document-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean.html: Added.
• fast/canvas/webgl/move-canvas-in-document.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:50 PM Changeset in webkit [266961] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: [ BigSur wk2 ] http/tests/media/video-no-content-length-stall.html is a constant failure
rdar://68740987

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

5:20 PM Changeset in webkit [266960] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Adding myself as committer
​https://bugs.webkit.org/show_bug.cgi?id=216419

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-09-11
Reviewed by Myles C. Maxfield.

Adding myself as a committer.

• Scripts/webkitpy/common/config/contributors.json:

adding committer status to my name.

5:18 PM Changeset in webkit [266959] by Alan Coon

• 1 edit in branches/safari-610.2.5.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp

Cherry-pick a build fix for r266771.

Unreviewed build fix for r266771. An include is missing which causes the build to fail flakily depending on the position of the cpp in the unified source file.

• UIProcess/mac/DisplayLink.cpp:

4:54 PM Changeset in webkit [266958] by Ben Nham

• 1 edit in trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp

Unreviewed build fix for r266771. An include is missing which causes the build to fail flakily depending on the position of the cpp in the unified source file.

• UIProcess/mac/DisplayLink.cpp:

4:46 PM Changeset in webkit [266957] by Russell Epstein

• 9 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266771. rdar://problem/68666453

Regression(r260614) Power usage has increased due to extra thread hopping
​https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>

Reviewed by Simon Fraser.

Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.

• UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
• UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
• WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
• WebProcess/WebPage/EventDispatcher.h:
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:25 PM Changeset in webkit [266956] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Disable gtk-api queue temporarily
​https://bugs.webkit.org/show_bug.cgi?id=216411

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/config.json:
• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

4:19 PM Changeset in webkit [266955] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: [ BigSur < 20A2374 ] fast/images/animated-gif-loop-count.html is a constant image failure
rdar://68736735

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:43 PM Changeset in webkit [266954] by ysuzuki@apple.com

• 6 edits
  2 adds in trunk

Serialization should have exception checks
​https://bugs.webkit.org/show_bug.cgi?id=216399
<rdar://problem/68633776>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: js/dom/serialization-should-have-exception-check.html

IDL CodeGenerator missed appropriate exception checks in serialization code. This patch adds it.
In serialization we cannot throw an error currently. So we should ensure it with assertNoException().

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateSerializerDefinition):

• bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::JSTestSerialization::serialize):

• bindings/scripts/test/JS/JSTestSerializationInherit.cpp:

(WebCore::JSTestSerializationInherit::serialize):

• bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:

(WebCore::JSTestSerializationInheritFinal::serialize):

LayoutTests:

• js/dom/serialization-should-have-exception-check-expected.txt: Added.
• js/dom/serialization-should-have-exception-check.html: Added.

3:24 PM Changeset in webkit [266953] by James Darpinian

• 7 edits
  3 adds in trunk

[WebGL2] Support EXT_color_buffer_half_float on WebGL 2.0 contexts
​https://bugs.webkit.org/show_bug.cgi?id=216010

Reviewed by Kenneth Russell.

Source/ThirdParty/ANGLE:

• src/libANGLE/formatutils.cpp:

(gl::SizedHalfFloatRGTextureAttachmentSupport):
(gl::SizedHalfFloatRGBTextureAttachmentSupport):
(gl::SizedHalfFloatRGBRenderbufferSupport):
(gl::SizedHalfFloatRGBATextureAttachmentSupport):

Source/WebCore:

Added test webgl/2.0.0/conformance2/extensions/ext-color-buffer-half-float.html

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
(WebCore::WebGL2RenderingContext::renderbufferStorageImpl):

LayoutTests:

• webgl/2.0.0/conformance2/extensions/ext-color-buffer-half-float-expected.txt: Added.
• webgl/2.0.0/conformance2/extensions/ext-color-buffer-half-float.html: Added.
• webgl/2.0.0/conformance2/extensions/promoted-extensions-expected.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/extensions/ext-color-buffer-half-float.html: Added.
• webgl/2.0.0/resources/webgl_test_files/conformance2/extensions/promoted-extensions.html:

3:05 PM Changeset in webkit [266952] by Russell Epstein

• 20 edits
  3 adds in branches/safari-610-branch

Cherry-pick r266743. rdar://problem/68652752

iOS: <attachment>'s QuickLook thumbnails can appear squished
​https://bugs.webkit.org/show_bug.cgi?id=216209
<rdar://problem/67817706>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html

• html/HTMLAttachmentElement.idl:
• testing/Internals.cpp: (WebCore::Internals::attachmentThumbnailInfo):
• testing/Internals.h:
• testing/Internals.idl: Expose the attachment thumbnail size via Internals.

• rendering/RenderThemeIOS.mm: (WebCore::RenderAttachmentInfo::RenderAttachmentInfo): Allow the thumbnail aspect ratio to vary, instead of assuming it is always square.

Source/WebKit:

• UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::convertPlatformImageToBitmap): Propagate an image of the same aspect ratio that QuickLook provided, instead of squishing it to square.

• UIProcess/QuickLookThumbnailLoader.mm: (-[WKQLThumbnailLoadOperation start]): Only request full thumbnails; we do not want the icon form, since <attachment> already has one without QuickLook's help; if we can't get a full thumbnail, we'll just leave it alone.

Tools:

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::insertAttachmentForFilePath):
• WebKitTestRunner/TestController.cpp: (WTR::TestController::currentTestURL const):
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: (WTR::UIScriptControllerCocoa::insertAttachmentForFilePath): Make it possible to insert an attachment wrapping a file on disk via UIScriptController.

LayoutTests:

• fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
• fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: Added.
• fast/attachment/resources/400x200-circle.png: Added.
• platform/ios/fast/attachment/attachment-thumbnail-preserves-aspect-ratio-expected.txt: Added.
• resources/ui-helper.js: (window.UIHelper.insertAttachmentForFilePath): Add a test that dumps the thumbnail size for a 400x200 attachment. We only run it on iOS, because on macOS, QuickLook always returns an image of the size we ask for (400x400), padded with whitespace, so the problem does not reproduce and the test doesn't work right there. On iOS, the result used to be 400x400 and now is 400x200.

I tried and failed to make a more useful test (a ref test, actually
testing the presentation) because it's quite hard to match the
native <attachment> painting.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:01 PM Changeset in webkit [266951] by achristensen@apple.com

• 16 edits in trunk

Move _setCookieAcceptPolicy to WKHTTPCookieStore
​https://bugs.webkit.org/show_bug.cgi?id=216375

Reviewed by Geoffrey Garen.

Source/WebCore:

• platform/network/cocoa/HTTPCookieAcceptPolicyCocoa.h:

Source/WebKit:

It is only used by Safari, which I am changing along with this in rdar://problem/68659937
I need it to not be on the process pool for ​https://bugs.webkit.org/show_bug.cgi?id=216041
and because the cookie store's job is to manage cookie storage. The fact that it was on the process pool
is just a historical artifact of us trying to make it global.

WKContextUseTestingNetworkSession has had its important parts replaced by WKWebsiteDataStoreConfigurationSetTestingSessionEnabled
but it was still being used to determinte whether the UI process should persist the cookie accept policy. We don't need this
any more because we send a message to the network process and let it manage the cookie accept policy.

• UIProcess/API/C/WKContext.cpp:

(WKContextUseTestingNetworkSession): Deleted.

• UIProcess/API/C/WKContextPrivate.h:
• UIProcess/API/Cocoa/WKHTTPCookieStore.mm:

(-[WKHTTPCookieStore _setCookieAcceptPolicy:completionHandler:]):

• UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h:
• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setCookieAcceptPolicy:]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::useTestingNetworkSession): Deleted.

• UIProcess/WebProcessPool.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):

2:56 PM Changeset in webkit [266950] by Alan Coon

• 6 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266932. rdar://problem/68732136

Fix undeclared identifier issue due to clashes in soft link headers
​https://bugs.webkit.org/show_bug.cgi?id=216412

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

r266898 broke builds on certain SDKs. The reason for this is that it includes
MediaToolbox/FigPhoto.h, which transitively includes CoreMedia/CMTimePrivate.h. The latter
header has a bunch of inline code in certain SDKs which conflicts with the
CoreMediaSoftLink.h header. For instance, CoreMediaSoftLink.h redefines CMTimeCompare to
softLink_CoreMedia_CMTimeCompare, which messes up the inline code in the CMTimePrivate.h
header that references CMTimeCompare.

For now, we just avoid including FigPhoto.h altogether and use a constant. We'll clean this
up once we start weak linking rather than soft linking CoreMedia and MediaToolbox (216388).

• pal/cocoa/MediaToolboxSoftLink.cpp:
• pal/cocoa/MediaToolboxSoftLink.h:
• pal/spi/cocoa/MediaToolboxSPI.h:

Source/WebKit:

Use the workaround constant kPALFigPhotoContainerFormat_JFIF instead of the enum value
kFigPhotoContainerFormat_JFIF.

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266949] by Alan Coon

• 10 edits
  1 copy in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266898. rdar://problem/68732160

Disable hardware JPEG decoding on x86 Mac
​https://bugs.webkit.org/show_bug.cgi?id=216377

Reviewed by Geoff Garen.

Source/WebCore/PAL:

Add wrappers for a new MediaToolbox SPI that allows us to disable HW JPEG decoding.

• PAL.xcodeproj/project.pbxproj:
• pal/PlatformMac.cmake:
• pal/cocoa/MediaToolboxSoftLink.cpp:
• pal/cocoa/MediaToolboxSoftLink.h:

Source/WebKit:

In Big Sur, ImageIO uses hardware JPEG decoding automatically for certain JPEGs. This caused
a small regression in our battery life benchmark since the one-time setup cost for the
decoder (~20-30 ms per process) was higher than the per-decode win we got from the HW decoder.

For now, we're reverting to the Catalina behavior of not using hardware JPEG on x86 Macs by
calling a MediaToolbox SPI. (The tradeoffs for Apple Silicon are different so we use
ImageIO's default heuristics on that architecture.) We plan to revisit this decision once we
move to a GPUProcess world.

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Add macros to disable HW JPEG decoding on x86 Macs and indicate the presence of a new MediaToolbox SPI.
(The latter is to prevent unnecessary dlopen/dlsym calls since we soft-link MediaToolbox.)

• wtf/PlatformEnableCocoa.h:
• wtf/PlatformHave.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266948] by Alan Coon

• 7 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266844. rdar://problem/68732100

[Cocoa] PERF: Don't instantiate AVPlayer-based audio decoders or renderers if an element is initially muted.
​https://bugs.webkit.org/show_bug.cgi?id=216299

Reviewed by Eric Carlson.

Source/WebCore:

When an AVPlayer is created, even if muted, it will still instantiate an audio decoder and renderer if the
AVAsset in the current player item has an audio track. Ostensibly, this is so that an unmute operation is
instantaneous, as it's merely applying a zero gain to the decoded audio. However for web content, there's
many autoplaying, muted <video> elements which may never be un-muted before being destroyed.

Implement a policy where, if an AVPlayer is initially muted, we adopt AVFoundation SPI to forcibly prevent
audio decoding and rendering until the first time the AVPlayer is unmuted. This means the first un-mute may
not be instantaneous, as an audio decoder will have to be created and fed before any audio is rendered.

There's some incorrect caching of mute state at the MediaPlayer level; so MediaPlayer and MPPAVFoundationObjC
can get their respective m_muted states out of sync. Make sure that HTMLMediaElement always sets muted state
after creating a MediaPlayer and that, respectively, MPPAVFoundationObjC always queries it's parent MediaPlayer's
mute state when it in turn is created.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createMediaPlayer):
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::setMuted):

Source/WebCore/PAL:

• pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

• wtf/PlatformHave.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266947] by Alan Coon

• 27 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266803. rdar://problem/68732086

[Repaint] styleWillChange may call repaint on the same renderer multiple times.
​https://bugs.webkit.org/show_bug.cgi?id=216295
<rdar://problem/68538666>

Reviewed by Simon Fraser.

Source/WebCore:

RenderElement::styleWillChange is a virtual function. This function is called whenever the associated RenderStyle changes.
The subclass implementation (e.g. RenderBox::styleWillChange) calls the parent class to make sure the style change is covered properly.
Now in certain cases,

1. this may trigger multiple calls to repaint() (e.g one in each ::styleWillChange implementation)
2. paint invalidation requires absolute coordinates
3. geometry does not change during styleWillChange it could end up being redundant/unnecessarily expensive.

This patch moves all the style-will-change-requires-repaint logic to one single function so that we can limit the number of repaints.

• rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
• rendering/RenderElement.cpp: (WebCore::RenderElement::issueRepaintBeforeStyleChange): (WebCore::RenderElement::initializeStyle): (WebCore::RenderElement::setStyle): (WebCore::RenderElement::styleWillChange):
• rendering/RenderElement.h:
• rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::styleWillChange):

LayoutTests:

• compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
• compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt:
• fast/css-custom-paint/delay-repaint-expected.txt:
• fast/images/async-image-multiple-clients-repaint-expected.txt:
• fast/repaint/focus-ring-repaint-expected.txt:
• fast/repaint/horizontal-bt-overflow-child-expected.txt:
• fast/repaint/horizontal-bt-overflow-parent-expected.txt:
• fast/repaint/horizontal-bt-overflow-same-expected.txt:
• fast/repaint/mutate-non-visible-expected.txt:
• fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
• fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
• fast/repaint/table-row-repaint-expected.txt:
• fast/repaint/vertical-overflow-child-expected.txt:
• fast/repaint/vertical-overflow-parent-expected.txt:
• fast/repaint/vertical-overflow-same-expected.txt:
• svg/transforms/svg-transform-foreign-object-repaint-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266946] by Alan Coon

• 5 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266797. rdar://problem/68732167

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

• platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
• platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
• UIProcess/mac/DisplayLink.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266945] by Alan Coon

• 9 edits in branches/safari-610.2.5.1-branch/Source/WebKit

Cherry-pick r266771. rdar://problem/68732073

Regression(r260614) Power usage has increased due to extra thread hopping
​https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>

Reviewed by Simon Fraser.

Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.

• UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
• UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
• WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
• WebProcess/WebPage/EventDispatcher.h:
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266944] by Alan Coon

• 6 edits in branches/safari-610.2.5.1-branch/Source/WebCore

Cherry-pick r266717. rdar://problem/68732093

Comparing styles with large but identical custom property maps is slow
​https://bugs.webkit.org/show_bug.cgi?id=216241
<rdar://problem/67946605>

Reviewed by Darin Adler.

In a full style rebuild we lose sharing of equal StyleCustomPropertyDatas between the old and the new style.
Custom properties are usually defined in document element and this lack of sharing inherits to all elements.
Without sharing equality comparisons end up requiring deep comparisons, which can be slow if there are thousands of properties.

Fix by deduplicating identical property maps between the old the new style. All the descendants that inherit the properties will
now be cheap to compare.

The patch also contains some other basic custom property optimizations.

Going to full screen and back on youtube, this patch reduces time in the longest style update from ~460ms to ~90ms.

• css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::equals const):

Check for pointer equality first.

• rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::deduplicateInheritedCustomProperties):

Deduplicate if the properties are equal but not shared.

(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):

Check if the value is already in the map before triggering copy-on-write.

• rendering/style/RenderStyle.h: (WebCore::RenderStyle::setInheritedCustomPropertyValue): Deleted. (WebCore::RenderStyle::setNonInheritedCustomPropertyValue): Deleted.
• style/StyleBuilder.cpp: (WebCore::Style::Builder::applyCustomProperty):

Don't create unnecesary copies of CSSCustomPropertyValue.

• style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Try to deduplicate before comparing the styles.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266943] by Alan Coon

• 6 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266710. rdar://problem/68732167

Unreviewed, reverting r266645.
​https://bugs.webkit.org/show_bug.cgi?id=216251

Caused MotionMark regression

Reverted changeset:

"Move lazy DisplayLink tear down logic from the WebProcess to
the UIProcess"
​https://bugs.webkit.org/show_bug.cgi?id=216195
​https://trac.webkit.org/changeset/266645

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266942] by Alan Coon

• 6 edits in branches/safari-610.2.5.1-branch/Source

Cherry-pick r266645. rdar://problem/68732073

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

• platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
• platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
• UIProcess/mac/DisplayLink.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266941] by Alan Coon

• 8 edits
  2 adds in branches/safari-610.2.5.1-branch

Cherry-pick r266403. rdar://problem/68732151

EventRegion paint should respect layer's foreground and background painting phases
​https://bugs.webkit.org/show_bug.cgi?id=216031
<rdar://problem/67282372>

Reviewed by Simon Fraser.

Source/WebCore:

We are currently painting event region for the box background to the foreground layer, which can cause
foreground layer to wrongly catch scroll events. Similarly we are unnecessarily painting foreground for
layers that don't need it.

Test: fast/scrolling/mac/negative-z-index-overflow-scroll.html

• rendering/PaintPhase.h:

Add two new event region specific PaintBehaviors for foreground and background paint. This essentially duplicates
foreground/background PaintPhases but since event region paint is itself a paint phase we can't use those.
This should be reconciled at some point.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):

Add the background flag when painting contents as the descendant backgrounds are part of the layer foreground.

(WebCore::RenderBlock::paintObject):

Respect the new flags.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):

Setup the flags based on what we are supposed to be painting on this layer.

(WebCore::RenderLayer::collectEventRegionForFragments):

Flag filtering moves to paintLayerContents.

LayoutTests:

• editing/editable-region/text-field-inside-composited-negative-z-index-layer-expected.txt:
• fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt: Added.
• fast/scrolling/mac/negative-z-index-overflow-scroll.html: Added.
• pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer-expected.txt:
• pointerevents/ios/touch-action-region-backing-sharing-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:56 PM Changeset in webkit [266940] by Alan Coon

• 4 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266232. rdar://problem/68732143

Step animations invalidate style on every rendering update whether or not they need to
​https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>

Reviewed by Antoine Quint.

Source/WebCore:

Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):

Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.

LayoutTests:

• animations/steps-transform-rendering-updates-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:47 PM Changeset in webkit [266939] by Russell Epstein

• 20 edits
  3 deletes in branches/safari-610-branch

Revert r266881. rdar://problem/68652752

2:44 PM Changeset in webkit [266938] by Alan Coon

• 8 edits in branches/safari-610.2.5.1-branch/Source

Versioning.

WebKit-7610.2.5.1.1

2:14 PM Changeset in webkit [266937] by zhifei_fang@apple.com

• 2 edits in trunk/Tools

Strip Quotes for run-jsc-stress-tests --model arg
​https://bugs.webkit.org/show_bug.cgi?id=216417

Reviewed by Jonathan Bedard.

• Scripts/run-jsc-stress-tests:

1:27 PM Changeset in webkit [266936] by mmaxfield@apple.com

• 17 edits
  2 copies
  2 moves
  3 adds in trunk/Source

[Cocoa] Migrate CoreText-specific code from *Cocoa.mm to *CoreText.cpp
​https://bugs.webkit.org/show_bug.cgi?id=216400

Reviewed by Tim Horton.

Source/WebCore:

This is in preparation for sharing the CoreText code with the Apple Windows port.

This patch doesn't actually cause Windows to use this code yet. That will happen
in a series of subsequent patches. This patch is just the first stage.

There isn't any actual behavior change here - it's just moving code around between
files.

This patch also adds a new USE() flag: USE(CORE_TEXT). It migrates CoreText-specific
code from #if PLATFORM(COCOA) to #if USE(CORE_TEXT).

No new tests because there is no behavior change.

• PlatformMac.cmake:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/Font.cpp:
• platform/graphics/Font.h:
• platform/graphics/FontCascade.cpp:
• platform/graphics/FontCascade.h:
• platform/graphics/FontPlatformData.cpp:
• platform/graphics/FontPlatformData.h:
• platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::FontCascade::isSubpixelAntialiasingAvailable): Deleted.
(WebCore::fillVectorWithHorizontalGlyphPositions): Deleted.
(WebCore::shouldUseLetterpressEffect): Deleted.
(WebCore::showGlyphsWithAdvances): Deleted.
(WebCore::setCGFontRenderingMode): Deleted.
(WebCore::FontCascade::drawGlyphs): Deleted.
(WebCore::FontCascade::primaryFontIsSystemFont const): Deleted.
(WebCore::FontCascade::fontForCombiningCharacterSequence const): Deleted.

• platform/graphics/cocoa/FontCocoa.cpp: Added.

(WebCore::Font::platformDestroy):

• platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::hash const):
(WebCore::isSystemFont): Deleted.
(): Deleted.
(WebCore::FontPlatformData::FontPlatformData): Deleted.
(WebCore::FontPlatformData::registeredFont const): Deleted.
(WebCore::mapFontWidthVariantToCTFeatureSelector): Deleted.
(WebCore::cascadeToLastResortAttributesDictionary): Deleted.
(WebCore::cascadeToLastResortAndVariationsFontDescriptor): Deleted.
(WebCore::FontPlatformData::ctFont const): Deleted.
(WebCore::FontPlatformData::objectForEqualityCheck): Deleted.
(WebCore::FontPlatformData::objectForEqualityCheck const): Deleted.
(WebCore::FontPlatformData::openTypeTable const): Deleted.
(WebCore::FontPlatformData::description const): Deleted.
(WebCore::FontPlatformData::familyName const): Deleted.

• platform/graphics/cocoa/SourceBufferParserWebM.cpp:
• platform/graphics/ct/FontCascadeCoreText.cpp: Copied from Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm.

(WebCore::FontCascade::isSubpixelAntialiasingAvailable):
(WebCore::fillVectorWithHorizontalGlyphPositions):
(WebCore::shouldUseLetterpressEffect):
(WebCore::showGlyphsWithAdvances):
(WebCore::setCGFontRenderingMode):
(WebCore::FontCascade::drawGlyphs):
(WebCore::FontCascade::primaryFontIsSystemFont const):
(WebCore::FontCascade::fontForCombiningCharacterSequence const):

• platform/graphics/ct/FontCoreText.cpp: Renamed from Source/WebCore/platform/graphics/cocoa/FontCocoa.mm.

(WebCore::Font::platformInit):
(WebCore::Font::platformCharWidthInit):
(WebCore::Font::platformCreateScaledFont const):
(WebCore::Font::applyTransforms const):

• platform/graphics/ct/FontPlatformDataCoreText.cpp: Copied from Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::isSystemFont):
(WebCore::FontPlatformData::registeredFont const):
(WebCore::mapFontWidthVariantToCTFeatureSelector):
(WebCore::cascadeToLastResortAttributesDictionary):
(WebCore::cascadeToLastResortAndVariationsFontDescriptor):
(WebCore::FontPlatformData::ctFont const):
(WebCore::FontPlatformData::objectForEqualityCheck):
(WebCore::FontPlatformData::objectForEqualityCheck const):
(WebCore::FontPlatformData::openTypeTable const):
(WebCore::FontPlatformData::description const):
(WebCore::FontPlatformData::familyName const):

• platform/graphics/ct/GlyphPageCoreText.cpp: Renamed from Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp.
• platform/graphics/win/FontCascadeCGWin.cpp: Added.

(WebCore::FontCascade::setFontSmoothingLevel):
(WebCore::setCGFontSmoothingStyle):
(WebCore::FontCascade::setFontSmoothingStyle):
(WebCore::FontCascade::setFontSmoothingContrast):
(WebCore::clearTypeContrast):
(WebCore::FontCascade::systemFontSmoothingChanged):
(WebCore::FontCascade::setCGContextFontRenderingStyle):
(WebCore::renderingStyleForFont):
(WebCore::FontCascade::getPlatformGlyphAdvances):

Source/WebCore/PAL:

• pal/spi/win/CoreTextSPIWin.h:

Source/WTF:

• wtf/PlatformUse.h:

1:09 PM Changeset in webkit [266935] by Alan Coon

• 1 copy in branches/safari-610.2.5.1-branch

New branch.

12:05 PM Changeset in webkit [266934] by Devin Rousso

• 5 edits in trunk

REGRESSION(r266885): ASSERTION FAILED: Inspector::CSSBackendDispatcher::getInlineStylesForNode(long, RefPtr<JSON::Object> &&) !result.error().isEmpty()
​https://bugs.webkit.org/show_bug.cgi?id=216409
<rdar://problem/68715815>

Reviewed by Brian Burg.

Source/WebCore:

Test: inspector/css/pseudo-element-matches-for-pseudo-element-node.html

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getInlineStylesForNode):

LayoutTests:

• TestExpectations:
• platform/mac-wk2/TestExpectations:

12:04 PM Changeset in webkit [266933] by Alan Coon

• 9 edits in branches/safari-610-branch/Source/WebKit

Revert r266891. rdar://problem/68666453

11:54 AM Changeset in webkit [266932] by Ben Nham

• 6 edits in trunk/Source

Fix undeclared identifier issue due to clashes in soft link headers
​https://bugs.webkit.org/show_bug.cgi?id=216412

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

r266898 broke builds on certain SDKs. The reason for this is that it includes
MediaToolbox/FigPhoto.h, which transitively includes CoreMedia/CMTimePrivate.h. The latter
header has a bunch of inline code in certain SDKs which conflicts with the
CoreMediaSoftLink.h header. For instance, CoreMediaSoftLink.h redefines CMTimeCompare to
softLink_CoreMedia_CMTimeCompare, which messes up the inline code in the CMTimePrivate.h
header that references CMTimeCompare.

For now, we just avoid including FigPhoto.h altogether and use a constant. We'll clean this
up once we start weak linking rather than soft linking CoreMedia and MediaToolbox (216388).

• pal/cocoa/MediaToolboxSoftLink.cpp:
• pal/cocoa/MediaToolboxSoftLink.h:
• pal/spi/cocoa/MediaToolboxSPI.h:

Source/WebKit:

Use the workaround constant kPALFigPhotoContainerFormat_JFIF instead of the enum value
kFigPhotoContainerFormat_JFIF.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

11:53 AM Changeset in webkit [266931] by jer.noble@apple.com

• 6 edits in trunk/Source

[iOS] Add Experimental setting to disable calling PID Inheritance API.
​https://bugs.webkit.org/show_bug.cgi?id=216387
<rdar://problem/66286777>

Reviewed by Eric Carlson.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDisableMediaExperiencePIDInheritance):
(WebCore::RuntimeEnabledFeatures::disableMediaExperiencePIDInheritance const):

• page/Settings.yaml:
• platform/audio/ios/MediaSessionHelperIOS.mm:

(MediaSessionHelperiOS::providePresentingApplicationPID):

Source/WebKit:

• Shared/WebPreferences.yaml:

11:09 AM Changeset in webkit [266930] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

styleDidChange functions should all check for nullptr oldStyle
​https://bugs.webkit.org/show_bug.cgi?id=216410

Reviewed by Simon Fraser.

While some of these calls are protected by the StyleDifference value check (!StyleDifference::NewStyle), an unsafe code refactoring could result in null deref.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::styleDidChange):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::styleDidChange):

• rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):

10:33 AM Changeset in webkit [266929] by Kate Cheney

• 9 edits in trunk

Followup to Bug 215027: address comments to improve APP_BOUND_DOMAINS macro use
​https://bugs.webkit.org/show_bug.cgi?id=216373
<rdar://problem/68645704>

Reviewed by Darin Adler.

Source/WebCore:

Separate out App-Bound Domain functions to avoid nested #if ENABLE()
macros, which are hard to read.

No new tests. Behavior confirmed by existing tests.

• platform/network/NetworkStorageSession.h:

Source/WebKit:

Use a local variable to avoid awkward #if ENABLE() macro placement.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::swServerForSession):

Source/WTF:

Remove unnecessary default. All enable flags are off by default.

• wtf/PlatformEnable.h:

LayoutTests:

Skip tests in platform/wk2/TestExpectations file to overwrite the
expectation that all resourceLoadStatistics tests pass on wk2. Then
unskip for the ios-wk2 specific platform.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/wk2/TestExpectations:

10:18 AM Changeset in webkit [266928] by Hector Lopez

• 3 edits in trunk/LayoutTests

REGRESSION(r266885): ASSERTION FAILED: Inspector::CSSBackendDispatcher::getInlineStylesForNode(long, RefPtr<JSON::Object> &&) !result.error().isEmpty()
​https://bugs.webkit.org/show_bug.cgi?id=216409

Unreviewed test gardening.

• TestExpectations:
• platform/mac-wk2/TestExpectations:

9:54 AM Changeset in webkit [266927] by sihui_liu@apple.com

• 4 edits in trunk/Tools

REGRESSION(r266634): WKThumbnailViewResetsViewStateWhenUnparented is flaky
​https://bugs.webkit.org/show_bug.cgi?id=216258
<rdar://problem/68515242>

Reviewed by Tim Horton.

r266634 makes activity state changes dispatched after existing CA transaction is committed, which delays update
of page state in web process.

• TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView waitUntilActivityStateUpdateDone]):

9:08 AM Changeset in webkit [266926] by weinig@apple.com

• 8 edits
  10 adds in trunk/Source/WebCore

[WebIDL] Split supplemental interfaces out of Document
​https://bugs.webkit.org/show_bug.cgi?id=216336

Reviewed by Darin Adler.

Split supplemental interfaces out of Document, adding/updating comments.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• animation/DocumentAnimations.idl: Added.
• css/FontFaceSource.idl: Added.
• dom/Document.idl:
• dom/DocumentHTML.idl: Added.
• dom/DocumentHTMLObsolete.idl: Added.
• dom/DocumentPageVisibility.idl: Added.
• dom/DocumentPointerLock.idl: Added.
• dom/DocumentScrolling.idl: Added.
• dom/DocumentSelection.idl: Added.
• dom/DocumentUndoMananger.idl: Added.
• xml/XPathEvaluator.idl:
• xml/XPathEvaluatorBase.idl: Added.

9:07 AM Changeset in webkit [266925] by Alexey Shvayka

• 2 edits in trunk/JSTests

Update test262 to commit 323905b70e64
​https://bugs.webkit.org/show_bug.cgi?id=216379

Unreviewed test gardening.

• test262/expectations.yaml: Reset expectations for --debug.

8:42 AM Changeset in webkit [266924] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.30.0

WPE WebKit 2.30.0

8:39 AM Changeset in webkit [266923] by Simon Fraser

• 8 edits
  2 adds in trunk

REGRESSION (Async overflow scroll): Mouse wheel scrolling over an "always-on" overflow scrollbar doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=216381
<rdar://problem/68593743>

Reviewed by Antti Koivisto.

Source/WebCore:

The scrollbar and scroll corner layers need event regions and scrollingNodeIDs so that
we hit-test them via CA layers and find the right scrolling node.

Test: fast/scrolling/mac/mousewheel-over-scrollbar.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateEventRegion):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::RenderLayerBacking::setScrollingNodeIDForRole):

LayoutTests:

• fast/scrolling/mac/border-radius-event-region-expected.txt:
• fast/scrolling/mac/event-region-scrolled-contents-layer-expected.txt:
• fast/scrolling/mac/event-region-subscroller-overflow-expected.txt:
• fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
• fast/scrolling/mac/mousewheel-over-scrollbar-expected.txt: Added.
• fast/scrolling/mac/mousewheel-over-scrollbar.html: Added.
• fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt:

8:28 AM Changeset in webkit [266922] by Chris Dumez

• 5 edits in trunk

AudioContext does not start rendering until an AudioNode is constructed
​https://bugs.webkit.org/show_bug.cgi?id=216393

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/constructor-allowed-to-start-expected.txt:

Source/WebCore:

AudioContext does not start rendering until an AudioNode is constructed. This is not as per specification
and does not match Chrome's behavior.

Specification section is here:

• ​https://www.w3.org/TR/webaudio/#dom-audiocontext-audiocontext

and says
"If the context is allowed to start, send a control message to start processing."

No new tests, rebaselined existing test.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):

• dom/Document.cpp:

(WebCore::Document::addMediaCanStartListener):

8:05 AM Changeset in webkit [266921] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] Make InlineBoxes grow vertically as they gain content
​https://bugs.webkit.org/show_bug.cgi?id=216405

Reviewed by Antti Koivisto.

Construct InlineBoxes with zero height (even the root inline box starts empty in quirks mode) and make them grow as they gain text runs.
(This initial vertical geometry adjustment is different from the sizing in computeInlineBoxesLogicalHeight(). It is based on
the font metrics (triggered by text runs), while in computeInlineBoxesLogicalHeight inline boxes stretch their parent inline boxes.)
This will also turn into a more dynamic sizing when we start handling fallback fonts.

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::fontMetrics const):
(WebCore::Layout::LineBox::InlineBox::setDescent):

8:00 AM Changeset in webkit [266920] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.30.0 release

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.30.0

5:18 AM Changeset in webkit [266919] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Rename m_URL to m_frameURL
​https://bugs.webkit.org/show_bug.cgi?id=216401

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-11
Reviewed by Frédéric Wang.

Rename m_URL to m_frameURL since m_URL violates the style
checker and any patches that touch m_URL would have to deal
with this style check violation.

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::canLoad const):
(WebCore::HTMLFrameElementBase::openURL):
(WebCore::HTMLFrameElementBase::setLocation):

• html/HTMLFrameElementBase.h:

2:45 AM Changeset in webkit [266918] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.30.0

WebKitGTK 2.30.0

2:45 AM Changeset in webkit [266917] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.30.0 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.30.0

1:46 AM Changeset in webkit [266916] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r266819 - [GTK][WPE] Support NTLM authentication
​https://bugs.webkit.org/show_bug.cgi?id=122952

Reviewed by Adrian Perez de Castro.

Add SoupAuthNTLM feature to the session.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):

1:46 AM Changeset in webkit [266915] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r266726 - [GTK] AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo
​https://bugs.webkit.org/show_bug.cgi?id=216254

Patch by Mike Gorse <​mgorse@suse.com> on 2020-09-08
Reviewed by Adrian Perez de Castro.

• UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::tryInitializeSHM): Return false for wpebackend-fdo < 1.7.0.

1:46 AM Changeset in webkit [266914] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r266702 - Build failure; cannot find seccomp.h
​https://bugs.webkit.org/show_bug.cgi?id=216226

Patch by Mike Gorse <​mgorse@suse.com> on 2020-09-07
Reviewed by Darin Adler.

No new tests (build fix only).

• PlatformGTK.cmake: Add LIBSECCOMP_INCLUDE_DIRS to

WebKit_SYSTEM_INCLUDE_DIRECTORIES.