Context Navigation

← Previous Period
Next Period →

Timeline

Sep 16, 2020:

9:40 PM Changeset in webkit [267182] by Alan Bujtas

10 edits
1 move in trunk/Source/WebCore

[LFC][IFC] Move InlineRect from Display to Layout namespace
https://bugs.webkit.org/show_bug.cgi?id=216633

Reviewed by Simon Fraser.

Let's move the Display type over to Layout namespace. Display tree needs a different set of data types.

WebCore.xcodeproj/project.pbxproj:
layout/displaytree/DisplayLine.h:

(WebCore::Display::Line::rect const):
(WebCore::Display::Line::scrollableOverflow const):
(WebCore::Display::Line::inkOverflow const):
(WebCore::Display::Line::Line):

layout/displaytree/DisplayRun.h:

(WebCore::Display::Run::rect const):
(WebCore::Display::Run::inkOverflow const):
(WebCore::Display::Run::Run):

layout/flexformatting/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::logicalRect const):

layout/inlineformatting/InlineRect.h: Renamed from Source/WebCore/layout/displaytree/DisplayInlineRect.h.

(WebCore::Layout::InlineRect::expandHorizontally):
(WebCore::Layout::InlineRect::expandVertically):
(WebCore::Layout::InlineRect::invalidateTop):
(WebCore::Layout::InlineRect::invalidateLeft):
(WebCore::Layout::InlineRect::invalidateWidth):
(WebCore::Layout::InlineRect::invalidateHeight):
(WebCore::Layout::InlineRect::hasValidPosition const):
(WebCore::Layout::InlineRect::hasValidSize const):
(WebCore::Layout::InlineRect::hasValidGeometry const):
(WebCore::Layout::InlineRect::InlineRect):
(WebCore::Layout::InlineRect::invalidatePosition):
(WebCore::Layout::InlineRect::setHasValidPosition):
(WebCore::Layout::InlineRect::setHasValidSize):
(WebCore::Layout::InlineRect::top const):
(WebCore::Layout::InlineRect::left const):
(WebCore::Layout::InlineRect::bottom const):
(WebCore::Layout::InlineRect::right const):
(WebCore::Layout::InlineRect::topLeft const):
(WebCore::Layout::InlineRect::size const):
(WebCore::Layout::InlineRect::width const):
(WebCore::Layout::InlineRect::height const):
(WebCore::Layout::InlineRect::setTopLeft):
(WebCore::Layout::InlineRect::setTop):
(WebCore::Layout::InlineRect::setBottom):
(WebCore::Layout::InlineRect::setLeft):
(WebCore::Layout::InlineRect::setWidth):
(WebCore::Layout::InlineRect::setHeight):
(WebCore::Layout::InlineRect::moveHorizontally):
(WebCore::Layout::InlineRect::moveVertically):
(WebCore::Layout::InlineRect::moveBy):
(WebCore::Layout::InlineRect::expand):
(WebCore::Layout::InlineRect::expandToContain):
(WebCore::Layout::InlineRect::expandVerticallyToContain):
(WebCore::Layout::InlineRect::inflate):
(WebCore::Layout::InlineRect::operator InlineLayoutRect const):

8:58 PM Changeset in webkit [267181] by weinig@apple.com

7 edits
3 adds in trunk/Source/WebKit

WebPreferences.yaml is overwhelming, what if we split it up a bit
https://bugs.webkit.org/show_bug.cgi?id=216627

Reviewed by Tim Horton.

Split out experimental, internal and debug preferences into their own
yaml files to add a bit of order.

CMakeLists.txt:
DerivedSources.make:
Shared/WebPreferences.yaml:
Shared/WebPreferencesDebug.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
Shared/WebPreferencesExperimental.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
Shared/WebPreferencesInternal.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
WebKit.xcodeproj/project.pbxproj:

7:59 PM Changeset in webkit [267180] by Alan Bujtas

10 edits in trunk/Source/WebCore

[LFC] Remove partial invalidation
https://bugs.webkit.org/show_bug.cgi?id=216631

Reviewed by Simon Fraser.

Invalidation fails when the LayoutTree does not match the RenderTree structures (e.g. table wrapper box).
Since incremental layouts are not supported yet, it has a very little value. Let's remove it for now.

layout/display/DisplayView.h:
layout/integration/LayoutIntegrationLineLayout.h:
layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::LayoutTree::LayoutTree):
(WebCore::Layout::TreeBuilder::buildLayoutTree):
(WebCore::Layout::TreeBuilder::TreeBuilder):
(WebCore::Layout::TreeBuilder::createReplacedBox):
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLineBreakBox):
(WebCore::Layout::TreeBuilder::createContainer):
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::printLayoutTreeForLiveDocuments):
(WebCore::Layout::LayoutTreeContent::LayoutTreeContent): Deleted.
(WebCore::Layout::LayoutTreeContent::addLayoutBoxForRenderer): Deleted.
(WebCore::Layout::TreeBuilder::buildTree): Deleted.

layout/layouttree/LayoutTreeBuilder.h:

(WebCore::Layout::LayoutTree::root const):
(WebCore::Layout::LayoutTree::append):
(WebCore::Layout::LayoutTreeContent::rootLayoutBox const): Deleted.
(WebCore::Layout::LayoutTreeContent::rootLayoutBox): Deleted.
(WebCore::Layout::LayoutTreeContent::rootRenderer const): Deleted.
(WebCore::Layout::LayoutTreeContent::addBox): Deleted.
(WebCore::Layout::LayoutTreeContent::addContainer): Deleted.
(WebCore::Layout::LayoutTreeContent::layoutBoxForRenderer): Deleted.
(WebCore::Layout::LayoutTreeContent::layoutBoxForRenderer const): Deleted.
(WebCore::Layout::LayoutTreeContent::rendererForLayoutBox const): Deleted.

page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):
(WebCore::FrameViewLayoutContext::invalidateLayoutTreeContent): Deleted.
(WebCore::FrameViewLayoutContext::invalidateLayoutState): Deleted.

page/FrameViewLayoutContext.h:

(WebCore::FrameViewLayoutContext::layoutFormattingState const):
(WebCore::FrameViewLayoutContext::layoutTreeContent const): Deleted.

rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::attachToRenderElementInternal):
(WebCore::RenderTreeBuilder::detachFromRenderElement):

rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRendererStyle):

7:58 PM Changeset in webkit [267179] by Hector Lopez

2 edits in trunk/LayoutTests

[ macOS wk2 ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216634

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

7:23 PM Changeset in webkit [267178] by Hector Lopez

2 edits in trunk/LayoutTests

Added fast/selectors/selection-window-inactive-stroke-color.html to bug and changed expectations
https://bugs.webkit.org/show_bug.cgi?id=216394

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

7:05 PM Changeset in webkit [267177] by Fujii Hironori

14 edits
3 adds in trunk

[CMake] Add a new library target TestRunnerShared
https://bugs.webkit.org/show_bug.cgi?id=216465

WinCairo port is using both DRT and WTR. However, it has a problem
for precompiled header builds to compile the source of
TestRunnerShared twice for DRT and WTR.

Add a new library target TestRunnerShared. Re-enable precompiled
header for DRT and WTR for WinCairo.

Reviewed by Don Olmstead.

Source/cmake/OptionsWinCairo.cmake:
Source/cmake/WebKitFS.cmake:

Tools:

Reviewed by Don Olmstead.

DumpRenderTree/CMakeLists.txt:
DumpRenderTree/PlatformWin.cmake:
PlatformFTW.cmake:
PlatformGTK.cmake:
PlatformMac.cmake:
PlatformWPE.cmake:
PlatformWin.cmake:
TestRunnerShared/CMakeLists.txt: Added.
TestRunnerShared/config/config.h: Added.
WebKitTestRunner/CMakeLists.txt:
WebKitTestRunner/PlatformFTW.cmake:
WebKitTestRunner/PlatformWin.cmake:

6:57 PM Changeset in webkit [267176] by Kate Cheney

3 edits in trunk/Source/WebKit

Revert _setIgnoresAppBoundDomains SPI to compile for macOS
https://bugs.webkit.org/show_bug.cgi?id=216628
<rdar://problem/69025655>

Reviewed by Tim Horton.

We need to give users of the _setIgnoresAppBoundDomains SPI time to
convert uses to iOS only, so in the meantime we should still compile
the SPI for macOS so we don't break anything.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

6:53 PM Changeset in webkit [267175] by rniwa@webkit.org

8 edits in trunk/Source/WebCore

MutationObserverRegistration should be ref counted
https://bugs.webkit.org/show_bug.cgi?id=216528

Reviewed by Darin Adler.

This patch makes MutationObserverRegistration ref counted so that the transient registry can store
Ref<MutationObserverRegistration> instead of a raw pointer. It also merges NodeMutationObserverData
into NodeRareData now that NodeRareData is actually rare after r266714 and r266769.

Before this patch, MutationObserverRegistration had to be kept alive by the originally observed node
using m_nodeKeptAlive whenever a transient observation occurs (i.e. observation of a node which used
to be a part of the subtree of the observed node). With this patch, this complexity is eliminated.

No new tests since there should be no behavioral difference.

dom/MutationObserver.cpp:

(WebCore::MutationObserver::disconnect): Skip any node for which the observed node had been deleted.
This means that the registration is alive for transient nodes (i.e. a node which used to be a part of
the subtree of the observed node).
(WebCore::MutationObserver::observationStarted): Converted debug assert to a release assert.
(WebCore::MutationObserver::observationEnded): Ditto.
(WebCore::MutationObserver::deliver): Simplified logic a bit using WTF::map.

dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::create): Added.
(WebCore::MutationObserverRegistration::MutationObserverRegistration): Create a WeakPtr for m_node.
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Deleted the code for
m_nodeKeptAlive since the observed node is no longer responsible for keeping this
MutationObserverRegistration alive while transient observarion takes place.
(WebCore::MutationObserverRegistration::takeTransientRegistrations): Ditto.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom const):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet const): Skip m_node if it has been
deleted. This is possible during transient observations.

dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration): This class is now ref counted. Also made m_node WeakPtr.
(WebCore::MutationObserverRegistration::node):

dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::moveNodeToNewDocument):
(WebCore::Node::mutationObserverRegistry): Deleted.
(WebCore::Node::transientMutationObserverRegistry): Deleted.
(WebCore::collectMatchingObserversForMutation): Now takes a reference to registry.
(WebCore::Node::registeredMutationObservers):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver): Converted debug assertions to release assertions. With
script execution forbidden during tree mutations, this should never happen now.
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::unregisterTransientMutationObserver): Ditto.
(WebCore::Node::notifyMutationObserversNodeWillDetach):

dom/Node.h:
dom/NodeRareData.cpp:
dom/NodeRareData.h:

(WebCore::NodeMutationObserverData): Merged into NodeRareData.
(WebCore::NodeRareData::mutationObserverData): Deleted.
(WebCore::NodeRareData::ensureMutationObserverData): Deleted.
(WebCore::NodeRareData::mutationObserverRegistry): Added.
(WebCore::NodeRareData::mutationObserverRegistryIfExists): Added.
(WebCore::NodeRareData::transientMutationObserverRegistry): Added.
(WebCore::NodeRareData::useTypes const):

5:23 PM Changeset in webkit [267174] by Ryan Haddad

2 edits in branches/safari-610-branch/LayoutTests/imported/w3c

Cherry-pick r266098. rdar://problem/67703327

Update iOS layout test results after r266087
https://bugs.webkit.org/show_bug.cgi?id=215671

web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt: Apparently there's a newly passing test here, too. I wonder why macOS isn't affected by this change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:58 PM Changeset in webkit [267173] by Ryan Haddad

1 edit
4 deletes in trunk/LayoutTests

Unreviewed, reverting r267171.

The tests need to be fixed

Reverted changeset:

"4 webaudio/oscillator tests missing expected results"
https://bugs.webkit.org/show_bug.cgi?id=216625
https://trac.webkit.org/changeset/267171

4:56 PM Changeset in webkit [267172] by weinig@apple.com

16 edits in trunk

Remove runtime setting for enabling/disabling CSS shadow parts
https://bugs.webkit.org/show_bug.cgi?id=216567

Reviewed by Tim Horton.

Remove runtime setting for enabling/disabling CSS shadow parts. It is
on by default and there is no known reason one would need to disable it.

Source/WebCore:

css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoElementType):

dom/Element.cpp:

(WebCore::Element::partAttributeChanged):

dom/Element.idl:
dom/ShadowRoot.cpp:

(WebCore::parsePartMappingsList):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCSSShadowPartsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssShadowPartsEnabled const): Deleted.

style/StyleInvalidator.cpp:

(WebCore::Style::Invalidator::invalidateShadowParts):

Source/WebKit:

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setCSSShadowPartsEnabled:]):
(-[WebPreferences cssShadowPartsEnabled]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

4:54 PM Changeset in webkit [267171] by Ryan Haddad

1 edit
4 adds in trunk/LayoutTests

4 webaudio/oscillator tests missing expected results
https://bugs.webkit.org/show_bug.cgi?id=216625

Unreviewed test gardening.

webaudio/oscillator-custom-expected.txt: Added.
webaudio/oscillator-sawtooth-expected.txt: Added.
webaudio/oscillator-square-expected.txt: Added.
webaudio/oscillator-triangle-expected.txt: Added.

4:26 PM Changeset in webkit [267170] by Chris Dumez

4 edits in trunk

AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0
https://bugs.webkit.org/show_bug.cgi?id=216623

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero-expected.txt:

Source/WebCore:

AudioBufferSourceNode::renderFromBuffer() has special logic when pitch rate is 0 since
the output value is constant. However, that logic was wrongly always writing to the
begining of the destination buffer, ignoring the computed writeIndex. As a result,
instead of having silence at the beginning of the destination buffer, we would have
it at the end.

No new tests, rebaselined existing test.

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):

3:43 PM Changeset in webkit [267169] by Chris Dumez

4 edits in trunk

AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer
https://bugs.webkit.org/show_bug.cgi?id=216622

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-start-expected.txt:

Source/WebCore:

AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer. We
are supposed to output silence. However, in order implementation, we were just resetting the offset
to 0, playing the buffer from the beginning.

To address the issue, I have dropped the logic that would reset the read offset if past the end of
the buffer.

No new tests, rebaselined existing test.

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):

(WebCore::AudioBufferSourceNode::startPlaying):
Drop dead code since m_isGrain is always true in this function.

3:40 PM Changeset in webkit [267168] by Hector Lopez

4 edits in trunk/LayoutTests

[ macOS iOS Debug ] imported/w3c/web-platform-tests/selection/*: 4 tests marked as slow
https://bugs.webkit.org/show_bug.cgi?id=216492

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:

3:31 PM Changeset in webkit [267167] by Chris Dumez

50 edits in trunk/LayoutTests

Update WPT test harness so that webaudio tests output results that are consistent across different machines
https://bugs.webkit.org/show_bug.cgi?id=216332

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline tests.

web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-scheduling-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setTargetAtTime-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-output-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/gain-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-getFrequencyResponse-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

LayoutTests:

Unskip tests that should now pass on all platforms.

TestExpectations:
resources/testharnessreport.js:

(self.testRunner.add_completion_callback):
Our webaudio implementation uses single precision for floating point audio values. However, the tests were
printing out those values with 16 digits, even when the checks were passing. We had to skip those tests
because digits after the 6th one may differ across machines and we were getting TEXT diffs. To address the
issue we now strip arrays from PASS lines in webaudio tests output and replace them with the string
'[expected array]'. As long as the check is passing, the actual value in the array does not really matter.

webaudio/Oscillator/no-dezippering-expected.txt:
webaudio/Oscillator/osc-440hz-expected.txt:
webaudio/Oscillator/osc-negative-freq-expected.txt:
webaudio/Oscillator/start-sampling-expected.txt:
webaudio/audioparam-cancel-and-hold-expected.txt:
webaudio/convolvernode-unmodified-buffer-expected.txt:

Rebaseline tests.

3:30 PM Changeset in webkit [267166] by stephan.szabo@sony.com

35 edits in trunk

Remove ENABLE_METER_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=216582

Reviewed by Fujii Hironori.

With PlayStation finally planning to turn this on,
no ports had this disabled, so remove the enable flag.

Source/cmake/OptionsFTW.cmake:
Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsPlayStation.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/WebCore:

DerivedSources.make:
accessibility/AXObjectCache.cpp:
accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityProgressIndicator.cpp:
accessibility/AccessibilityProgressIndicator.h:
accessibility/AccessibilityRenderObject.cpp:
css/html.css:
html/HTMLMeterElement.cpp:
html/HTMLMeterElement.h:
html/HTMLMeterElement.idl:
html/HTMLTagNames.in:
platform/LocalizedStrings.h:
platform/cocoa/LocalizedStringsCocoa.mm:
rendering/RenderMeter.cpp:
rendering/RenderMeter.h:
rendering/RenderObject.h:
rendering/RenderTheme.cpp:
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:
rendering/RenderThemeWin.cpp:
rendering/RenderThemeWin.h:

Source/WTF:

wtf/PlatformEnable.h:

Tools:

Scripts/webkitperl/FeatureList.pm:

3:05 PM Changeset in webkit [267165] by aakash_jain@apple.com

2 edits in trunk/Tools

EWS emails to bot watchers about build failures should be grouped properly
https://bugs.webkit.org/show_bug.cgi?id=216495

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Set email headers appropriately.

3:04 PM Changeset in webkit [267164] by weinig@apple.com

25 edits
2 deletes in trunk

Remove runtime setting for enabling/disabling the isSecureContext API?
https://bugs.webkit.org/show_bug.cgi?id=216562

Reviewed by Darin Adler.

Remove runtime setting for enabling/disabling the the isSecureContext attribute.
on window and the worker global scope. There is no known reason one would need
to disable it.

Source/WebCore:

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setIsSecureContextAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::isSecureContextAttributeEnabled const): Deleted.

page/WindowOrWorkerGlobalScope.idl:

Source/WebKit:

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetIsSecureContextAttributeEnabled):
(WKPreferencesGetIsSecureContextAttributeEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setIsSecureContextAttributeEnabled:]):
(-[WebPreferences isSecureContextAttributeEnabled]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setIsSecureContextAttributeEnabled):
(WebPreferences::isSecureContextAttributeEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

DumpRenderTree/TestOptions.h:
DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

DumpRenderTree/win/DumpRenderTree.cpp:

(setWebPreferencesForTestOptions):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

platform/win/TestExpectations:
security/isSecureContext-disabled-expected.txt: Removed.
security/isSecureContext-disabled.html: Removed.

3:04 PM Changeset in webkit [267163] by sbarati@apple.com

3 edits
1 add in trunk

Don't IC a null custom accessor/value setter
https://bugs.webkit.org/show_bug.cgi?id=216620
<rdar://problem/68976066>

Reviewed by Mark Lam.

JSTests:

stress/dont-ic-null-custom-setter.js: Added.

Source/JavaScriptCore:

Our runtime allows CustomGetterSetter objects setter field to not contain an
actual C function to call. In such a scenario, the runtime just does nothing
except return false to the ::put code (which may result in throwing an
exception in strict mode code).

However, our IC code never considered whether this function could be nullptr.
The fix here is simple: don't IC such custom accessor/value setters.

runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::isCacheableCustom const):

2:56 PM Changeset in webkit [267162] by jer.noble@apple.com

4 edits in trunk

REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216619

Reviewed by Chris Dumez.

Tools:

In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

platform/mac-wk2/TestExpectations:

2:52 PM Changeset in webkit [267161] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
https://bugs.webkit.org/show_bug.cgi?id=216566

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.

2:34 PM Changeset in webkit [267160] by Ryan Haddad

19 edits
37 copies
1 move
14 adds
8 deletes in branches/safari-610-branch/LayoutTests

Unreviewed test gardening, land baselines for rdar://67764580 and rdar://68372418.

platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
platform/mac-bigsur/fast/css/text-overflow-input-expected.txt: Removed.
platform/mac-bigsur/fast/forms/button-sizes-expected.txt: Removed.
platform/mac-bigsur/fast/forms/input-button-sizes-expected.txt: Removed.
platform/mac-bigsur/fast/forms/listbox-bidi-align-expected.txt: Removed.
platform/mac-bigsur/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
platform/mac-bigsur/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
platform/mac-bigsur/tables/mozilla/bugs/bug33855-expected.txt: Removed.
platform/mac-catalina/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt.
platform/mac-catalina/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
platform/mac-catalina/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
platform/mac-catalina/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
platform/mac-catalina/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
platform/mac-catalina/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/forms/button-table-styles-expected.txt.
platform/mac-catalina/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
platform/mac-catalina/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
platform/mac-catalina/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
platform/mac-catalina/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
platform/mac-catalina/fast/forms/select/optgroup-rendering-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt.
platform/mac-catalina/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
platform/mac-catalina/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
platform/mac-catalina/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
platform/mac-catalina/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
platform/mac-catalina/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Renamed from LayoutTests/platform/mac-bigsur/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
platform/mac-mojave/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt.
platform/mac-mojave/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
platform/mac-mojave/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
platform/mac-mojave/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
platform/mac-mojave/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
platform/mac-mojave/fast/forms/button-table-styles-expected.txt: Renamed from LayoutTests/platform/mac-bigsur/fast/forms/button-table-styles-expected.txt.
platform/mac-mojave/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
platform/mac-mojave/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
platform/mac-mojave/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
platform/mac-mojave/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
platform/mac-mojave/fast/forms/select/optgroup-rendering-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt.
platform/mac-mojave/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
platform/mac-mojave/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
platform/mac-mojave/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
platform/mac-mojave/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
platform/mac/fast/css/continuationCrash-expected.txt:
platform/mac/fast/css/text-overflow-input-expected.txt:
platform/mac/fast/forms/button-positioned-expected.txt:
platform/mac/fast/forms/button-sizes-expected.txt:
platform/mac/fast/forms/input-button-sizes-expected.txt:
platform/mac/fast/forms/input-disabled-color-expected.txt:
platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
platform/mac/fast/forms/input-text-word-wrap-expected.txt:
platform/mac/fast/forms/listbox-bidi-align-expected.txt:
platform/mac/fast/forms/plaintext-mode-2-expected.txt:
platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
platform/mac/fast/forms/select-selected-expected.txt:
platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
platform/mac/fast/parser/document-write-option-expected.txt:
platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
platform/mac/tables/mozilla/bugs/bug33855-expected.txt:

2:11 PM Changeset in webkit [267159] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[Flatpak SDK][WPE] Launching the remote inspector kills MB
https://bugs.webkit.org/show_bug.cgi?id=213899

Patch by Philippe Normand <pnormand@igalia.com> on 2020-09-16
Reviewed by Adrian Perez de Castro.

Load inspector resources from developer build artefacts, when the inspector server is
running in this configuration. Fall back to system libraries loading mechanism otherwise.

inspector/remote/glib/RemoteInspectorUtils.cpp:

(Inspector::backendCommands):

1:58 PM Changeset in webkit [267158] by Alan Bujtas

23 edits in trunk/Source/WebCore

[LFC] Box geometry is all logical
https://bugs.webkit.org/show_bug.cgi?id=216614

Reviewed by Simon Fraser.

Rename top/left/bottom/right/width/height to logical*. These coordinates are in the Layout namespace, therefore they are all logical.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):

layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layout):

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticVerticalPosition const):

layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeHeightAndMarginForTableBox):

layout/display/DisplayLayerController.cpp:

(WebCore::Display::LayerController::prepareForDisplay):

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBoxDecoration):
(WebCore::Display::Painter::absoluteBoxGeometry):
(WebCore::Display::paintSubtree):
(WebCore::Display::collectPaintRootsAndContentRect):

layout/flexformatting/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):

layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::append):
(WebCore::Layout::FloatingContext::mapTopLeftToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::rectWithMargin const):
(WebCore::Layout::FloatingState::FloatItem::bottom const):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::inlineItemWidth const):

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::prepareFloatingState):

layout/layouttree/LayoutBoxGeometry.cpp:

(WebCore::Layout::BoxGeometry::borderBox const):

layout/layouttree/LayoutBoxGeometry.h:

(WebCore::Layout::BoxGeometry::logicalBottom const):
(WebCore::Layout::BoxGeometry::logicalRight const):
(WebCore::Layout::BoxGeometry::logicalBottomRight const):
(WebCore::Layout::BoxGeometry::logicalSize const):
(WebCore::Layout::BoxGeometry::logicalWidth const):
(WebCore::Layout::BoxGeometry::logicalHeight const):
(WebCore::Layout::BoxGeometry::isEmpty const):
(WebCore::Layout::BoxGeometry::logicalRect const):
(WebCore::Layout::BoxGeometry::logicalRectWithMargin const):
(WebCore::Layout::BoxGeometry::logicalTop const):
(WebCore::Layout::BoxGeometry::logicalLeft const):
(WebCore::Layout::BoxGeometry::logicalTopLeft const):
(WebCore::Layout::BoxGeometry::setLogicalTopLeft):
(WebCore::Layout::BoxGeometry::setLogicalTop):
(WebCore::Layout::BoxGeometry::setLogicalLeft):
(WebCore::Layout::BoxGeometry::bottom const): Deleted.
(WebCore::Layout::BoxGeometry::right const): Deleted.
(WebCore::Layout::BoxGeometry::bottomRight const): Deleted.
(WebCore::Layout::BoxGeometry::size const): Deleted.
(WebCore::Layout::BoxGeometry::width const): Deleted.
(WebCore::Layout::BoxGeometry::height const): Deleted.
(WebCore::Layout::BoxGeometry::rect const): Deleted.
(WebCore::Layout::BoxGeometry::rectWithMargin const): Deleted.
(WebCore::Layout::BoxGeometry::top const): Deleted.
(WebCore::Layout::BoxGeometry::left const): Deleted.
(WebCore::Layout::BoxGeometry::topLeft const): Deleted.
(WebCore::Layout::BoxGeometry::setTopLeft): Deleted.
(WebCore::Layout::BoxGeometry::setTop): Deleted.
(WebCore::Layout::BoxGeometry::setLeft): Deleted.

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):

layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):

layout/tableformatting/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):

page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):

1:09 PM Changeset in webkit [267157] by Alan Bujtas

10 edits
3 adds in trunk

[LFC][FFC] Add basic flex item sizing and positioning
https://bugs.webkit.org/show_bug.cgi?id=216613

Reviewed by Antti Koivisto.

Source/WebCore:

This patch adds support for single line (no-wrap), row based flex item layout with default spacing.

Test: fast/layoutformattingcontext/flex-box-simple.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

layout/flexformatting/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::layoutInFlowContent):
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):
(WebCore::Layout::FlexFormattingContext::computeIntrinsicWidthConstraintsForFlexItems):

layout/flexformatting/FlexFormattingContext.h:

(WebCore::Layout::FlexFormattingContext::Geometry::Geometry):

layout/flexformatting/FlexFormattingContextGeometry.cpp: Added.

(WebCore::Layout::FlexFormattingContext::Geometry::intrinsicWidthConstraints):

layout/flexformatting/FlexFormattingState.h:

(WebCore::Layout::FlexFormattingState::lines const): Flex layout has the concept of lines where flex wrap may trigger multi-line layout.
(WebCore::Layout::FlexFormattingState::addLine):

LayoutTests:

fast/layoutformattingcontext/flex-box-simple-expected.html: Added.
fast/layoutformattingcontext/flex-box-simple.html: Added.

12:07 PM HackingWebInspector edited by Nikita Vasilyev

Replace IRC with Slack. Update paths. (diff)

11:43 AM Changeset in webkit [267156] by youenn@apple.com

13 edits in trunk/Source/WebKit

RemoteSampleBufferDisplayLayer should process its IPC messages from a background thread
https://bugs.webkit.org/show_bug.cgi?id=216475

Reviewed by Eric Carlson.

Use a process wide work queue to process all track video renderer messages in a background thread.
This queue is shared by all RemoteSampleBufferDisplayLayerManager and RemoteSampleBufferDisplayLayer objects, which are per web process.
Since LocalSampleBufferDisplayLayer must currently be created in main thread, hop to main thread to create/delete renderers.

We update messages.py to support WantsAsyncDispatchMessage, which removes the sync handling with dispatchMessage.
This allows RemoteSampleBufferDisplayLayerManager to also handle messages from RemoteSampleBufferDisplayLayer.
Update RemoteSampleBufferDisplayLayerManager accordingly as well.

Covered by webrtc/video.html with GPU process enabled.

GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):

GPUProcess/GPUConnectionToWebProcess.h:
GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::videoMediaStreamTrackRendererQueue):

GPUProcess/GPUProcess.h:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp:

(WebKit::RemoteAudioMediaStreamTrackRendererManager::dispatchMessage):

GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.messages.in:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:

(WebKit::RemoteSampleBufferDisplayLayerManager::RemoteSampleBufferDisplayLayerManager):
(WebKit::RemoteSampleBufferDisplayLayerManager::~RemoteSampleBufferDisplayLayerManager):
(WebKit::RemoteSampleBufferDisplayLayerManager::close):
(WebKit::RemoteSampleBufferDisplayLayerManager::dispatchToThread):
(WebKit::RemoteSampleBufferDisplayLayerManager::dispatchMessage):
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
(WebKit::RemoteSampleBufferDisplayLayerManager::releaseLayer):

GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
Scripts/webkit/messages.py:
SourcesCocoa.txt:

11:21 AM Changeset in webkit [267155] by commit-queue@webkit.org

14 edits in trunk/Source/WebKit

Move TLS certificate bypass SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216585

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-16
Reviewed by Geoffrey Garen.

It will eventually be replaced by WKNavigationDelegate's didReceiveAuthenticationChallenge in rdar://30655740
but the SPI needs to continue to exist somewhere until that is complete.
In the meantime, it needs to be moved from the WebProcessPool for https://bugs.webkit.org/show_bug.cgi?id=216041
and rdar://problem/68942815 tracks Safari's adoption of the SPI introduced here, which I will fix within an hour of landing this.

UIProcess/API/C/WKContext.cpp:

(WKContextAllowSpecificHTTPSCertificateForHost):

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]): Deleted.

UIProcess/API/Cocoa/WKProcessGroupPrivate.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _allowTLSCertificate:forHost:]):

UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_allow_tls_certificate_for_host):
Use the default data store until this API can be replaced by API in a different place.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::allowSpecificHTTPSCertificateForHost): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::allowSpecificHTTPSCertificateForHost):

UIProcess/WebsiteData/WebsiteDataStore.h:

10:57 AM Changeset in webkit [267154] by Chris Lord

118 edits in trunk

Enable full CSS color parsing within a worker for OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=204575

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing OffscreenCanvas tests now that full CSS color
parsing is available.

web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-4.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-5-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-5.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-6-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-6.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-6-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-6.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgb-eof-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgb-eof.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-eof-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-eof.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-1-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-1.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-2-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-2.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-3-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-3.worker-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-4-expected.txt:
web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-4.worker-expected.txt:

Source/WebCore:

Enable full CSS color parsing in OffscreenCanvas by removing the
unnecessary use of CSSValuePool::singleton in color-parsing code in
CSSPropertyParserHelpers and adding a new helper function to return a
Color instead of a CSSPrimitiveValue when parsing a color.

Rebaselined existing layout tests.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeDegrees const):

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::computeDegrees):

css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseColorWorkerSafe):

css/parser/CSSParser.h:
css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumePercentRaw):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeAngleRaw):
(WebCore::CSSPropertyParserHelpers::consumePercentRaw):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumeAngleRaw):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::clampRGBComponent):
(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::consumeColorWorkerSafe):

css/parser/CSSPropertyParserHelpers.h:

10:40 AM Changeset in webkit [267153] by Chris Dumez

27 edits in trunk

Merge PeriodicWave improvements from Blink
https://bugs.webkit.org/show_bug.cgi?id=216576

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline tests that now have a slightly different output.

web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

Source/WebCore:

Merge PeriodicWave improvements from Blink:

These fixes allow us to pass some of the tests imported from Blink.

No new tests, rebaselined existing tests.

Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::maxNumberOfPartials const):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):
(WebCore::PeriodicWave::periodicWaveSize const):

Modules/webaudio/PeriodicWave.h:

LayoutTests:

Rebaseline tests that are now passing.

webaudio/Oscillator/no-dezippering-expected.txt:
webaudio/Oscillator/osc-negative-freq-expected.txt:
webaudio/Oscillator/osc-sweep-snr-triangle-expected.txt:
webaudio/Oscillator/start-sampling-expected.txt:

10:08 AM Changeset in webkit [267152] by Hector Lopez

2 edits in trunk/LayoutTests

Correction to test expectation for imported/w3c/web-platform-tests/css/css-position/fixed-z-index-blend.html
webkit.org/b/207891

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

10:06 AM Changeset in webkit [267151] by Chris Dumez

4 edits in trunk

OfflineAudioContext should support up to 32 channels
https://bugs.webkit.org/show_bug.cgi?id=216587

Reviewed by Darin Adler.

Source/WebCore:

OfflineAudioContext should support up to 32 channels. It previously had
an artificial limit of 10.

No new tests, updated existing test.

Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

LayoutTests:

Update test that is now passing.

webaudio/dom-exceptions-expected.txt:

9:56 AM Changeset in webkit [267150] by commit-queue@webkit.org

6 edits in trunk/Source

Remove unneeded HAVE_FOUNDATION_WITH_SAVE_COOKIES_WITH_COMPLETION_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=216572

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-16
Reviewed by Youenn Fablet.

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

It's available everywhere we support.

NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::saveCookies):
(WebKit::NetworkProcess::platformFlushCookies):

Source/WTF:

wtf/PlatformHave.h:

9:39 AM Changeset in webkit [267149] by Philippe Normand

2 edits in trunk/Tools

[Flatpak] webkit-bwrap drive-by cleanups

Rubber-stamped by Adrian Perez de Castro.

flatpak/webkit-bwrap: Extend lists with tuples, use itertools and map to build the final

command line.

9:34 AM Changeset in webkit [267148] by Brent Fulgham

2 edits in trunk/Source/WebCore

[macOS] Limit reported macOS release to 10.15 series
https://bugs.webkit.org/show_bug.cgi?id=216593
<rdar://problem/68937905>

Reviewed by Maciej Stachowiak.

If the reported system OS is 11.0 (or beyond) report the last stable release
of macOS.

platform/mac/UserAgentMac.mm:

(WebCore::standardUserAgentWithApplicationName):

9:00 AM Changeset in webkit [267147] by Chris Dumez

15 edits in trunk

OfflineAudioContext constructor should not throw when given a bad buffer length
https://bugs.webkit.org/show_bug.cgi?id=216584

Reviewed by Youenn Fablet.

Source/WebCore:

OfflineAudioContext constructor should not throw when given a bad buffer length. We should
instead throw later on when trying to start rendering.

No new tests, rebaselined existing test.

Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):

Modules/webaudio/BaseAudioContext.h:
Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::OfflineAudioContext):
(WebCore::OfflineAudioContext::create):
(WebCore::OfflineAudioContext::startOfflineRendering):

Modules/webaudio/OfflineAudioContext.h:
Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::maxChannelCount const):

LayoutTests:

Rebaseline test now that more checks are passing.

webaudio/dom-exceptions-expected.txt:

8:55 AM Changeset in webkit [267146] by weinig@apple.com

7 edits
1 add in trunk/Source/WebCore

[WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec
https://bugs.webkit.org/show_bug.cgi?id=216590

Reviewed by Youenn Fablet.

Adds NavigatorCookies interface mixin and includes it in Navigator.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
page/Navigator.idl:
page/NavigatorCookies.idl: Added.

8:51 AM Changeset in webkit [267145] by youenn@apple.com

7 edits in trunk/Source/WebKit

Move LibWebRTCCodecsProxy message handling out of the main thread
https://bugs.webkit.org/show_bug.cgi?id=216531

Reviewed by Eric Carlson.

Use a process wide work queue to process all LibWebRTCCodecsProxy messages in a background thread.
This queue is shared by all LibWebRTCCodecsProxy objects, which are per web process.
Covered by webrtc/video.html with GPU process enabled.

GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):
(WebKit::GPUConnectionToWebProcess::libWebRTCCodecsProxy): Deleted.

GPUProcess/GPUConnectionToWebProcess.h:
GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::libWebRTCCodecsQueue):

GPUProcess/GPUProcess.h:
GPUProcess/webrtc/LibWebRTCCodecsProxy.h:

(WebKit::LibWebRTCCodecsProxy::create):
(WebKit::LibWebRTCCodecsProxy::didReceiveMessageFromWebProcess): Deleted.

GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::~LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
(WebKit::LibWebRTCCodecsProxy::close):

8:32 AM Changeset in webkit [267144] by Chris Dumez

3 edits
34 adds
4 deletes in trunk/LayoutTests

Import OscillatorNode layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216569

Reviewed by Eric Carlson.

Import OscillatorNode layout tests from Blink.

webaudio/Oscillator/no-dezippering-expected.txt: Added.
webaudio/Oscillator/no-dezippering.html: Added.
webaudio/Oscillator/osc-440hz-expected.txt: Added.
webaudio/Oscillator/osc-440hz.html: Added.
webaudio/Oscillator/osc-low-freq-expected.txt: Added.
webaudio/Oscillator/osc-low-freq.html: Added.
webaudio/Oscillator/osc-negative-freq-expected.txt: Added.
webaudio/Oscillator/osc-negative-freq.html: Added.
webaudio/Oscillator/osc-sweep-snr-custom-expected.txt: Added.
webaudio/Oscillator/osc-sweep-snr-custom.html: Added.
webaudio/Oscillator/osc-sweep-snr-sawtooth-expected.txt: Added.
webaudio/Oscillator/osc-sweep-snr-sawtooth.html: Added.
webaudio/Oscillator/osc-sweep-snr-sine-expected.txt: Added.
webaudio/Oscillator/osc-sweep-snr-sine.html: Added.
webaudio/Oscillator/osc-sweep-snr-square-expected.txt: Added.
webaudio/Oscillator/osc-sweep-snr-square.html: Added.
webaudio/Oscillator/osc-sweep-snr-triangle-expected.txt: Added.
webaudio/Oscillator/osc-sweep-snr-triangle.html: Added.
webaudio/Oscillator/oscillator-basic-expected.txt: Added.
webaudio/Oscillator/oscillator-basic.html: Added.
webaudio/Oscillator/oscillator-ended-expected.txt: Added.
webaudio/Oscillator/oscillator-ended.html: Added.
webaudio/Oscillator/oscillator-late-start-expected.txt: Added.
webaudio/Oscillator/oscillator-late-start.html: Added.
webaudio/Oscillator/start-sampling-expected.txt: Added.
webaudio/Oscillator/start-sampling.html: Added.
webaudio/oscillator-basic-expected.txt: Removed.
webaudio/oscillator-basic.html: Removed.
webaudio/oscillator-ended-expected.txt: Removed.
webaudio/oscillator-ended.html: Removed.
webaudio/resources/audio-file-utils.js: Added.
webaudio/resources/oscillator-testing.js:
webaudio/resources/start-stop-exceptions.js: Added.

8:09 AM Changeset in webkit [267143] by Adrian Perez de Castro

32 edits in trunk/Source

Non-unified build fixes, early September 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=216599

Unreviewed build fix.

Largely based on a patch by Lauro Moura <Lauro Moura>

Source/JavaScriptCore:

runtime/IntlCache.cpp: Add missing wtf/Vector.h include.
runtime/IntlCache.h: Add missing wtf/text/CString.h include.
runtime/IntlNumberFormatPrototype.cpp: Replace IntlNumberFormat.h

include with IntlNumberFormatInlines.h to fix linking.

Source/WebCore:

Modules/async-clipboard/ClipboardImageReader.cpp: Add missing Document.h include.
Modules/async-clipboard/ClipboardImageReader.h: Add missing forward declaration

for Document.

Modules/fetch/FetchBodyConsumer.cpp: Add missing includes for DOMFormData.h,

HTTPParsers.h, and JSDOMFormData.h.

css/parser/CSSSelectorParser.cpp: Move CSSSelectorParser declaration to header.
css/parser/CSSSelectorParser.h: Ditto.
css/parser/CSSSupportsParser.cpp: Add missing CSSSelectorParser.h include.
dom/DataTransferItemList.cpp: Add missing includes for ContextDestructionObserver.h

and Document.h.

html/HTMLMetaElement.cpp: Add missing includes for Settings.h and

wtf/IsoMallocInlines.h.

html/canvas/EXTBlendMinMax.cpp: Add missing wtf/IsoMallocInlines.h include.
html/canvas/EXTColorBufferFloat.cpp: Ditto.
html/canvas/OESElementIndexUint.cpp: Ditto.
html/canvas/WebGLCompressedTextureASTC.cpp: Ditto.
html/canvas/WebGLCompressedTextureATC.cpp: Ditto.
html/canvas/WebGLCompressedTextureETC.cpp: Ditto.
inspector/InspectorFrontendHost.cpp: Add missing Settings.h include.
layout/display/DisplayLayerController.cpp: Add missing LayoutState.h include.
layout/displaytree/DisplayPainter.h: Add missing LayoutBox.h include.
layout/inlineformatting/InlineLineBox.cpp: Add missing InlineFormattingContext.h

include.

platform/audio/FFTFrame.cpp: Add missing VectorMath.h include.
platform/audio/SincResampler.h: Add missing wtf/Optional.h include.
rendering/SimpleLineLayout.h: Add missing RenderStyleConstants.h include.

Source/WebKit:

GPUProcess/media/RemoteCDMProxy.cpp: Add missing WebCore/SharedBuffer.h include.
GPUProcess/media/RemoteMediaResourceLoader.cpp: Add missing WebCore/ResourceError.h

include.

NetworkProcess/webrtc/NetworkRTCProvider.cpp: Add missing DataReference.h include.
UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::show): Add missing namespace to
WebCore::monitorWorkArea() call.

WebProcess/Network/WebSocketChannelManager.cpp: Add missing

WebCore/WebSocketIdentifier.h include.
(WebKit::WebSocketChannelManager::didReceiveMessage): Add missing namespace to
WebCore::WebSocketIdentifierType usage.

7:05 AM Changeset in webkit [267142] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][FFC] Create a Layout::ContainerBox for flex container
https://bugs.webkit.org/show_bug.cgi?id=216598

Reviewed by Antti Koivisto.

A flex container establishes a flex formatting context.

layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::createFormattingContext):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):

6:45 AM Changeset in webkit [267141] by Aditya Keerthi

4 edits
2 adds in trunk

[Cocoa] Use OTF font features instead of AAT font features when possible
https://bugs.webkit.org/show_bug.cgi?id=182845
<rdar://problem/33046942>

Reviewed by Myles C. Maxfield.

Source/WebCore:

Using OTF font features instead of AAT font features allows WebKit to
leverage CoreText's mapping between OTF and AAT features. This prevents us
from having to maintain our own mapping, and adds support for previously
missing features (for AAT fonts), such as stylistic alternatives.

Note that the hlig and hist features are not mapped by CoreText for AAT
fonts, in which case we handle the mapping to an AAT font feature ourselves.

Test: css3/font-feature-settings-stylistic-set.html

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::appendTrueTypeFeature):
(WebCore::preparePlatformFont):

LayoutTests:

css3/font-feature-settings-stylistic-set-expected-mismatch.html: Added.
css3/font-feature-settings-stylistic-set.html: Added.
platform/win/TestExpectations:

6:17 AM WebKitGTK/2.30.x edited by Carlos Garcia Campos

(diff)

3:26 AM WebKitFlatpakSDK/PerfTools edited by Philippe Normand

(diff)

3:24 AM WebKitFlatpakSDK/PerfTools edited by Philippe Normand

(diff)

2:20 AM WebKitFlatpakSDK/PerfTools created by Philippe Normand

2:16 AM WebKitFlatpakSDK edited by Philippe Normand

(diff)

12:18 AM Changeset in webkit [267140] by Philippe Normand

2 edits
3 adds in trunk/Tools

[Flatpak SDK] Cherry-pick Mesa use-after-free fixes
https://bugs.webkit.org/show_bug.cgi?id=216532

Reviewed by Žan Doberšek.

These patches are not in any stable Mesa release yet. The crash is happening on various
tests on both WPE and GTK test bots.

Upstream MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5789

buildstream/elements/sdk/mesa.bst:
buildstream/patches/mesa/0001-mesa-rename-_mesa_free_errors_data.patch: Added.
buildstream/patches/mesa/0002-mesa-add-bool-param-to-_mesa_free_context_data.patch: Added.
buildstream/patches/mesa/0003-mesa-st-release-debug_output-after-destroying-the-co.patch: Added.

12:10 AM Changeset in webkit [267139] by Philippe Normand

7 edits
9 deletes in trunk/Tools

[GStreamer] Update Flatpak SDK to 1.18.0
https://bugs.webkit.org/show_bug.cgi?id=216270

Reviewed by Žan Doberšek.

Update to GStreamer 1.18.0, removing the patches now being shipped in this release.

buildstream/elements/sdk/gst-libav.bst:
buildstream/elements/sdk/gst-plugins-bad.bst:
buildstream/elements/sdk/gst-plugins-base.bst:
buildstream/elements/sdk/gst-plugins-good.bst:
buildstream/elements/sdk/gst-plugins-ugly.bst:
buildstream/elements/sdk/gstreamer.bst:
buildstream/patches/gst-libav-stop-caching-codecs.patch: Removed.
buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Removed.
buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Removed.
buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch: Removed.
buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Removed.
buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Removed.
buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Removed.
buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Removed.
buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Removed.

12:08 AM Changeset in webkit [267138] by Philippe Normand

5 edits in trunk/Source/WebCore

[GStreamer][1.18] Regressions
https://bugs.webkit.org/show_bug.cgi?id=216558

Reviewed by Xabier Rodriguez-Calvar.

The most significant change here is the added support for video rendering stats caching.
This was caught by
imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html

platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:

(webKitGLVideoSinkGetProperty): Fix 1.18 version runtime check. 1.17 was the development version of 1.18.

platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const): Ditto.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createVideoSink): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::videoPlaybackQualityMetrics): Cache or reuse cached
statistics. Caching is required so that metrics queries performed after EOS still return
valid values.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Sep 15, 2020:

11:33 PM Changeset in webkit [267137] by commit-queue@webkit.org

9 edits in trunk/Source

REGRESSION(r266677): ASSERTION FAILED in PaintFrequencyTracker::end()
https://bugs.webkit.org/show_bug.cgi?id=216591
<rdar://problem/68635418>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-15
Reviewed by Simon Fraser.

Source/WebCore:

Make RenderLayer track the painting which is scheduled through
RenderingUpdateScheduler only. We can do this by (1) reseting Page::
m_renderingUpdateTimestamp at the end of Page::updateRendering() and (2)
making SinglePaintFrequencyTracking track the painting only if the
timestamp is not zero.

page/ChromeClient.h:

(WebCore::ChromeClient::timestampForPaintFrequencyTracking const): Deleted.

page/Page.cpp:

(WebCore::Page::updateRendering):

page/Page.h:

(WebCore::Page::renderingUpdateTimestamp const):
(WebCore::Page::lastRenderingUpdateTimestamp const): Deleted.

rendering/PaintFrequencyTracker.h:

(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects const):

Source/WebKit:

timestampForPaintFrequencyTracking() do not have to be in ChromeClient.
RenderLayer can access it through its page(). No need to special case
isSVGImageChromeClient() because we are going to track the painting that
goes through Page::updateRendering(). This means all the painting of the
SVG image RenderLayers will be tracked by the same timestamp. Currently
we do not support compositing inside the SVG image which means there is
only one RenderLayer per SVG image.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::timestampForPaintFrequencyTracking const): Deleted.

WebProcess/WebCoreSupport/WebChromeClient.h:

11:22 PM Changeset in webkit [267136] by commit-queue@webkit.org

4 edits in trunk

Fix lazy image load painting
https://bugs.webkit.org/show_bug.cgi?id=216554

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-15
Reviewed by Darin Adler.

Source/WebCore:

Fix lazy image load painting, when LoadImmediately was introduced, it correctly
triggered the immediate load but after finishing the load there was no transition
to the finished lazy load state, causing the logic in RenderImage::paint to not
paint the finished load. This was not detected before since most lazy load WPT tests are
not pixel tests but rather test correct load events etc. (image-loading-subpixel-clip.html
is an exception since it is a reftest).

Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html

loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

The test image-loading-subpixel-clip.html now passes.

TestExpectations:

11:07 PM Changeset in webkit [267135] by sbarati@apple.com

3 edits
1 add in trunk

JSImmutableButterfly::get needs to return jsDoubleNumber for double arrays
https://bugs.webkit.org/show_bug.cgi?id=216589
<rdar://problem/68061245>

Reviewed by Yusuke Suzuki.

JSTests:

stress/jsimmutablebutterfly-get-must-return-double-boxed-value.js: Added.

Source/JavaScriptCore:

We are using JSImmutableButterfly::get in AI to constant fold GetByVal,
but we were failing to always return a boxed double value for double loads.
We were calling jsNumber instead of jsDooubleNumber. This is in contrast to
the runtime, which always returns a double boxed value. This would lead AI
to disagree with the runtime, and miscompile code.

runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::get const):

9:43 PM Changeset in webkit [267134] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][FFC] 'display: flex' generates a flex container box that is block-level when placed in flow layout
https://bugs.webkit.org/show_bug.cgi?id=216596

Reviewed by Simon Fraser.

See https://www.w3.org/TR/css-flexbox-1/#flex-containers.

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isBlockLevelBox const):

9:33 PM Changeset in webkit [267133] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] Use isBlockBox() in Box::establishesBlockFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=216595

Reviewed by Simon Fraser.

Let's use the Box::isBlockBox() function (now that we have it) to check if a box establishes a new BFC (this matches spec language now).

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesBlockFormattingContext const):

9:23 PM Changeset in webkit [267132] by ysuzuki@apple.com

7 edits
5 adds in trunk

[JSC] Cache UDateTimePatternGenerator
https://bugs.webkit.org/show_bug.cgi?id=213454

Reviewed by Ross Kirsling.

JSTests:

microbenchmarks/date-to-locale-date-string.js: Added.
microbenchmarks/date-to-locale-string.js: Added.
microbenchmarks/date-to-locale-time-string.js: Added.

Source/JavaScriptCore:

ICU udatpg_open function is particularly slow. As a result, 80~% of time is used by this function when calling Date#toLocaleString.
We should have last-used cache in VM, which covers major cases like, "One locale (possibly default locale) is used and continuously
use toLocaleString with that locale".

This significantly improves toLocaleString / toLocaleDateString / toLocaleTimeString performance.

ToT Patched

date-to-locale-string 392.0092+-0.6811 ^{87.3196+-3.1598} definitely 4.4894x faster
date-to-locale-date-string 377.9117+-7.8701 ^{70.4155+-3.6661} definitely 5.3669x faster
date-to-locale-time-string 373.1970+-3.0142 ^{67.3790+-2.8952} definitely 5.5388x faster

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
runtime/IntlCache.cpp: Added.

(JSC::IntlCache::cacheSharedPatternGenerator):
(JSC::IntlCache::getBestDateTimePattern):

runtime/IntlCache.h: Added.

(JSC::IntlCache::getSharedPatternGenerator):

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::intlCache):

8:10 PM Changeset in webkit [267131] by Aditya Keerthi

5 edits in trunk/Source

[macOS] Date pickers should respect the document's color scheme
https://bugs.webkit.org/show_bug.cgi?id=216514
<rdar://problem/68889548>

Reviewed by Tim Horton.

Source/WebCore:

Added the useDarkAppearance property to DateTimeChooserParameters, which
is based on Document::useDarkAppearance and the associated element's
computed style.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

platform/DateTimeChooserParameters.h:

(WebCore::DateTimeChooserParameters::encode const):
(WebCore::DateTimeChooserParameters::decode):

Source/WebKit:

Use the appearance property of NSWindow to ensure the appearance of the
contained NSDatePicker matches the value encoded in DateTimeChooserParameters.

UIProcess/mac/WebDateTimePickerMac.mm:

(-[WKDateTimePicker initWithParams:inView:]):

7:53 PM Changeset in webkit [267130] by ddkilzer@apple.com

10 edits
5 adds
1 delete in trunk

WebKit should support building with clang ThreadSanitizer enabled
<https://webkit.org/b/216318>
<rdar://problem/31615729>

Reviewed by Darin Adler.

This patch doesn't attempt to resolve every potential false
positive, but makes it easy to build WebKit with TSan enabled.

Makefile.shared:
Update to work with make [args] TSAN=YES.

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
Add ThreadSanitizerSupport.h to the project.

wtf/Compiler.h:
Define TSAN_ENABLED and SUPPRESS_TSAN macros.

wtf/Locker.h:

(WTF::Locker::~Locker):
(WTF::Locker::unlockEarly):
(WTF::Locker::operator=):
(WTF::Locker::lock):

Instrument lock/unlock methods for ThreadSanitizer.

wtf/ThreadSanitizerSupport.h: Add.

(AnnotateHappensBefore):
(AnnotateHappensAfter):

Declare TSan runtime functions needed to annotate WTF::Locker.

(TSAN_ANNOTATE_HAPPENS_BEFORE):
(TSAN_ANNOTATE_HAPPENS_AFTER):

Define macros used to call TSan runtime functions if TSan is enabled.

Tools:

Scripts/set-webkit-configuration:
Add support for --[no-]tsan switches.
Scripts/webkitdirs.pm:

(determineTSanIsEnabled):
(tsanIsEnabled):
(XcodeOptions):
(generateBuildSystemFromCMakeProject):

Add support for building with TSan enabled.

asan/asan.xcconfig: Rename to sanitizer/asan.xcconfig.
sanitizer/asan.xcconfig: Rename from asan/asan.xcconfig.
Extract common variables to sanitizer.xcconfig.
sanitizer/sanitizer.xcconfig: Add.
Extract common variables from asan.xcconfig.
sanitizer/tsan.xcconfig: Add.
Add support for TSan.

7:42 PM Changeset in webkit [267129] by Karl Rackler

2 edits in trunk/LayoutTests

Change test expectation description
rdar://68957822

Unreviewed test gardening.

platform/mac/TestExpectationsRosetta:

7:36 PM Changeset in webkit [267128] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION: [ BigSur wk2 rosetta ] compositing/contents-scale/hidpi-compositing-layer-positioned-on-scaled-context.html is a flaky failure
rdar://68957822

Unreviewed test gardening.

platform/mac/TestExpectationsRosetta:

7:21 PM Changeset in webkit [267127] by Hector Lopez

2 edits in trunk/LayoutTests

[ BigSur+ ] webrtc/captureCanvas-webrtc-software-h264-high.html is a constant failure/timeout
<rdar://68957215>

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

6:37 PM Changeset in webkit [267126] by ysuzuki@apple.com

3 edits
1 move
1 delete in trunk/Source/WebCore

Delete LocaleToScriptMappingICU.cpp since it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=216592

Reviewed by Myles C. Maxfield.

All ports are using LocaleToScriptMappingDefault.cpp and nobody is using / building LocaleToScriptMappingICU.cpp.
Let's remove it and rename LocaleToScriptMappingDefault.cpp to LocaleToScriptMapping.cpp

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
platform/text/LocaleToScriptMapping.cpp: Renamed from Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp.
platform/text/LocaleToScriptMappingICU.cpp: Removed.

6:17 PM Changeset in webkit [267125] by commit-queue@webkit.org

3 edits
1 add in trunk

Check whether the iterator is callable in spread
https://bugs.webkit.org/show_bug.cgi?id=215974

Patch by HyeockJin Kim <kherootz@gmail.com> on 2020-09-15
Reviewed by Darin Adler.

JSTests:

stress/spread-array-iterator.js: Added.

(shouldThrowTypeError):
(shouldThrowExactly):
(f):
(C):

Source/JavaScriptCore:

builtins/IteratorHelpers.js:

(performIteration):

6:07 PM Changeset in webkit [267124] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html: Correction for test expectations
<rdar://68947198>

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations: to include wk1

5:57 PM Changeset in webkit [267123] by commit-queue@webkit.org

14 edits in trunk

Move local storage sync SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216581

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Geoffrey Garen.

Source/WebKit:

This move is needed for https://bugs.webkit.org/show_bug.cgi?id=216041
We no longer need to sync the legacy private browsing storage because it is no longer used by WebKitTestRunner. Thank goodness.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::clearLegacyPrivateBrowsingLocalStorage): Deleted.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/C/WKContext.cpp:

(WKContextSyncLocalStorage): Deleted.
(WKContextClearLegacyPrivateBrowsingLocalStorage): Deleted.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSyncLocalStorage):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::syncLocalStorage): Deleted.
(WebKit::WebProcessPool::clearLegacyPrivateBrowsingLocalStorage): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::syncLocalStorage):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::clearLocalStorage):
(WTR::TestController::syncLocalStorage):

5:54 PM Changeset in webkit [267122] by commit-queue@webkit.org

11 edits in trunk

Move service worker testing timeout setting from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216578

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Geoffrey Garen.

Source/WebKit:

This is needed for https://bugs.webkit.org/show_bug.cgi?id=216041

UIProcess/API/C/WKContext.cpp:

(WKContextSetServiceWorkerFetchTimeoutForTesting): Deleted.
(WKContextResetServiceWorkerFetchTimeoutForTesting): Deleted.

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetServiceWorkerFetchTimeoutForTesting):
(WKWebsiteDataStoreResetServiceWorkerFetchTimeoutForTesting):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setServiceWorkerTimeoutForTesting): Deleted.
(WebKit::WebProcessPool::resetServiceWorkerTimeoutForTesting): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setServiceWorkerTimeoutForTesting):
(WebKit::WebsiteDataStore::resetServiceWorkerTimeoutForTesting):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setServiceWorkerFetchTimeoutForTesting):

5:50 PM Changeset in webkit [267121] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS wk2 ] media/media-continues-playing-after-replace-source.html is a flaky failure
<rdar://68952824>

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac-wk2/TestExpectations:

5:22 PM Changeset in webkit [267120] by Fujii Hironori

11 edits
2 moves in trunk/Tools

[TestRunnerShared] Add a new class UIScriptControllerCommon to implement UIScriptController::windowIsKey and UIScriptController::setWindowIsKey
https://bugs.webkit.org/show_bug.cgi?id=216469

Reviewed by Darin Adler.

Even though UIScriptController class is defined in
TestRunnerShared, UIScriptController::windowIsKey and
UIScriptController::setWindowIsKey methods were defined in the
client modules DRT and WTR. I'd like to make TestRunnerShared a
stand-alone library which doesn't depend on DRT and WTR (Bug
216465).

Add a new class UIScriptControllerCommon to host the common
methods by renaming UIScriptController.cpp.

DumpRenderTree/CMakeLists.txt:
TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::windowIsKey const):
(WTR::UIScriptController::setWindowIsKey):

WebKitTestRunner/CMakeLists.txt:
WebKitTestRunner/UIScriptControllerCommon.cpp: Renamed from Tools/WebKitTestRunner/UIScriptController.cpp.

(WTR::UIScriptControllerCommon::windowIsKey const):
(WTR::UIScriptControllerCommon::setWindowIsKey):

WebKitTestRunner/UIScriptControllerCommon.h: Added.

(WTR::UIScriptControllerCommon::UIScriptControllerCommon):

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::UIScriptControllerCocoa):

WebKitTestRunner/gtk/UIScriptControllerGtk.h:

(WTR::UIScriptControllerGtk::UIScriptControllerGtk):

WebKitTestRunner/win/UIScriptControllerWin.h:

(WTR::UIScriptControllerWin::UIScriptControllerWin):

WebKitTestRunner/wpe/UIScriptControllerWPE.h:

5:15 PM Changeset in webkit [267119] by Alan Coon

17 edits in branches/safari-610.2.5.1-branch

Cherry-pick r266121. rdar://problem/68949249

[macOS] Update audio arbitration manager when audio transport changes
https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated AudioRoutingArbitration API test.

platform/audio/AudioSession.cpp: (WebCore::AudioSession::audioOutputDeviceChanged): Add empty method. (WebCore::setIsPlayingToBluetoothOverride): Ditto.
platform/audio/AudioSession.h:

platform/audio/cocoa/MediaSessionManagerCocoa.h:
platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.

platform/audio/mac/AudioSessionMac.mm: (WebCore::defaultDeviceTransportIsBluetooth): New. (WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth if bluetooth transport has changed since the last arbitration update. (WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth transport for testing. (WebCore::AudioSession::setCategory): Update routing arbitration if audio session category or bluetooth transport changes.

testing/Internals.cpp: (WebCore::Internals::setIsPlayingToBluetoothOverride):
testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _audioRoutingArbitrationUpdateTime]):

UIProcess/Media/AudioSessionRoutingArbitratorProxy.h: (WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):

UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm: (WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help debugging when the test fails.
TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:13 PM Changeset in webkit [267118] by Alan Coon

8 edits in branches/safari-610.2.5.1-branch/Source

Versioning.

WebKit-7610.2.5.1.2

5:09 PM Changeset in webkit [267117] by Alan Coon

17 edits in branches/safari-610-branch

Cherry-pick r266121. rdar://problem/68949237

[macOS] Update audio arbitration manager when audio transport changes
https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated AudioRoutingArbitration API test.

platform/audio/AudioSession.cpp: (WebCore::AudioSession::audioOutputDeviceChanged): Add empty method. (WebCore::setIsPlayingToBluetoothOverride): Ditto.
platform/audio/AudioSession.h:

platform/audio/cocoa/MediaSessionManagerCocoa.h:
platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.

platform/audio/mac/AudioSessionMac.mm: (WebCore::defaultDeviceTransportIsBluetooth): New. (WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth if bluetooth transport has changed since the last arbitration update. (WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth transport for testing. (WebCore::AudioSession::setCategory): Update routing arbitration if audio session category or bluetooth transport changes.

testing/Internals.cpp: (WebCore::Internals::setIsPlayingToBluetoothOverride):
testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _audioRoutingArbitrationUpdateTime]):

UIProcess/Media/AudioSessionRoutingArbitratorProxy.h: (WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):

UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm: (WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help debugging when the test fails.
TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:06 PM Changeset in webkit [267116] by mmaxfield@apple.com

4 edits in trunk/Source

[macOS Big Sur] CGFontRenderingGetFontSmoothingDisabled() is no longer useful
https://bugs.webkit.org/show_bug.cgi?id=216588
<rdar://problem/68657748>

Reviewed by Simon Fraser.

Source/WebCore:

No new tests because there is no behavior change.

platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::FontCascade::isSubpixelAntialiasingAvailable):

Source/WTF:

We can eliminate WebKit's use of it to eventually phase it out entirely.

wtf/PlatformHave.h:

4:51 PM Changeset in webkit [267115] by ysuzuki@apple.com

2 edits in trunk/JSTests

Unreviewed, skip construct-return-early-from-infinite-loop-for-fuzzer.js when JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=216406

We are not supporting returnEarlyFromInfiniteLoopsForFuzzing option for CLoop.

stress/construct-return-early-from-infinite-loop-for-fuzzer.js:

(vm.useJIT):

4:46 PM Changeset in webkit [267114] by Tadeu Zagallo

3 edits
1 add in trunk

Object allocation sinking forgets escaped nodes when structure changes
https://bugs.webkit.org/show_bug.cgi?id=216214
<rdar://problem/68518460>

Reviewed by Saam Barati.

JSTests:

stress/allocation-sinking-changing-structures.js: Added.

(main.v4.get v4):
(main):

Source/JavaScriptCore:

Consider the following program:

bb0:

a: NewObject
b: CreateActivation()
_: Branch(bb2, bb1)

bb1:

_: PutByOffset(a, 'x', 42)
_: PutStrucute(a, {x: 0})
_: Branch(bb2, bb1)

bb2:

_: CheckStructure(a, {x: 0})
_: PutClosureVar(b, 0, Kill:a)
_: Branch(bb3, bb2)

bb3:

c: GetClosureVar(b, 0)
_: PutByOffset(global, 'y', c)
_: Return

Due to the order we visit the program, we'll visit bb2 before bb1. The first time we visit bb2, heapAtHead will be:

#@a: ObjectAllocation({})
#@b: ActivationAllocation()
@a => #@a
@b => #@b

Now CheckStructure would always fail, so it will escape @a and heapAtTail will be:

#@a: EscapedAllocation()
#@b: ActivationAllocation()
@a => #@a
@b => #@b

And after pruning:

#@b: ActivationAllocation()
@b => #@b

Now, we'll visit bb3 and then bb1. When we visit bb1 we'll set the structure {x: 0} for the #@a and eventually visit bb2 again. This time around CheckStructure will no longer escape @a, since the allocation has the right structure, and heapAtTail will be:

#@a: ObjectAllocation({x: 0})
#@b: ActivationAllocation(0: #@a)
@b => #@b

However, we now have to merge into bb3, which has heapAtHead:

#@b: ActivationAllocation()
@b => #@b

Since we can't add the extra field to the activation, we'll end up escaping @a at the edge and therefore pruning #@b, which will leave the heap for bb3 unchanged.
That's a problem, since PutClosureVar didn't see the escaped object, but GetClosureVar thinks it's escaped. The materialization for @a will be placed after the
PutClosureVar, at end of bb2, when the node is already dead. When computing the SSA defs, the PutByOffset at bb3 will then see @a (which at this point will be a
PhantomNewObject) instead of its materialization.

The issue happens because we don't allow allocations to add extra fields while merging, but we do allow adding new structures. This results in different decisions
being made about what escapes in CheckStructure and MultiGetByOffset. To avoid this problem, we track two sets of structures: structures and structuresForMaterialization.
The first is used for checks and should never grow while the second is used for materialization and is allowed to grow.

dfg/DFGObjectAllocationSinkingPhase.cpp:

4:38 PM Changeset in webkit [267113] by sbarati@apple.com

7 edits
1 add in trunk

CustomFunctionEquivalence PropertyCondition needs to check if the structure has the property
https://bugs.webkit.org/show_bug.cgi?id=216575
<rdar://problem/68286930>

Reviewed by Yusuke Suzuki.

JSTests:

stress/has-static-property-property-condition-needs-to-check-if-structure-has-property.js: Added.

(foo):

Source/JavaScriptCore:

The CustomFunctionEquivalence PropertyCondition would only return false to
isStillValidAssumingImpurePropertyWatchpoint if the Structure's static
property table was reified or if the static property table did not contain the
property. However, this missed the obvious case of where we store to this
property in normal object storage without reifying the static property table.
The fix here is simple: we first check if the Structure's property table
has this property, and if so, return false.

This patch also renames CustomFunctionEquivalence to HasStaticProperty to
better capture what we're doing.

bytecode/ObjectPropertyCondition.h:

(JSC::ObjectPropertyCondition::hasStaticProperty):
(JSC::ObjectPropertyCondition::customFunctionEquivalence): Deleted.

bytecode/ObjectPropertyConditionSet.cpp:

(JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition const):
(JSC::ObjectPropertyConditionSet::slotBaseCondition const):
(JSC::generateConditionsForPrototypePropertyHitCustom):

bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::dumpInContext const):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
(JSC::PropertyCondition::isStillValid const):
(JSC::PropertyCondition::isWatchableWhenValid const):
(WTF::printInternal):

bytecode/PropertyCondition.h:

(JSC::PropertyCondition::hasStaticProperty):
(JSC::PropertyCondition::hash const):
(JSC::PropertyCondition::operator== const):
(JSC::PropertyCondition::customFunctionEquivalence): Deleted.

tools/JSDollarVM.cpp:

(JSC::functionCreateStaticCustomValue):
(JSC::JSDollarVM::finishCreation):

4:34 PM Changeset in webkit [267112] by mmaxfield@apple.com

6 edits in trunk/Source/WebCore

[Apple Win] Migrate the first part of SimpleFontData{CG}Win.cpp to FontCoreText.cpp
https://bugs.webkit.org/show_bug.cgi?id=216525

Reviewed by Dean Jackson.

This migrates:

Font::isProbablyOnlyUsedToRenderIcons()
Font::platformSupportsCodePoint()
Font::determinePitch()
Font::platformBoundsForGlyph()
Font::platformPathForGlyph()
Font::applyTransforms()

from the old Windows CG codepath to the Core Text codepath. This patch unifies these functions
between the Apple Windows port and the macOS / iOS ports.

Covered by existing tests.

platform/graphics/Font.cpp:

(WebCore::Font::variantCapsSupportsCharacterForSynthesis const):
(WebCore::Font::platformSupportsCodePoint const): Deleted.

platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::platformWidthForGlyph const): Move this up into the #if !PLATFORM(WIN) section.
We don't want to migrate this one just yet because it causes a significant number of test failures,
which require more investigation.
(WebCore::Font::determinePitch):
(WebCore::Font::isProbablyOnlyUsedToRenderIcons const):

platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::Font::platformBoundsForGlyph const): Deleted.
(WebCore::Font::platformPathForGlyph const): Deleted.

platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::Font::determinePitch): The WinCairo port is the only port still using the non-CG Windows
implementation of this function, so we can just move it directly into the CairoWin-specific file.

platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::Font::determinePitch): Deleted.

4:33 PM Changeset in webkit [267111] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION (r266634): [ BigSur wk2 ] fast/selectors/text-field-selection-window-inactive-stroke-color.html is a flaky image failure
rdar://68947260

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

4:21 PM Changeset in webkit [267110] by Peng Liu

2 edits in trunk/Source/WebKit

REGRESSION (r267053): ASSERTION FAILED: videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient in [WKFullScreenWindowController _completedExitFullScreen]
https://bugs.webkit.org/show_bug.cgi?id=216571

Reviewed by Jer Noble.

It is possible that an element exits fullscreen before it completely enters
fullscreen. In that case, the client of VideoFullscreenManagerProxy is nullptr.

No new tests, fixing an assertion failure when running
TestWebKitAPI.WKWebViewCloseAllMediaPresentations.ElementFullscreen.

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _completedExitFullScreen]):

4:08 PM Changeset in webkit [267109] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html
<rdar://68947198>

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac-wk2/TestExpectations:

3:56 PM Changeset in webkit [267108] by ysuzuki@apple.com

6 edits
1 add in trunk

[JSC] Apply Intl.DateTimeFormat hour-cycle correctly when timeStyle is used
https://bugs.webkit.org/show_bug.cgi?id=216521

Reviewed by Ross Kirsling.

JSTests:

JSTests/stress/intl-date-time-format-date-time-style-hour-cycle.js result is now matching against V8 and SpiderMonkey,
and this new behavior is more reasonable.

stress/intl-date-time-format-date-time-style-hour-cycle.js:

(shouldBe.o.format):
(shouldBe):

stress/intl-datetimeformat-hour-cycle.js: Added.

(shouldBe):
(throw.new.Error):

test262/expectations.yaml:

Source/JavaScriptCore:

When specifying timeStyle in Intl.DateTimeFormat, we need to check that the generated format also follows to the hourCycle / hour12 options
specified in the constructor. Because dayPeriod can be included automatically, just replacing symbols after generating a pattern can dump strange result.
For example, the generated one is something like "02:12:47 PM Coordinated Universal Time". And we adjust the pattern to make it "14:12:47 PM Coordinated Universal Time"
when hourCycle H23 / H24 is specified. But this looks strange since dayPeriod "PM" should not exist when using H23 / H24.

In this patch, we revise our hour-cycle handling in Intl.DateTimeFormat. We align our behavior to SpiderMonkey's one[1] rather than the spec's one: when hour12 is specified,
we will just use 'H' or 'h' skeleton and do not enforce hour-cycle after generating pattern in hour12 case. If hour12 is not specified, then we use 'h' or 'H' skeleton
symbols based on hour-cycle, and later we modify the pattern based on hour-cycle. If both are not offered, we use 'j' which allows ICU to pick preferable one.
This is slightly different behavior to the spec (hcDefault etc.) but the spec's behavior can cause a bit surprising result[2,3], and SpiderMonkey like behavior will be
integrated into the spec eventually[4].

[1]: https://github.com/tc39/ecma402/issues/402#issuecomment-623628320
[2]: https://github.com/tc39/ecma402/issues/402
[3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1045791
[4]: https://github.com/tc39/ecma402/pull/436

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::parseHourCycle):
(JSC::IntlDateTimeFormat::hourCycleFromPattern):
(JSC::IntlDateTimeFormat::replaceHourCycleInSkeleton):
(JSC::IntlDateTimeFormat::replaceHourCycleInPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::hourCycleString):
(JSC::IntlDateTimeFormat::resolvedOptions const):
(JSC::IntlDateTimeFormat::createDateIntervalFormatIfNecessary):

runtime/IntlDateTimeFormat.h:

3:37 PM Changeset in webkit [267107] by Chris Dumez

5 edits in trunk

ScriptProcessorNode should throw when trying to change its channel count or channel count mode
https://bugs.webkit.org/show_bug.cgi?id=216583

Reviewed by Geoffrey Garen.

Source/WebCore:

ScriptProcessorNode should throw when trying to change its channel count or channel count mode:

No new tests, rebaselined existing test.

Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::setChannelCount):
(WebCore::ScriptProcessorNode::setChannelCountMode):

Modules/webaudio/ScriptProcessorNode.h:

LayoutTests:

Rebaseline test now that more checks are passing.

webaudio/dom-exceptions-expected.txt:

3:25 PM Changeset in webkit [267106] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

CRASH: Exception thrown from -[AVContentKeyRequest makeStreamingContentKeyRequestDataForApp:contentIdentifier:options:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=216580
<rdar://problem/68866834>

Reviewed by Eric Carlson.

Protect against undocumented exceptions thrown from AVContentKeySession (and related) APIs by wrapping in @try/@catch blocks and firing
the correct failure callbacks if an exception is encountered.

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):

3:05 PM Changeset in webkit [267105] by Chris Dumez

1 edit
2 adds in trunk/LayoutTests

Import webaudio/dom-exceptions.html layout test from Blink
https://bugs.webkit.org/show_bug.cgi?id=216579

Reviewed by Geoffrey Garen.

Import webaudio/dom-exceptions.html layout test from Blink to extend test coverage.

webaudio/dom-exceptions-expected.txt: Added.
webaudio/dom-exceptions.html: Added.

3:04 PM Changeset in webkit [267104] by Alan Coon

1 copy in tags/Safari-610.1.28.1.9

Tag Safari-610.1.28.1.9.

3:02 PM Changeset in webkit [267103] by Alan Coon

2 edits in branches/safari-610.1.28.1-branch/Source/WebKit

Cherry-pick r265930. rdar://problem/67364262

Fix null pointer crashes in network process after r265835

https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:58 PM Changeset in webkit [267102] by ysuzuki@apple.com

4 edits in trunk

[JSC] Intl.Collator should take collation option
https://bugs.webkit.org/show_bug.cgi?id=216529

Reviewed by Ross Kirsling.

JSTests:

stress/intl-collator-co-extension.js:

(shouldThrow):

Source/JavaScriptCore:

This patch adds "collation" option to Intl.Collator. We are already getting consensus[1], and will be integrated into the spec.
Previously, passing "collation" is only available through "-u-co-" unicode extension in the passed locale. The proposal exposes
collation option as an option to Intl.Collator so that we can set it easily.
"collation" is used only when "usage" is "sort". "search" usage will filter out collation options since "search" itself is one of
the "collation" option.

[1]: https://github.com/tc39/ecma402/pull/459

runtime/IntlCollator.cpp:

(JSC::IntlCollator::sortLocaleData):
(JSC::IntlCollator::initializeCollator):

2:43 PM Changeset in webkit [267101] by Fujii Hironori

2 edits in trunk/Source/WebCore

preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command
https://bugs.webkit.org/show_bug.cgi?id=216527

Reviewed by Darin Adler.

bindings/scripts/preprocessor.pm:

(applyPreprocessor): Use shellwords() to split the $preprocessor.
Use Cygwin Perl's builtin functions instead of spawning process.

2:41 PM Changeset in webkit [267100] by Hector Lopez

3 edits in trunk/LayoutTests

[ macOS iOS ] imported/w3c/web-platform-tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216292

Unreviewed test gardening!.

platform/mac-wk1/TestExpectations: adjustment for Debug
platform/mac-wk2/TestExpectations: adjustment for Debug

2:28 PM Changeset in webkit [267099] by Alan Coon

8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.9

1:59 PM Changeset in webkit [267098] by weinig@apple.com

22 edits in trunk

Remove runtime setting for enabling/disabling the fetch API
https://bugs.webkit.org/show_bug.cgi?id=216519

Reviewed by Alex Christensen.

Remove runtime setting for enabling/disabling the fetch API. There is no
reason one needs to disable it now and it has been on by default for
a long enough time.

Source/WebCore:

Modules/fetch/FetchBody.idl:
Modules/fetch/FetchHeaders.idl:
Modules/fetch/FetchRequest.idl:
Modules/fetch/FetchResponse.idl:
Modules/fetch/WindowOrWorkerGlobalScopeFetch.idl:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setFetchAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::fetchAPIEnabled const): Deleted.

Source/WebKit:

Also cleans up WKPreferencesRefPrivate.h/WKPreferences.cpp to move all the obsolete
preferences to the bottom with a comment about removing them when possible.

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesResetTestRunnerOverrides):
(WKPreferencesSetPrivateBrowsingEnabled):
(WKPreferencesGetPrivateBrowsingEnabled):
(WKPreferencesSetIgnoreViewportScalingConstraints):
(WKPreferencesGetIgnoreViewportScalingConstraints):
(WKPreferencesSetWebRTCLegacyAPIEnabled):
(WKPreferencesGetWebRTCLegacyAPIEnabled):
(WKPreferencesSetNewBlockInsideInlineModelEnabled):
(WKPreferencesGetNewBlockInsideInlineModelEnabled):
(WKPreferencesSetLongMousePressEnabled):
(WKPreferencesGetLongMousePressEnabled):
(WKPreferencesSetAntialiasedFontDilationEnabled):
(WKPreferencesGetAntialiasedFontDilationEnabled):
(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):
(WKPreferencesSetApplicationChromeModeEnabled):
(WKPreferencesGetApplicationChromeModeEnabled):
(WKPreferencesSetInspectorUsesWebKitUserInterface):
(WKPreferencesGetInspectorUsesWebKitUserInterface):
(WKPreferencesSetFetchAPIEnabled):
(WKPreferencesGetFetchAPIEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setFetchAPIEnabled:]):
(-[WebPreferences fetchAPIEnabled]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::fetchAPIEnabled):
(WebPreferences::setFetchAPIEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/TestRunner.h:
DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

1:44 PM Changeset in webkit [267097] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed, fix the build with recent SDKs.
rdar://68939059

platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::FontCascade::isSubpixelAntialiasingAvailable):

1:04 PM Changeset in webkit [267096] by Jonathan Bedard

2 edits
2 adds in trunk/Tools

[webkitscmpy] Add Contributor object
https://bugs.webkit.org/show_bug.cgi?id=216402

<rdar://problem/68702680>

Reviewed by Dewei Zhu.

Scripts/libraries/webkitscmpy/webkitscmpy/init.py:
Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py: Added.

(Contributor): Object mapping a contributor by name to their associated email addresses.
(Contributor.clear): Clear the in-memory cache of Contributor objects.
(Contributor.from_scm_log): Find or generate a Contributor object given a commit log line from
an SCM tool.
(Contributor.init):
(Contributor.email): Return a single email for a Contributor.
(Contributor.repr):
(Contributor.hash):
(Contributor.cmp):
(Contributor.eq):
(Contributor.ne):
(Contributor.lt):
(Contributor.le):
(Contributor.gt):
(Contributor.ge):

Scripts/libraries/webkitscmpy/webkitscmpy/test/contributor_unittest.py: Added.

(TestContributor):
(TestContributor.test_git_log):
(TestContributor.test_svn_log):
(TestContributor.test_svn_patch_by_log):
(TestContributor.test_author_mapping):
(TestContributor.test_email_mapping):
(TestContributor.test_invalid_log):
(TestContributor.test_comparison):
(TestContributor.test_string_comparison):
(TestContributor.test_hash):
(TestContributor.test_sorting):

12:43 PM Changeset in webkit [267095] by weinig@apple.com

18 edits in trunk

Remove runtime setting for enabling/disabling custom elements
https://bugs.webkit.org/show_bug.cgi?id=216518

Reviewed by Tim Horton.

Remove runtime setting for enabling/disabling custom elements. There is no
reason one need to disable it now, and it has been on by default for
a long enough time.

Source/WebCore:

dom/CustomElementRegistry.idl:
dom/Document.cpp:

(WebCore::createUpgradeCandidateElement):

page/DOMWindow.idl:
page/Settings.yaml:

Source/WebKit:

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setCustomElementsEnabled:]):
(-[WebPreferences customElementsEnabled]):

WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::customElementsEnabled):
(WebPreferences::setCustomElementsEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

11:57 AM Changeset in webkit [267094] by Chris Dumez

3 edits in trunk/Source/WebCore

Improve thread-safety in ScriptProcessorNode implementation
https://bugs.webkit.org/show_bug.cgi?id=216555

Reviewed by Geoffrey Garen.

Improve thread-safety in ScriptProcessorNode implementation:

Use a Lock instead of a volatile bool to determine if the main thread is still busy firing the event.
Pass the doubleBufferIndex to the main thread by capturing it in the lambda instead of relying on a data member.

Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
(WebCore::ScriptProcessorNode::fireProcessEvent):

Modules/webaudio/ScriptProcessorNode.h:

11:49 AM Changeset in webkit [267093] by Jonathan Bedard

7 edits in trunk/Tools

[webkitscmpy] Add default_branch for local SCM repositories
https://bugs.webkit.org/show_bug.cgi?id=216422
<rdar://problem/68735897>

Reviewed by Dewei Zhu.

Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.default_branch): Query the local checkout for the default branch.
(Git):
(Git.branches): Strip "remotes/origin/" from branch names.

Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm.default_branch):

Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn.default_branch): The default svn branch is always 'trunk'.

Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit.test_branches):
(TestGit.test_tags):
(TestGit):
(TestGit.test_default_branch):

Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestSvn.test_tags):
(TestSvn):
(TestSvn.test_default_branch):

11:39 AM Changeset in webkit [267092] by Simon Fraser

4 edits in trunk

REGRESSION (r267002): ASSERTION FAILED:[ iOS wk2 Debug ] !HashTranslator::equal(KeyTraits::emptyValue(), key) on compositing/ios/overflow-scroll-update-overlap.html
https://bugs.webkit.org/show_bug.cgi?id=216520
<rdar://problem/68894931>

Reviewed by Tim Horton.

Source/WebKit:

Avoid hash lookups with zero nodeIDs.

WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::isRubberBandInProgress const):
(WebKit::RemoteScrollingCoordinator::isUserScrollInProgress const):
(WebKit::RemoteScrollingCoordinator::isScrollSnapInProgress const):

LayoutTests:

platform/ios-wk2/TestExpectations:

11:25 AM Changeset in webkit [267091] by achristensen@apple.com

14 edits in trunk

Move WKContextClearCachedCredentials SPI to WKWebsiteDataStoreClearCachedCredentials
https://bugs.webkit.org/show_bug.cgi?id=216513

Reviewed by Chris Dumez.

Source/WebKit:

The credentials are owned by session anyways.
This is needed for https://bugs.webkit.org/show_bug.cgi?id=216041

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::clearCachedCredentials):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/C/WKContext.cpp:

(WKContextClearCachedCredentials): Deleted.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreClearCachedCredentials):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearCachedCredentials):

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::clearCachedCredentials):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

11:07 AM Changeset in webkit [267090] by achristensen@apple.com

20 edits in trunk

Remove unused plumbing for setting whether the storage access API is enabled
https://bugs.webkit.org/show_bug.cgi?id=216516

Reviewed by Youenn Fablet.

Source/WebCore:

Sending a boolean from the process pool to the network process has been superceded by a preference in WebPreferences.yaml.
The boolean sent to the network process was not even used any more.

platform/network/NetworkStorageSession.h:
platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setStorageAccessAPIEnabled): Deleted.

Source/WebKit:

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::setStorageAccessAPIEnabled): Deleted.

UIProcess/API/C/WKContext.cpp:

(WKContextSetStorageAccessAPIEnabled): Deleted.

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetStorageAccessAPIEnabled): Deleted.

UIProcess/API/C/WKCookieManager.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _isStorageAccessAPIEnabled]): Deleted.
(-[WKProcessPool _setStorageAccessAPIEnabled:]): Deleted.

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setStorageAccessAPIEnabled): Deleted.

UIProcess/WebProcessPool.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

10:04 AM Changeset in webkit [267089] by weinig@apple.com

10 edits
2 copies
1 add
6 deletes in trunk/Source/WebCore

[WebIDL] Update Fetch IDLs to use WindowOrWorkerGlobalScope partial mixin
https://bugs.webkit.org/show_bug.cgi?id=216524

Reviewed by Darin Adler.

Move global fetch() function definition from DOMWindowFetch.idl & WorkerGlobalScopeFetch.idl
to single WindowOrWorkerGlobalScopeFetch.idl, matching the spec.

Also cleanup some comments in other Fetch related IDLs.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/fetch/DOMWindowFetch.cpp: Removed.
Modules/fetch/DOMWindowFetch.h: Removed.
Modules/fetch/DOMWindowFetch.idl: Removed.
Modules/fetch/FetchRequest.idl:
Modules/fetch/FetchRequestInit.idl:
Modules/fetch/FetchResponse.idl:
Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp: Added.

(WebCore::WindowOrWorkerGlobalScopeFetch::fetch):

Modules/fetch/WindowOrWorkerGlobalScopeFetch.h: Added.
Modules/fetch/WindowOrWorkerGlobalScopeFetch.idl: Added.
Modules/fetch/WorkerGlobalScopeFetch.cpp: Removed.
Modules/fetch/WorkerGlobalScopeFetch.h: Removed.
Modules/fetch/WorkerGlobalScopeFetch.idl: Removed.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

9:28 AM Changeset in webkit [267088] by commit-queue@webkit.org

14 edits in trunk

Move WebSocket TLS bypass SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216509

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Youenn Fablet.

Source/WebKit:

After https://bugs.webkit.org/show_bug.cgi?id=216041 we will be unable to determine which WebsiteDataStore's
NetworkProcess to add the TLS bypass to, so we need to move the SPI to the WebsiteDataStore object. This breaks
off a piece of that large change into a small, easy-to-review change.

UIProcess/API/C/WKContext.cpp:

(WKContextSetAllowsAnySSLCertificateForWebSocketTesting): Deleted.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetAllowsAnySSLCertificateForWebSocketTesting):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _allowAnyTLSCertificateForWebSocketTesting]): Deleted.

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setAllowsAnySSLCertificateForWebSocket): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setAllowsAnySSLCertificateForWebSocket):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::setAllowsAnySSLCertificate):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::setAllowsAnySSLCertificate):

9:16 AM Changeset in webkit [267087] by Alan Bujtas

3 edits
1 add in trunk/Source/WebCore

[LFC] Move Layout::Rect to a dedicated file
https://bugs.webkit.org/show_bug.cgi?id=216553

Reviewed by Antti Koivisto.

WebCore.xcodeproj/project.pbxproj:
layout/layouttree/LayoutBoxGeometry.h:

(WebCore::Layout::Rect::expandHorizontally): Deleted.
(WebCore::Layout::Rect::expandVertically): Deleted.
(WebCore::Layout::Rect::intersects const): Deleted.
(WebCore::Layout::Rect::invalidateTop): Deleted.
(WebCore::Layout::Rect::invalidateLeft): Deleted.
(WebCore::Layout::Rect::invalidateWidth): Deleted.
(WebCore::Layout::Rect::invalidateHeight): Deleted.
(WebCore::Layout::Rect::hasValidPosition const): Deleted.
(WebCore::Layout::Rect::hasValidSize const): Deleted.
(WebCore::Layout::Rect::hasValidGeometry const): Deleted.
(WebCore::Layout::Rect::Rect): Deleted.
(WebCore::Layout::Rect::invalidatePosition): Deleted.
(WebCore::Layout::Rect::setHasValidPosition): Deleted.
(WebCore::Layout::Rect::setHasValidSize): Deleted.
(WebCore::Layout::Rect::top const): Deleted.
(WebCore::Layout::Rect::left const): Deleted.
(WebCore::Layout::Rect::bottom const): Deleted.
(WebCore::Layout::Rect::right const): Deleted.
(WebCore::Layout::Rect::topLeft const): Deleted.
(WebCore::Layout::Rect::bottomRight const): Deleted.
(WebCore::Layout::Rect::size const): Deleted.
(WebCore::Layout::Rect::width const): Deleted.
(WebCore::Layout::Rect::height const): Deleted.
(WebCore::Layout::Rect::setTopLeft): Deleted.
(WebCore::Layout::Rect::setTop): Deleted.
(WebCore::Layout::Rect::setLeft): Deleted.
(WebCore::Layout::Rect::setWidth): Deleted.
(WebCore::Layout::Rect::setHeight): Deleted.
(WebCore::Layout::Rect::setSize): Deleted.
(WebCore::Layout::Rect::shiftLeftTo): Deleted.
(WebCore::Layout::Rect::shiftRightTo): Deleted.
(WebCore::Layout::Rect::shiftTopTo): Deleted.
(WebCore::Layout::Rect::shiftBottomTo): Deleted.
(WebCore::Layout::Rect::moveHorizontally): Deleted.
(WebCore::Layout::Rect::moveVertically): Deleted.
(WebCore::Layout::Rect::expand): Deleted.
(WebCore::Layout::Rect::clone const): Deleted.
(WebCore::Layout::Rect::operator LayoutRect const): Deleted.

layout/layouttree/LayoutGeometryRect.h: Added.

(WebCore::Layout::Rect::expandHorizontally):
(WebCore::Layout::Rect::expandVertically):
(WebCore::Layout::Rect::intersects const):
(WebCore::Layout::Rect::invalidateTop):
(WebCore::Layout::Rect::invalidateLeft):
(WebCore::Layout::Rect::invalidateWidth):
(WebCore::Layout::Rect::invalidateHeight):
(WebCore::Layout::Rect::hasValidPosition const):
(WebCore::Layout::Rect::hasValidSize const):
(WebCore::Layout::Rect::hasValidGeometry const):
(WebCore::Layout::Rect::Rect):
(WebCore::Layout::Rect::invalidatePosition):
(WebCore::Layout::Rect::setHasValidPosition):
(WebCore::Layout::Rect::setHasValidSize):
(WebCore::Layout::Rect::top const):
(WebCore::Layout::Rect::left const):
(WebCore::Layout::Rect::bottom const):
(WebCore::Layout::Rect::right const):
(WebCore::Layout::Rect::topLeft const):
(WebCore::Layout::Rect::bottomRight const):
(WebCore::Layout::Rect::size const):
(WebCore::Layout::Rect::width const):
(WebCore::Layout::Rect::height const):
(WebCore::Layout::Rect::setTopLeft):
(WebCore::Layout::Rect::setTop):
(WebCore::Layout::Rect::setLeft):
(WebCore::Layout::Rect::setWidth):
(WebCore::Layout::Rect::setHeight):
(WebCore::Layout::Rect::setSize):
(WebCore::Layout::Rect::shiftLeftTo):
(WebCore::Layout::Rect::shiftRightTo):
(WebCore::Layout::Rect::shiftTopTo):
(WebCore::Layout::Rect::shiftBottomTo):
(WebCore::Layout::Rect::moveHorizontally):
(WebCore::Layout::Rect::moveVertically):
(WebCore::Layout::Rect::expand):
(WebCore::Layout::Rect::clone const):
(WebCore::Layout::Rect::operator LayoutRect const):

7:55 AM Changeset in webkit [267086] by svillar@igalia.com

4 edits in trunk

[css-flexbox] Indefinite flex-basis percentage should cause height to be ignored
https://bugs.webkit.org/show_bug.cgi?id=210077

Reviewed by Darin Adler.

Source/WebCore:

If flex-basis is a percentage of an indefinite height we should ignore
what height specifies and treat it and as height:auto.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::cacheChildMainSize): Cache the intrinsic height of the child when
flex-basis is a percentage of an indefinite length.

LayoutTests:

TestExpectations: Removed flex-basis-010.html which is passing now.

7:35 AM Changeset in webkit [267085] by Aditya Keerthi

2 edits in trunk/Source/WebKit

[macOS] Update date picker appearance to match system date pickers
https://bugs.webkit.org/show_bug.cgi?id=216517
<rdar://problem/68890678>

Reviewed by Wenson Hsieh.

System date pickers in macOS do not use NSVisualEffectView. Instead, use
a solid background view with three rounded corners.

UIProcess/mac/WebDateTimePickerMac.mm:

(-[WKDateTimePickerWindow initWithContentRect:styleMask:backing:defer:]):
(-[WKDateTimePickerBackdropView drawRect:]):
(-[WKDateTimePicker initWithParams:inView:]):

7:24 AM Changeset in webkit [267084] by Diego Pino Garcia

3 edits
1 move
2 adds
2 deletes in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update baselines and expectations after r267083.

platform/glib/TestExpectations:
platform/glib/fast/text/justify-ideograph-leading-expansion-expected.png: Updated after r267010.
platform/glib/fast/text/justify-ideograph-leading-expansion-expected.txt: Renamed from LayoutTests/platform/wpe/fast/text/justify-ideograph-leading-expansion-expected.txt.
platform/gtk/fast/repaint/spanner-with-margin-expected.txt: Updated after r266818.
platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Removed.

4:36 AM Changeset in webkit [267083] by commit-queue@webkit.org

50 edits in trunk

Convert runtime flag to setting for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=215610

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-15
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Remove the webkit-test-runner directive additions done to the lazy image loading tests.
The new expected results are improvements.

web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:

Source/WebCore:

Convert runtime flag to setting for lazy image loading. Settings are
preferred over RuntimeEnabledFeatures as they are not global singletons
and are automatically accessible in layout tests via InternalSettingsGenerated.

loader/ImageLoader.cpp:

Source/WebKit:

Remove lazy image loading runtime flag.

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Remove lazy image loading runtime flag.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Update test expectations and adjust the tests in http/tests/lazyload/ to
enable the setting. Fow WK1 list more tests that should be skipped.

TestExpectations:
http/tests/lazyload/attribute.html:
http/tests/lazyload/js-image.html:
http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
http/tests/lazyload/lazy.html:
http/tests/lazyload/resources/lazy-load-in-iframe.html:
platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

2:02 AM Changeset in webkit [267082] by commit-queue@webkit.org

2 edits in trunk/Tools

run-jsc-stress-tests: handle remotes that are down on startup
https://bugs.webkit.org/show_bug.cgi?id=216357

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-09-15
Reviewed by Yusuke Suzuki.

Previously, the GNU parallel runner would needlessly fail to run if a
remote host was down on startup, as it used forEachRemote for the
preparatory steps (which would instafail on error).

Change forEachRemote to (optionally) recover from failure by removing
the remote host from the array. This also handles the case where a
remote unexpectedly comes up during a test run (by not picking it up).

Scripts/run-jsc-stress-tests:

1:56 AM Changeset in webkit [267081] by youenn@apple.com

14 edits in trunk

End of media capture should not be reported before 3 seconds of the start of capture
https://bugs.webkit.org/show_bug.cgi?id=216415
Source/WebCore:

Reviewed by Eric Carlson.

Add a timer that allows taking a function and a delay as parameter.
Covered by added API test.

platform/Timer.h:

(WebCore::DeferrableTaskTimer::fired):
(WebCore::DeferrableTaskTimer::doTask):
(WebCore::DeferrableTaskTimer::cancel):

Source/WebKit:

<rdar://problem/68512358>

Reviewed by Eric Carlson.

Add support for delaying of end of capture notification to the application.
This allows to ensure that a capture indicator stays for long enough for the user to notice it.
A capture indicator should be visible to the user for at least three seconds.

A timer is scheduled when starting a capture and there is no ongoing capture.
As long as the timer is active, the capture state cannot be transitioned to no capture.
Other transitions are allowed.
Once the timer kicks in, any capture state update is done synchronously.
Ensure to update the capture state when the timer kicks in.

Note that even navigations will not allow transitioning the capture state sooner.
This is done to ensure a page does not try to capture one frame before navigating to another page.
In practice, very few pages should navigate quickly after starting capture.

UIProcess/API/C/WKPage.cpp:

(WKPageGetMediaState):
(WKPageSetMediaCaptureReportingDelayForTesting):

UIProcess/API/C/WKPagePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mediaCaptureState]):

UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _mediaCaptureReportingDelayForTesting]):
(-[WKWebView _setMediaCaptureReportingDelayForTesting:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updatePlayingMediaDidChange):
(WebKit::WebPageProxy::updateReportedMediaCaptureState):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::reportedMediaCaptureState const):
(WebKit::WebPageProxy::mediaCaptureReportingDelay const):
(WebKit::WebPageProxy::setMediaCaptureReportingDelay):

Tools:

Reviewed by Eric Carlson.

TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
Add a notCapturing boolean and wait for the notification before going back to the capturing page.
Decrease delay to 1 second to make the test run faster.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Make sure to set media capture state delay to zero.

1:55 AM Changeset in webkit [267080] by jh718.park@samsung.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Remove the build warning below since r228533.
warning: ‘%40s’ directive argument is null [-Wformat-overflow=]

Since gcc which has version >= 9 is stricter about passing null string
pointers to printf-like functions, add null string pointer check
to fix the warning proactively.

jsc.cpp:

(runJSC):

12:13 AM Changeset in webkit [267079] by youenn@apple.com

9 edits in trunk/Source/WebKit

Enable VP9 in GPUProcess if page needs it
https://bugs.webkit.org/show_bug.cgi?id=216472

Reviewed by Eric Carlson.

In case a page is using GPUProcess for media, send the VP9 parameters to GPUProcess.
GPUProcess will enable VP9 decoders based on that input.
Covered by LayoutTests/media/vp9.html with GPU process enabled.

GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::enableVP9Decoders):

GPUProcess/GPUConnectionToWebProcess.h:
GPUProcess/GPUConnectionToWebProcess.messages.in:
GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::enableVP9Decoders):

GPUProcess/GPUProcess.h:
WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::updateParameters):

WebProcess/GPU/GPUProcessConnection.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed