Timeline

Sep 17, 2020:

9:54 PM Changeset in webkit [267224] by Ryan Haddad

• 2 edits in trunk/Tools

Unreviewed test gardening for rdar://57029120.

• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:

9:11 PM Changeset in webkit [267223] by Ryan Haddad

• 2 edits in branches/safari-610-branch/Tools

Cherry-pick r266182. rdar://problem/66950074

TestWebKitAPI.AudioRoutingArbitration.Deletion is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=215856
<rdar://problem/66950074>

Reviewed by Jer Noble.

This test deletes a video element by removing it from the DOM, and verifies that
arbitration status changes appropriately. Arbitration status isn't changed until
the element's destructor runs, and that doesn't happen until it is garbage collected
so force GC while waiting for the status to change.

• TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add optional parameter to force GC while waiting for status to change. (TEST_F):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:08 PM Changeset in webkit [267222] by weinig@apple.com

• 31 edits in trunk

Remove runtime setting for enabling/disabling the UserTiming and ResourceTiming APIs
​https://bugs.webkit.org/show_bug.cgi?id=216556

Reviewed by Darin Adler.

Remove runtime setting for enabling/disabling UserTiming and ResourceTiming
APIs. They have both been on for a while in WebKit2 and there aren't any
known uses cases for disabling them. In addition to removing the setting,
they are now enabled in LegacyWebKit as well.

Source/WebCore:

In addition to removing UserTiming and ResourceTiming, we can also remove the
checks for PerformanceTimelineEnabled, as that was defined entirely in terms
of the former.

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::addResourceTiming):
(WebCore::ResourceTimingInformation::storeResourceTimingInitiatorInformation):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::reportResourceTiming):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):

• page/Performance.idl:
• page/PerformanceEntry.cpp:

(WebCore::PerformanceEntry::parseEntryTypeString):

• page/PerformanceEntry.idl:
• page/PerformanceObserver.idl:
• page/PerformanceObserverEntryList.idl:
• page/PerformanceResourceTiming.idl:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setResourceTimingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::resourceTimingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setUserTimingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::userTimingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::performanceTimelineEnabled const): Deleted.

Source/WebKit:

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetUserTimingEnabled):
(WKPreferencesGetUserTimingEnabled):
(WKPreferencesSetResourceTimingEnabled):
(WKPreferencesGetResourceTimingEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setUserTimingEnabled:]):
(-[WebPreferences userTimingEnabled]):
(-[WebPreferences setResourceTimingEnabled:]):
(-[WebPreferences resourceTimingEnabled]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setUserTimingEnabled):
(WebPreferences::userTimingEnabled):
(WebPreferences::setResourceTimingEnabled):
(WebPreferences::resourceTimingEnabled):

• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

7:06 PM Changeset in webkit [267221] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Use OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) in speculationFromCell()'s isSanePointer().
​https://bugs.webkit.org/show_bug.cgi?id=216638

Reviewed by Saam Barati.

We should be using OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) instead of assuming the
width of the pointer address bits.

• bytecode/SpeculatedType.cpp:

(JSC::isSanePointer):

6:45 PM Changeset in webkit [267220] by Darin Adler

• 23 edits in trunk

Selection API: Introduce LiveRangeSelectionEnabled, off by default
​https://bugs.webkit.org/show_bug.cgi?id=216656

Reviewed by Sam Weinig.

Source/WebCore:

For interoperability, the Selection API requires behavior that is quite different
from how our Selection object has behaves historically. Specifically, the range
returned is a live range that update as the selection updates and the selection,
in turn, is updated if the returned range is modified.

This significant change will have compatibility impact on websites and other
content that assumes the legacy WebKit behavior, so we are developing it behind
a feature flag, LiveRangeSelectionEnabled.

This patch introduces the live range selection behind the flag, but leaves one
significant area unresolved, changing selection to keep track of the original
endpoints rather than only canonicalized endpoints, and a couple of loose ends,
lifetime of ride-along properties on the live range object, and updating test
expectations for the new behavior.

• dom/CharacterData.cpp:

(WebCore::CharacterData::setData): Fixed timing of call to Document::textRemoved
by letting setDataAndUpdate do it; otherwise it can be called after the selection
has been updated, and the range gets updated twice.
(WebCore::CharacterData::appendData): Pass UpdateLiveRanges::No to setDataAndUpdate,
to preserve the existing "don't update ranges" behavior for now at least.
(WebCore::CharacterData::insertData): Fixed timing of call to Document::textInserted
by letting setDataAndUpdate do it, for the same reason as above.
(WebCore::CharacterData::deleteData): Ditto, for textRemoved.
(WebCore::CharacterData::replaceData): Ditto, for textRemoved and textInserted.
(WebCore::CharacterData::setDataAndUpdate): Added UpdateLiveRanges argument and
calls to textRemoved and textInserted, after setting data, but before other updates.

• dom/CharacterData.h: Made setDataAndUpdate protected and added UpdateLiveRanges.

• dom/Document.h: Added optimized version of the Node::contains function. When the

node in question is the document we can just check treeScope and isConnected
rather than walking up the tree.

• dom/Node.cpp:

(WebCore::Node::isDescendantOf const): Moved special case for document to the top
of the function; seems a more important special case than disconnected nodes and
nodes with no children.
(WebCore::Node::isDescendantOrShadowDescendantOf const): Reworded the FIXME for clarity.
(WebCore::Node::contains const): Changed this to toke a reference instead of a pointer.
The pointer flavor is now inlined in the header.

• dom/Node.h: Added an overload of contains that takes a reference, analogous to what

we already have for isDescendantOf.

• dom/Position.cpp:

(WebCore::Position::Position): Removed too-strict assertions. When we start using
positions to represent arbitrary DOM positions for things outside editing we won't
want these assertions any more, and we hit them when we use Position in a more
straightforward way, like some cases in this patch.
(WebCore::Position::primaryDirection const): Added a missing null check. This case
is hit in some test cases in the new mode.

• dom/Range.cpp: Removed some, but probably not all, of the unneeded headers.

(WebCore::Range::~Range): Added an assertion.
(WebCore::Range::updateAssociatedSelection): Added. Tells FrameSelection to update
the selection when this is the live range associated with the selection.
(WebCore::Range::updateDocument): Added an assertion.
(WebCore::Range::setStart): Call updateAssociatedSelection.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::collapse): Ditto.
(WebCore::Range::processContents): Call collapse here to share slightly more
code so we don't have to call updateAssociatedSelection here.
(WebCore::Range::checkNodeOffsetPair): Made this a static function so it can
be used outside the Range class. Also fixed indentation of the switch statement.
(WebCore::Range::selectNodeContents): Call updateAssociatedSelection and
updateDocument.
(WebCore::setBothEndpoints): Added.
(WebCore::Range::updateFromSelection): Added. Uses setBothEndpoints.
(WebCore::createLiveRange): Refactored to call setBothEndpoints.

• dom/Range.h: Added didAssociateWithSelection, didDisassociateFromSelection,

updateFromSelection, updateAssociatedSelection, and m_isAssociatedWithSelection.
Also made checkNodeOffsetPair a public static member function instead of a
private non-static member function.

• dom/Text.cpp:

(WebCore::Text::setDataAndUpdate): Update to pass along UpdateLiveRanges argument.

• dom/Text.h: Ditto. Also made the override of setDataAndUpdate private.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): Call
updateAssociatedLiveRange after updating the selection.
(WebCore::containsEndpoints): Added. Used to check if a live range still has the
document as its root node so it can remain associated this with the selection.
(WebCore::FrameSelection::associatedLiveRange): Added.
(WebCore::FrameSelection::disassociateLiveRange): Added.
(WebCore::FrameSelection::associateLiveRange): Added.
(WebCore::FrameSelection::updateFromAssociatedLiveRange): Added.
(WebCore::FrameSelection::updateAssociatedLiveRange): Added.

• editing/FrameSelection.h: Added associatedLiveRange, associateLiveRange,

disassociateLiveRange, updateFromAssociatedLiveRange, updateAssociatedLiveRange,
and m_associatedLiveRange. Also change m_document to a WeakPtr and do some
tidying up.

• page/DOMSelection.cpp:

(WebCore::selectionShadowAncestor): Assert the live range setting is false,
since this code is not used in that case. Changed the return type to RefPtr.
Address the FIXME here by getting the document in a simpler way.
(WebCore::DOMSelection::create): Moved here from the header.
(WebCore::DOMSelection::frame const): Added. Returns a RefPtr. This gets rid
of the need for various instances of the "protector" pattern in this file.
(WebCore::DOMSelection::range const): Added. Returns the selected range, but
checks for the shadow tree case and returns null in that case.
(WebCore::DOMSelection::anchorPosition const): Redid as a member function.
(WebCore::DOMSelection::focusPosition const): Ditto.
(WebCore::DOMSelection::basePosition const): Ditto.
(WebCore::DOMSelection::extentPosition const): Ditto.
(WebCore::DOMSelection::anchorNode const): Rewrote to be simpler using the
functions above.
(WebCore::DOMSelection::anchorOffset const): Ditto.
(WebCore::DOMSelection::focusNode const): Ditto.
(WebCore::DOMSelection::focusOffset const): Ditto.
(WebCore::DOMSelection::baseNode const): Ditto.
(WebCore::DOMSelection::baseOffset const): Ditto.
(WebCore::DOMSelection::extentNode const): Ditto.
(WebCore::DOMSelection::extentOffset const): Ditto.
(WebCore::DOMSelection::isCollapsed const): Rewrote using DOMSelection::range
and SimpleRange::collapsed.
(WebCore::DOMSelection::type const): Updated since frame returns RefPtr.
(WebCore::DOMSelection::rangeCount const): Ditto.
(WebCore::DOMSelection::collapse): Added new corrected checking for special
cases, guarded by the setting.
(WebCore::DOMSelection::collapseToEnd): Updated since frame returns RefPtr.
way to do protection. Added a call to disassociateLiveRange. No need to put
under a setting guard since it does nothing if feature is not enabled.
(WebCore::DOMSelection::collapseToStart): Ditto.
(WebCore::DOMSelection::empty): Call removeAllRanges so we don't have two
copies of the same function to maintain.
(WebCore::DOMSelection::setBaseAndExtent): Use makeRefPtr, added corrected
checking for special cases guarded by the setting.
(WebCore::DOMSelection::setPosition): Call collapse so we don't have two
copies of the same function to maintain.
(WebCore::DOMSelection::modify): Updated since frame returns RefPtr.
(WebCore::DOMSelection::extend): Ditto. Also added corrected checking for
special cases guarded by the setting.
(WebCore::DOMSelection::getRangeAt): Added a version of this function that
simply returns the associated live range, creating one if needed, guarded
by the setting.
(WebCore::DOMSelection::removeAllRanges): Updated since frame returns RefPtr.
(WebCore::DOMSelection::addRange): Added a version of this function that
matches the specification, guarded by the setting.
(WebCore::DOMSelection::removeRange): Added.
(WebCore::DOMSelection::deleteFromDocument): Added a version of this
function that simply calls deleteContents on the associated live range,
guarded by the setting.
(WebCore::DOMSelection::containsNode const): Put the text node workaround
inside a setting check. I also figured out why workaround was added: it
works around unwanted range canonicalization in various tests, but also
introduces incorrect behavior. Also rewrote to use DOMSelection::range.
(WebCore::DOMSelection::toString): Use DOMSelection::range, guarded by
the setting, so we return empty string when selection is in the shadow tree.
(WebCore::DOMSelection::shadowAdjustedNode const): When the live range
setting is enabled, adjust by changing the node to nullptr, not finding an
ancestor in the document.
(WebCore::DOMSelection::shadowAdjustedOffset const): Ditto, but offset 0.
(WebCore::DOMSelection::isValidForPosition const): Assert that the live range
selection setting is disabled, because this incorrect check should only be
used to preserve legacy behavior until we are ready to turn it on.

• page/DOMSelection.h: Updated since setBaseAndExtent, setPosition, and

collapse can raise exceptions, although they only do so when the live range
selection setting is on. Added removeRange. Moved the create function
out of the class definition into the .cpp file. Made return values of
baseNode, extentNode, anchorNode, focusNode, and shadowAdjustedNode RefPtr.
Made toString const. Added frame, range, anchorPosition, focusPosition,
basePosition, and extentPosition private functions. Removed visibleSelection.

• page/DOMSelection.idl: Updated file to match a recent draft of the

Selection standard, reordering things to match the order they appear there.
Added removeRange, guarded by the setting. Also got rid of the
unncecessary "undefined" string defaults for the arguments to the modify
method since they have no effect on observed behavior anyway.

• page/Settings.yaml: Added liveRangeSelectionEnabled.

Source/WebKit:

• Shared/WebPreferencesInternal.yaml: Added LiveRangeSelectionEnabled.

LayoutTests:

• editing/selection/move-to-line-boundary-clear-selection.html: Fix test that accidentally

relied on our non-standard behavior of clamping a too-high offset to a valid value. This
was not what we were trying to test. Without this change, the test fails in the new mode.
The offset was "5", which seems to be a character count, rather than "1", meaning "after
the text node".

• editing/selection/toString-1.html: Ditto. The offset here was 3, but the HTML element

has only 2 children, the head and the body.

• editing/selection/user-select-all-selection.html: Ditto. The code was passing the wrong

container by acccident, the parent of the text node rather than the text node.

6:44 PM Changeset in webkit [267219] by Devin Rousso

• 5 edits in trunk/Source

Web Inspector: REGRESSION(r266885): fix open source build
​https://bugs.webkit.org/show_bug.cgi?id=216675

Reviewed by Timothy Hatcher.

Add back methods used by WebInspector.framework.

Source/JavaScriptCore:

• inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::getInteger): Added.
(Inspector::BackendDispatcher::getDouble): Added.
(Inspector::BackendDispatcher::getString): Added.

Source/WTF:

• wtf/JSONValues.h:
• wtf/JSONValues.cpp:

(WTF::JSONImpl::Value::asDouble const): Added.
(WTF::JSONImpl::Value::asInteger const): Added.
(WTF::JSONImpl::Value::asString const): Added.
(WTF::JSONImpl::ObjectBase::getBoolean const): Added.
(WTF::JSONImpl::ObjectBase::getString const): Added.
(WTF::JSONImpl::ObjectBase::getObject const): Added.
(WTF::JSONImpl::ObjectBase::getArray const): Added.
(WTF::JSONImpl::ObjectBase::getValue const): Added.

6:33 PM Changeset in webkit [267218] by Chris Dumez

• 11 edits
  2 deletes in trunk

Vectorize SetTargetAtTime processing in AudioParamTimeline
​https://bugs.webkit.org/show_bug.cgi?id=216673

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setTargetAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/test-constantsourcenode-expected.txt:

Source/WebCore:

Vectorize SetTargetAtTime processing in AudioParamTimeline.

The patch is based on the Blink implementation at:

• ​https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc

I have however added the USE(ACCELERATE) and HAVE(ARM_NEON_INTRINSICS) implementations
for DARWIN and non-SSE platforms.

This allows us to pass some more tests that we were failing merely due to precision
issues. Now that our implemention matches Blink's, our results are consistent
with Blink.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
(WebCore::AudioParamTimeline::processSetTarget):

• Modules/webaudio/AudioParamTimeline.h:
• platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsadd):
(WebCore::VectorMath::vsmul):

• platform/audio/VectorMath.h:

LayoutTests:

• webaudio/audioparam-cancel-and-hold-expected.txt:

Rebaseline test now that one more subtest is passing.

• webaudio/audioparam-setTargetAtTime-expected.txt: Removed.
• webaudio/audioparam-setTargetAtTime.html: Removed.

Remove outdated test now that it was upstreamed to WPT. The updated
copy resides at:
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setTargetAtTime.html

6:32 PM Changeset in webkit [267217] by Karl Rackler

• 2 edits in branches/safari-610-branch/LayoutTests

[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215773

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

6:17 PM Changeset in webkit [267216] by Tadeu Zagallo

• 3 edits
  1 add in trunk

Inconsistent loop exit assertion in B3ReduceLoopStrength
​https://bugs.webkit.org/show_bug.cgi?id=216274
<rdar://problem/68513573>

Reviewed by Keith Miller.

JSTests:

• stress/reduce-loop-strength-multiple-exits.js: Added.

(build_array):
(main):

Source/JavaScriptCore:

On B3ReduceLoopStrength, we first calculate where the loop exits to, and ensure there's only
one exit target. Later on, we compute how many places within the loop exit to that single exit
target. Currently, we assume that having a single target implies that we'll only ever have one
exit point, which is incorrect. To fix it, instead of asserting there should only be one exit
point, we just bail if we find more than one.

• b3/B3ReduceLoopStrength.cpp:

(JSC::B3::ReduceLoopStrength::reduceByteCopyLoopsToMemcpy):

5:50 PM Changeset in webkit [267215] by timothy_horton@apple.com

• 4 edits in trunk/Source

Per-app accent color overrides are broken
​https://bugs.webkit.org/show_bug.cgi?id=216674
<rdar://problem/67745464>

Reviewed by Wenson Hsieh.

Source/WebCore/PAL:

• pal/spi/mac/NSApplicationSPI.h:

Source/WebKit:

No new tests; I've no idea how to write a test that would have caught this;
any test I can imagine would have also written to _accentColor and worked fine.

• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::accentColor):
AppKit changed the meaning of the IPI. Use the correct version.
We still write to _accentColor; it is now purely an override.

5:33 PM Changeset in webkit [267214] by Ryan Haddad

• 3 edits in branches/safari-610-branch

Cherry-pick r267162. rdar://problem/69104937

REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216619

Reviewed by Chris Dumez.

Tools:

In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.

• WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):

LayoutTests:

• platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:50 PM Changeset in webkit [267213] by Alan Coon

• 1 copy in tags/Safari-610.2.6

Tag Safari-610.2.6.

3:50 PM Changeset in webkit [267212] by Alan Coon

• 1 delete in tags/Safari-610.2.6

Delete tag.

3:46 PM Changeset in webkit [267211] by Alan Coon

• 1 copy in tags/Safari-610.2.6

Tag Safari-610.2.6.

3:36 PM Changeset in webkit [267210] by eric.carlson@apple.com

• 4 edits
  2 adds in trunk

[Cocoa] canPlayType('audio/mpeg; codecs="mp3"') returns ""
​https://bugs.webkit.org/show_bug.cgi?id=147309

Reviewed by Darin Adler.
Source/WebCore:

'audio/mpeg; codecs="mp3"' is not an RFC 3003 compliant MIME type but some big
web sites use it. AVFoundation says the type is not supported, but MediaPlayerPrivateMediaSourceAVFObjC
previously returned "maybe" for all extended types where the container type is
supported. This bug was fixed when we moved the MIME type logic from MediaPlayerPrivateMediaSourceAVFObjC
to MIMETypeCache, so add a mechanism to override extended types and use it to
support 'audio/mpeg; codecs="mp3"'.

Test: media/media-can-play-mp3.html

• platform/graphics/MIMETypeCache.cpp:

(WebCore::MIMETypeCache::canDecodeType):
(WebCore::MIMETypeCache::overrideExtendedType):

• platform/graphics/MIMETypeCache.h:

LayoutTests:

• media/media-can-play-mp3-expected.txt: Added.
• media/media-can-play-mp3.html: Added.

2:45 PM Changeset in webkit [267209] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.7

1:42 PM Changeset in webkit [267208] by Kate Cheney

• 2 edits in trunk/Source/WebKit

Enable ITP in WKWebViews for apps with the full browser entitlement who are not linked to iOS 14.0
​https://bugs.webkit.org/show_bug.cgi?id=216655
<rdar://problem/69081227>

Reviewed by Brent Fulgham.

Apps with the full browser entitlement who are not linked to iOS 14.0
should have ITP enabled in WKWebViews by default.

No new tests, no way currently to test apps with different iOS
versions. Tested manually.

• Shared/Cocoa/DefaultWebBrowserChecks.mm:

(WebKit::determineITPStateInternal):
Ignore the early return for the linked-on-or-after check if the
app has the default browser entitlement so we still enable ITP based
on the user's preference.

1:33 PM Changeset in webkit [267207] by Ryan Haddad

• 3 edits in branches/safari-610-branch/LayoutTests

Cherry-pick r266772. rdar://problem/69087333

[ iOS wk2 ] fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216300
<rdar://problem/68542670>

Reviewed by Wenson Hsieh.

• fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: shouldBecomeDifferent only works if both of the strings it evals are evaluable in the global scope.

• platform/ios-wk2/TestExpectations: Remove the failure expectation.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:21 PM Changeset in webkit [267206] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

WebKit::XPCServiceEventHandler block should call exit() on the main thread
<​https://webkit.org/b/216594>
<rdar://problem/68053217>

Reviewed by Chris Dumez.

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

• Call exit() on the main thread. I chose dispatch_sync() here so that if other crashes occur on the main thread, we will know if this background thread is waiting to call exit() at the same time. Also, if a different background thread calls exit() in the future with this block running on the main thread, we'll know where the block came from since the XPC handler thread will be waiting for the dispatch_sync() to return (instead of having a mysterious block calling exit() on the main thread and not knowing where it came from).
• Add logging (including simulated crash logs) when either of these exit() code paths is taken.

12:52 PM Changeset in webkit [267205] by msaboff@apple.com

• 3 edits
  2 adds in trunk

Segfault in WebCore::IDBKey::createBinary
​https://bugs.webkit.org/show_bug.cgi?id=216501

Reviewed by Youenn Fablet.

Source/WebCore:

If we can't get a copy of the JSBufferView, return an invalid IDBKey.
This can happen if we are low on memory. The existing calling code already
handles the case where we might produce an invalid IDBKey.

Test: storage/indexeddb/IDBKey-create-array-buffer-view-oom.html

• Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::createBinary):

LayoutTests:

New test. Since this test is looking for the out of memory condition, the test is written
to avoid false failures in the case we can't achieve out of memory. That is when the
expected exception is not thrown.

• storage/indexeddb/IDBKey-create-array-buffer-view-oom-expected.txt: Added.
• storage/indexeddb/IDBKey-create-array-buffer-view-oom.html: Added.

12:28 PM Changeset in webkit [267204] by graouts@webkit.org

• 7 edits in trunk/Source/WebCore

Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData
​https://bugs.webkit.org/show_bug.cgi?id=216654

Reviewed by Simon Fraser.

Before we implemented the correct way to sort animations using KeyframeEffectStack, we relied on distinct animation collections
for CSS Transtions and CSS Animations and remaining Web Animations on ElementAnimationRareData. We don't need those anymore and
we can use a single collection which we can now name animations() for all animations.

Additionally, the AnimationTimeline::animationsForElement() method where these collections were used when requesting unsorted
animations was unnecessary and an incorrect design. Animations do not belong to a given timeline, so we now use the accessors
on ElementAnimationRareData directly to get the sorted list of effects or the single animations collection.

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationWasAddedToElement):
(WebCore::AnimationTimeline::animationWasRemovedFromElement):
(WebCore::AnimationTimeline::willChangeRendererForElement):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
(WebCore::AnimationTimeline::animationsForElement const): Deleted.

• animation/AnimationTimeline.h:
• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animationCanBeRemoved):
(WebCore::DocumentTimeline::computeExtentOfAnimation const):
(WebCore::DocumentTimeline::isRunningAnimationOnRenderer const):
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::DocumentTimeline::animatedStyleForRenderer):
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement):

• animation/ElementAnimationRareData.h:

(WebCore::ElementAnimationRareData::animations):
(WebCore::ElementAnimationRareData::webAnimations): Deleted.
(WebCore::ElementAnimationRareData::cssAnimations): Deleted.
(WebCore::ElementAnimationRareData::transitions): Deleted.

• dom/Element.cpp:

(WebCore::Element::animations const):
(WebCore::Element::ensureAnimations):
(WebCore::Element::getAnimations):
(WebCore::Element::webAnimations const): Deleted.
(WebCore::Element::cssAnimations const): Deleted.
(WebCore::Element::transitions const): Deleted.
(WebCore::Element::ensureWebAnimations): Deleted.
(WebCore::Element::ensureCSSAnimations): Deleted.
(WebCore::Element::ensureTransitions): Deleted.

• dom/Element.h:

11:54 AM Changeset in webkit [267203] by commit-queue@webkit.org

• 10 edits in trunk/Source

Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks to clarify what this enum value is for.
​https://bugs.webkit.org/show_bug.cgi?id=216651

Patch by Hoa Dinh <​dvh@apple.com> on 2020-09-17
Reviewed by Alex Christensen.

Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks and reflects the change where it's used.

Source/WebCore:

Source/WebCore:

• loader/FrameLoaderTypes.h:
• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

Source/WebKit:

Source/WebKit:

• Shared/SessionState.cpp:

(WebKit::isValidEnum):

• UIProcess/API/APINavigationAction.h:
• UIProcess/API/glib/WebKitWebViewSessionState.cpp:

(toExternalURLsPolicy):
(toWebCoreExternalURLsPolicy):

• UIProcess/WebPageProxy.h:
• UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::decodeSessionHistoryEntry):

• WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

11:39 AM Changeset in webkit [267202] by Chris Dumez

• 7 edits in trunk

AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent
​https://bugs.webkit.org/show_bug.cgi?id=216629

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:

Source/WebCore:

AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent.
This behavior is consistent with Gecko and Blink. Previously, we'd use AnalyserNode.minDecibels
instead.

No new tests, rebaselined existing test.

• Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::getFloatFrequencyData):

• platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::linearToDecibels):

11:10 AM Changeset in webkit [267201] by Chris Dumez

• 7 edits
  1 add in trunk/LayoutTests

Regression(r267144) 4 webaudio/oscillator tests are broken
​https://bugs.webkit.org/show_bug.cgi?id=216625
<rdar://problem/69024624>

Reviewed by Darin Adler.

• webaudio/oscillator-custom.html:
• webaudio/oscillator-sawtooth.html:
• webaudio/oscillator-sine.html:
• webaudio/oscillator-square.html:
• webaudio/oscillator-triangle.html:

Update tests to use oscillator-testing-legacy.js since they are not compatible
with the newer oscillator-testing.js that was resync'd from Blink.

• webaudio/oscillator-triangle-expected.wav:

Rebaseline test that has different output due to the fix in r267153.

• webaudio/resources/oscillator-testing-legacy.js: Added.

Restore old copy of oscillator-testing.js and rename it to oscillator-testing-legacy.js.

11:07 AM Changeset in webkit [267200] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak SDK] bwrap: add pipewire socket as bind mount
​https://bugs.webkit.org/show_bug.cgi?id=216606

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2020-09-17
Reviewed by Philippe Normand.

Add pipewire socket to bwrap as a try binding mount.

• flatpak/webkit-bwrap:

10:54 AM Changeset in webkit [267199] by ysuzuki@apple.com

• 4 edits
  3 adds in trunk

[JSC] Async generator default-export is not handled
​https://bugs.webkit.org/show_bug.cgi?id=216643

Reviewed by Ross Kirsling.

JSTests:

• modules/async-generator-default.js: Added.

(from.string_appeared_here.import.test.from.string_appeared_here.async test2):

• modules/async-generator-default/module.js: Added.

(export.default.async test):

• test262/expectations.yaml:

Source/JavaScriptCore:

export default async function * test() { } syntax should be correctly handled.
This patch adds the code retrieving "test" name from the above declaration correctly.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseExportDeclaration):

10:47 AM Changeset in webkit [267198] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] YouTube does not route video to AirPlay the first time
​https://bugs.webkit.org/show_bug.cgi?id=216626
<rdar://problem/62222846>

Reviewed by Eric Carlson.

Difficult to test this, since it requires an live AppleTV device.

During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
which explains the "only initial AirPlay fails" behavior.

• platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):

10:45 AM Changeset in webkit [267197] by Diego Pino Garcia

• 3 edits in trunk/Tools

[ews] Re-enable api-gtk queue
​https://bugs.webkit.org/show_bug.cgi?id=216647

Reviewed by Aakash Jain.

The queue was disabled temporarily in r266956.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

• BuildSlaveSupport/ews-build/config.json:

10:17 AM Changeset in webkit [267196] by ysuzuki@apple.com

• 4 edits
  3 adds in trunk

[JSC] Update JSModuleNamespaceObject::defineOwnProperty
​https://bugs.webkit.org/show_bug.cgi?id=216640

Reviewed by Ross Kirsling.

JSTests:

• modules/module-namespace-object-define-own-property.js: Added.

(from.string_appeared_here.import.as.ns.from.string_appeared_here.shouldThrow):
(shouldThrow):
(shouldThrow.):
(get TypeError):

• modules/module-namespace-object-define-own-property/module.js: Added.
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements spec update of JSModuleNamespaceObject::defineOwnProperty.
We implement ​https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-defineownproperty-p-desc precisely.

• runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::deleteProperty):
(JSC::JSModuleNamespaceObject::getOwnPropertyNames):
(JSC::JSModuleNamespaceObject::defineOwnProperty):

10:08 AM Changeset in webkit [267195] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[WPE] Unreviewed gardening. Several fast/events/mouse-* tests are flaky after r264117.

The test started failing somewhere between r264103-r264117.

• platform/wpe/TestExpectations:

9:17 AM Changeset in webkit [267194] by weinig@apple.com

• 5 edits in trunk/Source/WebKit

We shouldn't need to specify a category for preferences now that they are split into separate files
​https://bugs.webkit.org/show_bug.cgi?id=216648

Reviewed by Tim Horton.

Remove need / ability to specify a category in the yaml, rather, infer the category
from which file it is in.

• Scripts/GeneratePreferences.rb:
• Shared/WebPreferencesDebug.yaml:
• Shared/WebPreferencesExperimental.yaml:
• Shared/WebPreferencesInternal.yaml:

8:59 AM Changeset in webkit [267193] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[WPE] Unreviewed gardening. Update baselines after r20056.

• platform/glib/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt:
• platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Updated after r266510.
• platform/wpe/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt: Updated after r266399.

8:43 AM Changeset in webkit [267192] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Add some pointer sanity checks to speculationFromCell().
​https://bugs.webkit.org/show_bug.cgi?id=216638
rdar://23226333

Reviewed by Yusuke Suzuki.

Add some sanity checks to mitigate against some potential pointer corruptions
from profiling data. The goal here is not to exhaustively filter out all possible
bad pointers, but simply to filter out as many as possible to reduce crashes from
such bad pointers, and to do so with the least possible performance impact.

It is OK to do such filtering here because we're only trying to compute a
SpeculatedType from the pointer. If the pointer is bad, we can just return
SpecNone indicating that we don't have any info to speculate on.

• bytecode/SpeculatedType.cpp:

(JSC::isSanePointer):
(JSC::speculationFromCell):

• runtime/StructureIDTable.h:

(JSC::StructureIDTable::tryGet):

• runtime/VM.h:

(JSC::VM::tryGetStructure):

8:07 AM Changeset in webkit [267191] by Antti Koivisto

• 12 edits in trunk/Source/WebCore

Style::Change should be enum class
​https://bugs.webkit.org/show_bug.cgi?id=216644

Reviewed by Sam Weinig.

Also improve the names of the values.

• dom/Document.cpp:

(WebCore::Document::resolveStyle):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):

• rendering/updating/RenderTreeBuilderFirstLetter.cpp:

(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::RenderTreeUpdater::updateElementRenderer):

• rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):

• style/StyleChange.cpp:

(WebCore::Style::determineChange):

• style/StyleChange.h:

(): Deleted.

• style/StyleTreeResolver.cpp:

(WebCore::Style::computeDescendantsToResolve):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::resolveComposedTree):

• style/StyleTreeResolver.h:
• style/StyleUpdate.h:
• svg/SVGElement.cpp:

(WebCore::SVGElement::willRecalcStyle):

7:44 AM Changeset in webkit [267190] by Diego Pino Garcia

• 2 edits in trunk/Tools

[GTK] Unreviewed gardening. API test WebKitWebInspectorServer/test-page-list is flaky.

• TestWebKitAPI/glib/TestExpectations.json:

7:11 AM Changeset in webkit [267189] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[GLIB] Unreviewwed test gardening. Update baselines after WPT update in r267167.

• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:

5:39 AM Changeset in webkit [267188] by graouts@webkit.org

• 153 edits
  2 copies
  2 deletes in trunk

Remove the legacy animation code
​https://bugs.webkit.org/show_bug.cgi?id=216608

Reviewed by Dean Jackson.

Source/WebCore:

We remove the legacy animation code found in Source/WebCore/page/animation/, save for CSSPropertyAnimation which
is also used by the new Web Animations engine and now moved to Source/WebCore/animation/. Since we now have a single
animation engine, the runtime flags to optionally enable the Web Animations engine are not needed anymore and removed
as well.

We also remove some testing utilities and some RenderLayerBacking methods specific to accelerated transitions which
the new animation engine does not use.

• CMakeLists.txt:
• Headers.cmake:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• animation/Animatable.idl:
• animation/AnimationEffect.idl:
• animation/AnimationPlaybackEvent.idl:
• animation/AnimationPlaybackEventInit.idl:
• animation/AnimationTimeline.idl:
• animation/CSSAnimation.idl:
• animation/CSSPropertyAnimation.cpp: Renamed from Source/WebCore/page/animation/CSSPropertyAnimation.cpp.

(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):

• animation/CSSPropertyAnimation.h: Renamed from Source/WebCore/page/animation/CSSPropertyAnimation.h.
• animation/CSSTransition.idl:
• animation/DocumentAnimations.idl:
• animation/DocumentOrShadowRootAnimations.idl:
• animation/DocumentTimeline.idl:
• animation/KeyframeEffect.idl:
• animation/WebAnimation.idl:
• animation/WebAnimationTypes.h:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

• dom/Document.cpp:

(WebCore::Document::resolveStyle):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::implicitClose):
(WebCore::Document::resume):

• dom/Element.cpp:

(WebCore::Element::removedFromAncestor):

• dom/PseudoElement.cpp:

(WebCore::PseudoElement::clearHostElement):

• history/CachedFrame.cpp:

(WebCore::CachedFrame::destroy):

• page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::clearTimers):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):

• page/Frame.h:
• page/FrameView.cpp:

(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

• page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):

• page/Page.cpp:

(WebCore::Page::handleLowModePowerChange):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebAnimationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAnimationsCSSIntegrationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsCSSIntegrationEnabled const): Deleted.

• page/animation/AnimationBase.cpp: Removed.
• page/animation/AnimationBase.h: Removed.
• page/animation/CSSAnimationController.cpp: Removed.
• page/animation/CSSAnimationController.h: Removed.
• page/animation/CSSAnimationControllerPrivate.h: Removed.
• page/animation/CompositeAnimation.cpp: Removed.
• page/animation/CompositeAnimation.h: Removed.
• page/animation/ImplicitAnimation.cpp: Removed.
• page/animation/ImplicitAnimation.h: Removed.
• page/animation/KeyframeAnimation.cpp: Removed.
• page/animation/KeyframeAnimation.h: Removed.
• platform/graphics/GraphicsLayer.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::isKeyframe):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::animatedStyle):

• rendering/RenderElement.h:

(WebCore::RenderElement::startTransition): Deleted.
(WebCore::RenderElement::transitionPaused): Deleted.
(WebCore::RenderElement::transitionFinished): Deleted.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::currentTransform const):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::notifyAnimationStarted):
(WebCore::RenderLayerBacking::startTransition): Deleted.
(WebCore::RenderLayerBacking::transitionPaused): Deleted.
(WebCore::RenderLayerBacking::transitionFinished): Deleted.

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::startTransition): Deleted.
(WebCore::RenderLayerModelObject::transitionPaused): Deleted.
(WebCore::RenderLayerModelObject::transitionFinished): Deleted.

• rendering/RenderLayerModelObject.h:
• rendering/RenderObject.h:

(WebCore::RenderObject::legacyAnimation const): Deleted.

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::tearDownRenderers):

• style/StyleAdjuster.cpp:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::webAnimationsCSSIntegrationEnabled): Deleted.

• testing/InternalSettings.h:
• testing/InternalSettings.idl:
• testing/Internals.cpp:

(WebCore::Internals::numberOfActiveAnimations const):
(WebCore::Internals::animationsAreSuspended const):
(WebCore::Internals::animationsInterval const):
(WebCore::Internals::suspendAnimations const):
(WebCore::Internals::resumeAnimations const):
(WebCore::Internals::acceleratedAnimationsForElement):
(WebCore::Internals::numberOfAnimationTimelineInvalidations const):
(WebCore::Internals::pauseAnimationAtTimeOnElement): Deleted.
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement): Deleted.
(WebCore::Internals::pauseTransitionAtTimeOnElement): Deleted.
(WebCore::Internals::pauseTransitionAtTimeOnPseudoElement): Deleted.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.

• Shared/WebPreferencesExperimental.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebAnimationsEnabled): Deleted.
(WKPreferencesGetWebAnimationsEnabled): Deleted.
(WKPreferencesSetWebAnimationsCSSIntegrationEnabled): Deleted.
(WKPreferencesGetWebAnimationsCSSIntegrationEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setWebAnimationsCSSIntegrationEnabled:]): Deleted.
(-[WKPreferences _webAnimationsCSSIntegrationEnabled]): Deleted.

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setWebAnimationsEnabled): Deleted.
(WebKit::InjectedBundle::setWebAnimationsCSSIntegrationEnabled): Deleted.

• WebProcess/InjectedBundle/InjectedBundle.h:

Source/WebKitLegacy/mac:

Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences webAnimationsEnabled]): Deleted.
(-[WebPreferences setWebAnimationsEnabled:]): Deleted.
(-[WebPreferences webAnimationsCSSIntegrationEnabled]): Deleted.
(-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]): Deleted.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.

• Interfaces/IWebFramePrivate.idl:
• Interfaces/IWebPreferencesPrivate.idl:
• WebFrame.cpp:

(WebFrame::resumeAnimations): Deleted.
(WebFrame::suspendAnimations): Deleted.
(WebFrame::pauseAnimation): Deleted.
(WebFrame::pauseTransition): Deleted.
(WebFrame::numberOfActiveAnimations): Deleted.

• WebFrame.h:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::webAnimationsCSSIntegrationEnabled): Deleted.
(WebPreferences::setWebAnimationsCSSIntegrationEnabled): Deleted.
(WebPreferences::setWebAnimationsEnabled): Deleted.
(WebPreferences::webAnimationsEnabled): Deleted.

• WebPreferences.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.

• DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):
(TestOptions::webViewIsCompatibleWithOptions const):

• DumpRenderTree/TestOptions.h:
• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):

LayoutTests:

Remove any use of now-removed testing methods and some runtime flags from layout tests.

• animations/legacy-encoding-timing-function.html:
• animations/resources/animation-test-helpers.js:

(pauseAnimationAtTimeOnElement):

• http/tests/contentextensions/css-display-none-keyframe.html:
• imported/blink/transitions/resources/opacity-transform-transitions-inside-iframe-inner.html: Removed.
• transitions/background-position-transitions.html:
• transitions/background-transitions.html:
• transitions/blendmode-transitions.html:
• transitions/border-radius-transition.html:
• transitions/clip-path-path-transitions.html:
• transitions/clip-path-transitions.html:
• transitions/clip-transition.html:
• transitions/color-transition-all.html:
• transitions/color-transition-premultiplied.html:
• transitions/color-transition-rounding.html:
• transitions/cross-fade-background-image.html:
• transitions/cross-fade-border-image.html:
• transitions/cubic-bezier-overflow-color.html:
• transitions/cubic-bezier-overflow-length.html:
• transitions/cubic-bezier-overflow-shadow.html:
• transitions/cubic-bezier-overflow-svg-length.html:
• transitions/cubic-bezier-overflow-transform.html:
• transitions/default-timing-function.html:
• transitions/delay.html:
• transitions/flex-transitions.html:
• transitions/font-family-during-transition.html:
• transitions/frames-timing-function.html:
• transitions/interrupted-all-transition.html:
• transitions/longhand-vs-shorthand-initial.html:
• transitions/mask-transitions.html:
• transitions/min-max-width-height-transitions.html:
• transitions/mismatched-shadow-styles.html:
• transitions/mismatched-shadow-transitions.html:
• transitions/mixed-type.html:
• transitions/move-after-transition.html:
• transitions/multiple-background-size-transitions.html:
• transitions/multiple-background-transitions.html:
• transitions/multiple-mask-transitions.html:
• transitions/multiple-shadow-transitions.html:
• transitions/negative-delay.html:
• transitions/opacity-transition-zindex.html:
• transitions/resources/transition-test-helpers.js:
• transitions/shape-outside-transitions.html:
• transitions/shorthand-border-transitions.html:
• transitions/shorthand-transitions.html:
• transitions/steps-timing-function.html:
• transitions/svg-layout-transition.html:
• transitions/svg-text-shadow-transition.html:
• transitions/svg-transitions.html:
• transitions/text-indent-transition.html:
• transitions/transform-op-list-match.html:
• transitions/transform-op-list-no-match.html:
• transitions/transition-end-event-rendering.html:
• transitions/transition-hit-test-transform.html:
• transitions/transition-hit-test.html:
• transitions/transition-in-delay-phase.html:
• transitions/transition-on-element-with-content.html:
• transitions/transition-shorthand-delay.html:
• transitions/transition-timing-function.html:
• transitions/transition-to-from-auto.html:
• transitions/transition-to-from-undefined.html:
• transitions/visited-link-color.html:
• transitions/zero-duration-in-list.html:
• transitions/zero-duration-with-non-zero-delay-start.html:
• webanimations/accelerated-animation-interruption-display-none.html:
• webanimations/accelerated-animation-removal-upon-transition-completion.html:
• webanimations/accelerated-animation-suspension.html:
• webanimations/accelerated-transition-by-removing-property.html:
• webanimations/accessing-current-time-after-clearing-css-animation-effect.html:
• webanimations/accessing-current-time-after-finished-css-animation-target-removal.html:
• webanimations/css-animation-effect-target-change-and-animation-removal-crash.html:
• webanimations/css-animation-effect-target-change-and-get-keyframes-crash.html:
• webanimations/css-animations.html:
• webanimations/css-transition-in-flight-reversal-accelerated.html:
• webanimations/empty-keyframes-crash.html:
• webanimations/partly-accelerated-transition-by-removing-property.html:
• webanimations/setting-css-animation-none-after-clearing-effect.html:
• webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html:

5:12 AM Changeset in webkit [267187] by commit-queue@webkit.org

• 4 edits in trunk

Clean up lazy frame loading
​https://bugs.webkit.org/show_bug.cgi?id=216560

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-17
Reviewed by Youenn Fablet.

Source/WebKit:

Allow web preference to be consistent with lazy image loading.

• Shared/WebPreferencesExperimental.yaml:

LayoutTests:

Remove WPT specific custom code to set the
lazy frame loading setting, not needed since
experimental features will be enabled for WPT
runs and that will set this setting.

• resources/testharnessreport.js:

3:30 AM Changeset in webkit [267186] by ysuzuki@apple.com

• 17 edits in trunk

Support export namespace export * as ns
​https://bugs.webkit.org/show_bug.cgi?id=214379

Reviewed by Ross Kirsling.

JSTests:

• stress/modules-syntax-error.js:
• stress/modules-syntax.js:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch supports export * as ns from "module" syntax. If it is used, we expose "module"'s namespace object as "ns".
For each module environment, we create *namespace* (starNamespace) private symbol scope variable. And we fill it later
with module namespace object. This way allows us to use module namespace object IC and super fast imported module binding
lookup though environment variable lookup mechanism.

• builtins/BuiltinNames.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• parser/NodesAnalyzeModule.cpp:

(JSC::ExportNamedDeclarationNode::analyzeModule):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseExportDeclaration):

• runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::ExportEntry::createNamespace):
(JSC::AbstractModuleRecord::resolveExportImpl):
(JSC::AbstractModuleRecord::getModuleNamespace):
(JSC::AbstractModuleRecord::setModuleEnvironment):
(JSC::AbstractModuleRecord::dump):

• runtime/AbstractModuleRecord.h:
• runtime/CommonIdentifiers.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::name):
(JSC::JSFunction::reifyName):

• runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):

• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::instantiateDeclarations):
(JSC::JSModuleRecord::evaluate):

• wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::finishCreation):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

2:19 AM Changeset in webkit [267185] by jer.noble@apple.com

• 11 edits in trunk/Source

Unified build fix for "redefinition of 'kCMVideoCodecType_VP9"
​https://bugs.webkit.org/show_bug.cgi?id=216205

Reviewed by Youenn Fablet.

Source/WebCore:

kCMVideoCodecType_VP9 is present in the macOS Big Sur SDK, so the redeclaration can
be removed. To protect builds using prior OS SDKs, wrap the entire VP9 implementation
in ENABLE(VP9) checks.

• platform/graphics/VP9Utilities.cpp:
• platform/graphics/VP9Utilities.h:
• platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:

(WebCore::videoCodecTypeFromRFC4281Type):
(WebCore::createMediaPlayerDecodingConfigurationCocoa):
(): Deleted.

• platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::isContentTypeSupported):

• platform/graphics/cocoa/VP9UtilitiesCocoa.h:
• platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
• testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::parseVPCodecParameters):
(WebCore::Internals::setHardwareVP9DecoderDisabledForTesting):
(WebCore::Internals::setVP9ScreenSizeAndScaleForTesting):

Source/WebKit:

Wrap calls to WebCore VP9 functions in ENABLE(VP9) checks.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

• WebProcess/WebProcess.cpp:
• WebProcess/WebProcess.h:

1:05 AM Changeset in webkit [267184] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Optimize Promise#finally by avoiding creating multiple environments
​https://bugs.webkit.org/show_bug.cgi?id=216637

Reviewed by Ross Kirsling.

Let's just create functions inside Promise#finally. This avoids creating
multiple lexical environments that are captured by each function.

• builtins/PromisePrototype.js:

(finally):
(globalPrivate.getThenFinally): Deleted.
(globalPrivate.getCatchFinally): Deleted.

1:01 AM Changeset in webkit [267183] by svillar@igalia.com

• 5 edits in trunk

[css-flex] Remove flexbox's specific computePreferredLogicalWidths()
​https://bugs.webkit.org/show_bug.cgi?id=216577

Reviewed by Darin Adler.

Source/WebCore:

Remove the flexbox override of computePreferredLogicalWidths() because it's essentially the same as RenderBlock's
but worst because it was missing some cases that were properly handled in the superclass.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths): Deleted.

• rendering/RenderFlexibleBox.h: Ditto.

LayoutTests:

• TestExpectations: Removed flexbox_stf-table-singleline.html and flexbox_stf-table-singleline-2.html that are now passing.

Sep 16, 2020:

9:40 PM Changeset in webkit [267182] by Alan Bujtas

• 10 edits
  1 move in trunk/Source/WebCore

[LFC][IFC] Move InlineRect from Display to Layout namespace
​https://bugs.webkit.org/show_bug.cgi?id=216633

Reviewed by Simon Fraser.

Let's move the Display type over to Layout namespace. Display tree needs a different set of data types.

• WebCore.xcodeproj/project.pbxproj:
• layout/displaytree/DisplayLine.h:

(WebCore::Display::Line::rect const):
(WebCore::Display::Line::scrollableOverflow const):
(WebCore::Display::Line::inkOverflow const):
(WebCore::Display::Line::Line):

• layout/displaytree/DisplayRun.h:

(WebCore::Display::Run::rect const):
(WebCore::Display::Run::inkOverflow const):
(WebCore::Display::Run::Run):

• layout/flexformatting/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::logicalRect const):

• layout/inlineformatting/InlineRect.h: Renamed from Source/WebCore/layout/displaytree/DisplayInlineRect.h.

(WebCore::Layout::InlineRect::expandHorizontally):
(WebCore::Layout::InlineRect::expandVertically):
(WebCore::Layout::InlineRect::invalidateTop):
(WebCore::Layout::InlineRect::invalidateLeft):
(WebCore::Layout::InlineRect::invalidateWidth):
(WebCore::Layout::InlineRect::invalidateHeight):
(WebCore::Layout::InlineRect::hasValidPosition const):
(WebCore::Layout::InlineRect::hasValidSize const):
(WebCore::Layout::InlineRect::hasValidGeometry const):
(WebCore::Layout::InlineRect::InlineRect):
(WebCore::Layout::InlineRect::invalidatePosition):
(WebCore::Layout::InlineRect::setHasValidPosition):
(WebCore::Layout::InlineRect::setHasValidSize):
(WebCore::Layout::InlineRect::top const):
(WebCore::Layout::InlineRect::left const):
(WebCore::Layout::InlineRect::bottom const):
(WebCore::Layout::InlineRect::right const):
(WebCore::Layout::InlineRect::topLeft const):
(WebCore::Layout::InlineRect::size const):
(WebCore::Layout::InlineRect::width const):
(WebCore::Layout::InlineRect::height const):
(WebCore::Layout::InlineRect::setTopLeft):
(WebCore::Layout::InlineRect::setTop):
(WebCore::Layout::InlineRect::setBottom):
(WebCore::Layout::InlineRect::setLeft):
(WebCore::Layout::InlineRect::setWidth):
(WebCore::Layout::InlineRect::setHeight):
(WebCore::Layout::InlineRect::moveHorizontally):
(WebCore::Layout::InlineRect::moveVertically):
(WebCore::Layout::InlineRect::moveBy):
(WebCore::Layout::InlineRect::expand):
(WebCore::Layout::InlineRect::expandToContain):
(WebCore::Layout::InlineRect::expandVerticallyToContain):
(WebCore::Layout::InlineRect::inflate):
(WebCore::Layout::InlineRect::operator InlineLayoutRect const):

8:58 PM Changeset in webkit [267181] by weinig@apple.com

• 7 edits
  3 adds in trunk/Source/WebKit

WebPreferences.yaml is overwhelming, what if we split it up a bit
​https://bugs.webkit.org/show_bug.cgi?id=216627

Reviewed by Tim Horton.

Split out experimental, internal and debug preferences into their own
yaml files to add a bit of order.

• CMakeLists.txt:
• DerivedSources.make:
• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDebug.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
• Shared/WebPreferencesExperimental.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
• Shared/WebPreferencesInternal.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
• WebKit.xcodeproj/project.pbxproj:

7:59 PM Changeset in webkit [267180] by Alan Bujtas

• 10 edits in trunk/Source/WebCore

[LFC] Remove partial invalidation
​https://bugs.webkit.org/show_bug.cgi?id=216631

Reviewed by Simon Fraser.

Invalidation fails when the LayoutTree does not match the RenderTree structures (e.g. table wrapper box).
Since incremental layouts are not supported yet, it has a very little value. Let's remove it for now.

• layout/display/DisplayView.h:
• layout/integration/LayoutIntegrationLineLayout.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::LayoutTree::LayoutTree):
(WebCore::Layout::TreeBuilder::buildLayoutTree):
(WebCore::Layout::TreeBuilder::TreeBuilder):
(WebCore::Layout::TreeBuilder::createReplacedBox):
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLineBreakBox):
(WebCore::Layout::TreeBuilder::createContainer):
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::printLayoutTreeForLiveDocuments):
(WebCore::Layout::LayoutTreeContent::LayoutTreeContent): Deleted.
(WebCore::Layout::LayoutTreeContent::addLayoutBoxForRenderer): Deleted.
(WebCore::Layout::TreeBuilder::buildTree): Deleted.

• layout/layouttree/LayoutTreeBuilder.h:

(WebCore::Layout::LayoutTree::root const):
(WebCore::Layout::LayoutTree::append):
(WebCore::Layout::LayoutTreeContent::rootLayoutBox const): Deleted.
(WebCore::Layout::LayoutTreeContent::rootLayoutBox): Deleted.
(WebCore::Layout::LayoutTreeContent::rootRenderer const): Deleted.
(WebCore::Layout::LayoutTreeContent::addBox): Deleted.
(WebCore::Layout::LayoutTreeContent::addContainer): Deleted.
(WebCore::Layout::LayoutTreeContent::layoutBoxForRenderer): Deleted.
(WebCore::Layout::LayoutTreeContent::layoutBoxForRenderer const): Deleted.
(WebCore::Layout::LayoutTreeContent::rendererForLayoutBox const): Deleted.

• page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):
(WebCore::FrameViewLayoutContext::invalidateLayoutTreeContent): Deleted.
(WebCore::FrameViewLayoutContext::invalidateLayoutState): Deleted.

• page/FrameViewLayoutContext.h:

(WebCore::FrameViewLayoutContext::layoutFormattingState const):
(WebCore::FrameViewLayoutContext::layoutTreeContent const): Deleted.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::attachToRenderElementInternal):
(WebCore::RenderTreeBuilder::detachFromRenderElement):

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRendererStyle):

7:58 PM Changeset in webkit [267179] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216634

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:23 PM Changeset in webkit [267178] by Hector Lopez

• 2 edits in trunk/LayoutTests

Added fast/selectors/selection-window-inactive-stroke-color.html to bug and changed expectations
​https://bugs.webkit.org/show_bug.cgi?id=216394

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:05 PM Changeset in webkit [267177] by Fujii Hironori

• 14 edits
  3 adds in trunk

[CMake] Add a new library target TestRunnerShared
​https://bugs.webkit.org/show_bug.cgi?id=216465

.:

WinCairo port is using both DRT and WTR. However, it has a problem
for precompiled header builds to compile the source of
TestRunnerShared twice for DRT and WTR.

Add a new library target TestRunnerShared. Re-enable precompiled
header for DRT and WTR for WinCairo.

Reviewed by Don Olmstead.

• Source/cmake/OptionsWinCairo.cmake:
• Source/cmake/WebKitFS.cmake:

Tools:

Reviewed by Don Olmstead.

• DumpRenderTree/CMakeLists.txt:
• DumpRenderTree/PlatformWin.cmake:
• PlatformFTW.cmake:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• PlatformWPE.cmake:
• PlatformWin.cmake:
• TestRunnerShared/CMakeLists.txt: Added.
• TestRunnerShared/config/config.h: Added.
• WebKitTestRunner/CMakeLists.txt:
• WebKitTestRunner/PlatformFTW.cmake:
• WebKitTestRunner/PlatformWin.cmake:

6:57 PM Changeset in webkit [267176] by Kate Cheney

• 3 edits in trunk/Source/WebKit

Revert _setIgnoresAppBoundDomains SPI to compile for macOS
​https://bugs.webkit.org/show_bug.cgi?id=216628
<rdar://problem/69025655>

Reviewed by Tim Horton.

We need to give users of the _setIgnoresAppBoundDomains SPI time to
convert uses to iOS only, so in the meantime we should still compile
the SPI for macOS so we don't break anything.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

6:53 PM Changeset in webkit [267175] by rniwa@webkit.org

• 8 edits in trunk/Source/WebCore

MutationObserverRegistration should be ref counted
​https://bugs.webkit.org/show_bug.cgi?id=216528

Reviewed by Darin Adler.

This patch makes MutationObserverRegistration ref counted so that the transient registry can store
Ref<MutationObserverRegistration> instead of a raw pointer. It also merges NodeMutationObserverData
into NodeRareData now that NodeRareData is actually rare after r266714 and r266769.

Before this patch, MutationObserverRegistration had to be kept alive by the originally observed node
using m_nodeKeptAlive whenever a transient observation occurs (i.e. observation of a node which used
to be a part of the subtree of the observed node). With this patch, this complexity is eliminated.

No new tests since there should be no behavioral difference.

• dom/MutationObserver.cpp:

(WebCore::MutationObserver::disconnect): Skip any node for which the observed node had been deleted.
This means that the registration is alive for transient nodes (i.e. a node which used to be a part of
the subtree of the observed node).
(WebCore::MutationObserver::observationStarted): Converted debug assert to a release assert.
(WebCore::MutationObserver::observationEnded): Ditto.
(WebCore::MutationObserver::deliver): Simplified logic a bit using WTF::map.

• dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::create): Added.
(WebCore::MutationObserverRegistration::MutationObserverRegistration): Create a WeakPtr for m_node.
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Deleted the code for
m_nodeKeptAlive since the observed node is no longer responsible for keeping this
MutationObserverRegistration alive while transient observarion takes place.
(WebCore::MutationObserverRegistration::takeTransientRegistrations): Ditto.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom const):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet const): Skip m_node if it has been
deleted. This is possible during transient observations.

• dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration): This class is now ref counted. Also made m_node WeakPtr.
(WebCore::MutationObserverRegistration::node):

• dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::moveNodeToNewDocument):
(WebCore::Node::mutationObserverRegistry): Deleted.
(WebCore::Node::transientMutationObserverRegistry): Deleted.
(WebCore::collectMatchingObserversForMutation): Now takes a reference to registry.
(WebCore::Node::registeredMutationObservers):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver): Converted debug assertions to release assertions. With
script execution forbidden during tree mutations, this should never happen now.
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::unregisterTransientMutationObserver): Ditto.
(WebCore::Node::notifyMutationObserversNodeWillDetach):

• dom/Node.h:
• dom/NodeRareData.cpp:
• dom/NodeRareData.h:

(WebCore::NodeMutationObserverData): Merged into NodeRareData.
(WebCore::NodeRareData::mutationObserverData): Deleted.
(WebCore::NodeRareData::ensureMutationObserverData): Deleted.
(WebCore::NodeRareData::mutationObserverRegistry): Added.
(WebCore::NodeRareData::mutationObserverRegistryIfExists): Added.
(WebCore::NodeRareData::transientMutationObserverRegistry): Added.
(WebCore::NodeRareData::useTypes const):

5:23 PM Changeset in webkit [267174] by Ryan Haddad

• 2 edits in branches/safari-610-branch/LayoutTests/imported/w3c

Cherry-pick r266098. rdar://problem/67703327

Update iOS layout test results after r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt: Apparently there's a newly passing test here, too. I wonder why macOS isn't affected by this change.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:58 PM Changeset in webkit [267173] by Ryan Haddad

• 1 edit
  4 deletes in trunk/LayoutTests

Unreviewed, reverting r267171.

The tests need to be fixed

Reverted changeset:

"4 webaudio/oscillator tests missing expected results"
​https://bugs.webkit.org/show_bug.cgi?id=216625
​https://trac.webkit.org/changeset/267171

4:56 PM Changeset in webkit [267172] by weinig@apple.com

• 16 edits in trunk

Remove runtime setting for enabling/disabling CSS shadow parts
​https://bugs.webkit.org/show_bug.cgi?id=216567

Reviewed by Tim Horton.

Remove runtime setting for enabling/disabling CSS shadow parts. It is
on by default and there is no known reason one would need to disable it.

Source/WebCore:

• css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoElementType):

• dom/Element.cpp:

(WebCore::Element::partAttributeChanged):

• dom/Element.idl:
• dom/ShadowRoot.cpp:

(WebCore::parsePartMappingsList):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCSSShadowPartsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssShadowPartsEnabled const): Deleted.

• style/StyleInvalidator.cpp:

(WebCore::Style::Invalidator::invalidateShadowParts):

Source/WebKit:

• Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setCSSShadowPartsEnabled:]):
(-[WebPreferences cssShadowPartsEnabled]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

4:54 PM Changeset in webkit [267171] by Ryan Haddad

• 1 edit
  4 adds in trunk/LayoutTests

4 webaudio/oscillator tests missing expected results
​https://bugs.webkit.org/show_bug.cgi?id=216625

Unreviewed test gardening.

• webaudio/oscillator-custom-expected.txt: Added.
• webaudio/oscillator-sawtooth-expected.txt: Added.
• webaudio/oscillator-square-expected.txt: Added.
• webaudio/oscillator-triangle-expected.txt: Added.

4:26 PM Changeset in webkit [267170] by Chris Dumez

• 4 edits in trunk

AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0
​https://bugs.webkit.org/show_bug.cgi?id=216623

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero-expected.txt:

Source/WebCore:

AudioBufferSourceNode::renderFromBuffer() has special logic when pitch rate is 0 since
the output value is constant. However, that logic was wrongly always writing to the
begining of the destination buffer, ignoring the computed writeIndex. As a result,
instead of having silence at the beginning of the destination buffer, we would have
it at the end.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):

3:43 PM Changeset in webkit [267169] by Chris Dumez

• 4 edits in trunk

AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer
​https://bugs.webkit.org/show_bug.cgi?id=216622

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-start-expected.txt:

Source/WebCore:

AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer. We
are supposed to output silence. However, in order implementation, we were just resetting the offset
to 0, playing the buffer from the beginning.

To address the issue, I have dropped the logic that would reset the read offset if past the end of
the buffer.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):

(WebCore::AudioBufferSourceNode::startPlaying):
Drop dead code since m_isGrain is always true in this function.

3:40 PM Changeset in webkit [267168] by Hector Lopez

• 4 edits in trunk/LayoutTests

[ macOS iOS Debug ] imported/w3c/web-platform-tests/selection/*: 4 tests marked as slow
​https://bugs.webkit.org/show_bug.cgi?id=216492

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:

3:31 PM Changeset in webkit [267167] by Chris Dumez

• 50 edits in trunk/LayoutTests

Update WPT test harness so that webaudio tests output results that are consistent across different machines
​https://bugs.webkit.org/show_bug.cgi?id=216332

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline tests.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-scheduling-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setTargetAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-getFrequencyResponse-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

LayoutTests:

Unskip tests that should now pass on all platforms.

• TestExpectations:
• resources/testharnessreport.js:

(self.testRunner.add_completion_callback):
Our webaudio implementation uses single precision for floating point audio values. However, the tests were
printing out those values with 16 digits, even when the checks were passing. We had to skip those tests
because digits after the 6th one may differ across machines and we were getting TEXT diffs. To address the
issue we now strip arrays from PASS lines in webaudio tests output and replace them with the string
'[expected array]'. As long as the check is passing, the actual value in the array does not really matter.

• webaudio/Oscillator/no-dezippering-expected.txt:
• webaudio/Oscillator/osc-440hz-expected.txt:
• webaudio/Oscillator/osc-negative-freq-expected.txt:
• webaudio/Oscillator/start-sampling-expected.txt:
• webaudio/audioparam-cancel-and-hold-expected.txt:
• webaudio/convolvernode-unmodified-buffer-expected.txt:

Rebaseline tests.

3:30 PM Changeset in webkit [267166] by stephan.szabo@sony.com

• 35 edits in trunk

Remove ENABLE_METER_ELEMENT
​https://bugs.webkit.org/show_bug.cgi?id=216582

Reviewed by Fujii Hironori.

With PlayStation finally planning to turn this on,
no ports had this disabled, so remove the enable flag.

.:

• Source/cmake/OptionsFTW.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsPlayStation.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/WebCore:

• DerivedSources.make:
• accessibility/AXObjectCache.cpp:
• accessibility/AccessibilityObject.cpp:
• accessibility/AccessibilityProgressIndicator.cpp:
• accessibility/AccessibilityProgressIndicator.h:
• accessibility/AccessibilityRenderObject.cpp:
• css/html.css:
• html/HTMLMeterElement.cpp:
• html/HTMLMeterElement.h:
• html/HTMLMeterElement.idl:
• html/HTMLTagNames.in:
• platform/LocalizedStrings.h:
• platform/cocoa/LocalizedStringsCocoa.mm:
• rendering/RenderMeter.cpp:
• rendering/RenderMeter.h:
• rendering/RenderObject.h:
• rendering/RenderTheme.cpp:
• rendering/RenderTheme.h:
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:
• rendering/RenderThemeWin.cpp:
• rendering/RenderThemeWin.h:

Source/WTF:

• wtf/PlatformEnable.h:

Tools:

• Scripts/webkitperl/FeatureList.pm:

3:05 PM Changeset in webkit [267165] by aakash_jain@apple.com

• 2 edits in trunk/Tools

EWS emails to bot watchers about build failures should be grouped properly
​https://bugs.webkit.org/show_bug.cgi?id=216495

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Set email headers appropriately.

3:04 PM Changeset in webkit [267164] by weinig@apple.com

• 25 edits
  2 deletes in trunk

Remove runtime setting for enabling/disabling the isSecureContext API?
​https://bugs.webkit.org/show_bug.cgi?id=216562

Reviewed by Darin Adler.

Remove runtime setting for enabling/disabling the the isSecureContext attribute.
on window and the worker global scope. There is no known reason one would need
to disable it.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setIsSecureContextAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::isSecureContextAttributeEnabled const): Deleted.

• page/WindowOrWorkerGlobalScope.idl:

Source/WebKit:

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetIsSecureContextAttributeEnabled):
(WKPreferencesGetIsSecureContextAttributeEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setIsSecureContextAttributeEnabled:]):
(-[WebPreferences isSecureContextAttributeEnabled]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setIsSecureContextAttributeEnabled):
(WebPreferences::isSecureContextAttributeEnabled):

• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

• DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

• DumpRenderTree/TestOptions.h:
• DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

• DumpRenderTree/win/DumpRenderTree.cpp:

(setWebPreferencesForTestOptions):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

• platform/win/TestExpectations:
• security/isSecureContext-disabled-expected.txt: Removed.
• security/isSecureContext-disabled.html: Removed.

3:04 PM Changeset in webkit [267163] by sbarati@apple.com

• 3 edits
  1 add in trunk

Don't IC a null custom accessor/value setter
​https://bugs.webkit.org/show_bug.cgi?id=216620
<rdar://problem/68976066>

Reviewed by Mark Lam.

JSTests:

• stress/dont-ic-null-custom-setter.js: Added.

Source/JavaScriptCore:

Our runtime allows CustomGetterSetter objects setter field to not contain an
actual C function to call. In such a scenario, the runtime just does nothing
except return false to the ::put code (which may result in throwing an
exception in strict mode code).

However, our IC code never considered whether this function could be nullptr.
The fix here is simple: don't IC such custom accessor/value setters.

• runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::isCacheableCustom const):

2:56 PM Changeset in webkit [267162] by jer.noble@apple.com

• 4 edits in trunk

REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216619

Reviewed by Chris Dumez.

Tools:

In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

• platform/mac-wk2/TestExpectations:

2:52 PM Changeset in webkit [267161] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
​https://bugs.webkit.org/show_bug.cgi?id=216566

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.

2:34 PM Changeset in webkit [267160] by Ryan Haddad

• 19 edits
  37 copies
  1 move
  14 adds
  8 deletes in branches/safari-610-branch/LayoutTests

Unreviewed test gardening, land baselines for rdar://67764580 and rdar://68372418.

• platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
• platform/mac-bigsur/fast/css/text-overflow-input-expected.txt: Removed.
• platform/mac-bigsur/fast/forms/button-sizes-expected.txt: Removed.
• platform/mac-bigsur/fast/forms/input-button-sizes-expected.txt: Removed.
• platform/mac-bigsur/fast/forms/listbox-bidi-align-expected.txt: Removed.
• platform/mac-bigsur/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
• platform/mac-bigsur/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
• platform/mac-bigsur/tables/mozilla/bugs/bug33855-expected.txt: Removed.
• platform/mac-catalina/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt.
• platform/mac-catalina/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
• platform/mac-catalina/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
• platform/mac-catalina/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
• platform/mac-catalina/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
• platform/mac-catalina/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/forms/button-table-styles-expected.txt.
• platform/mac-catalina/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
• platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
• platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
• platform/mac-catalina/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
• platform/mac-catalina/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
• platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
• platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
• platform/mac-catalina/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
• platform/mac-catalina/fast/forms/select/optgroup-rendering-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt.
• platform/mac-catalina/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
• platform/mac-catalina/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
• platform/mac-catalina/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
• platform/mac-catalina/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
• platform/mac-catalina/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Renamed from LayoutTests/platform/mac-bigsur/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
• platform/mac-mojave/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt.
• platform/mac-mojave/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
• platform/mac-mojave/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
• platform/mac-mojave/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
• platform/mac-mojave/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
• platform/mac-mojave/fast/forms/button-table-styles-expected.txt: Renamed from LayoutTests/platform/mac-bigsur/fast/forms/button-table-styles-expected.txt.
• platform/mac-mojave/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
• platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
• platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
• platform/mac-mojave/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
• platform/mac-mojave/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
• platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
• platform/mac-mojave/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
• platform/mac-mojave/fast/forms/select/optgroup-rendering-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt.
• platform/mac-mojave/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
• platform/mac-mojave/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
• platform/mac-mojave/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
• platform/mac-mojave/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
• platform/mac/fast/css/continuationCrash-expected.txt:
• platform/mac/fast/css/text-overflow-input-expected.txt:
• platform/mac/fast/forms/button-positioned-expected.txt:
• platform/mac/fast/forms/button-sizes-expected.txt:
• platform/mac/fast/forms/input-button-sizes-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/input-text-word-wrap-expected.txt:
• platform/mac/fast/forms/listbox-bidi-align-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/select-selected-expected.txt:
• platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
• platform/mac/fast/parser/document-write-option-expected.txt:
• platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/mac/tables/mozilla/bugs/bug33855-expected.txt:

2:11 PM Changeset in webkit [267159] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[Flatpak SDK][WPE] Launching the remote inspector kills MB
​https://bugs.webkit.org/show_bug.cgi?id=213899

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-09-16
Reviewed by Adrian Perez de Castro.

Load inspector resources from developer build artefacts, when the inspector server is
running in this configuration. Fall back to system libraries loading mechanism otherwise.

• inspector/remote/glib/RemoteInspectorUtils.cpp:

(Inspector::backendCommands):

1:58 PM Changeset in webkit [267158] by Alan Bujtas

• 23 edits in trunk/Source/WebCore

[LFC] Box geometry is all logical
​https://bugs.webkit.org/show_bug.cgi?id=216614

Reviewed by Simon Fraser.

Rename top/left/bottom/right/width/height to logical*. These coordinates are in the Layout namespace, therefore they are all logical.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):

• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layout):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticVerticalPosition const):

• layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeHeightAndMarginForTableBox):

• layout/display/DisplayLayerController.cpp:

(WebCore::Display::LayerController::prepareForDisplay):

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBoxDecoration):
(WebCore::Display::Painter::absoluteBoxGeometry):
(WebCore::Display::paintSubtree):
(WebCore::Display::collectPaintRootsAndContentRect):

• layout/flexformatting/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):

• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::append):
(WebCore::Layout::FloatingContext::mapTopLeftToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):

• layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::rectWithMargin const):
(WebCore::Layout::FloatingState::FloatItem::bottom const):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::inlineItemWidth const):

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::prepareFloatingState):

• layout/layouttree/LayoutBoxGeometry.cpp:

(WebCore::Layout::BoxGeometry::borderBox const):

• layout/layouttree/LayoutBoxGeometry.h:

(WebCore::Layout::BoxGeometry::logicalBottom const):
(WebCore::Layout::BoxGeometry::logicalRight const):
(WebCore::Layout::BoxGeometry::logicalBottomRight const):
(WebCore::Layout::BoxGeometry::logicalSize const):
(WebCore::Layout::BoxGeometry::logicalWidth const):
(WebCore::Layout::BoxGeometry::logicalHeight const):
(WebCore::Layout::BoxGeometry::isEmpty const):
(WebCore::Layout::BoxGeometry::logicalRect const):
(WebCore::Layout::BoxGeometry::logicalRectWithMargin const):
(WebCore::Layout::BoxGeometry::logicalTop const):
(WebCore::Layout::BoxGeometry::logicalLeft const):
(WebCore::Layout::BoxGeometry::logicalTopLeft const):
(WebCore::Layout::BoxGeometry::setLogicalTopLeft):
(WebCore::Layout::BoxGeometry::setLogicalTop):
(WebCore::Layout::BoxGeometry::setLogicalLeft):
(WebCore::Layout::BoxGeometry::bottom const): Deleted.
(WebCore::Layout::BoxGeometry::right const): Deleted.
(WebCore::Layout::BoxGeometry::bottomRight const): Deleted.
(WebCore::Layout::BoxGeometry::size const): Deleted.
(WebCore::Layout::BoxGeometry::width const): Deleted.
(WebCore::Layout::BoxGeometry::height const): Deleted.
(WebCore::Layout::BoxGeometry::rect const): Deleted.
(WebCore::Layout::BoxGeometry::rectWithMargin const): Deleted.
(WebCore::Layout::BoxGeometry::top const): Deleted.
(WebCore::Layout::BoxGeometry::left const): Deleted.
(WebCore::Layout::BoxGeometry::topLeft const): Deleted.
(WebCore::Layout::BoxGeometry::setTopLeft): Deleted.
(WebCore::Layout::BoxGeometry::setTop): Deleted.
(WebCore::Layout::BoxGeometry::setLeft): Deleted.

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):

• layout/tableformatting/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):

• page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):

1:09 PM Changeset in webkit [267157] by Alan Bujtas

• 10 edits
  3 adds in trunk

[LFC][FFC] Add basic flex item sizing and positioning
​https://bugs.webkit.org/show_bug.cgi?id=216613

Reviewed by Antti Koivisto.

Source/WebCore:

This patch adds support for single line (no-wrap), row based flex item layout with default spacing.

Test: fast/layoutformattingcontext/flex-box-simple.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

• layout/flexformatting/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::layoutInFlowContent):
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):
(WebCore::Layout::FlexFormattingContext::computeIntrinsicWidthConstraintsForFlexItems):

• layout/flexformatting/FlexFormattingContext.h:

(WebCore::Layout::FlexFormattingContext::Geometry::Geometry):

• layout/flexformatting/FlexFormattingContextGeometry.cpp: Added.

(WebCore::Layout::FlexFormattingContext::Geometry::intrinsicWidthConstraints):

• layout/flexformatting/FlexFormattingState.h:

(WebCore::Layout::FlexFormattingState::lines const): Flex layout has the concept of lines where flex wrap may trigger multi-line layout.
(WebCore::Layout::FlexFormattingState::addLine):

LayoutTests:

• fast/layoutformattingcontext/flex-box-simple-expected.html: Added.
• fast/layoutformattingcontext/flex-box-simple.html: Added.

12:07 PM HackingWebInspector edited by Nikita Vasilyev

Replace IRC with Slack. Update paths. (diff)

11:43 AM Changeset in webkit [267156] by youenn@apple.com

• 13 edits in trunk/Source/WebKit

RemoteSampleBufferDisplayLayer should process its IPC messages from a background thread
​https://bugs.webkit.org/show_bug.cgi?id=216475

Reviewed by Eric Carlson.

Use a process wide work queue to process all track video renderer messages in a background thread.
This queue is shared by all RemoteSampleBufferDisplayLayerManager and RemoteSampleBufferDisplayLayer objects, which are per web process.
Since LocalSampleBufferDisplayLayer must currently be created in main thread, hop to main thread to create/delete renderers.

We update messages.py to support WantsAsyncDispatchMessage, which removes the sync handling with dispatchMessage.
This allows RemoteSampleBufferDisplayLayerManager to also handle messages from RemoteSampleBufferDisplayLayer.
Update RemoteSampleBufferDisplayLayerManager accordingly as well.

Covered by webrtc/video.html with GPU process enabled.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::videoMediaStreamTrackRendererQueue):

• GPUProcess/GPUProcess.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp:

(WebKit::RemoteAudioMediaStreamTrackRendererManager::dispatchMessage):

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.messages.in:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:

(WebKit::RemoteSampleBufferDisplayLayerManager::RemoteSampleBufferDisplayLayerManager):
(WebKit::RemoteSampleBufferDisplayLayerManager::~RemoteSampleBufferDisplayLayerManager):
(WebKit::RemoteSampleBufferDisplayLayerManager::close):
(WebKit::RemoteSampleBufferDisplayLayerManager::dispatchToThread):
(WebKit::RemoteSampleBufferDisplayLayerManager::dispatchMessage):
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
(WebKit::RemoteSampleBufferDisplayLayerManager::releaseLayer):

• GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
• Scripts/webkit/messages.py:
• SourcesCocoa.txt:

11:21 AM Changeset in webkit [267155] by commit-queue@webkit.org

• 14 edits in trunk/Source/WebKit

Move TLS certificate bypass SPI from WebProcessPool to WebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=216585

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-16
Reviewed by Geoffrey Garen.

It will eventually be replaced by WKNavigationDelegate's didReceiveAuthenticationChallenge in rdar://30655740
but the SPI needs to continue to exist somewhere until that is complete.
In the meantime, it needs to be moved from the WebProcessPool for ​https://bugs.webkit.org/show_bug.cgi?id=216041
and rdar://problem/68942815 tracks Safari's adoption of the SPI introduced here, which I will fix within an hour of landing this.

• UIProcess/API/C/WKContext.cpp:

(WKContextAllowSpecificHTTPSCertificateForHost):

• UIProcess/API/C/WKContextPrivate.h:
• UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]): Deleted.

• UIProcess/API/Cocoa/WKProcessGroupPrivate.h:
• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _allowTLSCertificate:forHost:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_allow_tls_certificate_for_host):
Use the default data store until this API can be replaced by API in a different place.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::allowSpecificHTTPSCertificateForHost): Deleted.

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::allowSpecificHTTPSCertificateForHost):

• UIProcess/WebsiteData/WebsiteDataStore.h:

10:57 AM Changeset in webkit [267154] by Chris Lord

• 118 edits in trunk

Enable full CSS color parsing within a worker for OffscreenCanvas
​https://bugs.webkit.org/show_bug.cgi?id=204575

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing OffscreenCanvas tests now that full CSS color
parsing is available.

• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-4.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-5-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-5.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-6-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-6.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-6-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-6.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgb-eof-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgb-eof.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-eof-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-eof.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-1-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-1.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-2-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-2.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-3-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-3.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-4-expected.txt:
• web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-4.worker-expected.txt:

Source/WebCore:

Enable full CSS color parsing in OffscreenCanvas by removing the
unnecessary use of CSSValuePool::singleton in color-parsing code in
CSSPropertyParserHelpers and adding a new helper function to return a
Color instead of a CSSPrimitiveValue when parsing a color.

Rebaselined existing layout tests.

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeDegrees const):

• css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::computeDegrees):

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseColorWorkerSafe):

• css/parser/CSSParser.h:
• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumePercentRaw):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeAngleRaw):
(WebCore::CSSPropertyParserHelpers::consumePercentRaw):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumeAngleRaw):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::clampRGBComponent):
(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::consumeColorWorkerSafe):

• css/parser/CSSPropertyParserHelpers.h:

10:40 AM Changeset in webkit [267153] by Chris Dumez

• 27 edits in trunk

Merge PeriodicWave improvements from Blink
​https://bugs.webkit.org/show_bug.cgi?id=216576

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline tests that now have a slightly different output.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

Source/WebCore:

Merge PeriodicWave improvements from Blink:

• ​https://codereview.chromium.org/1180613007
• ​https://codereview.chromium.org/66393004

These fixes allow us to pass some of the tests imported from Blink.

No new tests, rebaselined existing tests.

• Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::maxNumberOfPartials const):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):
(WebCore::PeriodicWave::periodicWaveSize const):

• Modules/webaudio/PeriodicWave.h:

LayoutTests:

Rebaseline tests that are now passing.

• webaudio/Oscillator/no-dezippering-expected.txt:
• webaudio/Oscillator/osc-negative-freq-expected.txt:
• webaudio/Oscillator/osc-sweep-snr-triangle-expected.txt:
• webaudio/Oscillator/start-sampling-expected.txt:

10:08 AM Changeset in webkit [267152] by Hector Lopez

• 2 edits in trunk/LayoutTests

Correction to test expectation for imported/w3c/web-platform-tests/css/css-position/fixed-z-index-blend.html
webkit.org/b/207891

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

10:06 AM Changeset in webkit [267151] by Chris Dumez

• 4 edits in trunk

OfflineAudioContext should support up to 32 channels
​https://bugs.webkit.org/show_bug.cgi?id=216587

Reviewed by Darin Adler.

Source/WebCore:

OfflineAudioContext should support up to 32 channels. It previously had
an artificial limit of 10.

No new tests, updated existing test.

• Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

LayoutTests:

Update test that is now passing.

• webaudio/dom-exceptions-expected.txt:

9:56 AM Changeset in webkit [267150] by commit-queue@webkit.org

• 6 edits in trunk/Source

Remove unneeded HAVE_FOUNDATION_WITH_SAVE_COOKIES_WITH_COMPLETION_HANDLER
​https://bugs.webkit.org/show_bug.cgi?id=216572

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-16
Reviewed by Youenn Fablet.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

It's available everywhere we support.

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::saveCookies):
(WebKit::NetworkProcess::platformFlushCookies):

Source/WTF:

• wtf/PlatformHave.h:

9:39 AM Changeset in webkit [267149] by Philippe Normand

• 2 edits in trunk/Tools

[Flatpak] webkit-bwrap drive-by cleanups

Rubber-stamped by Adrian Perez de Castro.

• flatpak/webkit-bwrap: Extend lists with tuples, use itertools and map to build the final

command line.

9:34 AM Changeset in webkit [267148] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[macOS] Limit reported macOS release to 10.15 series
​https://bugs.webkit.org/show_bug.cgi?id=216593
<rdar://problem/68937905>

Reviewed by Maciej Stachowiak.

If the reported system OS is 11.0 (or beyond) report the last stable release
of macOS.

• platform/mac/UserAgentMac.mm:

(WebCore::standardUserAgentWithApplicationName):

9:00 AM Changeset in webkit [267147] by Chris Dumez

• 15 edits in trunk

OfflineAudioContext constructor should not throw when given a bad buffer length
​https://bugs.webkit.org/show_bug.cgi?id=216584

Reviewed by Youenn Fablet.

Source/WebCore:

OfflineAudioContext constructor should not throw when given a bad buffer length. We should
instead throw later on when trying to start rendering.

No new tests, rebaselined existing test.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::OfflineAudioContext):
(WebCore::OfflineAudioContext::create):
(WebCore::OfflineAudioContext::startOfflineRendering):

• Modules/webaudio/OfflineAudioContext.h:
• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::maxChannelCount const):

LayoutTests:

Rebaseline test now that more checks are passing.

• webaudio/dom-exceptions-expected.txt:

8:55 AM Changeset in webkit [267146] by weinig@apple.com

• 7 edits
  1 add in trunk/Source/WebCore

[WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec
​https://bugs.webkit.org/show_bug.cgi?id=216590

Reviewed by Youenn Fablet.

Adds NavigatorCookies interface mixin and includes it in Navigator.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• page/Navigator.idl:
• page/NavigatorCookies.idl: Added.

8:51 AM Changeset in webkit [267145] by youenn@apple.com

• 7 edits in trunk/Source/WebKit

Move LibWebRTCCodecsProxy message handling out of the main thread
​https://bugs.webkit.org/show_bug.cgi?id=216531

Reviewed by Eric Carlson.

Use a process wide work queue to process all LibWebRTCCodecsProxy messages in a background thread.
This queue is shared by all LibWebRTCCodecsProxy objects, which are per web process.
Covered by webrtc/video.html with GPU process enabled.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):
(WebKit::GPUConnectionToWebProcess::libWebRTCCodecsProxy): Deleted.

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::libWebRTCCodecsQueue):

• GPUProcess/GPUProcess.h:
• GPUProcess/webrtc/LibWebRTCCodecsProxy.h:

(WebKit::LibWebRTCCodecsProxy::create):
(WebKit::LibWebRTCCodecsProxy::didReceiveMessageFromWebProcess): Deleted.

• GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::~LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
(WebKit::LibWebRTCCodecsProxy::close):

8:32 AM Changeset in webkit [267144] by Chris Dumez

• 3 edits
  34 adds
  4 deletes in trunk/LayoutTests

Import OscillatorNode layout tests from Blink
​https://bugs.webkit.org/show_bug.cgi?id=216569

Reviewed by Eric Carlson.

Import OscillatorNode layout tests from Blink.

• webaudio/Oscillator/no-dezippering-expected.txt: Added.
• webaudio/Oscillator/no-dezippering.html: Added.
• webaudio/Oscillator/osc-440hz-expected.txt: Added.
• webaudio/Oscillator/osc-440hz.html: Added.
• webaudio/Oscillator/osc-low-freq-expected.txt: Added.
• webaudio/Oscillator/osc-low-freq.html: Added.
• webaudio/Oscillator/osc-negative-freq-expected.txt: Added.
• webaudio/Oscillator/osc-negative-freq.html: Added.
• webaudio/Oscillator/osc-sweep-snr-custom-expected.txt: Added.
• webaudio/Oscillator/osc-sweep-snr-custom.html: Added.
• webaudio/Oscillator/osc-sweep-snr-sawtooth-expected.txt: Added.
• webaudio/Oscillator/osc-sweep-snr-sawtooth.html: Added.
• webaudio/Oscillator/osc-sweep-snr-sine-expected.txt: Added.
• webaudio/Oscillator/osc-sweep-snr-sine.html: Added.
• webaudio/Oscillator/osc-sweep-snr-square-expected.txt: Added.
• webaudio/Oscillator/osc-sweep-snr-square.html: Added.
• webaudio/Oscillator/osc-sweep-snr-triangle-expected.txt: Added.
• webaudio/Oscillator/osc-sweep-snr-triangle.html: Added.
• webaudio/Oscillator/oscillator-basic-expected.txt: Added.
• webaudio/Oscillator/oscillator-basic.html: Added.
• webaudio/Oscillator/oscillator-ended-expected.txt: Added.
• webaudio/Oscillator/oscillator-ended.html: Added.
• webaudio/Oscillator/oscillator-late-start-expected.txt: Added.
• webaudio/Oscillator/oscillator-late-start.html: Added.
• webaudio/Oscillator/start-sampling-expected.txt: Added.
• webaudio/Oscillator/start-sampling.html: Added.
• webaudio/oscillator-basic-expected.txt: Removed.
• webaudio/oscillator-basic.html: Removed.
• webaudio/oscillator-ended-expected.txt: Removed.
• webaudio/oscillator-ended.html: Removed.
• webaudio/resources/audio-file-utils.js: Added.
• webaudio/resources/oscillator-testing.js:
• webaudio/resources/start-stop-exceptions.js: Added.

8:09 AM Changeset in webkit [267143] by Adrian Perez de Castro

• 32 edits in trunk/Source

Non-unified build fixes, early September 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=216599

Unreviewed build fix.

Largely based on a patch by Lauro Moura <Lauro Moura>

Source/JavaScriptCore:

• runtime/IntlCache.cpp: Add missing wtf/Vector.h include.
• runtime/IntlCache.h: Add missing wtf/text/CString.h include.
• runtime/IntlNumberFormatPrototype.cpp: Replace IntlNumberFormat.h

include with IntlNumberFormatInlines.h to fix linking.

Source/WebCore:

• Modules/async-clipboard/ClipboardImageReader.cpp: Add missing Document.h include.
• Modules/async-clipboard/ClipboardImageReader.h: Add missing forward declaration

for Document.

• Modules/fetch/FetchBodyConsumer.cpp: Add missing includes for DOMFormData.h,

HTTPParsers.h, and JSDOMFormData.h.

• css/parser/CSSSelectorParser.cpp: Move CSSSelectorParser declaration to header.
• css/parser/CSSSelectorParser.h: Ditto.
• css/parser/CSSSupportsParser.cpp: Add missing CSSSelectorParser.h include.
• dom/DataTransferItemList.cpp: Add missing includes for ContextDestructionObserver.h

and Document.h.

• html/HTMLMetaElement.cpp: Add missing includes for Settings.h and

wtf/IsoMallocInlines.h.

• html/canvas/EXTBlendMinMax.cpp: Add missing wtf/IsoMallocInlines.h include.
• html/canvas/EXTColorBufferFloat.cpp: Ditto.
• html/canvas/OESElementIndexUint.cpp: Ditto.
• html/canvas/WebGLCompressedTextureASTC.cpp: Ditto.
• html/canvas/WebGLCompressedTextureATC.cpp: Ditto.
• html/canvas/WebGLCompressedTextureETC.cpp: Ditto.
• inspector/InspectorFrontendHost.cpp: Add missing Settings.h include.
• layout/display/DisplayLayerController.cpp: Add missing LayoutState.h include.
• layout/displaytree/DisplayPainter.h: Add missing LayoutBox.h include.
• layout/inlineformatting/InlineLineBox.cpp: Add missing InlineFormattingContext.h

include.

• platform/audio/FFTFrame.cpp: Add missing VectorMath.h include.
• platform/audio/SincResampler.h: Add missing wtf/Optional.h include.
• rendering/SimpleLineLayout.h: Add missing RenderStyleConstants.h include.

Source/WebKit:

• GPUProcess/media/RemoteCDMProxy.cpp: Add missing WebCore/SharedBuffer.h include.
• GPUProcess/media/RemoteMediaResourceLoader.cpp: Add missing WebCore/ResourceError.h

include.

• NetworkProcess/webrtc/NetworkRTCProvider.cpp: Add missing DataReference.h include.
• UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::show): Add missing namespace to
WebCore::monitorWorkArea() call.

• WebProcess/Network/WebSocketChannelManager.cpp: Add missing

WebCore/WebSocketIdentifier.h include.
(WebKit::WebSocketChannelManager::didReceiveMessage): Add missing namespace to
WebCore::WebSocketIdentifierType usage.

7:05 AM Changeset in webkit [267142] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][FFC] Create a Layout::ContainerBox for flex container
​https://bugs.webkit.org/show_bug.cgi?id=216598

Reviewed by Antti Koivisto.

A flex container establishes a flex formatting context.

• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::createFormattingContext):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):

6:45 AM Changeset in webkit [267141] by Aditya Keerthi

• 4 edits
  2 adds in trunk

[Cocoa] Use OTF font features instead of AAT font features when possible
​https://bugs.webkit.org/show_bug.cgi?id=182845
<rdar://problem/33046942>

Reviewed by Myles C. Maxfield.

Source/WebCore:

Using OTF font features instead of AAT font features allows WebKit to
leverage CoreText's mapping between OTF and AAT features. This prevents us
from having to maintain our own mapping, and adds support for previously
missing features (for AAT fonts), such as stylistic alternatives.

Note that the hlig and hist features are not mapped by CoreText for AAT
fonts, in which case we handle the mapping to an AAT font feature ourselves.

Test: css3/font-feature-settings-stylistic-set.html

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::appendTrueTypeFeature):
(WebCore::preparePlatformFont):

LayoutTests:

• css3/font-feature-settings-stylistic-set-expected-mismatch.html: Added.
• css3/font-feature-settings-stylistic-set.html: Added.
• platform/win/TestExpectations:

6:17 AM WebKitGTK/2.30.x edited by Carlos Garcia Campos

(diff)

3:26 AM WebKitFlatpakSDK/PerfTools edited by Philippe Normand

(diff)

3:24 AM WebKitFlatpakSDK/PerfTools edited by Philippe Normand

(diff)

2:20 AM WebKitFlatpakSDK/PerfTools created by Philippe Normand

2:16 AM WebKitFlatpakSDK edited by Philippe Normand

(diff)

12:18 AM Changeset in webkit [267140] by Philippe Normand

• 2 edits
  3 adds in trunk/Tools

[Flatpak SDK] Cherry-pick Mesa use-after-free fixes
​https://bugs.webkit.org/show_bug.cgi?id=216532

Reviewed by Žan Doberšek.

These patches are not in any stable Mesa release yet. The crash is happening on various
tests on both WPE and GTK test bots.

Upstream MR: ​https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5789

• buildstream/elements/sdk/mesa.bst:
• buildstream/patches/mesa/0001-mesa-rename-_mesa_free_errors_data.patch: Added.
• buildstream/patches/mesa/0002-mesa-add-bool-param-to-_mesa_free_context_data.patch: Added.
• buildstream/patches/mesa/0003-mesa-st-release-debug_output-after-destroying-the-co.patch: Added.

12:10 AM Changeset in webkit [267139] by Philippe Normand

• 7 edits
  9 deletes in trunk/Tools

[GStreamer] Update Flatpak SDK to 1.18.0
​https://bugs.webkit.org/show_bug.cgi?id=216270

Reviewed by Žan Doberšek.

Update to GStreamer 1.18.0, removing the patches now being shipped in this release.

• buildstream/elements/sdk/gst-libav.bst:
• buildstream/elements/sdk/gst-plugins-bad.bst:
• buildstream/elements/sdk/gst-plugins-base.bst:
• buildstream/elements/sdk/gst-plugins-good.bst:
• buildstream/elements/sdk/gst-plugins-ugly.bst:
• buildstream/elements/sdk/gstreamer.bst:
• buildstream/patches/gst-libav-stop-caching-codecs.patch: Removed.
• buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Removed.
• buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Removed.
• buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch: Removed.
• buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Removed.
• buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Removed.
• buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Removed.
• buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Removed.
• buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Removed.

12:08 AM Changeset in webkit [267138] by Philippe Normand

• 5 edits in trunk/Source/WebCore

[GStreamer][1.18] Regressions
​https://bugs.webkit.org/show_bug.cgi?id=216558

Reviewed by Xabier Rodriguez-Calvar.

The most significant change here is the added support for video rendering stats caching.
This was caught by
imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html

• platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:

(webKitGLVideoSinkGetProperty): Fix 1.18 version runtime check. 1.17 was the development version of 1.18.

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const): Ditto.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createVideoSink): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::videoPlaybackQualityMetrics): Cache or reuse cached
statistics. Caching is required so that metrics queries performed after EOS still return
valid values.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: