Timeline

Sep 19, 2020:

9:32 PM Changeset in webkit [267323] by Lauro Moura

• 2 edits in trunk/Tools

[GLIB] Merge API test expectations

Unreviewed test gardening.

Two TestUIClient sections were causing the first one to be ignored.

• TestWebKitAPI/glib/TestExpectations.json:

9:30 PM Changeset in webkit [267322] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GLIB] Unreviewed gardening.

• platform/glib/TestExpectations:

7:51 PM Changeset in webkit [267321] by Darin Adler

• 20 edits in trunk/LayoutTests

Selection API: Update some more tests so they don't accidentally rely on flaws in WebKit's old implementation
​https://bugs.webkit.org/show_bug.cgi?id=216737

Reviewed by Sam Weinig.

Like the three tests I modified in r267220, these tests are accidentally
depending on the fact that our selection object implementation currently
allows invalid indexes. It's clear that these are mistakes in the tests,
not intentional, and fixing these does not change the test expectations,
only the tests themselves.

• accessibility/mac/select-text-should-match-whole-words.html: Set the selection

with separate calls to the collapse function. The old code tried to reuse the
same range to set the selection back to an old value, but that won't work if
the selection updates the range (as it is supposed to do).

• editing/execCommand/indent-selection.html: Pass a valid index, 1, instead of

an invalid one, 2.

• editing/pasteboard/paste-visible-script.html: Ditto.

• editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html:

Pass a valid index, 0, instead of an invalid one, 10500000000. Also fixed line
endings in this file, which were all Windows-style CR/LF pairs to be Unix-style
LF like most of our other files.

• editing/pasteboard/testcase-9507.html: Use childNodes.length to compute a

valid index instead of passing 5, which was an invalid one.

• editing/style/apply-style-crash2.html: Pass a valid index, 0, instead of

an invalid one, 4.

• editing/style/query-typing-style.html: Pass a valid index, 0, instead of

an invalid one, 1.

• editing/undo/undo-paste-when-caret-is-not-in-range.html: Pass valid index

1 instead of invalid ones, 3 and 4.

• fast/block/float/float-list-changed-before-layout-crash.html: Pass a valid

index, 0, instead of an invalid one, 1.

• fast/dynamic/checkbox-selection-crash.html: Use childNodes.length to compute

a valid index instead of passing 1000, which was an invalid one.

• fast/repaint/selection-gap-absolute-child.html: Pass a valid index, 0, instead

of an invalid one, 1.

• fast/repaint/selection-gap-fixed-child.html: Ditto.
• fast/repaint/selection-gap-flipped-absolute-child.html: Ditto.
• fast/repaint/selection-gap-flipped-fixed-child.html: Ditto.
• fast/repaint/selection-gap-transformed-absolute-child.html: Ditto.
• fast/repaint/selection-gap-transformed-fixed-child.html: Ditto.

• fast/replaced/selection-rect.html: Select the image with a range in its

parent node with valid indices instead of relying WebKit's quirky way of
expressing selections of replaced elements, which involves an invalid index
of 1 for an image element with no children. This test has nothing to do with
the particular selection range technique used, so it's fine to change it.

• http/tests/security/resources/foreign-domain-iframe-for-selection-test.html:

Use childNodes.length to compute a valid index instead of passing 10, which was
an invalid one.

• imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash.html:

Use a valid index, 0, instead of an invalid one, 4.

11:52 AM Changeset in webkit [267320] by Andres Gonzalez

• 5 edits in trunk/Source/WebCore

Implementation for AXIsolatedObject::nextSibling and previousSibling.
​https://bugs.webkit.org/show_bug.cgi?id=216710

Reviewed by Chris Fleizach.

Implementation for AXIsolatedObject::previousSibling and nextSibling which
are invoked by VoiceOver in Safari Reader mode.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::previousSibling const):

• Fixed crash caused by dereferencing m_renderer->parent() which can be null.
• Added check for the AXObjectCache that can become null.

(WebCore::AccessibilityRenderObject::nextSibling const):

• Code style cleanup.
• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):

• Added caching of next/previousSiblling objects.

(WebCore::AXIsolatedObject::previousSibling const): Inlined in header..
(WebCore::AXIsolatedObject::nextSibling const): Inlined in header.

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/isolatedtree/AXIsolatedTree.h:

10:43 AM Changeset in webkit [267319] by Kocsen Chung

• 1 copy in tags/Safari-610.2.6.1.3

Tag Safari-610.2.6.1.3.

10:39 AM Changeset in webkit [267318] by Kocsen Chung

• 1 edit in branches/safari-610.2.6.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp

Cherry-pick r266958. rdar://problem/69202514

Unreviewed build fix for r266771. An include is missing which causes the build to fail flakily depending on the position of the cpp in the unified source file.

• UIProcess/mac/DisplayLink.cpp:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:37 AM Changeset in webkit [267317] by Kocsen Chung

• 8 edits in branches/safari-610.2.6.1-branch/Source

Versioning.

WebKit-7610.2.6.1.3

10:07 AM Changeset in webkit [267316] by weinig@apple.com

• 10 edits in trunk

Performance and PerformanceNavigation interfaces are missing toJSON operations
​https://bugs.webkit.org/show_bug.cgi?id=216728

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update results now that we pass more subtests.

• web-platform-tests/hr-time/idlharness.any-expected.txt:
• web-platform-tests/hr-time/idlharness.any.worker-expected.txt:
• web-platform-tests/hr-time/performance-tojson-expected.txt:

Source/WebCore:

Add missing toJSON operations to Performance and PerformanceNavigation and update
comments in related IDLs.

Updates results for existing tests, more of which now pass.

• page/Performance.idl:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.idl:
• page/PerformanceTiming.idl:

9:46 AM Changeset in webkit [267315] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] InlineFormattingContext::computeGeometryForLineContent should not construct Display::Lines
​https://bugs.webkit.org/show_bug.cgi?id=216723

Reviewed by Antti Koivisto.

Display::Lines construction should live in the display builder. However currently we don't yet have a real builder, so let's
just use the integration layer.
This is also in preparation for removing all the Display::InlineContent code from the Layout namespace.

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::layout):
(WebCore::LayoutIntegration::LineLayout::constructDisplayContent):

• layout/integration/LayoutIntegrationLineLayout.h:

8:05 AM Changeset in webkit [267314] by weinig@apple.com

• 8 edits
  1 copy
  1 move
  12 adds
  2 deletes in trunk/LayoutTests

Resync web-platform-tests/hr-time from upstream
​https://bugs.webkit.org/show_bug.cgi?id=216724

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Resync web-platform-tests/hr-time from upstream.

• web-platform-tests/hr-time/META.yml: Added.
• web-platform-tests/hr-time/OWNERS: Removed.
• web-platform-tests/hr-time/idlharness-expected.txt: Removed.
• web-platform-tests/hr-time/idlharness.any-expected.txt: Added.
• web-platform-tests/hr-time/idlharness.any.html: Added.
• web-platform-tests/hr-time/idlharness.any.js: Added.
• web-platform-tests/hr-time/idlharness.any.worker-expected.txt: Added.
• web-platform-tests/hr-time/idlharness.any.worker.html: Added.
• web-platform-tests/hr-time/idlharness.html: Removed.
• web-platform-tests/hr-time/monotonic-clock.any.js:
• web-platform-tests/hr-time/performance-tojson-expected.txt: Added.
• web-platform-tests/hr-time/performance-tojson.html: Added.
• web-platform-tests/hr-time/resources/unload-a.html: Added.
• web-platform-tests/hr-time/resources/unload-b.html: Added.
• web-platform-tests/hr-time/resources/unload-c.html: Added.
• web-platform-tests/hr-time/resources/unload.js: Added.
• web-platform-tests/hr-time/resources/w3c-import.log:
• web-platform-tests/hr-time/timeOrigin-expected.txt:
• web-platform-tests/hr-time/w3c-import.log:
• web-platform-tests/hr-time/window-worker-timeOrigin.window-expected.txt: Added.
• web-platform-tests/hr-time/window-worker-timeOrigin.window.html: Added.

LayoutTests:

• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

Update paths in expectations.

7:48 AM Changeset in webkit [267313] by Darin Adler

• 8 edits
  2 adds in trunk

Selection API: Extend lifetime of selection live range to preserve expando properties
​https://bugs.webkit.org/show_bug.cgi?id=216721

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/selection/expando.html

• dom/Range.cpp:

(WebCore::Range::window): Added. Returns window if range is associated with selection.

• dom/Range.h: Added window.
• dom/Range.idl: Added GenerateIsReachable=ReachableFromDOMWindow.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::disassociateLiveRange): Removed a FIXME comment about the
need for this fix.
(WebCore::FrameSelection::updateAssociatedLiveRange): Added a comment explaining
why an associated live range might not be contained in the document.

LayoutTests:

• editing/selection/expando-expected.txt: Added.
• editing/selection/expando.html: Added.

• TestExpectations: Skip the new test since DumpRenderTree doesn't support enabling

internal properties.

• platform/wk2/TestExpectations: Unskip the new test since WebKitTestRunner does.

7:22 AM Changeset in webkit [267312] by weinig@apple.com

• 8 edits
  3 adds in trunk/Source/WebCore

Add support for Settings equivilent of RuntimeConditionallyReadWrite
​https://bugs.webkit.org/show_bug.cgi?id=216697

Reviewed by Darin Adler.

Adds a new extended attribute, [SettingsConditionallyReadWrite] to allow users of
[RuntimeConditionallyReadWrite] to convert from RuntimeEnabledFeatures to Settings.

• bindings/scripts/CodeGeneratorJS.pm:

(NeedsRuntimeReadWriteCheck):
(GeneratePropertiesHashTable):
(GenerateRuntimeEnableConditionalString):
(GenerateImplementation):

• bindings/scripts/IDLAttributes.json:

Adds new extended attribute.

• bindings/scripts/test/DOMWindowConstructors.idl:
• bindings/scripts/test/JS/JSDOMWindow.cpp:
• bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp: Added.
• bindings/scripts/test/JS/JSTestConditionallyReadWrite.h: Added.
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/SupplementalDependencies.dep:
• bindings/scripts/test/TestConditionallyReadWrite.idl: Added.
• bindings/scripts/test/TestObj.idl:

Move conditionally read-write tests to a new test, TestConditionallyReadWrite.idl and
update results.

7:20 AM Changeset in webkit [267311] by weinig@apple.com

• 7 edits in trunk/Source

Remove runtime setting for enabling/disabling the CrossOriginResourcePolicy API
​https://bugs.webkit.org/show_bug.cgi?id=216561

Reviewed by Darin Adler.

Remove runtime setting for enabling/disabling CrossOriginResourcePolicy. It has been
enabled by default for a while and there are no known reasons one would need to
disable it.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCrossOriginResourcePolicyEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::crossOriginResourcePolicyEnabled const): Deleted.

Source/WebKit:

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCrossOriginResourcePolicyEnabled):
(WKPreferencesGetCrossOriginResourcePolicyEnabled):

• UIProcess/API/C/WKPreferencesRef.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

5:54 AM Changeset in webkit [267310] by Simon Fraser

• 7 edits in trunk/Source/WebCore

ASSERTION FAILED: &formattingContextRoot == m_rootContainer.get() in WebCore::Layout::LayoutState::establishedInlineFormattingState
​https://bugs.webkit.org/show_bug.cgi?id=216668

Reviewed by Zalan Bujtas.

Display::View didn't unparent the GraphicsLayers when Document::documentWillBecomeInactive() was called,
so a layer pointing to an old LayoutState would try to paint.

Fix by plumbing setIsInWindow() through to Display::View and using it to detach the root layer.

• dom/Document.cpp:

(WebCore::Document::documentWillBecomeInactive): The ASSERT_IMPLIES() is there to ensure that this isn't
a behavior change; we used to go to RenderView directly, and now go via FrameView.

• layout/display/DisplayLayerController.cpp:

(WebCore::Display::LayerController::detachRootLayer):
(WebCore::Display::LayerController::setIsInWindow):

• layout/display/DisplayLayerController.h:
• layout/display/DisplayView.cpp:

(WebCore::Display::View::setIsInWindow):

• layout/display/DisplayView.h:
• page/FrameView.cpp:

(WebCore::FrameView::setIsInWindow):

Sep 18, 2020:

11:42 PM Changeset in webkit [267309] by Diego Pino Garcia

• 2 edits in trunk/Tools

[GTK] API test /webkit/WebKitWebView/usermedia-enumeratedevices-permission-check is crashing

• TestWebKitAPI/glib/TestExpectations.json:

7:52 PM Changeset in webkit [267308] by Alan Bujtas

• 18 edits
  1 add in trunk/Source/WebCore

[LFC][IFC] Do not use Display::Line geometry in layout
​https://bugs.webkit.org/show_bug.cgi?id=216711

Reviewed by Simon Fraser.

This patch introduces Layout::LineGeometry.
LineGeometry is used to hold the logical geometry of line and it is input to subsequent layouts.
This patch is also in preparation for moving out the "displayInlineItem" construction from Layout::InlineFormattingContext.

• WebCore.xcodeproj/project.pbxproj:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):

• layout/displaytree/DisplayLine.h:

(WebCore::Display::Line::rect const):
(WebCore::Display::Line::scrollableOverflow const):
(WebCore::Display::Line::inkOverflow const):
(WebCore::Display::Line::baseline const):
(WebCore::Display::Line::Line):
(WebCore::Display::Line::left const): Deleted.
(WebCore::Display::Line::right const): Deleted.
(WebCore::Display::Line::top const): Deleted.
(WebCore::Display::Line::bottom const): Deleted.
(WebCore::Display::Line::width const): Deleted.
(WebCore::Display::Line::height const): Deleted.
(WebCore::Display::Line::moveVertically): Deleted.

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
(WebCore::Layout::InlineFormattingContext::invalidateFormattingState):

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):

• layout/inlineformatting/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::lines const):
(WebCore::Layout::InlineFormattingState::lines):
(WebCore::Layout::InlineFormattingState::addLine):
(WebCore::Layout::InlineFormattingState::clearLineAndRuns):
(WebCore::Layout::InlineFormattingState::shrinkDisplayInlineContent):
(WebCore::Layout::InlineFormattingState::clearDisplayInlineContent): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:
• layout/inlineformatting/InlineLineBuilder.h:
• layout/inlineformatting/InlineLineGeometry.h: Added.

(WebCore::Layout::InlineLineGeometry::logicalLeft const):
(WebCore::Layout::InlineLineGeometry::logicalRight const):
(WebCore::Layout::InlineLineGeometry::logicalTop const):
(WebCore::Layout::InlineLineGeometry::logicalBottom const):
(WebCore::Layout::InlineLineGeometry::logicalWidth const):
(WebCore::Layout::InlineLineGeometry::logicalHeight const):
(WebCore::Layout::InlineLineGeometry::logicalRect const):
(WebCore::Layout::InlineLineGeometry::lineBoxLogicalRect const):
(WebCore::Layout::InlineLineGeometry::baseline const):
(WebCore::Layout::InlineLineGeometry::moveVertically):
(WebCore::Layout::InlineLineGeometry::InlineLineGeometry):

• layout/inlineformatting/InlineTextItem.h:
• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::lineCount const):
(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::paint):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):

• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

7:20 PM Changeset in webkit [267307] by Chris Dumez

• 5 edits
  4 copies
  12 moves
  110 adds
  22 deletes in trunk/LayoutTests

Import remaining webaudio layout tests from Blink
​https://bugs.webkit.org/show_bug.cgi?id=216719

Reviewed by Darin Adler.

Import remaining webaudio tests from Blink that we had not imported yet.

• TestExpectations:
• webaudio/BiquadFilter/biquad-829349-expected.txt: Added.
• webaudio/BiquadFilter/biquad-829349.html: Added.
• webaudio/BiquadFilter/tail-time-allpass-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-allpass.html: Added.
• webaudio/BiquadFilter/tail-time-bandpass-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-bandpass.html: Added.
• webaudio/BiquadFilter/tail-time-highpass-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-highpass.html: Added.
• webaudio/BiquadFilter/tail-time-highshelf-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-highshelf.html: Added.
• webaudio/BiquadFilter/tail-time-lowpass-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-lowpass.html: Added.
• webaudio/BiquadFilter/tail-time-lowshelf-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-lowshelf.html: Added.
• webaudio/BiquadFilter/tail-time-notch-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-notch.html: Added.
• webaudio/BiquadFilter/tail-time-peaking-expected.txt: Added.
• webaudio/BiquadFilter/tail-time-peaking.html: Added.
• webaudio/BiquadFilter/test-tail-time.js: Added.

(testTailTime):

• webaudio/BiquadFilter/unstable-filter-warning-expected.txt: Added.
• webaudio/BiquadFilter/unstable-filter-warning.html: Added.
• webaudio/ChannelMerger/audiochannelmerger-cycle-expected.txt: Added.
• webaudio/ChannelMerger/audiochannelmerger-cycle.html: Added.
• webaudio/Convolver/unmmodified-buffer-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
• webaudio/Convolver/unmmodified-buffer.html: Renamed from LayoutTests/webaudio/convolvernode-unmodified-buffer.html.
• webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state-expected.txt: Added.
• webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html: Added.
• webaudio/DynamicsCompressor/dynamicscompressor-simple-expected.txt: Added.
• webaudio/DynamicsCompressor/dynamicscompressor-simple.html: Added.
• webaudio/IIRFilter/iir-tail-time-expected.txt: Added.
• webaudio/IIRFilter/iir-tail-time.html: Added.
• webaudio/IIRFilter/iir-unstable-expected.txt: Added.
• webaudio/IIRFilter/iir-unstable.html: Added.
• webaudio/IIRFilter/unstable-filter-warning-expected.txt: Added.
• webaudio/IIRFilter/unstable-filter-warning.html: Added.
• webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-expected.txt: Added.
• webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html: Added.
• webaudio/MediaElementAudioSource/resampling-crash-expected.txt: Added.
• webaudio/MediaElementAudioSource/resampling-crash.html: Added.
• webaudio/MediaStreamAudioDestination/create-in-destroyed-context-expected.txt: Added.
• webaudio/MediaStreamAudioDestination/create-in-destroyed-context.html: Added.
• webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode-expected.txt: Added.
• webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode.html: Added.
• webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource-expected.txt: Added.
• webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource.html: Added.
• webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode-expected.txt: Added.
• webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-constructor-expected.txt: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-constructor.html: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-event-listener-gc-expected.txt: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-event-listener-gc.html: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic-expected.txt: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-promise-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
• webaudio/OfflineAudioContext/offlineaudiocontext-promise.html: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise-expected.txt.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise.html.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence-expected.txt.
• webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence.html.
• webaudio/OfflineAudioContext/offlineaudiocontext-thread-smoke-test-expected.txt: Added.
• webaudio/OfflineAudioContext/offlineaudiocontext-thread-smoke-test.html: Added.
• webaudio/OfflineAudioContext/onstatechange-expected.txt: Added.
• webaudio/OfflineAudioContext/onstatechange.html: Added.
• webaudio/Panner/hrtf-database-expected.txt: Added.
• webaudio/Panner/hrtf-database.html: Added.
• webaudio/Panner/panner-loop-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
• webaudio/Panner/panner-loop.html: Added.
• webaudio/Panner/panner-set-position-expected.txt: Added.
• webaudio/Panner/panner-set-position.html: Added.
• webaudio/PeriodicWave/ctor-periodicwave-expected.txt: Added.
• webaudio/PeriodicWave/ctor-periodicwave.html: Added.
• webaudio/PeriodicWave/periodicwave-contexts-expected.txt: Added.
• webaudio/PeriodicWave/periodicwave-contexts.html: Added.
• webaudio/PeriodicWave/periodicwave-exceptions-expected.txt: Added.
• webaudio/PeriodicWave/periodicwave-exceptions.html: Added.
• webaudio/PeriodicWave/periodicwave-lengths-expected.txt: Added.
• webaudio/PeriodicWave/periodicwave-lengths.html: Added.
• webaudio/PeriodicWave/periodicwave-normalization-expected.txt: Added.
• webaudio/PeriodicWave/periodicwave-normalization.html: Added.
• webaudio/ScriptProcessor/scriptprocessor-offlineaudiocontext-expected.txt: Added.
• webaudio/ScriptProcessor/scriptprocessor-offlineaudiocontext.html: Added.
• webaudio/ScriptProcessor/scriptprocessornode-0-output-channels-expected.txt: Added.
• webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html: Added.
• webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input-expected.txt: Added.
• webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html: Added.
• webaudio/ScriptProcessor/scriptprocessornode-expected.txt: Added.
• webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input-expected.txt: Added.
• webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html: Added.
• webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels-expected.txt: Added.
• webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html: Added.
• webaudio/ScriptProcessor/scriptprocessornode.html: Added.
• webaudio/WaveShaper/waveshaper-364379-expected.txt: Added.
• webaudio/WaveShaper/waveshaper-364379.html: Added.
• webaudio/WaveShaper/waveshaper-oversample-2x-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
• webaudio/WaveShaper/waveshaper-oversample-2x.html: Added.
• webaudio/WaveShaper/waveshaper-oversample-4x-expected.txt: Renamed from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
• webaudio/WaveShaper/waveshaper-oversample-4x.html: Added.
• webaudio/audio-scheduled-source-basic-expected.txt: Added.
• webaudio/audio-scheduled-source-basic.html: Added.
• webaudio/javascriptaudionode-downmix8-2channel-input-expected.txt: Removed.
• webaudio/javascriptaudionode-downmix8-2channel-input.html: Removed.
• webaudio/javascriptaudionode-expected.txt: Removed.
• webaudio/javascriptaudionode-upmix2-8channel-input-expected.txt: Removed.
• webaudio/javascriptaudionode-upmix2-8channel-input.html: Removed.
• webaudio/javascriptaudionode-zero-input-channels-expected.txt: Removed.
• webaudio/javascriptaudionode-zero-input-channels.html: Removed.
• webaudio/javascriptaudionode.html: Removed.
• webaudio/mediastreamaudiodestinationnode-expected.txt: Removed.
• webaudio/mediastreamaudiodestinationnode.html: Removed.
• webaudio/mediastreamaudiosourcenode-expected.txt: Removed.
• webaudio/mediastreamaudiosourcenode.html: Removed.
• webaudio/offlineaudiocontext-constructor-expected.txt: Removed.
• webaudio/offlineaudiocontext-constructor.html: Removed.
• webaudio/panner-loop-expected.txt: Removed.
• webaudio/panner-loop.html: Removed.
• webaudio/periodicwave-lengths-expected.txt: Removed.
• webaudio/periodicwave-lengths.html: Removed.
• webaudio/resources/audionodeoptions.js: Added.

(testAudioNodeOptions):
(initializeContext):
(testInvalidConstructor):
(testDefaultConstructor):
(testDefaultAttributes):

• webaudio/resources/biquad-filters.js: Added.

(createLowpassFilter):
(createHighpassFilter):
(normalizeFilterCoefficients):
(createBandpassFilter):
(createLowShelfFilter):
(createHighShelfFilter):
(createPeakingFilter):
(createNotchFilter):
(createAllpassFilter):
(filterData):
(createFilter):

• webaudio/resources/hrtf/Composite.flac: Added.
• webaudio/resources/hrtf/Composite.wav: Added.
• webaudio/resources/hrtf/README: Added.
• webaudio/resources/scriptprocessornode-testing-audit.js: Added.

(createBuffer):
(processAudioData):
(fillData):
(checkStereoOnlyData):
(runJSNodeTest):

• webaudio/resources/scriptprocessornode-testing.js: Added.

(createBuffer):
(processAudioData):
(fillData):
(checkStereoOnlyData):
(runJSNodeTest):

• webaudio/resources/waveshaper-testing.js:

(T0):
(T1):
(T2):
(T3):
(T4):
(generateWaveShapingCurve):
(checkShapedCurve):
(createImpulseBuffer):
(runWaveShaperOversamplingTest):

• webaudio/waveshaper-oversample-2x-expected.txt: Removed.
• webaudio/waveshaper-oversample-2x.html: Removed.
• webaudio/waveshaper-oversample-4x-expected.txt: Removed.
• webaudio/waveshaper-oversample-4x.html: Removed.

7:19 PM Changeset in webkit [267306] by ysuzuki@apple.com

• 6 edits in trunk

[JSC] Generator declaration should not be allowed in single statement context
​https://bugs.webkit.org/show_bug.cgi?id=216720

Reviewed by Ross Kirsling.

JSTests:

• stress/generator-syntax.js:

(testSyntaxError.gen):

• test262/expectations.yaml:

Source/JavaScriptCore:

Generator declaration in single statement context (like the following code) should be syntax error.
We already made async function / async generator function syntax error. We should apply the same rule
to generator declaration too.

if (false)

function * gen() { }

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseSingleFunction):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionDeclarationStatement):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseExportDeclaration):

• parser/Parser.h:

6:34 PM Changeset in webkit [267305] by Wenson Hsieh

• 4 edits in trunk

[macOS] REGRESSION (r265702): System Services receive 0 bytes when extracting selected content as rich text data
​https://bugs.webkit.org/show_bug.cgi?id=216718
<rdar://problem/69150358>

Reviewed by Tim Horton.

Source/WebKit:

Test: CopyHTML.WriteRichTextSelectionToPasteboard

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::dataSelectionForPasteboard):

After r265702, the IPCHandle received in the UI process was always being converted into a buffer of size 0,
due to using the size local variable (which is no longer set as an outparam of the sync IPC message). Instead,
use ipcHandle.dataSize.

Tools:

Add a new API test to verify that we get non-empty web archive data when using
-writeSelectionToPasteboard:types: to grab selected content as rich text data.

• TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:

6:22 PM Changeset in webkit [267304] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] PreciseAllocation's isNewlyAllocated flag should be propagated from isMarked at GC begin phase to make isLive correct
​https://bugs.webkit.org/show_bug.cgi?id=216717

Reviewed by Mark Lam.

When starting full GC, at beginMarking, PreciseAllocation's mark bit is cleared to be usable for upcoming marking.
However, this means that HeapCell::isLive will see this object as dead until it is marked.
Let's consider that this object is not newly allocated one. Then, its isNewlyAllocated is false. And now mark bit

is also cleared. Since PreciseAllocation::isLive is isNewlyAllocated

isMarked, then it looks dead, while it is live.

This confuses HeapCell:isLive function and makes some of watchpoints perform wrong decisions (e.g. this condition is
no longer valid, let's just discard it).
At the beginning of full collection, we should propagate the old mark bit to isNewlyAllocated so that it looks live
during marking. This is similar trick to MarkedBlock::aboutToMark.

• heap/PreciseAllocation.cpp:

(JSC::PreciseAllocation::flip):

5:40 PM Changeset in webkit [267303] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][FFC] Add flex box/item to showLayoutTree
​https://bugs.webkit.org/show_bug.cgi?id=216694

Reviewed by Sam Weinig.

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox): 'Table principal' -> 'Table wrapper box' for consistency sake.

5:40 PM Changeset in webkit [267302] by Alan Coon

• 1 copy in tags/Safari-610.2.6.1.2

Tag Safari-610.2.6.1.2.

5:27 PM Changeset in webkit [267301] by sbarati@apple.com

• 9 edits
  2 adds in trunk

console APIs shouldn't crash making a string that's too long for a console warning when using user provided labels
​https://bugs.webkit.org/show_bug.cgi?id=216709
<rdar://problem/68275357>

Reviewed by Mark Lam and Devin Rousso.

Source/JavaScriptCore:

Various console APIs send warnings when a label can't be found. These warnings
include the label itself. If this label has a long enough length, when we make
these warning strings, we can crash, because we exceed max string length.
This patch fixes this by truncating the label everywhere it's used if it
exceeds a length of 10000.

• inspector/JSGlobalObjectConsoleClient.cpp:

(Inspector::JSGlobalObjectConsoleClient::profile):

• inspector/ScriptArguments.h:
• inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::startTiming):
(Inspector::InspectorConsoleAgent::logTiming):
(Inspector::InspectorConsoleAgent::stopTiming):
(Inspector::InspectorConsoleAgent::count):
(Inspector::InspectorConsoleAgent::countReset):

Source/WebCore:

Test: inspector/console/console-oom.html

• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):

• inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::didReceiveResponse):

LayoutTests:

• TestExpectations:
• inspector/console/console-oom-expected.txt: Added.
• inspector/console/console-oom.html: Added.

5:17 PM Changeset in webkit [267300] by Alan Coon

• 8 edits in branches/safari-610.2.6.1-branch/Source

Versioning.

WebKit-7610.2.6.1.2

4:29 PM Changeset in webkit [267299] by Russell Epstein

• 1 copy in tags/Safari-610.2.6.1.1

Tag Safari-610.2.6.1.1.

4:20 PM Changeset in webkit [267298] by Megan Gardner

• 2 edits in trunk/Source/WebKit

Remove unneeded respondsToSelector staging for keyboard.
​https://bugs.webkit.org/show_bug.cgi?id=216421

Staging needed for dual work in UIKit in 2019, no longer needed.

Reviewed by Tim Horton.

No behavior change, covered by existing tests.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView insertText:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):

4:18 PM Changeset in webkit [267297] by Alan Coon

• 5 edits in branches/safari-610.2.6.1-branch/Source

Cherry-pick r266797. rdar://problem/68732167

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

• platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
• platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
• UIProcess/mac/DisplayLink.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:18 PM Changeset in webkit [267296] by Alan Coon

• 9 edits in branches/safari-610.2.6.1-branch/Source/WebKit

Cherry-pick r266771. rdar://problem/68732073

Regression(r260614) Power usage has increased due to extra thread hopping
​https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>

Reviewed by Simon Fraser.

Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.

• UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
• UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
• WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
• WebProcess/WebPage/EventDispatcher.h:
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:18 PM Changeset in webkit [267295] by Alan Coon

• 6 edits in branches/safari-610.2.6.1-branch/Source

Cherry-pick r266710. rdar://problem/68732167

Unreviewed, reverting r266645.
​https://bugs.webkit.org/show_bug.cgi?id=216251

Caused MotionMark regression

Reverted changeset:

"Move lazy DisplayLink tear down logic from the WebProcess to
the UIProcess"
​https://bugs.webkit.org/show_bug.cgi?id=216195
​https://trac.webkit.org/changeset/266645

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:18 PM Changeset in webkit [267294] by Alan Coon

• 6 edits in branches/safari-610.2.6.1-branch/Source

Cherry-pick r266645. rdar://problem/68732167

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

• platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
• platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

• UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
• UIProcess/mac/DisplayLink.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:18 PM Changeset in webkit [267293] by Alan Coon

• 9 edits in branches/safari-610.2.6.1-branch/Source/WebKit

Revert r266771. rdar://problem/68732073

4:18 PM Changeset in webkit [267292] by Alan Coon

• 5 edits in branches/safari-610.2.6.1-branch/Source

Revert r266797. rdar://problem/68732167

4:18 PM Changeset in webkit [267291] by Alan Coon

• 26 edits
  1 copy
  3 adds in branches/safari-610.2.6.1-branch

Cherry-pick r266846. rdar://problem/68740516

Don't create event regions when the page has no subscrollers
​https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/mac/event-region-subscroller-frame.html

fast/scrolling/mac/event-region-subscroller-overflow.html

Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.

• page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
• page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
• page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):

Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):

Don't maintain event region if there are no subscrollers and none of the other reasons were hit.

• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):

Invalidate event regions if a subscroller appears.

(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):

• rendering/RenderLayerCompositor.h:

LayoutTests:

Add overflow scrollers to some existing tests so they still generate event regions.

• fast/scrolling/ios/border-radius-event-region-expected.txt:
• fast/scrolling/ios/border-radius-event-region.html:
• fast/scrolling/ios/event-region-float-expected.txt:
• fast/scrolling/ios/event-region-float.html:
• fast/scrolling/ios/event-region-pointer-events-expected.txt:
• fast/scrolling/ios/event-region-pointer-events.html:
• fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-scale-transform-shared.html:
• fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-translate-transform-shared.html:
• fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
• fast/scrolling/ios/event-region-visibility-hidden.html:
• fast/scrolling/mac/border-radius-event-region-expected.txt:
• fast/scrolling/mac/border-radius-event-region.html:
• fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-frame.html: Added.
• fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
• fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
• fast/scrolling/mac/event-region-visibility-hidden.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:18 PM Changeset in webkit [267290] by Alan Coon

• 10 edits in branches/safari-610.2.6.1-branch/Source

Cherry-pick r266677. rdar://problem/68740526

[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
​https://bugs.webkit.org/show_bug.cgi?id=216190

Reviewed by Darin Adler.

Source/WebCore:

In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContents due to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time via MonotonicTime::now().

We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable on Page. See below for more details, as well as
the WebKit2 ChangeLog.

• page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):

Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.

• page/Page.cpp: (WebCore::Page::updateRendering):

Update m_lastRenderingUpdateTimestamp.

• page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
• rendering/PaintFrequencyTracker.h:

Drive-by cleanup: narrow the PaintFrequency enum to bool width.

(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):

Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.

(WebCore::RenderLayer::simulateFrequentPaint):

• rendering/RenderLayer.h:

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):

In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).

Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions in SinglePaintFrequencyTracking::end(). As such, we
stick with MonotonicTime::now() in WebKit1.

• WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:18 PM Changeset in webkit [267289] by Alan Coon

• 4 edits in branches/safari-610.2.6.1-branch

Cherry-pick r266232. rdar://problem/68732143

Step animations invalidate style on every rendering update whether or not they need to
​https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>

Reviewed by Antoine Quint.

Source/WebCore:

Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):

Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.

LayoutTests:

• animations/steps-transform-rendering-updates-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:54 PM Changeset in webkit [267288] by don.olmstead@sony.com

• 180 edits in trunk/Source

[WebGPU] Add ENABLE(WHLSL_COMPILER) guard
​https://bugs.webkit.org/show_bug.cgi?id=216713

Reviewed by Myles C. Maxfield.

Source/WebCore:

Replaces the ENABLE(WEBGPU) guards in the Modules/webgpu/WHLSL with ENABLE(WHLSL_COMPILER)
since not all ports need a WHLSL compiler to support WebGPU.

• Modules/webgpu/WHLSL/AST/WHLSLAST.h:
• Modules/webgpu/WHLSL/AST/WHLSLAddressEscapeMode.h:
• Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h:
• Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
• Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
• Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h:
• Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h:
• Modules/webgpu/WHLSL/AST/WHLSLBlock.h:
• Modules/webgpu/WHLSL/AST/WHLSLBooleanLiteral.h:
• Modules/webgpu/WHLSL/AST/WHLSLBreak.h:
• Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h:
• Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLCommaExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLContinue.h:
• Modules/webgpu/WHLSL/AST/WHLSLDefaultDelete.h:
• Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h:
• Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h:
• Modules/webgpu/WHLSL/AST/WHLSLEntryPointType.h:
• Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h:
• Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h:
• Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
• Modules/webgpu/WHLSL/AST/WHLSLExpression.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLFallthrough.h:
• Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h:
• Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h:
• Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:
• Modules/webgpu/WHLSL/AST/WHLSLFunctionAttribute.h:
• Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:
• Modules/webgpu/WHLSL/AST/WHLSLFunctionDefinition.h:
• Modules/webgpu/WHLSL/AST/WHLSLGlobalVariableReference.h:
• Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h:
• Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h:
• Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h:
• Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLNameSpace.h:
• Modules/webgpu/WHLSL/AST/WHLSLNamedType.h:
• Modules/webgpu/WHLSL/AST/WHLSLNativeFunctionDeclaration.h:
• Modules/webgpu/WHLSL/AST/WHLSLNativeTypeDeclaration.h:
• Modules/webgpu/WHLSL/AST/WHLSLNumThreadsFunctionAttribute.h:
• Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
• Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLQualifier.h:
• Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
• Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h:
• Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h:
• Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h:
• Modules/webgpu/WHLSL/AST/WHLSLReturn.h:
• Modules/webgpu/WHLSL/AST/WHLSLSemantic.h:
• Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h:
• Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h:
• Modules/webgpu/WHLSL/AST/WHLSLStatement.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLStatement.h:
• Modules/webgpu/WHLSL/AST/WHLSLStatementList.h:
• Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h:
• Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h:
• Modules/webgpu/WHLSL/AST/WHLSLSwitchCase.h:
• Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h:
• Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h:
• Modules/webgpu/WHLSL/AST/WHLSLType.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLType.h:
• Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.h:
• Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h:
• Modules/webgpu/WHLSL/AST/WHLSLTypeReference.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
• Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
• Modules/webgpu/WHLSL/AST/WHLSLUnnamedTypeHash.h:
• Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h:
• Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp:
• Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h:
• Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
• Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:
• Modules/webgpu/WHLSL/AST/WHLSLVariableReference.h:
• Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h:
• Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp:
• Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.h:
• Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:
• Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.h:
• Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:
• Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.cpp:
• Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.h:
• Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp:
• Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.h:
• Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.cpp:
• Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.h:
• Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:
• Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.h:
• Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.cpp:
• Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.h:
• Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
• Modules/webgpu/WHLSL/WHLSLASTDumper.h:
• Modules/webgpu/WHLSL/WHLSLBuildStandardLibraryFunctionMap.py:
• Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
• Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.h:
• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp:
• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.h:
• Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.cpp:
• Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.h:
• Modules/webgpu/WHLSL/WHLSLChecker.cpp:
• Modules/webgpu/WHLSL/WHLSLChecker.h:
• Modules/webgpu/WHLSL/WHLSLCodeLocation.h:
• Modules/webgpu/WHLSL/WHLSLComputeDimensions.cpp:
• Modules/webgpu/WHLSL/WHLSLComputeDimensions.h:
• Modules/webgpu/WHLSL/WHLSLError.h:
• Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp:
• Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.h:
• Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:
• Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
• Modules/webgpu/WHLSL/WHLSLHighZombieFinder.cpp:
• Modules/webgpu/WHLSL/WHLSLHighZombieFinder.h:
• Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
• Modules/webgpu/WHLSL/WHLSLInferTypes.h:
• Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp:
• Modules/webgpu/WHLSL/WHLSLIntrinsics.h:
• Modules/webgpu/WHLSL/WHLSLLexer.cpp:
• Modules/webgpu/WHLSL/WHLSLLexer.h:
• Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp:
• Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.h:
• Modules/webgpu/WHLSL/WHLSLNameContext.cpp:
• Modules/webgpu/WHLSL/WHLSLNameContext.h:
• Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
• Modules/webgpu/WHLSL/WHLSLNameResolver.h:
• Modules/webgpu/WHLSL/WHLSLParser.cpp:
• Modules/webgpu/WHLSL/WHLSLParser.h:
• Modules/webgpu/WHLSL/WHLSLParsingMode.h:
• Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:
• Modules/webgpu/WHLSL/WHLSLPrepare.cpp:
• Modules/webgpu/WHLSL/WHLSLPrepare.h:
• Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp:
• Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.h:
• Modules/webgpu/WHLSL/WHLSLProgram.cpp:
• Modules/webgpu/WHLSL/WHLSLProgram.h:
• Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
• Modules/webgpu/WHLSL/WHLSLPropertyResolver.h:
• Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp:
• Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.h:
• Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:
• Modules/webgpu/WHLSL/WHLSLRecursionChecker.h:
• Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:
• Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.h:
• Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:
• Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.h:
• Modules/webgpu/WHLSL/WHLSLResolvingType.h:
• Modules/webgpu/WHLSL/WHLSLScopedSetAdder.h:
• Modules/webgpu/WHLSL/WHLSLSemanticMatcher.cpp:
• Modules/webgpu/WHLSL/WHLSLSemanticMatcher.h:
• Modules/webgpu/WHLSL/WHLSLStandardLibraryFunctionMap.h:
• Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.cpp:
• Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h:
• Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:
• Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.h:
• Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
• Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.h:
• Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
• Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.h:
• Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
• Modules/webgpu/WHLSL/WHLSLVisitor.h:

Source/WTF:

Adds a default for ENABLE_WHLSL_COMPILER on Cocoa platforms.

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:

3:50 PM Changeset in webkit [267287] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Crash under WebCore::shouldResetFocusNavigationStartingNode()
​https://bugs.webkit.org/show_bug.cgi?id=216714
<rdar://problem/68132047>

Reviewed by Darin Adler.

Protect anchorElement in FrameView::scrollToFragmentInternal() to make sure
it stays alive until the time we pass it to setFocusNavigationStartingNode().

• page/FrameView.cpp:

(WebCore::FrameView::scrollToFragmentInternal):

3:27 PM Changeset in webkit [267286] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r267208. rdar://problem/69178138

Enable ITP in WKWebViews for apps with the full browser entitlement who are not linked to iOS 14.0
​https://bugs.webkit.org/show_bug.cgi?id=216655
<rdar://problem/69081227>

Reviewed by Brent Fulgham.

Apps with the full browser entitlement who are not linked to iOS 14.0
should have ITP enabled in WKWebViews by default.

No new tests, no way currently to test apps with different iOS
versions. Tested manually.

• Shared/Cocoa/DefaultWebBrowserChecks.mm: (WebKit::determineITPStateInternal): Ignore the early return for the linked-on-or-after check if the app has the default browser entitlement so we still enable ITP based on the user's preference.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:27 PM Changeset in webkit [267285] by Russell Epstein

• 3 edits
  1 add in branches/safari-610-branch

Cherry-pick r266907. rdar://problem/69178126

[JSC] unshift / shift should take structure lock
​https://bugs.webkit.org/show_bug.cgi?id=216378
<rdar://problem/68496096>

Reviewed by Mark Lam.

JSTests:

• stress/unshift-and-concurrent-access.js: Added.

Source/JavaScriptCore:

When unshifting / shifting butterfly, we need to move property storage values too.
If property storage values are moved while concurrent JIT compiler is accessing it, it could include garbage value.

For example, concurrent JIT compiler is accessing [2] property storage.

1 2 3

[ JSValue ][ JSValue ][ Header ]

But unshift moved it like this.

1 2 3

[ JSValue ][ JSValue ][ Header ]

Since butterfly pointer held by JSObject is not updated yet, concurrent JIT compiler will read [ Header ] as JSValue and crash.
In this patch, we take structure lock when shifting existing butterfly since this affect on property storage. Since JSObject::getDirectConcurrently
takes a structure lock, this locking prevents concurrent compilers from getting an invalid value.

• runtime/JSArray.cpp: (JSC::JSArray::unshiftCountSlowCase): (JSC::JSArray::shiftCountWithArrayStorage): (JSC::JSArray::unshiftCountWithArrayStorage):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:25 PM Changeset in webkit [267284] by sihui_liu@apple.com

• 9 edits in trunk

REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
​https://bugs.webkit.org/show_bug.cgi?id=216394
<rdar://problem/68679551>

Reviewed by Tim Horton.

Source/WebKit:

In WebKitTestRunner, we reset the states and load about:blank page between tests. The resetting may cause some
activity state changes of web page, like WindowIsActive. Before r266634, these changes will be dispatched
quickly enough (before runloop waits or when runloop exits) to web process, so web process can do rendering with
updated activity state. After r266634, dispatch of the changes may be delayed (until CATransaction commits).
Page activity state can affect scrollability (in FrameView::computeScrollability()) and scrollability can affect
tiling size (in TileController::computeTileSize()). Different tilings may cause the tiny pixel difference we see
in the test results.

To fix this, create an SPI for sending out activity state updates in next runloop cycle and adopt it in WTR.

• UIProcess/API/C/WKPage.cpp:

(WKPageDispatchActivityStateUpdateForTesting):

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateUpdateForTesting):

• UIProcess/WebPageProxy.h:

Tools:

Make sure activity state changes for window updates in resetStateToConsistentValues are dispatched in time.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Update test expectations as tests should be passing.

• platform/mac-wk2/TestExpectations:

2:18 PM Changeset in webkit [267283] by Aditya Keerthi

• 5 edits
  1 add in trunk

Date/time inputs should not use user-specified formats
​https://bugs.webkit.org/show_bug.cgi?id=216484
<rdar://problem/68864815>

Reviewed by Wenson Hsieh.

Source/WebCore:

On macOS, users can specify custom date and time formats through System
Preferences. These formats can be different from the default for the
user’s current locale. Using these formats when rendering date and time
inputs is a potential fingerprinting vector, as sites can apply CSS to
components of the input, and measure the size of the input.

To fix, we create a new NSLocale even if the identifier matches
[NSLocale currentLocale]. This ensures that m_locale does not contain
the user's changes to the locale.

• platform/text/cocoa/LocaleCocoa.h:
• platform/text/cocoa/LocaleCocoa.mm:

(WebCore::Locale::create):
(WebCore::LocaleCocoa::LocaleCocoa):

Tools:

Added a test which sets a custom date format using "defaults write"
and verifies that the width is indistinguishable from the default
format.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/DateInputTests.mm: Added.

(createWebViewForTest):
(DateInputsTests.IgnoresUserEditsToLocale):

1:50 PM Changeset in webkit [267282] by Lauro Moura

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline test after r266816 changed wptserve output.

• web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt:

1:34 PM Changeset in webkit [267281] by Aditya Keerthi

• 11 edits in trunk

[macOS] Date/time inputs should focus the next editable component when entering a separator key
​https://bugs.webkit.org/show_bug.cgi?id=216661
<rdar://problem/69091856>

Reviewed by Wenson Hsieh.

Source/WebCore:

NSDatePicker focuses the next editable field when entering a separator
key. We should match this behavior to be consistent with the rest of
the system.

• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):

Tools:

• WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::keyDown):

Add support for colon, semicolon, and comma keys. The keycode values are
taken from the virtual keycode values in HIToolbox/Events.h.

Note that the keycode for colon and semicolon is the same, as there is
no distinct value for colon. This is safe as it matches the Javascript
behavior.

LayoutTests:

Added new test cases to the existing set of keyboard tests for date/time inputs.

• fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events-expected.txt:
• fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events.html:
• fast/forms/time/time-editable-components/time-editable-components-keyboard-events-expected.txt:
• fast/forms/time/time-editable-components/time-editable-components-keyboard-events.html:

1:28 PM Changeset in webkit [267280] by Caio Lima

• 5 edits in trunk/JSTests

[ARMv7][MIPS] Test gaderning September version
​https://bugs.webkit.org/show_bug.cgi?id=216699

Unreviewed test gardening.

• stress/array-species-create-should-handle-masquerader.js:
• stress/compare-eq-should-use-known-other-use.js:
• stress/ftl-reflect-get-prototype-of.js:
• stress/typedarray-access-neutered.js:

1:17 PM Changeset in webkit [267279] by commit-queue@webkit.org

• 5 edits in trunk

WKWebView._tryClose should return whether it succeeded or not
​https://bugs.webkit.org/show_bug.cgi?id=216660

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-18
Reviewed by Tim Horton.

Source/WebKit:

The return value of WKPageTryClose is used by Safari.
In order to migrate to WKWebView _tryClose, we need to expose this return value.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _tryClose]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:

(TEST):

1:15 PM Changeset in webkit [267278] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Make TLSVersion.NetworkSession API test more robust
​https://bugs.webkit.org/show_bug.cgi?id=216704
<rdar://problem/68643674>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-18
Reviewed by Tim Horton.

r265573 made preconnect attempts to legacy TLS servers fail.
This caused the TLSVersion.NetworkSession to assert because the first connection attempt would fail
(and the second would succeed if it was supposed to succeed with the conditions in the test).
The test calls waitForDidFailProvisionalNavigation in cases where it is supposed to fail and
waitForDidFinishNavigation in cases where it supposed to succeed.
Like I did in r266100 with another test, use HTTPServer which allows a variable number of connection attempts.

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

12:46 PM Changeset in webkit [267277] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Make ews-app robust against config.json issues
​https://bugs.webkit.org/show_bug.cgi?id=216705

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/common/buildbot.py:

(Buildbot.fetch_config):
(Buildbot.update_icons_for_queues_mapping):

12:36 PM Changeset in webkit [267276] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266619. rdar://problem/69101154

Add a fast path in TransformationMatrix::mapRect(const FloatRect&) for affine transformations
​https://bugs.webkit.org/show_bug.cgi?id=216139

Reviewed by Tim Horton.

Add a fast path when mapping 2D points through affine transformation matrices that takes advantage of both:

1. The predetermined 0 and 1 values in affine transformation matrices.
2. The fact that points in the FloatRect are aligned with x and y axes (as opposed to a FloatQuad of 4 arbitrary

points), which allows us to avoid mapping all 4 corners of the rect through the matrix.

The current implementation of this method maps each of the 4 corners through the transformation matrix, creates
a FloatQuad using these 4 transformed points, and then asks the FloatQuad for its bounding box. This requires
a total of 26 floating point additions, 24 multiplications and 20 comparisons, as well as a small (but
measurable) amount of overhead when creating the FloatPoints and FloatQuad and asking for the bounding rect.

We can pare this down to just 8 additions, 8 multiplications, and 4 comparisons by using a different strategy
that instead branches on the 4 relevant matrix coefficients a, b, c, d (rather than the each of the final x
and y coordinates) to determine which of the min or max x and y values to multiply in order to compute the min
and max x and y coordinates in the final bounding rect.

In a quick microbenchmark that maps FloatRects through an affine TransformationMatrix, this roughly halves the
time spent in TransformationMatrix::mapRect; on the Multiply subtest of MotionMark (which invokes this method
~17 million times, almost entirely with affine transformation matrices), I measured a ~1% improvement.

• platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::mapRect const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267275] by Russell Epstein

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266513. rdar://problem/69153717

Make TransformationMatrix::inverse() faster in the case of affine transformation matrices
​https://bugs.webkit.org/show_bug.cgi?id=216101

Reviewed by Tim Horton.

The Multiply subtest of MotionMark places a large number of elements that are all rotated by some angle; when
painting these, we currently spend about 7% of the time under RenderLayer::paintLayerByApplyingTransform just
inverting the transformation matrix (underneath TransformationMatrix::inverse()) so that we can map the bounds
of the dirty rect through this inverse.

TransformationMatrix::inverse() currently has a fast path for identity and translation matrices that avoids
having to fall back to the generalized 4-by-4 matrix inverse equation; this generalized algorithm works by
dividing the entire adjoint matrix by the determinant, a process that involves nearly 1000 floating point
additions and multiplications.

However, in this case, all of the matrices are a combination of translations and rotations, which all result in
affine transformations. As such, there's no need to fall back to the generalized algorithm for computing the
inverse; instead, we can bail early with simpler strategy that only requires 15 floating point additions and
multiplications.

We can also take advantange of the fact that we currently go through most of the entries in the 4x4 matrix to
determine whether the matrix is an identity or translation matrix, by introducing a new helper method that
returns not only whether the matrix is the identity matrix or translation, but also whether the matrix is affine
(by the definition of TransformationMatrix::isAffine()). Since most of the entries that need to be 1 or 0 in
order for a matrix to be a translation matrix vs. just an affine transformation matrix are the same, this helps
avoid some redundant checks in TransformationMatrix::inverse().

We also apply a similar optimization to TransformationMatrix::isInvertible(), reducing the multiplications and
additions from roughly 200 to just 3.

I measured this locally to be a (statistically significant) 2% improvement on Multiply.

• platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::isInvertible const): (WebCore::TransformationMatrix::inverse const):
• platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::type const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267274] by Russell Epstein

• 4 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266834. rdar://problem/69101124

REGRESSION (r260360): Ionic modal dialog doesn't animate correctly when dragged and released
​https://bugs.webkit.org/show_bug.cgi?id=216308
<rdar://problem/68567444>

Reviewed by Simon Fraser.

Source/WebCore:

We fixed seeking for animations with a reversed playback rate in r261637, the fix for bug 204717,
but only looked at the animation's playback rate. However, an animation can also play in reverse
using the "direction" property of the timing object passed to updateTiming(), so we should also
check that it's playing forwards in order to be seeked.

Test: webanimations/accelerated-animation-easing-and-direction-update.html

• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::animationCanBeAccelerated const):

LayoutTests:

Add a new test that updates the "easing" and "direction" timing properties of a playing animation
and checks that it matches the display of another animation with similar timing properties from
the start.

• platform/win/TestExpectations:
• webanimations/accelerated-animation-easing-and-direction-update-expected.html: Added.
• webanimations/accelerated-animation-easing-and-direction-update.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267273] by Russell Epstein

• 8 edits in branches/safari-610-branch/Source

Cherry-pick r266802. rdar://problem/69101097

Text copied and pasted from Mac Catalyst apps appears larger than expected
​https://bugs.webkit.org/show_bug.cgi?id=215971
<rdar://problem/65768907>

Reviewed by Tim Horton.

Source/WebKit:

Various pieces of platform logic in Mac Catalyst depend on the user interface idiom (i.e. Mac or iPad) of the
app, as well as the application-wide "scale factor". In the context of this bug, NSAttributedString to RTF data
conversion methods in UIFoundation consult the scale factor of UIiOSMacIdiomManager to determine whether to
emit 0 (standard) or 1 (iOS) for the \cocoatextscaling attribute. The fact that the web process' scale factor
may be out of sync with the UI process' scale factor leads to copied RTF data in the web process appearing
either larger or smaller than expected, due to an incorrect NSTextScalingType value.

To mitigate this (as well as any other issues), we add a mechanism for the UI process to forward the global
scale factor and user interface idiom to the web process inside of the web process creation parameters, and then
use new UIKit SPI to override the scale factor and idiom within the web process.

• Scripts/process-entitlements.sh:

Add a new entitlement needed to use _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.

• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):

Use _UIApplicationCatalystUserInterfaceIdiom and _UIApplicationCatalystScaleFactor to grab the global user
interface idiom and scale factor, respectively.

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

Override the idiom and scale factor in the web process with the idiom and scale factor from the UI process,
using the new SPI _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor. As this function hasn't landed
yet, we soft link the function for now to avoid causing the web process to instantly crash on any builds without
the fix for <rdar://problem/68524148>.

Source/WTF:

Add a new flag to guard the presence of _UIApplicationCatalystUserInterfaceIdiom,
_UIApplicationCatalystScaleFactor, and _UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.

• wtf/PlatformHave.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267272] by Russell Epstein

• 5 edits
  4 adds in branches/safari-610-branch

Cherry-pick r266789. rdar://problem/69101080

REGRESSION (r264856): updating easing on accelerated animation results in incorrect playback
​https://bugs.webkit.org/show_bug.cgi?id=215853
<rdar://problem/67815853>

Reviewed by Simon Fraser.

Source/WebCore:

Stop accelerated animations if the timing function has changed in a way that makes it so that it should
no longer play accelerated, but otherwise simply update their timing properties such that may keep
playing.

Test: webanimations/accelerated-animation-easing-update-after-pause.html

webanimations/accelerated-animation-easing-update-steps-after-pause.html

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::canBeAccelerated const): (WebCore::KeyframeEffect::updateAcceleratedActions): (WebCore::KeyframeEffect::animationDidChangeTimingProperties):
• animation/KeyframeEffect.h:

LayoutTests:

Add new tests that check that updating an animation's easing does not stop it.

• platform/win/TestExpectations:
• webanimations/accelerated-animation-easing-update-after-pause-expected.html: Added.
• webanimations/accelerated-animation-easing-update-after-pause.html: Added.
• webanimations/accelerated-animation-easing-update-steps-after-pause-expected.html: Addded.
• webanimations/accelerated-animation-easing-update-steps-after-pause.html: Addded.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267271] by Russell Epstein

• 26 edits
  1 copy
  3 adds in branches/safari-610-branch

Cherry-pick r266846. rdar://problem/68740511

Don't create event regions when the page has no subscrollers
​https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/mac/event-region-subscroller-frame.html

fast/scrolling/mac/event-region-subscroller-overflow.html

Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.

• page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
• page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
• page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):

Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):

Don't maintain event region if there are no subscrollers and none of the other reasons were hit.

• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):

Invalidate event regions if a subscroller appears.

(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):

• rendering/RenderLayerCompositor.h:

LayoutTests:

Add overflow scrollers to some existing tests so they still generate event regions.

• fast/scrolling/ios/border-radius-event-region-expected.txt:
• fast/scrolling/ios/border-radius-event-region.html:
• fast/scrolling/ios/event-region-float-expected.txt:
• fast/scrolling/ios/event-region-float.html:
• fast/scrolling/ios/event-region-pointer-events-expected.txt:
• fast/scrolling/ios/event-region-pointer-events.html:
• fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-scale-transform-shared.html:
• fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
• fast/scrolling/ios/event-region-translate-transform-shared.html:
• fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
• fast/scrolling/ios/event-region-visibility-hidden.html:
• fast/scrolling/mac/border-radius-event-region-expected.txt:
• fast/scrolling/mac/border-radius-event-region.html:
• fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-frame.html: Added.
• fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
• fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
• fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
• fast/scrolling/mac/event-region-visibility-hidden.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267270] by Russell Epstein

• 10 edits in branches/safari-610-branch/Source

Cherry-pick r266677. rdar://problem/68740521

[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
​https://bugs.webkit.org/show_bug.cgi?id=216190

Reviewed by Darin Adler.

Source/WebCore:

In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContents due to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time via MonotonicTime::now().

We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable on Page. See below for more details, as well as
the WebKit2 ChangeLog.

• page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):

Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.

• page/Page.cpp: (WebCore::Page::updateRendering):

Update m_lastRenderingUpdateTimestamp.

• page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
• rendering/PaintFrequencyTracker.h:

Drive-by cleanup: narrow the PaintFrequency enum to bool width.

(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):

Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.

(WebCore::RenderLayer::simulateFrequentPaint):

• rendering/RenderLayer.h:

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):

In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).

Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions in SinglePaintFrequencyTracking::end(). As such, we
stick with MonotonicTime::now() in WebKit1.

• WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267269] by Russell Epstein

• 4 edits in branches/safari-610-branch

Cherry-pick r266232. rdar://problem/68178664

Step animations invalidate style on every rendering update whether or not they need to
​https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>

Reviewed by Antoine Quint.

Source/WebCore:

Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):

Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.

LayoutTests:

• animations/steps-transform-rendering-updates-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267268] by Russell Epstein

• 11 edits
  5 adds in branches/safari-610-branch

Cherry-pick r267057. rdar://problem/69101182

[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
​https://bugs.webkit.org/show_bug.cgi?id=216203
<rdar://problem/67438626>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/media/hls/hls-hdr-switch.html

In r264710, we adopted a new API to set the preferred HDR mode for every AVPlayer created by an HTMLMediaElement. The
MediaPlayerPrivateAVFoundationObjC object will query its parent when it creates an AVPlayer, or the MediaPlayer will
tell the MediaPlayerPrivate... that the HDR mode changes if the AVPlayer is already created. However, in r264710, we
neglected to cache the new value of the preferred HDR mode, so subsequent queries will just return "Standard". This means
HDR mode will correctly be applied if it changes after the AVPlayer has been created, but not initially.

• platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreferredDynamicRangeMode):

LayoutTests:

• http/tests/media/hls/hls-hdr-switch-expected.txt: Added.
• http/tests/media/hls/hls-hdr-switch.html: Added.
• http/tests/media/resources/hls/green-bip.ts: Added.
• http/tests/media/resources/hls/hdr.m3u8: Added.
• http/tests/media/resources/hls/red-bip.ts: Added.
• http/tests/media/resources/hls/test-live.php:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267267] by Russell Epstein

• 4 edits in branches/safari-610-branch/Source

Cherry-pick r267031. rdar://problem/69101165

Web Inspector: docking buttons don't work when already docked if window is too small
​https://bugs.webkit.org/show_bug.cgi?id=216488
<rdar://problem/68242717>

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

• UserInterface/Base/Main.js: (WI.updateDockingAvailability): (WI.updateDockedState): (WI._updateDockNavigationItems): Always be sure to update the docking navigation items when docking becomes unavailable instead of just forcing Web Inspector to undock as if Web Inspector is already undocked then none of the docking navigation items will be updated. This makes it so that the docking navigation items are hidden when docking becomes unavailable while undocked.

Source/WebKit:

• UIProcess/Inspector/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::attach): (WebKit::WebInspectorProxy::attachAvailabilityChanged): If Web Inspector is already attached, it can re-attach with a different configuration.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267266] by Russell Epstein

• 3 edits
  1 add in branches/safari-610-branch

Cherry-pick r267017. rdar://problem/69100994

Don't assume byte code operands are uint32 JSValues
​https://bugs.webkit.org/show_bug.cgi?id=216386

Reviewed by Yusuke Suzuki.

JSTests:

• stress/dont-assume-bytecode-operand-is-uint32.js: Added. (async foo):

Source/JavaScriptCore:

The slow path for enumerator_generic_pname was assuming that its input index operand
would always be a UInt32 JSValue boxed as int32. However, this assumption isn't true
because that value can have double format in the DFG, and remain in that format when
we exit from the DFG to baseline/LLInt code.

This was found via the widening number fuzzing agent.

I also audited two more places that seem like they suffer from the same issue,
and also switched them to using the asUInt32AsAnyInt function:

• enumerator_structure_pname
• create_rest

• runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:36 PM Changeset in webkit [267265] by Russell Epstein

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266972. rdar://problem/69101020

REGRESSION (r255383): Transition from email to password field on login.live.com stutters after going back and forth
​https://bugs.webkit.org/show_bug.cgi?id=216368
<rdar://problem/67019460>

Reviewed by Simon Fraser.

Source/WebCore:

Ensure we repaint before disconnecting from the backing provider layer.

Test: compositing/animation/repaint-after-clearing-shared-backing.html

• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):

LayoutTests:

• compositing/animation/repaint-after-clearing-shared-backing-expected.html: Added.
• compositing/animation/repaint-after-clearing-shared-backing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267264] by Russell Epstein

• 6 edits in branches/safari-610-branch

Cherry-pick r266827. rdar://problem/69101047

[CG] REGRESSION (Big Sur): A GIF image with a finite loopCount loops an extra cycle
​https://bugs.webkit.org/show_bug.cgi?id=216018
<rdar://problem/68304035>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-09-10
Reviewed by Tim Horton.

Source/WebCore:

Remove the extra 'one' we used to add to the GIF loopCount since it is
now added by the underlying frameworks. But make sure we are compatible
with the older versions of macOS and iOS.

• platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::ImageDecoderCG::repetitionCount const):

Source/WTF:

Add a new macro for the new accurate behavior of CGImageSource.

Unrelated change: Fix the conditions for enabling the WebP images.

• wtf/PlatformHave.h:

LayoutTests:

• platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267263] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266752. rdar://problem/69101201

Web process crashes at WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby
​https://bugs.webkit.org/show_bug.cgi?id=216283

Reviewed by Alex Christensen.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267262] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/JavaScriptCore

Cherry-pick r266747. rdar://problem/69101160

re-enable TCSM on all OSs
​https://bugs.webkit.org/show_bug.cgi?id=216281

Reviewed by Tadeu Zagallo.

• runtime/Options.cpp: (JSC::defaultTCSMValue):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267261] by Russell Epstein

• 12 edits in branches/safari-610-branch/Source

Cherry-pick r266745. rdar://problem/69100985

Tighten checks when creating an audio buffer list
​https://bugs.webkit.org/show_bug.cgi?id=216237
<rdar://problem/68271376>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add a routine to check there is no multiplication integer overflow.

• platform/audio/cocoa/WebAudioBufferList.cpp: (WebCore::computeBufferSize): (WebCore::WebAudioBufferList::isSupportedDescription): (WebCore::WebAudioBufferList::setSampleCount):
• platform/audio/cocoa/WebAudioBufferList.h:

Source/WebKit:

Add message checks to verify that no message integer overflows happen when processing audio buffer list messages.

• GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::audioTrackRendererManager):
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp: (WebKit::RemoteAudioMediaStreamTrackRenderer::RemoteAudioMediaStreamTrackRenderer): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesAvailable):
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp: (WebKit::RemoteAudioMediaStreamTrackRendererManager::RemoteAudioMediaStreamTrackRendererManager): (WebKit::RemoteAudioMediaStreamTrackRendererManager::createRenderer):
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
• GPUProcess/webrtc/RemoteMediaRecorder.cpp: (WebKit::RemoteMediaRecorder::audioSamplesStorageChanged): (WebKit::RemoteMediaRecorder::audioSamplesAvailable):
• GPUProcess/webrtc/RemoteMediaRecorder.h:
• WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267260] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266375. rdar://problem/69101035

Avoid computing metadata for idempotent text autosizing on macOS
​https://bugs.webkit.org/show_bug.cgi?id=216011

Reviewed by Darin Adler.

Avoids an unnecessary call to adjustForTextAutosizing during style resolution on macOS, where idempotent text
autosizing is disabled. This function call populates the AutosizeStatus fields on RenderStyle that are used
by the idempotent text autosizing heuristic. This function call appears consistently in traces taken while
running the Multiply subtest of MotionMark, if only for a relatively small number of samples. While
AutosizeStatus::computeStatus is designed to be very cheap, it ends up being called around 1.6 million times
over the course of the subtest.

• style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267259] by Russell Epstein

• 9 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266344. rdar://problem/69101085

Make StyleRareNonInheritedData::mask and StyleBackgroundData::background DataRefs
​https://bugs.webkit.org/show_bug.cgi?id=215942

Reviewed by Darin Adler.

A significant amount of time in MotionMark's Multiply subtest is spent underneath the copy constructor
StyleRareNonInheritedData, and a significant amount of time underneath this copy constructor is spent copying
the rare non-inherited data's mask (a FillLayer).

This FillLayer is currently inline data in StyleRareNonInheritedData; to reduce the cost of copying rare
non-inherited data, we can instead make this a DataRef<FillLayer>, such that copying rare data will only copy
the reference to the FillLayer rather than the FillLayer itself.

Upon mutating the FillLayer, we now use DataRef::access() to ensure that these FillLayers are copied
before writing. See below for more details.

• css/makeprop.pl: (generateFillLayerPropertyInheritValueSetter): (generateFillLayerPropertyValueSetter):
• rendering/style/FillLayer.cpp: (WebCore::FillLayer::create): (WebCore::FillLayer::FillLayer):

Deeply copy the FillLayer's linked list of FillLayers. This preserves existing behavior, which currently
uses std::unique_ptr to store the pointer to the next FillLayer (and therefore, requires a deep copy of the
linked list when copying FillLayer).

In a future patch, we could probably further optimize this as well to behave in a copy-on-write way, by turning
the RefPtr<FillLayer> m_next; into an Optional<DataRef<FillLayer>> instead (and then use access() to copy
the next FillLayer prior to writing).

(WebCore::FillLayer::~FillLayer):
(WebCore::FillLayer::operator=):

• rendering/style/FillLayer.h:

Make FillLayer ref-counted, and introduce new create methods for constructing FillLayers. Use these
methods in several places where we currently call the constructors directly, via makeUnique.

(WebCore::FillLayer::copy const):
(WebCore::FillLayer::setNext):

• rendering/style/RenderStyle.h: (WebCore::RenderStyle::hasBackgroundImage const): (WebCore::RenderStyle::hasFixedBackgroundImage const): (WebCore::RenderStyle::backgroundRepeatX const): (WebCore::RenderStyle::backgroundRepeatY const): (WebCore::RenderStyle::backgroundComposite const): (WebCore::RenderStyle::backgroundAttachment const): (WebCore::RenderStyle::backgroundClip const): (WebCore::RenderStyle::backgroundOrigin const): (WebCore::RenderStyle::backgroundXPosition const): (WebCore::RenderStyle::backgroundYPosition const): (WebCore::RenderStyle::backgroundSizeType const): (WebCore::RenderStyle::backgroundSizeLength const): (WebCore::RenderStyle::ensureBackgroundLayers): (WebCore::RenderStyle::maskImage const): (WebCore::RenderStyle::maskRepeatX const): (WebCore::RenderStyle::maskRepeatY const): (WebCore::RenderStyle::maskComposite const): (WebCore::RenderStyle::maskClip const): (WebCore::RenderStyle::maskOrigin const): (WebCore::RenderStyle::maskXPosition const): (WebCore::RenderStyle::maskYPosition const): (WebCore::RenderStyle::maskSizeType const): (WebCore::RenderStyle::maskSizeLength const): (WebCore::RenderStyle::ensureMaskLayers): (WebCore::RenderStyle::hasMask const): (WebCore::RenderStyle::setBackgroundXPosition): (WebCore::RenderStyle::setBackgroundYPosition): (WebCore::RenderStyle::setBackgroundSize): (WebCore::RenderStyle::setBackgroundSizeLength): (WebCore::RenderStyle::clearBackgroundLayers): (WebCore::RenderStyle::inheritBackgroundLayers): (WebCore::RenderStyle::clearMaskLayers): (WebCore::RenderStyle::inheritMaskLayers): (WebCore::RenderStyle::setMaskImage): (WebCore::RenderStyle::setMaskXPosition): (WebCore::RenderStyle::setMaskYPosition): (WebCore::RenderStyle::setMaskSize):
• rendering/style/StyleBackgroundData.cpp: (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleBackgroundData::dump const):
• rendering/style/StyleBackgroundData.h:

Since FillLayer is now ref-counted, StyleBackgroundData::background needs to be a DataRef as well.

• rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
• rendering/style/StyleRareNonInheritedData.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267258] by Russell Epstein

• 5 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266290. rdar://problem/69101142

[iOS] Vertical text's logical width calculation is stale from the previous height of the WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=215910

Reviewed by Simon Fraser.

Source/WebCore:

When there is vertical text (really: orthogonal flows) in the content, the available width of the vertical
text is the height of its containing block. However, the height of the containing block (indeed: all ancestors)
may be "auto", in which case the CSS spec says the available width of the element should be "the initial
containing block's size."[1]

Previously, we were using the FrameView's visibleHeight as this metric. However, the visibleHeight is calculated
asynchronously, after layout, after a round-trip from the Web Process to the UI Process and back to the Web
Process. Therefore, if content changes the WKWebView's size and the web view immediatey re-lays-out, this
visibleHeight metric is stale from whatever the previous height of the WKWebView was. In addition, the
visibleHeight metric isn't even supposed to be used inside layout; it's instead only supposed to be used for
things like position: fixed elements.

Instead, we should use FrameView::layoutSize(), which is set before layout to the size of the WKWebView. The
name even indicates that it should be used for layout purposes.

[1] ​https://drafts.csswg.org/css-writing-modes-4/#orthogonal-auto

Test: WebKit.OrthogonalFlowAvailableSize

• rendering/RenderBox.cpp: (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):
• rendering/RenderView.cpp: (WebCore::RenderView::availableLogicalHeight const):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/OrthogonalFlowAvailableSize.mm: Added. (TEST):
• TestWebKitAPI/Tests/WebKit/orthogonal-flow-available-size.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267257] by Russell Epstein

• 4 edits in branches/safari-610-branch

Cherry-pick r266244. rdar://problem/69101147

REGRESSION (r264790): IndexedDB may abort transactions of in-memory databases
​https://bugs.webkit.org/show_bug.cgi?id=215855
<rdar://problem/67418574>

Reviewed by Youenn Fablet.

Source/WebCore:

We don't abort transactions on in-memory database before process suspension because they don't hold database
file lock. Before r264790, only ephemeral session would use in-memory databases, so we only checked session. Now
persistent session also uses in-memory databases for third-party storage, so we need to add another check.

API test: IndexedDB.SuspendImminentlyForThirdPartyDatabases

• Modules/indexeddb/server/IDBServer.cpp: (WebCore::IDBServer::IDBServer::stopDatabaseActivitiesOnMainThread):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: (postResult): (catch):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:35 PM Changeset in webkit [267256] by Russell Epstein

• 5 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266411. rdar://problem/68300959

[iOS] AGX compiler service sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=216042
<rdar://problem/68111667>

Reviewed by Brent Fulgham.

For a set of devices, mach-lookup sandbox violations have been observed for an AGX compiler service. For these devices,
we currently issue an extension for one AGX compiler service, but this is not sufficient since there is a similar
service name that needs to be added as well.

• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::agxCompilerServices): (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 PM Changeset in webkit [267255] by keith_miller@apple.com

• 3 edits
  1 add in trunk

DFG should ensure there are PhantomLocals for the taken block of op_jneq_ptr
​https://bugs.webkit.org/show_bug.cgi?id=216669

Reviewed by Saam Barati.

JSTests:

• stress/jneq-ptr-opcode-variable-only-live-on-taken-branch.js: Added.

(bar):
(foo):

Source/JavaScriptCore:

Right now, if there is a local that is live on the taken branch but dead on
not-taken branch then nothing will preserve it for OSR exit. This patch simply
adds a PhantomLocal for each live operand for the first bytecode of the taken block.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

12:30 PM Changeset in webkit [267254] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

REGRESSION(r267137): PaintFrequencyTracker needs to track all the painting
​https://bugs.webkit.org/show_bug.cgi?id=216677

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-09-18
Reviewed by Simon Fraser.

r267137 removed all the optimizations which the Design test got from
r230544 because it resets the renderingUpdateTimestamp to zero when it
exists. This makes RenderLayer always retrieves this timestamp with value
equal to zero. There is no direct call from Page::updateRendering() to
RenderLayer::paintLayerContents(). Painting has to be scheduled to the
next run-loop. Because SinglePaintFrequencyTracking tracks only the painting
whose timestamp is not zero, SinglePaintFrequencyTracking has not been
tracking any painting.

The solution is to track all the painting. When renderingUpdateTimestamp()
is zero, SinglePaintFrequencyTracking will use MonotonicTime::now() instead.
This will happen in cases like calling updateControlTints() before calling
Page::updateRendering().

• page/Page.cpp:

(WebCore::Page::updateRendering):

• page/Page.h:

(WebCore::Page::lastRenderingUpdateTimestamp const):
(WebCore::Page::renderingUpdateTimestamp const): Deleted.

• rendering/PaintFrequencyTracker.h:

(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
(WebCore::SinglePaintFrequencyTracking::~SinglePaintFrequencyTracking):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects const):

12:18 PM Changeset in webkit [267253] by Chris Dumez

• 6 edits
  1 copy
  4 moves
  60 adds in trunk/LayoutTests

Import AudioContext / AudioListener / AudioNode / AudioParam layout tests from Blink
​https://bugs.webkit.org/show_bug.cgi?id=216706

Reviewed by Eric Carlson.

Import AudioContext / AudioListener / AudioNode / AudioParam layout tests from Blink.

• webaudio/AudioContext/audiocontext-close-basic-expected.txt: Added.
• webaudio/AudioContext/audiocontext-close-basic.html: Added.
• webaudio/AudioContext/audiocontext-listener-should-not-crash-expected.txt: Added.
• webaudio/AudioContext/audiocontext-listener-should-not-crash.html: Added.
• webaudio/AudioListener/audiolistener-automation-position-expected.txt: Added.
• webaudio/AudioListener/audiolistener-automation-position.html: Added.
• webaudio/AudioListener/audiolistener-set-position-expected.txt: Added.
• webaudio/AudioListener/audiolistener-set-position.html: Added.
• webaudio/AudioNode/tail-connections-expected.txt: Added.
• webaudio/AudioNode/tail-connections.html: Added.
• webaudio/AudioNode/tail-processing-expected.txt: Added.
• webaudio/AudioNode/tail-processing.html: Added.
• webaudio/AudioParam/audioparam-automation-clamping-expected.txt: Added.
• webaudio/AudioParam/audioparam-automation-clamping.html: Added.
• webaudio/AudioParam/audioparam-cancel-and-hold-expected.txt: Renamed from LayoutTests/webaudio/audioparam-cancel-and-hold-expected.txt.
• webaudio/AudioParam/audioparam-cancel-and-hold.html: Renamed from LayoutTests/webaudio/audioparam-cancel-and-hold.html.
• webaudio/AudioParam/audioparam-clamp-time-to-current-time-expected.txt: Added.
• webaudio/AudioParam/audioparam-clamp-time-to-current-time.html: Added.
• webaudio/AudioParam/audioparam-initial-event-expected.txt: Added.
• webaudio/AudioParam/audioparam-initial-event.html: Added.
• webaudio/AudioParam/audioparam-k-rate-expected.txt: Added.
• webaudio/AudioParam/audioparam-k-rate.html: Added.
• webaudio/AudioParam/audioparam-linearRamp-value-attribute-expected.txt: Added.
• webaudio/AudioParam/audioparam-linearRamp-value-attribute.html: Added.
• webaudio/AudioParam/audioparam-negative-exponentialRamp-expected.txt: Added.
• webaudio/AudioParam/audioparam-negative-exponentialRamp.html: Added.
• webaudio/AudioParam/audioparam-nominal-range-expected.txt: Renamed from LayoutTests/webaudio/audioparam-nominal-range-expected.txt.
• webaudio/AudioParam/audioparam-nominal-range.html: Renamed from LayoutTests/webaudio/audioparam-nominal-range.html.
• webaudio/AudioParam/audioparam-processing-expected.txt: Added.
• webaudio/AudioParam/audioparam-processing.html: Added.
• webaudio/AudioParam/audioparam-sampling-expected.txt: Added.
• webaudio/AudioParam/audioparam-sampling.html: Added.
• webaudio/AudioParam/audioparam-setTarget-timeConstant-0-expected.txt: Added.
• webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html: Added.
• webaudio/AudioParam/audioparam-setTargetAtTime-continuous-expected.txt: Added.
• webaudio/AudioParam/audioparam-setTargetAtTime-continuous.html: Added.
• webaudio/AudioParam/audioparam-setTargetAtTime-limit-expected.txt: Added.
• webaudio/AudioParam/audioparam-setTargetAtTime-limit.html: Added.
• webaudio/AudioParam/audioparam-setTargetAtTime-sampling-expected.txt: Added.
• webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html: Added.
• webaudio/AudioParam/audioparam-setValueCurve-copy-expected.txt: Added.
• webaudio/AudioParam/audioparam-setValueCurve-copy.html: Added.
• webaudio/AudioParam/audioparam-setValueCurve-duration-expected.txt: Added.
• webaudio/AudioParam/audioparam-setValueCurve-duration.html: Added.
• webaudio/AudioParam/audioparam-setValueCurve-end-expected.txt: Added.
• webaudio/AudioParam/audioparam-setValueCurve-end.html: Added.
• webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt: Added.
• webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation-expected.txt: Added.
• webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html: Added.
• webaudio/AudioParam/audioparam-update-value-attribute-expected.txt: Added.
• webaudio/AudioParam/audioparam-update-value-attribute.html: Added.
• webaudio/AudioParam/audioparam-value-setter-error-expected.txt: Added.
• webaudio/AudioParam/audioparam-value-setter-error.html: Added.
• webaudio/AudioParam/cancel-values-crash-913217-expected.txt: Added.
• webaudio/AudioParam/cancel-values-crash-913217.html: Added.
• webaudio/AudioParam/value-setter-warnings-expected.txt: Added.
• webaudio/AudioParam/value-setter-warnings.html: Added.
• webaudio/AudioParam/worklet-warnings-expected.txt: Added.
• webaudio/AudioParam/worklet-warnings.html: Added.
• webaudio/audioparam-exponentialRampToValueAtTime.html:
• webaudio/audioparam-linearRampToValueAtTime.html:
• webaudio/audioparam-setValueAtTime.html:
• webaudio/resources/audioparam-testing-legacy.js: Copied from LayoutTests/webaudio/resources/audioparam-testing.js.

(renderLength):
(createConstantBuffer):
(createConstantArray):
(createLinearRampArray):
(createExponentialRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):

• webaudio/resources/audioparam-testing.js:

(renderLength):
(createConstantArray):
(getStartEndFrames):
(createLinearRampArray):
(createExponentialRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createReferenceSineArray):
(createSineWaveArray):
(endValueDelta):
(relativeErrorMetric):
(differenceErrorMetric):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):

• webaudio/resources/set-position-vs-curve-test.js: Added.

(testPositionSetterVsCurve):

11:55 AM Changeset in webkit [267252] by Chris Dumez

• 7 edits in trunk

webaudio/Analyser/handle-silent-inputs.html test is failing
​https://bugs.webkit.org/show_bug.cgi?id=216708

Reviewed by Geoffrey Garen.

Source/WebCore:

Merge the following fix to AnalyserNode from Blink so that webaudio/Analyser/handle-silent-inputs.html
layout test starts passing:

• ​https://codereview.chromium.org/2666063003

No new tests, rebaselined existing test.

• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::process):
(WebCore::AnalyserNode::updatePullStatus):
(WebCore::AnalyserNode::tailTime const):

• Modules/webaudio/AnalyserNode.h:
• Modules/webaudio/AudioBasicInspectorNode.h:

LayoutTests:

Rebaseline test that is now passing.

• webaudio/Analyser/handle-silent-inputs-expected.txt:

10:53 AM Changeset in webkit [267251] by Chris Dumez

• 10 edits
  9 adds in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/webaudio from upstream
​https://bugs.webkit.org/show_bug.cgi?id=216700

Reviewed by Sam Weinig.

Resync web-platform-tests/webaudio from upstream 175a1086e0061c75d1.

• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active-expected.txt: Added.
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active.html: Added.
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/resources/not-fully-active-helper.sub.html: Added.
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/resources/w3c-import.log: Added.
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/w3c-import.log:
• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https-expected.txt: Added.
• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https.html: Added.
• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/w3c-import.log:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv.html:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delay-test-expected.txt: Added.
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delay-test.html: Added.
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/w3c-import.log:

10:52 AM Changeset in webkit [267250] by sihui_liu@apple.com

• 4 edits in trunk/Source/WebKit

Webpages flash when getting closed
​https://bugs.webkit.org/show_bug.cgi?id=216131
<rdar://problem/62264106>

Reviewed by Chris Dumez.

Closing a page in web process will detach root CA layer and clears content in view immediately. If this happens
in web process before transaction, which contains view hierachy change or layer change, is committed in UI
process, we would see a white flash. To try fixing this issue, we explicitly delay sending the close message
to next runloop cycle.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

• UIProcess/WebProcessProxy.cpp:

(WebKit::m_shutdownPreventingScopeCounter):
(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):

• UIProcess/WebProcessProxy.h: remove class ScopePreventingShutdown and use RefCounter to prevent process

shutdown.
(WebKit::WebProcessProxy::shutdownPreventingScope):
(WebKit::WebProcessProxy::ScopePreventingShutdown::ScopePreventingShutdown): Deleted.
(WebKit::WebProcessProxy::ScopePreventingShutdown::~ScopePreventingShutdown): Deleted.
(WebKit::WebProcessProxy::makeScopePreventingShutdown): Deleted.

10:26 AM Changeset in webkit [267249] by youenn@apple.com

• 9 edits in trunk/Source

Add internal flag to enable/disable H264 hardware encoder
​https://bugs.webkit.org/show_bug.cgi?id=216534

Reviewed by Eric Carlson.

Source/WebCore:

Update process-wide hardware H264 boolean flag based on internal feature flag.
No change of behavior.

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::setH264HardwareEncoderAllowed):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:
• platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:

(WebCore::LibWebRTCProvider::setH264HardwareEncoderAllowed):
(WebCore::LibWebRTCProviderCocoa::~LibWebRTCProviderCocoa):
(WebCore::LibWebRTCProviderCocoa::setH264HardwareEncoderAllowed): Deleted.

• platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h:
• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setH264HardwareEncoderAllowed):

Source/WebKit:

• Shared/WebPreferencesInternal.yaml:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

10:19 AM Changeset in webkit [267248] by Karl Rackler

• 2 edits in branches/safari-610-branch/LayoutTests

[ iOS wk2 ] compositing/clipping/border-radius-on-webgl.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215324

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:18 AM Changeset in webkit [267247] by Alan Coon

• 8 edits in branches/safari-610.2.6.1-branch/Source

Versioning.

WebKit-7610.2.6.1.1

10:15 AM Changeset in webkit [267246] by youenn@apple.com

• 10 edits in trunk

Hash deviceIds in WebProcess instead of UIProcess to allow audio output device IDs in WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=216693

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices-returned-objects.https-expected.txt:

Source/WebCore:

Make sure to create new MediaDeviceInfo objects everytime enumerateDevices is called.
Covered by updated tests.

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::stop):
(WebCore::MediaDevices::computeDevices):
(WebCore::MediaDevices::enumerateDevices):
(WebCore::MediaDevices::refreshDevices): Deleted.

• Modules/mediastream/MediaDevices.h:

Source/WebKit:

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:

LayoutTests:

• fast/mediastream/device-change-event-2.html:

10:13 AM Changeset in webkit [267245] by Chris Dumez

• 11 edits
  1 copy
  53 adds
  5 deletes in trunk/LayoutTests

Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink
​https://bugs.webkit.org/show_bug.cgi?id=216649

Reviewed by Eric Carlson.

Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink to extend
webaudio test coverage.

• webaudio/Analyser/automatic-pull-node-expected.txt: Added.
• webaudio/Analyser/automatic-pull-node.html: Added.
• webaudio/Analyser/handle-silent-inputs-expected.txt: Added.
• webaudio/Analyser/handle-silent-inputs.html: Added.
• webaudio/Analyser/realtimeanalyser-byte-data-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-byte-data.html: Added.
• webaudio/Analyser/realtimeanalyser-downmix-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-downmix.html: Added.
• webaudio/Analyser/realtimeanalyser-fftsize-reset-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-fftsize-reset.html: Added.
• webaudio/Analyser/realtimeanalyser-float-data-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-float-data.html: Added.
• webaudio/Analyser/realtimeanalyser-freq-data-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-freq-data-smoothing-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html: Added.
• webaudio/Analyser/realtimeanalyser-freq-data.html: Added.
• webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-multiple-calls.html: Added.
• webaudio/Analyser/realtimeanalyser-zero-expected.txt: Added.
• webaudio/Analyser/realtimeanalyser-zero.html: Added.
• webaudio/AudioBuffer/audiobuffer-resample-expected.txt: Added.
• webaudio/AudioBuffer/audiobuffer-resample.html: Added.
• webaudio/AudioBuffer/huge-buffer-expected.txt: Added.
• webaudio/AudioBuffer/huge-buffer.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-detune-modulation-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-detune-modulation.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-late-start-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-late-start.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-loop-points-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-loop-points.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-playbackrate-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-playbackrate.html: Added.
• webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop-expected.txt: Added.
• webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html: Added.
• webaudio/AudioBufferSource/resources/audiobuffersource-detune-modulation-expected.wav: Added.
• webaudio/AudioBufferSource/resources/audiobuffersource-loop-points-expected.wav: Added.
• webaudio/AudioBufferSource/resources/audiobuffersource-playbackrate-modulation-expected.wav: Added.
• webaudio/audiobuffersource-loop-comprehensive-expected.txt: Removed.
• webaudio/audiobuffersource-loop-comprehensive.html: Removed.
• webaudio/audiobuffersource-loop-points-expected.wav: Removed.
• webaudio/audiobuffersource-loop-points.html: Removed.
• webaudio/audiobuffersource-negative-playbackrate-interpolated-loop.html:
• webaudio/audiobuffersource-negative-playbackrate-interpolated.html:
• webaudio/audiobuffersource-negative-playbackrate-loop.html:
• webaudio/audiobuffersource-negative-playbackrate.html:
• webaudio/audiobuffersource-playbackrate-expected.wav: Removed.
• webaudio/audiobuffersource-start.html:
• webaudio/resources/audiobuffersource-testing-legacy.js: Copied from LayoutTests/webaudio/resources/audiobuffersource-testing.js.

(createTestBuffer):
(createRamp):
(checkSingleTest):
(checkAllTests):

• webaudio/resources/audiobuffersource-testing.js:

(createTestBuffer):
(checkSingleTest):
(checkAllTests):
(createSawtoothWithModulation):

• webaudio/resources/buffer-loader.js:

(BufferLoader):
(request.onload):
(request.onerror):
(BufferLoader.prototype.loadBuffer):
(BufferLoader.prototype.load):

• webaudio/resources/fft.js: Added.

(FFT):
(this.toString):
(FFT.prototype.FFTException):
(FFT.prototype.FFTRadix2Core):
(FFT.prototype.fft):
(FFT.prototype.iFFTRadix2Core):
(FFT.prototype.ifft):
(FFT.prototype.ifftScale):
(FFT.prototype.RFFTRadix2CoreStage1):
(FFT.prototype.rfft):

• webaudio/resources/realtimeanalyser-testing.js: Added.

(createGraph):
(applyWindow):
(computeFFTMagnitude):
(dbToLinear):
(linearToDb):
(clipMagnitude):
(compareFloatFreq):
(smoothFFT):
(convertFloatToByte):

10:08 AM Changeset in webkit [267244] by Alan Coon

• 1 copy in branches/safari-610.2.6.1-branch

New branch.

10:03 AM Changeset in webkit [267243] by jer.noble@apple.com

• 12 edits
  1 delete in trunk

REGRESSION(r254031): Captions fail to load on jw.org
​https://bugs.webkit.org/show_bug.cgi?id=216672
<rdar://problem/69016059>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt:
• web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt:
• web-platform-tests/service-workers/service-worker/webvtt-cross-origin.https-expected.txt:

Source/WebCore:

Revert r254031.

• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

LayoutTests:

• http/tests/security/contentSecurityPolicy/resources/track.php: Removed.
• http/tests/security/contentSecurityPolicy/track-redirect-allowed.html:
• http/tests/security/contentSecurityPolicy/track-redirect-allowed2.html:
• http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
• http/tests/security/text-track-crossorigin-expected.txt:
• http/tests/security/text-track-crossorigin.html:

10:02 AM Changeset in webkit [267242] by Ryan Haddad

• 2 edits in branches/safari-610-branch/Tools

Cherry-pick r267224. rdar://problem/57029120

Unreviewed test gardening for rdar://57029120.

• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:43 AM Changeset in webkit [267241] by Chris Dumez

• 2 edits in trunk/Source/WebCore

[macOS Big Sur] ASSERTION FAILED: !m_gamepadMap.get(device)./platform/gamepad/mac/HIDGamepadProvider.mm(233) under WebCore::HIDGamepadProvider::deviceAdded
​https://bugs.webkit.org/show_bug.cgi?id=216665
<rdar://problem/68641574>

Reviewed by Alex Christensen.

On macOS Big Sur, it appears we get notified multiple times that the Shenzhen Longshengwei Technology Gamepad
is getting added during Gamepad.GCFVersusHID API test. This was causing an assertion to be hit under
HIDGamepadProvider::deviceAdded() where we expected the device not not already be in the map. In this patch,
we work around this HID quirk on Big Sur by ignoring the notification if we already know about the device.

No new tests, fixes existing API test.

• platform/gamepad/mac/HIDGamepadProvider.mm:

(WebCore::HIDGamepadProvider::deviceAdded):

9:43 AM Changeset in webkit [267240] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Vectorize SetTargetAtTime processing in AudioParamTimeline
​https://bugs.webkit.org/show_bug.cgi?id=216673
<rdar://problem/69111432>

Reviewed by Sam Weinig.

Fix the SSE implementation of VectorMath::vsadd() to properly deal with source
and destination alignment, similarly to what is done in other VectorMath functions.

No new tests, fixes existing crash on GTK bots.

• platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsadd):

9:32 AM Changeset in webkit [267239] by Paulo Matos

• 6 edits in trunk/Source/JavaScriptCore

Unified build fixes from ARMv7 build failures
​https://bugs.webkit.org/show_bug.cgi?id=216698

Reviewed by Adrian Perez de Castro.

• llint/LLIntThunks.cpp:
• runtime/FileBasedFuzzerAgent.cpp:
• runtime/FunctionExecutableDump.cpp:
• runtime/NativeExecutable.cpp:
• runtime/WeakMapImpl.cpp:

8:24 AM Changeset in webkit [267238] by Chris Dumez

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html.

• web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:

8:13 AM Changeset in webkit [267237] by youenn@apple.com

• 6 edits in trunk/Source/WebKit

Unified build fixes in media code
​https://bugs.webkit.org/show_bug.cgi?id=216691

Reviewed by Sam Weinig.

Add missing includes and/or missing undef.
No change of behavior.

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
• GPUProcess/webrtc/RemoteMediaRecorder.cpp:
• WebProcess/WebPage/WebPageOverlay.h:
• WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
• WebProcess/cocoa/RemoteRealtimeMediaSource.h:

5:15 AM Changeset in webkit [267236] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Move computedLineLogicalRect to InlineFormattingContext::Geometry
​https://bugs.webkit.org/show_bug.cgi?id=216680

Reviewed by Simon Fraser.

This function computes line geometry. It belongs in InlineFormattingContext::Geometry.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const): Deleted.

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::computedLineLogicalRect const):

4:23 AM Changeset in webkit [267235] by Noam Rosenthal

• 2 edits in trunk/Source/WebKit

Enable paint timing by default
​https://bugs.webkit.org/show_bug.cgi?id=211736

Reviewed by Simon Fraser.

• Shared/WebPreferencesExperimental.yaml:

PaintTimingEnabled default to true.

4:16 AM Changeset in webkit [267234] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

[LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder
​https://bugs.webkit.org/show_bug.cgi?id=216678

Reviewed by Simon Fraser.

Move the LineBox related logic out of the LineBox class to InlineFormattingContext::Geometry::LineBoxBuilder.
This makes the LineBox class a light, box like class that we can cache in the InlineFormattingState.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::formattingContext const):
(WebCore::Layout::LineBoxBuilder::root const):
(WebCore::Layout::LineBoxBuilder::layoutState const):
(WebCore::Layout::HangingContent::width const):
(WebCore::Layout::HangingContent::isConditional const):
(WebCore::Layout::HangingContent::setIsConditional):
(WebCore::Layout::HangingContent::expand):
(WebCore::Layout::HangingContent::reset):
(WebCore::Layout::collectHangingContent):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):
(WebCore::Layout::LineBoxBuilder::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBoxBuilder::alignInlineBoxesVerticallyAndComputeLineBoxHeight):
(WebCore::Layout::InlineFormattingContext::Geometry::lineBoxForLineContent):

• layout/inlineformatting/InlineLine.cpp:
• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_isLineVisuallyEmpty):
(WebCore::Layout::LineBox::addRootInlineBox):
(WebCore::Layout::LineBox::addInlineBox):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::collectHangingContent): Deleted.
(WebCore::Layout::horizontalAlignmentOffset): Deleted.
(WebCore::Layout::m_inlineFormattingContext): Deleted.
(WebCore::Layout::LineBox::constructInlineBoxes): Deleted.
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight): Deleted.
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight): Deleted.
(WebCore::Layout::LineBox::formattingContext const): Deleted.
(WebCore::Layout::LineBox::root const): Deleted.
(WebCore::Layout::LineBox::layoutState const): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::setLogicalHeight):
(WebCore::Layout::LineBox::setHorizontalAlignmentOffset):
(WebCore::Layout::LineBox::rootInlineBox):
(WebCore::Layout::LineBox::nonRootInlineBoxes const):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):

• layout/inlineformatting/InlineLineBuilder.h:

4:10 AM Changeset in webkit [267233] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening. Mark several fast/layoutformattingcontext as failure after r267024.

• platform/wpe/TestExpectations:

3:35 AM WebKitGTK/2.30.x edited by Adrian Perez de Castro

(diff)

2:18 AM Changeset in webkit [267232] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/gtk/po

Merge r267228 - [l10n] [pt_BR] Updated Brazilian Portuguese translation
​https://bugs.webkit.org/show_bug.cgi?id=216436

Patch by Rafael Fontenelle <​rafaelff@gnome.org> on 2020-09-18
Rubber-stamped by Carlos Garcia Campos.

• pt_BR.po:

2:18 AM Changeset in webkit [267231] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.30

Merge r267226 - [GTK] Epiphany does not make connections in Incognito Mode after clearing .cache
​https://bugs.webkit.org/show_bug.cgi?id=216430

Reviewed by Adrian Perez de Castro.

Source/WebKit:

The problem is that when using an ephemeral context, the download is started before the ephemeral session has
been registered in the network process, so it's just ignored.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createDownloadProxy): Pass the given WebsiteDataStore to ensureNetworkProcess().

Tools:

Add unit test to check we can start downloads in ephemeral sessions before a web view is created.

• TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(testDownloadEphemeralContext):
(beforeAll):

2:17 AM Changeset in webkit [267230] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Unreviewed. [GTK] Add an env var to force single process model

WEBKIT_USE_SINGLE_WEB_PROCESS=1 can be used to force the single process model when PSON is disabled. This is a
temporary solution for applications still depending on the single process mode behavior. It will be only
available in 2.28 series.

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed):

1:20 AM Changeset in webkit [267229] by Diego Pino Garcia

• 2 edits in trunk/Tools

[ews] Set only one worker for JSC ARMv7 builder and tester queues
​https://bugs.webkit.org/show_bug.cgi?id=216476

Reviewed by Aakash Jain.

Currently many builds are failing in EWS JSC ARMv7 tester queue due to
a linking error in libicu. The problem lies on the boards that are
used to run the tests which have different system libraries.

Temporarily use one single builder and tester producing binaries compatible
with the boards.

• BuildSlaveSupport/ews-build/config.json:

1:19 AM Changeset in webkit [267228] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [pt_BR] Updated Brazilian Portuguese translation
​https://bugs.webkit.org/show_bug.cgi?id=216436

Patch by Rafael Fontenelle <​rafaelff@gnome.org> on 2020-09-18
Rubber-stamped by Carlos Garcia Campos.

• pt_BR.po:

1:15 AM Changeset in webkit [267227] by youenn@apple.com

• 23 edits
  5 adds in trunk

XHR.timeout is affected by long tasks
​https://bugs.webkit.org/show_bug.cgi?id=216266
<rdar://problem/68908150>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/xhr/xhr-timeout-longtask.any-expected.txt: Added.
• web-platform-tests/xhr/xhr-timeout-longtask.any.html: Added.
• web-platform-tests/xhr/xhr-timeout-longtask.any.js: Added.
• web-platform-tests/xhr/xhr-timeout-longtask.any.worker-expected.txt: Added.
• web-platform-tests/xhr/xhr-timeout-longtask.any.worker.html: Added.

Source/WebCore:

Long tasks may block the main thread, which may block IPC processing of load messages.
In that case, even though the load is finished, WebProcess did not know that yet and will cancel the load.
To prevent that, in case of XHR timeout, do an explicit check to compute the done flag.
​https://fetch.spec.whatwg.org/#done-flag

Tests: imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.html

imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.worker.html

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::computeIsDone):

• loader/DocumentThreadableLoader.h:
• loader/LoaderStrategy.h:
• loader/ThreadableLoader.h:
• loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::notifyIsDone):

• loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::notifyIsDone):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::computeIsDone):
(WebCore::WorkerThreadableLoader::MainThreadBridge::computeIsDone):
(WebCore::WorkerThreadableLoader::MainThreadBridge::notifyIsDone):

• loader/WorkerThreadableLoader.h:

(WebCore::WorkerThreadableLoader::MainThreadBridge::loaderProxy):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didReachTimeout):
(WebCore::XMLHttpRequest::notifyIsDone):

• xml/XMLHttpRequest.h:

Source/WebKit:

Go to network process to know whether a load is finished or not.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::isResourceLoadFinished):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::isResourceLoadFinished):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::isResourceLoadFinished):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

platform/mac-wk1/TestExpectations: Skip WK1 test.

1:14 AM Changeset in webkit [267226] by Carlos Garcia Campos

• 4 edits in trunk

[GTK] Epiphany does not make connections in Incognito Mode after clearing .cache
​https://bugs.webkit.org/show_bug.cgi?id=216430

Reviewed by Adrian Perez de Castro.

Source/WebKit:

The problem is that when using an ephemeral context, the download is started before the ephemeral session has
been registered in the network process, so it's just ignored.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createDownloadProxy): Pass the given WebsiteDataStore to ensureNetworkProcess().

Tools:

Add unit test to check we can start downloads in ephemeral sessions before a web view is created.

• TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(testDownloadEphemeralContext):
(beforeAll):

12:38 AM Changeset in webkit [267225] by youenn@apple.com

• 4 edits in trunk/Source/WebKit

Enable MediaRecorder by default on MacOS
​https://bugs.webkit.org/show_bug.cgi?id=216663

Reviewed by Eric Carlson.

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultMediaRecorderEnabled):

• Shared/WebPreferencesDefaultValues.h:
• Shared/WebPreferencesExperimental.yaml: