Context Navigation

← Previous Period
Next Period →

Timeline

Oct 7, 2020:

10:26 PM Changeset in webkit [268172] by jh718.park@samsung.com

2 edits in trunk/Source/WebKit

Unreviewed. Remove the build warning below since r238330.
warning: unused variable ‘connectionIdentifier’ [-Wunused-variable]

No new tests, no new behaviors.

WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::updateConnection):

9:56 PM Changeset in webkit [268171] by Hector Lopez

2 edits in trunk/LayoutTests

Rebaseline test result
https://bugs.webkit.org/show_bug.cgi?id=167729

Unreviewed test gardening.

platform/mac/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt:

9:18 PM Changeset in webkit [268170] by ysuzuki@apple.com

27 edits in trunk/Source

[JSC] Restrict more ptr-tagging and avoid using OperationPtrTag for JIT code
https://bugs.webkit.org/show_bug.cgi?id=217460

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch makes tagging / untagging pointer functions solid by using PtrTag in template parameter.
Later, we will introduce compile time behavior change for different kind of PtrTag so that we can insert OperationPtrTag validation
when tagging a function with OperationPtrTag.

We also found that FTL is tagging JIT code with OperationPtrTag wrongly. We should tag it with JITThunkPtrTag.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::getLinkerAddress):

assembler/AssemblerBuffer.h:

(JSC::ARM64EHash::update):
(JSC::ARM64EHash::finalHash const):

assembler/JITOperationList.cpp:

(JSC::addPointers):

assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):

assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

assembler/testmasm.cpp:

(JSC::testProbeModifiesProgramCounter):

b3/air/testair.cpp:
ftl/FTLOutput.h:

(JSC::FTL::Output::callWithoutSideEffects):
(JSC::FTL::Output::operation):

ftl/FTLSlowPathCall.cpp:

(JSC::FTL::SlowPathCallContext::makeCall):

jit/JITCode.cpp:

(JSC::JITCodeWithCodeRef::executableAddressAtOffset):

jit/JITExceptions.cpp:

(JSC::genericUnwind):

jit/JITOperations.cpp:
jit/Repatch.cpp:

(JSC::readPutICCallTarget):
(JSC::ftlThunkAwareRepatchCall):
(JSC::tryCacheGetBy):
(JSC::tryCachePutByID):

llint/LLIntData.cpp:

(JSC::LLInt::initialize):

llint/LLIntPCRanges.h:

(JSC::LLInt::isLLIntPC):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall):

llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

runtime/MachineContext.h:

(JSC::MachineContext::instructionPointer):

runtime/NativeExecutable.cpp:

(JSC::NativeExecutable::finishCreation):

runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::setCustomValue):
(JSC::PutPropertySlot::setCustomAccessor):
(JSC::PutPropertySlot::customSetter const):

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::emitCCall):

wasm/WasmSlowPaths.cpp:

Source/WTF:

wtf/PlatformRegisters.cpp:

(WTF::threadStateLRInternal):
(WTF::threadStatePCInternal):

wtf/PtrTag.h:

(WTF::tagCFunctionPtr):
(WTF::tagCFunction):
(WTF::untagCFunctionPtr):
(WTF::tagInt):
(WTF::isTaggedWith):
(WTF::assertIsTaggedWith):
(WTF::assertIsNullOrTaggedWith):

8:19 PM Changeset in webkit [268169] by Aditya Keerthi

2 edits in trunk/Tools

REGRESSION(r268123): [ iOS ] 4 TestWebKitAPI.WebKitLegacy failures: File name unavailable. Unknown C++ exception thrown in the test body.
https://bugs.webkit.org/show_bug.cgi?id=217445
<rdar://problem/70063370>

Reviewed by Wenson Hsieh.

The patch which introduced these tests swizzled [UIDatePicker setDatePickerMode:]
to avoid a crash within UIKit, resulting from the fact that TestWebKitAPI isn't
actually an app.

However, this was not a reliable solution since UIKit was still attempting to
create a QoS interval. To fix, swizzle out a method much closer to the source
of the exception: [UITableView cellForRowAtIndexPath:].

TestWebKitAPI/Tests/WebKitLegacy/ios/DateTimeInputsAccessoryViewTests.mm:

(cellForRowAtIndexPath):
(runTestWithInputType):

7:11 PM Changeset in webkit [268168] by Hector Lopez

2 edits in trunk/LayoutTests

REGRESSION(r267940): [ macOS Catalina ] imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=167729#add_comment

Unreviewed test gardening.

platform/mac/TestExpectations:

6:52 PM Changeset in webkit [268167] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION (iOS 14): [ iOS wk2 ] imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217462

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

6:35 PM Changeset in webkit [268166] by Karl Rackler

3 edits
3 adds in trunk/LayoutTests

REGRESSION (r268138): [ iOS Mojave+ ] imported/w3c/web-platform-tests/css/css-masking/clip-path/svg-clipPath.svg is missing expected results
https://bugs.webkit.org/show_bug.cgi?id=217461

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:
platform/mac/TestExpectations:

5:59 PM Changeset in webkit [268165] by Ross Kirsling

9 edits in trunk

[JSC] Revert String.prototype.item
https://bugs.webkit.org/show_bug.cgi?id=217449

Reviewed by Yusuke Suzuki.

JSTests:

stress/item-method.js:
test262/config.yaml:

Source/JavaScriptCore:

This patch reverts the String part of r267814, as it has been shown to be web-incompatible:
https://github.com/tc39/proposal-item-method/issues/31

Thankfully, this was the inessential part of the proposal; the core parts (Array and %TypedArray%) remain for now.

builtins/StringPrototype.js:

(item): Deleted.

runtime/StringPrototype.cpp:

LayoutTests:

js/Object-getOwnPropertyNames-expected.txt:
js/script-tests/Object-getOwnPropertyNames.js:

5:27 PM Changeset in webkit [268164] by Chris Dumez

3 edits in trunk/Source/WebCore

Unreviewed, fix Windows build after r268161.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):

workers/WorkerOrWorkletGlobalScope.h:

(isType):

5:23 PM Changeset in webkit [268163] by Keith Rollin

12 edits in trunk/Source

Update post-processing rules for headers to not unnecessarily change timestamps
https://bugs.webkit.org/show_bug.cgi?id=217371
<rdar://problem/69992230>

Reviewed by Darin Adler.

Under XCBuild, the scripts employed in custom build rules can be
invoked in innocuous situations. A common example is when the user is
building from the command-line and they change the make output from
stdout to a file, or vice-versa. Changing the output changes the
setting of the COLOR_DIAGNOSTICS environment variable, which is enough
to cause XCBuild to think something is different and that the custom
build rule needs to be invoked. For the script's part, nothing
significant has changed, yet it post-processes the header files,
causing their modification dates to change, causing downstream
rebuilds to occur.

Fix this problem by adopting an approach that doesn't modify the
post-processed header files unless their contents actually change.

Source/JavaScriptCore:

Scripts/postprocess-header-rule:

Source/ThirdParty/ANGLE:

adjust-angle-include-paths-rule:

Source/ThirdParty/libwebrtc:

libwebrtc.xcodeproj/project.pbxproj:

Source/WebKit:

No new tests -- this is a build change only.

Scripts/postprocess-header-rule:

Source/WebKitLegacy:

scripts/postprocess-header-rule:

Source/WTF:

Scripts/GeneratePreferences.rb:

5:01 PM Changeset in webkit [268162] by timothy_horton@apple.com

4 edits
2 adds in trunk

REGRESSION: Safari unable to load PDF in <embed> (docs.legalconnect.com)
https://bugs.webkit.org/show_bug.cgi?id=217451
<rdar://problem/69767043>

Reviewed by Alex Christensen.

Source/WebCore:

Test: fast/replaced/pdf-as-embed-with-no-mime-type-is-not-blank.html

If plugins are enabled, we'll always let the request go through, and WebKit will
guess that files with PDFPlugin-handled extensions should instantiate PDFPlugin,
even if no other plugins are available.

However, if plugins are disabled, requestPlugin() will early return if the explicitly
specified MIME type is not handled by an application plugin (even though the downstream
WebKit code would have happily instantiated an application plugin for us).

Application plugins shouldn't depend on the plugin enablement setting.
To fix this, have SubframeLoader guess the MIME type if not explicitly specified
(matching WebKit's behavior), and allow the request if it matches an application plugin.

loader/SubframeLoader.cpp:

(WebCore::findPluginMIMETypeFromURL):
Improve this previously logging-only function to use the lastPathComponent
of the URL instead of randomly looking at the end of the URL, to ignore
query strings and fragments when looking for the file extension.

(WebCore::FrameLoader::SubframeLoader::requestPlugin):
Make use of findPluginMIMETypeFromURL to guess the MIME type if it's not
explicitly specified. If the guessed MIME type is one that is handled
by application plugins, allow the request to go out to WebKit (which
may then instantiate a PDFPlugin, for example).

(WebCore::logPluginRequest):
(WebCore::FrameLoader::SubframeLoader::requestObject):
(WebCore::FrameLoader::SubframeLoader::createJavaAppletWidget):
Pass the URL instead of stringifying it, so we can lastPathComponent as above.

LayoutTests:

fast/replaced/pdf-as-embed-with-no-mime-type-is-not-blank-expected-mismatch.html: Added.
fast/replaced/pdf-as-embed-with-no-mime-type-is-not-blank.html: Added.

Add a test ensuring that <embed> with no specified MIME type still renders the PDF.

4:31 PM Changeset in webkit [268161] by Chris Dumez

35 edits
1 copy in trunk

Constructing a AudioWorkletNode should construct an AudioWorkletProcessor on the Worklet thread
https://bugs.webkit.org/show_bug.cgi?id=217442

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that we are passing more checks.

web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/processing-after-resume.https-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-messageport.https-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletglobalscope-timing-info.https-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-options.https-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processor-construction-port.https-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/suspended-context-messageport.https-expected.txt:

Source/WebCore:

Constructing a AudioWorkletNode should construct an AudioWorkletProcessor on the Worklet thread:

https://www.w3.org/TR/webaudio/#AudioWorkletNode-constructors (Step 13)

No new tests, rebaselined existing tests.

Modules/webaudio/AudioWorklet.cpp:

(WebCore::AudioWorklet::createProcessor):
Add createProcessor() function to AudioWorklet which takes care of hopping to the worklet thread
in order to call createProcessor() on the AudioWorkletGlobalScope.

Modules/webaudio/AudioWorklet.h:

Modules/webaudio/AudioWorkletGlobalScope.cpp:

(WebCore::AudioWorkletGlobalScope::createProcessor):
Construct an AudioWorkletProcessor, as specified here:

https://www.w3.org/TR/webaudio/#AudioWorkletProcessor-instantiation

(WebCore::AudioWorkletGlobalScope::takePendingProcessorConstructionData):
A function to take the pending ProcessorConstructionData. This construction
data gets initialized in createProcessor() and gets consumed by
AudioWorkletProcessor::create().

Modules/webaudio/AudioWorkletGlobalScope.h:

Modules/webaudio/AudioWorkletNode.cpp:

(WebCore::AudioWorkletNode::create):
Improve AudioWorkletNode constructor to actually cause the construction of
the AudioWorkletProcessor on the worklet thread, passing it the options and
the MessagePort. This is as per the specification here:

https://www.w3.org/TR/webaudio/#AudioWorkletNode-constructors

(WebCore::AudioWorkletNode::AudioWorkletNode):
(WebCore::AudioWorkletNode::~AudioWorkletNode):

(WebCore::AudioWorkletNode::setProcessor):
Once the AudioWorkletProcessor is created on the worklet thread, this gets
called so that the AudioWorkletNode has a reference to the processor. This
will be needed later on once AudioWorkletNode::process() starts doing audio
processing through the AudioWorkletProcessor.

(WebCore::AudioWorkletNode::process):
Improve comment.

Modules/webaudio/AudioWorkletNode.h:
Modules/webaudio/AudioWorkletNode.idl:

Pass the global object to the constructor. It is needed now that the constructor
serializes script values to pass them to the worklet thread.

Modules/webaudio/AudioWorkletNodeOptions.idl:

Add [JSGenerateToJSObject] to AudioWorkletNodeOptions dictionary so that a
convertDictionaryToJS() function gets generated for this dictionary. This function
is called by the AudioWorkletNode constructor.

Modules/webaudio/AudioWorkletProcessor.cpp:

(WebCore::AudioWorkletProcessor::create):
(WebCore::AudioWorkletProcessor::AudioWorkletProcessor):

Modules/webaudio/AudioWorkletProcessor.h:

(WebCore::AudioWorkletProcessor::name const):
(WebCore::AudioWorkletProcessor::port):
Implement AudioWorkletProcessor constructor so that its retrieves the pending
construction data from the AudioWorkletGlobalScope and properly initializes
its name and port. The specification for this is here:

https://www.w3.org/TR/webaudio/#dom-audioworkletprocessor-audioworkletprocessor

Modules/webaudio/AudioWorkletProcessor.idl:

Indicate that the constructor may throw an exception as per the specification:

https://www.w3.org/TR/webaudio/#dom-audioworkletprocessor-audioworkletprocessor (Step 1)

Also pass the ScriptExecutionContext to the constructor since the constructor
needs to retrieve the pending construction data from it:

https://www.w3.org/TR/webaudio/#dom-audioworkletprocessor-audioworkletprocessor (Step 1)

Modules/webaudio/AudioWorkletProcessorConstructionData.h:

(WebCore::AudioWorkletProcessorConstructionData::AudioWorkletProcessorConstructionData):
(WebCore::AudioWorkletProcessorConstructionData::name const):
(WebCore::AudioWorkletProcessorConstructionData::port const):
Add class to wrap the AudioWorkletProcess's construction data:

https://www.w3.org/TR/webaudio/#pending-processor-construction-data

Modules/webaudio/AudioWorkletThread.h:

Move ThreadSafeRefCounted from this class to the parent class (WorkerOrWorkletThread)
since WorkerMessagePortChannelProvider needs to protect a WorkerOrWorkletThread now.

WebCore.xcodeproj/project.pbxproj:

Add new header to project.

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::toJSDOMGlobalObject):
Properly handle WorkletGlobalScope.

dom/MessagePort.cpp:

(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::disentanglePorts):
(WebCore::MessagePort::entanglePorts):
(WebCore::MessagePort::entangle):

dom/MessagePort.h:

Tweak MessagePort API to support disentangling/entangling a single
MessagePort. Previously we had to pass an array of ports.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):
Tweak assertions to handle AudioWorkletGlobalScopes.

dom/messageports/MessagePortChannelProvider.cpp:

(WebCore::MessagePortChannelProvider::fromContext):

dom/messageports/MessageWithMessagePorts.h:
dom/messageports/WorkerMessagePortChannelProvider.cpp:

(WebCore::WorkerMessagePortChannelProvider::WorkerMessagePortChannelProvider):
(WebCore::WorkerMessagePortChannelProvider::takeAllMessagesForPort):
(WebCore::WorkerMessagePortChannelProvider::checkRemotePortForActivity):

dom/messageports/WorkerMessagePortChannelProvider.h:

Update WorkerMessagePortChannelProvider to use WorkerOrWorkletScope instead
or WorkerGlobalScope. This allows us to reuse this class for AudioWorklets
so that MessagePort communication between the main thread and the worklet
thread now works.

workers/WorkerOrWorkletThread.h:

Move ThreadSafeRefCounted from subclasses to this class so that
WorkerMessagePortChannelProvider can protect a WorkerOrWorkletThread.

workers/WorkerThread.h:
worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::notifyFinished):
Only evaluate the script if we have not already evaluated it in this worklet.
I am assuming this is needed because we are not treating the script as a module
yet (due to lack of support in workers). Without this changes, the worklet's
script would get in a bad state when importing several times the same module
(which is something the WPT tests do).

(WebCore::WorkletGlobalScope::messagePortChannelProvider):
Instantiate WorkerMessagePortChannelProvider if needed. This is needed for
MessagePort communication is AudioWorklets.

worklets/WorkletGlobalScope.h:

LayoutTests:

Unskip a few tests that are no longer timing out.

TestExpectations:

3:49 PM Changeset in webkit [268160] by Russell Epstein

1 copy in tags/Safari-610.2.8.1.1

Tag Safari-610.2.8.1.1.

3:44 PM Changeset in webkit [268159] by Chris Dumez

2 edits in trunk/Source/WebCore

Crash under JSAudioWorkletProcessorConstructor::~JSAudioWorkletProcessorConstructor()
https://bugs.webkit.org/show_bug.cgi?id=217448
<rdar://problem/70059902>

Reviewed by Geoffrey Garen.

Make sure we clear out m_processorConstructorMap in AudioWorkletGlobalScope::prepareForTermination()
since this map keeps JS wrappers alive.

No new tests, already covered by existing tests that are crashing on ASAN bots.

Modules/webaudio/AudioWorkletGlobalScope.cpp:

(WebCore::AudioWorkletGlobalScope::prepareForTermination):

3:42 PM Changeset in webkit [268158] by commit-queue@webkit.org

5 edits in trunk

background-clip:var(--a) invalidates -webkit-background-clip:text when --a:text
https://bugs.webkit.org/show_bug.cgi?id=199410

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-10-07
Reviewed by Darin Adler.

Source/WebCore:

Parse the text value (CSSValueText) for the background-clip
property. While the bug this patch is associated with is about CSS
variable interactions, the underlying issue is that we weren't parsing
the text value for background-clip.

https://www.w3.org/TR/2017/CR-css-backgrounds-3-20171017/#the-background-clip

This patch also removes the ability to parse the -webkit-text value
for the background-origin (CSSPropertyBackgroundOrigin) property by
removing CSSValueWebkitText from consumeBackgroundBox. Neither
-webkit-text nor the unprefixed text are valid values for this property.

https://www.w3.org/TR/2017/CR-css-backgrounds-3-20171017/#the-background-origin

Updated existing fast/css/background-clip-text.html test.

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeBackgroundBox): Removed CSSValueWebkitText.
(WebCore::consumeBackgroundClip): Added.
(WebCore::consumeBackgroundComponent): Use consumeBackgroundClip for
the CSSPropertyBackgroundClip property case.

LayoutTests:

We now parse the text value for the background-clip property, so
update this test to reflect that.

fast/css/background-clip-text-expected.txt:
fast/css/background-clip-text.html: Parse text value.

3:41 PM Changeset in webkit [268157] by commit-queue@webkit.org

3 edits
4 adds in trunk

Using CSS wide keywords as a fallback for variable substitution works inconsistently.
https://bugs.webkit.org/show_bug.cgi?id=197158

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-10-07
Reviewed by Darin Adler.

Source/WebCore:

Enable CSS-wide keywords to be used as variable fallbacks.

See spec-issue for further discussion:
https://github.com/w3c/csswg-drafts/issues/5325

Patch inspired by Chromium's implementation:
https://bugs.chromium.org/p/chromium/issues/detail?id=954963#c5

Tests: fast/css/variables/css-wide-keywords-in-fallback-inherited-property.html

fast/css/variables/css-wide-keywords-in-fallback-non-inherited-property.html

css/parser/CSSPropertyParser.cpp: Add maybeConsumeCSSWideKeyword

function.
(WebCore::CSSPropertyParser::parseSingleValue): Before trying to parse
the property-specific values for the input property, first try parsing the
CSS-wide keywords via maybeConsumeCSSWideKeyword.
(WebCore::CSSPropertyParser::consumeCSSWideKeyword): Refactor to use
maybeConsumeCSSWideKeyword.

LayoutTests:

Add tests ensuring CSS-wide keywords are functional as variable
fallbacks.

fast/css/variables/css-wide-keywords-in-fallback-inherited-property-expected.html: Added.
fast/css/variables/css-wide-keywords-in-fallback-inherited-property.html: Added.
fast/css/variables/css-wide-keywords-in-fallback-non-inherited-property-expected.html: Added.
fast/css/variables/css-wide-keywords-in-fallback-non-inherited-property.html: Added.

3:29 PM Changeset in webkit [268156] by Russell Epstein

1 copy in tags/Safari-610.2.8.0.2

Tag Safari-610.2.8.0.2.

3:27 PM Changeset in webkit [268155] by jiewen_tan@apple.com

2 edits
7 adds in trunk/Source/WebKit

[WebAuthn] Implement a dummy WebAuthenticationAgent
https://bugs.webkit.org/show_bug.cgi?id=217401
<rdar://problem/70012011>

Reviewed by Darin Adler.

Part 1.

This patch introduces a new dummy WebAuthenticationAgent where in the future it will take over all WebAuthn operations
from the UI Process such that we can isolate high privileged entitlements to this standalone daemon and therefore are able
offer WebAuthn to third party WKWebView clients. One of the future feautres will require this new process to listen to
LaunchEvents, which only daemons can do. That's why it is implemented as a user agent instead of a XPC service.

This is the first part of establishing such a dummy daemon. What it does is to set up a new build target for the daemon and
hook it up with WebKit's build system. One can manually load the launchd plist and load the daemon to verify this change.

Commands are:
launchctl load /to/your/path/com.apple.webkit.WebAuthenticationAgent.plist
launchctl start com.apple.webkit.WebAuthenticationAgent.Development

Covered by manual tests.

Configurations/WebAuthenticationAgent.xcconfig: Added.

Somehow the executable has a suffix .Development for debug/release builds. Will fix that in the later part.

Daemons/WebAuthenticationAgent/Info.plist: Added.
Daemons/WebAuthenticationAgent/WebAuthenticationAgent.entitlements: Added.
Daemons/WebAuthenticationAgent/com.apple.webkit.WebAuthenticationAgent.plist: Added.

The executable location is hardcoded for now. It will be fixed in Part 2 to dynamically point to the right binary.

Daemons/WebAuthenticationAgent/main.mm: Added.

(main):

WebKit.xcodeproj/project.pbxproj:

Not sure why libWTF.a is needed. Will fix that in the later part.

3:09 PM Changeset in webkit [268154] by aakash_jain@apple.com

5 edits in trunk/Tools

[build.webkit.org] Ensure that builder names are valid Buildbot identifiers
https://bugs.webkit.org/show_bug.cgi?id=217434

Reviewed by Dewei Zhu.

BuildSlaveSupport/build.webkit.org-config/config.json: Updated builder names.
BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Ditto.
BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Ensure that unit-tests fail when any builder name does

not follow required naming convention.

2:50 PM Changeset in webkit [268153] by Jonathan Bedard

3 edits in trunk/Tools

REGRESSION (r268080): [test-webkitpy] Mojave bots failing to install python-dateutil-2.8.1
https://bugs.webkit.org/show_bug.cgi?id=217438

Reviewed by Dewei Zhu.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Include wheel package.
Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): The wheel package may be needed by setup tools.

2:38 PM Changeset in webkit [268152] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Integration] Use display structures (InlineContent) to provide content height and baseline used values
https://bugs.webkit.org/show_bug.cgi?id=217437

Reviewed by Antti Koivisto.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::lineCount const):
(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):

2:18 PM Changeset in webkit [268151] by Peng Liu

3 edits in trunk/LayoutTests

[Media in GPU Process] Unskip some layout tests

Unreviewed test gardening.

gpu-process/TestExpectations:

Unskip the tests that are marked as failure or timeout when the "Media in GPU Process"
is not enabled.

media/video-size-intrinsic-scale.html:

2:04 PM Changeset in webkit [268150] by Alan Bujtas

2 edits in trunk/Source/WebCore

Add std::max to make sure the line gap is always larger than 0 (see FIXME).

Reviewed by Antti Koivisto.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):

2:03 PM Changeset in webkit [268149] by Konstantin Tokarev

3 edits in trunk/Tools

[GTK][WPE] Remove Apache's mod_bw from install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=217441

Reviewed by Carlos Alberto Lopez Perez.

It is not activated in any of Apache configs in LayoutTests, and is not
referenced anywhere else.

gtk/install-dependencies:
wpe/install-dependencies:

1:56 PM Changeset in webkit [268148] by Devin Rousso

5 edits in trunk/Source

Add missing #define for PENCILKIT_TEXT_INPUT flag
https://bugs.webkit.org/show_bug.cgi?id=217436
<rdar://problem/69720219>

Reviewed by Wenson Hsieh.

Source/WebKit:

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _shouldSimulateKeyboardInputOnTextInsertion]):
Change from ENABLE to HAVE.

Source/WTF:

wtf/PlatformHave.h:

1:33 PM Changeset in webkit [268147] by Wenson Hsieh

2 edits in trunk/LayoutTests

Unreviewed, unskip a few dozen canvas-related tests that now pass after recent changes

gpu-process/TestExpectations:

Unskip a number of tests that were skipped when enabling GPU process. Additionally, remove some erroneous test
expectation lines that were targeting HTML files that are resources or ref test.

1:17 PM Changeset in webkit [268146] by Karl Rackler

2 edits in trunk/LayoutTests

Remove test expectation for fast/images/image-orientation-none-canvas.html while the issue is investigated.
https://bugs.webkit.org/show_bug.cgi?id=217435

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

1:13 PM Changeset in webkit [268145] by Wenson Hsieh

24 edits in trunk/Source

[GPU Process] Support CanvasRenderingContext2D.drawImage() with HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=217339
<rdar://problem/69409029>

Reviewed by Darin Adler.

Source/WebCore:

Implements support for painting the current video frame into a canvas 2D graphics context. See below for more
details.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::paintCurrentFrameInContext):

Flip this around to call GraphicsContext::paintFrameForMedia with the MediaPlayer, instead of calling into
MediaPlayer with the graphics context. See changes below.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::paintFrameForMedia):

platform/graphics/GraphicsContext.h:

Add a paintFrameForMedia method that takes a MediaPlayer representing a video, and paints the current frame
of the video into the context. If the graphics context is backed by an platform context (i.e. m_impl is
nullptr), then we simply call through to MediaPlayer's private impl to paint into the context. Otherwise, we
forward the call to the GraphicsContextImpl (see the changes to DisplayListRecorder.cpp below).

platform/graphics/GraphicsContextImpl.h:

Add a new virtual function to paint the current frame of the given MediaPlayer into the destination rect.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::playerPrivate const):
(WebCore::MediaPlayer::playerPrivate):
(WebCore::MediaPlayer::paintCurrentFrameInContext): Deleted.

platform/graphics/MediaPlayer.h:

Remove the existing paintCurrentFrameInContext method on MediaPlayer, which currently takes a graphics
context. Instead, move paintCurrentFrameInContext to GraphicsContext, rename it to paintFrameForMedia, and
pass it a MediaPlayer. Additionally, expose a helper method to get a non-const MediaPlayerPrivateInterface,
and move both method definitions to the implementation file to avoid style checker errors due to MediaPlayer
itself being WEBCORE_EXPORT-ed.

platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::paintFrameForMedia):

platform/graphics/cairo/GraphicsContextImplCairo.h:
platform/graphics/displaylists/DisplayList.h:
platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::PaintFrameForMedia::create):
(WebCore::DisplayList::PaintFrameForMedia::PaintFrameForMedia):
(WebCore::DisplayList::PaintFrameForMedia::apply const):
(WebCore::DisplayList::operator<<):

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::PaintFrameForMedia::destination const):
(WebCore::DisplayList::PaintFrameForMedia::identifier const):
(WebCore::DisplayList::PaintFrameForMedia::encode const):
(WebCore::DisplayList::PaintFrameForMedia::decode):
(WebCore::DisplayList::Item::encode const):
(WebCore::DisplayList::Item::decode):

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::paintFrameForMedia):

platform/graphics/displaylists/DisplayListRecorder.h:

Add a new display list item, PaintFrameForMedia, that paints the current frame of a given MediaPlayer. This
works by serializing and then deserializing a MediaPlayerHandle and destination rect; similar to
PutImageData, the replayer delegate is responsible for applying this item by mapping the MediaPlayerHandle
to a concrete MediaPlayer instance.

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::paintFrameForMedia):

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
platform/graphics/win/GraphicsContextImplDirect2D.cpp:

(WebCore::GraphicsContextImplDirect2D::paintFrameForMedia):

platform/graphics/win/GraphicsContextImplDirect2D.h:
rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

Source/WebKit:

Implements support for painting the current video frame into a canvas 2D graphics context. See below (and
Source/WebCore/ChangeLog) for more details.

GPUProcess/graphics/RemoteImageBufferMessageHandlerProxy.h:

(WebKit::RemoteImageBufferMessageHandlerProxy::backend):

GPUProcess/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::apply):

Refactor apply so that it treats PutImageData and PaintFrameForMedia as special cases, and otherwise
returns false by default. Implement apply in the case where the display list item is PaintFrameForMedia by
using the MediaPlayerIdentifier to look up the platform MediaPlayer instance, and then calling
GraphicsContext::paintFrameForMedia with this MediaPlayer.

GPUProcess/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::gpuConnectionToWebProcess const):

GPUProcess/graphics/RemoteRenderingBackendProxy.h:

1:10 PM Changeset in webkit [268144] by Aditya Keerthi

3 edits
2 adds in trunk

[Contact Picker API] Add support for ContactsManager.getProperties()
https://bugs.webkit.org/show_bug.cgi?id=217354
<rdar://problem/69862099>

Reviewed by Youenn Fablet.

Source/WebCore:

ContactsManager.getProperties() returns a list of properties supported
by the API. These currently include name, email and tel.

Test: contact-picker/contacts-manager-get-properties.html

Modules/contact-picker/ContactsManager.cpp:

(WebCore::ContactsManager::getProperties):

LayoutTests:

Added a layout test to exercise the method.

contact-picker/contacts-manager-get-properties-expected.txt: Added.
contact-picker/contacts-manager-get-properties.html: Added.

1:10 PM Changeset in webkit [268143] by Karl Rackler

19 edits in trunk/Tools

Unreviewed, reverting r268115.

This reverts commit r268115 while investigating ews test
failure.

Reverted changeset:

"Refactor TestOptions code in WebKitTestRunner to make it
easier to rationalize and extend"
https://bugs.webkit.org/show_bug.cgi?id=217390
https://trac.webkit.org/changeset/268115

1:08 PM Changeset in webkit [268142] by Caio Lima

2 edits in trunk/JSTests

[MIPS] Flaky test stress/array-species-create-should-handle-masquerader.js
https://bugs.webkit.org/show_bug.cgi?id=217433

Unreviewed test gardening.

stress/array-species-create-should-handle-masquerader.js:

12:58 PM Changeset in webkit [268141] by Karl Rackler

2 edits in trunk/LayoutTests

REGRESSION (r268115?): [ iOS wk2 EWS ] fast/images/image-orientation-none-canvas.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=217435

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

12:42 PM Changeset in webkit [268140] by Russell Epstein

8 edits in branches/safari-610.2.8.0-branch/Source

Versioning.

WebKit-7610.2.8.0.2

12:23 PM Changeset in webkit [268139] by Russell Epstein

8 edits in branches/safari-610.2-branch/Source

Versioning.

WebKit-7610.2.12

11:54 AM Changeset in webkit [268138] by Noam Rosenthal

10 edits
141 adds in trunk

clip-path: path() ignores page zooming (Command-+)
https://bugs.webkit.org/show_bug.cgi?id=217311
<rdar://problem/69977271>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Imported all clip-path web platform tests.
Some of them don't pass yet for unrelated reasons, skipped in TestExpectations.

web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-with-zoom-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-with-zoom.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom.html: Added.

These tests test the actual zoom-related issues.

resources/import-expectations.json:
web-platform-tests/css/css-masking: Added.
web-platform-tests/css/css-masking/clip-path: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-003-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-003.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-004-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-004.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-005-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-005.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-006-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-006.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-007-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-007.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-008-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-circle-008.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-columns-shape-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-columns-shape-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-columns-shape-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-columns-shape-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-descendant-text-mutated-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-descendant-text-mutated-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-document-element-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-document-element-will-change-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-document-element-will-change.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-document-element.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-003-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-003.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-004-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-004.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-003-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-003.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-004-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-004.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-005-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-005.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-006-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-006.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-007-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-007.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-008-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-008.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-filter-order-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-filter-order.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-filter-radius-clips-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-filter-radius-clips.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-fixed-nested-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-fixed-nested.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-inline-001-expected.xht: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-inline-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-inline-002-expected.xht: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-inline-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-inline-003-expected.xht: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-inline-003.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-003-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-003.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-004-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-004.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-005-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-005.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-006-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-006.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-007-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-007.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-008-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-008.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-009-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-009.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-010-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-010.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-011-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-011.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-012-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-012.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-013-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-polygon-013.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-003-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-003.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-004-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-004.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-restore-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-reference-restore.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-rotated-will-change-transform-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-rotated-will-change-transform.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-scroll-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-scroll.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-svg-invalidate-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-svg-invalidate.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-transform-mutated-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-transform-mutated-001.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-transform-mutated-002-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-transform-mutated-002.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-url-reference-change-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-url-reference-change-from-empty-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-url-reference-change-from-empty.html: Added.
web-platform-tests/css/css-masking/clip-path/clip-path-url-reference-change.html: Added.
web-platform-tests/css/css-masking/clip-path/interpolation-expected.txt: Added.
web-platform-tests/css/css-masking/clip-path/interpolation.html: Added.
web-platform-tests/css/css-masking/clip-path/reference: Added.
web-platform-tests/css/css-masking/clip-path/reference-local-url-with-base-001-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/reference-local-url-with-base-001.html: Added.
web-platform-tests/css/css-masking/clip-path/reference-mutated-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/reference-mutated.html: Added.
web-platform-tests/css/css-masking/clip-path/reference-nonexisting-existing-local-expected.html: Added.
web-platform-tests/css/css-masking/clip-path/reference-nonexisting-existing-local.html: Added.
web-platform-tests/css/css-masking/clip-path/reference/clip-path-path-with-zoom-hittest-ref.html: Added.
web-platform-tests/css/css-masking/clip-path/reference/w3c-import.log: Added.
web-platform-tests/css/css-masking/clip-path/svg-clipPath.svg: Added.
web-platform-tests/css/css-masking/clip-path/w3c-import.log: Added.

Source/WebCore:

Added a zoom property to BasicShapePath.

When BasicShapePath is created from a clip-path, the shape's zoom received the effective zoom.
The internal cache in BasicShapePath now uses the zoom as an additional cache key, in addition
to windRule, offset and byteStream. Renamed SVGPathTranslatedByteStream to SVGPathTransformedByteStream.

Tests:

imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-with-zoom.html
imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest.html
imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom.html

Also imported the rest of the w3c clip-path tests.

css/BasicShapeFunctions.cpp:

(WebCore::basicShapeForValue):

css/BasicShapeFunctions.h:
rendering/style/BasicShapes.cpp:

(WebCore::SVGPathTransformedByteStream::SVGPathTransformedByteStream):
(WebCore::SVGPathTransformedByteStream::operator== const):
(WebCore::SVGPathTransformedByteStream::operator!= const):
(WebCore::SVGPathTransformedByteStream::path const):
(WebCore::TransformedByteStreamPathPolicy::isKeyNull):
(WebCore::TransformedByteStreamPathPolicy::createValueForKey):
(WebCore::cachedTransformedByteStreamPath):
(WebCore::BasicShapePath::path):
(WebCore::BasicShapePath::operator== const):
(WebCore::BasicShapePath::blend const):
(WebCore::SVGPathTranslatedByteStream::SVGPathTranslatedByteStream): Deleted.
(WebCore::SVGPathTranslatedByteStream::operator== const): Deleted.
(WebCore::SVGPathTranslatedByteStream::operator!= const): Deleted.
(WebCore::SVGPathTranslatedByteStream::isEmpty const): Deleted.
(WebCore::SVGPathTranslatedByteStream::path const): Deleted.
(WebCore::TranslatedByteStreamPathPolicy::isKeyNull): Deleted.
(WebCore::TranslatedByteStreamPathPolicy::createValueForKey): Deleted.
(WebCore::cachedTranslatedByteStreamPath): Deleted.

Add zoom to BasicShapePath and related internal structure.

rendering/style/BasicShapes.h:
style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertClipPath):

Read zoom from current style when creating a BasicShapeClipPath.

LayoutTests:

TestExpectations:

Marked newly imported clip-path w3c tests that don't pass yet as expected failure.
Some of them have open bugs, the others need triage.

11:39 AM Changeset in webkit [268137] by Russell Epstein

8 edits in trunk/Source

Versioning.

WebKit-7611.1.4

11:07 AM Changeset in webkit [268136] by youenn@apple.com

19 edits in trunk

Add support for BlobEvent.timecode
https://bugs.webkit.org/show_bug.cgi?id=217379

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/mediacapture-record/idlharness.window-expected.txt:

Source/WebCore:

Expose timecode getter for BlobEvent.
Make MediaRecorder backend return the timecode value for each fetch data.
For the real backend, compute the timecode as the current audio timestamp for the next fetch data request,
or the current video timestamp if only video is captured.

Covered by rebased test.

Modules/mediarecorder/BlobEvent.cpp:

(WebCore::BlobEvent::BlobEvent):

Modules/mediarecorder/BlobEvent.h:
Modules/mediarecorder/BlobEvent.idl:
Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::createDataAvailableEvent):
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):
(WebCore::MediaRecorder::fetchData):
(WebCore::MediaRecorder::handleTrackChange):
(WebCore::MediaRecorder::trackEnded):

Modules/mediarecorder/MediaRecorder.h:
platform/mediarecorder/MediaRecorderPrivate.h:
platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::fetchData):

platform/mediarecorder/MediaRecorderPrivateMock.cpp:

(WebCore::MediaRecorderPrivateMock::fetchData):

platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::clear):
(WebCore::MediaRecorderPrivateWriter::stopRecording):
(WebCore::MediaRecorderPrivateWriter::fetchData):
(WebCore::MediaRecorderPrivateWriter::updateTimeCode):

Source/WebKit:

Exchange timecode through IPC.

GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::fetchData):

GPUProcess/webrtc/RemoteMediaRecorder.h:
GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::fetchData):

WebProcess/GPU/webrtc/MediaRecorderPrivate.h:

11:05 AM Changeset in webkit [268135] by Tadeu Zagallo

2 edits in trunk/Source/WTF

Add maximum depth check to RedBlackTree
https://bugs.webkit.org/show_bug.cgi?id=217249
<rdar://problem/69432957>

Reviewed by Saam Barati.

We limit all tree traversals to 128 levels deep. That's a very conservative upper bound that
would work for a tree that used all of the available address space.

wtf/RedBlackTree.h:

11:04 AM Changeset in webkit [268134] by basuke.suzuki@sony.com

2 edits in trunk/Tools

[build-webkit] Compare with cmakeargs and unhandled to detect configuration change
https://bugs.webkit.org/show_bug.cgi?id=207012

Reviewed by Carlos Alberto Lopez Perez.

Added command line arguments on top of @featureArgs for comparison with previous build
options. This forces regeneration of CMakeCache.txt when any configuration is changed.

Scripts/webkitdirs.pm:

(shouldRemoveCMakeCache):

11:02 AM Changeset in webkit [268133] by Alan Bujtas

6 edits
2 adds in trunk

[LFC][IFC] Adjust the inline formatting context root's content height when the last line has float clear
https://bugs.webkit.org/show_bug.cgi?id=217432

Reviewed by Antti Koivisto.

Source/WebCore:

This patch expands the support for inline content to clear floats (r268122) by taking the clear gap into
account when it occurs after the last line (e.g. <div>foobar<br clear=left"></div>).
In such cases the inline formatting context's content height needs to be adjusted with the computed clear
gap value.

Test: fast/layoutformattingcontext/float-avoiding-br-last-line.html

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):

layout/inlineformatting/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::setClearGapAfterLastLine):
(WebCore::Layout::InlineFormattingState::clearGapAfterLastLine const):
(WebCore::Layout::InlineFormattingState::clearLineAndRuns):

LayoutTests:

fast/layoutformattingcontext/float-avoiding-br-last-line-expected.html: Added.
fast/layoutformattingcontext/float-avoiding-br-last-line.html: Added.

10:09 AM Changeset in webkit [268132] by Alan Coon

3 edits in branches/safari-610-branch/LayoutTests

Apply patch. rdar://problem/70024420

Applied "rebased-expectations-patch".

10:09 AM Changeset in webkit [268131] by Alan Coon

1 edit in branches/safari-610-branch/Source/WebCore/platform/Timer.h

Apply patch. rdar://problem/70024420

Applied "patch-timer".

9:41 AM Changeset in webkit [268130] by youenn@apple.com

23 edits
2 adds in trunk

Add support for MediaRecorder pause/resume
https://bugs.webkit.org/show_bug.cgi?id=217375

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt:
web-platform-tests/mediacapture-record/MediaRecorder-peerconnection.https-expected.txt:
web-platform-tests/mediacapture-record/idlharness.window-expected.txt:

Source/WebCore:

Implement pause and resume as per spec.
MediaRecorder basically sends pause/resume order to its backend.
The backend then stops observing tracks when paused and resumed observing at resume time.
For video, we make sure to compute the frame timestamp so that the recorded video continues to play without interruption.

Test: http/wpt/mediarecorder/pause-recording.html

Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::pauseRecording):
(WebCore::MediaRecorder::resumeRecording):

Modules/mediarecorder/MediaRecorder.h:
Modules/mediarecorder/MediaRecorder.idl:
platform/mediarecorder/MediaRecorderPrivate.cpp:

(WebCore::MediaRecorderPrivate::pause):
(WebCore::MediaRecorderPrivate::resume):

platform/mediarecorder/MediaRecorderPrivate.h:
platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::pauseRecording):
(WebCore::MediaRecorderPrivateAVFImpl::resumeRecording):

platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
platform/mediarecorder/MediaRecorderPrivateMock.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::pause):
(WebCore::MediaRecorderPrivateWriter::resume):

Source/WebKit:

Add IPC support for sending pause/resume orders.

GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::pause):
(WebKit::RemoteMediaRecorder::resume):

GPUProcess/webrtc/RemoteMediaRecorder.h:
GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::pauseRecording):
(WebKit::MediaRecorderPrivate::resumeRecording):

WebProcess/GPU/webrtc/MediaRecorderPrivate.h:

LayoutTests:

fix-217375

http/wpt/mediarecorder/pause-recording-expected.txt: Added.
http/wpt/mediarecorder/pause-recording.html: Added.

9:39 AM Changeset in webkit [268129] by youenn@apple.com

2 edits in trunk/LayoutTests/imported/w3c

MediaRecorder::create should not need to create a MediaRecorderPrivate to validate it can record properly
https://bugs.webkit.org/show_bug.cgi?id=217387
<rdar://problem/70049616>

Unreviewed.

Rebased test after https://trac.webkit.org/changeset/268125.
We should fix the exact name of the exception based on https://github.com/w3c/mediacapture-record/issues/206.

web-platform-tests/mediacapture-record/MediaRecorder-detached-context-expected.txt:

9:01 AM Changeset in webkit [268128] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] Ensure that invalid step names are not allowed
https://bugs.webkit.org/show_bug.cgi?id=217431

Reviewed by Darin Adler.

BuildSlaveSupport/build.webkit.org-config/loadConfig.py:

(loadBuilderConfig):

8:54 AM Changeset in webkit [268127] by pvollan@apple.com

5 edits in trunk

[macOS] Remove 'com.apple.cookied' from the WebContent process sandbox.
https://bugs.webkit.org/show_bug.cgi?id=206088
Source/WebKit:

<rdar://problem/58489040>

Reviewed by Darin Adler.

It has been confirmed that access to the cookied service can be removed from the WebContent process.

Test: fast/sandbox/sandbox-mach-lookup.html

WebProcess/com.apple.WebProcess.sb.in:

LayoutTests:

Reviewed by Darin Adler.

fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
fast/sandbox/mac/sandbox-mach-lookup.html:

8:52 AM Changeset in webkit [268126] by Aditya Keerthi

2 edits in trunk/Source/WebKit

zappos.com: Dropdown - 'Quantity' option size different
https://bugs.webkit.org/show_bug.cgi?id=217395
<rdar://problem/60261396>

Reviewed by Tim Horton.

The select element used in this instance uses a custom font (Open Sans)
with a 16px font size. When presenting the select dropdown a call to
WebPopupMenuProxyMac::showPopupMenu is made with those attributes.
However, since Open Sans is not a system font, the call to
[NSFont fontWithDescriptor:size:] returns nil. This results in the
presented view falling back to the default font size, which is smaller
than the expected 16px size, leading to smaller options.

While other browsers do not honor custom fonts in their select dropdowns,
they do honor the font size. Consequently, this dropdown appears
different in Safari. To fix, ensure that the font size is always honored
if the corresponding attribute is present.

UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu):

8:48 AM Changeset in webkit [268125] by youenn@apple.com

3 edits
2 adds in trunk

MediaRecorder::create should not need to create a MediaRecorderPrivate to validate it can record properly
https://bugs.webkit.org/show_bug.cgi?id=217387

Reviewed by Darin Adler.

Source/WebCore:

Instead of creating a MediaRecorderPrivate to verify that we can create one, just rely on isTypeSupported.
Add a check that page is not null in the create method.

Remove assertion that we can create a private recorder in start since thgere is no guarantee that the frame might not be detached.

Test: http/wpt/mediarecorder/MediaRecorder-frame.html

Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::createMediaRecorderPrivate):
(WebCore::MediaRecorder::startRecording):

LayoutTests:

http/wpt/mediarecorder/MediaRecorder-frame-expected.txt: Added.
http/wpt/mediarecorder/MediaRecorder-frame.html: Added.

8:47 AM Changeset in webkit [268124] by Antti Koivisto

9 edits
4 adds in trunk/Source/WebCore

[LFC][Integration] Add line iterator
https://bugs.webkit.org/show_bug.cgi?id=217427

Reviewed by Zalan Bujtas.

Add line iterator. In this patch it is only used to replace onSameLine function.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Position.cpp:

(WebCore::Position::rendersInDifferentPosition const):

layout/integration/LayoutIntegrationLineIterator.cpp: Added.

(WebCore::LayoutIntegration::LineIterator::LineIterator):
(WebCore::LayoutIntegration::LineIterator::atEnd const):
(WebCore::LayoutIntegration::LineIterator::next const):
(WebCore::LayoutIntegration::LineIterator::previous const):
(WebCore::LayoutIntegration::LineIterator::traverseNext):
(WebCore::LayoutIntegration::LineIterator::traversePrevious):

layout/integration/LayoutIntegrationLineIterator.h: Added.

(WebCore::LayoutIntegration::PathLine::operator!= const):
(WebCore::LayoutIntegration::LineIterator::LineIterator):
(WebCore::LayoutIntegration::LineIterator::operator++):
(WebCore::LayoutIntegration::LineIterator::operator bool const):
(WebCore::LayoutIntegration::LineIterator::operator== const):
(WebCore::LayoutIntegration::LineIterator::operator!= const):
(WebCore::LayoutIntegration::LineIterator::operator* const):
(WebCore::LayoutIntegration::LineIterator::operator-> const):
(WebCore::LayoutIntegration::PathLine::PathLine):
(WebCore::LayoutIntegration::PathLine::rect const):
(WebCore::LayoutIntegration::PathLine::operator== const):

layout/integration/LayoutIntegrationLineIteratorLegacyPath.h: Added.

(WebCore::LayoutIntegration::LegacyLinePath::LegacyLinePath):
(WebCore::LayoutIntegration::LegacyLinePath::rect const):
(WebCore::LayoutIntegration::LegacyLinePath::traverseNext):
(WebCore::LayoutIntegration::LegacyLinePath::traversePrevious):
(WebCore::LayoutIntegration::LegacyLinePath::operator== const):
(WebCore::LayoutIntegration::LegacyLinePath::atEnd const):
(WebCore::LayoutIntegration::LegacyLinePath::setAtEnd):

layout/integration/LayoutIntegrationLineIteratorModernPath.h: Added.

(WebCore::LayoutIntegration::ModernLinePath::ModernLinePath):
(WebCore::LayoutIntegration::ModernLinePath::rect const):
(WebCore::LayoutIntegration::ModernLinePath::traverseNext):
(WebCore::LayoutIntegration::ModernLinePath::traversePrevious):
(WebCore::LayoutIntegration::ModernLinePath::operator== const):
(WebCore::LayoutIntegration::ModernLinePath::atEnd const):
(WebCore::LayoutIntegration::ModernLinePath::setAtEnd):
(WebCore::LayoutIntegration::ModernLinePath::lines const):
(WebCore::LayoutIntegration::ModernLinePath::line const):

layout/integration/LayoutIntegrationRunIterator.cpp:

(WebCore::LayoutIntegration::RunIterator::line const):

layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::PathRun::logicalLeft const):
(WebCore::LayoutIntegration::PathRun::logicalRight const):
(WebCore::LayoutIntegration::PathRun::logicalWidth const):
(WebCore::LayoutIntegration::PathRun::logicalHeight const):
(WebCore::LayoutIntegration::PathRun::onSameLine const): Deleted.

layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

(WebCore::LayoutIntegration::LegacyPath::operator== const):
(WebCore::LayoutIntegration::LegacyPath::rootInlineBox const):
(WebCore::LayoutIntegration::LegacyPath::onSameLine const): Deleted.

layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::verticallyRoundedRect):
(WebCore::LayoutIntegration::ModernPath::rect const):
(WebCore::LayoutIntegration::ModernPath::operator== const):
(WebCore::LayoutIntegration::linePosition): Deleted.
(WebCore::LayoutIntegration::ModernPath::onSameLine const): Deleted.

8:20 AM Changeset in webkit [268123] by Aditya Keerthi

4 edits
1 add in trunk

REGRESSION: Date/time pickers are not displayed in UIWebViews
https://bugs.webkit.org/show_bug.cgi?id=217341
<rdar://problem/66881739>

Reviewed by Wenson Hsieh.

Source/WTF:

Date/time inputs were incorrectly disabled by default on
PLATFORM(IOS_FAMILY) in WebPreferencesInternal.

Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

Added regression tests to ensure this preference is not accidently
modified in the future.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitLegacy/ios/DateTimeInputsAccessoryViewTests.mm: Added.

(-[DateTimeInputsTestsLoadingDelegate webViewDidFinishLoad:]):
(runTestWithInputType):

Note that [UIDatePicker setDatePickerMode:] had to be swizzled to an
empty implementation as the UIKit version on the bots attempts to
create a QoS interval upon setting the initially selected row in
a UITableView when the date picker is presented. This fails because
TestWebKitAPI isn't actually an app. To avoid an exception, the method
is swizzled out.

7:38 AM Changeset in webkit [268122] by Alan Bujtas

10 edits
2 adds in trunk

[LFC][IFC] Add initial support for inline content to clear intrusive floats
https://bugs.webkit.org/show_bug.cgi?id=217418

Reviewed by Antti Koivisto.

Source/WebCore:

In this patch we introduce the concept of gaps between lines. These gaps are required
to clear intrusive floats when the inline content has the clear property set.
(This behavior changed in CSS2. Now the clear property only applies to block-level elements.)

Adjust the logic in FloatingContext::verticalPositionWithClearance so that it can take an inline level box
and make sure that the next line does not start above the clearance position.

Test: fast/layoutformattingcontext/float-avoiding-br-simple.html

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

layout/FormattingContext.h:
layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::absoluteCoordinates const):
(WebCore::Layout::FloatingContext::mapTopLeftToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::logicalTopForNextLine const):

LayoutTests:

fast/layoutformattingcontext/float-avoiding-br-simple-expected.html: Added.
fast/layoutformattingcontext/float-avoiding-br-simple.html: Added.

6:19 AM Changeset in webkit [268121] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC][Floating] Move FloatingState::top/bottom functions over to FloatingContext
https://bugs.webkit.org/show_bug.cgi?id=217411

Reviewed by Antti Koivisto.

FormattingState classes are mostly about setters and getters and they don't have any involved logic.
While both top() and bottom() are both rather lightweight at the moment, it will change with the
upcoming <br clear> feature. Let's just move these function over to FloatingContext.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases const):

layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::bottom const): The check for isInFormattingContextOf() is redundant, so let's not add that back here.
(WebCore::Layout::FloatingContext::top const):

layout/floats/FloatingContext.h:

(WebCore::Layout::FloatingContext::leftBottom const):
(WebCore::Layout::FloatingContext::rightBottom const):
(WebCore::Layout::FloatingContext::bottom const):

layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::bottom const): Deleted.
(WebCore::Layout::FloatingState::top const): Deleted.

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::leftBottom const): Deleted.
(WebCore::Layout::FloatingState::rightBottom const): Deleted.
(WebCore::Layout::FloatingState::bottom const): Deleted.

4:01 AM Changeset in webkit [268120] by commit-queue@webkit.org

15 edits
10 deletes in trunk

Unreviewed, reverting r268085.
https://bugs.webkit.org/show_bug.cgi?id=217424

Added broken test webgl/conformance/extensions/s3tc-and-
rgtc.html

Reverted changeset:

"Support EXT_texture_compression_rgtc WebGL extension"
https://bugs.webkit.org/show_bug.cgi?id=217198
https://trac.webkit.org/changeset/268085

2:22 AM Changeset in webkit [268119] by youenn@apple.com

15 edits in trunk

Make sure to fire the correct set of events in case MediaRecorder stream has track changes
https://bugs.webkit.org/show_bug.cgi?id=217316

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/mediacapture-record/MediaRecorder-error.html:
web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt:
web-platform-tests/mediacapture-record/MediaRecorder-stop.html:

Source/WebCore:

Introduce MediaRecorderPrivate::stop which makes sure to unregister from media sources before stopping.
Update firing events according https://w3c.github.io/mediacapture-record/#dom-mediarecorder-start when track set is changed.
Covered by updated test.

Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::stopRecordingInternal):
(WebCore::MediaRecorder::handleTrackChange):

platform/mediarecorder/MediaRecorderPrivate.cpp:

(WebCore::MediaRecorderPrivate::stop):

platform/mediarecorder/MediaRecorderPrivate.h:
platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::~MediaRecorderPrivateAVFImpl):
(WebCore::MediaRecorderPrivateAVFImpl::stopRecording):

platform/mediarecorder/MediaRecorderPrivateMock.cpp:

(WebCore::MediaRecorderPrivateMock::~MediaRecorderPrivateMock):
(WebCore::MediaRecorderPrivateMock::stopRecording):

Source/WebKit:

Make sure to not set audio/video tracks if the recorder was stopped.

WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::startRecording):
(WebKit::MediaRecorderPrivate::~MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::stopRecording):

WebProcess/GPU/webrtc/MediaRecorderPrivate.h:

LayoutTests:

platform/mac-wk2/TestExpectations:

Oct 6, 2020:

11:01 PM Changeset in webkit [268118] by Peng Liu

37 edits in trunk/Source/WebKit

[Media in GPU process] Don't use 'id' as a parameter or variable name
https://bugs.webkit.org/show_bug.cgi?id=206189

Reviewed by Tim Horton.

Mass rename id to identifier.

No new tests, no functional change.

GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestination::create):
(WebKit::RemoteAudioDestination::RemoteAudioDestination):
(WebKit::RemoteAudioDestinationManager::deleteAudioDestination):
(WebKit::RemoteAudioDestinationManager::startAudioDestination):
(WebKit::RemoteAudioDestinationManager::stopAudioDestination):

GPUProcess/media/RemoteAudioDestinationManager.messages.in:
GPUProcess/media/RemoteAudioTrackProxy.cpp:

(WebKit::RemoteAudioTrackProxy::RemoteAudioTrackProxy):
(WebKit::RemoteAudioTrackProxy::configuration):

GPUProcess/media/RemoteAudioTrackProxy.h:
GPUProcess/media/RemoteCDMFactoryProxy.cpp:

(WebKit::RemoteCDMFactoryProxy::addProxy):
(WebKit::RemoteCDMFactoryProxy::removeProxy):
(WebKit::RemoteCDMFactoryProxy::addInstance):
(WebKit::RemoteCDMFactoryProxy::removeInstance):
(WebKit::RemoteCDMFactoryProxy::getInstance):
(WebKit::RemoteCDMFactoryProxy::addSession):
(WebKit::RemoteCDMFactoryProxy::removeSession):

GPUProcess/media/RemoteCDMFactoryProxy.messages.in:
GPUProcess/media/RemoteCDMInstanceProxy.messages.in:
GPUProcess/media/RemoteCDMProxy.messages.in:
GPUProcess/media/RemoteLegacyCDMFactoryProxy.cpp:

(WebKit::RemoteLegacyCDMFactoryProxy::addProxy):
(WebKit::RemoteLegacyCDMFactoryProxy::removeProxy):
(WebKit::RemoteLegacyCDMFactoryProxy::addSession):
(WebKit::RemoteLegacyCDMFactoryProxy::removeSession):
(WebKit::RemoteLegacyCDMFactoryProxy::getSession const):

GPUProcess/media/RemoteLegacyCDMFactoryProxy.messages.in:
GPUProcess/media/RemoteLegacyCDMProxy.messages.in:
GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::createMediaPlayer):
(WebKit::RemoteMediaPlayerManagerProxy::deleteMediaPlayer):
(WebKit::RemoteMediaPlayerManagerProxy::getProxy):

GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy):

GPUProcess/media/RemoteMediaResource.cpp:

(WebKit::RemoteMediaResource::create):
(WebKit::RemoteMediaResource::RemoteMediaResource):

GPUProcess/media/RemoteMediaResourceManager.cpp:

(WebKit::RemoteMediaResourceManager::responseReceived):
(WebKit::RemoteMediaResourceManager::redirectReceived):
(WebKit::RemoteMediaResourceManager::dataSent):
(WebKit::RemoteMediaResourceManager::dataReceived):
(WebKit::RemoteMediaResourceManager::accessControlCheckFailed):
(WebKit::RemoteMediaResourceManager::loadFailed):
(WebKit::RemoteMediaResourceManager::loadFinished):

GPUProcess/media/RemoteMediaResourceManager.messages.in:
GPUProcess/media/RemoteTextTrackProxy.cpp:

(WebKit::RemoteTextTrackProxy::RemoteTextTrackProxy):
(WebKit::RemoteTextTrackProxy::configuration):

GPUProcess/media/RemoteTextTrackProxy.h:
GPUProcess/media/RemoteVideoTrackProxy.cpp:

(WebKit::RemoteVideoTrackProxy::RemoteVideoTrackProxy):
(WebKit::RemoteVideoTrackProxy::configuration):

GPUProcess/media/RemoteVideoTrackProxy.h:
GPUProcess/media/TextTrackPrivateRemoteConfiguration.h:

(WebKit::TextTrackPrivateRemoteConfiguration::encode const):
(WebKit::TextTrackPrivateRemoteConfiguration::decode):

GPUProcess/media/TrackPrivateRemoteConfiguration.h:

(WebKit::TrackPrivateRemoteConfiguration::encode const):
(WebKit::TrackPrivateRemoteConfiguration::decode):

WebProcess/GPU/media/AudioTrackPrivateRemote.cpp:

(WebKit::AudioTrackPrivateRemote::updateConfiguration):

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::remoteTextTrackConfigurationChanged):
(WebKit::MediaPlayerPrivateRemote::removeRemoteVideoTrack):
(WebKit::MediaPlayerPrivateRemote::remoteVideoTrackConfigurationChanged):

WebProcess/GPU/media/RemoteCDM.cpp:

(WebKit::RemoteCDM::create):
(WebKit::RemoteCDM::RemoteCDM):
(WebKit::RemoteCDM::createInstance):

WebProcess/GPU/media/RemoteCDMFactory.cpp:

(WebKit::RemoteCDMFactory::createCDM):
(WebKit::RemoteCDMFactory::removeSession):

WebProcess/GPU/media/RemoteCDMInstance.cpp:

(WebKit::RemoteCDMInstance::create):
(WebKit::RemoteCDMInstance::RemoteCDMInstance):
(WebKit::RemoteCDMInstance::createSession):

WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:

(WebKit::RemoteCDMInstanceSession::create):
(WebKit::RemoteCDMInstanceSession::RemoteCDMInstanceSession):

WebProcess/GPU/media/RemoteLegacyCDM.cpp:

(WebKit::RemoteLegacyCDM::create):
(WebKit::RemoteLegacyCDM::RemoteLegacyCDM):
(WebKit::RemoteLegacyCDM::createSession):
(WebKit::RemoteLegacyCDM::setPlayerId):

WebProcess/GPU/media/RemoteLegacyCDMFactory.cpp:

(WebKit::RemoteLegacyCDMFactory::createCDM):
(WebKit::RemoteLegacyCDMFactory::addSession):
(WebKit::RemoteLegacyCDMFactory::removeSession):

WebProcess/GPU/media/RemoteLegacyCDMSession.cpp:

(WebKit::RemoteLegacyCDMSession::create):
(WebKit::RemoteLegacyCDMSession::RemoteLegacyCDMSession):

WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::deleteRemoteMediaPlayer):

WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:

(WebKit::RemoteMediaResourceProxy::RemoteMediaResourceProxy):

WebProcess/GPU/media/TextTrackPrivateRemote.cpp:

(WebKit::TextTrackPrivateRemote::updateConfiguration):

WebProcess/GPU/media/VideoTrackPrivateRemote.cpp:

(WebKit::VideoTrackPrivateRemote::updateConfiguration):

10:59 PM Changeset in webkit [268117] by Andres Gonzalez

5 edits in trunk

Presidential Executive Order pages not accessible with Safari.
https://bugs.webkit.org/show_bug.cgi?id=217415

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/aria-modal.html.

These pages have a dialog modal element of the form

with style visible and a display value different from none. This makes
WebCore/accessibility to treat it as if the dialog were always visible,
and thus do not convey the content of the page outside the dialog to
VoiceOver. The author controls the visibility of the dialog using the
style opacity. This patch adds the check for the opacity to determine
whether an element is visible or not.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::isNodeVisible const):

LayoutTests:

Expanded this test to cover the case whether the modal dialog visibility
is controlled by its opacity. Cleaned up JS code and made it work in
isolated tree mode.

accessibility/aria-modal-expected.txt:
accessibility/aria-modal.html:

9:50 PM Changeset in webkit [268116] by Devin Rousso

22 edits in trunk

Move platform logic for CSS hover and pointer media queries outside of WebCore
https://bugs.webkit.org/show_bug.cgi?id=217413

Reviewed by Tim Horton.

Source/WebCore:

No change in behavior, covered by existing tests.

css/MediaQueryEvaluator.cpp:

(WebCore::hoverEvaluate):
(WebCore::pointerEvaluate):

page/ChromeClient.h:
loader/EmptyClients.h:

(WebCore::EmptyChromeClient::hoverSupportedByPrimaryPointingDevice const): Added.
(WebCore::EmptyChromeClient::pointerCharacteristicsOfPrimaryPointingDevices const): Added.
Provide a way for WebCore to get information about the primary pointing device.
Refactor logic in hoverEvaluate and pointerEvaluate to move platform code into the
respective WebKit::WebPage file.

Source/WebKit:

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::hoverSupportedByPrimaryPointingDevice const): Added.
(WebKit::WebChromeClient::pointerCharacteristicsOfPrimaryPointingDevices const): Added.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/gtk/WebPageGtk.cpp: