Timeline

Oct 23, 2020:

11:30 PM Changeset in webkit [268947] by Simon Fraser

• 7 edits
  2 adds in trunk

REGRESSION (r260276): Unable to click on image and text link at the bottom of ​https://www.nytimes.com/ article
​https://bugs.webkit.org/show_bug.cgi?id=218137
<rdar://problem/70439526>

Reviewed by Zalan Bujtas.
Source/WebCore:

r238725 made RenderLayers for accelerated overflow:scroll be self-painting, but that
changes paint and hit-testing order, which affected this nytimes article (the failing
element has large negative margin-top).

This is the fundamental compositing bug, but we can work around it in this case by
only making the layer self-painting if it does actually scroll.

Test: fast/layers/overflow-scroll-self-painting.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Need to update isSelfPaintingLayer()
after layout because now it depends on scrollable overflow.
(WebCore::RenderLayer::shouldBeSelfPaintingLayer const): Consult hasCompositedScrollableOverflow()
rather than canUseCompositedScrolling().

LayoutTests:

New test. Rebaseline tests affected by the self-painting layer change.

• compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:
• compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping-expected.txt:
• fast/layers/overflow-scroll-self-painting-expected.html: Added.
• fast/layers/overflow-scroll-self-painting.html: Added.
• platform/ios-wk2/compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:
• platform/ios-wk2/compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping-expected.txt:

5:02 PM Changeset in webkit [268946] by rniwa@webkit.org

• 7 edits in trunk

IPC testing API should expose ArrayBuffer for an unknown decoded argument
​https://bugs.webkit.org/show_bug.cgi?id=218113

Reviewed by Darin Adler.

Source/WebKit:

Expose the decoded argument as an ArrayBuffer when it can't be encoded as a JS value.

Also make the treatment of a JS array as a tuple or a Vector explicit in argument encoding.

Test: TestWebKitAPI.IPCTestingAPI.CanInterceptAlert

• Platform/IPC/Decoder.h:

(IPC::Decoder::currentBufferPosition const): Added.

• Platform/IPC/JSIPCBinding.cpp:

(IPC::putJSValueForDecodedArgumentAtIndexOrArrayBufferIfUndefined): Added.

• Platform/IPC/JSIPCBinding.h:

(IPC::DecodedArgumentJSValueConverter): Deleted.
(IPC::putJSValueForDecodeArgumentInArray): Replaced DecodedArgumentJSValueConverter.
Take Decoder and decode each tuple argument and create a JS value at a time.
(IPC::jsValueForArgumentTuple): Deleted. Merged into jsValueForDecodedArguments.
(IPC::jsValueForDecodedArguments):

• WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::VectorEncodeHelper::encode const):
(WebKit::IPCTestingAPI::encodeArrayArgument): Extracted out of encodeArgument.
(WebKit::IPCTestingAPI::encodeArgument): Treat an array as a tuple unless it's explicitly
specified that the argument's type is a Vector.

Tools:

Updated a test case to check that the unknown type produces an ArrayBuffer.

• TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

(IPCTestingAPI.CanInterceptAlert):

4:09 PM Changeset in webkit [268945] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output.html as flaky.

It was unskipped recently but it is still flaky.

• TestExpectations:

4:02 PM Changeset in webkit [268944] by Russell Epstein

• 1 copy in tags/Safari-610.2.11.51.6

Tag Safari-610.2.11.51.6.

4:00 PM Changeset in webkit [268943] by Alan Coon

• 8 edits in branches/safari-610.2.11.51-branch/Source

Versioning.

WebKit-7610.2.11.51.6

3:53 PM Changeset in webkit [268942] by keith_miller@apple.com

• 8 edits in trunk/Source/JavaScriptCore

Using WASM function size as the cap for choosing a register allocator causes performance regressions.
​https://bugs.webkit.org/show_bug.cgi?id=217290

Reviewed by Michael Saboff.

Previously in ​https://bugs.webkit.org/show_bug.cgi?id=212105 we
limited the size of WASM functions we compile with OMG because
sufficiently large functions caused us to OOM while register
allocating. The memory growth we saw is because the memory usage
of graph coloring is O((number of tmps)^{2). However, some large
WASM functions may not have that many tmps by the time we get to
register allocation. This patch changes our heuristic to instead
use the total number of tmps right before register allocation
instead of the WASM function size. The number of tmps is more
likely to represent the worst case memory usage of register
allocation. This fixes a performance regression in Safari 14 when running
​https://dos.zone/en/play/https%3A%2F%2Fdoszone-uploads.s3.dualstack.eu-central-1.amazonaws.com%2Foriginal%2F2X%2Fb%2Fb4b5275904d86a4ab8a20917b2b7e34f0df47bf7.jsdos}

• b3/air/AirGenerate.cpp:

(JSC::B3::Air::prepareForGeneration):

• runtime/OptionsList.h:
• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::AirIRGenerator):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::parseAndCompile):

• wasm/WasmCompilationMode.cpp:

(JSC::Wasm::wasmFunctionSizeCanBeOMGCompiled): Deleted.

• wasm/WasmCompilationMode.h:
• wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

2:27 PM Changeset in webkit [268941] by Hector Lopez

• 2 edits
  3 adds in trunk/LayoutTests

2 fast/canvas/canvas* tests are flaky failures
<rdar://70623742>

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

2:04 PM Changeset in webkit [268940] by Darin Adler

• 17 edits
  2 adds in trunk

Source/WebCore:
REGRESSION(r266295): DOMSelection's addRange and containsNode behave incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

Test: editing/selection/selections-across-trees.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::linkClickPoint): Update for the new name of
isPointInRange, contains<ComposedTree>. We can return and change it from ComposedTree
to something else since that's likely not the tree we need here.
(WebCore::AccessibilityRenderObject::setSelectedTextRange): Ditto.
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const): Ditto.

• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(isWhiteSpaceBetweenSentences): Ditto.

• dom/BoundaryPoint.h: Update to use TreeType enumeration instead of classes.
• dom/Node.cpp:

(WebCore::depth): Ditto.
(WebCore::commonInclusiveAncestorAndChildren): Ditto.
(WebCore::treeOrder): Ditto.

• dom/Node.h: Ditto.

• dom/Range.cpp:

(WebCore::Range::isPointInRange): Updated since we renamed isPointInRange to be
an overload of contains.

• dom/SimpleRange.cpp:

(WebCore::treeOrder): Update to use TreeType enumeration instead of classes.
(WebCore::contains): Ditto. Also renamed isPointInRange to an overload of contains.
Also added converted the contains that takes two ranges to a function template.
(WebCore::intersects): Ditto.

• dom/SimpleRange.h: Reorganized the functions so all the deprecated functions

that silently use ComposedTree are grouped together. Updated the function templates
to use TreeType enumeration instead of classes. Added a couple more function
templates that we used to fix DOMSelection.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains const): Update for the new name of sPointInRange,
contains<ComposedTree>. We can return and change it from ComposedTree to something
else since that's likely not the tree we need here.

• editing/mac/DictionaryLookupLegacy.mm:

(WebCore::selectionContainsPosition): Ditto.

• page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange): Use intersects<Tree> because we don't want to
use the composed tree here.
(WebCore::DOMSelection::containsNode const): Use intersects<Tree> and contains<Tree>.
Evantually <Tree> will be the default and we can come back here and edit down these
calls for brevity, but first we have to make all the uses of ComposedTree explicit.

Source/WebKitLegacy/win:
REGRESSION(r266295): DOMSelection's addRange and containsNode behave incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

• AccessibleTextImpl.cpp:

(AccessibleText::isInRange): Updated since we renamed isPointInRange to be
an overload of contains.

Tools:
REGRESSION(r266295): DOMSelection's addRange and containsNode behave incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

• TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Disabled the isPointInRange

test and added comments about how we will restore it in the future.

LayoutTests:
REGRESSION(r266295): DOMSelection's addRange and containsNode behaves incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

• editing/selection/selections-across-trees-expected.txt: Added.
• editing/selection/selections-across-trees.html: Added.

1:19 PM Changeset in webkit [268939] by eric.carlson@apple.com

• 7 edits in trunk

[Media in GPU Process] in-band metadata cues sometimes crash
​https://bugs.webkit.org/show_bug.cgi?id=218106
<rdar://problem/70226170>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, enabled existing test in the GPU process.

• platform/SerializedPlatformDataCueValue.h:

(WebCore::SerializedPlatformDataCueValue::SerializedPlatformDataCueValue):
(WebCore::SerializedPlatformDataCueValue::nativeValue const):
Make m_nativeValue a RetainPtr<> so the ownership and lifetime of the object is
explicit and managed correctly.

• platform/mac/SerializedPlatformDataCueMac.mm:

(WebCore::SerializedPlatformDataCueMac::encodableValue const): Update for change
to native value.
(WebCore::jsValueWithAVMetadataItemInContext): Ditto.
(WebCore::NSDictionaryWithAVMetadataItem): Return a RetainPtr<NSDictionary> instead
of an auto-released dictionary.

Source/WebKit:

• Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::SerializedPlatformDataCueValue>::encodePlatformData):
SerializedPlatformDataCueValue::nativeValue() is a RetainPtr<>.

LayoutTests:

• gpu-process/TestExpectations: Mark test as passing.

1:13 PM Changeset in webkit [268938] by Truitt Savell

• 5 edits in trunk/Tools

Unreviewed, reverting r268761.

May have casued webrtc crashes on Catalina Debug.

Reverted changeset:

"[webkitpy] Use allowlist and blocklist"
​https://bugs.webkit.org/show_bug.cgi?id=217985
​https://trac.webkit.org/changeset/268761

12:27 PM Changeset in webkit [268937] by Jonathan Bedard

• 3 edits
  1 delete in trunk/Tools

[webkitpy] Remove the old autointaller
​https://bugs.webkit.org/show_bug.cgi?id=218131
<rdar://problem/70627699>

Rubber-stamped by Aakash Jain.

• Scripts/webkitpy/test/main.py:

(Tester._run_tests): Remove reference to old autoinstaller.

• Scripts/webkitpy/thirdparty/init.py: Deleted content.

(autoinstall_everything): Deleted.

12:20 PM Changeset in webkit [268936] by Jonathan Bedard

• 7 edits in trunk/Tools

[webkitscmpy] Use 'which' to find git and svn paths
​https://bugs.webkit.org/show_bug.cgi?id=217717
<rdar://problem/70299192>

Rubber-stamped by Aakash Jain.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
• Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git):
(Git.executable): Generate git path from 'which' call.

• Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm.executable): Generate a program path from a 'which' call.

• Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn):
(Svn.executable): Generate svn path from 'which' call.

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:

(Git):

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:

(Svn.init):

11:54 AM Changeset in webkit [268935] by aakash_jain@apple.com

• 5 edits in trunk/Tools

[build.webkit.org] Add python 3 support - part 2
​https://bugs.webkit.org/show_bug.cgi?id=218130

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/buildbot.tac:
• BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
• BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
• BuildSlaveSupport/build.webkit.org-config/loadConfig_unittest.py:

11:51 AM Changeset in webkit [268934] by Aditya Keerthi

• 2 edits in trunk/Source/WebCore

webkit.org/status/ is missing input type=date (and related) features
​https://bugs.webkit.org/show_bug.cgi?id=195666

Reviewed by Darin Adler.

• features.json: Updated to include date and time input types.

11:49 AM Changeset in webkit [268933] by Simon Fraser

• 3 edits in trunk/LayoutTests

[ macOS wk2 ] fast/scrolling/latching/latched-scroll-remove-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216059
<rdar://problem/68177922>

Reviewed by Sam Weinig.

Deflake the test by not using a 16ms timeout, and remove the expectation.

• fast/scrolling/latching/latched-scroll-remove-iframe.html:
• platform/mac-wk2/TestExpectations:

11:35 AM Changeset in webkit [268932] by graouts@webkit.org

• 20 edits in trunk

REGRESSION(r268615): certain animations break when moving from one to display to another or resizing the window
​https://bugs.webkit.org/show_bug.cgi?id=218080
<rdar://problem/70547132>

Reviewed by Dean Jackson.

Source/WebCore:

Since transform-related animations include non-interpolating animations meant to insert the static base value for a given
transform-related CSS property, we need to update animations on GraphicsLayerCA whenever one of the transform-related CSS
properties have a new value.

We used to rely on GraphicsLayerCA::setTransform() being called with a different transform than the current one to identify
such cases, but that is suboptimal because that method can be called with a compound interpolated value of transform-related
CSS properties when a rendering update occurs, such as during resizing or moving a window between displays. In those cases,
the static base value of the transform-related CSS properties hasn't actually changed.

Instead, we now provide the non-animated style from the last style change event to the function resolving keyframe effects
so that for a given element we can compare that style with the new, as-yet-non-animated style and see if any of the transform-
related CSS properties have been changed. If that is the case, we inform any KeyframeEffect that has a running accelerated
animation for any of those CSS properties so that the effect may enqueue an accelerated action that will then notify the
GraphicsLayer of such a change, and trigger an animation update.

Since we were changing the applyKeyframeEffects() method signature to add the extra RenderStyle needed to compare the current
and previous non-animated styles, we also moved that method from Element to KeyframeEffectStack since no Element private
API was required.

No new test since this was already tested by webanimations/accelerated-translate-animation-underlying-transform-changed-in-flight.html
and it's not clear how to test the live-resizing or display-change scenario.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::isRunningAcceleratedTransformRelatedAnimation const): New method called from KeyframeEffectStack::applyKeyframeEffects()
to indicate that a keyframe effect has a running accelerated animation targeting a transform-related property.
(WebCore::KeyframeEffect::addPendingAcceleratedAction): Ensure that the new AcceleratedAction::TransformChange accelerated action
recorded in transformRelatedPropertyDidChange() is not ever set as m_lastRecordedAcceleratedAction as we use this member to identify
whether we have a pending running, pause or stop action.
(WebCore::KeyframeEffect::transformRelatedPropertyDidChange): New method meant to be called for an effect that has a running
accelerated animation targeting a transform-related property to notify that one or more of the target element's transform-related
CSS property static values was changed.
(WebCore::KeyframeEffect::applyPendingAcceleratedActions): Call transformRelatedPropertyDidChange() on the composited renderer for
a AcceleratedAction::TransformChange action.

• animation/KeyframeEffect.h:
• animation/KeyframeEffectStack.cpp:

(WebCore::KeyframeEffectStack::applyKeyframeEffects): Move the method previously exposed on Element to KeyframeEffectStack. Additionally,
accept an extra RenderStyle parameter to provide the non-animated style from the last style change event so that we can compare that style
with the new, as-yet-non-animated style and see if any of the transform-related CSS properties have been changed and notify the effect
should it run an accelerated animation for one of those properties.

• animation/KeyframeEffectStack.h:
• dom/Element.cpp:

(WebCore::Element::applyKeyframeEffects): Deleted. Moved to KeyframeEffectStack.

• dom/Element.h:
• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::transformRelatedPropertyDidChange):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setTransform): Move the animation-update logic to transformRelatedPropertyDidChange()
(WebCore::GraphicsLayerCA::transformRelatedPropertyDidChange):

• platform/graphics/ca/GraphicsLayerCA.h:
• rendering/RenderElement.h:

(WebCore::RenderElement::transformRelatedPropertyDidChange):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::transformRelatedPropertyDidChange):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::transformRelatedPropertyDidChange):

• rendering/RenderLayerModelObject.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate): Pass the non-animated style from the last style change event to
KeyframeEffectStack::applyKeyframeEffects() to determine whether this style change event includes a change to any of the
transform-related properties.

• style/Styleable.h:

(WebCore::Styleable::applyKeyframeEffects const):

LayoutTests:

Increase the fidelity of this test where the scale transform would sometimes yield some 0.01% ImageOnlyFailure results.

• webanimations/accelerated-translate-animation-additional-animation-added-in-flight-expected.html:
• webanimations/accelerated-translate-animation-additional-animation-added-in-flight.html:

11:23 AM Changeset in webkit [268931] by aakash_jain@apple.com

• 2 edits
  1 add in trunk/Tools

[build.webkit.org] Create master.cfg for newer buildbot
​https://bugs.webkit.org/show_bug.cgi?id=218102

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/buildbot.tac:
• BuildSlaveSupport/build.webkit.org-config/master_buildbot2.cfg: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg.

11:15 AM Changeset in webkit [268930] by Jonathan Bedard

• 7 edits
  2 adds
  1 delete in trunk/Tools

[webkitpy] Use webkitcorepy's autoinstaller for buildbot and twisted
​https://bugs.webkit.org/show_bug.cgi?id=218105
<rdar://problem/70593576>

Rubber-stamped by Aakash Jain.

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

(BuildBotConfigLoader._add_dependent_modules_to_sys_modules):

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.archives): tar.bz2 archives are tar.gz archives.
(Package.install): After r267056, we don't need "old-and-unmanageable" and
"single-version-externally-managed", handle case of nested modules more completely.

• Scripts/webkitpy/autoinstalled/buildbot.py: Added.
• Scripts/webkitpy/autoinstalled/twisted.py: Added.
• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:

Import new auto installed twisted.

• Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver._ensure_http_server_dependencies): Import new auto installed twisted.

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remove all modules.
(AutoinstallImportHook._install_buildbot): Deleted.
(AutoinstallImportHook._install_twisted_15_5_0): Deleted.

• Scripts/webkitpy/thirdparty/init_unittest.py: Removed.

11:08 AM Changeset in webkit [268929] by Nikita Vasilyev

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Typo in experimentalEnableStyelsJumpToVariableDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=218119

Reviewed by Devin Rousso.

Replace "Styels" with "Styles".

• UserInterface/Base/Setting.js:
• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._addVariableTokens):

11:03 AM Changeset in webkit [268928] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests/imported/w3c

REGRESSION (r267402): [ iOS Mojave+ Release ] imported/w3c/web-platform-tests/user-timing/measure-l3.any.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217414

Reviewed by Alex Christensen.

Sometimes lhs of comparison is higher by an infinitisimal margin.
Round number to two-digit precision to prevent such scenarios.

• web-platform-tests/user-timing/measure-l3.any.js:

(test):

10:10 AM Changeset in webkit [268927] by Hector Lopez

• 2 edits in trunk/LayoutTests

2 compositing/contents-scale/* tests are flaky failures
<rdar://70623742>

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

9:22 AM Changeset in webkit [268926] by Chris Dumez

• 6 edits in trunk

AnalyserNode's output should only have one channel
​https://bugs.webkit.org/show_bug.cgi?id=218125

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output-expected.txt:

Source/WebCore:

AnalyserNode's output should only have one channel. We were using 2 channels, which
was inconsistent with Blink and Gecko.

No new tests, rebaselined existing test.

• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

LayoutTests:

Unskip test that is no longer flaky, now that it passes.

• TestExpectations:

9:13 AM Changeset in webkit [268925] by aakash_jain@apple.com

• 11 edits in trunk/Tools

Rename slave to worker in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=218123

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/net/buildbot/buildbot.py:
• Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
• Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
• Scripts/webkitpy/common/system/crashlogs_unittest.py:
• Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests.py:
• Scripts/webkitpy/port/leakdetector_unittest.py:
• Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:

7:40 AM Changeset in webkit [268924] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Add initial support for vertical-align: <length> and <percentage>
​https://bugs.webkit.org/show_bug.cgi?id=218109

Reviewed by Antti Koivisto.

Raise (positive value) or lower (negative value) the box by this distance.
It fixes css2.1/20110323/vertical-align-boxes-001.htm.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::alignInlineLevelBoxesVerticallyAndComputeLineBoxHeight):

5:53 AM Changeset in webkit [268923] by magomez@igalia.com

• 13 edits in trunk

[GTK][WPE] Implement antialiased rounded rectangle clipping in TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=174457

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Implement rounded rectangle clipping in TextureMapperGL, supporting up to 10 simultaneous
rounded rectangle clips. TextureMapper::beginClip() now receives a rounded rectangle, and
it applies the appropriate clipping method as required.

The rounded rectangle clip implementation uses the fragment shader to calculate whether
each pixel is inside the defined rounded rectangles, and paints or skips it as needed.

• platform/graphics/texmap/ClipStack.cpp:

(WebCore::ClipStack::addRoundedRect):

• platform/graphics/texmap/ClipStack.h:

(WebCore::ClipStack::State::State):
(WebCore::ClipStack::roundedRectComponents const):
(WebCore::ClipStack::roundedRectInverseTransformComponents const):
(WebCore::ClipStack::roundedRectCount const):
(WebCore::ClipStack::isRoundedRectClipEnabled const):
(WebCore::ClipStack::isRoundedRectClipAllowed const):

• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::prepareRoundedRectClip):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTexturePlanarYUV):
(WebCore::TextureMapperGL::drawTextureSemiPlanarYUV):
(WebCore::TextureMapperGL::drawTexturePackedYUV):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::beginRoundedRectClip):
(WebCore::TextureMapperGL::beginClip):

• platform/graphics/texmap/TextureMapperGL.h:
• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

• platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore::TextureMapperShaderProgram::create):

• platform/graphics/texmap/TextureMapperShaderProgram.h:

Source/WebKit:

Use the new TextureMapper::beginClip() method that receives a FloatRoundedRect.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):

LayoutTests:

Update expectations for passing test.

• platform/gtk/TestExpectations:

5:44 AM Changeset in webkit [268922] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Fix inline box relative alignment when line-height is set
​https://bugs.webkit.org/show_bug.cgi?id=218107

Reviewed by Antti Koivisto.

Inline box relative vertical alignment logic should use the combination of the layout bounds
and the font metric values of the parent inline box.

The layout bound values (ascent and descent adjusted with half leading) normally match the font metric values,
unless the line-height is set to something other than normal.
In such cases the gap affects the vertical position of the child inline level boxes (e.g. text-top aligns with the
top of the text (use font metrics) and not with the layout bounds).

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::alignInlineLevelBoxesVerticallyAndComputeLineBoxHeight):

5:24 AM Changeset in webkit [268921] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.30.2

WPE WebKit 2.30.2

5:23 AM Changeset in webkit [268920] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.30.2 release

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.30.2.

2:55 AM Changeset in webkit [268919] by svillar@igalia.com

• 22 edits in trunk/Source/WebCore

Rename override sizes to overriding sizes
​https://bugs.webkit.org/show_bug.cgi?id=217898

Reviewed by Darin Adler.

We've been traditionally using the word "override" to refer to those sizes that were explicitly set by
layout systems like tables, flex or grid. However that's a grammatical mistake. override is a verb which
does not work well as a noun. It'd be more correct to refer to them as "overriding" sizes.

No new tests required as this is just a renaming.

• WebCore.order:
• rendering/ComplexLineLayout.cpp:

(WebCore::ComplexLineLayout::updateRubyForJustifiedText):

• rendering/GridLayoutFunctions.cpp:

(WebCore::GridLayoutFunctions::hasOverridingContainingBlockContentSizeForChild):
(WebCore::GridLayoutFunctions::overridingContainingBlockContentSizeForChild):
(WebCore::GridLayoutFunctions::hasOverrideContainingBlockContentSizeForChild): Deleted.
(WebCore::GridLayoutFunctions::overrideContainingBlockContentSizeForChild): Deleted.

• rendering/GridLayoutFunctions.h:
• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::shouldClearOverridingContainingBlockContentSizeForChild):
(WebCore::setOverridingContainingBlockContentSizeForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverridingContainingBlockContentSizeForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minLogicalSizeForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalSizeForChild const):
(WebCore::DefiniteSizeStrategy::minContentForChild const):
(WebCore::shouldClearOverrideContainingBlockContentSizeForChild): Deleted.
(WebCore::setOverrideContainingBlockContentSizeForChild): Deleted.
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const): Deleted.

• rendering/GridTrackSizingAlgorithm.h:
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::computeChildPreferredLogicalWidths const):
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::hasOverridingLogicalHeight const):
(WebCore::RenderBox::hasOverridingLogicalWidth const):
(WebCore::RenderBox::setOverridingLogicalHeight):
(WebCore::RenderBox::setOverridingLogicalWidth):
(WebCore::RenderBox::clearOverridingLogicalHeight):
(WebCore::RenderBox::clearOverridingLogicalWidth):
(WebCore::RenderBox::clearOverridingContentSize):
(WebCore::RenderBox::overridingLogicalWidth const):
(WebCore::RenderBox::overridingLogicalHeight const):
(WebCore::RenderBox::overridingContainingBlockContentWidth const):
(WebCore::RenderBox::overridingContainingBlockContentHeight const):
(WebCore::RenderBox::hasOverridingContainingBlockContentWidth const):
(WebCore::RenderBox::hasOverridingContainingBlockContentHeight const):
(WebCore::RenderBox::overridingContainingBlockContentLogicalWidth const):
(WebCore::RenderBox::overridingContainingBlockContentLogicalHeight const):
(WebCore::RenderBox::hasOverridingContainingBlockContentLogicalWidth const):
(WebCore::RenderBox::hasOverridingContainingBlockContentLogicalHeight const):
(WebCore::RenderBox::setOverridingContainingBlockContentLogicalWidth):
(WebCore::RenderBox::setOverridingContainingBlockContentLogicalHeight):
(WebCore::RenderBox::clearOverridingContainingBlockContentSize):
(WebCore::RenderBox::clearOverridingContainingBlockContentLogicalHeight):
(WebCore::RenderBox::containingBlockLogicalWidthForContent const):
(WebCore::RenderBox::containingBlockLogicalHeightForContent const):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::cacheIntrinsicContentLogicalHeightForFlexItem const):
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::computePercentageLogicalHeight const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::availableLogicalHeightUsing const):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):
(WebCore::RenderBox::hasOverrideLogicalHeight const): Deleted.
(WebCore::RenderBox::hasOverrideLogicalWidth const): Deleted.
(WebCore::RenderBox::setOverrideLogicalHeight): Deleted.
(WebCore::RenderBox::setOverrideLogicalWidth): Deleted.
(WebCore::RenderBox::clearOverrideLogicalHeight): Deleted.
(WebCore::RenderBox::clearOverrideLogicalWidth): Deleted.
(WebCore::RenderBox::clearOverrideContentSize): Deleted.
(WebCore::RenderBox::overrideLogicalWidth const): Deleted.
(WebCore::RenderBox::overrideLogicalHeight const): Deleted.
(WebCore::RenderBox::overrideContainingBlockContentWidth const): Deleted.
(WebCore::RenderBox::overrideContainingBlockContentHeight const): Deleted.
(WebCore::RenderBox::hasOverrideContainingBlockContentWidth const): Deleted.
(WebCore::RenderBox::hasOverrideContainingBlockContentHeight const): Deleted.
(WebCore::RenderBox::overrideContainingBlockContentLogicalWidth const): Deleted.
(WebCore::RenderBox::overrideContainingBlockContentLogicalHeight const): Deleted.
(WebCore::RenderBox::hasOverrideContainingBlockContentLogicalWidth const): Deleted.
(WebCore::RenderBox::hasOverrideContainingBlockContentLogicalHeight const): Deleted.
(WebCore::RenderBox::setOverrideContainingBlockContentLogicalWidth): Deleted.
(WebCore::RenderBox::setOverrideContainingBlockContentLogicalHeight): Deleted.
(WebCore::RenderBox::clearOverrideContainingBlockContentSize): Deleted.
(WebCore::RenderBox::clearOverrideContainingBlockContentLogicalHeight): Deleted.

• rendering/RenderBox.h:

(WebCore::RenderBox::overridingContentLogicalWidth const):
(WebCore::RenderBox::overridingContentLogicalHeight const):
(WebCore::RenderBox::overrideContentLogicalWidth const): Deleted.
(WebCore::RenderBox::overrideContentLogicalHeight const): Deleted.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const):
(WebCore::RenderBoxModelObject::relativePositionOffset const):

• rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::overridingContainingBlockContentWidth const):
(WebCore::RenderBoxModelObject::overridingContainingBlockContentHeight const):
(WebCore::RenderBoxModelObject::hasOverridingContainingBlockContentWidth const):
(WebCore::RenderBoxModelObject::hasOverridingContainingBlockContentHeight const):
(WebCore::RenderBoxModelObject::overrideContainingBlockContentWidth const): Deleted.
(WebCore::RenderBoxModelObject::overrideContainingBlockContentHeight const): Deleted.
(WebCore::RenderBoxModelObject::hasOverrideContainingBlockContentWidth const): Deleted.
(WebCore::RenderBoxModelObject::hasOverrideContainingBlockContentHeight const): Deleted.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::widthForChild):
(WebCore::heightForChild):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const):
(WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild):
(WebCore::RenderFlexibleBox::crossSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::constructFlexItem):
(WebCore::RenderFlexibleBox::setOverrideMainAxisContentSizeForChild):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

• rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreen::unwrapRenderer):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::overrideSizeChanged):
(WebCore::RenderGrid::updateGridAreaLogicalSize const):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::updateAutoMarginsInRowAxisIfNeeded):
(WebCore::RenderGrid::updateAutoMarginsInColumnAxisIfNeeded):
(WebCore::RenderGrid::gridAreaPositionForOutOfFlowChild const):

• rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::adjustInlineDirectionLineBounds const):

• rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverridingLogicalHeightFromRowHeight):
(WebCore::RenderTableCell::setOverrideLogicalHeightFromRowHeight): Deleted.

• rendering/RenderTableCell.h:
• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::relayoutCellIfFlexed):

2:44 AM Changeset in webkit [268918] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Fix argument order for double and/or ops on ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=218118

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-10-23
Reviewed by Adrian Perez de Castro.

The andDouble and orDouble macro assembler methods for ARMv7
incorrectly pass the destination register as the last argument,
whereas the assembler expects the destination to be the first
argument.

This fixes a failing testmasm test.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::andDouble):
(JSC::MacroAssemblerARMv7::orDouble):

2:23 AM Changeset in webkit [268917] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.30.2 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.30.2.

1:26 AM Changeset in webkit [268916] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r267875 - [GTK] WPE and backend versions are mixed up in webkit://gpu
​https://bugs.webkit.org/show_bug.cgi?id=217210

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2020-10-02
Reviewed by Adrian Perez de Castro.

• UIProcess/API/glib/WebKitProtocolHandler.cpp:

(WebKit::WebKitProtocolHandler::handleGPU):

1:26 AM WebKitGTK/2.30.x edited by Carlos Garcia Campos

(diff)

1:26 AM Changeset in webkit [268915] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r268000 - [GTK][X11] WebProcess crash in WebCore::GLContextGLX::createPbufferContext() with NVidia proprietary drivers
​https://bugs.webkit.org/show_bug.cgi?id=217323

Reviewed by Adrian Perez de Castro.

The returnedElements variable might remain uninitialized if the glXChooseFBConfig()
function call fails, leading to execution of the wrong code branch later.

• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::createPbufferContext): Initialized the returnedElements variable.

1:26 AM Changeset in webkit [268914] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r268472 - [GLIB] Fix linking error for systems not providing <sys/memfd.h>
​https://bugs.webkit.org/show_bug.cgi?id=217514

Reviewed by Carlos Garcia Campos.

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp: Unconditionally check for <sys/mman.h> which should always exist instead

of <sys/memfd.h>. Also define the fallback with syscall() only for linux systems (as it requires <linux/memfd.h>).

1:25 AM Changeset in webkit [268913] by Carlos Garcia Campos

• 24 edits in releases/WebKitGTK/webkit-2.30/Source

Merge r268522 - [GTK][WPE] Add support for smooth scrolling animation with async scrolling
​https://bugs.webkit.org/show_bug.cgi?id=210382

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Respect smooth-scrolling setting and fix deadlock issues with async
scrolling on nicosia path.

No new tests, no functional change.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scrollAnimatorEnabled const):

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::ThreadedScrollingTree):

• page/scrolling/ThreadedScrollingTree.h:

(WebCore::ThreadedScrollingTree::scrollAnimatorEnabled const):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ScrollingTreeFrameScrollingNodeNicosia):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ensureScrollAnimationKinetic):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ensureScrollAnimationSmooth):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::stopScrollAnimations):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionRelatedLayers):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ScrollingTreeOverflowScrollingNodeNicosia):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::repositionScrollingLayers):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ensureScrollAnimationKinetic):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ensureScrollAnimationSmooth):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
• platform/PlatformWheelEvent.h:
• platform/ScrollAnimation.h:
• platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::isActive const):

• platform/ScrollAnimationKinetic.h:
• platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::isActive const):

• platform/ScrollAnimationSmooth.h:
• platform/generic/ScrollAnimatorGeneric.cpp:

(WebCore::ScrollAnimatorGeneric::ensureSmoothScrollingAnimation):

Source/WebKit:

Add hasPreciseScrollingDeltas to GTK/WPE wheel events.

No new tests needed.

• Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

• Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode const):
(WebKit::WebWheelEvent::decode):

• Shared/WebWheelEvent.h:
• Shared/WebWheelEventCoalescer.cpp:

(WebKit::WebWheelEventCoalescer::canCoalesce):
(WebKit::WebWheelEventCoalescer::coalesce):

• Shared/gtk/NativeWebWheelEventGtk.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

• Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

• Shared/libwpe/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

1:25 AM Changeset in webkit [268912] by Carlos Garcia Campos

• 13 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r266390 - [GTK][WPE] Add support for smooth scrolling animation with async scrolling
​https://bugs.webkit.org/show_bug.cgi?id=210382

Reviewed by Carlos Garcia Campos.

This removes the dependency on ScrollableArea from
ScrollAnimationSmooth, which allows its use as a utility class for
smooth scrolling. This class is then used in the Nicosia async layer
composition scrolling code to provide smooth scrolling, when the
feature is enabled. This mirrors the work done in bug 209230 for
kinetic scrolling.

No new tests, enabling existing functionality in more situations.

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::scrollTo):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ScrollingTreeFrameScrollingNodeNicosia):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ScrollingTreeOverflowScrollingNodeNicosia):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
• platform/ScrollAnimation.h:

(WebCore::ScrollAnimation::serviceAnimation):

• platform/ScrollAnimationKinetic.cpp:
• platform/ScrollAnimationKinetic.h:
• platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::stop):
(WebCore::ScrollAnimationSmooth::updateVisibleLengths):
(WebCore::ScrollAnimationSmooth::animationTimerFired):

• platform/ScrollAnimationSmooth.h:
• platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

• platform/generic/ScrollAnimatorGeneric.cpp:

(WebCore::ScrollAnimatorGeneric::ScrollAnimatorGeneric):
(WebCore::ScrollAnimatorGeneric::ensureSmoothScrollingAnimation):

1:25 AM Changeset in webkit [268911] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WTF

Merge r267789 - [GTK] Chassis type check fails if the value is quoted
​https://bugs.webkit.org/show_bug.cgi?id=217123

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2020-09-30
Reviewed by Carlos Garcia Campos.

Sometimes the chassis type can be quoted, in this case we'll fail to
parse it and fall back to desktop type. Unquote the string before
attempting to parse it.

• wtf/glib/ChassisType.cpp:

(WTF::readMachineInfoChassisType):

1:25 AM Changeset in webkit [268910] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r268906 - [SOUP] Fix crash in WebSocketTask
​https://bugs.webkit.org/show_bug.cgi?id=217892

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-10-23
Reviewed by Carlos Garcia Campos.

The WebSocketTask connects to the "starting" signal of its SoupMessage and never disconnects
this signal, which is only safe if it is guaranteed to outlive its SoupMessage. However, it
is not. We crash when the signal is emitted after the WebSocketTask is destroyed. To solve
this, we just need to disconnect the signal when required. Normally that would be done in
the destructor, but the WebSocketTask drops its ownership of the SoupMessage prior to that
point, so we need to disconnect on each possible paths.

• NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::~WebSocketTask):
(WebKit::WebSocketTask::didConnect):
(WebKit::WebSocketTask::didFail):

1:25 AM Changeset in webkit [268909] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r268394 - [SOUP] webkit_web_view_get_https_status() broken with service workers
​https://bugs.webkit.org/show_bug.cgi?id=216038

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-10-13
Reviewed by Carlos Garcia Campos.

This implements CertificateInfo::isolatedCopy for libsoup ports. This is impossible to do
completely, because we cannot copy the private key portion of the GTlsCertificate, because
it is a write-only property, because it might be backed by a hardware token and therefore
really impossible to write software to get it. If we were to implement g_tls_certificate_copy()
in GLib -- which I will probably do eventually, because I need this outside WebKit as well --
then GTlsCertificate implementations could copy the private key or PKCS#11 handle or
whatever.

But anyway, let not perfect be the enemy of the good. We only need this for service workers
currently. (Probably that's all we'll *ever* need it for.) So we are only working with
server certificates, and the private portion of the certificate is guaranteed to not exist
(because servers don't send us their private keys), and we can just forget about it. As
long as nobody tries to copy a client certificate in the future -- where we really would
need the private key portion of the certificate -- this will be perfectly fine.

Actually copying the certificate is kind of annoying, because a chain of certificates is
represented by having the main (server) certificate keep a reference to its issuer, which is
not referenced anywhere else, so we have to reconstruct the chain in reverse order starting
from the final certificate, working back towards the server cert. Fun. Let's also be
careful to construct a completely new GByteArray rather than expecting the GTlsCertificate
implementation to copy it for us. Because GTlsCertificate is implemented by an extension
point and applications and system administrators can -- and do -- implement their own,
implementations could do anything, including keep a reference to the GByteArray that we
pass in.

It would be nice to have a test for this, but writing tests is hard. Also, I don't really
want to learn what service workers are. :)

Drive-by fix: also remove explicit from a constructor that doesn't need it.

• platform/network/soup/CertificateInfo.h:

(WebCore::CertificateInfo::isolatedCopy const):

• platform/network/soup/CertificateInfoSoup.cpp:

(WebCore::createCertificate):
(WebCore::CertificateInfo::isolatedCopy const):

1:25 AM Changeset in webkit [268908] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.30

Merge r268392 - [GStreamer] Crash in WebCore::GStreamerRegistryScanner::isAVC1CodecSupported
​https://bugs.webkit.org/show_bug.cgi?id=217647

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The registry scanner was assuming the avc1 codec field is always of the form
avc1.codecprofile, which is wrong.

Covered by test: media/media-can-play-mpeg4-video.html

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const): Check for '.' presence and
fallback to unconstrained check if no profile or level information was extracted.

LayoutTests:

• media/media-can-play-mpeg4-video-expected.txt:
• media/media-can-play-mpeg4-video.html: Add test for "avc1" codec.

1:06 AM Changeset in webkit [268907] by commit-queue@webkit.org

• 7 edits in trunk

[GStreamer] Replace USE(WEBAUDIO_GSTREAMER) with USE(GSTREAMER)
​https://bugs.webkit.org/show_bug.cgi?id=218083

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-10-23
Reviewed by Xabier Rodriguez-Calvar.

.:

A separate define was introduced back when we thought enabling WebAudio without enabling
<audio> would be a highly relevant scenario. I don't think it is very relevant, let's clean
this up.

• Source/cmake/GStreamerChecks.cmake: Wrap the WebAudio platform bits in the USE(GSTREAMER) umbrella.

Source/WebCore:

• platform/audio/FFTFrame.h: No need for G_{BEGIN,END}_DECLS dance anymore, these were added

upstream 9 years ago.

• platform/audio/FFTFrameStub.cpp:
• platform/audio/HRTFElevation.cpp:
• platform/audio/gstreamer/FFTFrameGStreamer.cpp:

12:33 AM Changeset in webkit [268906] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[SOUP] Fix crash in WebSocketTask
​https://bugs.webkit.org/show_bug.cgi?id=217892

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-10-23
Reviewed by Carlos Garcia Campos.

The WebSocketTask connects to the "starting" signal of its SoupMessage and never disconnects
this signal, which is only safe if it is guaranteed to outlive its SoupMessage. However, it
is not. We crash when the signal is emitted after the WebSocketTask is destroyed. To solve
this, we just need to disconnect the signal when required. Normally that would be done in
the destructor, but the WebSocketTask drops its ownership of the SoupMessage prior to that
point, so we need to disconnect on each possible paths.

• NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::~WebSocketTask):
(WebKit::WebSocketTask::didConnect):
(WebKit::WebSocketTask::didFail):

Oct 22, 2020:

10:30 PM Changeset in webkit [268905] by Fujii Hironori

• 9 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening

Updated expected.png for compositing and transforms tests.

• platform/gtk/compositing/reflections/animation-inside-reflection-expected.png:
• platform/gtk/compositing/webgl/webgl-background-color-expected.png:
• platform/gtk/compositing/webgl/webgl-nonpremultiplied-blend-expected.png:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-2-expected.png:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-expected.png:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
• platform/gtk/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:

9:25 PM Changeset in webkit [268904] by commit-queue@webkit.org

• 8 edits in trunk

Null check platformStrategies when making blob read stream for an NSURLRequest
​https://bugs.webkit.org/show_bug.cgi?id=218112
<rdar://problem/70507102>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-10-22
Reviewed by Wenson Hsieh.

Source/WebCore:

r266187 made it possible to create a DataTransfer without a user event, which allows you to make a FileList,
which allows you to submit a multipart form without a user event that calls decidePolicyForNavigationAction
with a request that has a form data body that would make a blob upload stream. This causes us to use
platformStrategies in the UI process, which dereferences null. Since the blob only really exists in the network
process, just return a nil HTTPBody in such an exotic case instead of crashing.

Covered by an API test that would hit this crash. Web platform tests were insufficient because WebKitTestRunner does not
access WKNavigationAction.request, but Safari does.

• platform/PlatformStrategies.cpp:

(WebCore::hasPlatformStrategies):

• platform/PlatformStrategies.h:
• platform/network/FormData.cpp:

(WebCore::FormData::containsBlobElement const):
(WebCore::FormData::resolveBlobReferences):

• platform/network/FormData.h:
• platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::createHTTPBodyCFReadStream):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:

(TEST):

8:49 PM Changeset in webkit [268903] by clopez@igalia.com

• 4 edits in trunk/LayoutTests

[GTK][WPE] Gardening of failures happening on the bots.

Unreviewed gardening.

• platform/glib/TestExpectations:
• platform/gtk-wayland/TestExpectations:
• platform/gtk/TestExpectations:

6:38 PM Changeset in webkit [268902] by Simon Fraser

• 8 edits in trunk

REGRESSION(r268476): [ macOS ] tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=218031
<rdar://problem/70532268>

Reviewed by Tim Horton.
Source/WebCore:

The test exercises wheel event regions in non-composited iframes. These were not reliably updated
when all wheel event handlers were removed, because Frame::invalidateContentEventRegionsIfNeeded()
early-returned if there were no handlers (but we need to update the regions in this case). Clean
up the logic here, and pass in a "reason" so we know that we should do work when there are no
handlers.

Document::wheelEventHandlersChanged() also needs to invalidate style, since flags in style
are used for wheel event region building, and it needs to call invalidateContentEventRegionsIfNeeded().

• dom/Document.cpp:

(WebCore::Document::wheelEventHandlersChanged):
(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):

• dom/Document.h:
• page/Frame.cpp:

(WebCore::Frame::invalidateContentEventRegionsIfNeeded):

• page/Frame.h:
• page/FrameView.cpp:

(WebCore::FrameView::didLayout):

LayoutTests:

• platform/mac/TestExpectations:

6:32 PM Changeset in webkit [268901] by Aditya Keerthi

• 21 edits
  1 copy
  6 adds in trunk

[Contact Picker API] Add skeleton implementation of ContactsManager.select()
​https://bugs.webkit.org/show_bug.cgi?id=218050
<rdar://problem/69862186>

Reviewed by Devin Rousso.

Source/WebCore:

ContactsManager.select() is the interface that allows clients to
present a contact picker. The method should immediately reject when
called from a subframe, when called outside user-interaction and when
called while a contact picker is already being displayed. Furthermore,
the promise is rejected when the supplied properties are empty or
invalid.

After the conditions necessary for the UI to be presented are verified,
ContactsManager.select() calls into the page's Chrome to display the
picker. The UI implementation on macOS and iOS will be done in
forthcoming patches.

See ​https://wicg.github.io/contact-api/spec/#contacts-manager-select
for more information.

Tests: contact-picker/contacts-select-invalid-properties-and-options.html

contact-picker/contacts-select-requires-user-gesture.html
contact-picker/contacts-select-subframe.html

• Headers.cmake:
• Modules/contact-picker/ContactInfo.h: Added encoder and decoder for IPC.

(WebCore::ContactInfo::encode const):
(WebCore::ContactInfo::decode):

• Modules/contact-picker/ContactInfo.idl:
• Modules/contact-picker/ContactProperty.h:
• Modules/contact-picker/ContactsManager.cpp:

(WebCore::ContactsManager::frame const):
(WebCore::ContactsManager::select):

• Modules/contact-picker/ContactsManager.h:
• Modules/contact-picker/ContactsRequestData.h: Added.

ContactsRequestData encapsulates the information required to display a
picker UI. This includes the requested properties, the URL of the
presenting site, and whether multiple contact selection should be allowed.

(WebCore::ContactsRequestData::encode const):
(WebCore::ContactsRequestData::decode):

• WebCore.xcodeproj/project.pbxproj:
• page/Chrome.cpp:

(WebCore::Chrome::showContactPicker):

• page/Chrome.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::showContactPicker):

Source/WebKit:

Added the necessary plumbing in order for the UIProcess to display a
contact picker after a call to ContactsManager.select() is made.

• UIProcess/PageClient.h:

(WebKit::PageClient::showContactPicker):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContactPicker):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::showContactPicker):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::showContactPicker):

• WebProcess/WebPage/WebPage.h:

LayoutTests:

Added tests for failure cases of the API. Note that success cases are
untested since no platforms currently display a picker UI, and the
specification states that the promise should fail in this case. The
success test cases will be added once the UI is implemented for iOS.

• contact-picker/contacts-select-invalid-properties-and-options-expected.txt: Added.
• contact-picker/contacts-select-invalid-properties-and-options.html: Added.
• contact-picker/contacts-select-requires-user-gesture-expected.txt: Added.
• contact-picker/contacts-select-requires-user-gesture.html: Added.
• contact-picker/contacts-select-subframe-expected.txt: Added.
• contact-picker/contacts-select-subframe.html: Added.

6:00 PM Changeset in webkit [268900] by Chris Dumez

• 27 edits in trunk/Source/WebCore

Use WorkerOrWorkletGlobalScope in WebInspector code instead of WorkerGlobalScope
​https://bugs.webkit.org/show_bug.cgi?id=218108

Reviewed by Darin Adler and Devin Rousso.

Use WorkerOrWorkletGlobalScope in WebInspector code instead of WorkerGlobalScope,
in preparation for Worklets support. This will allow us to reuse this code when
we add Web Inspector support for Worklets.

No new tests, no behavior change yet.

• Modules/webaudio/AudioWorkletThread.cpp:

(WebCore::AudioWorkletThread::workerDebuggerProxy const):

• Modules/webaudio/AudioWorkletThread.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::instrumentingAgentsForWebGPUDevice):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentTracking):
(WebCore::InspectorInstrumentation::instrumentingAgentsFor):
(WebCore::InspectorInstrumentation::instrumentingAgentsForRenderer): Deleted.
(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerGlobalScope): Deleted.
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage): Deleted.
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext): Deleted.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore::InspectorInstrumentation::identifierForNode):
(WebCore::InspectorInstrumentation::addEventListenersToNode):
(WebCore::InspectorInstrumentation::willInsertDOMNode):
(WebCore::InspectorInstrumentation::didInsertDOMNode):
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
(WebCore::InspectorInstrumentation::willInvalidateStyleAttr):
(WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
(WebCore::InspectorInstrumentation::documentDetached):
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::mediaQueryResultChanged):
(WebCore::InspectorInstrumentation::activeStyleSheetsUpdated):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):
(WebCore::InspectorInstrumentation::didChangeCustomElementState):
(WebCore::InspectorInstrumentation::pseudoElementCreated):
(WebCore::InspectorInstrumentation::pseudoElementDestroyed):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore::InspectorInstrumentation::didChangeRegionOverset):
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
(WebCore::InspectorInstrumentation::handleTouchEvent):
(WebCore::InspectorInstrumentation::handleMousePress):
(WebCore::InspectorInstrumentation::forcePseudoState):
(WebCore::InspectorInstrumentation::characterDataModified):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
(WebCore::InspectorInstrumentation::willFetch):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::didAddEventListener):
(WebCore::InspectorInstrumentation::willRemoveEventListener):
(WebCore::InspectorInstrumentation::isEventListenerDisabled):
(WebCore::InspectorInstrumentation::willPostMessage):
(WebCore::InspectorInstrumentation::didPostMessage):
(WebCore::InspectorInstrumentation::didFailPostMessage):
(WebCore::InspectorInstrumentation::willDispatchPostMessage):
(WebCore::InspectorInstrumentation::didDispatchPostMessage):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didCallFunction):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::didDispatchEvent):
(WebCore::InspectorInstrumentation::willHandleEvent):
(WebCore::InspectorInstrumentation::didHandleEvent):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::eventDidResetAfterDispatch):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::didEvaluateScript):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::didFireTimer):
(WebCore::InspectorInstrumentation::didInvalidateLayout):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::didLayout):
(WebCore::InspectorInstrumentation::didScroll):
(WebCore::InspectorInstrumentation::willComposite):
(WebCore::InspectorInstrumentation::didComposite):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::didRecalculateStyle):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculation):
(WebCore::InspectorInstrumentation::applyUserAgentOverride):
(WebCore::InspectorInstrumentation::applyEmulatedMedia):
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::willSendRequestOfType):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveThreadableLoaderResponse):
(WebCore::InspectorInstrumentation::didReceiveData):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
(WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
(WebCore::InspectorInstrumentation::continueWithPolicyDownload):
(WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
(WebCore::InspectorInstrumentation::willLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::didLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::scriptImported):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):
(WebCore::InspectorInstrumentation::didReceiveScriptResponse):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetachedFromParent):
(WebCore::InspectorInstrumentation::didCommitLoad):
(WebCore::InspectorInstrumentation::frameDocumentUpdated):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
(WebCore::InspectorInstrumentation::defaultAppearanceDidChange):
(WebCore::InspectorInstrumentation::willIntercept):
(WebCore::InspectorInstrumentation::shouldInterceptRequest):
(WebCore::InspectorInstrumentation::shouldInterceptResponse):
(WebCore::InspectorInstrumentation::interceptRequest):
(WebCore::InspectorInstrumentation::interceptResponse):
(WebCore::InspectorInstrumentation::didOpenDatabase):
(WebCore::InspectorInstrumentation::didDispatchDOMStorageEvent):
(WebCore::InspectorInstrumentation::shouldWaitForDebuggerOnStart):
(WebCore::InspectorInstrumentation::workerStarted):
(WebCore::InspectorInstrumentation::workerTerminated):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrame):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameError):
(WebCore::InspectorInstrumentation::didSendWebSocketFrame):
(WebCore::InspectorInstrumentation::didHandleMemoryPressure):
(WebCore::InspectorInstrumentation::didChangeCSSCanvasClientNodes):
(WebCore::InspectorInstrumentation::didCreateCanvasRenderingContext):
(WebCore::InspectorInstrumentation::didChangeCanvasMemory):
(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::didFinishRecordingCanvasFrame):
(WebCore::InspectorInstrumentation::didEnableExtension):
(WebCore::InspectorInstrumentation::didCreateWebGLProgram):
(WebCore::InspectorInstrumentation::willDestroyWebGLProgram):
(WebCore::InspectorInstrumentation::isWebGLProgramDisabled):
(WebCore::InspectorInstrumentation::isWebGLProgramHighlighted):
(WebCore::InspectorInstrumentation::willConfigureSwapChain):
(WebCore::InspectorInstrumentation::willDestroyWebGPUPipeline):
(WebCore::InspectorInstrumentation::willApplyKeyframeEffect):
(WebCore::InspectorInstrumentation::didChangeWebAnimationName):
(WebCore::InspectorInstrumentation::didSetWebAnimationEffect):
(WebCore::InspectorInstrumentation::didChangeWebAnimationEffectTiming):
(WebCore::InspectorInstrumentation::didChangeWebAnimationEffectTarget):
(WebCore::InspectorInstrumentation::didCreateWebAnimation):
(WebCore::InspectorInstrumentation::willDestroyWebAnimation):
(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::consoleCountReset):
(WebCore::InspectorInstrumentation::takeHeapSnapshot):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::logConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleTimeStamp):
(WebCore::InspectorInstrumentation::startProfiling):
(WebCore::InspectorInstrumentation::stopProfiling):
(WebCore::InspectorInstrumentation::consoleStartRecordingCanvas):
(WebCore::InspectorInstrumentation::consoleStopRecordingCanvas):
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
(WebCore::InspectorInstrumentation::didFireAnimationFrame):
(WebCore::InspectorInstrumentation::willFireObserverCallback):
(WebCore::InspectorInstrumentation::didFireObserverCallback):
(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):
(WebCore::InspectorInstrumentation::instrumentingAgentsFor):
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext): Deleted.
(WebCore::InspectorInstrumentation::instrumentingAgentsForFrame): Deleted.
(WebCore::InspectorInstrumentation::instrumentingAgentsForDocument): Deleted.
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage): Deleted.
(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerGlobalScope): Deleted.

• inspector/InspectorWebAgentBase.h:

(WebCore::WorkerAgentContext::WorkerAgentContext):

• inspector/WorkerDebugger.cpp:

(WebCore::WorkerDebugger::WorkerDebugger):
(WebCore::WorkerDebugger::attachDebugger):
(WebCore::WorkerDebugger::detachDebugger):
(WebCore::WorkerDebugger::runEventLoopWhilePaused):

• inspector/WorkerDebugger.h:
• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::workerAgentContext):
(WebCore::WorkerInspectorController::createLazyAgents):
(WebCore::WorkerInspectorController::vm):

• inspector/WorkerInspectorController.h:
• inspector/WorkerToPageFrontendChannel.h:
• inspector/agents/worker/ServiceWorkerAgent.cpp:

(WebCore::ServiceWorkerAgent::ServiceWorkerAgent):

• inspector/agents/worker/WorkerAuditAgent.cpp:

(WebCore::WorkerAuditAgent::WorkerAuditAgent):
(WebCore::WorkerAuditAgent::injectedScriptForEval):

• inspector/agents/worker/WorkerAuditAgent.h:
• inspector/agents/worker/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):

• inspector/agents/worker/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::breakpointActionLog):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

• inspector/agents/worker/WorkerDebuggerAgent.h:
• inspector/agents/worker/WorkerNetworkAgent.cpp:

(WebCore::WorkerNetworkAgent::WorkerNetworkAgent):
(WebCore::WorkerNetworkAgent::setResourceCachingDisabledInternal):
(WebCore::WorkerNetworkAgent::scriptExecutionContext):

• inspector/agents/worker/WorkerNetworkAgent.h:
• inspector/agents/worker/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):

• inspector/agents/worker/WorkerRuntimeAgent.h:
• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::prepareForDestruction):

• workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::inspectorController const): Deleted.

• workers/WorkerOrWorkletGlobalScope.cpp:

(WebCore::WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope):
(WebCore::WorkerOrWorkletGlobalScope::prepareForDestruction):

• workers/WorkerOrWorkletGlobalScope.h:

(WebCore::WorkerOrWorkletGlobalScope::inspectorController const):

• workers/WorkerOrWorkletThread.h:
• workers/WorkerThread.h:

(WebCore::WorkerThread::workerDebuggerProxy const): Deleted.

5:20 PM Changeset in webkit [268899] by Russell Epstein

• 1 copy in tags/Safari-610.2.11.51.5

Tag Safari-610.2.11.51.5.

4:15 PM Changeset in webkit [268898] by Simon Fraser

• 7 edits
  2 adds in trunk

Twitter Photo gallery incorrectly rendered after opening another modal
​https://bugs.webkit.org/show_bug.cgi?id=217737
<rdar://problem/70314822>

Reviewed by Zalan Bujtas.
Source/WebCore:

If a layer with a certain configuration of clipping layers had non-zero border-radius, then
changes to zero border-radius, we'd fail to undo the composited rounded-corner masking.
This was because RenderLayerBacking::updateGeometry() didn't call setMasksToBoundsRect()
in the non-rounded corner case.

The compositing code in general tries to separate "configuration" changes (i.e. setting
up the right layer hierarchy) from "geometry" changes (setting positions and sizes).
In this area, those responsibilities were muddied because the return value from
setMasksToBoundsRect() was used to know whether the platform-specific GraphicsLayer
supports rounded-corner clips. This forced RenderLayerBacking::updateChildClippingStrategy()
to do some geometry computation.

Clean that up by adding the static GraphicsLayer::supportsRoundedClip(), and use
that to know if the platform needs a m_childClippingMaskLayer (all non-CA platforms).
Now updateChildClippingStrategy() can be purely about hierarchy, and updateGeometry()
can focus on geometry. In updateGeometry(), we are sure to call setMasksToBoundsRect()
in the non-rounded corner case too.

Test: compositing/style-change/border-radius-change.html

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::supportsRoundedClip):
(WebCore::GraphicsLayer::setMasksToBoundsRect):

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setMasksToBoundsRect): Deleted.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::supportsRoundedClip):
(WebCore::GraphicsLayerCA::setMasksToBoundsRect):

• platform/graphics/ca/GraphicsLayerCA.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateChildClippingStrategy):

LayoutTests:

• compositing/style-change/border-radius-change-expected.html: Added.
• compositing/style-change/border-radius-change.html: Added.

3:25 PM Changeset in webkit [268897] by Chris Dumez

• 19 edits
  1 copy in trunk/Source/WebCore

Share more code between WorkerThread and AudioWorkletThread
​https://bugs.webkit.org/show_bug.cgi?id=218051

Reviewed by Geoffrey Garen.

Share more code between WorkerThread and AudioWorkletThread by moving more logic
to the WorkerOrWorklet base class.

No new tests, no web-facing behavior change.

• Modules/webaudio/AudioWorkletMessagingProxy.cpp:

(WebCore::generateWorkletParameters):

• Modules/webaudio/AudioWorkletThread.cpp:

(WebCore::AudioWorkletThread::AudioWorkletThread):
(WebCore::AudioWorkletThread::createGlobalScope):
(WebCore::AudioWorkletThread::workerLoaderProxy):
(WebCore::AudioWorkletThread::createThread):
(WebCore::AudioWorkletThread::globalScope const):

• Modules/webaudio/AudioWorkletThread.h:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• page/MemoryRelease.cpp:

(WebCore::releaseMemory):

• page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformCollectCPUData):

• page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::ResourceUsageThread::platformCollectCPUData):

• workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::runEventLoop):

• workers/WorkerGlobalScope.h:
• workers/WorkerOrWorkletGlobalScope.h:

(WebCore::WorkerOrWorkletGlobalScope::suspend):
(WebCore::WorkerOrWorkletGlobalScope::resume):

• workers/WorkerOrWorkletThread.cpp: Copied from Source/WebCore/workers/WorkerThread.cpp.

(WebCore::WorkerOrWorkletThread::workerOrWorkletThreadsLock):
(WebCore::WorkerOrWorkletThread::WorkerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::~WorkerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::startRunningDebuggerTasks):
(WebCore::WorkerOrWorkletThread::stopRunningDebuggerTasks):
(WebCore::WorkerOrWorkletThread::runEventLoop):
(WebCore::WorkerOrWorkletThread::workerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::start):
(WebCore::WorkerOrWorkletThread::stop):
(WebCore::WorkerOrWorkletThread::suspend):
(WebCore::WorkerOrWorkletThread::resume):
(WebCore::WorkerOrWorkletThread::releaseFastMallocFreeMemoryInAllThreads):

• workers/WorkerOrWorkletThread.h:

(WebCore::WorkerOrWorkletThread::thread const):
(WebCore::WorkerOrWorkletThread::globalScope const):
(WebCore::WorkerOrWorkletThread::runLoop):
(WebCore::WorkerOrWorkletThread::start):
(WebCore::WorkerOrWorkletThread::stop):
(WebCore::WorkerOrWorkletThread::identifier const):
(WebCore::WorkerOrWorkletThread::evaluateScriptIfNecessary):
(WebCore::WorkerOrWorkletThread::shouldWaitForWebInspectorOnStartup const):

• workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
(WebCore::WorkerThread::createThread):
(WebCore::WorkerThread::createGlobalScope):
(WebCore::WorkerThread::shouldWaitForWebInspectorOnStartup const):
(WebCore::WorkerThread::evaluateScriptIfNecessary):
(WebCore::WorkerThread::globalScope):

• workers/WorkerThread.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::queueTaskToFireFetchEvent):
(WebCore::ServiceWorkerThread::queueTaskToPostMessage):
(WebCore::ServiceWorkerThread::queueTaskToFireInstallEvent):
(WebCore::ServiceWorkerThread::queueTaskToFireActivateEvent):
(WebCore::ServiceWorkerThread::finishedEvaluatingScript):

• worklets/Worklet.cpp:

(WebCore::Worklet::Worklet):

• worklets/Worklet.h:

(WebCore::Worklet::identifier const):

• worklets/WorkletParameters.h:

(WebCore::WorkletParameters::isolatedCopy const):

3:13 PM Changeset in webkit [268896] by Jonathan Bedard

• 3 edits
  4 adds in trunk/Tools

[webkitpy] Use webkitcorepy's autoinstaller for chrome and gecko drivers
​https://bugs.webkit.org/show_bug.cgi?id=218059
<rdar://problem/70551255>

Rubber-stamped by Aakash Jain.

• Scripts/webkitpy/autoinstalled: Added.
• Scripts/webkitpy/autoinstalled/init.py: Added.
• Scripts/webkitpy/autoinstalled/chromedriver.py: Added.

(ChromeDriverPackage): Special listing rules for the chrome driver.

• Scripts/webkitpy/autoinstalled/geckodriver.py: Added.

(GeckoDriverPackage): Special listing rules for the GeckoDriver.

• Scripts/webkitpy/benchmark_runner/utils.py:

(get_driver_binary_path):

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remove Chrome and Gecko drivers.
(AutoinstallImportHook.install_chromedriver): Deleted.
(AutoinstallImportHook.install_geckodriver): Deleted.
(get_driver_filename): Deleted.
(get_os_info): Deleted.

3:06 PM Changeset in webkit [268895] by Adrian Perez de Castro

• 5 edits in trunk/Source/WebCore

Non-unified build fixes, late-ish October 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=218095

Unreviewed non-unified build fix.

No new tests needed.

• Modules/speech/SpeechRecognitionResultList.h: Include SpeechRecognitionResult.h

instead of using a forward declaration.

• layout/integration/LayoutIntegrationLineLayout.cpp: Add missing RenderImage.h header.
• page/scrolling/ScrollingTreeLatchingController.h: Add missing wtf/OptionSet.h header

and forward-declare WheelEventProcessingSteps.

• workers/WorkerOrWorkletGlobalScope.cpp: Add missing WorkerOrWorkletThread.h and

WorkerRunLoop.h headers.

3:01 PM Changeset in webkit [268894] by Alan Coon

• 1 copy in tags/Safari-611.1.4

Tag Safari-611.1.4.

2:56 PM Changeset in webkit [268893] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Web Audio continues to play when navigating off the web page via an iframe
​https://bugs.webkit.org/show_bug.cgi?id=218078

Reviewed by Eric Carlson.

The page was suspending playback when clicking the link and then resuming playback in the pagehide
event handler. The issue is that the AudioContext's state gets updated asynchronously when the
page suspends or resume rendering, as per specification. When entering the back/forward cache,
AudioContext::suspend() would be called but would do nothing because the state was "suspended",
despite the script having just called "resume()". To address the issue, AudioContext::suspend()
now early returns only if the context is closed or based on the m_wasSuspendedByScript flag
when gets updated synchronously when the script calls suspend() / resume(). Similarly,
AudioContext::resume() checks those same flags now.

No new tests, this impacts audio rendering on speakers but is not web-observable.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::resumeRendering):
Check if the MediaSession is interrupted before asynchronously setting the AudioContext's state
to "running". This is important because the state gets updated asynchronously but the MediaSession
can be interrupted synchronously when AudioContext::suspend() gets called, which would have set
the AudioContext's state to "interrupted". We don't want to incorrectly change the state from
"interrupted" to "running" in this case. Note that AudioContext::suspendRendering() already does
the same thing.

(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
Only early return if the AudioContext is closed or if the m_wasSuspendedByScript flag is set. The
m_wasSuspendedByScript gets updated synchronously when suspendRendering() / resumeRendering() get
called, unlike the AudioContext's state which gets updated asynchronously.

(WebCore::AudioContext::suspendPlayback):
Stop early returning if the state is "suspended". This was wrong since the state gets updated
asynchronously.

2:34 PM Changeset in webkit [268892] by Lauro Moura

• 3 edits in trunk/LayoutTests

[GLIB] Gardening some crashes

Unreviewed test gardening.

Mesa 'hydra' crashes still almost every build.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

2:23 PM Changeset in webkit [268891] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening. Move WebAudio test failure entries to GLIB.

Also gardened a few more flaky failures.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

1:32 PM Changeset in webkit [268890] by aakash_jain@apple.com

• 2 edits in trunk/Tools

report-non-inclusive-language should also report total for all the non-inclusive terms
​https://bugs.webkit.org/show_bug.cgi?id=218096

Reviewed by Darin Adler.

• Scripts/report-non-inclusive-language: Report total for all the non-inclusive terms. Also improved

formatting of the output to make it one-line.

1:31 PM Changeset in webkit [268889] by commit-queue@webkit.org

• 19 edits in trunk

Rename scroll-snap-margin to scroll-margin
​https://bugs.webkit.org/show_bug.cgi?id=218075

Patch by Martin Robinson <​mrobinson@igalia.com> on 2020-10-22
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Update result for newly passing test.
• web-platform-tests/css/css-scroll-snap/inheritance-expected.txt: Ditto
• web-platform-tests/css/css-scroll-snap/parsing/scroll-margin-computed-expected.txt: Ditto.
• web-platform-tests/css/css-scroll-snap/parsing/scroll-margin-shorthand-expected.txt: Ditto.
• web-platform-tests/css/css-scroll-snap/parsing/scroll-margin-valid-expected.txt: Ditto.
• web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

Source/WebCore:

Rename scroll-snap-margin to scroll-margin while leaving scroll-snap-margin still
available as an alias for backward compatibility reasons.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle): Rename CSS property name.

• css/CSSProperties.json: Rename CSS property and add an alias to the old name.
• css/StyleProperties.cpp: Changes to reflect new name.

(WebCore::StyleProperties::getPropertyValue const): Ditto.
(WebCore::StyleProperties::asText const): Ditto.

• css/parser/CSSPropertyParser.cpp: Ditto.

(WebCore::CSSPropertyParser::parseSingleValue): Ditto.
(WebCore::CSSPropertyParser::parseShorthand): Ditto.

• page/scrolling/AxisScrollSnapOffsets.cpp: Ditto.

(WebCore::updateSnapOffsetsForScrollableArea): Ditto.

• rendering/style/RenderStyle.cpp: Ditto.

(WebCore::RenderStyle::scrollMargin const): Ditto.
(WebCore::RenderStyle::scrollMarginTop const): Ditto.
(WebCore::RenderStyle::scrollMarginBottom const): Ditto.
(WebCore::RenderStyle::scrollMarginLeft const): Ditto.
(WebCore::RenderStyle::scrollMarginRight const): Ditto.
(WebCore::RenderStyle::setScrollMarginTop): Ditto.
(WebCore::RenderStyle::setScrollMarginBottom): Ditto.
(WebCore::RenderStyle::setScrollMarginLeft): Ditto.
(WebCore::RenderStyle::setScrollMarginRight): Ditto.
(WebCore::RenderStyle::scrollSnapMargin const): Deleted.
(WebCore::RenderStyle::scrollSnapMarginTop const): Deleted.
(WebCore::RenderStyle::scrollSnapMarginBottom const): Deleted.
(WebCore::RenderStyle::scrollSnapMarginLeft const): Deleted.
(WebCore::RenderStyle::scrollSnapMarginRight const): Deleted.
(WebCore::RenderStyle::setScrollSnapMarginTop): Deleted.
(WebCore::RenderStyle::setScrollSnapMarginBottom): Deleted.
(WebCore::RenderStyle::setScrollSnapMarginLeft): Deleted.
(WebCore::RenderStyle::setScrollSnapMarginRight): Deleted.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::initialScrollMargin): Added to reflect new name.
(WebCore::RenderStyle::initialScrollSnapMargin): Deleted.

• rendering/style/StyleScrollSnapPoints.cpp: Changes to reflect new name.

(WebCore::StyleScrollSnapArea::StyleScrollSnapArea): Ditto.

• rendering/style/StyleScrollSnapPoints.h: Ditto.

(WebCore::operator==): Ditto.

LayoutTests:

• platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Update results for this test.

1:29 PM Changeset in webkit [268888] by Russell Epstein

• 2 edits in branches/safari-610.2.11.51-branch/Source/WebKit

Cherry-pick r268377. rdar://problem/70320656

Unreviewed build fix after r268367.

• Configurations/WebKit.xcconfig: Corrected the definition of WK_PDFKIT_LDFLAGS_maccatalyst.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:29 PM Changeset in webkit [268887] by Russell Epstein

• 4 edits in branches/safari-610.2.11.51-branch/Source

Cherry-pick r268367. rdar://problem/70320656

[macCatalyst] Enable WKPDFView
​https://bugs.webkit.org/show_bug.cgi?id=217403
<rdar://problem/48217791>

Reviewed by Tim Horton.

Source/WebKit:

• Configurations/WebKit.xcconfig: Linked PDFKit.framework when building for the Catalyst variant on Big Sur or later.

Source/WTF:

• wtf/PlatformEnableCocoa.h: Enabled WKPDFView when building for the Catalyst variant on Big Sur or later.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:20 PM Changeset in webkit [268886] by Noam Rosenthal

• 24 edits
  37 adds in trunk

LayoutTests/imported/w3c:
Support EXIF image resolution in CoreGraphics (macOS/iOS)
​https://bugs.webkit.org/show_bug.cgi?id=217820

Reviewed by Darin Adler.

Imported density-size-correction tests

• resources/import-expectations.json:
• web-platform-tests/density-size-correction: Added.
• web-platform-tests/density-size-correction/density-corrected-image-in-canvas-expected.txt: Added.
• web-platform-tests/density-size-correction/density-corrected-image-in-canvas.html: Added.
• web-platform-tests/density-size-correction/density-corrected-image-svg-aspect-ratio-expected.html: Added.
• web-platform-tests/density-size-correction/density-corrected-image-svg-aspect-ratio.html: Added.
• web-platform-tests/density-size-correction/density-corrected-image-svg-expected.html: Added.
• web-platform-tests/density-size-correction/density-corrected-image-svg.html: Added.
• web-platform-tests/density-size-correction/density-corrected-natural-size-expected.txt: Added.
• web-platform-tests/density-size-correction/density-corrected-natural-size.html: Added.
• web-platform-tests/density-size-correction/density-corrected-size-bg-expected.html: Added.
• web-platform-tests/density-size-correction/density-corrected-size-bg.html: Added.
• web-platform-tests/density-size-correction/density-corrected-size-img-expected.html: Added.
• web-platform-tests/density-size-correction/density-corrected-size-img.html: Added.
• web-platform-tests/density-size-correction/density-corrected-size-pseudo-elements-expected.html: Added.
• web-platform-tests/density-size-correction/density-corrected-size-pseudo-elements.html: Added.
• web-platform-tests/density-size-correction/density-corrected-various-elements-expected.html: Added.
• web-platform-tests/density-size-correction/density-corrected-various-elements.html: Added.
• web-platform-tests/density-size-correction/resources: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-no-change.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-none.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-preapplied-hires.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-preapplied-lores.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-preapplied-non-uniform.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-valid-hires.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-valid-lores.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-valid-non-uniform.jpg: Added.
• web-platform-tests/density-size-correction/resources/exif-resolution-with-orientation.jpg: Added.
• web-platform-tests/density-size-correction/resources/exify.js: Added.

(createImageWithMetadata):

• web-platform-tests/density-size-correction/resources/w3c-import.log: Added.
• web-platform-tests/density-size-correction/third_party: Added.
• web-platform-tests/density-size-correction/third_party/piexif: Added.
• web-platform-tests/density-size-correction/third_party/piexif/LICENSE.txt: Added.
• web-platform-tests/density-size-correction/third_party/piexif/piexif.js: Added.

(that.remove):
(that.insert):
(that.load):
(that.dump):
(copy):
(_get_thumbnail):
(_pack_byte):
(_pack_short):
(_pack_long):
(_value_to_bytes):
(_dict_to_bytes):
(ExifReader):
(ExifReader.prototype.get_ifd):
(ExifReader.prototype.convert_value):
(typeof.btoa.string_appeared_here.btoa):
(typeof.atob.string_appeared_here.atob):
(getImageSize):
(pack):
(unpack):
(nStr):
(splitIntoSegments):
(getExifSeg):
(mergeSegments):
(toHex):
(that.GPSHelper.degToDmsRational):
(that.GPSHelper.dmsRationalToDeg):

• web-platform-tests/density-size-correction/third_party/piexif/w3c-import.log: Added.
• web-platform-tests/density-size-correction/w3c-import.log: Added.

Source/WebCore:
Support EXIF image resolution in CoreGraphics (macOS/iOS)
​https://bugs.webkit.org/show_bug.cgi?id=217820

Reviewed by Darin Adler.

Spec: ​https://github.com/whatwg/html/pull/5574

Read EXIF resolution/preferred size from image in decoder using CoreGraphics methods.
Separate between image size and sourceSize(), the latter should only be used for accessing the
actual pixels of the stored image.

Imported relevant w3c tests.

Tests: imported/w3c/web-platform-tests/density-size-correction/density-corrected-image-in-canvas.html

imported/w3c/web-platform-tests/density-size-correction/density-corrected-image-svg-aspect-ratio.html
imported/w3c/web-platform-tests/density-size-correction/density-corrected-image-svg.html
imported/w3c/web-platform-tests/density-size-correction/density-corrected-natural-size.html
imported/w3c/web-platform-tests/density-size-correction/density-corrected-size-bg.html
imported/w3c/web-platform-tests/density-size-correction/density-corrected-size-img.html
imported/w3c/web-platform-tests/density-size-correction/density-corrected-size-pseudo-elements.html
imported/w3c/web-platform-tests/density-size-correction/density-corrected-various-elements.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texImageSourceHelper):

Similar to orientation, draw into a buffer before uploading to WebGL also when the image
has a density corrected size.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::preTransformedNativeImageForCurrentFrame):

Apply density-correction when pre-transforming image for tile drawing.

(WebCore::BitmapImage::draw):

Correct the source-rect when drawing the image.

(WebCore::BitmapImage::nativeImageForCurrentFrameRespectingOrientation): Deleted.

Renamed to preTransformedNativeImageForCurrentFrame.

• platform/graphics/BitmapImage.h:
• platform/graphics/Image.h:

(WebCore::Image::sourceSize const):
(WebCore::Image::hasDensityCorrectedSize const):
(WebCore::Image::preTransformedNativeImageForCurrentFrame):
(WebCore::Image::nativeImageForCurrentFrameRespectingOrientation): Deleted.

Expose hasDensityCorrectedSize and sourceSize (for WebGL) and

• platform/graphics/ImageDecoder.h:

(WebCore::ImageDecoder::frameDensityCorrectedSizeAtIndex const):

• platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::setDensityCorrectedSize):
(WebCore::ImageFrame::densityCorrectedSize const):

• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::cacheMetadataAtIndex):
(WebCore::ImageSource::densityCorrectedSize):
(WebCore::ImageSource::size):
(WebCore::ImageSource::sourceSize):

• platform/graphics/ImageSource.h:

(WebCore::ImageSource::hasDensityCorrectedSize):

Expose existence of densityCorrectedSize in Image{Decoder|Source|Frame}.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawPattern):

Handle nativeImageForCurrentFrameRespectingOrientation rename.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceMetadataOptions):
(WebCore::densityCorrectedSizeFromProperties):
(WebCore::ImageDecoderCG::hotSpot const):
(WebCore::ImageDecoderCG::frameDensityCorrectedSizeAtIndex const):
(WebCore::ImageDecoderCG::createFrameImageAtIndex):

• platform/graphics/cg/ImageDecoderCG.h:
• platform/image-decoders/ScalableImageDecoder.h:

Decode image resolution from image metadata.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/ImageResolution.h:
• platform/graphics/ImageResolution.cpp:

Added.

LayoutTests:
Support EXIF image resolution in CoreGraphics (OSX/iOS)
​https://bugs.webkit.org/show_bug.cgi?id=217820

Reviewed by Darin Adler.

• TestExpectations:

For now, expect image failure in tests that require fuzzy matching.
The tests pass manually. There is an open bug for fuzzy matching.

• platform/gtk/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wpe/TestExpectations:

Disable this feature for platforms where it's not yet supported.

1:09 PM Changeset in webkit [268885] by Devin Rousso

• 7 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r266074): Sources: icon for non-JavaScript breakpoints doesn't change when breakpoints are globally disabled
​https://bugs.webkit.org/show_bug.cgi?id=218064

Reviewed by Joseph Pecoraro.

• UserInterface/Models/Breakpoint.js:

(WI.Breakpoint.prototype.get resolved): Added.

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.prototype.get resolved):
Add get resolved to the base class based on WI.debuggerManager.breakpointsEnabled. Use
it in the subclass as part of the result.

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.updateStatus):
(WI.BreakpointTreeElement.prototype._dataUpdated):

• UserInterface/Views/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image:not(.resolved)): Added.

• UserInterface/Views/JavaScriptBreakpointTreeElement.css:

(.item.breakpoint.javascript .status > .status-image): Deleted.
(.item.breakpoint.javascript .status > .status-image.resolved): Deleted.

• UserInterface/Views/JavaScriptBreakpointTreeElement.js:

(WI.JavaScriptBreakpointTreeElement.prototype.updateStatus): Deleted.
Eliminate unnecessary protected function now that all breakpoints have a get resolved.
Drive-by: inline CSS class name constants.

12:31 PM Changeset in webkit [268884] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Rebaseline fast/repaint/focus-ring-repaint.html after r268862

Unreviewed test gardening.

• platform/gtk/fast/repaint/focus-ring-repaint-expected.txt:

12:16 PM Changeset in webkit [268883] by rniwa@webkit.org

• 3 edits in trunk/Source/WebKit

IPC testing API should have the capability to observe messages being sent and received
​https://bugs.webkit.org/show_bug.cgi?id=217870

Unreviewed ASAN release build fix.

• Platform/IPC/JSIPCBinding.cpp:
• WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::JSMessageListener::JSMessageListener):

12:16 PM Changeset in webkit [268882] by Alan Coon

• 8 edits in branches/safari-610.2.11.51-branch/Source

Versioning.

WebKit-7610.2.11.51.5

12:12 PM Changeset in webkit [268881] by Lauro Moura

• 1 edit
  1 add in trunk/LayoutTests

[GTK] Add media/context-menu-actions baseline after r268865.

Unreviewed test gardening.

r268865 changed this test to use set isChangingPresentationMode, which
is not yet supported in GTK. Instead of skipping all test, update the
baseline to keep testing the other assertions.

• platform/gtk/media/context-menu-actions-expected.txt: Added.

11:51 AM Changeset in webkit [268880] by aakash_jain@apple.com

• 5 edits in trunk/Tools

[webkitpy] Rename slave to worker in perftestsrunner
​https://bugs.webkit.org/show_bug.cgi?id=218082

Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args): Supporting both --slave-config-json-path and --worker-config-json-path for now.
(_generate_results):
(_merge_worker_config_json):
(_merge_slave_config_json): Deleted.

• Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.test_parse_args):
(MainTest.test_parse_deprecated_args): Added unit-test for deprecated parameter.

• BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunAndUploadPerfTests):

11:47 AM Changeset in webkit [268879] by Jonathan Bedard

• 5 edits in trunk/Tools

Few webkitpy tests fail for machines in non-PST timezones
​https://bugs.webkit.org/show_bug.cgi?id=218079
<rdar://problem/70579517>

Reviewed by Aakash Jain.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
• Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
• Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit.test_info):

• Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestSvn.test_info):

11:36 AM Changeset in webkit [268878] by eric.carlson@apple.com

• 7 edits
  1 add in trunk

UIClient isn't notified when page muted state changes
​https://bugs.webkit.org/show_bug.cgi?id=218085
<rdar://problem/70462420>

Reviewed by Youenn Fablet.

Source/WebKit:

API test: WKWebView.MediaMuted

• UIProcess/API/C/WKPage.cpp:

(WKPageGetMediaState): reportedMediaCaptureState -> reportedMediaState.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mediaCaptureState]): Ditto.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateReportedMediaCaptureState): Only record current capture
state in m_reportedMediaCaptureState. m_delayStopCapturingReporting isn't necessary,
remove it.

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::reportedMediaState const): Renamed from reportedMediaCaptureState
to reflect what it returns.
(WebKit::WebPageProxy::mediaStateFlags const): Deleted.
(WebKit::WebPageProxy::reportedMediaCaptureState const): Deleted.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
• TestWebKitAPI/Tests/WebKitCocoa/MediaMutedState.mm: Added.

(-[AudioStateObserver initWithWebView:]):
(-[AudioStateObserver observeValueForKeyPath:ofObject:change:context:]):
(-[AudioStateTestView setMuted:]):
(TestWebKitAPI::TEST):

11:26 AM Changeset in webkit [268877] by Alan Coon

• 3 edits in branches/safari-611.1.4-branch/Source/WebCore

Revert r268483. rdar://problem/70578639

11:26 AM Changeset in webkit [268876] by Alan Coon

• 17 edits
  10 deletes in branches/safari-611.1.4-branch

Revert r268615. rdar://problem/70578639

11:26 AM Changeset in webkit [268875] by Alan Coon

• 7 edits in branches/safari-611.1.4-branch

Revert r268616. rdar://problem/70578639

11:26 AM Changeset in webkit [268874] by Alan Coon

• 7 edits in branches/safari-611.1.4-branch

Revert r268746. rdar://problem/70578639

11:26 AM Changeset in webkit [268873] by Alan Coon

• 4 edits
  2 deletes in branches/safari-611.1.4-branch

Revert r268771. rdar://problem/70578639

11:06 AM Changeset in webkit [268872] by youenn@apple.com

• 9 edits
  3 adds in trunk

Introduce worklet destinations and allow to fetch modules with CORS based on destination
​https://bugs.webkit.org/show_bug.cgi?id=218019
<rdar://problem/70526201>

Reviewed by Chris Dumez.

Source/WebCore:

Add support for audioworklet and paintworklet fetch destinations.
In case of those destinations, use cors mode instead of same-origin mode when fetching worklet top level module.

Test: http/wpt/webaudio/audioworklet-addModule-cors.sub.https.html

• Modules/fetch/FetchRequest.idl:
• loader/FetchOptions.h:

(WebCore::isScriptLikeDestination):

• workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadAsynchronously):

• worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::processNextScriptFetchJobIfNeeded):

Source/WebKit:

Add support to new fetch destinations in enumerations.

• NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy):

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::resourceLoadInfo):

LayoutTests:

• http/wpt/webaudio/audioworklet-addModule-cors.sub.https-expected.txt: Added.
• http/wpt/webaudio/audioworklet-addModule-cors.sub.https.html: Added.
• http/wpt/webaudio/resources/dummy-worklet.py: Added.

(main):
(DummyProcessor):

10:45 AM Changeset in webkit [268871] by rmorisset@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Use operand names when dumping Bytecode
​https://bugs.webkit.org/show_bug.cgi?id=218084

Reviewed by Saam Barati.

For example this would output the following:

[ 258] put_to_scope scope:loc7, var:3, value:loc8, getPutInfo:1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, symbolTableOrScopeDepth:0, offset:0

instead of

[ 258] put_to_scope loc7, 3, loc8, 1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, 0, 0

• bytecode/BytecodeDumper.h:

(JSC::BytecodeDumperBase::dumpOperand):

• generator/Opcode.rb:

10:31 AM Changeset in webkit [268870] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Detect unrecognized options in build-jsc
​https://bugs.webkit.org/show_bug.cgi?id=218077

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-10-22
Reviewed by Yusuke Suzuki.

Currently, Getopt::Long is configured with pass_through, in order to
be able to forward arbitrary arguments in buildMyProject. However, that
means that typos in option names (e.g. using --cmake-args instead of
--cmakeargs) go undetected and the option is silently ignored.

For cmake builds, there is no such forwarding, so check that there are
no remaining arguments in ARGV and refuse to continue if so. This runs
the risk of breaking wrapper scripts that incorrectly pass unrecognized
options, but that seems like a good thing.

• Scripts/build-jsc:

9:47 AM Changeset in webkit [268869] by don.olmstead@sony.com

• 3 edits
  14 copies
  5 adds in trunk/Source/WebCore

[WebGPU] Add Dawn implementation skeleton
​https://bugs.webkit.org/show_bug.cgi?id=217982

Reviewed by Myles C. Maxfield.

Add an empty implementation of the WebGPU types. This gets WebGPU built and linking
using Dawn.

• PlatformWinCairo.cmake:
• platform/Dawn.cmake: Added.
• platform/graphics/gpu/GPUPlatformTypes.h:
• platform/graphics/gpu/dawn/GPUBindGroupAllocatorDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUBindGroupAllocator::create):
(WebCore::GPUBindGroupAllocator::GPUBindGroupAllocator):
(WebCore::GPUBindGroupAllocator::reallocate):
(WebCore::GPUBindGroupAllocator::tryReset):

• platform/graphics/gpu/dawn/GPUBindGroupDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUBindGroup::tryCreate):
(WebCore::GPUBindGroup::GPUBindGroup):
(WebCore::GPUBindGroup::~GPUBindGroup):

• platform/graphics/gpu/dawn/GPUBindGroupLayoutDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUBindGroupLayout::tryCreate):

• platform/graphics/gpu/dawn/GPUBufferDawn.cpp: Added.

(WebCore::GPUBuffer::tryCreate):
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::~GPUBuffer):
(WebCore::GPUBuffer::isReadOnly const):
(WebCore::GPUBuffer::state const):
(WebCore::GPUBuffer::mapOnCreation):
(WebCore::GPUBuffer::registerMappingCallback):
(WebCore::GPUBuffer::runMappingCallback):
(WebCore::GPUBuffer::stagingBufferForRead):
(WebCore::GPUBuffer::stagingBufferForWrite):
(WebCore::GPUBuffer::copyStagingBufferToGPU):
(WebCore::GPUBuffer::unmap):
(WebCore::GPUBuffer::destroy):

• platform/graphics/gpu/dawn/GPUCommandBufferDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUCommandBuffer::tryCreate):
(WebCore::GPUCommandBuffer::GPUCommandBuffer):
(WebCore::GPUCommandBuffer::copyBufferToBuffer):
(WebCore::GPUCommandBuffer::copyBufferToTexture):
(WebCore::GPUCommandBuffer::copyTextureToBuffer):
(WebCore::GPUCommandBuffer::copyTextureToTexture):

• platform/graphics/gpu/dawn/GPUComputePassEncoderDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUComputePassEncoder::tryCreate):
(WebCore::GPUComputePassEncoder::GPUComputePassEncoder):
(WebCore::GPUComputePassEncoder::setPipeline):
(WebCore::GPUComputePassEncoder::dispatch):
(WebCore::GPUComputePassEncoder::platformPassEncoder const):

• platform/graphics/gpu/dawn/GPUComputePipelineDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUComputePipeline::tryCreate):
(WebCore::GPUComputePipeline::recompile):

• platform/graphics/gpu/dawn/GPUDeviceDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUDevice::tryCreate):
(WebCore::GPUDevice::GPUDevice):

• platform/graphics/gpu/dawn/GPUPlatformTypesDawn.h: Added.

(WebCore::HandleDeleter<PlatformBuffer>::operator()):
(WebCore::HandleDeleter<PlatformCommandBuffer>::operator()):
(WebCore::HandleDeleter<PlatformComputePassEncoder>::operator()):
(WebCore::HandleDeleter<PlatformComputePipeline>::operator()):
(WebCore::HandleDeleter<PlatformDevice>::operator()):
(WebCore::HandleDeleter<PlatformDrawable>::operator()):
(WebCore::HandleDeleter<PlatformProgrammablePassEncoder>::operator()):
(WebCore::HandleDeleter<PlatformQueue>::operator()):
(WebCore::HandleDeleter<PlatformRenderPassEncoder>::operator()):
(WebCore::HandleDeleter<PlatformRenderPipeline>::operator()):
(WebCore::HandleDeleter<PlatformSampler>::operator()):
(WebCore::HandleDeleter<PlatformShaderModule>::operator()):
(WebCore::HandleDeleter<PlatformSwapLayer>::operator()):
(WebCore::HandleDeleter<PlatformTexture>::operator()):

• platform/graphics/gpu/dawn/GPUProgrammablePassEncoderDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUProgrammablePassEncoder::endPass):
(WebCore::GPUProgrammablePassEncoder::setBindGroup):

• platform/graphics/gpu/dawn/GPUQueueDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUQueue::tryCreate):
(WebCore::GPUQueue::GPUQueue):
(WebCore::GPUQueue::submit):
(WebCore::GPUQueue::label const):
(WebCore::GPUQueue::setLabel const):

• platform/graphics/gpu/dawn/GPURenderPassEncoderDawn.cpp: Added.

(WebCore::GPURenderPassEncoder::tryCreate):
(WebCore::GPURenderPassEncoder::GPURenderPassEncoder):
(WebCore::GPURenderPassEncoder::platformPassEncoder const):
(WebCore::GPURenderPassEncoder::setPipeline):
(WebCore::GPURenderPassEncoder::setBlendColor):
(WebCore::GPURenderPassEncoder::setViewport):
(WebCore::GPURenderPassEncoder::setScissorRect):
(WebCore::GPURenderPassEncoder::setIndexBuffer):
(WebCore::GPURenderPassEncoder::setVertexBuffers):
(WebCore::GPURenderPassEncoder::draw):
(WebCore::GPURenderPassEncoder::drawIndexed):

• platform/graphics/gpu/dawn/GPURenderPipelineDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPURenderPipeline::tryCreate):
(WebCore::GPURenderPipeline::recompile):

• platform/graphics/gpu/dawn/GPUSamplerDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUSampler::tryCreate):
(WebCore::GPUSampler::GPUSampler):

• platform/graphics/gpu/dawn/GPUShaderModuleDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUShaderModule::tryCreate):
(WebCore::GPUShaderModule::GPUShaderModule):

• platform/graphics/gpu/dawn/GPUSwapChainDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUSwapChain::tryCreate):
(WebCore::GPUSwapChain::GPUSwapChain):
(WebCore::GPUSwapChain::tryGetCurrentTexture):
(WebCore::GPUSwapChain::present):
(WebCore::GPUSwapChain::reshape):
(WebCore::GPUSwapChain::platformLayer const):

• platform/graphics/gpu/dawn/GPUTextureDawn.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUPlatformTypes.h.

(WebCore::GPUTexture::tryCreate):
(WebCore::GPUTexture::create):
(WebCore::GPUTexture::GPUTexture):
(WebCore::GPUTexture::tryCreateDefaultTextureView):

9:23 AM Changeset in webkit [268868] by Chris Dumez

• 8 edits in trunk/Source/WebCore

Turn ScriptExecutionContext::vm() into a pure virtual function
​https://bugs.webkit.org/show_bug.cgi?id=218057

Reviewed by Geoffrey Garen.

Turn ScriptExecutionContext::vm() into a pure virtual function instead of using a
non-virtual function that does type-checking inside.

• dom/Document.cpp:

(WebCore::Document::vm):

• dom/Document.h:
• dom/EmptyScriptExecutionContext.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::vm): Deleted.

• dom/ScriptExecutionContext.h:
• workers/WorkerOrWorkletGlobalScope.cpp:

(WebCore::WorkerOrWorkletGlobalScope::vm):

• workers/WorkerOrWorkletGlobalScope.h:

9:01 AM Changeset in webkit [268867] by commit-queue@webkit.org

• 4 edits in trunk/Source

Elements in Shadow DOM are wrongly marked as stale by the WebDriver
​https://bugs.webkit.org/show_bug.cgi?id=217635

Patch by Nitzan Uziely <​linkgoron@gmail.com> on 2020-10-22
Reviewed by Brian Burg.

Source/WebDriver:

Changed stale checking, to check if the root node is the document element,
instead of document.contains which doesn't work for elements in Shadow DOM.

• Session.cpp:

(WebDriver::Session::elementSendKeys):

Source/WebKit:

Fixed the focus script to work for elements in Shadow DOM
instead of declaring them as not interactable.

• WebProcess/Automation/WebAutomationSessionProxy.js:

(let.AutomationSessionProxy.prototype._clearStaleNodes):
(let.AutomationSessionProxy):

8:55 AM Changeset in webkit [268866] by Aditya Keerthi

• 10 edits
  2 adds in trunk

[iOS] Prevent presentation of input peripherals when focusing form controls with a validation message
​https://bugs.webkit.org/show_bug.cgi?id=218004
<rdar://problem/70507678>

Reviewed by Wenson Hsieh.

Source/WebCore:

Added isFocusingWithValidationMessage() to HTMLFormControlElement so
that the state can be encoded in FocusedElementInformation and sent to
the UIProcess.

See WebKit Changelog for more information.

Test: fast/forms/ios/input-peripherals-with-validation-message.html

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isFocusingWithValidationMessage const):
(WebCore::HTMLFormControlElement::focusAndShowValidationMessage):

• html/HTMLFormControlElement.h:

Source/WebKit:

Interactive form validation can result in the presentation of a
validation message bubble near the first form control that has invalid
data. Prior to displaying the message, the invalid control is focused.
On iOS, this also has the effect of also presenting a virtual keyboard
or another custom input peripheral, such as a context menu for date
inputs.

Attempting to present both the validation message and custom input
peripheral can leave the view in an inconsistent state. For example,
<select> popovers have a strange flashing behavior when presented
alongside a validation message, and context menus can fail to present
entirely.

In order to address these issues, we should never attempt to present
both a validation message and an input peripheral. Instead, we can
prevent the presentation of input peripherals when the focused control
is presenting a validation message. This behavior matches macOS. Note
that we still present the keyboard for controls that have a keyboard
view, since the keyboard area does overlap the area where a validation
message is presented.

• Shared/FocusedElementInformation.cpp:

(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

• Shared/FocusedElementInformation.h:

Added isFocusingWithValidationMessage to the struct, so that the UIProcess
knows that the element gained focus due to the presentation of a
validation message.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):

Prevent an input view from being shown if the control does not present
a keyboard and was focused with a validation message.

(-[WKContentView _elementDidBlur]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getFocusedElementInformation):

LayoutTests:

Added a test which verifies that focusing on a date input as a result
of presenting a validation message, successfully presents the message,
and does not present a context menu. The test also ensures that controls
that present a keyboard, such as text inputs, present both the message
and the keyboard.

• fast/forms/ios/input-peripherals-with-validation-message-expected.txt: Added.
• fast/forms/ios/input-peripherals-with-validation-message.html: Added.
• resources/ui-helper.js:

(window.UIHelper.isShowingPopover):

8:22 AM Changeset in webkit [268865] by Peng Liu

• 33 edits in trunk

Let webkitDisplayingFullscreen() return true when a video element’s fullscreen mode is not VideoFullscreenModeNone
​https://bugs.webkit.org/show_bug.cgi?id=216426

Reviewed by Jer Noble.

Source/WebCore:

This patch moves m_changingVideoFullscreenMode of HTMLVideoElement to HTMLMediaElement.
The flag is used to protect interfaces regarding video presentation mode changes.
It also guards the code path when we use element fullscreen to implement video
fullscreen (VIDEO_USES_ELEMENT_FULLSCREEN). It is better to store the flag in
HTMLMediaElement to have fine control.

This patch reverts the changing regarding HTMLVideoElement::webkitDisplayingFullscreen
in r262456. This function will return true in the same run loop as a
webkitpresentationmodechanged event is fired when a video element is entering
fullscreen or picture-in-picture.

Also, this patch adds Internals::isChangingPresentationMode which can be used by
layout tests to check whether a video presentation mode change is completed.

Covered by existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isFullscreen const): Align the implementation
with isStandardFullscreen().
(WebCore::HTMLMediaElement::enterFullscreen): Set m_changingVideoFullscreenMode to true
if the video element is changing presentation mode. Also fix a bug about the
flag m_waitingToEnterFullscreen.
(WebCore::HTMLMediaElement::exitFullscreen): Ditto.
(WebCore::HTMLMediaElement::didBecomeFullscreenElement): Ditto.
(WebCore::HTMLMediaElement::didStopBeingFullscreenElement): Ditto.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::setChangingVideoFullscreenMode):
(WebCore::HTMLMediaElement::isChangingVideoFullscreenMode const):
(WebCore::HTMLMediaElement::waitingToEnterFullscreen): Deleted.

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Revert the change
in r262456. Some web sites expect this function to return true if the video element
is entering fullscreen and the event webkitpresentationmodechanged is fired.
(WebCore::HTMLVideoElement::setPresentationMode): Remove code regarding m_isChangingVideoFullscreenMode.
(WebCore::HTMLVideoElement::didEnterFullscreenOrPictureInPicture): Fix an event firing issue when
a video element is entering fullscreen while exiting picture-in-picture.
(WebCore::HTMLVideoElement::didExitFullscreenOrPictureInPicture): Fix an event firing issue when
a video element is exiting picture-in-picture.
(WebCore::HTMLVideoElement::isChangingPresentationMode const): This interface
is used by layout tests (through Internals) to check whether a video presentation
mode change is completed.
(WebCore::HTMLVideoElement::didBecomeFullscreenElement): Deleted.

• html/HTMLVideoElement.h:

• testing/Internals.cpp:

(WebCore::Internals::isChangingPresentationMode const): This interface is used
by layout tests to check whether a video presentation mode change is completed.

• testing/Internals.h:
• testing/Internals.idl:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:

(TEST):
Use internals.isChangingPresentationMode() to make sure a video presentation mode
change (from inline to picture-in-picture) is completed before moving to the next
step of the test.

LayoutTests:

Check Internals::isChangingPresentationMode instead of HTMLVideoElement::webkitDisplayingFullscreen
to confirm the video presentation mode change is completed before moving to the next step of a test.

• http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt:
• http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:
• media/context-menu-actions.html:
• media/media-fullscreen-loop-inline-expected.txt:
• media/media-fullscreen-loop-inline.html:
• media/media-fullscreen-pause-inline-expected.txt:
• media/media-fullscreen-pause-inline.html:
• media/media-fullscreen-return-to-inline-expected.txt:
• media/media-fullscreen-return-to-inline.html:
• media/presentationmodechanged-fired-once-expected.txt:
• media/presentationmodechanged-fired-once.html:
• media/video-fullscreen-only-playback-expected.txt:
• media/video-fullscreen-only-playback.html:
• media/video-playsinline-expected.txt:
• media/video-playsinline.html:
• media/video-presentation-mode-expected.txt:
• media/video-presentation-mode.html:
• media/video-webkit-playsinline-expected.txt:
• media/video-webkit-playsinline.html:
• platform/mac/TestExpectations:

7:43 AM Changeset in webkit [268864] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[LFC][IFC] Handle line box sizing quirks at the line box level
​https://bugs.webkit.org/show_bug.cgi?id=218060

Reviewed by Antti Koivisto.

In this patch the line box vertical sizing behavior (mostly quirk) is moved from the inline box to the line box level.

1. Inline boxes (root and other inline boxes (<span>)) are always sized to their initial height (see layout bounds) regardless of

whether they have content or not.

2. They are set to empty initially and we change them to non-empty as they gain (non-inline-level-box) content

(e.g. <div>root inline box gains content</div>).

3. Use this empty flag as input to the line box vertical sizing logic (only non-empty inline boxes contribute to the line box height).

Note that in standard mode the root inline box starts with an imaginary strut which makes it non-empty even when it has no content.
This is most visible with simple block containers like this:

<div style="border: 1px solid green"><img></div>

In quirks mode the border hugs the image (root inline box does not contribute to the height of the line box), while in standard mode
(assume 1. the image is taller than the default font with line spacing, 2. font has 4px descent),
there's a 4px gap between the border and the image.

4. While computing the final line rect (InlineFormattingContext::Geometry::computedLineLogicalRect), just rely on the line box height

computation (no need to check whether the line has content).

5. Treat <br> as visually non-empty run as it may contribute to the line box visually.
6. Add <br> quirk behavior so that it only contributes to the line box height when the line is empty.

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::alignInlineLevelBoxesVerticallyAndComputeLineBoxHeight):
(WebCore::Layout::InlineFormattingContext::Geometry::computedLineLogicalRect const):

• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::shouldInlineLevelBoxStretchLineBox const):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::isRunVisuallyNonEmpty const):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineLevelBox::verticalAlign const):

6:40 AM Changeset in webkit [268863] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Tools

[Flatpak SDK] Backport GStreamer device monitor patch
​https://bugs.webkit.org/show_bug.cgi?id=218021

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-10-22
Reviewed by Adrian Perez de Castro.

Backport of ​https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/679 to be shipped in 1.20.
This is needed to prevent false-positive critical warnings on the bots. See #217959.

• buildstream/elements/sdk/gstreamer.bst:
• buildstream/patches/gstreamer-0001-devicemonitor-Stop-only-the-already-started-provider.patch: Added.

6:22 AM Changeset in webkit [268862] by Antti Koivisto

• 4 edits in trunk

[LFC][Integration] Lines with outline should be marked having visual overflow
​https://bugs.webkit.org/show_bug.cgi?id=218071

Reviewed by Zalan Bujtas.

Source/WebCore:

Seen in fast/repaint/focus-ring-repaint.html

We may fail to paint newly added outlines correctly. This is a legacy line layout bug exposed by IFC integration.

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):

Mark when adding content to line.

LayoutTests:

• fast/repaint/focus-ring-repaint-expected.txt:

6:02 AM Changeset in webkit [268861] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GLIB][GTK] Unreviewed test gardening. Gardened some of the latest flaky failures.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

5:41 AM Changeset in webkit [268860] by cathiechen

• 12 edits
  1 copy
  2 adds in trunk

ResizeObserver is not properly garbage collected
​https://bugs.webkit.org/show_bug.cgi?id=215158

Reviewed by Frédéric Wang.

Source/WebCore:

If ResizeObservers are referenced inside ResizeObserverCallbacks, they are not garbage collected properly. To fix this,
add IsWeakCallback to ResizeObserverCallback interface so that it uses JSC::Weak to store the callback. And add the callback
to visitor in JSResizeObserver::visitAdditionalChildren() to keep it alive. In order to test ResizeObserver leak, add test interface
numberOfResizeObservers() to Internals.idl.

Test: resize-observer/resize-observer-callback-leak.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSResizeObserverCustom.cpp: Copied from Source/WebCore/page/ResizeObserverCallback.idl.

(WebCore::JSResizeObserver::visitAdditionalChildren): Add callback to SlotVisitor.

• dom/Document.h:

(WebCore::Document::numberOfResizeObservers const):

• page/ResizeObserver.h:

(WebCore::ResizeObserver::callback):

• page/ResizeObserver.idl: Add JSCustomMarkFunction to the interface.
• page/ResizeObserverCallback.h:
• page/ResizeObserverCallback.idl: Add IsWeakCallback to the interface.
• testing/Internals.cpp: Add numberOfResizeObservers.

(WebCore::Internals::numberOfResizeObservers const):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• resize-observer/resize-observer-callback-leak-expected.txt: Added.
• resize-observer/resize-observer-callback-leak.html: Added.

3:00 AM Changeset in webkit [268859] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Restrict ImageDecoder to WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=218023

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-10-22
Reviewed by Carlos Garcia Campos.

Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
should be the only process where GStreamer has been runtime initialized. This is a step
towards a GStreamer-free GTK/WPE UIProcess.

• platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::supportsContainerType):
(WebCore::ImageDecoderGStreamer::canDecodeType):

2:42 AM Changeset in webkit [268858] by Carlos Garcia Campos

• 6 edits in trunk

WebDriver: handle key events with non-ASCII unicode code point
​https://bugs.webkit.org/show_bug.cgi?id=217950

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

We are assuming that key events are limited to ASCII, but they contain a unicode code point.

Fixes: imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\xe0-]

imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u0416-]
imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u2603-]
imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\uf6c2-]

• UIProcess/Automation/SimulatedInputDispatcher.h: Use UChar32 instead of char for CharKey.
• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): Handle Charkey as a unicode code point.

• UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): Ditto.

WebDriverTests:

Remove expectations for tests that are now passing.

• TestExpectations.json:

2:38 AM WebKitGTK/2.30.x edited by Philippe Normand

(diff)

2:36 AM Changeset in webkit [268857] by Carlos Garcia Campos

• 24 edits
  1 add in trunk

Unreviewed. Update W3C WebDriver imported tests.

Tools:

Always connect to WebKitWebView::close even if the view is never made active.

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowSwitchTab):
(browser_window_append_view):

WebDriverTests:

• TestExpectations.json:
• imported/w3c/importer.json:
• imported/w3c/tools/webdriver/webdriver/client.py:
• imported/w3c/tools/wptrunner/wptrunner/browsers/android_weblayer.py:
• imported/w3c/tools/wptrunner/wptrunner/browsers/chrome.py:
• imported/w3c/tools/wptrunner/wptrunner/browsers/chrome_android.py:
• imported/w3c/tools/wptrunner/wptrunner/environment.py:
• imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
• imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
• imported/w3c/tools/wptrunner/wptrunner/executors/executorselenium.py:
• imported/w3c/tools/wptrunner/wptrunner/executors/executorservodriver.py:
• imported/w3c/tools/wptrunner/wptrunner/executors/executorwebdriver.py:
• imported/w3c/tools/wptrunner/wptrunner/executors/protocol.py:
• imported/w3c/tools/wptrunner/wptrunner/testdriver-extra.js:
• imported/w3c/tools/wptrunner/wptrunner/testharnessreport.js:¡
• imported/w3c/tools/wptrunner/wptrunner/webdriver_server.py:
• imported/w3c/tools/wptrunner/wptrunner/wptcommandline.py:
• imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
• imported/w3c/webdriver/tests/element_click/shadow_dom.py: Added.
• imported/w3c/webdriver/tests/perform_actions/support/refine.py:
• imported/w3c/webdriver/tests/print/printcmd.py:
• imported/w3c/webdriver/tests/print/user_prompts.py:

12:32 AM Changeset in webkit [268856] by commit-queue@webkit.org

• 21 edits in trunk

Scroll snap: don't create implicit snap points at scrollmin/scrollmax
​https://bugs.webkit.org/show_bug.cgi?id=216882
<rdar://problem/69443288>

Patch by Martin Robinson <​mrobinson@igalia.com> on 2020-10-22
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectations for these tests.

• web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt:
• web-platform-tests/css/css-scroll-snap/snap-after-relayout/adding-only-snap-area-expected.txt:
• web-platform-tests/css/css-scroll-snap/snap-after-relayout/changing-scroll-snap-align-expected.txt:
• web-platform-tests/css/css-scroll-snap/snap-after-relayout/snap-to-different-targets-expected.txt:
• web-platform-tests/css/css-scroll-snap/snap-area-capturing-remove-scroll-container-expected.txt:

Source/WebCore:

• page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::updateSnapOffsetsForScrollableArea): No longer call adjustmentForTextAutosizing and
only conditionally adjust the scroll area by the scroll offset, becauase mapping to container
coordinates only applies container scroll offsets in the case that the container is not a
ScrollView.
(WebCore::adjustAxisSnapOffsetsForScrollExtent): Deleted.

LayoutTests:

• TestExpectations: Mark some tests as passing.
• css3/scroll-snap/nested-elements-expected.txt: Update results to eliminate implicit stops.
• css3/scroll-snap/scroll-snap-children-with-padding-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-children-with-scroll-snap-margin-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-children-with-transforms-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-elements-container-larger-than-children-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-elements-container-larger-than-children-rtl-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-offsets-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-offsets-rtl-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-positions-expected.txt: Ditto.
• css3/scroll-snap/scroll-snap-with-scroll-padding-expected.txt: Ditto.