Timeline

Oct 26, 2020:

11:39 PM Changeset in webkit [269023] by Devin Rousso

• 37 edits in trunk

Web Inspector: console command line API should be exposed to breakpoint conditions/actions
​https://bugs.webkit.org/show_bug.cgi?id=218141
<rdar://problem/70636727>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• debugger/Debugger.h:

(JSC::Debugger::Client::scopeExtensionObject): Added.

• debugger/Debugger.cpp:

(JSC::Debugger::setClient): Added.
(JSC::Debugger::evaluateBreakpointCondition):
(JSC::Debugger::evaluateBreakpointActions):
Introduce an optional Debugger::Client virtual class that can be used to adjust behavior
in various situations. Right now it is used when evaluating breakpoint conditions/actions
to get a scope extension object.

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::internalEnable):
(Inspector::InspectorDebuggerAgent::internalDisable):
(Inspector::InspectorDebuggerAgent::scopeExtensionObject): Added.
Implement Debugger::Client and provide a newly created CommandLineAPI instance.

• inspector/InjectedScript.h:
• inspector/InjectedScript.cpp:

(Inspector::InjectedScript::createCommandLineAPIObject const): Added.

• inspector/InjectedScriptSource.js:

(let.InjectedScript.prototype.createCommandLineAPIObject): Added.
(let.InjectedScript.prototype._evaluateOn):
Expose a way for the C++ to create CommandLineAPI instances.

Source/WebInspectorUI:

• UserInterface/Controllers/CodeMirrorCompletionController.js:

(WI.CodeMirrorCompletionController):
(WI.CodeMirrorCompletionController.prototype.get mode): Added.
(WI.CodeMirrorCompletionController.prototype.get delegate): Deleted.

• UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.shouldExposeEvent): Added.
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.shouldExposeException): Added.
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames):
Introduce a Mode enum that can be fetched by completion providers to adjust functionality.

• UserInterface/Views/BreakpointPopover.js:

(WI.BreakpointPopover.appendContextMenuItems):
(WI.BreakpointPopover.prototype.show):
(WI.BreakpointPopover.prototype.breakpointActionViewCodeMirrorCompletionControllerMode): Added.
(WI.BreakpointPopover.prototype.get codeMirrorCompletionControllerMode): Added.

• UserInterface/Views/EventBreakpointPopover.js:

(WI.EventBreakpointPopover.prototype.get codeMirrorCompletionControllerMode): Added.

• UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView.prototype._updateBody):
Use a Mode that always exposes $event/$exception depending on the breakpoint type.

• UserInterface/Views/ConsolePrompt.js:

(WI.ConsolePrompt):
Use a Mode that only exposes $event/$exception when paused for an event/exeption.

• UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked):
Use a Mode that always exposes $event/$exception since watch expressions track values
over time, and may therefore not always have an $event/$exception set.

• UserInterface/Views/TextEditor.js:

(WI.TextEditor):
Use the default Mode that never exposes $event/$exception.

LayoutTests:

• inspector/debugger/resources/breakpoint-options-utilities.js:
• inspector/debugger/break-on-exception-expected.txt:
• inspector/debugger/break-on-uncaught-exception-expected.txt:
• inspector/debugger/setPauseOnAssertions-expected.txt:
• inspector/debugger/setPauseOnDebuggerStatements-expected.txt:
• inspector/debugger/setPauseOnMicrotasks-expected.txt:
• inspector/dom-debugger/attribute-modified-style-expected.txt:
• inspector/dom-debugger/dom-breakpoint-attribute-modified-expected.txt:
• inspector/dom-debugger/dom-breakpoint-node-removed-ancestor-expected.txt:
• inspector/dom-debugger/dom-breakpoint-node-removed-direct-expected.txt:
• inspector/dom-debugger/dom-breakpoint-subtree-modified-add-expected.txt:
• inspector/dom-debugger/dom-breakpoint-subtree-modified-remove-expected.txt:
• inspector/dom-debugger/event-animation-frame-breakpoints-expected.txt:
• inspector/dom-debugger/event-interval-breakpoints-expected.txt:
• inspector/dom-debugger/event-listener-breakpoints-expected.txt:
• inspector/dom-debugger/event-timeout-breakpoints-expected.txt:
• inspector/dom-debugger/url-breakpoints-all-requests-expected.txt:
• inspector/dom-debugger/url-breakpoints-containing-expected.txt:
• inspector/dom-debugger/url-breakpoints-matching-expected.txt:

9:39 PM Changeset in webkit [269022] by commit-queue@webkit.org

• 28 edits
  2 copies
  1 move
  2 deletes in trunk/Source

[GPU Process]: Introduce RemoteResourceCacheProxy to manage the remote resources in Web Process
​https://bugs.webkit.org/show_bug.cgi?id=217558

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-10-26
Reviewed by Simon Fraser.

Source/WebCore:

Rename Recorder::Observer to Recorder::Delegate because it will be responsible
for creating DisplayListItems in future patches. So it will not be just
an observer. Also do not make DisplayList::ImageBuffer a superclass of it.
RemoteImageBufferProxy, which is a superclass of DisplayList::ImageBuffer,
will be the superclass of Recorder::Delegate.

Make ImageBufferBackend::isAccelerated a static member instead of a virtual
method. RemoteRenderingBackendProxy would want to know whether the backend
of an ImageBuffer isAccelerated or not without having to create it.
ImageBufferBackend::isAccelerated will be set to false and
ImageBufferIOSurfaceBackend::isAccelerated will be set to true.

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/ConcreteImageBuffer.h:
• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::renderingResourceIdentifier const):

• platform/graphics/ImageBufferBackend.h:

(WebCore::ImageBufferBackend::isAccelerated const): Deleted.

• platform/graphics/RenderingResourceIdentifier.h: Renamed from Source/WebCore/platform/graphics/RemoteResourceIdentifier.h.
• platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::isAccelerated const): Deleted.

• platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
• platform/graphics/displaylists/DisplayListDrawingContext.cpp:

(WebCore::DisplayList::DrawingContext::DrawingContext):

• platform/graphics/displaylists/DisplayListDrawingContext.h:

(WebCore::DisplayList::DrawingContext::DrawingContext):

• platform/graphics/displaylists/DisplayListImageBuffer.h:

(WebCore::DisplayList::ImageBuffer::ImageBuffer):

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):
(WebCore::DisplayList::Recorder::willAppendItem):

• platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::~Delegate):
(WebCore::DisplayList::Recorder::Observer::~Observer): Deleted.
(WebCore::DisplayList::Recorder::Observer::willAppendItem): Deleted.

Source/WebKit:

Remove RemoteImageBufferMessageHandlerProxy and move sending the messages
to RemoteRenderingBackendProxy.

To allow casting ImageBuffer to RemoteImageBufferProxy, a new method named
remoteResourceIdentifier() is added to IamgeBuffer and it is only overridden
by RemoteImageBufferProxy. This method is used in SPECIALIZE_TYPE_TRAITS
macros along with IamgeBuffer::isAccelerated().

Introduce RemoteResourceCacheProxy which will manage caching and releasing
the RemoteImageBufferProxy. Caching NativeImage will be added to it in
future patches. More about controlling the life cycles of remote resources
will be added also when supporting drawing remote resources to remote client
in future patches.

• GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::create):
(WebKit::RemoteImageBuffer::RemoteImageBuffer):

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::imageBufferBackendWasCreated):
(WebKit::RemoteRenderingBackend::flushDisplayListWasCommitted):
(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::flushDisplayList):
(WebKit::RemoteRenderingBackend::flushDisplayListAndCommit):
(WebKit::RemoteRenderingBackend::getImageData):
(WebKit::RemoteRenderingBackend::releaseRemoteResource):

• GPUProcess/graphics/RemoteRenderingBackend.h:
• GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::cacheImageBuffer):
(WebKit::RemoteResourceCache::cachedImageBuffer):
(WebKit::RemoteResourceCache::releaseRemoteResource):

• GPUProcess/graphics/RemoteResourceCache.h:
• Scripts/webkit/messages.py:
• Sources.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/graphics/PlatformRemoteImageBufferProxy.h:

(isType):

• WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp: Removed.
• WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.h: Removed.
• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::create):
(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):
(WebKit::RemoteImageBufferProxy::createBackend):
(WebKit::RemoteImageBufferProxy::commitFlushDisplayList):
(WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):
(WebKit::RemoteImageBufferProxy::isPendingFlush const):
(WebKit::RemoteImageBufferProxy::timeoutWaitForFlushDisplayListWasCommitted):
(WebKit::RemoteImageBufferProxy::flushDrawingContextAndCommit):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getImageData):
(WebKit::RemoteRenderingBackendProxy::flushDisplayList):
(WebKit::RemoteRenderingBackendProxy::flushDisplayListAndCommit):
(WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):
(WebKit::RemoteRenderingBackendProxy::imageBufferBackendWasCreated):
(WebKit::RemoteRenderingBackendProxy::flushDisplayListWasCommitted):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

(WebKit::RemoteRenderingBackendProxy::remoteResourceCacheProxy):
(WebKit::RemoteRenderingBackendProxy::renderingBackendIdentifier const): Deleted.

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:
• WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: Copied from Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp.

(WebKit::RemoteResourceCacheProxy::RemoteResourceCacheProxy):
(WebKit::RemoteResourceCacheProxy::cacheImageBuffer):
(WebKit::RemoteResourceCacheProxy::cachedImageBuffer):
(WebKit::RemoteResourceCacheProxy::releaseImageBuffer):

• WebProcess/GPU/graphics/RemoteResourceCacheProxy.h: Copied from Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h.

9:39 PM Changeset in webkit [269021] by clopez@igalia.com

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening of layout test failures.

Unreviewed gardening.

• platform/glib/TestExpectations:
• platform/wpe/TestExpectations:

7:13 PM Changeset in webkit [269020] by Tadeu Zagallo

• 5 edits in trunk/Source

Sign MacroAssembler::jumpsToLink
​https://bugs.webkit.org/show_bug.cgi?id=217774
<rdar://problem/69433058>

Reviewed by Saam Barati.

Source/JavaScriptCore:

• assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::LinkRecord::LinkRecord):
(JSC::ARM64Assembler::LinkRecord::setFrom):
(JSC::ARM64Assembler::LinkRecord::to const):
(JSC::ARM64Assembler::linkJump):

• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

Source/WTF:

• wtf/PtrTag.h:

(WTF::untagInt):
(WTF::tagInt):

7:07 PM Changeset in webkit [269019] by Tadeu Zagallo

• 2 edits in trunk/Source/WTF

Add extra validation to MetaAllocator::findAndRemoveFreeSpace
​https://bugs.webkit.org/show_bug.cgi?id=217792
<rdar://problem/69433015>

Reviewed Saam Barati.

• wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::findAndRemoveFreeSpace):

7:05 PM Changeset in webkit [269018] by timothy_horton@apple.com

• 2 edits in trunk/LayoutTests

fast/events/touch/ios/show-modal-alert-during-touch-start.html logs about unexpected argument
​https://bugs.webkit.org/show_bug.cgi?id=218214

Reviewed by Darin Adler.

• fast/events/touch/ios/show-modal-alert-during-touch-start.html:

webkit-test-runner options are not comma separated (and "true," is not a valid value, thus the logging).

7:04 PM Changeset in webkit [269017] by Tadeu Zagallo

• 2 edits in trunk/Source/WTF

Assert that WTF::HashTable does not visit the same bucket twice
​https://bugs.webkit.org/show_bug.cgi?id=217691
<rdar://problem/69887843>

Reviewed by Saam Barati.

• wtf/HashTable.h:

(WTF::KeyTraits>::inlineLookup):
(WTF::KeyTraits>::lookupForWriting):
(WTF::KeyTraits>::fullLookupForWriting):
(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::add):

6:56 PM Changeset in webkit [269016] by Tadeu Zagallo

• 2 edits in trunk/Source/JavaScriptCore

Validate addresses returned by LinkBuffer::locationOf
​https://bugs.webkit.org/show_bug.cgi?id=217786
<rdar://problem/69887913>

Reviewed by Saam Barati.

• assembler/LinkBuffer.h:

(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::getLinkerAddress):

6:13 PM Changeset in webkit [269015] by Alan Coon

• 3 edits in branches/safari-611.1.4-branch

Cherry-pick r268382. rdar://problem/70702384

REGRESSION (r268294): [ iOS wk2 ] imported/blink/fast/css/zoomed-intrinsic-width.html is a constant image failure
​https://bugs.webkit.org/show_bug.cgi?id=217610
<rdar://problem/70207977>

Reviewed by Antti Koivisto.

Source/WebCore:

InlineTree snaps line boxes to integral values.

• layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::constructContent):

LayoutTests:

• platform/ios-simulator-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [269014] by Alan Coon

• 17 edits
  2 adds in branches/safari-611.1.4-branch

Cherry-pick r268940. rdar://problem/70702182

Source/WebCore:
REGRESSION(r266295): DOMSelection's addRange and containsNode behave incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

Test: editing/selection/selections-across-trees.html

• accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::linkClickPoint): Update for the new name of isPointInRange, contains<ComposedTree>. We can return and change it from ComposedTree to something else since that's likely not the tree we need here. (WebCore::AccessibilityRenderObject::setSelectedTextRange): Ditto. (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const): Ditto.
• accessibility/atk/WebKitAccessibleInterfaceText.cpp: (isWhiteSpaceBetweenSentences): Ditto.

• dom/BoundaryPoint.h: Update to use TreeType enumeration instead of classes.
• dom/Node.cpp: (WebCore::depth): Ditto. (WebCore::commonInclusiveAncestorAndChildren): Ditto. (WebCore::treeOrder): Ditto.
• dom/Node.h: Ditto.

• dom/Range.cpp: (WebCore::Range::isPointInRange): Updated since we renamed isPointInRange to be an overload of contains.

• dom/SimpleRange.cpp: (WebCore::treeOrder): Update to use TreeType enumeration instead of classes. (WebCore::contains): Ditto. Also renamed isPointInRange to an overload of contains. Also added converted the contains that takes two ranges to a function template. (WebCore::intersects): Ditto.

• dom/SimpleRange.h: Reorganized the functions so all the deprecated functions that silently use ComposedTree are grouped together. Updated the function templates to use TreeType enumeration instead of classes. Added a couple more function templates that we used to fix DOMSelection.

• editing/FrameSelection.cpp: (WebCore::FrameSelection::contains const): Update for the new name of sPointInRange, contains<ComposedTree>. We can return and change it from ComposedTree to something else since that's likely not the tree we need here.
• editing/mac/DictionaryLookupLegacy.mm: (WebCore::selectionContainsPosition): Ditto.

• page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Use intersects<Tree> because we don't want to use the composed tree here. (WebCore::DOMSelection::containsNode const): Use intersects<Tree> and contains<Tree>. Evantually <Tree> will be the default and we can come back here and edit down these calls for brevity, but first we have to make all the uses of ComposedTree explicit.

Source/WebKitLegacy/win:
REGRESSION(r266295): DOMSelection's addRange and containsNode behave incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

• AccessibleTextImpl.cpp: (AccessibleText::isInRange): Updated since we renamed isPointInRange to be an overload of contains.

Tools:
REGRESSION(r266295): DOMSelection's addRange and containsNode behave incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

• TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Disabled the isPointInRange test and added comments about how we will restore it in the future.

LayoutTests:
REGRESSION(r266295): DOMSelection's addRange and containsNode behaves incorrectly when selection crosses shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=218007

Reviewed by Ryosuke Niwa.

• editing/selection/selections-across-trees-expected.txt: Added.
• editing/selection/selections-across-trees.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [269013] by Alan Coon

• 18 edits in branches/safari-611.1.4-branch

Cherry-pick r268932. rdar://problem/70702224

REGRESSION(r268615): certain animations break when moving from one to display to another or resizing the window
​https://bugs.webkit.org/show_bug.cgi?id=218080
<rdar://problem/70547132>

Reviewed by Dean Jackson.

Source/WebCore:

Since transform-related animations include non-interpolating animations meant to insert the static base value for a given
transform-related CSS property, we need to update animations on GraphicsLayerCA whenever one of the transform-related CSS
properties have a new value.

We used to rely on GraphicsLayerCA::setTransform() being called with a different transform than the current one to identify
such cases, but that is suboptimal because that method can be called with a compound interpolated value of transform-related
CSS properties when a rendering update occurs, such as during resizing or moving a window between displays. In those cases,
the static base value of the transform-related CSS properties hasn't actually changed.

Instead, we now provide the non-animated style from the last style change event to the function resolving keyframe effects
so that for a given element we can compare that style with the new, as-yet-non-animated style and see if any of the transform-
related CSS properties have been changed. If that is the case, we inform any KeyframeEffect that has a running accelerated
animation for any of those CSS properties so that the effect may enqueue an accelerated action that will then notify the
GraphicsLayer of such a change, and trigger an animation update.

Since we were changing the applyKeyframeEffects() method signature to add the extra RenderStyle needed to compare the current
and previous non-animated styles, we also moved that method from Element to KeyframeEffectStack since no Element private
API was required.

No new test since this was already tested by webanimations/accelerated-translate-animation-underlying-transform-changed-in-flight.html
and it's not clear how to test the live-resizing or display-change scenario.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::isRunningAcceleratedTransformRelatedAnimation const): New method called from KeyframeEffectStack::applyKeyframeEffects() to indicate that a keyframe effect has a running accelerated animation targeting a transform-related property. (WebCore::KeyframeEffect::addPendingAcceleratedAction): Ensure that the new AcceleratedAction::TransformChange accelerated action recorded in transformRelatedPropertyDidChange() is not ever set as m_lastRecordedAcceleratedAction as we use this member to identify whether we have a pending running, pause or stop action. (WebCore::KeyframeEffect::transformRelatedPropertyDidChange): New method meant to be called for an effect that has a running accelerated animation targeting a transform-related property to notify that one or more of the target element's transform-related CSS property static values was changed. (WebCore::KeyframeEffect::applyPendingAcceleratedActions): Call transformRelatedPropertyDidChange() on the composited renderer for a AcceleratedAction::TransformChange action.
• animation/KeyframeEffect.h:
• animation/KeyframeEffectStack.cpp: (WebCore::KeyframeEffectStack::applyKeyframeEffects): Move the method previously exposed on Element to KeyframeEffectStack. Additionally, accept an extra RenderStyle parameter to provide the non-animated style from the last style change event so that we can compare that style with the new, as-yet-non-animated style and see if any of the transform-related CSS properties have been changed and notify the effect should it run an accelerated animation for one of those properties.
• animation/KeyframeEffectStack.h:
• dom/Element.cpp: (WebCore::Element::applyKeyframeEffects): Deleted. Moved to KeyframeEffectStack.
• dom/Element.h:
• platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::transformRelatedPropertyDidChange):
• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setTransform): Move the animation-update logic to transformRelatedPropertyDidChange() (WebCore::GraphicsLayerCA::transformRelatedPropertyDidChange):
• platform/graphics/ca/GraphicsLayerCA.h:
• rendering/RenderElement.h: (WebCore::RenderElement::transformRelatedPropertyDidChange):
• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::transformRelatedPropertyDidChange):
• rendering/RenderLayerBacking.h:
• rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::transformRelatedPropertyDidChange):
• rendering/RenderLayerModelObject.h:
• style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): Pass the non-animated style from the last style change event to KeyframeEffectStack::applyKeyframeEffects() to determine whether this style change event includes a change to any of the transform-related properties.
• style/Styleable.h: (WebCore::Styleable::applyKeyframeEffects const):

LayoutTests:

Increase the fidelity of this test where the scale transform would sometimes yield some 0.01% ImageOnlyFailure results.

• webanimations/accelerated-translate-animation-additional-animation-added-in-flight-expected.html:
• webanimations/accelerated-translate-animation-additional-animation-added-in-flight.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [269012] by Alan Coon

• 7 edits in branches/safari-611.1.4-branch/Source/WebInspectorUI

Cherry-pick r268885. rdar://problem/70702192

Web Inspector: REGRESSION(r266074): Sources: icon for non-JavaScript breakpoints doesn't change when breakpoints are globally disabled
​https://bugs.webkit.org/show_bug.cgi?id=218064

Reviewed by Joseph Pecoraro.

• UserInterface/Models/Breakpoint.js: (WI.Breakpoint.prototype.get resolved): Added.
• UserInterface/Models/JavaScriptBreakpoint.js: (WI.JavaScriptBreakpoint.prototype.get resolved): Add get resolved to the base class based on WI.debuggerManager.breakpointsEnabled. Use it in the subclass as part of the result.

• UserInterface/Views/BreakpointTreeElement.js: (WI.BreakpointTreeElement.prototype.updateStatus): (WI.BreakpointTreeElement.prototype._dataUpdated):
• UserInterface/Views/BreakpointTreeElement.css: (.item.breakpoint .status > .status-image:not(.resolved)): Added.
• UserInterface/Views/JavaScriptBreakpointTreeElement.css: (.item.breakpoint.javascript .status > .status-image): Deleted. (.item.breakpoint.javascript .status > .status-image.resolved): Deleted.
• UserInterface/Views/JavaScriptBreakpointTreeElement.js: (WI.JavaScriptBreakpointTreeElement.prototype.updateStatus): Deleted. Eliminate unnecessary protected function now that all breakpoints have a get resolved. Drive-by: inline CSS class name constants.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [269011] by Alan Coon

• 2 edits in branches/safari-611.1.4-branch/Source/WebCore

Cherry-pick r268816. rdar://problem/70702274

A video element may fail to enter picture-in-picture from fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=217999

Reviewed by Eric Carlson.

When a video element is entering picture-in-picture from fullscreen,
WebKit should only fire the webkitendfullscreenEvent event, but should not
request the player in the UI process to exit fullscreen(picture-in-picture).
So the condition to decide sending the exit fullscreen request is wrong because
HTMLMediaElement::didBecomeFullscreenElement(), which sets m_waitingToEnterFullscreen
to false, might be called before dispatching the webkitendfullscreenEvent event.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEvent): Fix the condition. (WebCore::HTMLMediaElement::exitFullscreen): Set fullscreen mode to VideoFullscreenModeNone.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [269010] by Alan Coon

• 8 edits
  2 adds in branches/safari-611.1.4-branch

Cherry-pick r268800. rdar://problem/70702272

REGRESSION(r266295): Range allows start and end containers to belong to different trees
​https://bugs.webkit.org/show_bug.cgi?id=217895

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/Range/ranges-across-trees.html

• dom/BoundaryPoint.h: Added treeOrder<TreeType>.

• dom/Node.cpp: (WebCore::parent<Tree>): Added. (WebCore::parent<ComposedTree>): Added. (WebCore::depth): Changed into a template that takes TreeType. (WebCore::commonInclusiveAncestorAndChildren): Ditto. (WebCore::commonInclusiveAncestor): Changed to explicitly use ComposedTree to preserve the current behavior, but likely will return later to make this a template and have it us the normal tree by default. (WebCore::treeOrder): Changed into a template that takes TreeType. (WebCore::documentOrder): Call treeOrder<ComposedTree> to preserve the current behavior. Likely will delete this later after changing callers to use treeOrder.

• dom/Node.h: Added Tree, ShadowIncludingTree, and ComposedTree. Added parent and treeOrder function templates. TreeType currently is a set of classes but they could also be objects of another type. Maybe an enumeration named TreeType instead?

• dom/Range.cpp: (WebCore::Range::setStart): Use treeOrder instead of documentOrder to use the normal tree instead of the composed tree. (WebCore::Range::setEnd): Ditto. (WebCore::Range::isPointInRange): Use isPointInRange<Tree> instead of isPointInRange to use the normal tree instead of the composed tree. (WebCore::Range::comparePoint const): Use treeOrder instead of documentOrder to use the normal tree instead of the composed tree. (WebCore::Range::compareNode const): Ditto. (WebCore::Range::compareBoundaryPoints const): Ditto. (WebCore::Range::intersectsNode const): Use intersects<Tree> instead of isPointInRange to use the normal tree instead of the composed tree.

• dom/SimpleRange.cpp: (WebCore::treeOrder): Changed into a template that takes TreeType. (WebCore::documentOrder): Call treeOrder<ComposedTree> to preserve the current behavior. Likely will delete this later after changing callers to use treeOrder. (WebCore::isPointInRange): Changed into a template that takes TreeType. For now the default tree type is still ComposedTree, but will change that later. (WebCore::intersects): Ditto. (WebCore::contains<Tree>): Added. (WebCore::contains<ComposedTree>): Added.

• dom/SimpleRange.h: Added isPointInRange, intersects, and treeOrder function templates.

LayoutTests:

• fast/dom/Range/ranges-across-trees.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [269009] by Alan Coon

• 5 edits in branches/safari-611.1.4-branch

Cherry-pick r268796. rdar://problem/70702309

Don't crash when deallocating WKWebView during TLS handshake
​https://bugs.webkit.org/show_bug.cgi?id=218025
<rdar://problem/70225969>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-10-21
Reviewed by Tim Horton.

Source/WebKit:

NetworkProcessProxy::didReceiveAuthenticationChallenge would sometimes dereference an unchecked
Optional<SecurityOriginData> which would result in a null dereference crash. Also, sometimes
Connection::initializeSendSource would assert because it was trying to set up a cancel handler for
a send port that had not been successfully set up yet. I added a test that reproduces both of these
issues most of the time.

• Platform/IPC/cocoa/ConnectionCocoa.mm: (IPC::Connection::initializeSendSource):
• UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [269008] by Alan Coon

• 2 edits in branches/safari-611.1.4-branch/Source/WebInspectorUI

Cherry-pick r268786. rdar://problem/70702339

Web Inspector: REGRESSION(r266074): Uncaught Exception: undefined is not an object (evaluating 'this._allListenersBreakpoint.disabled')
​https://bugs.webkit.org/show_bug.cgi?id=217992

Reviewed by Joseph Pecoraro.

r266074 changed it such that _allListenersBreakpoint doesn't always exist, so check that
it exists before getting a property from it.

• UserInterface/Controllers/DOMDebuggerManager.js: (WI.DOMDebuggerManager.prototype.listenerBreakpointForEventName):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:12 PM Changeset in webkit [269007] by Alan Coon

• 2 edits in branches/safari-611.1.4-branch/Source/WebCore

Cherry-pick r268730. rdar://problem/70702315

Web Inspector: REGRESSION(r260076): crash under InspectorInstrumentation::willApplyKeyframeEffect
​https://bugs.webkit.org/show_bug.cgi?id=217936

Reviewed by Brian Burg.

Speculative fix by null-checking targetElementOrPseudoElement() before using it. Before
r260076 this was not necessary as m_target is null-checked earlier in the function, but
after it can now return nullptr depending on the value of m_pseudoId.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::apply):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:12 PM Changeset in webkit [269006] by Alan Coon

• 2 edits in branches/safari-611.1.4-branch/Source/WebCore

Cherry-pick r268701. rdar://problem/70702378

Fix possible crash in GraphicsLayerCA::computeVisibleAndCoverageRect()
​https://bugs.webkit.org/show_bug.cgi?id=217930
<rdar://problem/70316943>

Reviewed by Tim Horton.

If we made a m_overflowControlsHostLayerAncestorClippingStack, make sure we unparent
its layers when tearing down the RenderLayerBacking, and when we determine that we
longer need a m_ancestorClippingStack (having a m_overflowControlsHostLayerAncestorClippingStack
implies that we have a m_ancestorClippingStack).

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::destroyGraphicsLayers): (WebCore::RenderLayerBacking::updateAncestorClipping):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:12 PM Changeset in webkit [269005] by Alan Coon

• 9 edits
  2 deletes in branches/safari-611.1.4-branch

Cherry-pick r268695. rdar://problem/70702399

Unreviewed, reverting r267175 and r267779.
​https://bugs.webkit.org/show_bug.cgi?id=217923

Regressed NYTimes's DOM content loaded time by 400%

Reverted changesets:

"MutationObserverRegistration should be ref counted"
​https://bugs.webkit.org/show_bug.cgi?id=216528
​https://trac.webkit.org/changeset/267175

"Crash while loading a confluence page"
​https://bugs.webkit.org/show_bug.cgi?id=217111
​https://trac.webkit.org/changeset/267779

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:50 PM Changeset in webkit [269004] by Alan Coon

• 8 edits in branches/safari-611.1.4-branch/Source

Versioning.

WebKit-7611.1.4.1

5:30 PM Changeset in webkit [269003] by Peng Liu

• 3 edits in trunk/LayoutTests

REGRESSION (r268865): [macOS WK2] media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=218208

Reviewed by Darin Adler.

Fix the flakiness by holding a video presentation mode change until the ongoing
mode change is completed.

• media/modern-media-controls/placard-support/placard-support-pip-expected.txt:
• media/modern-media-controls/placard-support/placard-support-pip.html:

4:55 PM Changeset in webkit [269002] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add Federico Bucchi to list of WebKit contributors
​https://bugs.webkit.org/show_bug.cgi?id=218136

• Added Federico Bucchi
• Removed "slackId" : "UTWC5TTSP", because it was causing:

ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json differs from the canonical format.

Patch by Federico Bucchi <Federico Bucchi> on 2020-10-26
Reviewed by Brian Burg.

• Scripts/webkitpy/common/config/contributors.json:

4:47 PM Changeset in webkit [269001] by stephan.szabo@sony.com

• 2 edits in trunk/Source/WebCore

evictCodedFrames does extra work if RELEASE_LOG_DISABLED is set
​https://bugs.webkit.org/show_bug.cgi?id=218203

Reviewed by Eric Carlson.

Undo part of previous logging change that prevents checking
if the buffer is still full after the first part of eviction
if RELEASE_LOG_DISABLED is set.

• Modules/mediasource/SourceBuffer.cpp:

4:38 PM Changeset in webkit [269000] by Simon Fraser

• 7 edits
  2 adds in trunk

REGRESSION (r260276): Unable to click on image and text link at the bottom of ​https://www.nytimes.com/ article
​https://bugs.webkit.org/show_bug.cgi?id=218137
<rdar://problem/70439526>

Reviewed by Zalan Bujtas.
Source/WebCore:

r238725 made RenderLayers for accelerated overflow:scroll be self-painting, but that
changes paint and hit-testing order, which affected this nytimes article (the failing
element has large negative margin-top).

This is the fundamental compositing bug, but we can work around it in this case by
only making the layer self-painting if it does actually scroll.

Test: fast/layers/overflow-scroll-self-painting.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Need to update isSelfPaintingLayer()
after layout because now it depends on scrollable overflow.
(WebCore::RenderLayer::shouldBeSelfPaintingLayer const): Consult hasCompositedScrollableOverflow()
rather than canUseCompositedScrolling().

LayoutTests:

New test. Rebaseline tests affected by the self-painting layer change.

• compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:
• compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping-expected.txt:
• fast/layers/overflow-scroll-self-painting-expected.html: Added.
• fast/layers/overflow-scroll-self-painting.html: Added.
• platform/ios-wk2/compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:
• platform/ios-wk2/compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping-expected.txt:

4:09 PM Changeset in webkit [268999] by Chris Dumez

• 5 edits in trunk

Improve exception messages when AudioContext.suspend() / resume() promises are rejected
​https://bugs.webkit.org/show_bug.cgi?id=218210

Reviewed by Geoffrey Garen.

Source/WebCore:

Improve exception messages when AudioContext.suspend() / resume() promises are rejected.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspendRendering):
(WebCore::AudioContext::resumeRendering):

LayoutTests:

• webaudio/audiocontext-state.html:

Stop expecting that the resume() promise is rejected without any exception.
This is not standard behavior and does not match the behavior of other
browsers either.

• webaudio/construct-node-with-closed-context-expected.txt:

Rebaseline test now that exception messages have been improved.

3:11 PM Changeset in webkit [268998] by Adrian Perez de Castro

• 3 edits in trunk/Source/WebCore

Unreviewed non-unified build fix

• animation/KeyframeEffectStack.h: Add missing forward declaration for RenderStyle.
• workers/WorkerOrWorkletThread.cpp: Add missing headers ThreadGlobalData.h and WorkerOrWorkletGlobalScope.h

2:49 PM Changeset in webkit [268997] by Truitt Savell

• 7 edits
  2 deletes in trunk

Unreviewed, reverting r268947.

Caused 60 image failures on Catalina WK2

Reverted changeset:

"REGRESSION (r260276): Unable to click on image and text link
at the bottom of ​https://www.nytimes.com/ article"
​https://bugs.webkit.org/show_bug.cgi?id=218137
​https://trac.webkit.org/changeset/268947

2:19 PM Changeset in webkit [268996] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Allow skipping specific files from report-non-inclusive-language
​https://bugs.webkit.org/show_bug.cgi?id=218199

Reviewed by Darin Adler.

• Scripts/report-non-inclusive-language:

1:24 PM Changeset in webkit [268995] by Diego Pino Garcia

• 15 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update expectations after r268973.

• platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
• platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
• platform/gtk/fast/forms/basic-buttons-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
• platform/gtk/svg/text/text-overflow-ellipsis-svgfont-expected.txt:

1:23 PM Changeset in webkit [268994] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

[LFC][Integration] Use term "modern line layout" in RenderBlockFlow
​https://bugs.webkit.org/show_bug.cgi?id=218200

Reviewed by Zalan Bujtas.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::containing):
(WebCore::LayoutIntegration::LineLayout::releaseCaches):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):
(WebCore::RenderBlockFlow::firstLineBaseline const):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
(WebCore::RenderBlockFlow::lineCount const):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::hasLines const):
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):
(WebCore::RenderBlockFlow::layoutModernLines):
(WebCore::RenderBlockFlow::ensureLineBoxes):
(WebCore::RenderBlockFlow::layoutLFCLines): Deleted.

• rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::hasModernLineLayout const):
(WebCore::RenderBlockFlow::modernLineLayout const):
(WebCore::RenderBlockFlow::modernLineLayout):
(WebCore::RenderBlockFlow::hasLayoutFormattingContextLineLayout const): Deleted.
(WebCore::RenderBlockFlow::layoutFormattingContextLineLayout const): Deleted.
(WebCore::RenderBlockFlow::layoutFormattingContextLineLayout): Deleted.

1:08 PM Changeset in webkit [268993] by achristensen@apple.com

• 32 edits
  2 adds
  2 deletes in trunk/Source

Inclusive software: Remove instances of "dumb" from the code
​https://bugs.webkit.org/show_bug.cgi?id=217778

Reviewed by Simon Fraser.

Source/JavaScriptCore:

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::unboxBoolean):

• heap/SlotVisitor.h:
• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitVirtualCall):
(JSC::AssemblyHelpers::emitDumbVirtualCall): Deleted.

• jit/AssemblyHelpers.h:
• jit/JITCall.cpp:

(JSC::JIT::compileCallEvalSlowCase):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):

• runtime/CachedTypes.cpp:
• runtime/JSCJSValue.h:
• runtime/WriteBarrier.h:
• runtime/WriteBarrierInlines.h:

(JSC::RawValueTraits<Unknown>>::set):
(JSC::DumbValueTraits<Unknown>>::set): Deleted.

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addCallIndirect):

• wasm/generateWasm.py:

(opcodeIterator):

Source/WebCore:

• Modules/webaudio/AudioNode.h:
• dom/GCReachableRef.h:
• page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• icu/unicode/caniter.h:
• wtf/Bag.h:
• wtf/CMakeLists.txt:
• wtf/CagedPtr.h:
• wtf/Forward.h:
• wtf/NakedRef.h:
• wtf/RawPtrTraits.h: Renamed from Source/WTF/wtf/DumbPtrTraits.h.
• wtf/RawValueTraits.h: Renamed from Source/WTF/wtf/DumbValueTraits.h.
• wtf/Ref.h:
• wtf/RefCountedArray.h:
• wtf/RefPtr.h:
• wtf/SentinelLinkedList.h:

12:57 PM Changeset in webkit [268992] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[TextureMapper] min(genIType) isn't supported for GLSL ES < 3.0
​https://bugs.webkit.org/show_bug.cgi?id=218164

Reviewed by Don Olmstead.

Nothing is drawn in AC mode of WinCairo port since r268923.
r268923 added a shader code of using min of int type which is
supported since GLSL ES 3.0.

• platform/graphics/texmap/TextureMapperShaderProgram.cpp: Added fragmentTemplateES to define int type of min.

(WebCore::TextureMapperShaderProgram::create):

12:54 PM Changeset in webkit [268991] by Keith Rollin

• 3 edits in trunk

Move some initialization code from top-level CMakeLists.txt to WebKitCommon.cmake
​https://bugs.webkit.org/show_bug.cgi?id=218069
<rdar://problem/70556952>

Reviewed by Fujii Hironori.

Moving this initialization code into a central location allows other
top-level CMakeLists.txt files to include WebKitCommon.cmake and get
that same initialization.

• CMakeLists.txt:
• Source/cmake/WebKitCommon.cmake:

11:41 AM Changeset in webkit [268990] by weinig@apple.com

• 95 edits in trunk/Source

JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage
​https://bugs.webkit.org/show_bug.cgi?id=218159

Reviewed by Darin Adler.

Add static prefix when declarations are constrained to the cpp file. This should help out the linker
by using the correct linkage type.

Source/JavaScriptCore:

• runtime/ArrayPrototype.cpp:
• runtime/AsyncGeneratorFunctionConstructor.cpp:
• runtime/AtomicsObject.cpp:
• runtime/DateConstructor.cpp:
• runtime/DatePrototype.cpp:
• runtime/InspectorInstrumentationObject.cpp:
• runtime/JSDataViewPrototype.cpp:
• runtime/JSONObject.cpp:
• runtime/MathObject.cpp:
• runtime/ObjectConstructor.cpp:
• runtime/RegExpObject.cpp:
• runtime/StringPrototype.cpp:

Source/WebCore:

• page/DOMWindow.idl:
• bindings/js/JSDOMWindowCustom.cpp:

Add ForwardDeclareInHeader to showModalDialog to allow it to be access from JSDOMWindowCustom.cpp. This
also means we can remove the redundant forward declaration.

• bindings/scripts/CodeGeneratorJS.pm:

Prefix declarations that are constrained to the cpp files with static.

• bindings/scripts/test/JS/JSDOMWindow.cpp:
• bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp:
• bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:
• bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp:
• bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp:
• bindings/scripts/test/JS/JSTestCEReactions.cpp:
• bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
• bindings/scripts/test/JS/JSTestCallTracer.cpp:
• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
• bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:
• bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp:
• bindings/scripts/test/JS/JSTestDOMJIT.cpp:
• bindings/scripts/test/JS/JSTestDefaultToJSON.cpp:
• bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp:
• bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp:
• bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp:
• bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp:
• bindings/scripts/test/JS/JSTestDomainSecurity.cpp:
• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
• bindings/scripts/test/JS/JSTestEnabledForContext.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventTarget.cpp:
• bindings/scripts/test/JS/JSTestException.cpp:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
• bindings/scripts/test/JS/JSTestGlobalObject.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
• bindings/scripts/test/JS/JSTestIterable.cpp:
• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
• bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:
• bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp:
• bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp:
• bindings/scripts/test/JS/JSTestMapLike.cpp:
• bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:
• bindings/scripts/test/JS/JSTestNode.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestOperationConditional.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
• bindings/scripts/test/JS/JSTestPluginInterface.cpp:
• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
• bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp:
• bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp:
• bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestSetLike.cpp:
• bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp:
• bindings/scripts/test/JS/JSTestStringifier.cpp:
• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
• bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bindings/scripts/test/JS/JSWorkerGlobalScope.cpp:
• bindings/scripts/test/JS/JSWorkletGlobalScope.cpp:

Update tests with new output.

11:40 AM Changeset in webkit [268989] by commit-queue@webkit.org

• 11 edits in trunk/Source/WebKit

Add null checks and smart pointers in PDF and Plugin code
​https://bugs.webkit.org/show_bug.cgi?id=218144
<rdar://problem/69931543>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-10-26
Reviewed by Youenn Fablet.

It's nice when things don't crash.
isBeingAsynchronouslyInitialized wasn't called anywhere, so I removed it.

• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::~PDFPlugin):
(WebKit::PDFPlugin::getResourceBytesAtPosition):
(WebKit::PDFPlugin::updateScrollbars):
(WebKit::PDFPlugin::createScrollbar):
(WebKit::PDFPlugin::isActive const):
(WebKit::PDFPlugin::forceUpdateScrollbarsOnMainThreadForPerformanceTesting const):
(WebKit::PDFPlugin::jsPDFDocPrint):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):
(WebKit::PDFPlugin::calculateSizes):
(WebKit::PDFPlugin::willDetachRenderer):
(WebKit::PDFPlugin::destroy):
(WebKit::PDFPlugin::paintControlForLayerInContext):
(WebKit::PDFPlugin::convertFromPDFViewToScreen const):
(WebKit::PDFPlugin::boundsOnScreen const):
(WebKit::PDFPlugin::visibilityDidChange):
(WebKit::PDFPlugin::showContextMenuAtPoint):
(WebKit::PDFPlugin::handleContextMenuEvent):
(WebKit::PDFPlugin::isFullFramePlugin const):
(WebKit::PDFPlugin::handlesPageScaleFactor const):
(WebKit::PDFPlugin::clickedLink):
(WebKit::PDFPlugin::save):
(WebKit::PDFPlugin::openWithPreview):
(WebKit::PDFPlugin::saveToPDF):
(WebKit::PDFPlugin::openWithNativeApplication):
(WebKit::PDFPlugin::showDefinitionForAttributedString):
(WebKit::PDFPlugin::notifySelectionChanged):
(WebKit::PDFPlugin::notifyCursorChanged):
(WebKit::PDFPlugin::axObjectCache const):
(WebKit::PDFPlugin::performWebSearch):
(WebKit::PDFPlugin::performSpotlightSearch):

• WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Plugin):
(WebKit::Plugin::initialize):
(WebKit::Plugin::controller):
(WebKit::Plugin::controller const):
(WebKit::Plugin::~Plugin): Deleted.

• WebProcess/Plugins/Plugin.h:

(WebKit::Plugin::controller): Deleted.
(WebKit::Plugin::controller const): Deleted.

• WebProcess/Plugins/PluginController.h:
• WebProcess/WebPage/WebFrame.h:

(WebKit::WebFrame::setLoadListener):
(WebKit::WebFrame::loadListener const):

11:24 AM Changeset in webkit [268988] by Peng Liu

• 2 edits in trunk/Source/WebCore

Clean up CAAudioStreamDescription
​https://bugs.webkit.org/show_bug.cgi?id=217552

Reviewed by Youenn Fablet.

Remove an unused private function.

• platform/audio/cocoa/CAAudioStreamDescription.h:

11:06 AM Changeset in webkit [268987] by Peng Liu

• 2 edits in trunk/Source/WebCore

Video immediately exits full screen and pauses
​https://bugs.webkit.org/show_bug.cgi?id=218103

Reviewed by Jer Noble.

A follow-up patch of r265437 to enable the quirk when a video element's class names
contain amp-html5 and amp-media-element.

• page/Quirks.cpp:

(WebCore::Quirks::needsAkamaiMediaPlayerQuirk const):

10:54 AM Changeset in webkit [268986] by Antti Koivisto

• 5 edits in trunk/Source/WebCore

Move some functions from RenderBlockFlow to RenderDeprecatedFlexbox
​https://bugs.webkit.org/show_bug.cgi?id=218194

Reviewed by Zalan Bujtas.

It is the only client.

• rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::markupBox const):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::lineAtIndex const): Deleted.
(WebCore::getHeightForLineCount): Deleted.
(WebCore::RenderBlockFlow::heightForLineCount): Deleted.

• rendering/RenderBlockFlow.h:
• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::shouldCheckLines):
(WebCore::lineAtIndex):
(WebCore::getHeightForLineCount):
(WebCore::heightForLineCount):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

10:52 AM Changeset in webkit [268985] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][Integration] Account for margin start when setting the renderer's border box location
​https://bugs.webkit.org/show_bug.cgi?id=218190

Reviewed by Antti Koivisto.

After r268950 replaced runs start at the margin box logical left. Let's offset the border box
location with the margin value.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendInlineContainerStart): <span> should take negative margins into account as well.
(WebCore::Layout::Line::appendNonReplacedInlineBox): rename.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

10:49 AM Changeset in webkit [268984] by Matt Lewis

• 3 edits in trunk/Tools

Webkitscmpy has missing / in scm executable candidate list.
​https://bugs.webkit.org/show_bug.cgi?id=218166

Reviewed by Jonathan Bedard.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Version Bump
• Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm.executable):

10:29 AM Changeset in webkit [268983] by youenn@apple.com

• 3 edits in trunk/Tools

W3C test importer should not import manual HTTPS tests
​https://bugs.webkit.org/show_bug.cgi?id=217944

Reviewed by Jonathan Bedard.

Uodate manual test detection heuristic to simply search for '-manual.'.

• Scripts/webkitpy/w3c/test_parser.py:

(TestParser.is_wpt_manualtest):

• Scripts/webkitpy/w3c/test_parser_unittest.py:

10:27 AM Changeset in webkit [268982] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._boxModelDiagramRow.minimumWidth')
​https://bugs.webkit.org/show_bug.cgi?id=218135

Patch by Patrick Angle <Patrick Angle> on 2020-10-26
Reviewed by Brian Burg.

minimumWidth may be retrieved before the ComputedStylesDetailsPanel has done its initial layout, which means the
_boxModelDiagramRow will not have been initialized. In this case, we want to return 0 causing the absolute
minimum width of a sidebar to be used for calculations instead.

• UserInterface/Views/ComputedStyleDetailsPanel.js:

(WI.ComputedStyleDetailsPanel.prototype.get minimumWidth):

10:25 AM Changeset in webkit [268981] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Change minimum width of #tab-browser to a more reasonable value
​https://bugs.webkit.org/show_bug.cgi?id=217998

Patch by Patrick Angle <Patrick Angle> on 2020-10-26
Reviewed by Brian Burg.

Adjusted the minimum width of the #tab-browser to be 200px, which is a more reasonable minimum usable width.
Additionally, adjusted the threshold for which multiple sidebars are shown by 50px so that the size of the
#tab-browser does not have to become its minimum width before hiding the additional sidebars.

• UserInterface/Base/Main.js:
• UserInterface/Views/Main.css:

(#tab-browser):

• UserInterface/Views/MultiSidebar.js:

(WI.MultiSidebar.prototype._updateMinimumWidthForMultipleSidebars):

10:02 AM Changeset in webkit [268980] by Karl Rackler

• 2 edits in branches/safari-610-branch/LayoutTests

REGRESSION: [ iOS wk2 ] fast/events/touch/ios/pointer-events-with-modifiers.html is a constant crash
rdar://69762963
Removing test expectation now that test is passing.

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

8:35 AM Changeset in webkit [268979] by youenn@apple.com

• 5 edits in trunk/Source

Use a WeakHashSet for Document::m_captionPreferencesChangedElements
​https://bugs.webkit.org/show_bug.cgi?id=218170

Reviewed by Eric Carlson.

Source/WebCore:

Refactoring to move from raw pointer to weak pointer.
For that purpose, we use WeakHashSet and WeakHashSet::forEach for extra safety.
No observable change of behavior.

• dom/Document.cpp:

(WebCore::Document::registerForCaptionPreferencesChangedCallbacks):
(WebCore::Document::unregisterForCaptionPreferencesChangedCallbacks):
(WebCore::Document::captionPreferencesChanged):

• dom/Document.h:

Source/WTF:

• wtf/WeakHashSet.h:

Add a static cast for classes inheriting CanMakeWeakPtr like done for the set iterator.
Update code to compile in WinCairo.

7:54 AM Changeset in webkit [268978] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Make use of signalling thread when creating the peer connection factory
​https://bugs.webkit.org/show_bug.cgi?id=218169

Reviewed by Eric Carlson.

Covered by existing tests.

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::factory):
This will free the networking thread from some tasks which is better for performance reasons,
as well as more consistent.

6:59 AM Changeset in webkit [268977] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer][EME] Remove unused protection even in common decryptor
​https://bugs.webkit.org/show_bug.cgi?id=218183

Reviewed by Philippe Normand.

Removing unused decryptor attribute, reminiscence of the past.

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

6:58 AM Changeset in webkit [268976] by Antti Koivisto

• 5 edits in trunk/Source/WebCore

[LFC][Integration] Allow all replaced elements
​https://bugs.webkit.org/show_bug.cgi?id=218074

Reviewed by Zalan Bujtas.

Add a #define to allow all RenderReplaced in modern line layout.
Also add one for inline-blocks.

Both are disabled for now.

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::containing):
(WebCore::LayoutIntegration::LineLayout::hitTest):

Implement hit testing.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutLFCLines):

6:48 AM Changeset in webkit [268975] by calvaris@igalia.com

• 3 edits in trunk/Source/WebCore

[EME] Fix casts and sizes printing
​https://bugs.webkit.org/show_bug.cgi?id=218171

Reviewed by Philippe Normand.

Fix size printing and casts in CDMThunder and ClearKey.

• platform/graphics/gstreamer/eme/CDMProxyClearKey.cpp:

(WebCore::CDMProxyClearKey::cencDecryptSubsampled):

• platform/graphics/gstreamer/eme/CDMThunder.cpp:

(WebCore::ParsedResponseMessage::ParsedResponseMessage):
(WebCore::CDMInstanceSessionThunder::requestLicense):
(WebCore::CDMInstanceSessionThunder::updateLicense):
(WebCore::CDMInstanceSessionThunder::loadSession):
(WebCore::CDMInstanceSessionThunder::removeSessionData):

6:32 AM Changeset in webkit [268974] by Alan Bujtas

• 10 edits in trunk/Source/WebCore

[LFC] Rename functions with ContentWidth/HeightAndMargin return type
​https://bugs.webkit.org/show_bug.cgi?id=218165

Reviewed by Antti Koivisto.

E.g. inlineBlockWidthAndMargin does not indicate whether it computes border, padding or content box width.
Let's rename Geometry::*WidthAndMargin and Geometry::*HeightAndMargin to Geometry::*ContentWidthAndMargin and Geometry::*ContentHeightAndMargin.

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedContentWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedContentHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedContentWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingContentHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingContentWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedContentHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedContentWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin): Deleted.
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin): Deleted.
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin): Deleted.
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin): Deleted.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedContentHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedContentWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedContentWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowContentHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowContentWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::computedContentWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::computedWidthAndMargin): Deleted.

• layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):
(WebCore::Layout::TableWrapperBlockFormattingContext::computeHeightAndMarginForTableBox):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockContentWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockContentHeightAndMargin const):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin): Deleted.
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin const): Deleted.

6:28 AM Changeset in webkit [268973] by Alan Bujtas

• 26 edits in trunk/LayoutTests

Remove unneeded whitespace between content and <br>
​https://bugs.webkit.org/show_bug.cgi?id=218151
<rdar://problem/70662471>

Reviewed by Antti Koivisto.

Missed these files in r268958.

• fast/css/text-overflow-ellipsis-bidi.html:
• fast/css/text-overflow-ellipsis-strict.html:
• fast/forms/basic-buttons.html:
• fast/repaint/add-table-overpaint-expected.txt:
• fast/repaint/hidpi-wrong-repaint-rect-when-parent-has-noncompositing-transform-expected.txt:
• fast/repaint/obscured-background-no-repaint-expected.txt:
• fast/repaint/resources/line-flow-with-floats.html:
• platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
• platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
• platform/mac/fast/forms/basic-buttons-expected.txt:
• platform/mac/fast/repaint/japanese-rl-selection-clear-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
• platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
• platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
• platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt:
• svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html:
• svg/text/text-overflow-ellipsis-svgfont.html:

6:19 AM Changeset in webkit [268972] by Philippe Normand

• 4 edits
  3 moves
  2 adds
  2 deletes in trunk/LayoutTests

Unreviewed, GStreamer WebAudio gardening

• platform/glib/TestExpectations: Remove tests consistently passing or that needed a

rebaseline which is part of this commit.

• platform/glib/webaudio/audiobuffersource-playbackrate-expected.wav:
• platform/glib/webaudio/oscillator-custom-expected.wav: Renamed from LayoutTests/platform/gtk/webaudio/oscillator-custom-expected.wav.
• platform/glib/webaudio/oscillator-sawtooth-expected.wav: Renamed from LayoutTests/platform/gtk/webaudio/oscillator-sawtooth-expected.wav.
• platform/glib/webaudio/oscillator-sine-expected.wav: Renamed from LayoutTests/platform/gtk/webaudio/oscillator-sine-expected.wav.
• platform/glib/webaudio/oscillator-square-expected.wav: Added.
• platform/glib/webaudio/oscillator-triangle-expected.wav: Added.
• platform/gtk/TestExpectations:
• platform/gtk/webaudio/oscillator-square-expected.wav: Removed.
• platform/gtk/webaudio/oscillator-triangle-expected.wav: Removed.

5:50 AM Changeset in webkit [268971] by youenn@apple.com

• 20 edits
  2 adds in trunk

Add support for VP9 Profile 2 (10-bit color) in WebRTC
​https://bugs.webkit.org/show_bug.cgi?id=217673
<rdar://problem/70283885>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Add support for VP9 profile 0 and 2.
This requires correctly handling 10-bit decoded buffers as is done by the MSE code path.

• Configurations/libwebrtc.iOS.exp:
• Configurations/libwebrtc.iOSsim.exp:
• Configurations/libwebrtc.mac.exp:
• Source/webrtc/sdk/WebKit/WebKitUtilities.h:
• Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

(webrtc::pixelBufferFromFrame):

• Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

(webrtc::WebKitVP9DecoderReceiver::Decoded):

• Source/webrtc/sdk/objc/api/video_codec/RTCVideoEncoderVP9.h:
• Source/webrtc/sdk/objc/api/video_codec/RTCVideoEncoderVP9.mm:

(+[RTCVideoEncoderVP9 vp9Encoder:]):

• Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.m:

(-[RTCDefaultVideoDecoderFactory supportedCodecs]):

• Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m:

(+[RTCDefaultVideoEncoderFactory supportedCodecsWithH265:vp9:]):
(-[RTCDefaultVideoEncoderFactory createEncoder:]):

Source/WebCore:

In case software VP9 decoded buffer is 10 bits, we use kCVPixelFormatType_420YpCbCr10BiPlanarFullRange.

Test: webrtc/vp9-profile2.html

• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h:
• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:

(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferPool):
(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferFromVideoFrame):

• platform/mediastream/mac/RealtimeVideoUtilities.h:
• platform/mediastream/mac/RealtimeVideoUtilities.mm:

(WebCore::createPixelBufferPool):

Source/WebKit:

• WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::LibWebRTCCodecs::pixelBufferPool):

LayoutTests:

• webrtc/vp9-profile2-expected.txt: Added.
• webrtc/vp9-profile2.html: Added.

5:42 AM Changeset in webkit [268970] by youenn@apple.com

• 7 edits in trunk/Source/WebCore

Remove MediaPlayer::m_visible
​https://bugs.webkit.org/show_bug.cgi?id=217810

Reviewed by Eric Carlson.

MediaPlayer::visible() is only used by MediaPlayerPrivateAVFoundation and MediaPlayerPrivateGStreamer but they have their own m_visible state.
We need to keep m_visible and add m_visibleForCanvas to keep the state when changing of engine.
No change of behavior.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setVisible):
(WebCore::MediaPlayer::setVisibleForCanvas):

• platform/graphics/MediaPlayer.h:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const):
(WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup const):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::paint):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

5:31 AM Changeset in webkit [268969] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, GStreamer WebAudio gardening

• platform/glib/TestExpectations: Unflag flaky webaudio tests consistently passing since

r268826.

4:56 AM Changeset in webkit [268968] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[EME][Thunder][GStreamer] Assert on 0 length messages from Thunder
​https://bugs.webkit.org/show_bug.cgi?id=218173

Reviewed by Philippe Normand.

• platform/graphics/gstreamer/eme/CDMThunder.cpp:

(WebCore::CDMInstanceSessionThunder::CDMInstanceSessionThunder):
Assert on 0 length messages to get a crash and be able to analyze
why.

4:33 AM Changeset in webkit [268967] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GLIB][GTK] Unreviewed test gardening. Gardened latest tests passing on bots.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

4:00 AM Changeset in webkit [268966] by emilio

• 6 edits in trunk

Drop sorting and deduplication of media queries.
​https://bugs.webkit.org/show_bug.cgi?id=217751

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/css/cssom/mediaquery-sort-dedup-expected.txt: annotate progression

Source/WebCore:

This matches what Gecko has shipped for ages.

The spec used to contain the sorting but not the de-duplication.

Both the spec and Chromium have been updated to match Gecko, see
​https://github.com/w3c/csswg-drafts/issues/5627

• css/MediaQuery.cpp:

(WebCore::MediaQuery::MediaQuery): Don't sort / dedup

Tests: imported/w3c/web-platform-tests/css/cssom/mediaquery-sort-dedup.html

LayoutTests:

• fast/media/media-query-serialization.html: Adjust to match spec.

2:35 AM Changeset in webkit [268965] by zandobersek@gmail.com

• 14 edits in trunk

Remove Accelerated2dCanvasEnabled WebPreferences entry
​https://bugs.webkit.org/show_bug.cgi?id=218114

Reviewed by Adrian Perez de Castro.

Source/WebKit:

With the removal of the Accelerated2dCanvasEnabled preference key,
relevant API functions in the WK2 C API are made no-op. Similar
thing is done for the relevant GLib API, with the addition of marking
relevant API funcions as deprecated.

• Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPreferencesSetAccelerated2DCanvasEnabled):
(WKPreferencesGetAccelerated2DCanvasEnabled):

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAccelerated2DCanvasEnabled): Deleted.
(WKPreferencesGetAccelerated2DCanvasEnabled): Deleted.

• UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_accelerated_2d_canvas):
(webkit_settings_set_enable_accelerated_2d_canvas):

• UIProcess/API/gtk/WebKitSettings.h:
• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_backend):

• UIProcess/API/wpe/WebKitSettings.h:

Source/WebKitLegacy/mac:

• WebView/WebPreferences.mm:

(-[WebPreferences accelerated2dCanvasEnabled]): Make the API function
no-op and move it into the deprecated section.
(-[WebPreferences setAccelerated2dCanvasEnabled:]): Ditto.

Source/WTF:

• Scripts/Preferences/WebPreferences.yaml:

Remove the Accelerated2dCanvasEnabled key after the underlying code
was removed in r268453.

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings): Adjust the test case to properly evaluate the
deprecated no-op behavior.

2:02 AM Changeset in webkit [268964] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening. Update baselines of a few more tests remaining after r268958.

• platform/glib/fast/box-shadow/box-shadow-radius-expected.txt:
• platform/gtk/fonts/serif-expected.txt:
• platform/wpe/fonts/serif-expected.txt:

Oct 25, 2020:

11:13 PM Changeset in webkit [268963] by Diego Pino Garcia

• 178 edits
  6 moves
  3 adds
  8 deletes in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening. Update baselines after r268958.

• platform/glib/fast/block/positioning/differing-writing-modes-expected.txt:
• platform/glib/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
• platform/glib/fast/borders/border-image-01-expected.txt:
• platform/glib/fast/borders/border-image-longhand-expected.txt:
• platform/glib/fast/borders/border-image-massive-scale-expected.txt:
• platform/glib/fast/borders/border-image-outset-expected.txt:
• platform/glib/fast/borders/border-image-outset-in-shorthand-expected.txt:
• platform/glib/fast/borders/border-image-repeat-expected.txt:
• platform/glib/fast/borders/border-image-rotate-transform-expected.txt:
• platform/glib/fast/borders/border-image-scale-transform-expected.txt:
• platform/glib/fast/borders/border-image-scaled-expected.txt:
• platform/glib/fast/borders/border-image-scrambled-expected.txt:
• platform/glib/fast/borders/border-image-side-reduction-expected.txt:
• platform/glib/fast/borders/border-image-slices-expected.txt:
• platform/glib/fast/borders/border-image-source-expected.txt:
• platform/glib/fast/borders/mixed-border-styles-expected.txt:
• platform/glib/fast/borders/mixed-border-styles-radius-expected.txt:
• platform/glib/fast/box-shadow/inset-box-shadow-radius-expected.txt:
• platform/glib/fast/box-shadow/inset-box-shadows-expected.txt:
• platform/glib/fast/box-shadow/scaled-box-shadow-expected.txt:
• platform/glib/fast/css/focus-ring-detached-expected.txt:
• platform/glib/fast/images/image-map-anchor-children-expected.txt:
• platform/glib/fast/inline-block/006-expected.txt:
• platform/glib/fast/ruby/ruby-simple-rp-expected.txt: Renamed from LayoutTests/platform/wpe/fast/ruby/ruby-simple-rp-expected.txt.
• platform/glib/fast/text/basic/012-expected.txt: Renamed from LayoutTests/platform/wpe/fast/text/basic/012-expected.txt.
• platform/glib/fast/text/emphasis-overlap-expected.txt: Added.
• platform/glib/fast/text/indic-expected.txt: Renamed from LayoutTests/platform/gtk/fast/text/indic-expected.txt.
• platform/glib/fast/text/justify-nbsp-expected.txt: Renamed from LayoutTests/platform/gtk/fast/text/justify-nbsp-expected.txt.
• platform/glib/fast/transforms/identity-matrix-expected.txt:
• platform/glib/fonts/monospace-expected.txt: Renamed from LayoutTests/platform/wpe/fonts/monospace-expected.txt.
• platform/glib/svg/as-border-image/svg-as-border-image-2-expected.txt:
• platform/glib/svg/as-border-image/svg-as-border-image-expected.txt:
• platform/glib/svg/custom/getscreenctm-in-mixed-content-expected.txt:
• platform/glib/tables/mozilla/bugs/bug11026-expected.txt:
• platform/glib/tables/mozilla/bugs/bug28341-expected.txt:
• platform/glib/tables/mozilla/bugs/bug4284-expected.txt:
• platform/glib/tables/mozilla/bugs/bug4849-2-expected.txt:
• platform/glib/tables/mozilla/bugs/bug60992-expected.txt:
• platform/glib/tables/mozilla/bugs/bug92868-expected.txt:
• platform/glib/tables/mozilla/bugs/bug963-expected.txt:
• platform/glib/tables/mozilla/core/col_widths_fix_auto-expected.txt:
• platform/glib/tables/mozilla/other/nestedTables-expected.txt:
• platform/glib/tables/mozilla_expected_failures/bugs/bug1262-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug1262-expected.txt.
• platform/gtk/compositing/iframes/composited-iframe-alignment-expected.txt:
• platform/gtk/compositing/overflow/ancestor-overflow-expected.txt:
• platform/gtk/compositing/overflow/overflow-scroll-expected.txt:
• platform/gtk/fast/block/float/float-in-float-hit-testing-expected.txt:
• platform/gtk/fast/block/float/float-in-float-painting-expected.txt:
• platform/gtk/fast/borders/border-image-border-radius-expected.txt:
• platform/gtk/fast/clip/overflow-border-radius-combinations-expected.txt:
• platform/gtk/fast/clip/overflow-border-radius-composited-expected.txt:
• platform/gtk/fast/clip/overflow-border-radius-transformed-expected.txt:
• platform/gtk/fast/css/first-line-text-decoration-expected.txt:
• platform/gtk/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/gtk/fast/css/layerZOrderCrash-expected.txt:
• platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
• platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• platform/gtk/fast/dom/focus-contenteditable-expected.txt:
• platform/gtk/fast/forms/basic-inputs-expected.txt:
• platform/gtk/fast/forms/basic-selects-expected.txt:
• platform/gtk/fast/forms/button-align-expected.txt:
• platform/gtk/fast/forms/button-generated-content-expected.txt:
• platform/gtk/fast/forms/button-table-styles-expected.txt:
• platform/gtk/fast/forms/caret-rtl-expected.txt:
• platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
• platform/gtk/fast/forms/hidden-listbox-expected.txt:
• platform/gtk/fast/forms/input-align-expected.txt:
• platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
• platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
• platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
• platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
• platform/gtk/fast/forms/input-baseline-expected.txt:
• platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
• platform/gtk/fast/forms/input-spaces-expected.txt:
• platform/gtk/fast/forms/listbox-width-change-expected.txt:
• platform/gtk/fast/forms/option-script-expected.txt:
• platform/gtk/fast/forms/option-text-clip-expected.txt:
• platform/gtk/fast/forms/range/slider-padding-expected.txt:
• platform/gtk/fast/forms/search-rtl-expected.txt:
• platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt:
• platform/gtk/fast/forms/select-align-expected.txt:
• platform/gtk/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/gtk/fast/forms/select-initial-position-expected.txt:
• platform/gtk/fast/forms/select-style-expected.txt:
• platform/gtk/fast/forms/textarea-align-expected.txt:
• platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
• platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
• platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/gtk/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/gtk/fast/inline/drawStyledEmptyInlines-expected.txt:
• platform/gtk/fast/layers/layer-visibility-sublayer-expected.txt:
• platform/gtk/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
• platform/gtk/fast/ruby/bopomofo-letter-spacing-expected.txt:
• platform/gtk/fast/ruby/ruby-inline-table-expected.txt:
• platform/gtk/fast/ruby/ruby-length-expected.txt:
• platform/gtk/fast/ruby/ruby-run-break-expected.txt:
• platform/gtk/fast/ruby/ruby-runs-expected.txt:
• platform/gtk/fast/ruby/ruby-simple-expected.txt:
• platform/gtk/fast/ruby/ruby-simple-rp-expected.txt: Removed.
• platform/gtk/fast/text/basic/012-expected.txt: Removed.
• platform/gtk/fast/text/capitalize-boundaries-expected.txt:
• platform/gtk/fast/text/emphasis-overlap-expected.txt: Removed.
• platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
• platform/gtk/fast/writing-mode/fieldsets-expected.txt:
• platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt:
• platform/gtk/fast/writing-mode/vertical-baseline-alignment-mixed-expected.txt:
• platform/gtk/fonts/monospace-expected.txt: Removed.
• platform/gtk/fonts/sans-serif-expected.txt:
• platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug131020_iframe-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug1430-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug19599-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug30559-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug32205-2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug4427-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug46623-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug9123-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug92143-expected.txt:
• platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
• platform/gtk/tables/mozilla/core/bloomberg-expected.txt:
• platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
• platform/gtk/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.txt:
• platform/gtk/tables/mozilla/marvin/tables_cellspacing-expected.txt:
• platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/core/col_span2-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
• platform/wpe/fast/block/float/float-in-float-hit-testing-expected.txt:
• platform/wpe/fast/block/float/float-in-float-painting-expected.txt:
• platform/wpe/fast/borders/border-image-border-radius-expected.txt:
• platform/wpe/fast/clip/overflow-border-radius-combinations-expected.txt:
• platform/wpe/fast/clip/overflow-border-radius-composited-expected.txt:
• platform/wpe/fast/clip/overflow-border-radius-transformed-expected.txt:
• platform/wpe/fast/css/first-line-text-decoration-expected.txt:
• platform/wpe/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/wpe/fast/css/layerZOrderCrash-expected.txt:
• platform/wpe/fast/css/text-overflow-ellipsis-expected.txt:
• platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• platform/wpe/fast/dom/focus-contenteditable-expected.txt:
• platform/wpe/fast/frames/iframe-with-frameborder-expected.txt:
• platform/wpe/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/wpe/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/wpe/fast/inline/drawStyledEmptyInlines-expected.txt:
• platform/wpe/fast/layers/layer-visibility-sublayer-expected.txt:
• platform/wpe/fast/ruby/bopomofo-letter-spacing-expected.txt:
• platform/wpe/fast/ruby/ruby-inline-table-expected.txt:
• platform/wpe/fast/ruby/ruby-length-expected.txt:
• platform/wpe/fast/ruby/ruby-run-break-expected.txt:
• platform/wpe/fast/ruby/ruby-runs-expected.txt:
• platform/wpe/fast/ruby/ruby-simple-expected.txt:
• platform/wpe/fast/text/capitalize-boundaries-expected.txt:
• platform/wpe/fast/text/emphasis-overlap-expected.txt: Removed.
• platform/wpe/fast/text/indic-expected.txt: Removed.
• platform/wpe/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
• platform/wpe/fast/text/justify-nbsp-expected.txt: Removed.
• platform/wpe/fast/text/svg-font-face-with-kerning-expected.txt:
• platform/wpe/fast/writing-mode/fieldsets-expected.txt:
• platform/wpe/fast/writing-mode/vertical-baseline-alignment-expected.txt:
• platform/wpe/fast/writing-mode/vertical-baseline-alignment-mixed-expected.txt:
• platform/wpe/fonts/sans-serif-expected.txt:
• platform/wpe/scrollbars/overflow-scrollbar-combinations-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug131020-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug131020_iframe-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1318-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1430-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug19599-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug30559-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug32205-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4382-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4427-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug46623-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug55694-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug9123-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug92143-expected.txt:
• platform/wpe/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
• platform/wpe/tables/mozilla/core/bloomberg-expected.txt:
• platform/wpe/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
• platform/wpe/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_cellpadding-expected.txt:
• platform/wpe/tables/mozilla/marvin/tables_cellspacing-expected.txt:
• platform/wpe/tables/mozilla/other/wa_table_tr_align-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug1262-expected.txt: Removed.
• platform/wpe/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/core/col_span2-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/other/test4-expected.txt:

6:57 PM Changeset in webkit [268962] by weinig@apple.com

• 6 edits in trunk

Remove non-standard 'css'/'Css' prefixed properties on CSSStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=218158

Reviewed by Simon Fraser.

Source/WebCore:

Remove support for 'css'/'Css' prefixed properties of CSSStyleDeclaration which
are no longer supported by any other browser.

• css/CSSStyleDeclaration.cpp:
• css/makeprop.pl:

LayoutTests:

• fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt:
• fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html:

Update test to reflect removal of css prefixes.

2:43 PM Changeset in webkit [268961] by emilio

• 12 edits
  11 adds
  3 deletes in trunk/LayoutTests

Update CSSOM WPT tests.
​https://bugs.webkit.org/show_bug.cgi?id=218157

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• resources/resource-files.json:
• web-platform-tests/css/cssom/CSS.html: Removed.
• web-platform-tests/css/cssom/CSSCounterStyleRule-expected.txt: Added.
• web-platform-tests/css/cssom/CSSCounterStyleRule.html: Added.
• web-platform-tests/css/cssom/CSSFontFaceRule-expected.txt: Added.
• web-platform-tests/css/cssom/CSSFontFaceRule.html: Added.
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative.html:
• web-platform-tests/css/cssom/css-style-attr-decl-block.html:
• web-platform-tests/css/cssom/cssimportrule.html:
• web-platform-tests/css/cssom/escape.html:
• web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html:
• web-platform-tests/css/cssom/getComputedStyle-resolved-colors-expected.txt: Added.
• web-platform-tests/css/cssom/getComputedStyle-resolved-colors.html: Added.
• web-platform-tests/css/cssom/medialist-interfaces-003-expected.txt: Removed.
• web-platform-tests/css/cssom/medialist-interfaces-003.html: Removed.
• web-platform-tests/css/cssom/mediaquery-sort-dedup-expected.txt: Added.
• web-platform-tests/css/cssom/mediaquery-sort-dedup.html: Added.
• web-platform-tests/css/cssom/removerule-invalidation-crash.html: Added.
• web-platform-tests/css/cssom/rule-restrictions-expected.txt: Added.
• web-platform-tests/css/cssom/rule-restrictions.html: Added.
• web-platform-tests/css/cssom/serialize-media-rule-expected.txt:
• web-platform-tests/css/cssom/serialize-media-rule.html:
• web-platform-tests/css/cssom/w3c-import.log:

LayoutTests:

• tests-options.json:

2:34 PM Changeset in webkit [268960] by Simon Fraser

• 5 edits
  2 copies in trunk/Source/WebCore

[LFC Display] Move code for painting a single Display::Box into its own class
​https://bugs.webkit.org/show_bug.cgi?id=218161

Reviewed by Antti Koivisto.

Move box-painting code into its own class, so that CSSPainter is about CSS stacking
context logic, and BoxPainter is about how to paint a single box.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• display/css/DisplayBoxPainter.cpp: Copied from Source/WebCore/display/css/DisplayCSSPainter.cpp.

(WebCore::Display::BoxPainter::paintFillLayer):
(WebCore::Display::BoxPainter::paintBackgroundImages):
(WebCore::Display::BoxPainter::paintBoxDecorations):
(WebCore::Display::BoxPainter::paintBoxContent):
(WebCore::Display::BoxPainter::paintBox):

• display/css/DisplayBoxPainter.h: Copied from Source/WebCore/display/css/DisplayCSSPainter.h.
• display/css/DisplayCSSPainter.cpp:

(WebCore::Display::CSSPainter::recursivePaintDescendants):
(WebCore::Display::CSSPainter::paintStackingContext):
(WebCore::Display::CSSPainter::paintFillLayer): Deleted.
(WebCore::Display::CSSPainter::paintBackgroundImages): Deleted.
(WebCore::Display::CSSPainter::paintBoxDecorations): Deleted.
(WebCore::Display::CSSPainter::paintBoxContent): Deleted.
(WebCore::Display::CSSPainter::paintBox): Deleted.

• display/css/DisplayCSSPainter.h:

1:26 PM Changeset in webkit [268959] by Simon Fraser

• 18 edits
  1 copy
  1 add in trunk/Source/WebCore

[LFC Display] Move display box creation and geometry computation out of Display::TreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=218160

Reviewed by Zalan Bujtas.

Make Display::BoxFactory, which has the responsibility of making Display::Boxes,
and setting up their style and geometry. This moves all of the pixel snapping
code out of Display::TreeBuilder.

Display::Box subclasses declare Display::BoxFactory as a friend class so that the factory
can call geometry setter functions (to avoid passing long lists of arguments down through
constructors).

Display::TextBox's text() is no longer Optional<> because we only make text boxes
for runs with text.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• display/DisplayTreeBuilder.cpp:

(WebCore::Display::TreeBuilder::TreeBuilder):
(WebCore::Display::TreeBuilder::build const):
(WebCore::Display::TreeBuilder::buildInlineDisplayTree const):
(WebCore::Display::TreeBuilder::recursiveBuildDisplayTree const):
(WebCore::Display::TreeBuilder::computeBoxDecorationData const): Deleted.
(WebCore::Display::TreeBuilder::displayBoxForRootBox const): Deleted.
(WebCore::Display::TreeBuilder::displayBoxForLayoutBox const): Deleted.

• display/DisplayTreeBuilder.h:
• display/css/DisplayBoxDecorationData.cpp:

(WebCore::Display::BoxDecorationData::create): Deleted.

• display/css/DisplayBoxDecorationData.h:
• display/css/DisplayBoxFactory.cpp: Added.

(WebCore::Display::BoxFactory::BoxFactory):
(WebCore::Display::BoxFactory::displayBoxForRootBox const):
(WebCore::Display::BoxFactory::displayBoxForLayoutBox const):
(WebCore::Display::BoxFactory::displayBoxForTextRun const):
(WebCore::Display::BoxFactory::setupBoxGeometry const):
(WebCore::Display::BoxFactory::constructBoxDecorationData const):
(WebCore::Display::BoxFactory::setupBoxModelBox const):

• display/css/DisplayBoxFactory.h: Copied from Source/WebCore/display/DisplayTreeBuilder.h.
• display/css/DisplayBoxModelBox.cpp:
• display/css/DisplayBoxModelBox.h:

(WebCore::Display::BoxModelBox::absoluteBorderBoxRect const):
(WebCore::Display::BoxModelBox::absolutePaddingBoxRect const):
(WebCore::Display::BoxModelBox::absoluteContentBoxRect const):
(WebCore::Display::BoxModelBox::boxDecorationData const):
(WebCore::Display::BoxModelBox::setAbsolutePaddingBoxRect):
(WebCore::Display::BoxModelBox::setAbsoluteContentBoxRect):

• display/css/DisplayCSSPainter.cpp:

(WebCore::Display::CSSPainter::paintBoxContent):

• display/css/DisplayFillLayerImageGeometry.cpp:

(WebCore::Display::calculateFillLayerImageGeometry):

• display/css/DisplayFillLayerImageGeometry.h:
• display/css/DisplayImageBox.cpp:

(WebCore::Display::ImageBox::ImageBox):
(WebCore::Display::m_image):
(): Deleted.
(WebCore::Display::ImageBox::setImage): Deleted.

• display/css/DisplayImageBox.h:

(WebCore::Display::ImageBox::image const):

• display/css/DisplayReplacedBox.cpp:

(WebCore::Display::ReplacedBox::ReplacedBox):

• display/css/DisplayReplacedBox.h:

(WebCore::Display::ReplacedBox::setReplacedContentRect):

• display/css/DisplayTextBox.cpp:

(WebCore::Display::m_text):
(WebCore::Display::TextBox::debugDescription const):

• display/css/DisplayTextBox.h:

(WebCore::Display::TextBox::text const):

12:52 PM Changeset in webkit [268958] by Alan Bujtas

• 406 edits in trunk/LayoutTests

Remove unneeded whitespace between content and <br>
​https://bugs.webkit.org/show_bug.cgi?id=218151

This is in preparation for fixing webkit.org/b/216902
(Remove collapsible trailing whitespace when it is followed by a hard line break)
These tests don't really need to have trailing whitespace in front of <br>.

Reviewed by Antti Koivisto.

• compositing/iframes/composited-iframe-alignment.html:
• compositing/overflow/ancestor-overflow.html:
• compositing/overflow/overflow-scroll.html:
• fast/block/float/float-in-float-hit-testing.html:
• fast/block/float/float-in-float-painting.html:
• fast/block/positioning/differing-writing-modes-replaced.html:
• fast/block/positioning/differing-writing-modes.html:
• fast/borders/border-image-01.html:
• fast/borders/border-image-border-radius.html:
• fast/borders/border-image-longhand.html:
• fast/borders/border-image-massive-scale.html:
• fast/borders/border-image-outset-in-shorthand.html:
• fast/borders/border-image-outset.html:
• fast/borders/border-image-repeat.html:
• fast/borders/border-image-rotate-transform.html:
• fast/borders/border-image-scale-transform.html:
• fast/borders/border-image-scaled.html:
• fast/borders/border-image-scrambled.html:
• fast/borders/border-image-side-reduction.html:
• fast/borders/border-image-slices.html:
• fast/borders/border-image-source.html:
• fast/borders/mixed-border-styles-radius.html:
• fast/borders/mixed-border-styles.html:
• fast/box-shadow/box-shadow-radius.html:
• fast/box-shadow/inset-box-shadow-radius.html:
• fast/box-shadow/inset-box-shadows.html:
• fast/box-shadow/scaled-box-shadow.html:
• fast/clip/overflow-border-radius-combinations.html:
• fast/clip/overflow-border-radius-composited.html:
• fast/clip/overflow-border-radius-transformed.html:
• fast/css/first-line-text-decoration-inherited-from-parent.html:
• fast/css/first-line-text-decoration.html:
• fast/css/focus-ring-detached.html:
• fast/css/layerZOrderCrash.html:
• fast/css/text-overflow-ellipsis.html:
• fast/dom/HTMLTextAreaElement/reset-textarea.html:
• fast/dom/Range/getBoundingClientRect-expected.txt:
• fast/dom/Range/getBoundingClientRect.html:
• fast/dom/focus-contenteditable.html:
• fast/forms/basic-inputs.html:
• fast/forms/basic-selects.html:
• fast/forms/button-align.html:
• fast/forms/button-generated-content.html:
• fast/forms/button-table-styles.html:
• fast/forms/caret-rtl.html:
• fast/forms/control-restrict-line-height.html:
• fast/forms/hidden-listbox.html:
• fast/forms/input-align.html:
• fast/forms/input-appearance-bkcolor.html:
• fast/forms/input-appearance-default-bkcolor.html:
• fast/forms/input-appearance-disabled.html:
• fast/forms/input-appearance-readonly.html:
• fast/forms/input-baseline.html:
• fast/forms/input-readonly-dimmed.html:
• fast/forms/input-spaces.html:
• fast/forms/listbox-width-change.html:
• fast/forms/option-script.html:
• fast/forms/option-text-clip.html:
• fast/forms/range/slider-padding.html:
• fast/forms/search-rtl.html:
• fast/forms/search/search-size-with-decorations.html:
• fast/forms/select-align.html:
• fast/forms/select-change-popup-to-listbox.html:
• fast/forms/select-initial-position.html:
• fast/forms/select-style.html:
• fast/forms/textarea-align.html:
• fast/forms/textarea-scrollbar.html:
• fast/frames/iframe-with-frameborder.html:
• fast/frames/onlyCommentInIFrame.html:
• fast/images/image-map-anchor-children.html:
• fast/inline-block/006.html:
• fast/inline-block/contenteditable-baseline.html:
• fast/inline/drawStyledEmptyInlines.html:
• fast/layers/layer-visibility-sublayer.html:
• fast/repaint/rel-positioned-inline-with-overflow.html:
• fast/ruby/bopomofo-letter-spacing.html:
• fast/ruby/ruby-inline-table.html:
• fast/ruby/ruby-length.html:
• fast/ruby/ruby-run-break.html:
• fast/ruby/ruby-runs.html:
• fast/ruby/ruby-simple-rp.html:
• fast/ruby/ruby-simple.html:
• fast/text-autosizing/ios/contenteditable.html:
• fast/text/basic/012.html:
• fast/text/capitalize-boundaries.html:
• fast/text/emphasis-overlap-expected.txt:
• fast/text/emphasis-overlap.html:
• fast/text/indic.html:
• fast/text/international/rtl-white-space-pre-wrap.html:
• fast/text/justify-nbsp.html:
• fast/text/svg-font-face-with-kerning.html:
• fast/transforms/identity-matrix.html:
• fast/writing-mode/fieldsets.html:
• fast/writing-mode/vertical-baseline-alignment-mixed.html:
• fast/writing-mode/vertical-baseline-alignment.html:
• fonts/monospace.html:
• fonts/sans-serif.html:
• fonts/serif.html:
• platform/mac-catalina/fast/forms/basic-inputs-expected.txt:
• platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac-catalina/fast/forms/option-text-clip-expected.txt:
• platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac-catalina/fast/text/indic-expected.txt:
• platform/mac-catalina/tables/mozilla/other/wa_table_tr_align-expected.txt:
• platform/mac-wk2/fast/layers/layer-visibility-sublayer-expected.txt:
• platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
• platform/mac/compositing/overflow/ancestor-overflow-expected.txt:
• platform/mac/compositing/overflow/overflow-scroll-expected.txt:
• platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
• platform/mac/fast/block/float/float-in-float-painting-expected.txt:
• platform/mac/fast/block/positioning/differing-writing-modes-expected.txt:
• platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
• platform/mac/fast/borders/border-image-01-expected.txt:
• platform/mac/fast/borders/border-image-border-radius-expected.txt:
• platform/mac/fast/borders/border-image-longhand-expected.txt:
• platform/mac/fast/borders/border-image-massive-scale-expected.txt:
• platform/mac/fast/borders/border-image-outset-expected.txt:
• platform/mac/fast/borders/border-image-outset-in-shorthand-expected.txt:
• platform/mac/fast/borders/border-image-repeat-expected.txt:
• platform/mac/fast/borders/border-image-rotate-transform-expected.txt:
• platform/mac/fast/borders/border-image-scale-transform-expected.txt:
• platform/mac/fast/borders/border-image-scaled-expected.txt:
• platform/mac/fast/borders/border-image-scrambled-expected.txt:
• platform/mac/fast/borders/border-image-side-reduction-expected.txt:
• platform/mac/fast/borders/border-image-slices-expected.txt:
• platform/mac/fast/borders/border-image-source-expected.txt:
• platform/mac/fast/borders/mixed-border-styles-expected.txt:
• platform/mac/fast/borders/mixed-border-styles-radius-expected.txt:
• platform/mac/fast/box-shadow/box-shadow-radius-expected.txt:
• platform/mac/fast/box-shadow/inset-box-shadow-radius-expected.txt:
• platform/mac/fast/box-shadow/inset-box-shadows-expected.txt:
• platform/mac/fast/box-shadow/scaled-box-shadow-expected.txt:
• platform/mac/fast/clip/overflow-border-radius-combinations-expected.txt:
• platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
• platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
• platform/mac/fast/css/first-line-text-decoration-expected.txt:
• platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/mac/fast/css/focus-ring-detached-expected.txt:
• platform/mac/fast/css/layerZOrderCrash-expected.txt:
• platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
• platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• platform/mac/fast/dom/focus-contenteditable-expected.txt:
• platform/mac/fast/forms/basic-selects-expected.txt:
• platform/mac/fast/forms/button-align-expected.txt:
• platform/mac/fast/forms/button-generated-content-expected.txt:
• platform/mac/fast/forms/button-table-styles-expected.txt:
• platform/mac/fast/forms/caret-rtl-expected.txt:
• platform/mac/fast/forms/control-restrict-line-height-expected.txt:
• platform/mac/fast/forms/hidden-listbox-expected.txt:
• platform/mac/fast/forms/input-align-expected.txt:
• platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
• platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
• platform/mac/fast/forms/input-appearance-disabled-expected.txt:
• platform/mac/fast/forms/input-appearance-readonly-expected.txt:
• platform/mac/fast/forms/input-baseline-expected.txt:
• platform/mac/fast/forms/input-spaces-expected.txt:
• platform/mac/fast/forms/listbox-width-change-expected.txt:
• platform/mac/fast/forms/option-script-expected.txt:
• platform/mac/fast/forms/range/slider-padding-expected.txt:
• platform/mac/fast/forms/search-rtl-expected.txt:
• platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
• platform/mac/fast/forms/select-align-expected.txt:
• platform/mac/fast/forms/select-initial-position-expected.txt:
• platform/mac/fast/forms/select-style-expected.txt:
• platform/mac/fast/forms/textarea-align-expected.txt:
• platform/mac/fast/forms/textarea-scrollbar-expected.txt:
• platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
• platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/mac/fast/images/image-map-anchor-children-expected.txt:
• platform/mac/fast/inline-block/006-expected.txt:
• platform/mac/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
• platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
• platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt:
• platform/mac/fast/ruby/ruby-inline-table-expected.txt:
• platform/mac/fast/ruby/ruby-length-expected.txt:
• platform/mac/fast/ruby/ruby-run-break-expected.txt:
• platform/mac/fast/ruby/ruby-runs-expected.txt:
• platform/mac/fast/ruby/ruby-simple-expected.txt:
• platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
• platform/mac/fast/text-autosizing/ios/contenteditable-expected.txt:
• platform/mac/fast/text/basic/012-expected.txt:
• platform/mac/fast/text/capitalize-boundaries-expected.txt:
• platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
• platform/mac/fast/text/justify-nbsp-expected.txt:
• platform/mac/fast/text/svg-font-face-with-kerning-expected.txt:
• platform/mac/fast/transforms/identity-matrix-expected.txt:
• platform/mac/fast/writing-mode/fieldsets-expected.txt:
• platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.txt:
• platform/mac/fast/writing-mode/vertical-baseline-alignment-mixed-expected.txt:
• platform/mac/fonts/monospace-expected.txt:
• platform/mac/fonts/sans-serif-expected.txt:
• platform/mac/fonts/serif-expected.txt:
• platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
• platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
• platform/mac/svg/as-border-image/svg-as-border-image-expected.txt:
• platform/mac/svg/custom/getscreenctm-in-mixed-content-expected.txt:
• platform/mac/tables/mozilla/bugs/bug11026-expected.txt:
• platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.txt:
• platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
• platform/mac/tables/mozilla/bugs/bug1430-expected.txt:
• platform/mac/tables/mozilla/bugs/bug19599-expected.txt:
• platform/mac/tables/mozilla/bugs/bug28341-expected.txt:
• platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
• platform/mac/tables/mozilla/bugs/bug32205-2-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
• platform/mac/tables/mozilla/bugs/bug46623-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4849-2-expected.txt:
• platform/mac/tables/mozilla/bugs/bug55694-expected.txt:
• platform/mac/tables/mozilla/bugs/bug60992-expected.txt:
• platform/mac/tables/mozilla/bugs/bug9123-1-expected.txt:
• platform/mac/tables/mozilla/bugs/bug92143-expected.txt:
• platform/mac/tables/mozilla/bugs/bug92868-expected.txt:
• platform/mac/tables/mozilla/bugs/bug963-expected.txt:
• platform/mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
• platform/mac/tables/mozilla/core/bloomberg-expected.txt:
• platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
• platform/mac/tables/mozilla/core/col_widths_fix_auto-expected.txt:
• platform/mac/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_cellpadding-expected.txt:
• platform/mac/tables/mozilla/marvin/tables_cellspacing-expected.txt:
• platform/mac/tables/mozilla/other/nestedTables-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
• platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.txt:
• platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
• scrollbars/overflow-scrollbar-combinations.html:
• svg/as-border-image/svg-as-border-image-2.html:
• svg/as-border-image/svg-as-border-image.html:
• svg/custom/getscreenctm-in-mixed-content.xhtml:
• tables/mozilla/bugs/bug11026.html:
• tables/mozilla/bugs/bug131020_iframe.html:
• tables/mozilla/bugs/bug1318.html:
• tables/mozilla/bugs/bug1430.html:
• tables/mozilla/bugs/bug16012.html:
• tables/mozilla/bugs/bug19599.html:
• tables/mozilla/bugs/bug28341.html:
• tables/mozilla/bugs/bug30559.html:
• tables/mozilla/bugs/bug32205-2.html:
• tables/mozilla/bugs/bug4284.html:
• tables/mozilla/bugs/bug4382.html:
• tables/mozilla/bugs/bug4427.html:
• tables/mozilla/bugs/bug46623-1.html:
• tables/mozilla/bugs/bug4849-2.html:
• tables/mozilla/bugs/bug55694.html:
• tables/mozilla/bugs/bug60992.html:
• tables/mozilla/bugs/bug9123-1.html:
• tables/mozilla/bugs/bug92143.html:
• tables/mozilla/bugs/bug92868.html:
• tables/mozilla/bugs/bug963.html:
• tables/mozilla/collapsing_borders/bug41262-3.html:
• tables/mozilla/core/bloomberg.html:
• tables/mozilla/core/col_widths_auto_autoFix.html:
• tables/mozilla/core/col_widths_fix_auto.html:
• tables/mozilla/dom/deleteTbodyRebuild1.html:
• tables/mozilla/marvin/tables_cellpadding.html:
• tables/mozilla/marvin/tables_cellspacing.html:
• tables/mozilla/other/nestedTables.html:
• tables/mozilla/other/wa_table_tr_align.html:
• tables/mozilla_expected_failures/bugs/bug1262.html:
• tables/mozilla_expected_failures/bugs/bug56024.html:
• tables/mozilla_expected_failures/bugs/bug8499.html:
• tables/mozilla_expected_failures/core/col_span2.html:
• tables/mozilla_expected_failures/other/test4.html:

9:34 AM Changeset in webkit [268957] by weinig@apple.com

• 8 edits in trunk

Remove support for 'pixel' and 'pos' CSSOM prefixes
​https://bugs.webkit.org/show_bug.cgi?id=119712

Reviewed by Simon Fraser.

Source/WebCore:

Remove support for pixel/pos prefixed properties of CSSStyleDeclaration which
are no longer supported by any other browser.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):

• css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::getCSSPropertyIDFromJavaScriptPropertyName):
(WebCore::CSSStyleDeclaration::getPropertyValueInternalForPosOrPixelPrefixed): Deleted.
(WebCore::CSSStyleDeclaration::setPropertyValueInternalForPosOrPixelPrefixed): Deleted.

• css/CSSStyleDeclaration.h:
• css/makeprop.pl:

LayoutTests:

• fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt:
• fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html:

Update test to reflect removal of pos/pixel prefixes.