Timeline

Nov 2, 2020:

10:56 PM Changeset in webkit [269286] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Fix GStreamerCommon.cpp debug category
​https://bugs.webkit.org/show_bug.cgi?id=218392

Reviewed by Adrian Perez de Castro.

GStreamerCommon.cpp lacked a default debug category so debug from
that file was not appearing under the WebKit category but empty.

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

8:20 PM Changeset in webkit [269285] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Crash under WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent()
​https://bugs.webkit.org/show_bug.cgi?id=218474

Reviewed by Geoffrey Garen.

After r269227, event loop tasks can get executed even after the script execution context
has been stopped. This introduce a flaky crash under:
WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent()

This patch updates the function to not attempt to dispatch the event after the context
has been stopped.

No new tests, covered by the following tests that are flaky crashing in debug:

• webgl/1.0.3/conformance/glsl/misc/non-ascii-comments.vert.html
• webgl/2.0.0/conformance/glsl/bugs/sampler-array-using-loop-index.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent):

7:39 PM Changeset in webkit [269284] by Chris Dumez

• 2 edits in trunk/Source/WebCore

REGRESSION (r269214): ASSERTION FAILED: m_state == CLOSED in WebCore::EventSource::abortConnectionAttempt
​https://bugs.webkit.org/show_bug.cgi?id=218457
<rdar://problem/70963581>

Reviewed by Geoffrey Garen.

When EventSource::didFail() gets called with an AccessControl error, it calls abortConnectionAttempt()
which cancels the load (by calling doExplicitLoadCancellation()). The expectation is that cancelling
the load will cause EventSource::didFail() to get called again, this time with a cancellation error,
which will set m_state to CLOSED. We're hitting the assertion because EventSource::didFail() is not
getting called with a cancellation error when the loader is a WorkerThreadableLoader and thus m_state
is not set to CLOSED as expected.

The reason for this is that MainThreadBridge::cancel() would return early and not call
ThreadableLoaderClientWrapper::didFail() if ThreadableLoaderClientWrapper::done() returns true.
ThreadableLoaderClientWrapper::done() returns true when ThreadableLoaderClientWrapper::didFail()
was already called previously, which is what's happening in our test. To address the issue,
MainThreadBridge::cancel() now calls ThreadableLoaderClientWrapper::didFail() no matter what.
This ensures consistency with the DocumentThreadableLoader.

No new tests, covered by existing test crashing on the bots.

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):

7:21 PM Changeset in webkit [269283] by rniwa@webkit.org

• 4 edits in trunk/Source/WebKit

Remove some useless comments from .messages.in files
​https://bugs.webkit.org/show_bug.cgi?id=218473

Reviewed by Tim Horton.

Remove comments that simply repeats what the code says.

• GPUProcess/GPUProcess.messages.in:
• NetworkProcess/NetworkProcess.messages.in:
• WebProcess/WebProcess.messages.in:

6:09 PM Changeset in webkit [269282] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Input sanitization improvements for Payment Request demo
​https://bugs.webkit.org/show_bug.cgi?id=218470

Reviewed by Andy Estes.

• demos/payment-request/merchant-validation.php:

5:15 PM Changeset in webkit [269281] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Regression(r269227) imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=218468
<rdar://problem/70969071>

Reviewed by Darin Adler.

Code in ServiceWorkerContainer::ready() was queueing an event loop task and then dereferencing
scriptExecutionContext() in the task. This is no longer safe after r269227 since tasks may
still be run after ActiveDOMObjects have been stopped. To address the issue, we need to
null check the scriptExecutionContext.

No new tests, covered by existing test.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ready):

4:59 PM Changeset in webkit [269280] by weinig@apple.com

• 2 edits in trunk/Tools

Sort/cleanup preferences in resetWebPreferencesToConsistentValues
​https://bugs.webkit.org/show_bug.cgi?id=218467

Reviewed by Darin Adler.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):
Sort things.

4:40 PM Changeset in webkit [269279] by Devin Rousso

• 4 edits in trunk/Source

guard UIScribbleInteraction class property observing behind a LOA check
​https://bugs.webkit.org/show_bug.cgi?id=218463
<rdar://problem/70747966>

Reviewed by Tim Horton.

Some apps appear to swizzle -[NSObject addObserver:forKeyPath:options:context:] without
support for the fact that the object can be a class rather than an instance and therefore
crash. Use a LOA check to guard observing +[UIScribbleInteraction isPencilInputExpected]
so that this doesn't happen, but only until the apps update, at which point they can fix it.

Source/WebCore:

• platform/cocoa/VersionChecks.h:

This appears to be the first instance of observing a class property, so add a new version
value for FirstThatObservesClassProperty.

Source/WebKit:

• UIProcess/ios/WKStylusDeviceObserver.mm:

(-[WKStylusDeviceObserver start]):
(-[WKStylusDeviceObserver stop]):

4:05 PM Changeset in webkit [269278] by weinig@apple.com

• 10 edits in trunk

[Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
​https://bugs.webkit.org/show_bug.cgi?id=218447

Reviewed by Darin Adler.

Source/WebKitLegacy/mac:

• Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb:
• Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb:
• WebView/WebFeature.m:

(-[WebFeature initWithKey:preferencesKey:name:details:defaultValue:hidden:]):
(-[WebFeature initWithKey:name:details:defaultValue:hidden:]): Deleted.

• WebView/WebFeatureInternal.h:

Handle non-standard preference keys by ensure we initialize WebFeatures with the generated
preferenceKey accessor rather than trying to derive it from the key directly.

Tools:

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Add missing file, TestOptionsGeneratedWebKitLegacyKeyMapping.cpp.erb.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):
(enableExperimentalFeatures): Deleted.
Match WebKitTestRunner and enable all experimental features by default. Disable a few of them to
keep the current behavior, but added FIXME to figure out why they are exposed but not enabled. Also
ensure a few preferences that are not experimental features, but were in the enableExperimentalFeatures
function remain set.

2:41 PM Changeset in webkit [269277] by Diego Pino Garcia

• 2 edits
  1 copy
  2 deletes in trunk/LayoutTests

[WPE] Unreviewed test gardening. Update test expectations.

Also remove stale WPE baseline for test imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001.html

• platform/glib/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt.
• platform/wpe/TestExpectations:
• platform/wpe/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt: Removed.

2:35 PM Changeset in webkit [269276] by Chris Dumez

• 3 edits in trunk/LayoutTests

Unreviewed, deflake imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https.html

Dump its console logging to stderr to address flakiness.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

2:24 PM Changeset in webkit [269275] by Chris Dumez

• 3 edits in trunk/Source/WebCore

REGRESSION (r269227): Crash in WebCore::WorkerOrWorkletGlobalScope::prepareForDestruction
​https://bugs.webkit.org/show_bug.cgi?id=218455
<rdar://problem/70963191>

Reviewed by Geoffrey Garen.

Document::willBeRemovedFromFrame() may have the same PaintWorkletGlobalScope instance
more than once in its m_paintWorkletGlobalScopes HashMap, under different keys. As a
result, it may call PaintWorkletGlobalScope::prepareForDestruction() more than once
on the same instance. This was causing issues because
EventLoopTaskGroup::markAsReadyToStop(), when called the second time, would move the
state from Stopped and back to ReadyToStop, which is unexpected.

To address the issue, EventLoopTaskGroup::markAsReadyToStop() now returns early if
the state is "Stopped". Also, I added a boolean check in PaintWorkletGlobalScope's
prepareForDestruction() to make sure we only do the work once per instance.

No new tests, covered by existing tests.

• dom/EventLoop.h:

(WebCore::EventLoopTaskGroup::markAsReadyToStop):

• worklets/PaintWorkletGlobalScope.h:

2:07 PM Changeset in webkit [269274] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Unreviewed, reverting r269245.

3 LFC tests asserting in
WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree

Reverted changeset:

"[LFC][IFC] Empty lines stay empty even when the imaginary
strut is present"
​https://bugs.webkit.org/show_bug.cgi?id=218420
​https://trac.webkit.org/changeset/269245

1:53 PM Changeset in webkit [269273] by James Savage

• 2 edits in trunk/Source/WebKit

Changes to SWIFT_MODULE_ONLY_ARCHS
​https://bugs.webkit.org/show_bug.cgi?id=218404

Reviewed by Tim Horton.

• SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig: Simplify how

we specify these options.

1:43 PM Changeset in webkit [269272] by Antti Koivisto

• 11 edits in trunk

[LFC][Integration] RenderText::absoluteQuadsForRange should use iterator
​https://bugs.webkit.org/show_bug.cgi?id=218444

Reviewed by Zalan Bujtas.

Source/WebCore:

Add the required iterator support and convert absoluteQuadsForRange to use it.
This eliminates ensureLineBoxes from two places.

• layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::PathTextRun::isSelectable const):
(WebCore::LayoutIntegration::PathTextRun::selectionRect const):

• layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

(WebCore::LayoutIntegration::RunIteratorLegacyPath::isSelectable const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::selectionRect const):

• layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::offsetForPosition const):
(WebCore::LayoutIntegration::RunIteratorModernPath::isSelectable const):
(WebCore::LayoutIntegration::RunIteratorModernPath::selectionRect const):
(WebCore::LayoutIntegration::RunIteratorModernPath::clampedOffset const):
(WebCore::LayoutIntegration::RunIteratorModernPath::createTextRun const):

• rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange const):
(WebCore::localQuadForTextRun):
(WebCore::RenderText::absoluteQuadsForRange const):

• rendering/RenderTextLineBoxes.cpp:

(WebCore::localQuadForTextBox): Deleted.
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange const): Deleted.
(WebCore::RenderTextLineBoxes::absoluteRectsForRange const): Deleted.

• rendering/RenderTextLineBoxes.h:

LayoutTests:

• fast/dom/Range/getBoundingClientRect-expected.txt:
• fast/dom/Range/getBoundingClientRect.html:

On legacy path <br> y position is miscomputed affecting getBoundingClientRect().
Update the test to match the new behavior. Results now match Firefox and Chrome.

1:21 PM Changeset in webkit [269271] by Chris Dumez

• 5 edits in trunk

[ macOS ] webaudio/OfflineAudioContext/onstatechange.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217543
<rdar://problem/70160122>

Reviewed by Alex Christensen.

Source/WebCore:

No new tests, unskipped existing test.

• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::startRendering):
After offline rendering on the audio thread and we go back to the main thread, make sure we queue a task of the
event loop to fire the statechange and completion events. We were previously failing to do so and that meant
that the ordering with other main thread events (which were queued on the event loop) was not always correct.

LayoutTests:

• platform/mac/TestExpectations:

Unskip test that should no longer be flaky.

• webaudio/OfflineAudioContext/onstatechange-expected.txt:

Rebaseline test now that the order of the promise resolution and the statechange event have changed.
Note that the new ordering is consistent with both Chrome and Firefox.

1:17 PM Changeset in webkit [269270] by Diego Pino Garcia

• 1 edit
  1 delete in trunk/LayoutTests

[WPE] Unreviewed test gardening. Remove outdated baselines no longer necessary after r269104.

• platform/wpe/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Removed.

12:55 PM Changeset in webkit [269269] by ddkilzer@apple.com

• 6 edits in trunk

Sort Xcode project file

Source/bmalloc:

• bmalloc.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:

Tools:

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

12:31 PM Changeset in webkit [269268] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, skip imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html on mac-arm64 only.

Sadly, there is no way to land a mac-arm64 specific baseline yet so we have to mark the test as failing on this platform, even though it
is actually passing (with slightly different values).

• platform/mac/TestExpectations:

12:17 PM Changeset in webkit [269267] by Alan Coon

• 1 copy in tags/Safari-611.1.4.0.1

Tag Safari-611.1.4.0.1.

12:14 PM Changeset in webkit [269266] by Alan Coon

• 2 edits in branches/safari-611.1.4.0-branch/Source/WebCore

Cherry-pick r269206. rdar://problem/70730895

Further lessen reliance on VPATH in WebCore/DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=218378
<rdar://problem/70730895>

Reviewed by Darin Adler.

Bug 217696 updated WebCore/DerivedSources.make to rely less on VPATH
and make more use of explicit partial or full paths. The solution
there, however, did not go far enough, and led to failures when
building WebKit for Safari Tech Preview and using old SDKs that
contains files that have since been "upstreamed" into WebKit. Address
this problem by taking further control of how DerivedSources.make
finds needed files instead of using the VPATH mechanism.

No new tests -- this is a build fix.

• DerivedSources.make:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [269265] by Alan Coon

• 8 edits in branches/safari-611.1.4.0-branch/Source

Versioning.

WebKit-7611.1.4.0.1

11:56 AM Changeset in webkit [269264] by Diego Pino Garcia

• 6 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines of several tests failing.

• platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Needs update after r269224.
• platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.txt: Needs update after r269214.
• platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.png: Needs update after r269214.
• platform/gtk/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt: Needs update after r269238.
• platform/gtk/tables/mozilla/bugs/bug28928-expected.txt: Needs update after r269238.

11:46 AM Changeset in webkit [269263] by Aditya Keerthi

• 3 edits in trunk/Source/WebKit

[iOS] Link Contacts.framework during build
​https://bugs.webkit.org/show_bug.cgi?id=218289
<rdar://problem/70770410>

Reviewed by Andy Estes.

Contacts.framework is currrently soft linked in PaymentAuthorizationPresenter.
Soft linking is generally discouraged, since it requires running the linker
at runtime, leading to an unwanted performance cost. By normally linking
the framework, the linkage is declared at build time, which enables running
the linker at build/update/install time and avoiding the runtime cost.

Unfortunately, we still have to soft link the framework on macOS, to avoid
introducing a dependency cycle. Upward linking is not an option, since the
Contacts framework does not implement InstallAPI.

The SOFT_LINK_FRAMEWORK macro has been kept in PaymentAuthorizationPresenter
to avoid introducing additional #ifs. This should be fine to keep on iOS,
since the framework will already loaded in the address space, and the call
to dlopen() should be much less expensive.

• Configurations/WebKit.xcconfig:
• Platform/cocoa/PaymentAuthorizationPresenter.mm:

11:45 AM Changeset in webkit [269262] by Alan Bujtas

• 3 edits in trunk/LayoutTests

[LFC] Do not [ ImageOnlyFailure ] all the tests in fast/layoutformattingcontext
​https://bugs.webkit.org/show_bug.cgi?id=218446

Many tests pass now.

Reviewed by Simon Fraser.

• TestExpectations:
• platform/mac-wk2/TestExpectations:

11:21 AM Changeset in webkit [269261] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Only upload to S3 when running on ews-build.webkit.org (follow-up fix for unit-test).
​https://bugs.webkit.org/show_bug.cgi?id=218439

Unreviewed follow-up fix.

• CISupport/ews-build/steps_unittest.py: Set CURRENT_HOSTNAME to EWS_BUILD_HOSTNAME during TestTransferToS3 unit-tests,

restore it in tearDown so that it doesn't affect any other unit-test.

11:20 AM Changeset in webkit [269260] by Alan Coon

• 4 edits in branches/safari-610-branch

Cherry-pick r268199. rdar://problem/70952726

Crash under WebKit::WebProcessCache::clear()
​https://bugs.webkit.org/show_bug.cgi?id=217480

Reviewed by Geoffrey Garen.

Source/WebKit:

Protect |process| in the responsiveness check lambda in WebProcessCache::addProcessIfPossible().
If we fail to do so and WebProcessCache::clear() gets called while the responsiveness check is
pending, the WebProcessProxy destructor may get called while clear() clears m_pendingAddRequests,
which would resolve the responsiveness check with responsive=false, and cause the lambda to
try and remove the entry from m_pendingAddRequests (while clear() is clearing it).

• UIProcess/WebProcessCache.cpp: (WebKit::WebProcessCache::addProcessIfPossible):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [269259] by Alan Coon

• 1 edit in branches/safari-610-branch/Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm

Apply patch. rdar://problem/70952670

Cherry-pick part of r268577 to branch.

11:20 AM Changeset in webkit [269258] by Alan Coon

• 1 edit
  2 adds in branches/safari-610-branch

Apply patch. rdar://problem/70733358

11:13 AM Changeset in webkit [269257] by Chris Dumez

• 2 edits in trunk/LayoutTests

REGRESSION (r268897): [macOS WK1] inspector/cpu-profiler/threads.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=218253
<rdar://problem/70732755>

Reviewed by Geoffrey Garen.

Check the thread name to identify the 2 worker threads. This is needed so that worklet thread are
not identified as worker threads after r268897.

• inspector/cpu-profiler/threads.html:

11:01 AM Changeset in webkit [269256] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Crash under ProcessThrottler::setAssertionType()
​https://bugs.webkit.org/show_bug.cgi?id=218448
<rdar://problem/67419221>

Reviewed by Geoffrey Garen.

A ProcessThrottler object is owned by its associated AuxiliaryProcessProxy. The crash was happening
in ProcessThrottler::setAssertionType(), we would replace m_assertion with a new "Suspended"
assertion and then crash on the next line when using m_assertion. The reason we crash is that
when we replaced m_assertion with a new assertion, the destruction of the previous assertion
caused the UIProcess's background task to get released (because this was the last non-suspended
process assertion). When we release the UIProcess' background task, we call
WebProcessPool::notifyProcessPoolsApplicationIsAboutToSuspend(), which destroys non-critical
WebProcesses (e.g. WebProcesses in the back/forward cache), which in turns destroy their
ProcessThrottler. As a result, when replacing m_assertion, the ProcessAssertion may get
destroyed, which is why we would crash on the next line when trying to use m_assertion.

To address the issue, we now release the UIProcess's background task asynchronously when
releasing the last non-suspended ProcessAssertion, making sure we still need to release
the assertion beforehand. This has 2 benefits:

• The ProcessThrottler can no longer get destroyed synchronously when releasing its ProcessAssertion.
• In the case where the ProcessThrottler replaces a foreground assertion with a background assertion (or vice-versa) and this is the last non-suspended assertion, this avoids unnecessarily releasing and retaking the UIProcess's background task. This also avoids killing non-critical processes unnecessarily.

• UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):

11:01 AM Changeset in webkit [269255] by Alan Coon

• 1 copy in branches/safari-611.1.4.0-branch

New branch.

10:59 AM Changeset in webkit [269254] by Brent Fulgham

• 4 edits in trunk/Source/WebKit

[macOS] Remove unneeded shmem access to ColorSync
​https://bugs.webkit.org/show_bug.cgi?id=218395
<rdar://problem/70354916>

Reviewed by Per Arne Vollan.

ColorSync on macOS has not used shared memory since Mac OS X 10.7, and our sandbox
should not have this access. Removing this unused shared memory capability.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

10:53 AM Changeset in webkit [269253] by Darin Adler

• 22 edits
  6 adds in trunk

Start removing functions that implicitly use composed tree
​https://bugs.webkit.org/show_bug.cgi?id=218424

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/rangeContainsNode.html

fast/dom/rangeContainsRange.html
fast/dom/treeOrder.html

Ryosuke pointed out that most clients should not be using the composed tree, so this
is a step in work to make the use of the composed tree explicit. After that we can
more easily find and correct call sites where use of the composed tree is incorrect.

Likely that most or all cases of treeOrder<ComposedTree> can be changed to just
treeOrder and contains<ComposedTree> to just contains; will do those in follow-ups.

• Modules/highlight/Highlight.cpp:

(WebCore::repaintRange): Simplified code to use boundary points, and changed to use
treeOrder<ComposedTree>.

• dom/AbstractRange.h: Export makeSimpleRange so it can be used in Internals.
• dom/AbstractRange.idl: Export the class so it can be used in Internals.

• dom/Node.cpp:

(WebCore::parent<ShadowIncludingTree>): Added.
(WebCore::treeOrderForTesting): Added.
(WebCore::documentOrder): Deleted.

• dom/Node.h: Updated for the above.

• dom/RadioButtonGroups.cpp:

(WebCore::RadioButtonGroup::members const): Use treeOrder<ComposedTree>.

• dom/SimpleRange.cpp:

(WebCore::contains): Removed a couple contains functions that implicitly use
composed tree.
(WebCore::containsForTesting): Added.

• dom/SimpleRange.h: Updated for the above. Should also make contains<Tree> the

default and remove the <Tree> at all call sites, but it's safer to do that in a
separate patch after this is landed and builds on all platforms.

• editing/Editing.cpp:

(WebCore::isNodeVisiblyContainedWithin): Use contains<ComposedTree>.

• page/DragController.cpp:

(WebCore::DragController::draggableElement const): Ditto.

• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Ditto. Note that this has a call to
isDescendantOf right next to it, which does not use the composed tree.

• page/Page.cpp:

(WebCore::Page::findTextMatches): Use treeOrder<ComposedTree>.
(WebCore::replaceRanges): Ditto.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
Use contains<ComposedTree>.

• testing/Internals.cpp:

(WebCore::string): Added.
(WebCore::convertType): Added.
(WebCore::Internals::treeOrder): Added.
(WebCore::Internals::rangeContainsNode): Added.
(WebCore::Internals::rangeContainsRange): Added.

• testing/Internals.h: Updated for added functions above.
• testing/Internals.idl: Ditto. These functions were tested in a

TestWebKitAPI test, but we plan to move those types of tests to
internals-based tests instead.

Source/WebKit:

• WebProcess/WebPage/glib/WebPageGLib.cpp:

(WebKit::WebPage::getPlatformEditorState const): Use contains<ComposedTree>.

Tools:

• TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Moved the tests of documentOrder

for two nodes and contains for range/range or range/node into internals-based tests
in the LayoutTests directory. Eventually we'll move the rest of these tests, too.

LayoutTests:

• fast/dom/rangeContainsNode-expected.txt: Added.
• fast/dom/rangeContainsNode.html: Added.
• fast/dom/rangeContainsRange-expected.txt: Added.
• fast/dom/rangeContainsRange.html: Added.
• fast/dom/treeOrder-expected.txt: Added.
• fast/dom/treeOrder.html: Added.

These tests were formerly part of TestWebKitAPI, although treeOrder was named documentOrder.
Moving to internals-style tests at Ryosuke's suggestion since these are not something exposed
as API or even SPI.

10:35 AM Changeset in webkit [269252] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Remove compiler warning in LLIntData.cpp
​https://bugs.webkit.org/show_bug.cgi?id=218443

Patch by Xan Lopez <Xan Lopez> on 2020-11-02
Reviewed by Mark Lam.

Fix compiler warning by casting a scoped enum to its underlying
type. Not allowing implicit type conversions is the whole point of
scoped enums.

• interpreter/CallFrame.h: remove underlying type specifier, since

we are using the default anyway ('int').

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions): cast the scoped enum to its
underlying type.

10:11 AM Changeset in webkit [269251] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

Fix link error with WebKit.framework

Undefined symbols for architecture x86_64:

"JSC::GenericTypedArrayView<JSC::Uint8Adaptor>::create(WTF::RefPtr<JSC::ArrayBuffer, WTF::RawPtrTraits<JSC::ArrayBuffer>, WTF::DefaultRefDerefTraits<JSC::ArrayBuffer> >&&, unsigned int, unsigned int)", referenced from:

WebKit::convertToUint8Array(IPC::SharedBufferCopy&&) in UnifiedSource7.o

ld: symbol(s) not found for architecture x86_64

• GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
• Include <JavaScriptCore/GenericTypedArrayViewInlines.h> to fix linker error with some builds of WebKit.
• See also WebProcess/GPU/media/RemoteLegacyCDMSession.cpp.

9:56 AM Changeset in webkit [269250] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.3.7

9:23 AM Changeset in webkit [269249] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Don't fail the build on S3 upload failure
​https://bugs.webkit.org/show_bug.cgi?id=218438

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-02
Reviewed by Aakash Jain.

This allows buildbots to keep going even when S3 is down. Using
S3 is not strictly necessary, as the built product can also be
downloaded from the buildbot server.

Patch-by: ​aakash_jain@apple.com

• CISupport/ews-build/steps.py:

(CompileWebKit.evaluateCommand):
(TransferToS3):
(TransferToS3.finished):

8:59 AM Changeset in webkit [269248] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Only upload to S3 when running on ews-build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=218439

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-02
Reviewed by Aakash Jain.

Uploading to S3 is inconvenient for testing instances, so only run this
step if we're executing on ews-build.webkit.org. Otherwise, transfer the
file through the buildbot server.

Patch-by: ​aakash_jain@apple.com

• CISupport/ews-build/steps.py:

(TransferToS3.doStepIf):

7:54 AM Changeset in webkit [269247] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests/imported/w3c

Update baselines of tests failing after WPT resync

Unreviewed test gardening.

These tests are failing in several platforms (iOS, Mac, GTK, WPE, ...) with the same diff. Thus, the general expectations file is updated.

• web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-invalid-expected.txt: Needs update after r269187.
• web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt: Needs update after r269235.

6:59 AM Changeset in webkit [269246] by commit-queue@webkit.org

• 9 edits in trunk

[GLIB] REGRESSION(r269144) imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=218358

Patch by Martin Robinson <​mrobinson@igalia.com> on 2020-11-02
Reviewed by Simon Fraser.

Source/WebCore:

Finish some missing pieces of exposing scroll-margin when ENABLE_SCROLL_SNAP is off.
This allows non-scroll-snap ports to use scroll-margin.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle): Move scroll margin code
out of the ENABLE_SCROLL_SNAP block.

• css/CSSProperties.json: Remove ENABLE_SCROLL_SNAP requirement for scroll-margin properties.
• css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const): Move scroll-margin code out of ENABLE_SCROLL_MARGIN block.
(WebCore::StyleProperties::asText const): Ditto.

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue): Ditto.
(WebCore::CSSPropertyParser::parseShorthand): Ditto.

LayoutTests:

• platform/glib/TestExpectations: Mark test as passing.
• platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Update expectations.
• platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

6:12 AM Changeset in webkit [269245] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Empty lines stay empty even when the imaginary strut is present
​https://bugs.webkit.org/show_bug.cgi?id=218420

Reviewed by Antti Koivisto.

Use the more correct runs.isEmpty() check to decide whether the root inline box should stay empty.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

12:35 AM Changeset in webkit [269244] by youenn@apple.com

• 19 edits
  1 add in trunk/Source

Stop sending origins from WebProcess to UIProcess for getUserMedia requests
​https://bugs.webkit.org/show_bug.cgi?id=218192

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior, move UserMediaRequestIdentifier in its own header.
Covered by existing tests.

• Headers.cmake:
• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::userMediaDocumentOrigin const): Deleted.
(WebCore::UserMediaRequest::topLevelDocumentOrigin const): Deleted.

• Modules/mediastream/UserMediaRequest.h:
• Modules/mediastream/UserMediaRequestIdentifier.h:
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Pass directly a UserMediaRequestIdentifier through IPC.
Stop passing origins from IPC and instead compute them from UIProcess side.

• Scripts/webkit/messages.py:
• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::denyRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::grantRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionInvalidRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionValidRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:
• UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy):

• UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::create):
(WebKit::UserMediaPermissionRequestProxy::userMediaID const):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
(WebKit::WebPageProxy::enumerateMediaDevicesForFrame):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::sendUserMediaRequest):
(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManager::enumerateMediaDevices):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted):
(WebKit::WebPage::userMediaAccessWasDenied):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

12:32 AM Changeset in webkit [269243] by youenn@apple.com

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Set vpcC box for hardware WebRTC VP9 decoder
​https://bugs.webkit.org/show_bug.cgi?id=218337

Reviewed by Eric Carlson.

Hardware VP9 decoder code path requires vpcC box information.
Provide it as part of the video format.
Initialize the vpcC box with a zeroed buffer.

Make sure WebKitVP9Decoder is able to handle dynamically 10 bits or 8 bits frames.

• Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

(webrtc::createWebKitVP9Decoder):
(webrtc::startVP9DecoderSession):
(webrtc::WebKitVP9DecoderReceiver::initializeFromFormatDescription):
(webrtc::WebKitVP9DecoderReceiver::pixelBufferPool):
(webrtc::WebKitVP9DecoderReceiver::Decoded):

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:

(-[RTCVideoDecoderVTBVP9 decodeData:size:timeStamp:]):
(-[RTCVideoDecoderVTBVP9 resetDecompressionSession]):

Nov 1, 2020:

7:50 PM Changeset in webkit [269242] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION (r252689): box-shadow with inset and negative spread renders incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=209930

Patch by Mason Xiao <​me@masonx.ca> on 2020-11-01
Reviewed by Simon Fraser.

Source/WebCore:

r252689 introduced a typo when refactoring the calculation of xOffset.
Instead of subtracting the shadowSpread, it was added.
This caused issues when the shadowSpread was greater than approximately half of the enclosing element's width.

Test: fast/box-shadow/negative-inset-box-shadow.html

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow): Change sign of shadowSpread in xOffset calculation for inset

LayoutTests:

• fast/box-shadow/negative-inset-box-shadow-expected.html: Added.
• fast/box-shadow/negative-inset-box-shadow.html: Added.

6:49 PM Changeset in webkit [269241] by Diego Pino Garcia

• 3 edits
  3 adds in trunk/LayoutTests

Emit baselines for WPT css-sizing/aspect-ratio/quirks-mode* tests after resync in r269187

Unreviewed test gardening.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001-expected.txt: Added.
• web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-002-expected.txt: Added.
• web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-003-expected.txt: Added.

LayoutTests:

• TestExpectations:

5:43 PM Changeset in webkit [269240] by Diego Pino Garcia

• 3 edits
  2 copies
  1 delete in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening. Update baselines of WPT test 'html/dom/idlharness' after r269214.

• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Renamed from LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:

5:39 PM Changeset in webkit [269239] by Simon Fraser

• 7 edits
  1 copy in trunk/Source/WebCore

[LFC Display] Pass deviceScaleFactor around with GraphicsContext at paint time
​https://bugs.webkit.org/show_bug.cgi?id=218423

Reviewed by Zalan Bujtas.

Border painting code will need to use deviceScaleFactor at paint time, so make a small
struct that bundles GraphicsContext& and deviceScaleFactor together, and pass that to
paint functions.

• WebCore.xcodeproj/project.pbxproj:
• display/DisplayLayerController.cpp:

(WebCore::Display::LayerController::RootLayerClient::paintContents):

• display/css/DisplayBoxPainter.cpp:

(WebCore::Display::BoxPainter::paintFillLayer):
(WebCore::Display::BoxPainter::paintBackgroundImages):
(WebCore::Display::BoxPainter::paintBoxDecorations):
(WebCore::Display::BoxPainter::paintBoxContent):
(WebCore::Display::BoxPainter::paintBox):

• display/css/DisplayBoxPainter.h:
• display/css/DisplayCSSPainter.cpp:

(WebCore::Display::CSSPainter::recursivePaintDescendants):
(WebCore::Display::CSSPainter::paintStackingContext):
(WebCore::Display::CSSPainter::paintTree):

• display/css/DisplayCSSPainter.h:
• display/css/DisplayPaintingContext.h: Copied from Source/WebCore/display/css/DisplayBoxPainter.h.

2:03 PM Changeset in webkit [269238] by Alan Bujtas

• 5 edits
  2 adds in trunk

[LegacyInlineLayout] Remove collapsible trailing whitespace when it is followed by a hard line break
​https://bugs.webkit.org/show_bug.cgi?id=216902
<rdar://problem/69812136>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt:

Source/WebCore:

Ignore collapsible trailing whitespace followed by hard linebreak while computing the preferred width.
Such content is input to the trimming logic, and it should be handled accordingly.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

LayoutTests:

• fast/text/trimmable-whitespace-followed-by-br-expected.html: Added.
• fast/text/trimmable-whitespace-followed-by-br.html: Added.

12:14 PM Changeset in webkit [269237] by commit-queue@webkit.org

• 7 edits in trunk

background-size should not accept negative values
​https://bugs.webkit.org/show_bug.cgi?id=183990

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-11-01
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

We now reject negative values for background-size. Update newly
passing test expectations to reflect this.

• web-platform-tests/css/css-backgrounds/parsing/background-size-computed-expected.txt:
• web-platform-tests/css/css-backgrounds/parsing/background-size-invalid-expected.txt:

Source/WebCore:

Reject negative background-size length-percentage values,
as these are explicitly disallowed by the spec.

​https://www.w3.org/TR/2017/CR-css-backgrounds-3-20171017/#the-background-size

Change is covered by existing tests that now pass.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeBackgroundSize): Reject negative length-percentage
values as is mandated by the spec.

LayoutTests:

We now reject negative background-size values. Update newly passing
test expectations to reflect this.

• TestExpectations:

12:09 PM Changeset in webkit [269236] by weinig@apple.com

• 345 edits in trunk

Remove remaining alternative preference setting mechanisms from LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=218417

Reviewed by Simon Fraser.

Source/WebKit:

Remove now unused bundle SPI that was only used by the WebKitTestRuner.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleOverrideBoolPreferenceForTestRunner): Deleted.
(WKBundleSetAllowUniversalAccessFromFileURLs): Deleted.
(WKBundleSetAllowFileAccessFromFileURLs): Deleted.
(WKBundleSetAllowStorageAccessFromFileURLS): Deleted.
(WKBundleSetMinimumLogicalFontSize): Deleted.
(WKBundleSetFrameFlatteningEnabled): Deleted.
(WKBundleSetJavaScriptCanAccessClipboard): Deleted.
(WKBundleSetPopupBlockingEnabled): Deleted.
(WKBundleSetAuthorAndUserStylesEnabled): Deleted.

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addOriginAccessAllowListEntry):
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Deleted.
(WebKit::InjectedBundle::setAllowUniversalAccessFromFileURLs): Deleted.
(WebKit::InjectedBundle::setAllowFileAccessFromFileURLs): Deleted.
(WebKit::InjectedBundle::setNeedsStorageAccessFromFileURLsQuirk): Deleted.
(WebKit::InjectedBundle::setMinimumLogicalFontSize): Deleted.
(WebKit::InjectedBundle::setFrameFlatteningEnabled): Deleted.
(WebKit::InjectedBundle::setAsyncFrameScrollingEnabled): Deleted.
(WebKit::InjectedBundle::setJavaScriptCanAccessClipboard): Deleted.
(WebKit::InjectedBundle::setPopupBlockingEnabled): Deleted.
(WebKit::InjectedBundle::setAuthorAndUserStylesEnabled): Deleted.

• WebProcess/InjectedBundle/InjectedBundle.h:

Source/WebKitLegacy/win:

• WebPreferenceKeysPrivate.h:

Update key to match cocoa WebKitLegacy for shared use by DumpRenderTree.

Tools:

Remove various one off solutions for setting preferences in WebKitTestRunner and DumpRenderTree
keeping only test header commands (which can be set without JS and can be in place before the
inital load) and internals.settings, which can be used when dynamic changing is required.

• DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::supportedUInt32WebPreferenceFeatures):
(WTR::TestOptions::defaults):

• DumpRenderTree/TestOptions.h:
• DumpRenderTree/TestRunner.cpp:

(setPagePausedCallback):
(TestRunner::staticFunctions):
(setAuthorAndUserStylesEnabledCallback): Deleted.
(setJavaScriptCanAccessClipboardCallback): Deleted.
(setXSSAuditorEnabledCallback): Deleted.
(setAllowUniversalAccessFromFileURLsCallback): Deleted.
(setAllowFileAccessFromFileURLsCallback): Deleted.
(setNeedsStorageAccessFromFileURLsQuirkCallback): Deleted.
(setTelephoneNumberParsingEnabledCallback): Deleted.
(setPopupBlockingEnabledCallback): Deleted.
(setPluginsEnabledCallback): Deleted.

• DumpRenderTree/TestRunner.h:
• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
(webPreferenceFeatureValue):
(setWebPreferencesForTestOptions):
(runTest):
(boolWebPreferenceFeatureValue): Deleted.
(shouldEnableDeveloperExtras): Deleted.

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setAuthorAndUserStylesEnabled): Deleted.
(TestRunner::setXSSAuditorEnabled): Deleted.
(TestRunner::setAllowUniversalAccessFromFileURLs): Deleted.
(TestRunner::setAllowFileAccessFromFileURLs): Deleted.
(TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Deleted.
(TestRunner::setPopupBlockingEnabled): Deleted.
(TestRunner::setPluginsEnabled): Deleted.
(TestRunner::setJavaScriptCanAccessClipboard): Deleted.
(TestRunner::setTelephoneNumberParsingEnabled): Deleted.
(TestRunner::setDeveloperExtrasEnabled): Deleted.

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):
(webPreferenceFeatureValue):
(setWebPreferencesForTestOptions):
(runTest):
(shouldEnableDeveloperExtras): Deleted.
(boolWebPreferenceFeatureValue): Deleted.

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setAuthorAndUserStylesEnabled): Deleted.
(TestRunner::setXSSAuditorEnabled): Deleted.
(TestRunner::setAllowUniversalAccessFromFileURLs): Deleted.
(TestRunner::setAllowFileAccessFromFileURLs): Deleted.
(TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Deleted.
(TestRunner::setPopupBlockingEnabled): Deleted.
(TestRunner::setPluginsEnabled): Deleted.
(TestRunner::setJavaScriptCanAccessClipboard): Deleted.
(TestRunner::setDeveloperExtrasEnabled): Deleted.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::overridePreference): Deleted.
(WTR::TestRunner::setXSSAuditorEnabled): Deleted.
(WTR::TestRunner::setMediaDevicesEnabled): Deleted.
(WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled): Deleted.
(WTR::TestRunner::setWebAPIStatisticsEnabled): Deleted.
(WTR::TestRunner::setModernMediaControlsEnabled): Deleted.
(WTR::TestRunner::setWebGL2Enabled): Deleted.
(WTR::TestRunner::setWritableStreamAPIEnabled): Deleted.
(WTR::TestRunner::setTransformStreamAPIEnabled): Deleted.
(WTR::TestRunner::setReadableByteStreamAPIEnabled): Deleted.
(WTR::TestRunner::setEncryptedMediaAPIEnabled): Deleted.
(WTR::TestRunner::setPictureInPictureAPIEnabled): Deleted.
(WTR::TestRunner::setGenericCueAPIEnabled): Deleted.
(WTR::TestRunner::setAllowUniversalAccessFromFileURLs): Deleted.
(WTR::TestRunner::setAllowFileAccessFromFileURLs): Deleted.
(WTR::TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Deleted.
(WTR::TestRunner::setPluginsEnabled): Deleted.
(WTR::TestRunner::setJavaScriptCanAccessClipboard): Deleted.
(WTR::TestRunner::setPopupBlockingEnabled): Deleted.
(WTR::TestRunner::setAuthorAndUserStylesEnabled): Deleted.
(WTR::TestRunner::setOffscreenCanvasEnabled): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

• WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::defaults):

LayoutTests:

Update tests to only rely on test header commands and internals.settings for
changing preferences to simplify test writing.

• editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes.html:
• editing/async-clipboard/clipboard-read-text-from-platform.html:
• editing/async-clipboard/clipboard-read-text-same-origin.html:
• editing/async-clipboard/clipboard-write-in-copy-event-handler-in-subframe.html:
• editing/async-clipboard/clipboard-write-in-copy-event-handler.html:
• editing/async-clipboard/clipboard-write-text-requires-user-gesture.html:
• editing/execCommand/clipboard-access-with-user-gesture.html:
• editing/execCommand/clipboard-access.html:
• fast/css/disabled-author-styles.html:
• fast/css/object-fit/object-fit-embed-expected.html:
• fast/css/object-fit/object-fit-embed.html:
• fast/css/object-position/object-position-embed.html:
• fast/events/before-unload-navigate-different-window.html:
• fast/events/before-unload-open-window.html:
• fast/events/ios/submit-form-target-blank-using-return-key.html:
• fast/events/open-window-from-another-frame.html:
• fast/events/popup-allowed-from-gesture-initiated-event.html:
• fast/events/popup-allowed-from-gesture-initiated-form-submit.html:
• fast/events/popup-blocked-from-fake-button-click.html:
• fast/events/popup-blocked-from-fake-focus.html:
• fast/events/popup-blocked-from-fake-user-gesture.html:
• fast/events/popup-blocked-from-history-reload.html:
• fast/events/popup-blocked-from-iframe-script.html:
• fast/events/popup-blocked-from-iframe-src.html:
• fast/events/popup-blocked-from-mousemove.html:
• fast/events/popup-blocked-from-sandboxed-frame-via-window-open-named-sibling-frame.html:
• fast/events/popup-blocked-from-sandboxed-frame-via-window-open-named-sibling-frame2.html:
• fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html:
• fast/events/popup-blocked-from-untrusted-mouse-click.html:
• fast/events/popup-blocked-from-window-open.html:
• fast/events/popup-blocked-to-post-blank.html:
• fast/events/popup-blocking-click-in-iframe.html:
• fast/events/popup-blocking-timers1.html:
• fast/events/popup-blocking-timers2.html:
• fast/events/popup-blocking-timers3.html:
• fast/events/popup-blocking-timers5.html:
• fast/events/popup-blocking-timers6.html:
• fast/events/popup-when-select-change.html:
• fast/files/file-reader-file-url.html:
• fast/files/file-reader-sandbox-iframe.html:
• fast/files/workers/inline-worker-via-blob-url.html:
• fast/forms/formtarget-attribute-button-html.html:
• fast/forms/formtarget-attribute-input-2.html:
• fast/forms/formtarget-attribute-input-html.html:
• fast/forms/xss-auditor-doesnt-crash-on-post-submit.html:
• fast/frames/resources/no-file-access-frame-1.html:
• fast/frames/xss-auditor-handles-file-urls.html:
• fast/images/embed-image.html:
• fast/images/move-image-to-new-document.html:
• fast/loader/url-selected-user-gesture.html:
• fast/replaced/border-radius-clip-content-edge.html:
• fast/replaced/outline-replaced-elements.html:
• fast/replaced/pdf-as-embed-with-no-mime-type-is-not-blank.html:
• fast/xmlhttprequest/xmlhttprequest-no-file-access.html:
• fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html:
• fullscreen/full-screen-request-rejected.html:
• fullscreen/full-screen-request-removed.html:
• fullscreen/full-screen-restrictions.html:
• http/tests/cookies/resources/cookie-utilities.js:
• http/tests/dom/window-open-about-blank-and-access-document.html:
• http/tests/dom/window-open-about-uppercase-blank-and-access-document.html:
• http/tests/dom/window-open-about-webkit-org-and-access-document-async-delegates.html:
• http/tests/dom/window-open-about-webkit-org-and-access-document.html:
• http/tests/download/convert-cached-load-to-download.html:
• http/tests/security/popup-blocked-from-fake-event.html:
• http/tests/security/popup-blocked-from-window-open.html:
• http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html:
• http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:
• http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html:
• http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event.html:
• http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html:
• http/tests/security/xssAuditor/anchor-url-dom-write-location.html:
• http/tests/security/xssAuditor/anchor-url-dom-write-location2.html:
• http/tests/security/xssAuditor/base-href-control-char.html:
• http/tests/security/xssAuditor/base-href-direct.html:
• http/tests/security/xssAuditor/base-href-null-char.html:
• http/tests/security/xssAuditor/base-href-safe.html:
• http/tests/security/xssAuditor/base-href-safe2.html:
• http/tests/security/xssAuditor/base-href-safe3.html:
• http/tests/security/xssAuditor/base-href-scheme-relative.html:
• http/tests/security/xssAuditor/base-href.html:
• http/tests/security/xssAuditor/block-does-not-leak-location.html:
• http/tests/security/xssAuditor/block-does-not-leak-referrer.html:
• http/tests/security/xssAuditor/block-does-not-leak-that-page-was-blocked-using-empty-data-url.html:
• http/tests/security/xssAuditor/cached-frame.html:
• http/tests/security/xssAuditor/cookie-injection.html:
• http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html:
• http/tests/security/xssAuditor/data-urls-work.html:
• http/tests/security/xssAuditor/dom-write-URL.html:
• http/tests/security/xssAuditor/dom-write-innerHTML.html:
• http/tests/security/xssAuditor/dom-write-location-dom-write-open-img-onerror.html:
• http/tests/security/xssAuditor/dom-write-location-inline-event.html:
• http/tests/security/xssAuditor/dom-write-location-javascript-URL.html:
• http/tests/security/xssAuditor/dom-write-location-open-img-onerror.html:
• http/tests/security/xssAuditor/dom-write-location.html:
• http/tests/security/xssAuditor/embed-tag-code-attribute-2.html:
• http/tests/security/xssAuditor/embed-tag-code-attribute.html:
• http/tests/security/xssAuditor/embed-tag-control-char.html:
• http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html:
• http/tests/security/xssAuditor/embed-tag-javascript-url.html:
• http/tests/security/xssAuditor/embed-tag-null-char.html:
• http/tests/security/xssAuditor/embed-tag.html:
• http/tests/security/xssAuditor/faux-script1.html:
• http/tests/security/xssAuditor/faux-script2.html:
• http/tests/security/xssAuditor/faux-script3.html:
• http/tests/security/xssAuditor/form-action.html:
• http/tests/security/xssAuditor/formaction-on-button.html:
• http/tests/security/xssAuditor/formaction-on-input.html:
• http/tests/security/xssAuditor/frameset-injection.html:
• http/tests/security/xssAuditor/full-block-base-href.html:
• http/tests/security/xssAuditor/full-block-get-from-iframe.html:
• http/tests/security/xssAuditor/full-block-iframe-javascript-url.html:
• http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
• http/tests/security/xssAuditor/full-block-javascript-link.html:
• http/tests/security/xssAuditor/full-block-link-onclick.html:
• http/tests/security/xssAuditor/full-block-object-tag.html:
• http/tests/security/xssAuditor/full-block-post-from-iframe.html:
• http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
• http/tests/security/xssAuditor/full-block-script-tag-with-source.html:
• http/tests/security/xssAuditor/full-block-script-tag.html:
• http/tests/security/xssAuditor/get-from-iframe.html:
• http/tests/security/xssAuditor/iframe-injection-allowed-2.html:
• http/tests/security/xssAuditor/iframe-injection-allowed-3.html:
• http/tests/security/xssAuditor/iframe-injection-allowed.html:
• http/tests/security/xssAuditor/iframe-injection.html:
• http/tests/security/xssAuditor/iframe-javascript-url-more-encoding.html:
• http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html:
• http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html:
• http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html:
• http/tests/security/xssAuditor/iframe-javascript-url-url-encoded.html:
• http/tests/security/xssAuditor/iframe-javascript-url.html:
• http/tests/security/xssAuditor/iframe-onload-GBK-char.html:
• http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html:
• http/tests/security/xssAuditor/iframe-srcdoc-property-blocked.html:
• http/tests/security/xssAuditor/iframe-srcdoc.html:
• http/tests/security/xssAuditor/img-onerror-GBK-char.html:
• http/tests/security/xssAuditor/img-onerror-accented-char.html:
• http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding.html:
• http/tests/security/xssAuditor/img-onerror-non-ASCII-char.html:
• http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding.html:
• http/tests/security/xssAuditor/img-onerror-non-ASCII-char2.html:
• http/tests/security/xssAuditor/img-onerror-tricky.html:
• http/tests/security/xssAuditor/img-tag-with-comma.html:
• http/tests/security/xssAuditor/inline-event-HTML-entities.html:
• http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html:
• http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html:
• http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html:
• http/tests/security/xssAuditor/javascript-link-HTML-entities.html:
• http/tests/security/xssAuditor/javascript-link-ampersand.html:
• http/tests/security/xssAuditor/javascript-link-control-char.html:
• http/tests/security/xssAuditor/javascript-link-control-char2.html:
• http/tests/security/xssAuditor/javascript-link-null-char.html:
• http/tests/security/xssAuditor/javascript-link-one-plus-one.html:
• http/tests/security/xssAuditor/javascript-link-safe.html:
• http/tests/security/xssAuditor/javascript-link-url-encoded.html:
• http/tests/security/xssAuditor/javascript-link.html:
• http/tests/security/xssAuditor/link-onclick-ampersand.html:
• http/tests/security/xssAuditor/link-onclick-control-char.html:
• http/tests/security/xssAuditor/link-onclick-entities.html:
• http/tests/security/xssAuditor/link-onclick-null-char.html:
• http/tests/security/xssAuditor/link-onclick.html:
• http/tests/security/xssAuditor/link-opens-new-window.html:
• http/tests/security/xssAuditor/malformed-HTML.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-1.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-2.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-3.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-4.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-5.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-6.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-7.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-8.html:
• http/tests/security/xssAuditor/malformed-xss-protection-header-9.html:
• http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html:
• http/tests/security/xssAuditor/meta-tag-http-refresh-x-frame-options-ignored.html:
• http/tests/security/xssAuditor/nested-dom-write-location-open-img-onerror.html:
• http/tests/security/xssAuditor/no-protection-script-tag.html:
• http/tests/security/xssAuditor/non-block-javascript-url-frame.html:
• http/tests/security/xssAuditor/object-embed-tag-control-char.html:
• http/tests/security/xssAuditor/object-embed-tag-null-char.html:
• http/tests/security/xssAuditor/object-embed-tag.html:
• http/tests/security/xssAuditor/object-src-inject.html:
• http/tests/security/xssAuditor/object-tag-javascript-url.html:
• http/tests/security/xssAuditor/object-tag.html:
• http/tests/security/xssAuditor/open-attribute-body.html:
• http/tests/security/xssAuditor/open-event-handler-iframe.html:
• http/tests/security/xssAuditor/open-iframe-src-01.html:
• http/tests/security/xssAuditor/open-iframe-src-02.html:
• http/tests/security/xssAuditor/open-iframe-src-03.html:
• http/tests/security/xssAuditor/open-script-src-01.html:
• http/tests/security/xssAuditor/open-script-src-02.html:
• http/tests/security/xssAuditor/open-script-src-03.html:
• http/tests/security/xssAuditor/open-script-src-04.html:
• http/tests/security/xssAuditor/post-from-iframe.html:
• http/tests/security/xssAuditor/property-escape-comment-01.html:
• http/tests/security/xssAuditor/property-escape-comment-02.html:
• http/tests/security/xssAuditor/property-escape-comment-03.html:
• http/tests/security/xssAuditor/property-escape-entity-01.html:
• http/tests/security/xssAuditor/property-escape-entity-02.html:
• http/tests/security/xssAuditor/property-escape-entity-03.html:
• http/tests/security/xssAuditor/property-escape-long.html:
• http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
• http/tests/security/xssAuditor/property-escape-noquotes.html:
• http/tests/security/xssAuditor/property-escape-quote-01.html:
• http/tests/security/xssAuditor/property-escape-quote-02.html:
• http/tests/security/xssAuditor/property-escape-quote-03.html:
• http/tests/security/xssAuditor/property-escape.html:
• http/tests/security/xssAuditor/property-inject.html:
• http/tests/security/xssAuditor/reflection-in-path.html:
• http/tests/security/xssAuditor/regress-167121.html:
• http/tests/security/xssAuditor/report-script-tag-and-do-not-follow-redirect-when-sending-report.html:
• http/tests/security/xssAuditor/report-script-tag-full-block-and-do-not-follow-redirect-when-sending-report.html:
• http/tests/security/xssAuditor/report-script-tag-full-block.html:
• http/tests/security/xssAuditor/report-script-tag-replace-state.html:
• http/tests/security/xssAuditor/report-script-tag.html:
• http/tests/security/xssAuditor/resources/base-href/base-href-safe2.html:
• http/tests/security/xssAuditor/resources/base-href/base-href-safe3.html:
• http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html:
• http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html:
• http/tests/security/xssAuditor/script-tag-Big5-char.html:
• http/tests/security/xssAuditor/script-tag-Big5-char2.html:
• http/tests/security/xssAuditor/script-tag-addslashes-backslash.html:
• http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html:
• http/tests/security/xssAuditor/script-tag-addslashes-null-char.html:
• http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html:
• http/tests/security/xssAuditor/script-tag-control-char.html:
• http/tests/security/xssAuditor/script-tag-convoluted.html:
• http/tests/security/xssAuditor/script-tag-entities.html:
• http/tests/security/xssAuditor/script-tag-expression-follows.html:
• http/tests/security/xssAuditor/script-tag-inside-svg-tag.html:
• http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html:
• http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html:
• http/tests/security/xssAuditor/script-tag-near-start.html:
• http/tests/security/xssAuditor/script-tag-null-char.html:
• http/tests/security/xssAuditor/script-tag-open-redirect.html:
• http/tests/security/xssAuditor/script-tag-post-control-char.html:
• http/tests/security/xssAuditor/script-tag-post-null-char.html:
• http/tests/security/xssAuditor/script-tag-post.html:
• http/tests/security/xssAuditor/script-tag-redirect.html:
• http/tests/security/xssAuditor/script-tag-safe.html:
• http/tests/security/xssAuditor/script-tag-safe2.html:
• http/tests/security/xssAuditor/script-tag-safe3.html:
• http/tests/security/xssAuditor/script-tag-safe4.html:
• http/tests/security/xssAuditor/script-tag-src-redirect-safe.html:
• http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html:
• http/tests/security/xssAuditor/script-tag-with-16bit-unicode.html:
• http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html:
• http/tests/security/xssAuditor/script-tag-with-16bit-unicode3.html:
• http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html:
• http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html:
• http/tests/security/xssAuditor/script-tag-with-actual-comma.html:
• http/tests/security/xssAuditor/script-tag-with-callbacks.html:
• http/tests/security/xssAuditor/script-tag-with-comma-01.html:
• http/tests/security/xssAuditor/script-tag-with-comma-02.html:
• http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html:
• http/tests/security/xssAuditor/script-tag-with-injected-comment.html:
• http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html:
• http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html:
• http/tests/security/xssAuditor/script-tag-with-source-control-char.html:
• http/tests/security/xssAuditor/script-tag-with-source-data-url.html:
• http/tests/security/xssAuditor/script-tag-with-source-data-url2.html:
• http/tests/security/xssAuditor/script-tag-with-source-data-url3.html:
• http/tests/security/xssAuditor/script-tag-with-source-data-url4.html:
• http/tests/security/xssAuditor/script-tag-with-source-data-url5.html:
• http/tests/security/xssAuditor/script-tag-with-source-double-quote.html:
• http/tests/security/xssAuditor/script-tag-with-source-entities.html:
• http/tests/security/xssAuditor/script-tag-with-source-no-quote.html:
• http/tests/security/xssAuditor/script-tag-with-source-null-char.html:
• http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html:
• http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html:
• http/tests/security/xssAuditor/script-tag-with-source-same-host.html:
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-01.html:
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-02.html:
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-03.html:
• http/tests/security/xssAuditor/script-tag-with-source.html:
• http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html:
• http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html:
• http/tests/security/xssAuditor/script-tag-with-trailing-comment.html:
• http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html:
• http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html:
• http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html:
• http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html:
• http/tests/security/xssAuditor/script-tag-with-trailing-script-and-urlencode.html:
• http/tests/security/xssAuditor/script-tag.html:
• http/tests/security/xssAuditor/svg-animate.html:
• http/tests/security/xssAuditor/svg-script-tag.html:
• http/tests/security/xssAuditor/window-open-without-url-should-not-assert.html:
• http/tests/security/xssAuditor/xss-filter-bypass-big5.html:
• http/tests/security/xssAuditor/xss-filter-bypass-long-string.html:
• http/tests/security/xssAuditor/xss-filter-bypass-sjis.html:
• http/tests/security/xssAuditor/xss-protection-parsing-01.html:
• http/tests/security/xssAuditor/xss-protection-parsing-02.html:
• http/tests/security/xssAuditor/xss-protection-parsing-03.html:
• http/tests/security/xssAuditor/xss-protection-parsing-04.html:
• http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture.html:
• http/tests/storageAccess/deny-without-prompt-preserves-gesture.html:
• http/tests/storageAccess/grant-with-prompt-preserves-gesture.html:
• http/tests/storageAccess/resources/request-storage-access-iframe-and-pop-window.html:
• http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html:
• http/tests/webAPIStatistics/font-load-data-collection.html:
• http/tests/webAPIStatistics/navigator-functions-accessed-data-collection.html:
• http/tests/webAPIStatistics/screen-functions-accessed-data-collection.html:
• imported/blink/fast/events/popup-forwarded-gesture.html:
• imported/blink/fast/workers/worker-shared-asm-buffer.html:
• platform/ios/ios/fast/text/data-detectors/phone-disabled.html:
• platform/ios/ios/fast/text/data-detectors/phone.html:
• platform/mac/plugins/disable-plugins.html:
• plugins/js-from-destroy.html:
• plugins/navigator-plugin-crash.html:
• plugins/navigator-plugins-disabled.html:
• plugins/plugin-initiate-popup-window.html:
• security/cannot-read-self-from-file.html:
• storage/domstorage/localstorage/blocked-file-access-permitted-by-quirk.html:
• storage/domstorage/localstorage/blocked-file-access.html:
• storage/domstorage/localstorage/file-can-access.html:
• storage/domstorage/sessionstorage/blocked-file-access.html:
• webrtc/datachannel/mdns-ice-candidates.html:
• webrtc/peerconnection-new-candidate-page-cache.html:

10:24 AM Changeset in webkit [269235] by Chris Dumez

• 243 edits
  30 copies
  1 move
  318 adds
  3 deletes in trunk/LayoutTests

Resync web-platform-tests/tools tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=218352

Reviewed by Sam Weinig.

Resync web-platform-tests/tools tests from upstream 5dbb0a3fa631ef73da0.

• web-platform-tests/tools/*: Updated.

9:57 AM Changeset in webkit [269234] by Karl Rackler

• 1 edit
  2 adds in trunk/LayoutTests

REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-of-multiline-input.html is a constant failure
rdar://70819245
Re-baseline for Catalina after r269174.

Unreviewed test gardening.

• platform/mac-catalina/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.

9:52 AM Changeset in webkit [269233] by Karl Rackler

• 1 edit
  1 delete in trunk/LayoutTests

REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-of-multiline-input.html is a constant failure
rdar://70819245
Re-baseline for Catalina after r269174. Capital letter in Input folder.

Unreviewed test gardening.

• platform/mac-catalina/editing/Input/reveal-caret-of-multiline-input-expected.txt: Removed.

8:41 AM Changeset in webkit [269232] by Chris Fleizach

• 4 edits in trunk/Source/WebCore

AX: Provide build workaround while isSystemVoice is not in all SDKs
​https://bugs.webkit.org/show_bug.cgi?id=218414

Reviewed by Tim Horton.

Source/WebCore:

• platform/ios/PlatformSpeechSynthesizerIOS.mm:

(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

Source/WebCore/PAL:

• pal/spi/cocoa/AXSpeechManagerSPI.h:

5:57 AM Changeset in webkit [269231] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] InlineLevelBox logical rect should only be accessed through LineBox
​https://bugs.webkit.org/show_bug.cgi?id=218418

Reviewed by Antti Koivisto.

InlineLevelBox logical rect is relative to the parent inline box. Calling InlineLevelBox::logicalRect
and expect a line relative rect is an easy mistake to make (and one I made myself).
Only the LineBuilder and the LineBox should really need access to the relative rect, others should
continue to use LineBox::logicalRectForInlineLevelBox.

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineLevelBox::logicalTop const):
(WebCore::Layout::LineBox::InlineLevelBox::logicalBottom const):
(WebCore::Layout::LineBox::InlineLevelBox::logicalLeft const):
(WebCore::Layout::LineBox::InlineLevelBox::logicalWidth const):
(WebCore::Layout::LineBox::InlineLevelBox::logicalHeight const):
(WebCore::Layout::LineBox::InlineLevelBox::logicalRect const): Deleted.

5:55 AM Changeset in webkit [269230] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Set the descent layout bounds for atomic inline level boxes
​https://bugs.webkit.org/show_bug.cgi?id=218421

Reviewed by Antti Koivisto.

In most cases the layout bounds descent is 0, but in case of inline-block (or inline table) the decent value may be greater than 0.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):