Timeline

Nov 3, 2020:

11:34 PM Changeset in webkit [269357] by graouts@webkit.org

• 9 edits
  1 add in trunk

align-items should be a discrete animatable property
​https://bugs.webkit.org/show_bug.cgi?id=218535
<rdar://problem/71012428>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

• web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• rendering/style/StyleSelfAlignmentData.cpp: Added.

(WebCore::operator<<):

• rendering/style/StyleSelfAlignmentData.h:

10:23 PM Changeset in webkit [269356] by Diego Pino Garcia

• 2 edits
  2 deletes in trunk/LayoutTests

[GTK] Unreviewed test gardening. Remove stale baselines of two mediastream tests.

Also update bug number of failing test.

• platform/gtk/TestExpectations:
• platform/gtk/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt: Removed.
• platform/gtk/fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt: Removed.

9:50 PM Changeset in webkit [269355] by Lauro Moura

• 2 edits in trunk/LayoutTests

[WPE] Gardening adClickAttribution failure

Unreviewed test gardening.

Also grouped some target-related entries together

• platform/wpe/TestExpectations:

8:59 PM Changeset in webkit [269354] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

Ignore order when parsing inset and color for box-shadow
​https://bugs.webkit.org/show_bug.cgi?id=182677

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-11-03
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update tests to pass now that we parse inset, a color, and the lengths
component of <shadow> values in any order.

​https://drafts.csswg.org/css-backgrounds/#typedef-shadow

• web-platform-tests/css/css-backgrounds/parsing/box-shadow-valid-expected.txt:

Source/WebCore:

According to the spec [1], box-shadow should allow the inset keyword,
a color, and the lengths component in any order. Our implementation
allowed only 2 out of the 4 possible orders; fix our parsing to
match the spec.

[1]: ​https://drafts.csswg.org/css-backgrounds/#typedef-shadow

Above description is (almost) a direct quote from <​cnardi@chromium.org>
who previously submitted a patch for this bug.

Change is covered by existing test

LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/box-shadow-valid.html

and new test

LayoutTests/fast/box-shadow/box-shadow-invalid-values.html

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeSingleShadow): Parse inset,
color, and lengths component of a single <shadow> in any order.

LayoutTests:

Add additional test coverage around rejecting invalid box-shadow
values (e.g. multiple colors, multiple insets, multiple lengths-components).

​https://drafts.csswg.org/css-backgrounds/#typedef-shadow

• LayoutTests/fast/box-shadow/box-shadow-invalid-values.html: Added.
• LayoutTests/fast/box-shadow/box-shadow-invalid-values-expected.txt: Added.

8:55 PM Changeset in webkit [269353] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for ARM64E debug build
​https://bugs.webkit.org/show_bug.cgi?id=218143

• runtime/JSCPtrTag.cpp:

(JSC::tagForPtr):

8:54 PM Changeset in webkit [269352] by Diego Pino Garcia

• 6 edits
  2 deletes in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update state of flaky crash tests that are actually failing.

Some tests were actually passing after removing or updating their baseline.

• platform/gtk/TestExpectations:
• platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: Removed.
• platform/gtk/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt: Removed.
• platform/gtk/media/controls-styling-strict-expected.txt:
• platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
• platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
• platform/gtk/media/video-aspect-ratio-expected.txt:

8:07 PM Changeset in webkit [269351] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][Integration] Rename Run::needsHyphen to hasHyphen
​https://bugs.webkit.org/show_bug.cgi?id=218541

Reviewed by Sam Weinig.

1. Integration uses the term "has" instead of "needs".
2. Runs will gain the hyphen character soon (when we introduce the concept of rendered content (vs. original content)).

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

• layout/integration/LayoutIntegrationRun.h:

(WebCore::LayoutIntegration::Run::TextContent::hasHyphen const):
(WebCore::LayoutIntegration::Run::TextContent::TextContent):
(WebCore::LayoutIntegration::Run::TextContent::needsHyphen const): Deleted.

• layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::hasHyphen const):

6:50 PM Changeset in webkit [269350] by sbarati@apple.com

• 4 edits
  1 add in trunk

Add back the removed assertion from r269338 and add a test
​https://bugs.webkit.org/show_bug.cgi?id=218543

Reviewed by Filip Pizlo.

JSTests:

• stress/bad-osr-exit-checkpoint-state-assertion-during-js-lock-destruction.js: Added.

(foo):
(let.a.get length):

Source/JavaScriptCore:

The assertion from r269338 was wrong in JSLock::willReleaseLock because
of our use of DropAllLocks. However, it is correct inside the topmost ~VMEntryScope.

• jsc.cpp:

(JSC_DEFINE_HOST_FUNCTION):

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::~VMEntryScope):

6:31 PM Changeset in webkit [269349] by ysuzuki@apple.com

• 48 edits
  1 add in trunk/Source

[JSC] Add JITCage support
​https://bugs.webkit.org/show_bug.cgi?id=218143

Reviewed by Saam Barati.

Source/JavaScriptCore:

Towards software verified JIT, this patch adds partial JIT-Caging support which cages JIT call / jumps in a certain format.
This is currently only enabled when internal SDK is enabled. And it is only enabled in ARM64E for now.
Currently, this patch does not have CSS JIT support. Subsequent patch will add it.
We ensured that JS2 and RAMification are neutral.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/JITOperationList.cpp:

(JSC::addPointers):
(JSC::JITOperationList::populatePointersInJavaScriptCoreForLLInt):

• assembler/JITOperationList.h:

(JSC::JITOperationList::map const):
(JSC::JITOperationList::assertIsHostFunction):
(JSC::JITOperationList::assertIsJITOperation):
(JSC::JITOperationList::contains const): Deleted.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::farJump):

• assembler/MacroAssemblerARM64E.h:

(JSC::MacroAssemblerARM64E::callTrustedPtr):
(JSC::MacroAssemblerARM64E::call):
(JSC::MacroAssemblerARM64E::callRegister):
(JSC::MacroAssemblerARM64E::farJumpRegister):
(JSC::MacroAssemblerARM64E::farJump):
(JSC::MacroAssemblerARM64E::ret):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::farJump):

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::farJump):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::farJump):

• bytecode/BytecodeList.rb:
• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::callerReturnPC):
(JSC::DFG::adjustAndJumpToTarget):

• dfg/DFGOSRExitCompilerCommon.h:
• jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::setJITEnabled):
(JSC::initializeJITPageReservation):

• jit/GPRInfo.h:
• jit/PolymorphicCallStubRoutine.cpp:

(JSC::PolymorphicCallNode::unlink):

• jit/ThunkGenerators.cpp:

(JSC::emitPointerValidation):

• llint/LLIntData.cpp:

(JSC::LLInt::initialize):

• llint/LLIntData.h:

(JSC::LLInt::getOpcode):
(JSC::LLInt::getOpcodeWide16):
(JSC::LLInt::getOpcodeWide32):
(JSC::LLInt::getCodePtr):
(JSC::LLInt::getWide16CodePtr):
(JSC::LLInt::getWide32CodePtr):
(JSC::LLInt::getCodeFunctionPtr):
(JSC::LLInt::getWide16CodeFunctionPtr):
(JSC::LLInt::getWide32CodeFunctionPtr):

• llint/LLIntEntrypoint.cpp:

(JSC::LLInt::entrypointTrampoline):
(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
(JSC::LLInt::setModuleProgramEntrypoint):
(JSC::LLInt::getHostCallReturnValueEntrypoint):
(JSC::LLInt::fuzzerReturnEarlyFromLoopHintEntrypoint):
(JSC::LLInt::genericReturnPointEntrypoint):

• llint/LLIntEntrypoint.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::commonCallEval):
(JSC::LLInt::dispatchToNextInstruction):

• llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::generateThunkWithJumpToPrologue):
(JSC::LLInt::generateThunkWithJumpToLLIntReturnPoint):
(JSC::LLInt::functionForCallEntryThunk):
(JSC::LLInt::functionForConstructEntryThunk):
(JSC::LLInt::functionForCallArityCheckThunk):
(JSC::LLInt::functionForConstructArityCheckThunk):
(JSC::LLInt::evalEntryThunk):
(JSC::LLInt::programEntryThunk):
(JSC::LLInt::moduleProgramEntryThunk):
(JSC::LLInt::wasmFunctionEntryThunk):
(JSC::LLInt::handleCatchThunk):
(JSC::LLInt::genericReturnPointThunk):
(JSC::LLInt::fuzzerReturnEarlyFromLoopHintThunk):
(JSC::LLInt::createJSGateThunk):
(JSC::LLInt::createWasmGateThunk):
(JSC::LLInt::createTailCallGate):
(JSC::LLInt::loopOSREntryGateThunk):
(JSC::LLInt::entryOSREntryGateThunk):
(JSC::LLInt::wasmOSREntryGateThunk):
(JSC::LLInt::exceptionHandlerGateThunk):
(JSC::LLInt::returnFromLLIntGateThunk):
(JSC::LLInt::tagGateThunk):
(JSC::LLInt::untagGateThunk):
(JSC::LLInt::jitCagePtrThunk):
(JSC::LLInt::normalOSRExitTrampolineThunk):
(JSC::LLInt::checkpointOSRExitTrampolineThunk):
(JSC::LLInt::checkpointOSRExitFromInlinedCallTrampolineThunk):
(JSC::LLInt::returnLocationThunk):

• llint/LLIntThunks.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• llint/WebAssembly.asm:
• offlineasm/arm64.rb:
• offlineasm/mips.rb:
• runtime/Gate.h: Added.
• runtime/JSCConfig.h:
• runtime/JSCPtrTag.cpp:

(JSC::tagForPtr):
(JSC::callerType):
(JSC::calleeType):

• runtime/JSCPtrTag.h:

(JSC::tagJSCCodePtrImpl):
(JSC::untagJSCCodePtrImpl):
(JSC::tagCodePtrWithStackPointerForJITCall):
(JSC::untagCodePtrWithStackPointerForJITCall):

• runtime/MatchResult.h:

(JSC::MatchResult::MatchResult):

• runtime/Options.cpp:

(JSC::disableAllJITOptions):
(JSC::canUseJITCage):

• runtime/OptionsList.h:
• wasm/WasmSlowPaths.cpp:
• yarr/YarrJIT.cpp:
• yarr/YarrJIT.h:

(JSC::Yarr::YarrCodeBlock::execute):

Source/WTF:

• wtf/OSAllocator.h:

(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::reallocateCommitted):

• wtf/PageReservation.h:

(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveWithGuardPages):
(WTF::PageReservation::reserveAndCommitWithGuardPages):
(WTF::PageReservation::PageReservation):

• wtf/PlatformEnable.h:
• wtf/PlatformUse.h:
• wtf/PtrTag.h:

(WTF::assertIsTaggedWith):
(WTF::tagCodePtrWithStackPointerForJITCall): Deleted.
(WTF::untagCodePtrWithStackPointerForJITCall): Deleted.

• wtf/posix/OSAllocatorPOSIX.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::reserveAndCommit):

• wtf/win/OSAllocatorWin.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::reserveAndCommit):

5:44 PM Changeset in webkit [269348] by sihui_liu@apple.com

• 38 edits
  11 copies
  11 adds in trunk

Set up basic infrastructure for SpeechRecognition
​https://bugs.webkit.org/show_bug.cgi?id=218216
<rdar://problem/70703788>

Reviewed by Youenn Fablet.

Source/WebCore:

Introduce SpeechRecognitionConnectionClient, SpeechRecognitionConnection and SpeechRecognitionServer.
SpeechRecognition is a SpeechRecognitionConnectionClient that can send SpeechRecognitionRequest to
SpeechRecognitionServer via SpeechRecognitionConnection. Currently we have one SpeechRecogntionConnection and
one SpeechRecogntionServer per page. SpeechRecognitionServer will be responsible for handling
SpeechRecognitionRequests, including audio capturing and hosting speech recognition engine, and that
implementation is not included in this patch.

Our current plan is put SpeechRecognitionServer in UI process (or GPU process when media code is all moved) and
keep SpeechRecognitionConnectionClient in web process.

Test: fast/speechrecognition/start-recognition-twice-exception.html

• Headers.cmake:
• Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::create):
(WebCore::SpeechRecognition::SpeechRecognition):
(WebCore::SpeechRecognition::startRecognition):
(WebCore::SpeechRecognition::stopRecognition):
(WebCore::SpeechRecognition::abortRecognition):
(WebCore::SpeechRecognition::didStart):
(WebCore::SpeechRecognition::didStartCapturingAudio):
(WebCore::SpeechRecognition::didStartCapturingSound):
(WebCore::SpeechRecognition::didStartCapturingSpeech):
(WebCore::SpeechRecognition::didStopCapturingSpeech):
(WebCore::SpeechRecognition::didStopCapturingSound):
(WebCore::SpeechRecognition::didStopCapturingAudio):
(WebCore::SpeechRecognition::didFindNoMatch):
(WebCore::SpeechRecognition::didReceiveResult):
(WebCore::SpeechRecognition::didError):
(WebCore::SpeechRecognition::didEnd):

• Modules/speech/SpeechRecognition.h:
• Modules/speech/SpeechRecognitionConnection.h: Added.

(WebCore::SpeechRecognitionConnection::~SpeechRecognitionConnection):

• Modules/speech/SpeechRecognitionConnectionClient.h: Added.

(WebCore::SpeechRecognitionConnectionClient::SpeechRecognitionConnectionClient):
(WebCore::SpeechRecognitionConnectionClient::identifier const):

• Modules/speech/SpeechRecognitionConnectionClientIdentifier.h: Added.
• Modules/speech/SpeechRecognitionError.h: Added.

(WebCore::SpeechRecognitionError::encode const):
(WebCore::SpeechRecognitionError::decode):

• Modules/speech/SpeechRecognitionErrorCode.h:
• Modules/speech/SpeechRecognitionRequest.cpp: Added.

(WebCore::SpeechRecognitionRequest::create):
(WebCore::SpeechRecognitionRequest::SpeechRecognitionRequest):

• Modules/speech/SpeechRecognitionRequest.h: Added.

(WebCore::SpeechRecognitionRequest::clientIdentifier const):
(WebCore::SpeechRecognitionRequest::lang const):
(WebCore::SpeechRecognitionRequest::continuous const):
(WebCore::SpeechRecognitionRequest::interimResults const):
(WebCore::SpeechRecognitionRequest::maxAlternatives const):

• Modules/speech/SpeechRecognitionRequestInfo.h: Added.

(WebCore::SpeechRecognitionRequestInfo::encode const):
(WebCore::SpeechRecognitionRequestInfo::decode):

• Modules/speech/SpeechRecognitionResultData.h: Added.

(WebCore::SpeechRecognitionAlternativeData::encode const):
(WebCore::SpeechRecognitionAlternativeData::decode):
(WebCore::SpeechRecognitionResultData::encode const):
(WebCore::SpeechRecognitionResultData::decode):

• Modules/speech/SpeechRecognitionResultList.h:
• Modules/speech/SpeechRecognitionUpdate.cpp: Added.

(WebCore::convertEnumerationToString):
(WebCore::SpeechRecognitionUpdate::create):
(WebCore::SpeechRecognitionUpdate::createError):
(WebCore::SpeechRecognitionUpdate::createResult):
(WebCore::SpeechRecognitionUpdate::SpeechRecognitionUpdate):
(WebCore::SpeechRecognitionUpdate::error const):
(WebCore::SpeechRecognitionUpdate::result const):

• Modules/speech/SpeechRecognitionUpdate.h: Added.

(WebCore::SpeechRecognitionUpdate::clientIdentifier const):
(WebCore::SpeechRecognitionUpdate::type const):
(WebCore::SpeechRecognitionUpdate::encode const):
(WebCore::SpeechRecognitionUpdate::decode):
(WTF::LogArgument<WebCore::SpeechRecognitionUpdateType>::toString):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/TaskSource.h:
• loader/EmptyClients.cpp:

(WebCore::pageConfigurationWithEmptyClients):

• page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::speechRecognitionConnection):

• page/Page.h:
• page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

• page/PageConfiguration.h:
• page/DummySpeechRecognitionProvider.h: Added.
• page/SpeechRecognitionProvider.h: Added.

Source/WebKit:

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Scripts/webkit/messages.py:
• Sources.txt:
• UIProcess/SpeechRecognitionServer.cpp: Added.

(WebKit::SpeechRecognitionServer::SpeechRecognitionServer):
(WebKit::SpeechRecognitionServer::start):
(WebKit::SpeechRecognitionServer::processNextPendingRequestIfNeeded):
(WebKit::SpeechRecognitionServer::stop):
(WebKit::SpeechRecognitionServer::abort):
(WebKit::SpeechRecognitionServer::removePendingRequest):
(WebKit::SpeechRecognitionServer::invalidate):
(WebKit::SpeechRecognitionServer::startPocessingRequest):
(WebKit::SpeechRecognitionServer::stopProcessingRequest):
(WebKit::SpeechRecognitionServer::messageSenderConnection const):
(WebKit::SpeechRecognitionServer::messageSenderDestinationID const):

• UIProcess/SpeechRecognitionServer.h: Added.
• UIProcess/SpeechRecognitionServer.messages.in: Added.
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createSpeechRecognitionServer):
(WebKit::WebProcessProxy::destroySpeechRecognitionServer):

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.cpp: Added.

(WebKit::WebSpeechRecognitionConnection::create):
(WebKit::WebSpeechRecognitionConnection::WebSpeechRecognitionConnection):
(WebKit::WebSpeechRecognitionConnection::~WebSpeechRecognitionConnection):
(WebKit::WebSpeechRecognitionConnection::registerClient):
(WebKit::WebSpeechRecognitionConnection::start):
(WebKit::WebSpeechRecognitionConnection::stop):
(WebKit::WebSpeechRecognitionConnection::abort):
(WebKit::WebSpeechRecognitionConnection::invalidate):
(WebKit::WebSpeechRecognitionConnection::didReceiveUpdate):
(WebKit::WebSpeechRecognitionConnection::messageSenderConnection const):
(WebKit::WebSpeechRecognitionConnection::messageSenderDestinationID const):

• WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.h: Added.
• WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.messages.in: Added.
• WebProcess/WebCoreSupport/WebSpeechRecognitionProvider.h: Added.
• WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::encodeArgument):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKitLegacy/win:

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::speechRecognitionEnabled):
(WebPreferences::setSpeechRecognitionEnabled):

• WebPreferences.h:
• WebView.cpp:

(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

LayoutTests:

• fast/speechrecognition/start-recognition-twice-exception-expected.txt: Added.
• fast/speechrecognition/start-recognition-twice-exception.html: Added.

5:13 PM Changeset in webkit [269347] by Keith Rollin

• 2 edits in trunk/Source/WebCore

Include path in generated IDL dependencies
​https://bugs.webkit.org/show_bug.cgi?id=218480

Reviewed by Brent Fulgham.

Changes in Bug 218378 and Bug 217696 have lessened the reliance on
VPATH to find files. This means that more places need to be explicit
about the locations of their files. This change updates
preprocess-idls.pl to include full- and partial-paths when generating
dependency information.

No new tests -- this is a build system change.

• bindings/scripts/preprocess-idls.pl:

(RemovePWD):

4:30 PM Changeset in webkit [269346] by Kocsen Chung

• 1 copy in tags/Safari-610.2.11.51.8

Tag Safari-610.2.11.51.8.

4:16 PM Changeset in webkit [269345] by Ryan Haddad

• 10 edits in trunk/LayoutTests

Unreviewed test gardening, rebaseline tests for Big Sur after r268958 and r268520.

• platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/listbox-width-change-expected.txt:
• platform/mac/fast/forms/option-text-clip-expected.txt:
• platform/mac/fast/forms/search-rtl-expected.txt:
• platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/text/indic-expected.txt:
• platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:

4:11 PM Changeset in webkit [269344] by dino@apple.com

• 7 edits in trunk/Source/WebCore

Link against the ANGLE Shared Library
​https://bugs.webkit.org/show_bug.cgi?id=218539
<rdar://problem/69062211>

Reviewed by Tim Horton.

Weak link against libANGLE-shared.dylib.

• Configurations/WebCore.xcconfig:
• Configurations/WebCoreTestSupport.xcconfig:
• Sources.txt: Stop compiling ANGLEWebKitBridge.
• SourcesGTK.txt:
• SourcesWPE.txt:
• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::isANGLEAvailable): Add a helper to check if ANGLE loaded properly.
(WebCore::GraphicsContextGLOpenGL::create):

4:03 PM Changeset in webkit [269343] by ggaren@apple.com

• 48 edits in trunk/Source

Drop most uses of the phrase 'neuter' from the tree
​https://bugs.webkit.org/show_bug.cgi?id=218536

Reviewed by Tim Horton.

In ArrayBuffer use cases, the spec has gone with "detached".

In other cases, I picked something.

Source/JavaScriptCore:

• JavaScriptCore.order:
• builtins/ArrayIteratorPrototype.js:

(next):

• builtins/BuiltinNames.h:
• builtins/TypedArrayPrototype.js:

(fill):
(globalPrivate.typedArrayElementCompare):

• bytecode/LinkTimeConstant.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckDetached):
(JSC::DFG::SpeculativeJIT::jumpForTypedArrayIsDetachedIfOutOfBounds):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileCheckNeutered): Deleted.
(JSC::DFG::SpeculativeJIT::jumpForTypedArrayIsNeuteredIfOutOfBounds): Deleted.

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckDetached):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::speculateTypedArrayIsNotDetached):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckNeutered): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::speculateTypedArrayIsNotNeutered): Deleted.

• runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBuffer::transferTo):
(JSC::ArrayBuffer::detach):
(JSC::ArrayBuffer::notifyDetaching):
(JSC::ArrayBuffer::neuter): Deleted.
(JSC::ArrayBuffer::notifyNeutering): Deleted.

• runtime/ArrayBuffer.h:

(JSC::ArrayBuffer::isDetached):
(JSC::ArrayBuffer::detachingWatchpointSet):
(JSC::ArrayBuffer::isNeutered): Deleted.
(JSC::ArrayBuffer::neuteringWatchpointSet): Deleted.

• runtime/ArrayBufferView.cpp:

(JSC::ArrayBufferView::ArrayBufferView):
(JSC::ArrayBufferView::~ArrayBufferView):
(JSC::ArrayBufferView::setDetachable):
(JSC::ArrayBufferView::setNeuterable): Deleted.

• runtime/ArrayBufferView.h:

(JSC::ArrayBufferView::isDetached const):
(JSC::ArrayBufferView::possiblySharedBuffer const):
(JSC::ArrayBufferView::isShared const):
(JSC::ArrayBufferView::baseAddress const):
(JSC::ArrayBufferView::byteOffset const):
(JSC::ArrayBufferView::isDetachable const):
(JSC::ArrayBufferView::isNeutered const): Deleted.
(JSC::ArrayBufferView::isNeuterable const): Deleted.

• runtime/GenericTypedArrayView.h:
• runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::detach):
(JSC::JSArrayBufferView::neuter): Deleted.

• runtime/JSArrayBufferView.h:

(JSC::JSArrayBufferView::isDetached):
(JSC::JSArrayBufferView::isNeutered): Deleted.

• runtime/JSDataView.cpp:

(JSC::JSDataView::create):

• runtime/JSDataViewPrototype.cpp:

(JSC::getData):
(JSC::setData):
(JSC::JSC_DEFINE_HOST_FUNCTION):

• runtime/JSGenericTypedArrayView.h:
• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::setWithSpecificType):
(JSC::JSGenericTypedArrayView<Adaptor>::set):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):
(JSC::JSGenericTypedArrayView<Adaptor>::deletePropertyByIndex):

• runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::speciesConstruct):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncIncludes):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::createTypedArrayIteratorObject):

• runtime/JSTypedArrayViewPrototype.h:
• wasm/js/JSWebAssemblyHelpers.h:

(JSC::getWasmBufferFromValue):

• wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::growSuccessCallback):

Source/WebCore:

• Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::hasDetachedChannelBuffer const):

• Modules/webaudio/AudioBuffer.h:
• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::initialize):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::SerializedScriptValue::create):

• html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise):

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::putImageData):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texImageSourceHelper):

• platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::headerAvailable):

3:58 PM Changeset in webkit [269342] by Wenson Hsieh

• 4 edits in trunk/Source

Adjust some compile-time guards in GraphicsContextCG.cpp
​https://bugs.webkit.org/show_bug.cgi?id=218534

Reviewed by Tim Horton.

Source/WebCore:

Rename USE_DRAW_PATH_DIRECT to HAVE(CG_CONTEXT_DRAW_PATH_DIRECT), and delete the associated FIXME comment.
Also, put the line segment stroking optimization added in r268240 behind a new compile-time flag,
USE(CG_CONTEXT_STROKE_LINE_SEGMENTS_WHEN_STROKING_PATH). Note that we use USE rather than HAVE for this
flag, due to the fact that this API exists on all CoreGraphics platforms (but we only intend to use it in
certain configurations).

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):

Source/WTF:

Add HAVE(CG_CONTEXT_DRAW_PATH_DIRECT).

• wtf/PlatformHave.h:

3:50 PM Changeset in webkit [269341] by ysuzuki@apple.com

• 4 edits in trunk/Source/JavaScriptCore

[JSC] Obtain default timezone ID from cached icu::TimeZone
​https://bugs.webkit.org/show_bug.cgi?id=218531
<rdar://problem/64265880>

Reviewed by Ross Kirsling.

ICU internally caches icu::TimeZone (icu::TimeZone::createDefault), and it is not updated even if system timezone is changed.
As a result, we will see wrong timezone in Intl.DateTimeFormat when system timezone is changed.
We have a mechanism that clears TimeZone cache for JS Date. However, this mechanism is not used for Intl.DateTimeFormat.

This patch retrieves timezone ID from cached icu::TimeZone in VM::dateCache. So system's timezone change can be effective for
Intl.DateTimeFormat, and timezone becomes consistent between JS Date and Intl.DateTimeFormat.

Unfortunately, we need to use C++ APIs since we do not have a way to get timezone ID from icu::TimeZone.
Once ​https://unicode-org.atlassian.net/browse/ICU-21372 is fixed, we can switch to C APIs.

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::isUTCEquivalent): Deleted.
(JSC::defaultTimeZone): Deleted.

• runtime/JSDateMath.cpp:

(JSC::DateCache::defaultTimeZone):

• runtime/JSDateMath.h:

(JSC::isUTCEquivalent):

3:44 PM Changeset in webkit [269340] by Alan Coon

• 2 edits in branches/safari-610.2.11.51-branch/Source/JavaScriptCore

Cherry-pick r269338. rdar://problem/71014532

Don't assert there is no checkpoint side state when dropping the JSLock
​https://bugs.webkit.org/show_bug.cgi?id=218537

Reviewed by Filip Pizlo.

You may have multiple OSR exit sidestate data on the stack, and then call into
API code, which might DropAllLocks. Hence, this assert is wrong.

Working on a test. Will land in a followup.

• runtime/JSLock.cpp: (JSC::JSLock::willReleaseLock):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:43 PM Changeset in webkit [269339] by Alan Coon

• 8 edits in branches/safari-610.2.11.51-branch/Source

Versioning.

WebKit-7610.2.11.51.8

3:36 PM Changeset in webkit [269338] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Don't assert there is no checkpoint side state when dropping the JSLock
​https://bugs.webkit.org/show_bug.cgi?id=218537

Reviewed by Filip Pizlo.

You may have multiple OSR exit sidestate data on the stack, and then call into
API code, which might DropAllLocks. Hence, this assert is wrong.

Working on a test. Will land in a followup.

• runtime/JSLock.cpp:

(JSC::JSLock::willReleaseLock):

3:33 PM Changeset in webkit [269337] by Devin Rousso

• 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: should have the option to Edit Breakpoint... or at least Reveal Breakpoint in Sources Tab
​https://bugs.webkit.org/show_bug.cgi?id=218366

Reviewed by Brian Burg.

• UserInterface/Views/BreakpointPopover.js:

(WI.BreakpointPopover.appendContextMenuItems):

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype.get statusImageElement): Added.
(WI.DOMTreeElement.prototype._statusImageContextmenu):

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.populateContextMenu):

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForDOMNodeBreakpoints):
Show an "Edit Breakpoint..." action (via WI.BreakpointPopover.appendContextMenuItems) when
there is only one WI.DOMBreakpoint (if there are multiple then it would be confusing),
otherwise using "Breakpoints" (plural) for the other actions.

• UserInterface/Base/Main.js:

(WI.showSourcesTab):

• UserInterface/Views/EventListenerSectionGroup.js:

(WI.EventListenerSectionGroup):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):

• UserInterface/Views/SourcesTabContentView.js:

(WI.SourcesTabContentView.prototype.revealAndSelectRepresentedObject): Added.
(WI.SourcesTabContentView.prototype.revealAndSelectBreakpoint): Deleted.
Rename breakpointToSelect to representedObjectToSelect for more flexibility in the case
that there are multiple WI.DOMBreakpoint for the given WI.DOMNode, in which case we want
to select the WI.DOMNode instead.

• Localizations/en.lproj/localizedStrings.js:

3:17 PM Changeset in webkit [269336] by Karl Rackler

• 1 delete in trunk/LayoutTests/platform/mac-catalina/editing/Input

Fix broken rename

3:05 PM Changeset in webkit [269335] by Jonathan Bedard

• 4 edits in trunk/Tools

[webkitscmpy] Populate parent branch for tags
<rdar://problem/70998928>
​https://bugs.webkit.org/show_bug.cgi?id=218521

Rubber-stamped by Aakash Jain.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Version bump.
• Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn.commit): Populate cache of commits when the canonical branch does not match
the provided commit.

• Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestSvn):
(TestSvn.test_tag_previous):

2:49 PM Changeset in webkit [269334] by Brent Fulgham

• 3 edits in trunk/Source/WebKit

[macOS] remove sysctl.oidfmt. access
​https://bugs.webkit.org/show_bug.cgi?id=218524
<rdar://problem/70353722>

Reviewed by Per Arne Vollan.

Access to "sysctl.oidfmt." was needed due to a bug <rdar://problem/64208532>.
Since that issue has been fixed, we can remove the access.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

2:17 PM Changeset in webkit [269333] by graouts@webkit.org

• 10 edits
  1 add in trunk

align-content should be a discrete animatable property
​https://bugs.webkit.org/show_bug.cgi?id=218530

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:

Source/WebCore:

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• animation/CSSPropertyAnimation.cpp:

(WebCore::DiscretePropertyWrapper::DiscretePropertyWrapper):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• rendering/style/StyleContentAlignmentData.cpp: Added.

(WebCore::operator<<):

• rendering/style/StyleContentAlignmentData.h:

1:37 PM Changeset in webkit [269332] by ddkilzer@apple.com

• 8 edits
  4 adds in trunk

Add test for cacheModelForMainBundle() in WebKitLegacy
<​https://webkit.org/b/217960>

Reviewed by Darin Adler.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj/project.pbxproj:
• Add TestingFunctions.h to the project.

(Generate Export Files):

• Append WebKit.Testing.exp to the generated export file if WK_BUILD_FOR_TESTING is set to YES.

Source/WebKitLegacy/mac:

• Configurations/DebugRelease.xcconfig:

(WK_BUILD_FOR_TESTING): Add.

• This single setting controls whether test code is built and test functions are exported. Currently only Debug and Release configurations are supported.

• Configurations/WebKitLegacy.xcconfig:

(OTHER_CFLAGS):

• Include necessary macro definition when WK_BUILD_FOR_TESTING is YES.

(WK_CFLAGS_BUILD_FOR_TESTING_YES):

• Define macro set when WK_BUILD_FOR_TESTING is YES. Used by both OTHER_CFLAGS and OTHER_TAPI_FLAGS to enable test code.

(OTHER_TAPI_FLAGS[sdk=iphone*]):

• Include necessary macro definition when WK_BUILD_FOR_TESTING is YES.
• Add -extra-private-header argument to declare exported functions in TestingFunctions.h when WK_BUILD_FOR_TESTING is YES.

• TestingFunctions.h: Add.
• Declare functions exported when WK_BUILD_FOR_TESTING is YES.

• WebKit.Testing.exp: Add.
• This contains a list of test functions that are only exported when WK_BUILD_FOR_TESTING is YES.

• WebView/WebPreferences.mm:

(cacheModelForMainBundle):

• Add NSString *bundleIdentifier argument to make testable.

(TestWebPreferencesCacheModelForMainBundle): Add.

• Add function only used for testing, and only compiled when WK_BUILD_FOR_TESTING is YES.

(+[WebPreferences initialize]):

• Change to pass main bundle identifier as argument.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• Add WebPreferencesTest.mm to project.
• TestWebKitAPI/Tests/WebKitLegacy/cocoa/WebPreferencesTest.mm: Add.

(TestWebKitAPI::TEST):

• Add test for TestWebPreferencesCacheModelForMainBundle().

1:24 PM Changeset in webkit [269331] by commit-queue@webkit.org

• 7 edits in trunk/Source

[GPU Process] Flush canvas displayList from doAfterUpdateRendering
​https://bugs.webkit.org/show_bug.cgi?id=218401

Patch by Rini Patel <​rini_patel@apple.com> on 2020-11-03
Reviewed by Simon Fraser.

Source/WebCore:

Leverage prepareCanvasesForDisplayIfNeeded() for canvas 2D context to flush the display list items via doAfterUpdateRendering.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createContext2d):
(WebCore::HTMLCanvasElement::prepareForDisplay):

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::prepareForDisplay):

• html/canvas/CanvasRenderingContext2DBase.h:
• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::flushDrawingContextAndCommit):

Source/WebKit:

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::flushDrawingContextAndCommit): Deleted.

1:08 PM Changeset in webkit [269330] by Wenson Hsieh

• 9 edits
  2 adds in trunk/Source

Replace DisplayList::Recorder::Delegate::(will|did)AppendItem with (will|did)AppendItemOfType
​https://bugs.webkit.org/show_bug.cgi?id=218518

Reviewed by Simon Fraser.

Source/WebCore:

In preparation for larger changes to display lists and display list items in <webkit.org/b/218406>, replace
DisplayList::Recorder::Delegate's willAppendItem and didAppendItem client hooks with
willAppendItemOfType and didAppendItemOfType instead. Once all display list items are no longer ref-counted
objects that inherit from DisplayList::Item, plumbing these items through virtual client hooks will introduce
unnecessary complexity and runtime overhead.

Instead, we can refactor these methods to only pass the type of the display list item being appended; this is
because all extant clients that implement these hooks only require the item for its ItemType.

• Headers.cmake:

Pull DisplayList::ItemType out into a separate header: DisplayListItemType.h. This header additionally
contains several helper functions (sizeOfItemInBytes, isInlineItem, and isDrawingItem) that operate only
on ItemTypes, rather than items themselves.

We will use these helper functions as we work towards <webkit.org/b/218406>.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/displaylists/DisplayList.h:
• platform/graphics/displaylists/DisplayListItemType.cpp: Added.

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

• platform/graphics/displaylists/DisplayListItemType.h: Added.
• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::willAppendItemOfType):

Use the new DisplayList::isDrawingItem(ItemType) function here, instead of checking whether the item is a
subclass of DrawingItem.

(WebCore::DisplayList::Recorder::didAppendItemOfType):
(WebCore::DisplayList::Recorder::appendItem):
(WebCore::DisplayList::Recorder::willAppendItem): Deleted.
(WebCore::DisplayList::Recorder::didAppendItem): Deleted.

• platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::willAppendItemOfType):
(WebCore::DisplayList::Recorder::Delegate::didAppendItemOfType):
(WebCore::DisplayList::Recorder::Delegate::willAppendItem): Deleted.
(WebCore::DisplayList::Recorder::Delegate::didAppendItem): Deleted.

Source/WebKit:

See WebCore ChangeLog for more information.

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

12:51 PM Changeset in webkit [269329] by Lauro Moura

• 2 edits
  2 adds in trunk/LayoutTests

[GTK] Layout Test webaudio/codec-tests/mp3/128kbps-44khz.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=132056

Unreviewed test gardening.

This tests has been stable for a long time. Checking the actual
audio file with Audacity, the gstreamer one, the baseline, the mac one,
and the mp3 source differs only in the delay before the sound starts
playing, likely due to platform-specific loading time or something
similar. So a rebaseline should be enough.

• platform/glib/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
• platform/gtk/TestExpectations:

12:32 PM Changeset in webkit [269328] by Fujii Hironori

• 3 edits
  2 adds in trunk

[TextureMapper] Crashed in TextureMapperLayer::paintUsingOverlapRegions
​https://bugs.webkit.org/show_bug.cgi?id=214817
<rdar://problem/66489090>

Reviewed by Don Olmstead.

Source/WebCore:

TextureMapperLayer::paintUsingOverlapRegions has the expression
overlapRegion.bounds().size().area() which crashes for a very
large layer.

computeOverlapRegions returned very large overlap and non-overlap
regions without taking the clip bounds into account.

Change computeOverlapRegions to return clipped regions.
paintUsingOverlapRegions no longer needs to clip the returned
regions.

Test: compositing/tiling/huge-layer-with-opacity.html

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

• platform/graphics/texmap/TextureMapperLayer.h:

LayoutTests:

• compositing/tiling/huge-layer-with-opacity-expected.html: Added.
• compositing/tiling/huge-layer-with-opacity.html: Added.

12:20 PM Changeset in webkit [269327] by Wenson Hsieh

• 5 edits in trunk/Source/WebKit

Add helper methods to encode and decode IPC arguments as raw data
​https://bugs.webkit.org/show_bug.cgi?id=218516

Reviewed by Geoff Garen.

Add new helper methods to IPC::Encoder and IPC::Decoder that can be used to convert anything that can be
sent as an IPC argument into raw bytes (i.e. using WebCore::SharedBuffer), as long as there are no IPC
attachments in the encoded data.

For more details, see <webkit.org/b/218406>.

• Platform/IPC/Decoder.cpp:

(IPC::Decoder::Decoder):

Add private versions of the Encoder and Decoder constructors that avoid IPC header data. These constructors are
called only from within encodeSingleObject and decodeSingleObject, respectively.

(IPC::m_bufferDeallocator):

• Platform/IPC/Decoder.h:

(IPC::Decoder::decodeSingleObject):

• Platform/IPC/Encoder.cpp:

(IPC::Encoder::Encoder):
(IPC::Encoder::releaseAttachments):
(IPC::Encoder::hasAttachments const):

• Platform/IPC/Encoder.h:

12:16 PM Changeset in webkit [269326] by commit-queue@webkit.org

• 1 edit
  41 adds in trunk/Tools

Add SwiftUI MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=218393

Patch by Adam Roben <Adam Roben> on 2020-11-03
Rubber-stamped by Tim Horton.

Using WKWebView in SwiftUI is pretty cumbersome today. At a minimum,
you need to wrap the WKWebView in a NS/UIViewRepresentable SwiftUI
view, but to react to any state changes in the WKWebView (e.g.,
-canGoBack changing from NO to YES) you need to bridge between
WKWebView's KVO and SwiftUI's use of Combine publishers or
ObservableObjects. Setting up WKWebView's various delegates has to
happen down inside the NS/UIViewRepresentable's Coordinator object.
And so on.

There have been some attempts at this in the past, e.g.:

​https://medium.com/macoclock/how-to-use-webkit-webview-in-swiftui-4b944d04190a
​https://medium.com/@mdyamin/swiftui-mastering-webview-5790e686833e
​https://github.com/kylehickinson/SwiftUI-WebView

Someday it would be nice to provide an idiomatic SwiftUI API for
WebKit out of the box, like the new VideoPlayer API that wraps
AVPlayer.

This change provides a SwiftUI MiniBrowser implementation as well as a
very preliminary SwiftUI wrapper for WKWebView, originally authored by
James Savage. This only exposes a subset of the WKWebView API, and is
definitely not production ready yet, but will give us a place to
experiment with ways to make WebKit and SwiftUI work together better.

Here's James's description of the API:

The initial version of this API is composed of two primary
components: WebView and WebViewState. WebView conforms to
View, and its usage is straight-forward. WebViewState is novel,
and may not survive to the final API. It exists as a read-write
handle on the rather large amount of state that a web view offers.
This includes read-only access to properties about the current
page (title, url, hasOnlySecureContent), navigations
(estimatedProgress, isLoading), and back/forward history
(canGoBack, canGoForward). It also offers imperative methods
for navigation which map 1:1 with our existing Objective-C API.

struct BrowserView : View {

@StateObject var state = WebViewState(initialURL: URL(string: "​https://apple.com")!)
var body: some View {

HStack {

Text(verbatim: state.title ?? "Nothing Loaded")
Text(verbatim: state.url ?? "--")
WebView(state: state)

}

}

}

JavaScript dialogs are supported with both built-in behavior for all
clients, and a customization point if desired. Clients can pass a
Binding<Dialog?> to their WebView to disable the built-in
display, and provide custom handling.

Navigation policies can be customized using
webViewNavigationPolicy(onAction:onResponse:) to provide custom
decider for the action and response phases. These propagate via the
environment, allowing them to be defined at an app, window, or
individual view level.

Future Directions

To make WebView as declarative as possible, we're investigating
how to make broader use of Binding for navigation. As a simple
example, you could imagine if the WebView's initializer took a
Binding<URL?> for the current page. However, this design alone is
too simplistic to model all states that the web view could be, so we
will likely need to introduce a more complex type for the binding.

Currently navigation policies are attached via View modifiers.
This has the benefit that they can be installed at the root of an
application, which is useful for a web browser where all tabs want
to have uniform policies. Given the number of customization points
in existing WKWebView delegates, this may fail to scale and lead
to undesirable ergonomics. Another approach would to be just use a
delegate protocol (a la DropDelegate:
​https://developer.apple.com/documentation/swiftui/dropdelegate).

As a practical matter, we want to minimize the amount of work that
adding new functionality to WebKit API incurs for engineers. While
we could redefine every Objective-C type for SwiftUI, but this could
lead to SwiftUI falling behind as our Objective-C API gets updated.
We could use tools like @dynamicMemberLookup to automatically pull
our Objective-C APIs over to Swift, however this could have
undesirable impact our our ABI. There may be a better compromise we
haven’t yet reached.

• MiniBrowserSwiftUI/Configurations/Base.xcconfig:
• MiniBrowserSwiftUI/Configurations/Debug.xcconfig:
• MiniBrowserSwiftUI/Configurations/MiniBrowserSwiftUI.xcconfig:
• MiniBrowserSwiftUI/Configurations/Release.xcconfig:
• MiniBrowserSwiftUI/Configurations/WebKit_SwiftUI.xcconfig:
• MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/project.pbxproj:
• MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/xcshareddata/xcschemes/MiniBrowserSwiftUI.xcscheme:
• MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/xcshareddata/xcschemes/_WebKit_SwiftUI.xcscheme:

Added the new project and its configuration. The project was generated
from Xcode's "Multiplatform App" template. There are two targets: the
MiniBrowserSwiftUI app, and the _WebKit_SwiftUI framework. Both are
cross-platform. The build settings were extracted out of the .pbxproj
into the .xcconfig files.

• MiniBrowserSwiftUI/Shared/Assets.xcassets/AccentColor.colorset/Contents.json:
• MiniBrowserSwiftUI/Shared/Assets.xcassets/AppIcon.appiconset/Contents.json:
• MiniBrowserSwiftUI/Shared/Assets.xcassets/Contents.json:
• MiniBrowserSwiftUI/Shared/Assets.xcassets/URLFieldBackground.colorset/Contents.json:

Defines a couple of colors and an empty icon for the app.

• MiniBrowserSwiftUI/iOS/Info.plist:
• MiniBrowserSwiftUI/macOS/Info.plist:
• MiniBrowserSwiftUI/macOS/macOS.entitlements:
• MiniBrowserSwiftUI/WebKit_SwiftUI/WebKit_SwiftUI-Info.plist: Added.

Added these files generated by Xcode. The only change was adding
com.apple.security.network.client to the entitlements so the browser
can connect to servers.

• MiniBrowserSwiftUI/Shared/BrowserApp.swift: Added. This is the entry

point of the app, and just sets up a BrowserScene.

• MiniBrowserSwiftUI/Shared/BrowserScene.swift: Added. This sets up

the browser's windows, each of which just contain a single BrowserTab.
On iOS we wrap the BrowserTab in a NavigationView so there will be
somewhere to show our toolbar buttons.

• MiniBrowserSwiftUI/Shared/BrowserTab.swift: Added. This is the heart

of the browser.
(BrowserTab.body): Sets up the WebView itself plus some toolbar items:
the back/forward buttons and URL field.
(BrowserTab.onNavigate(to:)): Callback called when the user presses
Return in the URL field.
(BrowserTab.decidePolicy(for:state:)): Callback called when the
WebView is about to navigate, similar to WKNavigationDelegate's
-webView:decidePolicyForNavigationAction:decisionHandler:.
(BrowserTab.makeExternalNavigationAlert(_:)): Displays an alert to let
the user decide whether to follow a URL that will open in some other
application.
(UserInput): Represents text typed in the URL field after determining
whether it is a URL or a search query.
(ExternalURLNavigation): Provides the data for the external navigation
alert.
(BrowserTab_Previews): Shows a canned BrowserTab in Xcode's preview
canvas.

• MiniBrowserSwiftUI/Shared/FoundationExtras.swift: Added. Provides a

few utility functions for URLs.

• MiniBrowserSwiftUI/Shared/URLField.swift: Added.

(URLField): The SwiftUI view you use directly. It contains a leading
glyph (e.g., a lock icon when viewing a secure page), a text field,
a trailing accessory view provided by the caller, and a progress bar.
It also supports callbacks to notify the caller when the text field
gains/loses focus and when the user has committed the text in the
field (e.g., by pressing Return).
(Background): The background view for the URLField, which defines both
the rounded rectangle shape for the field and the progress bar.
(URLField_Previews): Shows some canned URLFields in Xcode's preview
canvas.

• MiniBrowserSwiftUI/WebKit_SwiftUI/Dialog.swift: Added.

(Dialog): Represents a single JavaScript dialog (alert, confirm, or
prompt).
(DialogContainer): Provides the default UI shared by all JavaScript
dialog types.

• MiniBrowserSwiftUI/WebKit_SwiftUI/JavaScriptDialogs.swift: Added.

(JavaScriptAlert): Default UI for a JavaScript alert dialog.
(JavaScriptConfirm): Default UI for a JavaScript confirm dialog.
(JavaScriptPrompt): Default UI for a JavaScript prompt dialog.

• MiniBrowserSwiftUI/WebKit_SwiftUI/Navigation.swift: Added.

(View.webViewNavigationPolicy(onAction:)):
(View.webViewNavigationPolicy(onResponse:)):
(View.webViewNavigationPolicy(onAction:onResponse:)):
These let the application specify navigation policy logic for any
descendant WebViews in the view hierarchy, using SwiftUI's Environment
facility.
(NavigationAction): Idiomatic SwiftUI wrapper around
WKNavigationAction and its decision handler callback.
(NavigationResponse): Idiomatic SwiftUI wrapper around
WKNavigationResponse and its decision handler callback.

• MiniBrowserSwiftUI/WebKit_SwiftUI/SwiftUIExtras.swift: Added.

(Color.platformSeparator):
(Color.platformBackground):
Cross-platform wrappers around platform-specific colors.

• MiniBrowserSwiftUI/WebKit_SwiftUI/WebView.swift: Added.

(WebView): The heart of the SwiftUI API. You provide it a WebViewState
struct to represent and control its state (similar to AVFoundation's
VideoPlayer view controlled by AVPlayer). You can optionally provide a
Binding to be notified of the current JavaScript dialog that the web
content wishes to display. If you don't provide this binding, WebView
will present the dialog using default UI.
(WebView.dialogView): Configures the default dialog UI if the caller
doesn't want to handle dialogs on its own.
(_WebView): Internal view that bridges SwiftUI to WKWebView.
(Coordinator): Internal class that functions as the WKWebView's
WKNavigationDelegate and WKUIDelegate.
(Coordinator.webView(_:decidePolicyFor:preferences:decisionHandler:)):
Looks for a navigation decider in the view's environment and delegates
to it if found, otherwise allows all navigations.

(Coordinator.webView(_:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:)):
(Coordinator.webView(_:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:)):
(Coordinator.webView(_:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:)):
Passes the dialog information up to the WebView, which then decides
whether to present default UI itself or let the caller handle it.

• MiniBrowserSwiftUI/WebKit_SwiftUI/WebViewModifiers.swift: Added.

(View.webViewAllowsBackForwardNavigationGestures(_:)): Specifies
whether WebViews below this point in the view hierarchy should support
swipe gestures to navigate back/forward.

• MiniBrowserSwiftUI/WebKit_SwiftUI/WebViewState.swift: Added.

(WebViewState): Represents the state and actions of a WebView.
Conforms to ObservableObject so SwiftUI views can react to changes in
the WebViewState.
(WebViewState.webView(_:didChangeKeyPath:)): Detects when the
WKWebView's state has changed via KVO and reflects those through the
ObservableObject.objectWillChange mechanism so SwiftUI views will be
updated.

(WebViewState.canGoBack):
(WebViewState.canGoForward):
(WebViewState.title):
(WebViewState.url):
(WebViewState.isLoading):
(WebViewState.estimatedProgress):
(WebViewState.hasOnlySecureContent):
Wrappers around WKWebView properties.

(WebViewState.load(_:)):
(WebViewState.goBack):
(WebViewState.goForward):
(WebViewState.reload):
(WebViewState.stopLoading):
(WebViewState.createPDF(configuration:completion:)):
Wrappers around WKWebView methods.

12:06 PM Changeset in webkit [269325] by stephan.szabo@sony.com

• 8 edits in trunk/Source

[WinCairo/PlayStation] ICU 68.1 no longer exposes FALSE and TRUE macros by default
​https://bugs.webkit.org/show_bug.cgi?id=218522

Reviewed by Don Olmstead.

Source/WebCore:

• platform/text/TextCodecICU.cpp: Replace use of TRUE with true

Source/WebKit:

• UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp: Replace FALSE with false

Source/WTF:

Replace uses of FALSE and TRUE with false and true.

• wtf/text/icu/UTextProvider.h:
• wtf/text/icu/UTextProviderLatin1.cpp:
• wtf/text/icu/UTextProviderUTF16.cpp:

11:54 AM Changeset in webkit [269324] by Fujii Hironori

• 2 edits in trunk/Tools

WebKitTestRunner --show-webview doesn't work since r268238
​https://bugs.webkit.org/show_bug.cgi?id=218430

Reviewed by Simon Fraser.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Use insert_or_assign() of
std::unordered_map instead of insert() which does nothing if the
key already exists.

11:38 AM Changeset in webkit [269323] by Said Abou-Hallawa

• 75 edits in trunk/Source

[GPU Process] Make ImageBuffer RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=218472

Reviewed by Simon Fraser.

Source/WebCore:

This will allow a better life cycle for the ImageBuffer.

• html/CanvasBase.cpp:

(WebCore::CanvasBase::setImageBuffer const):

• html/CanvasBase.h:
• html/CustomPaintCanvas.h:
• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::setImageBufferAndMarkDirty):

• html/HTMLCanvasElement.h:
• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::createBufferForPainting const):

• html/HTMLVideoElement.h:
• html/ImageBitmap.cpp:

(WebCore::ImageBitmap::takeImageBuffer):

• html/ImageBitmap.h:
• html/ImageBitmapBacking.cpp:

(WebCore::ImageBitmapBacking::ImageBitmapBacking):
(WebCore::ImageBitmapBacking::takeImageBuffer):

• html/ImageBitmapBacking.h:
• html/OffscreenCanvas.cpp:

(WebCore::DetachedOffscreenCanvas::DetachedOffscreenCanvas):
(WebCore::DetachedOffscreenCanvas::takeImageBuffer):
(WebCore::OffscreenCanvas::takeImageBuffer const):

• html/OffscreenCanvas.h:
• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::createCompositingBuffer):

• html/canvas/CanvasRenderingContext2DBase.h:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):

• html/canvas/WebGLRenderingContextBase.h:
• html/shadow/MediaControlTextTrackContainerElement.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::indexForData):

• inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::snapshotNode):
(WebCore::InspectorPageAgent::snapshotRect):

• page/Chrome.cpp:

(WebCore::Chrome::createImageBuffer const):

• page/Chrome.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::createImageBuffer const):

• page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
(WebCore::snapshotFrameRectWithClip):
(WebCore::snapshotSelection):
(WebCore::snapshotNode):

• page/FrameSnapshotting.h:
• page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

• page/TextIndicator.cpp:

(WebCore::takeSnapshot):

• platform/DragImage.cpp:

(WebCore::createDragImageFromSnapshot):

• platform/HostWindow.h:
• platform/graphics/ConcreteImageBuffer.h:

(WebCore::ConcreteImageBuffer::create):

• platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawConsumingImageBuffer):

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::drawConsumingImageBuffer):

• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::create):
(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::copyRectToBuffer):
(WebCore::ImageBuffer::sinkIntoNativeImage):
(WebCore::ImageBuffer::sinkIntoImage):
(WebCore::ImageBuffer::drawConsuming):

• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::drawConsuming):

• platform/graphics/ImageBufferPipe.h:
• platform/graphics/ShadowBlur.cpp:
• platform/graphics/cg/PDFDocumentImage.h:
• platform/graphics/cocoa/IOSurface.h:
• platform/graphics/coreimage/FilterEffectRendererCoreImage.h:
• platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:

(WebCore::FilterEffectRendererCoreImage::clearResult):

• platform/graphics/filters/Filter.h:

(WebCore::Filter::setSourceImage):

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::clearResult):

• platform/graphics/filters/FilterEffect.h:
• platform/graphics/nicosia/NicosiaImageBufferPipe.cpp:

(Nicosia::NicosiaImageBufferPipeSource::handle):

• platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:

(Nicosia::GCGLLayer::swapBuffersIfNeeded):

• platform/graphics/texmap/BitmapTexture.cpp:

(WebCore::BitmapTexture::updateContents):

• platform/mock/MockRealtimeVideoSource.h:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::invalidateBufferedForeground):

• rendering/svg/RenderSVGImage.h:
• rendering/svg/RenderSVGResourceClipper.h:
• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

• rendering/svg/RenderSVGResourceFilter.h:
• rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::postApplyResource):

• rendering/svg/RenderSVGResourceGradient.h:
• rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

• rendering/svg/RenderSVGResourceMasker.h:
• rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage const):

• rendering/svg/RenderSVGResourcePattern.h:
• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):

• rendering/svg/SVGRenderingContext.h:
• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::drawPatternForContainer):

Source/WebKit:

Currently after a remote ImageBuffer is deleted, its identifier is locked
in the RemoteResourceCacheProxy till no remote client is referencing it.
Then an IPC message is sent to GPU Process to release it.

The plan is to decode the DisplayList::DrawImageBuffer by replacing the
ImageBuffer identifier with a RefPtr to the ImageBuffer itself. Once the
ImageBuffer is removed from the RemoteResourceCache, it is going to be
deleted after the last DrawImageBuffer is replayed back. So no locking
is needed to guarantee the existence of the ImageBuffer when it is drawn.

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::flushDisplayList):
(WebKit::RemoteRenderingBackend::flushDisplayListAndCommit):
(WebKit::RemoteRenderingBackend::getImageData):

• GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::cacheImageBuffer):

• GPUProcess/graphics/RemoteResourceCache.h:
• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::create):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::createImageBuffer):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createImageBuffer const):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot const):

11:36 AM Changeset in webkit [269322] by Ryan Haddad

• 1 edit in trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-expected.txt

Unreviewed test gardening.

• platform/ios-wk2/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-expected.txt:

Rebaseline the test after r269276, which added DumpJSConsoleLogInStdErr to address flakiness.

11:36 AM Changeset in webkit [269321] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

Protect against HTMLMediaElement being destroyed during disptachEvent().
​https://bugs.webkit.org/show_bug.cgi?id=218398
<rdar://problem/67613836>

Reviewed by Chris Dumez.

Make the MainThreadGenericEventQueue protect the target as well as the owner of the queue.

Drive-by fix: Create the scoped eventFiringScope object after the protect object, to ensure
that the member variable set by the first scope will safely occur.

Drive-by fix #2: Also null-check the result of document().page() within HTMLMediaElement::dispatchEvent().

• dom/GenericEventQueue.cpp:

(WebCore::MainThreadGenericEventQueue::dispatchOneEvent):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::dispatchEvent):

11:26 AM Changeset in webkit [269320] by ysuzuki@apple.com

• 33 edits
  3 adds in trunk

REGRESSION (r254038): Simple.com money transfer UI is very laggy (multiple seconds per keypress)
​https://bugs.webkit.org/show_bug.cgi?id=218348

Reviewed by Darin Adler.

JSTests:

• ChakraCore.yaml:
• ChakraCore/test/Date/DateCtr.baseline-jsc: Added. The time before America/Los_Angeles timezone is effective should be handled as UTC-0752.
• complex.yaml:
• complex/timezone-offset-before-america-los-angeles-is-defined.js: Added for UTC-0752.

(shouldBe):

• microbenchmarks/local-date-constructor.js: Added for microbenchmarking.

(test):

• mozilla/ecma/Date/15.9.5.16.js:
• mozilla/ecma/Date/15.9.5.18.js:
• mozilla/ecma/Date/15.9.5.22-1.js:
• mozilla/ecma/Date/15.9.5.22-2.js:
• mozilla/ecma/Date/15.9.5.35-1.js:

When year is 0, America/Los_Angeles timezone is not effective, and mozilla test harness does not handle this timezone difference correctly.

Source/JavaScriptCore:

We have depth-1 LocalTimeOffset cache to avoid repeatedly calling localtime_r. But this depth-1 cache can be easily missed if
we parse Dates of multiple years. Instead of increasing depth as a work-around, this patch starts using ICU TimeZone cache.
This is used in SpiderMonkey and V8 too, and it is the right direction since ICU knows tzdata and can do more sophisticated caching.

Microbenchmark shows 24x improvement.

ToT Patched

local-date-constructor 2026.8715+-11.2909 ^{85.0022+-1.0548} definitely 23.8449x faster

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• runtime/DateConstructor.cpp:

(JSC::millisecondsFromComponents):
(JSC::constructDate):
(JSC::JSC_DEFINE_HOST_FUNCTION):

• runtime/DateInstance.cpp:

(JSC::DateInstance::calculateGregorianDateTime const):
(JSC::DateInstance::calculateGregorianDateTimeUTC const):

• runtime/DateInstance.h:
• runtime/DatePrototype.cpp:

(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::JSC_DEFINE_HOST_FUNCTION):

• runtime/JSDateMath.cpp:

(JSC::OpaqueICUTimeZoneDeleter::operator()):
(JSC::localTimeOffset):
(JSC::DateCache::gregorianDateTimeToMS):
(JSC::DateCache::msToGregorianDateTime):
(JSC::DateCache::parseDate):
(JSC::DateCache::cachedDateInstanceData):
(JSC::DateCache::timeZoneCacheSlow):
(JSC::DateCache::reset):
(JSC::gregorianDateTimeToMS): Deleted.
(JSC::msToGregorianDateTime): Deleted.
(JSC::parseDate): Deleted.

• runtime/JSDateMath.h:

(JSC::DateCache::timeZoneCache):

• runtime/VM.cpp:

(JSC::VM::resetDateCache): Deleted.

• runtime/VM.h:

(JSC::VM::resetDateCache):

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):

LayoutTests:

• js/date-constructor-expected.txt: The time before America/Los_Angeles timezone is effective should be handled as UTC-0752. Use 1995 to test the intent correctly.
• js/date-timeClip-large-values-expected.txt: Ditto about old timezone.
• js/dom/script-tests/date-DST-time-cusps.js: Our timezone database was broken. Nov 02 2014 01:00:00 is not PDT.

(1.toString.match):

• js/dom/script-tests/date-big-setdate.js: Fix and adjust for right DST periods.

(1.toString.match):

• js/script-tests/date-constructor.js:

(object.valueOf):

• platform/mac/fast/AppleScript/date-expected.txt: Ditto, 1800 does not have America/Los_Angeles.
• platform/mac/fast/AppleScript/date.html:
• storage/indexeddb/modern/date-basic-expected.txt: Nov 04 1955 is PST, not PDT.
• storage/indexeddb/modern/date-basic-private-expected.txt: Ditto.
• storage/indexeddb/modern/get-keyrange-expected.txt: Ditto.
• storage/indexeddb/modern/get-keyrange-private-expected.txt: Ditto.

11:14 AM Changeset in webkit [269319] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r269190. rdar://problem/70970247

Increase camera failing timer to 30 seconds
​https://bugs.webkit.org/show_bug.cgi?id=218389

Reviewed by Eric Carlson.

From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.

• platform/mediastream/mac/AVVideoCaptureSource.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [269318] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/ThirdParty/ANGLE

Cherry-pick r267770. rdar://problem/70970346

Fix EXT_color_buffer_half_float on iOS
​https://bugs.webkit.org/show_bug.cgi?id=217107

Reviewed by Kenneth Russell.

• src/libANGLE/Context.cpp: (gl::Context::generateSupportedExtensions const):
• src/libANGLE/renderer/gl/renderergl_utils.cpp: (rx::nativegl_gl::GenerateTextureFormatCaps):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@267770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [269317] by Alan Coon

• 13 edits
  3 adds in branches/safari-610-branch/Source

Cherry-pick r266364. rdar://problem/70970205

Implement WEBGL_compressed_texture_s3tc_srgb extension
​https://bugs.webkit.org/show_bug.cgi?id=215973

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

• src/libANGLE/renderer/gl/formatutilsgl.cpp: (rx::nativegl::ExtAndVersionOrExt): (rx::nativegl::BuildInternalFormatInfoMap):

Source/WebCore:

Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html

• CMakeLists.txt:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMConvertWebGL.cpp: (WebCore::convertToJSValue):
• html/canvas/WebGLCompressedTextureS3TCsRGB.cpp: Added. (WebCore::WebGLCompressedTextureS3TCsRGB::WebGLCompressedTextureS3TCsRGB): (WebCore::WebGLCompressedTextureS3TCsRGB::getName const): (WebCore::WebGLCompressedTextureS3TCsRGB::supported):
• html/canvas/WebGLCompressedTextureS3TCsRGB.h: Added.
• html/canvas/WebGLCompressedTextureS3TCsRGB.idl: Added.
• html/canvas/WebGLExtension.h:
• html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions):
• html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::extensionIsEnabled): (WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData): (WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions): (WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions):
• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/ExtensionsGL.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [269316] by Alan Coon

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266362. rdar://problem/70970398

WebGL goes in a bad state where glContext.createProgram() returns null
​https://bugs.webkit.org/show_bug.cgi?id=215844

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Kenneth Russell.

Added test webgl/2.0.0/conformance/canvas/render-after-resize-test.html

• platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLOpenGL::reshape):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:45 AM Changeset in webkit [269315] by ddkilzer@apple.com

• 3 edits
  1 add in trunk/Source/ThirdParty/ANGLE

Stop building ANGLE source files twice
<​https://webkit.org/b/218469>

Reviewed by Dean Jackson.

• ANGLE.xcodeproj/project.pbxproj:

(ANGLE (dynamic)):

• Replace sources with empty.cpp. Xcode requires a single source file to be compiled to create a dylib, even if the static library contains all necessary symbols.
• Add dependency on "ANGLE (static)" target.
• Configurations/ANGLE-dynamic.xcconfig:

(ANGLE_OTHER_LDFLAGS):

• Add $(ANGLE_STATIC_LIB_OTHER_LDFLAGS).

(ANGLE_STATIC_LIB_OTHER_LDFLAGS): Add.

• Special linker command-line switch to load all symbols from libANGLE.a when linking libANGLE-shared.dylib.
• src/empty.cpp: Add.
• See above why this is needed by Xcode.

10:45 AM Changeset in webkit [269314] by commit-queue@webkit.org

• 24 edits in trunk

Unreviewed, reverting r268564, r268957, and r268962.
​https://bugs.webkit.org/show_bug.cgi?id=218525

Caused 9% binary size increase in WebCore

Reverted changesets:

"CSSStyleDeclaration breaks JS spec (properties not showing up
in Object.getOwnPropertyNames)"
​https://bugs.webkit.org/show_bug.cgi?id=217623
​https://trac.webkit.org/changeset/268564

"Remove support for 'pixel' and 'pos' CSSOM prefixes"
​https://bugs.webkit.org/show_bug.cgi?id=119712
​https://trac.webkit.org/changeset/268957

"Remove non-standard 'css'/'Css' prefixed properties on
CSSStyleDeclaration"
​https://bugs.webkit.org/show_bug.cgi?id=218158
​https://trac.webkit.org/changeset/268962

10:00 AM Changeset in webkit [269313] by Wenson Hsieh

• 11 edits in trunk/Source

Replace DisplayList::itemCount with DisplayList::isEmpty
​https://bugs.webkit.org/show_bug.cgi?id=218517

Reviewed by Geoffrey Garen.

Source/WebCore:

In preparation for larger changes to display lists and display list items in <webkit.org/b/218406>, replace
DisplayList::itemCount() with DisplayList::isEmpty(). Once display list items are no longer stored in a
Vector of ref-counted items, keeping track of the exact item count will be difficult and introduce unnecessary
overhead, especially when reconstructing display lists out of shared memory in the GPU process.

Instead, change this to simply return whether or not the display list is empty (i.e. contains at least one
item), which is what (nearly) all call sites end up using itemCount() to determine anyways.

No change in behavior.

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::paintRenderingResultsToCanvas):

• platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::isEmpty const):
(WebCore::DisplayList::DisplayList::itemCount const): Deleted.

• platform/graphics/displaylists/DisplayListDrawingContext.cpp:

(WebCore::DisplayList::DrawingContext::replayDisplayList):

• platform/graphics/displaylists/DisplayListImageBuffer.h:
• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::operator<<):

• platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::isEmpty const):
(WebCore::DisplayList::Recorder::itemCount const): Deleted.

• platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

Source/WebKit:

Separately keep track of the item count in the context's display list. See WebCore/ChangeLog for more details.

• GPUProcess/graphics/RemoteImageBuffer.h: Use isEmpty() instead of checking itemCount().
• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::flushDrawingContextAndCommit):

9:59 AM Changeset in webkit [269312] by Simon Fraser

• 8 edits in trunk/Source

Scroll position can get reset after programmatic scroll
​https://bugs.webkit.org/show_bug.cgi?id=218477

Reviewed by Antti Koivisto.

Source/WebCore:

Part of rdar://problem/69599531: Scrolling on netflix.com sometimes jumps to the top.

Scrolling thread scroll notifications are handled on the main thread asynchronously, and
there are two sources of delay: first, the RunLoop::main().dispatch() in ThreadedScrollingTree::scrollingTreeNodeDidScroll(),
and second the zero-delay m_updateNodeScrollPositionTimer in AsyncScrollingCoordinator.

This is a problem when doing programmatic scrolls, since the main thread can
programmatically scroll, then the above asynchrony means that
AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll() gets called for an earlier
user scroll (or, as is often the case on netflix.com, a scroll triggered by the
rubberbanding timer on the scrolling thread).

This patches addresses these out-of-order scrolls by storing scrolling thread scroll updates
in a threadsafe data structure on the scrolling tree, and always applying those on the main
thread before handling other scroll changes.

This patch removes the zero-delay timer, which did serve a purpose of coalescing scroll
notifications from the scrolling thread and UI process (for iOS). With the patch, we still
get coalescing per RunLoop::main().dispatch(). We lose coalescing on iOS, but those
notifications should be just once per frame. If we find that it was necessary to coalesce,
we can put a timer back.

Not testable because it's very timing dependent.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::synchronizeStateFromScrollingTree):
(WebCore::AsyncScrollingCoordinator::noteScrollingThreadSyncCompleteForNode):
(WebCore::AsyncScrollingCoordinator::applyPendingScrollUpdates):
(WebCore::AsyncScrollingCoordinator::applyScrollUpdate):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll): Deleted.
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired): Deleted.

• page/scrolling/AsyncScrollingCoordinator.h:

(WebCore::AsyncScrollingCoordinator::ScheduledScrollUpdate::ScheduledScrollUpdate): Deleted.
(WebCore::AsyncScrollingCoordinator::ScheduledScrollUpdate::matchesUpdateType const): Deleted.

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::applyLayerPositionsInternal):
(WebCore::ScrollingTree::addPendingScrollUpdate):
(WebCore::ScrollingTree::takePendingScrollUpdates):

• page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::ScrollUpdate::ScrollUpdate):
(WebCore::ScrollingTree::ScrollUpdate::canMerge const):
(WebCore::ScrollingTree::ScrollUpdate::merge):

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):

Source/WebKit:

• WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode):

9:53 AM Changeset in webkit [269311] by Hector Lopez

• 2 edits in trunk/LayoutTests

Test expectation adjustment to cover internal testers
<rdar://68947198>

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:52 AM Changeset in webkit [269310] by Keith Rollin

• 6 edits in trunk

Extend check-for-inappropriate-files-in-framework to WebKitLegacy and JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=218272
<rdar://problem/70748116>

Reviewed by Simon Fraser.

Bug 218268 reports that some *.txt files got included in WebKitLegacy.
To help protect against this happening in the future, extend
check-for-inappropriate-files-in-framework to check for *.txt files,
and apply the script to WebKitLegacy and JavaScriptCore in addition to
WebCore and WebKit.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebKitLegacy:

In order to prevent this change from breaking local engineering builds
that still have these files in their build output directories, add a
couple of lines that will delete those *.txt files before making the
check for them.

• WebKitLegacy.xcodeproj/project.pbxproj:

Tools:

• Scripts/check-for-inappropriate-files-in-framework:

9:37 AM Changeset in webkit [269309] by don.olmstead@sony.com

• 7 edits
  1 copy
  2 moves
  3 adds in trunk/Source/JavaScriptCore

[CMake] Add remote inspector platforms
​https://bugs.webkit.org/show_bug.cgi?id=218451

Reviewed by Michael Catanzaro.

Add a CMake definition for each of the three remote inspector server backends to
remove duplication between the ports. Modify the port's CMake files to use the
shared definitions.

• PlatformFTW.cmake:
• PlatformGTK.cmake:
• PlatformJSCOnly.cmake:
• PlatformPlayStation.cmake:
• PlatformWPE.cmake:
• PlatformWin.cmake:
• inspector/remote/Cocoa.cmake: Added.
• inspector/remote/GLib.cmake: Added.
• inspector/remote/Socket.cmake: Added.
• inspector/remote/SourcesCocoa.txt: Copied from Source/JavaScriptCore/SourcesWPE.txt.
• inspector/remote/SourcesGLib.txt: Renamed from Source/JavaScriptCore/SourcesGTK.txt.
• inspector/remote/SourcesSocket.txt: Renamed from Source/JavaScriptCore/SourcesWPE.txt.

9:20 AM Changeset in webkit [269308] by weinig@apple.com

• 10 edits in trunk/Source/WebCore

Convert Settings.yaml to match the rough schema of the WebPreferences*.yaml files as a first step toward merging them
​https://bugs.webkit.org/show_bug.cgi?id=218428

Reviewed by Darin Adler.

As the first step toward merging Settings.yaml into the WebPreferences*.yaml files
update Settings.yaml better match. This includes:

• Fix key names start with capital letters.
• A 'type' is now required (no more defaulting to bool)
• 'initial' is renamed to defaultValue and gains the same per-frontend structure. This also means we can use PLATFORM() specific default values now rather than requiring the SettingsDefaults.h header, though this patch does not take advantage of that yet.
• 'type' must now be 'bool', 'double', 'uint32_t' or 'String'. A new refinedType allows Settings to maintain the more explicit enum types / URL types.
• Moves comments into the data structure to make it possible to keep them when manipulating the yaml programatically.
• Use webcore prefix for webcore specific keys.
• Replace single textAutosizingWindowSizeOverride preference which used an IntSize with TextAutosizingWindowSizeOverrideHeight and TextAutosizingWindowSizeOverrideWidth which are representable by one of the core types.

• Scripts/GenerateSettings.rb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb:
• Scripts/SettingsTemplates/Settings.cpp.erb:
• Scripts/SettingsTemplates/Settings.h.erb:
• WebCore.xcodeproj/project.pbxproj:
• page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::applyTextSizingIfNeeded):

• page/Settings.yaml:
• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setTextAutosizingWindowSizeOverride):

9:14 AM Changeset in webkit [269307] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[macOS] Adopt additional QuartzCore entitlement to reduce accessible endpoints
​https://bugs.webkit.org/show_bug.cgi?id=218466
<rdar://problem/55790037>

Reviewed by Per Arne Vollan.

In iOS 14 we adopted a new entitlement that limited the set of XPC endpoints available
to QuartzCore clients. We should do the same on macOS to provide a similar level of
protection.

• Scripts/process-entitlements.sh:

8:43 AM Changeset in webkit [269306] by youenn@apple.com

• 15 edits in trunk/Source

Add support for WebRTC VP9 decoder in GPU process
​https://bugs.webkit.org/show_bug.cgi?id=218445

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Allow creating a VTB VP9 decoder from WebCore.
VTB VP9 decoder currently needs key frame width and height information so we provide it as part of the decode callback.

• Configurations/libwebrtc.iOS.exp:
• Configurations/libwebrtc.iOSsim.exp:
• Configurations/libwebrtc.mac.exp:
• Source/webrtc/sdk/WebKit/WebKitDecoder.h:
• Source/webrtc/sdk/WebKit/WebKitDecoder.mm:

(-[WK_RTCLocalVideoH264H265VP9Decoder initVP9DecoderWithCallback:]):
(-[WK_RTCLocalVideoH264H265VP9Decoder decodeData:size:timeStamp:]):
(-[WK_RTCLocalVideoH264H265VP9Decoder setWidth:height:]):
(-[WK_RTCLocalVideoH264H265VP9Decoder releaseDecoder]):
(webrtc::RemoteVideoDecoder::Decode):
(webrtc::RemoteVideoDecoderFactory::GetSupportedFormats const):
(webrtc::createLocalH264Decoder):
(webrtc::createLocalH265Decoder):
(webrtc::createLocalVP9Decoder):
(webrtc::releaseLocalDecoder):
(webrtc::decodeFrame):
(webrtc::setDecoderFrameSize):

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.h:
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:

(-[RTCVideoDecoderVTBVP9 decode:missingFrames:codecSpecificInfo:renderTimeMs:]):
(-[RTCVideoDecoderVTBVP9 setWidth:height:]):

Source/WebKit:

Add support for VP9 decoder, send key frame size as IPC message specifically for VP9 hardware decoder.
If GPU process does not enable either SW or HW VP9 decoder, we fall back to in process VP9 decoder.

Manually tested by enabling WebRTC codec in GPU process.
Will be covered by existing VP9 tests in GPU process mode once canvas in GPUProcess is fully supported.

• GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
• GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in:
• GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

(WebKit::LibWebRTCCodecsProxy::createVP9Decoder):
(WebKit::LibWebRTCCodecsProxy::setFrameSize):

• WebProcess/GPU/GPUProcessConnection.h:

(WebKit::GPUProcessConnection::isVP9DecoderEnabled const):
(WebKit::GPUProcessConnection::isVPSWDecoderEnabled const):

• WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::createVideoDecoder):
(WebKit::decodeVideoFrame):
(WebKit::LibWebRTCCodecs::setCallbacks):
(WebKit::LibWebRTCCodecs::createDecoder):
(WebKit::LibWebRTCCodecs::decodeFrame):
(WebKit::formatNameFromCodecType):

• WebProcess/GPU/webrtc/LibWebRTCCodecs.h:

(WebKit::LibWebRTCCodecs::setVP9VTBSupport):
(WebKit::LibWebRTCCodecs::supportVP9VTB const):

8:21 AM Changeset in webkit [269305] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] MiniBrowser: increase default window size
​https://bugs.webkit.org/show_bug.cgi?id=218513

Reviewed by Adrian Perez de Castro.

Because 800x600 is to small nowadays. Use 1024x768 instead.

• MiniBrowser/gtk/BrowserWindow.c:

7:11 AM Changeset in webkit [269304] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WebDriver] Update config.json after tools update in r269235
​https://bugs.webkit.org/show_bug.cgi?id=218512

Reviewed by Carlos Garcia Campos.

• imported/w3c/config.json: Add missing value to https list.

6:49 AM Changeset in webkit [269303] by youenn@apple.com

• 264 edits
  1 copy
  4 moves
  54 adds
  18 deletes in trunk/Source/ThirdParty/libwebrtc

Update WebRTC boringssl to M87
​https://bugs.webkit.org/show_bug.cgi?id=218431

Reviewed by Eric Carlson.

• CMakeLists.txt:
• Source/third_party/boringssl: Resynced.
• libwebrtc.xcodeproj/project.pbxproj:

6:46 AM Changeset in webkit [269302] by clopez@igalia.com

• 4 edits in trunk/LayoutTests

[GTK][WPE] Move passing tests to the top of the TestExpectation files.

Some tests like http/tests/contentextensions/service-worker.https.html
are flaky and we have it marked as such at the GTK/WPE expectation file.
But the bots continue to complain about unexpected flakiness for this test.
This is because we have our section of tests passing at the bottom
of the TestExpectation files. And the layout test runner evaluates
the rules from top to bottom and it picks as the valid rule the last
one matching.
So when we unskip folders from the main TestExpectation file like
"http/tests/contentextensions [ Pass ]" we are also resetting the
value of all those tests to just Pass.
To avoid this problem move the expected passes to the top of the files.

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

6:34 AM Changeset in webkit [269301] by Antti Koivisto

• 11 edits in trunk/Source/WebCore

[LFC][Integration] RenderText::absoluteQuads should use iterator
​https://bugs.webkit.org/show_bug.cgi?id=218508

Reviewed by Zalan Bujtas.

• rendering/InlineBox.h:

(WebCore::InlineBox::calculateBoundaries const): Deleted.

This function is SVG-specific.
To reduce confusion, make it non-virtual and available in SVG inline box classes only.

• rendering/InlineTextBox.h:
• rendering/RenderText.cpp:

(WebCore::boundariesForTextRun):
(WebCore::ellipsisRectForTextRun):
(WebCore::collectAbsoluteQuads):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis const):
(WebCore::RenderText::absoluteQuads const):
(WebCore::RenderText::absoluteQuadsForRange const):
(WebCore::RenderText::collectSelectionRectsForLineBoxes):

Also inline selectionRectForRange/collectSelectionRectsForRange to the only caller here and make it use iterator.

(WebCore::collectAbsoluteQuadsForNonComplexPaths): Deleted.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::ellipsisRectForBox): Deleted.
(WebCore::RenderTextLineBoxes::selectionRectForRange): Deleted.
(WebCore::RenderTextLineBoxes::collectSelectionRectsForRange): Deleted.
(WebCore::RenderTextLineBoxes::absoluteQuads const): Deleted.

• rendering/RenderTextLineBoxes.h:

(): Deleted.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::floatLinesBoundingBox const):
(WebCore::RenderSVGInlineText::positionForPoint):
(WebCore::RenderSVGInlineText::firstTextBox const):

• rendering/svg/RenderSVGInlineText.h:
• rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::calculateBoundaries const):

• rendering/svg/SVGInlineFlowBox.h:
• rendering/svg/SVGInlineTextBox.h:

6:20 AM Changeset in webkit [269300] by youenn@apple.com

• 77 edits
  9 adds
  1 delete in trunk/Source/ThirdParty/libwebrtc

Update WebRTC usrsctp to M87
​https://bugs.webkit.org/show_bug.cgi?id=218433

Reviewed by Eric Carlson.

• Source/third_party/usrsctp: Resynced.

6:16 AM Changeset in webkit [269299] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

[LFC][IFC] Use "isConsideredEmpty" instead of "isVisuallyEmpty"
​https://bugs.webkit.org/show_bug.cgi?id=218475

Reviewed by Antti Koivisto.

In certain cases the line may look visually empty, but still considered non-empty when computing the line box geometry.
Use a more precise term to indicated whether the line is empty.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::shouldInlineLevelBoxStretchLineBox const):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::removeTrailingTrimmableContent):
(WebCore::Layout::Line::append):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::isRunConsideredEmpty const):
(WebCore::Layout::Line::isRunVisuallyNonEmpty const): Deleted.

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::isConsideredEmpty const):
(WebCore::Layout::Line::isVisuallyEmpty const): Deleted.

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_isConsideredEmpty):
(WebCore::Layout::m_isLineVisuallyEmpty): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::isConsideredEmpty const):
(WebCore::Layout::LineBox::isLineVisuallyEmpty const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):

• layout/inlineformatting/InlineLineBuilder.h:

6:14 AM Changeset in webkit [269298] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] showInlineTreeAndRuns should print the inline level boxes in visual order
​https://bugs.webkit.org/show_bug.cgi?id=218478

Reviewed by Antti Koivisto.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::rootInlineBox const):
(WebCore::Layout::LineBox::nonRootInlineLevelBoxes const):
(WebCore::Layout::LineBox::rootInlineBox):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::showInlineTreeAndRuns):

6:09 AM Changeset in webkit [269297] by Diego Pino Garcia

• 4 edits
  1 delete in trunk/LayoutTests

[GTK] Unreviewed test gardening. Remove stale flaky crashes.

All the tests failures removed were flaky crashes that were consistently
passing in the last 4000 revisions.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/media/video-played-collapse-expected.txt: Removed.
• platform/wpe/TestExpectations:

6:05 AM Changeset in webkit [269296] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Gardening fast/dom/Range/getBoundingClientRect.html failure

Unreviewed test gardening.

• platform/gtk/TestExpectations:

5:35 AM Changeset in webkit [269295] by youenn@apple.com

• 4 edits in trunk/Source/WebCore

REGRESSION (r269244?): ASSERTION FAILED: m_idHashSalt.isEmpty()

m_idHashSalt == salt in WebCore::Document::setDeviceIDHashSalt

​https://bugs.webkit.org/show_bug.cgi?id=218458
<rdar://problem/70963733>

Reviewed by Eric Carlson.

Remove no longer needed code.

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):

• dom/Document.cpp:
• dom/Document.h:

(WebCore::Document::hasHadCaptureMediaStreamTrack const):

4:55 AM Changeset in webkit [269294] by Adrian Perez de Castro

• 5 edits in trunk/Source/WebCore

Non-unified build fixes, early November 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=218464

Unreviewed non-unified build fixes.

No new tests needed.

• editing/VisibleUnits.cpp: Add missing InlineRunAndOffset.h header.
• inspector/InspectorFrontendAPIDispatcher.cpp: Add missing InspectorController.h and

wtf/RunLoop.h headers.
(WebCore::InspectorFrontendAPIDispatcher::frontendGlobalObject): Add missing JSC::
namespace to usage of JSC::JSGlobalObject type.

• layout/integration/LayoutIntegrationLineIterator.cpp: Add missing RenderBlockFlow.h

header.

• rendering/RenderBlockFlow.cpp: Add missing LayoutIntegrationRunIterator.h header.

4:33 AM Changeset in webkit [269293] by youenn@apple.com

• 21 edits in trunk/Source

Allow low latency H264 encoder in GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=218442

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Add a useLowLatency boolean in RTCVideoEncoderH264 and in encoder factory.
Encoder is set by the factory at creation time.
useLowLatency factory value is set at creation of the factory.

Clean up WebKitXX.h headers to do less include and move declarations in specific headers.

• Configurations/libwebrtc.iOS.exp:
• Configurations/libwebrtc.iOSsim.exp:
• Configurations/libwebrtc.mac.exp:
• Source/webrtc/sdk/WebKit/WebKitDecoder.h:
• Source/webrtc/sdk/WebKit/WebKitDecoder.mm:

(webrtc::videoDecoderTaskComplete):

• Source/webrtc/sdk/WebKit/WebKitEncoder.h:
• Source/webrtc/sdk/WebKit/WebKitEncoder.mm:

(-[WK_RTCLocalVideoH264H265Encoder setLowLatency:]):
(webrtc::createWebKitEncoderFactory):
(webrtc::setLocalEncoderLowLatency):

• Source/webrtc/sdk/WebKit/WebKitUtilities.h:
• Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
• Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h:
• Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m:

(-[RTCDefaultVideoEncoderFactory initWithH265:vp9:lowLatencyH264:]):
(-[RTCDefaultVideoEncoderFactory createEncoder:]):

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.h:
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCVideoEncoderH264 initWithCodecInfo:]):
(-[RTCVideoEncoderH264 setH264LowLatencyEncoderEnabled:]):
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

Source/WebCore:

Pass useLowLatency boolean when creating encoder factory.
Manually tested.

• platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:

(WebCore::LibWebRTCProviderCocoa::createEncoderFactory):

Source/WebKit:

Pass useLowLatency boolean from WebProcess to GPUProcess.

• GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
• GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in:
• GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

(WebKit::LibWebRTCCodecsProxy::createEncoder):

• WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::LibWebRTCCodecs::completedDecoding):
(WebKit::LibWebRTCCodecs::createEncoder):

3:50 AM Changeset in webkit [269292] by dino@apple.com

• 2 edits
  5 adds in trunk/Source/ThirdParty/ANGLE

Add schemes for ANGLE to Xcode project
​https://bugs.webkit.org/show_bug.cgi?id=217546
rdar://69062082

Reviewed by Alex Christensen.

• ANGLE.xcodeproj/xcshareddata/xcschemes/ANGLE (dynamic).xcscheme: Added.
• ANGLE.xcodeproj/xcshareddata/xcschemes/ANGLE (static).xcscheme: Added.
• ANGLE.xcodeproj/xcshareddata/xcschemes/ANGLE.xcscheme: Added.

3:23 AM Changeset in webkit [269291] by youenn@apple.com

• 1 edit in trunk/Source/ThirdParty/libwebrtc/ChangeLog

Update WebRTC libyuv to M87
​https://bugs.webkit.org/show_bug.cgi?id=218434

Reviewed by Eric Carlson.

• Source/third_party/usrsctp: Resynced.

2:18 AM Changeset in webkit [269290] by Chris Lord

• 2 edits in trunk/Source/WebKit

[GTK] Zooming causes page to scroll to top
​https://bugs.webkit.org/show_bug.cgi?id=217955

Reviewed by Carlos Garcia Campos.

Don't reset page scale when setting zoom level on GLIB backend.

• UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_set_zoom_level):

12:44 AM Changeset in webkit [269289] by youenn@apple.com

• 1128 edits
  9 copies
  2 moves
  118 adds
  14 deletes in trunk/Source/ThirdParty/libwebrtc

Update WebRTC abseil to M87
​https://bugs.webkit.org/show_bug.cgi?id=218432

Reviewed by Eric Carlson.

• CMakeLists.txt:
• Source/third_party/abseil-cpp: Resynced.

12:41 AM Changeset in webkit [269288] by youenn@apple.com

• 4 edits in trunk/Source/ThirdParty/libwebrtc

Update WebRTC opus to M87
​https://bugs.webkit.org/show_bug.cgi?id=218435

Reviewed by Eric Carlson.

• Source/third_party/opus: Resynced.

12:40 AM Changeset in webkit [269287] by Adrian Perez de Castro

• 8 edits in trunk

[GTK][WPE] Cannot remove individual scripts/stylesheets using WebKitUserContentManager
​https://bugs.webkit.org/show_bug.cgi?id=218403

Reviewed by Carlos Garcia Campos.

Add the missing WebKitUserContentManager functions which allow
removing a single script and style sheet from the manager. Given
that it is possible to remove a single content filter and message
handlers already, this make the API orthogonal for scripts and style
sheets as well.

Source/WebKit:

• UIProcess/API/glib/WebKitUserContentManager.cpp:

(webkit_user_content_manager_remove_style_sheet): Added.
(webkit_user_content_manager_remove_script): Added.

• UIProcess/API/gtk/WebKitUserContentManager.h: Add declarations for the new functions.
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Ditto.
• UIProcess/API/wpe/WebKitUserContentManager.h: Ditto.
• UIProcess/API/wpe/docs/wpe-1.0-sections.txt: Ditto.

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:

(testUserContentManagerInjectedStyleSheet): Add test for
webkit_user_content_manager_remove_style_sheet().
(testUserContentManagerInjectedScript): Add test for
webkit_user_content_manager_remove_script().

Nov 2, 2020:

10:56 PM Changeset in webkit [269286] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Fix GStreamerCommon.cpp debug category
​https://bugs.webkit.org/show_bug.cgi?id=218392

Reviewed by Adrian Perez de Castro.

GStreamerCommon.cpp lacked a default debug category so debug from
that file was not appearing under the WebKit category but empty.

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

8:20 PM Changeset in webkit [269285] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Crash under WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent()
​https://bugs.webkit.org/show_bug.cgi?id=218474

Reviewed by Geoffrey Garen.

After r269227, event loop tasks can get executed even after the script execution context
has been stopped. This introduce a flaky crash under:
WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent()

This patch updates the function to not attempt to dispatch the event after the context
has been stopped.

No new tests, covered by the following tests that are flaky crashing in debug:

• webgl/1.0.3/conformance/glsl/misc/non-ascii-comments.vert.html
• webgl/2.0.0/conformance/glsl/bugs/sampler-array-using-loop-index.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent):

7:39 PM Changeset in webkit [269284] by Chris Dumez

• 2 edits in trunk/Source/WebCore

REGRESSION (r269214): ASSERTION FAILED: m_state == CLOSED in WebCore::EventSource::abortConnectionAttempt
​https://bugs.webkit.org/show_bug.cgi?id=218457
<rdar://problem/70963581>

Reviewed by Geoffrey Garen.

When EventSource::didFail() gets called with an AccessControl error, it calls abortConnectionAttempt()
which cancels the load (by calling doExplicitLoadCancellation()). The expectation is that cancelling
the load will cause EventSource::didFail() to get called again, this time with a cancellation error,
which will set m_state to CLOSED. We're hitting the assertion because EventSource::didFail() is not
getting called with a cancellation error when the loader is a WorkerThreadableLoader and thus m_state
is not set to CLOSED as expected.

The reason for this is that MainThreadBridge::cancel() would return early and not call
ThreadableLoaderClientWrapper::didFail() if ThreadableLoaderClientWrapper::done() returns true.
ThreadableLoaderClientWrapper::done() returns true when ThreadableLoaderClientWrapper::didFail()
was already called previously, which is what's happening in our test. To address the issue,
MainThreadBridge::cancel() now calls ThreadableLoaderClientWrapper::didFail() no matter what.
This ensures consistency with the DocumentThreadableLoader.

No new tests, covered by existing test crashing on the bots.

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):

7:21 PM Changeset in webkit [269283] by rniwa@webkit.org

• 4 edits in trunk/Source/WebKit

Remove some useless comments from .messages.in files
​https://bugs.webkit.org/show_bug.cgi?id=218473

Reviewed by Tim Horton.

Remove comments that simply repeats what the code says.

• GPUProcess/GPUProcess.messages.in:
• NetworkProcess/NetworkProcess.messages.in:
• WebProcess/WebProcess.messages.in:

6:09 PM Changeset in webkit [269282] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Input sanitization improvements for Payment Request demo
​https://bugs.webkit.org/show_bug.cgi?id=218470

Reviewed by Andy Estes.

• demos/payment-request/merchant-validation.php:

5:15 PM Changeset in webkit [269281] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Regression(r269227) imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=218468
<rdar://problem/70969071>

Reviewed by Darin Adler.

Code in ServiceWorkerContainer::ready() was queueing an event loop task and then dereferencing
scriptExecutionContext() in the task. This is no longer safe after r269227 since tasks may
still be run after ActiveDOMObjects have been stopped. To address the issue, we need to
null check the scriptExecutionContext.

No new tests, covered by existing test.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ready):

4:59 PM Changeset in webkit [269280] by weinig@apple.com

• 2 edits in trunk/Tools

Sort/cleanup preferences in resetWebPreferencesToConsistentValues
​https://bugs.webkit.org/show_bug.cgi?id=218467

Reviewed by Darin Adler.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):
Sort things.

4:40 PM Changeset in webkit [269279] by Devin Rousso

• 4 edits in trunk/Source

guard UIScribbleInteraction class property observing behind a LOA check
​https://bugs.webkit.org/show_bug.cgi?id=218463
<rdar://problem/70747966>

Reviewed by Tim Horton.

Some apps appear to swizzle -[NSObject addObserver:forKeyPath:options:context:] without
support for the fact that the object can be a class rather than an instance and therefore
crash. Use a LOA check to guard observing +[UIScribbleInteraction isPencilInputExpected]
so that this doesn't happen, but only until the apps update, at which point they can fix it.

Source/WebCore:

• platform/cocoa/VersionChecks.h:

This appears to be the first instance of observing a class property, so add a new version
value for FirstThatObservesClassProperty.

Source/WebKit:

• UIProcess/ios/WKStylusDeviceObserver.mm:

(-[WKStylusDeviceObserver start]):
(-[WKStylusDeviceObserver stop]):

4:05 PM Changeset in webkit [269278] by weinig@apple.com

• 10 edits in trunk

[Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
​https://bugs.webkit.org/show_bug.cgi?id=218447

Reviewed by Darin Adler.

Source/WebKitLegacy/mac:

• Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb:
• Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb:
• WebView/WebFeature.m:

(-[WebFeature initWithKey:preferencesKey:name:details:defaultValue:hidden:]):
(-[WebFeature initWithKey:name:details:defaultValue:hidden:]): Deleted.

• WebView/WebFeatureInternal.h:

Handle non-standard preference keys by ensure we initialize WebFeatures with the generated
preferenceKey accessor rather than trying to derive it from the key directly.

Tools:

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Add missing file, TestOptionsGeneratedWebKitLegacyKeyMapping.cpp.erb.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):
(enableExperimentalFeatures): Deleted.
Match WebKitTestRunner and enable all experimental features by default. Disable a few of them to
keep the current behavior, but added FIXME to figure out why they are exposed but not enabled. Also
ensure a few preferences that are not experimental features, but were in the enableExperimentalFeatures
function remain set.

2:41 PM Changeset in webkit [269277] by Diego Pino Garcia

• 2 edits
  1 copy
  2 deletes in trunk/LayoutTests

[WPE] Unreviewed test gardening. Update test expectations.

Also remove stale WPE baseline for test imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001.html

• platform/glib/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt.
• platform/wpe/TestExpectations:
• platform/wpe/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt: Removed.

2:35 PM Changeset in webkit [269276] by Chris Dumez

• 3 edits in trunk/LayoutTests

Unreviewed, deflake imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https.html

Dump its console logging to stderr to address flakiness.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

2:24 PM Changeset in webkit [269275] by Chris Dumez

• 3 edits in trunk/Source/WebCore

REGRESSION (r269227): Crash in WebCore::WorkerOrWorkletGlobalScope::prepareForDestruction
​https://bugs.webkit.org/show_bug.cgi?id=218455
<rdar://problem/70963191>

Reviewed by Geoffrey Garen.

Document::willBeRemovedFromFrame() may have the same PaintWorkletGlobalScope instance
more than once in its m_paintWorkletGlobalScopes HashMap, under different keys. As a
result, it may call PaintWorkletGlobalScope::prepareForDestruction() more than once
on the same instance. This was causing issues because
EventLoopTaskGroup::markAsReadyToStop(), when called the second time, would move the
state from Stopped and back to ReadyToStop, which is unexpected.

To address the issue, EventLoopTaskGroup::markAsReadyToStop() now returns early if
the state is "Stopped". Also, I added a boolean check in PaintWorkletGlobalScope's
prepareForDestruction() to make sure we only do the work once per instance.

No new tests, covered by existing tests.

• dom/EventLoop.h:

(WebCore::EventLoopTaskGroup::markAsReadyToStop):

• worklets/PaintWorkletGlobalScope.h:

2:07 PM Changeset in webkit [269274] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Unreviewed, reverting r269245.

3 LFC tests asserting in
WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree

Reverted changeset:

"[LFC][IFC] Empty lines stay empty even when the imaginary
strut is present"
​https://bugs.webkit.org/show_bug.cgi?id=218420
​https://trac.webkit.org/changeset/269245

1:53 PM Changeset in webkit [269273] by James Savage

• 2 edits in trunk/Source/WebKit

Changes to SWIFT_MODULE_ONLY_ARCHS
​https://bugs.webkit.org/show_bug.cgi?id=218404

Reviewed by Tim Horton.

• SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig: Simplify how

we specify these options.

1:43 PM Changeset in webkit [269272] by Antti Koivisto

• 11 edits in trunk

[LFC][Integration] RenderText::absoluteQuadsForRange should use iterator
​https://bugs.webkit.org/show_bug.cgi?id=218444

Reviewed by Zalan Bujtas.

Source/WebCore:

Add the required iterator support and convert absoluteQuadsForRange to use it.
This eliminates ensureLineBoxes from two places.

• layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::PathTextRun::isSelectable const):
(WebCore::LayoutIntegration::PathTextRun::selectionRect const):

• layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

(WebCore::LayoutIntegration::RunIteratorLegacyPath::isSelectable const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::selectionRect const):

• layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::offsetForPosition const):
(WebCore::LayoutIntegration::RunIteratorModernPath::isSelectable const):
(WebCore::LayoutIntegration::RunIteratorModernPath::selectionRect const):
(WebCore::LayoutIntegration::RunIteratorModernPath::clampedOffset const):
(WebCore::LayoutIntegration::RunIteratorModernPath::createTextRun const):

• rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange const):
(WebCore::localQuadForTextRun):
(WebCore::RenderText::absoluteQuadsForRange const):

• rendering/RenderTextLineBoxes.cpp:

(WebCore::localQuadForTextBox): Deleted.
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange const): Deleted.
(WebCore::RenderTextLineBoxes::absoluteRectsForRange const): Deleted.

• rendering/RenderTextLineBoxes.h:

LayoutTests:

• fast/dom/Range/getBoundingClientRect-expected.txt:
• fast/dom/Range/getBoundingClientRect.html:

On legacy path <br> y position is miscomputed affecting getBoundingClientRect().
Update the test to match the new behavior. Results now match Firefox and Chrome.

1:21 PM Changeset in webkit [269271] by Chris Dumez

• 5 edits in trunk

[ macOS ] webaudio/OfflineAudioContext/onstatechange.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217543
<rdar://problem/70160122>

Reviewed by Alex Christensen.

Source/WebCore:

No new tests, unskipped existing test.

• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::startRendering):
After offline rendering on the audio thread and we go back to the main thread, make sure we queue a task of the
event loop to fire the statechange and completion events. We were previously failing to do so and that meant
that the ordering with other main thread events (which were queued on the event loop) was not always correct.

LayoutTests:

• platform/mac/TestExpectations:

Unskip test that should no longer be flaky.

• webaudio/OfflineAudioContext/onstatechange-expected.txt:

Rebaseline test now that the order of the promise resolution and the statechange event have changed.
Note that the new ordering is consistent with both Chrome and Firefox.

1:17 PM Changeset in webkit [269270] by Diego Pino Garcia

• 1 edit
  1 delete in trunk/LayoutTests

[WPE] Unreviewed test gardening. Remove outdated baselines no longer necessary after r269104.

• platform/wpe/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Removed.
• platform/wpe/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Removed.

12:55 PM Changeset in webkit [269269] by ddkilzer@apple.com

• 6 edits in trunk

Sort Xcode project file

Source/bmalloc:

• bmalloc.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:

Tools:

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

12:31 PM Changeset in webkit [269268] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, skip imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html on mac-arm64 only.

Sadly, there is no way to land a mac-arm64 specific baseline yet so we have to mark the test as failing on this platform, even though it
is actually passing (with slightly different values).

• platform/mac/TestExpectations:

12:17 PM Changeset in webkit [269267] by Alan Coon

• 1 copy in tags/Safari-611.1.4.0.1

Tag Safari-611.1.4.0.1.

12:14 PM Changeset in webkit [269266] by Alan Coon

• 2 edits in branches/safari-611.1.4.0-branch/Source/WebCore

Cherry-pick r269206. rdar://problem/70730895

Further lessen reliance on VPATH in WebCore/DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=218378
<rdar://problem/70730895>

Reviewed by Darin Adler.

Bug 217696 updated WebCore/DerivedSources.make to rely less on VPATH
and make more use of explicit partial or full paths. The solution
there, however, did not go far enough, and led to failures when
building WebKit for Safari Tech Preview and using old SDKs that
contains files that have since been "upstreamed" into WebKit. Address
this problem by taking further control of how DerivedSources.make
finds needed files instead of using the VPATH mechanism.

No new tests -- this is a build fix.

• DerivedSources.make:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:07 PM Changeset in webkit [269265] by Alan Coon

• 8 edits in branches/safari-611.1.4.0-branch/Source

Versioning.

WebKit-7611.1.4.0.1

11:56 AM Changeset in webkit [269264] by Diego Pino Garcia

• 6 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines of several tests failing.

• platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Needs update after r269224.
• platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.txt: Needs update after r269214.
• platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.png: Needs update after r269214.
• platform/gtk/imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001-expected.txt: Needs update after r269238.
• platform/gtk/tables/mozilla/bugs/bug28928-expected.txt: Needs update after r269238.

11:46 AM Changeset in webkit [269263] by Aditya Keerthi

• 3 edits in trunk/Source/WebKit

[iOS] Link Contacts.framework during build
​https://bugs.webkit.org/show_bug.cgi?id=218289
<rdar://problem/70770410>

Reviewed by Andy Estes.

Contacts.framework is currrently soft linked in PaymentAuthorizationPresenter.
Soft linking is generally discouraged, since it requires running the linker
at runtime, leading to an unwanted performance cost. By normally linking
the framework, the linkage is declared at build time, which enables running
the linker at build/update/install time and avoiding the runtime cost.

Unfortunately, we still have to soft link the framework on macOS, to avoid
introducing a dependency cycle. Upward linking is not an option, since the
Contacts framework does not implement InstallAPI.

The SOFT_LINK_FRAMEWORK macro has been kept in PaymentAuthorizationPresenter
to avoid introducing additional #ifs. This should be fine to keep on iOS,
since the framework will already loaded in the address space, and the call
to dlopen() should be much less expensive.

• Configurations/WebKit.xcconfig:
• Platform/cocoa/PaymentAuthorizationPresenter.mm:

11:45 AM Changeset in webkit [269262] by Alan Bujtas

• 3 edits in trunk/LayoutTests

[LFC] Do not [ ImageOnlyFailure ] all the tests in fast/layoutformattingcontext
​https://bugs.webkit.org/show_bug.cgi?id=218446

Many tests pass now.

Reviewed by Simon Fraser.

• TestExpectations:
• platform/mac-wk2/TestExpectations:

11:21 AM Changeset in webkit [269261] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Only upload to S3 when running on ews-build.webkit.org (follow-up fix for unit-test).
​https://bugs.webkit.org/show_bug.cgi?id=218439

Unreviewed follow-up fix.

• CISupport/ews-build/steps_unittest.py: Set CURRENT_HOSTNAME to EWS_BUILD_HOSTNAME during TestTransferToS3 unit-tests,

restore it in tearDown so that it doesn't affect any other unit-test.

11:20 AM Changeset in webkit [269260] by Alan Coon

• 4 edits in branches/safari-610-branch

Cherry-pick r268199. rdar://problem/70952726

Crash under WebKit::WebProcessCache::clear()
​https://bugs.webkit.org/show_bug.cgi?id=217480

Reviewed by Geoffrey Garen.

Source/WebKit:

Protect |process| in the responsiveness check lambda in WebProcessCache::addProcessIfPossible().
If we fail to do so and WebProcessCache::clear() gets called while the responsiveness check is
pending, the WebProcessProxy destructor may get called while clear() clears m_pendingAddRequests,
which would resolve the responsiveness check with responsive=false, and cause the lambda to
try and remove the entry from m_pendingAddRequests (while clear() is clearing it).

• UIProcess/WebProcessCache.cpp: (WebKit::WebProcessCache::addProcessIfPossible):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [269259] by Alan Coon

• 1 edit in branches/safari-610-branch/Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm

Apply patch. rdar://problem/70952670

Cherry-pick part of r268577 to branch.

11:20 AM Changeset in webkit [269258] by Alan Coon

• 1 edit
  2 adds in branches/safari-610-branch

Apply patch. rdar://problem/70733358

11:13 AM Changeset in webkit [269257] by Chris Dumez

• 2 edits in trunk/LayoutTests

REGRESSION (r268897): [macOS WK1] inspector/cpu-profiler/threads.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=218253
<rdar://problem/70732755>

Reviewed by Geoffrey Garen.

Check the thread name to identify the 2 worker threads. This is needed so that worklet thread are
not identified as worker threads after r268897.

• inspector/cpu-profiler/threads.html:

11:01 AM Changeset in webkit [269256] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Crash under ProcessThrottler::setAssertionType()
​https://bugs.webkit.org/show_bug.cgi?id=218448
<rdar://problem/67419221>

Reviewed by Geoffrey Garen.

A ProcessThrottler object is owned by its associated AuxiliaryProcessProxy. The crash was happening
in ProcessThrottler::setAssertionType(), we would replace m_assertion with a new "Suspended"
assertion and then crash on the next line when using m_assertion. The reason we crash is that
when we replaced m_assertion with a new assertion, the destruction of the previous assertion
caused the UIProcess's background task to get released (because this was the last non-suspended
process assertion). When we release the UIProcess' background task, we call
WebProcessPool::notifyProcessPoolsApplicationIsAboutToSuspend(), which destroys non-critical
WebProcesses (e.g. WebProcesses in the back/forward cache), which in turns destroy their
ProcessThrottler. As a result, when replacing m_assertion, the ProcessAssertion may get
destroyed, which is why we would crash on the next line when trying to use m_assertion.

To address the issue, we now release the UIProcess's background task asynchronously when
releasing the last non-suspended ProcessAssertion, making sure we still need to release
the assertion beforehand. This has 2 benefits:

• The ProcessThrottler can no longer get destroyed synchronously when releasing its ProcessAssertion.
• In the case where the ProcessThrottler replaces a foreground assertion with a background assertion (or vice-versa) and this is the last non-suspended assertion, this avoids unnecessarily releasing and retaking the UIProcess's background task. This also avoids killing non-critical processes unnecessarily.

• UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):

11:01 AM Changeset in webkit [269255] by Alan Coon

• 1 copy in branches/safari-611.1.4.0-branch

New branch.

10:59 AM Changeset in webkit [269254] by Brent Fulgham

• 4 edits in trunk/Source/WebKit

[macOS] Remove unneeded shmem access to ColorSync
​https://bugs.webkit.org/show_bug.cgi?id=218395
<rdar://problem/70354916>

Reviewed by Per Arne Vollan.

ColorSync on macOS has not used shared memory since Mac OS X 10.7, and our sandbox
should not have this access. Removing this unused shared memory capability.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

10:53 AM Changeset in webkit [269253] by Darin Adler

• 22 edits
  6 adds in trunk

Start removing functions that implicitly use composed tree
​https://bugs.webkit.org/show_bug.cgi?id=218424

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/rangeContainsNode.html

fast/dom/rangeContainsRange.html
fast/dom/treeOrder.html

Ryosuke pointed out that most clients should not be using the composed tree, so this
is a step in work to make the use of the composed tree explicit. After that we can
more easily find and correct call sites where use of the composed tree is incorrect.

Likely that most or all cases of treeOrder<ComposedTree> can be changed to just
treeOrder and contains<ComposedTree> to just contains; will do those in follow-ups.

• Modules/highlight/Highlight.cpp:

(WebCore::repaintRange): Simplified code to use boundary points, and changed to use
treeOrder<ComposedTree>.

• dom/AbstractRange.h: Export makeSimpleRange so it can be used in Internals.
• dom/AbstractRange.idl: Export the class so it can be used in Internals.

• dom/Node.cpp:

(WebCore::parent<ShadowIncludingTree>): Added.
(WebCore::treeOrderForTesting): Added.
(WebCore::documentOrder): Deleted.

• dom/Node.h: Updated for the above.

• dom/RadioButtonGroups.cpp:

(WebCore::RadioButtonGroup::members const): Use treeOrder<ComposedTree>.

• dom/SimpleRange.cpp:

(WebCore::contains): Removed a couple contains functions that implicitly use
composed tree.
(WebCore::containsForTesting): Added.

• dom/SimpleRange.h: Updated for the above. Should also make contains<Tree> the

default and remove the <Tree> at all call sites, but it's safer to do that in a
separate patch after this is landed and builds on all platforms.

• editing/Editing.cpp:

(WebCore::isNodeVisiblyContainedWithin): Use contains<ComposedTree>.

• page/DragController.cpp:

(WebCore::DragController::draggableElement const): Ditto.

• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Ditto. Note that this has a call to
isDescendantOf right next to it, which does not use the composed tree.

• page/Page.cpp:

(WebCore::Page::findTextMatches): Use treeOrder<ComposedTree>.
(WebCore::replaceRanges): Ditto.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
Use contains<ComposedTree>.

• testing/Internals.cpp:

(WebCore::string): Added.
(WebCore::convertType): Added.
(WebCore::Internals::treeOrder): Added.
(WebCore::Internals::rangeContainsNode): Added.
(WebCore::Internals::rangeContainsRange): Added.

• testing/Internals.h: Updated for added functions above.
• testing/Internals.idl: Ditto. These functions were tested in a

TestWebKitAPI test, but we plan to move those types of tests to
internals-based tests instead.

Source/WebKit:

• WebProcess/WebPage/glib/WebPageGLib.cpp:

(WebKit::WebPage::getPlatformEditorState const): Use contains<ComposedTree>.

Tools:

• TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Moved the tests of documentOrder

for two nodes and contains for range/range or range/node into internals-based tests
in the LayoutTests directory. Eventually we'll move the rest of these tests, too.

LayoutTests:

• fast/dom/rangeContainsNode-expected.txt: Added.
• fast/dom/rangeContainsNode.html: Added.
• fast/dom/rangeContainsRange-expected.txt: Added.
• fast/dom/rangeContainsRange.html: Added.
• fast/dom/treeOrder-expected.txt: Added.
• fast/dom/treeOrder.html: Added.

These tests were formerly part of TestWebKitAPI, although treeOrder was named documentOrder.
Moving to internals-style tests at Ryosuke's suggestion since these are not something exposed
as API or even SPI.

10:35 AM Changeset in webkit [269252] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Remove compiler warning in LLIntData.cpp
​https://bugs.webkit.org/show_bug.cgi?id=218443

Patch by Xan Lopez <Xan Lopez> on 2020-11-02
Reviewed by Mark Lam.

Fix compiler warning by casting a scoped enum to its underlying
type. Not allowing implicit type conversions is the whole point of
scoped enums.

• interpreter/CallFrame.h: remove underlying type specifier, since

we are using the default anyway ('int').

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions): cast the scoped enum to its
underlying type.

10:11 AM Changeset in webkit [269251] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

Fix link error with WebKit.framework

Undefined symbols for architecture x86_64:

"JSC::GenericTypedArrayView<JSC::Uint8Adaptor>::create(WTF::RefPtr<JSC::ArrayBuffer, WTF::RawPtrTraits<JSC::ArrayBuffer>, WTF::DefaultRefDerefTraits<JSC::ArrayBuffer> >&&, unsigned int, unsigned int)", referenced from:

WebKit::convertToUint8Array(IPC::SharedBufferCopy&&) in UnifiedSource7.o

ld: symbol(s) not found for architecture x86_64

• GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
• Include <JavaScriptCore/GenericTypedArrayViewInlines.h> to fix linker error with some builds of WebKit.
• See also WebProcess/GPU/media/RemoteLegacyCDMSession.cpp.

9:56 AM Changeset in webkit [269250] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.3.7

9:23 AM Changeset in webkit [269249] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Don't fail the build on S3 upload failure
​https://bugs.webkit.org/show_bug.cgi?id=218438

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-02
Reviewed by Aakash Jain.

This allows buildbots to keep going even when S3 is down. Using
S3 is not strictly necessary, as the built product can also be
downloaded from the buildbot server.

Patch-by: ​aakash_jain@apple.com

• CISupport/ews-build/steps.py:

(CompileWebKit.evaluateCommand):
(TransferToS3):
(TransferToS3.finished):

8:59 AM Changeset in webkit [269248] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Only upload to S3 when running on ews-build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=218439

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-02
Reviewed by Aakash Jain.

Uploading to S3 is inconvenient for testing instances, so only run this
step if we're executing on ews-build.webkit.org. Otherwise, transfer the
file through the buildbot server.

Patch-by: ​aakash_jain@apple.com

• CISupport/ews-build/steps.py:

(TransferToS3.doStepIf):

7:54 AM Changeset in webkit [269247] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests/imported/w3c

Update baselines of tests failing after WPT resync

Unreviewed test gardening.

These tests are failing in several platforms (iOS, Mac, GTK, WPE, ...) with the same diff. Thus, the general expectations file is updated.

• web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-invalid-expected.txt: Needs update after r269187.
• web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt: Needs update after r269235.

6:59 AM Changeset in webkit [269246] by commit-queue@webkit.org

• 9 edits in trunk

[GLIB] REGRESSION(r269144) imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=218358

Patch by Martin Robinson <​mrobinson@igalia.com> on 2020-11-02
Reviewed by Simon Fraser.

Source/WebCore:

Finish some missing pieces of exposing scroll-margin when ENABLE_SCROLL_SNAP is off.
This allows non-scroll-snap ports to use scroll-margin.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle): Move scroll margin code
out of the ENABLE_SCROLL_SNAP block.

• css/CSSProperties.json: Remove ENABLE_SCROLL_SNAP requirement for scroll-margin properties.
• css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const): Move scroll-margin code out of ENABLE_SCROLL_MARGIN block.
(WebCore::StyleProperties::asText const): Ditto.

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue): Ditto.
(WebCore::CSSPropertyParser::parseShorthand): Ditto.

LayoutTests:

• platform/glib/TestExpectations: Mark test as passing.
• platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Update expectations.
• platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

6:12 AM Changeset in webkit [269245] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Empty lines stay empty even when the imaginary strut is present
​https://bugs.webkit.org/show_bug.cgi?id=218420

Reviewed by Antti Koivisto.

Use the more correct runs.isEmpty() check to decide whether the root inline box should stay empty.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

12:35 AM Changeset in webkit [269244] by youenn@apple.com

• 19 edits
  1 add in trunk/Source

Stop sending origins from WebProcess to UIProcess for getUserMedia requests
​https://bugs.webkit.org/show_bug.cgi?id=218192

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior, move UserMediaRequestIdentifier in its own header.
Covered by existing tests.

• Headers.cmake:
• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::userMediaDocumentOrigin const): Deleted.
(WebCore::UserMediaRequest::topLevelDocumentOrigin const): Deleted.

• Modules/mediastream/UserMediaRequest.h:
• Modules/mediastream/UserMediaRequestIdentifier.h:
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Pass directly a UserMediaRequestIdentifier through IPC.
Stop passing origins from IPC and instead compute them from UIProcess side.

• Scripts/webkit/messages.py:
• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::denyRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::grantRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionInvalidRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionValidRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:
• UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy):

• UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::create):
(WebKit::UserMediaPermissionRequestProxy::userMediaID const):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
(WebKit::WebPageProxy::enumerateMediaDevicesForFrame):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::sendUserMediaRequest):
(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManager::enumerateMediaDevices):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted):
(WebKit::WebPage::userMediaAccessWasDenied):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

12:32 AM Changeset in webkit [269243] by youenn@apple.com

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Set vpcC box for hardware WebRTC VP9 decoder
​https://bugs.webkit.org/show_bug.cgi?id=218337

Reviewed by Eric Carlson.

Hardware VP9 decoder code path requires vpcC box information.
Provide it as part of the video format.
Initialize the vpcC box with a zeroed buffer.

Make sure WebKitVP9Decoder is able to handle dynamically 10 bits or 8 bits frames.

• Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

(webrtc::createWebKitVP9Decoder):
(webrtc::startVP9DecoderSession):
(webrtc::WebKitVP9DecoderReceiver::initializeFromFormatDescription):
(webrtc::WebKitVP9DecoderReceiver::pixelBufferPool):
(webrtc::WebKitVP9DecoderReceiver::Decoded):

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:

(-[RTCVideoDecoderVTBVP9 decodeData:size:timeStamp:]):
(-[RTCVideoDecoderVTBVP9 resetDecompressionSession]):