Timeline

Nov 12, 2020:

11:20 PM Changeset in webkit [269764] by youenn@apple.com

• 34 edits
  7 copies
  14 adds in trunk

Add infrastructure for WebRTC transforms
​https://bugs.webkit.org/show_bug.cgi?id=218750

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Make sure buffer is owned by the encoded image object.

• Configurations/libwebrtc.mac.exp:
• Source/webrtc/sdk/WebKit/WebKitEncoder.h:
• Source/webrtc/sdk/WebKit/WebKitEncoder.mm:

(webrtc::encoderVideoTaskComplete):

Source/WebCore:

Introduce RTCRtpTransform behind a preference.
Add binding code with libwebrtc to be able to process encoded content in sender and receiver sides.
Add a mock transform to validate the infrastructure is working.

Test: webrtc/webrtc-transform.html

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/mediastream/RTCRtpReceiver+Transform.idl: Added.
• Modules/mediastream/RTCRtpReceiver.cpp:

(WebCore::RTCRtpReceiver::~RTCRtpReceiver):
(WebCore::RTCRtpReceiver::stop):
(WebCore::RTCRtpReceiver::setTransform):

• Modules/mediastream/RTCRtpReceiver.h:
• Modules/mediastream/RTCRtpReceiverBackend.h:
• Modules/mediastream/RTCRtpReceiverWithTransform.h: Added.

(WebCore::RTCRtpReceiverWithTransform::transform):
(WebCore::RTCRtpReceiverWithTransform::setTransform):

• Modules/mediastream/RTCRtpSender+Transform.idl: Added.
• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::~RTCRtpSender):
(WebCore::RTCRtpSender::stop):
(WebCore::RTCRtpSender::setTransform):

• Modules/mediastream/RTCRtpSender.h:
• Modules/mediastream/RTCRtpSenderBackend.h:
• Modules/mediastream/RTCRtpSenderWithTransform.h: Added.

(WebCore::RTCRtpSenderWithTransform::transform):
(WebCore::RTCRtpSenderWithTransform::setTransform):

• Modules/mediastream/RTCRtpTransform.cpp: Added.

(WebCore::RTCRtpTransform::~RTCRtpTransform):
(WebCore::RTCRtpTransform::attachToReceiver):
(WebCore::RTCRtpTransform::attachToSender):
(WebCore::RTCRtpTransform::detachFromReceiver):
(WebCore::RTCRtpTransform::detachFromSender):

• Modules/mediastream/RTCRtpTransform.h: Added.
• Modules/mediastream/RTCRtpTransform.idl: Added.
• Modules/mediastream/RTCRtpTransformBackend.h: Added.
• Modules/mediastream/RTCRtpTransformableFrame.h: Added.
• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::LibWebRTCRtpReceiverBackend::createRTCRtpTransformBackend):

• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.cpp: Added.

(WebCore::mediaTypeFromReceiver):
(WebCore::LibWebRTCRtpReceiverTransformBackend::LibWebRTCRtpReceiverTransformBackend):
(WebCore::LibWebRTCRtpReceiverTransformBackend::~LibWebRTCRtpReceiverTransformBackend):
(WebCore::LibWebRTCRtpReceiverTransformBackend::setTransformableFrameCallback):

• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h: Added.
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::createRTCRtpTransformBackend):

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.cpp: Added.

(WebCore::mediaTypeFromSender):
(WebCore::LibWebRTCRtpSenderTransformBackend::LibWebRTCRtpSenderTransformBackend):
(WebCore::LibWebRTCRtpSenderTransformBackend::~LibWebRTCRtpSenderTransformBackend):
(WebCore::LibWebRTCRtpSenderTransformBackend::setTransformableFrameCallback):

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h: Added.
• Modules/mediastream/libwebrtc/LibWebRTCRtpTransformBackend.cpp: Added.

(WebCore::LibWebRTCRtpTransformBackend::setInputCallback):
(WebCore::LibWebRTCRtpTransformBackend::clearTransformableFrameCallback):
(WebCore::LibWebRTCRtpTransformBackend::setOutputCallback):
(WebCore::LibWebRTCRtpTransformBackend::processTransformedFrame):
(WebCore::LibWebRTCRtpTransformBackend::Transform):
(WebCore::LibWebRTCRtpTransformBackend::RegisterTransformedFrameCallback):
(WebCore::LibWebRTCRtpTransformBackend::RegisterTransformedFrameSinkCallback):
(WebCore::LibWebRTCRtpTransformBackend::UnregisterTransformedFrameCallback):
(WebCore::LibWebRTCRtpTransformBackend::UnregisterTransformedFrameSinkCallback):

• Modules/mediastream/libwebrtc/LibWebRTCRtpTransformBackend.h: Added.

(WebCore::LibWebRTCRtpTransformBackend::LibWebRTCRtpTransformBackend):
(WebCore::LibWebRTCRtpTransformBackend::Release const):

• Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.h: Added.

(WebCore::LibWebRTCRtpTransformableFrame::LibWebRTCRtpTransformableFrame):
(WebCore::LibWebRTCRtpTransformableFrame::toRTCFrame):
(WebCore::LibWebRTCRtpTransformableFrame::data const):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

• bindings/scripts/test/JS/JSTestInterface.h:
• testing/Internals.cpp:

(WebCore::Internals::createMockRTCRtpTransform):

• testing/Internals.h:
• testing/Internals.idl:
• testing/MockRTCRtpTransform.cpp: Added.

(WebCore::MockRTCRtpTransformer::create):
(WebCore::MockRTCRtpTransformer::clear):
(WebCore::MockRTCRtpTransformer::transform):
(WebCore::MockRTCRtpTransformer::isProcessing const):
(WebCore::MockRTCRtpTransformer::MockRTCRtpTransformer):
(WebCore::MockRTCRtpTransform::MockRTCRtpTransform):
(WebCore::MockRTCRtpTransform::~MockRTCRtpTransform):
(WebCore::MockRTCRtpTransform::isProcessing const):
(WebCore::MockRTCRtpTransform::initializeBackendForReceiver):
(WebCore::MockRTCRtpTransform::initializeBackendForSender):
(WebCore::MockRTCRtpTransform::willClearBackend):

• testing/MockRTCRtpTransform.h: Added.
• testing/MockRTCRtpTransform.idl: Added.

Source/WebKit:

Remove no longer needed const casting.

• Configurations/WebKit.xcconfig:
• WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::LibWebRTCCodecs::completedEncoding):

Source/WTF:

Add an experimental preference for WebRTC transforms.

• Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

• webrtc/webrtc-transform-expected.txt: Added.
• webrtc/webrtc-transform.html: Added.

8:50 PM Changeset in webkit [269763] by commit-queue@webkit.org

• 3 edits
  1 delete in trunk/Source/WebKit

Remove SecItemShim.dylib
​https://bugs.webkit.org/show_bug.cgi?id=218862

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-11-12
Reviewed by Alexey Proskuryakov.

This is dead code since r269697.

• Shared/mac/SecItemShim.cpp:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/mac/SecItemShimLibrary.h: Removed.
• WebProcess/mac/SecItemShimLibrary.mm: Removed.

7:15 PM Changeset in webkit [269762] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix the build warning below since r269753.
warning: unused parameter ‘spacing’ [-Wunused-parameter]

No new tests, no new behaviors.

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawPlatformPattern):

4:34 PM Changeset in webkit [269761] by Truitt Savell

• 2 edits in trunk/LayoutTests

REGRESSION: [ Mac wk2 ] webrtc/captureCanvas-webrtc-software-h264-baseline.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=218875

unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:20 PM Changeset in webkit [269760] by weinig@apple.com

• 11 edits in trunk

Move more WebKitLegacy specific settings usage to WebPreferences.yaml
​https://bugs.webkit.org/show_bug.cgi?id=218852

Reviewed by Tim Horton.

Source/WebCore:

This batch focuses on settings with defaults based on SDK/host app conditions.

• page/Settings.yaml:

Source/WebKitLegacy/mac:

This batch focuses on settings with defaults based on SDK/host app conditions.

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

• WebView/WebPreferencesDefaultValues.h:
• WebView/WebPreferencesDefaultValues.mm:

(WebKit::defaultAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
(WebKit::defaultLoadDeferringEnabled):
(WebKit::defaultWindowFocusRestricted):
(WebKit::defaultUsePreHTML5ParserQuirks):
(WebKit::defaultNeedsAdobeFrameReloadingQuirk):
(WebKit::defaultTreatsAnyTextCSSLinkAsStylesheet):
(WebKit::defaultNeedsFrameNameFallbackToIdQuirk):
(WebKit::defaultNeedsKeyboardEventDisambiguationQuirks):
(WebKit::defaultEnforceCSSMIMETypeInNoQuirksMode):
(WebKit::defaultNeedsIsLoadingInAPISenseQuirk):
(WebKit::defaultUseLegacyBackgroundSizeShorthandBehavior):
(WebKit::defaultAllowDisplayOfInsecureContent):
(WebKit::defaultAllowRunningOfInsecureContent):
(WebKit::defaultShouldConvertInvalidURLsToBlank):

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(needsSelfRetainWhileLoadingQuirk):
(-[WebView _preferencesChanged:]):
(-[WebView dealloc]):
(-[WebView setFrameLoadDelegate:]):
(shouldEnableLoadDeferring): Deleted.
(shouldRestrictWindowFocus): Deleted.
(shouldUseLegacyBackgroundSizeShorthandBehavior): Deleted.
(shouldAllowDisplayAndRunningOfInsecureContent): Deleted.
(shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Deleted.
(shouldConvertInvalidURLsToBlank): Deleted.
(-[WebView _needsAdobeFrameReloadingQuirk]): Deleted.
(-[WebView _needsLinkElementTextCSSQuirk]): Deleted.
(-[WebView _needsFrameNameFallbackToIdQuirk]): Deleted.
(-[WebView _needsIsLoadingInAPISenseQuirk]): Deleted.
(-[WebView _needsKeyboardEventDisambiguationQuirks]): Deleted.
(-[WebView _needsPreHTML5ParserQuirks]): Deleted.

Source/WTF:

This batch focuses on settings with defaults based on SDK/host app conditions.

• Scripts/Preferences/WebPreferences.yaml:

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):
Remove unnecessary call of [WebPreferences setUsePreHTML5ParserQuirks:NO] as this is the default.

3:59 PM Changeset in webkit [269759] by Simon Fraser

• 10 edits
  44 moves
  3 adds in trunk/LayoutTests

Move tests in fast/events that dispatch platform wheel events to their own directory
​https://bugs.webkit.org/show_bug.cgi?id=218869

Reviewed by Tim Horton.

Move tests in fast/events that rely on dispatching wheel events via eventSender to their own directory for
easier skipping on particular platforms.

Tests that synthesize DOM events remain in fast/events, since they are cross-platform.

Fix up some linter and sorting errors in TestExpectations.

• fast/events/wheel/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Renamed from LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt.
• fast/events/wheel/continuous-platform-wheelevent-in-scrolling-div.html: Renamed from LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div.html.
• fast/events/wheel/platform-wheelevent-in-scrolling-div-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-in-scrolling-div-expected.txt.
• fast/events/wheel/platform-wheelevent-in-scrolling-div.html: Renamed from LayoutTests/fast/events/platform-wheelevent-in-scrolling-div.html.
• fast/events/wheel/platform-wheelevent-paging-x-in-non-scrolling-div-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-non-scrolling-div-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-x-in-non-scrolling-div.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html.
• fast/events/wheel/platform-wheelevent-paging-x-in-non-scrolling-page-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-non-scrolling-page-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-x-in-non-scrolling-page.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html.
• fast/events/wheel/platform-wheelevent-paging-x-in-scrolling-div-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-div-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-x-in-scrolling-div.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-div.html.
• fast/events/wheel/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-x-in-scrolling-page.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-page.html.
• fast/events/wheel/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-xy-in-scrolling-div.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html.
• fast/events/wheel/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-xy-in-scrolling-page.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html.
• fast/events/wheel/platform-wheelevent-paging-y-in-non-scrolling-div-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-non-scrolling-div-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-y-in-non-scrolling-div.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html.
• fast/events/wheel/platform-wheelevent-paging-y-in-non-scrolling-page-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-non-scrolling-page-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-y-in-non-scrolling-page.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html.
• fast/events/wheel/platform-wheelevent-paging-y-in-scrolling-div-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-y-in-scrolling-div.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div.html.
• fast/events/wheel/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt.
• fast/events/wheel/platform-wheelevent-paging-y-in-scrolling-page.html: Renamed from LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html.
• fast/events/wheel/wheel-event-destroys-frame-expected.txt: Renamed from LayoutTests/fast/events/wheel-event-destroys-frame-expected.txt.
• fast/events/wheel/wheel-event-destroys-frame.html: Renamed from LayoutTests/fast/events/wheel-event-destroys-frame.html.
• fast/events/wheel/wheel-event-destroys-overflow-expected.txt: Renamed from LayoutTests/fast/events/wheel-event-destroys-overflow-expected.txt.
• fast/events/wheel/wheel-event-destroys-overflow.html: Renamed from LayoutTests/fast/events/wheel-event-destroys-overflow.html.
• fast/events/wheel/wheel-event-outside-body-expected.txt: Renamed from LayoutTests/fast/events/wheel-event-outside-body-expected.txt.
• fast/events/wheel/wheel-event-outside-body.html: Renamed from LayoutTests/fast/events/wheel-event-outside-body.html.
• fast/events/wheel/wheelevent-basic-expected.txt: Renamed from LayoutTests/fast/events/wheelevent-basic-expected.txt.
• fast/events/wheel/wheelevent-basic.html: Renamed from LayoutTests/fast/events/wheelevent-basic.html.
• fast/events/wheel/wheelevent-direction-inverted-from-device-expected.txt: Renamed from LayoutTests/fast/events/wheelevent-direction-inverted-from-device-expected.txt.
• fast/events/wheel/wheelevent-direction-inverted-from-device.html: Renamed from LayoutTests/fast/events/wheelevent-direction-inverted-from-device.html.
• fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt.
• fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl.html: Renamed from LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html.
• fast/events/wheel/wheelevent-in-text-node-expected.txt: Renamed from LayoutTests/fast/events/wheelevent-in-text-node-expected.txt.
• fast/events/wheel/wheelevent-in-text-node.html: Renamed from LayoutTests/fast/events/wheelevent-in-text-node.html.
• fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt.
• fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl.html: Renamed from LayoutTests/fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html.
• fast/events/wheel/wheelevent-mousewheel-interaction-expected.txt: Renamed from LayoutTests/fast/events/wheelevent-mousewheel-interaction-expected.txt.
• fast/events/wheel/wheelevent-mousewheel-interaction.html: Renamed from LayoutTests/fast/events/wheelevent-mousewheel-interaction.html.
• fast/scrolling/mac/wheel-event-listener-region-inside-overflow-expected.txt: Added.
• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt.
• platform/gtk/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt.
• platform/ios/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wk2/TestExpectations:
• platform/wpe/TestExpectations:

3:45 PM Changeset in webkit [269758] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

canvas-createPattern-video-modify-crash-log.txt asserts on debug GPUProcess bots
​https://bugs.webkit.org/show_bug.cgi?id=218872

Reviewed by Simon Fraser.

• WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::create):
This assertion is wrong; make it the same as the one in ImageBufferCGBitmapBackend.

3:11 PM November 2020 Meeting edited by Jon Davis

(diff)

3:11 PM November 2020 Meeting edited by Jon Davis

(diff)

3:07 PM November 2020 Meeting created by Jon Davis

2:54 PM Changeset in webkit [269757] by Devin Rousso

• 27 edits in trunk

Web Inspector: ensure that JSON::ArrayOf<T> doesn't allow addItem to be called with a type other than T
​https://bugs.webkit.org/show_bug.cgi?id=218686

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/scripts/codegen/cpp_generator_templates.py:
• inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator._generate_small_dispatcher_switch_implementation_for_domain):
(CppBackendDispatcherImplementationGenerator._generate_large_dispatcher_switch_implementation_for_domain):

• inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
• inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator._generate_enum_mapping):
(CppProtocolTypesImplementationGenerator._generate_open_field_names):
Use ASCIILiteral, makeString, and _s instead of inlined char* to ensure that the
String function overload is used.

• inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/expected/domain-debuggableTypes.json-result:
• inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/domain-targetTypes.json-result:
• inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/expected/enum-values.json-result:
• inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
• inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/expected/type-declaration-array-type.json-result:
• inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
• inspector/scripts/tests/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
• inspector/scripts/tests/expected/type-with-open-parameters.json-result:

Source/WTF:

• wtf/JSONValues.h:

(WTF::JSONImpl::Value::Value):
(WTF::JSONImpl::Value::Value):
(WTF::JSONImpl::ArrayOf::addItem):

• wtf/JSONValues.cpp:

(WTF::JSONImpl::Value::create):
Right now, JSON::ArrayOf<T> always has addItem overloads for int, double, String,
and Ref<T> (even when T is not a JSON::Value). This means that a JSON::ArrayOf<int>
can call addItem(42.0) or addItem("foo"_s) and it would work. This doesn't really match
the intention of JSON::ArrayOf<T>, so add some template std::enable_if to ensure that
the only addItem overload that exists is the one that matches T.

Tools:

• TestWebKitAPI/Tests/WTF/JSONValue.cpp:

(TestWebKitAPI::TEST):
Use _s and makeString to ensure that the String function overload is used.

2:52 PM Changeset in webkit [269756] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'target.DOMAgent.hideHighlight')
​https://bugs.webkit.org/show_bug.cgi?id=218836

Reviewed by Brian Burg.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype.hideDOMNodeHighlight):
Some views eagerly call this when detached, possibly even before the WI.mainTarget has
been established (i.e. it's still a WI.MultiplexingBackendTarget). Rather than add a
specific check for the WI.mainTarget, just iterate over WI.targets and check each target
since that's eventually what's going to need to be done anyways.

2:49 PM Changeset in webkit [269755] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(?): Graphics: cannot click on recording icon more than once
​https://bugs.webkit.org/show_bug.cgi?id=218834

Reviewed by Brian Burg.

• UserInterface/Views/ContextMenuUtilities.js:

(WI.addMouseDownContextMenuHandlers):
Only ignore future "mousedown" events if the WI.ContextMenu actually has items.

2:44 PM Changeset in webkit [269754] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(?): Sources: WebSocket status not shown when organized By Path
​https://bugs.webkit.org/show_bug.cgi?id=218679

Reviewed by Brian Burg.

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addResource):
Make sure to use WI.WebSocketResourceTreeElement for WI.WebSocketResource.

2:31 PM Changeset in webkit [269753] by Said Abou-Hallawa

• 24 edits in trunk/Source

[GPU Process] GraphicsContext::drawPattern() should take a NativeImage argument
​https://bugs.webkit.org/show_bug.cgi?id=218865

Reviewed by Simon Fraser.

Source/WebCore:

When recording the DisplayList item DrawPattern, the renderingResourceIdentifier
of the NativeImage will be recorded. When replaying it back, the
renderingResourceIdentifier will be resolved to a NativeImage and the
item will be applied the same way we for DrawNativeImage.

DrawPattern will be inline DisplayList item and should not need encoding
or decoding when sending it to the GPU.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawPattern):

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::drawPlatformImage): Deleted.

• platform/graphics/GraphicsContextImpl.h:
• platform/graphics/Image.cpp:

(WebCore::Image::drawPattern):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawPlatformPattern):
(WebCore::GraphicsContext::drawPattern): Deleted.

• platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawPattern):

• platform/graphics/cairo/GraphicsContextImplCairo.h:
• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawPlatformPattern):
(WebCore::GraphicsContext::drawPattern): Deleted.

• platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::copyTo const):

• platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawPattern::DrawPattern):
(WebCore::DisplayList::DrawPattern::apply const):
(WebCore::DisplayList::operator<<):

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawPattern::DrawPattern):
(WebCore::DisplayList::DrawPattern::imageIdentifier const):
(WebCore::DisplayList::DrawPattern::imageSize const):
(WebCore::DisplayList::DrawPattern::tileRect const):
(WebCore::DisplayList::DrawPattern::patternTransform const):
(WebCore::DisplayList::DrawPattern::image const): Deleted.
(WebCore::DisplayList::DrawPattern::encode const): Deleted.
(WebCore::DisplayList::DrawPattern::decode): Deleted.

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawPattern):

• platform/graphics/displaylists/DisplayListRecorder.h:
• platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::applyImageBufferItem):
(WebCore::DisplayList::applyNativeImageItem):
(WebCore::DisplayList::Replayer::applyItem):

• platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawPattern):

• platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
• platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawPlatformPattern):
(WebCore::GraphicsContext::drawPattern): Deleted.

• platform/graphics/win/GraphicsContextImplDirect2D.cpp:

(WebCore::GraphicsContextImplDirect2D::drawPattern):

• platform/graphics/win/GraphicsContextImplDirect2D.h:

Source/WebKit:

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::decodeItem):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

2:18 PM Changeset in webkit [269752] by ajuma@chromium.org

• 2 edits in trunk/Tools

configure-xcode-for-embedded-development breaks @available in Swift files
​https://bugs.webkit.org/show_bug.cgi?id=218850

Reviewed by Jonathan Bedard.

The changes applied by configure-xcode-for-embedded-development
for AvailabilityProhibitedInternal.h cause API_AVAILABLE to be ignored
in Objective-C, but @available is not ignored in Swift. As a result,
if an Objective-C method marked with API_AVAILABLE makes a call
into a Swift class marked with @available, this can lead to an
availability warning even when the calling method is only available
when the callee is available.

To fix this, ensure that @available is also ignored in Swift.

• Scripts/configure-xcode-for-embedded-development:

2:12 PM Changeset in webkit [269751] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] IOKit sandbox violation when enabling all GPU runtime flags
​https://bugs.webkit.org/show_bug.cgi?id=218820
<rdar://problem/71296116>

Reviewed by Brent Fulgham.

When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient
in the WebContent process. When all GPU runtime flags are enabled, IOKit extensions are not provided to the WebContent process,
which should then fall back to a set of rules allowing use of these IOKit classes, with logging. There seems to be a problem
with the fallback for this specific IOKit class, which this patch addresses by adding an extra requirement to the rule. The
extra requirement is that IOKit extensions have not been provided for these IOKit classes.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2:10 PM Changeset in webkit [269750] by Chris Dumez

• 10 edits in trunk

[GPUProcess] Add basic GPUProcess crash handling for media playback
​https://bugs.webkit.org/show_bug.cgi?id=218825

Reviewed by Eric Carlson.

Source/WebCore:

Add utility function to MediaPlayer to reload the media engine and resume
playback if necessary. This is called after the GPU process has crashed
so that the playback picks up where it left off.

Also add a new seekWhenPossible() function that only attempts to seek
once we've received the metadata. Any attempt to seek before the metadata
has been received gets ignored otherwise.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::reloadAndResumePlaybackIfNeeded):
(WebCore::MediaPlayer::seekWhenPossible):
(WebCore::MediaPlayer::readyStateChanged):

• platform/graphics/MediaPlayer.h:

Source/WebKit:

When the GPU process crashes and there are pending media players, we
now relaunch the GPU process and ask those media players to reconstuct
their private media players, reload the file and resume playback if
necessary. This ensures that in case of a GPU process crash while the
user is playing a video, the video just seamlessly keeps playing from
where it was before the crash.

Before this patch, we would end up busy looping and the WebContent process
would use 100% CPU after a GPU process crash.

• WebProcess/GPU/GPUProcessConnection.h:

(WebKit::GPUProcessConnection::addClient):
(WebKit::GPUProcessConnection::removeClient):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::proxyConfigurationForPlayer):
(WebKit::RemoteMediaPlayerManager::gpuProcessConnection const):
(WebKit::RemoteMediaPlayerManager::gpuProcessConnectionDidClose):

• WebProcess/GPU/media/RemoteMediaPlayerManager.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

2:01 PM Changeset in webkit [269749] by Chris Dumez

• 2 edits in trunk/Source/WebKit

ASSERTION FAILED: isValidIdentifier(m_identifier) seen with TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes
​https://bugs.webkit.org/show_bug.cgi?id=218856
<rdar://problem/71331809>

Reviewed by Tim Horton.

The API test is repeatedly killing the GPU process. As a result, it is possible for the
GPUProcess to crash while RemoteAudioDestinationProxy::connectToGPUProcess() is in the
middle of its RemoteAudioDestinationManager::CreateAudioDestination() synchronous IPC.
The function would fail to check if the IPC was successful and proceed with an invalid
destinationID in such cases, causing the crash.

We now check if the sendSync() was successful. If it wasn't we now log an error and
return early. RemoteAudioDestinationManager::gpuProcessConnectionDidClose() will get
called later on to notify us that the GPU Process crashed and it will call
connectToGPUProcess() again.

No new tests, covered by existing API test that is flakily crashing.

• WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::connectToGPUProcess):

1:53 PM Changeset in webkit [269748] by Alan Coon

• 8 edits in branches/safari-610.3.7.1-branch/Source

Versioning.

WebKit-7610.3.7.1.4

1:24 PM Changeset in webkit [269747] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

[LFC][Integration] VisiblePosition::absoluteSelectionBoundsForLine should use iterator
​https://bugs.webkit.org/show_bug.cgi?id=218866

Reviewed by Zalan Bujtas.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):

Also fix confused logical->physical mapping. The client wants physical position.

• editing/VisiblePosition.h:

(WebCore::VisiblePosition::inlineBoxAndOffset const): Deleted.

12:54 PM Changeset in webkit [269746] by Caio Lima

• 2 edits in trunk/JSTests

[Intl][ARMv7][MIPS] Skip stress/intl-datetimeformat-formatrange.js
​https://bugs.webkit.org/show_bug.cgi?id=218867

Unreviewed test gardening.

• stress/intl-datetimeformat-formatrange.js:

12:25 PM Changeset in webkit [269745] by Alan Bujtas

• 15 edits in trunk

[LFC][Integration] Enable inline replaced support
​https://bugs.webkit.org/show_bug.cgi?id=218514
<rdar://problem/71239028>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/html/browsers/sandboxing/sandbox-parse-noscript-expected.txt:

Source/WebCore:

• layout/integration/LayoutIntegrationCoverage.cpp:

LayoutTests:

Progressions (mostly trimmable trailing whitespace).

• accessibility/mac/attachment-element-replacement-character-expected.txt:
• compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt:
• platform/mac/fast/block/basic/013-expected.txt:
• platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:

10:46 AM Changeset in webkit [269744] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] FormattingContext::Geometry::computedHeightValue should handle min, max and fit-content
​https://bugs.webkit.org/show_bug.cgi?id=218853

Reviewed by Antti Koivisto.

This is not an actual support for those height values (that's something the caller needs to implement),
it's just avoiding the assertion in valueForLength.

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue const):

10:38 AM Changeset in webkit [269743] by Alan Coon

• 1 copy in tags/Safari-611.1.4.0.2

Tag Safari-611.1.4.0.2.

10:35 AM Changeset in webkit [269742] by Alan Coon

• 1 edit in branches/safari-611.1.4.0-branch/Source/WebCore/DerivedSources.make

Unreviewed build fix. rdar://71019899

Remove SpeechRecognition IDL files from WebCore/DerivedSources.make

10:31 AM Changeset in webkit [269741] by Alan Coon

• 8 edits in branches/safari-611.1.4.0-branch/Source

Versioning.

WebKit-7611.1.4.0.2

10:29 AM Changeset in webkit [269740] by Alan Coon

• 1 copy in tags/Safari-611.1.5

Tag Safari-611.1.5.

10:26 AM Changeset in webkit [269739] by youenn@apple.com

• 5 edits in trunk/Source/WebKit

WebProcess should process WebRTC codecs IPC messages from the GPU Process in a background thread
​https://bugs.webkit.org/show_bug.cgi?id=218790

Reviewed by Eric Carlson.

Use a WorkQueue to process GPU WebRTC codec IPC messages.
For that reason, handle encoder and decoder map within that queue.

Covered by existing tests.

• GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

(WebKit::LibWebRTCCodecsProxy::setEncodeRates):

• WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::dispatchMessage):

• WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::LibWebRTCCodecs::LibWebRTCCodecs):
(WebKit::LibWebRTCCodecs::~LibWebRTCCodecs):
(WebKit::LibWebRTCCodecs::setConnection):
(WebKit::LibWebRTCCodecs::createDecoder):
(WebKit::LibWebRTCCodecs::releaseDecoder):
(WebKit::LibWebRTCCodecs::failedDecoding):
(WebKit::LibWebRTCCodecs::completedDecoding):
(WebKit::LibWebRTCCodecs::createEncoder):
(WebKit::LibWebRTCCodecs::releaseEncoder):
(WebKit::LibWebRTCCodecs::initializeEncoder):
(WebKit::LibWebRTCCodecs::setEncodeRates):
(WebKit::LibWebRTCCodecs::completedEncoding):
(WebKit::LibWebRTCCodecs::dispatchToThread):

• WebProcess/GPU/webrtc/LibWebRTCCodecs.h:

10:00 AM Changeset in webkit [269738] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] configure buildbot not to send Usage Data to buildbot developers
​https://bugs.webkit.org/show_bug.cgi?id=218821

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/master_buildbot2.cfg:

9:57 AM Changeset in webkit [269737] by ysuzuki@apple.com

• 44 edits
  9 moves
  21 adds
  3 deletes in trunk/JSTests

[JSC] Upgrade test262
​https://bugs.webkit.org/show_bug.cgi?id=218845

Reviewed by Alexey Shvayka.

One failing test is test262 bug and tracked in ​https://github.com/tc39/test262/pull/2898.

• test262/expectations.yaml:
• test262/harness/atomicsHelper.js:
• test262/latest-changes-summary.txt:
• test262/test/built-ins/Atomics/waitAsync/bigint/true-for-timeout.js:
• test262/test/built-ins/Atomics/waitAsync/returns-result-object-value-is-promise-resolves-to-timed-out.js:
• test262/test/built-ins/Atomics/waitAsync/true-for-timeout.js:
• test262/test/built-ins/Object/seal/configurable-attribute-all-own-properties-set-from-true-to-false-property-are-unaltered.js: Renamed from JSTests/test262/test/built-ins/Object/seal/object-seal-the-configurable-attribute-of-all-own-properties-of-o-are-set-from-true-to-false-and-other-attributes-of-the-property-are-unaltered.js.
• test262/test/built-ins/Object/seal/configurable-attribute-own-accessor-property-set-from-true-to-false-property-are-unaltered.js: Renamed from JSTests/test262/test/built-ins/Object/seal/object-seal-the-configurable-attribute-of-own-accessor-property-of-o-is-set-from-true-to-false-and-other-attributes-of-the-property-are-unaltered.js.
• test262/test/built-ins/Object/seal/seal-finalizationregistry.js:
• test262/test/built-ins/Object/seal/seal-weakref.js:
• test262/test/built-ins/String/prototype/split/arguments-are-objects-and-instance-is-string-first-object-have-overrided-to-string-function-and-value-of-function-that-throw-exception-second-object-have-overrided-value-of-function-that-throw-exception.js: Removed.
• test262/test/built-ins/String/prototype/split/separator-override-tostring-limit-override-valueof-throws.js: Renamed from JSTests/test262/test/built-ins/String/prototype/split/arguments-are-objects-and-instance-is-string-first-object-have-overrided-to-string-function-second-object-have-overrided-value-of-function-that-throw-exception.js.
• test262/test/built-ins/String/prototype/split/separator-override-tostring-limit-override-valueof-tostring-throws.js: Renamed from JSTests/test262/test/built-ins/String/prototype/split/arguments-are-objects-and-instance-is-string-first-object-have-overrided-to-string-function-second-object-have-overrided-value-of-function-and-to-string-function-that-throw-exception.js.
• test262/test/built-ins/String/prototype/split/separator-override-tostring-limit-override-valueof-tostring.js: Renamed from JSTests/test262/test/built-ins/String/prototype/split/arguments-are-objects-and-instance-is-string-first-object-have-overrided-to-string-function-second-object-have-overrided-value-of-and-to-string-functions.js.
• test262/test/built-ins/String/prototype/split/separator-override-tostring-limit-override-valueof.js: Renamed from JSTests/test262/test/built-ins/String/prototype/split/arguments-are-objects-and-instance-is-string-first-object-have-overrided-to-string-function-second-object-have-overrided-value-of-function.js.
• test262/test/built-ins/String/prototype/split/separator-override-tostring-throws-limit-override-valueof-throws.js: Renamed from JSTests/test262/test/built-ins/String/prototype/split/arguments-are-objects-and-instance-is-string-first-object-have-overrided-to-string-function-that-throw-exception-second-object-have-overrided-value-of-function-that-throw-exception.js.
• test262/test/built-ins/String/prototype/split/separator-override-valueof.js: Renamed from JSTests/test262/test/built-ins/String/prototype/split/argument-is-function-and-instance-is-string-object-object-have-overrided-to-string-and-value-of-functions.js.
• test262/test/built-ins/String/prototype/split/transferred-to-custom.js: Added.

(Splittable.this.toString):
(Splittable.this.valueOf):
(Splittable):

• test262/test/built-ins/String/prototype/split/transferred-to-number-separator-override-tostring-returns-regexp.js: Renamed from JSTests/test262/test/built-ins/String/prototype/split/argument-is-object-and-instance-is-number-object-have-overrided-to-string-function-that-return-regexp.js.
• test262/test/built-ins/String/prototype/split/valueOf-is-called-for-limit-argument.js: Added.

(let.limit.toString):
(let.limit.valueOf):

• test262/test/built-ins/TypedArray/prototype/every/BigInt/callbackfn-detachbuffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/every/callbackfn-detachbuffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/filter/BigInt/callbackfn-detachbuffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/filter/callbackfn-detachbuffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/find/BigInt/predicate-may-detach-buffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/find/predicate-may-detach-buffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/findIndex/predicate-may-detach-buffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/forEach/BigInt/callbackfn-detachbuffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/forEach/callbackfn-detachbuffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/map/BigInt/callbackfn-detachbuffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/map/callbackfn-detachbuffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/reduce/BigInt/callbackfn-detachbuffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/reduce/callbackfn-detachbuffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/reduceRight/BigInt/callbackfn-detachbuffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/reduceRight/callbackfn-detachbuffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/slice/BigInt/detached-buffer-custom-ctor-other-targettype.js:

(testWithBigIntTypedArrayConstructors.get sample): Deleted.

• test262/test/built-ins/TypedArray/prototype/slice/detached-buffer-custom-ctor-other-targettype.js:

(testWithTypedArrayConstructors.get sample): Deleted.

• test262/test/built-ins/TypedArray/prototype/some/BigInt/callbackfn-detachbuffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/some/callbackfn-detachbuffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-realm.js:
• test262/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-configurable.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-numericindex-desc-configurable.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-numericindex.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/GetOwnProperty/BigInt/index-prop-desc.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/GetOwnProperty/index-prop-desc.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer-realm.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/tonumber-value-detached-buffer.js:

(testWithBigIntTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/Set/detached-buffer-realm.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/Set/detached-buffer.js:

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArrayConstructors/internals/Set/tonumber-value-detached-buffer.js:

(testWithTypedArrayConstructors):

• test262/test/intl402/DateTimeFormat/intl-legacy-constructed-symbol-on-unwrap.js: Added.

(try.get target):
(catch):

• test262/test/intl402/DateTimeFormat/intl-legacy-constructed-symbol.js: Added.
• test262/test/intl402/NumberFormat/intl-legacy-constructed-symbol-on-unwrap.js: Added.

(try.get target):
(catch):

• test262/test/intl402/NumberFormat/intl-legacy-constructed-symbol.js: Added.
• test262/test/language/eval-code/direct/arrow-fn-body-cntns-arguments-fn-decl-params-cntns-dflt-assignment-arrow-func-declare-arguments-assign-incl-def-param-arrow-arguments.js: Removed.
• test262/test/language/eval-code/direct/arrow-fn-body-cntns-arguments-fn-decl-params-cntns-dflt-assignment-arrow-func-declare-arguments-assign.js: Removed.
• test262/test/language/literals/string/legacy-non-octal-escape-sequence-1-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-2-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-3-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-4-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-5-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-6-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-7-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-8-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/literals/string/legacy-non-octal-escape-sequence-9-strict-explicit-pragma.js: Added.

(invalid):

• test262/test/language/module-code/export-expname-binding-string.js:
• test262/test/language/module-code/export-expname-from-as-unpaired-surrogate.js: Added.
• test262/test/language/module-code/export-expname-from-star-unpaired-surrogate.js: Added.
• test262/test/language/module-code/export-expname-from-unpaired-surrogate.js: Added.
• test262/test/language/module-code/export-expname-import-unpaired-surrogate.js: Added.
• test262/test/language/module-code/export-expname-string-binding.js: Added.

(foo):

• test262/test/language/module-code/export-expname-unpaired-surrogate.js: Added.

(Foo):

• test262/test/language/module-code/export-expname_FIXTURE.js:
• test262/test262-Revision.txt:

9:43 AM Changeset in webkit [269736] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Remove obsolete buildHorizon, eventHorizon and logHorizon properties from master_buildbot2.cfg
​https://bugs.webkit.org/show_bug.cgi?id=218818

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/master_buildbot2.cfg:

9:41 AM Changeset in webkit [269735] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Replace status with www in master.cfg
​https://bugs.webkit.org/show_bug.cgi?id=218822

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/master_buildbot2.cfg:

9:37 AM Changeset in webkit [269734] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] vertical-align: super and sub values are not supported yet.
​https://bugs.webkit.org/show_bug.cgi?id=218851

Reviewed by Antti Koivisto.

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

9:03 AM Changeset in webkit [269733] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] replace cslavePortnum with cprotocols in master_buildbot2.cfg
​https://bugs.webkit.org/show_bug.cgi?id=218819

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/master_buildbot2.cfg:

8:40 AM Changeset in webkit [269732] by Antti Koivisto

• 7 edits in trunk/Source/WebCore

[LFC][IFC] Use inline iterator in VisiblePosition::left/rightVisuallyDistinctCandidate
​https://bugs.webkit.org/show_bug.cgi?id=218848

Reviewed by Zalan Bujtas.

Less direct InlineBox access.

The patch also simplifies the iterator by removing separate LineRunIterator. Base RunIterator
is used instead and the incompatible traversal functions are explicitly hidden in TextRunIterator.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate const):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate const):

• editing/VisibleUnits.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):

• layout/integration/LayoutIntegrationLineIterator.cpp:

(WebCore::LayoutIntegration::LineIterator::firstRun const):
(WebCore::LayoutIntegration::LineIterator::lastRun const):
(WebCore::LayoutIntegration::LineIterator::logicalStartRunWithNode const):
(WebCore::LayoutIntegration::LineIterator::logicalEndRunWithNode const):
(WebCore::LayoutIntegration::LineIterator::closestRunForPoint):
(WebCore::LayoutIntegration::LineIterator::closestRunForLogicalLeftPosition):

• layout/integration/LayoutIntegrationLineIterator.h:
• layout/integration/LayoutIntegrationRunIterator.cpp:

(WebCore::LayoutIntegration::RunIterator::nextOnLine const):
(WebCore::LayoutIntegration::RunIterator::previousOnLine const):
(WebCore::LayoutIntegration::RunIterator::nextOnLineIgnoringLineBreak const):
(WebCore::LayoutIntegration::RunIterator::previousOnLineIgnoringLineBreak const):
(WebCore::LayoutIntegration::RunIterator::traverseNextOnLine):
(WebCore::LayoutIntegration::RunIterator::traversePreviousOnLine):
(WebCore::LayoutIntegration::RunIterator::traverseNextOnLineIgnoringLineBreak):
(WebCore::LayoutIntegration::RunIterator::traversePreviousOnLineIgnoringLineBreak):
(WebCore::LayoutIntegration::LineRunIterator::LineRunIterator): Deleted.
(WebCore::LayoutIntegration::LineRunIterator::traverseNextOnLine): Deleted.
(WebCore::LayoutIntegration::LineRunIterator::traversePreviousOnLine): Deleted.
(WebCore::LayoutIntegration::LineRunIterator::traverseNextOnLineIgnoringLineBreak): Deleted.
(WebCore::LayoutIntegration::LineRunIterator::traversePreviousOnLineIgnoringLineBreak): Deleted.
(WebCore::LayoutIntegration::lineRun): Deleted.

• layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::TextRunIterator::get const):
(WebCore::LayoutIntegration::LineRunIterator::LineRunIterator): Deleted.
(WebCore::LayoutIntegration::LineRunIterator::operator++): Deleted.

5:18 AM Changeset in webkit [269731] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Update CheckOutSource step for new buildbot (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=218802
<rdar://problem/71295484>

Unreviewed minor follow-up fix.

• CISupport/build-webkit-org/steps.py:

(CheckOutSource):

4:18 AM Changeset in webkit [269730] by commit-queue@webkit.org

• 10 edits
  1 add in trunk/LayoutTests

Simplify mainframe tests tiled-drawing/scrolling/scroll-snap
​https://bugs.webkit.org/show_bug.cgi?id=218757

Patch by Martin Robinson <​mrobinson@igalia.com> on 2020-11-12
Reviewed by Simon Fraser.

• tiled-drawing/scrolling/scroll-snap/resources/mainframe-scroll-snap-test.js: Added. Allows

sharing the mainframe scroll testing code between tests and reimplements them with Promises.

• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-legacy.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-with-margin.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-legacy.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-then-horizontal.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-with-margin.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html:

3:59 AM Changeset in webkit [269729] by commit-queue@webkit.org

• 21 edits in trunk

[WASM-References] Support imm for ref.null
​https://bugs.webkit.org/show_bug.cgi?id=218744

Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-11-12
Reviewed by Yusuke Suzuki.

JSTests:

Updated the Builder DSL and spec tests for ref.null extern/funcref.
Spec is here - ​https://webassembly.github.io/reference-types/core/.

• wasm/Builder.js:

(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):

• wasm/Builder_WebAssemblyBinary.js:

(const.putInitExpr):

• wasm/LowLevelBinary.js:

(export.default.LowLevelBinary.prototype.ref_type):

• wasm/WASM.js:
• wasm/references-spec-tests/ref_is_null.js:
• wasm/references-spec-tests/ref_null.js:
• wasm/references/externref_globals.js:
• wasm/references/externref_modules.js:
• wasm/references/externref_table.js:
• wasm/references/externref_table_import.js:

(makeImport):
(string_appeared_here.fullGC.assert.eq.1.exports.get_tbl.makeImport):
(string_appeared_here.fullGC.assert.eq.1.exports.get_tbl):

• wasm/references/func_ref.js:

(assert.eq.instance.exports.fix):

• wasm/references/is_null.js:

(checkRefNullWithI32ImmType):

• wasm/references/multitable.js:
• wasm/wasm.json:

Source/JavaScriptCore:

Updated ref.null according to the ref-types spec:
​https://github.com/WebAssembly/reference-types/.

• wasm/WasmFormat.h:

(JSC::Wasm::isRefType):

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

• wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::parseRefType):

• wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseInitExpr):

• wasm/wasm.json:

3:25 AM Changeset in webkit [269728] by svillar@igalia.com

• 3 edits
  2 adds in trunk

Crash in RenderBox::overrideContainingBlockContentHeight()
​https://bugs.webkit.org/show_bug.cgi?id=218504
<rdar://problem/70989103>

Reviewed by Zalan Bujtas.

Source/WebCore:

It should check the overriding widths map for vertical writing modes because it deals with logical sizes. Instead it was always checking the
overriding heights map and thus giving incorrect results.

Test: fast/flexbox/flex-column-vertical-rl-dynamic-child-crash.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::hasOverridingContainingBlockContentHeight const): Check gOverridingContainingBlockContentLogicalWidthMap
for vertical writing modes.

LayoutTests:

• fast/flexbox/flex-column-vertical-rl-dynamic-child-crash-expected.txt: Added.
• fast/flexbox/flex-column-vertical-rl-dynamic-child-crash.html: Added.

3:10 AM Changeset in webkit [269727] by Diego Pino Garcia

• 2 edits in trunk/Source/WebKit

[GTK] Unreviewed, non-unified build fix.

• WebProcess/Gamepad/WebGamepadProvider.cpp: Add missing Logging.h header.

2:50 AM Changeset in webkit [269726] by Alan Bujtas

• 39 edits
  1 copy
  1 delete in trunk

Show legacy line layout visual coverage instead of "simple line" layout.
​https://bugs.webkit.org/show_bug.cgi?id=218695

Reviewed by Antti Koivisto.

Source/WebCore:

Paint legacy line layout content with the debug shadow instead of the modern one (and use red instead of blue).

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::debugTextShadow): Deleted.

• layout/integration/LayoutIntegrationLineLayout.h:
• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintMarkedTextForeground):
(WebCore::InlineTextBox::debugTextShadow):

• rendering/InlineTextBox.h:

Source/WebKit:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLegacyLineLayoutVisualCoverageEnabled):
(WKPreferencesGetLegacyLineLayoutVisualCoverageEnabled):
(WKPreferencesSetSimpleLineLayoutDebugBordersEnabled): Deleted.
(WKPreferencesGetSimpleLineLayoutDebugBordersEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _legacyLineLayoutVisualCoverageEnabled]):
(-[WKPreferences _setLegacyLineLayoutVisualCoverageEnabled:]):
(-[WKPreferences _simpleLineLayoutDebugBordersEnabled]): Deleted.
(-[WKPreferences _setSimpleLineLayoutDebugBordersEnabled:]): Deleted.

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(-[WebPreferences legacyLineLayoutVisualCoverageEnabled]):
(-[WebPreferences setLegacyLineLayoutVisualCoverageEnabled:]):
(-[WebPreferences simpleLineLayoutDebugBordersEnabled]): Deleted.
(-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]): Deleted.

• WebView/WebPreferencesPrivate.h:

Source/WTF:

• Scripts/Preferences/WebPreferencesDebug.yaml:

Tools:

• MiniBrowser/mac/SettingsController.h:
• MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleLegacyLineLayoutVisualCoverageEnabled:]):
(-[SettingsController legacyLineLayoutVisualCoverageEnabled]):
(-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]): Deleted.
(-[SettingsController simpleLineLayoutDebugBordersEnabled]): Deleted.

• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]):

LayoutTests:

• fast/inline/simple-line-layout-16bit-content-expected-mismatch.html: Removed.
• fast/inline/simple-line-layout-16bit-content.html:
• fast/text/simple-line-layout-do-not-support-unicode-range-expected.html:
• fast/text/simple-line-layout-do-not-support-unicode-range.html:
• fast/text/simple-line-layout-line-box-contain-glyphs-expected.html:
• fast/text/simple-line-layout-line-box-contain-glyphs.html:
• fast/text/simple-line-layout-no-surrogate-pairs-expected.html:
• fast/text/simple-line-layout-no-surrogate-pairs.html:
• fast/text/simple-line-layout-simple-text-but-complex-font-path-expected.html:
• fast/text/simple-line-layout-simple-text-but-complex-font-path.html:
• fast/text/simple-line-layout-with-text-underline-position-expected.html:
• fast/text/simple-line-layout-with-text-underline-position.html:
• fast/text/simple-lines-float-expected.html:
• fast/text/simple-lines-float.html:
• fast/text/simple-lines-hover-expected.html:
• fast/text/simple-lines-hover.html:
• fast/text/simple-lines-multiple-renderers-expected.html:
• fast/text/simple-lines-multiple-renderers.html:

1:26 AM Changeset in webkit [269725] by Lauro Moura

• 2 edits in trunk/Tools

[WPE][TestWebKitAPI] Wait for RenderingState::Started to avoid flakiness
​https://bugs.webkit.org/show_bug.cgi?id=218841

Reviewed by Adrian Perez de Castro.

The external audio rendering test asked JS to play the video but
checked the condition right away. As with other tests, the full side
effects of the JS call might not have propagated, causing the
assertion to fail. This became especially visible after the build with
r269579.

So, like the other conditions in the test, add a method to wait for
the condition.

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(AudioRenderingWebViewTest::waitUntilStarted): Added

1:09 AM Changeset in webkit [269724] by Said Abou-Hallawa

• 25 edits in trunk/Source

[GPU Process] Implement DisplayList::ClipToImageBuffer item
​https://bugs.webkit.org/show_bug.cgi?id=218843

Reviewed by Tim Horton.

Source/WebCore:

Record the renderingResourceIdentifier of the ImageBuffer. At replaying
time, the renderingResourceIdentifier of the ClipToImageBuffer will be
resolved to an ImageBuffer. The actual clipping will be moved to an new
function named ImageBuffer::clipToMask().

• platform/graphics/ConcreteImageBuffer.h:
• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::clipToImageBuffer):

• platform/graphics/ImageBuffer.h:
• platform/graphics/ImageBufferBackend.h:

(WebCore::ImageBufferBackend::clipToMask):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clipToImageBuffer): Deleted.

• platform/graphics/cairo/ImageBufferCairoBackend.cpp:

(WebCore::ImageBufferCairoBackend::clipToMask):

• platform/graphics/cairo/ImageBufferCairoBackend.h:
• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipToImageBuffer): Deleted.

• platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::clipToMask):

• platform/graphics/cg/ImageBufferCGBackend.h:
• platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::append):

• platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::copyTo const):

• platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

• platform/graphics/displaylists/DisplayListItemType.h:
• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::ClipToImageBuffer::apply const):
(WebCore::DisplayList::operator<<):

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::ClipToImageBuffer::ClipToImageBuffer):
(WebCore::DisplayList::ClipToImageBuffer::imageBufferIdentifier const):
(WebCore::DisplayList::ClipToImageBuffer::destinationRect const):

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::clipToImageBuffer):

• platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::applyItem):

• platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::clipToImageBuffer): Deleted.

• platform/graphics/win/ImageBufferDirect2DBackend.cpp:

(WebCore::ImageBufferDirect2DBackend::clipToMask):

• platform/graphics/win/ImageBufferDirect2DBackend.h:

Source/WebKit:

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::decodeItem):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

1:03 AM Changeset in webkit [269723] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit

Unreviewed follow-up to r268965.

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_get_enable_accelerated_2d_canvas):
Use the FALSE identifier, following GLib styling guidelines.

12:56 AM Changeset in webkit [269722] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

[JSC] Skip stress/lars-sab-workers.js on arm32
​https://bugs.webkit.org/show_bug.cgi?id=218797

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-12
Reviewed by Žan Doberšek.

The test is currently flaky on arm32 when run in bytecode-cache mode.
Skip pending further investigation.

• stress/lars-sab-workers.js:

12:47 AM Changeset in webkit [269721] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK] Swipe navigation shadow is blurry on hidpi
​https://bugs.webkit.org/show_bug.cgi?id=218800

Patch by Alexander Mikhaylenko <​exalm7659@gmail.com> on 2020-11-12
Reviewed by Carlos Garcia Campos.

• UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::createElementPattern): Scale surface size and set its scale factor.
(WebKit::ViewGestureController::beginSwipeGesture): Pass scale factor to createElementPattern().

12:21 AM Changeset in webkit [269720] by ysuzuki@apple.com

• 2 edits in trunk/JSTests

Unreviewed, rebaseline test262's config.yaml part 2

test262 bot is using Catalina, it should use Big Sur. filed in [1].

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=218844

• test262/config.yaml:

Nov 11, 2020:

11:57 PM Changeset in webkit [269719] by ysuzuki@apple.com

• 3 edits in trunk/JSTests

Unreviewed, rebaseline test262's config.yaml

test262 bot is using Catalina, it should use Big Sur. filed in [1].

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=218844

• test262/config.yaml:
• test262/expectations.yaml:

10:30 PM Changeset in webkit [269718] by BJ Burg

• 3 edits in trunk/Source/WebKit

REGRESSION(r267411): Unable to "Start Element Selection" with Web Inspector closed
​https://bugs.webkit.org/show_bug.cgi?id=218838
<rdar://problem/71158215>

Reviewed by Devin Rousso.

The inspector side of the connection between WebInspector (inspected WebProcess) and
WebInspectorUI (inspector WebProcess) was mistakenly removed in r267411. Revert those changes.
Without a valid frontend connection, WebInspector cannot forward some IPC messages
to WebInspectorUI including StartElementSelection.

• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::updateConnection):
(WebKit::WebInspectorUI::closeWindow):

• WebProcess/Inspector/WebInspectorUI.h:

10:24 PM Changeset in webkit [269717] by commit-queue@webkit.org

• 3 edits in trunk

[css-grid] Percentage height on replaced item with scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=191462

Patch by Ziran Sun <Ziran Sun> on 2020-11-11
Reviewed by Manuel Rego Casasnovas.

This CL is to subtract scrollbar in computeReplacedLogicalHeightUsing().
In RenderBox::computeReplacedLogicalHeightUsing() we should also subtract
scrollbarLogicalHeight() when calculating stretchHeight. Without this subtraction,
it caused issues to resolve the percentage heights on grid item replaced children,
if the grid item has a scrollbar.

It ports the changes from the following patch at Chromium:
​https://bugs.chromium.org/p/chromium/issues/detail?id=837141
Test files were already ported in WPT at
​https://github.com/web-platform-tests/wpt/commit/538eedafb15733c6113b44998170a6bbdae7518b

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):

10:09 PM Changeset in webkit [269716] by Said Abou-Hallawa

• 21 edits in trunk/Source

[GPU Process] Delete the DisplayList items: DrawImage and DrawTiledImage
​https://bugs.webkit.org/show_bug.cgi?id=218839

Reviewed by Tim Horton.

Source/WebCore:

This is clean up left from r269708. These DisplayList items are not needed
anymore. The default implementation of the recording functions in the super
classes of GraphicsContextImpl was to call Image::draw() or Image::drawTiled()
which we do right now by not recording in the functions:
GraphicsContext::drawImage() and GraphicsContext::drawTiledImage().

• platform/graphics/GraphicsContextImpl.cpp:

(WebCore::GraphicsContextImpl::drawImageImpl): Deleted.
(WebCore::GraphicsContextImpl::drawTiledImageImpl): Deleted.

• platform/graphics/GraphicsContextImpl.h:
• platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawImage): Deleted.
(WebCore::GraphicsContextImplCairo::drawTiledImage): Deleted.

• platform/graphics/cairo/GraphicsContextImplCairo.h:
• platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::append):

• platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawImage):

• platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::copyTo const):

• platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

• platform/graphics/displaylists/DisplayListItemType.h:
• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::DrawImage::apply const): Deleted.
(WebCore::DisplayList::DrawTiledImage::apply const): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::apply const): Deleted.

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawImage::DrawImage): Deleted.
(WebCore::DisplayList::DrawImage::image const): Deleted.
(WebCore::DisplayList::DrawImage::source const): Deleted.
(WebCore::DisplayList::DrawImage::destination const): Deleted.
(WebCore::DisplayList::DrawImage::globalBounds const): Deleted.
(WebCore::DisplayList::DrawImage::localBounds const): Deleted.
(WebCore::DisplayList::DrawImage::encode const): Deleted.
(WebCore::DisplayList::DrawImage::decode): Deleted.
(WebCore::DisplayList::DrawTiledImage::image const): Deleted.
(WebCore::DisplayList::DrawTiledImage::source const): Deleted.
(WebCore::DisplayList::DrawTiledImage::destination const): Deleted.
(WebCore::DisplayList::DrawTiledImage::tileSize const): Deleted.
(WebCore::DisplayList::DrawTiledImage::spacing const): Deleted.
(WebCore::DisplayList::DrawTiledImage::DrawTiledImage): Deleted.
(WebCore::DisplayList::DrawTiledImage::globalBounds const): Deleted.
(WebCore::DisplayList::DrawTiledImage::localBounds const): Deleted.
(WebCore::DisplayList::DrawTiledImage::encode const): Deleted.
(WebCore::DisplayList::DrawTiledImage::decode): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::DrawTiledScaledImage): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::image const): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::source const): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::destination const): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::globalBounds const): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::localBounds const): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::encode const): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::decode): Deleted.

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawImage): Deleted.
(WebCore::DisplayList::Recorder::drawTiledImage): Deleted.

• platform/graphics/displaylists/DisplayListRecorder.h:
• platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawImage): Deleted.
(Nicosia::CairoOperationRecorder::drawTiledImage): Deleted.

• platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
• platform/graphics/win/GraphicsContextImplDirect2D.cpp:

(WebCore::GraphicsContextImplDirect2D::drawImage): Deleted.
(WebCore::GraphicsContextImplDirect2D::drawTiledImage): Deleted.

• platform/graphics/win/GraphicsContextImplDirect2D.h:

Source/WebKit:

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::decodeItem):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

9:49 PM Changeset in webkit [269715] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

Unreviewed, GTK Ubuntu LTS build fix after r269662.

• dom/BoundaryPoint.cpp:

6:53 PM Changeset in webkit [269714] by Chris Dumez

• 5 edits in trunk/Source

Add RunLoop::Timer constructor taking in a WTF::Function
​https://bugs.webkit.org/show_bug.cgi?id=218828

Reviewed by Darin Adler.

Source/WebKit:

Use the new RunLoop::Timer constructor to simplify the code a bit.

• UIProcess/WebProcessPool.cpp:

(WebKit::m_resetGPUProcessCrashCountTimer):

• UIProcess/WebProcessPool.h:

Source/WTF:

Add RunLoop::Timer constructor taking in a WTF::Function instead of a function pointer.
This is similar to what was done for WebCore::Timer.

• wtf/RunLoop.h:

6:34 PM Changeset in webkit [269713] by weinig@apple.com

• 10 edits in trunk

Move more WebKitLegacy preferences bound to Settings to WebPreferences.yaml
​https://bugs.webkit.org/show_bug.cgi?id=218826

Reviewed by Tim Horton.

Source/WebCore:

• page/Settings.yaml:

Move AcceleratedCompositingForFixedPositionEnabled, ForceWebGLUsesLowPower,
RubberBandingForSubScrollableRegionsEnabled, ShrinksStandaloneImagesToFit and
VisualViewportEnabled to WebPreferences.yaml

Source/WebKitLegacy/mac:

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
Remove manual defaults for ShrinksStandaloneImagesToFit and ForceWebGLUsesLowPower
now they are generated.

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Remove manual setting of AcceleratedCompositingForFixedPositionEnabled, ForceWebGLUsesLowPower,
RubberBandingForSubScrollableRegionsEnabled, ShrinksStandaloneImagesToFit and
VisualViewportEnabled now that they are generated.

Source/WTF:

• Scripts/Preferences/WebPreferences.yaml:

Move AcceleratedCompositingForFixedPositionEnabled, ForceWebGLUsesLowPower,
RubberBandingForSubScrollableRegionsEnabled, ShrinksStandaloneImagesToFit and
VisualViewportEnabled to WebPreferences.yaml

Tools:

• DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):
Switch to using TestOptions for ShrinksStandaloneImagesToFit now that it is supported.

6:04 PM Changeset in webkit [269712] by wilander@apple.com

• 84 edits
  34 copies
  7 moves
  10 adds
  4 deletes in trunk

PCM: Change from ad-click-attribution to private-click-measurement (in all forms, including .well-known URL)
​https://bugs.webkit.org/show_bug.cgi?id=218730
<rdar://problem/71094296>

Reviewed by Alex Christensen.

Change to the official name of the proposed standard Private Click Measurement
​https://github.com/privacycg/private-click-measurement.

This includes a change of the reporting URL from
"/.well-known/ad-click-attribution/" to
"/.well-known/private-click-measurement/".

Source/JavaScriptCore:

• inspector/ConsoleMessage.cpp:

(Inspector::messageSourceValue):

• inspector/protocol/Console.json:
• inspector/protocol/Page.json:
• runtime/ConsoleClient.cpp:

(JSC::appendMessagePrefix):

• runtime/ConsoleTypes.h:

Source/WebCore:

Tests: http/tests/contentextensions/block-private-click-measurement.html

http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html
http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html
http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority.html
http/tests/privateClickMeasurement/clear-through-website-data-removal.html
http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session.html
http/tests/privateClickMeasurement/expired-attributions-removed.html
http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority.html
http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority.html
http/tests/privateClickMeasurement/second-conversion-with-higher-priority.html
http/tests/privateClickMeasurement/second-conversion-with-lower-priority.html
http/tests/privateClickMeasurement/send-attribution-conversion-request.html
http/tests/privateClickMeasurement/store-disabled-in-ephemeral-session.html
http/tests/privateClickMeasurement/store-private-click-measurement.html
inspector/page/overrideSetting-PrivateClickMeasurementDebugModeEnabled.html

• Headers.cmake:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parsePrivateClickMeasurement const):
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::HTMLAnchorElement::parseAdClickAttribution const): Deleted.

• html/HTMLAnchorElement.h:
• html/HTMLAnchorElement.idl:
• inspector/InspectorClient.h:
• inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::overrideSetting):

• inspector/agents/page/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::getLoggingChannels):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):

• loader/FrameLoader.h:
• loader/NavigationAction.h:

(WebCore::NavigationAction::privateClickMeasurement const):
(WebCore::NavigationAction::setPrivateClickMeasurement):
(WebCore::NavigationAction::adClickAttribution const): Deleted.
(WebCore::NavigationAction::setAdClickAttribution): Deleted.

• loader/PrivateClickMeasurement.cpp: Renamed from Source/WebCore/loader/AdClickAttribution.cpp.

(WebCore::PrivateClickMeasurement::isValid const):
(WebCore::PrivateClickMeasurement::parseConversionRequest):
(WebCore::PrivateClickMeasurement::convertAndGetEarliestTimeToSend):
(WebCore::PrivateClickMeasurement::markAsExpired):
(WebCore::PrivateClickMeasurement::hasExpired const):
(WebCore::PrivateClickMeasurement::hasHigherPriorityThan const):
(WebCore::PrivateClickMeasurement::reportURL const):
(WebCore::PrivateClickMeasurement::json const):
(WebCore::PrivateClickMeasurement::markConversionAsSent):
(WebCore::PrivateClickMeasurement::wasConversionSent const):
(WebCore::PrivateClickMeasurement::toString const):
(WebCore::PrivateClickMeasurement::debugModeEnabled):

• loader/PrivateClickMeasurement.h: Renamed from Source/WebCore/loader/AdClickAttribution.h.

(WebCore::PrivateClickMeasurement::Campaign::Campaign):
(WebCore::PrivateClickMeasurement::Campaign::isValid const):
(WebCore::PrivateClickMeasurement::Source::Source):
(WebCore::PrivateClickMeasurement::Source::operator== const):
(WebCore::PrivateClickMeasurement::Source::matches const):
(WebCore::PrivateClickMeasurement::Source::isHashTableDeletedValue const):
(WebCore::PrivateClickMeasurement::Source::deletedValue):
(WebCore::PrivateClickMeasurement::Source::constructDeletedValue):
(WebCore::PrivateClickMeasurement::Source::deleteValue):
(WebCore::PrivateClickMeasurement::Source::isDeletedValue const):
(WebCore::PrivateClickMeasurement::SourceHash::hash):
(WebCore::PrivateClickMeasurement::SourceHash::equal):
(WebCore::PrivateClickMeasurement::Destination::Destination):
(WebCore::PrivateClickMeasurement::Destination::operator== const):
(WebCore::PrivateClickMeasurement::Destination::matches const):
(WebCore::PrivateClickMeasurement::Destination::isHashTableDeletedValue const):
(WebCore::PrivateClickMeasurement::Destination::deletedValue):
(WebCore::PrivateClickMeasurement::Destination::constructDeletedValue):
(WebCore::PrivateClickMeasurement::Destination::deleteValue):
(WebCore::PrivateClickMeasurement::Destination::isDeletedValue const):
(WebCore::PrivateClickMeasurement::DestinationHash::hash):
(WebCore::PrivateClickMeasurement::DestinationHash::equal):
(WebCore::PrivateClickMeasurement::Priority::Priority):
(WebCore::PrivateClickMeasurement::Conversion::Conversion):
(WebCore::PrivateClickMeasurement::Conversion::isValid const):
(WebCore::PrivateClickMeasurement::PrivateClickMeasurement):
(WebCore::PrivateClickMeasurement::source const):
(WebCore::PrivateClickMeasurement::destination const):
(WebCore::PrivateClickMeasurement::earliestTimeToSend const):
(WebCore::PrivateClickMeasurement::isEmpty const):
(WebCore::PrivateClickMeasurement::encode const):
(WebCore::PrivateClickMeasurement::decode):
(WebCore::PrivateClickMeasurement::Conversion::encode const):
(WebCore::PrivateClickMeasurement::Conversion::decode):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::Source>::emptyValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::Source>::constructDeletedValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::Source>::isDeletedValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::Destination>::emptyValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::Destination>::constructDeletedValue):
(WTF::HashTraits<WebCore::PrivateClickMeasurement::Destination>::isDeletedValue):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::privateClickMeasurementDebugModeEnabled const):
(WebCore::RuntimeEnabledFeatures::setPrivateClickMeasurementDebugModeEnabled):
(WebCore::RuntimeEnabledFeatures::adClickAttributionDebugModeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setAdClickAttributionDebugModeEnabled): Deleted.

• platform/Logging.h:

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Main.js:
• UserInterface/Models/ConsoleMessage.js:
• UserInterface/Models/IssueMessage.js:

(WI.IssueMessage):

• UserInterface/Protocol/Legacy/14.0/InspectorBackendCommands.js:

Source/WebKit:

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::setPrivateClickMeasurementDebugMode):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::storePrivateClickMeasurement):
(WebKit::NetworkProcess::dumpPrivateClickMeasurement):
(WebKit::NetworkProcess::clearPrivateClickMeasurement):
(WebKit::NetworkProcess::setPrivateClickMeasurementOverrideTimerForTesting):
(WebKit::NetworkProcess::setPrivateClickMeasurementConversionURLForTesting):
(WebKit::NetworkProcess::markPrivateClickMeasurementsAsExpiredForTesting):
(WebKit::NetworkProcess::setAdClickAttributionDebugMode): Deleted.
(WebKit::NetworkProcess::storeAdClickAttribution): Deleted.
(WebKit::NetworkProcess::dumpAdClickAttribution): Deleted.
(WebKit::NetworkProcess::clearAdClickAttribution): Deleted.
(WebKit::NetworkProcess::setAdClickAttributionOverrideTimerForTesting): Deleted.
(WebKit::NetworkProcess::setAdClickAttributionConversionURLForTesting): Deleted.
(WebKit::NetworkProcess::markAdClickAttributionsAsExpiredForTesting): Deleted.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):

• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::storePrivateClickMeasurement):
(WebKit::NetworkSession::handlePrivateClickMeasurementConversion):
(WebKit::NetworkSession::dumpPrivateClickMeasurement):
(WebKit::NetworkSession::clearPrivateClickMeasurement):
(WebKit::NetworkSession::clearPrivateClickMeasurementForRegistrableDomain):
(WebKit::NetworkSession::setPrivateClickMeasurementOverrideTimerForTesting):
(WebKit::NetworkSession::setPrivateClickMeasurementConversionURLForTesting):
(WebKit::NetworkSession::markPrivateClickMeasurementsAsExpiredForTesting):
(WebKit::NetworkSession::storeAdClickAttribution): Deleted.
(WebKit::NetworkSession::handleAdClickAttributionConversion): Deleted.
(WebKit::NetworkSession::dumpAdClickAttribution): Deleted.
(WebKit::NetworkSession::clearAdClickAttribution): Deleted.
(WebKit::NetworkSession::clearAdClickAttributionForRegistrableDomain): Deleted.
(WebKit::NetworkSession::setAdClickAttributionOverrideTimerForTesting): Deleted.
(WebKit::NetworkSession::setAdClickAttributionConversionURLForTesting): Deleted.
(WebKit::NetworkSession::markAdClickAttributionsAsExpiredForTesting): Deleted.

• NetworkProcess/NetworkSession.h:
• NetworkProcess/PrivateClickMeasurementManager.cpp: Renamed from Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp.

(WebKit::PrivateClickMeasurementManager::storeUnconverted):
(WebKit::PrivateClickMeasurementManager::handleConversion):
(WebKit::PrivateClickMeasurementManager::startTimer):
(WebKit::PrivateClickMeasurementManager::convert):
(WebKit::PrivateClickMeasurementManager::fireConversionRequest):
(WebKit::PrivateClickMeasurementManager::firePendingConversionRequests):
(WebKit::PrivateClickMeasurementManager::clear):
(WebKit::PrivateClickMeasurementManager::clearForRegistrableDomain):
(WebKit::PrivateClickMeasurementManager::clearExpired):
(WebKit::PrivateClickMeasurementManager::toString const):
(WebKit::PrivateClickMeasurementManager::setConversionURLForTesting):
(WebKit::PrivateClickMeasurementManager::markAllUnconvertedAsExpiredForTesting):
(WebKit::PrivateClickMeasurementManager::debugModeEnabled const):

• NetworkProcess/PrivateClickMeasurementManager.h: Renamed from Source/WebKit/NetworkProcess/AdClickAttributionManager.h.

(WebKit::PrivateClickMeasurementManager::PrivateClickMeasurementManager):
(WebKit::PrivateClickMeasurementManager::m_sessionID):
(WebKit::PrivateClickMeasurementManager::setPingLoadFunction):
(WebKit::PrivateClickMeasurementManager::setOverrideTimerForTesting):

• Platform/Logging.h:
• Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):

• Shared/NavigationActionData.h:
• Shared/WebsiteData/WebsiteData.cpp:

(WebKit::WebsiteData::ownerProcess):

• Shared/WebsiteData/WebsiteDataType.h:
• Sources.txt:
• UIProcess/API/APINavigation.h:

(API::Navigation::privateClickMeasurement const):
(API::Navigation::adClickAttribution const): Deleted.

• UIProcess/API/C/WKPage.cpp:

(WKPageDumpPrivateClickMeasurement):
(WKPageClearPrivateClickMeasurement):
(WKPageSetPrivateClickMeasurementOverrideTimerForTesting):
(WKPageSetPrivateClickMeasurementConversionURLForTesting):
(WKPageMarkPrivateClickMeasurementsAsExpiredForTesting):
(WKPageDumpAdClickAttribution): Deleted.
(WKPageClearAdClickAttribution): Deleted.
(WKPageSetAdClickAttributionOverrideTimerForTesting): Deleted.
(WKPageSetAdClickAttributionConversionURLForTesting): Deleted.
(WKPageMarkAdClickAttributionsAsExpiredForTesting): Deleted.

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreClearPrivateClickMeasurementsThroughWebsiteDataRemoval):
(WKWebsiteDataStoreClearAdClickAttributionsThroughWebsiteDataRemoval): Deleted.

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:

(dataTypesToString):

_WKWebsiteDataTypeAdClickAttributions still supported.
_WKWebsiteDataTypePrivateClickMeasurements added.

• UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:

(WebKit::toWebsiteDataType):

_WKWebsiteDataTypeAdClickAttributions still supported and mapped to
WebsiteDataType::PrivateClickMeasurements.

(WebKit::toWKWebsiteDataTypes):

• UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:

_WKWebsiteDataTypeAdClickAttributions still supported.
_WKWebsiteDataTypePrivateClickMeasurements added.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

_WKWebsiteDataTypeAdClickAttributions still supported.
_WKWebsiteDataTypePrivateClickMeasurements added.

(+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::setDeveloperPreferenceOverride):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::setPrivateClickMeasurementDebugMode):
(WebKit::NetworkProcessProxy::setAdClickAttributionDebugMode): Deleted.

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::dumpPrivateClickMeasurement):
(WebKit::WebPageProxy::clearPrivateClickMeasurement):
(WebKit::WebPageProxy::setPrivateClickMeasurementOverrideTimerForTesting):
(WebKit::WebPageProxy::setPrivateClickMeasurementConversionURLForTesting):
(WebKit::WebPageProxy::markPrivateClickMeasurementsAsExpiredForTesting):
(WebKit::WebPageProxy::dumpAdClickAttribution): Deleted.
(WebKit::WebPageProxy::clearAdClickAttribution): Deleted.
(WebKit::WebPageProxy::setAdClickAttributionOverrideTimerForTesting): Deleted.
(WebKit::WebPageProxy::setAdClickAttributionConversionURLForTesting): Deleted.
(WebKit::WebPageProxy::markAdClickAttributionsAsExpiredForTesting): Deleted.

• UIProcess/WebPageProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setPrivateClickMeasurementDebugMode):
(WebKit::WebsiteDataStore::setAdClickAttributionDebugMode): Deleted.

• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebChromeClient.mm:

(stringForMessageSource):

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(-[WebPreferences privateClickMeasurementEnabled]):
(-[WebPreferences setPrivateClickMeasurementEnabled:]):
(-[WebPreferences adClickAttributionEnabled]): Deleted.
(-[WebPreferences setAdClickAttributionEnabled:]): Deleted.

• WebView/WebPreferencesPrivate.h:

Source/WTF:

• Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

• DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Removed.
• TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp: Added.

(TestWebKitAPI::TEST):

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::dumpPrivateClickMeasurement):
(WTR::TestRunner::clearPrivateClickMeasurement):
(WTR::TestRunner::clearPrivateClickMeasurementsThroughWebsiteDataRemoval):
(WTR::TestRunner::setPrivateClickMeasurementOverrideTimerForTesting):
(WTR::TestRunner::setPrivateClickMeasurementConversionURLForTesting):
(WTR::TestRunner::markPrivateClickMeasurementsAsExpiredForTesting):
(WTR::TestRunner::dumpAdClickAttribution): Deleted.
(WTR::TestRunner::clearAdClickAttribution): Deleted.
(WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval): Deleted.
(WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting): Deleted.
(WTR::TestRunner::setAdClickAttributionConversionURLForTesting): Deleted.
(WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::PrivateClickMeasurementStringResultCallbackContext::PrivateClickMeasurementStringResultCallbackContext):
(WTR::privateClickMeasurementStringResultCallback):
(WTR::TestController::dumpPrivateClickMeasurement):
(WTR::PrivateClickMeasurementVoidCallbackContext::PrivateClickMeasurementVoidCallbackContext):
(WTR::privateClickMeasurementVoidCallback):
(WTR::TestController::clearPrivateClickMeasurement):
(WTR::TestController::clearPrivateClickMeasurementsThroughWebsiteDataRemoval):
(WTR::TestController::setPrivateClickMeasurementOverrideTimerForTesting):
(WTR::TestController::setPrivateClickMeasurementConversionURLForTesting):
(WTR::TestController::markPrivateClickMeasurementsAsExpiredForTesting):
(WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext): Deleted.
(WTR::adClickAttributionStringResultCallback): Deleted.
(WTR::TestController::dumpAdClickAttribution): Deleted.
(WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext): Deleted.
(WTR::adClickAttributionVoidCallback): Deleted.
(WTR::TestController::clearAdClickAttribution): Deleted.
(WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval): Deleted.
(WTR::TestController::setAdClickAttributionOverrideTimerForTesting): Deleted.
(WTR::TestController::setAdClickAttributionConversionURLForTesting): Deleted.
(WTR::TestController::markAdClickAttributionsAsExpiredForTesting): Deleted.

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::dumpPrivateClickMeasurement):
(WTR::TestInvocation::dumpAdClickAttribution): Deleted.

• WebKitTestRunner/TestInvocation.h:

LayoutTests:

• TestExpectations:
• http/tests/adClickAttribution/attribution-conversion-through-cross-site-image-redirect-expected.txt: Removed.
• http/tests/adClickAttribution/expired-attributions-removed-expected.txt: Removed.
• http/tests/adClickAttribution/resources/redirectToConversionOnIPAddress.php: Removed.
• http/tests/adClickAttribution/store-ad-click-attribution-expected.txt: Removed.
• http/tests/adClickAttribution/store-disabled-in-ephemeral-session-expected.txt: Removed.
• http/tests/contentextensions/block-ad-click-attribution-expected.txt: Removed.
• http/tests/contentextensions/block-private-click-measurement-expected.txt: Added.
• http/tests/contentextensions/block-private-click-measurement.html: Renamed from LayoutTests/http/tests/contentextensions/block-ad-click-attribution.html.
• http/tests/contentextensions/block-private-click-measurement.html.json: Renamed from LayoutTests/http/tests/contentextensions/block-ad-click-attribution.html.json.
• http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-reflect-expected.txt.
• http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html: Renamed from LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-reflect.html.
• http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt.
• http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html: Renamed from LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation.html.
• http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt: Added.
• http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html: Renamed from LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-cross-site-image-redirect.html.
• http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-in-new-window-expected.txt.
• http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html: Renamed from LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-in-new-window.html.
• http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority-expected.txt.
• http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html: Renamed from LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority.html.
• http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority-expected.txt.
• http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority.html: Renamed from LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html.
• http/tests/privateClickMeasurement/clear-through-website-data-removal-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/clear-through-website-data-removal-expected.txt.
• http/tests/privateClickMeasurement/clear-through-website-data-removal.html: Renamed from LayoutTests/http/tests/adClickAttribution/clear-through-website-data-removal.html.
• http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session-expected.txt.
• http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session.html: Renamed from LayoutTests/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html.
• http/tests/privateClickMeasurement/expired-attributions-removed-expected.txt: Added.
• http/tests/privateClickMeasurement/expired-attributions-removed.html: Renamed from LayoutTests/http/tests/adClickAttribution/expired-attributions-removed.html.
• http/tests/privateClickMeasurement/resources/conversionFilePath.php: Renamed from LayoutTests/http/tests/adClickAttribution/resources/conversionFilePath.php.
• http/tests/privateClickMeasurement/resources/conversionReport.php: Renamed from LayoutTests/http/tests/adClickAttribution/resources/conversionReport.php.
• http/tests/privateClickMeasurement/resources/convertAndPostMessageBack.html: Renamed from LayoutTests/http/tests/adClickAttribution/resources/convertAndPostMessageBack.html.
• http/tests/privateClickMeasurement/resources/getConversionData.php: Renamed from LayoutTests/http/tests/adClickAttribution/resources/getConversionData.php.
• http/tests/privateClickMeasurement/resources/redirectToConversion.php: Renamed from LayoutTests/http/tests/adClickAttribution/resources/redirectToConversion.php.
• http/tests/privateClickMeasurement/resources/redirectToConversionOnIPAddress.php: Added.
• http/tests/privateClickMeasurement/resources/util.js: Renamed from LayoutTests/http/tests/adClickAttribution/resources/util.js.

(prepareTest):
(tearDownAndFinish):

• http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-higher-priority-expected.txt.
• http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority.html: Renamed from LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html.
• http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-lower-priority-expected.txt.
• http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority.html: Renamed from LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html.
• http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/second-conversion-with-higher-priority-expected.txt.
• http/tests/privateClickMeasurement/second-conversion-with-higher-priority.html: Renamed from LayoutTests/http/tests/adClickAttribution/second-conversion-with-higher-priority.html.
• http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/second-conversion-with-lower-priority-expected.txt.
• http/tests/privateClickMeasurement/second-conversion-with-lower-priority.html: Renamed from LayoutTests/http/tests/adClickAttribution/second-conversion-with-lower-priority.html.
• http/tests/privateClickMeasurement/send-attribution-conversion-request-expected.txt: Renamed from LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request-expected.txt.
• http/tests/privateClickMeasurement/send-attribution-conversion-request.html: Renamed from LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html.
• http/tests/privateClickMeasurement/store-disabled-in-ephemeral-session-expected.txt: Added.
• http/tests/privateClickMeasurement/store-disabled-in-ephemeral-session.html: Renamed from LayoutTests/http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html.
• http/tests/privateClickMeasurement/store-private-click-measurement-expected.txt: Added.
• http/tests/privateClickMeasurement/store-private-click-measurement.html: Renamed from LayoutTests/http/tests/adClickAttribution/store-ad-click-attribution.html.
• inspector/page/overrideSetting-AdClickAttributionDebugModeEnabled-expected.txt: Removed.
• inspector/page/overrideSetting-PrivateClickMeasurementDebugModeEnabled-expected.txt: Added.
• inspector/page/overrideSetting-PrivateClickMeasurementDebugModeEnabled.html: Renamed from LayoutTests/inspector/page/overrideSetting-AdClickAttributionDebugModeEnabled.html.
• platform/mac-wk2/TestExpectations:
• platform/wk2/TestExpectations:

5:48 PM Changeset in webkit [269711] by Peng Liu

• 24 edits in trunk/Source

Update RemoteMediaPlayerMIMETypeCache to add the support for AVFoundationMSE media engine
​https://bugs.webkit.org/show_bug.cgi?id=218788

Reviewed by Eric Carlson.

Source/WebCore:

With this patch, we can create MSE media players (AVFoundationMSE) in the GPU process.

This patch cleans up MIMETypeCache, AVAssetMIMETypeCache, and
AVStreamDataParserMIMETypeCache. A media player factory and SourceBufferParserAVFObjC
will only need to use one MIMETypeCache, either AVAssetMIMETypeCache or
AVStreamDataParserMIMETypeCache, but not both.

To be consistent with MediaPlayerPrivateAVFoundationObjC, this patch renames
supportsType() of MediaPlayerPrivateMediaSourceAVFObjC to supportsTypeAndCodecs().

• platform/graphics/MIMETypeCache.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

• platform/graphics/MediaPlayer.h:
• platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::supportsKeySystemAndMimeType):
(WebCore::CDMPrivateMediaSourceAVFObjC::supportsMIMEType):

• platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.h:
• platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:
• platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.h:
• platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:

(WebCore::AVStreamDataParserMIMETypeCache::isAvailable const):
(WebCore::AVStreamDataParserMIMETypeCache::canDecodeType):
(WebCore::AVStreamDataParserMIMETypeCache::supportedTypes):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsTypeAndCodecs):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType): Deleted.

• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):

• platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:

(WebCore::SourceBufferParserAVFObjC::isContentTypeSupported):

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::canSwitchToType):

Source/WebKit:

Originally, RemoteMediaPlayerMIMETypeCache inherits from MIMETypeCache.
It needs to implement three functions: isAvailable(), canDecodeExtendedType(),
supportedTypes() through IPC messages, and the IPC message receivers in
RemoteMediaPlayerManagerProxy needs to repeat the work done by AVAssetMIMETypeCache
and AVStreamDataParserMIMETypeCache.

Actually, MediaPlayerRemoteFactory only needs two functions from
RemoteMediaPlayerMIMETypeCache: supportedTypes() and supportsTypeAndCodecs().
We can implement these two functions with IPC messages to RemoteMediaPlayerManagerProxy
and cache the results to avoid too many IPC messages. In addition, the implementation of
the IPC message receivers in RemoteMediaPlayerManagerProxy can reuse the implementation
of AVAssetMIMETypeCache and AVStreamDataParserMIMETypeCache.

• GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::supportsTypeAndCodecs):
(WebKit::RemoteMediaPlayerManagerProxy::canDecodeExtendedType): Deleted.

• GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
• GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
• WebProcess/GPU/media/RemoteAudioDestinationProxy.h:
• WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:
• WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.cpp:

(WebKit::RemoteMediaPlayerMIMETypeCache::addSupportedTypes):
(WebKit::RemoteMediaPlayerMIMETypeCache::supportedTypes):
(WebKit::RemoteMediaPlayerMIMETypeCache::supportsTypeAndCodecs):
(WebKit::RemoteMediaPlayerMIMETypeCache::mimeCache const): Deleted.
(WebKit::RemoteMediaPlayerMIMETypeCache::staticContainerTypeList): Deleted.
(WebKit::RemoteMediaPlayerMIMETypeCache::isUnsupportedContainerType): Deleted.
(WebKit::RemoteMediaPlayerMIMETypeCache::canDecodeExtendedType): Deleted.
(WebKit::RemoteMediaPlayerMIMETypeCache::initializeCache): Deleted.

• WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.h:
• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::getSupportedTypes):
(RemoteMediaPlayerManager::initialize):

5:47 PM Changeset in webkit [269710] by timothy_horton@apple.com

• 50 edits in trunk

Add minimal support for deep color IOSurface backing store to ImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=218816

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; will be covered by all deep color tests when GPU Process DOM rendering lands.

Make it possible to pass a ColorFormat into the ImageBuffer constructor,
and add RGB10 and RGB10A8 ColorFormats.

We don't currently support get/putImageData for deep color buffers, because
that is not needed for ImageBuffers backing RemoteLayerBackingStore (the motivation
for this), but if we eventually wanted to more generally support deep color ImageBuffers,
that's most of the remaining work.

Also, standardize on BGRA8 as the default ColorFormat for buffers.
iOS, Cairo, IOSurface, and ShareableBitmap all already use BGRA8 by default;
only ImageBuffer with CGBitmap backing store on macOS used RGBA8. So,
for sanity's sake (and so that it's easy to have a default passed into
the constructor), standardize on BGRA8.

• html/CustomPaintCanvas.cpp:

(WebCore::CustomPaintCanvas::copiedImage const):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer const):

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::createBufferForPainting const):

• html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createImageBuffer):

• page/Chrome.cpp:

(WebCore::Chrome::createImageBuffer const):

• page/Chrome.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::createImageBuffer const):

• platform/HostWindow.h:
• platform/graphics/ConcreteImageBuffer.h:

(WebCore::ConcreteImageBuffer::create):

• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::create):

• platform/graphics/ImageBuffer.h:

Plumbing ColorFormat around.

• platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::ImageBufferBackend):
(WebCore::ImageBufferBackend::toBGRAData const):
(WebCore::ImageBufferBackend::copyImagePixels const):
(WebCore::ImageBufferBackend::getImageData const):
(WebCore::ImageBufferBackend::putImageData):
Assert that copyImagePixels is always operating on a 8-bit buffer,
since that's all it supports for now.

• platform/graphics/ImageBufferBackend.h:

(WebCore::ImageBufferBackend::colorFormat const):
(WebCore::ImageBufferBackend::bytesPerRow const):
(WebCore::ImageBufferBackend::backendColorFormat const): Deleted.

• platform/graphics/RemoteVideoSample.cpp:

(WebCore::transferBGRAPixelBufferToIOSurface):

• platform/graphics/cairo/ImageBufferCairoBackend.h:
• platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::create):
(WebCore::ImageBufferCairoImageSurfaceBackend::ImageBufferCairoImageSurfaceBackend):

• platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.h:
• platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::createBitmapImageAfterScalingIfNeeded):
(WebCore::ImageBufferCGBackend::toCFData const):
(WebCore::copyImagePixelsAccelerated):

• platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:

(WebCore::ImageBufferCGBitmapBackend::create):
(WebCore::ImageBufferCGBitmapBackend::ImageBufferCGBitmapBackend):
(WebCore::ImageBufferCGBitmapBackend::copyNativeImage const):
Adopt ColorFormat and standardize on BGRA8.

• platform/graphics/cg/ImageBufferCGBitmapBackend.h:
• platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::create):
(WebCore::ImageBufferIOSurfaceBackend::ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::backendColorFormat const): Deleted.

• platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
• platform/graphics/cocoa/IOSurface.h:
• platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::IOSurface):
(WebCore::IOSurface::ensurePlatformContext):
(WebCore::IOSurface::format const):
(WebCore::IOSurface::formatForColorFormat):
(WebCore::operator<<):

• platform/graphics/displaylists/DisplayListImageBuffer.h:

(WebCore::DisplayList::ImageBuffer::create):

Source/WebKit:

• GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::create):
(WebKit::RemoteImageBuffer::RemoteImageBuffer):

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::imageBufferBackendWasCreated):
(WebKit::RemoteRenderingBackend::createImageBuffer):

• GPUProcess/graphics/RemoteRenderingBackend.h:
• GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• Scripts/webkit/messages.py:
• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::bytesPerPixel const):
(WebKit::RemoteLayerBackingStore::surfaceBufferFormat const):

• Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create):

• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _takeViewSnapshot]):

• WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::create):
(WebKit::ImageBufferShareableBitmapBackend::ImageBufferShareableBitmapBackend):

• WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::createBackend):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::imageBufferBackendWasCreated):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:
• WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableIOSurfaceBackend::create):

• WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createImageBuffer const):

• WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

• DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):

5:16 PM Changeset in webkit [269709] by Wenson Hsieh

• 6 edits in trunk

Add system trace points for the GPU process display list processing loop
​https://bugs.webkit.org/show_bug.cgi?id=218824

Reviewed by Simon Fraser.

Source/WebKit:

Capture the time spent applying display list items in the GPU process with a pair of new trace points, to aid
performance debugging and analysis.

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):

Source/WTF:

• wtf/SystemTracing.h:

Tools:

• Tracing/SystemTracePoints.plist:

4:59 PM Changeset in webkit [269708] by Said Abou-Hallawa

• 32 edits
  1 add in trunk/Source

[GPU Process] Cache the NativeImage in GPU Process and allow referencing it with its RemoteResourceIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=217596

Reviewed by Simon Fraser.

Source/WebCore:

In this patch all the drawImage functions will not be recorded as display
list items. Instead we are going to let them proceed till they reach lower
level calls such as drawNativeImage().

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::subsamplingLevelForScaleFactor):
Because we no longer record DrawImage, calling BitmapImage::draw() is now
allowed even if the GraphicsContext is backed by a DisplayList::Recorder.
If the image sub-sampling is allowed, which we do for iOS, this function
is going to be called. We need to guard using the platformContext by calling
hasPlatformContext() first.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
We have to let these function proceed till they end up calling the
DOM rendering for SVGImage, PDFDocumentImage::draw for pdf image and
drawNativeImage for the rest.

• platform/graphics/ImageBuffer.h:

Make ImageBuffer a CanMakeWeakPtr so we can have a HashMap whose values
are of type WeakPtr<ImageBuffer>.

• platform/graphics/NativeImage.cpp:

(WebCore::NativeImage::create):
(WebCore::NativeImage::NativeImage):
(WebCore::NativeImage::~NativeImage):

• platform/graphics/NativeImage.h:

(WebCore::NativeImage::renderingResourceIdentifier const):
(WebCore::NativeImage::setObserver):
Add an observer to NativeImage whose job is to observe when it is being
destroyed. Add also an renderingResourceIdentifier so it can be used to
reference the NativeImage in a NativeImageHashMap.

• platform/graphics/NativeImageReference.h: Added.

This definition can be used to encode/decode a Ref<NativeImage> for IPC
messages.

• platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::m_nativeImages):
(WebCore::DisplayList::DisplayList::operator=):
(WebCore::DisplayList::DisplayList::clear):

• platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::nativeImages const):
(WebCore::DisplayList::DisplayList::cacheImageBuffer):
(WebCore::DisplayList::DisplayList::cacheNativeImage):
Add the ability to cache the NativeImage in DisplayList such that its
renderingResourceIdentifier can be used when recording DrawNativeImage
and m_nativeImages can be used to access the NativeImage when replaying
back DrawNativeImage.

• platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::destroy):

• platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::isInlineItem):

• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::DrawNativeImage::apply const):
(WebCore::DisplayList::DrawNativeImage::DrawNativeImage): Deleted.

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawImageBuffer::DrawImageBuffer):
(WebCore::DisplayList::DrawImageBuffer::imageBufferIdentifier const):
(WebCore::DisplayList::DrawNativeImage::DrawNativeImage):
(WebCore::DisplayList::DrawNativeImage::imageIdentifier const):
(WebCore::DisplayList::DrawImageBuffer::renderingResourceIdentifier const): Deleted.
(WebCore::DisplayList::DrawNativeImage::encode const): Deleted.
(WebCore::DisplayList::DrawNativeImage::decode): Deleted.
DrawNativeImage is an inline item now. No encoding/decoding is needed.

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawImageBuffer):
(WebCore::DisplayList::Recorder::drawNativeImage):

• platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::cacheNativeImage):
Ask the DisplayList::Recorder::Delegate to cache the NativeImage.

• platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::Replayer):
(WebCore::DisplayList::Replayer::applyItem):

• platform/graphics/displaylists/DisplayListReplayer.h:

Resolve the renderingResourceIdentifier of DrawNativeImage to a NativeImage
from the m_nativeImages before drawing it.

Source/WebKit:

Recorder::drawNativeImage() will ensure the NativeImage is cached before
recording the DrawNativeImage item with the renderingResourceIdentifier.

Because RemoteImageBufferProxy is a superclass of DisplayList::Recorder::
Delegate, it will ensure the NativeImage is cached in its RemoteResourceCacheProxy.

If the NativeImage is registered in RemoteResourceCacheProxy for the first
time, it is going to be sent as an IPC message to GPU. Upon receiving this
message, RemoteRenderingBackend will cache this NativeImage in its
RemoteResourceCache. This message has to be received for any NativeImage
only once for its entire life time.

When flushing the DisplayList of any ImageBuffer, RemoteImageBuffer will
ensure the NativeImages are cached in the RemoteResourceCache are passed
to DisplayList::Replayer so it can use them to get NativeImage for every
DrawNativeImage with the same renderingResourceIdentifier it was recorded
with.

When NativeImage is bing destroyed, its destructor will call its observer
virtual method releaseNativeImage(). RemoteResourceCacheProxy will be a
superclass NativeImage::Observer so its overriding method will be called.
When RemoteResourceCacheProxy::releaseNativeImage() is called it is going
to delete the NativeImage from RemoteResourceCacheProxy and is going to
send a message to GPU to delete the corresponding NativeImage from
RemoteResourceCache via RemoteRenderingBackend::releaseRemoteResource().

• GPUProcess/graphics/RemoteImageBuffer.h:
• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::cacheNativeImage):
(WebKit::RemoteRenderingBackend::decodeItem):

• GPUProcess/graphics/RemoteRenderingBackend.h:
• GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::cacheNativeImage):
(WebKit::RemoteResourceCache::releaseRemoteResource):

• GPUProcess/graphics/RemoteResourceCache.h:

(WebKit::RemoteResourceCache::nativeImages const):

• Scripts/webkit/messages.py:
• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Ref<NativeImage>>::encode):
(IPC::ArgumentCoder<Ref<NativeImage>>::decode):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):
(WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::cacheNativeImage):
(WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::RemoteResourceCacheProxy):
(WebKit::RemoteResourceCacheProxy::cacheImageBuffer):
(WebKit::RemoteResourceCacheProxy::cachedImageBuffer):
(WebKit::RemoteResourceCacheProxy::cacheNativeImage):
(WebKit::RemoteResourceCacheProxy::releaseNativeImage):

• WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

4:37 PM Changeset in webkit [269707] by ysuzuki@apple.com

• 5 edits in trunk/JSTests

Unreviewed, fix wrong tests at the final clean up
​https://bugs.webkit.org/show_bug.cgi?id=213822

• stress/intl-datetimeformat-formatrange.js:
• stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:

(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt1.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt2.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt3.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt4.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt5.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.vm.icuVersion): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt6.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt7.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt8.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt9.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt10.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt11.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt12.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt13.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt14.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt15.formatRangeToParts): Deleted.
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt16.formatRangeToParts): Deleted.

• stress/intl-datetimeformat-formatrangetoparts-relevant-extensions.js:
• stress/intl-datetimeformat-formatrangetoparts.js:

4:25 PM Changeset in webkit [269706] by ysuzuki@apple.com

• 13 edits
  5 adds in trunk

[JSC] Implement Intl.DateTimeFormat.formatRangeToParts
​https://bugs.webkit.org/show_bug.cgi?id=213822
<rdar://problem/69328711>

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-datetimeformat-formatrange-relevant-extensions.js:
• stress/intl-datetimeformat-formatrange-should-not-handle-gregorian-change-date.js: Added.

(shouldBe):
(vm.icuHeaderVersion):

• stress/intl-datetimeformat-formatrange.js:

(shouldThrow):
(test):

• stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js: Added.

(shouldBe):
(compareParts):
(shouldThrow):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt1.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt2.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt3.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt4.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt5.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.vm.icuVersion):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt6.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt7.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt8.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt9.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt10.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt11.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt12.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt13.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt14.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt15.formatRangeToParts):
(Intl.DateTimeFormat.formatRangeToParts.compareParts.fmt16.formatRangeToParts):

• stress/intl-datetimeformat-formatrangetoparts-relevant-extensions.js: Added.

(shouldBe):
(compareParts):
(shouldThrow):

• stress/intl-datetimeformat-formatrangetoparts-should-not-handle-gregorian-change-date.js: Added.

(shouldBe):
(compareParts):
(vm.icuHeaderVersion):

• stress/intl-datetimeformat-formatrangetoparts.js: Added.

(shouldBe):
(compareParts):
(shouldThrow):

• test262/config.yaml:
• test262/expectations.yaml: This failure is because of CLDR data inside ICU. ICU 67 will fix them.

Source/JavaScriptCore:

This patch implements Intl.DateTimeFormat.formatRangeToParts. It is already stage-4 (included in the spec).
The inputs are date interval, and this function generates array of parts of formatted string of date interval.
Currently, required ICU APIs are draft status. So, for now, we track ABI changes, and use APIs with careful version checks.

However, currently, OpenSource macOS WebKit is built with specific ICU header (ICU 62 headers). So for now, we disable it
in OpenSource macOS WebKit build. But we enable it for Apple Internal SDK WebKit build. We can enable it if we include
multiple ICU header sets and select appropriate one against the linked ICU version. In the other platforms, they are using
corresponding ICU headers so that we can just enable it.

There are two interesting implementation topics.

1. From ICU 67, the signature of udtitvfmt_formatToResult is changed. We need to switch the implementation with fine grained ICU version checks.
2. udtitvfmt_formatToResult does not have an ability to configure gregorian calendar change date: before that date, the calendar is julian. In ECMAScript spec, we need to ignore this gregorian calendar change date, and we should handle all gregorian calendar dates as is even if the dates are older than gregorian calendar change date. However, since udtitvfmt_formatToResult does not offer the above ability, ICU automatically switches the calendar between gregorian and julian. To fix this issue, ICU 67 introduced udtitvfmt_formatCalendarToResult, which can take an explicit calendar for each input date so that we configure gregorian calendar change date. But this only exists after ICU 67. In the implementations using ICU 64-66, we just use udtitvfmt_formatToResult.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• runtime/IntlDateTimeFormat.cpp:

(JSC::UDateIntervalFormatDeleter::operator()):
(JSC::IntlDateTimeFormat::formatToParts const):
(JSC::definitelyAfterGregorianCalendarChangeDate):
(JSC::formattedValueFromDateRange):
(JSC::IntlDateTimeFormat::formatRange):
(JSC::IntlDateTimeFormat::formatRangeToParts):

• runtime/IntlDateTimeFormat.h:
• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::create):
(JSC::IntlDateTimeFormatPrototype::finishCreation):
(JSC::JSC_DEFINE_HOST_FUNCTION):

• runtime/IntlDateTimeFormatPrototype.h:
• runtime/OptionsList.h:

4:01 PM Changeset in webkit [269705] by Ryan Haddad

• 3 edits in trunk/Tools

[webkitpy] Bump CURRENT_VERSION to 11.0 for Mac port
​https://bugs.webkit.org/show_bug.cgi?id=218581

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/port/mac.py:

(MacPort):

• Scripts/webkitpy/port/mac_unittest.py:

(MacTest):
(MacTest.test_big_sur_baseline_search_path):

3:37 PM Changeset in webkit [269704] by weinig@apple.com

• 13 edits in trunk

Remove unused ExperimentalNotificationsEnabled setting
​https://bugs.webkit.org/show_bug.cgi?id=218813

Reviewed by Tim Horton.

Source/WebCore:

• page/Settings.yaml:

Remove ExperimentalNotificationsEnabled. It was unused.

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setExperimentalNotificationsEnabled:]):
(-[WebPreferences experimentalNotificationsEnabled]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Obsolete ExperimentalNotificationsEnabled preference as it does nothing.

Source/WebKitLegacy/win:

• WebPreferences.cpp:

(WebPreferences::setExperimentalNotificationsEnabled):
(WebPreferences::experimentalNotificationsEnabled):

• WebView.cpp:

(WebView::notifyPreferencesChanged):
Obsolete ExperimentalNotificationsEnabled preference as it does nothing.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):
Stop setting ExperimentalNotificationsEnabled to false. It does nothing.

2:49 PM Changeset in webkit [269703] by Chris Dumez

• 8 edits in trunk

Terminate WebProcesses if GPUProcess crashes more than twice in 30 seconds
​https://bugs.webkit.org/show_bug.cgi?id=218811
<rdar://problem/71292424>

Reviewed by Tim Horton.

Source/WebKit:

If the GPUProcess crashes more than twice in 30 seconds, we now terminate all WebProcesses
to try and get back into a good state. This is to avoid getting into a situation where
the GPUProcess is crash looping.

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::terminate):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::gpuProcessCrashed):
(WebKit::WebProcessPool::resetGPUProcessCrashCount):
(WebKit::WebProcessPool::terminateAllWebContentProcesses):

• UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

• TestWebKitAPI/cocoa/TestNavigationDelegate.h:
• TestWebKitAPI/cocoa/TestNavigationDelegate.mm:

(-[TestNavigationDelegate waitForWebContentProcessDidTerminate]):
(-[WKWebView _test_waitForWebContentProcessDidTerminate]):

2:12 PM Changeset in webkit [269702] by Ryan Haddad

• 1 edit
  8 adds in trunk/LayoutTests

Unreviewed test gardening, add Mojave specific baselines.

• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Added.
• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Added.
• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Added.
• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt: Added.
• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt: Added.
• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt: Added.
• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Added.
• platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt: Added.

1:44 PM Changeset in webkit [269701] by BJ Burg

• 34 edits
  10 copies
  5 adds in trunk

[Cocoa] Inspector Extensions: Add _WKInspectorExtension and related plumbing
​https://bugs.webkit.org/show_bug.cgi?id=217783
<rdar://problem/69968787>

Reviewed by Devin Rousso.

Source/WebCore:

• inspector/InspectorFrontendClient.h:
• inspector/InspectorFrontendClientLocal.h:

In order for WebInspectorUIExtensionController to work with remote and local
inspectors, it stores a weak pointer the inspector's InspectorFrontendClient.
Expose the frontend's page so that the frontend API dispatcher can dispatch to it.

Source/WebInspectorUI:

• UserInterface/Main.html: Add new files.

• UserInterface/Controllers/AppControllerBase.js:

(WI.AppControllerBase):
(WI.AppControllerBase.prototype.get extensionController):
Hang the extension controller off of the global singleton, as there can only be one.

• UserInterface/Controllers/WebInspectorExtensionController.js:

(WI.WebInspectorExtensionController):
(WI.WebInspectorExtensionController.prototype.registerExtension):
(WI.WebInspectorExtensionController.prototype.unregisterExtension):
Added. For now, just keep the UUIDs in a map and log the result.

• UserInterface/Models/WebInspectorExtension.js:

(WI.WebInspectorExtension):
(WI.WebInspectorExtension.prototype.get extensionID):
(WI.WebInspectorExtension.prototype.get displayName):
Added. This is a data object for now.

• UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.loadCompleted):
(InspectorFrontendAPI.registerExtension):
(InspectorFrontendAPI.unregisterExtension):
Added. Forward invocations to the extension controller.

Source/WebKit:

_WKInspectorExtension is new SPI that represents a Web Extension that uses the 'devtools'
API to interact with Web Inspector. An extension is associated with its _WKInspectorExtensionHost.
A WebKit client that supports Web Extensions can use this class to implement 'devtools' extension APIs.

Add _WKInspectorExtensionHost methods to register and unregister an extension.
Add plumbing so that the extension in registered in the frontend with WI.InspectorExtensionController.

Later patches will flesh out the needed functionality to implement rest of the 'devtools' API.

• Sources.txt:
• SourcesCocoa.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• WebKit.xcodeproj/project.pbxproj:

Add new files.

• Scripts/webkit/messages.py: If a message includes InspectorExtensionError,

then generate an include for InspectorExtensionTypes.h where it is declared.

• Shared/API/APIObject.h:
• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
New API object type.

• Shared/InspectorExtensionTypes.h: Added error code enum and useful type aliases.
• Shared/InspectorExtensionTypes.cpp:

(WebKit::inspectorExtensionErrorToString):

• UIProcess/API/APIInspectorExtension.h:
• UIProcess/API/APIInspectorExtension.cpp:

(API::InspectorExtension::create):
(API::InspectorExtension::InspectorExtension):
(API::InspectorExtension::~InspectorExtension):
Added. This is a placeholder object that's used for the wrapper system,
since we don't have single C++ objects for each extension to back the API object.

• UIProcess/API/Cocoa/_WKInspector.h:
• UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector registerExtensionWithID:displayName:completionHandler:]):
(-[_WKInspector unregisterExtension:completionHandler:]):
Implement new _WKInspectorExtensionHost methods. Send IPC to the Inspector web process.

• UIProcess/API/Cocoa/_WKInspectorExtension.h:
• UIProcess/API/Cocoa/_WKInspectorExtension.mm:

(-[_WKInspectorExtension initWithIdentifier:]):
(-[_WKInspectorExtension dealloc]):
(-[_WKInspectorExtension _apiObject]):
(-[_WKInspectorExtension extensionID]):
Added. This is a data object that's also used as a token to unregister the extension.

• UIProcess/API/Cocoa/_WKInspectorExtensionHost.h: Add new SPI.
• UIProcess/API/Cocoa/_WKInspectorExtensionInternal.h:

• UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
• UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(-[_WKRemoteWebInspectorViewController registerExtensionWithID:displayName:completionHandler:]):
(-[_WKRemoteWebInspectorViewController unregisterExtension:completionHandler:]):
Implement new _WKInspectorExtensionHost methods. Send IPC to the Inspector web process.

• UIProcess/Inspector/RemoteWebInspectorProxy.h:
• UIProcess/Inspector/RemoteWebInspectorProxy.messages.in: Add FrontendLoaded.

(WebKit::RemoteWebInspectorProxy::extensionController const): Added.

• UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::frontendLoaded):
(WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):
Set up the extension controller object after the frontend has been created.
Hook up the FrontendLoaded event sent from Inspector web process so that the
extension controller can be notified of when it's safe to message the frontend.

• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createFrontendPage):
(WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
(WebKit::WebInspectorProxy::frontendLoaded):
Set up the extension controller object after the frontend has been created.

• UIProcess/Inspector/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::extensionController const): Added.

• UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h:
• UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp: Added.

(WebKit::WebInspectorUIExtensionControllerProxy::WebInspectorUIExtensionControllerProxy):
(WebKit::WebInspectorUIExtensionControllerProxy::~WebInspectorUIExtensionControllerProxy):
(WebKit::WebInspectorUIExtensionControllerProxy::whenFrontendHasLoaded):
(WebKit::WebInspectorUIExtensionControllerProxy::inspectorFrontendLoaded):
(WebKit::WebInspectorUIExtensionControllerProxy::registerExtension):
(WebKit::WebInspectorUIExtensionControllerProxy::unregisterExtension):
Added. Forward API requests to the Web Inspector's web process to be evaluated in the frontend.

• WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.h:
• WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.cpp:

(WebKit::WebInspectorFrontendAPIDispatcher::dispatchCommand):
Add a more generic way to encode values to be passed as arguments to InspectorFrontendAPI.dispatch.

• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::closeWindow):

• WebProcess/Inspector/WebInspectorUI.h:

(WebKit::WebInspectorUI::frontendPage const): Added.
(WebKit::WebInspectorUI::frontendAPIDispatcher): Added.

• WebProcess/Inspector/WebInspectorUIExtensionController.h:
• WebProcess/Inspector/WebInspectorUIExtensionController.messages.in: Added.
• WebProcess/Inspector/WebInspectorUIExtensionController.cpp: Added.

(WebKit::WebInspectorUIExtensionController::WebInspectorUIExtensionController):
(WebKit::WebInspectorUIExtensionController::~WebInspectorUIExtensionController):
(WebKit::WebInspectorUIExtensionController::registerExtension):
(WebKit::WebInspectorUIExtensionController::unregisterExtension):
(WebKit::WebInspectorUIExtensionController::parseInspectorExtensionErrorFromResult):
Handle incoming messages by forwarding the associated command to WI.WebExtensionController
via InspectorFrontendAPI evaluations.

• UIProcess/API/Cocoa/_WKUserStyleSheet.h:
• UIProcess/API/Cocoa/_WKUserStyleSheet.mm:

Fallout from unified build chunking shifts.

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
Fallout from unified build chunking shifts, but more.

Tools:

Add API tests to exercise new methods of the _WKInspectorExtensionHost protocol.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New test file.
• TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtensionHost.mm: Added.

(resetGlobalState):
(-[UIDelegateForTestingInspectorExtensionHost _webView:didAttachLocalInspector:]):
(TEST):

1:09 PM Changeset in webkit [269700] by achristensen@apple.com

• 4 edits in trunk/Source

Define USE(LEGACY_CFNETWORK_DOWNLOADS)
​https://bugs.webkit.org/show_bug.cgi?id=218814

Reviewed by Geoffrey Garen.

Source/WebKit:

Mojave CFNetwork has a few download bugs I'll need to work around.
With this change I can use USE(LEGACY_CFNETWORK_DOWNLOADS) instead of MAC_OS_X_VERSION_MIN_REQUIRED,
which is more in line with WebKit style. This will be used more in bug 217747.

• NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::resume):

Source/WTF:

• wtf/PlatformUse.h:

12:56 PM Changeset in webkit [269699] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Update CheckOutSource step for new buildbot
​https://bugs.webkit.org/show_bug.cgi?id=218802

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/steps.py:

(CheckOutSource):
(CheckOutSource.init):

12:16 PM Changeset in webkit [269698] by Chris Dumez

• 13 edits in trunk

[GPUProcess] Seamlessly resume WebAudio playback if the GPU Process crashes
​https://bugs.webkit.org/show_bug.cgi?id=218806

Reviewed by Geoffrey Garen.

Source/WebCore:

• platform/audio/cocoa/AudioDestinationCocoa.h:

Export function so it can be called from WebKit layer.

Source/WebKit:

In case of a GPU process crash, we were previously terminating all WebProcesses.
This patch makes it so that WebProcesses are no longer terminated in such cases.
Additionally, this patch makes sure that if WebAudio is rendering audio while
the GPU Process crashes, the GPU process will get relaunched right away and
audio rendering will seamlessly continue.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::gpuProcessCrashed):

• WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::didClose):

• WebProcess/GPU/GPUProcessConnection.h:

(WebKit::GPUProcessConnection::Client::gpuProcessConnectionDidClose):
(WebKit::GPUProcessConnection::addClient):
(WebKit::GPUProcessConnection::removeClient):

• WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy):
(WebKit::RemoteAudioDestinationProxy::connectToGPUProcess):
(WebKit::RemoteAudioDestinationProxy::gpuProcessConnectionDidClose):

• WebProcess/GPU/media/RemoteAudioDestinationProxy.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::gpuProcessConnectionClosed):

• WebProcess/WebProcess.h:

Tools:

Extend API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

12:15 PM Changeset in webkit [269697] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs
​https://bugs.webkit.org/show_bug.cgi?id=218810

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-11-11
Reviewed by Geoffrey Garen.

A long, long time ago, we realized that CFNetwork was looking in the keychain for persistent credentials,
and in order to make the network process get credentials as the UI process, we introduced SecItemShim which
used DYLD_INTERPOSE to intercept the calls to the security framework and synchronously message the UI process
for those calls. Over the last 6 years we have realized that doesn't work on iOS or Apple silicon Macs, so
we use _CFURLConnectionSetFrameworkStubs instead. That works on Intel Macs, too, and I'm reasonably certain
that using it everywhere won't break anything, so as a step towards rdar://problem/15588174 which should allow
us to use asynchronous messages and no more globalNetworkProcess pointer, let's stop using DYLD_INTERPOSE.

• Shared/mac/SecItemShim.cpp:

(WebKit::initializeSecItemShim):

11:57 AM Changeset in webkit [269696] by commit-queue@webkit.org

• 7 edits in trunk/Source

Don't look in keychain for SecKeyRef after deserializing SecIdentityRef
​https://bugs.webkit.org/show_bug.cgi?id=218809
<rdar://problem/69394018>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-11-11
Reviewed by Geoffrey Garen.

Source/WebKit:

In ye olden days of WebKit2, we used to use special code to serialize an NSURLCredential with an identity.
We needed to serialize the certificate chain and a way to look in the keychain to find the private key.
That didn't work with third party apps not entitled to look in the keychain, and it also didn't work with hardware
keys that retain the private key themselves, so we introduced SecKeyProxy. Now, all those things work and we don't
serialize SecIdentityRefs any more, so let's remove the problematic dead code that would have tried.
Luckily, we now have API tests that verify that client certificate authentication still works.

r169938 added a restriction to looking in the keychain only if the parent app has entitlements needed to do so.
That restriction isn't needed any more because nobody looks in the keychain from the network process.

r269162 entirely removed looking in the keychain for private keys for client certificate authentication.
This is moving in that same direction.

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements):

• Shared/cf/ArgumentCodersCF.cpp:

(IPC::typeFromCFTypeRef):
(IPC::encode):
(IPC::decode):
(IPC::setAllowsDecodingSecKeyRef): Deleted.
(IPC::copyPersistentRef): Deleted.

• Shared/cf/ArgumentCodersCF.h:
• Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::Credential>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::Credential>::decodePlatformData):

Source/WTF:

• wtf/spi/cocoa/SecuritySPI.h:

11:54 AM Changeset in webkit [269695] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Protect ScheduledURLNavigation member
​https://bugs.webkit.org/show_bug.cgi?id=218593

Patch by Rob Buis <​rbuis@igalia.com> on 2020-11-11
Reviewed by Alex Christensen.

Protect ScheduledURLNavigation member m_url by using a copy since
ScheduledURLNavigation itself is not protected and may be cancelled
(and thus deleted) just at the time it is sending a message to the
UIProcess which encodes the passed m_url member variable.

• loader/NavigationScheduler.cpp:

11:50 AM Changeset in webkit [269694] by ysuzuki@apple.com

• 6 edits in trunk/Source/JavaScriptCore

[JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr
​https://bugs.webkit.org/show_bug.cgi?id=218781

Reviewed by Keith Miller and Mark Lam.

When returning from signal handler, handler requires that instruction pointer is CFunctionPtrTag-ed.
So we should set C trampoline instead of JIT trampoline here.
This patch implements trampoline in LLInt Wasm code so that we can use CFunctionPtrTag.

• bytecode/BytecodeList.rb:
• llint/WebAssembly.asm:
• wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):

11:37 AM Changeset in webkit [269693] by Antti Koivisto

• 23 edits in trunk/Source/WebCore

Replace confusing extraWidthToEndOfLine parameter with an enum
​https://bugs.webkit.org/show_bug.cgi?id=218793

Reviewed by Zalan Bujtas.

When a client of localCaretRect wants a rect that extends from caret to the end of the line it gets the length
of the remaining line awkwardly via extraWidthToEndOfLine out-parameter and then uses it to mutate the caret rect.

Instead just pass an enum telling that an extended rect is required and compute it in when constructing the rect.

• editing/Editor.cpp:

(WebCore::Editor::firstRectForRange const):

• editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect const):

• editing/RenderedPosition.h:
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect const):

• rendering/RenderBlock.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeCaretRect const):

• rendering/RenderBlockFlow.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect const):

• rendering/RenderBox.h:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement const):

• rendering/RenderBoxModelObject.h:
• rendering/RenderInline.cpp:

(WebCore::RenderInline::localCaretRect const):

• rendering/RenderInline.h:
• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::localCaretRect const):

• rendering/RenderLineBreak.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::localCaretRect const):

• rendering/RenderObject.h:
• rendering/RenderObjectEnums.h:
• rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect const):

• rendering/RenderText.h:
• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect const):

• rendering/svg/RenderSVGInlineText.h:

11:13 AM Changeset in webkit [269692] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

Implementation for AXIsolatedObject methods that return a VisiblePositionRange.
​https://bugs.webkit.org/show_bug.cgi?id=218783

Reviewed by Chris Fleizach.

Fix for the following tests in isolated tree mode:
accessibility/mac/attributed-string-with-listitem-multiple-lines.html
accessibility/mac/character-offset-from-upstream-position.html

Methods that return a VisiblePositionRange need to be called on the main
thread. The implementation of each of these methods forward the call to
the associated AXObject.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::visiblePositionRange const):
(WebCore::AXIsolatedObject::visiblePositionRangeForLine const):
(WebCore::AXIsolatedObject::visiblePositionRangeForUnorderedPositions const):
(WebCore::AXIsolatedObject::positionOfLeftWord const):
(WebCore::AXIsolatedObject::positionOfRightWord const):
(WebCore::AXIsolatedObject::leftLineVisiblePositionRange const):
(WebCore::AXIsolatedObject::rightLineVisiblePositionRange const):
(WebCore::AXIsolatedObject::sentenceForPosition const):
(WebCore::AXIsolatedObject::paragraphForPosition const):
(WebCore::AXIsolatedObject::styleRangeForPosition const):
(WebCore::AXIsolatedObject::visiblePositionRangeForRange const):
(WebCore::AXIsolatedObject::lineRangeForPosition const):

• accessibility/isolatedtree/AXIsolatedObject.h:

11:12 AM Changeset in webkit [269691] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r269348): ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::SpeechRecognitionServer::~SpeechRecognitionServer
​https://bugs.webkit.org/show_bug.cgi?id=218770
<rdar://problem/71252234>

Reviewed by Youenn Fablet.

Remove SpeechRecognitionServer from MessageReceiverMap before it is destroyed.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):

10:43 AM Changeset in webkit [269690] by Chris Dumez

• 4 edits in trunk/Source/WebKit

REGRESSION (r269657): ASSERTION FAILED: Completion handler should always be called under WebKit::GPUProcessProxy::~GPUProcessProxy
​https://bugs.webkit.org/show_bug.cgi?id=218807
<rdar://problem/71285627>

Reviewed by Geoffrey Garen.

GPUProcessProxy::sendPrepareToSuspend() was failing to send the IPC to the GPUProcess and was also
failing to call its completion handler, thus asserting in Debug. Update GPUProcessProxy to actually
send the PrepareToSuspend / ProcessDidResume IPCs to the GPUProcess. The GPUProcess actually already
had an implementation to deal with those IPCs.

No new tests, covered by existing tests that are crashing in debug.

• GPUProcess/GPUProcess.messages.in:
• UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::sendPrepareToSuspend):
(WebKit::GPUProcessProxy::sendProcessDidResume):

• UIProcess/GPU/GPUProcessProxy.h:

10:27 AM Changeset in webkit [269689] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Update RunWebKitTests step for new buildbot
​https://bugs.webkit.org/show_bug.cgi?id=218805

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/steps.py:

(ParseByLineLogObserver): New helper class to replace usage of LineConsumerLogObserver. This both makes it
easier to adopt the generator-based approach and reduces duplication of: while True, try, run some code,
then except GeneratorExit.
(ParseByLineLogObserver.init): Takes one argument: the function to run against each line produced.
(RunWebKitTests):
(RunWebKitTests.start): Initialize log_observer and appropriate variables.
(RunWebKitTests._parseRunWebKitTestsOutput): Added FIXME to remove this method after switching to buildbot v2.
(RunWebKitTests.parseOutputLine): Method to parse each log line as it is generated.
(RunWebKitTests.processTestFailures): Method to summarize the test failure information.
(RunWebKitTests.commandComplete):
(RunWebKitTests.evaluateCommand): Call processTestFailures method before processing results.
(RunWebKitTests.getResultSummary): Method to show step summary in new buildbot.
(RunWebKitTests.getText): Added FIXME to remove this method after switching to buildbot v2.
(RunWebKitTests.getText2): Ditto.

10:06 AM Changeset in webkit [269688] by eric.carlson@apple.com

• 12 edits in trunk/Source/WebCore

USB microphone not recognized iOS Safari
​https://bugs.webkit.org/show_bug.cgi?id=211192
<rdar://problem/62607313>

Reviewed by Youenn Fablet.

Source/WebCore:

Testing requires hardware, tested manually.

• platform/mediastream/CaptureDevice.h: Add concept of default device.

(WebCore::CaptureDevice::isDefault const):
(WebCore::CaptureDevice::setIsDefault):
(WebCore::CaptureDevice::encode const):
(WebCore::CaptureDevice::decode):

• platform/mediastream/ios/AVAudioSessionCaptureDevice.h: Don't retain port

description, it is never used.

• platform/mediastream/ios/AVAudioSessionCaptureDevice.mm:

(WebCore::AVAudioSessionCaptureDevice::create): Add default input parameter.
(WebCore::AVAudioSessionCaptureDevice::AVAudioSessionCaptureDevice): Set enabled
and default attributes.

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

(-[WebAVAudioSessionAvailableInputsListener initWithCallback:audioSession:]): Take
parent object and audio session. Listen for session route change notification.
(-[WebAVAudioSessionAvailableInputsListener invalidate]):
(-[WebAVAudioSessionAvailableInputsListener routeDidChange:]):
(WebCore::AVAudioSessionCaptureDeviceManager::AVAudioSessionCaptureDeviceManager):
Allocate and use an auxiliary audio session because it isn't possible to enumerate
all audio inputs without one.
(WebCore::AVAudioSessionCaptureDeviceManager::audioSessionDeviceWithUID): No need
to call refreshAudioCaptureDevices, audioSessionCaptureDevices does it if necessary.
(WebCore::AVAudioSessionCaptureDeviceManager::scheduleUpdateCaptureDevices): New,
refresh devices on a task queue because we frequently get more than one notification
when a route changes.
(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices): Sort devices
so the default is always first. Only call deviceChanged when something actually changes.
(-[WebAVAudioSessionAvailableInputsListener initWithCallback:]): Deleted.
(-[WebAVAudioSessionAvailableInputsListener observeValueForKeyPath:ofObject:change:context:]): Deleted.

• platform/mediastream/mac/CoreAudioCaptureDevice.cpp:

(WebCore::getDeviceInfo): Deal with input and output devices. Translate the data
source name if possible.
(WebCore::CoreAudioCaptureDevice::create):
(WebCore::CoreAudioCaptureDevice::CoreAudioCaptureDevice): Set new default attribute.
(WebCore::CoreAudioCaptureDevice::defaultDevice): New.

• platform/mediastream/mac/CoreAudioCaptureDevice.h:

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::CoreAudioCaptureDeviceManager::scheduleUpdateCaptureDevices): New, coalesce
calls to refreshAudioCaptureDevices.
(WebCore::CoreAudioCaptureDeviceManager::coreAudioCaptureDevices):
(WebCore::computeAudioDeviceList): No need to check for the default device explicitly.
(WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):
(WebCore::getDefaultCaptureInputDevice): Deleted.
(WebCore::getDefaultCaptureOutputDevice): Deleted.

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:

Source/WebCore/PAL:

• pal/spi/cocoa/AVFoundationSPI.h: Declare +[AVAudioSession initAuxiliarySession].

9:23 AM Changeset in webkit [269687] by Noam Rosenthal

• 2 edits in trunk/Source/WebCore

ContentfulPaintChecker should not trigger plugin snapshotting
​https://bugs.webkit.org/show_bug.cgi?id=218777
<rdar://problem/71256352>

Reviewed by Simon Fraser.

Widgets should not be notified when detecting contentful paint.

No new tests, a minor optimization.

• page/FrameView.cpp:

(WebCore::FrameView::willPaintContents):

8:17 AM Changeset in webkit [269686] by commit-queue@webkit.org

• 12 edits in trunk/Source/WebCore

Unreviewed, reverting r269680.
​https://bugs.webkit.org/show_bug.cgi?id=218803

Broke a webgl test on ios-wk2

Reverted changeset:

"Remove uses of MakeCurrent from WebGL implementation"
​https://bugs.webkit.org/show_bug.cgi?id=218178
​https://trac.webkit.org/changeset/269680

8:03 AM Changeset in webkit [269685] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

[GStreamer] Fix build due to unhandled AudioConfiguration Optional<T> members introduced in r269631

Unreviewed build fix.

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::isConfigurationSupported const): Use .valueOr(0) in
arguments to GST_DEBUG() macro to avoid passing non-POD types through varargs.

7:59 AM Changeset in webkit [269684] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Pass replaced box baseline to IFC
​https://bugs.webkit.org/show_bug.cgi?id=218801

Reviewed by Zalan Bujtas.

This fixes <attachment> element tests (like fast/attachment/attachment-title.html) with full replaced element support enabled.

It is also needed for the future inline-block support.

(WebCore::LayoutIntegration::LineLayout::updateReplacedDimensions):

7:52 AM Changeset in webkit [269683] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Use FileDownload to fetch built product from master
​https://bugs.webkit.org/show_bug.cgi?id=218440

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-11
Reviewed by Aakash Jain.

This removes the need for a front-end web server to serve the static
files.

• CISupport/ews-build/steps.py:

(DownloadBuiltProductFromMaster):
(DownloadBuiltProductFromMaster.init):
(DownloadBuiltProductFromMaster.getResultSummary):

• CISupport/ews-build/steps_unittest.py:

7:06 AM Changeset in webkit [269682] by Wenson Hsieh

• 11 edits
  2 copies
  1 move
  1 add in trunk/Source/WebKit

[Concurrent display lists] Add an initial implementation of concurrent display list rendering
​https://bugs.webkit.org/show_bug.cgi?id=218426
<rdar://problem/71167220>

Reviewed by Ryosuke Niwa.

This patch adds a first-cut implementation of concurrent display list rendering, which allows the GPU and web
processes to read and write display list data at the same time. To achieve this, we remove the placeholder
shared memory display list encoding mechanism previously added in <webkit.org/b/218406>, and replace it with a
new model in which a writer (i.e. the web process) and a reader (i.e. the GPU process) share a set of reusable
shared memory buffers which contain display list item data. As the writer appends data to shared memory, it
increments a counter in each shared memory buffer that represents the number of bytes that the reader has yet to
read; as the reader reads display list items from shared memory, it decrements this counter.

This patch also implements a simple strategy for reusing these shared item buffers. The web process maintains a
queue of reusable buffers; when display list items are appended and the current writable buffer is out of
capacity, the display list item buffer calls out to WebKit2 via a client method to request more shared memory.
Here, the web process traverses the queue of reusable item buffers in search of a buffer with sufficient
capacity; if found, we hand this back to WebCore as an opaque ItemBufferHandle; otherwise, we allocate a new
reusable shared memory buffer. Item buffers that have been used become reusable only after they are (1) no
longer being read from -- i.e., the counter value is 0, and (2) they are not actively being written to.
Buffers that have been used are lazily reintroduced into the reuse queue when a display list requests a handle
to writable item buffer data.

See below for more details.

• GPUProcess/graphics/DisplayListReaderHandle.cpp: Copied from Source/WebKit/Shared/SharedDisplayListHandle.cpp.

(WebKit::DisplayListReaderHandle::advance):
(WebKit::DisplayListReaderHandle::displayListForReading const):

• GPUProcess/graphics/DisplayListReaderHandle.h: Copied from Source/WebKit/Shared/SharedDisplayListHandle.cpp.

(WebKit::DisplayListReaderHandle::create):
(WebKit::DisplayListReaderHandle::DisplayListReaderHandle):

Add a new helper class to represent a shared display list item buffer that the GPU process can use to consume
display list items. Advancing the cursor in DisplayListReaderHandle decrements the "remaining bytes" counter;
the class also has a helper method for creating a new DisplayList with a given offset into the shared buffer,
as well the number of bytes to read.

• GPUProcess/graphics/RemoteImageBuffer.h:

Handle the MetaCommandSwitchTo and FlushContext items by (respectively) informing the rendering backend
about the next buffer to read from, and sending a "flush committed" IPC message back to the web process.

(WebKit::RemoteImageBuffer::RemoteImageBuffer):

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::applyDisplayListsFromHandle):
(WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):

This is the main loop in the GPU process that is responsible for applying incoming display list item data. This
IPC endpoint receives information about where to start (i.e. an item buffer ID and an offset into shared memory
in that buffer) and begins reading ranges of display list item data inside that buffer. After it is done
processing all of its unread bytes, it then checks the unread byte count once again, and continues the loop if
the web process has advanced this count.

(WebKit::RemoteRenderingBackend::setNextItemBufferToRead):
(WebKit::RemoteRenderingBackend::didCreateSharedDisplayListHandle):

Add logic to handle the case where we reached the end of an item buffer, but the next buffer identifier is still
unknown to us (since it is still "in transit" via the DidCreateSharedDisplayListHandle IPC message). In this
case, we remember the next buffer identifier in m_nextItemBufferToRead, and exit the processing loop inside
wakeUpAndApplyDisplayList. Upon receiving the shared memory handle in didCreateSharedDisplayListHandle, we
then automatically resume display list processing, starting from the beginning of this new buffer.

(WebKit::RemoteRenderingBackend::applyDisplayList): Deleted.
(WebKit::RemoteRenderingBackend::submitDisplayList): Deleted.
(WebKit::RemoteRenderingBackend::flushDisplayListAndCommit): Deleted.
(WebKit::RemoteRenderingBackend::didCreateSharedItemData): Deleted.

We don't need any of these methods anymore, now that there is only one codepath for processing display list
items. See RemoteRenderingBackend::wakeUpAndApplyDisplayList above. Also, rename didCreateSharedItemData
to didCreateSharedDisplayListHandle (also above).

• GPUProcess/graphics/RemoteRenderingBackend.h:
• GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• Shared/SharedDisplayListHandle.h:

(WebKit::SharedDisplayListHandle::sharedMemory):
(WebKit::SharedDisplayListHandle::sharedMemory const):
(WebKit::SharedDisplayListHandle::identifier const):
(WebKit::SharedDisplayListHandle::data const):
(WebKit::SharedDisplayListHandle::unreadBytes):
(WebKit::SharedDisplayListHandle::Lock::Lock):
(WebKit::SharedDisplayListHandle::Lock::~Lock):
(WebKit::SharedDisplayListHandle::SharedDisplayListHandle):
(WebKit::SharedDisplayListHandle::header):
(WebKit::SharedDisplayListHandle::header const):
(WebKit::SharedDisplayListHandle::encode const): Deleted.
(WebKit::SharedDisplayListHandle::decode): Deleted.

Repurpose SharedDisplayListHandle to serve as a base class for both DisplayListReaderHandle and
DisplayListWriterHandle. This base class is aware of the memory layout of the display list item buffer in
shared memory (in particular, the fact that the first 8 bytes are the atomic lock and the next 8 bytes contain
the unread byte counter).

Internally, this uses a protected RAII class, SharedDisplayListHandle::Lock, to grab the lock before either
reading or writing the unread bytes count.

• Sources.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/graphics/DisplayListWriterHandle.cpp: Added.

(WebKit::DisplayListWriterHandle::advance):
(WebKit::DisplayListWriterHandle::availableCapacity const):
(WebKit::DisplayListWriterHandle::createHandle const):
(WebKit::DisplayListWriterHandle::resetWritableOffsetIfPossible):

This helper method moves the writable offset (see below) back to the start of the buffer if it is not being read
from by the GPU process.

• WebProcess/GPU/graphics/DisplayListWriterHandle.h: Renamed from Source/WebKit/Shared/SharedDisplayListHandle.cpp.

(WebKit::DisplayListWriterHandle::create):
(WebKit::DisplayListWriterHandle::writableOffset const):

Similar to DisplayListReaderHandle, except that this contains logic specific to the web process for writing
display list items into shared memory. Advancing the cursor in DisplayListWriterHandle increments the counter.
It also increments the writableOffset of the handle, which represents the minimum offset into the shared
buffer that may contain newly appended display list items.

(WebKit::DisplayListWriterHandle::DisplayListWriterHandle):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::submitDisplayList):
(WebKit::RemoteRenderingBackendProxy::updateReusableHandles):

This private helper iterates the set of buffers that are not currently being written to, and adds each one to
the reusable buffer queue only if its writable offset is at the start.

(WebKit::RemoteRenderingBackendProxy::createItemBuffer):

Implements logic that hands shared item buffer data handles to WebCore for writing display list items. This will
try to reuse an item buffer in the reuse queue, if possible, and fall back to allocating a new chunk of shared
memory if no reusable buffer is found (or the existing buffers have insufficient capacity). The fact that we
iterate through each reusable buffer in order, combined with the above logic in updateReusableHandles, ensures
that once we begin writing to a item buffer, we will continue using that item buffer until it exhausts available
capacity.

This property is important because it allows the GPU process to simply start reading item data from a given
offset and buffer ID (specified in the WakeUpAndApplyDisplayList IPC message), and seamlessly continue
reading data even after it exhausts all available item data in the current buffer by continuing from the start
of the item buffer that contains the next display list items (which we learn in the GPU process by encountering
a MetaCommandSwitchTo item at the end of the previous buffer).

In "steady state" (wherein both processes are concurrently writing and reading items as quickly as possible),
this means that as the web process is busy filling up each item buffer with item data, the GPU process is also
busy applying all the item data in one buffer and automatically moving on to the next buffer with no additional
IPC messages required.

(WebKit::RemoteRenderingBackendProxy::flushDisplayListAndCommit): Deleted.

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

6:19 AM Changeset in webkit [269681] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Add modern line layout statistics
​https://bugs.webkit.org/show_bug.cgi?id=218782

Reviewed by Antti Koivisto.

notifyutil -p com.apple.WebKit.showModernLineLayoutCoverage and com.apple.WebKit.showModernLineLayoutReasons.
e.g.

nytimes.com:

---

Modern line layout coverage: 64.20%

Number of blocks: total(196) legacy(71)
Content length: total(8313) legacy(2976)
nested renderers: 20.77%
flow does not establishes inline formatting context: 3.04%
non top level column: 6.56%
missing glyph or glyph needs another font: 0.02%
unsupported TextFragment: 0.31%
text-shadow: 12.80%

---

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::printReasons):
(WebCore::LayoutIntegration::printTextForSubtree):
(WebCore::LayoutIntegration::textLengthForSubtree):
(WebCore::LayoutIntegration::collectNonEmptyLeafRenderBlockFlows):
(WebCore::LayoutIntegration::collectNonEmptyLeafRenderBlockFlowsForCurrentPage):
(WebCore::LayoutIntegration::printModernLineLayoutBlockList):
(WebCore::LayoutIntegration::printModernLineLayoutCoverage):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

4:27 AM Changeset in webkit [269680] by commit-queue@webkit.org

• 12 edits in trunk/Source/WebCore

Remove uses of MakeCurrent from WebGL implementation
​https://bugs.webkit.org/show_bug.cgi?id=218178
<rdar://problem/70714561>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-11-11
Reviewed by Dean Jackson.

Work towards WebGL implementation which uses
GraphicsContextGL abstract base class instead of
GraphicsContextGLOpenGL concrete class.

Move GraphicsContextGLOpenGL::makeContextCurrent() to
private section, as it is an implementation detail of
the class. The function is intended to be called at the
start of all public functions that might call into OpenGL
to ensure that OpenGL uses the right context.

Check all return values of makeCurrentContext(). We
should not call into OpenGL if the context is not current,
as that can lead to corruption, crashes or incorrect results.
Add a compile-time warning if the return value is not used.
Non-EWS compiled flavors of GraphicsContextGLOpenGL are changed
only in best effort manner.

Ensure that all functions actually call the makeCurrentContext()
function before calling into OpenGL. Non-ANGLE flavors of
GraphicsContextGLOpenGL are ensured only in best effort manner.

ANGLE flavor of GraphicsContextGLOpenGL function implementations
should call directly the ANGLE functions instead of calling them
through getExtensions() interface. There is no conditional code
inside and the implementation knows exactly which function to
call in all situations. There is no abstraction between
GraphicsContextGLOpenGL and ExtensionsGL, rather they are
in practice the same object currently, semi-artificially split to
two. This is true of other flavors of GraphicsContextGLOpenGL,
but those are left unchanged in this regard.

No new tests, a refactor.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::validateElementArraySize):
(WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContextBase::validateDrawElements):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
(WebCore::WebGLRenderingContextBase::initVertexAttrib0):

• platform/graphics/angle/ExtensionsGLANGLE.cpp:

(WebCore::ExtensionsGLANGLE::supports):
(WebCore::ExtensionsGLANGLE::ensureEnabled):
(WebCore::ExtensionsGLANGLE::getTranslatedShaderSourceANGLE):
(WebCore::ExtensionsGLANGLE::blitFramebuffer):
(WebCore::ExtensionsGLANGLE::renderbufferStorageMultisample):
(WebCore::ExtensionsGLANGLE::createVertexArrayOES):
(WebCore::ExtensionsGLANGLE::deleteVertexArrayOES):
(WebCore::ExtensionsGLANGLE::isVertexArrayOES):
(WebCore::ExtensionsGLANGLE::bindVertexArrayOES):
(WebCore::ExtensionsGLANGLE::drawBuffersEXT):
(WebCore::ExtensionsGLANGLE::drawArraysInstanced):
(WebCore::ExtensionsGLANGLE::drawElementsInstanced):
(WebCore::ExtensionsGLANGLE::vertexAttribDivisor):
(WebCore::ExtensionsGLANGLE::getBooleanvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFloatvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFramebufferAttachmentParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getIntegervRobustANGLE):
(WebCore::ExtensionsGLANGLE::getProgramivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getRenderbufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getShaderivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribPointervRobustANGLE):
(WebCore::ExtensionsGLANGLE::readPixelsRobustANGLE):
(WebCore::ExtensionsGLANGLE::texImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texSubImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexSubImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexSubImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texSubImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferPointervRobustANGLE):
(WebCore::ExtensionsGLANGLE::getIntegeri_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInternalformativRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getActiveUniformBlockivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInteger64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInteger64i_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferParameteri64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFramebufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getProgramInterfaceivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBooleani_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getMultisamplefvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexLevelParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexLevelParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getPointervRobustANGLERobustANGLE):
(WebCore::ExtensionsGLANGLE::readnPixelsRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjecti64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectui64vRobustANGLE):

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorage):
(WebCore::GraphicsContextGLOpenGL::getIntegerv):
(WebCore::GraphicsContextGLOpenGL::getIntegeri_v):
(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):
(WebCore::GraphicsContextGLOpenGL::depthRange):
(WebCore::GraphicsContextGLOpenGL::clearDepth):
(WebCore::GraphicsContextGLOpenGL::readPixels):
(WebCore::GraphicsContextGLOpenGL::prepareTexture):
(WebCore::GraphicsContextGLOpenGL::readRenderingResults):
(WebCore::GraphicsContextGLOpenGL::reshape):
(WebCore::GraphicsContextGLOpenGL::activeTexture):
(WebCore::GraphicsContextGLOpenGL::attachShader):
(WebCore::GraphicsContextGLOpenGL::bindAttribLocation):
(WebCore::GraphicsContextGLOpenGL::bindBuffer):
(WebCore::GraphicsContextGLOpenGL::bindFramebuffer):
(WebCore::GraphicsContextGLOpenGL::bindRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::bindTexture):
(WebCore::GraphicsContextGLOpenGL::blendColor):
(WebCore::GraphicsContextGLOpenGL::blendEquation):
(WebCore::GraphicsContextGLOpenGL::blendEquationSeparate):
(WebCore::GraphicsContextGLOpenGL::blendFunc):
(WebCore::GraphicsContextGLOpenGL::blendFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::bufferData):
(WebCore::GraphicsContextGLOpenGL::bufferSubData):
(WebCore::GraphicsContextGLOpenGL::mapBufferRange):
(WebCore::GraphicsContextGLOpenGL::unmapBuffer):
(WebCore::GraphicsContextGLOpenGL::copyBufferSubData):
(WebCore::GraphicsContextGLOpenGL::getInternalformativ):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorageMultisample):
(WebCore::GraphicsContextGLOpenGL::texStorage2D):
(WebCore::GraphicsContextGLOpenGL::texStorage3D):
(WebCore::GraphicsContextGLOpenGL::getActiveUniforms):
(WebCore::GraphicsContextGLOpenGL::checkFramebufferStatus):
(WebCore::GraphicsContextGLOpenGL::clearColor):
(WebCore::GraphicsContextGLOpenGL::clear):
(WebCore::GraphicsContextGLOpenGL::clearStencil):
(WebCore::GraphicsContextGLOpenGL::colorMask):
(WebCore::GraphicsContextGLOpenGL::compileShader):
(WebCore::GraphicsContextGLOpenGL::compileShaderDirect):
(WebCore::GraphicsContextGLOpenGL::copyTexImage2D):
(WebCore::GraphicsContextGLOpenGL::copyTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::cullFace):
(WebCore::GraphicsContextGLOpenGL::depthFunc):
(WebCore::GraphicsContextGLOpenGL::depthMask):
(WebCore::GraphicsContextGLOpenGL::detachShader):
(WebCore::GraphicsContextGLOpenGL::disable):
(WebCore::GraphicsContextGLOpenGL::disableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::drawArrays):
(WebCore::GraphicsContextGLOpenGL::drawElements):
(WebCore::GraphicsContextGLOpenGL::enable):
(WebCore::GraphicsContextGLOpenGL::enableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::finish):
(WebCore::GraphicsContextGLOpenGL::flush):
(WebCore::GraphicsContextGLOpenGL::framebufferRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::framebufferTexture2D):
(WebCore::GraphicsContextGLOpenGL::frontFace):
(WebCore::GraphicsContextGLOpenGL::generateMipmap):
(WebCore::GraphicsContextGLOpenGL::getActiveAttribImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformImpl):
(WebCore::GraphicsContextGLOpenGL::getAttachedShaders):
(WebCore::GraphicsContextGLOpenGL::getAttribLocation):
(WebCore::GraphicsContextGLOpenGL::moveErrorsToSyntheticErrorList):
(WebCore::GraphicsContextGLOpenGL::getError):
(WebCore::GraphicsContextGLOpenGL::getString):
(WebCore::GraphicsContextGLOpenGL::hint):
(WebCore::GraphicsContextGLOpenGL::isBuffer):
(WebCore::GraphicsContextGLOpenGL::isEnabled):
(WebCore::GraphicsContextGLOpenGL::isFramebuffer):
(WebCore::GraphicsContextGLOpenGL::isProgram):
(WebCore::GraphicsContextGLOpenGL::isRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::isShader):
(WebCore::GraphicsContextGLOpenGL::isTexture):
(WebCore::GraphicsContextGLOpenGL::lineWidth):
(WebCore::GraphicsContextGLOpenGL::linkProgram):
(WebCore::GraphicsContextGLOpenGL::pixelStorei):
(WebCore::GraphicsContextGLOpenGL::polygonOffset):
(WebCore::GraphicsContextGLOpenGL::sampleCoverage):
(WebCore::GraphicsContextGLOpenGL::scissor):
(WebCore::GraphicsContextGLOpenGL::shaderSource):
(WebCore::GraphicsContextGLOpenGL::stencilFunc):
(WebCore::GraphicsContextGLOpenGL::stencilFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilMask):
(WebCore::GraphicsContextGLOpenGL::stencilMaskSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilOp):
(WebCore::GraphicsContextGLOpenGL::stencilOpSeparate):
(WebCore::GraphicsContextGLOpenGL::texParameterf):
(WebCore::GraphicsContextGLOpenGL::texParameteri):
(WebCore::GraphicsContextGLOpenGL::uniform1f):
(WebCore::GraphicsContextGLOpenGL::uniform1fv):
(WebCore::GraphicsContextGLOpenGL::uniform2f):
(WebCore::GraphicsContextGLOpenGL::uniform2fv):
(WebCore::GraphicsContextGLOpenGL::uniform3f):
(WebCore::GraphicsContextGLOpenGL::uniform3fv):
(WebCore::GraphicsContextGLOpenGL::uniform4f):
(WebCore::GraphicsContextGLOpenGL::uniform4fv):
(WebCore::GraphicsContextGLOpenGL::uniform1i):
(WebCore::GraphicsContextGLOpenGL::uniform1iv):
(WebCore::GraphicsContextGLOpenGL::uniform2i):
(WebCore::GraphicsContextGLOpenGL::uniform2iv):
(WebCore::GraphicsContextGLOpenGL::uniform3i):
(WebCore::GraphicsContextGLOpenGL::uniform3iv):
(WebCore::GraphicsContextGLOpenGL::uniform4i):
(WebCore::GraphicsContextGLOpenGL::uniform4iv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4fv):
(WebCore::GraphicsContextGLOpenGL::useProgram):
(WebCore::GraphicsContextGLOpenGL::validateProgram):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribPointer):
(WebCore::GraphicsContextGLOpenGL::vertexAttribIPointer):
(WebCore::GraphicsContextGLOpenGL::viewport):
(WebCore::GraphicsContextGLOpenGL::createVertexArray):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::bindVertexArray):
(WebCore::GraphicsContextGLOpenGL::getBooleanv):
(WebCore::GraphicsContextGLOpenGL::getBufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getFloatv):
(WebCore::GraphicsContextGLOpenGL::getInteger64v):
(WebCore::GraphicsContextGLOpenGL::getInteger64i_v):
(WebCore::GraphicsContextGLOpenGL::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContextGLOpenGL::getProgramiv):
(WebCore::GraphicsContextGLOpenGL::getProgramInfoLog):
(WebCore::GraphicsContextGLOpenGL::getRenderbufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getShaderiv):
(WebCore::GraphicsContextGLOpenGL::getShaderInfoLog):
(WebCore::GraphicsContextGLOpenGL::getTexParameterfv):
(WebCore::GraphicsContextGLOpenGL::getTexParameteriv):
(WebCore::GraphicsContextGLOpenGL::getUniformfv):
(WebCore::GraphicsContextGLOpenGL::getUniformiv):
(WebCore::GraphicsContextGLOpenGL::getUniformuiv):
(WebCore::GraphicsContextGLOpenGL::getUniformLocation):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribfv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribiv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribOffset):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::createBuffer):
(WebCore::GraphicsContextGLOpenGL::createFramebuffer):
(WebCore::GraphicsContextGLOpenGL::createProgram):
(WebCore::GraphicsContextGLOpenGL::createRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::createShader):
(WebCore::GraphicsContextGLOpenGL::createTexture):
(WebCore::GraphicsContextGLOpenGL::deleteBuffer):
(WebCore::GraphicsContextGLOpenGL::deleteFramebuffer):
(WebCore::GraphicsContextGLOpenGL::deleteProgram):
(WebCore::GraphicsContextGLOpenGL::deleteRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::deleteShader):
(WebCore::GraphicsContextGLOpenGL::deleteTexture):
(WebCore::GraphicsContextGLOpenGL::texImage2DDirect):
(WebCore::GraphicsContextGLOpenGL::drawArraysInstanced):
(WebCore::GraphicsContextGLOpenGL::drawElementsInstanced):
(WebCore::GraphicsContextGLOpenGL::vertexAttribDivisor):
(WebCore::GraphicsContextGLOpenGL::getUniformBlockIndex):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockName):
(WebCore::GraphicsContextGLOpenGL::uniformBlockBinding):
(WebCore::GraphicsContextGLOpenGL::createQuery):
(WebCore::GraphicsContextGLOpenGL::beginQuery):
(WebCore::GraphicsContextGLOpenGL::endQuery):
(WebCore::GraphicsContextGLOpenGL::getQueryObjectuiv):
(WebCore::GraphicsContextGLOpenGL::createTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::deleteTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::isTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::beginTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::endTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::transformFeedbackVaryings):
(WebCore::GraphicsContextGLOpenGL::getTransformFeedbackVarying):
(WebCore::GraphicsContextGLOpenGL::bindBufferBase):
(WebCore::GraphicsContextGLOpenGL::blitFramebuffer):
(WebCore::GraphicsContextGLOpenGL::framebufferTextureLayer):
(WebCore::GraphicsContextGLOpenGL::invalidateFramebuffer):
(WebCore::GraphicsContextGLOpenGL::invalidateSubFramebuffer):
(WebCore::GraphicsContextGLOpenGL::readBuffer):
(WebCore::GraphicsContextGLOpenGL::copyTexSubImage3D):
(WebCore::GraphicsContextGLOpenGL::getFragDataLocation):
(WebCore::GraphicsContextGLOpenGL::uniform1ui):
(WebCore::GraphicsContextGLOpenGL::uniform2ui):
(WebCore::GraphicsContextGLOpenGL::uniform3ui):
(WebCore::GraphicsContextGLOpenGL::uniform4ui):
(WebCore::GraphicsContextGLOpenGL::uniform1uiv):
(WebCore::GraphicsContextGLOpenGL::uniform2uiv):
(WebCore::GraphicsContextGLOpenGL::uniform3uiv):
(WebCore::GraphicsContextGLOpenGL::uniform4uiv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2x3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3x2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2x4fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4x2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3x4fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4x3fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4i):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4iv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4ui):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4uiv):
(WebCore::GraphicsContextGLOpenGL::drawRangeElements):
(WebCore::GraphicsContextGLOpenGL::drawBuffers):
(WebCore::GraphicsContextGLOpenGL::clearBufferiv):
(WebCore::GraphicsContextGLOpenGL::clearBufferuiv):
(WebCore::GraphicsContextGLOpenGL::clearBufferfv):
(WebCore::GraphicsContextGLOpenGL::clearBufferfi):
(WebCore::GraphicsContextGLOpenGL::deleteQuery):
(WebCore::GraphicsContextGLOpenGL::isQuery):
(WebCore::GraphicsContextGLOpenGL::getQuery):
(WebCore::GraphicsContextGLOpenGL::createSampler):
(WebCore::GraphicsContextGLOpenGL::deleteSampler):
(WebCore::GraphicsContextGLOpenGL::isSampler):
(WebCore::GraphicsContextGLOpenGL::bindSampler):
(WebCore::GraphicsContextGLOpenGL::samplerParameteri):
(WebCore::GraphicsContextGLOpenGL::samplerParameterf):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameterfv):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameteriv):
(WebCore::GraphicsContextGLOpenGL::fenceSync):
(WebCore::GraphicsContextGLOpenGL::isSync):
(WebCore::GraphicsContextGLOpenGL::deleteSync):
(WebCore::GraphicsContextGLOpenGL::clientWaitSync):
(WebCore::GraphicsContextGLOpenGL::waitSync):
(WebCore::GraphicsContextGLOpenGL::getSynciv):
(WebCore::GraphicsContextGLOpenGL::pauseTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::resumeTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindBufferRange):
(WebCore::GraphicsContextGLOpenGL::getUniformIndices):

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::updateCGLContext):

• platform/graphics/opengl/ExtensionsGLOpenGL.cpp:

(WebCore::ExtensionsGLOpenGL::blitFramebuffer):
(WebCore::ExtensionsGLOpenGL::renderbufferStorageMultisample):
(WebCore::ExtensionsGLOpenGL::createVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::deleteVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::isVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::bindVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::supportsExtension):
(WebCore::ExtensionsGLOpenGL::drawBuffersEXT):
(WebCore::ExtensionsGLOpenGL::drawArraysInstanced):
(WebCore::ExtensionsGLOpenGL::drawElementsInstanced):
(WebCore::ExtensionsGLOpenGL::vertexAttribDivisor):

• platform/graphics/opengl/ExtensionsGLOpenGLES.cpp:

(WebCore::ExtensionsGLOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::ExtensionsGLOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::ExtensionsGLOpenGLES::renderbufferStorageMultisample):
(WebCore::ExtensionsGLOpenGLES::createVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::deleteVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::isVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::bindVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::getGraphicsResetStatusARB):
(WebCore::ExtensionsGLOpenGLES::readnPixelsEXT):
(WebCore::ExtensionsGLOpenGLES::getnUniformfvEXT):
(WebCore::ExtensionsGLOpenGLES::getnUniformivEXT):
(WebCore::ExtensionsGLOpenGLES::drawArraysInstanced):
(WebCore::ExtensionsGLOpenGLES::drawElementsInstanced):
(WebCore::ExtensionsGLOpenGLES::vertexAttribDivisor):

• platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

(WebCore::GraphicsContextGLOpenGL::renderbufferStorage):
(WebCore::GraphicsContextGLOpenGL::getIntegerv):
(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):
(WebCore::GraphicsContextGLOpenGL::depthRange):
(WebCore::GraphicsContextGLOpenGL::clearDepth):
(WebCore::GraphicsContextGLOpenGL::readPixels):

• platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::prepareTexture):
(WebCore::GraphicsContextGLOpenGL::readRenderingResults):
(WebCore::GraphicsContextGLOpenGL::reshape):
(WebCore::GraphicsContextGLOpenGL::activeTexture):
(WebCore::GraphicsContextGLOpenGL::attachShader):
(WebCore::GraphicsContextGLOpenGL::bindAttribLocation):
(WebCore::GraphicsContextGLOpenGL::bindBuffer):
(WebCore::GraphicsContextGLOpenGL::bindFramebuffer):
(WebCore::GraphicsContextGLOpenGL::bindRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::bindTexture):
(WebCore::GraphicsContextGLOpenGL::blendColor):
(WebCore::GraphicsContextGLOpenGL::blendEquation):
(WebCore::GraphicsContextGLOpenGL::blendEquationSeparate):
(WebCore::GraphicsContextGLOpenGL::blendFunc):
(WebCore::GraphicsContextGLOpenGL::blendFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::bufferData):
(WebCore::GraphicsContextGLOpenGL::bufferSubData):
(WebCore::GraphicsContextGLOpenGL::checkFramebufferStatus):
(WebCore::GraphicsContextGLOpenGL::clearColor):
(WebCore::GraphicsContextGLOpenGL::clear):
(WebCore::GraphicsContextGLOpenGL::clearStencil):
(WebCore::GraphicsContextGLOpenGL::colorMask):
(WebCore::GraphicsContextGLOpenGL::compileShader):
(WebCore::GraphicsContextGLOpenGL::compileShaderDirect):
(WebCore::GraphicsContextGLOpenGL::copyTexImage2D):
(WebCore::GraphicsContextGLOpenGL::copyTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::cullFace):
(WebCore::GraphicsContextGLOpenGL::depthFunc):
(WebCore::GraphicsContextGLOpenGL::depthMask):
(WebCore::GraphicsContextGLOpenGL::detachShader):
(WebCore::GraphicsContextGLOpenGL::disable):
(WebCore::GraphicsContextGLOpenGL::disableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::drawArrays):
(WebCore::GraphicsContextGLOpenGL::drawElements):
(WebCore::GraphicsContextGLOpenGL::enable):
(WebCore::GraphicsContextGLOpenGL::enableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::finish):
(WebCore::GraphicsContextGLOpenGL::flush):
(WebCore::GraphicsContextGLOpenGL::framebufferRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::framebufferTexture2D):
(WebCore::GraphicsContextGLOpenGL::frontFace):
(WebCore::GraphicsContextGLOpenGL::generateMipmap):
(WebCore::GraphicsContextGLOpenGL::getActiveAttribImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformImpl):
(WebCore::GraphicsContextGLOpenGL::getAttachedShaders):
(WebCore::GraphicsContextGLOpenGL::getAttribLocation):
(WebCore::GraphicsContextGLOpenGL::getAttribLocationDirect):
(WebCore::GraphicsContextGLOpenGL::moveErrorsToSyntheticErrorList):
(WebCore::GraphicsContextGLOpenGL::getError):
(WebCore::GraphicsContextGLOpenGL::getString):
(WebCore::GraphicsContextGLOpenGL::hint):
(WebCore::GraphicsContextGLOpenGL::isBuffer):
(WebCore::GraphicsContextGLOpenGL::isEnabled):
(WebCore::GraphicsContextGLOpenGL::isFramebuffer):
(WebCore::GraphicsContextGLOpenGL::isProgram):
(WebCore::GraphicsContextGLOpenGL::isRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::isShader):
(WebCore::GraphicsContextGLOpenGL::isTexture):
(WebCore::GraphicsContextGLOpenGL::lineWidth):
(WebCore::GraphicsContextGLOpenGL::linkProgram):
(WebCore::GraphicsContextGLOpenGL::pixelStorei):
(WebCore::GraphicsContextGLOpenGL::polygonOffset):
(WebCore::GraphicsContextGLOpenGL::sampleCoverage):
(WebCore::GraphicsContextGLOpenGL::scissor):
(WebCore::GraphicsContextGLOpenGL::shaderSource):
(WebCore::GraphicsContextGLOpenGL::stencilFunc):
(WebCore::GraphicsContextGLOpenGL::stencilFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilMask):
(WebCore::GraphicsContextGLOpenGL::stencilMaskSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilOp):
(WebCore::GraphicsContextGLOpenGL::stencilOpSeparate):
(WebCore::GraphicsContextGLOpenGL::texParameterf):
(WebCore::GraphicsContextGLOpenGL::texParameteri):
(WebCore::GraphicsContextGLOpenGL::uniform1f):
(WebCore::GraphicsContextGLOpenGL::uniform1fv):
(WebCore::GraphicsContextGLOpenGL::uniform2f):
(WebCore::GraphicsContextGLOpenGL::uniform2fv):
(WebCore::GraphicsContextGLOpenGL::uniform3f):
(WebCore::GraphicsContextGLOpenGL::uniform3fv):
(WebCore::GraphicsContextGLOpenGL::uniform4f):
(WebCore::GraphicsContextGLOpenGL::uniform4fv):
(WebCore::GraphicsContextGLOpenGL::uniform1i):
(WebCore::GraphicsContextGLOpenGL::uniform1iv):
(WebCore::GraphicsContextGLOpenGL::uniform2i):
(WebCore::GraphicsContextGLOpenGL::uniform2iv):
(WebCore::GraphicsContextGLOpenGL::uniform3i):
(WebCore::GraphicsContextGLOpenGL::uniform3iv):
(WebCore::GraphicsContextGLOpenGL::uniform4i):
(WebCore::GraphicsContextGLOpenGL::uniform4iv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4fv):
(WebCore::GraphicsContextGLOpenGL::useProgram):
(WebCore::GraphicsContextGLOpenGL::validateProgram):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribPointer):
(WebCore::GraphicsContextGLOpenGL::viewport):
(WebCore::GraphicsContextGLOpenGL::createVertexArray):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::bindVertexArray):
(WebCore::GraphicsContextGLOpenGL::getBooleanv):
(WebCore::GraphicsContextGLOpenGL::getBufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getFloatv):
(WebCore::GraphicsContextGLOpenGL::getIntegeri_v):
(WebCore::GraphicsContextGLOpenGL::getInteger64v):
(WebCore::GraphicsContextGLOpenGL::getInteger64i_v):
(WebCore::GraphicsContextGLOpenGL::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContextGLOpenGL::getProgramiv):
(WebCore::GraphicsContextGLOpenGL::getNonBuiltInActiveSymbolCount):
(WebCore::GraphicsContextGLOpenGL::getProgramInfoLog):
(WebCore::GraphicsContextGLOpenGL::getRenderbufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getShaderiv):
(WebCore::GraphicsContextGLOpenGL::getShaderInfoLog):
(WebCore::GraphicsContextGLOpenGL::getShaderSource):
(WebCore::GraphicsContextGLOpenGL::getTexParameterfv):
(WebCore::GraphicsContextGLOpenGL::getTexParameteriv):
(WebCore::GraphicsContextGLOpenGL::getUniformfv):
(WebCore::GraphicsContextGLOpenGL::getUniformiv):
(WebCore::GraphicsContextGLOpenGL::getUniformLocation):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribfv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribiv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribOffset):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::createBuffer):
(WebCore::GraphicsContextGLOpenGL::createFramebuffer):
(WebCore::GraphicsContextGLOpenGL::createProgram):
(WebCore::GraphicsContextGLOpenGL::createRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::createShader):
(WebCore::GraphicsContextGLOpenGL::createTexture):
(WebCore::GraphicsContextGLOpenGL::deleteBuffer):
(WebCore::GraphicsContextGLOpenGL::deleteFramebuffer):
(WebCore::GraphicsContextGLOpenGL::deleteProgram):
(WebCore::GraphicsContextGLOpenGL::deleteRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::deleteShader):
(WebCore::GraphicsContextGLOpenGL::deleteTexture):
(WebCore::GraphicsContextGLOpenGL::texImage2DDirect):
(WebCore::GraphicsContextGLOpenGL::primitiveRestartIndex):
(WebCore::GraphicsContextGLOpenGL::copyBufferSubData):
(WebCore::GraphicsContextGLOpenGL::mapBufferRange):
(WebCore::GraphicsContextGLOpenGL::unmapBuffer):
(WebCore::GraphicsContextGLOpenGL::getInternalformativ):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorageMultisample):
(WebCore::GraphicsContextGLOpenGL::texStorage2D):
(WebCore::GraphicsContextGLOpenGL::texStorage3D):
(WebCore::GraphicsContextGLOpenGL::getActiveUniforms):

• platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:

(WebCore::GraphicsContextGLOpenGL::readPixels):
(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorage):
(WebCore::GraphicsContextGLOpenGL::getIntegerv):
(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):
(WebCore::GraphicsContextGLOpenGL::depthRange):
(WebCore::GraphicsContextGLOpenGL::clearDepth):
(WebCore::GraphicsContextGLOpenGL::create):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):

• platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):

4:15 AM Changeset in webkit [269679] by commit-queue@webkit.org

• 122 edits in trunk/LayoutTests

Resync web-platform-tests/css/css-sizing/aspect-ratio from upstream
​https://bugs.webkit.org/show_bug.cgi?id=218796

Patch by Rob Buis <​rbuis@igalia.com> on 2020-11-11
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Resync web-platform-tests/css/css-sizing/aspect-ratio from upstream fe67f0b56f.

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-003.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-004.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-005.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-006.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-007.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-008.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-009.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-010.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-011.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-012.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-013.html:
• web-platform-tests/css/css-sizing/aspect-ratio/abspos-014.html:
• web-platform-tests/css/css-sizing/aspect-ratio/auto-margins-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-003.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-004.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-005.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-006.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-007.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-008.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-009.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-010.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-011.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-012.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-013.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-014.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-015.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-016.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-017.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-018.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-019.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-020.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-021.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-022.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-023.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-024.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-025.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-026.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-027.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-028.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-with-margin-collapsing-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-with-margin-collapsing-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-003.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-004.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-005.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-006.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-007.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-008.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-009.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-010.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-011.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-012.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-013.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-014.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-015.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-016.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-017.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-018.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-019.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-020.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-021.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-022.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-023.html:
• web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-024.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-003.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-004.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-005.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-006.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.html:
• web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-008.html:
• web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-computed.html:
• web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid-expected.txt:
• web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid.html:
• web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-003.html:
• web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-004.html:
• web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/quirks-mode-003.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-001.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-002.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-003.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-004.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-005.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-006.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-007.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-008.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-009.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-010.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-011.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-012.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-013.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-014.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-015.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-016.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-017.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-018.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-019.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-020.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-021.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-022.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-023.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-024.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-025.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-026.html:
• web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-027.html:
• web-platform-tests/css/css-sizing/aspect-ratio/small-aspect-ratio-crash.html:
• web-platform-tests/css/css-sizing/aspect-ratio/support/w3c-import.log:
• web-platform-tests/css/css-sizing/aspect-ratio/w3c-import.log:

LayoutTests:

Adapt platform test expectations.

• TestExpectations:

2:44 AM Changeset in webkit [269678] by commit-queue@webkit.org

• 12 edits
  2 moves
  1 add in trunk/Source/WebCore

Refactor VideoTextureCopier to be specific to a particular GraphicsContextGL and polymorphic to it
​https://bugs.webkit.org/show_bug.cgi?id=217218
<rdar://problem/69876433>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-11-11
Reviewed by Dean Jackson.

Work towards WebGL implementation which uses GraphicsContextGL abstract
base class instead of GraphicsContextGLOpenGL concrete class.

Relatively minimal changes to make AVFOUNDATION variants of MediaPlayerPrivate
compile when GraphicsContextGL is passed as the context instead of
GraphicsContextGLOpenGL.

Changes functionality so that the conversion resources (shaders, FBO)
are allocated per context instead of previously per video element.
This also means that context loss is handled correctly for the element.

Removes unused RGB texture copying code from the copy implementation.
This was left unused when OpenGL and OpenGL ES backends for AVF users
were removed.

Makes it possible to have GraphicsContextGLRemote that is able to copy
both AVF media textures as well as remote media textures.

Makes it possible to have Cocoa variant of GraphicsContextGLOpenGL that
is able to copy both AVF media textures as well as remote media
textures.

Changes only the AVF variants of MediaPlayerPrivate, not
the GStreamer variants. Similar interface GraphicsContextGLGStreamer
could be implemented for GStreamer if/when remote WebGL would support
GStreamer. If this is not done, a downcast from GraphicsContextGL
to GraphicsContextGLOpenGL can be added at the moment when the GraphicsContextGLOpenGL
uses in core WebGL are modified to GraphicsContextGL uses.

No new tests, a refactor.

• PlatformMac.cmake:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/GraphicsContextGL.h:
• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::asCV):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::copyVideoTextureToPlatformTexture):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture):

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):

• platform/graphics/cv/GraphicsContextGLCV.h: Added.
• platform/graphics/cv/GraphicsContextGLCVANGLE.cpp: Renamed from Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp.

(WebCore::GraphicsContextGLCVANGLE::GraphicsContextGLCVANGLE):
(WebCore::GraphicsContextGLCVANGLE::~GraphicsContextGLCVANGLE):
(WebCore::GraphicsContextGLCVANGLE::initializeUVContextObjects):
(WebCore::GraphicsContextGLCVANGLE::attachIOSurfaceToTexture):
(WebCore::GraphicsContextGLCVANGLE::detachIOSurfaceFromTexture):
(WebCore::GraphicsContextGLCVANGLE::copyPixelBufferToTexture):

• platform/graphics/cv/GraphicsContextGLCVANGLE.h: Renamed from Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.h.
• platform/graphics/opengl/GraphicsContextGLOpenGL.h:

1:06 AM Changeset in webkit [269677] by ysuzuki@apple.com

• 2 edits in trunk/Source/WTF

Unreviewed, reverting r269403
​https://bugs.webkit.org/show_bug.cgi?id=218143

Now, bytecode list is moved out of JSCConfig. So it is not large size now.

• wtf/WTFConfig.h:

12:35 AM Changeset in webkit [269676] by commit-queue@webkit.org

• 19 edits
  1 delete in trunk/Source

Unreviewed, reverting r269244.
​https://bugs.webkit.org/show_bug.cgi?id=218483

Patch is breaking tests

Reverted changeset:

"Stop sending origins from WebProcess to UIProcess for
getUserMedia requests"
​https://bugs.webkit.org/show_bug.cgi?id=218192
​https://trac.webkit.org/changeset/269244

12:13 AM Changeset in webkit [269675] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK] Annotate WebKitUserMessage getters as nullable
​https://bugs.webkit.org/show_bug.cgi?id=218761

Patch by Corentin Noël <​corentin.noel@collabora.com> on 2020-11-11
Reviewed by Carlos Garcia Campos.

These properties can be set to NULL at creation time.

• Shared/API/glib/WebKitUserMessage.cpp: