Timeline

Nov 14, 2020:

5:38 PM Changeset in webkit [269822] by Simon Fraser

• 9 edits in trunk/Source/WebCore

[LFC Display] Implement propagation background style from body to root
​https://bugs.webkit.org/show_bug.cgi?id=218947

Reviewed by Zalan Bujtas.

The root display box needs to get its background style from the document element box,
if it has one, otherwise the body box. If the body background style is propagated
to the root, then the body box needs to not paint its background.

Implement by adding BoxFactory::determineRootBackgroundPropagation(), and consulting
the result when creating the display boxes for the root and body. This is complicated
slightly by the need to pass the correct style to constructBoxDecorationData(),
which deals with both backgrounds and other (non-propagating) properties.

• display/DisplayTreeBuilder.cpp:

(WebCore::Display::TreeBuilder::build):
(WebCore::Display::TreeBuilder::recursiveBuildDisplayTree const):
(WebCore::Display::TreeBuilder::build const): Deleted.

• display/DisplayTreeBuilder.h:
• display/css/DisplayBoxFactory.cpp:

(WebCore::Display::BoxFactory::determineRootBackgroundPropagation):
(WebCore::Display::BoxFactory::displayBoxForRootBox const):
(WebCore::Display::BoxFactory::displayBoxForBodyBox const):
(WebCore::Display::BoxFactory::displayBoxForLayoutBox const):
(WebCore::Display::BoxFactory::constructBoxDecorationData const):
(WebCore::Display::BoxFactory::setupBoxModelBox const):
(WebCore::Display::BoxFactory::documentElementBoxFromRootBox):
(WebCore::Display::BoxFactory::bodyBoxFromRootBox):

• display/css/DisplayBoxFactory.h:
• display/css/DisplayFillLayerImageGeometry.cpp:

(WebCore::Display::calculateFillLayerImageGeometry):

• display/css/DisplayFillLayerImageGeometry.h:
• display/css/DisplayStyle.cpp:

(WebCore::Display::Style::Style):
(WebCore::Display::Style::setupBackground):

• display/css/DisplayStyle.h:

1:43 PM Changeset in webkit [269821] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Negative margin before (>border box height value) completely pulls the inline level box out of the line box
​https://bugs.webkit.org/show_bug.cgi?id=218945

Reviewed by Antti Koivisto.

maximumTopOffsetFromRootInlineBoxBaseline could very well be negative e.g
<div><div style="display: inline-block; height: 10px; margin-top: -20px"></div></div>.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically):

11:46 AM Changeset in webkit [269820] by commit-queue@webkit.org

• 23 edits
  5 deletes in trunk

Remove -webkit-aspect-ratio support
​https://bugs.webkit.org/show_bug.cgi?id=218384

Patch by Rob Buis <​rbuis@igalia.com> on 2020-11-14
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Remove tests for -webkit-aspect-ratio.

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:

Source/WebCore:

Remove -webkit-aspect-ratio support since it is superseded
by aspect-ratio (​https://www.w3.org/TR/css-sizing-4/).

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• css/StyleProperties.cpp:
• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeWebkitAspectRatio): Deleted.

• layout/layouttree/LayoutReplacedBox.cpp:

(WebCore::Layout::ReplacedBox::hasAspectRatio const):

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::aspectRatioType const):
(WebCore::RenderStyle::setAspectRatioType):
(WebCore::RenderStyle::initialAspectRatioType):
(WebCore::RenderStyle::aspectRatioDenominator const): Deleted.
(WebCore::RenderStyle::aspectRatioNumerator const): Deleted.
(WebCore::RenderStyle::setAspectRatioDenominator): Deleted.
(WebCore::RenderStyle::setAspectRatioNumerator): Deleted.
(WebCore::RenderStyle::initialAspectRatioDenominator): Deleted.
(WebCore::RenderStyle::initialAspectRatioNumerator): Deleted.

• rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

• rendering/style/RenderStyleConstants.h:
• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):

• rendering/style/StyleRareNonInheritedData.h:
• style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyInitialWebkitAspectRatio): Deleted.
(WebCore::Style::BuilderCustom::applyInheritWebkitAspectRatio): Deleted.
(WebCore::Style::BuilderCustom::applyValueWebkitAspectRatio): Deleted.

LayoutTests:

Remove tests for -webkit-aspect-ratio.

• fast/css/aspect-ratio-inheritance-expected.txt: Removed.
• fast/css/aspect-ratio-inheritance.html: Removed.
• fast/css/aspect-ratio-parsing-tests-expected.txt: Removed.
• fast/css/aspect-ratio-parsing-tests.html: Removed.
• fast/css/aspect-ratio/badchess-tall.png: Removed.
• fast/css/aspect-ratio/badchess-wide.png: Removed.
• fast/css/aspect-ratio/columns-expected.html: Removed.
• fast/css/aspect-ratio/columns.html: Removed.
• fast/css/aspect-ratio/containers-expected.html: Removed.
• fast/css/aspect-ratio/containers.html: Removed.
• fast/css/aspect-ratio/simple-expected.html: Removed.
• fast/css/aspect-ratio/simple.html: Removed.
• platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
• platform/ios-13/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
• platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:

10:25 AM Changeset in webkit [269819] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Gardening imported/w3c/web-platform-tests/css/css-color/composited-filters-under-opacity.html

Unreviewed test gardening.

• platform/gtk/TestExpectations:

9:38 AM Changeset in webkit [269818] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][Integration] Use the physical size when setting the pre-computed width/height on ReplacedBox
​https://bugs.webkit.org/show_bug.cgi?id=218915

Reviewed by Antti Koivisto.

This is where the logical vs. physical coordinate flip happens on the integration level.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateReplacedDimensions):
(WebCore::LayoutIntegration::LineLayout::updateInlineBlockDimensions):

• layout/integration/LayoutIntegrationLineLayout.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutModernLines):

7:26 AM Changeset in webkit [269817] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] Display runs generated by boxes should have border box geometries
​https://bugs.webkit.org/show_bug.cgi?id=218932

Reviewed by Antti Koivisto.

Layout::Runs/InlineBoxes have margin box geometries, but the Display::Runs should preserve border box instead.
This is mostly interesting in the context of negative vertical margins where such margin values could make the run "empty".

• layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

5:53 AM Changeset in webkit [269816] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Inline level box with negative vertical margin should not be considered empty
​https://bugs.webkit.org/show_bug.cgi?id=218933

Reviewed by Antti Koivisto.

While in practice when the negative vertical margin makes the layout bounds empty (e.g: height: 100px; margin-top: -100px;),
and the inline level box contributes 0px to the line box height, it should not be considered empty.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

3:59 AM Changeset in webkit [269815] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit

Unreviewed, suppressing GCC compilation warnings.

• UIProcess/API/wpe/ScrollGestureController.cpp:

(WebKit::ScrollGestureController::handleEvent):
Explicitly store the std::abs() results as uint32_t values. This avoids
comparison between the otherwise-signed return values and the unsigned
constants.

2:28 AM Changeset in webkit [269814] by don.olmstead@sony.com

• 12 edits in trunk/Source

[clang-tidy] Run modernize-use-override through JSC
​https://bugs.webkit.org/show_bug.cgi?id=218916

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• inspector/agents/InspectorAgent.h:
• inspector/agents/InspectorScriptProfilerAgent.h:
• inspector/agents/InspectorTargetAgent.h:
• inspector/agents/JSGlobalObjectAuditAgent.h:
• inspector/agents/JSGlobalObjectDebuggerAgent.h:
• inspector/agents/JSGlobalObjectRuntimeAgent.h:
• inspector/remote/socket/RemoteInspectorConnectionClient.h:
• inspector/remote/socket/RemoteInspectorServer.h:
• runtime/JSGlobalObjectDebuggable.h:

Source/WTF:

• wtf/RunLoop.h:

1:01 AM Changeset in webkit [269813] by graouts@webkit.org

• 18 edits in trunk

Support animations on more pseudo-elements
​https://bugs.webkit.org/show_bug.cgi?id=218792
<rdar://problem/71274485>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Add PASS results for WPT tests running animations on ::marker pseudo-elements.

• web-platform-tests/css/css-animations/Document-getAnimations.tentative-expected.txt:
• web-platform-tests/css/css-animations/animationevent-marker-pseudoelement-expected.txt:
• web-platform-tests/css/css-animations/event-order.tentative-expected.txt:
• web-platform-tests/css/css-pseudo/marker-animate-expected.txt:
• web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
• web-platform-tests/css/css-transitions/Document-getAnimations.tentative-expected.txt:

Source/WebCore:

We used to only support animations for pseudo-elements that were represented by PseudoElement (::before and ::after).
With this patch, we can now animate any public pseudo-element, such as ::marker.

• animation/KeyframeEffect.cpp:

(WebCore::elementOrPseudoElementForStyleable): For pseudo-elements other than ::before or ::after, return the Styleable's
element since a PseudoElement is only accessible for the aforementioned pseudo-elements.
(WebCore::KeyframeEffect::targetElementOrPseudoElement const): For pseudo-elements other than ::before or ::after, return
the animation target as the target element.

• dom/PseudoElement.cpp:

(WebCore::PseudoElement::rendererIsNeeded): Refactor what was originally isTargetedByKeyframeEffectRequiringPseudoElement()
into this method since isTargetedByKeyframeEffectRequiringPseudoElement() was removed.
(WebCore::PseudoElement::isTargetedByKeyframeEffectRequiringPseudoElement): Remove this method from PseudoElement since
pseudo-elements that are not represented by a PseudoElement need similar logic, which is now available through the static
function elementIsTargetedByKeyframeEffectRequiringPseudoElement() in RenderTreeUpdaterGeneratedContent.cpp.

• dom/PseudoElement.h:
• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree): Pass the entire set of ElementUpdates instead of just the ElementUpdate to
updateElementRenderer() such that it may process the new pseudoElementUpdates member.
(WebCore::RenderTreeUpdater::updateBeforeDescendants): Pass the entire set of ElementUpdates and a PseudoId to
updatePseudoElement() such that it may use the new pseudoElementUpdates member in combination with the PseudoId
to determine what ElementUpdate to use.
(WebCore::RenderTreeUpdater::updateAfterDescendants): Pass the entire set of ElementUpdates and a PseudoId to
updatePseudoElement() such that it may use the new pseudoElementUpdates member in combination with the PseudoId
to determine what ElementUpdate to use.
(WebCore::RenderTreeUpdater::updateElementRenderer): Use the new pseudoElementUpdates member in ElementUpdates to set the
pseudo-element styles.

• rendering/updating/RenderTreeUpdater.h:
• rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::elementIsTargetedByKeyframeEffectRequiringPseudoElement): New static method meant to replace the removed
PseudoElement::isTargetedByKeyframeEffectRequiringPseudoElement() such that we may use this method regardless of whether
the pseudo-element is represented by PseudoElement.
(WebCore::createContentRenderers): Use elementIsTargetedByKeyframeEffectRequiringPseudoElement() instead of the removed
PseudoElement::isTargetedByKeyframeEffectRequiringPseudoElement().
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement): Look up all ElementUpdate for the provided PseudoId
in the new pseudoElementUpdates member in ElementUpdates in order to determine what ElementUpdate to process. Also, use
elementIsTargetedByKeyframeEffectRequiringPseudoElement() instead of the removed
PseudoElement::isTargetedByKeyframeEffectRequiringPseudoElement().
(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):

• rendering/updating/RenderTreeUpdaterGeneratedContent.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement): Resolve any public pseudo-element instead of just ::before and ::after
and save those in the new ElementUpdates pseudoElementUpdates member.
(WebCore::Style::TreeResolver::resolvePseudoStyle): Resolve any pseudo-element set on an element that either has animations
set on it, either set by Web Animations, as seen on the KeyframeEffectStack, or yet to be applied through a CSS Animation or
CSS Transition, as seen on the RenderStyle.

• style/StyleTreeResolver.h:
• style/StyleUpdate.h: Add a new pseudoElementUpdates member on ElementUpdates.

12:52 AM Changeset in webkit [269812] by graouts@webkit.org

• 17 edits
  1 add in trunk

Add support for discrete animations of many CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=218902

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

By virtue of animation a host of new properties, we run an extra 551 tests and pass 518 of them.

• web-platform-tests/css/css-logical/animations/float-interpolation-expected.txt:
• web-platform-tests/css/css-position/animations/position-interpolation-expected.txt:
• web-platform-tests/css/css-transitions/properties-value-003-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

Add support for discrete animation of the following properties:

-webkit-backface-visibility, -webkit-box-decoration-break, -webkit-hyphens, -webkit-initial-letter,
-webkit-print-color-adjust, -webkit-ruby-position, -webkit-text-emphasis-color, -webkit-text-emphasis-position,
border-bottom-style, border-collapse, border-left-style, border-right-style, border-top-style, box-sizing,
caption-side, clear, column-fill, column-rule-style, column-rule-style, cursor, empty-cells, flex-direction,
flex-wrap, float, grid-auto-columns, grid-auto-flow, grid-auto-rows, grid-column-end, grid-column-start,
grid-row-end, grid-row-start, image-orientation, isolation, justify-content, justify-items, justify-self,
list-style-position, list-style-type, mix-blend-mode, object-fit, outline-style, overflow-wrap, overflow-x,
overflow-y, page-break-after, page-break-before, page-break-inside, paint-order, pointer-events, position,
resize, table-layout, text-align, text-decoration-color, text-decoration-line, text-decoration-style,
text-overflow, text-transform, touch-action, transform-box, transform-style, white-space, word-break.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• rendering/style/GridPosition.cpp:

(WebCore::operator<<):

• rendering/style/GridPosition.h:
• rendering/style/GridTrackSize.cpp: Added.

(WebCore::operator<<):

• rendering/style/GridTrackSize.h:

Nov 13, 2020:

8:04 PM Changeset in webkit [269811] by Lauro Moura

• 3 edits in trunk/LayoutTests

[GLIB] Gardening some failures

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

6:16 PM Changeset in webkit [269810] by sihui_liu@apple.com

• 50 edits
  4 copies
  11 adds in trunk

Implement basic permission check for SpeechRecognition
​https://bugs.webkit.org/show_bug.cgi?id=218476
<rdar://problem/71222638>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: fast/speechrecognition/permission-error.html

fast/speechrecognition/start-recognition-in-removed-iframe.html

• Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::startRecognition):

• Modules/speech/SpeechRecognitionConnection.h:
• Modules/speech/SpeechRecognitionRequest.cpp:

(WebCore::SpeechRecognitionRequest::create): Deleted.

• Modules/speech/SpeechRecognitionRequest.h:

(WebCore::SpeechRecognitionRequest::clientOrigin const):

• Modules/speech/SpeechRecognitionRequestInfo.h:

(WebCore::SpeechRecognitionRequestInfo::encode const):
(WebCore::SpeechRecognitionRequestInfo::decode):

• Modules/speech/SpeechRecognitionUpdate.cpp:

(WebCore::SpeechRecognitionUpdate::create):
(WebCore::SpeechRecognitionUpdate::error const):
(WebCore::SpeechRecognitionUpdate::result const):

• Modules/speech/SpeechRecognitionUpdate.h:
• page/DummySpeechRecognitionProvider.h:

Source/WebKit:

Introduce SpeechRecognitionPermissionManager, which checks and requests speech recognition permissions before
we actually start capturing audio and perform recognition. SpeechRecognitionPermissionManager is per-page, like
SpeechRecognitionServer. The checks include:

1. Sandbox requirement for microphone
2. TCC check for microphone
3. TCC check for SFSpeechRecognizer
4. User permission on speech recognition for origin

Add a delegate function for requesting user permission. By default, user permission is not granted.

API test: WebKit2.SpeechRecognitionUserPermissionPersistence

• Headers.cmake:
• Shared/API/APIObject.h:
• Shared/API/c/WKBase.h:
• Sources.txt:
• SourcesCocoa.txt:
• UIProcess/API/APIUIClient.h:

(API::UIClient::decidePolicyForSpeechRecognitionPermissionRequest):

• UIProcess/API/C/WKAPICast.h:
• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/API/C/WKPageUIClient.h:
• UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp: Added.

(WKSpeechRecognitionPermissionCallbackGetTypeID):
(WKSpeechRecognitionPermissionCallbackComplete):

• UIProcess/API/C/WKSpeechRecognitionPermissionCallback.h: Added.
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _speechRecognitionEnabled]):
(-[WKPreferences _setSpeechRecognitionEnabled:]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/MediaPermissionUtilities.mm: Added.

(WebKit::checkSandboxRequirementForType):
(WebKit::checkUsageDescriptionStringForType):
(WebKit::checkUsageDescriptionStringForSpeechRecognition):
(WebKit::requestAVCaptureAccessForType):
(WebKit::checkAVCaptureAccessForType):
(WebKit::requestSpeechRecognitionAccess):
(WebKit::checkSpeechRecognitionServiceAccess):

• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForSpeechRecognitionPermissionRequest):

• UIProcess/Cocoa/UserMediaPermissionRequestManagerProxy.mm:

(WebKit::UserMediaPermissionRequestManagerProxy::permittedToCaptureAudio):
(WebKit::UserMediaPermissionRequestManagerProxy::permittedToCaptureVideo):
(WebKit::UserMediaPermissionRequestManagerProxy::requestSystemValidation):
(WebKit::requestAVCaptureAccessForMediaType): Deleted.

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:
• UIProcess/MediaPermissionUtilities.h: Copied from Added.
• UIProcess/SpeechRecognitionPermissionManager.cpp: Added.

(WebKit::computeMicrophoneAccess):
(WebKit::computeSpeechRecognitionServiceAccess):
(WebKit::SpeechRecognitionPermissionManager::SpeechRecognitionPermissionManager):
(WebKit::SpeechRecognitionPermissionManager::~SpeechRecognitionPermissionManager):
(WebKit::SpeechRecognitionPermissionManager::request):
(WebKit::SpeechRecognitionPermissionManager::startNextRequest):
(WebKit::SpeechRecognitionPermissionManager::startProcessingRequest):
(WebKit::SpeechRecognitionPermissionManager::continueProcessingRequest):
(WebKit::SpeechRecognitionPermissionManager::completeCurrentRequest):
(WebKit::SpeechRecognitionPermissionManager::requestSpeechRecognitionServiceAccess):
(WebKit::SpeechRecognitionPermissionManager::requestMicrophoneAccess):
(WebKit::SpeechRecognitionPermissionManager::requestUserPermission):

• UIProcess/SpeechRecognitionPermissionManager.h: Added.
• UIProcess/SpeechRecognitionPermissionRequest.h: Added.

(WebKit::SpeechRecognitionPermissionRequest::create):
(WebKit::SpeechRecognitionPermissionRequest::complete):
(WebKit::SpeechRecognitionPermissionRequest::origin const):
(WebKit::SpeechRecognitionPermissionRequest::SpeechRecognitionPermissionRequest):
(WebKit::SpeechRecognitionPermissionCallback::create):
(WebKit::SpeechRecognitionPermissionCallback::complete):
(WebKit::SpeechRecognitionPermissionCallback::SpeechRecognitionPermissionCallback):

• UIProcess/SpeechRecognitionServer.cpp:

(WebKit::SpeechRecognitionServer::SpeechRecognitionServer):
(WebKit::SpeechRecognitionServer::start):
(WebKit::SpeechRecognitionServer::requestPermissionForRequest):
(WebKit::SpeechRecognitionServer::stop):
(WebKit::SpeechRecognitionServer::abort):
(WebKit::SpeechRecognitionServer::invalidate):
(WebKit::SpeechRecognitionServer::handleRequest):
(WebKit::SpeechRecognitionServer::stopRequest):
(WebKit::SpeechRecognitionServer::abortRequest):
(WebKit::SpeechRecognitionServer::sendUpdate):
(WebKit::SpeechRecognitionServer::processNextPendingRequestIfNeeded): Deleted.
(WebKit::SpeechRecognitionServer::removePendingRequest): Deleted.
(WebKit::SpeechRecognitionServer::startPocessingRequest): Deleted.
(WebKit::SpeechRecognitionServer::stopProcessingRequest): Deleted.

• UIProcess/SpeechRecognitionServer.h:
• UIProcess/SpeechRecognitionServer.messages.in:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeMainDocument):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::requestSpeechRecognitionPermission):

• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createSpeechRecognitionServer):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.cpp:

(WebKit::WebSpeechRecognitionConnection::start):
(WebKit::WebSpeechRecognitionConnection::didReceiveUpdate):

• WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.h:

Source/WTF:

• wtf/PlatformHave.h:

Tools:

• MiniBrowser/mac/Info.plist:
• MobileMiniBrowser/MobileMiniBrowser/Info.plist:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm: Added.

(-[SpeechRecognitionPermissionUIDelegate _webView:requestSpeechRecognitionPermissionForOrigin:decisionHandler:]):
(-[SpeechRecognitionMessageHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/speechrecognition-user-permission-persistence.html: Added.
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setIsSpeechRecognitionPermissionGranted):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::decidePolicyForSpeechRecognitionPermissionRequest):
(WTR::TestController::completeSpeechRecognitionPermissionCheck):
(WTR::TestController::setIsSpeechRecognitionPermissionGranted):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::resetStateToConsistentValues):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

• TestExpectations:
• fast/speechrecognition/permission-error-expected.txt: Added.
• fast/speechrecognition/permission-error.html: Added.
• fast/speechrecognition/resources/removed-iframe.html: Added.
• fast/speechrecognition/start-recognition-in-removed-iframe-expected.txt: Added.
• fast/speechrecognition/start-recognition-in-removed-iframe.html: Added.
• platform/wk2/TestExpectations:

6:11 PM Changeset in webkit [269809] by Chris Dumez

• 7 edits in trunk

[GPUProcess] Add basic GPUProcess crash handling for canvas
​https://bugs.webkit.org/show_bug.cgi?id=218924

Reviewed by Simon Fraser.

Source/WebKit:

Update RemoteRenderingBackendProxy to be a GPUProcessConnection::Client so that it
gets notified when the IPC connection to the GPUProcess gets severed. When this
happens, RemoteRenderingBackendProxy clears all its SharedMemory handles and
sends IPC messages to the GPU process to recreate all the ImageBuffers we had.

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::create):
(WebKit::RemoteImageBufferProxy::clearBackend):
(WebKit::RemoteImageBufferProxy::size const):
(WebKit::RemoteImageBufferProxy::renderingMode const):
(WebKit::RemoteImageBufferProxy::colorSpace const):
(WebKit::RemoteImageBufferProxy::pixelFormat const):
(WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::connectToGPUProcess):
(WebKit::recreateImage):
(WebKit::RemoteRenderingBackendProxy::gpuProcessConnectionDidClose):
(WebKit::RemoteRenderingBackendProxy::createImageBuffer):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

(WebKit::RemoteResourceCacheProxy::imageBuffers const):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(convertToCGImage):
(getPixelIndex):
(TEST):

5:09 PM Changeset in webkit [269808] by Chris Dumez

• 2 edits in trunk/Source/WebKit

[GPUProcess] Add basic low memory handling in the GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=218926
<rdar://problem/70300888>

Reviewed by Geoffrey Garen.

Add basic low memory handling in the GPUProcess. For now, the GPUProcess only calls
WTF::releaseFastMallocFreeMemory() on low memory warning.

• GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::initializeGPUProcess):

4:55 PM Changeset in webkit [269807] by Kate Cheney

• 25 edits in trunk/Source

Can't login to Microsoft Teams
​https://bugs.webkit.org/show_bug.cgi?id=218778
<rdar://problem/36331568>

Reviewed by John Wilander.

This is a temporary quirk to assist a high-traffic website while they
complete the large task of migrating away from login flows that
require third party cookies. This quirk will be removed when the site
is updated.

Create a quirk to call the Storage Access API on behalf of Microsoft.

Source/WebCore:

No new tests, site-specific quirk.

• dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):
Pass additional parameters to be able to dispatch a synthetic click
if storage access is granted.

• loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::setDomainsWithCrossPageStorageAccess):
(WebCore::ResourceLoadObserver::hasCrossPageStorageAccess const):
Store domains in the web process to avoid async calls to the network
process.

(WebCore::isMicrosoftLoginElement):
(WebCore::isMicrosoftDomain):

• page/Quirks.cpp:

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
This is the quirk.

• page/Quirks.h:
• platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::setDomainsWithCrossPageStorageAccess):
(WebCore::NetworkStorageSession::grantCrossPageStorageAccess):
(WebCore::NetworkStorageSession::hasStorageAccess const):
(WebCore::NetworkStorageSession::grantStorageAccess):
(WebCore::NetworkStorageSession::removeAllStorageAccess):
(WebCore::NetworkStorageSession::storageAccessQuirks):
(WebCore::NetworkStorageSession::canRequestStorageAccessForLoginPurposesWithoutPriorUserInteraction):
(WebCore::NetworkStorageSession::loginDomainForFirstParty):
(WebCore::NetworkStorageSession::mapToTopDomain):
The user might go directly to login.live.com to sign in to Microsoft
Teams, but may not have seen the Storage Access prompt. In this case,
we should map live.com to microsoft.com and request storage access for
microsoftonline.com under microsoft.com. Since login.live.com is used
for other Microsoft login flows besides Teams, a user may have to
grant storage access to microsoftonline.com even when it is not needed
to complete the login. But this guarantees they will always be
successfully logged into all Microsoft accounts.

• platform/network/NetworkStorageSession.h:

In order for the user to stay logged in between sessions, we should
update NetworkStorageSession to grant storage access based on values
stored in the ITP database for quirk domains.

Source/WebKit:

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
Relax the requirement for user interaction for a specific third party
needing cookies for authentication purposes.

(WebKit::ResourceLoadStatisticsDatabaseStore::clear):
(WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess):
Relax the requirement for user interaction for a specific third party
needing cookies for authentication purposes.

(WebKit::ResourceLoadStatisticsDatabaseStore::domainsWithStorageAccess const):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateCookieBlocking):

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::clear):
(WebKit::ResourceLoadStatisticsMemoryStore::updateCookieBlocking):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessEphemeral):
Relax user interaction for reasons above.

(WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToBlockCookiesForHandler):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:

(WebKit::RegistrableDomainsToBlockCookiesFor::isolatedCopy const):

• Shared/WebProcessDataStoreParameters.h:

(WebKit::WebProcessDataStoreParameters::encode const):
(WebKit::WebProcessDataStoreParameters::decode):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::setDomainsWithCrossPageStorageAccess):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::webProcessDataStoreParameters):
(WebKit::WebProcessPool::setDomainsWithCrossPageStorageAccess):

• UIProcess/WebProcessPool.h:
• WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::hasCrossPageStorageAccess const):
(WebKit::WebResourceLoadObserver::setDomainsWithCrossPageStorageAccess):

• WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setWebsiteDataStoreParameters):
(WebKit::WebProcess::setDomainsWithCrossPageStorageAccess):
Add quirk'd domains to have page level storage access to be able to
use document.cookie.

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

Forward domains with the storage access quirk to the web process to
avoid an async call to the network process.

4:20 PM Changeset in webkit [269806] by BJ Burg

• 2 edits in trunk/Source/WebCore

REGRESSION(r269701): inspector/console/webcore-logging.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=218840
<rdar://problem/71310952>

Reviewed by Devin Rousso.

This test is triggering a bizarre backtrace that fails the assertion ASSERT(m_frontendLoaded)
in the frontend dispatcher. The sequence of events present in the stack trace is as follows:

1. Test.html finishes loading.
2. DOMContentLoaded event listener eventually calls InspectorFrontendHost::loaded().
3. InspectorFrontendClient::frontendLoaded() calls -[NSWindow showWindow:] on the inspector window, which makes the inspected webpage window unfocus and resign first responder.
4. Unfocusing causes an activity state change and style recalc. Script is unsafe to execute under this.
5. Synchronously under the style recalc, inspector instrumentation is triggered when layers change.
6. The backend sends a protocol event, which is synchronously dispatched to the frontend.
7. Due to script evaluation being unsafe in (4), the frontend dispatcher tries to suspend. This hits the assertion because the frontend dispatcher hasn't been notified that the frontend finished loading as part of (3).

This only affects WebKitLegacy clients, where events 1-7 happen synchronously from top to bottom
due to the single process architecture. In the multiprocess case, frontendLoaded is an async
IPC message and frontend evaluations are not affected by the state of the inspected page.

• inspector/InspectorFrontendAPIDispatcher.cpp:

(WebCore::InspectorFrontendAPIDispatcher::frontendLoaded): Dispatch messages iff not suspended.

(WebCore::InspectorFrontendAPIDispatcher::suspend): Remove the assertion that is incorrect.
Allow clients of this class to call suspend() before frontendLoaded().

(WebCore::InspectorFrontendAPIDispatcher::unsuspend): Using a similar argument as above, it
is possible that WebKitLegacy may unsuspend the dispatcher before the frontend has fully loaded.

4:02 PM Changeset in webkit [269805] by weinig@apple.com

• 17 edits in trunk/Source

Move some more WebKit and WebKitLegacy preferences bound to Settings to WebPreferences.yaml
​https://bugs.webkit.org/show_bug.cgi?id=218914

Reviewed by Tim Horton.

Source/WebCore:

Moves AppleMailPaginationQuirkEnabled, ContentDispositionAttachmentSandboxEnabled and
UseImageDocumentForSubframePDF from Settings.yaml to WebPreferences.yaml and merges in
WebCore values for ScrollingPerformanceLoggingEnabled.

• page/Settings.yaml:

Source/WebKit:

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

• UIProcess/WebPageProxy.h:
• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::appleMailPaginationQuirkEnabled): Deleted.
(WebKit::WebPageProxy::appleMailLinesClampEnabled): Deleted.
Removes appleMailPaginationQuirkEnabled and appleMailLinesClampEnabled.
appleMailPaginationQuirkEnabled is now handled via the preferences infrastructure
and appleMailLinesClampEnabled was unused.

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultAppleMailPaginationQuirkEnabled):

• Shared/WebPreferencesDefaultValues.h:

Adds default value for AppleMailPaginationQuirkEnabled, which is now in WebPreferences.yaml.
Moved from WebPageProxyMac.mm

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Removes explicit setting of setAppleMailPaginationQuirkEnabled, setContentDispositionAttachmentSandboxEnabled,
setScrollingPerformanceLoggingEnabled and setUseImageDocumentForSubframePDF which are all generated now.
LayoutViewportHeightExpansionFactor was already generated so this call was just redundant.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setScrollingPerformanceLoggingEnabled): Deleted.
It's also no longer necessary to store m_scrollingPerformanceLoggingEnabled as the value
can be extracted directly from the store in the one place it was read. setScrollingPerformanceLoggingEnabled
was never called, so has been removed.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
Extract scrollingPerformanceLoggingEnabled directly from the store rather than having the page
set it just for this one place to read it.

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove explicit setting of Settings::setContentDispositionAttachmentSandboxEnabled as
it is now handled by the generated code. Merge together a few sequential #ifdefs while
in the area.

Source/WTF:

Moves AppleMailPaginationQuirkEnabled, ContentDispositionAttachmentSandboxEnabled and
UseImageDocumentForSubframePDF from Settings.yaml to WebPreferences.yaml. Merges in
WebCore values from ScrollingPerformanceLoggingEnabled and removes binding override
since it can now be fully generated.

• Scripts/Preferences/WebPreferences.yaml:

3:46 PM Changeset in webkit [269804] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Update CompileWebKit step for new buildbot
​https://bugs.webkit.org/show_bug.cgi?id=218922

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/steps.py:

(CompileWebKit.start): Initialize logobserver.
(CompileWebKit.parseOutputLine): Method to process each line.
(CompileWebKit._addToLog): Method to add to the log which is displayed in UI.
(CompileWebKit.createSummary):

2:56 PM Changeset in webkit [269803] by Ryan Haddad

• 3 edits
  2 deletes in trunk

Unreviewed, reverting r269776.

The test added with this change is asserting

Reverted changeset:

"Null check anchorNode of endingSelection start"
​https://bugs.webkit.org/show_bug.cgi?id=218492
​https://trac.webkit.org/changeset/269776

2:38 PM Changeset in webkit [269802] by ggaren@apple.com

• 7 edits in trunk/Source

Removed DeferrableTaskTimer
​https://bugs.webkit.org/show_bug.cgi?id=218874

Reviewed by Chris Dumez.

It was (mostly) redundant.

Source/WebCore:

• platform/Timer.h:

(WebCore::Timer::schedule): This helper function does the same job
that DeferrableTaskTimer used to do.

(WebCore::DeferrableTaskTimer::fired): Deleted.
(WebCore::DeferrableTaskTimer::doTask): Deleted.
(WebCore::DeferrableTaskTimer::cancel): Deleted.

• platform/mediarecorder/MediaRecorderPrivateMock.cpp:

(WebCore::MediaRecorderPrivateMock::fetchData): Use the new helper function.

• platform/mediarecorder/MediaRecorderPrivateMock.h: No need for a data

member anymore since we can use the schedule() convenience function instead.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateReportedMediaCaptureState):

• UIProcess/WebPageProxy.h: Use WTF::RunLoop::Timer instead of

WebCore::Timer because WebCore::Timer for WebKit code in the UI process
is a no-no, which can crash if the UI process also uses WebThread.

2:32 PM Changeset in webkit [269801] by commit-queue@webkit.org

• 15 edits in trunk

[JSC] Use symbols as identifiers for class fields computed names storage
​https://bugs.webkit.org/show_bug.cgi?id=216172

Patch by Xan López <Xan Lopez> on 2020-11-13
Reviewed by Yusuke Suzuki.

Use private symbols for the property keys of the class fields with
computed names. This is cleaner than using raw numeric identifiers and
will be less cumbersome when we add static fields. It also prevents
potential collisions if other features want to store data in the class
scope.

JSTests:

• stress/class-fields-harmony.js: new test, make sure

setFunctionName works properly with computed fields.

Source/JavaScriptCore:

• bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitSaveComputedFieldName): adapt a comment.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass): use private identifiers for computed fields property keys.
(JSC::Parser<LexerType>::parseInstanceFieldInitializerSourceElements): ditto.

• parser/ParserArena.cpp:

(JSC::IdentifierArena::makePrivateIdentifier): method to create a private identifier.

• parser/ParserArena.h:
• runtime/CachedTypes.cpp:

(JSC::CachedUniquedStringImplBase::encode): consider registered symbols, they are used by the parser now.
(JSC::CachedUniquedStringImplBase::decode const): ditto.

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

(JSC::VM::privateSymbolRegistry): create a private symbol registry too.

Source/WTF:

• wtf/text/SymbolImpl.cpp:

(WTF::RegisteredSymbolImpl::createPrivate): add a method to create a registered private symbol from a string key.

• wtf/text/SymbolImpl.h:
• wtf/text/SymbolRegistry.cpp:

(WTF::SymbolRegistry::symbolForKey): consider that we can hold private symbols now too.

• wtf/text/SymbolRegistry.h:

(WTF::SymbolRegistry::SymbolRegistry): new enum type for public/private symbols.

2:29 PM Changeset in webkit [269800] by Alan Coon

• 1 copy in tags/Safari-610.3.7.1.4

Tag Safari-610.3.7.1.4.

2:22 PM Changeset in webkit [269799] by Russell Epstein

• 1 edit in branches/safari-610-branch/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_indata.c

Apply patch. rdar://problem/71378194

2:17 PM Changeset in webkit [269798] by Russell Epstein

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r269384. rdar://problem/71381924

REGRESSION (r257839): Miscomputed style due to computed 'rem' value in matched declaration cache
​https://bugs.webkit.org/show_bug.cgi?id=218561
<rdar://problem/70074191>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/dom/focus-rem-style-update.html

Call to focus() causes computed style update for the element’s ancestor chain before the the document
has otherwise been styled (using the shortcut mechanism introduced in r257839). This style, which uses ‘rem’
unit and so depends on root element font size, gets cached in MatchedDeclarationsCache. The root font size
then changes but during the resulting style update we use this cached value, failing to re-resolve ‘rem’.

• style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement):

Invalidate matched declarations cache also when there is no existing document element style.

LayoutTests:

• fast/dom/focus-rem-style-update-expected.html: Added.
• fast/dom/focus-rem-style-update.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:17 PM Changeset in webkit [269797] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r269321. rdar://problem/71083861

Protect against HTMLMediaElement being destroyed during disptachEvent().
​https://bugs.webkit.org/show_bug.cgi?id=218398
<rdar://problem/67613836>

Reviewed by Chris Dumez.

Make the MainThreadGenericEventQueue protect the target as well as the owner of the queue.

Drive-by fix: Create the scoped eventFiringScope object after the protect object, to ensure
that the member variable set by the first scope will safely occur.

Drive-by fix #2: Also null-check the result of document().page() within HTMLMediaElement::dispatchEvent().

• dom/GenericEventQueue.cpp: (WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEvent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:17 PM Changeset in webkit [269796] by Russell Epstein

• 7 edits
  1 add in branches/safari-610-branch/Source

Cherry-pick r269208. rdar://problem/71378171

AX: Incorrect list of voices being displayed on iOS
​https://bugs.webkit.org/show_bug.cgi?id=218293

Reviewed by Per Arne Vollan.

Source/WebCore:

Limit the voices that we display in WebSpeech to only built-in system voices. This was the intention of the "compact"
decision, but some mobile assets have compact voices, which are not available WebContent.

• platform/ios/PlatformSpeechSynthesizerIOS.mm: (WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/PlatformMac.cmake:
• pal/spi/cocoa/AXSpeechManagerSPI.h: Added.

Source/WTF:

• wtf/PlatformHave.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:16 PM Changeset in webkit [269795] by Russell Epstein

• 6 edits
  2 adds in branches/safari-610-branch

Cherry-pick r269121. rdar://problem/71381839

[MSE] Handle trackId changing across Initialization Segments
​https://bugs.webkit.org/show_bug.cgi?id=218294
<rdar://problem/70771306>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-trackid-change.html

When appending an initialization segment after the receivedFirstInitializationSegment flag is
true, and when the number of video or audio tracks is 1, the trackId is allowed to change across
initialiaztion segments. When this occurs, move the TrackBuffer inside the trackBufferMap to
refer to the new trackId, so that when MediaSamples are parsed, they're put into the correct
TrackBuffer.

• Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
• html/track/AudioTrack.cpp: (WebCore::AudioTrack::setPrivate):
• html/track/InbandTextTrack.cpp: (WebCore::InbandTextTrack::setPrivate):
• html/track/VideoTrack.cpp: (WebCore::VideoTrack::setPrivate):

LayoutTests:

• media/media-source/media-source-trackid-change-expected.txt: Added.
• media/media-source/media-source-trackid-change.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@269121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:16 PM Changeset in webkit [269794] by Russell Epstein

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r268782. rdar://problem/71381941

Release assert in ~Node due to render element of pseudo element not getting removed in time
​https://bugs.webkit.org/show_bug.cgi?id=217996

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2020-10-20
Reviewed by Ryosuke Niwa.

When attaching a shadow root to an element, remember to tear down renderers not only if
one exists on the element, but also if it uses display: contents.

• dom/Element.cpp: (WebCore::Element::addShadowRoot):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:16 PM Changeset in webkit [269793] by Russell Epstein

• 7 edits in branches/safari-610-branch

Cherry-pick r266052. rdar://problem/71378190

RTCRtpSynchronizationSource.rtpTimestamp is not present
​https://bugs.webkit.org/show_bug.cgi?id=215722

Patch by Justin Uberti <​justin@uberti.name> on 2020-08-24
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations file to indicate that tests checking for .rtpTimestamp now pass.

• LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt.

• Modules/mediastream/RTCRtpContributingSource.idl:
• Modules/mediastream/RTCRtpContributingSource.idl:
• Modules/mediastream/RTCRtpSynchronizationSource.idl: Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated.
• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp: (WebCore::fillRTCRtpContributingSource):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:13 PM Changeset in webkit [269792] by pvollan@apple.com

• 3 edits in trunk/Source/WebKit

[macOS] Issue sandbox extension to the WebContent process for com.apple.lskdd
​https://bugs.webkit.org/show_bug.cgi?id=218920
<rdar://problem/69168801>

Reviewed by Geoffrey Garen.

This is a Media related service, and a sandbox extension should be issued to the WebContent process based on GPU runtime settings.

No new tests, covered by existing tests.

• UIProcess/WebPageProxy.cpp:

(WebKit::mediaRelatedMachServices):

• WebProcess/com.apple.WebProcess.sb.in:

1:49 PM Changeset in webkit [269791] by ysuzuki@apple.com

• 8 edits in trunk/JSTests

Unreviewed, skip new ICU related tests in MIPS and ARMv7 and adjust it for ICU 65
​https://bugs.webkit.org/show_bug.cgi?id=213822

• stress/intl-datetimeformat-formatrange-relevant-extensions.js:
• stress/intl-datetimeformat-formatrange-should-not-handle-gregorian-change-date.js:
• stress/intl-datetimeformat-formatrange.js:

(test):

• stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:
• stress/intl-datetimeformat-formatrangetoparts-relevant-extensions.js:
• stress/intl-datetimeformat-formatrangetoparts-should-not-handle-gregorian-change-date.js:
• stress/intl-datetimeformat-formatrangetoparts.js:

1:39 PM Changeset in webkit [269790] by commit-queue@webkit.org

• 6 edits
  1 add in trunk

WebAssembly: opcodes for table.grow and table.size are mixed up
​https://bugs.webkit.org/show_bug.cgi?id=218644

Patch by Sergey Rubanov <Sergey Rubanov> on 2020-11-13
Reviewed by Yusuke Suzuki.

JSTests:

• wasm/stress/table-grow-table-size.js: Added.

(async test):

• wasm/wasm.json:

Source/JavaScriptCore:

• wasm/wasm.json:

LayoutTests:

• workers/wasm-references/test.js:

1:19 PM Changeset in webkit [269789] by Claudio Saavedra

• 17 edits in trunk/Source

Non-unified build fixes.
​https://bugs.webkit.org/show_bug.cgi?id=218905

Unreviewed.

Source/WebCore:

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h:
• animation/WebAnimationUtilities.h:
• display/css/DisplayBoxDecorationData.h:
• dom/BoundaryPoint.cpp:
• dom/EventDispatcher.cpp:
• html/HTMLFrameOwnerElement.h:
• layout/integration/LayoutIntegrationInlineContentBuilder.h:
• loader/DocumentWriter.h:
• page/FrameTree.h:
• platform/encryptedmedia/CDMPrivate.cpp:
• rendering/InlineTextBox.cpp:

Source/WebKit:

• GPUProcess/graphics/RemoteRenderingBackend.cpp:
• GPUProcess/graphics/RemoteResourceCache.h:

1:11 PM Changeset in webkit [269788] by commit-queue@webkit.org

• 4 edits
  1 delete in trunk/Source/WebKit

Remove more SecItemShim leftovers
​https://bugs.webkit.org/show_bug.cgi?id=218919

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-11-13
Reviewed by Geoffrey Garen.

• Configurations/SecItemShim.xcconfig: Removed.
• NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkServiceEntryPoint.mm:

(NETWORK_SERVICE_INITIALIZER):

• PlatformMac.cmake:
• WebKit.xcodeproj/project.pbxproj:

1:09 PM Changeset in webkit [269787] by Jonathan Bedard

• 2 edits in trunk/Tools

REGRESSION: r269514 Reset server port before restarting webserver
​https://bugs.webkit.org/show_bug.cgi?id=218918
<rdar://problem/71380345>

Reviewed by Stephanie Lewis.

• Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.serve): Reset server port.
(SimpleHTTPServerDriver.kill_server): Ditto.

10:22 AM Changeset in webkit [269786] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Update RunAPITests step for new buildbot
​https://bugs.webkit.org/show_bug.cgi?id=218907

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/steps.py:

(TestWithFailureCount.getText): Added FIXME to remove this method after switching to buildbot v2.
(TestWithFailureCount.getText2): Added FIXME to remove this method after switching to buildbot v2.
(TestWithFailureCount.getResultSummary): Method to generate custom step summary.
(RunWebKitTests.getResultSummary): Removed unnecessary u, python3 defaults to unicode anyways.
(RunAPITests):
(RunAPITests.start): Use ParseByLineLogObserver.
(RunAPITests.countFailures):
(RunAPITests.parseOutputLine): Method to process each line.

9:51 AM Changeset in webkit [269785] by Darin Adler

• 92 edits
  14 deletes in trunk

Remove unused advanced plug-in features: snapshotting and plug-in load policy
​https://bugs.webkit.org/show_bug.cgi?id=218835

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

• LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Updated for progression.

Source/WebCore:

• Headers.cmake: Removed some headers.
• Sources.txt: Removed some source files.
• WebCore.xcodeproj/project.pbxproj: Ditto.

• css/CSSPrimitiveValueMappings.h: Removed SnapshottedPluginOverlayPart.
• css/CSSValueKeywords.in: Removed snapshotted-plugin-overlay.

• html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement): Moved member initialization to
the class definition.
(WebCore::HTMLPlugInElement::canProcessDrag const): Deleted.
(WebCore::HTMLPlugInElement::defaultEventHandler): Removed snapshot-specific code.
(WebCore::HTMLPlugInElement::swapRendererTimerFired): Removed code to handle
DisplayingSnapshot state.
(WebCore::HTMLPlugInElement::setDisplayState): Ditto.

• html/HTMLPlugInElement.h: Removed WaitingForSnapshot, DisplayingSnapshot,

Restarting and RestartingWithPendingMouseClick states, updateSnapshot,
dispatchPendingMouseClick, isRestartedPlugin, and canProcessDrag. Marked some
more functions final, made a couple non-virtual, and moved some things from
public to protected and protected to private.

• html/HTMLPlugInImageElement.cpp:

(WebCore::titleText): Deleted.
(WebCore::subtitleText): Deleted.
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Removed a few data
members.
(WebCore::HTMLPlugInImageElement::setDisplayState): Deleted.
(WebCore::HTMLPlugInImageElement::createElementRenderer): Removed code to handle
the DisplayingSnapshot case.
(WebCore::HTMLPlugInImageElement::childShouldCreateRenderer const): Removed code
to handle a snapshotted plug-in.
(WebCore::HTMLPlugInImageElement::willRecalcStyle): Removed check for
the DisplayingSnapshot case.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Deleted.
(WebCore::plugInImageElementIsolatedWorld): Deleted.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Deleted.
(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay const): Deleted.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Deleted.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): Deleted.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Deleted.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Deleted.
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn): Deleted.
(WebCore::HTMLPlugInImageElement::dispatchPendingMouseClick): Deleted.
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Deleted.
(WebCore::documentHadRecentUserGesture): Deleted.
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting): Deleted.
(WebCore::is100Percent): Deleted.
(WebCore::isSmallerThanTinySizingThreshold): Deleted.
(WebCore::HTMLPlugInImageElement::isTopLevelFullPagePlugin const): Deleted.
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus): Deleted.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Deleted.
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn): Deleted.
(WebCore::HTMLPlugInImageElement::defaultEventHandler): Deleted.

• html/HTMLPlugInImageElement.h: Removed the functions mentioned above.

Also loadedUrl, snapshotImage, needsCheckForSizeChange, setNeedsCheckForSizeChange,
snapshotDecision, isRestartedPlugin, m_loadedUrl, m_pendingClickEventFromSnapshot,
m_simulatedMouseClickTimer, m_removeSnapshotTimer, m_snapshotImage,
m_createdDuringUserGesture, m_isRestartedPlugin, m_needsCheckForSizeChange,
m_plugInWasCreated, m_deferredPromotionToPrimaryPlugIn, m_sizeWhenSnapshotted,
m_snapshotDecision, and m_plugInDimensionsSpecified.

• loader/SubframeLoader.cpp:

(WebCore::FrameLoader::SubframeLoader::loadPlugin): Removed calls to
subframeLoaderWillCreatePlugIn/DidCreatePlugIn.

• page/DragController.cpp:

(WebCore::DragController::canProcessDrag): Removed special case for plug-ins.

• page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate): Removed call to
needsCheckForSizeChange.
(WebCore::FrameView::updateEmbeddedObject): Removed special case for
snapshotted plug-in and call to needsCheckForSizeChange.

• page/Page.cpp:

(WebCore::Page::Page): Removed m_plugInClient.

• page/Page.h: Ditto.
• page/PageConfiguration.cpp: Removed PlugInClient.h.
• page/PageConfiguration.h: Removed plugInClient.
• page/PlugInClient.h: Removed.

• page/Settings.yaml: Removed MaximumPlugInSnapshotAttempts.

• platform/ThemeTypes.cpp:

(WebCore::operator<<): Removed SnapshottedPluginOverlayPart.

• platform/ThemeTypes.h: Ditto.

• plugins/PluginViewBase.h: Removed canProcessDrag, shouldAlwaysAutoStart,

and beginSnapshottingRunningPlugin.

• rendering/RenderBoxModelObject.h: Added an export because the linker failed.

Not sure what triggered this.

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage): Deleted.
(WebCore::RenderEmbeddedObject::paintContents): Deleted.
(WebCore::RenderEmbeddedObject::layout): Removed code that was only for
snahpshotted plug-ins, guarded both by an explicit check for snapshot state
and by a check of canHaveChildren (now always false).
(WebCore::RenderEmbeddedObject::canHaveChildren const): Deleted.

• rendering/RenderEmbeddedObject.h: Marked the class final, made everything

private that was protected, removed functions mentioned above, and virtual
canHaveWidget function.

• rendering/RenderLayerBacking.cpp:

(WebCore::isRestartedPlugin): Deleted.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer const):
Removed call to isRestartedPlugin.

• rendering/RenderObject.h: Removed isSnapshottedPlugIn.
• rendering/RenderSnapshottedPlugIn.cpp: Removed.
• rendering/RenderSnapshottedPlugIn.h: Removed.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint): Removed SnapshottedPluginOverlayPart.

• rendering/RenderTheme.h: Removed paintSnapshottedPluginOverlay.
• rendering/RenderThemeMac.h: Ditto.
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay): Deleted.

• testing/Internals.cpp:

(WebCore::Internals::isPluginSnapshotted): Always return false.

Source/WebKit:

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::muteAudio): Deleted.
(WebKit::PluginProcess::platformInitializePluginProcess):

• Scripts/webkit/messages.py: Remove PluginProcessType.
• Shared/Plugins/PluginProcessAttributes.h: Ditto.
• Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode const): Ditto.
(WebKit::PluginProcessCreationParameters::decode): Ditto.

• Shared/Plugins/PluginProcessCreationParameters.h: Ditto.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const): Remove plugInAutoStartOrigins
and pluginLoadClientPolicies.
(WebKit::WebProcessCreationParameters::decode): Ditto.

• Shared/WebProcessCreationParameters.h: Ditto.

• Shared/WebProcessDataStoreParameters.h:

(WebKit::WebProcessDataStoreParameters::encode const): Remove plugInAutoStartOriginHashes.
(WebKit::WebProcessDataStoreParameters::decode): Ditto.

• Sources.txt: Remove PlugInAutoStartProvider.cpp and WebPlugInClient.cpp.

• UIProcess/API/C/WKContext.cpp:

(WKContextCopyPlugInAutoStartOriginHashes): Return nullptr.
(WKContextSetPlugInAutoStartOriginHashes): Do nothing.
(WKContextSetPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime): Ditto.
(WKContextSetPlugInAutoStartOrigins): Ditto.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient): Remove decidePolicyForPluginLoad.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPlugInSnapshottingEnabled): Do nothing.
(WKPreferencesGetPlugInSnapshottingEnabled): Return false.
(WKPreferencesSetSnapshotAllPlugIns): Do nothing.
(WKPreferencesGetSnapshotAllPlugIns): Return false.
(WKPreferencesSetAutostartOriginPlugInSnapshottingEnabled): Do nothing.
(WKPreferencesGetAutostartOriginPlugInSnapshottingEnabled): Return false.
(WKPreferencesSetPrimaryPlugInSnapshotDetectionEnabled): Do nothing.
(WKPreferencesGetPrimaryPlugInSnapshotDetectionEnabled): Return false.

• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextIsPlugInUpdateAvailable): Return false.
(WKContextSetPluginLoadClientPolicy): Do nothing.
(WKContextClearPluginClientPolicies): Do nothing.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setPlugInSnapshottingEnabled:]): Do nothing.
(-[WKPreferences _plugInSnapshottingEnabled]): Return NO.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(toPluginLoadClientPoliciesHashMap): Deleted.
(policiesHashMapToDictionary): Deleted.
(-[WKProcessPool _resetPluginLoadClientPolicies:]): Do nothing.
(-[WKProcessPool _pluginLoadClientPolicies]): Return an empty dictionary.

• UIProcess/Cocoa/NavigationState.h: Remove didFailToInitializePlugIn,

didBlockInsecurePluginVersion, decidePolicyForPluginLoad,
webViewDidFailToInitializePlugInWithInfo,
webViewDidBlockInsecurePluginVersionWithInfo, and
webViewDecidePolicyForPluginLoadWithCurrentPolicyPluginInfoCompletionHandler.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate): Updated for abvoe removals.
(WebKit::NavigationState::NavigationClient::didFailToInitializePlugIn): Deleted.
(WebKit::NavigationState::NavigationClient::didBlockInsecurePluginVersion): Deleted.
(WebKit::pluginModuleLoadPolicy): Deleted.
(WebKit::wkPluginModuleLoadPolicy): Deleted.
(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad): Deleted.

• UIProcess/Plugins/PlugInAutoStartProvider.cpp: Removed.
• UIProcess/Plugins/PlugInAutoStartProvider.h: Removed.

• UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::pluginProcessToken): Removed the
pluginProcessType argument.
(WebKit::PluginProcessManager::fetchWebsiteData): Ditto.
(WebKit::PluginProcessManager::deleteWebsiteData): Ditto.
(WebKit::PluginProcessManager::deleteWebsiteDataForHostNames): Ditto.

• UIProcess/Plugins/PluginProcessManager.h: Ditto.

• UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching): Removed the code to
handle PluginProcessType::Snapshot.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin): Removed the processType argument.

• UIProcess/WebPageProxy.h: Ditto.
• UIProcess/WebPageProxy.messages.in: Ditto.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::webProcessDataStoreParameters): Removed
plugInAutoStartOriginHashes.
(WebKit::WebProcessPool::initializeNewWebProcess): Removed
plugInAutoStartOrigins and pluginLoadClientPolicies.
(WebKit::WebProcessPool::plugInAutoStartOriginHashes const): Deleted.
(WebKit::WebProcessPool::setPlugInAutoStartOriginHashes): Deleted.
(WebKit::WebProcessPool::setPlugInAutoStartOrigins): Deleted.
(WebKit::WebProcessPool::setPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime): Deleted.
(WebKit::WebProcessPool::setPluginLoadClientPolicy): Deleted.
(WebKit::WebProcessPool::resetPluginLoadClientPolicies): Deleted.
(WebKit::WebProcessPool::clearPluginClientPolicies): Deleted.

• UIProcess/WebProcessPool.h: Removed setPluginLoadClientPolicy,

resetPluginLoadClientPolicies, clearPluginClientPolicies,
pluginLoadClientPolicies, plugInAutoStartOriginHashes,
setPlugInAutoStartOriginHashes, setPlugInAutoStartOrigins,
setPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime,
plugInAutoStartProvider, m_plugInAutoStartProvider, and
m_pluginLoadClientPolicies.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addPlugInAutoStartOriginHash): Deleted.
(WebKit::WebProcessProxy::plugInDidReceiveUserInteraction): Deleted.

• UIProcess/WebProcessProxy.h: Ditto.
• UIProcess/WebProcessProxy.messages.in: Ditto.

• WebKit.xcodeproj/project.pbxproj: Removed PlugInAutoStartProvider.cpp/h

and WebPlugInClient.cpp/h.

• WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

Removed include of RenderSnapshottedPlugIn.h.

• WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginLayer): Removed code to handle
m_isRestartedProcess.

• WebProcess/Plugins/PDF/PDFPlugin.h: Removed shouldAlwaysAutoStart.
• WebProcess/Plugins/Plugin.h: Ditto.

• WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::create): Removed isRestartedProcess argument.
(WebKit::PluginProxy::PluginProxy): Ditto. Also moved initialization
to the class definition.

• WebProcess/Plugins/PluginProxy.h: Updated for the above changes.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView): Removed m_pluginSnapshotTimer.
(WebKit::PluginView::recreateAndInitialize): Removed code to manage
m_pluginSnapshotTimer.
(WebKit::PluginView::initializePlugin): Removed code to set
m_didPlugInStartOffScreen.
(WebKit::PluginView::didInitializePlugin): Removed code to handle
restarting plug-ins.
(WebKit::PluginView::paint): Ditto.
(WebKit::PluginView::handleEvent): Removed calls to
pluginDidReceiveUserInteraction.
(WebKit::PluginView::shouldNotAddLayer const): Return false.
(WebKit::PluginView::invalidateRect): Removed code to handle
restarting plug-ins.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Removed
some Flash-specific code.
(WebKit::isAlmostSolidColor): Deleted.
(WebKit::PluginView::pluginSnapshotTimerFired): Deleted.
(WebKit::PluginView::beginSnapshottingRunningPlugin): Deleted.
(WebKit::PluginView::shouldAlwaysAutoStart const): Deleted.
(WebKit::PluginView::pluginDidReceiveUserInteraction): Deleted.

• WebProcess/Plugins/PluginView.h: Removed pluginSnapshotTimerFired,

pluginDidReceiveUserInteraction, shouldAlwaysAutoStart,
beginSnapshottingRunningPlugin, m_didPlugInStartOffScreen,
m_pluginSnapshotTimer, m_countSnapshotRetries, m_didReceiveUserInteraction.

• WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
(WebKit::WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
(WebKit::WebPluginInfoProvider::populatePluginCache): Do not call
pluginLoadClientPolicyForHost.
(WebKit::WebPluginInfoProvider::pluginLoadClientPolicyForHost const): Deleted.
(WebKit::WebPluginInfoProvider::longestMatchedWildcardHostForHost const): Deleted.
(WebKit::WebPluginInfoProvider::replaceHostWithMatchedWildcardHost const): Deleted.

• WebProcess/Plugins/WebPluginInfoProvider.h: Removed setPluginLoadClientPolicy,

clearPluginClientPolicies, pluginLoadClientPolicyForHost,
longestMatchedWildcardHostForHost, replaceHostWithMatchedWildcardHost,
PluginLoadClientPoliciesByBundleVersion, PluginPolicyMapsByIdentifier, and
m_hostsToPluginIdentifierData.

• WebProcess/WebCoreSupport/WebPlugInClient.cpp: Removed.
• WebProcess/WebCoreSupport/WebPlugInClient.h: Removed.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Removed code to initialize
m_determinePrimarySnapshottedPlugInTimer, plugInClient, and processType.
(WebKit::WebPage::createPlugin): Removed isRestartedProcess.
(WebKit::WebPage::close): Removed m_determinePrimarySnapshottedPlugInTimer code.
(WebKit::WebPage::addPluginView): Ditto.
(WebKit::WebPage::removePluginView): Ditto.
(WebKit::WebPage::canPluginHandleResponse): Removed plug-in process type.
(WebKit::WebPage::didCommitLoad): Removed call to resetPrimarySnapshottedPlugIn.
(WebKit::WebPage::didFinishLoad): Removed m_determinePrimarySnapshottedPlugInTimer
code.
(WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired): Deleted.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Deleted.
(WebKit::WebPage::resetPrimarySnapshottedPlugIn): Deleted.
(WebKit::WebPage::matchesPrimaryPlugIn const): Deleted.
(WebKit::WebPage::plugInIntersectsSearchRect): Deleted.
(WebKit::WebPage::plugInIsPrimarySize): Deleted.

• WebProcess/WebPage/WebPage.h: Removed determinePrimarySnapshottedPlugIn,

determinePrimarySnapshottedPlugInTimerFired, resetPrimarySnapshottedPlugIn,
matchesPrimaryPlugIn, plugInIntersectsSearchRect, plugInIsPrimarySize,
m_readyToFindPrimarySnapshottedPlugin, m_didFindPrimarySnapshottedPlugin,
m_numberOfPrimarySnapshotDetectionAttempts, m_primaryPlugInPageOrigin,
m_primaryPlugInOrigin, m_primaryPlugInMimeType, and
m_determinePrimarySnapshottedPlugInTimer.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Removed code to set
m_plugInAutoStartOrigins and call to resetPluginLoadClientPolicies.
(WebKit::WebProcess::setWebsiteDataStoreParameters): Removed call
to resetPlugInAutoStartOriginHashes.
(WebKit::addCaseFoldedCharacters): Deleted.
(WebKit::hashForPlugInOrigin): Deleted.
(WebKit::WebProcess::isPlugInAutoStartOriginHash): Deleted.
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Deleted.
(WebKit::WebProcess::plugInDidStartFromOrigin): Deleted.
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash): Deleted.
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes): Deleted.
(WebKit::WebProcess::plugInDidReceiveUserInteraction): Deleted.
(WebKit::WebProcess::setPluginLoadClientPolicy): Deleted.
(WebKit::WebProcess::resetPluginLoadClientPolicies): Deleted.
(WebKit::WebProcess::clearPluginClientPolicies): Deleted.

• WebProcess/WebProcess.h: Removed shouldPlugInAutoStartFromOrigin,

plugInDidStartFromOrigin, plugInDidReceiveUserInteraction,
setPluginLoadClientPolicy, resetPluginLoadClientPolicies,
clearPluginClientPolicies, isPlugInAutoStartOriginHash,
didAddPlugInAutoStartOriginHash, resetPlugInAutoStartOriginHashes,
m_plugInAutoStartOriginHashes, and m_plugInAutoStartOrigins.

• WebProcess/WebProcess.messages.in: Removed

DidAddPlugInAutoStartOriginHash, ResetPlugInAutoStartOriginHashes,
SetPluginLoadClientPolicy, ResetPluginLoadClientPolicies, and
ClearPluginClientPolicies.

Source/WebKitLegacy/mac:

• WebView/WebPreferences.mm:

(-[WebPreferences plugInSnapshottingEnabled]): Return NO.
(-[WebPreferences setPlugInSnapshottingEnabled:]): Do nothing.

Source/WTF:

• Scripts/Preferences/WebPreferences.yaml: Removed

AutostartOriginPlugInSnapshottingEnabled, PlugInSnapshottingEnabled,
PrimaryPlugInSnapshotDetectionEnabled, and SnapshotAllPlugIns.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Removed

PluginLoadClientPolicies.mm.

• TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm: Removed.

This tested a feature that is now removed.

LayoutTests:

• http/tests/plugins/plugin-allow-then-reload-expected.txt: Removed.
• http/tests/plugins/plugin-allow-then-reload.html: Removed.

This was testing a behavior that's no longer supported, blocking a plug-in so
completely that it doesn't show up in the plug-in list.

• platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Updated for progression.

• platform/mac-wk1/TestExpectations: Removed snapshotting expectations.
• platform/mac-wk2/TestExpectations: Ditto.
• platform/win/TestExpectations: Ditto.
• platform/wincairo/TestExpectations: Ditto.

• platform/mac-wk2/plugins/snapshotting: Removed.
• plugins/snapshotting: Removed.

9:46 AM Changeset in webkit [269784] by weinig@apple.com

• 68 edits in trunk

Cleanup InternalSettings
​https://bugs.webkit.org/show_bug.cgi?id=218881

Reviewed by Darin Adler.

Source/WebCore:

Cleanup InternalSettings by removing all the functions that duplicated functionality
already implemented by InternalSettingsGenerated, sorting the remaining functions by
setting class, and replacing string parameters with proper IDL enums.

• testing/InternalSettings.cpp:
• testing/InternalSettings.h:
• testing/InternalSettings.idl:

Remove duplicate functions and add enums for EditingBehavior, PDFImageCachingPolicy,
StorageBlockingPolicy, SystemLayoutDirection, TrackKind, and UserInterfaceDirectionPolicy.
Most of these map directly to existing WebCore enums (and FontLoadTimingOverride was easily
updated to match the WebCore enum), but new enums were needed for EditingBehavior, PDFImageCachingPolicy
and StorageBlockingPolicy to keep existing tests working. The UserInterfaceDirectionPolicy enum
is different than what the tests expect (tests used "View" rather then "System") but were updated
to match.

• testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setMediaCaptureRequiresSecureConnection): Deleted.

• testing/Internals.h:

Remove now unused function setMediaCaptureRequiresSecureConnection. This should
be done by the test runner or individual tests as needed.

• testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::setAllowsAnySSLCertificate):
Switch to calling DeprecatedGlobalSettings directly rather than hopping
through InternalSettings. This allows us to remove the InternalSettings
function.

LayoutTests:

Update tests to work with update InternalSettings related enum values.

• Platforms passed to internals.settings.setEditingBehavior now must be all lowercase.
• The value "View" has been renamed to "System" for internals.settings.setUserInterfaceDirectionPolicy

• editing/mac/selection/double-click-and-drag-over-anchor-to-select.html:
• editing/selection/shift-click-includes-existing-selection.html:
• editing/selection/user-select-all-with-shift-expected.txt:
• editing/selection/user-select-all-with-shift.html:
• fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html:
• fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.html:
• fast/scrolling/rtl-scrollbars-animation-property.html:
• fast/scrolling/rtl-scrollbars-elementFromPoint-static.html:
• fast/scrolling/rtl-scrollbars-elementFromPoint.html:
• fast/scrolling/rtl-scrollbars-expected.html:
• fast/scrolling/rtl-scrollbars-iframe-offset-expected.html:
• fast/scrolling/rtl-scrollbars-iframe-offset.html:
• fast/scrolling/rtl-scrollbars-iframe-position-absolute.html:
• fast/scrolling/rtl-scrollbars-iframe-scrolled-expected.html:
• fast/scrolling/rtl-scrollbars-iframe-scrolled.html:
• fast/scrolling/rtl-scrollbars-iframe.html:
• fast/scrolling/rtl-scrollbars-listbox-scroll-expected.html:
• fast/scrolling/rtl-scrollbars-listbox-scroll.html:
• fast/scrolling/rtl-scrollbars-listbox-select-left-expected.html:
• fast/scrolling/rtl-scrollbars-listbox-select-left.html:
• fast/scrolling/rtl-scrollbars-listbox-select-right-expected.html:
• fast/scrolling/rtl-scrollbars-listbox-select-right.html:
• fast/scrolling/rtl-scrollbars-listbox-simple.html:
• fast/scrolling/rtl-scrollbars-listbox.html:
• fast/scrolling/rtl-scrollbars-overflow-contents.html:
• fast/scrolling/rtl-scrollbars-overflow-dir-rtl.html:
• fast/scrolling/rtl-scrollbars-overflow-elementFromPoint.html:
• fast/scrolling/rtl-scrollbars-overflow-expected.html:
• fast/scrolling/rtl-scrollbars-overflow-padding.html:
• fast/scrolling/rtl-scrollbars-overflow-position-absolute-expected.html:
• fast/scrolling/rtl-scrollbars-overflow-position-absolute.html:
• fast/scrolling/rtl-scrollbars-overflow-simple.html:
• fast/scrolling/rtl-scrollbars-overflow-text-selection-scrolled.html:
• fast/scrolling/rtl-scrollbars-overflow.html:
• fast/scrolling/rtl-scrollbars-overlay-no-push-contents-expected.html:
• fast/scrolling/rtl-scrollbars-overlay-no-push-contents.html:
• fast/scrolling/rtl-scrollbars-position-absolute-expected.html:
• fast/scrolling/rtl-scrollbars-position-absolute.html:
• fast/scrolling/rtl-scrollbars-position-fixed-expected.html:
• fast/scrolling/rtl-scrollbars-position-fixed.html:
• fast/scrolling/rtl-scrollbars-positioning-expected.html:
• fast/scrolling/rtl-scrollbars-positioning.html:
• fast/scrolling/rtl-scrollbars-simple.html:
• fast/scrolling/rtl-scrollbars-sticky-document-2-expected.html:
• fast/scrolling/rtl-scrollbars-sticky-document-2.html:
• fast/scrolling/rtl-scrollbars-sticky-document-expected.html:
• fast/scrolling/rtl-scrollbars-sticky-document.html:
• fast/scrolling/rtl-scrollbars-sticky-iframe-2-expected.html:
• fast/scrolling/rtl-scrollbars-sticky-iframe-2.html:
• fast/scrolling/rtl-scrollbars-sticky-iframe-expected.html:
• fast/scrolling/rtl-scrollbars-sticky-iframe.html:
• fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2-expected.html:
• fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html:
• fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-expected.html:
• fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html:
• fast/scrolling/rtl-scrollbars-text-selection-expected.html:
• fast/scrolling/rtl-scrollbars-text-selection-scrolled-expected.html:
• fast/scrolling/rtl-scrollbars-text-selection-scrolled.html:
• fast/scrolling/rtl-scrollbars-text-selection.html:
• fast/scrolling/rtl-scrollbars.html:

9:44 AM Changeset in webkit [269783] by Adrian Perez de Castro

• 5 edits in releases/WebKitGTK/webkit-2.30/Source/JavaScriptCore

Merge r265891 - B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_1.cpp:

(run):

• b3/testb3_5.cpp:

(testCheckSubBitAnd):

9:22 AM Changeset in webkit [269782] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Remote encoder should set its encoder frame callback to nullptr when being released
​https://bugs.webkit.org/show_bug.cgi?id=218906

Reviewed by Eric Carlson.

• Source/webrtc/sdk/WebKit/WebKitEncoder.mm:

(webrtc::RemoteVideoEncoder::Release):
We need to reset the callback at Release call time so that WebKit will take a lock to set it back to null.
That way, we ensure to not call this callback while libwebrtc expects not to be called.

9:21 AM Changeset in webkit [269781] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Use python3 to run transfer-to-s3 script
​https://bugs.webkit.org/show_bug.cgi?id=218904

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/steps.py:

(TransferToS3.start):

8:46 AM Changeset in webkit [269780] by Simon Fraser

• 15 edits
  8 adds in trunk

Force wheel event listeners on the root to be passive
​https://bugs.webkit.org/show_bug.cgi?id=218842
<rdar://problem/71312668>

Reviewed by Chris Dumez.

Following Blink (​https://www.chromestatus.com/feature/6662647093133312) force 'wheel' and
'mousewheel' event listeners on root objects (window, document and body) to be passive if
they were not explicitly registered as non-passive.

This behavior is controlled by an experimental feature flag, and a linked-on-or-after check
to avoid changing behavior for apps that embed WebKit until they link against new SDKs.

Source/WebCore:

Tests: fast/events/wheel/wheel-event-listeners-on-body-made-passive.html

fast/events/wheel/wheel-event-listeners-on-document-made-passive.html
fast/events/wheel/wheel-event-listeners-on-window-left-active.html
fast/events/wheel/wheel-event-listeners-on-window-made-passive.html

• page/Quirks.cpp:

(WebCore::Quirks::shouldMakeEventListenerPassive):

• platform/cocoa/VersionChecks.h:

Source/WebKit:

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCSSOMViewScrollingAPIEnabled):
(WebKit::defaultPassiveWheelListenersAsDefaultOnDocument):

• Shared/WebPreferencesDefaultValues.h:

Source/WebKitLegacy/mac:

• WebView/WebPreferencesDefaultValues.h:
• WebView/WebPreferencesDefaultValues.mm:

(WebKit::defaultPassiveTouchListenersAsDefaultOnDocument):
(WebKit::defaultPassiveWheelListenersAsDefaultOnDocument):

Source/WTF:

• Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

• fast/events/wheel/wheel-event-listeners-on-body-made-passive-expected.txt: Added.
• fast/events/wheel/wheel-event-listeners-on-body-made-passive.html: Added.
• fast/events/wheel/wheel-event-listeners-on-document-made-passive-expected.txt: Added.
• fast/events/wheel/wheel-event-listeners-on-document-made-passive.html: Added.
• fast/events/wheel/wheel-event-listeners-on-window-left-active-expected.txt: Added.
• fast/events/wheel/wheel-event-listeners-on-window-left-active.html: Added.
• fast/events/wheel/wheel-event-listeners-on-window-made-passive-expected.txt: Added.
• fast/events/wheel/wheel-event-listeners-on-window-made-passive.html: Added.

8:08 AM Changeset in webkit [269779] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Tighten inline-block coverage conditions
​https://bugs.webkit.org/show_bug.cgi?id=218901

Reviewed by Zalan Bujtas.

The current ones allow some non-inline-blocks.

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

8:04 AM Changeset in webkit [269778] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Crash in ReplaceSelectionCommand::moveNodeOutOfAncestor
​https://bugs.webkit.org/show_bug.cgi?id=218878

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2020-11-13
Reviewed by Alex Christensen.

Source/WebCore:

Add a missing null check inside moveNodeOutOfAncestor, as splitTreeToNode()
can return nullptr.

Test: editing/execCommand/crash-deleting-after-inserting-text-horizontal-rule.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor):

LayoutTests:

Add simple test that selects elements, and using execCommand() inserts text
and a horizontal rule, and performs a deletion.

• editing/execCommand/crash-deleting-after-inserting-text-horizontal-rule-expected.txt: Added.
• editing/execCommand/crash-deleting-after-inserting-text-horizontal-rule.html: Added.

8:01 AM Changeset in webkit [269777] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebKit

Add _STAttributionDisplayName to macOS WebContent Info.plist
​https://bugs.webkit.org/show_bug.cgi?id=218900

Reviewed by Youenn Fablet.

• WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:

8:00 AM Changeset in webkit [269776] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Null check anchorNode of endingSelection start
​https://bugs.webkit.org/show_bug.cgi?id=218492

Patch by Rob Buis <​rbuis@igalia.com> on 2020-11-13
Reviewed by Alex Christensen.

Source/WebCore:

Null check anchorNode of endingSelection start.

Test: editing/deleting/delete-contenteditable-crash.html

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs):

LayoutTests:

Add testcase.

• editing/deleting/delete-contenteditable-crash-expected.txt: Added.
• editing/deleting/delete-contenteditable-crash.html: Added.

7:30 AM Changeset in webkit [269775] by Aditya Keerthi

• 11 edits
  1 add in trunk/Source

[iOS][FCR] Add an internal feature flag to enable the new appearance
​https://bugs.webkit.org/show_bug.cgi?id=218873
<rdar://problem/71345270>

Reviewed by Tim Horton.

Source/WebCore:

Add a feature flag for the iOS form control refresh, so that the
feature can be tested.

A new user-agent stylesheet is introduced for the refresh so that
the new styles can be opted in to at runtime. Only styles which
differ from the existing stylesheet will be added to the new one.

• DerivedSources-input.xcfilelist:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• css/iOSFormControlRefresh.css: Added.
• style/InspectorCSSOMWrappers.cpp:

(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers):

• style/UserAgentStyle.cpp:

(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

• style/UserAgentStyle.h:

Source/WTF:

Enable the feature at build time on PLATFORM(IOS_FAMILY) and disable
the feature at runtime.

• Scripts/Preferences/WebPreferencesInternal.yaml:
• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:

6:32 AM Changeset in webkit [269774] by graouts@webkit.org

• 6 edits in trunk

Support more properties on ::marker
​https://bugs.webkit.org/show_bug.cgi?id=218894
<rdar://problem/71368343>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark some WPT progressions.

• web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:

Source/WebCore:

In preparation for the support of animations on ::marker and other pseudo-elements, we add support for animation and transition
properties and add more rules to the user-agent stylesheet as defined by ​https://drafts.csswg.org/css-lists-3/#marker-properties.

• css/html.css:

(::marker):

• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::computeMarkerStyle const):

• style/PropertyCascade.cpp:

(WebCore::Style::isValidMarkerStyleProperty):

6:12 AM Changeset in webkit [269773] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Add initial bidi support
​https://bugs.webkit.org/show_bug.cgi?id=218884

Reviewed by Antti Koivisto.

In this patch, we introduce the Bidi Run and the Iterator and use the BidiResolver to compute
the bidi boundaries.
Currently only single direction content is passed in to the BidiResolver which meas that we always
end up with one and only one Bidi run.

• layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::Iterator::offset const):
(WebCore::LayoutIntegration::Iterator::currentRun const):
(WebCore::LayoutIntegration::Iterator::runOffset const):
(WebCore::LayoutIntegration::Iterator::operator== const):
(WebCore::LayoutIntegration::Iterator::operator!= const):
(WebCore::LayoutIntegration::Iterator::atEnd const):
(WebCore::LayoutIntegration::Iterator::Iterator):
(WebCore::LayoutIntegration::Iterator::direction const):
(WebCore::LayoutIntegration::Iterator::increment):
(WebCore::LayoutIntegration::BidiRun::start const):
(WebCore::LayoutIntegration::BidiRun::end const):
(WebCore::LayoutIntegration::BidiRun::level const):
(WebCore::LayoutIntegration::BidiRun::next const):
(WebCore::LayoutIntegration::BidiRun::setNext):
(WebCore::LayoutIntegration::BidiRun::takeNext):
(WebCore::LayoutIntegration::BidiRun::BidiRun):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):

5:12 AM Changeset in webkit [269772] by magomez@igalia.com

• 9 edits in trunk

[GTK][WPE] CSS backdrop overlay corners are not rounded on results.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=215445

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Pass the backdropFiltersRect from CoordinatedGraphicsLayer through Nicosia to TextureMapperLayer. The
latter will use this value to clip when painting the backdrop layer.

Based on a patch created by Carlos Garcia Campos <​cgarcia@igalia.com>.

• platform/graphics/nicosia/NicosiaPlatformLayer.h:

(Nicosia::CompositionLayer::flushState):

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::setBackdropFiltersRect):

• platform/graphics/texmap/TextureMapperLayer.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setBackdropFilters):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

Source/WebKit:

Pass the backdropFiltersRect from the state to TextureMapperLayer.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::updateSceneState):

LayoutTests:

Update expectations for passing tests.

• platform/glib/TestExpectations:

4:41 AM Changeset in webkit [269771] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Remove SecItemShim.dylib from network service link
​https://bugs.webkit.org/show_bug.cgi?id=218892

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-11-13
Reviewed by Antti Koivisto.

Fixes a build failure after
​https://bugs.webkit.org/show_bug.cgi?id=218862

• Configurations/NetworkService.xcconfig:

4:18 AM Changeset in webkit [269770] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][Integration] Minor rename and cleanup in InlineContentBuilder
​https://bugs.webkit.org/show_bug.cgi?id=218883

Reviewed by Antti Koivisto.

• layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
(WebCore::LayoutIntegration::InlineContentBuilder::constructDisplayLineRuns const): Deleted.
(WebCore::LayoutIntegration::InlineContentBuilder::constructDisplayLines const): Deleted.

• layout/integration/LayoutIntegrationInlineContentBuilder.h:
• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

4:07 AM Changeset in webkit [269769] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Decouple box and text run construction
​https://bugs.webkit.org/show_bug.cgi?id=218882

Reviewed by Antti Koivisto.

This is in preparation for adding bidi support where we may need to split a run on bidi boundaries.

• layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::constructDisplayLineRuns const):

1:53 AM Changeset in webkit [269768] by commit-queue@webkit.org

• 12 edits in trunk/Source/WebCore

Remove uses of MakeCurrent from WebGL implementation
​https://bugs.webkit.org/show_bug.cgi?id=218178
<rdar://problem/70714561>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-11-13
Reviewed by Dean Jackson.

Work towards WebGL implementation which uses
GraphicsContextGL abstract base class instead of
GraphicsContextGLOpenGL concrete class.

Move GraphicsContextGLOpenGL::makeContextCurrent() to
private section, as it is an implementation detail of
the class. The function is intended to be called at the
start of all public functions that might call into OpenGL
to ensure that OpenGL uses the right context.

Check all return values of makeCurrentContext(). We
should not call into OpenGL if the context is not current,
as that can lead to corruption, crashes or incorrect results.
Add a compile-time warning if the return value is not used.
Non-EWS compiled flavors of GraphicsContextGLOpenGL are changed
only in best effort manner.

Ensure that all functions actually call the makeCurrentContext()
function before calling into OpenGL. Non-ANGLE flavors of
GraphicsContextGLOpenGL are ensured only in best effort manner.

ANGLE flavor of GraphicsContextGLOpenGL function implementations
should call directly the ANGLE functions instead of calling them
through getExtensions() interface. There is no conditional code
inside and the implementation knows exactly which function to
call in all situations. There is no abstraction between
GraphicsContextGLOpenGL and ExtensionsGL, rather they are
in practice the same object currently, semi-artificially split to
two. This is true of other flavors of GraphicsContextGLOpenGL,
but those are left unchanged in this regard.

No new tests, a refactor.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::validateElementArraySize):
(WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContextBase::validateDrawElements):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
(WebCore::WebGLRenderingContextBase::initVertexAttrib0):

• platform/graphics/angle/ExtensionsGLANGLE.cpp:

(WebCore::ExtensionsGLANGLE::supports):
(WebCore::ExtensionsGLANGLE::ensureEnabled):
(WebCore::ExtensionsGLANGLE::getTranslatedShaderSourceANGLE):
(WebCore::ExtensionsGLANGLE::blitFramebuffer):
(WebCore::ExtensionsGLANGLE::renderbufferStorageMultisample):
(WebCore::ExtensionsGLANGLE::createVertexArrayOES):
(WebCore::ExtensionsGLANGLE::deleteVertexArrayOES):
(WebCore::ExtensionsGLANGLE::isVertexArrayOES):
(WebCore::ExtensionsGLANGLE::bindVertexArrayOES):
(WebCore::ExtensionsGLANGLE::drawBuffersEXT):
(WebCore::ExtensionsGLANGLE::drawArraysInstanced):
(WebCore::ExtensionsGLANGLE::drawElementsInstanced):
(WebCore::ExtensionsGLANGLE::vertexAttribDivisor):
(WebCore::ExtensionsGLANGLE::getBooleanvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFloatvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFramebufferAttachmentParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getIntegervRobustANGLE):
(WebCore::ExtensionsGLANGLE::getProgramivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getRenderbufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getShaderivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribPointervRobustANGLE):
(WebCore::ExtensionsGLANGLE::readPixelsRobustANGLE):
(WebCore::ExtensionsGLANGLE::texImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texSubImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexSubImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexSubImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texSubImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferPointervRobustANGLE):
(WebCore::ExtensionsGLANGLE::getIntegeri_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInternalformativRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getActiveUniformBlockivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInteger64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInteger64i_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferParameteri64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFramebufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getProgramInterfaceivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBooleani_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getMultisamplefvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexLevelParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexLevelParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getPointervRobustANGLERobustANGLE):
(WebCore::ExtensionsGLANGLE::readnPixelsRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjecti64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectui64vRobustANGLE):

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorage):
(WebCore::GraphicsContextGLOpenGL::getIntegerv):
(WebCore::GraphicsContextGLOpenGL::getIntegeri_v):
(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):
(WebCore::GraphicsContextGLOpenGL::depthRange):
(WebCore::GraphicsContextGLOpenGL::clearDepth):
(WebCore::GraphicsContextGLOpenGL::readPixels):
(WebCore::GraphicsContextGLOpenGL::prepareTexture):
(WebCore::GraphicsContextGLOpenGL::readRenderingResults):
(WebCore::GraphicsContextGLOpenGL::reshape):
(WebCore::GraphicsContextGLOpenGL::activeTexture):
(WebCore::GraphicsContextGLOpenGL::attachShader):
(WebCore::GraphicsContextGLOpenGL::bindAttribLocation):
(WebCore::GraphicsContextGLOpenGL::bindBuffer):
(WebCore::GraphicsContextGLOpenGL::bindFramebuffer):
(WebCore::GraphicsContextGLOpenGL::bindRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::bindTexture):
(WebCore::GraphicsContextGLOpenGL::blendColor):
(WebCore::GraphicsContextGLOpenGL::blendEquation):
(WebCore::GraphicsContextGLOpenGL::blendEquationSeparate):
(WebCore::GraphicsContextGLOpenGL::blendFunc):
(WebCore::GraphicsContextGLOpenGL::blendFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::bufferData):
(WebCore::GraphicsContextGLOpenGL::bufferSubData):
(WebCore::GraphicsContextGLOpenGL::mapBufferRange):
(WebCore::GraphicsContextGLOpenGL::unmapBuffer):
(WebCore::GraphicsContextGLOpenGL::copyBufferSubData):
(WebCore::GraphicsContextGLOpenGL::getInternalformativ):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorageMultisample):
(WebCore::GraphicsContextGLOpenGL::texStorage2D):
(WebCore::GraphicsContextGLOpenGL::texStorage3D):
(WebCore::GraphicsContextGLOpenGL::getActiveUniforms):
(WebCore::GraphicsContextGLOpenGL::checkFramebufferStatus):
(WebCore::GraphicsContextGLOpenGL::clearColor):
(WebCore::GraphicsContextGLOpenGL::clear):
(WebCore::GraphicsContextGLOpenGL::clearStencil):
(WebCore::GraphicsContextGLOpenGL::colorMask):
(WebCore::GraphicsContextGLOpenGL::compileShader):
(WebCore::GraphicsContextGLOpenGL::compileShaderDirect):
(WebCore::GraphicsContextGLOpenGL::copyTexImage2D):
(WebCore::GraphicsContextGLOpenGL::copyTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::cullFace):
(WebCore::GraphicsContextGLOpenGL::depthFunc):
(WebCore::GraphicsContextGLOpenGL::depthMask):
(WebCore::GraphicsContextGLOpenGL::detachShader):
(WebCore::GraphicsContextGLOpenGL::disable):
(WebCore::GraphicsContextGLOpenGL::disableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::drawArrays):
(WebCore::GraphicsContextGLOpenGL::drawElements):
(WebCore::GraphicsContextGLOpenGL::enable):
(WebCore::GraphicsContextGLOpenGL::enableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::finish):
(WebCore::GraphicsContextGLOpenGL::flush):
(WebCore::GraphicsContextGLOpenGL::framebufferRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::framebufferTexture2D):
(WebCore::GraphicsContextGLOpenGL::frontFace):
(WebCore::GraphicsContextGLOpenGL::generateMipmap):
(WebCore::GraphicsContextGLOpenGL::getActiveAttribImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformImpl):
(WebCore::GraphicsContextGLOpenGL::getAttachedShaders):
(WebCore::GraphicsContextGLOpenGL::getAttribLocation):
(WebCore::GraphicsContextGLOpenGL::moveErrorsToSyntheticErrorList):
(WebCore::GraphicsContextGLOpenGL::getError):
(WebCore::GraphicsContextGLOpenGL::getString):
(WebCore::GraphicsContextGLOpenGL::hint):
(WebCore::GraphicsContextGLOpenGL::isBuffer):
(WebCore::GraphicsContextGLOpenGL::isEnabled):
(WebCore::GraphicsContextGLOpenGL::isFramebuffer):
(WebCore::GraphicsContextGLOpenGL::isProgram):
(WebCore::GraphicsContextGLOpenGL::isRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::isShader):
(WebCore::GraphicsContextGLOpenGL::isTexture):
(WebCore::GraphicsContextGLOpenGL::lineWidth):
(WebCore::GraphicsContextGLOpenGL::linkProgram):
(WebCore::GraphicsContextGLOpenGL::pixelStorei):
(WebCore::GraphicsContextGLOpenGL::polygonOffset):
(WebCore::GraphicsContextGLOpenGL::sampleCoverage):
(WebCore::GraphicsContextGLOpenGL::scissor):
(WebCore::GraphicsContextGLOpenGL::shaderSource):
(WebCore::GraphicsContextGLOpenGL::stencilFunc):
(WebCore::GraphicsContextGLOpenGL::stencilFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilMask):
(WebCore::GraphicsContextGLOpenGL::stencilMaskSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilOp):
(WebCore::GraphicsContextGLOpenGL::stencilOpSeparate):
(WebCore::GraphicsContextGLOpenGL::texParameterf):
(WebCore::GraphicsContextGLOpenGL::texParameteri):
(WebCore::GraphicsContextGLOpenGL::uniform1f):
(WebCore::GraphicsContextGLOpenGL::uniform1fv):
(WebCore::GraphicsContextGLOpenGL::uniform2f):
(WebCore::GraphicsContextGLOpenGL::uniform2fv):
(WebCore::GraphicsContextGLOpenGL::uniform3f):
(WebCore::GraphicsContextGLOpenGL::uniform3fv):
(WebCore::GraphicsContextGLOpenGL::uniform4f):
(WebCore::GraphicsContextGLOpenGL::uniform4fv):
(WebCore::GraphicsContextGLOpenGL::uniform1i):
(WebCore::GraphicsContextGLOpenGL::uniform1iv):
(WebCore::GraphicsContextGLOpenGL::uniform2i):
(WebCore::GraphicsContextGLOpenGL::uniform2iv):
(WebCore::GraphicsContextGLOpenGL::uniform3i):
(WebCore::GraphicsContextGLOpenGL::uniform3iv):
(WebCore::GraphicsContextGLOpenGL::uniform4i):
(WebCore::GraphicsContextGLOpenGL::uniform4iv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4fv):
(WebCore::GraphicsContextGLOpenGL::useProgram):
(WebCore::GraphicsContextGLOpenGL::validateProgram):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribPointer):
(WebCore::GraphicsContextGLOpenGL::vertexAttribIPointer):
(WebCore::GraphicsContextGLOpenGL::viewport):
(WebCore::GraphicsContextGLOpenGL::createVertexArray):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::bindVertexArray):
(WebCore::GraphicsContextGLOpenGL::getBooleanv):
(WebCore::GraphicsContextGLOpenGL::getBufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getFloatv):
(WebCore::GraphicsContextGLOpenGL::getInteger64v):
(WebCore::GraphicsContextGLOpenGL::getInteger64i_v):
(WebCore::GraphicsContextGLOpenGL::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContextGLOpenGL::getProgramiv):
(WebCore::GraphicsContextGLOpenGL::getProgramInfoLog):
(WebCore::GraphicsContextGLOpenGL::getRenderbufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getShaderiv):
(WebCore::GraphicsContextGLOpenGL::getShaderInfoLog):
(WebCore::GraphicsContextGLOpenGL::getTexParameterfv):
(WebCore::GraphicsContextGLOpenGL::getTexParameteriv):
(WebCore::GraphicsContextGLOpenGL::getUniformfv):
(WebCore::GraphicsContextGLOpenGL::getUniformiv):
(WebCore::GraphicsContextGLOpenGL::getUniformuiv):
(WebCore::GraphicsContextGLOpenGL::getUniformLocation):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribfv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribiv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribOffset):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::createBuffer):
(WebCore::GraphicsContextGLOpenGL::createFramebuffer):
(WebCore::GraphicsContextGLOpenGL::createProgram):
(WebCore::GraphicsContextGLOpenGL::createRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::createShader):
(WebCore::GraphicsContextGLOpenGL::createTexture):
(WebCore::GraphicsContextGLOpenGL::deleteBuffer):
(WebCore::GraphicsContextGLOpenGL::deleteFramebuffer):
(WebCore::GraphicsContextGLOpenGL::deleteProgram):
(WebCore::GraphicsContextGLOpenGL::deleteRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::deleteShader):
(WebCore::GraphicsContextGLOpenGL::deleteTexture):
(WebCore::GraphicsContextGLOpenGL::texImage2DDirect):
(WebCore::GraphicsContextGLOpenGL::drawArraysInstanced):
(WebCore::GraphicsContextGLOpenGL::drawElementsInstanced):
(WebCore::GraphicsContextGLOpenGL::vertexAttribDivisor):
(WebCore::GraphicsContextGLOpenGL::getUniformBlockIndex):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockName):
(WebCore::GraphicsContextGLOpenGL::uniformBlockBinding):
(WebCore::GraphicsContextGLOpenGL::createQuery):
(WebCore::GraphicsContextGLOpenGL::beginQuery):
(WebCore::GraphicsContextGLOpenGL::endQuery):
(WebCore::GraphicsContextGLOpenGL::getQueryObjectuiv):
(WebCore::GraphicsContextGLOpenGL::createTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::deleteTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::isTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::beginTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::endTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::transformFeedbackVaryings):
(WebCore::GraphicsContextGLOpenGL::getTransformFeedbackVarying):
(WebCore::GraphicsContextGLOpenGL::bindBufferBase):
(WebCore::GraphicsContextGLOpenGL::blitFramebuffer):
(WebCore::GraphicsContextGLOpenGL::framebufferTextureLayer):
(WebCore::GraphicsContextGLOpenGL::invalidateFramebuffer):
(WebCore::GraphicsContextGLOpenGL::invalidateSubFramebuffer):
(WebCore::GraphicsContextGLOpenGL::readBuffer):
(WebCore::GraphicsContextGLOpenGL::copyTexSubImage3D):
(WebCore::GraphicsContextGLOpenGL::getFragDataLocation):
(WebCore::GraphicsContextGLOpenGL::uniform1ui):
(WebCore::GraphicsContextGLOpenGL::uniform2ui):
(WebCore::GraphicsContextGLOpenGL::uniform3ui):
(WebCore::GraphicsContextGLOpenGL::uniform4ui):
(WebCore::GraphicsContextGLOpenGL::uniform1uiv):
(WebCore::GraphicsContextGLOpenGL::uniform2uiv):
(WebCore::GraphicsContextGLOpenGL::uniform3uiv):
(WebCore::GraphicsContextGLOpenGL::uniform4uiv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2x3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3x2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2x4fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4x2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3x4fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4x3fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4i):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4iv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4ui):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4uiv):
(WebCore::GraphicsContextGLOpenGL::drawRangeElements):
(WebCore::GraphicsContextGLOpenGL::drawBuffers):
(WebCore::GraphicsContextGLOpenGL::clearBufferiv):
(WebCore::GraphicsContextGLOpenGL::clearBufferuiv):
(WebCore::GraphicsContextGLOpenGL::clearBufferfv):
(WebCore::GraphicsContextGLOpenGL::clearBufferfi):
(WebCore::GraphicsContextGLOpenGL::deleteQuery):
(WebCore::GraphicsContextGLOpenGL::isQuery):
(WebCore::GraphicsContextGLOpenGL::getQuery):
(WebCore::GraphicsContextGLOpenGL::createSampler):
(WebCore::GraphicsContextGLOpenGL::deleteSampler):
(WebCore::GraphicsContextGLOpenGL::isSampler):
(WebCore::GraphicsContextGLOpenGL::bindSampler):
(WebCore::GraphicsContextGLOpenGL::samplerParameteri):
(WebCore::GraphicsContextGLOpenGL::samplerParameterf):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameterfv):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameteriv):
(WebCore::GraphicsContextGLOpenGL::fenceSync):
(WebCore::GraphicsContextGLOpenGL::isSync):
(WebCore::GraphicsContextGLOpenGL::deleteSync):
(WebCore::GraphicsContextGLOpenGL::clientWaitSync):
(WebCore::GraphicsContextGLOpenGL::waitSync):
(WebCore::GraphicsContextGLOpenGL::getSynciv):
(WebCore::GraphicsContextGLOpenGL::pauseTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::resumeTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindBufferRange):
(WebCore::GraphicsContextGLOpenGL::getUniformIndices):

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::updateCGLContext):

• platform/graphics/opengl/ExtensionsGLOpenGL.cpp:

(WebCore::ExtensionsGLOpenGL::blitFramebuffer):
(WebCore::ExtensionsGLOpenGL::renderbufferStorageMultisample):
(WebCore::ExtensionsGLOpenGL::createVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::deleteVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::isVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::bindVertexArrayOES):
(WebCore::ExtensionsGLOpenGL::supportsExtension):
(WebCore::ExtensionsGLOpenGL::drawBuffersEXT):
(WebCore::ExtensionsGLOpenGL::drawArraysInstanced):
(WebCore::ExtensionsGLOpenGL::drawElementsInstanced):
(WebCore::ExtensionsGLOpenGL::vertexAttribDivisor):

• platform/graphics/opengl/ExtensionsGLOpenGLES.cpp:

(WebCore::ExtensionsGLOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::ExtensionsGLOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::ExtensionsGLOpenGLES::renderbufferStorageMultisample):
(WebCore::ExtensionsGLOpenGLES::createVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::deleteVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::isVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::bindVertexArrayOES):
(WebCore::ExtensionsGLOpenGLES::getGraphicsResetStatusARB):
(WebCore::ExtensionsGLOpenGLES::readnPixelsEXT):
(WebCore::ExtensionsGLOpenGLES::getnUniformfvEXT):
(WebCore::ExtensionsGLOpenGLES::getnUniformivEXT):
(WebCore::ExtensionsGLOpenGLES::drawArraysInstanced):
(WebCore::ExtensionsGLOpenGLES::drawElementsInstanced):
(WebCore::ExtensionsGLOpenGLES::vertexAttribDivisor):

• platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

(WebCore::GraphicsContextGLOpenGL::renderbufferStorage):
(WebCore::GraphicsContextGLOpenGL::getIntegerv):
(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):
(WebCore::GraphicsContextGLOpenGL::depthRange):
(WebCore::GraphicsContextGLOpenGL::clearDepth):
(WebCore::GraphicsContextGLOpenGL::readPixels):

• platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::prepareTexture):
(WebCore::GraphicsContextGLOpenGL::readRenderingResults):
(WebCore::GraphicsContextGLOpenGL::reshape):
(WebCore::GraphicsContextGLOpenGL::activeTexture):
(WebCore::GraphicsContextGLOpenGL::attachShader):
(WebCore::GraphicsContextGLOpenGL::bindAttribLocation):
(WebCore::GraphicsContextGLOpenGL::bindBuffer):
(WebCore::GraphicsContextGLOpenGL::bindFramebuffer):
(WebCore::GraphicsContextGLOpenGL::bindRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::bindTexture):
(WebCore::GraphicsContextGLOpenGL::blendColor):
(WebCore::GraphicsContextGLOpenGL::blendEquation):
(WebCore::GraphicsContextGLOpenGL::blendEquationSeparate):
(WebCore::GraphicsContextGLOpenGL::blendFunc):
(WebCore::GraphicsContextGLOpenGL::blendFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::bufferData):
(WebCore::GraphicsContextGLOpenGL::bufferSubData):
(WebCore::GraphicsContextGLOpenGL::checkFramebufferStatus):
(WebCore::GraphicsContextGLOpenGL::clearColor):
(WebCore::GraphicsContextGLOpenGL::clear):
(WebCore::GraphicsContextGLOpenGL::clearStencil):
(WebCore::GraphicsContextGLOpenGL::colorMask):
(WebCore::GraphicsContextGLOpenGL::compileShader):
(WebCore::GraphicsContextGLOpenGL::compileShaderDirect):
(WebCore::GraphicsContextGLOpenGL::copyTexImage2D):
(WebCore::GraphicsContextGLOpenGL::copyTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::cullFace):
(WebCore::GraphicsContextGLOpenGL::depthFunc):
(WebCore::GraphicsContextGLOpenGL::depthMask):
(WebCore::GraphicsContextGLOpenGL::detachShader):
(WebCore::GraphicsContextGLOpenGL::disable):
(WebCore::GraphicsContextGLOpenGL::disableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::drawArrays):
(WebCore::GraphicsContextGLOpenGL::drawElements):
(WebCore::GraphicsContextGLOpenGL::enable):
(WebCore::GraphicsContextGLOpenGL::enableVertexAttribArray):
(WebCore::GraphicsContextGLOpenGL::finish):
(WebCore::GraphicsContextGLOpenGL::flush):
(WebCore::GraphicsContextGLOpenGL::framebufferRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::framebufferTexture2D):
(WebCore::GraphicsContextGLOpenGL::frontFace):
(WebCore::GraphicsContextGLOpenGL::generateMipmap):
(WebCore::GraphicsContextGLOpenGL::getActiveAttribImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformImpl):
(WebCore::GraphicsContextGLOpenGL::getAttachedShaders):
(WebCore::GraphicsContextGLOpenGL::getAttribLocation):
(WebCore::GraphicsContextGLOpenGL::getAttribLocationDirect):
(WebCore::GraphicsContextGLOpenGL::moveErrorsToSyntheticErrorList):
(WebCore::GraphicsContextGLOpenGL::getError):
(WebCore::GraphicsContextGLOpenGL::getString):
(WebCore::GraphicsContextGLOpenGL::hint):
(WebCore::GraphicsContextGLOpenGL::isBuffer):
(WebCore::GraphicsContextGLOpenGL::isEnabled):
(WebCore::GraphicsContextGLOpenGL::isFramebuffer):
(WebCore::GraphicsContextGLOpenGL::isProgram):
(WebCore::GraphicsContextGLOpenGL::isRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::isShader):
(WebCore::GraphicsContextGLOpenGL::isTexture):
(WebCore::GraphicsContextGLOpenGL::lineWidth):
(WebCore::GraphicsContextGLOpenGL::linkProgram):
(WebCore::GraphicsContextGLOpenGL::pixelStorei):
(WebCore::GraphicsContextGLOpenGL::polygonOffset):
(WebCore::GraphicsContextGLOpenGL::sampleCoverage):
(WebCore::GraphicsContextGLOpenGL::scissor):
(WebCore::GraphicsContextGLOpenGL::shaderSource):
(WebCore::GraphicsContextGLOpenGL::stencilFunc):
(WebCore::GraphicsContextGLOpenGL::stencilFuncSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilMask):
(WebCore::GraphicsContextGLOpenGL::stencilMaskSeparate):
(WebCore::GraphicsContextGLOpenGL::stencilOp):
(WebCore::GraphicsContextGLOpenGL::stencilOpSeparate):
(WebCore::GraphicsContextGLOpenGL::texParameterf):
(WebCore::GraphicsContextGLOpenGL::texParameteri):
(WebCore::GraphicsContextGLOpenGL::uniform1f):
(WebCore::GraphicsContextGLOpenGL::uniform1fv):
(WebCore::GraphicsContextGLOpenGL::uniform2f):
(WebCore::GraphicsContextGLOpenGL::uniform2fv):
(WebCore::GraphicsContextGLOpenGL::uniform3f):
(WebCore::GraphicsContextGLOpenGL::uniform3fv):
(WebCore::GraphicsContextGLOpenGL::uniform4f):
(WebCore::GraphicsContextGLOpenGL::uniform4fv):
(WebCore::GraphicsContextGLOpenGL::uniform1i):
(WebCore::GraphicsContextGLOpenGL::uniform1iv):
(WebCore::GraphicsContextGLOpenGL::uniform2i):
(WebCore::GraphicsContextGLOpenGL::uniform2iv):
(WebCore::GraphicsContextGLOpenGL::uniform3i):
(WebCore::GraphicsContextGLOpenGL::uniform3iv):
(WebCore::GraphicsContextGLOpenGL::uniform4i):
(WebCore::GraphicsContextGLOpenGL::uniform4iv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4fv):
(WebCore::GraphicsContextGLOpenGL::useProgram):
(WebCore::GraphicsContextGLOpenGL::validateProgram):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib1fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib2fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib3fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4f):
(WebCore::GraphicsContextGLOpenGL::vertexAttrib4fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribPointer):
(WebCore::GraphicsContextGLOpenGL::viewport):
(WebCore::GraphicsContextGLOpenGL::createVertexArray):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::bindVertexArray):
(WebCore::GraphicsContextGLOpenGL::getBooleanv):
(WebCore::GraphicsContextGLOpenGL::getBufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getFloatv):
(WebCore::GraphicsContextGLOpenGL::getIntegeri_v):
(WebCore::GraphicsContextGLOpenGL::getInteger64v):
(WebCore::GraphicsContextGLOpenGL::getInteger64i_v):
(WebCore::GraphicsContextGLOpenGL::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContextGLOpenGL::getProgramiv):
(WebCore::GraphicsContextGLOpenGL::getNonBuiltInActiveSymbolCount):
(WebCore::GraphicsContextGLOpenGL::getProgramInfoLog):
(WebCore::GraphicsContextGLOpenGL::getRenderbufferParameteriv):
(WebCore::GraphicsContextGLOpenGL::getShaderiv):
(WebCore::GraphicsContextGLOpenGL::getShaderInfoLog):
(WebCore::GraphicsContextGLOpenGL::getShaderSource):
(WebCore::GraphicsContextGLOpenGL::getTexParameterfv):
(WebCore::GraphicsContextGLOpenGL::getTexParameteriv):
(WebCore::GraphicsContextGLOpenGL::getUniformfv):
(WebCore::GraphicsContextGLOpenGL::getUniformiv):
(WebCore::GraphicsContextGLOpenGL::getUniformLocation):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribfv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribiv):
(WebCore::GraphicsContextGLOpenGL::getVertexAttribOffset):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::createBuffer):
(WebCore::GraphicsContextGLOpenGL::createFramebuffer):
(WebCore::GraphicsContextGLOpenGL::createProgram):
(WebCore::GraphicsContextGLOpenGL::createRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::createShader):
(WebCore::GraphicsContextGLOpenGL::createTexture):
(WebCore::GraphicsContextGLOpenGL::deleteBuffer):
(WebCore::GraphicsContextGLOpenGL::deleteFramebuffer):
(WebCore::GraphicsContextGLOpenGL::deleteProgram):
(WebCore::GraphicsContextGLOpenGL::deleteRenderbuffer):
(WebCore::GraphicsContextGLOpenGL::deleteShader):
(WebCore::GraphicsContextGLOpenGL::deleteTexture):
(WebCore::GraphicsContextGLOpenGL::texImage2DDirect):
(WebCore::GraphicsContextGLOpenGL::primitiveRestartIndex):
(WebCore::GraphicsContextGLOpenGL::copyBufferSubData):
(WebCore::GraphicsContextGLOpenGL::mapBufferRange):
(WebCore::GraphicsContextGLOpenGL::unmapBuffer):
(WebCore::GraphicsContextGLOpenGL::getInternalformativ):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorageMultisample):
(WebCore::GraphicsContextGLOpenGL::texStorage2D):
(WebCore::GraphicsContextGLOpenGL::texStorage3D):
(WebCore::GraphicsContextGLOpenGL::getActiveUniforms):

• platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:

(WebCore::GraphicsContextGLOpenGL::readPixels):
(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorage):
(WebCore::GraphicsContextGLOpenGL::getIntegerv):
(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):
(WebCore::GraphicsContextGLOpenGL::depthRange):
(WebCore::GraphicsContextGLOpenGL::clearDepth):
(WebCore::GraphicsContextGLOpenGL::create):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):

• platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):

1:31 AM Changeset in webkit [269767] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add Kimmo Kinnunen as committer
​https://bugs.webkit.org/show_bug.cgi?id=218888

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-11-13
Reviewed by Antti Koivisto.

• Scripts/webkitpy/common/config/contributors.json:

12:36 AM Changeset in webkit [269766] by commit-queue@webkit.org

• 18 edits in trunk/JSTests

WebAssembly: update wabt.js
​https://bugs.webkit.org/show_bug.cgi?id=218876

Patch by Sergey Rubanov <Sergey Rubanov> on 2020-11-13
Reviewed by Yusuke Suzuki.

• wasm/libwabt.js:

(WabtModule): Deleted.

• wasm/regress/llint-callee-saves-with-fast-memory.js:

(async test):

• wasm/regress/llint-callee-saves-without-fast-memory.js:

(async test):

• wasm/regress/regression-with-loop.js:

(async test):

• wasm/regress/stack-consistency.js:

(async test):

• wasm/stress/js-wasm-call-many-return-types-on-stack-no-args.js:

(async buildWat):
(async test):
(buildWat): Deleted.

• wasm/stress/js-wasm-js-varying-arities.js:

(async paramForwarder):
(async test):
(paramForwarder): Deleted.

• wasm/stress/local-ref.js:

(async test):

• wasm/stress/loop-more-args-than-results.js:

(async test):

• wasm/stress/set-local-enclosed-stack.js:

(async test):
(assert.eq.instance.exports.foo): Deleted.
(assert.eq): Deleted.

• wasm/stress/top-most-enclosing-stack.js:

(async test):

• wasm/stress/trunc-int-min-minus-one.js:

(async test):

• wasm/stress/wasm-js-call-many-return-types-on-stack-no-args.js:

(async buildWat):
(async test):
(buildWat): Deleted.

• wasm/stress/wasm-js-multi-value-exception-in-iterator.js:

(async buildWat):
(async test):
(buildWat.throwError): Deleted.
(buildWat.throwErrorInIterator): Deleted.
(buildWat.tooManyValues): Deleted.
(buildWat.tooFewValues): Deleted.
(buildWat): Deleted.

• wasm/stress/wasm-wasm-call-indirect-many-return-types-on-stack.js:

(async buildWat):
(async test):
(buildWat): Deleted.

• wasm/stress/wasm-wasm-call-many-return-types-on-stack-no-args.js:

(async buildWat):
(async test):
(buildWat): Deleted.

• wasm/wabt-wrapper.js:

(export.async compile):
(export.compile): Deleted.

12:22 AM Changeset in webkit [269765] by magomez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK][WPE] FilterInfo must cleared when reusing BitmapTextureGL
​https://bugs.webkit.org/show_bug.cgi?id=218854

Reviewed by Carlos Garcia Campos.

Clear the FilterInfo attribute when reusing a BitmapTextureGL.

• platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::didReset):