Context Navigation

← Previous Period
Next Period →

Timeline

Nov 16, 2020:

9:23 PM Changeset in webkit [269893] by commit-queue@webkit.org

4 edits
1 add in trunk/Source/WebCore

Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
https://bugs.webkit.org/show_bug.cgi?id=218637
<rdar://problem/71102126>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-11-16
Reviewed by Eric Carlson.

Patch by Jer Noble.

Treat internal compressed YUV pixel formats
kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange and
kCVPixelFormatType_AGX_420YpCbCr8BiPlanarFullRange as
kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange and
kCVPixelFormatType_420YpCbCr8BiPlanarFullRange when
using the OpenGL shader to convert video IOSurface to a WebGL
texture.

Fixes cases where the decoder outputs the compressed formats.

No new tests, adding more comprehensive test content suite is tracked
in another bug.

Source/WebCore:

platform/graphics/cv/GraphicsContextGLCVANGLE.cpp:

(WebCore::pixelRangeFromPixelFormat):
(WebCore::GraphicsContextGLCVANGLE::copyPixelBufferToTexture):

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/cf/CoreVideoSPI.h: Added.

8:33 PM Changeset in webkit [269892] by Dewei Zhu

3 edits in trunk/Websites/perf.webkit.org

BuildbotTriggerable should not process a completed build request from a completed test group.
https://bugs.webkit.org/show_bug.cgi?id=219016

Reviewed by Ryosuke Niwa.

BuildBotTriggerable._pullBuildbotOnAllSyncers relies on buildReqeustsByGroup to contain all build requests found by
BuildRequest.findById. However, since re-use root change is landed, above assumption is no longer valid. BuildRequest.all()
may includes build requests under same analysis task. Thus, _pullBuildbotOnAllSyncers will fail due to 'info' is undefined.

server-tests/tools-buildbot-triggerable-tests.js: Added a unit test.
tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers): Added logic to stop processing the build request if it's not
from incomplete build requests under a triggerable.

7:15 PM Changeset in webkit [269891] by Jonathan Bedard

4 edits
1 copy in trunk/Tools

[webkitscmpy] Generalize parts of local.Scm class
https://bugs.webkit.org/show_bug.cgi?id=218935
<rdar://problem/71395688>

Rubber-stamped by Aakash Jain.

Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm):
(Scm.Exception): Moved to ScmBase.
(Scm.init): Move branches logic to ScmBase.
(Scm.is_svn): Moved to ScmBase.
(Scm.is_git): Ditto.
(Scm.default_branch): Ditto.
(Scm.branches): Ditto.
(Scm.tags): Ditto.
(Scm.find): Ditto.
(Scm.commit): Ditto.
(Scm.prioritize_branches): Ditto.
(Scm.log): Ditto.

Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn.commit): Passing branch to self.info is redundant.

Scripts/libraries/webkitscmpy/webkitscmpy/mocks/init.py:
Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py: Added.

(ScmBase): Base class for all local and remote Scm objects.
(ScmBase.Exception): Moved from local.Scm.
(ScmBase.init): Ditto.
(ScmBase.is_svn): Ditto.
(ScmBase.is_git): Ditto.
(ScmBase.default_branch): Ditto.
(ScmBase.branches): Ditto.
(ScmBase.tags): Ditto.
(ScmBase.commit): Ditto.
(ScmBase.prioritize_branches): Ditto.
(ScmBase.find): Ditto.
(ScmBase.log): Ditto.

Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

7:05 PM Changeset in webkit [269890] by Brent Fulgham

3 edits in trunk/Source/WebKit

[macOS] Remove access to the unused AppleIntelMEUserClient IOKit class
https://bugs.webkit.org/show_bug.cgi?id=219012
<rdar://problem/70462796>

Reviewed by Eric Carlson.

Although we originally thought this was needed for H.264 decoding, testing shows that
this class is never used in WebKit flows, and is not needed. We should remove it.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

6:39 PM Changeset in webkit [269889] by pvollan@apple.com

3 edits in trunk/Source/WebKit

[macOS] Create sandbox extension for the power log service on internal installs
https://bugs.webkit.org/show_bug.cgi?id=218984
<rdar://problem/58488936>

Reviewed by Brent Fulgham.

Create a sandbox extension for the WebContent process for the power log service on macOS internal installs.

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::diagnosticServices):

WebProcess/com.apple.WebProcess.sb.in:

5:34 PM Changeset in webkit [269888] by weinig@apple.com

116 edits
1 copy
1 move
12 adds in trunk

Source/WebCore:
Standardize enums that are used by Settings in preperation for autogeneration
https://bugs.webkit.org/show_bug.cgi?id=218960

Reviewed by Tim Horton.

Move each enum type used by Settings to its own header and make them all scoped
enums in preparation for using them in the generated settings code.

Also converted enums used in Settings that are used as flags to use OptionSet,
adding the necessary EnumTraits to make it to work. In the change, Settings still
generates with getters/setters that work on the raw enum, but in subsequent changes
the generation will work directly with OptionSets.

Headers.cmake:
WebCore.xcodeproj/project.pbxproj:

Add new headers, adjust for renames.

Scripts/GenerateSettings.rb:

Add special case for HTML prefix to keep renamed HTMLParserScriptingFlagPolicy
setting using WebCore consistent capitalization.

accessibility/ForcedAccessibilityValue.h: Added.
css/FontLoadTimingOverride.h: Added.
editing/EditableLinkBehavior.h: Added.
editing/cocoa/DataDetectorTypes.h: Added.
html/parser/HTMLParserScriptingFlagPolicy.h: Added.
page/FrameFlattening.h: Added.
page/PDFImageCachingPolicy.h: Added.
page/DebugOverlayRegions.h: Added.
page/StorageBlockingPolicy.h: Added.
page/TextDirectionSubmenuInclusionBehavior.h: Added.
page/UserInterfaceDirectionPolicy.h: Added.
platform/text/FontRenderingMode.h: Added.
platform/text/TextDirection.h: Added.

Add new headers.

editing/EditingBehaviorType.h: Added.
editing/EditingBehaviorTypes.h: Removed.

Renamed header to match enum name.

css/CSSFontFace.cpp:

(WebCore::fontLoadTimingOverride):
(WebCore::CSSFontFace::fontLoadTiming const):
Update uses of FontLoadTimingOverride to remove Settings scoping.

css/MediaQueryEvaluator.cpp:

(WebCore::monochromeEvaluate):
(WebCore::invertedColorsEvaluate):
(WebCore::dynamicRangeEvaluate):
(WebCore::prefersReducedMotionEvaluate):
Update uses of ForcedAccessibilityValue to remove Settings scoping.

dom/Document.cpp:

(WebCore::Document::applyQuickLookSandbox):
Update uses of StorageBlockingPolicy to remove SecurityOrigin scoping.

editing/EditingBehavior.h:

Update use of EditingBehaviorType to use scoped syntax.

editing/Editor.cpp:

(WebCore::Editor::behavior const):
Remove unnecessary duplication of EditingBehavior construction.

editing/cocoa/DataDetection.h:
editing/cocoa/DataDetection.mm:

Switch to using OptionSet<DataDetectorTypes> rather than raw DataDetectorTypes.

editing/markup.cpp:

(WebCore::createPageForSanitizingWebContent):
Update for renamed setter now called setHTMLParserScriptingFlagPolicy to make it clear
it is about the HTML parser.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setActive):
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType const):
Update use of EditableLinkBehavior to use scoped syntax.

html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):
Update for renamed setting now called HTMLParserScriptingFlagPolicy to make it clear
it is about the HTML parser and no longer scoped to Settings.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Switch to using OptionSet<DataDetectorTypes> rather than raw DataDetectorTypes.

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):
Update use of TextDirectionSubmenuInclusionBehavior to use scoped syntax.

page/DebugPageOverlays.cpp:

(WebCore::DebugPageOverlays::updateOverlayRegionVisibility):
(WebCore::DebugPageOverlays::settingsChanged):

page/DebugPageOverlays.h:

Switch to using OptionSet<DebugOverlayRegions> rather than raw DebugOverlayRegions.

page/EventHandler.cpp:

(WebCore::EventHandler::useHandCursor):
Update use of EditableLinkBehavior to use scoped syntax.

page/FrameView.h:

Switch to #including FrameFlattening.h since it is such a trivial include now.

page/Page.cpp:

(WebCore::Page::shouldBuildEditableRegion const):
Switch to using OptionSet<DebugOverlayRegions> rather than raw DebugOverlayRegions.

page/SecurityOrigin.cpp:
page/SecurityOrigin.h:

Update to now include StorageBlockingPolicy.h and switch to use scoped syntax.

page/Settings.yaml:

Update setting defaults to use new scoped names where appropriate and rename
ParserScriptingFlagPolicy to HTMLParserScriptingFlagPolicy to make it clear which
parser it is for.

page/SettingsBase.h:

Replace enum definitions with #includes for the new headers. In future changes,
these will be automatically included in the generated code and this won't be necessary
anymore.

platform/DragImage.h:
platform/graphics/FontDescription.h:

Update #includes to keep things building.

platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):

platform/graphics/cg/PDFDocumentImage.h:

Update use of PDFImageCachingPolicy to use scoped syntax.

platform/text/TextFlags.h:

Extract FontRenderingMode into its own header.

platform/text/WritingMode.h:

Extract TextDirection into its own header. Also replace some macros with constexprs while
I was here.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintDebugOverlays):
(WebCore::RenderLayerBacking::paintContents):
Switch to using OptionSet<DebugOverlayRegions> rather than raw DebugOverlayRegions.

testing/InternalSettings.cpp:
testing/InternalSettings.h:
testing/InternalSettings.idl:

Use new enums rather than redeclaring them. Updates EditingBehaviorType to use the
value "windows" rather than "win" which requires test changes as does changes to
capitalization of PDFImageCachingPolicy enum values.

workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::createPageForServiceWorker):
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):

workers/service/context/ServiceWorkerThreadProxy.h:

Update for extracted StorageBlockingPolicy enum.

Source/WebKit:
Standardize enums that are used by Settings in preperation for autogeneration
https://bugs.webkit.org/show_bug.cgi?id=218960

Reviewed by Tim Horton.

Update enum uses for renames and scoped syntax use.

UIProcess/API/C/WKAPICast.h:

(WebKit::toAPI):
(WebKit::toEditableLinkBehavior):
(WebKit::toStorageBlockingPolicy):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesSetStorageBlockingPolicy):
(WKPreferencesGetStorageBlockingPolicy):

UIProcess/API/Cocoa/WKPreferences.mm:

(toStorageBlockingPolicy):
(toAPI):
(-[WKPreferences _storageBlockingPolicy]):
(-[WKPreferences _setStorageBlockingPolicy:]):
(toEditableLinkBehavior):
(-[WKPreferences _setEditableLinkBehavior:]):

UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::createWithLegacyDefaults):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::updatePreferencesStore):

WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::detectDataInAllFrames):

Source/WebKitLegacy/mac:
Standardize enums that are used by Settings in preperation for autogeneration
https://bugs.webkit.org/show_bug.cgi?id=218960

Reviewed by Tim Horton.

Update enum uses for renames and scoped syntax use.

WebView/WebFrame.mm:
WebView/WebView.mm:

Source/WTF:
Standardize enums that are used by Settings in preperation for autogeneration
https://bugs.webkit.org/show_bug.cgi?id=218960

Reviewed by Tim Horton.

Update enum uses in default WebPreferences values for renames and scoped syntax use.

Scripts/Preferences/WebPreferences.yaml:

LayoutTests:
Standardize enums that are used by Settings in preparation for autogeneration
https://bugs.webkit.org/show_bug.cgi?id=218960

Reviewed by Tim Horton.

Update tests and results for change in EditingBahavior enum value "win" -> "windows".

editing/deleting/delete-ligature-003-expected.txt:
editing/deleting/delete-ligature-003.html:
editing/deleting/paragraph-in-preserveNewline-expected.txt:
editing/deleting/paragraph-in-preserveNewline.html:
editing/deleting/smart-editing-disabled-win.html:
editing/deleting/whitespace-pre-1-expected.txt:
editing/deleting/whitespace-pre-1.html:
editing/execCommand/query-command-state-expected.txt:
editing/execCommand/query-command-state.html:
editing/execCommand/query-text-alignment-expected.txt:
editing/execCommand/query-text-alignment.html:
editing/execCommand/remove-format-multiple-elements-win.html:
editing/execCommand/toggle-compound-styles-expected.txt:
editing/execCommand/toggle-compound-styles.html:
editing/execCommand/toggle-link-win.html:
editing/execCommand/toggle-unlink-win.html:
editing/selection/5195166-1.html:
editing/selection/5354455-1.html:
editing/selection/click-in-margins-inside-editable-div.html:
editing/selection/click-in-padding-with-multiple-line-boxes.html:
editing/selection/context-menu-text-selection-lookup.html:
editing/selection/context-menu-text-selection.html:
editing/selection/extend-after-mouse-selection.html:
editing/selection/extend-selection-after-double-click.html:
editing/selection/extend-selection-enclosing-block-win.html:
editing/selection/move-by-word-visually-crash-test-1.html:
editing/selection/move-by-word-visually-crash-test-2.html:
editing/selection/move-by-word-visually-crash-test-3.html:
editing/selection/move-by-word-visually-crash-test-4.html:
editing/selection/move-by-word-visually-crash-test-5.html:
editing/selection/move-by-word-visually-crash-test-css-generated-content.html:
editing/selection/move-by-word-visually-crash-test-textarea.html:
editing/selection/move-by-word-visually-inline-block-positioned-element.html:
editing/selection/move-by-word-visually-multi-line.html:
editing/selection/move-by-word-visually-multi-space.html:
editing/selection/move-by-word-visually-null-box.html:
editing/selection/move-by-word-visually-single-space-inline-element.html:
editing/selection/move-by-word-visually-single-space-one-element.html:
editing/selection/move-by-word-visually-textarea.html:
editing/selection/move-by-word-visually-wrong-left-right.html:
editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
editing/selection/programmatic-selection-on-mac-is-directionless.html:
editing/selection/rtl-move-selection-right-left.html:
editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
editing/selection/shift-click.html:
editing/selection/user-select-all-with-shift-expected.txt:
editing/selection/user-select-all-with-shift.html:
editing/spelling/copy-paste-crash.html:
editing/style/iframe-onload-crash-win.html:
editing/style/make-text-writing-direction-inline-win.html:
editing/style/push-down-font-styles-win.html:
editing/style/push-down-implicit-styles-around-list-win.html:
editing/style/toggle-style-bold-italic-expected.txt:
editing/style/toggle-style-bold-italic-mixed-editability-expected.txt:
editing/style/toggle-style-bold-italic-mixed-editability.html:
editing/style/toggle-style-bold-italic.html:
fast/events/backspace-navigates-back.html:
fast/forms/selection-direction-expected.txt:
fast/forms/selection-direction.html:

5:09 PM Changeset in webkit [269887] by lingho@apple.com

3 edits in trunk/Tools

Updated contributors.json to remove inactive committers and reviewers.
Removed irc user "Adam Barth" from IRCCommand in webkitpy unittest.
https://bugs.webkit.org/show_bug.cgi?id=219006

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois):

4:00 PM Changeset in webkit [269886] by wilander@apple.com

28 edits in trunk

PCM: Change attribute and JSON key names according to the W3C conversation
https://bugs.webkit.org/show_bug.cgi?id=218967

Reviewed by Brent Fulgham.

We've discussed extensively with Google and others on naming for the link
attributes and JSON key names in these issues:
https://github.com/privacycg/private-click-measurement/issues/30
https://github.com/privacycg/private-click-measurement/issues/56

This patch changes PCM accordingly.

Source/WebCore:

No new tests. Exiting tests updated.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parsePrivateClickMeasurement const):

html/HTMLAnchorElement.idl:
html/HTMLAttributeNames.in:
loader/PrivateClickMeasurement.cpp:

(WebCore::PrivateClickMeasurement::json const):

Tools:

TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

http/tests/contentextensions/block-private-click-measurement.html:
http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt:
http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:
http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html:
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html:
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html:
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority.html:
http/tests/privateClickMeasurement/clear-through-website-data-removal.html:
http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session.html:
http/tests/privateClickMeasurement/expired-attributions-removed.html:
http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority.html:
http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority.html:
http/tests/privateClickMeasurement/second-conversion-with-higher-priority.html:
http/tests/privateClickMeasurement/second-conversion-with-lower-priority.html:
http/tests/privateClickMeasurement/send-attribution-conversion-request-expected.txt:
http/tests/privateClickMeasurement/send-attribution-conversion-request.html:
http/tests/privateClickMeasurement/store-disabled-in-ephemeral-session.html:
http/tests/privateClickMeasurement/store-private-click-measurement.html:

3:51 PM Changeset in webkit [269885] by wilander@apple.com

2 edits in trunk/Source/WebKit

NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds
https://bugs.webkit.org/show_bug.cgi?id=218997
<rdar://problem/71460604>

Unreviewed minor change to logging.

NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the
cookie name in log output on customer builds. This patch changes the format
specifier from %s to %{public}s.

Note that this logging is just for ITP Debug Mode which is off by default, logs
in-memory only, and is disabled again on browser quit.

No new tests. This just changes log output on customer builds.

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):

3:49 PM Changeset in webkit [269884] by Russell Epstein

8 edits in branches/safari-611.1.6-branch/Source

Versioning.

WebKit-7611.1.6

3:45 PM Changeset in webkit [269883] by Russell Epstein

1 copy in branches/safari-611.1.6-branch

New branch.

3:38 PM Changeset in webkit [269882] by Russell Epstein

8 edits in trunk/Source

Versioning.

WebKit-7611.1.7

3:12 PM Changeset in webkit [269881] by Alan Coon

5 edits in branches/safari-610.3.7.0-branch/Source

Revert r268979. rdar://problem/71446619

2:40 PM Changeset in webkit [269880] by graouts@webkit.org

15 edits
6 adds in trunk

Add an experimental <model> element
https://bugs.webkit.org/show_bug.cgi?id=218991

Reviewed by Dean Jackson.

Source/WebCore:

Test: system-preview/model/model-element.html

Add the basis for a new <model> element.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
html/HTMLModelElement.cpp: Added.

(WebCore::HTMLModelElement::HTMLModelElement):
(WebCore::HTMLModelElement::~HTMLModelElement):
(WebCore::HTMLModelElement::create):

html/HTMLModelElement.h: Added.
html/HTMLModelElement.idl: Added.
html/HTMLTagNames.in:

Source/WTF:

Add a new build ENABLE(MODEL_ELEMENT) flag, enabled only on Cocoa platforms, and a new experimental feature
backed by a setting, currently disabled on all platforms except engineering builds and Safari Technology Preview.

Scripts/Preferences/WebPreferencesExperimental.yaml:
wtf/PlatformEnableCocoa.h:

LayoutTests:

Add a new system-preview/model subdirectory for <model> tests, which we run on macOS and iOS.

platform/mac/TestExpectations:
system-preview/model/model-element-expected.txt: Added.
system-preview/model/model-element.html: Added.

2:17 PM Changeset in webkit [269879] by Chris Dumez

3 edits in trunk/Source/WebKit

[GPUProcess] Update GPUProcess process assertion based on active WebProcesses
https://bugs.webkit.org/show_bug.cgi?id=219002

Reviewed by Simon Fraser.

Update GPUProcess process assertion based on active WebProcesses, similarly to what
we do for the network process. Previously, we would never release the GPUProcess
process assertion and it would time out after 30 seconds in the background.

UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::updateProcessAssertion):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::updateProcessAssertions):

2:14 PM Changeset in webkit [269878] by Truitt Savell

2 edits in trunk/LayoutTests

Modify expectations for webgpu/whlsl/dont-crash-parsing-enum.html
https://bugs.webkit.org/show_bug.cgi?id=215247

unreviewed test gardening.

platform/mac/TestExpectations:

2:07 PM Changeset in webkit [269877] by Brent Fulgham

4 edits in trunk/Source/WebKit

[macOS] Remove remote tcp capability from WebContent Sandbox
https://bugs.webkit.org/show_bug.cgi?id=218999
<rdar://problem/70355789>

Reviewed by Per Arne Vollan.

Since we have moved all network activity (aside from some syslog use) out of the WebContent
process, we do not need the ability to open remote tcp connections. We should deny this
capability from our non-Network sandboxes.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

1:58 PM Changeset in webkit [269876] by Alan Coon

5 edits in branches/safari-610.3.7.1-branch/Source

Revert r268979. rdar://problem/71446624

1:45 PM Changeset in webkit [269875] by commit-queue@webkit.org

8 edits in trunk

FileReaderLoader::convertToDataURL should use application/octet-stream if MIME type is empty
https://bugs.webkit.org/show_bug.cgi?id=218993

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-16
Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL-expected.txt:

Source/WebCore:

This matches Chrome and Firefox, and is covered by a web platform test.

fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::convertToDataURL):

LayoutTests:

fast/files/read-blob-async-expected.txt:
fast/files/workers/worker-read-blob-async-expected.txt:
fast/files/workers/worker-read-blob-sync-expected.txt:

1:27 PM Changeset in webkit [269874] by Matt Lewis

4 edits in trunk/Tools

Bring up Big Sur Builders and Testers
https://bugs.webkit.org/show_bug.cgi?id=218917

Reviewed by Aakash Jain.

CISupport/build-webkit-org/config.json:
CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

1:21 PM Changeset in webkit [269873] by Megan Gardner

2 edits in trunk/Source/WebCore

Speculative fix for localizableStrings.string in WebCore
https://bugs.webkit.org/show_bug.cgi?id=219003

Unreviewed build fix.

WebCore.xcodeproj/project.pbxproj:

1:17 PM Changeset in webkit [269872] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed test gardening, land expectations for rdar://71039166.

platform/mac/TestExpectations:

12:32 PM Changeset in webkit [269871] by Dewei Zhu

12 edits in trunk/Websites/perf.webkit.org

Performance dashboard should avoid building same configuration under one analysis task.
https://bugs.webkit.org/show_bug.cgi?id=218413

Reviewed by Ryosuke Niwa.

Add logic in syncing script to reuse already built roots from same build request under current analysis task.
If there is another same build request scheduled/running, will defer scheduling current build request.

public/admin/platforms.php: Fixed newer version of PHP warns on accessing invalid key in an array.
public/admin/tests.php: Added a null check against $selected_parent.
public/api/build-requests.php: Extended this API to allow reusing roots from existing build request.
public/v3/models/build-request.js:

(BuildRequest.prototype.async findBuildRequestWithSameRoots): Find build type build request with same commit set
which can/will be reused under current analysis task.

public/v3/models/commit-set.js:

(CommitSet.prototype.equalsIgnoringRoot): Added a helper function which checks commit set equality ignoring the root.
(CommitSet.prototype.equals): Use '_equalsOptionallyIgnoringRoot' as underlying implementation.
(CommitSet.prototype._equalsOptionallyIgnoringRoot): Implementation for both equals and equalsIngnoringRoot.

server-tests/api-build-requests-tests.js: Added unit tests.
server-tests/resources/mock-data.js: Added new mock data for new unit tests.

(MockData.addMockConfiguration):
(MockData.addMockData):
(MockData.set addMockBuildRequestsWithRoots):
(MockData.set addTwoMockTestGroupWithOwnedCommits):
(MockData.mockTestSyncConfigWithPatchAcceptingBuilder):

server-tests/tools-buildbot-triggerable-tests.js: Added unit tests.
tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype.async syncOnce):
(BuildbotTriggerable.prototype.async _scheduleRequest): A helper function to reuse the roots if there are built
roots available for same build type build request. If there is another build scheduled for same build request,
will defer scheduling the build request.

unit-tests/build-request-tests.js: Add unit tests.

12:25 PM Changeset in webkit [269870] by Russell Epstein

5 edits in branches/safari-610-branch/Source

Cherry-pick r268979. rdar://problem/71446613

Use a WeakHashSet for Document::m_captionPreferencesChangedElements
https://bugs.webkit.org/show_bug.cgi?id=218170

Reviewed by Eric Carlson.

Source/WebCore:

Refactoring to move from raw pointer to weak pointer.
For that purpose, we use WeakHashSet and WeakHashSet::forEach for extra safety.
No observable change of behavior.

dom/Document.cpp: (WebCore::Document::registerForCaptionPreferencesChangedCallbacks): (WebCore::Document::unregisterForCaptionPreferencesChangedCallbacks): (WebCore::Document::captionPreferencesChanged):
dom/Document.h:

Source/WTF:

wtf/WeakHashSet.h: Add a static cast for classes inheriting CanMakeWeakPtr like done for the set iterator. Update code to compile in WinCairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:14 PM Changeset in webkit [269869] by Devin Rousso

35 edits in trunk/Source

Ignore deprecation warnings for the uniform types C API
https://bugs.webkit.org/show_bug.cgi?id=218989

Reviewed by Tim Horton.

These should eventually be replaced with the ObjC API UniformTypeIdentifiers.framework.
See <https://developer.apple.com/documentation/uniformtypeidentifiers>.

Source/WebCore:

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::mimeTypeFromContentType):
(WebCore::attachmentForFilePath):

editing/mac/EditorMac.mm:

(WebCore::Editor::dataSelectionForPasteboard):

fileapi/FileCocoa.mm:

(WebCore::File::shouldReplaceFile):

page/mac/DragControllerMac.mm:

(WebCore::DragController::updateSupportedTypeIdentifiersForDragHandlingMethod const):

platform/cocoa/DragDataCocoa.mm:

(WebCore::rtfPasteboardType):
(WebCore::rtfdPasteboardType):
(WebCore::stringPasteboardType):
(WebCore::urlPasteboardType):
(WebCore::htmlPasteboardType):
(WebCore::pdfPasteboardType):
(WebCore::tiffPasteboardType):
(WebCore::DragData::containsCompatibleContent const):

platform/cocoa/MIMETypeRegistryCocoa.mm:

(WebCore::extensionsForMIMETypeMap):

platform/cocoa/PasteboardCocoa.mm:

(WebCore::cocoaTypeToImageType):
(WebCore::Pasteboard::fileContentState):

platform/cocoa/PlatformPasteboardCocoa.mm:

(WebCore::PlatformPasteboard::urlStringSuitableForLoading):

platform/graphics/cg/ImageBufferUtilitiesCG.cpp:

(WebCore::jpegUTI):
(WebCore::utiFromImageBufferMIMEType):

platform/graphics/cg/ImageSourceCGMac.mm:

(WebCore::preferredExtensionForImageType):

platform/graphics/mac/ImageMac.mm:

(WebCore::BitmapImage::tiffRepresentation):

platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::read):
(WebCore::supportedImageTypes):
(WebCore::isTypeAllowedByReadingPolicy):
(WebCore::Pasteboard::readPasteboardWebContentDataForType):
(WebCore::readURLAlongsideAttachmentIfNecessary):
(WebCore::prefersAttachmentRepresentation):
(WebCore::Pasteboard::supportedWebContentPasteboardTypes):
(WebCore::Pasteboard::supportedFileUploadPasteboardTypes):
(WebCore::utiTypeFromCocoaType):
(WebCore::Pasteboard::readPlatformValuesAsStrings):
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
(WebCore::webSafeTypes):
(WebCore::PlatformPasteboard::informationForItemAtIndex):
(WebCore::PlatformPasteboard::stringForType const):
(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):
(WebCore::addRepresentationsForPlainText):
(WebCore::PlatformPasteboard::allowReadingURLAtIndex const):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::createItemProviderRegistrationList):
(WebCore::PlatformPasteboard::readString const):
(WebCore::PlatformPasteboard::readURL const):
(WebCore::PlatformPasteboard::containsURLStringSuitableForLoading):

platform/ios/WebItemProviderPasteboard.mm:

(typeConformsToTypes):
(-[NSItemProvider web_containsFileURLAndFileUploadContent]):
(-[NSItemProvider web_fileUploadContentTypes]):
(-[WebItemProviderPasteboard _preLoadedDataConformingToType:forItemProviderAtIndex:]):
(classForTypeIdentifier):
(linkTemporaryItemProviderFilesToDropStagingDirectory):
(-[WebItemProviderPasteboard typeIdentifiersToLoad:]):

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::write):
(WebCore::Pasteboard::read):
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
(WebCore::Pasteboard::writeString):

platform/mac/PasteboardWriter.mm:

(WebCore::toUTI):
(WebCore::toUTIUnlessAlreadyUTI):
(WebCore::createPasteboardWriter):

platform/mac/PlatformPasteboardMac.mm:

(WebCore::canWritePasteboardType):
(WebCore::urlStringsFromPasteboard):
(WebCore::typeIdentifierForPasteboardType):
(WebCore::PlatformPasteboard::allStringsForType const):
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
(WebCore::PlatformPasteboard::setStringForType):

platform/network/ios/WebCoreURLResponseIOS.mm:

(WebCore::adjustMIMETypeIfNecessary):

platform/network/mac/UTIUtilities.mm:

(WebCore::MIMETypeFromUTI):
(WebCore::MIMETypeFromUTITree):
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::isDeclaredUTI):
(WebCore::UTIFromTag):

platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):

Source/WebKit:

Shared/ios/WebIconUtilities.mm:

(WebKit::iconForFile):

Shared/mac/PasteboardTypes.mm:

(WebKit::PasteboardTypes::forEditing):
(WebKit::PasteboardTypes::forSelection):

UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::isDeclaredOrDynamicTypeIdentifier):
(API::Attachment::mimeType const):
(API::Attachment::utiType const):
(API::Attachment::setFileWrapperAndUpdateContentType):

UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:

(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setPromisedDataForImage):

UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView supportedPasteboardTypesForCurrentSelection]):

UIProcess/ios/WKPDFView.mm:

(-[WKPDFView actionSheetAssistant:performAction:]):

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel currentAvailableActionTitles]):
(-[WKFileUploadPanel contextMenuInteraction:configurationForMenuAtLocation:]):
(-[WKFileUploadPanel showFilePickerMenu]):
(-[WKFileUploadPanel showDocumentPickerMenu]):
(-[WKFileUploadPanel _uploadItemFromMediaInfo:successBlock:failureBlock:]):

UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

12:05 PM Changeset in webkit [269868] by don.olmstead@sony.com

6 edits in trunk/Source

Non-unified build fixes, mid November 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=218911

Unreviewed build fix.

Source/WebCore:

display/css/DisplayBoxFactory.h:
page/Quirks.cpp:
rendering/style/GridPosition.cpp:

Source/WebKit:

UIProcess/SpeechRecognitionServer.cpp:

(WebKit::SpeechRecognitionServer::start):
(WebKit::SpeechRecognitionServer::requestPermissionForRequest):
(WebKit::SpeechRecognitionServer::sendUpdate):

11:52 AM Changeset in webkit [269867] by pvollan@apple.com

4 edits in trunk/Source

[macOS] The WebContent sandbox does not apply for open source builds
https://bugs.webkit.org/show_bug.cgi?id=218982

Reviewed by Alexey Proskuryakov.

Source/WebKit:

The WebContent sandbox does not apply for open source builds on macOS, since it has enabled message filtering,
which requires a private entitlement.

WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

Add HAVE define for sandbox message filtering.

wtf/PlatformHave.h:

11:46 AM Changeset in webkit [269866] by ysuzuki@apple.com

35 edits
12 copies
193 adds in trunk/LayoutTests

Import latest wpt/wasm tests
https://bugs.webkit.org/show_bug.cgi?id=218953

Reviewed by Saam Barati.

LayoutTests/imported/w3c:

This patch just imports and rebaselines wpt/wasm tests.

resources/import-expectations.json:
web-platform-tests/wasm/META.yml: Added.
web-platform-tests/wasm/compile_worker.js: Added.

(onmessage):

web-platform-tests/wasm/create_multiple_memory.worker-expected.txt: Added.
web-platform-tests/wasm/create_multiple_memory.worker.html: Added.
web-platform-tests/wasm/create_multiple_memory.worker.js: Added.

(test):

web-platform-tests/wasm/incrementer.wasm: Added.
web-platform-tests/wasm/jsapi/bad-imports.js:

(test_bad_imports.value_type):
(test_bad_imports):

web-platform-tests/wasm/jsapi/constructor/instantiate-bad-imports.any-expected.txt:
web-platform-tests/wasm/jsapi/constructor/instantiate-bad-imports.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/constructor/instantiate.any-expected.txt:
web-platform-tests/wasm/jsapi/constructor/instantiate.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/constructor/toStringTag.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/constructor/toStringTag.any.html: Added.
web-platform-tests/wasm/jsapi/constructor/toStringTag.any.js: Added.

(test):
(test.t.t.add_cleanup):

web-platform-tests/wasm/jsapi/constructor/toStringTag.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/constructor/toStringTag.any.worker.html: Added.
web-platform-tests/wasm/jsapi/constructor/w3c-import.log:
web-platform-tests/wasm/jsapi/functions/entry-different-function-realm-expected.txt: Added.
web-platform-tests/wasm/jsapi/functions/entry-different-function-realm.html: Added.
web-platform-tests/wasm/jsapi/functions/entry-expected.txt: Added.
web-platform-tests/wasm/jsapi/functions/entry.html: Added.
web-platform-tests/wasm/jsapi/functions/helper.js: Added.

(call_later):

web-platform-tests/wasm/jsapi/functions/incumbent-expected.txt: Added.
web-platform-tests/wasm/jsapi/functions/incumbent.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/README.md: Added.
web-platform-tests/wasm/jsapi/functions/resources/current/current.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/current/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/current/resources/window-to-open.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/current/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/entry-incumbent.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/function/function.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/function/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/function/resources/window-to-open.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/function/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/incumbent-incumbent.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/relevant/relevant.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/relevant/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/relevant/resources/window-to-open.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/relevant/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/resources/window-to-open.html: Added.
web-platform-tests/wasm/jsapi/functions/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/functions/resources/window-to-open.html: Added.
web-platform-tests/wasm/jsapi/functions/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/jsapi/global/constructor.any-expected.txt:
web-platform-tests/wasm/jsapi/global/constructor.any.js:

(test):
(string_appeared_here.toString):
(string_appeared_here.valueOf):
(string_appeared_here.test):
(toString):
(valueOf):
(name.format_value):
(const.invalidBigint.of.invalidBigints.test):

web-platform-tests/wasm/jsapi/global/constructor.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/global/value-get-set.any-expected.txt:
web-platform-tests/wasm/jsapi/global/value-get-set.any.js:

(string_appeared_here.name.of.immutableOptions.test):
(string_appeared_here.name.of.mutableOptions.test):
(test):

web-platform-tests/wasm/jsapi/global/value-get-set.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/idlharness.any-expected.txt:
web-platform-tests/wasm/jsapi/idlharness.any.js:

(async idl_array):
(promise_test.async const): Deleted.
(promise_test): Deleted.

web-platform-tests/wasm/jsapi/idlharness.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/instance/constructor-bad-imports.any-expected.txt:
web-platform-tests/wasm/jsapi/instance/constructor-bad-imports.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/instance/constructor.any-expected.txt:
web-platform-tests/wasm/jsapi/instance/constructor.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/instanceTestFactory.js:

(const.imports.string_appeared_here.string_appeared_here):

web-platform-tests/wasm/jsapi/memory/assertions.js: Added.

(assert_ArrayBuffer):

web-platform-tests/wasm/jsapi/memory/constructor-shared.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/memory/constructor-shared.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/memory/constructor-shared.tentative.any.js: Added.

(test):
(test.t.new.WebAssembly.Memory.get maximum):
(test.t.new.WebAssembly.Memory.get initial):
(test.t.new.WebAssembly.Memory.get shared):

web-platform-tests/wasm/jsapi/memory/constructor-shared.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/memory/constructor-shared.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/memory/constructor.any-expected.txt:
web-platform-tests/wasm/jsapi/memory/constructor.any.js:

(test.get assert_array_equals):
(test):
(assert_Memory): Deleted.
(test.t.get assert_array_equals): Deleted.

web-platform-tests/wasm/jsapi/memory/constructor.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/memory/grow.any.js:

(assert_ArrayBuffer): Deleted.

web-platform-tests/wasm/jsapi/memory/w3c-import.log:
web-platform-tests/wasm/jsapi/prototypes.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/prototypes.any.html: Added.
web-platform-tests/wasm/jsapi/prototypes.any.js: Added.

(setup):
(test):

web-platform-tests/wasm/jsapi/prototypes.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/prototypes.any.worker.html: Added.
web-platform-tests/wasm/jsapi/table/assertions.js:
web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/table/constructor.any.js:

(assert_Table): Deleted.

web-platform-tests/wasm/jsapi/table/w3c-import.log:
web-platform-tests/wasm/jsapi/w3c-import.log:
web-platform-tests/wasm/jsapi/wasm-module-builder.js:

(WasmModuleBuilder.prototype.addTable):
(WasmModuleBuilder.prototype.toBuffer):
(wasmF32Const):
(wasmF64Const):

web-platform-tests/wasm/resources/load_wasm.js: Added.

(createWasmModule):

web-platform-tests/wasm/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/serialization/arraybuffer/transfer.window-expected.txt: Added.
web-platform-tests/wasm/serialization/arraybuffer/transfer.window.html: Added.
web-platform-tests/wasm/serialization/arraybuffer/transfer.window.js: Added.

(test):

web-platform-tests/wasm/serialization/arraybuffer/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/serialization/module/broadcastchannel-success-and-failure-expected.txt: Added.
web-platform-tests/wasm/serialization/module/broadcastchannel-success-and-failure.html: Added.
web-platform-tests/wasm/serialization/module/broadcastchannel-success-expected.txt: Added.
web-platform-tests/wasm/serialization/module/broadcastchannel-success.html: Added.
web-platform-tests/wasm/serialization/module/identity-not-preserved-expected.txt: Added.
web-platform-tests/wasm/serialization/module/identity-not-preserved.html: Added.
web-platform-tests/wasm/serialization/module/incrementer.wasm: Added.
web-platform-tests/wasm/serialization/module/nested-worker-success.any.js: Added.
web-platform-tests/wasm/serialization/module/nested-worker-success.any.worker-expected.txt: Added.
web-platform-tests/wasm/serialization/module/nested-worker-success.any.worker.html: Added.
web-platform-tests/wasm/serialization/module/no-transferring-expected.txt: Added.
web-platform-tests/wasm/serialization/module/no-transferring.html: Added.
web-platform-tests/wasm/serialization/module/resources/blank.html: Added.
web-platform-tests/wasm/serialization/module/resources/broadcastchannel-iframe.html: Added.
web-platform-tests/wasm/serialization/module/resources/broadcastchannel-sharedworker.js: Added.

(channel.onmessageerror):

web-platform-tests/wasm/serialization/module/resources/broadcastchannel-worker.js: Added.

(channel.onmessage):

web-platform-tests/wasm/serialization/module/resources/create-empty-wasm-module.js: Added.

(createEmptyWasmModule):

web-platform-tests/wasm/serialization/module/resources/echo-iframe.html: Added.
web-platform-tests/wasm/serialization/module/resources/echo-worker.js: Added.

(self.onmessage):

web-platform-tests/wasm/serialization/module/resources/incrementer-iframe-domain.sub.html: Added.
web-platform-tests/wasm/serialization/module/resources/incrementer-iframe.html: Added.
web-platform-tests/wasm/serialization/module/resources/incrementer-popup.html: Added.
web-platform-tests/wasm/serialization/module/resources/incrementer-worker-with-channel.js: Added.

(self.onmessage):

web-platform-tests/wasm/serialization/module/resources/incrementer-worker.js: Added.
web-platform-tests/wasm/serialization/module/resources/incrementer.wasm: Added.
web-platform-tests/wasm/serialization/module/resources/nested-iframe-1.html: Added.
web-platform-tests/wasm/serialization/module/resources/nested-iframe-2.html: Added.
web-platform-tests/wasm/serialization/module/resources/nested-iframe-3.html: Added.
web-platform-tests/wasm/serialization/module/resources/nested-iframe-4-incrementer.html: Added.
web-platform-tests/wasm/serialization/module/resources/serviceworker-failure.js: Added.

(self.onmessage.e.else):

web-platform-tests/wasm/serialization/module/resources/sharedworker-failure.js: Added.
web-platform-tests/wasm/serialization/module/resources/test-incrementer.js: Added.

(createWasmModule):
(testModule):
(self.testSharingViaIncrementerScript):
(self.setupDestinationIncrementer):

web-platform-tests/wasm/serialization/module/resources/w3c-import.log: Added.
web-platform-tests/wasm/serialization/module/serialization-via-history-expected.txt: Added.
web-platform-tests/wasm/serialization/module/serialization-via-history.html: Added.
web-platform-tests/wasm/serialization/module/serialization-via-idb.any-expected.txt: Added.
web-platform-tests/wasm/serialization/module/serialization-via-idb.any.html: Added.
web-platform-tests/wasm/serialization/module/serialization-via-idb.any.js: Added.

(createEmptyWasmModule):
(async_test.t.openReq.onupgradeneeded.e.store.put.property.get x):
(async_test.t.openReq.onupgradeneeded.e.store.put.createEmptyWasmModule.get x):
(async_test.t.openReq.onupgradeneeded.e.store.put.createEmptyWasmModule):

web-platform-tests/wasm/serialization/module/serialization-via-idb.any.worker-expected.txt: Added.
web-platform-tests/wasm/serialization/module/serialization-via-idb.any.worker.html: Added.
web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any-expected.txt: Added.
web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.html: Added.
web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.js: Added.

(createEmptyWasmModule):
(test):

web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.worker-expected.txt: Added.
web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.worker.html: Added.
web-platform-tests/wasm/serialization/module/w3c-import.log: Added.
web-platform-tests/wasm/serialization/module/window-domain-success.sub-expected.txt: Added.
web-platform-tests/wasm/serialization/module/window-domain-success.sub.html: Added.
web-platform-tests/wasm/serialization/module/window-messagechannel-success-expected.txt: Added.
web-platform-tests/wasm/serialization/module/window-messagechannel-success.html: Added.
web-platform-tests/wasm/serialization/module/window-serviceworker-failure.https-expected.txt: Added.
web-platform-tests/wasm/serialization/module/window-serviceworker-failure.https.html: Added.
web-platform-tests/wasm/serialization/module/window-sharedworker-failure-expected.txt: Added.
web-platform-tests/wasm/serialization/module/window-sharedworker-failure.html: Added.
web-platform-tests/wasm/serialization/module/window-similar-but-cross-origin-success.sub-expected.txt: Added.
web-platform-tests/wasm/serialization/module/window-similar-but-cross-origin-success.sub.html: Added.
web-platform-tests/wasm/serialization/module/window-simple-success-expected.txt: Added.
web-platform-tests/wasm/serialization/module/window-simple-success.html: Added.
web-platform-tests/wasm/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/w3c-import.log.
web-platform-tests/wasm/webapi/abort.any-expected.txt: Added.
web-platform-tests/wasm/webapi/abort.any.html: Added.
web-platform-tests/wasm/webapi/abort.any.js: Added.

(const.method.of.methods.promise_test.async t):
(const.method.of.methods.return.promise_rejects_dom):

web-platform-tests/wasm/webapi/abort.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/abort.any.worker.html: Added.
web-platform-tests/wasm/webapi/body.any-expected.txt: Added.
web-platform-tests/wasm/webapi/body.any.html: Added.
web-platform-tests/wasm/webapi/body.any.js: Added.

(string_appeared_here.WebAssembly.method):
(string_appeared_here.return.promise_rejects_js):

web-platform-tests/wasm/webapi/body.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/body.any.worker.html: Added.
web-platform-tests/wasm/webapi/contenttype.any-expected.txt: Added.
web-platform-tests/wasm/webapi/contenttype.any.html: Added.
web-platform-tests/wasm/webapi/contenttype.any.js: Added.

(const.contenttype.of.validContentTypes.promise_test.async t):

web-platform-tests/wasm/webapi/contenttype.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/contenttype.any.worker.html: Added.
web-platform-tests/wasm/webapi/empty-body.any-expected.txt: Added.
web-platform-tests/wasm/webapi/empty-body.any.html: Added.
web-platform-tests/wasm/webapi/empty-body.any.js: Added.

(string_appeared_here.name.of.invalidArguments.WebAssembly.method):

web-platform-tests/wasm/webapi/empty-body.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/empty-body.any.worker.html: Added.
web-platform-tests/wasm/webapi/historical.any-expected.txt: Added.
web-platform-tests/wasm/webapi/historical.any.html: Added.
web-platform-tests/wasm/webapi/historical.any.js: Added.

(promise_test.async t.):
(promise_test.async t):

web-platform-tests/wasm/webapi/historical.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/historical.any.worker.html: Added.
web-platform-tests/wasm/webapi/idlharness.any-expected.txt: Added.
web-platform-tests/wasm/webapi/idlharness.any.html: Added.
web-platform-tests/wasm/webapi/idlharness.any.js: Added.
web-platform-tests/wasm/webapi/idlharness.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/idlharness.any.worker.html: Added.
web-platform-tests/wasm/webapi/instantiateStreaming-bad-imports.any-expected.txt: Added.
web-platform-tests/wasm/webapi/instantiateStreaming-bad-imports.any.html: Added.
web-platform-tests/wasm/webapi/instantiateStreaming-bad-imports.any.js: Added.

(test_bad_imports):

web-platform-tests/wasm/webapi/instantiateStreaming-bad-imports.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/instantiateStreaming-bad-imports.any.worker.html: Added.
web-platform-tests/wasm/webapi/instantiateStreaming.any-expected.txt: Added.
web-platform-tests/wasm/webapi/instantiateStreaming.any.html: Added.
web-platform-tests/wasm/webapi/instantiateStreaming.any.js: Added.

(setup):
(fn.of.instanceTestFactory.promise_test.async const):
(fn.of.instanceTestFactory.promise_test):
(promise_test.async const):
(promise_test.const.imports.get module.return.get global):
(promise_test.const.imports.get module):
(promise_test):

web-platform-tests/wasm/webapi/instantiateStreaming.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/instantiateStreaming.any.worker.html: Added.
web-platform-tests/wasm/webapi/invalid-args.any-expected.txt: Added.
web-platform-tests/wasm/webapi/invalid-args.any.html: Added.
web-platform-tests/wasm/webapi/invalid-args.any.js: Added.

(string_appeared_here.name.format_value):

web-platform-tests/wasm/webapi/invalid-args.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/invalid-args.any.worker.html: Added.
web-platform-tests/wasm/webapi/invalid-code.any-expected.txt: Added.
web-platform-tests/wasm/webapi/invalid-code.any.html: Added.
web-platform-tests/wasm/webapi/invalid-code.any.js: Added.

(setup):

web-platform-tests/wasm/webapi/invalid-code.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/invalid-code.any.worker.html: Added.
web-platform-tests/wasm/webapi/origin.sub.any-expected.txt: Added.
web-platform-tests/wasm/webapi/origin.sub.any.html: Added.
web-platform-tests/wasm/webapi/origin.sub.any.js: Added.
web-platform-tests/wasm/webapi/origin.sub.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/origin.sub.any.worker.html: Added.
web-platform-tests/wasm/webapi/rejected-arg.any-expected.txt: Added.
web-platform-tests/wasm/webapi/rejected-arg.any.html: Added.
web-platform-tests/wasm/webapi/rejected-arg.any.js: Added.

(string_appeared_here.WebAssembly.method):

web-platform-tests/wasm/webapi/rejected-arg.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/rejected-arg.any.worker.html: Added.
web-platform-tests/wasm/webapi/status.any-expected.txt: Added.
web-platform-tests/wasm/webapi/status.any.html: Added.
web-platform-tests/wasm/webapi/status.any.js: Added.
web-platform-tests/wasm/webapi/status.any.worker-expected.txt: Added.
web-platform-tests/wasm/webapi/status.any.worker.html: Added.
web-platform-tests/wasm/webapi/status.py: Added.

(main):

web-platform-tests/wasm/webapi/w3c-import.log: Added.

LayoutTests:

TestExpectations:
platform/mac-wk1/TestExpectations:

11:32 AM Changeset in webkit [269865] by Megan Gardner

20 edits in trunk/Source

Add menu support for app highlights for books
https://bugs.webkit.org/show_bug.cgi?id=218879
<rdar://problem/71352113>

Reviewed by Alex Christensen.

Source/WebCore:

Add menu items and associated plubling for support for books highlights in modern webkit.

WebCore.xcodeproj/project.pbxproj:
page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

platform/ContextMenuItem.cpp:

(WebCore::isValidContextMenuAction):

platform/ContextMenuItem.h:
platform/LocalizedStrings.h:
platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::contextMenuItemTagAddHighlightToCurrentGroup):
(WebCore::contextMenuItemTagAddHighlightToNewGroup):

Source/WebKit:

Add menu items and associated plumbing for support for books highlights in modern WebKit.

FeatureFlags/WebKit.plist:
Shared/API/c/WKContextMenuItemTypes.h:
Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:

(WebKit::isFeatureFlagEnabled):

Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultAppHighlightsEnabled):

Shared/WebPreferencesDefaultValues.h:
UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm:

(toTag):

Source/WTF:

Scripts/Preferences/WebPreferencesInternal.yaml:

10:59 AM Changeset in webkit [269864] by Russell Epstein

5 edits in branches/safari-610.3.7.0-branch/Source

Cherry-pick r268979. rdar://problem/71446619

Use a WeakHashSet for Document::m_captionPreferencesChangedElements
https://bugs.webkit.org/show_bug.cgi?id=218170

Reviewed by Eric Carlson.

Source/WebCore:

Refactoring to move from raw pointer to weak pointer.
For that purpose, we use WeakHashSet and WeakHashSet::forEach for extra safety.
No observable change of behavior.

dom/Document.cpp: (WebCore::Document::registerForCaptionPreferencesChangedCallbacks): (WebCore::Document::unregisterForCaptionPreferencesChangedCallbacks): (WebCore::Document::captionPreferencesChanged):
dom/Document.h:

Source/WTF:

wtf/WeakHashSet.h: Add a static cast for classes inheriting CanMakeWeakPtr like done for the set iterator. Update code to compile in WinCairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:58 AM Changeset in webkit [269863] by Russell Epstein

8 edits in branches/safari-610.3.7.0-branch/Source

Versioning.

WebKit-7610.3.7.0.3

10:58 AM Changeset in webkit [269862] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Add CSS aspect ratio to feature status page
https://bugs.webkit.org/show_bug.cgi?id=218979

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-16
Reviewed by Simon Fraser.

Add status entry for CSS aspect ratio as well as
a css-sizing category for CSS properties.

css/CSSProperties.json:
features.json:

10:41 AM Changeset in webkit [269861] by Russell Epstein

5 edits in branches/safari-610.3.7.1-branch/Source

Cherry-pick r268979. rdar://problem/71446624

Use a WeakHashSet for Document::m_captionPreferencesChangedElements
https://bugs.webkit.org/show_bug.cgi?id=218170

Reviewed by Eric Carlson.

Source/WebCore:

Refactoring to move from raw pointer to weak pointer.
For that purpose, we use WeakHashSet and WeakHashSet::forEach for extra safety.
No observable change of behavior.

dom/Document.cpp: (WebCore::Document::registerForCaptionPreferencesChangedCallbacks): (WebCore::Document::unregisterForCaptionPreferencesChangedCallbacks): (WebCore::Document::captionPreferencesChanged):
dom/Document.h:

Source/WTF:

wtf/WeakHashSet.h: Add a static cast for classes inheriting CanMakeWeakPtr like done for the set iterator. Update code to compile in WinCairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:40 AM Changeset in webkit [269860] by Russell Epstein

8 edits in branches/safari-610.3.7.1-branch/Source

Versioning.

WebKit-7610.3.7.1.5

10:12 AM Changeset in webkit [269859] by Andres Gonzalez

2 edits in trunk/Source/WebCore

Add logging of AXCoreObject outerHTML to AXLogger.
https://bugs.webkit.org/show_bug.cgi?id=218958

Reviewed by Chris Fleizach.

No change in functionality, debugging code.

accessibility/AXLogger.cpp:

(WebCore::operator<<):

Added logging of the outerHTML of the corresponding Element for AXCoreObjects.
Added logging of the platform wrapper address for AXCoreObjects.

10:08 AM Changeset in webkit [269858] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Add didReceiveResponseForResource to WKWebProcessPlugInLoadDelegate
https://bugs.webkit.org/show_bug.cgi?id=218925

Patch by Trevor Stevenson <trevor_s@apple.com> on 2020-11-16
Reviewed by Alex Christensen.

Expose the callback for didReceiveResponseForResource in WKWebProcessPlugInLoadDelegate
for use in the injected bundle.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didReceiveResponseForResource):
(setUpResourceLoadClient):

9:33 AM Changeset in webkit [269857] by Chris Dumez

4 edits in trunk/Tools

Fix several leaks of CGContext in API tests
https://bugs.webkit.org/show_bug.cgi?id=218988

Reviewed by Wenson Hsieh.

Make sure we adopt the value returned by CGBitmapContextCreate().

TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:

(TEST):

TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:

(TestWebKitAPI::TEST):

9:30 AM Changeset in webkit [269856] by Russell Epstein

2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r269651. rdar://problem/71442660

[macOS] Allow IOGLESBundleName for Apple Silicon Macs
https://bugs.webkit.org/show_bug.cgi?id=218774
<rdar://problem/67473780>

Unreviewed follow-up fix to r269649.

Two additional keys are needed: MetalPluginClassName and MetalPluginName

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:29 AM Changeset in webkit [269855] by Russell Epstein

2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r269649. rdar://problem/71442660

[macOS] Allow IOGLESBundleName for Apple Silicon Macs
https://bugs.webkit.org/show_bug.cgi?id=218774
<rdar://problem/67473780>

Reviewed by Tim Horton.

The WebContent should be able to read the IOGLESBundleName IOKit property on
Apple Silicon Macs. This will help the OpenGL stack make better choices about
which bundles to load when processing WebGL content.

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:04 AM Changeset in webkit [269854] by weinig@apple.com

1 edit
1 add in trunk/LayoutTests

Remove and re-add fast/forms/selection-direction.html without CRs
https://bugs.webkit.org/show_bug.cgi?id=218966

fast/forms/selection-direction.html:

Re add test back without the CRs.

8:40 AM Changeset in webkit [269853] by Chris Dumez

32 edits in trunk/LayoutTests

WebAudio tests may give slightly different outputs on different platforms
https://bugs.webkit.org/show_bug.cgi?id=218929

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that their output has changed.

web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet-connections.https-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/maxdelay-rounding-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:

LayoutTests:

WebAudio tests may give slightly different outputs on different platforms, causing what looks like flakiness.
This is due to the "(contains X different values)" because X may differ from one platform to another
(usually +/- 1).

resources/testharnessreport.js:

(self.testRunner.add_completion_callback):
Strip the "(contains X different values)" strings from output lines.

webaudio/AudioNode/tail-connections-expected.txt:
webaudio/AudioNode/tail-processing-expected.txt:
webaudio/BiquadFilter/biquad-829349-expected.txt:
webaudio/BiquadFilter/tail-time-allpass-expected.txt:
webaudio/BiquadFilter/tail-time-bandpass-expected.txt:
webaudio/BiquadFilter/tail-time-highpass-expected.txt:
webaudio/BiquadFilter/tail-time-highshelf-expected.txt:
webaudio/BiquadFilter/tail-time-lowpass-expected.txt:
webaudio/BiquadFilter/tail-time-lowshelf-expected.txt:
webaudio/BiquadFilter/tail-time-notch-expected.txt:
webaudio/BiquadFilter/tail-time-peaking-expected.txt:
webaudio/IIRFilter/iir-tail-time-expected.txt:

Rebaseline tests accordingly.

6:51 AM Changeset in webkit [269852] by Antti Koivisto

7 edits in trunk/Source/WebCore

[LFC][Integration] Remove isLastTextRunOnLine/isLastTextRun from run iterator
https://bugs.webkit.org/show_bug.cgi?id=218978

Reviewed by Zalan Bujtas.

Use the line interface instead. This both more readable and more generic.

dom/Position.cpp:

(WebCore::Position::upstream const):
(WebCore::Position::downstream const):

layout/integration/LayoutIntegrationLineIterator.cpp:

(WebCore::LayoutIntegration::LineIterator::operator== const):

Also use Variant default operator==.

layout/integration/LayoutIntegrationRunIterator.cpp:

(WebCore::LayoutIntegration::RunIterator::operator== const):

layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::PathTextRun::isLastTextRunOnLine const): Deleted.
(WebCore::LayoutIntegration::PathTextRun::isLastTextRun const): Deleted.

layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

Also use RefCountedArray instead of Vector to avoid unnecessary copies of the order cache.

(WebCore::LayoutIntegration::RunIteratorLegacyPath::isLastTextRunOnLine const): Deleted.
(WebCore::LayoutIntegration::RunIteratorLegacyPath::isLastTextRun const): Deleted.

layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::isLastTextRunOnLine const): Deleted.
(WebCore::LayoutIntegration::RunIteratorModernPath::isLastTextRun const): Deleted.

6:05 AM Changeset in webkit [269851] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit

WebDriver: do not focus the main frame when switching to a window
https://bugs.webkit.org/show_bug.cgi?id=218383

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-11-16
Reviewed by Brian Burg.

The spec doesn't say we should focus the main frame. This is confusing WPT test
infrastructure/testdriver/actions/crossOrigin.sub.html that first focuses an input in an iframe and then it send
keyboard events to the window (after switching to the window again even when it's already the current one, that
causes the iframe focus to be lost).

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::switchToBrowsingContext):

WebProcess/Automation/WebAutomationSessionProxy.cpp:
WebProcess/Automation/WebAutomationSessionProxy.h:
WebProcess/Automation/WebAutomationSessionProxy.messages.in:

4:57 AM Changeset in webkit [269850] by commit-queue@webkit.org

78 edits in trunk/Source

Final refactor for WebGL implementation to use only GraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=218333

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-11-16
Reviewed by Simon Fraser.

Source/WebCore:

Change WebGL implementation to use GraphicsContextGL abstract class
instead of GraphicsContextGLOpenGL concrete class. This allows
implementation of WebGL in GpuProcess, where the remote implementation
is one GraphicsContextGL subclass and the actual drawing is done,
either in GPUP and non-GPUP cases by the old GraphicsContextGLOpenGL.

The GPUP supports only ANGLE flavor of the WebGL implementation. This is
because ANGLE contains the functions that are designed to be more secure
for the cross-process environment. This is why GraphicsContextGL
interface is modified to contain only functions that make sense for
ANGLE. Functions unimplemeted by ANGLE are removed from the interface.
Calling WebGL code inside #ifdef !USE(ANGLE) will downcast the interface
to GraphicsContextGLOpenGL to call the functions that do not make sense
to exist in the ANGLE version.

Small amount of functions in GraphicsContextGL interface are re-ordered
to enable later IPC auto-generation from the interface.

ExtensionsGL.h is reformatted according to WebKit style to enable later
IPC auto-generation from the interface.

No new tests, a refactor.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::rendererIsNeeded):
(WebCore::HTMLVideoElement::parseAttribute):
(WebCore::HTMLVideoElement::supportsFullscreen const):
(WebCore::HTMLVideoElement::paintCurrentFrameInContext):
(WebCore::HTMLVideoElement::copyVideoTextureToPlatformTexture):
(WebCore::HTMLVideoElement::hasAvailableVideoFrame const):
(WebCore::HTMLVideoElement::webkitEnterFullscreen):

html/HTMLVideoElement.h:
html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::create):
(WebCore::WebGL2RenderingContext::WebGL2RenderingContext):
(WebCore::WebGL2RenderingContext::getBufferSubData):
(WebCore::WebGL2RenderingContext::vertexAttribI4uiv):
(WebCore::WebGL2RenderingContext::bindSampler):
(WebCore::WebGL2RenderingContext::clientWaitSync):
(WebCore::WebGL2RenderingContext::deleteTransformFeedback):
(WebCore::WebGL2RenderingContext::beginTransformFeedback):
(WebCore::WebGL2RenderingContext::endTransformFeedback):
(WebCore::WebGL2RenderingContext::transformFeedbackVaryings):
(WebCore::WebGL2RenderingContext::getActiveUniforms):

html/canvas/WebGL2RenderingContext.h:
html/canvas/WebGLActiveInfo.h:
html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::deleteObjectImpl):

html/canvas/WebGLBuffer.h:
html/canvas/WebGLContextGroup.cpp:

(WebCore::WebGLContextGroup::getAGraphicsContextGL):

html/canvas/WebGLContextGroup.h:
html/canvas/WebGLContextObject.cpp:

(WebCore::WebGLContextObject::getAGraphicsContextGL const):

html/canvas/WebGLContextObject.h:
html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::supported):

html/canvas/WebGLDepthTexture.h:
html/canvas/WebGLDrawBuffers.cpp:

(WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):

html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

html/canvas/WebGLFramebuffer.h:
html/canvas/WebGLObject.cpp:

(WebCore::WebGLObject::deleteObject):

html/canvas/WebGLObject.h:
html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::deleteObjectImpl):
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::cacheInfoIfNeeded):

html/canvas/WebGLProgram.h:
html/canvas/WebGLQuery.cpp:

(WebCore::WebGLQuery::deleteObjectImpl):

html/canvas/WebGLQuery.h:
html/canvas/WebGLRenderbuffer.cpp:

(WebCore::WebGLRenderbuffer::deleteObjectImpl):

html/canvas/WebGLRenderbuffer.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):

html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::isHighPerformanceContext):
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::compressedTexImage2D):
(WebCore::WebGLRenderingContextBase::validateElementArraySize):
(WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContextBase::validateDrawElements):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::texImageSourceHelper):
(WebCore::WebGLRenderingContextBase::texImage2DBase):
(WebCore::WebGLRenderingContextBase::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContextBase::copyTexImage2D):
(WebCore::WebGLRenderingContextBase::isTexInternalFormatColorBufferCombinationValid):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
(WebCore::WebGLRenderingContextBase::initVertexAttrib0):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::drawElementsInstanced):

html/canvas/WebGLRenderingContextBase.h:

(WebCore::WebGLRenderingContextBase::graphicsContextGL const):

html/canvas/WebGLSampler.cpp:

(WebCore::WebGLSampler::deleteObjectImpl):

html/canvas/WebGLSampler.h:
html/canvas/WebGLShader.cpp:

(WebCore::WebGLShader::deleteObjectImpl):

html/canvas/WebGLShader.h:
html/canvas/WebGLShaderPrecisionFormat.h:
html/canvas/WebGLSharedObject.cpp:

(WebCore::WebGLSharedObject::getAGraphicsContextGL const):

html/canvas/WebGLSharedObject.h:
html/canvas/WebGLSync.cpp:

(WebCore::WebGLSync::deleteObjectImpl):

html/canvas/WebGLSync.h:
html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::deleteObjectImpl):

html/canvas/WebGLTexture.h:
html/canvas/WebGLTransformFeedback.cpp:

(WebCore::WebGLTransformFeedback::deleteObjectImpl):

html/canvas/WebGLTransformFeedback.h:
html/canvas/WebGLVertexArrayObject.cpp:

(WebCore::WebGLVertexArrayObject::deleteObjectImpl):

html/canvas/WebGLVertexArrayObject.h:
html/canvas/WebGLVertexArrayObjectBase.h:
html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):

html/canvas/WebGLVertexArrayObjectOES.h:
inspector/InspectorShaderProgram.cpp:
platform/graphics/ConcreteImageBuffer.h:
platform/graphics/ExtensionsGL.h:
platform/graphics/FormatConverter.cpp:

(WebCore::FormatConverter::convert):

platform/graphics/FormatConverter.h:
platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextGL.cpp:
platform/graphics/GraphicsContextGL.h:

(WebCore::GraphicsContextGL::contextAttributes const):
(WebCore::GraphicsContextGL::setContextAttributes):

platform/graphics/GraphicsTypesGL.h:
platform/graphics/ImageBuffer.h:
platform/graphics/ImageBufferBackend.h:

(WebCore::ImageBufferBackend::copyToPlatformTexture const):

platform/graphics/MediaPlayer.cpp:

(WebCore::bestMediaEngineForSupportParameters):
(WebCore::MediaPlayer::nextMediaEngine):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::cancelLoad):
(WebCore::MediaPlayer::setSize):
(WebCore::MediaPlayer::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayer::supportsType):
(WebCore::MediaPlayer::getSupportedTypes):
(WebCore::MediaPlayer::languageOfPrimaryAudioTrack const):
(WebCore::MediaPlayer::fileSize const):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::hasClosedCaptions const):
(WebCore::MediaPlayerPrivateInterface::copyVideoTextureToPlatformTexture):

platform/graphics/angle/ExtensionsGLANGLE.cpp:

(WebCore::ExtensionsGLANGLE::compressedTexImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexSubImage2DRobustANGLE):

platform/graphics/angle/ExtensionsGLANGLE.h:
platform/graphics/angle/GraphicsContextGLANGLE.cpp:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
(WebCore::MediaPlayerPrivateAVFoundationObjC::accessLog const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::flushCues):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setBufferingPolicy):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture):

platform/graphics/cocoa/IOSurface.mm:

(WebCore::optionsForBiplanarSurface):
(WebCore::IOSurface::ensurePlatformContext):
(WebCore::IOSurface::convertToFormat):

platform/graphics/egl/GLContextEGL.cpp:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::copyVideoTextureToPlatformTexture):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::possibleFormatAndTypeForInternalFormat):

platform/graphics/opengl/GraphicsContextGLOpenGL.h:
platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::reshape):
(WebCore::GraphicsContextGLOpenGL::blendFunc):
(WebCore::GraphicsContextGLOpenGL::compileShader):
(WebCore::GraphicsContextGLOpenGL::getActiveAttribImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveAttrib):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveUniform):
(WebCore::GraphicsContextGLOpenGL::originalSymbolName):
(WebCore::GraphicsContextGLOpenGL::mappedSymbolName):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::getNonBuiltInActiveSymbolCount):
(WebCore::GraphicsContextGLOpenGL::getUnmangledInfoLog):
(WebCore::GraphicsContextGLOpenGL::getProgramInfoLog):
(WebCore::GraphicsContextGLOpenGL::getShaderiv):
(WebCore::GraphicsContextGLOpenGL::getShaderInfoLog):
(WebCore::GraphicsContextGLOpenGL::getShaderSource):

Source/WebKit:

Change MediaPlayerPrivate to use GraphicsContextGL abstract class
instead of GraphicsContextGLOpenGL concrete class, since the
calling code is doing the same change.

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::copyVideoTextureToPlatformTexture):

WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

4:46 AM Changeset in webkit [269849] by commit-queue@webkit.org

10 edits in trunk/Source/WebCore

[GStreamer] Clean-up Audio{Data,StreamDescription} implementations
https://bugs.webkit.org/show_bug.cgi?id=218957

Patch by Philippe Normand <pnormand@igalia.com> on 2020-11-16
Reviewed by Xabier Rodriguez-Calvar.

Refactor the GStreamerAudioData and GStreamerStreamDescription implementations in order to
avoid un-necessary copies. The call-sites were adapted accordingly. Some usage of the latter
class was removed because it was simpler to use the GstAudioInfo API directly.

Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp:

(WebCore::MediaStreamAudioSource::consumeAudio):

platform/audio/gstreamer/GStreamerAudioData.h:
platform/audio/gstreamer/GStreamerAudioStreamDescription.h:
platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::GStreamerAudioCaptureSource::newSampleCallback):

platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(webkitMediaStreamSrcPushAudioSample):

platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp:

(WebCore::MockRealtimeAudioSourceGStreamer::render):

platform/mediastream/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeIncomingAudioSourceLibWebRTC::OnData):

platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::libwebrtcAudioFormat):
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData):

platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:

4:29 AM Changeset in webkit [269848] by Andres Gonzalez

2 edits in trunk/Source/WebCore

Optimization for AccessibilityNodeObject::accessibilityDescription.
https://bugs.webkit.org/show_bug.cgi?id=218959

Reviewed by Darin Adler.

No change in functionality, optimization.

AccessibilityObject::title() can be an expensive operations because it
can invoke textUnderElement which causes text extraction for all
descendants of the object. Thus, rewrote this snippet in a more
efficient way.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::accessibilityDescription const):

4:17 AM Changeset in webkit [269847] by youenn@apple.com

5 edits
2 adds in trunk

TextEncoderStreamEncoder should not be exposed
https://bugs.webkit.org/show_bug.cgi?id=218956

Reviewed by Yusuke Suzuki.

Source/WebCore:

Binding generator correctly handles private identifiers and runtime settings, but not when combined for interfaces.

Test: fast/encoding/stream-visibility.html

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingDOMConstructor::prototypeForStructure):
(WebCore::JSTestEnabledBySetting::finishCreation):
(WebCore::jsTestEnabledBySetting_TestSubObjEnabledBySettingPrivateConstructorGetter):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
(WebCore::setJSTestEnabledBySetting_TestSubObjEnabledBySettingPrivateConstructorSetter):
(WebCore::JSC_DEFINE_CUSTOM_SETTER):
(WebCore::jsTestEnabledBySetting_TestSubObjEnabledBySettingPrivatePublicConstructorGetter):
(WebCore::setJSTestEnabledBySetting_TestSubObjEnabledBySettingPrivatePublicConstructorSetter):

bindings/scripts/test/TestEnabledBySetting.idl:

LayoutTests:

fast/encoding/stream-visibility-expected.txt: Added.
fast/encoding/stream-visibility.html: Added.

3:28 AM Changeset in webkit [269846] by Devin Rousso

4 edits in trunk/Source

[iPad] nhl.com cannot select new video to play while video is playing with desktop UA
https://bugs.webkit.org/show_bug.cgi?id=218868
<rdar://problem/67823088>

Reviewed by Antoine Quint.

The desktop "version" of this site uses custom media controls that don't work well on iOS
because they rely on mouse events (which is why it was quirked in r255592). The mobile
"version" uses the default/native media controls, so there is no issue.

Currently, when tapping on another video with a desktop UA, the site uses its touch event
handlers for mouse events. These handlers call Event.prototype.preventDefault if the event
is not a touch event, meaning that "click" is not fired. This prevents new videos from
being played.

Rather than limit the quirk based on some DOM state (which is fragile if the site changes),
just have the entire site default to a mobile UA.

Source/WebCore:

page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Source/WebKit:

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommendedForRequest):

3:16 AM Changeset in webkit [269845] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.30/Source

[GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF
https://bugs.webkit.org/show_bug.cgi?id=218921

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No new tests needed.

Modules/webaudio/AudioContext.cpp: Add missing Document.h include.

Source/WebKit:

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Use ENABLE(VIDEO)
guard to prevent usage of function which does not get compiled in when video support
disabled

2:35 AM Changeset in webkit [269844] by Philippe Normand

1 edit
1 add in trunk/Tools/buildstream

[Flatpak SDK] Update rr
https://bugs.webkit.org/show_bug.cgi?id=218973

Reviewed by Žan Doberšek.

elements/sdk/rr.bst: Update for new git repository location and bump to version 5.4.x.

2:08 AM Changeset in webkit [269843] by zandobersek@gmail.com

2 edits in trunk/Source/WTF

Re-disable async overflow scrolling for USE(NICOSIA)
https://bugs.webkit.org/show_bug.cgi?id=218974

Async overflow scrolling was accidentally enabled for ports using the
Nicosia platform layering infrastructure during the preference migration
done in r267775. This patch again disables it until it can be properly
supported.

Scripts/Preferences/WebPreferencesInternal.yaml:

2:06 AM Changeset in webkit [269842] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit

[CoordinatedGraphics] Adjust client resizing, render-scope notifying in ThreadedCompositor::renderLayerTree()
https://bugs.webkit.org/show_bug.cgi?id=218701

Reviewed by Carlos Garcia Campos.

Rework the client operations in ThreadedCompositor::renderLayerTree() so
that client resizing is done before the will-render client notification
is dispatched. This ensures everything in the will-render-to-did-render
scope is done for a well-specified size from the client's point of view.

Similar to this change, the GL viewport update is split from the client
resize operation and moved into the aforementioned rendering scope. This
change is mostly cosmetic, but it's done to neatly package all the GL
operations into that scope.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree):

2:05 AM Changeset in webkit [269841] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

PlatformDisplayLibWPE: use eglGetPlatformDisplay when possible
https://bugs.webkit.org/show_bug.cgi?id=218941

Reviewed by Carlos Garcia Campos.

Use the existing wpe_renderer_backend_egl API to detect any desired
EGL platform that should be used to retrieve the global EGLDisplay
object. If such a platform is specified, the eglGetPlatformDisplay
entrypoing from the EGL_EXT_platform_base extension should be used
to retrieve the corresponding EGLDisplay.

If the API or the extension is not available, or if the EGLDisplay is
not retrieved this way, we fall back to eglGetDisplay.

platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:

(WebCore::PlatformDisplayLibWPE::initialize):

1:50 AM Changeset in webkit [269840] by svillar@igalia.com

3 edits in trunk/Source/WebCore

[css-flex] Better naming from some methods
https://bugs.webkit.org/show_bug.cgi?id=218745

Reviewed by Javier Fernandez.

This patch improves the naming of several confusing methods.

hasOrthogonalFlow(): was too generic. It was basically checking that the flexbox container main size was not the child's inline size. So we renamed

it to mainAxisIsChildInlineAxis() reverting the output. For most of the cases it was enough to negate the output of the method to have the same
check, but in other cases we decided to swap the if-else blocks as it was more convenient.

{main|cross}AxisLengthIsDefinite(): the name was misleading because you don't know whether the method is evaluating the child's length

or the container's (the flexbox). Replaced by child{Main|Cross}SizeIsDefinite().

setOverrideMainAxisContentSizeForChild(): this had 2 problems. First it should use overriding instead of override. Second the size which is

overriden is not the content size, it used to be but not anymore.

No new tests as there is no change in functionality.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::firstLineBaseline const):
(WebCore::RenderFlexibleBox::mainAxisIsChildInlineAxis const): Renamed from hasOrthogonalFlow(). Also the behaviour
is now reversed from the original function.
(WebCore::RenderFlexibleBox::childIntrinsicLogicalHeight const):
(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const):
(WebCore::RenderFlexibleBox::crossAxisIntrinsicExtentForChild const):
(WebCore::RenderFlexibleBox::mainAxisContentExtent): Early return instead of if-else block.
(WebCore::RenderFlexibleBox::useChildAspectRatio const):
(WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing const): Use a single line for division operators.
(WebCore::RenderFlexibleBox::childMainSizeIsDefinite const): Renamed from mainAxisLengthIsDefinite.
(WebCore::RenderFlexibleBox::childCrossSizeIsDefinite const): Renamed from crossAxisLengthIsDefinite.
(WebCore::RenderFlexibleBox::cacheChildMainSize):
(WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
(WebCore::RenderFlexibleBox::crossSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::childLogicalHeightForPercentageResolution):
(WebCore::RenderFlexibleBox::adjustChildSizeForAspectRatioCrossAxisMinAndMax):
(WebCore::RenderFlexibleBox::setOverridingMainSizeForChild): Renamed from setOverrideMainAxisContentSizeForChild.
(WebCore::RenderFlexibleBox::alignmentForChild const):
(WebCore::RenderFlexibleBox::childHasIntrinsicMainAxisSize const):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
(WebCore::RenderFlexibleBox::hasOrthogonalFlow const): Deleted.
(WebCore::RenderFlexibleBox::mainAxisLengthIsDefinite const): Deleted.
(WebCore::RenderFlexibleBox::crossAxisLengthIsDefinite const): Deleted.
(WebCore::RenderFlexibleBox::setOverrideMainAxisContentSizeForChild): Deleted.

rendering/RenderFlexibleBox.h:

1:27 AM Changeset in webkit [269839] by Philippe Normand

3 edits in trunk/Source/WebCore

[GStreamer] Switch the ImageDecoder to decodebin3
https://bugs.webkit.org/show_bug.cgi?id=218246

Reviewed by Xabier Rodriguez-Calvar.

Rely on the decodebin3 select-stream to ensure that at most one video stream is selected for
decoding. Thus we don't need to plug a fakesink to streams we don't need anymore.

platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::InnerDecoder::decodebinSelectStreamCallback):
(WebCore::ImageDecoderGStreamer::InnerDecoder::selectStream):
(WebCore::ImageDecoderGStreamer::InnerDecoder::connectDecoderPad):
(WebCore::ImageDecoderGStreamer::InnerDecoder::preparePipeline):

platform/graphics/gstreamer/ImageDecoderGStreamer.h:

12:27 AM Changeset in webkit [269838] by Fujii Hironori

2 edits in trunk/Source/WebCore

[WinCairo][GraphicsLayerTextureMapper] Support rounded rect clipping for backdrop-filter
https://bugs.webkit.org/show_bug.cgi?id=218962

Reviewed by Carlos Garcia Campos.

r269772 (Bug 215445) added rounded rect clipping support for
backdrop-filter for TextureMapper and CoordinatedGraphics. Add the
feature to GraphicsLayerTextureMapper.

Existing tests cover this change:
css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html
css3/filters/backdrop/backdrop-filter-with-border-radius-value-change.html
css3/filters/backdrop/backdrop-filter-with-border-radius

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::commitLayerChanges): Call setBackdropFiltersRect.

12:19 AM Changeset in webkit [269837] by Fujii Hironori

4 edits
1 add in trunk

[TextureMapper] The edges of blur backdrop-filter look gradient tranparent
https://bugs.webkit.org/show_bug.cgi?id=218645
<rdar://problem/71356999>

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The blur backdrop-filter needs a larger input image than an output
image. However, it's not easy to get a larger input image in the
edges of the windows. Cocoa port is doing extrapolation by
duplicating edges pixels of the input image which has the same
size with the output image (Bug 146215). Take the same approach.

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeOverlapRegions): Don't
inflate the local bounding rect by the outsets for backdrop
layers.

platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(sampleColorAtRadius): Don't clamp 'coord'.

LayoutTests:

platform/glib/css3/filters/backdrop/blur-input-bounds-expected.png: Added.

Nov 15, 2020:

8:53 PM Changeset in webkit [269836] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Integration] Disable modern line layout for fieldset children.
https://bugs.webkit.org/show_bug.cgi?id=218963

Reviewed by Sam Weinig.

Fieldsets don't follow the standard CSS box model. They require special handling.

layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

5:15 PM Changeset in webkit [269835] by Simon Fraser

5 edits in trunk/Source/WebCore

Minor RenderStyle boxShadow cleanup
https://bugs.webkit.org/show_bug.cgi?id=218952

Reviewed by Sam Weinig.

Rename getBoxShadowExtent() to boxShadowExtent() and have it return a LayoutBoxExtent.

Make shadow-related functions static that can be, and private that can be.

rendering/RenderBox.cpp:

(WebCore::RenderBox::applyVisualEffectOverflow const):

rendering/RenderElement.cpp:

(WebCore::RenderElement::repaintAfterLayoutIfNeeded):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::shadowExtent):
(WebCore::RenderStyle::shadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
(WebCore::RenderStyle::getShadowExtent const): Deleted.
(WebCore::RenderStyle::getShadowInsetExtent const): Deleted.
(WebCore::RenderStyle::getShadowHorizontalExtent const): Deleted.
(WebCore::RenderStyle::getShadowVerticalExtent const): Deleted.

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::boxShadowExtent const):
(WebCore::RenderStyle::boxShadowInsetExtent const):
(WebCore::RenderStyle::getBoxShadowExtent const): Deleted.
(WebCore::RenderStyle::getBoxShadowInsetExtent const): Deleted.

4:33 PM Changeset in webkit [269834] by weinig@apple.com

1 edit
1 delete in trunk/LayoutTests

Remove and re-add fast/forms/selection-direction.html without CRs
https://bugs.webkit.org/show_bug.cgi?id=218966

Reviewed by Darin Adler.

fast/forms/selection-direction.html: Removed.

Temporarily remove test. Will add back without CRs in next commit.

1:03 PM Changeset in webkit [269833] by Andres Gonzalez

2 edits in trunk/Source/WebCore

Fix for infinite recursion crash in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=218961

Reviewed by Chris Fleizach.

Covered by existing tests.

[WebAccessibilityObjectWrapper attachmentView] can cause the
initialization of a new AXIsolatedObject which in turn can invoke
indirectly AccessibilityObject::accessibilityIgnoreAttachment, thus
creating an infinite recursion. This change avoids this problem and
makes this method more efficient even in those cases where there was no
infinite recursion.

accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment const):

11:58 AM Changeset in webkit [269832] by ysuzuki@apple.com

7 edits in trunk

[JSC] Wasm should get byte length from source typed array
https://bugs.webkit.org/show_bug.cgi?id=218955

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

web-platform-tests/wasm/jsapi/constructor/validate.any-expected.txt:
web-platform-tests/wasm/jsapi/constructor/validate.any.worker-expected.txt:

Source/JavaScriptCore:

WebAssembly's module source should be read with byteLength instead of length of typed-array.

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::byteLength const):
(JSC::JSArrayBufferView::slowDownAndWasteMemory):

runtime/JSArrayBufferView.h:
wasm/js/JSWebAssemblyHelpers.h:

(JSC::getWasmBufferFromValue):

10:55 AM Changeset in webkit [269831] by commit-queue@webkit.org

26 edits
1 move
4 adds
9 deletes in trunk/JSTests

[JSC] Update wasm spec tests
https://bugs.webkit.org/show_bug.cgi?id=218940

Patch by Sergey Rubanov <Sergey Rubanov> on 2020-11-15
Reviewed by Yusuke Suzuki.

Spec test commit revision number: 5475b7015684a07ba69762f8438e3bcff2647686

wasm.yaml:
wasm/spec-tests/address.wast.js:
wasm/spec-tests/binary-leb128.wast.js:
wasm/spec-tests/binary.wast.js:
wasm/spec-tests/block.wast.js:
wasm/spec-tests/br.wast.js:
wasm/spec-tests/break-drop.wast.js: Removed.
wasm/spec-tests/call.wast.js:
wasm/spec-tests/call_indirect.wast.js:
wasm/spec-tests/const.wast.js:
wasm/spec-tests/conversions.wast.js:
wasm/spec-tests/custom_section.wast.js: Removed.
wasm/spec-tests/data.wast.js:
wasm/spec-tests/f32.wast.js:
wasm/spec-tests/f64.wast.js:
wasm/spec-tests/fac.wast.js:
wasm/spec-tests/float_exprs.wast.js:
wasm/spec-tests/float_misc.wast.js:
wasm/spec-tests/func.wast.js:
wasm/spec-tests/get_local.wast.js: Removed.
wasm/spec-tests/global.wast.js: Renamed from JSTests/wasm/spec-tests/globals.wast.js.
wasm/spec-tests/harness/async_index.js: Added.

(let.testNum):
(uniqueTest):
(assertThrows):
(binary):
(module):
(assert_invalid):
(instance):
(exports):
(reinitializeRegistry.get promise_test):
(reinitializeRegistry):
(catch):
(assert_exhaustion):
(get const):

wasm/spec-tests/harness/sync_index.js: Added.

(let.testNum):
(assertThrows):
(_assert):
(ValueResult):
(ErrorResult):
(Result.prototype.isError):
(reinitializeRegistry.let.handler.get return):
(binary):
(module):

wasm/spec-tests/i32.wast.js:
wasm/spec-tests/i64.wast.js:
wasm/spec-tests/if.wast.js:
wasm/spec-tests/imports.wast.js:
wasm/spec-tests/jsapi.js: Removed.
wasm/spec-tests/loop.wast.js:
wasm/spec-tests/memory.wast.js:
wasm/spec-tests/resizing.wast.js: Removed.
wasm/spec-tests/set_local.wast.js: Removed.
wasm/spec-tests/stack.wast.js:
wasm/spec-tests/store_retval.wast.js: Removed.
wasm/spec-tests/table.wast.js: Added.
wasm/spec-tests/tee_local.wast.js: Removed.
wasm/spec-tests/type.wast.js:
wasm/spec-tests/typecheck.wast.js: Removed.

9:59 AM Changeset in webkit [269830] by youenn@apple.com

18 edits
4 copies
7 adds in trunk

Add a WebRTC SFrame transform
https://bugs.webkit.org/show_bug.cgi?id=218752

Reviewed by Eric Carlson.

Source/WebCore:

Introduce a RTCRtpSFrameTransform that implements the SFrame format.
RTCRtpSFrameTransform is a RTCRtpTransform that can be set to RTCRtp sender and receiver objects.
API supports setting encryption key.
Minor refactoring to reuse WebCrypto routines for encryption/decryption.

Test: webrtc/audio-sframe.html

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/mediastream/RTCRtpSFrameTransform.cpp: Added.

(WebCore::RTCRtpSFrameTransform::RTCRtpSFrameTransform):
(WebCore::RTCRtpSFrameTransform::~RTCRtpSFrameTransform):
(WebCore::RTCRtpSFrameTransform::setEncryptionKey):
(WebCore::RTCRtpSFrameTransform::initializeTransformer):
(WebCore::RTCRtpSFrameTransform::initializeBackendForReceiver):
(WebCore::RTCRtpSFrameTransform::initializeBackendForSender):
(WebCore::RTCRtpSFrameTransform::willClearBackend):

Modules/mediastream/RTCRtpSFrameTransform.h: Added.
Modules/mediastream/RTCRtpSFrameTransform.idl: Added.
Modules/mediastream/RTCRtpSFrameTransformer.cpp: Added.

(WebCore::writeUInt64):
(WebCore::lengthOfUInt64):
(WebCore::computeFirstHeaderByte):
(WebCore::computeIV):
(WebCore::parseSFrameHeader):
(WebCore::RTCRtpSFrameTransformer::create):
(WebCore::RTCRtpSFrameTransformer::RTCRtpSFrameTransformer):
(WebCore::RTCRtpSFrameTransformer::~RTCRtpSFrameTransformer):
(WebCore::RTCRtpSFrameTransformer::setEncryptionKey):
(WebCore::RTCRtpSFrameTransformer::decryptFrame):
(WebCore::RTCRtpSFrameTransformer::encryptFrame):
(WebCore::RTCRtpSFrameTransformer::transform):
(WebCore::RTCRtpSFrameTransformer::computeSaltKey):
(WebCore::RTCRtpSFrameTransformer::computeAuthenticationKey):
(WebCore::RTCRtpSFrameTransformer::computeEncryptionKey):
(WebCore::RTCRtpSFrameTransformer::decryptData):
(WebCore::RTCRtpSFrameTransformer::encryptData):
(WebCore::RTCRtpSFrameTransformer::computeEncryptedDataSignature):

Modules/mediastream/RTCRtpSFrameTransformer.h: Added.

(WebCore::RTCRtpSFrameTransformer::setIsSending):
(WebCore::RTCRtpSFrameTransformer::setIsProcessingAudio):

Modules/mediastream/RTCRtpSFrameTransformerCocoa.cpp: Added.

(WebCore::deriveHDKFSHA256Bits):
(WebCore::transformAES_CTR):
(WebCore::RTCRtpSFrameTransformer::computeSaltKey):
(WebCore::RTCRtpSFrameTransformer::computeAuthenticationKey):
(WebCore::RTCRtpSFrameTransformer::computeEncryptionKey):
(WebCore::RTCRtpSFrameTransformer::decryptData):
(WebCore::RTCRtpSFrameTransformer::encryptData):
(WebCore::RTCRtpSFrameTransformer::computeEncryptedDataSignature):

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
WebCore.xcodeproj/project.pbxproj:
crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
(WebCore::transformAES_CTR): Deleted.

crypto/mac/CryptoAlgorithmHKDFMac.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

crypto/mac/CryptoUtilitiesCocoa.cpp: Added.

(WebCore::transformAES_CTR):
(WebCore::deriveHDKFSHA256Bits):

crypto/mac/CryptoUtilitiesCocoa.h: Added.
bindings/js/WebCoreBuiltinNames.h:

Tools:

Add unit tests that validate SFrame generation and parsing.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebCore/RTCRtpSFrameTransformerTests.cpp: Added.

(TestWebKitAPI::getRawKey):
(TestWebKitAPI::createVideoTransformer):
(TestWebKitAPI::checkVectorsAreEqual):
(TestWebKitAPI::TEST):

LayoutTests:

webrtc/audio-sframe-expected.txt: Added.
webrtc/audio-sframe.html: Added.

9:47 AM Changeset in webkit [269829] by youenn@apple.com

3 edits in trunk/Source/WebCore

AudioSampleDataSource::pullSamplesInternal does not need to pass its sampleCount parameter as in/out
https://bugs.webkit.org/show_bug.cgi?id=218899

Reviewed by Eric Carlson.

pullSamplesInternal sets sampleCount to zero in some cases where pullSamplesInternal returns false.
pullSamplesInternal callers do not use the sampleCount parameter if pullSamplesInternal returns false.
Pass sampleCount by value to clarify the behavior and remove setting sampleCount to zero in pullSamplesInternal return false case.

No change of behavior.

platform/audio/cocoa/AudioSampleDataSource.h:
platform/audio/cocoa/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pullSamplesInternal):

8:03 AM Changeset in webkit [269828] by Alan Bujtas

2 edits in trunk/Source/WebCore

"Typo" in r269821 (by std::numeric_limits<>::min I really meant std::numeric_limits<>::lowest (got tricked by the floating-point type behavior))

Unreviewed.

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically):

7:38 AM Changeset in webkit [269827] by Philippe Normand

7 edits
2 moves
1 add in trunk

[GStreamer] WebAudio to MediaStream support
https://bugs.webkit.org/show_bug.cgi?id=218335

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Provide audio samples coming from the WebAudio bus to the MediaStreamAudioSource node, using
GStreamer. This patch also moves a couple files from platform/mediastream to platform/audio,
because this is where the virtual parent classes are defined.

Modules/webaudio/MediaStreamAudioSource.cpp:
Modules/webaudio/MediaStreamAudioSource.h:
Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp: Added.

(WebCore::copyBusData):
(WebCore::MediaStreamAudioSource::consumeAudio):

platform/GStreamer.cmake:
platform/audio/gstreamer/GStreamerAudioData.h: Renamed from Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioData.h.

(isType):

platform/audio/gstreamer/GStreamerAudioStreamDescription.h: Renamed from Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioStreamDescription.h.
platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData):

LayoutTests:

platform/gtk/TestExpectations: webrtc/peer-connection-createMediaStreamDestination.html is now passing.

6:25 AM Changeset in webkit [269826] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] Do not use RenderStyle's logical margin API
https://bugs.webkit.org/show_bug.cgi?id=218948

Reviewed by Antti Koivisto.

https://www.w3.org/TR/css-writing-modes-4/#logical-direction-layout

"Flow-relative directions are calculated with respect to the writing mode of the containing block of the box
and used to abstract layout rules related to the box properties (margins, borders, padding)
and any properties related to positioning the box within its containing block
(float, clear, top, bottom, left, right, caption-side).
For inline-level boxes, the writing mode of the parent box is used instead."

RenderStyle::marginStart/End/Before/After flips these values based on the box's own writing mode.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::usedWritingMode):
(WebCore::Layout::FormattingContext::Geometry::computedHorizontalMargin const):
(WebCore::Layout::FormattingContext::Geometry::computedVerticalMargin const):

6:23 AM Changeset in webkit [269825] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][Geometry] Add support for horizontal/vertical scrollbar spacing
https://bugs.webkit.org/show_bug.cgi?id=218950

Reviewed by Antti Koivisto.

Let's make room for visible scrollbars between the border and the padding box.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):

layout/layouttree/LayoutBoxGeometry.cpp:

(WebCore::Layout::BoxGeometry::BoxGeometry):
(WebCore::Layout::BoxGeometry::paddingBox const):

layout/layouttree/LayoutBoxGeometry.h:

(WebCore::Layout::BoxGeometry::borderBoxHeight const):
(WebCore::Layout::BoxGeometry::borderBoxWidth const):
(WebCore::Layout::BoxGeometry::verticalScrollbarWidth const):
(WebCore::Layout::BoxGeometry::horizontalScrollbarHeight const):
(WebCore::Layout::BoxGeometry::setVerticalScrollbarWidth):
(WebCore::Layout::BoxGeometry::setHorizontalScrollbarHeight):

1:30 AM Changeset in webkit [269824] by timothy_horton@apple.com

27 edits in trunk/Source

Initial implementation of DOM rendering via the GPU process
https://bugs.webkit.org/show_bug.cgi?id=218928

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; will be covered by all existing DOM rendering tests in GPU process mode.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/ConcreteImageBuffer.h:
platform/graphics/ImageBuffer.h:
platform/graphics/ImageBufferBackend.h:

(WebCore::ImageBufferBackend::isInUse const):
(WebCore::ImageBufferBackend::releaseGraphicsContext):
(WebCore::ImageBufferBackend::setVolatile):
(WebCore::ImageBufferBackend::releaseBufferToPool):
(WebCore::ImageBufferBackend::createFlusher):

platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::takeSurface):
(WebCore::IOSurfacePool::markOlderSurfacesPurgeable):

platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ThreadSafeImageBufferFlusherCG::ThreadSafeImageBufferFlusherCG):
(WebCore::ImageBufferCGBackend::contextColorSpace):
(WebCore::ImageBufferCGBackend::setupContext const):
(WebCore::ImageBufferCGBackend::createFlusher):
(WebCore::ImageBufferCGBackend::setupContext): Deleted.

platform/graphics/cg/ImageBufferCGBackend.h:
platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::context const):
(WebCore::ImageBufferIOSurfaceBackend::isInUse const):
(WebCore::ImageBufferIOSurfaceBackend::releaseGraphicsContext):
(WebCore::ImageBufferIOSurfaceBackend::setVolatile):
(WebCore::ImageBufferIOSurfaceBackend::releaseBufferToPool):

platform/graphics/cg/ImageBufferIOSurfaceBackend.h:

Add isInUse, setVolatile, and releaseGraphicsContext to ImageBuffer,
to manage volatile surfaces; they're only implemented for in-process
IOSurface right now, in order to keep RemoteLayerBackingStore working
after transitioning it to ImageBuffer. A future patch will determine
how to implement this mechanism for remote IOSurfaces.

Add createFlusher to ImageBuffer, which returns an object that can
be tossed to a background queue, and has one method: flush(), which
blocks until the ImageBuffer's oustanding painting is flushed. This is
currently implemented for CG just by calling CGContextFlush. This
is used to abstract out RemoteLayerBackingStore's background-thread
flush of all surfaces.

platform/graphics/cocoa/IOSurface.h:
platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::state const):
(WebCore::IOSurface::setVolatile):
(WebCore::operator<<):
(WebCore::IOSurface::setIsVolatile): Deleted.
Make use of VolatilityState instead of SurfaceState.

Source/WebKit:

Shared/RemoteLayerTree/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::hasFrontBuffer const):
(WebKit::RemoteLayerBackingStore::Buffer::operator bool const):

Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::encode const):
(WebKit::RemoteLayerBackingStore::decode):
(WebKit::RemoteLayerBackingStore::pixelFormat const):
(WebKit::RemoteLayerBackingStore::bytesPerPixel const):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
(WebKit::RemoteLayerBackingStore::takePendingFlusher):
(WebKit::RemoteLayerBackingStore::setBufferVolatility):
(WebKit::RemoteLayerBackingStore::Buffer::discard):
(WebKit::RemoteLayerBackingStore::drawInContext): Deleted.
(WebKit::RemoteLayerBackingStore::takeFrontContextPendingFlush): Deleted.
(WebKit::RemoteLayerBackingStore::surfaceBufferFormat const): Deleted.
Reimplement RemoteLayerBackingStore in terms of ImageBuffer instead of
using ShareableBitmap + IOSurface explicitly.
We use ConcreteImageBuffer versions of the shareable backends in the WebContent process
in the non-GPU-process case, and normal DisplayList-backed RemoteImageBufferProxies
in the GPU process case.

UIProcess/ViewSnapshotStore.h:
UIProcess/mac/ViewSnapshotStoreMac.mm:

(WebKit::ViewSnapshot::setVolatile):
(WebKit::ViewSnapshot::asLayerContents):

WebProcess/GPU/graphics/ImageBufferBackendHandle.h:
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::ThreadSafeRemoteImageBufferFlusher::ThreadSafeRemoteImageBufferFlusher):
Add a hack to emulate ThreadSafeRemoteImageBufferFlusher; right now,
we'll synchronously flush on the main thread when creating the flusher;
a future patch will move this into the flush() method so that RemoteLayerBackingStore
can do it on a secondary queue.

(WebKit::RemoteImageBufferProxy::createImageBufferBackendHandle):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createImageBuffer const):
(WebKit::WebChromeClient::ensureRemoteRenderingBackendProxy const): Deleted.

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::ensureRemoteRenderingBackendProxy):

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::create):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::BackingStoreFlusher):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
Reimplement BackingStoreFlusher in terms of the abstract ThreadSafeImageBufferFlusher.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::ensureRemoteRenderingBackendProxy):

WebProcess/WebPage/WebPage.h:

Move RemoteRenderingBackendProxy from WebChromeClient to WebPage, so that
other non-WebCore clients can use it without having to think about WebChromeClient.

12:56 AM Changeset in webkit [269823] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Font::platformBoundsForGlyph() should provide a boundingRect pointer to CTFontGetBoundingRectsForGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=218812

Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2020-11-15
Reviewed by Ryosuke Niwa.

Provide a zero CGRect boundingRect pointer in two places where the count argument
to CTFontGetBoundingRectsForGlyphs() is already 1.

No new tests, no behavior changes.

platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::platformBoundsForGlyph const):
(WebCore::Font::isProbablyOnlyUsedToRenderIcons const):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed