⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 19, 2020:

11:15 PM Changeset in webkit [271011] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Move FrameLoader::arePluginsEnabled to Frame
​https://bugs.webkit.org/show_bug.cgi?id=220022

Patch by Rob Buis <​rbuis@igalia.com> on 2020-12-19
Reviewed by Sam Weinig.

Source/WebCore:

The arePluginsEnabled functionality is not tied
to FrameLoader, so move it to Frame to save
some indirections.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::rendererIsEverNeeded):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::arePluginsEnabled): Deleted.

  • loader/FrameLoader.h:
  • loader/SubframeLoader.cpp:

(WebCore::FrameLoader::SubframeLoader::requestPlugin):

  • page/Frame.cpp:

(WebCore::Frame::arePluginsEnabled):

  • page/Frame.h:

Source/WebKit:

Adapt to API change.

  • WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::pluginInfo):
(WebKit::WebPluginInfoProvider::populatePluginCache):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
(WebKit::WebPage::canShowMIMEType const):

Source/WebKitLegacy/mac:

Adapt to API change.

  • WebCoreSupport/WebPluginInfoProvider.mm:

(WebPluginInfoProvider::pluginInfo):

  • WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]):

Source/WebKitLegacy/win:

Adapt to API change.

  • WebView.cpp:

(WebView::canShowMIMEType):

8:17 PM Changeset in webkit [271010] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][Integration] Remove redundant InlineContent::InlineBox
​https://bugs.webkit.org/show_bug.cgi?id=220042
<rdar://problem/72511784>

Reviewed by Simon Fraser.

This is not used anymore since we've decided to turn everything into a run for integration.

  • layout/integration/LayoutIntegrationInlineContent.h:

(WebCore::LayoutIntegration::InlineContent::shrinkToFit):
(WebCore::LayoutIntegration::InlineContent::InlineBox::InlineBox): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::layoutBox const): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::lineIndex const): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::rect const): Deleted.

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayInlineBoxes const): Deleted.

  • layout/integration/LayoutIntegrationInlineContentBuilder.h:
4:11 PM Changeset in webkit [271009] by bshafiei@apple.com
  • 1 copy in tags/Safari-611.1.9.3

Tag Safari-611.1.9.3.

4:10 PM Changeset in webkit [271008] by bshafiei@apple.com
  • 1 copy in tags/Safari-611.1.9.2

Tag Safari-611.1.9.2.

4:06 PM Changeset in webkit [271007] by bshafiei@apple.com
  • 8 edits in branches/safari-611.1.9-branch/Source

Versioning.

WebKit-7611.1.9.3

4:05 PM Changeset in webkit [271006] by bshafiei@apple.com
  • 8 edits in branches/safari-611.1.9-branch/Source

Versioning.

WebKit-7611.1.9.2

4:03 PM Changeset in webkit [271005] by bshafiei@apple.com
  • 2 edits in branches/safari-611.1.9-branch/Source/WebKit

Cherry-pick r271004. rdar://problem/72508138

REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
​https://bugs.webkit.org/show_bug.cgi?id=220041
<rdar://problem/72508138>

Unreviewed build fix after r270575.

A closing parentheses was omitted when the 'play-audio' rule was changed to
remove its last rule.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@271004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:55 PM Changeset in webkit [271004] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
​https://bugs.webkit.org/show_bug.cgi?id=220041
<rdar://problem/72508138>

Unreviewed build fix after r270575.

A closing parentheses was omitted when the 'play-audio' rule was changed to
remove its last rule.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
2:10 PM Changeset in webkit [271003] by Alan Bujtas
  • 21 edits in trunk

width: max-content with box-sizing: border-box should leave space for padding (Twitter date hover overflow)
​https://bugs.webkit.org/show_bug.cgi?id=219687
<rdar://problem/72137685>

Reviewed by Antti Koivisto.

Source/WebCore:

Non-quantitative values such as auto and min-content are not influenced by the box-sizing property.
See http::www.w3.org/TR/css-sizing-3/#box-sizing
(adjustContentBoxLogicalWidthFor* now needs the property type too)

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing const):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):

  • rendering/RenderBox.h:

(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing const):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderFragmentContainer.cpp:

(WebCore::RenderFragmentContainer::computePreferredLogicalWidths):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeAutoRepeatTracksCount const):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
5:16 AM Changeset in webkit [271002] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligned atomic inline level boxes
​https://bugs.webkit.org/show_bug.cgi?id=219962

Reviewed by Antti Koivisto.

Let's estimate the logical top of simple atomic inline level boxes while they are being constructed. It helps to avoid the rather expensive
three-pass vertical alignment code (see computeLineBoxHeightAndAlignInlineLevelBoxesVertically) when the line has nothing but such simple boxes.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically): Deleted.

Dec 18, 2020:

9:41 PM Changeset in webkit [271001] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GPU process] Adding more tests to TestExpectations for Layout tests crashes
​https://bugs.webkit.org/show_bug.cgi?id=220035

Patch by Rini Patel <​rini_patel@apple.com> on 2020-12-18
Reviewed by Tim Horton.

  • gpu-process/TestExpectations:
8:30 PM Changeset in webkit [271000] by timothy_horton@apple.com
  • 8 edits in trunk

iOS wheel events don't work on many websites
​https://bugs.webkit.org/show_bug.cgi?id=220034

Reviewed by Simon Fraser.

Source/WebKit:

  • Shared/ios/WebIOSEventFactory.h:
  • Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebWheelEvent):
It turns out that many sites look at the legacy mousewheel event properties,
so compute wheelTicks in the same way that we do on macOS.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _scrollView:asynchronouslyHandleScrollEvent:completion:]):
If the UI process sends a wheel event with delta=0,0 to the Web Content
process, it will not be sent to the page, and thus not handled.
If this is the first event, it will prevent future events from
being cancelable.

Instead, synthetically defer the "Begin" phase to the first event in a
given gesture that has non-zero deltas, and just short-circuit any
zero-delta events entirely.

This way, WebCore can continue with its existing only-the-first-event-is-cancelable
logic, and we are assured that the first event that WebCore sees is also
the first event that the page sees, and is a Begin-phase event.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dispatchWheelEventWithoutScrolling):
wheelScrollGestureState isn't reset to nullopt until we send the
Begin-phase event to EventHandler, so we must make an exception for
the Begin-phase event, and explicitly make it cancelable. Otherwise,
the state of the previous gesture leaks into the new gesture. Existing
API tests caught this, I just apparently failed to run them after
adopting the shared wheelScrollGestureState().

Tools:

  • TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:

(TEST):
Add a test ensuring that if the UIScrollPhaseBegin scroll event
has zero delta, that we let a subsequent UIScrollPhaseChanged event
with non-zero delta cancel the gesture's default action.

6:01 PM Changeset in webkit [270999] by Said Abou-Hallawa
  • 2 edits in trunk/Tools

Upgrade motionmark1.1.plan to r270959
​https://bugs.webkit.org/show_bug.cgi?id=220016

Reviewed by Alexey Proskuryakov.

r270959 increases the warm-up time to 1000ms. This should fix a bi-
modality problem in the score of Images and Multiply sub-tests.

  • Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan:
5:02 PM Changeset in webkit [270998] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Fix some issues with PDFs as <object>.
​https://bugs.webkit.org/show_bug.cgi?id=220024

Reviewed by Tim Horton.

No new tests (Unable to write automated tests)

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::dataProviderGetBytesAtPositionCallback):
(WebKit::PDFPlugin::getResourceBytesAtPosition): Set the correct URL.
(WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData): Try harder to catch mismatches in delivered bytes vs expected bytes.

4:39 PM Changeset in webkit [270997] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit

WKProcessPool enhancements for URL schemes
​https://bugs.webkit.org/show_bug.cgi?id=220030

Reviewed by Brian Weinstein.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _registerURLSchemeAsSecure:]):
Added, equivalent to WKContextRegisterURLSchemeAsSecure().

(-[WKProcessPool _registerURLSchemeAsBypassingContentSecurityPolicy:]):
Added, equivalent to WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy().

(-[WKProcessPool _setDomainRelaxationForbiddenForURLScheme:]):
Added, equivalent to WKContextSetDomainRelaxationForbiddenForURLScheme().

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
4:16 PM Changeset in webkit [270996] by BJ Burg
  • 4 edits in trunk/Source/WebKit

[Cocoa] Web Inspector: clean up _WKRemoteWebInspectorViewController
​https://bugs.webkit.org/show_bug.cgi?id=219963

Reviewed by Devin Rousso.

Remove deprecated and unused debuggableType-based SPI to load the frontend.

  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewControllerPrivate.h:

Promote the _WKInspectorDebuggableInfo-based SPI to the main header.
Fix availability annotations. This class has never worked on iOS.
Add TBA annotations for things added since the Big Sur SDK was finalized.

  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(legacyDebuggableTypeToModernDebuggableType): Deleted.
(-[_WKRemoteWebInspectorViewController loadForDebuggableType:backendCommandsURL:]): Deleted.

4:11 PM Changeset in webkit [270995] by Kate Cheney
  • 2 edits in trunk/Source/WebCore

Login flows on sites with ITP quirks no longer work with ITP disabled
​https://bugs.webkit.org/show_bug.cgi?id=220019
<rdar://problem/72472858>

Reviewed by Darin Adler.

We should add a check for ITP enabled before attempting to apply quirks,
otherwise the quirks will commandeer the login process, fail (because
no ITP), and thus result in an inability to login when ITP is disabled.

No new tests, this will fix login flows on sites with ITP quirks when
ITP is turned off. I confirmed these cases manually.

  • page/Quirks.cpp:

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

4:10 PM Changeset in webkit [270994] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r270983. rdar://problem/72484021

Crash in DOMSelection::getRangeAt()
​https://bugs.webkit.org/show_bug.cgi?id=219804

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2020-12-18
Reviewed by Darin Adler.

Add a check in HTMLTextFormControlElement::setSelectionRange()
that ensures we do not try to move the frame's selection
if the HTMLTextFormControlElement is no longer connected.

  • html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionRange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@270983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:59 PM Changeset in webkit [270993] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix after r270988.
​https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>

Not reviewed.

3:45 PM Changeset in webkit [270992] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

REGRESSION(iOS 14): http/tests/cache-storage/page-cache-domcache-pending-promise.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217408

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations: Add DumpJSConsoleLogInStdErr since it was errantly removed in r268078.
3:14 PM Changeset in webkit [270991] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CachedRefPtr should adoptRef before calling ref to appease RefCounted's debug assertions
​https://bugs.webkit.org/show_bug.cgi?id=219953
<rdar://problem/72391255>

Reviewed by Tadeu Zagallo.

  • runtime/CachedTypes.cpp:

(JSC::CachedRefPtr::decode const):

2:27 PM Changeset in webkit [270990] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Line snapping fails when the content is taller than the page.
​https://bugs.webkit.org/show_bug.cgi?id=220020
<rdar://problem/68761119>

Reviewed by Antti Koivisto.

When the snapped position of the current line falls off of the page, we call lineSnapAdjustment() recursively to figure out the snapped position on the next page.
We usually find the final position on the next page mostly slightly below the logical top.
However when the line is taller than the page itself, it does not fit the next page or any of the following pages (assuming uniform page height).

Let the line overflow when the pages can't accommodate it.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineSnapAdjustment const):

2:17 PM Changeset in webkit [270989] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Use EGL_PLATFORM_ANGLE_TYPE_METAL_ANGLE now it is in the build
​https://bugs.webkit.org/show_bug.cgi?id=219968
<rdar://problem/72405724>

Reviewed by Darin Adler.

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::InitializeEGLDisplay): Use the named value.

1:42 PM Changeset in webkit [270988] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix MacroAssemblerARM64E::validateUntaggedPtr() to account for TBI.
​https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>

Reviewed by Saam Barati.

  • assembler/AbstractMacroAssembler.h:
  • assembler/DisallowMacroScratchRegisterUsage.h:
  • templatized the DisallowMacroScratchRegisterUsage class so that we can #include it in MacroAssembler implementations.
  • assembler/MacroAssemblerARM64E.h:

(JSC::MacroAssemblerARM64E::validateUntaggedPtr):

1:10 PM Changeset in webkit [270987] by Peng Liu
  • 11 edits in trunk

[Media in GPU Process][MSE] SourceBufferPrivateRemote needs to override some track buffer related functions of SourceBufferPrivate
​https://bugs.webkit.org/show_bug.cgi?id=219998

Reviewed by Jer Noble.

Source/WebCore:

No new tests, fix layout test failures.

  • platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setTimestampOffset):
(WebCore::SourceBufferPrivate::setAppendWindowStart):
(WebCore::SourceBufferPrivate::setAppendWindowEnd):
(WebCore::SourceBufferPrivate::hasVideo const):
(WebCore::SourceBufferPrivate::timestampOffset const):
Change these functions to virtual because SourceBufferPrivateRemote needs to override them.

Source/WebKit:

Implement some track buffer related functions of SourceBufferPrivateRemote with new IPC messages.

  • GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::resetTrackBuffers):
(WebKit::RemoteSourceBufferProxy::clearTrackBuffers):
(WebKit::RemoteSourceBufferProxy::resetTimestampOffsetInTrackBuffers):
(WebKit::RemoteSourceBufferProxy::setTimestampOffset):
(WebKit::RemoteSourceBufferProxy::setAppendWindowStart):
(WebKit::RemoteSourceBufferProxy::setAppendWindowEnd):
(WebKit::RemoteSourceBufferProxy::updateTrackIds):

  • GPUProcess/media/RemoteSourceBufferProxy.h:
  • GPUProcess/media/RemoteSourceBufferProxy.messages.in:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::addRemoteAudioTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteTextTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteVideoTrack):
MediaSource manages the track information for the MSE media player, so we should not call
MediaPlayer::addAudioTrack(), MediaPlayer::addTextTrack() and MediaPlayer::addVideoTrack().

  • WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::resetTrackBuffers):
(WebKit::SourceBufferPrivateRemote::clearTrackBuffers):
(WebKit::SourceBufferPrivateRemote::resetTimestampOffsetInTrackBuffers):
(WebKit::SourceBufferPrivateRemote::setTimestampOffset):
(WebKit::SourceBufferPrivateRemote::setAppendWindowStart):
(WebKit::SourceBufferPrivateRemote::setAppendWindowEnd):
(WebKit::SourceBufferPrivateRemote::updateTrackIds):

  • WebProcess/GPU/media/SourceBufferPrivateRemote.h:

LayoutTests:

  • gpu-process/TestExpectations:
12:32 PM Changeset in webkit [270986] by sihui_liu@apple.com
  • 9 edits in trunk/Source

SpeechRecognitionRemoteRealtimeMediaSourceManager should not issue sandbox extension for mocked devices
​https://bugs.webkit.org/show_bug.cgi?id=219972

Reviewed by Eric Carlson.

Source/WebCore:

  • platform/mediastream/CaptureDevice.h:

(WebCore::CaptureDevice::isMockDevice const): Add a member in CaptureDevice to indicate if it's mocked device.
(WebCore::CaptureDevice::setIsMockDevice):
(WebCore::CaptureDevice::encode const):
(WebCore::CaptureDevice::decode):

  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::toCaptureDevice):

Source/WebKit:

  • UIProcess/SpeechRecognitionPermissionManager.cpp:

(WebKit::SpeechRecognitionPermissionManager::startProcessingRequest): We need to sync the preference not only
on when mockCaptureDevicesEnabled is set, but also when it is unset.

  • UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp:

(WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::addSource): Grant sandbox extensions to web process
when the first source that uses a real device is created.
(WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::removeSource): Revoke sandbox extensions from web
process when the last source that uses a real device is delete.

  • UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.h:
  • UIProcess/SpeechRecognitionServer.cpp: Correct a typo.

(WebKit::SpeechRecognitionServer::SpeechRecognitionServer):

  • UIProcess/SpeechRecognitionServer.h: Correct a typo
11:43 AM Changeset in webkit [270985] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/ThirdParty/libwebrtc

Cherry-pick r270895. rdar://problem/72474836

Cherry-pick usrsctp 355fb576b1a9dfef70fc0e158d66692662baaddc
​https://bugs.webkit.org/show_bug.cgi?id=219937

Reviewed by Alex Christensen.

  • Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c: (sctp_process_cookie_existing):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@270895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:42 AM Changeset in webkit [270984] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/ThirdParty/libwebrtc

Cherry-pick r270894. rdar://problem/72474831

Cherry-pick usrsctp 7dab23aa0d8db86fedd222a308067439b03fad0f
​https://bugs.webkit.org/show_bug.cgi?id=219936
<rdar://problem/72304588>

Reviewed by Alex Christensen.

  • Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c: (sctp_process_cookie_existing):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@270894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:34 AM Changeset in webkit [270983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in DOMSelection::getRangeAt()
​https://bugs.webkit.org/show_bug.cgi?id=219804

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2020-12-18
Reviewed by Darin Adler.

Add a check in HTMLTextFormControlElement::setSelectionRange()
that ensures we do not try to move the frame's selection
if the HTMLTextFormControlElement is no longer connected.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange):

11:32 AM Changeset in webkit [270982] by Russell Epstein
  • 1 copy in tags/Safari-611.1.9.1.1

Tag Safari-611.1.9.1.1.

11:25 AM Changeset in webkit [270981] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add tagging to JIT probe's return address.
​https://bugs.webkit.org/show_bug.cgi?id=220008
rdar://71279530

Reviewed by Keith Miller and Robin Morisset.

  • assembler/MacroAssemblerARM64.cpp:
  • assembler/testmasm.cpp:

(JSC::testProbeModifiesProgramCounter):

  • runtime/JSCPtrTag.h:
11:16 AM Changeset in webkit [270980] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

REGRESSION (r270938): ASSERTION FAILED: !m_renderThread in WebKit::RemoteAudioDestinationProxy::startRenderingThread
​https://bugs.webkit.org/show_bug.cgi?id=220017
<rdar://problem/72470176>

Reviewed by Darin Adler.

In case of a GPU process crash, we call stopRenderingThread() and then connectToGPUProcess() which
calls startRenderingThread(). We were hitting an assertion in startRenderingThread() making sure
that m_renderThread is null because stopRenderingThread() was failing to set it to null after
stopping the thread.

No new tests, covered by existing failing API test.

  • WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::stopRenderingThread):

11:11 AM Changeset in webkit [270979] by Russell Epstein
  • 8 edits in branches/safari-611.1.9-branch/Source

Versioning.

WebKit-7611.1.9.1.1

11:05 AM Changeset in webkit [270978] by Russell Epstein
  • 1 copy in tags/Safari-611.1.9.1

Tag Safari-611.1.9.1.

11:02 AM Changeset in webkit [270977] by Russell Epstein
  • 4 edits in branches/safari-611.1.9-branch

Cherry-pick r270962. rdar://problem/72472070

REGRESSION(r270638) decidePolicyForNewWindowAction should have non-null request
​https://bugs.webkit.org/show_bug.cgi?id=220001
Source/WebKit:

<rdar://72436824>

Reviewed by Tim Horton.

A ResourceRequest was used after being moved in the super old C SPI that we need to remove,
but to keep our client functioning correctly until they do we copy the ResourceRequest instead of moving it.
Covered by an API test.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNewWindowAction):

Tools:

Reviewed by Tim Horton.

  • TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@270962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:30 AM Changeset in webkit [270976] by Russell Epstein
  • 1 copy in tags/Safari-611.1.9.0.1

Tag Safari-611.1.9.0.1.

10:27 AM Changeset in webkit [270975] by Russell Epstein
  • 1 delete in tags/Safari-611.1.9.0.1

Delete tag.

10:25 AM Changeset in webkit [270974] by Megan Gardner
  • 24 edits in trunk/Source

Gate all of the code associated with app highlights
​https://bugs.webkit.org/show_bug.cgi?id=220003
Source/WebCore:

<rdar://problem/72451893>

Reviewed by Tim Horton.

Only gating code, no new tests needed.

  • Modules/highlight/AppHighlightListData.cpp:
  • Modules/highlight/AppHighlightListData.h:
  • Modules/highlight/AppHighlightStorage.cpp:
  • Modules/highlight/AppHighlightStorage.h:
  • Modules/highlight/HighlightRegister.cpp:
  • Modules/highlight/HighlightRegister.h:
  • dom/Document.cpp:

(WebCore::Document::commonTeardown):
(WebCore::Document::updateHighlightPositions):

  • dom/Document.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

  • platform/ContextMenuItem.cpp:

(WebCore::isValidContextMenuAction):

  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/cocoa/LocalizedStringsCocoa.mm:
  • rendering/RenderTheme.h:

Source/WebKit:

<rdar://problem/72451893>

Reviewed by Tim Horton.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

  • Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultAppHighlightsEnabled):

  • Shared/WebPreferencesDefaultValues.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):

Source/WebKitLegacy/mac:

<rdar://problem/72451893>

Reviewed by Tim Horton.

  • WebView/WebHTMLView.mm:

(toTag):

Source/WTF:

Reviewed by Tim Horton.

  • Scripts/Preferences/WebPreferencesInternal.yaml:
10:23 AM Changeset in webkit [270973] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[Mojave] webanimations/accelerated-transform-related-animation-property-order.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=220018

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Mark test as failing.
10:23 AM Changeset in webkit [270972] by Russell Epstein
  • 8 edits in branches/safari-611.1.9-branch/Source

Versioning.

WebKit-7611.1.9.1

10:21 AM Changeset in webkit [270971] by Russell Epstein
  • 1 copy in tags/Safari-611.1.9.0.1

Tag Safari-611.1.9.0.1.

10:11 AM Changeset in webkit [270970] by Russell Epstein
  • 8 edits in branches/safari-611.1.9-branch/Source

Versioning.

WebKit-7611.1.9.0.1

9:23 AM Changeset in webkit [270969] by Chris Dumez
  • 9 edits in trunk/Source

[iOS] Stop leaking an XPC boost message to XPC services
​https://bugs.webkit.org/show_bug.cgi?id=219453

Reviewed by Geoff Garen.

Source/WebKit:

Stop leaking an XPC boost message to XPC services on builds where RunningBoard is able to give the right
priorities to our XPC services based on the type of RunningBoard assertion is being held. There is no
behavior change for the Network/WebContent processes since those were blocklisted in RunningBoard (Turning
on the RB_full_manage_WK_jetsam feature flag gives us the default RunningBoard behavior without
blocklisting). However, this allows the new GPUProcess to move to IDLE jetsam band when homing out of
MobileSafari, which makes the GPUProcess eligible for the freezer. Previously, the leaked boost message
would keep the GPUProcess in a higher jetsam band.

  • FeatureFlags/WebKit.plist:

Add RB_full_manage_WK_jetsam feature flag and turn it on. On recent enough builds of RunningBoard, this
disables the blocklisting of the WebContent/Network processes in RunningBoard so that RunningBoard can now
set the priority of those processes (instead of us boosting our priority via boost messages).

  • GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:
  • NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist:
  • WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist:
  • WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

Set _ProcessType=App so that RunningBoard is able to set the priority of our XPC services on iOS. Without
this change, we get a permission denied when RunningBoard attempts to set the priority of our XPC services.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::shouldLeakBoost):
Stop leaking a boost message on iOS when RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT compile-time flag is enabled
and when the RB_full_manage_WK_jetsam feature flag is enabled.

Source/WTF:

Add new RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT build time flag since we need a recent
enough build of RunningBoard to do this.

  • wtf/PlatformHave.h:
5:29 AM Changeset in webkit [270968] by Lauro Moura
  • 2 edits in trunk/Source/WebCore

[WPE] Unreviewed buildfix after r270964

  • platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:
2:27 AM Changeset in webkit [270967] by ysuzuki@apple.com
  • 6 edits in trunk/Source

[CSSJIT] Do not use trampoline if JITCage is disabled
​https://bugs.webkit.org/show_bug.cgi?id=220004

Reviewed by Tadeu Zagallo.

Source/JavaScriptCore:

  • llint/LLIntData.cpp:
  • llint/LowLevelInterpreter.asm:

Source/WebCore:

This trampoline is not necessary if JITCage is not enabled.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateReturn):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

  • cssjit/SelectorCompiler.h:

(WebCore::SelectorCompiler::ruleCollectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::querySelectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::ruleCollectorSelectorCheckerWithCheckingContext):
(WebCore::SelectorCompiler::querySelectorSelectorCheckerWithCheckingContext):

2:09 AM Changeset in webkit [270966] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/JSTests

[WASM-References] Add reference spec tests for table instructions
​https://bugs.webkit.org/show_bug.cgi?id=220005

Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-18
Reviewed by Yusuke Suzuki.

These are reference types spec tests that we've already supported.
It help us prevent future inconsistencies with the proposal:
​https://github.com/WebAssembly/reference-types/tree/master/test/core

  • wasm.yaml:
  • wasm/references-spec-tests/table-sub.wast.js: Added.
  • wasm/references-spec-tests/table_get.wast.js: Added.
  • wasm/references-spec-tests/table_set.wast.js: Added.
  • wasm/references-spec-tests/table_size.wast.js: Added.
1:59 AM Changeset in webkit [270965] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[WASM-References] Reuse instance initElementSegment to reduce duplication
​https://bugs.webkit.org/show_bug.cgi?id=220007

Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-18
Reviewed by Yusuke Suzuki.

Simple refactroing. We need only one place to initialize elements
segments.

  • wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::evaluate):

Note: See TracTimeline for information about the timeline view.