Timeline
Dec 20, 2020:
- 8:07 PM Changeset in webkit [271019] by
-
- 4 edits in trunk/Source/WebCore
Rename FrameView::sendResizeEventIfNeeded() to scheduleResizeEventIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=220050
Reviewed by Ryosuke Niwa.
FrameView::sendResizeEventIfNeeded() only schedules events, it does not send them,
so rename accordingly.
Also fix some logging.
- dom/Document.cpp:
(WebCore::Document::runResizeSteps):
(WebCore::Document::runScrollSteps):
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::scheduleResizeEventIfNeeded):
(WebCore::FrameView::setCustomSizeForResizeEvent):
(WebCore::FrameView::sendResizeEventIfNeeded): Deleted.
- page/FrameView.h:
- 6:23 PM Changeset in webkit [271018] by
-
- 2 edits in trunk/Tools
Fix the lldb WebCoreColorProvider
https://bugs.webkit.org/show_bug.cgi?id=220049
Reviewed by Sam Weinig.
Fix the lldb color provider after Color internals where shifted around.
- lldb/lldb_webkit.py:
(WebCoreColorProvider.to_string):
- 3:15 PM Changeset in webkit [271017] by
-
- 9 edits in trunk/Source
Unreviewed, reverting r270969.
Regressed MotionMark with GPUProcess enabled
Reverted changeset:
"[iOS] Stop leaking an XPC boost message to XPC services"
https://bugs.webkit.org/show_bug.cgi?id=219453
https://trac.webkit.org/changeset/270969
- 12:16 PM Changeset in webkit [271016] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed typo fix of r271015
https://bugs.webkit.org/show_bug.cgi?id=220000
<rdar://problem/72531245>
Reviewed by Kenneth Russell.
- platform/graphics/win/PlatformDisplayWin.cpp:
(WebCore::PlatformDisplayWin::initializeEGLDisplay): Fixed a typo 'attributs'.
- 12:09 PM Changeset in webkit [271015] by
-
- 5 edits1 add in trunk
[WinCairo][WebGL] webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug builds
https://bugs.webkit.org/show_bug.cgi?id=220000
Reviewed by Kenneth Russell.
Source/WebCore:
Some WebGL tests were failing only in debug builds. Those test
cases expect black transparent for uninitialized buffers. ANGLE
enables debug layers as default only for debug builds. And it
fills uninitialized buffers with kDebugColorInitClearValue instead
of black transparent.
Create a PlatformDisplay with explicitly disabling debug layers by
using EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE.
- PlatformWinCairo.cmake:
- platform/graphics/win/PlatformDisplayWin.cpp: Added.
(WebCore::PlatformDisplayWin::initializeEGLDisplay):
- platform/graphics/win/PlatformDisplayWin.h:
LayoutTests:
- platform/wincairo/TestExpectations:
- 10:56 AM Changeset in webkit [271014] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Let's create the run and update the box geometry in one go for atomic inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=220045
Reviewed by Antti Koivisto.
Let's not run the "same" loop twice on atomic inline level boxes (first when we create the line run and the second time we
we update the associated the box geometry). Unfortunately we still have to run a second pass on the inline boxes (e.g <span>) as
they behave as containers (there's room for improvement here too).
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::addInlineLevelBox):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::hasInlineBox const):
- 8:29 AM Changeset in webkit [271013] by
-
- 14 edits in trunk/Source
Convert remaining FrameLoaderType enums to enum classes
https://bugs.webkit.org/show_bug.cgi?id=219898
Patch by Rob Buis <rbuis@igalia.com> on 2020-12-20
Reviewed by Sam Weinig.
Source/WebCore:
Convert remaining FrameLoaderType enums to enum classes.
Not converted is ShouldReplaceDocumentIfJavaScriptURL
since it should be removed eventually.
- dom/Document.cpp:
(WebCore::Document::open):
- history/BackForwardCache.cpp:
(WebCore::canCacheFrame):
(WebCore::firePageHideEventRecursively):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::isLoadingInAPISense const):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::initForSynthesizedDocument):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::activeDocumentLoader const):
(WebCore::FrameLoader::setState):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):
(WebCore::FrameLoader::shouldSuppressTextInputFromEditing const):
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h:
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::schedule):
- loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::loadSubframe):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- page/FrameView.cpp:
(WebCore::FrameView::shouldSuspendScrollAnimations const):
Source/WebKit:
Adapt to enum class changes.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetFrameLoadState):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
- 7:11 AM Changeset in webkit [271012] by
-
- 13 edits in trunk/Source/WebCore
[LFC] Move content height logic to the formatting contexts.
https://bugs.webkit.org/show_bug.cgi?id=220040
Reviewed by Simon Fraser.
Formatting contexts know about their content height.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::usedContentHeight const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/flexformatting/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::usedContentHeight const):
- layout/flexformatting/FlexFormattingContext.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::usedContentHeight const):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::usedContentHeight const):
- layout/tableformatting/TableFormattingContext.h:
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):
Dec 19, 2020:
- 11:15 PM Changeset in webkit [271011] by
-
- 17 edits in trunk/Source
Move FrameLoader::arePluginsEnabled to Frame
https://bugs.webkit.org/show_bug.cgi?id=220022
Patch by Rob Buis <rbuis@igalia.com> on 2020-12-19
Reviewed by Sam Weinig.
Source/WebCore:
The arePluginsEnabled functionality is not tied
to FrameLoader, so move it to Frame to save
some indirections.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsEverNeeded):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::arePluginsEnabled): Deleted.
- loader/FrameLoader.h:
- loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::requestPlugin):
- page/Frame.cpp:
(WebCore::Frame::arePluginsEnabled):
- page/Frame.h:
Source/WebKit:
Adapt to API change.
- WebProcess/Plugins/WebPluginInfoProvider.cpp:
(WebKit::WebPluginInfoProvider::pluginInfo):
(WebKit::WebPluginInfoProvider::populatePluginCache):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
(WebKit::WebPage::canShowMIMEType const):
Source/WebKitLegacy/mac:
Adapt to API change.
- WebCoreSupport/WebPluginInfoProvider.mm:
(WebPluginInfoProvider::pluginInfo):
- WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]):
Source/WebKitLegacy/win:
Adapt to API change.
- WebView.cpp:
(WebView::canShowMIMEType):
- 8:17 PM Changeset in webkit [271010] by
-
- 4 edits in trunk/Source/WebCore
[LFC][Integration] Remove redundant InlineContent::InlineBox
https://bugs.webkit.org/show_bug.cgi?id=220042
<rdar://problem/72511784>
Reviewed by Simon Fraser.
This is not used anymore since we've decided to turn everything into a run for integration.
- layout/integration/LayoutIntegrationInlineContent.h:
(WebCore::LayoutIntegration::InlineContent::shrinkToFit):
(WebCore::LayoutIntegration::InlineContent::InlineBox::InlineBox): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::layoutBox const): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::lineIndex const): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::rect const): Deleted.
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayInlineBoxes const): Deleted.
- layout/integration/LayoutIntegrationInlineContentBuilder.h:
- 4:11 PM Changeset in webkit [271009] by
-
- 1 copy in tags/Safari-611.1.9.3
Tag Safari-611.1.9.3.
- 4:10 PM Changeset in webkit [271008] by
-
- 1 copy in tags/Safari-611.1.9.2
Tag Safari-611.1.9.2.
- 4:06 PM Changeset in webkit [271007] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.3
- 4:05 PM Changeset in webkit [271006] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.2
- 4:03 PM Changeset in webkit [271005] by
-
- 2 edits in branches/safari-611.1.9-branch/Source/WebKit
Cherry-pick r271004. rdar://problem/72508138
REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
https://bugs.webkit.org/show_bug.cgi?id=220041
<rdar://problem/72508138>
Unreviewed build fix after r270575.
A closing parentheses was omitted when the 'play-audio' rule was changed to
remove its last rule.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:55 PM Changeset in webkit [271004] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
https://bugs.webkit.org/show_bug.cgi?id=220041
<rdar://problem/72508138>
Unreviewed build fix after r270575.
A closing parentheses was omitted when the 'play-audio' rule was changed to
remove its last rule.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- 2:10 PM Changeset in webkit [271003] by
-
- 21 edits in trunk
width: max-content with box-sizing: border-box should leave space for padding (Twitter date hover overflow)
https://bugs.webkit.org/show_bug.cgi?id=219687
<rdar://problem/72137685>
Reviewed by Antti Koivisto.
Source/WebCore:
Non-quantitative values such as auto and min-content are not influenced by the box-sizing property.
See http::www.w3.org/TR/css-sizing-3/#box-sizing
(adjustContentBoxLogicalWidthFor* now needs the property type too)
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing const):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
- rendering/RenderBox.h:
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing const):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
- rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::computePreferredLogicalWidths):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeAutoRepeatTracksCount const):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
- rendering/RenderMenuList.cpp:
(RenderMenuList::computePreferredLogicalWidths):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computePreferredLogicalWidths):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computePreferredLogicalWidths):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 5:16 AM Changeset in webkit [271002] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligned atomic inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=219962
Reviewed by Antti Koivisto.
Let's estimate the logical top of simple atomic inline level boxes while they are being constructed. It helps to avoid the rather expensive
three-pass vertical alignment code (see computeLineBoxHeightAndAlignInlineLevelBoxesVertically) when the line has nothing but such simple boxes.
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically): Deleted.
