Timeline

Dec 23, 2020:

5:01 PM Changeset in webkit [271081] by Simon Fraser

• 11 edits in trunk/Source/WebCore

Clean up some code related to scroll pinning
​https://bugs.webkit.org/show_bug.cgi?id=220128

Reviewed by Sam Weinig.

ScrollAnimatorMac and ScrollingTreeScrollingNodeDelegateMac share a lot of similar code
related to being "pinned" to an edge for scrolling (i.e. already scrolled to an edge).

There are too many functions implementing similar functionality in slightly different
ways. Reduce this count by one by rewriting isAlreadyPinnedInDirectionOfGesture()
and calling it from isPinnedForScrollDelta().

Rename bool pinnedInDirection() to isPinnedForScrollDelta().

Make use of wheelEvent.isGestureStart().

• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::isPinnedForScrollDeltaOnAxis const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::isPinnedForScrollDelta const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::isAlreadyPinnedInDirectionOfGesture const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::pinnedInDirection const): Deleted.

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::isPinnedForScrollDeltaOnAxis const):
(WebCore::ScrollableArea::isPinnedForScrollDelta const):
(WebCore::ScrollableArea::isPinnedInBothDirections const): Deleted.
(WebCore::ScrollableArea::isPinnedHorizontallyInDirection const): Deleted.
(WebCore::ScrollableArea::isPinnedVerticallyInDirection const): Deleted.

• platform/ScrollableArea.h:

(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition const): Deleted.
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition const): Deleted.
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition const): Deleted.
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition const): Deleted.

• platform/cocoa/ScrollController.h:
• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):

• platform/ios/ScrollAnimatorIOS.mm:

(WebCore::ScrollAnimatorIOS::determineScrollableAreaForTouchSequence):

• platform/mac/ScrollAnimatorMac.h:
• platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::isPinnedForScrollDelta const):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching const):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching const):
(WebCore::ScrollAnimatorMac::pinnedInDirection const): Deleted.
(WebCore::newGestureIsStarting): Deleted.
(WebCore::ScrollAnimatorMac::isAlreadyPinnedInDirectionOfGesture const): Deleted.

• platform/mock/ScrollAnimatorMock.h:

5:00 PM Changeset in webkit [271080] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] Metal backend renders tdl.js samples as red
​https://bugs.webkit.org/show_bug.cgi?id=220129

Patch by Kyle Piddington <Kyle Piddington> on 2020-12-23
Reviewed by Kenneth Russell.

• src/libANGLE/renderer/metal/FrameBufferMtl.mm:

(rx::FramebufferMtl::blitWithDraw):

1:57 PM Changeset in webkit [271079] by Said Abou-Hallawa

• 8 edits in trunk/Source

[GPU Process]: Don't call flushDrawingContext() in the middle of recording drawing commands
​https://bugs.webkit.org/show_bug.cgi?id=220126

Reviewed by Simon Fraser.

Source/WebCore:

Avoid calling flushDrawingContext() except when the drawing is finished
and the backend of the ImageBuffer is about to be used.

Rename flushDrawingContextAndCommit() to flushDrawingContextAsync(). The
difference between flushDrawingContext() and flushDrawingContextAsync()
is the former waits for the flush reply message.

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::prepareForDisplay):

• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::flushDrawingContextAsync):
(WebCore::ImageBuffer::flushDrawingContextAndCommit): Deleted.

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawImageBuffer):
(WebCore::DisplayList::Recorder::didAppendItemOfType): Deleted.

• platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::willAppendItemOfType):
(WebCore::DisplayList::Recorder::append):
(WebCore::DisplayList::Recorder::Delegate::didAppendItemOfType): Deleted.

Source/WebKit:

There is no need to replay back the DrawImageBuffer immediately after it
was recorded. The worry was the source ImageBuffer may change before
replaying back the DrawImageBuffer into the destination ImageBuffer. But
this should not happen with the shared memory buffer because the order
of drawing among multiple ImageBuffer is preserved.

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::display):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

1:27 PM Changeset in webkit [271078] by Peng Liu

• 14 edits in trunk/Source

[Media in GPU Process][MSE] Clean up SourceBufferPrivateRemote and implement functions with new IPC messages
​https://bugs.webkit.org/show_bug.cgi?id=220122

Reviewed by Eric Carlson.

Source/WebCore:

Currently, SourceBuffer needs to get the highestPresentationTimestamp from SourceBufferPrivate, which
is hard to implement synchronously when SourceBufferPrivate runs in a different process (e.g., GPU process).
This patch makes SourceBufferPrivate push highestPresentationTimestamp to SourceBuffer when its value
is changed.

This patch also changes some functions of SourceBufferPrivate to virtual so that we can override them
in SourceBufferPrivateRemote.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::highestPresentationTimestamp const):
(WebCore::SourceBuffer::sourceBufferPrivateHighestPresentationTimestampChanged):

• Modules/mediasource/SourceBuffer.h:
• platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::updateHighestPresentationTimestamp):
(WebCore::SourceBufferPrivate::removeCodedFrames):
(WebCore::SourceBufferPrivate::didReceiveSample):
(WebCore::SourceBufferPrivate::highestPresentationTimestamp const): Deleted.

• platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setMode):
(WebCore::SourceBufferPrivate::setGroupStartTimestamp):
(WebCore::SourceBufferPrivate::setGroupStartTimestampToEndTimestamp):
(WebCore::SourceBufferPrivate::setShouldGenerateTimestamps):
(WebCore::SourceBufferPrivate::startChangingType):
(WebCore::SourceBufferPrivate::bufferFull const):
(WebCore::SourceBufferPrivate::hasVideo const):
(WebCore::SourceBufferPrivate::timestampOffset const):

• platform/graphics/SourceBufferPrivateClient.h:

Source/WebKit:

Add IPC messages and handlers in RemoteSourceBufferProxy to implement the added functions of SourceBufferPrivateRemote.
Also add an IPC message to forward the HighestPresentationTimestampChanged callback from RemoteSourceBufferProxy
to SourceBufferPrivateRemote.

• GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateHighestPresentationTimestampChanged):
(WebKit::RemoteSourceBufferProxy::setMediaSourceEnded):
(WebKit::RemoteSourceBufferProxy::setMode):
(WebKit::RemoteSourceBufferProxy::startChangingType):
(WebKit::RemoteSourceBufferProxy::removeCodedFrames):
(WebKit::RemoteSourceBufferProxy::setAllTrackBuffersNeedRandomAccess):
(WebKit::RemoteSourceBufferProxy::setGroupStartTimestamp):
(WebKit::RemoteSourceBufferProxy::setGroupStartTimestampToEndTimestamp):
(WebKit::RemoteSourceBufferProxy::setShouldGenerateTimestamps):

• GPUProcess/media/RemoteSourceBufferProxy.h:
• GPUProcess/media/RemoteSourceBufferProxy.messages.in:
• Scripts/webkit/messages.py:
• WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::setMediaSourceEnded):
(WebKit::SourceBufferPrivateRemote::setMode):
(WebKit::SourceBufferPrivateRemote::removeCodedFrames):
(WebKit::SourceBufferPrivateRemote::setAllTrackBuffersNeedRandomAccess):
(WebKit::SourceBufferPrivateRemote::setGroupStartTimestamp):
(WebKit::SourceBufferPrivateRemote::setGroupStartTimestampToEndTimestamp):
(WebKit::SourceBufferPrivateRemote::setShouldGenerateTimestamps):
(WebKit::SourceBufferPrivateRemote::startChangingType):
(WebKit::SourceBufferPrivateRemote::sourceBufferPrivateHighestPresentationTimestampChanged):

• WebProcess/GPU/media/SourceBufferPrivateRemote.h:
• WebProcess/GPU/media/SourceBufferPrivateRemote.messages.in:

1:20 PM Changeset in webkit [271077] by Ryan Haddad

• 3 edits in trunk/LayoutTests

REGRESSION: [ Mac ] media/video-buffering-allowed.html is flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=217621

Unreviewed test gardening.

• platform/mac/TestExpectations:
• platform/mac/TestExpectationsRosetta:

Move the flaky expectation from Rosetta -> mac since this isn't
Rosetta specific.

12:55 PM Changeset in webkit [271076] by Peng Liu

• 5 edits in trunk

[Media in GPU Process][MSE] Media element does not fire "resize" event
​https://bugs.webkit.org/show_bug.cgi?id=220119

Reviewed by Eric Carlson.

Source/WebKit:

Implement RemoteMediaPlayerProxy::mediaPlayerSizeChanged() to forward the video
resize callback from MSE media player to web process.

No new tests, covered by existing failing layout test.

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerSizeChanged):

• GPUProcess/media/RemoteMediaPlayerProxy.h:

LayoutTests:

• gpu-process/TestExpectations:

12:06 PM Changeset in webkit [271075] by Fujii Hironori

• 6 edits in trunk

[WinCairo] Enable WebGL 2
​https://bugs.webkit.org/show_bug.cgi?id=192314

Reviewed by Kenneth Russell.

.:

• Source/cmake/OptionsWin.cmake: Turned ENABLE_WEBGL2 on.

Source/WebCore:

• platform/graphics/texmap/ANGLEContext.cpp:

(WebCore::ANGLEContext::createContext): Added context attributes
for WebGL by copying the code of GraphicsContextGLOpenGLCocoa.mm.

LayoutTests:

• platform/wincairo/TestExpectations:

11:18 AM Changeset in webkit [271074] by Kate Cheney

• 6 edits in trunk/Source/WebCore

Can't login to Skype from Microsoft Outlook account in Safari
​https://bugs.webkit.org/show_bug.cgi?id=220106
<rdar://problem/72453487>

Reviewed by Alex Christensen.

This is a temporary quirk to assist a high-traffic website while they
complete the large task of migrating away from logins using
third party cookies. This quirk will be removed when the site is
updated.

No new tests, site-specific quirk.

Create a quirk that will call the Storage Access API on behalf of
Microsoft for skype.com under live.com. This patch also refactors
existing quirks to avoid lots of duplicate code.

• dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccessQuirk):

• page/Quirks.cpp:

Condense the code which calls the Storage Access API and handles the
click into one function Quirks::requestStorageAccessAndHandleClick.
Call this function if the domain/element pair matches the check in
Quirks::isStorageAccessQuirkDomainElementPair.

(WebCore::isStorageAccessQuirkDomainElementPair):
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
(WebCore::Quirks::mapToTopDomain):
Moved from NetworkStorageSession and adjusted to check the host to
distinguish login.live.com from outlook.live.com which should be
treated differently.

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
The BBC case can't be included in the same check as other domains with
quirks because we need to create a pop-up and inject JavaScript based
on the user's response. So we still need to check for the BBC domain
separately.

(WebCore::isMicrosoftLoginElement): Deleted.
(WebCore::isMicrosoftDomain): Deleted.
(WebCore::isPlaystationLoginElement): Deleted.

• page/Quirks.h:
• platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::storageAccessQuirks):
(WebCore::NetworkStorageSession::mapToTopDomain): Moved.

• platform/network/NetworkStorageSession.h:

11:13 AM Changeset in webkit [271073] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[GTK][CMake] Forward missing header on Darwin
​https://bugs.webkit.org/show_bug.cgi?id=220114

Patch by Monson Shao <​holymonson@gmail.com> on 2020-12-23
Reviewed by Alex Christensen.

Building jsc with GTK port on Darwin needs spi/darwin/ProcessMemoryFootprint.h

• wtf/PlatformGTK.cmake:

10:51 AM Changeset in webkit [271072] by Simon Fraser

• 4 edits
  3 adds in trunk

REGRESSION: Scroll snapping triggers body scroll
​https://bugs.webkit.org/show_bug.cgi?id=220056
Source/WebCore:

<rdar://problem/72595482>

Reviewed by Wenson Hsieh.

ScrollController::handleWheelEvent() needs to return true to indicate that it
handled the event when it has been processed for scroll snap. If we don't do this,
the latching code thinks that no node handled the event so the latch times out.

Test: fast/scrolling/latching/scroll-snap-latching.html

• platform/cocoa/ScrollController.h:
• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):

LayoutTests:

Reviewed by Wenson Hsieh.

• fast/scrolling/latching/scroll-snap-latching-expected.txt: Added.
• fast/scrolling/latching/scroll-snap-latching.html: Added.
• platform/mac-wk1/fast/scrolling/latching/scroll-snap-latching-expected.txt: Added.

10:51 AM Changeset in webkit [271071] by dino@apple.com

• 2 edits in trunk/Tools

Simulated Python crash during test runs
​https://bugs.webkit.org/show_bug.cgi?id=220108
<rdar://problem/72605338>

Reviewed by Geoffrey Garen.

The ResourceLoadStatistics code can unlink a database during the test
run, which causes a simulated python crash. We already worked around this
by setting the SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS environment variable
on a temporary directory, but it needs to include /private/var/folders as well.
However, I didn't have any luck setting multiple directories, so I
used '/' instead.

• Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver):

9:00 AM Changeset in webkit [271070] by Simon Fraser

• 132 edits in trunk

Standardize on "allows scrolling" terminology instead of asking about scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=220111

Reviewed by Wenson Hsieh.

Source/WebCore:

Code variously used "canScrollHorizontally" and "hasEnabledHorizontalScrollbar".
Standardize on "allowsHorizontalScrolling". This returns true both when there
is overflow to scroll, and when style allows it (i.e. not overflow-x: hidden).

This changes the name and dumping for ScrollableAreaParams so lots of test results
change.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::operator<<):

• page/scrolling/ScrollingCoordinatorTypes.h:

(WebCore::ScrollableAreaParameters::operator== const):

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):

• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/ScrollingTreeScrollingNodeDelegate.h:

(WebCore::ScrollingTreeScrollingNodeDelegate::allowsHorizontalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegate::allowsVerticalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegate::hasEnabledHorizontalScrollbar const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegate::hasEnabledVerticalScrollbar const): Deleted.

• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalScrolling const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::canScrollHorizontally const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::canScrollVertically const): Deleted.

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::allowsHorizontalScrolling const):
(WebCore::ScrollableArea::allowsVerticalScrolling const):

• platform/ScrollableArea.h:
• platform/cocoa/ScrollController.h:
• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::snapRubberBandTimerFired):

• platform/mac/ScrollAnimatorMac.h:
• platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::allowsHorizontalScrolling const):
(WebCore::ScrollAnimatorMac::allowsVerticalScrolling const):
(WebCore::ScrollAnimatorMac::canScrollHorizontally const): Deleted.
(WebCore::ScrollAnimatorMac::canScrollVertically const): Deleted.

• platform/mock/ScrollAnimatorMock.h:

Source/WebKit:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<ScrollableAreaParameters>::decode):

LayoutTests:

• fast/scrolling/ios/change-scrollability-on-content-resize-expected.txt:
• fast/scrolling/ios/change-scrollability-on-content-resize-nested-expected.txt:
• fast/scrolling/ios/scrollbar-hiding-expected.txt:
• fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt:
• fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt:
• fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt:
• platform/ipad/fast/scrolling/ios/change-scrollability-on-content-resize-nested-expected.txt:
• platform/ipad/scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:
• scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt:
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-non-cb-overflow-expected.txt:
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow-expected.txt:
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow2-expected.txt:
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-dynamic-expected.txt:
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-expected.txt:
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-on-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/absolute-in-nested-sc-scrollers-expected.txt:
• scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt:
• scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested-expected.txt:
• scrollingcoordinator/scrolling-tree/composited-in-absolute-in-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
• scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
• scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
• scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
• scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
• scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
• scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
• scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt:
• scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
• scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
• scrollingcoordinator/scrolling-tree/positioned-nodes-expected.txt:
• scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt:
• scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
• scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
• scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
• scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
• scrollingcoordinator/scrolling-tree/sticky-in-overflow-expected.txt:
• scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:
• tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
• tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
• tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
• tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
• tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt:
• tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
• tiled-drawing/scrolling/fixed/four-bars-expected.txt:
• tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
• tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
• tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt:
• tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt:
• tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
• tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
• tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt:
• tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt:
• tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt:
• tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
• tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:

8:52 AM Changeset in webkit [271069] by commit-queue@webkit.org

• 2 edits in trunk

[CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
​https://bugs.webkit.org/show_bug.cgi?id=220082

Patch by Monson Shao <​holymonson@gmail.com> on 2020-12-23
Reviewed by Alex Christensen.

In some distros (NixOS) harfbuzz and harfbuzz-icu may have different include dir.

• Source/cmake/FindHarfBuzz.cmake: