Timeline
Dec 28, 2020:
- 1:43 PM Changeset in webkit [271105] by
-
- 2 edits in trunk/LayoutTests
Mark tests as flaky for https://bugs.webkit.org/show_bug.cgi?id=220188
- platform/mac-wk1/TestExpectations:
- 1:03 PM Changeset in webkit [271104] by
-
- 2 edits in trunk/LayoutTests
Mark webanimations/accelerated-animation-with-easing.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=220187
- platform/mac/TestExpectations:
- 10:26 AM Changeset in webkit [271103] by
-
- 2 edits in trunk/Source/WebCore
[LFC][Integration] Add support for non-baseline aligned text painting
https://bugs.webkit.org/show_bug.cgi?id=220185
Reviewed by Antti Koivisto.
Use the run's vertical position to set the text origin (instead of using the line's baseline position).
This is in preparation for enabling inline box content.
(e.g. <div><span style="vertical-align: text-top">non-baseline aligned text</span></div>)
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::paint):
- 9:33 AM Changeset in webkit [271102] by
-
- 2 edits in trunk/Tools
built-product-archive should work with Python 3
https://bugs.webkit.org/show_bug.cgi?id=220157
Reviewed by Aakash Jain.
- CISupport/built-product-archive:
(webkitBuildDirectoryForConfigurationAndPlatform): Decode result as a string,
because the directory is then used in string manipulation.
(createZipFromList): Use Python 3 compatible 'except' syntax. The new syntax works
in Python 2.6 and newer.
(createZip): Ditto.
Dec 27, 2020:
- 10:44 PM Changeset in webkit [271101] by
-
- 3 edits in trunk/Source/WTF
Add a helper method to WTF::MachSemaphore to wait with a timeout duration
https://bugs.webkit.org/show_bug.cgi?id=220110
Reviewed by Sam Weinig.
Adds a helper method on the cross-process WTF::MachSemaphore class (to be utilized in webkit.org/b/219586).
- wtf/cocoa/MachSemaphore.cpp:
(WTF::MachSemaphore::waitFor):
This wraps a call to
semaphore_timedwait, and converts the given time (in WTF::Seconds) into a
mach_timespec_t, which is an unsigned representing the number of seconds, along with another integer
representing the number of nanoseconds.
- wtf/cocoa/MachSemaphore.h:
- 8:41 PM Changeset in webkit [271100] by
-
- 7 edits2 adds in trunk
[WASM-References] Fix table.init and table.grow to satisfy the spec
https://bugs.webkit.org/show_bug.cgi?id=220181
Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-27
Reviewed by Yusuke Suzuki.
JSTests:
Fix behaviour of the previous tests and added ref-types
spec tests for bulk operations and table.grow.
- wasm.yaml:
- wasm/references-spec-tests/bulk.wast.js: Added.
- wasm/references-spec-tests/table_grow.wast.js: Added.
- wasm/references/table_misc.js:
(TableSize.0.End.End.WebAssembly):
Source/JavaScriptCore:
Fix and refactor a little bit table.init and
table.grow.
- wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
- wasm/WasmOperations.h:
- wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_SLOW_PATH_DECL):
- 6:47 PM Changeset in webkit [271099] by
-
- 1 edit1 add in trunk/Source/WebCore
Add a ReadMe.md for Source/WebCore/display
Reviewed by Zalan Bujtas.
- display/ReadMe.md: Added.
- 3:50 PM Changeset in webkit [271098] by
-
- 7 edits1 add in trunk
[WASM-References] Adjust table.fill to satisfy the spec
https://bugs.webkit.org/show_bug.cgi?id=220161
Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-27
Reviewed by Yusuke Suzuki.
JSTests:
Added table.fill spec tests and adjusted existing tests.
- wasm.yaml:
- wasm/references-spec-tests/table_fill.wast.js: Added.
- wasm/references/table_misc.js:
(GetLocal.0.GetLocal.1.TableGrow.0.End.End.WebAssembly):
Source/JavaScriptCore:
Fixed table.fill for the case when count is 0 and offset is equal to
table size.
- wasm/WasmOperations.cpp:
(JSC::Wasm::setWasmTableElement):
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
- wasm/WasmOperations.h:
- wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_SLOW_PATH_DECL):
- 3:35 PM Changeset in webkit [271097] by
-
- 7 edits1 add in trunk
[WASM-References] Add declared function indexes set to check from what functions we can create refs
https://bugs.webkit.org/show_bug.cgi?id=220009
Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-27
Reviewed by Yusuke Suzuki.
JSTests:
Now we satisfy ref_func spec test so I've added it.
- wasm.yaml:
- wasm/references-spec-tests/ref_func.wast.js: Added.
Source/JavaScriptCore:
By ref-types spec we can create references only from declared functions.
Declared function is a function that was mentioned:
as export,
as part of ref.func init expression for a global,
in the element section.
In this patch declared function indexes set introduced to check this
requirement.
https://webassembly.github.io/reference-types/core/valid/instructions.html#reference-instructions.
- wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):
- wasm/WasmModuleInformation.h:
(JSC::Wasm::ModuleInformation::isDeclaredFunction const):
(JSC::Wasm::ModuleInformation::addDeclaredFunction):
- wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseGlobal):
(JSC::Wasm::SectionParser::parseExport):
(JSC::Wasm::SectionParser::parseElementSegmentVectorOfExpressions):
(JSC::Wasm::SectionParser::parseElementSegmentVectorOfIndexes):
- 10:57 AM Changeset in webkit [271096] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Inline box should start with a strut in standards mode
https://bugs.webkit.org/show_bug.cgi?id=220160
Reviewed by Antti Koivisto.
If the inline box contains no glyphs at all, or if it contains only glyphs from fallback fonts,
it is considered to contain a “strut” (an invisible glyph of zero width) with the metrics of the box’s first available font.
https://www.w3.org/TR/css-inline-3/#inline-height
(css2.1/20110323/empty-inline-003.htm)
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
- 10:37 AM Changeset in webkit [271095] by
-
- 2 edits in trunk/Source/WebCore
Fix incorrect return types of fallback color conversion functions
https://bugs.webkit.org/show_bug.cgi?id=220159
Reviewed by Dean Jackson.
- platform/graphics/ColorConversion.h:
Fixup return types of fallback conversion functions to match signature.
- 10:34 AM Changeset in webkit [271094] by
-
- 2 edits in trunk/Source/WebCore
Generalize callWithColorType to work with either float or uint8_t color types
https://bugs.webkit.org/show_bug.cgi?id=220155
Reviewed by Dean Jackson.
- platform/graphics/ColorTypes.h:
(WebCore::callWithColorType):
Templatize the component type.
- 10:00 AM Changeset in webkit [271093] by
-
- 3 edits in trunk/Source/WebCore
Remove one more place needed when adding new color types
https://bugs.webkit.org/show_bug.cgi?id=220156
Reviewed by Simon Fraser.
- platform/graphics/Color.h:
(WebCore::Color::Color):
Missed this in the last pass. Replace specific overloads with a conditional template function contructor.
- platform/graphics/ColorTypes.h:
Adds a few traits to help identify color types.
