⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 19, 2021:

9:23 PM Changeset in webkit [271637] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

REGRESSION (r271508) Scrolling is no longer smooth
​https://bugs.webkit.org/show_bug.cgi?id=220759

Reviewed by Sam Weinig.

r271508 has a logic error that resulted in no scrolling thread layer commits, which meant that
scrolling on pages with a busy main thread only updated layers at main thread cadence.

  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::canUpdateLayersOnScrollingThread const):

8:33 PM Changeset in webkit [271636] by commit-queue@webkit.org
  • 12 edits in trunk

Update media state for active speech recognition as it uses audio capture
​https://bugs.webkit.org/show_bug.cgi?id=220667

Patch by Sihui Liu <​sihui_liu@appe.com> on 2021-01-19
Reviewed by Youenn Fablet.

Source/WebCore:

To make sure the media capture state is correctly sent to client.

API test: WebKit2.SpeechRecognitionMediaCaptureStateChange

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::startRecognition):
(WebCore::SpeechRecognition::stop):
(WebCore::SpeechRecognition::didStartCapturingAudio):
(WebCore::SpeechRecognition::didStopCapturingAudio):

  • Modules/speech/SpeechRecognition.h:
  • Modules/speech/SpeechRecognitionConnection.h:
  • dom/Document.cpp:

(WebCore::Document::setActiveSpeechRecognition):
(WebCore::Document::updateIsPlayingMedia):

  • dom/Document.h:
  • page/DummySpeechRecognitionProvider.h:

Source/WebKit:

  • WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.cpp:

(WebKit::WebSpeechRecognitionConnection::unregisterClient):

  • WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:

(-[SpeechRecognitionUIDelegate _webView:mediaCaptureStateDidChange:]):
(TestWebKitAPI::TEST):
(-[SpeechRecognitionPermissionUIDelegate _webView:requestSpeechRecognitionPermissionForOrigin:decisionHandler:]): Deleted.
(-[SpeechRecognitionPermissionUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]): Deleted.
(-[SpeechRecognitionPermissionUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]): Deleted.
(-[SpeechRecognitionPermissionUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.

6:00 PM Changeset in webkit [271635] by Megan Gardner
  • 6 edits
    2 adds in trunk

Elements in a table are incorrectly selected in JavaScript.
​https://bugs.webkit.org/show_bug.cgi?id=220607

Reviewed by Wenson Hsieh.

Source/WebCore:

After the fix for ​https://bugs.webkit.org/show_bug.cgi?id=130844 in ​https://trac.webkit.org/changeset/260207/webkit a regression was found for
table cell selections through JavaScript. The previous fix was for an issue in the difference between how PositionIterator and Position calculated
if it was canonical (::isCandidate) in the cases where the renderer was a BR. Instead of only converging isCandidate for BR, this function in PositionIterator
was completely subsumed by just calling the implementation for Position. While there are many similarities, there are important differences, especially in the
table code, therefore PositionIterator::isCandidate is being reinstated, but with the convergence in the BR case only.
Also, moved the check added in ​http://webkit.org/b/211864 so it will cover cases that were missed due to this code being wrong while that fix was added.

Test: editing/selection/editable-table-cell-selection.html

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate const):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

  • editing/execCommand/null_calc_primitive_value_for_css_property.html:

Added ending tag that was missing and does not affect the issue the test was verifying.

  • editing/inserting/insert-list-in-table-cell-07-expected.txt:

Restored expected text file to original output.

  • editing/selection/editable-table-cell-selection-expected.txt: Added.
  • editing/selection/editable-table-cell-selection.html: Added.
5:47 PM Changeset in webkit [271634] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r271506): webkit-patch keyring integration is broken on Linux
​https://bugs.webkit.org/show_bug.cgi?id=220736

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-01-19
Reviewed by Jonathan Bedard.

r271506 updated python-keyring to the last version to support python2, but unfortunately
this version seems to be somehow incompatible with python-secretstorage, which is required
for system keyring support on Linux. This bug is fixed in newer versions of python-keyring
that do not support python2, but we still support python2, so we cannot upgrade. I've tested
several versions of python-keyring and found that version 11.1.0 is the most recent version
that supports python2 and works properly on Linux, so let's stick with that until we are
ready to give up on python2.

  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py:
5:37 PM Changeset in webkit [271633] by ysuzuki@apple.com
  • 5 edits in trunk/Source/WTF

[WTF] StringImpl::removeCharacters should be inlined
​https://bugs.webkit.org/show_bug.cgi?id=220742

Reviewed by Saam Barati.

removeCharacters is used in WebCore's HTMLInputElement's critical path. And since String relatively has many elements (characters),
non-inlined StringImpl::removeCharacters causes significant number of indirect function calls of findMatch argument since it is
passed function pointer. We should make them templatized function to allow inlining of findMatch function to avoid repeated indirect calls.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::removeCharacters): Deleted.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::removeCharactersImpl):
(WTF::StringImpl::removeCharacters):

  • wtf/text/WTFString.cpp:

(WTF::String::removeCharacters const): Deleted.

  • wtf/text/WTFString.h:

(WTF::String::removeCharacters const):

4:49 PM Changeset in webkit [271632] by Alan Coon
  • 1 copy in tags/Safari-611.1.12.1

Tag Safari-611.1.12.1.

4:36 PM Changeset in webkit [271631] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

[Hardening] Protect against overflows in ArgumentCoder<ArrayReference<T, arrayReferenceDynamicExtent>>::decode()
​https://bugs.webkit.org/show_bug.cgi?id=220748
<rdar://73323644>

Reviewed by Geoff Garen.

Make sure size and size * sizeof(T) do not overflow.

  • Platform/IPC/ArgumentCoders.h:
4:34 PM Changeset in webkit [271630] by Jonathan Bedard
  • 4 edits in trunk/Tools

[webkitcorepy] Support alternative default pypi url on macOS
​https://bugs.webkit.org/show_bug.cgi?id=220744
<rdar://problem/73369338>

Reviewed by Aakash Jain.

  • Scripts/libraries/webkitcorepy/setup.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(_default_pypi_index): Pull default pypi index from pip.conf, if available.
(AutoInstall): Set index based on result of _default_pypi_index.

4:29 PM Changeset in webkit [271629] by Alan Coon
  • 8 edits in branches/safari-611.1.12-branch/Source

Versioning.

WebKit-7611.1.12.1

4:19 PM Changeset in webkit [271628] by Alan Coon
  • 1 copy in branches/safari-611.1.12-branch

New branch.

4:07 PM Changeset in webkit [271627] by Chris Dumez
  • 5 edits in trunk/Source

Source/WebCore/PAL:
[GPUProcess] Claim ownership of IOSurface backing for ImageBufferBackends in the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=220663

Reviewed by Geoffrey Garen.

Declare new IOSurface SPI.

  • pal/spi/cocoa/IOSurfaceSPI.h:

Source/WebKit:
[GPUProcess] Claim ownership of Canvas IOSurface backing in the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=220663

Reviewed by Geoffrey Garen.

Claim ownership of Canvas IOSurface backing in the WebProcess. If we don't do this, all
IOSurface memory gets attributed to the GPUProcess, making it a prime candidate for jetsam.
We need to attribute memory usage to the WebProcesses being served by the GPUProcess as much
as possible and this is a step in this direction.

Note that this patch currently only impacts Canvas IOSurface backing when "DOM Rendering in
GPUProcess" is disabled. When "DOM Rendering in GPUProcess" is enabled, we are not supposed
to use the IOSurface API in the WebProcess at all.

  • WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):

4:04 PM WebKitGTK/2.30.x edited by Michael Catanzaro
(diff)
3:50 PM Changeset in webkit [271626] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Syscall param sendmsg(msg.msg_iov[1]) points to uninitialised byte(s) in IPC::Connection::sendOutgoingMessage
​https://bugs.webkit.org/show_bug.cgi?id=220668

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-01-19
Reviewed by Darin Adler.

We previously discovered that we need to either (a) manually zero the MessageInfo struct
with memcpy (accepted solution), or b) use attribute((packed)) to omit struct packing.
This seemed to fix our valgrind warnings when bmalloc was in use, but not when bmalloc is
disabled, as is good practice when valgrinding.

Turns out we need to zero (or pack) the AttachmentInfo struct as well. Let's go with zeroing
it, since all its members are trivially copyable, so that's safe to do.

For good measure, we'll implement a copy constructor and do so there as well. Do this for
MessageInfo too, to round out the original fix to MessageInfo.

Since AttachmentInfo and MessageInfo are no longer trivially-copyable, we now need to cast
them to void* when using memcpy in order to avoid -Wclass-memaccess warnings from GCC.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::AttachmentInfo::AttachmentInfo):
(): Deleted.

  • Platform/IPC/unix/UnixMessage.h:

(IPC::MessageInfo::MessageInfo):
(IPC::UnixMessage::UnixMessage):

3:38 PM Changeset in webkit [271625] by Russell Epstein
  • 1 delete in branches/safari-612.1-branch

Delete branch.

3:27 PM Changeset in webkit [271624] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix GCC warnings
​https://bugs.webkit.org/show_bug.cgi?id=220718

  • dfg/DFGOperations.cpp:

(JSC::DFG::tierUpCommon):

3:23 PM Changeset in webkit [271623] by Russell Epstein
  • 8 edits in branches/safari-612.1-branch/Source

Versioning.

WebKit-7612.1.1

3:21 PM Changeset in webkit [271622] by Russell Epstein
  • 1 copy in branches/safari-612.1-branch

New branch.

3:07 PM Changeset in webkit [271621] by Russell Epstein
  • 8 edits in branches/safari-611-branch/Source

Revert "Versioning."

This reverts commit r271556.

2:55 PM Changeset in webkit [271620] by Patrick Angle
  • 5 edits in trunk/Source

Web Inspector: Font Details sidebar - Fractional variation axis ranges/default values are rounded.
​https://bugs.webkit.org/show_bug.cgi?id=220474

Reviewed by BJ Burg.

Source/WebCore:

Use float instead of int for variation axis range and defaults, as these values can be fractional.

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::FontVariationAxis::FontVariationAxis):
(WebCore::FontPlatformData::FontVariationAxis::defaultValue const):
(WebCore::FontPlatformData::FontVariationAxis::minimumValue const):
(WebCore::FontPlatformData::FontVariationAxis::maximumValue const):

Source/WebInspectorUI:

Fixes Font Details sidebar display of variation axis values, ranges, and defaults to show fractional precision
when such precision is present.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/FontDetailsPanel.js:

(WI.FontDetailsPanel.prototype.refresh):
(WI.FontDetailsPanel.prototype._formatSimpleSingleValue):
(WI.FontDetailsPanel.prototype._formatVariationValue):
(WI.FontDetailsPanel.prototype._createVariationValueElement):
(WI.FontDetailsPanel.prototype._formatAxisValueAsString):

  • Show fractional values with between 0 and 2 decimal places.
2:40 PM Changeset in webkit [271619] by commit-queue@webkit.org
  • 5 edits in trunk/Source

REGRESSION(r269865) Mail's context menu when right clicking on a link does not contain correct entries
​https://bugs.webkit.org/show_bug.cgi?id=220745

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-01-19
Reviewed by Tim Horton.

Source/WebCore:

r269865 broke binary compatibility by changing the values of many WebCore::ContextMenuAction values and many WKContextMenuItemTag values,
and not in the same way. In WebContextMenuProxyMac::getContextMenuItem we call NSMenuItem setTag: with the value from WebCore::ContextMenuAction
and mail compares those values with values from WKContextMenuItemTag in our C API. This isn't ideal, but we need to retain binary compatibility.

  • platform/ContextMenuItem.h:

Source/WebKit:

  • Shared/API/c/WKContextMenuItem.cpp:

Add a bunch of static_asserts to verify that our binary values correspond to each other and don't change.

  • Shared/API/c/WKContextMenuItemTypes.h:
2:15 PM Changeset in webkit [271618] by svillar@igalia.com
  • 3 edits
    2 adds in trunk

REGRESSION(r266695) Range control with custom track width sized incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=220608

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/forms/range/input-range-sizing-fixed-size.html

In r266695 we modified the way min-{width|height}: auto was computed for flexbox elements. That broke the sizing
of input range controls that were working under the assumption that min-{width|height} was 0. We have to force it
in the UA CSS in order to keep the same behaviour.

  • css/html.css:

(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container): force
min-width: 0.

LayoutTests:

New test case to verify that input range controls are sized correctly with specified widths.

  • fast/forms/range/input-range-sizing-fixed-size-expected.html: Added.
  • fast/forms/range/input-range-sizing-fixed-size.html: Added.
2:11 PM Changeset in webkit [271617] by Jonathan Bedard
  • 2 edits in trunk/Tools

[commit-queue] Cache credentials for https instead of http
​https://bugs.webkit.org/show_bug.cgi?id=220746
<rdar://problem/73369984>

Reviewed by Aakash Jain.

  • EWSTools/configure-svn-auth.sh:
1:48 PM Changeset in webkit [271616] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][RenderTreeDump] Match empty RenderInline geometry
​https://bugs.webkit.org/show_bug.cgi?id=220721

Reviewed by Antti Koivisto.

Let's match legacy line layout's RenderInline behavior and report 0 height when the inline box is "empty".
It helps to reduce noise for enabling LFC's inline-box support (see webkit.org/b/220148).
(Note that this is no-op on trunk at this point.)

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

1:43 PM Changeset in webkit [271615] by Devin Rousso
  • 4 edits
    2 adds in trunk

Payment Request API - PaymentDetailsUpdate requires "total"
​https://bugs.webkit.org/show_bug.cgi?id=220561
<rdar://problem/73204405>

Reviewed by Andy Estes.

Source/WebCore:

Test: http/tests/paymentrequest/updateWith-error.https.html

  • Modules/paymentrequest/PaymentDetailsUpdate.h:
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::settleDetailsPromise):
Use Optional for total so that it's possible to know when it's provided or not.
Only attempt to parse the total when it's provided.

LayoutTests:

  • http/tests/paymentrequest/updateWith-error.https.html: Added.
  • http/tests/paymentrequest/updateWith-error.https-expected.txt: Added.
1:38 PM Changeset in webkit [271614] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, reverting r271606.
​https://bugs.webkit.org/show_bug.cgi?id=220747

Didn't work properly

Reverted changeset:

"[update-webkit] Do not automatically use git svn rebase"
​https://bugs.webkit.org/show_bug.cgi?id=220739
​https://trac.webkit.org/changeset/271606

1:27 PM Changeset in webkit [271613] by jiewen_tan@apple.com
  • 5 edits in trunk/Source/WebKit

[WebAuthn] Polish the new WebAuthn UI
​https://bugs.webkit.org/show_bug.cgi?id=220617
<rdar://problem/73185470>

Reviewed by Brent Fulgham.

This patch does the following few things:

  1. It updates the way how the PIN error for security keys is handled.
  2. It uses the credential name to identify a credential that passed to the UI instead of the login choice object

as it turns out that the UI won't return the same object at all.

  1. It delays to show the UI if the platform authenticator is involved given the platform authenticator might not contain

the requested credentials. If not, we should either show an error or just requesting the security key ones.

Covered by manual tests.

  • Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:

(NS_ERROR_ENUM):

  • UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.h:
  • UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:

(WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
(WebKit::AuthenticatorPresenterCoordinator::updatePresenter):
(WebKit::AuthenticatorPresenterCoordinator::selectAssertionResponse):
(WebKit::AuthenticatorPresenterCoordinator::didSelectAssertionResponse):

  • UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:

(-[WKASCAuthorizationPresenterDelegate authorizationPresenter:credentialRequestedForLoginChoice:authenticatedContext:completionHandler:]):

1:26 PM Changeset in webkit [271612] by Patrick Angle
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Historical Figures string should be Alternate Glyphs
​https://bugs.webkit.org/show_bug.cgi?id=220731

Reviewed by BJ Burg.

Changed title for CSS property font-variant-alternates to be Alternate Glyphs.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/FontDetailsPanel.js:

(WI.FontDetailsPanel.prototype.initialLayout):

1:25 PM Changeset in webkit [271611] by youenn@apple.com
  • 2 edits in trunk/LayoutTests/imported/w3c

[ BigSur ] imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=220631
<rdar://problem/73212492>

Reviewed by Alex Christensen.

I reproduced locally the error and saw a -1005 error, 'The network connection was lost'.
When running tests sequentially instead of in parallel, I do not see this anymore.

  • web-platform-tests/fetch/nosniff/parsing-nosniff.window.js:

(runTests):

1:24 PM Changeset in webkit [271610] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[WPE][GTK] Remove unnecessary child setup function from process launcher
​https://bugs.webkit.org/show_bug.cgi?id=220090

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-01-19
Reviewed by Carlos Garcia Campos.

The process launcher currently uses a child setup function to close the server end of its
IPC socket. But this is totally unnecessary because this socket always uses CLOEXEC. So the
child setup function is redundant.

This is step one towards making Eclipse not crash when its UI process JVM is using a huge
amount of memory. In such conditions, fork() will fail due to OOM, but posix_spawn() will
still succeed. A child setup function forces GLib to use fork() instead of posix_spawn().
However, this commit is not sufficient to fix Eclipse, because GSubprocess itself sets its
own child setup function.

  • UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):
(WebKit::childSetupFunction): Deleted.

1:18 PM Changeset in webkit [271609] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION (r270964): Hovering cursor over Earth animation causes flashing red distortion on GitHub.com
​https://bugs.webkit.org/show_bug.cgi?id=220612
<rdar://problem/73175210>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-01-19
Reviewed by Dean Jackson.

When reading the display buffer for WebKit snapshots, use READ_FRAMEBUFFER on WebGL2 and
FRAMEBUFFER on WebGL1. Fixes the case where WebGL2 contexts would get broken because
taking a snapshot would overwrite the framebuffer attachment.

No new tests, snapshots are not tested at the moment.

  • platform/graphics/angle/GraphicsContextGLANGLEUtilities.h:

(WebCore::ScopedRestoreReadFramebufferBinding::framebufferTarget const):

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::readCompositedResults):

1:12 PM Changeset in webkit [271608] by Lauro Moura
  • 6 edits in trunk

REGRESSION(r271580) [GTK] LTS/Debian build failure due to unsupported g-ir-scanner parameter
​https://bugs.webkit.org/show_bug.cgi?id=220730

Reviewed by Philippe Normand.

.:

  • Source/cmake/FindGObjectIntrospection.cmake: Expose variable about the

presence of --sources-top-dirs.

Source/JavaScriptCore:

No new behavior. No new tests.

  • PlatformGTK.cmake: Expose --sources-top-dirs only if available.

Source/WebKit:

No new behavior. No new tests.

  • PlatformGTK.cmake: Expose --sources-top-dirs only if available.
1:09 PM Changeset in webkit [271607] by Keith Rollin
  • 10 edits
    1 copy
    5 adds in trunk/Source

Modularize WebKitLegacy.framework
​https://bugs.webkit.org/show_bug.cgi?id=220026
<rdar://57173237>

Reviewed by Darin Adler.

Add .modulemap files to WebKitLegacy to help speed up client builds.

Source/WebKit:

For MigrateHeadersFromWebKitLegacy.make, remove the newly-created
umbrella header files from WEBKIT_LEGACY_PRIVATE_HEADERS in order to
avoid some processing that the non-umbrella headers receive.

  • mac/MigrateHeadersFromWebKitLegacy.make:

Source/WebKitLegacy:

  • Modules/WebKitLegacy_iOS.private.modulemap: Added.
  • Modules/WebKitLegacy_macOS.private.modulemap: Added.
  • WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/ios:

For WebUIKitDelegate.h, ensure that ENABLE_ORIENTATION_EVENTS is
defined before checking its value, thereby avoiding a compiler
warning-turned-error that an uninitialized symbol is being used.

  • WebView/WebUIKitDelegate.h:

Source/WebKitLegacy/mac:

In WebKitLegacy.xcconfig, enable module creation for macOS and iOS.
Add the associated umbrella header files, and enable the validation of
the module files.

For WebHTMLViewPrivate.h, ensure that ENABLE_NETSCAPE_PLUGIN_API is
defined before checking its value, thereby avoiding a compiler
warning-turned-error that an uninitialized symbol is being used.

For WebBackForwardListPrivate.h, make the parameter name in a function
comment match the actual parameter name, thereby avoiding a
warning-turned-error from the tool that processes headers into built
modules.

  • Configurations/WebKitLegacy.xcconfig:
  • History/WebBackForwardListPrivate.h:
  • Misc/WebKitLegacy_Private.h: Added.
  • Misc/WebKitLegacy_iOS_Private.h: Added.
  • Misc/WebKitLegacy_macOS_Private.h: Copied from Source/WebKitLegacy/mac/History/WebBackForwardListPrivate.h.
  • WebView/WebHTMLViewPrivate.h:
11:44 AM Changeset in webkit [271606] by Jonathan Bedard
  • 2 edits in trunk/Tools

[update-webkit] Do not automatically use git svn rebase
​https://bugs.webkit.org/show_bug.cgi?id=220739
<rdar://problem/73365632>

Rubber-stamped by Aakash Jain.

git svn rebase is an expensive operation, it is also usually the wrong operation
when your git checkout is already being automatically populated from Subversion

  • Scripts/webkitdirs.pm:

(runGitUpdate): Replace git svn rebase with git svn fetch.

11:43 AM Changeset in webkit [271605] by Russell Epstein
  • 1 copy in tags/Safari-611.1.11.1

Tag Safari-611.1.11.1.

11:35 AM Changeset in webkit [271604] by Russell Epstein
  • 8 edits in branches/safari-611.1.11-branch/Source

Versioning.

WebKit-7611.1.11.1

11:10 AM Changeset in webkit [271603] by Russell Epstein
  • 1 copy in branches/safari-611.1.11-branch

New branch.

10:46 AM Changeset in webkit [271602] by Jonathan Bedard
  • 2 edits in trunk/Tools

[webkitpy] Support generating patch with main as the default branch
​https://bugs.webkit.org/show_bug.cgi?id=220737
<rdar://problem/73362104>

Reviewed by Dewei Zhu.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.remote_branch_ref): Support

9:11 AM Changeset in webkit [271601] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Unreviewed, drop remaining main-thread assertion in ShareableBitmap that I missed in r271533.

This assertion is hitting on the debug GPUProcess bot. SharedBitmap subclasses ThreadSafeRefCounted
as of r271533 and it is expected that it is used from non-main threads.

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

6:35 AM Changeset in webkit [271600] by Jonathan Bedard
  • 2 edits in trunk/Tools

[GitHub] Use github.com as the source of truth for EWS
​https://bugs.webkit.org/show_bug.cgi?id=220479
<rdar://problem/72941463>

Reviewed by Aakash Jain.

  • CISupport/ews-build/steps.py:

(CheckOutSource.init): Use GitHub.com instead of git.webkit.org.

3:38 AM Changeset in webkit [271599] by Adrian Perez de Castro
  • 7 edits in trunk/Source

Non-unified build fixes, mid January 2021 edition
​https://bugs.webkit.org/show_bug.cgi?id=220725

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getNonReifiedStaticPropertyNames): Remove inline function from here,
as it is used in JSPropertyNameEnumerator.cpp and the compiler needs to see the function
body to be able to inline it, otherwise linking fails.

  • runtime/JSObjectInlines.h:

(JSC::JSObject::getNonReifiedStaticPropertyNames): Moved inline function here.

  • wasm/WasmInstance.cpp: Add missing JSWebAssemblyHelpers.h header.
  • wasm/js/WebAssemblyModuleRecord.cpp: Add missing ObjectConstructor.h header.

Source/WebCore:

No new tests needed.

  • rendering/RenderLayerScrollableArea.cpp: Add missing header includes.
3:02 AM Changeset in webkit [271598] by Nikolas Zimmermann
  • 11 edits in trunk/Source

Continue removing glue code from RenderLayer that was recently added in r271559
​https://bugs.webkit.org/show_bug.cgi?id=220715

Reviewed by Adrian Perez de Castro.

Follow-up on patch adressing the removal of the glue code that
forwards calls from RenderLayer to RenderLayerScrollableArea (see
webkit.org/b/60305).

Covered by existing tests.

Source/WebCore:

  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

  • rendering/RenderBox.cpp:

(WebCore::setupWheelEventMonitor):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::setScrollPosition):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::currentScrollType const): Deleted.
(WebCore::RenderLayer::scrollAnimator const): Deleted.
(WebCore::RenderLayer::scrollToXPosition): Deleted.
(WebCore::RenderLayer::scrollToYPosition): Deleted.
(WebCore::RenderLayer::setScrollPosition): Deleted.
(WebCore::RenderLayer::scrollByRecursively): Deleted.
(WebCore::RenderLayer::setRequiresScrollPositionReconciliation): Deleted.
(WebCore::RenderLayer::hasScrollableOrRubberbandableAncestor): Deleted.
(WebCore::RenderLayer::reachableTotalContentsSize const): Deleted.
(WebCore::RenderLayer::horizontalScrollbarHiddenByStyle const): Deleted.
(WebCore::RenderLayer::verticalScrollbarHiddenByStyle const): Deleted.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateScrollOffset):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::LegacyWebKitScrollingLayerCoordinator::updateScrollingLayer):

  • rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::scrollByRecursively):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::hasScrollableOrRubberbandableAncestor):

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::gesture):

1:07 AM Changeset in webkit [271597] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Null check ResourceRequest IPC decode
​https://bugs.webkit.org/show_bug.cgi?id=220400

Patch by Rob Buis <​rbuis@igalia.com> on 2021-01-19
Reviewed by Youenn Fablet.

Source/WebKit:

Null check ResourceRequest IPC decode since
the IPC::decode call can succeed yet but set
the dictionary to null.

Test: ipc/web-authenticator-get-assertion.html

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::ResourceRequest>::decodePlatformData):

LayoutTests:

Add test for this.

  • ipc/web-authenticator-get-assertion-expected.txt: Added.
  • ipc/web-authenticator-get-assertion.html: Added.

Jan 18, 2021:

8:59 PM Changeset in webkit [271596] by ysuzuki@apple.com
  • 3 edits
    1 add in trunk

[JSC] FTL::prepareOSREntry can clear OSR entry CodeBlock if it is already invalidated
​https://bugs.webkit.org/show_bug.cgi?id=220718
<rdar://problem/70527068>

Reviewed by Mark Lam.

JSTests:

  • stress/ftl-osr-failure-clear-twice.js: Added.

(foo):

Source/JavaScriptCore:

FTL::prepareOSREntry can clear OSR entry CodeBlock if it is already invalidated. However, the caller is not assuming that,
and it calls clearOSREntryBlockAndResetThresholds again. And clearOSREntryBlockAndResetThresholds's assertion hit.
This patch correctly handles the invalidated case.

  • dfg/DFGOperations.cpp:

(JSC::DFG::tierUpCommon):

8:28 PM Changeset in webkit [271595] by Lauro Moura
  • 4 edits in trunk/LayoutTests

[GLIB] Gardening some failures and crashes

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
4:24 PM Changeset in webkit [271594] by commit-queue@webkit.org
  • 28 edits
    5 moves in trunk/Source/JavaScriptCore

[JSC] Implement a B3::Compilation replacement for wasm-llint
​https://bugs.webkit.org/show_bug.cgi?id=220585

Patch by Xan López <Xan Lopez> on 2021-01-18
Reviewed by Yusuke Suzuki.

Move B3Compilation, B3OpaqueByproducts and B3OpaqueByproduct to
jit/. They are used by non-B3 code and they are not really B3
specific. Also rename B3CompilationPtrTag to JITCompilationPtrTag.

  • CMakeLists.txt: add new source files.
  • JavaScriptCore.xcodeproj/project.pbxproj: ditto.
  • Sources.txt: ditto.
  • b3/B3Compile.cpp:

(JSC::B3::compile): use JITCompilationPtrTag.

  • b3/B3Compile.h: change includes.
  • b3/B3DataSection.h: ditto.
  • b3/B3Procedure.cpp: ditto.
  • b3/B3Procedure.h: ditto.
  • b3/air/testair.cpp: use JITCompilationPtrTag.
  • b3/testb3.h: change includes.

(invoke):

  • b3/testb3_6.cpp:

(testInterpreter): use JITCompilationPtrTag.
(testEntrySwitchSimple): ditto.
(testEntrySwitchNoEntrySwitch): ditto.
(testEntrySwitchWithCommonPaths): ditto.
(testEntrySwitchWithCommonPathsAndNonTrivialEntrypoint): ditto.
(testEntrySwitchLoop): ditto.

  • ftl/FTLJITCode.h: use JSC::OpaqueByproducts.
  • ftl/FTLOutput.h: change includes.
  • jit/JITCompilation.cpp: Renamed from Source/JavaScriptCore/b3/B3Compilation.cpp.

(JSC::Compilation::Compilation):

  • jit/JITCompilation.h: Renamed from Source/JavaScriptCore/b3/B3Compilation.h.

(JSC::Compilation::code const):
(JSC::Compilation::codeRef const):

  • jit/JITOpaqueByproduct.h: Renamed from Source/JavaScriptCore/b3/B3OpaqueByproduct.h.
  • jit/JITOpaqueByproducts.cpp: Renamed from Source/JavaScriptCore/b3/B3OpaqueByproducts.cpp.
  • jit/JITOpaqueByproducts.h: Renamed from Source/JavaScriptCore/b3/B3OpaqueByproducts.h.
  • runtime/JSCPtrTag.h: rename B3CompilationPtrTag to JITCompilationPtrTag.
  • wasm/WasmB3IRGenerator.h: use JSC::OpaqueByproducts.
  • wasm/WasmBBQPlan.cpp: use JSC::Compilation.

(JSC::Wasm::BBQPlan::work):
(JSC::Wasm::BBQPlan::didCompleteCompilation):

  • wasm/WasmBinding.h: change includes.
  • wasm/WasmCallee.h: ditto.
  • wasm/WasmFormat.h: use JSC::Compilation.
  • wasm/WasmLLIntPlan.cpp: ditto.

(JSC::Wasm::LLIntPlan::didCompleteCompilation):

  • wasm/WasmLLIntPlan.h: use JITCompilationPtrTag.
  • wasm/WasmModule.h: ditto.
  • wasm/WasmOMGForOSREntryPlan.cpp: use JSC::Compilation.

(JSC::Wasm::OMGForOSREntryPlan::work):

  • wasm/WasmOMGPlan.cpp: ditto.

(JSC::Wasm::OMGPlan::work):

  • wasm/WasmParser.h: change includes.
  • wasm/js/WasmToJS.h: ditto.
4:14 PM Changeset in webkit [271593] by Fujii Hironori
  • 5 edits in trunk

[Win][DumpRenderTree] ASSERT(!m_channel) failed in WebSocket::contextDestroyed
​https://bugs.webkit.org/show_bug.cgi?id=220450

Reviewed by Per Arne Vollan.

Tools:

WebSocket::failAsynchronously() posts a deferred task calling
WebSocket::stop() by using callOnMainThread, but the task was not
executed soon because DumpRenderTree stopped running the run loop
after finishing the test.

DumpRenderTree's run loop should dispatch all deferred tasks
before finishing the current test. Deffer setting the variable
'done' by posting a application message.

  • DumpRenderTree/win/DumpRenderTree.cpp: Define a application message WM_DRT_TEST_DONE.

(DumpRenderTreeWndProc): Set 'done' in the case of WM_DRT_TEST_DONE.
(dump): Post WM_DRT_TEST_DONE.

LayoutTests:

  • platform/win/TestExpectations: Marked fast/events/currentTarget-gc-crash.html.
  • platform/wincairo-wk1/TestExpectations: Ditto.
4:07 PM Changeset in webkit [271592] by ysuzuki@apple.com
  • 4 edits
    2 adds in trunk

[JSC] earlyReturnFromInfiniteLoopsLimit should check all caller functions when emitting
​https://bugs.webkit.org/show_bug.cgi?id=220700
<rdar://problem/71229150>

Reviewed by Mark Lam.

JSTests:

  • stress/early-return-from-builtin.js: Added.

(let.o.get value):
(let.iter.Symbol.iterator):

  • stress/early-return-from-builtin2.js: Added.

(foo):

Source/JavaScriptCore:

earlyReturnFromInfiniteLoopsLimit does not return when the function is builtin. But this does not consider about the case that
the caller is inlining and the caller is builtin. Since this returns from entire DFG / FTL functions, we should check any of
callers are not builtin functions too.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileLoopHint):

4:06 PM Changeset in webkit [271591] by ysuzuki@apple.com
  • 1 edit
    1 add in trunk/JSTests

[JSC] Add another tests for r271571 part 2
​https://bugs.webkit.org/show_bug.cgi?id=220702
<rdar://problem/71365255>

Reviewed by Mark Lam.

This patch adds yet another test for r271571.

  • stress/ftl-osr-entry-order-reverse3.js: Added.

(foo.bar):
(foo):

4:04 PM Changeset in webkit [271590] by ysuzuki@apple.com
  • 1 edit
    1 add in trunk/JSTests

[JSC] Add another tests for r271571
​https://bugs.webkit.org/show_bug.cgi?id=220701
<rdar://problem/72464341>

Reviewed by Mark Lam.

This patch adds another test for r271571 "[JSC] FTL OSR entry FlushFormat array is reversed".

  • stress/ftl-osr-entry-order-reverse2.js: Added.

(foo):

4:03 PM Changeset in webkit [271589] by Andres Gonzalez
  • 2 edits in trunk/Source/WebCore

Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
​https://bugs.webkit.org/show_bug.cgi?id=220672
<rdar://problem/73045466>

Reviewed by Darin Adler.

The call to AccessibilityObject::setFocused to set the focus to the
scroll view needs to happen before the check for canSetFocusAttribute.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setFocused):

4:00 PM Changeset in webkit [271588] by ysuzuki@apple.com
  • 1 edit
    1 add in trunk/JSTests

[JSC] Add another tests for r271571 part 3
​https://bugs.webkit.org/show_bug.cgi?id=220703
<rdar://problem/71224976>

Reviewed by Mark Lam.

This patch adds yet another test for r271571.

  • stress/ftl-osr-entry-order-reverse4.js: Added.

(foo):

3:54 PM Changeset in webkit [271587] by Andres Gonzalez
  • 9 edits
    1 delete in trunk

Fix for LayoutTests/accessibility/canvas-fallback-content.html in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=220644

Reviewed by Chris Fleizach.

Source/WebCore:

Tests:
accessibility/canvas-fallback-content.html
accessibility/canvas-fallback-content-2.html

  • Updates the accessibility isolated tree when the ARIA role attribute

changes for a DOM element.

  • Modified tests to use Promises and retrieve accessible elements by IDs

so that they work in both isolated tree mode on and off.

  • accessibility/AXLogger.cpp:

(WebCore::operator<<): Added new value to the AXNotification enum.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaRoleChanged):
Updates the isolated tree when an ARIA role attribute changes.
(WebCore::AXObjectCache::updateIsolatedTree):
Handles the AXAriaRoleChanged notification.

  • accessibility/AXObjectCache.h:

LayoutTests:

  • accessibility/canvas-fallback-content-2-expected.txt:

Removed the checks for the document.activeElement since the goal here is
not to test this method.

  • accessibility/canvas-fallback-content-2.html:

Retrieved the accessibility Objects by ID directly from the accessibilityController.
This simplifies the code since it is not necessary to set focus to the
object via the document, to then retrieve the focused accessibility element.
This works for isolated tree mode on and off.

  • accessibility/canvas-fallback-content.html:

Kept the focus manipulations but used Promises to make it work in both
isolated mode on and off.

  • platform/win/accessibility/canvas-fallback-content-expected.txt: Deleted.
  • platform/win/TestExpectations: Skip since this test was already failing in win.
1:49 PM Changeset in webkit [271586] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[AppleWin 32bit] LLInt C Loop: LowLevelInterpreter.cpp(90,7): error C2653: 'WebConfig': is not a class or namespace name
​https://bugs.webkit.org/show_bug.cgi?id=220405

Reviewed by Fujii Hironori.

Add a missing #if ENABLE(UNIFIED_AND_FREEZABLE_CONFIG_RECORD).

  • llint/LowLevelInterpreter.cpp:
1:11 PM Changeset in webkit [271585] by Nikolas Zimmermann
  • 9 edits in trunk/Source

Remove recently added glue code: RenderLayer::(setAdjustForIOSCaretWhenScrolling / setScrollShouldClearLatchedState / setConstrainsScrollingToContentEdge)
​https://bugs.webkit.org/show_bug.cgi?id=220708

Reviewed by Adrian Perez de Castro.

Follow-up on patch adressing the removal of the glue code that
forwards calls from RenderLayer to RenderLayerScrollableArea (see
webkit.org/b/60305).

Covered by existing tests.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::revealSelection):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scroll):
(WebCore::RenderLayer::setAdjustForIOSCaretWhenScrolling): Deleted.
(WebCore::RenderLayer::setScrollShouldClearLatchedState): Deleted.
(WebCore::RenderLayer::setConstrainsScrollingToContentEdge): Deleted.

  • rendering/RenderLayer.h:
  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::RenderMarquee):

Source/WebKitLegacy/mac:

  • DOM/DOMHTML.mm:

(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):

  • WebView/WebFrame.mm:

(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _scrollDOMRangeToVisible:withInset:]):

12:26 PM Changeset in webkit [271584] by Antti Koivisto
  • 12 edits in trunk/Source/WebCore

Optimize :hover/:active style invalidation for deep trees and descendant selectors
​https://bugs.webkit.org/show_bug.cgi?id=220711

Reviewed by Zalan Bujtas.

Hover and active states are flipped for the entire ancestor chain. We compute invalidation for each flipped
element separately. If the selectors are of form ':active .descendant' then each of these invalidations needs
to traverse the whole subtree, leading to O(n2) behavior.

We really only need to traverse the descendants once, starting from the element closest to the root that changes state.

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

Compute the change root and pass the information to setActive/Hover.
Reorganize the function a bit to allow this, and for general readability.

  • dom/Element.cpp:

(WebCore::Element::setActive):
(WebCore::Element::setHovered):

  • dom/Element.h:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setActive):

  • html/HTMLAnchorElement.h:
  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):

  • html/HTMLLabelElement.h:
  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::setHovered):

  • html/shadow/SpinButtonElement.h:
  • style/PseudoClassChangeInvalidation.cpp:

(WebCore::Style::PseudoClassChangeInvalidation::computeInvalidation):

Only include descendant traversing rulesets for the change root.

  • style/PseudoClassChangeInvalidation.h:

(WebCore::Style::PseudoClassChangeInvalidation::PseudoClassChangeInvalidation):

12:13 PM Changeset in webkit [271583] by Fujii Hironori
  • 4 edits
    2 adds in trunk

createImageBitmap() causes null pointer dereference using Cairo lib
​https://bugs.webkit.org/show_bug.cgi?id=220584

Reviewed by Carlos Garcia Campos.

Source/WebCore:

createImageBitmap(ImageData) creates an internal ImageBuffer with
the same size of the given ImageData. Cairo port has the
limitation to maximum width/height of ImageBuffer as 32768. It
fails to create the internal ImageBuffer if the ImageData size is
greater than 32768. Added a null-checking for the case.

Test: fast/images/createImageBitmap-with-ImageData.html

  • html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise): Added a null-checking for
tempBitmapData. Call resolveWithBlankImageBuffer in the case.

  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::create): Check the
cairo_surface_status of 'surface' to avoid the assertion failure
in ImageBufferCairoImageSurfaceBackend ctor.

LayoutTests:

  • fast/images/createImageBitmap-with-ImageData-expected.txt: Added.
  • fast/images/createImageBitmap-with-ImageData.html: Added.
11:41 AM Changeset in webkit [271582] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][Integration] Disable inline boxes with outline
​https://bugs.webkit.org/show_bug.cgi?id=220698

Reviewed by Antti Koivisto.

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

11:40 AM Changeset in webkit [271581] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][Integration] Disable inflow positioned inline boxes
​https://bugs.webkit.org/show_bug.cgi?id=220696

Reviewed by Antti Koivisto.

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

8:09 AM WebKitGTK/2.30.x edited by Michael Catanzaro
(diff)
7:56 AM Changeset in webkit [271580] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Multilib conflicts in gir files
​https://bugs.webkit.org/show_bug.cgi?id=220636

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-01-18
Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

  • PlatformGTK.cmake:

Source/WebKit:

By passing --sources-top-dirs to g-ir-scanner, we ensure all paths in the generated gir
files are relative to the toplevel builddir. This avoids multilib conflicts when the
builddir contains the target architecture.

  • PlatformGTK.cmake:
5:16 AM Changeset in webkit [271579] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

[ Mac WK1 ] REGRESSION (r239145) Layout Test http/wpt/mediarecorder/MediaRecorder-dataavailable.html is flaky text diff failure
​https://bugs.webkit.org/show_bug.cgi?id=194779
<rdar://problem/48166474>

Tests are no longer flaky no webkit bots.
Unreviewed.

  • platform/ios/TestExpectations:
3:24 AM Changeset in webkit [271578] by Lauro Moura
  • 5 edits in trunk/Tools

[WPE] Fix WPEQt tests after r271514
​https://bugs.webkit.org/show_bug.cgi?id=220681

Reviewed by Carlos Garcia Campos.

Setting the title became async, so we must wait for it to be
processed.

  • TestWebKitAPI/Tests/WPEQt/TestLoad.cpp:

(TestLoad::main):

  • TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp:

(TestLoadHtml::main):

  • TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:

(TestLoadRequest::main):

  • TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:

(TestRunJavaScript::main):

2:29 AM Changeset in webkit [271577] by Nikolas Zimmermann
  • 7 edits in trunk/Source

Remove recently added glue code: RenderLayer::(scrollToOffset / scrollToXOffset / scrollToYOffset)
​https://bugs.webkit.org/show_bug.cgi?id=220705

Reviewed by Adrian Perez de Castro.

Follow-up on patch adressing the removal of the glue code that
forwards calls from RenderLayer to RenderLayerScrollableArea (see
webkit.org/b/60305).

Covered by existing tests.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::scrollTo const):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset): Deleted.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrollToXOffset): Deleted.
(WebCore::RenderLayer::scrollToYOffset): Deleted.

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::start):
(WebCore::RenderMarquee::timerFired):

Source/WebKitLegacy/mac:

  • DOM/DOMHTML.mm:

(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):

2:24 AM Changeset in webkit [271576] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[WPE][GTK] Mark that the AminatedBackingStoreClient has changed only when layer requires it
​https://bugs.webkit.org/show_bug.cgi?id=220590

Reviewed by Philippe Normand.

Mark AnimatedBackingStoreClient instance as changed when it really has changed. When the layer
doesn't require a client, make it nullptr and don't modify it anymore.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

12:40 AM Changeset in webkit [271575] by youenn@apple.com
  • 9 edits in trunk

WebRTC live Opus audio stream stutters
​https://bugs.webkit.org/show_bug.cgi?id=220599
<rdar://problem/73190139>

Reviewed by Darin Adler.

Source/WebCore:

Before the patch, the MediaStreamTrack was owning its audio source provider.
Two MediaStreamAudioSourceNode reading the same track would read on the same provider buffer.
Instead, create a provider for each node.

Covered by updated test.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::createAudioSourceProvider):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::provideInput):

  • Modules/webaudio/MediaStreamAudioSourceNode.h:
  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::createAudioSourceProvider):

  • platform/mediastream/MediaStreamTrackPrivate.h:

LayoutTests:

Add media stream source nodes to ensure that concurrent reading is not an issue anymore.

  • fast/mediastream/mock-media-source-webaudio.html:
12:40 AM Changeset in webkit [271574] by ysuzuki@apple.com
  • 3 edits
    1 add in trunk

[JSC] callerIsOMGCompiled should be robust
​https://bugs.webkit.org/show_bug.cgi?id=220697

Reviewed by Mark Lam.

JSTests:

  • stress/callerIsOMGCompiled-should-be-robust.js: Added.

Source/JavaScriptCore:

This function did not work if this function is called from microtask / unhandled rejection since there is no caller frame.
This patch makes this function more robust against such usage.

  • jsc.cpp:

(JSC_DEFINE_HOST_FUNCTION):

Note: See TracTimeline for information about the timeline view.