Timeline
Jan 29, 2021:
- 9:41 PM Changeset in webkit [272113] by
-
- 2 edits in branches/safari-611-branch/Source/WebCore
Cherry-pick r271551. rdar://problem/73473686
Scroll position is lost when homing out and resuming Safari on iOS
https://bugs.webkit.org/show_bug.cgi?id=220676
Reviewed by Tim Horton.
When homing out on iOS, UIKit snapshotting causes multiple web view resizes, which runs
the dynamicViewportSizeUpdate() logic. This can trigger programmatic scrolls via
FrameView::setContentsSize(), which get stored in the scrolling state tree. When
that tree is committed on resume, we then erroneously apply the programmatic
scrolls.
Fix by ignoring requested scroll positions updates when snapshotting, as we do when
we're in the page cache.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272112] by
-
- 2 edits in branches/safari-611-branch/Source/WebCore
Cherry-pick r271515. rdar://problem/73473627
REGRESSION(r269813): PLT5 regressed by 0.5%
https://bugs.webkit.org/show_bug.cgi?id=220652
<rdar://problem/71517335>
Reviewed by Antti Koivisto.
In r269813 we added support for animating more pseudo-elements besides ::after and ::before. However, the only other
pseudo-element we realistically should be supporting animations for at this juncture is ::marker. So instead of
calling Style::TreeResolver::resolvePseudoStyle() for all public pseudo-elements, we call it for ::after, ::before
and ::marker alone.
- style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272111] by
-
- 9 edits2 adds in branches/safari-611-branch
Cherry-pick r271507. rdar://problem/73473467
[Cocoa] Strip DataDetectors links when copying content to the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=220526
<rdar://problem/71045590>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Currently, when DataDetectors links are written to the pasteboard when
copied. This is problematic, since clicking on a DataDetector link
outside of a valid context results in an attempt to open an invalid
URL. Instead, DataDetectors links should be stripped when copied.
To remove the link, while preserving any custom styles, the <a> element
created by Data Detection is replaced with a <span> element. Any
attributes and styles added by WebKit are removed as a part of this
transformation.
Tests: editing/pasteboard/copy-paste-data-detected-links.html
CopyRTF.StripsDataDetectedLinks
PasteWebArchive.StripsDataDetectedLinks
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm: (WebCore::DataDetection::isDataDetectorElement):
Add a helper to check if an element was created through Data Detection.
- editing/cocoa/HTMLConverter.mm: (HTMLConverter::_addLinkForElement):
Do not add NSLinkAttributeName for DataDetectors links.
(HTMLConverter::_exitElement):
Factor out link creation logic.
- editing/markup.cpp: (WebCore::StyledMarkupAccumulator::spanReplacementForElement):
Centralize the logic that determines whether or not an element should
be replaced by a <span>. Previously, this only applied to <slot>
elements. Now, it applies to <slot> and DataDetectors links.
(WebCore::StyledMarkupAccumulator::appendStartTag):
If the element was created through DataDetection, append a <span>
rather than an <a>, to drop the link. The DataDetectors and href
attributes are also dropped from the markup string. Finally, remove
the text decoration style that was added by WebKit to style the
DataDetectors link.
(WebCore::StyledMarkupAccumulator::appendEndTag):
Consult shouldReplaceElementWithSpan when appending the end tag.
Tools:
Added API tests to verify DataDetectors links are not preserved when
copying/pasting WebArchives and rich text.
- TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm: (StripsDataDetectorsLinks):
- TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: (StripsDataDetectorsLinks):
LayoutTests:
Added a test which copies content containing two data detected links
and verifies that the links are removed.
- editing/pasteboard/copy-paste-data-detected-links-expected.txt: Added.
- editing/pasteboard/copy-paste-data-detected-links.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272110] by
-
- 18 edits in branches/safari-611-branch/Source
Cherry-pick r271503. rdar://problem/73473503
Add a quirk to disable "return to element fullscreen from picture-in-picture" for some sites
https://bugs.webkit.org/show_bug.cgi?id=220606
Reviewed by Eric Carlson.
Source/WebCore:
For iPads, we add the support of "return to element fullscreen from picture-in-picture" in r265562.
Unfortunately, some sites do not set element's styles properly when a video returns to fullscreen
from picture-in-picture. This patch adds a quirk to disable the feature for those sites for now.
- page/Quirks.cpp: (WebCore::Quirks::blocksReturnToFullscreenFromPictureInPictureQuirk const):
- page/Quirks.h:
- platform/ios/VideoFullscreenInterfaceAVKit.h:
- platform/ios/VideoFullscreenInterfaceAVKit.mm: (VideoFullscreenInterfaceAVKit::setupFullscreen): (VideoFullscreenInterfaceAVKit::didStartPictureInPicture):
- platform/ios/WebVideoFullscreenControllerAVKit.mm: (VideoFullscreenControllerContext::setUpFullscreen):
Source/WebKit:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):
- UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::blocksReturnToFullscreenFromPictureInPicture const): (WebKit::WebFullScreenManagerProxy::enterFullScreen):
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebFullScreenManagerProxy.messages.in:
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen]): (-[WKFullScreenWindowController didEnterPictureInPicture]):
- WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement):
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement):
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
- WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272109] by
-
- 16 edits3 adds in branches/safari-611-branch
Cherry-pick r271459. rdar://problem/73473665
[macOS] "Correct Spelling Automatically" menu items are inconsistent when autocorrect="off"
https://bugs.webkit.org/show_bug.cgi?id=220598
<rdar://problem/71713611>
Reviewed by Tim Horton.
Source/WebCore:
Disable the context menu item to toggle automatic spelling correction, as well as the menu bar item to toggle
automatic spelling correction, in the case where the autocorrect attribute is set to "off". See below for more
details.
Tests: editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item.html
DisableAutomaticSpellingCorrection.AutocorrectAttribute
- editing/AlternativeTextController.cpp: (WebCore::AlternativeTextController::canEnableAutomaticSpellingCorrection const):
Factor out logic for checking the
autocorrectattribute into a separate helper function; this is used to
determine whether or not we should enable both the context menu item and menu item in the menu bar.
(WebCore::AlternativeTextController::isAutomaticSpellingCorrectionEnabled):
- editing/AlternativeTextController.h: (WebCore::AlternativeTextController::UNLESS_ENABLED):
- editing/Editor.cpp: (WebCore::Editor::canEnableAutomaticSpellingCorrection const):
- editing/Editor.h:
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::checkOrEnableIfNeeded const):
Source/WebKit:
Plumb the new
canEnableAutomaticSpellingCorrectionflag throughEditorStateto the UI process, where we can
consult it when validating user interface items (namely, the "Correct Spelling Automatically" menu item, which
corresponds to the-toggleAutomaticSpellingCorrection:selector).
- Shared/EditorState.cpp: (WebKit::EditorState::PostLayoutData::encode const): (WebKit::EditorState::PostLayoutData::decode): (WebKit::operator<<):
- Shared/EditorState.h:
- UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::validateUserInterfaceItem):
- WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getPlatformEditorState const):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/DisableAutomaticSpellingCorrection.mm: Added.
Add a new API test to verify that the
NSMenuItemfor toggling automatic spelling correction is invalid when
editing inside a form control with autocorrect="off".
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::getMenuItemEnabledCallback):
Add the readonly
enabledJS property on context menu items. See the new layout test,
editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item.html, for more information.
LayoutTests:
Add a new API test to verify that the context menu item to toggle "Correct Spelling Automatically" is disabled
when autocorrect="off".
- editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item-expected.txt: Added.
- editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item.html: Added.
- platform/mac-wk1/TestExpectations:
Disable the test in DumpRenderTree, due to lack of support for context menu testing in WebKit1.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272108] by
-
- 2 edits in branches/safari-611-branch/Source/WebInspectorUI
Cherry-pick r271458. rdar://problem/73477098
Web Inspector: RTL content inside elements is reversed and unreadable
https://bugs.webkit.org/show_bug.cgi?id=220241
Patch by Ebrahim Byagowi <ebrahim@gnu.org> on 2021-01-13
Reviewed by BJ Burg.
Use appropiate unicode-bidi value so that it won't reverse RTL text
inside elements.
- UserInterface/Views/DOMTreeOutline.css: (.tree-outline.dom li > span > .html-text-node):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272107] by
-
- 8 edits2 adds in branches/safari-611-branch
Cherry-pick r271414. rdar://problem/73473727
REGRESSION (r265044): [macOS] Safari autocorrects text when typing in login field on amazon.com
https://bugs.webkit.org/show_bug.cgi?id=220556
<rdar://problem/71602937>
Reviewed by Darin Adler.
Source/WebCore:
Add an internal testing hook to ask an input element whether it has disabled spellchecking (except for text
replacement).
- testing/Internals.cpp: (WebCore::Internals::isSpellcheckDisabledExceptTextReplacement const):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Restores the implementation of
WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled, which was removed in
r265044, with the reasoning that the code was unused. However, Safari still uses this SPI on macOS to prevent
automatic spelling correction from triggering when editing form fields that are AutoFillable.
Test: WebKit.DisableSpellcheck
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled):
Tools:
Add an API test that uses WebKit C API (
WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled) to disable or
enable spellchecking on input elements.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/DisableSpellcheck.mm: Added.
- TestWebKitAPI/Tests/WebKitCocoa/DisableSpellcheckPlugIn.mm: Added. (-[DisableSpellcheckPlugIn webProcessPlugIn:didCreateBrowserContextController:]): (-[DisableSpellcheckPlugIn webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]): (-[DisableSpellcheckPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272106] by
-
- 3 edits3 adds in branches/safari-611-branch
Cherry-pick r271388. rdar://problem/73473676
Safari 14 on 2x display renders NYS DMV page as blurry
https://bugs.webkit.org/show_bug.cgi?id=220528
<rdar://problem/71440246>
Reviewed by Tim Horton.
Source/WebCore:
Certain combinations of nested perspective and transform cause Core Animation to
rasterize at unit scale, which makes layers blurry on Retina displays.
Enable code that was already used on iOS to set layer rasterization scale.
Test: compositing/contents-scale/hidpi-tests/rasterization-scale.html
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayerCocoa::setContentsScale):
LayoutTests:
- compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html: Added.
- compositing/contents-scale/hidpi-tests/rasterization-scale.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272105] by
-
- 3 edits in branches/safari-611-branch/Source/WebKit
Cherry-pick r271384. rdar://problem/73473494
Crash in pageDidComputePageRects()
https://bugs.webkit.org/show_bug.cgi?id=220518
<rdar://problem/71065870>
Reviewed by Ryosuke Niwa.
Make _printOperation a weak pointer and check it before use.
Since WKPrintingView is ref counted, a reference could still exist
even if _printOperation is nil. Remove the comment as it is not a
justification for a raw pointer.
- UIProcess/mac/WKPrintingView.h:
- UIProcess/mac/WKPrintingView.mm: (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): (-[WKPrintingView _firstPrintedPageNumber]): (-[WKPrintingView _lastPrintedPageNumber]): (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): (pageDidComputePageRects): (-[WKPrintingView _askPageToComputePageRects]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView _drawPreview:]): (-[WKPrintingView drawRect:]): (-[WKPrintingView _drawPageBorderWithSizeOnMainThread:]): (-[WKPrintingView drawPageBorderWithSize:]): (-[WKPrintingView rectForPage:]): (-[WKPrintingView locationOfPrintRect:]): (-[WKPrintingView beginDocument]): (-[WKPrintingView endDocument]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 PM Changeset in webkit [272104] by
-
- 6 edits in branches/safari-611-branch
Cherry-pick r271379. rdar://problem/73473604
Keep newly created IDBObjectStores in deleted map when IDBTransaction is aborted
https://bugs.webkit.org/show_bug.cgi?id=220483
<rdar://problem/71934293>
Patch by Sihui Liu <sihui_liu@appe.com> on 2021-01-11
Reviewed by Darin Adler.
Source/WebCore:
When an upgrade transaction is aborted, we move objects from m_deletedObjectStores to m_referencedObjectStores
to revert the deletion operation. When updating m_referencedObjectStores, we did not check whether key already
exists (this can happen when an object store gets deleted and a new object store with the same name is
created; see updated layout test). Therefore, some object store in m_referencedObjectStores would be replaced
and destroyed (since m_referencedObjectStores holds unique pointers) when the object store is referenced by JS
object.
Test: storage/indexeddb/modern/abort-objectstore-info.html
- Modules/indexeddb/IDBTransaction.cpp: (WebCore::IDBTransaction::internalAbort):
LayoutTests:
- storage/indexeddb/modern/abort-objectstore-info-expected.txt:
- storage/indexeddb/modern/abort-objectstore-info-private-expected.txt:
- storage/indexeddb/modern/resources/abort-objectstore-info.js: (prepareDatabase): (secondUpgradeNeeded): (checkState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:40 PM Changeset in webkit [272103] by
-
- 2 edits in branches/safari-611-branch/Source/WebKit
Cherry-pick r271374. rdar://problem/73477142
Web Inspector: add nullptr check for WebInspectorProxy::m_extensionsController
https://bugs.webkit.org/show_bug.cgi?id=220485
<rdar://72496401>
Reviewed by Devin Rousso.
- UIProcess/Inspector/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::frontendLoaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:40 PM Changeset in webkit [272102] by
-
- 5 edits in branches/safari-611-branch
Cherry-pick r271369. rdar://problem/73473654
WebProcessPool::establishWorkerContextConnectionToNetworkProcess should make sure to remove the selected process from the cache
https://bugs.webkit.org/show_bug.cgi?id=220503
Reviewed by Darin Adler.
Source/WebKit:
In case we reuse an existing web process, make sure to remove it from web process cache.
Covered by API test.
- UIProcess/WebProcessCache.cpp: (WebKit::WebProcessCache::addProcessIfPossible): (WebKit::WebProcessCache::addProcess):
- UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:40 PM Changeset in webkit [272101] by
-
- 3 edits5 adds in branches/safari-611-branch
Cherry-pick r271368. rdar://problem/73473690
Keep newly created IDBIndex objects in deleted map when IDBTransaction is aborted
https://bugs.webkit.org/show_bug.cgi?id=220489
<rdar://problem/70498831>
Patch by Sihui Liu <sihui_liu@appe.com> on 2021-01-11
Reviewed by Youenn Fablet.
Source/WebCore:
When an upgrade transaction is aborted, we move objects from m_deletedIndexes to m_referencedIndexes to revert
the index deletion operation. When updating m_referencedIndexes, we did not check whether key already exists.
Therefore, some indexes in m_referencedIndexes would be replaced and destroyed (since m_referencedIndexes holds
unique pointers) when the index is still referenced by JS.
Tests: storage/indexeddb/modern/abort-index-info-private.html
storage/indexeddb/modern/abort-index-info.html
- Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::rollbackForVersionChangeAbort):
LayoutTests:
- storage/indexeddb/modern/abort-index-info-expected.txt: Added.
- storage/indexeddb/modern/abort-index-info-private-expected.txt: Added.
- storage/indexeddb/modern/abort-index-info-private.html: Added.
- storage/indexeddb/modern/abort-index-info.html: Added.
- storage/indexeddb/modern/resources/abort-index-info.js: Added. (prepareDatabase): (versionChangeSuccessCallback.secondRequest.onerror): (versionChangeSuccessCallback): (secondUpgradeNeeded): (checkState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:35 PM Changeset in webkit [272100] by
-
- 20 edits in trunk
[LFC][RenderTreeAsText] Apply the "adjustForTableCells" quirk to line break runs
https://bugs.webkit.org/show_bug.cgi?id=221142
Reviewed by Antti Koivisto.
Source/WebCore:
When the table rows get stretched vertically as individual cells grow, the cell content
gets "aligned" vertically (not to confuse it with the align property) by offsetting each line.
However this offset is removed in the render tree dump for historical reasons.
This patch ensures that the modern line layout runs that we create for line breaks (<br>)
produce the same vertical position as the legacy layout runs.
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
LayoutTests:
- platform/ios/fast/table/005-expected.txt:
- platform/ios/tables/mozilla/bugs/bug106795-expected.txt:
- platform/ios/tables/mozilla/bugs/bug1224-expected.txt:
- platform/ios/tables/mozilla/bugs/bug16252-expected.txt:
- platform/ios/tables/mozilla/bugs/bug20579-expected.txt:
- platform/ios/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/ios/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/ios/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac-catalina/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac/fast/table/005-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106795-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1224-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16252-expected.txt:
- platform/mac/tables/mozilla/bugs/bug20579-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- 8:57 PM Changeset in webkit [272099] by
-
- 3 edits1 add in trunk
[JSC] Adjust property order of host JSFunction
https://bugs.webkit.org/show_bug.cgi?id=221168
Reviewed by Darin Adler.
JSTests:
- stress/host-function-property-order.js: Added.
(shouldBe):
Source/JavaScriptCore:
We should first define "length" before "name".
This will be included in upcoming test262 update[1].
[1]: https://github.com/tc39/test262/pull/2921
- runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
- 7:17 PM Changeset in webkit [272098] by
-
- 8 edits in branches/safari-611-branch/Source
Versioning.
WebKit-7611.1.14
- 7:10 PM Changeset in webkit [272097] by
-
- 56 edits in trunk/Source/WebCore
Devirtualize some functions on InputType
https://bugs.webkit.org/show_bug.cgi?id=221121
Reviewed by Yusuke Suzuki .
Virtual functions on InputType show up in Speedometer profiles. We can make
many of these virtual functions non-virtual by just switching on the input type.
- dom/Element.cpp:
- html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::isCheckable): Deleted.
- html/BaseCheckableInputType.h:
- html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::isTextType const): Deleted.
- html/BaseTextInputType.h:
- html/ButtonInputType.cpp:
(WebCore::ButtonInputType::isTextButton const): Deleted.
- html/ButtonInputType.h:
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::isCheckbox const): Deleted.
- html/CheckboxInputType.h:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::isColorControl const): Deleted.
- html/ColorInputType.h:
- html/DateInputType.cpp:
(WebCore::DateInputType::isDateField const): Deleted.
- html/DateInputType.h:
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::isDateTimeLocalField const): Deleted.
- html/DateTimeLocalInputType.h:
- html/EmailInputType.cpp:
(WebCore::EmailInputType::isEmailField const): Deleted.
- html/EmailInputType.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::isFileUpload const): Deleted.
- html/FileInputType.h:
- html/FormAssociatedElement.h:
- html/HTMLFormControlElement.h:
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::isHiddenType const): Deleted.
- html/HiddenInputType.h:
- html/ImageInputType.cpp:
(WebCore::ImageInputType::isImageButton const): Deleted.
(WebCore::ImageInputType::isEnumeratable): Deleted.
- html/ImageInputType.h:
- html/InputType.cpp:
(WebCore::InputType::isTextType const):
(WebCore::InputType::isTextField const):
(WebCore::InputType::isTextButton const):
(WebCore::InputType::isInteractiveContent const):
(WebCore::InputType::supportLabels const):
(WebCore::InputType::isEnumeratable):
(WebCore::InputType::isCheckable):
(WebCore::InputType::isRangeControl const): Deleted.
(WebCore::InputType::isRadioButton const): Deleted.
(WebCore::InputType::isSearchField const): Deleted.
(WebCore::InputType::isHiddenType const): Deleted.
(WebCore::InputType::isPasswordField const): Deleted.
(WebCore::InputType::isCheckbox const): Deleted.
(WebCore::InputType::isEmailField const): Deleted.
(WebCore::InputType::isFileUpload const): Deleted.
(WebCore::InputType::isImageButton const): Deleted.
(WebCore::InputType::isNumberField const): Deleted.
(WebCore::InputType::isSubmitButton const): Deleted.
(WebCore::InputType::isTelephoneField const): Deleted.
(WebCore::InputType::isURLField const): Deleted.
(WebCore::InputType::isDateField const): Deleted.
(WebCore::InputType::isDateTimeField const): Deleted.
(WebCore::InputType::isDateTimeLocalField const): Deleted.
(WebCore::InputType::isMonthField const): Deleted.
(WebCore::InputType::isTimeField const): Deleted.
(WebCore::InputType::isWeekField const): Deleted.
(WebCore::InputType::isColorControl const): Deleted.
- html/InputType.h:
(WebCore::InputType::isCheckbox const):
(WebCore::InputType::isColorControl const):
(WebCore::InputType::isDateField const):
(WebCore::InputType::isDateTimeField const):
(WebCore::InputType::isDateTimeLocalField const):
(WebCore::InputType::isEmailField const):
(WebCore::InputType::isFileUpload const):
(WebCore::InputType::isHiddenType const):
(WebCore::InputType::isImageButton const):
(WebCore::InputType::isMonthField const):
(WebCore::InputType::isNumberField const):
(WebCore::InputType::isPasswordField const):
(WebCore::InputType::isRadioButton const):
(WebCore::InputType::isRangeControl const):
(WebCore::InputType::isSearchField const):
(WebCore::InputType::isSubmitButton const):
(WebCore::InputType::isTelephoneField const):
(WebCore::InputType::isTimeField const):
(WebCore::InputType::isURLField const):
(WebCore::InputType::isWeekField const):
- html/MonthInputType.cpp:
(WebCore::MonthInputType::isMonthField const): Deleted.
- html/MonthInputType.h:
- html/NumberInputType.cpp:
(WebCore::NumberInputType::isNumberField const): Deleted.
- html/NumberInputType.h:
- html/PasswordInputType.cpp:
(WebCore::PasswordInputType::isPasswordField const): Deleted.
- html/PasswordInputType.h:
- html/RadioInputType.cpp:
(WebCore::RadioInputType::isRadioButton const): Deleted.
- html/RadioInputType.h:
- html/RangeInputType.cpp:
(WebCore::RangeInputType::isRangeControl const): Deleted.
- html/RangeInputType.h:
- html/ResetInputType.cpp:
(WebCore::ResetInputType::isTextButton const): Deleted.
- html/ResetInputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::isSearchField const): Deleted.
- html/SearchInputType.h:
- html/SubmitInputType.cpp:
(WebCore::SubmitInputType::isSubmitButton const): Deleted.
(WebCore::SubmitInputType::isTextButton const): Deleted.
- html/SubmitInputType.h:
- html/TelephoneInputType.cpp:
(WebCore::TelephoneInputType::isTelephoneField const): Deleted.
- html/TelephoneInputType.h:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::isTextField const): Deleted.
- html/TextFieldInputType.h:
- html/TimeInputType.cpp:
(WebCore::TimeInputType::isTimeField const): Deleted.
- html/TimeInputType.h:
- html/URLInputType.cpp:
(WebCore::URLInputType::isURLField const): Deleted.
- html/URLInputType.h:
- html/WeekInputType.cpp:
(WebCore::WeekInputType::isWeekField const): Deleted.
- html/WeekInputType.h:
- 6:39 PM Changeset in webkit [272096] by
-
- 11 edits in trunk/Source
Add plumbing to allow AppHighlights to be restored.
https://bugs.webkit.org/show_bug.cgi?id=221123
Reviewed by Wenson Hsieh.
Source/WebCore:
- Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::restoreAppHighlights):
- Modules/highlight/AppHighlightStorage.h:
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _restoreAppHighlights:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::restoreAppHighlights):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreAppHighlights):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 6:16 PM Changeset in webkit [272095] by
-
- 5 edits in trunk/Source/WTF
Make check for full HashTables opt-in
https://bugs.webkit.org/show_bug.cgi?id=221166
<rdar://problem/70902458>
Reviewed by Saam Barati and Yusuke Suzuki.
Having the check always on was a regression on Speedometer2, so we only keep it for
the HashMaps in the MetaAllocator.
- wtf/HashTable.h:
(WTF::KeyTraits>::inlineLookup):
(WTF::KeyTraits>::lookupForWriting):
(WTF::KeyTraits>::fullLookupForWriting):
(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::add):
- wtf/HashTraits.h:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::addFreeSpace):
- wtf/MetaAllocator.h:
- 6:13 PM Changeset in webkit [272094] by
-
- 4 edits in trunk/Source/WebCore
Update consumeNumberRaw() to return an Optional<double> rather than using a bool/out parameter pattern
https://bugs.webkit.org/show_bug.cgi?id=221164
Reviewed by Darin Adler.
Match modern convention and the other raw consumers by returning a Optional<double>
rather than using the older bool / out parameter pattern.
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFontVariationTag):
(WebCore::consumeCubicBezier):
(WebCore::consumeSpringFunction):
(WebCore::consumePerspective):
(WebCore::consumeCursor):
(WebCore::CSSPropertyParser::consumeFlex):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumberRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumberRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumberRaw):
(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::parseOptionalAlpha):
(WebCore::CSSPropertyParserHelpers::parseLabParameters):
(WebCore::CSSPropertyParserHelpers::parseLCHParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForRGBTypes):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForLabParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
(WebCore::CSSPropertyParserHelpers::consumeColorWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientColorStop):
(WebCore::CSSPropertyParserHelpers::consumeLineHeightRaw):
- css/parser/CSSPropertyParserHelpers.h:
- 5:52 PM Changeset in webkit [272093] by
-
- 2 edits in trunk/Tools
[webkitpy] Thread.isAlive was renamed to Thread.is_alive
https://bugs.webkit.org/show_bug.cgi?id=221160
Reviewed by Jonathan Bedard.
Python 2.6 added threading.Thread.is_alive which aliased isAlive. In Python 3.x only
threading.Thread.is_alive is available so use that instead.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._run_test_in_another_thread):
- 5:25 PM Changeset in webkit [272092] by
-
- 1 copy in tags/Safari-611.1.13
Tag Safari-611.1.13.
- 5:25 PM Changeset in webkit [272091] by
-
- 1 delete in tags/Safari-611.1.13
Delete tag.
- 5:19 PM Changeset in webkit [272090] by
-
- 5 edits in branches/safari-611-branch/Source
Cherry-pick r271619. rdar://problem/73461349
REGRESSION(r269865) Mail's context menu when right clicking on a link does not contain correct entries
https://bugs.webkit.org/show_bug.cgi?id=220745
Patch by Alex Christensen <achristensen@webkit.org> on 2021-01-19
Reviewed by Tim Horton.
Source/WebCore:
r269865 broke binary compatibility by changing the values of many WebCore::ContextMenuAction values and many WKContextMenuItemTag values,
and not in the same way. In WebContextMenuProxyMac::getContextMenuItem we call NSMenuItem setTag: with the value from WebCore::ContextMenuAction
and mail compares those values with values from WKContextMenuItemTag in our C API. This isn't ideal, but we need to retain binary compatibility.
- platform/ContextMenuItem.h:
Source/WebKit:
- Shared/API/c/WKContextMenuItem.cpp: Add a bunch of static_asserts to verify that our binary values correspond to each other and don't change.
- Shared/API/c/WKContextMenuItemTypes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:16 PM Changeset in webkit [272089] by
-
- 2 edits in trunk/Websites/webkit.org
Remove non-inclusive language from webkit.org/blog-files/css-jit-introduction/html5-single-page-microbenchmark.html
https://bugs.webkit.org/show_bug.cgi?id=221154
Reviewed by Geoffrey Garen.
- blog-files/css-jit-introduction/html5-single-page-microbenchmark.html:
- 4:51 PM Changeset in webkit [272088] by
-
- 1 copy in tags/Safari-611.1.13
Tag Safari-611.1.13.
- 4:51 PM Changeset in webkit [272087] by
-
- 1 delete in tags/Safari-611.1.13
Delete tag.
- 4:36 PM Changeset in webkit [272086] by
-
- 3 edits in trunk/Source/JavaScriptCore
SourceParseMode should be a member of the JSC::Parser
https://bugs.webkit.org/show_bug.cgi?id=221149
Reviewed by Ross Kirsling.
Right now we pass the SourceParseMode as a argument to many of the
functions in the parser. This patch move it into a member on the
class. This will make it available deeper in the parser, which is
important for implementing top level await.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseModuleSourceElements):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parseFunctionExpression):
(JSC::Parser<LexerType>::parseAsyncFunctionExpression):
(JSC::Parser<LexerType>::parseArrowFunctionExpression):
- parser/Parser.h:
(JSC::Parser::sourceParseMode const):
(JSC::Parser<LexerType>::parse):
(JSC::parse):
(JSC::parseFunctionForFunctionConstructor):
- 4:30 PM Changeset in webkit [272085] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, internal build fix after r272082
https://bugs.webkit.org/show_bug.cgi?id=221147
- runtime/Options.cpp:
(JSC::canUseJITCage):
- 4:18 PM Changeset in webkit [272084] by
-
- 3 edits2 adds in trunk
WebKit doesn't automatically right-align Adlam
https://bugs.webkit.org/show_bug.cgi?id=220885
Reviewed by Alex Christensen.
Source/WTF:
If we want to iterate across code points, we have to actually
iterate across code points instead of iterating across code units.
Test: fast/text/adlam-dir-auto.html
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::defaultWritingDirection):
LayoutTests:
- fast/text/adlam-dir-auto-expected.html: Added.
- fast/text/adlam-dir-auto.html: Added.
- 3:32 PM Changeset in webkit [272083] by
-
- 2 edits in trunk/Tools
Upgrade motionmark1.1.plan to r272044
https://bugs.webkit.org/show_bug.cgi?id=221148
Reviewed by Said Abou-Hallawa.
r272044 is attempting to address extreme variance in the test.
- Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan:
- 3:31 PM Changeset in webkit [272082] by
-
- 5 edits in trunk/Source
[JSC] Add com.apple.private.securejit entitlement for JITCage
https://bugs.webkit.org/show_bug.cgi?id=221147
Reviewed by Keith Miller.
Source/JavaScriptCore:
Add com.apple.private.securejit only for iOS, used for JITCage.
- entitlements.plist:
- runtime/Options.cpp:
(JSC::canUseJITCage):
Source/WebKit:
Add com.apple.private.securejit only for iOS.
- Scripts/process-entitlements.sh:
- 3:07 PM Changeset in webkit [272081] by
-
- 7 edits1 add in trunk
[JSC] Fix WebAssembly.Global's error message and support "funcref"
https://bugs.webkit.org/show_bug.cgi?id=221157
Reviewed by Keith Miller.
JSTests:
- wasm/stress/global-wrong-type.js: Added.
(assert.throws):
LayoutTests/imported/w3c:
We also update test expect files failing after r272074.
- web-platform-tests/wasm/jsapi/global/type.tentative.any-expected.txt:
- web-platform-tests/wasm/jsapi/global/type.tentative.any.worker-expected.txt:
Source/JavaScriptCore:
Since it accepts "anyfunc" and "externref", we should update the error message.
And we should support "funcref" too.
- wasm/js/WebAssemblyGlobalConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- wasm/js/WebAssemblyTableConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- 2:55 PM Changeset in webkit [272080] by
-
- 8 edits in branches/safari-611-branch/Source/JavaScriptCore
[JSC] Avoid using DirectCall when executable is wasm function
https://bugs.webkit.org/show_bug.cgi?id=221055
Reviewed by Keith Miller.
This is a partial patch from https://bugs.webkit.org/show_bug.cgi?id=220339, which is reverted because of Facebook crash.
For now, we just avoid using DirectCall to wasm functions so that normal Call will be used, and it is efficient. This
patch avoids JetStream2 regression.
- dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- jit/JITOperations.cpp:
(JSC::virtualForWithFunction):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
- runtime/Intrinsic.cpp:
(JSC::intrinsicName):
- runtime/Intrinsic.h:
- wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::create):
Canonical link: https://commits.webkit.org/233420@main
- 2:55 PM Changeset in webkit [272079] by
-
- 12 edits in branches/safari-611-branch
Revert "[JSC] DFG/FTL DirectCall need to respect Wasm IC"
This reverts commit a125d083477069e9cb6bebbe6426eea7919499e4.
- 2:00 PM Changeset in webkit [272078] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r272065.
https://bugs.webkit.org/show_bug.cgi?id=221155
Introduced crash
Reverted changeset:
"[macOS] Add reporting for some syscalls"
https://bugs.webkit.org/show_bug.cgi?id=221135
https://trac.webkit.org/changeset/272065
- 1:42 PM Changeset in webkit [272077] by
-
- 1 copy in tags/Safari-610.4.3.1.6
Tag Safari-610.4.3.1.6.
- 1:37 PM Changeset in webkit [272076] by
-
- 8 edits in branches/safari-610.4.3.1-branch/Source
Versioning.
WebKit-7610.4.3.1.6
- 1:26 PM Changeset in webkit [272075] by
-
- 15 edits in trunk/Source/WebCore
Remove unused GraphicsContextGL::Destination enum class
https://bugs.webkit.org/show_bug.cgi?id=221122
Reviewed by Kenneth Russell.
It was used by Chromium port.
- platform/graphics/GraphicsContextGL.h:
(WebCore::GraphicsContextGL::destination const): Deleted.
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::create):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
- platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:
(Nicosia::GCGLANGLELayer::GCGLANGLELayer):
- platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h:
- platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:
(Nicosia::GCGLLayer::GCGLLayer):
- platform/graphics/nicosia/texmap/NicosiaGCGLLayer.h:
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:
(WebCore::GraphicsContextGLOpenGL::create):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
- platform/graphics/opengl/GraphicsContextGLOpenGLPrivate.cpp:
(WebCore::GraphicsContextGLOpenGLPrivate::GraphicsContextGLOpenGLPrivate):
- platform/graphics/opengl/GraphicsContextGLOpenGLPrivate.h:
- platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
(WebCore::GraphicsContextGLOpenGL::create):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL): Fix a compilation error by renaming texureType to textureTarget.
- platform/graphics/texmap/TextureMapperGCGLPlatformLayer.cpp:
(WebCore::TextureMapperGCGLPlatformLayer::TextureMapperGCGLPlatformLayer):
- platform/graphics/texmap/TextureMapperGCGLPlatformLayer.h:
- 12:59 PM Changeset in webkit [272074] by
-
- 11 edits in trunk
[WASM-References] Enable reference types by default
https://bugs.webkit.org/show_bug.cgi?id=220890
Patch by Dmitry Bezhetskov <dbezhetskov> on 2021-01-29
Reviewed by Yusuke Suzuki.
Enable wasm reference types by default.
Source/JavaScriptCore:
- runtime/OptionsList.h:
Tools:
- Scripts/run-jsc-stress-tests:
- 12:19 PM Changeset in webkit [272073] by
-
- 11 edits18 adds in trunk
font-stretch is not applied to system-ui
https://bugs.webkit.org/show_bug.cgi?id=221103
<rdar://problem/73719139>
Reviewed by Darin Adler.
Source/WebCore:
We just never hooked it up.
Tests: fast/text/system-font-width-2.html
fast/text/system-font-width-3.html
fast/text/system-font-width-4.html
fast/text/system-font-width-5.html
fast/text/system-font-width-6.html
fast/text/system-font-width-7.html
fast/text/system-font-width-8.html
fast/text/system-font-width-9.html
fast/text/system-font-width.html
- platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::createSystemUIFont):
(WebCore::SystemFontDatabaseCoreText::createSystemDesignFont):
(WebCore::SystemFontDatabaseCoreText::createTextStyleFont):
(WebCore::SystemFontDatabaseCoreText::createFontByApplyingWeightWidthItalicsAndFallbackBehavior):
(WebCore::mapWeight):
(WebCore::mapWidth):
(WebCore::SystemFontDatabaseCoreText::systemFontParameters):
(WebCore::SystemFontDatabaseCoreText::createFontByApplyingWeightItalicsAndFallbackBehavior): Deleted.
- platform/graphics/cocoa/SystemFontDatabaseCoreText.h:
(WebCore::SystemFontDatabaseCoreText::CascadeListParameters::operator== const):
(WebCore::SystemFontDatabaseCoreText::CascadeListParameters::hash const):
Source/WebCore/PAL:
- pal/spi/cocoa/CoreTextSPI.h:
Source/WTF:
- wtf/PlatformHave.h:
LayoutTests:
- fast/text/system-font-width-2-expected-mismatch.html: Added.
- fast/text/system-font-width-2.html: Added.
- fast/text/system-font-width-3-expected-mismatch.html: Added.
- fast/text/system-font-width-3.html: Added.
- fast/text/system-font-width-4-expected-mismatch.html: Added.
- fast/text/system-font-width-4.html: Added.
- fast/text/system-font-width-5-expected.html: Added.
- fast/text/system-font-width-5.html: Added.
- fast/text/system-font-width-6-expected-mismatch.html: Added.
- fast/text/system-font-width-6.html: Added.
- fast/text/system-font-width-7-expected-mismatch.html: Added.
- fast/text/system-font-width-7.html: Added.
- fast/text/system-font-width-8-expected-mismatch.html: Added.
- fast/text/system-font-width-8.html: Added.
- fast/text/system-font-width-9-expected-mismatch.html: Added.
- fast/text/system-font-width-9.html: Added.
- fast/text/system-font-width-expected-mismatch.html: Added.
- fast/text/system-font-width.html: Added.
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 11:31 AM Changeset in webkit [272072] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Stop observing changes in one preference domain
https://bugs.webkit.org/show_bug.cgi?id=221130
<rdar://problem/70729182>
Reviewed by Brent Fulgham.
It has been determined that there is no need to observe preference changes in the domain 'com.apple.Preferences'.
- UIProcess/Cocoa/PreferenceObserver.mm:
(-[WKPreferenceObserver init]):
- 11:26 AM Changeset in webkit [272071] by
-
- 8 edits1 add in trunk
[JSC] WebAssembly.Global should support Funcref and Externref
https://bugs.webkit.org/show_bug.cgi?id=220914
Patch by Dmitry Bezhetskov <dbezhetskov> on 2021-01-29
Reviewed by Yusuke Suzuki.
JSTests:
Add tests for WebAssembly.Global ctors with
new reference types:
https://webassembly.github.io/reference-types/js-api/index.html#dom-global-global.
- wasm/references/globals.js: Added.
(Pelmen):
(testGlobalConstructorForExternref):
(async testGlobalConstructorForFuncref):
Source/JavaScriptCore:
Allow using reference types in ctor of WebAssembly.Global
according to the spec
https://webassembly.github.io/reference-types/js-api/index.html#dom-global-global.
- wasm/js/WebAssemblyGlobalConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- 11:25 AM Changeset in webkit [272070] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Add audio related shm write reporting
https://bugs.webkit.org/show_bug.cgi?id=221136
<rdar://problem/73510094>
Reviewed by Brent Fulgham.
Add audio related shm write reporting in the WebContent process' sandbox.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:22 AM Changeset in webkit [272069] by
-
- 3 edits in trunk/Source/WebKit
[macOS] Remove access to IOSurfaceSendRight
https://bugs.webkit.org/show_bug.cgi?id=221131
<rdar://problem/70496356>
Reviewed by Brent Fulgham.
Remove access to IOSurfaceSendRight in the WebContent process on macOS, since there are no reports of this being used.
- UIProcess/WebPageProxy.cpp:
(WebKit::gpuIOKitClasses):
- WebProcess/com.apple.WebProcess.sb.in:
- 11:14 AM Changeset in webkit [272068] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r272020 and r272034.
https://bugs.webkit.org/show_bug.cgi?id=221144
Revert potentially related change while investigating crash
Reverted changesets:
"[macOS] WebProcess::updateProcessName should initiate network
process connection if none exists"
https://bugs.webkit.org/show_bug.cgi?id=221094
https://trac.webkit.org/changeset/272020
"Unreviewed macOS build fix after r272020."
https://trac.webkit.org/changeset/272034
- 11:07 AM Changeset in webkit [272067] by
-
- 22 edits2 adds in trunk
Support for aria-current state changed notifications.
https://bugs.webkit.org/show_bug.cgi?id=221074
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/aria-current-state-changed-notification.html
Added handling of the AXCurrentStateChanged notification for Mac and iOS
ports. This notification is fired when the aria-current attribute
changes.
Handling of this notification is required to properly update the
accessibility properties of the target object and convey them to
assistive technology clients.
- accessibility/AXLogger.cpp:
(WebCore::operator<<): Renamed notification anumerand.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
- accessibility/AXObjectCache.h:
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityDOMIdentifier]):
(-[WebAccessibilityObjectWrapper postCurrentStateChangedNotification]):
(-[WebAccessibilityObjectWrapper accessibilityCurrentState]):
(-[WebAccessibilityObjectWrapper accessibilityARIACurrentStatus]): Renamed to accessibilityCurrentState.
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
Tools:
Added AccessibilityUIElement::domIdentifier and currentStateValue used
in LayoutTests/accessibility/aria-current-state-changed-notification.html.
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::domIdentifier const): Non-Cocoa implementation.
(WTR::AccessibilityUIElement::currentStateValue const): Non-Cocoa implementation.
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::domIdentifier const):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::currentStateValue const):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::domIdentifier const):
(WTR::AccessibilityUIElement::currentStateValue const):
LayoutTests:
- accessibility/aria-current-state-changed-notification-expected.txt: Added.
- accessibility/aria-current-state-changed-notification.html: Added.
- accessibility/aria-current.html:
Use AccessibilityUIElement::currentStateValue for consistency and to
match closely how actual clients will invoke this functionality.
- platform/gtk/TestExpectations:
- platform/ios-wk1/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- 10:48 AM Changeset in webkit [272066] by
-
- 7 edits2 adds in trunk/Source/WebCore
Extract color model and transfer functions into their own files
https://bugs.webkit.org/show_bug.cgi?id=221105
Reviewed by Tim Horton.
Things are getting a bit cramped in ColorTypes.h and ColorConversions.
This extracts the color models into ColorModels.h and gamma transfer
functions into ColorTransferFunctions.h and generalized the transfer
functions a bit to reduce the code size.
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ColorModels.h: Added.
- platform/graphics/ColorTransferFunctions.h: Added.
- platform/graphics/ColorConversion.cpp:
- platform/graphics/ColorConversion.h:
- platform/graphics/ColorTypes.h:
Move code to new files.
- 10:40 AM Changeset in webkit [272065] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Add reporting for some syscalls
https://bugs.webkit.org/show_bug.cgi?id=221135
<rdar://problem/73513138>
Reviewed by Brent Fulgham.
Add reporting for some syscalls in the WebContent process on macOS in order to determine if they are being used.
- WebProcess/com.apple.WebProcess.sb.in:
- 10:11 AM Changeset in webkit [272064] by
-
- 6 edits in trunk
check-webkit-style: warn about WTF::BlockPtr use in JavaScriptCore until ARC is enabled
<https://webkit.org/b/221108>
<rdar://problem/73726640>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- API/JSVirtualMachine.mm:
- inspector/remote/RemoteConnectionToTarget.h:
- Remove or replace unused <wtf/BlockPtr.h> headers.
Tools:
- Scripts/webkitpy/style/checkers/cpp.py:
(_is_javascriptcore_file): Add.
- Extract code to reuse from check_identifier_name_in_declaration().
(check_include_line):
(check_language):
- Add check for use of WTF::BlockPtr.
(check_identifier_name_in_declaration):
- Use _is_javascriptcore_file().
(CppChecker):
- Add 'security/javascriptcore_wtf_blockptr' to list of checkers.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTestBase.perform_language_rules_check):
- Add 'security/javascriptcore_wtf_blockptr' to list of checkers for testing header includes.
(OrderOfIncludesTest.test_check_wtf_blockptr_usage_in_javascriptcore):
- Add test to detect use of WTF::BlockPtr in JavaScriptCore.
- 9:34 AM Changeset in webkit [272063] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [BigSur wk1] media/mediacapabilities/vp9.html is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=221095
Unreviewed test gardening.
Patch by Amir Mark Jr <Amir Mark Jr.> on 2021-01-29
- platform/mac-wk1/TestExpectations:
- 9:20 AM Changeset in webkit [272062] by
-
- 2 edits in trunk/Source/WebCore
[LFC][Integration] Switch over to legacy line layout when inline tree is required
https://bugs.webkit.org/show_bug.cgi?id=221118
Reviewed by Antti Koivisto.
These functions still require inline tree.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::generateLineBoxRects const):
(WebCore::RenderInline::absoluteRects const):
(WebCore::RenderInline::absoluteQuads const):
(WebCore::RenderInline::absoluteQuadsIgnoringContinuation const):
(WebCore::RenderInline::addFocusRingRects):
- 9:15 AM Changeset in webkit [272061] by
-
- 2 edits in trunk/LayoutTests
Two 'tests' are running with out expectation files that are not real tests.
https://bugs.webkit.org/show_bug.cgi?id=208477
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 7:11 AM Changeset in webkit [272060] by
-
- 14 edits2 adds in trunk
Unreviewed, reverting r272052.
https://bugs.webkit.org/show_bug.cgi?id=221132
WPT mediacapture-record/MediaRecorder-stop.html is broken
Reverted changeset:
"Use WebRTC GPU process flag for MediaRecorder"
https://bugs.webkit.org/show_bug.cgi?id=220967
https://trac.webkit.org/changeset/272052
- 6:53 AM Changeset in webkit [272059] by
-
- 3 edits2 adds in trunk
REGRESSION(r262893): feComponentTransfer is not rendered correctly on Retina display
https://bugs.webkit.org/show_bug.cgi?id=220576
Reviewed by Simon Fraser.
Source/WebCore:
convertImageDataToColorSpace() creates a temporary ImageBuffer with the
size of m_premultipliedImageResult. This ImageBuffer has to be scaled
with the filterScale(). But the size of m_premultipliedImageResult is
scaled with the filterScale(). This means, convertImageDataToColorSpace()
applies the filterScale() twice to the temporary ImageBuffer.
The fix is to create the temporary ImageBuffer with the unscaled size of
the input ImageData and scale it with the filterScale().
Test: fast/hidpi/filters-component-transfer.html
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::convertImageDataToColorSpace):
(WebCore::FilterEffect::copyPremultipliedResult):
LayoutTests:
- fast/hidpi/filters-component-transfer-expected.html: Added.
- fast/hidpi/filters-component-transfer.html: Added.
- 5:03 AM Changeset in webkit [272058] by
-
- 17 edits in trunk/Source/WebKit
Some type serialization encoders are implemented in Encoder class
https://bugs.webkit.org/show_bug.cgi?id=220519
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-01-29
Reviewed by Chris Dumez.
Move arithmetic type and enum type serialization from Encoder to
ArgumentCoder. This makes it a bit simpler to implement multiple
Encoder types, as the serialization code is consistently separate
from the Encoder. WebGL SHM IPC stream extensions would eventually
need a similar but slightly different Encoder.
Since Encoder is intentionally coupled with the Decoder, do the
corresponding modification to Decoder class for consistency.
Reimplement Has{Legacy,Modern}Decoder for ease of forward declaration
and (perhaps?) in a bit simpler terms.
Encoder::operator<<() and Encoder::encode() were the same function.
Remove Encoder::encode().
No new tests, a refactor.
- NetworkProcess/NetworkSocketChannel.h:
- Platform/IPC/ArgumentCoder.h:
(IPC::Detail::TestLegacyDecoder):
(IPC::Detail::TestModernDecoder):
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/Connection.h:
(IPC::Connection::send):
(IPC::Connection::sendWithAsyncReply):
(IPC::Connection::sendSync):
- Platform/IPC/Decoder.h:
(IPC::Decoder::decode):
(IPC::Decoder::operator>>):
- Platform/IPC/Encoder.h:
- Platform/IPC/MessageSender.h:
- Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::Connection::open):
- Platform/cocoa/SharedMemoryCocoa.cpp:
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode const):
- Shared/RemoteLayerTree/RemoteScrollingUIState.cpp:
(WebKit::RemoteScrollingUIState::encode const):
- UIProcess/AuxiliaryProcessProxy.h:
(WebKit::AuxiliaryProcessProxy::send):
(WebKit::AuxiliaryProcessProxy::sendWithAsyncReply):
- WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPC::sendMessage):
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
- 3:01 AM Changeset in webkit [272057] by
-
- 4 edits in trunk/Source
[GTK] return-type-c-linkage warnings
https://bugs.webkit.org/show_bug.cgi?id=221047
Patch by Philippe Normand <pnormand@igalia.com> on 2021-01-29
Reviewed by Carlos Garcia Campos.
Remove extern "C" braces, un-needed for private C++ objects.
Source/WebCore:
- platform/network/soup/WebKitFormDataInputStream.h:
Source/WebKit:
- NetworkProcess/soup/WebKitDirectoryInputStream.h:
- 2:46 AM Changeset in webkit [272056] by
-
- 4 edits in trunk/Tools
[JSC] Implement --artifact-exec-wrapper
https://bugs.webkit.org/show_bug.cgi?id=220924
Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2021-01-29
Reviewed by Carlos Alberto Lopez Perez.
Add an option to specify a wrapper for executing the built
artifacts for JSC (i.e. jsc, testmasm, ...). This is useful when
crossbuilding, to be able to specify the ELF interpreter and
LD_LIBRARY_PATH for the built executables (and only those; the
scripts may well execute native binaries that shouldn't be
wrapped). It's not needed when running the tests on the remotes
(as generate-bundle will take care of all that), but helps
e.g. when running 32-bit ARM binaries on a 64-bit host and not
using the system compiler/libraries.
This patch also simplifies the bytecode cache helper by switching
the argument order and changes a couple of uses of pathToVM to
vmCommand for consistency. It should be noted that
--artifact-exec-wrapper is not compatible with
--force-architecture. That shouldn't be a problem as (a) the use
cases of the two flags don't seem to overlap and (b) the exec
wrapper can subsume the functionality of --force-architecture.
- Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
- Scripts/run-javascriptcore-tests:
(runTest):
(runJSCStressTests):
- Scripts/run-jsc-stress-tests:
- 2:36 AM Changeset in webkit [272055] by
-
- 9 edits in trunk
[GStreamer][Playbin3] Support for CEA-608 closed captioned media
https://bugs.webkit.org/show_bug.cgi?id=220654
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Playbin2 currently doesn't support closed-caption formats such as CEA-608 and CEA-708.
However playbin3's decodebin3 will expose a source pad for these, so our text combiner can
handle this format, by adding a custom encoder that converts CEA-608 to WebVTT.
No new tests, although media/media-captions.html and media/track/track-in-band-style.html
will now pass when this env var is set WEBKIT_GST_USE_PLAYBIN3=1.
- Modules/mediacontrols/mediaControlsAdwaita.css: Synchronize text-track-container and cue
CSS with mediaControlsBase.css.
(video::-webkit-media-text-track-container,):
(video::-webkit-media-text-track-container):
(video::cue):
(video::cue(:future)):
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp: Set track kind according
to the GstStream format this track represents.
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Drive-by, check
WEBKIT_GST_USE_PLAYBIN3 contents and sprinkle a few more debug calls.
(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::timeChanged):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp: Plug custom encoder handling
conversion of CEA-608 to WebVTT.
(webKitTextCombinerHandleCapsEvent):
(webkitTextCombinerReleasePad):
(webKitTextCombinerConstructed):
LayoutTests:
- media/track/track-in-band-style-expected.txt:
- media/track/track-in-band-style.html:
- 2:01 AM Changeset in webkit [272054] by
-
- 4 edits2 adds in trunk
[css-flexbox] REGRESSION(r266695): content inside a
<button>inside a flex container has a height of0without a declaredmin-height
https://bugs.webkit.org/show_bug.cgi?id=220946
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: css3/flexbox/percentage-descendants-of-skipped-flex-item.html
r252620 added an optimization which saves layouts for flexbox containers' descendants with percentage heights.
That optimization relies on a hash map of percentage height descendants that is filled in with calls to
addPercentHeightDescendant().
FlexibleBoxImpl's like RenderButton might wrap their children in anonymous blocks. Those anonymous blocks are
skipped for percentage height calculations in RenderBox::computePercentageLogicalHeight() and thus
addPercentHeightDescendant() is never called for them. This means that hasPercentageHeightDescendants() would
always wrongly return false for a child of a <button> with a percentage height.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::childHasPercentHeightDescendants const): Renamed from hasPercentHeightDescendants in
order not to clash with RenderBlock method. It now also checks whether flex items skipped from percentage
height calculations are the containing blocks of any percentage height descendant of the flex container
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::hasPercentHeightDescendants const): Deleted.
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/percentage-descendants-of-skipped-flex-item-expected.html: Added.
- css3/flexbox/percentage-descendants-of-skipped-flex-item.html: Added.
- 1:01 AM Changeset in webkit [272053] by
-
- 6 edits in trunk
[MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=221035
Reviewed by Eric Carlson.
Tools:
Remove the default TestOptions values and instead on MacOS rely on capture in GPUProcess.
On iOS, capture ill still happen inprocess for the time being.
- WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
LayoutTests:
fast/mediastream/media-stream-track-interrupted.html needs to be run with mock audio capture in process
as interruption mock testing is only supported this way.
SpeechRecognition in GPUProcess is not yet working so we disable capture in GPU Process for these two tests
until SpeechRecognition in GPUProcess is supported.
- fast/mediastream/media-stream-track-interrupted.html:
- fast/speechrecognition/start-recognition-then-stop.html:
- fast/speechrecognition/start-second-recognition.html:
- 12:53 AM Changeset in webkit [272052] by
-
- 14 edits2 deletes in trunk
Use WebRTC GPU process flag for MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=220967
Reviewed by Eric Carlson.
Source/WebCore:
Remove Internals::setUseGPUProcessForWebRTC and rely on WebRTC codec feature flag.
- Modules/mediarecorder/MediaRecorderProvider.h:
- testing/Internals.cpp:
(WebCore::Internals::setUseGPUProcessForWebRTC): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:
(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):
LayoutTests:
Update test to use feature flag instead of internals API.
Removing webrtc/video-gpuProcess.html since it is now equivalent to webrtc/video.html.
- http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess.html:
- http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html:
- http/wpt/mediarecorder/MediaRecorder-requestData.html:
- http/wpt/mediarecorder/mute-tracks.html:
- http/wpt/mediarecorder/pause-recording.html:
- platform/glib/TestExpectations:
- webrtc/video-gpuProcess-expected.txt: Deleted.
- webrtc/video-gpuProcess.html: Deleted.
- 12:49 AM Changeset in webkit [272051] by
-
- 7 edits2 adds in trunk
[SOUP] Use a GInputStream to set the request body in preparation for libsoup3
https://bugs.webkit.org/show_bug.cgi?id=221034
Reviewed by Adrian Perez de Castro.
Source/WebCore:
In libsoup3, the request body can be set using a stream. Add the stream now, that can still be used in libsoup2
to set the body data. This moves the FormData processing code to WebKitFormDataInputStream and also implements
the file seek and range length, which makes test http/tests/local/blob/send-hybrid-blob-using-open-panel.html pass.
- platform/SourcesSoup.txt:
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageBody const):
- platform/network/soup/WebKitFormDataInputStream.cpp: Added.
(webkitFormDataInputStreamCreateNextStream):
(webkitFormDataInputStreamRead):
(webkitFormDataInputStreamClose):
(webkit_form_data_input_stream_class_init):
(webkitFormDataInputStreamNew):
(webkitFormDataInputStreamReadAll):
- platform/network/soup/WebKitFormDataInputStream.h: Added.
Tools:
Add WebKitFormDataInputStream as an exception for some style checker rules.
- Scripts/webkitpy/style/checker.py:
LayoutTests:
Remove expectations of http/tests/local/blob/send-hybrid-blob-using-open-panel.html that is now passing.
- platform/gtk/TestExpectations:
- 12:47 AM Changeset in webkit [272050] by
-
- 10 edits in trunk
Recover audio and video capture from GPUProcess crash
https://bugs.webkit.org/show_bug.cgi?id=221086
Reviewed by Eric Carlson.
Make RemoteRealtimeMediaSource observe GPU process crash.
If RemoteRealtimeMediaSource is live and capturing in GPUProcess, restart capture from WebProcess.
If GPU process crashes, make sure to send back the necessary entitlements and information to GPUProcess
of which processes are allowed to capture.
Covered by API test.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gpuProcessCrashed):
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
(WebKit::RemoteCaptureSampleManager::didUpdateSourceConnection):
- WebProcess/cocoa/RemoteCaptureSampleManager.h:
- WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
(WebKit::RemoteRealtimeMediaSource::create):
(WebKit::RemoteRealtimeMediaSource::createRemoteMediaSource):
(WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::gpuProcessConnectionDidClose):
- WebProcess/cocoa/RemoteRealtimeMediaSource.h:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::AudioFactory::createAudioCaptureSource):
(WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):
(WebKit::UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource):
(WebKit::UserMediaCaptureManager::didUpdateSourceConnection):
- WebProcess/cocoa/UserMediaCaptureManager.h:
- 12:04 AM Changeset in webkit [272049] by
-
- 4 edits in trunk
Fix logic error in shouldComputeLogicalHeightFromAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=220965
Patch by Rob Buis <rbuis@igalia.com> on 2021-01-29
Reviewed by Darin Adler.
Source/WebCore:
Logical height that uses percentages should be computed through
aspect-ratio only if it is not resolvable.
Test: imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/percentage-resolution-005.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::shouldComputeLogicalHeightFromAspectRatio const):
LayoutTests:
percentage-resolution-005.html now passes.
Jan 28, 2021:
- 8:56 PM Changeset in webkit [272048] by
-
- 2 edits in trunk/Tools
[GLIB] Gardening API release passes and some debug crashes
Unreviewed test gardening.
Many debug crashes still to be listed.
- TestWebKitAPI/glib/TestExpectations.json:
- 8:06 PM Changeset in webkit [272047] by
-
- 9 edits in trunk
Minor cleanup in CSSFontFaceSetClient
https://bugs.webkit.org/show_bug.cgi?id=221019
Reviewed by Ryosuke Niwa.
Source/WebCore:
Split up CSSFontFaceSetClient into two pieces:
- CSSFontFaceSet::FontEventClient
- CSSFontFaceSet::FontModifiedObserver
One is a Client because it's a struct with 3 callback methods that take different arguments.
The other is an observer because it's just a single callback method that takes no arguments
and has no return.
Both of these types are CanMakeWeakPtr, so lifetime is automatically managed.
Test: WTF_WeakPtr.MultipleInheritance
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::addFontModifiedObserver):
(WebCore::CSSFontFaceSet::addFontEventClient):
(WebCore::CSSFontFaceSet::incrementActiveCount):
(WebCore::CSSFontFaceSet::decrementActiveCount):
(WebCore::CSSFontFaceSet::add):
(WebCore::CSSFontFaceSet::remove):
(WebCore::CSSFontFaceSet::fontStateChanged):
(WebCore::CSSFontFaceSet::fontPropertyChanged):
(WebCore::CSSFontFaceSet::addClient): Deleted.
(WebCore::CSSFontFaceSet::removeClient): Deleted.
- css/CSSFontFaceSet.h:
(WebCore::CSSFontFaceSetClient::faceFinished): Deleted.
(WebCore::CSSFontFaceSetClient::fontModified): Deleted.
(WebCore::CSSFontFaceSetClient::startedLoading): Deleted.
(WebCore::CSSFontFaceSetClient::completedLoading): Deleted.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::m_version):
(WebCore::CSSFontSelector::~CSSFontSelector):
- css/CSSFontSelector.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::FontFaceSet):
(WebCore::FontFaceSet::~FontFaceSet):
(WebCore::FontFaceSet::startedLoading):
(WebCore::FontFaceSet::documentDidFinishLoading):
(WebCore::FontFaceSet::completedLoading):
- css/FontFaceSet.h:
Tools:
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::MultipleInheritanceDerived::meowCalled const):
(TestWebKitAPI::MultipleInheritanceDerived::woofCalled const):
(TestWebKitAPI::TEST):
- 7:57 PM Changeset in webkit [272046] by
-
- 5 edits in trunk/Source
[macOS] Policy for warning about or killing processes using too much memory triggers too easily
https://bugs.webkit.org/show_bug.cgi?id=221104
<rdar://73625621>
Reviewed by Geoff Garen.
The policy for warning about or killing processes using too much memory was triggering too
easily. I made the following changes to the policy to address this:
- We no longer kill WebProcesses associated with a visible (parented) view under any circumstances. We used to kill active WebProcesses when they reached 4GB. We would also kill visible WebProcesses when they reached 2GB if there were visible but not active / focused.
- For background WebProcesses (associated with non visible / parented views), I have raised the kill limit from 2GB to 4GB.
- For foreground WebProcesses (associated with visible / parent views), I have also raised the limit to show the excessive memory usage banner from 2GB to 4GB.
Source/WebCore:
- page/PerformanceMonitor.cpp:
(WebCore::PerformanceMonitor::activityStateChanged):
Source/WTF:
- wtf/MemoryPressureHandler.cpp:
(WTF::thresholdForMemoryKillOfInactiveProcess):
(WTF::MemoryPressureHandler::thresholdForMemoryKill):
(WTF::MemoryPressureHandler::shrinkOrDie):
(WTF::MemoryPressureHandler::measurementTimerFired):
- wtf/MemoryPressureHandler.h:
- 7:49 PM Changeset in webkit [272045] by
-
- 3 edits in trunk/Source/WebCore
Remove some uses of FontSelector from within CSSFontFace
https://bugs.webkit.org/show_bug.cgi?id=221064
Reviewed by Darin Adler.
This is one of the steps toward https://bugs.webkit.org/show_bug.cgi?id=208351 "CSSFontFace should
not need its m_fontSelector data member."
No new tests because there is no behavior change.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::fontLoadTiming const):
(WebCore::CSSFontFace::allowUserInstalledFonts const): Deleted.
(WebCore::fontLoadTimingOverride): Deleted.
(WebCore::CSSFontFace::shouldIgnoreFontLoadCompletions const): Deleted.
- css/CSSFontFace.h:
- 7:42 PM Changeset in webkit [272044] by
-
- 4 edits in trunk/PerformanceTests
MotionMark focus test can cause extreme variance in whichever test runs directly after it
https://bugs.webkit.org/show_bug.cgi?id=221075
<rdar://problem/72143661>
Reviewed by Said Abou-Hallawa.
The focus test loads up the window server with work, which runs asynchronously from WebKit's run loop.
This means that the window server can still be busy when the next test starts.
In r270959 we already tried to combat this, and it was mostly successful, but not as successful as we'd
like. This patch goes further by:
- Bumping up the warmup timeout to 2000ms from 1000ms
- Making the warmup render at least 30 frames. This means that a single extremely long frame can't fill up the entire warmup period.
- MotionMark/developer.html:
- MotionMark/resources/runner/motionmark.js:
(this.clear):
- MotionMark/tests/resources/main.js:
(Benchmark.Utilities.createClass):
(_animateLoop):
- 6:54 PM Changeset in webkit [272043] by
-
- 4 edits in trunk
[ Big Sur ] media/media-source/media-source-webm-init-inside-segment.html is failing
https://bugs.webkit.org/show_bug.cgi?id=220552
<rdar://problem/73048070>
Patch by Jean-Yves Avenard <Jean-Yves Avenard> on 2021-01-28
Reviewed by Jer Noble.
Source/WebCore:
No new tests - fixes an existing test.
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::supportedAudioCodecs): Don't make the webm supported codec
conditional.
This change makes the webm audio support consistent with video support. supportedAudioCodecs
is used by the libwebm parser to determine which codec IDs are to be rejected outright.
If a codec id that isn't supported is encountered a parsing error will be thrown, which
ultimately causes a HTML audio or video error.
If webkit is compiled without opus or vorbis support, in this particular case we do not want
an error to be produced but instead ignore the track.
LayoutTests:
- platform/mac/TestExpectations: unskip test
- 6:21 PM Changeset in webkit [272042] by
-
- 28 edits1 copy in trunk/Source
Add plumbing to allow AppHighlights to be stored.
https://bugs.webkit.org/show_bug.cgi?id=221020
Reviewed by Devin Rousso.
Source/WebCore:
- Modules/highlight/AppHighlightListData.cpp:
(WebCore::AppHighlightListData::toSharedBuffer const):
(WebCore::AppHighlightListData::toData const): Deleted.
- Modules/highlight/AppHighlightListData.h:
- Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::createAndSendAppHighlightsStorage):
(WebCore::AppHighlightStorage::createAppHighlightListData): Deleted.
- dom/Document.cpp:
- dom/Document.h:
- page/Chrome.cpp:
(WebCore::Chrome::didCreateHighlightsStorageData const):
- page/Chrome.h:
- page/ChromeClient.h:
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCreateHighlightsStorageData:]):
(-[WKWebView _appHighlightsStorageDelegate]):
(-[WKWebView _setAppHighlightsStorageDelegate:]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::didCreateHighlightsStorageData):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateHighlightsStorageData):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didCreateHighlightsStorageData):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createAppHighlightInSelectedRange):
- 5:50 PM Changeset in webkit [272041] by
-
- 4 edits in trunk/Tools
[webkitcrepy] Handle case where pypi serves invalid html
https://bugs.webkit.org/show_bug.cgi?id=221111
<rdar://problem/73728580>
Reviewed by David Kilzer.
- Scripts/libraries/webkitcorepy/setup.py: Bump version number.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
- Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.archives): Remove possibly invalid <meta> tag from html.
- 4:39 PM Changeset in webkit [272040] by
-
- 3 edits in trunk/Source/WebKit
[WebAuthn] Adopt new SPI to show no credentials error for the platform authenticator
https://bugs.webkit.org/show_bug.cgi?id=220894
<rdar://problem/73538568>
Reviewed by Brent Fulgham.
Covered by manual tests.
- Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
- UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
(WebKit::AuthenticatorPresenterCoordinator::updatePresenter):
- 4:19 PM Changeset in webkit [272039] by
-
- 13 edits2 adds in trunk
[GPUP][MSE] A video element does not fire “canplaythrough” event if SourceBuffer.abort() is called
https://bugs.webkit.org/show_bug.cgi?id=220964
Reviewed by Jer Noble.
Source/WebCore:
This patch removes
initializationSegmentIsHandledSemaphorefrom bothSourceBufferParserAVFObjC
andSourceBufferParserWebM, and implements a media sample cache mechanism inSourceBufferPrivateAVFObjC
to ensure that "Coded Frame Processing" steps execute afterSourceBufferPrivatehas handled the
initialization segment and enabled video/audio tracks. Without the cache mechanism, some media
samples following the initialization segment may be dropped when we runSourceBufferPrivateAVFObjC
in the GPU process, and the media element won't fire "canplaythrough" event because it cannot change
its ready state to a value greater than HAVE_METADATA.
This patch also implements the mechanism to make sure
SourceBufferPrivateAVFObjC::appendCompleted()
runs after all media samples have gone through the "Coded Frame Processing" steps, so that the source
buffer object will fire "update" and "updateend" event after the parser has completedly parsed the
appended buffer.
- platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::SourceBufferParserAVFObjC):
(WebCore::SourceBufferParserAVFObjC::~SourceBufferParserAVFObjC):
(WebCore::SourceBufferParserAVFObjC::appendData):
Add a parameter "CompletionHandler" to notify the caller that the parser has parsed the whole buffer.
(WebCore::SourceBufferParserAVFObjC::flushPendingMediaData):
(WebCore::SourceBufferParserAVFObjC::resetParserState):
(WebCore::SourceBufferParserAVFObjC::invalidate):
(WebCore::SourceBufferParserAVFObjC::didParseStreamDataAsAsset):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::didParseInitializationData):
AfterSourceBufferPrivateClienthas done the configuration with the initialization segment, we need to
push the cached media samples (if any) toSourceBufferPrivateto run the "Coded Frame Processing" steps.
And we need to call "appendCompleted()" if there is a pending callback.
(WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackId):
SourceBufferPrivateAVFObjCneeds to cache the media sample if the initialization segment has not been
processed bySourceBufferPrivateClientyet.
(WebCore::SourceBufferPrivateAVFObjC::append):
We need to postpone the "appendCompleted()" callback if there are cached media samples.
(WebCore::SourceBufferPrivateAVFObjC::appendCompleted):
(WebCore::SourceBufferPrivateAVFObjC::abort):
(WebCore::SourceBufferPrivateAVFObjC::setVideoLayer):
(WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID): Deleted.
- platform/graphics/cocoa/SourceBufferParser.h:
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::SourceBufferParserWebM):
(WebCore::SourceBufferParserWebM::~SourceBufferParserWebM):
(WebCore::SourceBufferParserWebM::appendData):
(WebCore::SourceBufferParserWebM::flushPendingMediaData):
(WebCore::SourceBufferParserWebM::resetParserState):
(WebCore::SourceBufferParserWebM::invalidate):
(WebCore::SourceBufferParserWebM::OnClusterBegin):
- platform/graphics/cocoa/SourceBufferParserWebM.h:
Source/WebKit:
- Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::parseByteSource):
LayoutTests:
- gpu-process/TestExpectations:
- media/media-source/media-source-webm-append-buffer-after-abort-expected.txt: Added.
- media/media-source/media-source-webm-append-buffer-after-abort.html: Added.
- platform/mac/TestExpectations:
- 4:05 PM Changeset in webkit [272038] by
-
- 2 edits in trunk/LayoutTests
[BigSur Wk1] media/video-ended-event-negative-playback.html is flaky text failure.
https://bugs.webkit.org/show_bug.cgi?id=221106
Unreviewed test guardening.
Patch by Amir Mark Jr <Amir Mark Jr.> on 2021-01-28
- platform/mac-wk1/TestExpectations:
- 3:49 PM Changeset in webkit [272037] by
-
- 1 copy in tags/Safari-612.1.1
Tag Safari-612.1.1.
- 2:58 PM Changeset in webkit [272036] by
-
- 10 edits in branches/safari-611-branch/Source
Cherry-pick r271873. rdar://problem/73722521
REGRESSION (r270874): Some React Native apps are reported broken on iOS
https://bugs.webkit.org/show_bug.cgi?id=220809
Reviewed by Saam Barati.
Source/JavaScriptCore:
r270874 fixed for/in shadowing issue by introducing an invariant: a property
returned by getOwn*PropertyNames() in DontEnumPropertiesMode::Exclude should be
reported as Enumerable by getOwnPropertySlot(). Otherwise, for/in skips the
property, which causes RN apps to break.
Since there is no way to enforce this invariant for opaque API objects like
JSCallbackObject, this change skips Enumerable check for them by introducing
GetOwnPropertySlotMayBeWrongAboutDontEnum out of line type info flag.
Also, this patch reverts JSCallbackObject::getOwnPropertySlot() changes of r270874
that are no longer necessary and observable (via Object.getOwnPropertyDescriptor).
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject<Parent>::getOwnPropertySlot):
- API/tests/testapiScripts/testapi.js:
- runtime/JSObject.cpp: (JSC::JSObject::hasEnumerableProperty const):
- runtime/JSTypeInfo.h: (JSC::TypeInfo::getOwnPropertySlotMayBeWrongAboutDontEnum const):
Source/WebCore:
- bridge/runtime_object.h:
Source/WebKit:
- WebProcess/Plugins/Netscape/JSNPObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:24 PM Changeset in webkit [272035] by
-
- 32 edits in trunk
Add support for logical variants of 'scroll-padding' and 'scroll-margin'
https://bugs.webkit.org/show_bug.cgi?id=220766
<rdar://problem/73661278>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update test expectations for this change.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-scroll-snap/inheritance-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-margin-block-inline-computed-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-margin-block-inline-shorthand-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-margin-block-inline-valid-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-padding-block-inline-computed-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-padding-block-inline-shorthand-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-padding-block-inline-valid-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-padding-computed-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-padding-invalid-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-padding-shorthand-expected.txt:
- web-platform-tests/css/css-scroll-snap/parsing/scroll-padding-valid-expected.txt:
- web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
Source/WebCore:
Add support for logical
scroll-marginandscroll-paddingproperties. Also
improve parsing ofscroll-paddingwhich should not accept negative values and
should accept "auto" values. The spec gives flexibility for how to interpret
"auto", but for us this should just be 0 currently.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle): Add support for logical
margin and padding longhands and shortands.
- css/CSSProperties.json: Ditto. Allow padding to accept "auto" as well.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::resolveDirectionAwareProperty): Ditto.
(WebCore::CSSProperty::isDirectionAwareProperty): Ditto.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const): Ditto.
(WebCore::StyleProperties::asText const): Ditto.
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeScrollPadding): Added this helper that accepts a length, a percentage,
or auto.
(WebCore::CSSPropertyParser::parseSingleValue): Added support for logical longhands.
(WebCore::CSSPropertyParser::parseShorthand): Added support for logical shorthands.
- page/scrolling/ScrollSnapOffsetsInfo.cpp:
(WebCore::computeScrollSnapPortOrAreaRect): Use minimumValueForLength here because
auto should resolve to 0px.
- rendering/RenderBox.cpp:
(RenderBox::scrollPaddingForViewportRect): Ditto.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialScrollPadding): Initialize scroll-padding values to
auto as specified.
- rendering/style/StyleRareNonInheritedData.h: Ditto.
LayoutTests:
Update test expectations.
- css3/scroll-snap/scroll-snap-inherit-expected.txt:
- css3/scroll-snap/scroll-snap-inherit.html:
- css3/scroll-snap/scroll-snap-initial-expected.txt:
- css3/scroll-snap/scroll-snap-initial.html:
- css3/scroll-snap/scroll-snap-property-computed-style-expected.txt:
- css3/scroll-snap/scroll-snap-property-computed-style.js:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- 1:58 PM Changeset in webkit [272034] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed macOS build fix after r272020.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::updateActivePages):
- 12:50 PM Changeset in webkit [272033] by
-
- 12 edits in trunk/Source/WebCore
Sort colors in ColorTypes.h alphabetically
https://bugs.webkit.org/show_bug.cgi?id=221073
Reviewed by Darin Adler.
- css/CSSValueKeywords.in:
- css/parser/CSSPropertyParserHelpers.cpp:
- platform/graphics/ColorConversion.cpp:
- platform/graphics/ColorConversion.h:
- platform/graphics/ColorSerialization.cpp:
- platform/graphics/ColorSerialization.h:
- platform/graphics/ColorSpace.cpp:
- platform/graphics/ColorSpace.h:
- platform/graphics/ColorTypes.h:
- platform/graphics/cg/ColorSpaceCG.cpp:
- platform/graphics/cg/ColorSpaceCG.h:
Sort things a bit more alphabetically.
- 12:47 PM Changeset in webkit [272032] by
-
- 3 edits in trunk/Tools
[build.webkit.org] Remove dead code for TestWebKit1LeaksFactory
https://bugs.webkit.org/show_bug.cgi?id=221090
Reviewed by Jonathan Bedard.
- CISupport/build-webkit-org/factories.py:
(BuildAndJSCTestsFactory.init):
(TestWebKit1LeaksFactory): Deleted.
(TestWebKit1LeaksFactory.init): Deleted.
- CISupport/build-webkit-org/steps.py:
(ExtractTestResults.finished):
(ExtractTestResultsAndLeaks): Deleted.
(ExtractTestResultsAndLeaks.addCustomURLs): Deleted.
- 12:41 PM Changeset in webkit [272031] by
-
- 1 edit5 adds in trunk/JSTests
Unreviewed, recover removed tests
https://bugs.webkit.org/show_bug.cgi?id=220216
These tests are important since we need to ensure that we are not accidentally expose internal-only functions.
- stress/function-caller-async-arrow-function-body.js:
(shouldBe):
(thingy.foo.async try): Deleted.
(thingy): Deleted.
- stress/function-caller-async-function-body.js:
(shouldBe):
(thingy.async foo):
(thingy):
- stress/function-caller-async-generator-body.js:
(shouldBe):
(thingy.async foo):
(thingy):
- stress/function-caller-generator-body.js:
(shouldBe):
(thingy.foo):
(thingy):
- stress/function-caller-generator-method-body.js:
(shouldBe):
(thingy.C.prototype.foo):
(thingy.C):
(thingy):
- 12:37 PM Changeset in webkit [272030] by
-
- 4 edits in trunk/LayoutTests
REGRESSION(r271119) Check for nullness of preamble.caller
https://bugs.webkit.org/show_bug.cgi?id=220610
Reviewed by Yusuke Suzuki.
r271119 changed some kinds of functions to return null when trying to
access its caller property.
This made the preamble helper from indexeddb tests to fail when used
in places like arrow functions, like in
storage/indexeddb/result-request-cycle.html.
This commit makes preamble default to an empty name if the caller is
null.
- http/tests/IndexedDB/resources/shared.js:
(preamble):
- imported/blink/storage/indexeddb/resources/shared.js:
(preamble):
- storage/indexeddb/resources/shared.js:
(preamble):
- 12:27 PM Changeset in webkit [272029] by
-
- 4 edits in trunk/Tools
Move Mac EWS to macOS Catalina.
https://bugs.webkit.org/show_bug.cgi?id=220818
Reviewed by Aakash Jain.
- CISupport/ews-build/config.json:
- CISupport/ews-build/factories_unittest.py:
(TestBuildFactory.test_generic_build_factory):
(TestBuildFactory.test_macos_build_factory):
(TestCommitQueueFactory.test_commit_queue_factory):
(TestLayoutTestsFactory.test_macos_wk1_release_factory):
(TestLayoutTestsFactory.test_macos_wk1_debug_factory):
(TestLayoutTestsFactory.test_macos_wk2_factory):
- CISupport/ews-build/steps_unittest.py:
(TestAnalyzeCompileWebKitResults.test_filter_logs_containing_error_with_no_error):
- 12:19 PM Changeset in webkit [272028] by
-
- 2 edits in branches/safari-612.1.1-branch/Source/WebCore
Cherry-pick r271994. rdar://problem/73718489
Don't link IOSurfaceAccelerator on simulator builds
https://bugs.webkit.org/show_bug.cgi?id=221066
rdar://73681508
Reviewed by Tim Horton.
- Configurations/WebCore.xcconfig: Don't link if the sdk matches "simulator".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:12 PM Changeset in webkit [272027] by
-
- 8 edits in trunk/Source
Remove the dead code of USE(WINGDI)
https://bugs.webkit.org/show_bug.cgi?id=221079
Reviewed by Don Olmstead.
Source/WebCore:
It was used by WinCE port.
- platform/graphics/GlyphBufferMembers.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/PlatformImage.h:
Source/WebKitLegacy/win:
- Plugins/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::snapshot):
- 12:04 PM Changeset in webkit [272026] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r271988): WebXR test failures on Big Sur
https://bugs.webkit.org/show_bug.cgi?id=221092
Patch by Ada Chan <ada.chan@apple.com> on 2021-01-28
Reviewed by Chris Dumez.
- platform/mac/TestExpectations: Skip failing tests
- 12:01 PM Changeset in webkit [272025] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Line break (and word break opportunity) is not necessarily the last inline item on the line
https://bugs.webkit.org/show_bug.cgi?id=221091
Reviewed by Antti Koivisto.
While both <br> and <wbr> are valid wrap opportunities, the actual wrap position may be at a later position on the line.
e.g. <span style="border-right: 1px solid green">text<br></span> <- the green border should show up on the same line as the text even though it is "after" the forced line break.
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::candidateContentForLine):
(WebCore::Layout::LineBuilder::nextWrapOpportunity const):
- 11:55 AM Changeset in webkit [272024] by
-
- 3 edits2 adds in trunk
AX: Long narrow tables should not be made in data tables unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=221061
<rdar://problem/73681149>
Reviewed by Zalan Bujtas.
Source/WebCore:
Some web authors use long columns/rows of cells for layout purposes. We shouldn't
automatically turn these into data tables based on row count only.
Instead let's ensure there are at least two rows/cols of content before automatically
turning into a data table.
Test: accessibility/narrow-tables-ignored.html
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable const):
LayoutTests:
- accessibility/narrow-tables-ignored-expected.txt: Added.
- accessibility/narrow-tables-ignored.html: Added.
- 11:52 AM Changeset in webkit [272023] by
-
- 1 copy in tags/Safari-611.1.12.2
Tag Safari-611.1.12.2.
- 11:47 AM Changeset in webkit [272022] by
-
- 2 edits in branches/safari-611.1.12-branch/Source/WebCore
Cherry-pick r271994. rdar://problem/73715829
Don't link IOSurfaceAccelerator on simulator builds
https://bugs.webkit.org/show_bug.cgi?id=221066
rdar://73681508
Reviewed by Tim Horton.
- Configurations/WebCore.xcconfig: Don't link if the sdk matches "simulator".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:45 AM Changeset in webkit [272021] by
-
- 8 edits in branches/safari-611.1.12-branch/Source
Versioning.
WebKit-7611.1.12.2
- 11:41 AM Changeset in webkit [272020] by
-
- 2 edits in trunk/Source/WebKit
[macOS] WebProcess::updateProcessName should initiate network process connection if none exists
https://bugs.webkit.org/show_bug.cgi?id=221094
<rdar://73658122>
Reviewed by Per Arne Vollan.
WebProcess::updateProcessName should initiate network process connection if none exists, instead of giving up
and returning early in this case. Same policy applies to WebProcess::updateActivePages.
This is a follow-up to:
https://trac.webkit.org/changeset/271897/webkit
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::updateActivePages):
- 10:32 AM Changeset in webkit [272019] by
-
- 9 edits in trunk/Source
Make closestSnapOffset a method on ScrollSnapOffsetsInfo
https://bugs.webkit.org/show_bug.cgi?id=221030
Reviewed by Simon Fraser.
Source/WebCore:
No new tests. This should not change behavior.
Make closestSnapOffset a method and change all call sites to use the new method.
- page/scrolling/ScrollSnapOffsetsInfo.cpp:
(WebCore::ScrollSnapOffsetsInfo<LayoutUnit>::closestSnapOffset const):
(WebCore::ScrollSnapOffsetsInfo<float>::closestSnapOffset const):
- page/scrolling/ScrollSnapOffsetsInfo.h:
- platform/cocoa/ScrollController.mm:
(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset):
(WebCore::ScrollController::adjustScrollDestination):
- platform/cocoa/ScrollSnapAnimatorState.h:
(WebCore::ScrollSnapAnimatorState::snapOffsetInfo const):
(WebCore::ScrollSnapAnimatorState::setSnapOffsetInfo):
- platform/cocoa/ScrollSnapAnimatorState.mm:
(WebCore::ScrollSnapAnimatorState::setupAnimationForState):
(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset const):
Source/WebKit:
Make closestSnapOffset a method and change all call sites to use the new method.
- UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling const):
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
- 10:26 AM Changeset in webkit [272018] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Flatpak environment JSON is prematurely deleted with flatpak-spawn calls
https://bugs.webkit.org/show_bug.cgi?id=221070
Reviewed by Philippe Normand.
To avoid nested webkit-flatpak calls overwriting/deleting whe
environment file, only create if there is no such file and only delete
in the same process that created it.
This approach has the drawback of limiting nested calls changing the
variable values and a file undeleted after a crash might avoid the
next normal invocation creating it.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
- 10:01 AM Changeset in webkit [272017] by
-
- 6 edits in trunk/Source
[macOS] Crash when updating color preferences
https://bugs.webkit.org/show_bug.cgi?id=221088
<rdar://problem/73709142>
Reviewed by Brent Fulgham.
Source/WebCore:
Remove previous workaround in r271965 for preventing Launch Services connections, since this is covered
by the new approach in this patch.
- platform/mac/ThemeMac.mm:
(-[WebCoreThemeWindow isKeyWindow]):
(-[WebCoreThemeWindow invalidateRestorableState]): Deleted.
Source/WebCore/PAL:
Declare NSApplication SPI for updating application information with Launch Services.
- pal/spi/mac/NSApplicationSPI.h:
Source/WebKit:
After r271965, the WebContent process is no longer allowed to connect to the Launch Services daemon. This introduced a crash
in the WebContent process when color preferences were changed in System Preferences, since AppKit will then attempt to set
application information with Launch Services, which causes a crash when that fails. This patch addresses this issue by
overriding the AppKit method that updates the specific application information with Launch Services, since updating this
information should be required in the WebContent process.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::updateCanQuitQuietlyAndSafely):
(WebKit::WebProcess::platformInitializeWebProcess):
- 9:28 AM Changeset in webkit [272016] by
-
- 6 edits in trunk/Source/WebKit
[macOS] Remove reference to deprecated SubmitDiagInfo.domains path
https://bugs.webkit.org/show_bug.cgi?id=221056
<rdar://problem/73474697>
Reviewed by Per Arne Vollan.
macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely.
There's no reason to have this access in any of our sandboxes, and we should remove it.
- GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
- WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 9:00 AM Changeset in webkit [272015] by
-
- 3 edits in trunk/Source/WebKit
[macOS] Remove access to com.apple.BluetoothServices
https://bugs.webkit.org/show_bug.cgi?id=221059
<rdar://problem/70509471>
Reviewed by Alex Christensen.
Remove access to com.apple.BluetoothServices in the WebContent sandbox on macOS, since there are no reports of this being used.
- UIProcess/WebPageProxy.cpp:
(WebKit::mediaRelatedMachServices):
- WebProcess/com.apple.WebProcess.sb.in:
- 8:32 AM Changeset in webkit [272014] by
-
- 4 edits in trunk
REGRESSION (r271988): XRSession.end() promise is not resolved if PlatformXR::Device::supportsSessionShutdownNotification() returns false
https://bugs.webkit.org/show_bug.cgi?id=221080
Patch by Ada Chan <ada.chan@apple.com> on 2021-01-28
Reviewed by Chris Dumez.
Source/WebCore:
m_endPromise needs to be set before WebXRSession::shutdown() is called
since that can call WebXRSession::didCompleteShutdown() which will
resolve m_endPromise.
This issue caused a timeout in the cleanup step for a test like
imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https.html.
- Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::end):
LayoutTests:
Enable a test that was timing out, but now passes with the bug fix.
- platform/mac/TestExpectations:
- 6:25 AM Changeset in webkit [272013] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests: Ensure correct count when subtests are specified
https://bugs.webkit.org/show_bug.cgi?id=221049
Reviewed by Adrian Perez de Castro.
Currently the code of run-gtk-tests adds the number of skipped tests
to the count of total tests. That computation failed to take into
account the case where specific subtests are run (by means of passing
the -p argument), instead of the full test suite.
This patch fixes that, only adding to "total tests" those skipped
subtests that were also specified with the -p argument when using that
mode.
- glib/api_test_runner.py:
(TestRunner.run_tests):
- 6:01 AM Changeset in webkit [272012] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Incorrect soft opportunity position when the inline box starts with an atomic inline box
https://bugs.webkit.org/show_bug.cgi?id=221076
Reviewed by Antti Koivisto.
This patch fixes the following case:
"text_content<span><img></span>"
On trunk we find the soft wrap opportunity after the <span> which could result the following, incorrect line setup
line #1: text_content<span>
line #2 <img></span>
This makes the inline box (<span>) taller than it is supposed to be as it shows up on both the first and the second line.
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::nextWrapOpportunity const):
- 4:48 AM Changeset in webkit [272011] by
-
- 3 edits in trunk/Tools
[Flatpak SDK] Avoid "Invalid byte sequence in conversion input" errors and other encoding issues
https://bugs.webkit.org/show_bug.cgi?id=221068
Reviewed by Philippe Normand.
- flatpak/flatpakutils.py:
(WebkitFlatpak.execute_command): Decode the arguments before printing.
(WebkitFlatpak.run_in_sandbox): Avoid iterating mutating dict and
export LANG.
- flatpak/webkit-bwrap: Ignore LANG as it's exported by
flatpakutils.py.
- 4:42 AM Changeset in webkit [272010] by
-
- 10 edits in trunk/Source
[SOUP] Stop using SoupRequest API in preparation for libsoup3
https://bugs.webkit.org/show_bug.cgi?id=220764
Reviewed by Adrian Perez de Castro.
Source/WebCore:
- platform/network/soup/ResourceError.h: Error constructors now receive the failing URL instead of a SoupRequest
that is only used to get its URL.
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::transportError):
(WebCore::ResourceError::httpError):
(WebCore::ResourceError::genericGError):
- platform/network/soup/ResourceRequest.h: Remmove the constructor that receives a SoupRequest and the
initiating page ID since it's currently unsused.
- platform/network/soup/ResourceRequestSoup.cpp:
- platform/network/soup/SoupNetworkSession.h:
Source/WebKit:
It's gone in libsoup3, we can just use soup_session_send_async() instead, which is what SoupRequest does
internally.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::createRequest): Manually create the SoupMessage. Also connect to content-sniffed
signal that it was handled by SoupRequest internally.
(WebKit::NetworkDataTaskSoup::clearRequest): Remove the SoupRequest reset and clear m_sniffedContentType.
(WebKit::NetworkDataTaskSoup::resume): Use soup_session_send_async(). We need to know the message for passed to
the function from the async ready callback, so we use a struct to pass both the task and the message. In case of
being suspended the struct was attached to the pending result.
(WebKit::NetworkDataTaskSoup::sendRequestCallback): Finish the soup_session_send_async() operation.
(WebKit::NetworkDataTaskSoup::didSendRequest): Set the sniffed content type from m_sniffedContentType.
(WebKit::NetworkDataTaskSoup::tlsConnectionAcceptCertificate): Use SoupMessage instead of SoupRequest to get the URI.
(WebKit::NetworkDataTaskSoup::didSniffContentCallback): Build the sniffed content type and call didSniffContent().
(WebKit::NetworkDataTaskSoup::didSniffContent): Save the passed content type.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Use m_currentRequest instead of the SoupRequest to build
the authentication error.
(WebKit::NetworkDataTaskSoup::skipInputStreamForRedirectionCallback): Pass the failing URL to the ResourceError constructor.
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Ditto.
(WebKit::NetworkDataTaskSoup::readCallback): Ditto.
(WebKit::NetworkDataTaskSoup::requestNextPartCallback): Ditto.
- NetworkProcess/soup/NetworkDataTaskSoup.h:
- WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: Stop setting the initiating page ID in the request because
it's unused.
- 4:40 AM Changeset in webkit [272009] by
-
- 15 edits in trunk
Load data URLs in the web process also for synchronous loads
https://bugs.webkit.org/show_bug.cgi?id=220981
Reviewed by Adrian Perez de Castro.
Source/WebCore:
Add synchronous API for DataURLDecoder. It now uses a Vector<char> for the data instead of SharedBuffer. That
way, ResourceLoader can create the SharedBuffer from the given data and loader strategy can simply move it.
- Headers.cmake: Add DataURLDecoder.h.
- WebCore.xcodeproj/project.pbxproj: Mark DataURLDecoder.h as private.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL): Adapt to the DataURLDecoder API changes.
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::parseMediaType): Update the data initialization.
(WebCore::DataURLDecoder::decodeBase64): Return bool to indicate success or error and move the resulting vector
instead of creating a SharedBuffer.
(WebCore::DataURLDecoder::decodeEscaped): Move the resulting vector instead of creating a SharedBuffer.
(WebCore::DataURLDecoder::decodeSynchronously): Helper to do the actual decoding synchronously.
(WebCore::DataURLDecoder::decode): Use decodeSynchronously.
(WebCore::DataURLDecoder::decode): Synchronous implementation.
- platform/network/DataURLDecoder.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::dataURLResponse): Create a ResourceResponse for the given url and DataURLDecoder::Result.
- platform/text/DecodeEscapeSequences.h:
(WebCore::decodeURLEscapeSequencesAsData): Use Vector<char> so that we can avoid data copies.
Source/WebKit:
In r271879 I removed the support for data URLs in the network process for soup, assuming data URLs were always
loaded from the web process, but that's not the case for synchronous loads.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::createRequest): Schedule an error if URL is not file or HTTP family.
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::loadDataURLSynchronously): Helper to load a Data URL synchronously.
(WebKit::WebLoaderStrategy::loadResourceSynchronously): Call loadDataURLSynchronously for data URLs.
- WebProcess/Network/WebLoaderStrategy.h:
LayoutTests:
Remove expectations for tests that are no longer crashing.
- platform/glib/TestExpectations:
- 2:58 AM Changeset in webkit [272008] by
-
- 3 edits2 adds in trunk
Crash from CompositeEditCommand::moveParagraphs() using Position instead of VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=220955
Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2021-01-28
Reviewed by Ryosuke Niwa.
Source/WebCore:
If the start or end VisiblePositions inside InsertListCommand::moveParagraphs()
are null, then makeSimpleRange(start, end) will not return a usable SimpleRange.
Bail out early in this case, similar to bug 220630.
Test: editing/inserting/paragraph-outdent-animationframe-crash.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
LayoutTests:
Add a test to verify that the crash here is resolved
using requestAnimationFrame(). Thanks to Ryosuke Niwa
for cleaning this up and making it reliable.
- editing/inserting/paragraph-outdent-animationframe-crash-expected.txt: Added.
- editing/inserting/paragraph-outdent-animationframe-crash.html: Added.
- 2:20 AM Changeset in webkit [272007] by
-
- 8 edits6 adds in trunk/LayoutTests
[selectors] Update :focus-visible tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=221037
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
- web-platform-tests/css/selectors/focus-visible-007-expected.txt:
- web-platform-tests/css/selectors/focus-visible-007.html:
- web-platform-tests/css/selectors/focus-visible-011.html:
- web-platform-tests/css/selectors/focus-visible-013-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-013.html: Added.
- web-platform-tests/css/selectors/focus-visible-017-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-017.html: Added.
- web-platform-tests/css/selectors/focus-visible-018-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-018.html: Added.
- web-platform-tests/css/selectors/w3c-import.log:
LayoutTests:
- TestExpectations: focus-visible-007.html has been fixed upstream and doesn't need to be skipped now.
- platform/ios/TestExpectations: Skip focus-visible-013.html as it timeouts in iOS.
- 1:20 AM Changeset in webkit [272006] by
-
- 2 edits in trunk/Source/WTF
[JSC] Add JSC_SIGNAL_FOR_GC environment variable for Linux / FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=221081
Reviewed by Mark Lam.
This patch adds JSC_SIGNAL_FOR_GC environment variable,
which changes signal number used for GC suspension.
- wtf/posix/ThreadingPOSIX.cpp:
(WTF::Thread::initializePlatformThreading):
- 12:08 AM Changeset in webkit [272005] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] Add JSPromise::rejectedPromise
https://bugs.webkit.org/show_bug.cgi?id=221077
Reviewed by Mark Lam.
This patch adds JSPromise::rejectedPromise static function which can return newly created rejected promise.
The benefit of this function is that it avoids calling JS functions internally. It is efficient, fast, plus,
we can ensure that no JS related error happens (stack-overflow, terminated-execution errors).
- builtins/PromiseOperations.js:
- runtime/JSPromise.cpp:
(JSC::JSPromise::rejectedPromise):
- runtime/JSPromise.h:
- wasm/js/JSWebAssembly.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
