⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 10, 2021:

7:57 PM Changeset in webkit [275806] by achristensen@apple.com
  • 10 edits in trunk/Source/WebKit

Use WeakHashSet<WebProcessProxy> instead of HashSet<WebProcessProxy*>
​https://bugs.webkit.org/show_bug.cgi?id=224393

Reviewed by Chris Dumez.

  • UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::requestHighPerformanceGPU):
(WebKit::WebProcessProxy::releaseHighPerformanceGPU):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::~WebProcessPool):
(WebKit::WebProcessPool::enableProcessTermination):
(WebKit::WebProcessPool::shouldTerminate):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::startedUsingGamepads):
(WebKit::WebProcessPool::stoppedUsingGamepads):
(WebKit::WebProcessPool::processStoppedUsingGamepads):
(WebKit::WebProcessPool::gamepadConnected):
(WebKit::WebProcessPool::gamepadDisconnected):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::maybeShutDown):
(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):

  • UIProcess/mac/HighPerformanceGPUManager.mm:

(WebKit::HighPerformanceGPUManager::addProcessRequiringHighPerformance):
(WebKit::HighPerformanceGPUManager::removeProcessRequiringHighPerformance):
(WebKit::HighPerformanceGPUManager::updateState):

5:48 PM Changeset in webkit [275805] by Chris Dumez
  • 8 edits in trunk/Source/WebKit

Crash under WebProcessProxy::shouldSendPendingMessage()
​https://bugs.webkit.org/show_bug.cgi?id=224377
<rdar://75329251>

Reviewed by David Kilzer.

We are crashing with a null-dereference of pendingMessage.encoder inside WebProcessProxy::shouldSendPendingMessage().
However, pendingMessage.encoder is a UniqueRef<> and thus cannot be null. Also, we know that the WebProcessProxy
is alive because WebProcessProxy::didFinishLaunching() has a protector.

One thing that I believe could theoretically happen and would not be safe though is AuxiliaryProcessProxy::sendMessage()
being called on a non-main thread. Sending IPC off the main thread is safe in general and something we commonly do with
an IPC::Connection. To make this safe, IPC::Connection uses a Lock to protect its vector of messages. However, sending
IPC via an AuxiliaryProcessProxy is currently not thread safe as it relies on the process state (which gets updated on
the main thread) and access to the m_pendingMessages is not synchronized.

As a speculative fix, I have added logic in AuxiliaryProcessProxy::sendMessage() to dispatch to the main thread if
we're not already on it. I have also used WTF::DestructionThread::MainRunLoop to make sure all AuxiliaryProcessProxy
objects get destroyed on the main thread.

In a follow-up, I am planning to add a release assertion in AuxiliaryProcessProxy::sendMessage() to make sure we're
on a main thread. We'll then be able to drop the "dispatching the main thread" logic. For now though, I think we
should start with the "dispatch to main thread" logic, so that we have a patch that we can cherry-pick to a branch.

  • UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::sendMessage):
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
(WebKit::AuxiliaryProcessProxy::replyToPendingMessages):

  • UIProcess/AuxiliaryProcessProxy.h:
  • UIProcess/GPU/GPUProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp:

(WebKit::WebAuthnProcessProxy::singleton):

  • UIProcess/WebProcessProxy.h:
3:41 PM Changeset in webkit [275804] by Chris Dumez
  • 3 edits
    2 adds in trunk

Regression(r275668) Potential null pointer deref in AudioParam::exponentialRampToValueAtTime(float, double)
​https://bugs.webkit.org/show_bug.cgi?id=224400
<rdar://76450376>

Reviewed by Ryosuke Niwa.

Source/WebCore:

In r275668, I added null-checks for the AudioContext in AudioParam, now that it holds a WeakPtr to its
context. However, I missed a null-check in AudioParam::exponentialRampToValueAtTime(). This patch adds
the missing check.

Test: webaudio/AudioParam/audioparam-exponentialRampToValueAtTime-nocontext-crash.html

  • Modules/webaudio/AudioParam.cpp:

LayoutTests:

Add layout test coverage.

  • webaudio/AudioParam/audioparam-exponentialRampToValueAtTime-nocontext-crash-expected.txt: Added.
  • webaudio/AudioParam/audioparam-exponentialRampToValueAtTime-nocontext-crash.html: Added.
3:37 PM Changeset in webkit [275803] by Chris Dumez
  • 4 edits in trunk/LayoutTests

[ macOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=223966
<rdar://problem/76028345>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update test as per:

Make sure subtests are run one after another, not in parallel, so that PASS lines are printed out in a
consistent order.

  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html:

LayoutTests:

Unskip test that should no longer be flaky.

  • platform/mac/TestExpectations:
3:02 PM Changeset in webkit [275802] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Properly use CompletionHandler when USE_OPENGL_OR_ES is set to OFF
​https://bugs.webkit.org/show_bug.cgi?id=224149

Patch by Charlène Wendling <​julianaito@posteo.jp> on 2021-04-10
Reviewed by Fujii Hironori.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:

(WebKit::LayerTreeHost::forceRepaintAsync):

1:14 PM Changeset in webkit [275801] by Angelos Oikonomopoulos
  • 4 edits in trunk/Tools

[JSC] detect infrastructure failure for remote stress tests
​https://bugs.webkit.org/show_bug.cgi?id=222601

Reviewed by Yusuke Suzuki.

run-jsc-stress-tests currently detects failures by the absence of
a failure file (that is generated by each failing test). This is
fragile to begin with, as it assumes that tests that fail to run
(e.g. because of an error in the runner script) are successful by
default.

However, the main motivation for this patch is to make execution
more robust when using remote hosts. Currently,
--gnu-parallel-runner will transparently reschedule jobs on a
different host when a remote host goes away. But detectFailures
expects to be able to connect to all hosts and fetch the failure
files, which fails if a remote host is still down when the run
finishes.

Instead, this patch changes the runners to always generate a status
file with the exit code. detectFailures then fetches all status
files from all hosts that are live on exit. Tests that failed to
run are explicitly accounted for as 'noreport' and are set to
ERROR in the final report.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests):

  • Scripts/run-jsc-stress-tests:
  • Scripts/webkitruby/jsc-stress-test-writer-default.rb:
12:00 PM Changeset in webkit [275800] by ysuzuki@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

[JSC] B3 reduce-double-to-float should reduce only when constant double is canonical one to reduced float value
​https://bugs.webkit.org/show_bug.cgi?id=224403
<rdar://problem/76259599>

Reviewed by Mark Lam.

When reducing double-constant value to float in B3, we should check whether the double value is a canonical one
which can be converted back from the reduced float value. For example, double 1.1 is not the one since it is truncated
into float 1.1 by removing some bits.

static_cast<double>(static_cast<float>(1.1)) != 1.1

Reducing such a double to float changes the semantics.

  • b3/B3ConstDoubleValue.cpp:

(JSC::B3::ConstDoubleValue::dumpMeta const):

  • b3/B3ConstFloatValue.cpp:

(JSC::B3::ConstFloatValue::dumpMeta const):

  • b3/B3ReduceDoubleToFloat.cpp:
  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:

(populateWithInterestingValues):

  • b3/testb3_1.cpp:

(run):

  • b3/testb3_3.cpp:

(testConvertDoubleToFloatToDouble):
(testConvertDoubleToFloatEqual):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::JSC_DEFINE_JIT_OPERATION_WITH_ATTRIBUTES):
(JSC::FTL::DFG::LowerDFGToB3::crash):
(JSC::FTL::DFG::ftlUnreachable): Deleted.

10:56 AM Changeset in webkit [275799] by sihui_liu@apple.com
  • 8 edits in trunk/Source/WebKit

Unreviewed, reverting r275794, r275784, r275779

r275779 caused bots to crash and r275794, r275784 didn't fully fix it; reverting the patches to investigate.

Reverted changeset:

"Create WebIDBServer only when it is needed"
​https://bugs.webkit.org/show_bug.cgi?id=224305
​https://commits.webkit.org/r275779

10:11 AM Changeset in webkit [275798] by Chris Dumez
  • 13 edits
    1 add in trunk

[ macOS ] 3 webaudio/OfflineAudioContext/ layout-tests are flakey text failures
​https://bugs.webkit.org/show_bug.cgi?id=224387
<rdar://problem/76468058>

Reviewed by Eric Carlson.

Source/WebCore:

Replace internals.numberOfBaseAudioContexts() test infrastructure with
internals.baseAudioContextIdentifier() & internals.isBaseAudioContextAlive().
This allows tests to check if specific BaseAudioContext instances created by the
tests are actually alive. As a result, the tests are no longer impacted by tests
running before them (and potentially leaking, see Bug 224399) or in parallel to
them in the same process.

This is the same approach we used for leak testing Documents (internals.documentIdentifier()
& internals.isDocumentAlive()).

  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::generateAudioContextID):
(WebCore::liveAudioContexts):
(WebCore::BaseAudioContext::BaseAudioContext):
(WebCore::BaseAudioContext::~BaseAudioContext):
(WebCore::BaseAudioContext::isContextAlive):

  • Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::contextID const):

  • testing/Internals.cpp:

(WebCore::Internals::countMatchesForText):
(WebCore::Internals::baseAudioContextIdentifier):
(WebCore::Internals::isBaseAudioContextAlive):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Update OfflineAudioContext leak tests to use the new test infrastructure. They are no longer impacted
by tests running before them or in parallel to them.

  • webaudio/OfflineAudioContext/offlineaudiocontext-leak-after-rendering-expected.txt:
  • webaudio/OfflineAudioContext/offlineaudiocontext-leak-after-rendering.html:
  • webaudio/OfflineAudioContext/offlineaudiocontext-leak-expected.txt:
  • webaudio/OfflineAudioContext/offlineaudiocontext-leak-while-suspended-expected.txt:
  • webaudio/OfflineAudioContext/offlineaudiocontext-leak-while-suspended.html:
  • webaudio/OfflineAudioContext/offlineaudiocontext-leak.html:
  • webaudio/resources/audiocontext-leak-test.js: Added.

(didGCAtLeastOneContext):
(gcAndCheckForContextLeaks):

9:12 AM Changeset in webkit [275797] by mark.lam@apple.com
  • 35 edits
    2 adds in trunk

Enable VMTraps checks in RETURN_IF_EXCEPTION.
​https://bugs.webkit.org/show_bug.cgi?id=224078
rdar://75037057

Reviewed by Keith Miller.

JSTests:

  • stress/watchdog-fire-while-in-forEachInIterable.js: Added.

Source/JavaScriptCore:

In pre-existing code, termination of a VM's execution can already be requested
asynchronously (with respect to the mutator thread). For example, sources of such
a request can be a watchdog timer firing, or a request to stop execution issued
from a main web thread to a worker thread.

This request is made by firing the VMTraps::NeedTermination event on VMTraps.
Firing the event here only means setting a flag to indicate the presence of the
request. We still have to wait till the mutator thread reaches one of the
pre-designated polling check points to call VMTraps::handleTraps() in order to
service the request. As a result of this need to wait for a polling check point,
if the mutator is executing in a long running C++ loop, then a termination request
may not be serviced for a long time.

However, we observed that a lot of our C++ loops already have RETURN_IF_EXCEPTION
checks. Hence, if we can check VMTraps::needHandling() there, we can service the
VMTraps events more frequently even in a lot of C++ loops, and get a better response.

Full details of what this patch changes:

  1. Shorten some type and methods names in the VMTraps class to make code easier to read e.g. EventType => Event, needTrapHandling => needHandling.
  1. Remove the VMTraps::Mask class. Mask was introduced so that we can express a concatenation of multiple VMTraps events to form a bit mask in a simple way. In the end, it isn't flexible enough but makes the code more complicated than necessary. It is now replaced by the simpler solution of using macros to define the Events as bit fields. Having Events as bit fields intrinsically make them easy to concatenate (bitwise or) or filter (bitwise and).

Also removed the unused VMTraps::Error class.

  1. Make VMTraps::BitField a uint32_t. There was always unused padding in VMTraps to allow for this. So, we'll just extend it to a full 32-bit to make it easier to add more events in the future for other uses.
  1. Add NeedExceptionHandling as a VMTrap::Event.
  1. Make VMTraps::m_trapBits Atomic. This makes it easier to set and clear the NeedExceptionHandling bit from the mutator without a lock.
  1. RETURN_IF_EXCEPTION now checks VMTraps::m_trapBits (via VMTraps::needHandling()) instead of checking VM::m_exception. If the VMTraps::m_trapBits is non-null, the macro will call VM:hasExceptionsAfterHandlingTraps() to service VMTraps events as appropriate before returning whether an exception is being thrown. The result of VM:hasExceptionsAfterHandlingTraps() will determine if RETURN_IF_EXCEPTION returns or not.

VM:hasExceptionsAfterHandlingTraps() is intentionally designed to take a minimum
of arguments (just the VM as this pointer). This is because RETURN_IF_EXCEPTION
is called from many places, and we would like to minimize code size bloating
from this change.

  1. Simplify paramaters of VMTraps::handleTraps().

NeedDebuggerBreak's callFrame argument was always vm.topCallFrame anyway.
So, the patch makes it explicit, and removes the callFrame parameter.

NeedWatchdogCheck's globalObject argument should have always been
vm.entryScope->globalObject(), and we can remove the globalObject parameter.

Before this, we pass in whichever globalObject was convenient to grab hold of.
However, the idea of the watchdog is to time out the current script executing
on the stack. Hence, it makes sense to identify thay script by the globalObject
in use at VM entry.

So far, the only clients that uses the watchdog mechanism only operates in
scenarios with only one globalObject anyway. So this formalization to use
VMEntryScope's globalObject does not change the expected behavior.

  1. Make the execution of termination more robust. Before reading this, please read the description of the Events in VMTraps.h first, especially the section on NeedTermination.

Here's the life cycle of a termination:

  1. a client requests termination of the current execution stack by calling VM::notifyNeedTermination(). notifyNeedTermination() does 2 things:
  1. fire the NeedTermination event on VMTraps.
  1. set the VM::m_terminationInProgress flag.
  1. Firing the NeedTermination event on VMTraps means setting the NeedTermination bit on VMTraps::m_trapBits. This bit will be polled by the mutator thread later at various designated points (including RETURN_IF_EXCEPTION, which we added in this patch).

Once the mutator sees the NeedTermination bit is set, it will clear the bit
and throw the TerminationException (see VMTraps::handleTraps()). This is
unless the mutator thread is currently in a DeferTermination scope (see (8)
below). If in a DeferTermination scope, then it will not throw the
TerminationException.

Since the NeedTermination bit is cleared, the VM will no longer call
VMTraps::handleTraps() to service the event. If the mutator thread is in
a DeferTermination scope, then on exiting the scope (at scope destruction),
the scope will see that VM::m_terminationInProgress is set, and throw the
deferred TerminationException then.

  1. The TerminationException will trigger unwinding out of the current stack until we get to the outermost VMEntryScope.
  1. At the the outermost VMEntryScope, we will clear VM::m_terminationInProgress if the NeedTermination bit in VMtraps::m_trapBits is cleared.

If the NeedTermination bit is set, then that means we haven't thrown the
TerminationException yet. Currently, clients expect that we must throw the
TerminationException if NeedTermination was requested (again, read comments
at the top of VMTraps.h).

If the NeedTermination bit is set, we'll leave VM::m_terminationInProgress
set until the next time we re-enter the VM and exit to the outermost
VMEntryScope.

  1. The purpose of VM::m_terminationInProgress is to provide a summary of the fact that the VM is in a state of trying to terminate the current stack.

Note that this state is first indicated by the NeedTermination bit being set
in VMTraps::m_trapBits. Then, in VMTraps::handleTraps(), the state is
handed of with the NeedTermination bit being cleared, and the
TerminationException being thrown.

While the VM is in this termination state, we need to prevent new DFG/FTL
JIT code from being compiled and run. The reason is the firing of the
NeedTermination event has invalidated DFG/FTL code on the stack, thereby
allowing their baseline / LLInt versions which have VMTraps polling checks
to run. We don't want to compile new DFG / FTL code and possibly get stuck
in loops in there before the termination is complete.

In operationOptimize(), we check if VM::m_terminationInProgress is set, and
prevent new DFG (and therefore FTL) code from being compiled if needed.
Note: it is easier to check a single flag, VM::m_terminationInProgress,
then to check both if the NeedTermination bit is set or if the
TerminationException is being being thrown.

  1. One complication of being able to service VMTraps in RETURN_IF_EXCEPTION checks is that some of our code (usually for lengthier initializations and bootstrapping) currently does not handle exceptions well, e.g. JSGlobalObject::init(). They rely on the code crashing if an exception is thrown while still initializing.

However, for a worker thread, a TerminationException (requested by the main
thread) may arrive before the initialization is complete. This can lead to
crashes because part of the initialization may be aborted in the presence of
an exception, while other parts still expect everything prior to have been
initialized correctly. For resource exhaustion cases (which is abnormal), it
is OK to crash. For the TerminationException (which can be part of normal
operation), we should not be crashing.

To work around this, we introduce a DeferTermination RAII scope object that we
deploy in this type of initialization code. With the scope in effect,

  1. if a TerminationException arrives but hasn't been thrown yet, it will be deferred till the scope ends before being thrown.
  2. if a TerminationException has already been thrown, the scope will stash the exception, clear it from the VM so that the initialization code can run to completion, and then re-throw the exception when the scope ends.

Currently, we only need to use the DeferTermination scope in a few places
where we know that initialization code will only run for a short period of time.

DeferTermination should not be used for code that can block waiting on an
external event for a long time. Obviously, doing so will prevent the VM
termination mechanism from working.

  1. Replaced llint_slow_path_check_if_exception_is_uncatchable_and_notify_profiler

and operationCheckIfExceptionIsUncatchableAndNotifyProfiler with
llint_slow_path_retrieve_and_clear_exception_if_catchable and
operationRetrieveAndClearExceptionIfCatchable.

The 2 runtime functions doesn't actually do anything to notify a profiler.
So, we drop that part of the name.

After returning from these runtime functions respectively, the previous LLInt
and JIT code, which calls these runtimes functions, would go on to load
VM::m_exception, and then store a nullptr there to clear it. This is wasteful.

This patch changes the runtime function to clear and return the Exception
instead. As a result, the calling LLInt and JIT code is simplified a bit.

Note also that clearing an exception now also entails clearing the
NeedExceptionHandling bit in VMTraps::m_trapBits in an atomic way. The above
change makes it easy to do this clearing with C++ code.

  1. Fix ScriptFunctionCall::call() to handle exceptions correctly. Previously,

it had one case where it propagates an exception, while another eats it.
Change this function to eat the exception in both cases. This is approproiate
because ScriptFunctionCall is only used to execute some Inspector instrumentation
calls. It doesn't make sense to propagate the exception back to user code.

  1. Fix the lazy initialization of JSGlobalObject::m_defaultCollator to be able to

handle the TerminationException.

  1. Not related to TerminationException, but this patch also fixes

MarkedArgumentBuffer::expandCapacity() to use Gigacage::tryMalloc() instead of
Gigacage::malloc(). This is needed as one of the fixes to make the
accompanying test case work.

This patch increases code size by 320K (144K for JSC, 176K for WebCore) measured
on x86_64.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::branchTest32):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchTest32):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchTest32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest32):

  • bindings/ScriptFunctionCall.cpp:

(Deprecated::ScriptFunctionCall::call):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckTraps):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):

  • interpreter/InterpreterInlines.h:

(JSC::Interpreter::execute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_check_traps):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOperations.cpp:

(JSC::JSC_DEFINE_JIT_OPERATION):

  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/ArgList.cpp:

(JSC::MarkedArgumentBuffer::expandCapacity):

  • runtime/DeferTermination.h: Added.

(JSC::DeferTermination::DeferTermination):
(JSC::DeferTermination::~DeferTermination):

  • runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception const):
(JSC::ExceptionScope::exception): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::finishCreation):

  • runtime/LazyPropertyInlines.h:

(JSC::ElementType>::callFunc):

  • runtime/StringPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/VM.cpp:

(JSC::VM::hasExceptionsAfterHandlingTraps):
(JSC::VM::clearException):
(JSC::VM::setException):
(JSC::VM::throwTerminationException):
(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::terminationInProgress const):
(JSC::VM::setTerminationInProgress):
(JSC::VM::notifyNeedTermination):
(JSC::VM::DeferExceptionScope::DeferExceptionScope):
(JSC::VM::DeferExceptionScope::~DeferExceptionScope):
(JSC::VM::handleTraps): Deleted.
(JSC::VM::needTrapHandling): Deleted.
(JSC::VM::needTrapHandlingAddress): Deleted.
(JSC::VM::setException): Deleted.
(JSC::VM::clearException): Deleted.

  • runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::~VMEntryScope):

  • runtime/VMTraps.cpp:

(JSC::VMTraps::tryInstallTrapBreakpoints):
(JSC::VMTraps::fireTrap):
(JSC::VMTraps::handleTraps):
(JSC::VMTraps::takeTopPriorityTrap):
(JSC::VMTraps::deferTermination):
(JSC::VMTraps::undoDeferTermination):

  • runtime/VMTraps.h:

(JSC::VMTraps::onlyContainsAsyncEvents):
(JSC::VMTraps::needHandling const):
(JSC::VMTraps::trapBitsAddress):
(JSC::VMTraps::isDeferringTermination const):
(JSC::VMTraps::notifyGrabAllLocks):
(JSC::VMTraps::hasTrapBit):
(JSC::VMTraps::clearTrapBit):
(JSC::VMTraps::setTrapBit):
(JSC::VMTraps::Mask::Mask): Deleted.
(JSC::VMTraps::Mask::allEventTypes): Deleted.
(JSC::VMTraps::Mask::bits const): Deleted.
(JSC::VMTraps::Mask::init): Deleted.
(JSC::VMTraps::interruptingTraps): Deleted.
(JSC::VMTraps::needTrapHandling): Deleted.
(JSC::VMTraps::needTrapHandlingAddress): Deleted.
(JSC::VMTraps::hasTrapForEvent): Deleted.
(JSC::VMTraps::setTrapForEvent): Deleted.
(JSC::VMTraps::clearTrapForEvent): Deleted.

Source/WebCore:

  1. Add DeferTermination in WorkerOrWorkletScriptController::initScript(). This allows us to avoid having to make all exception checking in WorkerOrWorkletScriptController::initScript() very thorough and complete. Currently, they aren't.
  1. Fix WorkerOrWorkletScriptController::evaluate() to handle the TerminationException.
  1. Fix JSEventListener::handleEvent() to handle the TerminationException correctly. Previously, in one case, it was checking scope.exception() for the exception, but the exception has already been taken out of there.
  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • workers/WorkerOrWorkletScriptController.cpp:

(WebCore::WorkerOrWorkletScriptController::evaluate):
(WebCore::WorkerOrWorkletScriptController::initScript):

5:31 AM Changeset in webkit [275796] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

RenderFlexibleBox::m_hasDefiniteHeight should not need to be mutable
​https://bugs.webkit.org/show_bug.cgi?id=224404

Reviewed by Antti Koivisto.

Let's just fix constness instead.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth):
(WebCore::RenderFlexibleBox::crossAxisIntrinsicExtentForChild):
(WebCore::RenderFlexibleBox::useChildAspectRatio):
(WebCore::RenderFlexibleBox::childMainSizeIsDefinite):
(WebCore::RenderFlexibleBox::childCrossSizeIsDefinite):
(WebCore::RenderFlexibleBox::childHasIntrinsicMainAxisSize):
(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const): Deleted.
(WebCore::RenderFlexibleBox::crossAxisIntrinsicExtentForChild const): Deleted.
(WebCore::RenderFlexibleBox::useChildAspectRatio const): Deleted.
(WebCore::RenderFlexibleBox::childMainSizeIsDefinite const): Deleted.
(WebCore::RenderFlexibleBox::childCrossSizeIsDefinite const): Deleted.
(WebCore::RenderFlexibleBox::childHasIntrinsicMainAxisSize const): Deleted.

  • rendering/RenderFlexibleBox.h:
4:20 AM Changeset in webkit [275795] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

Improve step description when compile-webkit step is skipped
​https://bugs.webkit.org/show_bug.cgi?id=224373

Reviewed by Jonathan Bedard.

  • CISupport/ews-build/steps.py:

(CompileWebKit.getResultSummary): Set custom summary when this step is skipped.

  • CISupport/ews-build/steps_unittest.py: Updated unit-tests.
1:39 AM Changeset in webkit [275794] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix test crashes after r275779
​https://bugs.webkit.org/show_bug.cgi?id=224305
rdar://71962196

  • NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::WebIDBServer): rolling back change on setting thread name as we see crash in
pthread_setname_np.

Apr 9, 2021:

11:43 PM Changeset in webkit [275793] by graouts@webkit.org
  • 20 edits in trunk

calc() simplification for a multiplication should apply the multiplication to each value of an addition
​https://bugs.webkit.org/show_bug.cgi?id=224376

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Mark 99 WPT progressions.

  • web-platform-tests/css/css-backgrounds/animations/background-position-origin-interpolation-expected.txt:
  • web-platform-tests/css/css-shapes/animation/shape-outside-interpolation-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-margin-003-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-circle-010-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-circle-011-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-010-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-011-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-inset-008-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-inset-009-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-polygon-006-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

An expression such as calc(0.5 * (100% + 100px)) should be simplified to calc(50% + 50px). We produce
these types of expressions when blending between a percentage and a dimension, and they can also be
specified explicitly in style.

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcOperationNode::combineChildren):

LayoutTests:

Rebase some non-WPT tests to account for new results.

  • css3/calc/simplification-expected.txt:
  • transitions/background-position-transitions-expected.txt:
  • transitions/background-position-transitions.html:
9:09 PM Changeset in webkit [275792] by Simon Fraser
  • 3 edits in trunk/Source/WebKit

[iOS WK2] CADisplayLink in the web process is used unintentionally
​https://bugs.webkit.org/show_bug.cgi?id=224395

Reviewed by Tim Horton.

When RemoteLayerTreeDrawingArea called windowScreenDidChange() from its constructor,
m_page.drawingArea() was null which resulted in DisplayRefreshMonitor::create()
receiving a null DisplayRefreshMonitorFactory*, so it fell back to the legacy
DisplayRefreshMonitorIOS, instead of using RemoteLayerTreeDisplayRefreshMonitor.

Fix by sending windowScreenDidChange() from the UI process, with the synthetic
DisplayID generated from the webPageID(). This has the advantage that
WebPageProxy will also store the correct DisplayID, and is more similar to macOS.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

8:01 PM Changeset in webkit [275791] by Wenson Hsieh
  • 12 edits
    2 adds in trunk

REGRESSION (r271660): Tap highlight no longer shows when tapping clickable elements without touch event listeners
​https://bugs.webkit.org/show_bug.cgi?id=224385
<rdar://problem/76462370>

Reviewed by Tim Horton.

Source/WebKit:

In r271660, I added a call to -finishInteraction when resetting the synthetic tap gesture to fix a bug where
it was possible for the tap highlight to remain indefinitely when tapping on a clickable element with a touchend
event listener. This was because the touch end deferring gesture defers -_singleTapDidReset: until after
-_didGetTapHighlightForRequest:…nodeHasBuiltInClickHandling:, where we receive the tap highlight information.

`
2021-04-09 13:05:27.141097-0700 -[WKContentView(WKInteraction) _singleTapIdentified:]
2021-04-09 13:05:27.148678-0700 -[WKContentView(WKInteraction) _didGetTapHighlightForRequest:…nodeHasBuiltInClickHandling:]
2021-04-09 13:05:27.162525-0700 -[WKContentView(WKInteraction) _singleTapRecognized:]
2021-04-09 13:05:27.162675-0700 ↳ -[WKContentView(WKInteraction) _showTapHighlight]
2021-04-09 13:05:27.163250-0700 -[WKContentView(WKInteraction) _singleTapDidReset:]
2021-04-09 13:05:51.849481-0700 ↳ -[WKContentView(WKInteraction) _finishInteraction]
`

However, in the case where there is no touchend event listener and when fast-click is active, we reset the tap
gesture before receiving the tap highlight information:

`
2021-04-09 13:05:51.836638-0700 -[WKContentView(WKInteraction) _singleTapIdentified:]
2021-04-09 13:05:51.846152-0700 -[WKContentView(WKInteraction) _singleTapRecognized:]
2021-04-09 13:05:51.847196-0700 -[WKContentView(WKInteraction) _singleTapDidReset:]
2021-04-09 13:05:51.848563-0700 -[WKContentView(WKInteraction) _didGetTapHighlightForRequest:…nodeHasBuiltInClickHandling:]
2021-04-09 13:05:51.848851-0700 ↳ -[WKContentView(WKInteraction) _showTapHighlight]
2021-04-09 13:05:51.849481-0700 ↳ -[WKContentView(WKInteraction) _finishInteraction]

`

Critically, this means that calling -_finishInteraction in -_singleTapDidReset: prematurely flagged the
tap highlight request as complete (by setting _isTapHighlightIDValid to NO) in the case where we aren't
deferring gestures, which caused us to avoid showing the tap highlight at all when we eventually receive the tap
highlight information.

To fix this, only fade out the tap highlight view in -_singleTapDidReset: if the tap highlight request has
already finished (i.e. _isTapHighlightIDValid has been set to NO). Additionally, split logic for fading out
the highlight view into a separate method, and add a BOOL flag to make the fading idempotent.

Test: fast/events/touch/ios/tap-highlight-during-synthetic-click.html

  • UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
  • UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _tapHighlightViewRect]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView tapHighlightViewRect]):

Also add a testing-only method to report the frame of the tap highlight view. Note that this only attempts to
return the current frame of the tap highlight view instead of converting the frame to the coordinate system of
the content view (as other similar testing hooks do), since the tap highlight view only exists in the view
hierarchy for a brief duration.

(-[WKContentView _finishInteraction]):
(-[WKContentView _fadeTapHighlightViewIfNeeded]):
(-[WKContentView _singleTapDidReset:]):

Tools:

Add plumbing to expose the frame of the tap highlight view via UIScriptController.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::tapHighlightViewRect const):

  • WebKitTestRunner/ios/UIScriptControllerIOS.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::tapHighlightViewRect const):

LayoutTests:

Add a new layout test that exercises 3 scenarios, using the new testing SPI:

  1. Tapping on a button that prevents the "touchend" event (and therefore prevents clicking) should cause

the tap highlight to not show up.

  1. Tapping on a button that has a "touchend" event listener and does not prevent default should cause the tap

highlight to show up.

  1. Tapping on a button with no event listeners should cause the tap highlight to show up.
  • fast/events/touch/ios/tap-highlight-during-synthetic-click-expected.txt: Added.
  • fast/events/touch/ios/tap-highlight-during-synthetic-click.html: Added.
  • resources/ui-helper.js:

(window.UIHelper.tapHighlightViewRect):

7:51 PM WebKitGTK/2.32.x edited by Michael Catanzaro
(diff)
7:11 PM Changeset in webkit [275790] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

scrollingTreeNodeDidScroll() should just trigger a rendering udpate
​https://bugs.webkit.org/show_bug.cgi?id=224394

Reviewed by Tim Horton.

After handling wheel events on the scrolling thread,
ThreadedScrollingTree::scrollingTreeNodeDidScroll() appends to a queue of pending updates
and then triggers applyPendingScrollUpdates() on the main thread to process those updates.
However, every rendering update also processes pending scroll updates via
synchronizeStateFromScrollingTree(), so it's simpler if we just trigger a rendering update.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate):
(WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit):

  • page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp:

(WebCore::ScrollingCoordinatorNicosia::scheduleTreeStateCommit):

6:55 PM Changeset in webkit [275789] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[iOS] Correct process-info rules to restrict to self
​https://bugs.webkit.org/show_bug.cgi?id=224383
<rdar://problem/66582454>

Reviewed by Eric Carlson.

The sandbox allows 'process-info' by default, so our allow rules have no real impact.
We need to deny access first, as we do on macOS, so that the allow rules have meaning.

I reviewed the macOS sandbox, and made sure the iOS sandbox allows the same items.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
6:00 PM Changeset in webkit [275788] by Alexey Shvayka
  • 34 edits in trunk

Remove className() and toStringName() from the method table
​https://bugs.webkit.org/show_bug.cgi?id=224247

Reviewed by Darin Adler.

Source/JavaScriptCore:

ES6 introduced Symbol.toStringTag to customize Object.prototype.toString return value.
It was adopted by WebIDL spec, Chrome's DevTools, Node.js etc. There is no reason to
keep 2 method table methods, each with only 1 call site, instead of using the symbol.

Also, it's a bit confusing that for some objects, method table's className() returns
different result than JSCell::className(VM&).

This change:

  1. Removes JSProxy's className() / toStringName() methods because its target() is a global object that never has these overrides and uses Symbol.toStringTag instead.
  1. Removes DebuggerScope's className() / toStringName() overrides because its objectAtScope() has these methods extremely rarely (e.g. with (new Date) {}), and its not displayed by Web Inspector.
  1. Merges JSCallbackObject's className() / toStringName() methods into Symbol.toStringTag branch of getOwnPropertySlot(), with permissive property attributes. To avoid any possible breakage, we make sure that it will be shadowed by a structure property.
  1. Reworks JSObject::calculatedClassName() to rely on Symbol.toStringTag, matching Chrome's DevTools behavior. On its own, it's a nice change for Web Inspector. We make sure to lookup Symbol.toStringTag if constructor.name inference fails to avoid confusion when extending builtins.
  1. Removes now unused className() from the method table.
  1. Removes toStringName() override from JSFinalizationRegistry because its builtin tag [1] is already "Object".
  1. Introduces BooleanObjectType for Boolean wrapper object, and Boolean.prototype as it's also required to have a BooleanData internal slot [2].
  1. Reworks Object.prototype.toString to determine builtin tag [1] based on JSType rather than performing method table call. It's guaranteed that a) the set of types we are checking against won't be expanded, and b) objects with these types have correct className.
  1. Removes now unused toStringTag() from the method table.

This patch is performance-neutral and carefully preserves current behavior for API objects,
including isPokerBros() hack.

[1]: ​https://tc39.es/ecma262/#sec-object.prototype.tostring (steps 5-14)
[2]: ​https://tc39.es/ecma262/#sec-properties-of-the-boolean-prototype-object

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::getOwnPropertySlot):
(JSC::JSCallbackObject<Parent>::className): Deleted.
(JSC::JSCallbackObject<Parent>::toStringName): Deleted.

  • API/tests/testapiScripts/testapi.js:
  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::className): Deleted.
(JSC::DebuggerScope::toStringName): Deleted.

  • debugger/DebuggerScope.h:
  • runtime/BooleanObject.cpp:

(JSC::BooleanObject::toStringName): Deleted.

  • runtime/BooleanObject.h:

(JSC::BooleanObject::createStructure):

  • runtime/BooleanPrototype.h:
  • runtime/ClassInfo.h:
  • runtime/DateInstance.cpp:

(JSC::DateInstance::toStringName): Deleted.

  • runtime/DateInstance.h:
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::toStringName): Deleted.

  • runtime/ErrorInstance.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::className): Deleted.
(JSC::JSCell::toStringName): Deleted.

  • runtime/JSCell.h:
  • runtime/JSFinalizationRegistry.cpp:

(JSC::JSFinalizationRegistry::toStringName): Deleted.

  • runtime/JSFinalizationRegistry.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):
(JSC::JSObject::className): Deleted.
(JSC::isPokerBros): Deleted.
(JSC::JSObject::toStringName): Deleted.

  • runtime/JSObject.h:
  • runtime/JSProxy.cpp:

(JSC::JSProxy::className): Deleted.
(JSC::JSProxy::toStringName): Deleted.

  • runtime/JSProxy.h:
  • runtime/JSType.cpp:

(WTF::printInternal):

  • runtime/JSType.h:
  • runtime/NumberObject.cpp:

(JSC::NumberObject::toStringName): Deleted.

  • runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

  • runtime/ObjectPrototype.cpp:

(JSC::isPokerBros):
(JSC::inferBuiltinTag):
(JSC::objectPrototypeToString):

  1. Removes jsNontrivialString() because it's assertion may fail in case of iOS hack.
  2. Utilizes AtomStringImpl to avoid allocating StringImpl for a small fixed set of strings.
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::toStringName): Deleted.

  • runtime/RegExpObject.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::toStringName): Deleted.

  • runtime/StringObject.h:

LayoutTests:

  • inspector/model/remote-object-get-properties-expected.txt:
  • inspector/model/remote-object-get-properties.html:
5:45 PM Changeset in webkit [275787] by Jean-Yves Avenard
  • 17 edits
    2 adds in trunk

Media Session action should default to the MediaElement's default when no MediaSession handler are set
​https://bugs.webkit.org/show_bug.cgi?id=224278
<rdar://problem/76339841>

Reviewed by Youenn Fablet .

Source/WebCore:

When a media session doesn't explicitly define an action handler, we use the media element
default action of the same type.
Media Session doesn't track a particular media element, instead it loosely defines a guessed playback state
that tracks if some element in the current document is playing and not muted or otherwise paused.
(see ​https://w3c.github.io/mediasession/#playback-state-model)
We therefore need to determine what is currently the most suitable media element available in this document.
Unlike the Media Controller and the Now Playing policy that will only ever select a media
if it is currently playing and not muted, for the Media Session we may have to interact with paused media elements.
For this we add a new PlaybackControlsPurpose named MediaSession defining new search criterias.
A media element will be up for selection if it's playable (according to autoplay policy). From then,
the best element will be selected accoring to its visibility, its size, if it's beeing played previously and
the last time it was interacted with.

Test: media/media-session/default-actionHandlers.html

  • Modules/mediasession/MediaSession.cpp:

(WebCore::platformCommandForMediaSessionAction): New convenience method to convert one datatype into another.
(WebCore::MediaSession::callActionHandler): Use user defined handler if present or run the related action on
the most suitable media element
(WebCore::MediaSession::activeMediaElement const): Determine the currently active media element in the current
Media Session's document.

  • Modules/mediasession/MediaSession.h:
  • html/HTMLMediaElement.cpp:

(WebCore::mediaElementSessionInfoForSession): Add new hasEverNotifiedAboutPlaying member.
(WebCore::preferMediaControlsForCandidateSessionOverOtherCandidateSession): Amend sorting algorithm to cater
for the MediaSession criterias described above.
(WebCore::mediaSessionMayBeConfusedWithMainContent): When using MediaSession purpose, there is no possible
ambiguity, amend as such.
(WebCore::HTMLMediaElement::bestMediaElementForRemoteControls): Renamed from bestMediaElementForShowingPlaybackControlsManager
method to better match how the method is actually used.

  • html/HTMLMediaElement.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canShowControlsManager const): Amend for new Media Session criterias.
(WebCore::MediaElementSession::didReceiveRemoteControlCommand): Always let MediaSession manage the actions handling.

  • html/MediaElementSession.h:
  • page/Page.cpp:

(WebCore::Page::playbackControlsManagerUpdateTimerFired): amend following method rename.

  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::nowPlayingEligibleSession): amend following method rename.

  • testing/Internals.cpp:

(WebCore::Internals::bestMediaElementForRemoteControls): Renamed from bestMediaElementForShowingPlaybackControlsManager as above.
(WebCore::Internals::sendMediaSessionAction): amend following method rename.

  • testing/Internals.h: Rename method
  • testing/Internals.idl: Rename method

LayoutTests:

  • media/audio-background-playback-playlist-expected.txt: Renamed method
  • media/audio-background-playback-playlist.html: Renamed method
  • media/media-session/default-actionHandlers-expected.txt: Added.
  • media/media-session/default-actionHandlers.html: Added.
  • platform/mac/media/video-best-element-for-playback-controls-purpose-expected.txt: Renamed method
  • platform/mac/media/video-best-element-for-playback-controls-purpose.html: Renamed method
5:03 PM Changeset in webkit [275786] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

Web process crashes if image extraction is requested for an element that is pending image extraction
​https://bugs.webkit.org/show_bug.cgi?id=224397
<rdar://problem/76472254>

Reviewed by Tim Horton.

Add a missing null check, so that we don't append (and then end up attempting to call) a null completion handler
in the case where image extraction is re-requested for an element that already has a pending image extraction
request.

This is currently not possible to reliably test this; in a future patch, I will add testing infrastructure that
will allow us to simulate image extraction requests and responses at the client layer.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestImageExtraction):

4:56 PM Changeset in webkit [275785] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS ] webgl/1.0.3/conformance/glsl/constructors/glsl-construct-ivec2.html is a flakey timeout
​https://bugs.webkit.org/show_bug.cgi?id=224396

Unreviewed test gardening.

  • platform/mac/TestExpectations: Updating test expectations to Pass Timeout while test is reviewed.
4:54 PM Changeset in webkit [275784] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix for test crashes after r275779.
​https://bugs.webkit.org/show_bug.cgi?id=224305
rdar://71962196

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createWebIDBServer): hitting an assertion when deref the WeakPtr, so rolling back to
old impl.

4:33 PM Changeset in webkit [275783] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit

[Cocoa] Don't set LD_RUNPATH_SEARCH_PATHS in the WebKit project file.
​https://bugs.webkit.org/show_bug.cgi?id=224392

Reviewed by Eric Carlson.

  • WebKit.xcodeproj/project.pbxproj:
3:20 PM Changeset in webkit [275782] by Russell Epstein
  • 1 copy in tags/Safari-612.1.10.1

Tag Safari-612.1.10.1.

3:20 PM Changeset in webkit [275781] by Russell Epstein
  • 1 delete in tags/Safari-612.1.10.1

Delete tag.

3:09 PM Changeset in webkit [275780] by Fujii Hironori
  • 2 edits in trunk/Source/WebCore

[Cairo][GPUP] GraphicsContextGLOpenGL::paintToCanvas can't paint into a remote canvas
​https://bugs.webkit.org/show_bug.cgi?id=224271

Reviewed by Don Olmstead.

WebGL canvas tests were failing for WinCairo port since r274327
enabled GPU process for canvas rendering. In the current
implementation of WebKitTestRunner, 2D canvases are in GPU
process, while WebGL canvases are in WebContent process. Remote
canvases in GPU process failed to drawImage() with a WebGL canvas
what is in WebContent process.

GraphicsContextGLOpenGL::paintToCanvas of Cairo port was painting
directly into PlatformContextCairo. It also should use
GraphicsContext::drawNativeImage as well as CG port does.

  • platform/graphics/cairo/GraphicsContextGLCairo.cpp:

(WebCore::GraphicsContextGLOpenGL::paintToCanvas):

3:04 PM Changeset in webkit [275779] by sihui_liu@apple.com
  • 8 edits in trunk/Source/WebKit

Create WebIDBServer only when it is needed
​https://bugs.webkit.org/show_bug.cgi?id=224305
rdar://71962196

Reviewed by Alex Christensen.

Currently each WebIDBServer comes with a thread, so we don't want to keep WebIDBServer if it's not in use.
Now there are two cases where network process needs a WebIDBServer:

  1. handle requests from UI process to collect or remove data
  2. handle requests from Web process to perform IDB operations

We created a WebIDBServer when network process connects to a web process, and we should create it when
web process is about to perform IDB operations. Also, we should remove WebIDBServer if it's done handling
requests, i.e count of pending requests from UI process is 0 and WebIDBServer is not associated with any web
process connection.

  • NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::create):
(WebKit::WebIDBServer::WebIDBServer): Add SessionID to thread name so we know which session to blame in crash
traces.
(WebKit::m_closeCallback):
(WebKit::WebIDBServer::getOrigins):
(WebKit::WebIDBServer::closeAndDeleteDatabasesModifiedSince):
(WebKit::WebIDBServer::closeAndDeleteDatabasesForOrigins):
(WebKit::WebIDBServer::renameOrigin):
(WebKit::WebIDBServer::removeConnection):
(WebKit::WebIDBServer::tryClose):

  • NetworkProcess/IndexedDB/WebIDBServer.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::addIDBConnection):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in: Add a message for web process to ask network process

to create WebIDBServer if not exists, and associate the web process connection with WebIDBServer.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::createWebIDBServer):
(WebKit::NetworkProcess::connectionToWebProcessClosed):
(WebKit::NetworkProcess::removeWebIDBServerIfPossible): Deleted. Move the removal code to WebIDBServer.

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):

2:56 PM Changeset in webkit [275778] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

git-webkit find doesn't work well with unicode characters in author name (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=223686

Reviewed by Jonathan Bedard.

  • Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:

(Info.main): Updated the error message.

1:37 PM Changeset in webkit [275777] by Russell Epstein
  • 13 edits in branches/safari-612.1.10-branch/Source

Cherry-pick r275775. rdar://problem/76467684

WTF SoftLinking macros can cause collisions with their target functions
​https://bugs.webkit.org/show_bug.cgi?id=224379
<rdar://76434202>

Reviewed by Eric Carlson.

Source/WebCore:

Don't include the SoftLinkLibxslt.h file in the .cpp file.

  • xml/SoftLinkLibxslt.cpp:
  • xml/SoftLinkLibxslt.h:

Source/WebCore/PAL:

  • pal/cf/CoreMediaSoftLink.h:
  • pal/cocoa/MediaToolboxSoftLink.h:
  • pal/cocoa/OpenGLSoftLinkCocoa.h:
  • pal/cocoa/PassKitSoftLink.h:
  • pal/ios/UIKitSoftLink.h:
  • pal/spi/cocoa/AccessibilitySupportSoftLink.cpp:
  • pal/spi/cocoa/AccessibilitySupportSoftLink.h:

Source/WTF:

Do not declare an inline version of the target function, as this will collide if the target function
becomes inlined. Instead, callers should use the explicit softLink_Library_Function() syntax, or
the LibrarySoftLinking.h headers should use #defines to re-declare the function name.

  • wtf/cocoa/SoftLinking.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:37 PM Changeset in webkit [275776] by Russell Epstein
  • 4 edits in branches/safari-612.1.10-branch/Source

Cherry-pick r275736. rdar://problem/76467285

Fix incorrect compile-time macro for CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER
​https://bugs.webkit.org/show_bug.cgi?id=224347
<rdar://problem/76353792>

Reviewed by Brent Fulgham.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): (WebKit::NetworkSessionCocoa::SessionSet::initializeEphemeralStatelessSessionIfNeeded):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:31 PM Changeset in webkit [275775] by jer.noble@apple.com
  • 13 edits in trunk/Source

WTF SoftLinking macros can cause collisions with their target functions
​https://bugs.webkit.org/show_bug.cgi?id=224379
<rdar://76434202>

Reviewed by Eric Carlson.

Source/WebCore:

Don't include the SoftLinkLibxslt.h file in the .cpp file.

  • xml/SoftLinkLibxslt.cpp:
  • xml/SoftLinkLibxslt.h:

Source/WebCore/PAL:

  • pal/cf/CoreMediaSoftLink.h:
  • pal/cocoa/MediaToolboxSoftLink.h:
  • pal/cocoa/OpenGLSoftLinkCocoa.h:
  • pal/cocoa/PassKitSoftLink.h:
  • pal/ios/UIKitSoftLink.h:
  • pal/spi/cocoa/AccessibilitySupportSoftLink.cpp:
  • pal/spi/cocoa/AccessibilitySupportSoftLink.h:

Source/WTF:

Do not declare an inline version of the target function, as this will collide if the target function
becomes inlined. Instead, callers should use the explicit softLink_Library_Function() syntax, or
the LibrarySoftLinking.h headers should use #defines to re-declare the function name.

  • wtf/cocoa/SoftLinking.h:
12:57 PM Changeset in webkit [275774] by graouts@webkit.org
  • 6 edits
    1 delete in trunk/LayoutTests

Remove tests under css3/shapes which are superseded by tests at imported/w3c/web-platform-tests/css/css-shapes
​https://bugs.webkit.org/show_bug.cgi?id=224378

Reviewed by Dean Jackson.

  • TestExpectations:
  • css3/shapes/shape-outside-invalid-001-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-001.html: Removed.
  • css3/shapes/shape-outside-invalid-circle-000-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-circle-000.html: Removed.
  • css3/shapes/shape-outside-invalid-circle-001-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-circle-001.html: Removed.
  • css3/shapes/shape-outside-invalid-circle-002-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-circle-002.html: Removed.
  • css3/shapes/shape-outside-invalid-circle-003-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-circle-003.html: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-001-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-001.html: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-002-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-002.html: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-003-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-003.html: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-004-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-004.html: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-005-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-005.html: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-006-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-ellipse-006.html: Removed.
  • css3/shapes/shape-outside-invalid-inset-001-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-inset-001.html: Removed.
  • css3/shapes/shape-outside-invalid-inset-002-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-inset-002.html: Removed.
  • css3/shapes/shape-outside-invalid-inset-003-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-inset-003.html: Removed.
  • css3/shapes/shape-outside-invalid-inset-004-expected.txt: Removed.
  • css3/shapes/shape-outside-invalid-inset-004.html: Removed.
  • css3/shapes/shape-outside-path-no-crash-expected.txt: Removed.
  • css3/shapes/shape-outside-path-no-crash.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-002-expected.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-002.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-003-expected.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-003.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-004-expected.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-004.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-006-expected.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-006.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-007-expected.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-007.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-008-expected.html: Removed.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-008.html: Removed.
  • css3/shapes/shape-outside/shape-box/w3c-import.log: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001-expected.txt: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002-expected.txt: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003-expected.txt: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004-expected.txt: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004.html: Removed.
  • css3/shapes/shape-outside/shape-image/gradients/w3c-import.log: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-000-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-000.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-001-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-001.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-002-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-002.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-003-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-003.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-004-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-004.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-005-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-005.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-006-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-006.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-007-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-007.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-008-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-008.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-009-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-009.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-010-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-010.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-011-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-011.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-012-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-012.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-013-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-013.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-014-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-014.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-015-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-015.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-016-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-016.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-017-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-017.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-018-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-018.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-019-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-019.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-020-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-020.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-021-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-021.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-022-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-022.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-023-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-023.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-024-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-024.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-025-expected.html: Removed.
  • css3/shapes/shape-outside/shape-image/shape-image-025.html: Removed.
  • css3/shapes/shape-outside/shape-image/support/animated.gif: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.svg: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.svg: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.svg: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle.jpg: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle.svg: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-20.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-50.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.svg: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.gif: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.jpg: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.png: Removed.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.svg: Removed.
  • css3/shapes/shape-outside/shape-image/support/w3c-import.log: Removed.
  • css3/shapes/shape-outside/shape-image/w3c-import.log: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/circle/w3c-import.log: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/w3c-import.log: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/inset/w3c-import.log: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/polygon/w3c-import.log: Removed.
  • css3/shapes/shape-outside/supported-shapes/support/rounded-rectangle.js: Removed.
  • css3/shapes/shape-outside/supported-shapes/support/subpixel-utils.js: Removed.
  • css3/shapes/shape-outside/supported-shapes/support/test-utils.js: Removed.
  • css3/shapes/shape-outside/supported-shapes/support/w3c-import.log: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-002.html: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-image-threshold-003.html: Removed.
  • css3/shapes/shape-outside/values/shape-margin-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-margin-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-margin-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-margin-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-margin-002-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-margin-002.html: Removed.
  • css3/shapes/shape-outside/values/shape-margin-003-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-margin-003.html: Removed.
  • css3/shapes/shape-outside/values/shape-margin-004-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-margin-004.html: Removed.
  • css3/shapes/shape-outside/values/shape-margin-005-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-margin-005.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-box-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-box-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-002-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-002.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-003.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-004-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-004.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-005-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-005.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-006.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-007.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-008.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-009-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-009.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-010-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-010.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-011-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-circle-011.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-002-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-002.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-003.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-004.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-006.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-007.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-008.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-009-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-009.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-002-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-002.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-003-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-003.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-004-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-004.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-005.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-006.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-007.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-008-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-008.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-009-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-inset-009.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-002-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-002.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-003.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-004-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-004.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-005-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-005.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-006-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-polygon-006.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-inherit-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-inherit-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-initial-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-initial-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-none-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-none-000.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-notation-000-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-shape-notation-000.html: Removed.
  • css3/shapes/shape-outside/values/support/parsing-utils.js: Removed.
  • css3/shapes/shape-outside/values/support/w3c-import.log: Removed.
  • css3/shapes/shape-outside/values/w3c-import.log: Removed.
  • css3/shapes/spec-examples/shape-outside-001-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-001.html: Removed.
  • css3/shapes/spec-examples/shape-outside-002-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-002.html: Removed.
  • css3/shapes/spec-examples/shape-outside-003-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-003.html: Removed.
  • css3/shapes/spec-examples/shape-outside-004-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-004.html: Removed.
  • css3/shapes/spec-examples/shape-outside-005-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-005.html: Removed.
  • css3/shapes/spec-examples/shape-outside-006-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-006.html: Removed.
  • css3/shapes/spec-examples/shape-outside-007-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-007.html: Removed.
  • css3/shapes/spec-examples/shape-outside-008-expected.html: Removed.
  • css3/shapes/spec-examples/shape-outside-008.html: Removed.
  • css3/shapes/spec-examples/shape-outside-010-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-010.html: Removed.
  • css3/shapes/spec-examples/shape-outside-011-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-011.html: Removed.
  • css3/shapes/spec-examples/shape-outside-012-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-012.html: Removed.
  • css3/shapes/spec-examples/shape-outside-013-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-013.html: Removed.
  • css3/shapes/spec-examples/shape-outside-014-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-014.html: Removed.
  • css3/shapes/spec-examples/shape-outside-015-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-015.html: Removed.
  • css3/shapes/spec-examples/shape-outside-016-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-016.html: Removed.
  • css3/shapes/spec-examples/shape-outside-017-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-017.html: Removed.
  • css3/shapes/spec-examples/shape-outside-018-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-018.html: Removed.
  • css3/shapes/spec-examples/shape-outside-019-expected.txt: Removed.
  • css3/shapes/spec-examples/shape-outside-019.html: Removed.
  • css3/shapes/spec-examples/support/circle-no-shadow.png: Removed.
  • css3/shapes/spec-examples/support/circle-shadow.png: Removed.
  • css3/shapes/spec-examples/support/rounded-triangle.svg: Removed.
  • css3/shapes/spec-examples/support/spec-example-utils.js: Removed.
  • css3/shapes/spec-examples/support/w3c-import.log: Removed.
  • css3/shapes/spec-examples/w3c-import.log: Removed.
  • css3/shapes/w3c-import.log: Removed.
  • platform/glib/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/wincairo/TestExpectations:
12:49 PM Changeset in webkit [275773] by Sam Sneddon
  • 7 edits in trunk/Tools

Make TestInput take a Test object, not a path
​https://bugs.webkit.org/show_bug.cgi?id=224329

Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests): Remove test_to_skip argument; skipped tests aren't for the runner.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests._run_tests): TestInput expects a Test.
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits): TestInput expects a Test.
(SharderTests.get_test_input): TestInput expects a Test.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._collect_tests):
Move duplicated code from Manager.run and Manager.print_expectations here.
(Manager._tests_to_run):
Renamed from Manager._prepare_lists; now just gives tests to run.
(Manager._test_input_for_file): Now takes a Test, not a str; device_type changes behaviour and shouldn't have any default.
(Manager._test_is_slow): device_type changes behaviour and shouldn't have any default.
(Manager._test_should_dump_jsconsolelog_in_stderr): device_type changes behaviour and shouldn't have any default.
(Manager._get_test_inputs): device_type changes behaviour and shouldn't have any default.
(Manager._update_worker_count): device_type changes behaviour and shouldn't have any default.
(Manager._set_up_run): device_type changes behaviour and shouldn't have any default.
(Manager.run):
Largely just change for Manager._collect_tests, also renaming the sets to match their
clearer names in print_expectations.
Additionally, now generate skip results here, as they aren't to do with actually running
tests, they're about test selection.
(Manager._run_test_subset): Remove tests_to_skip argument, devie_type is required.
(Manager._run_tests): Remove tests_to_skip argument, devie_type is required.
(Manager._print_expectation_line_for_test): Now takes a Test, not a str; device_type changes behaviour and shouldn't have any default.
(Manager._print_expectations_for_subset): Change default of tests_to_skip to avoid set/dict oddness.
(Manager.print_expectations): Largely change for Manager._collect_tests.

  • Scripts/webkitpy/layout_tests/models/test.py:

(Test): Use attrs to avoid having to define cmp, hash, repr, etc.

  • Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput.init): Take a Test, not a str.
(TestInput.test_name): Maintain compatibility with code reading TestInput.test_name for now.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.merge): Fix merging of dicts-of-sets, rather than overwriting the sets.
(TestRunResults.merge.merge_dict_sets): Implement the merging.

12:05 PM Changeset in webkit [275772] by commit-queue@webkit.org
  • 6 edits in trunk

[css-grid] Set hasIntrinsicWidth & hasIntrinsicHeight properties for SVG element's intrinsic size
​https://bugs.webkit.org/show_bug.cgi?id=223504

Patch by Ziran Sun <Ziran Sun> on 2021-04-09
Reviewed by Javier Fernandez.

Source/WebCore:

In RenderReplaced::computeReplacedLogicalWidth/RenderReplaced::computeReplacedLogicalHeight(),
hasIntrinsicWidth and hasIntrinsicHeight are decided by whether the value is bigger than 0.
This is not alway true. The SVG element sets its hasIntrinsicWidth/hasIntrinsicHeight property
in line with its lengthType(). This change adds checks for SVG element cases specifically.

  • platform/graphics/FloatSize.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth const):
(WebCore::RenderReplaced::computeReplacedLogicalHeight const):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation const):

LayoutTests:

Enable 4 tests that pass now.

11:55 AM EarlyWarningSystem edited by aakash_jain@apple.com
(diff)
11:35 AM Changeset in webkit [275771] by Said Abou-Hallawa
  • 3 edits in trunk/LayoutTests

[ macOS wk2 ARM64 ] fast/images/async-image-background-change.html is a flakey timeout
​https://bugs.webkit.org/show_bug.cgi?id=223469

Reviewed by Darin Adler.

If the event 'webkitImageFrameReady' fires before registering its listener,
the test will timeout.

Make sure the event listener is registered before changing the background
of the element.

  • fast/images/async-image-background-change.html:
  • platform/mac-wk2/TestExpectations:
11:33 AM Changeset in webkit [275770] by Alan Coon
  • 1 copy in tags/Safari-611.2.2

Tag Safari-611.2.2.

11:32 AM Changeset in webkit [275769] by Wenson Hsieh
  • 7 edits in trunk/LayoutTests

REGRESSION (r273154): 3 layout tests in editing/selection/ios are consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=224375
<rdar://problem/76420167>

Reviewed by Tim Horton.

Rebaseline some layout tests after enabling form control refresh on iOS.

  • editing/selection/ios/do-not-hide-selection-in-visible-field-expected.txt:
  • editing/selection/ios/do-not-hide-selection-in-visible-field.html:
  • editing/selection/ios/show-selection-in-transformed-container-2-expected.txt:
  • editing/selection/ios/show-selection-in-transformed-container-2.html:
  • editing/selection/ios/show-selection-in-transformed-container-expected.txt:
  • editing/selection/ios/show-selection-in-transformed-container.html:
11:31 AM Changeset in webkit [275768] by Chris Dumez
  • 30 edits
    1 add in trunk/Source/WebKit

Need to propagate and use 'canShowWhileLocked' in the GPU Process
​https://bugs.webkit.org/show_bug.cgi?id=224345
<rdar://76011262>

Reviewed by Tim Horton.

The GPUProcess was previously creating a single visibility propagation view even though
it was potentially serving several web views. Also, it would also pass
canShowWhileLocked=false when constructing the visibility propagation view, ignoring
the value of WKWebViewConfiguration._canShowWhileLocked. This would lead to issues for
apps relying on WKWebView to show content on the lock screen.

To address the issue, we now have the RemoteRenderingBackend construct its own
visibility propagation view in the GPUProcess. The GPUProcess constructs a
RemoteRenderingBackend per WebPage being served so this is convenient. When sending the
IPC to the GPUProcess to construct the RemoteRenderingBackend, the WebProcess now sends
the page identifier as well as the value of the canShowWhileLocked flag so that we
can use the correct canShowWhileLocked flag when constructing the visibility propagation
view.

The logic in the UIProcess for dealing with GPUProcess visibility propagation views
is now almost identical to WebProcess visibility propagation views. They are stored on
the WebPageProxy and get swapped on process-swap (since a new WebPage gets created).

  • GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::createRenderingBackend):

  • GPUProcess/GPUConnectionToWebProcess.h:
  • GPUProcess/GPUConnectionToWebProcess.messages.in:
  • GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::initializeGPUProcess):

  • GPUProcess/GPUProcess.h:
  • GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::create):
(WebKit::RemoteRenderingBackend::RemoteRenderingBackend):

  • GPUProcess/graphics/RemoteRenderingBackend.h:
  • GPUProcess/graphics/RemoteRenderingBackendCreationParameters.h: Added.

(WebKit::RemoteRenderingBackendCreationParameters::encode const):
(WebKit::RemoteRenderingBackendCreationParameters::decode):

  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::didCreateContextInWebProcessForVisibilityPropagation):
(WebKit::WebPageProxy::didCreateContextInGPUProcessForVisibilityPropagation):

  • UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::getGPUProcessConnection):
(WebKit::GPUProcessProxy::didCreateContextForVisibilityPropagation):

  • UIProcess/GPU/GPUProcessProxy.h:
  • UIProcess/GPU/GPUProcessProxy.messages.in:
  • UIProcess/PageClient.h:

(WebKit::PageClient::didCreateContextInWebProcessForVisibilityPropagation):

  • UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::didCreateContextInWebProcessForVisibilityPropagation):
(WebKit::ProvisionalPageProxy::didCreateContextInGPUProcessForVisibilityPropagation):
(WebKit::ProvisionalPageProxy::didReceiveMessage):

  • UIProcess/ProvisionalPageProxy.h:

(WebKit::ProvisionalPageProxy::contextIDForVisibilityPropagationInWebProcess const):
(WebKit::ProvisionalPageProxy::contextIDForVisibilityPropagationInGPUProcess const):

  • UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::SuspendedPageProxy):

  • UIProcess/SuspendedPageProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::swapToProvisionalPage):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::gpuProcessCrashed):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didCreateContextInWebProcessForVisibilityPropagation):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView _setupVisibilityPropagationViewForWebProcess]):
(-[WKContentView _setupVisibilityPropagationViewForGPUProcess]):
(-[WKContentView _removeVisibilityPropagationViewForWebProcess]):
(-[WKContentView _processDidExit]):
(-[WKContentView _gpuProcessCrashed]):
(-[WKContentView _didRelaunchProcess]):
(-[WKContentView _webProcessDidCreateContextForVisibilityPropagation]):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::create):
(WebKit::RemoteRenderingBackendProxy::RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::~RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::connectToGPUProcess):
(WebKit::RemoteRenderingBackendProxy::reestablishGPUProcessConnection):
(WebKit::RemoteRenderingBackendProxy::messageSenderDestinationID const):
(WebKit::RemoteRenderingBackendProxy::waitForDidCreateImageBufferBackend):
(WebKit::RemoteRenderingBackendProxy::waitForDidFlush):
(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::sharedMemoryForGetImageData):
(WebKit::RemoteRenderingBackendProxy::destroyGetImageDataSharedMemory):
(WebKit::RemoteRenderingBackendProxy::getDataURLForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getDataForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getBGRADataForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getShareableBitmap):
(WebKit::RemoteRenderingBackendProxy::cacheNativeImage):
(WebKit::RemoteRenderingBackendProxy::cacheFont):
(WebKit::RemoteRenderingBackendProxy::deleteAllFonts):
(WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):
(WebKit::RemoteRenderingBackendProxy::sendWakeupMessage):
(WebKit::RemoteRenderingBackendProxy::didAppendData):
(WebKit::RemoteRenderingBackendProxy::createItemBuffer):
(WebKit::RemoteRenderingBackendProxy::renderingBackendIdentifier const):

  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_lastNavigationWasAppBound):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::ensureRemoteRenderingBackendProxy):

10:19 AM Changeset in webkit [275767] by Russell Epstein
  • 5 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r274819. rdar://problem/76373741

AVAudioSessionCaptureDeviceManager should use crossThreadCopy
​https://bugs.webkit.org/show_bug.cgi?id=223565
<rdar://75480589>

Reviewed by Youenn Fablet.

Tested manually, this can only be tested on device.

  • platform/mediastream/CaptureDevice.h: Change access restriction for member variables from private: to protected: so derived classes can access them directly.
  • platform/mediastream/ios/AVAudioSessionCaptureDevice.h:
  • platform/mediastream/ios/AVAudioSessionCaptureDevice.mm: (WebCore::AVAudioSessionCaptureDevice::AVAudioSessionCaptureDevice): New constructor. (WebCore::AVAudioSessionCaptureDevice::isolatedCopy const): New.
  • platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm: (WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices): Use WTFMove(deviceList).isolatedCopy() when moving from AVAudioSession queue to main thread. (WebCore::AVAudioSessionCaptureDeviceManager::getCaptureDevices): Ditto.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:19 AM Changeset in webkit [275766] by Russell Epstein
  • 3 edits in branches/safari-611-branch/Source/WebKit

Cherry-pick r274377. rdar://problem/76412582

AX: PDF frame conversion routines need to be updated
​https://bugs.webkit.org/show_bug.cgi?id=223138

Reviewed by Darin Adler.

PDF bounding boxes are wrong in WebKit because.

1) There's no way for PDF objects to get the primary screen height. So we need to be able to return the primary

screen height from an object in the PDF hierarchy.

2) The WKPDFPluginAccessibilityObject's position was not being converted correctly.

  • WebProcess/Plugins/PDF/PDFPlugin.mm: (-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]): (-[WKPDFPluginAccessibilityObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (WebKit::PDFPlugin::boundsOnScreen const):
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: (-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:43 AM Changeset in webkit [275765] by Darin Adler
  • 9 edits in trunk/Source

[Cocoa] Reduce usage of autorelease, fix mistakes noticed nearby code using autorelease
​https://bugs.webkit.org/show_bug.cgi?id=224340

Reviewed by Anders Carlsson.

Source/WebCore:

  • bridge/objc/objc_instance.h: Added a static member function isInStringValue to

help factor the _web_description method better.

  • bridge/objc/objc_instance.mm:

(JSC::Bindings::ObjcInstance::stringValue const): Removed unneeded WTF prefixes.
(JSC::Bindings::ObjcInstance::isInStringValue): Added.
(-[NSObject _web_description]): Moved this out of the C++ namespace since it's an
Objective-C class implementation. Refactored for simplicity.

Source/WebKit:

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h: Use RetainPtr<NSURLRequest> instead of

strong NSURLRequest*& for the in/out argument of the
applySniffingPoliciesAndBindRequestToInferfaceIfNeeded function.

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::applySniffingPoliciesAndBindRequestToInferfaceIfNeeded):
Updated to use RetainPtr instead of strong. Also fixed some incorrect uses of %llu
to log NSUInteger and uint64_t, switching to "%lu" (and casting to unsigned long to
retain 32-bit compatibility) and "%" PRIu64 respectively.
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Ditto.
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): Ditto.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(setIgnoreHSTS): Added. Helper function so the code that makes a mutableCopy is isolated
in a helper function for clarity. A good counterpart to the existing ignoreHSTS function.
(updateIgnoreStrictTransportSecuritySetting): Changed to use a RetainPtr<NSURLRequest>
in/out argument instead of an argument plus a return value, obviating the need to use
autorelease and making this easier to read. Used setIgnoreHSTS for brevity in implementation.
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
Update for change to updateIgnoreStrictTransportSecuritySetting.
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]): Ditto.
(WebKit::proxyDictionary): Return a RetainPtr instead of something autoreleased.
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa): Call get() on the result of the
proxyDictionary function.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(makePolicyDecisionBlock): Return a BlockPtr instead of an autoreleased block.
Also use a lambda and retainWK for better clarity on capture semantics rather than
doing a WKRetain in the caller and a WKRelease in the block.
(setUpPagePolicyClient): Call get() on the result of the
makePolicyDecisionBlock function.

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::animationValueFromKeyframeValue): Return a RetainPtr instead of an
autoreleased object.
(WebKit::createAnimation): Call get() on the result of the
animationValueFromKeyframeValue function.

9:38 AM Changeset in webkit [275764] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit

[Cocoa] Silence a CFNetwork preference file access warning
​https://bugs.webkit.org/show_bug.cgi?id=224344
<rdar://problem/75839558>

Reviewed by Eric Carlson.

Silence sandbox telemetry and reports when CFNetwork attempts to read an unimportant preference
when executing in the WebContent process. This has been confirmed to be a silent/safe failiure
case (just returns false) and is not needed in the WebContent process.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:
8:58 AM Changeset in webkit [275763] by graouts@webkit.org
  • 24 edits in trunk

calc() values resulting from blending mixed type lengths should be simplified
​https://bugs.webkit.org/show_bug.cgi?id=224322

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Mark 84 WPT progressions.

  • web-platform-tests/css/css-backgrounds/animations/background-position-origin-interpolation-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-image-width-interpolation-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-radius-interpolation-expected.txt:
  • web-platform-tests/css/css-shapes/animation/shape-outside-composition-expected.txt:
  • web-platform-tests/css/css-shapes/animation/shape-outside-interpolation-expected.txt:
  • web-platform-tests/css/css-sizing/animation/max-height-composition-expected.txt:
  • web-platform-tests/css/css-sizing/animation/max-width-composition-expected.txt:
  • web-platform-tests/css/css-sizing/animation/min-height-composition-expected.txt:
  • web-platform-tests/css/css-sizing/animation/min-width-composition-expected.txt:
  • web-platform-tests/css/css-transitions/animations/vertical-align-composition-expected.txt:
  • web-platform-tests/css/css-transitions/animations/vertical-align-interpolation-expected.txt:
  • web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

While we simplify calc() values upon parsing such that operations are resolved and
values are sorted (percentages first then alphabetically by unit), we didn't do this
when creating calc() values during blending of lengths of mixed types.

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::create const):

LayoutTests:

Modify a few tests to account for the correct serialization.

  • fast/css/object-position/parsing-object-position-expected.txt:
  • fast/css/object-position/parsing-object-position.html:
  • fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
  • fast/shapes/shape-outside-floats/shape-outside-animation.html:
  • transitions/background-position-transitions.html:
  • transitions/background-position-transitions-expected.txt:
  • transitions/resources/transition-test-helpers.js: set computedValue such that

failures print out the actual value instead of "undefined".

8:02 AM Changeset in webkit [275762] by Chris Gambrell
  • 4 edits
    5 adds
    5 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/cookies convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=223891
<rdar://problem/75965634>

Reviewed by Jonathan Bedard.

  • http/tests/cookies/multiple-redirect-and-set-cookie.php: Removed.
  • http/tests/cookies/multiple-redirect-and-set-cookie.py: Added.

(redirect_url):
(redirect_to_step):
(step0):
(step2):

  • http/tests/cookies/resources/cookie-utilities.php: Removed.
  • http/tests/cookies/resources/cookie_utilities.py: Added.

(hostname_is_equal_to_string):
(reset_cookies_for_current_origin):
(reset_cookies):
(should_reset_cookies):
(wk_set_cookie):

  • http/tests/cookies/same-site/set-first-party-cross-site-cookies.php: Removed.
  • http/tests/cookies/same-site/set-first-party-cross-site-cookies.py: Added.
  • http/tests/cookies/same-site/set-first-party-same-site-cookies.php: Removed.
  • http/tests/cookies/same-site/set-first-party-same-site-cookies.py: Added.
  • http/tests/cookies/same-site/user-load-cross-site-redirect.php: Removed.
  • http/tests/cookies/same-site/user-load-cross-site-redirect.py: Added.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/wpe/TestExpectations:
6:48 AM Changeset in webkit [275761] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[RenderTreeBuilder] Cleanup the inline box wrappers when moving subtrees
​https://bugs.webkit.org/show_bug.cgi?id=224342
<rdar://76349279>

Reviewed by Antti Koivisto.

When an inline box is moved over to a different BFC (<span>), any inline level descendant (<span><img></span>) should release its inline box wrapper. This inline box wrapper (e.g. InlineFlowBox)
will eventually be destroy during the subsequent line layout of the original BFC.

  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::move):

6:25 AM Changeset in webkit [275760] by Aditya Keerthi
  • 10 edits in trunk

[iOS][FCR] Use context menus for text input datalist dropdowns
​https://bugs.webkit.org/show_bug.cgi?id=224287
<rdar://problem/76351317>

Reviewed by Wenson Hsieh.

Source/WebKit:

Use context menus rather than popovers to present suggested values for
text inputs with an associated datalist element.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:

Expose _isShowingDatalistSuggestions for testing. Previously, the test
runner traversed the view hierarchy in order to determine whether the
suggestions were visible. However, that approach is not reliable since
we no longer own the presented view, and UIKit could change the
implementation details of context menus.

  • UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _isShowingDataListSuggestions]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView doAfterEditorStateUpdateAfterFocusingElement:]):

Add a mechanism to perform actions after an editor state update when
focusing an element. If an update is not expected, run the block
immediately.

See below for details on why this is necessary.

(-[WKContentView _didUpdateEditorState]):

Run any pending blocks that were awaiting an editor state update.

(-[WKContentView isShowingDataListSuggestions]):

  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(-[WKDataListSuggestionsDropdown invalidate]):
(-[WKDataListSuggestionsDropdown didSelectOptionAtIndex:]):
(-[WKDataListSuggestionsDropdown _showSuggestions]):

Present a context menu displaying the suggestions if one is not already
presented.

Note that focusing text fields can result in automatic zooming of the
webview. This zooming occurs after an editor state update for focused
elements. The presentation of the context menu is deferred to run
after an editor state update to ensure any zooming occurs before
showing the menu. Without this deferred presentation mechanism, the
context menu can be presented before the state update, partially
obscuring the webview and resulting in an incorrect zoom once the
update occurs.

If a menu is already presented, use updateVisibleMenuWithBlock: to
update the contents of the menu.

(-[WKDataListSuggestionsDropdown _updateTextSuggestions]):
(-[WKDataListSuggestionsDropdown _updateSuggestionsMenuElements]):
(-[WKDataListSuggestionsDropdown _removeContextMenuInteraction]):
(-[WKDataListSuggestionsDropdown _suggestionsMenuDidPresent]):
(-[WKDataListSuggestionsDropdown _suggestionsMenuDidDismiss]):
(-[WKDataListSuggestionsDropdown _preferredEdgeInsetsForSuggestionsMenu]):

By default, context menus can obscure the presenting element if there
are too many options. Inset the menu so that it does not overlap the
text field. Present the menu above the text field if there is less
space underneath the field.

(-[WKDataListSuggestionsDropdown contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKDataListSuggestionsDropdown _contextMenuInteraction:styleForMenuWithConfiguration:]):
(-[WKDataListSuggestionsDropdown contextMenuInteraction:configurationForMenuAtLocation:]):
(-[WKDataListSuggestionsDropdown contextMenuInteraction:willDisplayMenuForConfiguration:animator:]):
(-[WKDataListSuggestionsDropdown contextMenuInteraction:willEndForConfiguration:animator:]):

Tools:

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::isShowingDataListSuggestions const):

Use the exposed information from the webview to determine whether the
datalist suggestions are visible, rather than traversing the view
hierarchy.

4:43 AM Changeset in webkit [275759] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK][WPE] Bump libsoup3 version to 2.99.3
​https://bugs.webkit.org/show_bug.cgi?id=224362

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-09
Reviewed by Žan Doberšek.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

  • platform/network/soup/GUniquePtrSoup.h:
  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::platformSuggestedFilename const):

4:35 AM Changeset in webkit [275758] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[css-flexbox] max-height percentages are wrongly resolved for replaced grid items in nested percentage flexboxes
​https://bugs.webkit.org/show_bug.cgi?id=223931

Patch by Ziran Sun <Ziran Sun> on 2021-04-09
Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-flexbox/percentage-max-height-004-expected.html: Added.
  • web-platform-tests/css/css-flexbox/percentage-max-height-004.html: Added.

Source/WebCore:

This change is to make sure that when overridingContainingBlockContentLogicalHeight of a replaced's containing block
element is indefinite, % max-height of the replaced element is resolved to none.

Test: imported/w3c/web-platform-tests/css/css-flexbox/percentage-max-height-004.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const):

3:58 AM WebKitGTK/2.32.x edited by Philippe Normand
(diff)
3:56 AM Changeset in webkit [275757] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, GStreamer Thunder decryptor build fix after r275599

  • platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp:

(decrypt):

3:25 AM Changeset in webkit [275756] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Teardown shadow root renderers on SlotAssignment::didChangeSlot
​https://bugs.webkit.org/show_bug.cgi?id=221386

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-09
Reviewed by Ryosuke Niwa.

This reverts r272900 to move the call to RenderTreeUpdater::tearDownRenderers() from hostChildElementDidChange()
to didChangeSlot(). This ensures the renderers are also cleared for other shadow root trees not using details
element.

  • dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::addSlotElementByName):
(WebCore::SlotAssignment::didChangeSlot):

  • dom/SlotAssignment.h:

(WebCore::ShadowRoot::hostChildElementDidChange):

2:35 AM WebKitGTK/2.32.x edited by Philippe Normand
(diff)
2:34 AM WebKitGTK/2.32.x edited by Philippe Normand
(diff)
2:29 AM Changeset in webkit [275755] by commit-queue@webkit.org
  • 4 edits in trunk

[GStreamer] fast/canvas/canvas-createPattern-video-loading.html is failing since r218170
​https://bugs.webkit.org/show_bug.cgi?id=173410

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-04-09
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

When a flush has been requested by the GL video sink, allocate a new copy of the sample
which has to be released. The copy is necessary so that the video dimensions can still be
fetched and also for canvas rendering. The release is necessary because the sample might
have been allocated by a hardware decoder and memory might have to be reclaimed by a
non-sysmem buffer pool.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::flushCurrentBuffer):
(WebCore::MediaPlayerPrivateGStreamer::paint):

LayoutTests:

  • platform/gtk/TestExpectations: Unflag now-passing test.
2:17 AM Changeset in webkit [275754] by commit-queue@webkit.org
  • 6 edits in trunk

[css-grid] Fix min/max widths of grid affected by ancestor
​https://bugs.webkit.org/show_bug.cgi?id=222100

Patch by Ziran Sun <Ziran Sun> on 2021-04-09
LayoutTests/imported/w3c:

Reviewed by Javier Fernandez.

  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-002-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002-expected.txt:

Source/WebCore:

Reviewed by Reviewed by Javier Fernandez.

It's a reland of r273435, which got reverted because it broke
imported/w3c/web-platform-tests/css/css-flexbox/percentage-max-height-003.html. This change
narrows down the fix specificallly to the case when logical-width is recomputed.
We need to recalculate min/max widths of child that depend on the ancestor.
Before update logical-width, for element that needs preferredWidth recalcution,
it is necessary to make sure that min/max widths are set dirty.

This change is an import of chromium CL at
​https://chromium-review.googlesource.com/c/chromium/src/+/527640/
Only the parts that apply to this issue are imported.

Tests were already imported in WPT.

  • rendering/RenderBlock.cpp:

(WebCore::shouldRecalculateMinMaxWidthsAffectedByAncestor):
(WebCore::RenderBlock::recomputeLogicalWidth):

2:17 AM Changeset in webkit [275753] by commit-queue@webkit.org
  • 2 edits in trunk/Tools/buildstream

[Flatpak SDK] Update to libsoup 2.99.3
​https://bugs.webkit.org/show_bug.cgi?id=224361

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-04-09
Reviewed by Carlos Garcia Campos.

  • elements/sdk/libsoup3.bst:
2:11 AM Changeset in webkit [275752] by graouts@webkit.org
  • 2 edits in trunk/LayoutTests

[ Mac WK2 ] compositing/animation/keyframe-order.html is a flakey image failure
​https://bugs.webkit.org/show_bug.cgi?id=221359

Reviewed by Dean Jackson.

Attempt to make this test more stable by awaiting the resolution of the animation.ready
promise as well as UIHelper.renderingUpdate() to ensure the animation has been committed.

  • compositing/animation/keyframe-order.html:
2:06 AM WebKitGTK/2.32.x edited by Philippe Normand
(diff)
1:54 AM Changeset in webkit [275751] by ysuzuki@apple.com
  • 5 edits
    4 adds in trunk

ServiceWorker should save module scripts
​https://bugs.webkit.org/show_bug.cgi?id=224356
<rdar://problem/75634897>

Reviewed by Youenn Fablet.

Source/WebCore:

Test: http/wpt/service-workers/persistent-modules.html

In this patch, we call setScriptResource / scriptResource while loading service-worker module scripts in module loaders,
so that we can ensure that they are saved on the disk.

  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::notifyFinished):

  • bindings/js/WorkerModuleScriptLoader.cpp:

(WebCore::WorkerModuleScriptLoader::load):
(WebCore::WorkerModuleScriptLoader::notifyFinished):
(WebCore::WorkerModuleScriptLoader::notifyClientFinished):

  • bindings/js/WorkerModuleScriptLoader.h:

LayoutTests:

  • http/wpt/service-workers/persistent-modules-expected.txt: Added.
  • http/wpt/service-workers/persistent-modules.html: Added.
  • http/wpt/service-workers/resources/persistent-imported-module-script.py: Added.

(main):

  • http/wpt/service-workers/resources/persistent-module-worker.js: Added.
Note: See TracTimeline for information about the timeline view.