Timeline

May 5, 2021:

11:43 PM Changeset in webkit [277069] by Megan Gardner

• 11 edits in trunk/Source/WebCore

AppHighlight scrolls should be smooth
​https://bugs.webkit.org/show_bug.cgi?id=225395

Reviewed by Simon Fraser.

Leverage smooth scrolling experimental feature to allow AppHighlight scrolls
to be smooth.

• Modules/highlight/AppHighlightStorage.cpp:

(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):

• editing/Editor.cpp:

(WebCore::TemporarySelectionChange::setSelection):

• editing/Editor.h:
• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::revealSelection):

• editing/FrameSelection.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollTo const):

• page/ScrollBehavior.cpp:

(WebCore::useSmoothScrolling):

• platform/ScrollTypes.h:

8:37 PM Changeset in webkit [277068] by mark.lam@apple.com

• 15 edits in trunk/Source

Introduce VM::hasPendingTerminationException() to make code a little more terse.
​https://bugs.webkit.org/show_bug.cgi?id=225412

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This is purely a refactoring patch. There is no behavior change.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):

• jit/JITOperations.cpp:
• runtime/ExceptionScope.h:

(JSC::ExceptionScope::assertNoExceptionExceptTermination):
(JSC::ExceptionScope::releaseAssertNoExceptionExceptTermination):

• runtime/JSObject.h:

(JSC::JSObject::get const):

• runtime/LazyPropertyInlines.h:

(JSC::ElementType>::callFunc):

• runtime/VM.cpp:

(JSC::VM::throwException):

• runtime/VM.h:

(JSC::VM::hasPendingTerminationException const):

• runtime/VMTraps.cpp:

(JSC::VMTraps::deferTerminationSlow):

Source/WebCore:

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::handleResponseOnStreamingAction):

• bindings/js/JSDOMPromise.cpp:

(WebCore::DOMPromise::whenPromiseIsSettled):

• bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::reject):

• bindings/js/ReadableStream.cpp:

(WebCore::invokeReadableStreamFunction):
(WebCore::ReadableStream::lock):
(WebCore::checkReadableStream):

• bindings/js/ReadableStreamDefaultController.cpp:

(WebCore::invokeReadableStreamDefaultControllerFunction):
(WebCore::ReadableStreamDefaultController::error):
(WebCore::ReadableStreamDefaultController::enqueue):

7:34 PM Changeset in webkit [277067] by Aditya Keerthi

• 2 edits in trunk/Source/WebCore

[macOS] Use system colors for ActiveButtonText
​https://bugs.webkit.org/show_bug.cgi?id=225375
<rdar://problem/75863443>

Reviewed by Tim Horton.

Currently, the ActiveButtonText color keyword returns a hardcoded value
on macOS. This behavior is problematic since AppKit can make changes to
the button style, leaving us with illegible text when a button is
pressed.

To fix, return a system color for ActiveButtonText, so that our pressed
buttons are consistent with the rest of the system.

• rendering/RenderThemeMac.mm:

(WebCore::activeButtonTextColor):

AppKit determines the pressed (active) text color using the cell's
interiorBackgroundStyle. There is not a single system color exposed for
the pressed text color, so it must be determined dynamically.

Unfortunately, this requires us to create an NSButtonCell to determine
the appropriate color. However, this logic is relatively inexpensive,
since we cache exposed system colors.

(WebCore::RenderThemeMac::systemColor const):

Remove the hardcoded value.

7:01 PM Changeset in webkit [277066] by Robert Jenner

• 2 edits in trunk/LayoutTests

[ BigSur wk2 arm64 ] http/tests/inspector/network/resource-sizes-network.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=225430

Unrviewed test gardening.

Updating expectations to flaky (Pass Failure) while test is reviewed.

• platform/mac-wk2/TestExpectations:

6:05 PM Changeset in webkit [277065] by Russell Epstein

• 1 copy in tags/Safari-611.3.1

Tag Safari-611.3.1.

5:35 PM Changeset in webkit [277064] by Russell Epstein

• 8 edits in branches/safari-611-branch/Source

Versioning.

WebKit-7611.3.1

5:30 PM Changeset in webkit [277063] by Diego Pino Garcia

• 2 edits in trunk/Tools

[build.webkit.org] Add new post-commit builder WPE-Linux-64-bit-Release-Non-Unified-Build
​https://bugs.webkit.org/show_bug.cgi?id=225385

Reviewed by Aakash Jain.

This new post-commit builder will build WPE with Unified builds disabled.

By default, builders build WebKit using Unified sources to speed up
time compilation. Unfortunately, unified source compilation may hide
compilation errors sometimes. A common hidden error are missing headers
in some source files. This hidden compilation errors might be discovered
later when a group of source files are stashed together in a different
manner.

Having a Non-Unified source post-commit builder will help to detect
regressions in unified source compilation for a certain WebKit port,
in this case WPE Release. Usually when these regressions happen they
tend to happen too in other ports such as WebKitGTK, Win or PlayStation.

• CISupport/build-webkit-org/config.json:

5:27 PM Changeset in webkit [277062] by Russell Epstein

• 1 copy in tags/Safari-612.1.12.3

Tag Safari-612.1.12.3.

5:22 PM Changeset in webkit [277061] by Jonathan Bedard

• 6 edits
  1 delete in trunk/Tools

[run-api-tests] Use webkitcorepy's TaskPool
​https://bugs.webkit.org/show_bug.cgi?id=225221
<rdar://problem/77352465>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/setup.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
• Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:

(TaskPool.enter): Ensure that mock has been imported before spawning child processes.

• Scripts/run-api-tests: Moved from webkitpy/api_tests/run_api_tests.py.
• Scripts/webkitpy/api_tests/run_api_tests.py: Moved to run-api-tests.
• Scripts/webkitpy/api_tests/runner.py:

(_Worker): Representation of Worker process.
(_Worker.setup): Pass port object to worker process.
(_Worker.teardown): Un-set port object on worker process.
(_Worker.init): Construct object to hold a Worker process's variables.
(_Worker._run_single_test): Log test results, post results to parent.
(_Worker.run): Run shard with and post results to parent process.
(setup_shard): Run setup in Worker process.
(run_shard): Run test shard in Worker process.
(report_result): Receive result in the parent process.
((teardown_shard): Tear down Worker process.
(Runner.init):
(Runner.command_for_port):
(Runner._shard_tests): Split tests into shards to be efficiently run.
(Runner.run): Use TaskPool to run tests in sub processes.
(Runner.callback): Save results in parent process.
(Runner.result_map_by_status):
(Runner.handle): Deleted.
(_Worker._run_shard_with_binary): Deleted.
(_Worker.post): Deleted.
(_Worker.handle): Deleted.

5:19 PM Changeset in webkit [277060] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Gardened latest test failures.

imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html
is failing after r277031.

fast/canvas/canvas-composite-text-alpha.html is an image failure after r277024.

• platform/glib/TestExpectations:

5:19 PM Changeset in webkit [277059] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebKit

Merge Cherry-pick r276618. rdar://problem/77326484

5:19 PM Changeset in webkit [277058] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebKit

Merge Cherry-pick r276852. rdar://problem/77468295

5:18 PM Changeset in webkit [277057] by Russell Epstein

• 4 edits in branches/safari-611-branch/Source

Merge Cherry-pick r276742. rdar://problem/77326513

5:18 PM Changeset in webkit [277056] by Russell Epstein

• 5 edits
  2 adds in branches/safari-611-branch

Merge Cherry-pick r276688. rdar://problem//77326513

5:09 PM Changeset in webkit [277055] by Kate Cheney

• 5 edits in trunk/Source/WebKit

Remove network website data when a user clears an individual domain
​https://bugs.webkit.org/show_bug.cgi?id=225350
<rdar://problem/76029480>

Reviewed by Brent Fulgham.

Convert parameters to Optional values now that we use the function
for individual domains.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
We should check all possible website data entries and delete
network domain data if any of them contain a domain.

• NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::removeNetworkWebsiteData):

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::removeNetworkWebsiteData):

4:53 PM Changeset in webkit [277054] by Robert Jenner

• 2 edits in trunk/LayoutTests

[ macOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https.html is a flaky text failure
​https://bugs.webkit.org/show_bug.cgi?id=225421

Unreviewed test gardening.

Marking test as flaky (Pass Failure), while under review.

• platform/mac/TestExpectations:

4:38 PM Changeset in webkit [277053] by ntim@apple.com

• 14 edits
  8 adds in trunk/LayoutTests

Re-sync css/css-animations WPTs
​https://bugs.webkit.org/show_bug.cgi?id=225404

Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

• resources/resource-files.json:
• web-platform-tests/css/css-animations/nested-scale-animations-expected.html: Added.
• web-platform-tests/css/css-animations/nested-scale-animations.html: Added.
• web-platform-tests/css/css-animations/svg-transform-animation-expected.html: Added.
• web-platform-tests/css/css-animations/svg-transform-animation.html: Added.
• web-platform-tests/css/css-animations/transform-animation-under-large-scale-expected.html: Added.
• web-platform-tests/css/css-animations/transform-animation-under-large-scale.html: Added.
• web-platform-tests/css/css-animations/translation-animation-subpixel-offset-expected.html: Added.
• web-platform-tests/css/css-animations/translation-animation-subpixel-offset.html: Added.
• web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html:
• web-platform-tests/css/css-animations/event-dispatch.tentative-expected.txt:
• web-platform-tests/css/css-animations/event-dispatch.tentative.html:
• web-platform-tests/css/css-animations/parsing/animation-invalid-expected.txt:
• web-platform-tests/css/css-animations/parsing/animation-invalid.html:
• web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt:
• web-platform-tests/css/css-animations/parsing/animation-shorthand.html:
• web-platform-tests/css/css-animations/support/testcommon.js:

(armTimeoutWhenReady):

• web-platform-tests/css/css-animations/w3c-import.log:

LayoutTests:

• TestExpectations:
• tests-options.json:

4:23 PM Changeset in webkit [277052] by pvollan@apple.com

• 3 edits in trunk/Source/WebKit

Reduce sandbox telemetry
​https://bugs.webkit.org/show_bug.cgi?id=225417
<rdar://77489628>

Reviewed by Darin Adler.

Remove sandbox telemetry which is no longer needed.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

4:19 PM Changeset in webkit [277051] by Amir Mark Jr.

• 2 edits in trunk/LayoutTests

[MacOS wk2] http/tests/cache/disk-cache/disk-cache-remove-several-pending-writes.html is a flakey failure
​https://bugs.webkit.org/show_bug.cgi?id=223531

Unreviewed test gardening.

Removed debug from a previous test expectation for this bug.

• platform/mac-wk2/TestExpectations:

4:06 PM Changeset in webkit [277050] by Cameron McCormack

• 3 edits in trunk/Source/WebCore

Remove unused DisplayList::Recorder::ContextState::wasUsedForDrawing
​https://bugs.webkit.org/show_bug.cgi?id=225381

Reviewed by Simon Fraser.

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::canAppendItemOfType):
(WebCore::DisplayList::Recorder::restore):

• platform/graphics/displaylists/DisplayListRecorder.h:

4:01 PM Changeset in webkit [277049] by Ruben Turcios

• 5 edits in branches/safari-612.1.13-branch

Cherry-pick r277044. rdar://problem/77579966

Sampled Page Top Color: don't snapshot if the hit test location is an image or has an animation
​https://bugs.webkit.org/show_bug.cgi?id=225338

Reviewed by Tim Horton.

Source/WebCore:

Tests: SampledPageTopColor.HitTestHTMLImage

SampledPageTopColor.HitTestCSSBackgroundImage
SampledPageTopColor.HitTestCSSAnimation

• dom/Document.h:
• dom/Document.cpp: (WebCore::isValidPageSampleLocation): Added. (WebCore::samplePageColor): Added. (WebCore::Document::determineSampledPageTopColor): (WebCore::Document::isHitTestLocationThirdPartyFrame): Deleted. Refactor isHitTestLocationThirdPartyFrame (and the pixelColor lambda) into static functions that are right above Document::determineSampledPageTopColor for clarity and to allow for more flexibility. In order to check if the hit test node is an image (including having a CSS background-image) or has a CSS animation (or CSS transition), it's necessary to continue to hit test beyond one node as the image and/or node with the CSS animation may be an ancestor (or unrelated position: absolute node) to the HitTestResult::innerNode. `

<div style="background-image: url(...)">

<button>Lorum ipsum ... </button>

</div>

`

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm: (TEST.SampledPageTopColor.HitTestHTMLImage): (TEST.SampledPageTopColor.HitTestCSSBackgroundImage): (TEST.SampledPageTopColor.HitTestCSSAnimation):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:01 PM Changeset in webkit [277048] by Ruben Turcios

• 2 edits in branches/safari-612.1.13-branch/Source/WebKit

Cherry-pick r277026. rdar://problem/77579962

REGRESSION (r276633): ASSERTION FAILED: !forbidMallocUseScopeCount

disableMallocRestrictionScopeCount

​https://bugs.webkit.org/show_bug.cgi?id=225374
<rdar://problem/77533237>

Reviewed by Chris Dumez.

Disable memory allocation checks in speech recognition code path.
No change of behavior.

• WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp: (WebKit::SpeechRecognitionRealtimeMediaSourceManager::Source::storageChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:46 PM Changeset in webkit [277047] by Cameron McCormack

• 6 edits in trunk/Source/WebCore

Rename DisplayList::Recorder::appendDrawGraphsItemWithCachedFont.
​https://bugs.webkit.org/show_bug.cgi?id=225382

Reviewed by Simon Fraser.

It appends a DrawGlyphsItem, not a DrawGraphsItem.

• platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawGlyphs):
(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

• platform/graphics/displaylists/DisplayListDrawGlyphsRecorderHarfBuzz.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

• platform/graphics/displaylists/DisplayListDrawGlyphsRecorderWin.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::appendDrawGlyphsItemWithCachedFont):

• platform/graphics/displaylists/DisplayListRecorder.h:

3:30 PM Changeset in webkit [277046] by Cameron McCormack

• 2 edits in trunk/Source/WebCore

Fix copy paste error in Recorder::canAppendItemOfType.
​https://bugs.webkit.org/show_bug.cgi?id=225380

Reviewed by Simon Fraser.

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::canAppendItemOfType):

3:22 PM Changeset in webkit [277045] by Devin Rousso

• 15 edits in trunk/Source

Sampled Page Top Color: tie into existing TCADA/RLTT systems so that the value is kept in sync with painting
​https://bugs.webkit.org/show_bug.cgi?id=225405

Reviewed by Tim Horton.

Instead of sending an IPC to the UIProcess whenever the logic to determine the sampled page
top color finishes, wait to dispatch the IPC until we're about to render (just like theme
color and page extended background color). On macOS, this means the IPC is dispatched inside
TiledCoreAnimationDrawingArea::updateRendering. On iOS, the Color is included as part of
the RemoteLayerTreeTransaction.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::determineSampledPageTopColor):

• page/ChromeClient.h:

(WebCore::ChromeClient::sampledPageTopColorChanged const): Renamed from didSamplePageTopColor.

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::sampledPageTopColorChanged const): Renamed from didSamplePageTopColor.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::sampledPageTopColorChanged): Added.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):
(WebKit::WebPage::flushPendingSampledPageTopColorChange): Added.
(WebKit::WebPage::didSamplePageTopColor): Deleted.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateRendering):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::sampledPageTopColor const): Added.
(WebKit::RemoteLayerTreeTransaction::setSampledPageTopColor): Added.

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sampledPageTopColorChanged): Renamed from didSamplePageTopColor.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):

2:53 PM Changeset in webkit [277044] by Devin Rousso

• 5 edits in trunk

Sampled Page Top Color: don't snapshot if the hit test location is an image or has an animation
​https://bugs.webkit.org/show_bug.cgi?id=225338

Reviewed by Tim Horton.

Source/WebCore:

Tests: SampledPageTopColor.HitTestHTMLImage

SampledPageTopColor.HitTestCSSBackgroundImage
SampledPageTopColor.HitTestCSSAnimation

• dom/Document.h:
• dom/Document.cpp:

(WebCore::isValidPageSampleLocation): Added.
(WebCore::samplePageColor): Added.
(WebCore::Document::determineSampledPageTopColor):
(WebCore::Document::isHitTestLocationThirdPartyFrame): Deleted.
Refactor isHitTestLocationThirdPartyFrame (and the pixelColor lambda) into static
functions that are right above Document::determineSampledPageTopColor for clarity and to
allow for more flexibility. In order to check if the hit test node is an image (including
having a CSS background-image) or has a CSS animation (or CSS transition), it's necessary
to continue to hit test beyond one node as the image and/or node with the CSS animation may
be an ancestor (or unrelated position: absolute node) to the HitTestResult::innerNode.
`

<div style="background-image: url(...)">

<button>Lorum ipsum ... </button>

</div>

`

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(TEST.SampledPageTopColor.HitTestHTMLImage):
(TEST.SampledPageTopColor.HitTestCSSBackgroundImage):
(TEST.SampledPageTopColor.HitTestCSSAnimation):

2:52 PM Changeset in webkit [277043] by aakash_jain@apple.com

• 4 edits in trunk/Tools

[build.webkit.org] Add a build step to set appropriate permissions on uploaded test results
​https://bugs.webkit.org/show_bug.cgi?id=225415

Reviewed by Dewei Zhu.

• CISupport/build-webkit-org/factories.py:

(TestFactory.init): Added the build-step.

• CISupport/build-webkit-org/steps.py:

(ExtractTestResults.resultDirectoryURL):
(SetPermissions): Build step to set permissions on uploaded test result directory.

2:33 PM Changeset in webkit [277042] by Amir Mark Jr.

• 2 edits in trunk/LayoutTests

[BigSur WK1] imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v* is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=221300

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

2:05 PM Changeset in webkit [277041] by weinig@apple.com

• 2 edits in trunk/LayoutTests

Skip fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled.html on windows
until the preference has been hooked up.

• platform/win/TestExpectations:

1:44 PM Changeset in webkit [277040] by Ruben Turcios

• 10 edits in branches/safari-612.1.13-branch

Cherry-pick r277030. rdar://problem/77573075

Sampled Page Top Color: take additional snapshots further down the page to see if the sampled top color is more than just a tiny strip
​https://bugs.webkit.org/show_bug.cgi?id=225323

Reviewed by Beth Dakin.

Source/WebCore:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

Tests: SampledPageTopColor.VerticalGradientBelowMaxDifference

SampledPageTopColor.VerticalGradientAboveMaxDifference

• dom/Document.cpp: (WebCore::Document::determineSampledPageTopColor):

Source/WebKit:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _setSampledPageTopColorMinHeight:]): Added. (-[WKWebViewConfiguration _sampledPageTopColorMinHeight]): Added.
• UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setupPageConfiguration:]): Provide SPI to configure the SampledPageTopColorMinHeight preference when creating the WKWebView.

Source/WTF:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

• Scripts/Preferences/WebPreferences.yaml:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm: (createWebViewWithSampledPageTopColorMaxDifference): (createHTMLGradientWithColorStops): (TEST.SampledPageTopColor.ZeroMaxDifference): (TEST.SampledPageTopColor.NegativeMaxDifference): (TEST.SampledPageTopColor.SolidColor): (TEST.SampledPageTopColor.DifferentColorsWithoutOutlierBelowMaxDifference): (TEST.SampledPageTopColor.DifferentColorsWithLeftOutlierAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsWithMiddleOutlierAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsWithRightOutlierAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsIndividuallyAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsCumulativelyAboveMaxDifference): (TEST.SampledPageTopColor.VerticalGradientBelowMaxDifference): Added. (TEST.SampledPageTopColor.VerticalGradientAboveMaxDifference): Added. (TEST.SampledPageTopColor.DISABLED_DisplayP3): (TEST.SampledPageTopColor.ExperimentalUseSampledPageTopColorForScrollAreaBackgroundColor):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 PM Changeset in webkit [277039] by ntim@apple.com

• 5 edits in trunk

Invalid media query keyword values should not be parsable
​https://bugs.webkit.org/show_bug.cgi?id=225282

Reviewed by Dean Jackson.

Updated WPT expectations.

LayoutTests/imported/w3c:

• web-platform-tests/css/mediaqueries/prefers-color-scheme-expected.txt:
• web-platform-tests/css/mediaqueries/prefers-reduced-motion-expected.txt:

Source/WebCore:

• css/MediaQueryExpression.cpp:

(WebCore::isValidValueForIdentMediaFeature):
(WebCore::featureWithValidIdent):

1:34 PM Changeset in webkit [277038] by achristensen@apple.com

• 5 edits in trunk/Source

Add WebKitAdditions stubs for new NetworkLoadMetrics
​https://bugs.webkit.org/show_bug.cgi?id=225406
<rdar://77563372>

Reviewed by Jer Noble.

Source/WebCore:

I also removed some dead code and added static asserts that do what the dead code was intended to do.

• platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics::isolatedCopy const):
(WebCore::NetworkLoadMetrics::operator== const):
(WebCore::NetworkLoadMetrics::encode const):
(WebCore::NetworkLoadMetrics::decode):
(WTF::Persistence::Coder<Optional<WebCore::NetworkLoadPriority>>::encode): Deleted.
(WTF::Persistence::Coder<Optional<WebCore::NetworkLoadPriority>>::decode): Deleted.

• platform/network/cocoa/WebCoreNSURLSession.mm:

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

1:34 PM Changeset in webkit [277037] by Robert Jenner

• 3 edits in trunk/LayoutTests

[ macOS/iOS Debug ] http/wpt/crypto/unwrap-rsa-key-crash.any.html (layout-test) is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=225315

Unreviewed test gardening.

Removing prior expectations.

• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

1:19 PM Changeset in webkit [277036] by yurys@chromium.org

• 2 edits in trunk/Source/ThirdParty/libwebrtc

[LibWebRTC][WPE][GTK] do not use system installed vpx headers when building webrtc
​https://bugs.webkit.org/show_bug.cgi?id=225401

Reviewed by Philippe Normand.

Use vpx headers from Source/ThirdParty/libwebrtc instead of those from the host system.

• CMakeLists.txt: expose libvpx headers to webrtc

12:37 PM Changeset in webkit [277035] by sbarati@apple.com

• 3 edits in trunk/JSTests

Update tests to use collectExtraSamplingProfilerData instead of collectSamplingProfilerDataForJSCShell
​https://bugs.webkit.org/show_bug.cgi?id=225398

Reviewed by Mark Lam.

I forgot to update the tests to use the new option name.

• stress/sampling-profiler-code-origin.js:
• stress/sampling-profiler-richards.js:

12:08 PM Changeset in webkit [277034] by dino@apple.com

• 2 edits in trunk/Source/WebKit

Separated layers need to be configured
​https://bugs.webkit.org/show_bug.cgi?id=225378

Reviewed by Tim Horton.

Configure a layer as it becomes separated. The actual code will
come from WebKitAdditions.

• Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(configureSeparatedLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):

11:47 AM Changeset in webkit [277033] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit

Add and adopt RemoteLayerBackingStore::Type (instead of "accelerates drawing" bit)
​https://bugs.webkit.org/show_bug.cgi?id=225384

Reviewed by Anders Carlsson.

No new tests, no behavior change, just refactoring.

• Shared/RemoteLayerTree/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::type const):
(WebKit::RemoteLayerBackingStore::acceleratesDrawing const): Deleted.

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):
(WebKit::RemoteLayerBackingStore::encode const):
(WebKit::RemoteLayerBackingStore::decode):
(WebKit::RemoteLayerBackingStore::pixelFormat const):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
(WebKit::RemoteLayerBackingStore::setBufferVolatility):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::nameForBackingStoreType):
(WebKit::operator<<):

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::updateBackingStore):
In preparation for adding another backing store type, refactor RemoteLayerBackingStore
to have a type enum instead of an "accelerates drawing" bit.

11:43 AM Changeset in webkit [277032] by Brent Fulgham

• 9 edits in trunk/Source/WebKit

[Cocoa] Remove access to the unused 'nvram' system command
​https://bugs.webkit.org/show_bug.cgi?id=225370
<rdar://problem/66583129>

Reviewed by Per Arne Vollan.

Add a 'deny' rule for nvram, since we don't use it and have no reason to access it.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

11:34 AM Changeset in webkit [277031] by aboya@igalia.com

• 22 edits
  5 adds
  2 deletes in trunk

[MSE][GStreamer] WebKitMediaSrc rework v2
​https://bugs.webkit.org/show_bug.cgi?id=225192

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

This patch (re)introduces a new source element for the MSE playback
pipeline. This is an iteration on the previous work on r249205 that
had to be reverted in r251365 because of flaky playbin3 bugs.

This new version avoids these pitfalls by avoiding flushes in
situations where they are avoidable and known to expose bugs.

This re-land shares many of the advantages that motivated the first
patch: seeks massively oversimplified and greater control by no longer
relying on appsrc. It can handle flushes of individual streams
natively.

Work has also gone into decoupling the state of the frame queue from
the state of WebKitMediaSrc so that the backend can survive
transitions from PAUSED to READY and back which
MediaPlayerPrivateGStreamer creates when playback ends. This latter
effort is not complete, and instead this version adds a special case
to inhibit downwards and back upwards transitions, avoiding any
issues.

It is expected that at this point this new backend is at least as
stable as the previous one. No LayoutTest has got worsened
expectations from adding this backend and some have improved.

• platform/GStreamer.cmake:
• platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:

(webKitGLVideoSinkFinalize):
(webKitGLVideoSinkSetMediaPlayerPrivate):

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<GstMiniObject>):
(WTF::derefGPtr<GstMiniObject>):

• platform/graphics/gstreamer/GRefPtrGStreamer.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(WebCore::MediaPlayerPrivateGStreamer::invalidateCachedPosition):

• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:

(WebCore::TrackPrivateBaseGStreamer::setInitialCaps):
(WebCore::TrackPrivateBaseGStreamer::initialCaps):

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
(WebCore::AppendPipeline::appsinkCapsChanged):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromStreamingThread):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):

• platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::demuxerSrcPadCaps):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::~MediaPlayerPrivateGStreamerMSE):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::play):
(WebCore::MediaPlayerPrivateGStreamerMSE::pause):
(WebCore::MediaPlayerPrivateGStreamerMSE::seek):
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
(WebCore::MediaPlayerPrivateGStreamerMSE::setReadyState):
(WebCore::MediaPlayerPrivateGStreamerMSE::propagateReadyStateToPlayer):
(WebCore::MediaPlayerPrivateGStreamerMSE::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamerMSE::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
(WebCore::MediaPlayerPrivateGStreamerMSE::unblockDurationChanges):
(WebCore::MediaPlayerPrivateGStreamerMSE::durationChanged):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::startSource):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

(WebCore::MediaPlayerPrivateGStreamerMSE::hasAllTracks const):
(WebCore::MediaPlayerPrivateGStreamerMSE::webKitMediaSrc):

• platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp:

(WebCore::MediaSourcePrivateGStreamer::addSourceBuffer):
(WebCore::MediaSourcePrivateGStreamer::markEndOfStream):
(WebCore::MediaSourcePrivateGStreamer::unmarkEndOfStream):
(WebCore::MediaSourcePrivateGStreamer::waitForSeekCompleted):
(WebCore::MediaSourcePrivateGStreamer::seekCompleted):
(WebCore::MediaSourcePrivateGStreamer::startPlaybackIfHasAllTracks):

• platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h:
• platform/graphics/gstreamer/mse/MediaSourceTrackGStreamer.cpp: Added.

(WebCore::MediaSourceTrackGStreamer::MediaSourceTrackGStreamer):
(WebCore::MediaSourceTrackGStreamer::~MediaSourceTrackGStreamer):
(WebCore::MediaSourceTrackGStreamer::create):
(WebCore::MediaSourceTrackGStreamer::isReadyForMoreSamples):
(WebCore::MediaSourceTrackGStreamer::notifyWhenReadyForMoreSamples):
(WebCore::MediaSourceTrackGStreamer::enqueueObject):
(WebCore::MediaSourceTrackGStreamer::clearQueue):
(WebCore::MediaSourceTrackGStreamer::remove):

• platform/graphics/gstreamer/mse/MediaSourceTrackGStreamer.h: Added.
• platform/graphics/gstreamer/mse/PlaybackPipeline.h: Removed.
• platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
(WebCore::SourceBufferPrivateGStreamer::flush):
(WebCore::SourceBufferPrivateGStreamer::enqueueSample):
(WebCore::SourceBufferPrivateGStreamer::isReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::allSamplesInTrackEnqueued):
(WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment):

• platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
• platform/graphics/gstreamer/mse/TrackQueue.cpp: Added.

(WebCore::TrackQueue::TrackQueue):
(WebCore::TrackQueue::enqueueObject):
(WebCore::TrackQueue::clear):
(WebCore::TrackQueue::flush):
(WebCore::TrackQueue::notifyWhenLowLevel):
(WebCore::TrackQueue::pop):
(WebCore::TrackQueue::notifyWhenNotEmpty):
(WebCore::TrackQueue::resetNotEmptyHandler):
(WebCore::TrackQueue::checkLowLevel):
(WebCore::TrackQueue::durationEnqueued const):

• platform/graphics/gstreamer/mse/TrackQueue.h: Added.

(WebCore::TrackQueue::isFull const):
(WebCore::TrackQueue::isEmpty const):
(WebCore::TrackQueue::hasNotEmptyHandler const):

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(WebKitMediaSrcPrivate::streamByName):
(WebKitMediaSrcPrivate::isStarted):
(WTF::adoptGRef):
(WTF::refGPtr<WebKitMediaSrcPad>):
(WTF::derefGPtr<WebKitMediaSrcPad>):
(webkit_media_src_pad_class_init):
(Stream::Stream):
(Stream::StreamingMembers::StreamingMembers):
(findPipeline):
(gstStreamType):
(streamTypeToString):
(webkit_media_src_class_init):
(webkit_media_src_init):
(webKitMediaSrcFinalize):
(webKitMediaSrcEmitStreams):
(webKitMediaSrcTearDownStream):
(webKitMediaSrcActivateMode):
(webKitMediaSrcPadLinked):
(webKitMediaSrcLoop):
(webKitMediaSrcStreamFlush):
(webKitMediaSrcFlush):
(webKitMediaSrcSeek):
(countStreamsOfType):
(webKitMediaSrcGetProperty):
(webKitMediaSrcChangeState):
(webKitMediaSrcSendEvent):
(webKitMediaSrcUriGetType):
(webKitMediaSrcGetProtocols):
(webKitMediaSrcGetUri):
(webKitMediaSrcSetUri):
(webKitMediaSrcUriHandlerInit):

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h:
• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h: Removed.

Tools:

WebKitMediaSrc is a GObject class and needs to follow some GObject
conventions that conflict with WebKit's. Make the checker aware of
this.

• Scripts/webkitpy/style/checker.py:

LayoutTests:

Update expectations.

• platform/glib/TestExpectations:
• platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt: Added.

11:17 AM Changeset in webkit [277030] by Devin Rousso

• 10 edits in trunk

Sampled Page Top Color: take additional snapshots further down the page to see if the sampled top color is more than just a tiny strip
​https://bugs.webkit.org/show_bug.cgi?id=225323

Reviewed by Beth Dakin.

Source/WebCore:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

Tests: SampledPageTopColor.VerticalGradientBelowMaxDifference

SampledPageTopColor.VerticalGradientAboveMaxDifference

• dom/Document.cpp:

(WebCore::Document::determineSampledPageTopColor):

Source/WebKit:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setSampledPageTopColorMinHeight:]): Added.
(-[WKWebViewConfiguration _sampledPageTopColorMinHeight]): Added.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):
Provide SPI to configure the SampledPageTopColorMinHeight preference when creating the WKWebView.

Source/WTF:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

• Scripts/Preferences/WebPreferences.yaml:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(createWebViewWithSampledPageTopColorMaxDifference):
(createHTMLGradientWithColorStops):
(TEST.SampledPageTopColor.ZeroMaxDifference):
(TEST.SampledPageTopColor.NegativeMaxDifference):
(TEST.SampledPageTopColor.SolidColor):
(TEST.SampledPageTopColor.DifferentColorsWithoutOutlierBelowMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsWithLeftOutlierAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsWithMiddleOutlierAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsWithRightOutlierAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsIndividuallyAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsCumulativelyAboveMaxDifference):
(TEST.SampledPageTopColor.VerticalGradientBelowMaxDifference): Added.
(TEST.SampledPageTopColor.VerticalGradientAboveMaxDifference): Added.
(TEST.SampledPageTopColor.DISABLED_DisplayP3):
(TEST.SampledPageTopColor.ExperimentalUseSampledPageTopColorForScrollAreaBackgroundColor):

11:12 AM Changeset in webkit [277029] by Chris Gambrell

• 2 edits
  2 adds in trunk/LayoutTests

[LayoutTests] http/tests/css/object-fit-delayed-img-svg.html yields errors due to missing scripts
​https://bugs.webkit.org/show_bug.cgi?id=225246
<rdar://problem/77397227>

Reviewed by Jonathan Bedard.

• http/tests/css/object-fit-delayed-img-svg.html:
• http/tests/css/resources/circle.svg: Added.
• http/tests/css/resources/delayedCircle.py: Added.

10:58 AM Changeset in webkit [277028] by youenn@apple.com

• 3 edits
  2 adds in trunk

No need to error a fetch body stream if its request or response is stopped
​https://bugs.webkit.org/show_bug.cgi?id=225347

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: http/wpt/fetch/fetch-response-body-stop-in-worker.html

• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::stop):
Nullify the source before we error it.

LayoutTests:

• http/wpt/fetch/fetch-response-body-stop-in-worker-expected.txt: Added.
• http/wpt/fetch/fetch-response-body-stop-in-worker.html: Added.

10:28 AM Changeset in webkit [277027] by mark.lam@apple.com

• 10 edits in trunk/Source/JavaScriptCore

Enable incremental sweeping of GCAwareJITStubRoutines.
​https://bugs.webkit.org/show_bug.cgi?id=225376

Reviewed by Filip Pizlo.

This patch makes the following changes:

1. Enhance JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines() to be able to run in an incremental time slice.

2. Added JITStubRoutineSet::notifyHaveRoutinesToDelete() so that GCAwareJITStubRoutine::observeZeroRefCount() can flag that the GC may have some dead GCAwareJITStubRoutines to delete.

3. Added JITStubRoutineSet::mayHaveRoutinesToDelete() so that clients can do a cheap check ahead of time to determine if there's work to do, and avoid calling JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines() altogether if not needed.

4. Added Heap::mayHaveJITStubRoutinesToDelete() and Heap::deleteDeadJITStubRoutines() as wrappers around JITStubRoutineSet::mayHaveRoutinesToDelete() and JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines() because the use of the JITStubRoutineSet is a heap internal implementation detail.

5. Enhanced the IncrementalSweeper to also call Heap::deleteDeadJITStubRoutines() if needed.

6. Enhanced Heap::sweepSynchronously() to also call Heap::deleteDeadJITStubRoutines() if needed.

7. Time slices for Heap::deleteDeadJITStubRoutines() is currently set at the current values:
   1. max of 1 ms (1/10 of the IncreamentalSweeper's time slice) when invoked from the IncreamentalSweeper.
   2. max of 5 ms when invoked from Heap::deleteUnmarkedCompiledCode().
   3. unlimited time (with a sanity check) when called from Heap::sweepSynchronously().

The choices of 1ms and 5ms were picked to not be too long, but would still delete
the bulk of the dead GCAwareJITStubRoutines quickly enough based on data from my
instrumented runs the CLI version of JetStream2.

I think these hardcoded values will do for now. If need be, we can try something
more sophisticated later.

• CMakeLists.txt:
• heap/Heap.cpp:

(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::sweepSynchronously):

• heap/Heap.h:
• heap/HeapInlines.h:

(JSC::Heap::mayHaveJITStubRoutinesToDelete):
(JSC::Heap::deleteDeadJITStubRoutines):

• heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep):

• heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

• heap/JITStubRoutineSet.h:

(JSC::JITStubRoutineSet::mayHaveRoutinesToDelete):
(JSC::JITStubRoutineSet::notifyHaveRoutinesToDelete):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

• jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::observeZeroRefCount):

• jit/JITStubRoutine.h:

(JSC::JITStubRoutine::createSelfManagedRoutine): Deleted.

10:00 AM Changeset in webkit [277026] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r276633): ASSERTION FAILED: !forbidMallocUseScopeCount

disableMallocRestrictionScopeCount

​https://bugs.webkit.org/show_bug.cgi?id=225374
<rdar://problem/77533237>

Reviewed by Chris Dumez.

Disable memory allocation checks in speech recognition code path.
No change of behavior.

• WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp:

(WebKit::SpeechRecognitionRealtimeMediaSourceManager::Source::storageChanged):

9:45 AM Changeset in webkit [277025] by Russell Epstein

• 1 edit in branches/safari-612.1.12-branch/Source/WebCore/html/HTMLElement.h

Unreviewed build fix. rdar://problem/77530347

Undefined symbols:

"WebCore::HTMLElement::isInsideImageOverlay(WebCore::SimpleRange const&)"

9:36 AM Changeset in webkit [277024] by weinig@apple.com

• 24 edits
  3 copies
  6 adds in trunk

Add preliminary support for specifying a color space for 2D canvas
​https://bugs.webkit.org/show_bug.cgi?id=225286

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/canvas/CanvasRenderingContext2DSettings-colorSpace-disabled.html

fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled.html
fast/canvas/canvas-color-space-display-p3.html

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

Add new files.

• html/canvas/CanvasRenderingContext2DSettings.idl:
• html/canvas/CanvasRenderingContext2DSettings.h:

Add a new setting blocked member to the CanvasRenderingContext2DSettings
dictionary for specifying a color space.

• html/canvas/PredefinedColorSpace.cpp: Added.
• html/canvas/PredefinedColorSpace.h: Added.
• html/canvas/PredefinedColorSpace.idl: Added.

Add a new IDL enumeration to represent the possible color spaces supported.
For ports that don't support DisplayP3, trying to use it will result in
type error from JS.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Add checks for color space and pixel format to 2d context reset optimation.
This can happen if the image buffer is allocated prior to the context being
requested (such as via canvas.toDataURL() or canvas.toBlob()).

(WebCore::HTMLCanvasElement::createImageBuffer const):
Pass the correct color space and pixel format (though
the later is always BGRA8 at the moment) to the ImageBuffer
create function to make a backing store in the right format.

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::createBufferForPainting const):

• html/HTMLVideoElement.h:

Pass color space and pixel format through to ensure the helper
buffer matches the correct color space.

• html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise):
Pass the existing defaults to HTMLVideoElement::createBufferForPainting.
In the future, ImageBitmap will also gain color space and pixel
format specificity and this will be updated.

• html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::pixelFormat const):
(WebCore::CanvasRenderingContext::colorSpace const):

• html/canvas/CanvasRenderingContext.h:

Add virtual base implementations of colorSpace and pixelFormat
which CanvasRenderingContext2D can override to return the
values specified in the CanvasRenderingContext2DSettings.

• html/canvas/CanvasRenderingContext2D.h:
• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fontProxy const):
Fix incorrect formatting.

(WebCore::CanvasRenderingContext2D::pixelFormat const):
(WebCore::CanvasRenderingContext2D::colorSpace const):
Add overrides, return m_settings.colorSpace for colorSpace.

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::CanvasRenderingContext2DBase::createCompositingBuffer):
(WebCore::CanvasRenderingContext2DBase::createPattern):
(WebCore::CanvasRenderingContext2DBase::drawTextUnchecked):
Pass along the colorSpace and pixelFormat when creating buffers.

• html/shadow/DateTimeSymbolicFieldElement.cpp:

Add missing includes that are now needed.

Source/WTF:

Add new experimental feature, CanvasColorSpaceEnabled, which blocks
access to the new ability to specify color spaces for 2D canvas.

• Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

• DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):
Add CanvasColorSpaceEnabled for windows.

LayoutTests:

Add basic tests for color space in canvas support.

• fast/canvas/CanvasRenderingContext2DSettings-colorSpace-disabled-expected.txt: Added.
• fast/canvas/CanvasRenderingContext2DSettings-colorSpace-disabled.html: Added.
• fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled-expected.txt: Added.
• fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled.html: Added.
• fast/canvas/canvas-color-space-display-p3-expected.html: Added.
• fast/canvas/canvas-color-space-display-p3.html: Added.

9:33 AM Changeset in webkit [277023] by Chris Lord

• 7 edits
  5 deletes in trunk/LayoutTests

Update WPT OffscreenCanvas tests to respect [EnforceRange]
​https://bugs.webkit.org/show_bug.cgi?id=225391

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Synchronise with upstream WPT OffscreenCanvas tests.

• web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny-expected.txt: Removed.
• web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.html: Removed.
• web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker-expected.txt: Removed.
• web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker.html: Removed.
• web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker.js: Removed.
• web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl-expected.txt:
• web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl.html:
• web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl.worker-expected.txt:
• web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl.worker.js:

(t.step):

LayoutTests:

WPT html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.html
passes after updating.

• platform/glib/TestExpectations:

9:19 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro

(diff)

9:18 AM Changeset in webkit [277022] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.32

Merge r277014 - [SOUP] Wrong cookie timestamp in case of long expire time
​https://bugs.webkit.org/show_bug.cgi?id=225389

Reviewed by Adrian Perez de Castro.

Source/WebCore:

There's an overflow when converting the dates in both libsoup2 and libsoup3, but for two different reasons. In
the case of libsoup2 we are using an int for the conversion of milliseconds to seconds which is not enough. In
the case of libsoup3 we are passing the value in milliseconds to g_date_time_new_from_unix_utc() that expects
seconds.

• platform/network/soup/CookieSoup.cpp:

(WebCore::msToSoupDate): Use int64_t instead of int for the cast.
(WebCore::Cookie::toSoupCookie const): Convert the value to seconds.

Tools:

Add a test case.

• TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerLongExpires):
(beforeAll):

9:18 AM Changeset in webkit [277021] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.32

Merge r277015 - USE_64KB_PAGE_BLOCK build option is broken
​https://bugs.webkit.org/show_bug.cgi?id=225393

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-05
Reviewed by Adrian Perez de Castro.

Call SET_AND_EXPOSE_TO_BUILD().

• Source/cmake/WebKitFeatures.cmake:

8:07 AM Changeset in webkit [277020] by Jean-Yves Avenard

• 7 edits in trunk

imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html is a flakey
​https://bugs.webkit.org/show_bug.cgi?id=225386
rdar://74704447

Reviewed by Eric Carlson.

Source/WebKit:

When enabling/disabling a track, the web content process would send a message to the GPU process which in turn
would send a message back to the content process, notifying that the track configuration had changed, that would
then enable/disable again the track.
If the content process in between those IPC messages had modified the track (such as via JS call), it was
possible for the track status to get lost once the GPU message above got actioned.

Having the GPU process notify that a track configuration got changed when it was originally triggered by the
content process is unnecessary. We modify the RemoteAudioTrack and RemoteVideoTrack so that if the change came
from the web process, the GPU process doesn't send a message back with information that could already be obsolete.

No new tests. Fix an assertion failure in tests.

• GPUProcess/media/RemoteAudioTrackProxy.cpp:

(WebKit::RemoteAudioTrackProxy::enabledChanged):

• GPUProcess/media/RemoteAudioTrackProxy.h:
• GPUProcess/media/RemoteVideoTrackProxy.cpp:

(WebKit::RemoteVideoTrackProxy::selectedChanged):

• GPUProcess/media/RemoteVideoTrackProxy.h:

LayoutTests:

• platform/mac-wk2/TestExpectations: Remove

8:02 AM Changeset in webkit [277019] by Chris Dumez

• 2 edits in trunk/Tools

Unreviewed, reverting r276985.

This test is still failing on Apple Silicon

Reverted changeset:

"Unreviewed, try and re-enable
AppleLanguagesTest.UpdateAppleLanguages on Apple Silicon."
​https://commits.webkit.org/r276985

7:48 AM Changeset in webkit [277018] by Chris Dumez

• 2 edits in trunk/Tools

REGRESSION (r272414?): [macOS] TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=221742
<rdar://problem/74220428>

Reviewed by Youenn Fablet.

Make sure the video is looping so that it cannot stop playing before the end of the test.
This is a speculative fix since I haven't been able to reproduce the issue.

• TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

7:11 AM Changeset in webkit [277017] by commit-queue@webkit.org

• 3 edits in trunk/Tools/buildstream

[Flatpak SDK] Update libwpe and wpebackend-fdo
​https://bugs.webkit.org/show_bug.cgi?id=225358

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-05
Reviewed by Adrian Perez de Castro.

• elements/sdk/libwpe.bst: Update to version 1.10.
• elements/sdk/wpebackend-fdo.bst: Update to 1.9.91, soon to be 1.10.

6:55 AM Changeset in webkit [277016] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] Wrap incoming audio buffers, complying with fastMalloc restrictions
​https://bugs.webkit.org/show_bug.cgi?id=225351

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-05
Reviewed by Xabier Rodriguez-Calvar.

The audio thread should avoid calling fastMalloc for performance reasons, so audio buffers
are now wrapped in GStreamer buffers and passed as read-only memories to the observers.

• platform/mediastream/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeIncomingAudioSourceLibWebRTC::OnData):

6:40 AM WebKitGTK/2.32.x edited by Michael Catanzaro

(diff)

6:39 AM Changeset in webkit [277015] by commit-queue@webkit.org

• 2 edits in trunk

USE_64KB_PAGE_BLOCK build option is broken
​https://bugs.webkit.org/show_bug.cgi?id=225393

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-05
Reviewed by Adrian Perez de Castro.

Call SET_AND_EXPOSE_TO_BUILD().

• Source/cmake/WebKitFeatures.cmake:

6:24 AM Changeset in webkit [277014] by Carlos Garcia Campos

• 4 edits in trunk

[SOUP] Wrong cookie timestamp in case of long expire time
​https://bugs.webkit.org/show_bug.cgi?id=225389

Reviewed by Adrian Perez de Castro.

Source/WebCore:

There's an overflow when converting the dates in both libsoup2 and libsoup3, but for two different reasons. In
the case of libsoup2 we are using an int for the conversion of milliseconds to seconds which is not enough. In
the case of libsoup3 we are passing the value in milliseconds to g_date_time_new_from_unix_utc() that expects
seconds.

• platform/network/soup/CookieSoup.cpp:

(WebCore::msToSoupDate): Use int64_t instead of int for the cast.
(WebCore::Cookie::toSoupCookie const): Convert the value to seconds.

Tools:

Add a test case.

• TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerLongExpires):
(beforeAll):

6:21 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro

(diff)

6:19 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro

(diff)

6:14 AM Changeset in webkit [277013] by rniwa@webkit.org

• 8 edits in trunk/Source/WebCore

Use WeakHashSet instead of HashSet of raw pointes in Document and SVGDocumentExtensions
​https://bugs.webkit.org/show_bug.cgi?id=225390

Reviewed by Antti Koivisto.

Replaced Document's m_documentSuspensionCallbackElements and m_articleElements as well as
SVGDocumentExtensions's m_timeContainers and m_svgFontFaceElements with WeakHashSet.

Also moved m_svgUseElements from Document to SVGDocumentExtensions as a WeakHashSet.

This patch also deletes Document::m_mediaStreamStateChangeElements which was never used,
m_mainArticleElement a WeakPtr instead of a raw pointer, replaces SVGDocumentExtensions's
m_rebuildElements, which is a temporary Vector used during tree mutations, with a Vector
of Refs instead of raw pointers.

No new tests since there should be no observable behavior differences.

• dom/Document.cpp:

(WebCore::Document::~Document): The release assert is moved to ~SVGDocumentExtensions.
(WebCore::Document::resolveStyle):
(WebCore::Document::suspend):
(WebCore::Document::resume):
(WebCore::Document::registerForDocumentSuspensionCallbacks):
(WebCore::Document::unregisterForDocumentSuspensionCallbacks):
(WebCore::Document::addSVGUseElement): Moved to SVGDocumentExtensions.
(WebCore::Document::removeSVGUseElement): Ditto.
(WebCore::Document::registerArticleElement):
(WebCore::Document::unregisterArticleElement):
(WebCore::Document::updateMainArticleElementAfterLayout):
(WebCore::Document::prepareCanvasesForDisplayIfNeeded):
(WebCore::Document::clearCanvasPreparation):
(WebCore::Document::canvasChanged):
(WebCore::Document::canvasDestroyed):

• dom/Document.h:

(WebCore::Document:: const const): Deleted.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
(WebCore::HTMLCanvasElement::didMoveToNewDocument):
(WebCore::HTMLCanvasElement::removedFromAncestor):

• style/StyleResolver.cpp:

(WebCore::Style::Resolver::addCurrentSVGFontFaceRules):

• svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Moved the release assertion
from ~Document.
(WebCore::SVGDocumentExtensions::addTimeContainer):
(WebCore::SVGDocumentExtensions::removeTimeContainer):
(WebCore::SVGDocumentExtensions::addUseElementWithPendingShadowTreeUpdate): Moved here
Document::addSVGUseElement.
(WebCore::SVGDocumentExtensions::removeUseElementWithPendingShadowTreeUpdate): Ditto.
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::rebuildElements):
(WebCore::SVGDocumentExtensions::clearTargetDependencies):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):
(WebCore::SVGDocumentExtensions::registerSVGFontFaceElement):
(WebCore::SVGDocumentExtensions::unregisterSVGFontFaceElement):

• svg/SVGDocumentExtensions.h:

(WebCore::SVGDocumentExtensions::useElementsWithPendingShadowTreeUpdate const): Added.
(WebCore::SVGDocumentExtensions::svgFontFaceElements const):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedIntoAncestor):
(WebCore::SVGUseElement::removedFromAncestor):
(WebCore::SVGUseElement::updateShadowTree):
(WebCore::SVGUseElement::invalidateShadowTree):

5:47 AM Changeset in webkit [277012] by commit-queue@webkit.org

• 2 edits in trunk

Fix typo in comment in WebKitFeatures.cmake
​https://bugs.webkit.org/show_bug.cgi?id=225392

Unreviewed.

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-05

• Source/cmake/WebKitFeatures.cmake:

5:43 AM WebKitGTK/2.32.x edited by Michael Catanzaro

(diff)

2:49 AM Changeset in webkit [277011] by Chris Lord

• 6 edits in trunk

OffscreenCanvas should preserve context transform after transferToImageBitmap
​https://bugs.webkit.org/show_bug.cgi?id=225304

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline transferToImageBitmap tests.

• web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt:
• web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap.w-expected.txt:

Source/WebCore:

transferToImageBitmap should not affect the state of the canvas
context. Instead of returning the actual canvas buffer, to which the
drawing context is tightly bound, return a copy and clear the
original.

No new tests, rebaselined existing tests.

• html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::transferToImageBitmap):
(WebCore::OffscreenCanvas::takeImageBuffer const):

• html/canvas/CanvasRenderingContext2DBase.h:

1:53 AM Changeset in webkit [277010] by youenn@apple.com

• 8 edits in trunk/Source/WebKit

Dynamically pass capture sandbox extensions to GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=225319

Reviewed by Eric Carlson.

Make sure to send the sandbox extensions for all WKWebView applications.
We do so once we are ready to start capture since TCC access should have been granted at that point.
Manually tested.

• GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::initializeGPUProcess):
(WebKit::GPUProcess::updateSandboxAccess):

• GPUProcess/GPUProcess.h:
• GPUProcess/GPUProcess.messages.in:
• GPUProcess/GPUProcessCreationParameters.cpp:

(WebKit::GPUProcessCreationParameters::encode const):
(WebKit::GPUProcessCreationParameters::decode):

• GPUProcess/GPUProcessCreationParameters.h:
• UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::GPUProcessProxy):
(WebKit::GPUProcessProxy::updateSandboxAccess):
(WebKit::GPUProcessProxy::updateCaptureAccess):
(WebKit::isSafari): Deleted.
(WebKit::shouldCreateCameraSandboxExtension): Deleted.
(WebKit::shouldCreateMicrophoneSandboxExtension): Deleted.

• UIProcess/GPU/GPUProcessProxy.h:

12:17 AM Changeset in webkit [277009] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.32/Source/WebCore/platform/gtk/po

Merge r277005 - Updated Swedish translation
​https://bugs.webkit.org/show_bug.cgi?id=225309

Patch by Anders Jonsson <​anders.jonsson@norsjovallen.se> on 2021-05-04
Rubber-stamped by Carlos Garcia Campos.

• sv.po:

May 4, 2021:

11:56 PM Changeset in webkit [277008] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.32/Source/WebKit

Merge r276430 - [GTK] Build error: Couldn't find include 'Soup-2.4.gir'
​https://bugs.webkit.org/show_bug.cgi?id=224926

Reviewed by Philippe Normand.

Use the right soup API version when generating the introspection.

• PlatformGTK.cmake:

11:56 PM Changeset in webkit [277007] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.32

Merge r276429 - [GTK][WPE] Bump libsoup3 version to 2.99.4
​https://bugs.webkit.org/show_bug.cgi?id=224925

Reviewed by Philippe Normand.

.:

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Source/WebCore:

Update to use the new API.

• platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::ResourceResponse):

• platform/network/soup/SoupVersioning.h:

(soup_message_get_tls_peer_certificate):
(soup_message_get_tls_peer_certificate_errors):
(soup_message_get_tls_certificate): Deleted.
(soup_message_get_tls_certificate_errors): Deleted.

Tools/buildstream:

• elements/sdk/libsoup3.bst:

LayoutTests:

Remove expectations for tests that should be passing now.

• platform/glib/TestExpectations:

11:56 PM Changeset in webkit [277006] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.32

Merge r275759 - [GTK][WPE] Bump libsoup3 version to 2.99.3
​https://bugs.webkit.org/show_bug.cgi?id=224362

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-09
Reviewed by Žan Doberšek.

.:

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Source/WebCore:

• platform/network/soup/GUniquePtrSoup.h:
• platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::platformSuggestedFilename const):

10:52 PM Changeset in webkit [277005] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Swedish translation
​https://bugs.webkit.org/show_bug.cgi?id=225309

Patch by Anders Jonsson <​anders.jonsson@norsjovallen.se> on 2021-05-04
Rubber-stamped by Carlos Garcia Campos.

• sv.po:

10:46 PM Changeset in webkit [277004] by commit-queue@webkit.org

• 5 edits
  137 adds in trunk/LayoutTests

Import webstorage WPTs
​https://bugs.webkit.org/show_bug.cgi?id=225369

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-05-04
Reviewed by Darin Adler.
LayoutTests/imported/w3c:

Import tip-of-tree webstorage WPTs with:
Tools/Scripts/import-w3c-tests -t web-platform-tests/webstorage

This patch also sets the baseline results for the newly imported tests.

• resources/import-expectations.json:
• web-platform-tests/webstorage/META.yml: Added.
• web-platform-tests/webstorage/README.md: Added.
• web-platform-tests/webstorage/defineProperty.window-expected.txt: Added.
• web-platform-tests/webstorage/defineProperty.window.html: Added.
• web-platform-tests/webstorage/defineProperty.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/document-domain-expected.txt: Added.
• web-platform-tests/webstorage/document-domain.html: Added.
• web-platform-tests/webstorage/eventTestHarness.js: Added.

(iframe.contentWindow.onstorage):
(runAfterNStorageEvents):
(onTimeout):
(countStorageEvents):
(clearStorage):

• web-platform-tests/webstorage/event_basic-expected.txt: Added.
• web-platform-tests/webstorage/event_basic.html: Added.
• web-platform-tests/webstorage/event_basic.js: Added.

(testStorages.):
(testStorages):

• web-platform-tests/webstorage/event_body_attribute-expected.txt: Added.
• web-platform-tests/webstorage/event_body_attribute.html: Added.
• web-platform-tests/webstorage/event_body_attribute.js: Added.

(testStorages.):
(testStorages):

• web-platform-tests/webstorage/event_case_sensitive-expected.txt: Added.
• web-platform-tests/webstorage/event_case_sensitive.html: Added.
• web-platform-tests/webstorage/event_case_sensitive.js: Added.

(testStorages.):
(testStorages):

• web-platform-tests/webstorage/event_constructor.window-expected.txt: Added.
• web-platform-tests/webstorage/event_constructor.window.html: Added.
• web-platform-tests/webstorage/event_constructor.window.js: Added.

(test):

• web-platform-tests/webstorage/event_initstorageevent.window-expected.txt: Added.
• web-platform-tests/webstorage/event_initstorageevent.window.html: Added.
• web-platform-tests/webstorage/event_initstorageevent.window.js: Added.

(test):

• web-platform-tests/webstorage/event_local_key-expected.txt: Added.
• web-platform-tests/webstorage/event_local_key.html: Added.
• web-platform-tests/webstorage/event_local_newvalue-expected.txt: Added.
• web-platform-tests/webstorage/event_local_newvalue.html: Added.
• web-platform-tests/webstorage/event_local_oldvalue-expected.txt: Added.
• web-platform-tests/webstorage/event_local_oldvalue.html: Added.
• web-platform-tests/webstorage/event_local_removeitem-expected.txt: Added.
• web-platform-tests/webstorage/event_local_removeitem.html: Added.
• web-platform-tests/webstorage/event_local_storagearea-expected.txt: Added.
• web-platform-tests/webstorage/event_local_storagearea.html: Added.
• web-platform-tests/webstorage/event_local_url-expected.txt: Added.
• web-platform-tests/webstorage/event_local_url.html: Added.
• web-platform-tests/webstorage/event_no_duplicates-expected.txt: Added.
• web-platform-tests/webstorage/event_no_duplicates.html: Added.
• web-platform-tests/webstorage/event_session_key-expected.txt: Added.
• web-platform-tests/webstorage/event_session_key.html: Added.
• web-platform-tests/webstorage/event_session_newvalue-expected.txt: Added.
• web-platform-tests/webstorage/event_session_newvalue.html: Added.
• web-platform-tests/webstorage/event_session_oldvalue-expected.txt: Added.
• web-platform-tests/webstorage/event_session_oldvalue.html: Added.
• web-platform-tests/webstorage/event_session_removeitem-expected.txt: Added.
• web-platform-tests/webstorage/event_session_removeitem.html: Added.
• web-platform-tests/webstorage/event_session_storagearea-expected.txt: Added.
• web-platform-tests/webstorage/event_session_storagearea.html: Added.
• web-platform-tests/webstorage/event_session_url-expected.txt: Added.
• web-platform-tests/webstorage/event_session_url.html: Added.
• web-platform-tests/webstorage/event_setattribute-expected.txt: Added.
• web-platform-tests/webstorage/event_setattribute.html: Added.
• web-platform-tests/webstorage/event_setattribute.js: Added.

(testStorages.):
(testStorages):

• web-platform-tests/webstorage/missing_arguments.window-expected.txt: Added.
• web-platform-tests/webstorage/missing_arguments.window.html: Added.
• web-platform-tests/webstorage/missing_arguments.window.js: Added.

(tests):
(tests.forEach):

• web-platform-tests/webstorage/resources/event_body_handler.html: Added.
• web-platform-tests/webstorage/resources/event_setattribute_handler.html: Added.
• web-platform-tests/webstorage/resources/local_change_item_iframe.html: Added.
• web-platform-tests/webstorage/resources/local_set_item_clear_iframe.html: Added.
• web-platform-tests/webstorage/resources/local_set_item_iframe.html: Added.
• web-platform-tests/webstorage/resources/local_set_item_remove_iframe.html: Added.
• web-platform-tests/webstorage/resources/session_change_item_iframe.html: Added.
• web-platform-tests/webstorage/resources/session_set_item_clear_iframe.html: Added.
• web-platform-tests/webstorage/resources/session_set_item_iframe.html: Added.
• web-platform-tests/webstorage/resources/session_set_item_remove_iframe.html: Added.
• web-platform-tests/webstorage/resources/storage_local_window_open_second.html: Added.
• web-platform-tests/webstorage/resources/storage_session_window_noopener_second.html: Added.
• web-platform-tests/webstorage/resources/storage_session_window_open_second.html: Added.
• web-platform-tests/webstorage/resources/w3c-import.log: Added.
• web-platform-tests/webstorage/set.window-expected.txt: Added.
• web-platform-tests/webstorage/set.window.html: Added.
• web-platform-tests/webstorage/set.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_builtins.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_builtins.window.html: Added.
• web-platform-tests/webstorage/storage_builtins.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_clear.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_clear.window.html: Added.
• web-platform-tests/webstorage/storage_clear.window.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_enumerate.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_enumerate.window.html: Added.
• web-platform-tests/webstorage/storage_enumerate.window.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_functions_not_overwritten.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_functions_not_overwritten.window.html: Added.
• web-platform-tests/webstorage/storage_functions_not_overwritten.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_getitem.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_getitem.window.html: Added.
• web-platform-tests/webstorage/storage_getitem.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_in.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_in.window.html: Added.
• web-platform-tests/webstorage/storage_in.window.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_indexing.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_indexing.window.html: Added.
• web-platform-tests/webstorage/storage_indexing.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_key.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_key.window.html: Added.
• web-platform-tests/webstorage/storage_key.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_key_empty_string.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_key_empty_string.window.html: Added.
• web-platform-tests/webstorage/storage_key_empty_string.window.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_length.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_length.window.html: Added.
• web-platform-tests/webstorage/storage_length.window.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_local_setitem_quotaexceedederr.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_local_setitem_quotaexceedederr.window.html: Added.
• web-platform-tests/webstorage/storage_local_setitem_quotaexceedederr.window.js: Added.

(test):

• web-platform-tests/webstorage/storage_local_window_open.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_local_window_open.window.html: Added.
• web-platform-tests/webstorage/storage_local_window_open.window.js: Added.

(async_test):

• web-platform-tests/webstorage/storage_removeitem.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_removeitem.window.html: Added.
• web-platform-tests/webstorage/storage_removeitem.window.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_session_setitem_quotaexceedederr.window.html: Added.
• web-platform-tests/webstorage/storage_session_setitem_quotaexceedederr.window.js: Added.

(test):

• web-platform-tests/webstorage/storage_session_window_noopener.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_session_window_noopener.window.html: Added.
• web-platform-tests/webstorage/storage_session_window_noopener.window.js: Added.

(async_test):

• web-platform-tests/webstorage/storage_session_window_open.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_session_window_open.window.html: Added.
• web-platform-tests/webstorage/storage_session_window_open.window.js: Added.

(async_test):

• web-platform-tests/webstorage/storage_set_value_enumerate.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_set_value_enumerate.window.html: Added.
• web-platform-tests/webstorage/storage_set_value_enumerate.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_setitem.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_setitem.window.html: Added.
• web-platform-tests/webstorage/storage_setitem.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_string_conversion.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_string_conversion.window.html: Added.
• web-platform-tests/webstorage/storage_string_conversion.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/storage_supported_property_names.window-expected.txt: Added.
• web-platform-tests/webstorage/storage_supported_property_names.window.html: Added.
• web-platform-tests/webstorage/storage_supported_property_names.window.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/webstorage/symbol-props.window-expected.txt: Added.
• web-platform-tests/webstorage/symbol-props.window.html: Added.
• web-platform-tests/webstorage/symbol-props.window.js: Added.

(string_appeared_here.forEach.):
(string_appeared_here.forEach):

• web-platform-tests/webstorage/w3c-import.log: Added.

LayoutTests:

Import tip-of-tree webstorage WPTs with:
Tools/Scripts/import-w3c-tests -t web-platform-tests/webstorage

• TestExpectations:

Skip 2 newly imported tests that consistently crash / timeout.

• tests-options.json:

Mark 4 newly imported tests as slow.

10:41 PM Changeset in webkit [277003] by Peng Liu

• 7 edits in trunk/Source

[GPUP] Implement SourceBufferPrivateRemote::bufferFull()
​https://bugs.webkit.org/show_bug.cgi?id=224139

Reviewed by Jer Noble.

Source/WebCore:

• platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setBufferFull): This function will be used
by SourceBufferPrivateRemote::evictCodedFrames() and SourceBufferPrivateRemote::reenqueueMediaIfNeeded().

Source/WebKit:

Modify two IPC messages to implement SourceBufferPrivateRemote::bufferFull().

• GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::evictCodedFrames):
(WebKit::RemoteSourceBufferProxy::reenqueueMediaIfNeeded):

• GPUProcess/media/RemoteSourceBufferProxy.h:
• GPUProcess/media/RemoteSourceBufferProxy.messages.in:

• WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::evictCodedFrames):
(WebKit::SourceBufferPrivateRemote::reenqueueMediaIfNeeded):

10:38 PM Changeset in webkit [277002] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Mark imported/w3c/web-platform-tests/worklets/paint-worklet-csp.https.html as flaky crash.

Also clean latest tests passing and mark 'open-features-tokenization-screenx-screeny.html' as flaky timeout.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

9:38 PM Changeset in webkit [277001] by Antti Koivisto

• 10 edits
  2 adds in trunk

REGRESSION(iOS 14): Author shadow DOM invalidated unnecessarily on pseudo element change
​https://bugs.webkit.org/show_bug.cgi?id=222187
<rdar://problem/74801314>

Reviewed by Ryosuke Niwa.
Source/WebCore:

Hovering the element causes us to invalidate the entire author shadow tree style.

The invalidation is triggered by the user agent stylesheet having some :hover rules targeting pseudo
elements. This should not require invalidation except for those specific elements and only for
UA shadow trees.

This patch optimizes the case and avoids unnecessary invalidations.

Test: fast/shadow-dom/shadow-style-invalidation-pseudo-element.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::handleFocusEvent):
(WebCore::HTMLInputElement::handleBlurEvent):
(WebCore::HTMLInputElement::invalidateStyleOnFocusChangeIfNeeded):

Input elements with 'text-overflow:ellipsis' (which is affected by focus) were relying
on spurious invalidations that we now optimize away. Invalidate properly.

• html/HTMLInputElement.h:
• style/ElementRuleCollector.cpp:

(WebCore::Style::ElementRuleCollector::collectMatchingShadowPseudoElementRules):

• style/RuleSet.cpp:

(WebCore::Style::RuleSet::evaluateDynamicMediaQueryRules):
(WebCore::Style::RuleSet::hasShadowPseudoElementRules const): Deleted.

Handle ::cue separately.

• style/RuleSet.h:

(WebCore::Style::RuleSet::cuePseudoRules const):
(WebCore::Style::RuleSet::hasShadowPseudoElementRules const):

• style/StyleInvalidationFunctions.h:

(WebCore::Style::traverseRuleFeatures):

• style/StyleInvalidator.cpp:

(WebCore::Style::Invalidator::collectRuleInformation):
(WebCore::Style::Invalidator::invalidateShadowPseudoElements):

Narrowly invalidate user agent shadow tree pseudo elements.

(WebCore::Style::Invalidator::invalidateInShadowTreeIfNeeded):

• style/StyleInvalidator.h:

LayoutTests:

• fast/shadow-dom/shadow-style-invalidation-pseudo-element-expected.txt: Added.
• fast/shadow-dom/shadow-style-invalidation-pseudo-element.html: Added.

7:45 PM Changeset in webkit [277000] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening. Gardened several WebXR tests that are crashing in Debug.

• platform/wpe/TestExpectations:

6:23 PM Changeset in webkit [276999] by commit-queue@webkit.org

• 5 edits in trunk

WebKit must treat 'webgl' and 'webgl2' as distinct context types
​https://bugs.webkit.org/show_bug.cgi?id=222758

Patch by Kenneth Russell <​kbr@chromium.org> on 2021-05-04
Reviewed by Dean Jackson.

Source/WebCore:

Update both the regular getContext and CSS context code paths with
checks distinguishing WebGL 1.0 and 2.0 contexts.

Covered by existing WebGL 2.0 conformance tests.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::getContextWebGL):

LayoutTests:

Revised the two copies of the WebGL 2.0 context-type-test with
strengthened checks taken from upstream KhronosGroup/WebGL.

• webgl/2.0.0/resources/webgl_test_files/conformance2/context/context-type-test-2.html:
• webgl/resources/webgl_test_files/conformance2/context/context-type-test-2.html:

5:42 PM Changeset in webkit [276998] by jiewen_tan@apple.com

• 4 edits in trunk

PCM: Find a way to validate source_secret_token and source_secret_token_signature
​https://bugs.webkit.org/show_bug.cgi?id=224321
<rdar://problem/76695542>

Reviewed by John Wilander.

Source/WebKit:

Covered by exisiting tests.

• NetworkProcess/PrivateClickMeasurementManager.cpp:

(WebKit::PrivateClickMeasurementManager::getTokenPublicKey):
(WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken):
Reverts r236878.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:

(TestWebKitAPI::TEST):
Uses RSA-PSS with SHA-384 to verify the signature.

5:00 PM Changeset in webkit [276997] by Jonathan Bedard

• 4 edits in trunk/Tools

[webkitscmpy] Scope classes used in TaskPool to object
​https://bugs.webkit.org/show_bug.cgi?id=225361
<rdar://problem/77514131>

Reviewed by Dewei Zhu.

The classes used by TaskPool must be stand-alone because they are passed between processes.
However, it makes sense that those classes are scoped to the TaskPool object since their
usage should always be associated with the TaskPool object

• Scripts/libraries/webkitcorepy/setup.py:
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py:
• Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:

(_Message): Renamed from Message.
(_Task): Renamed from Task.
(_Result): Renamed from Result.
(_Log): Renamed from Log.
(_Print): Renamed from Print.
(_State): Renamed from State.
(_ChildException): Renamed from ChildException.
(_BiDirectionalQueue): Renamed from BiDirectionalQueue.
(_Process): Renamed from Process.
(TaskPool):
(TaskPool.do):
(Message): Renamed to _Message..
(Task): Renamed to _Task.
(Result): Renamed to _Result.
(Log): Renamed to _Log.
(Print): Renamed to _Print.
(State): Renamed to _State.
(ChildException): Renamed to _ChildException.
(BiDirectionalQueue): Renamed to _BiDirectionalQueue.
(Process): Renamed to _Process.

4:58 PM Changeset in webkit [276996] by Russell Epstein

• 1 copy in tags/Safari-612.1.11.9

Tag Safari-612.1.11.9.

4:58 PM Changeset in webkit [276995] by Russell Epstein

• 1 delete in tags/Safari-612.1.11.9

Delete tag.

4:51 PM Changeset in webkit [276994] by Russell Epstein

• 8 edits in branches/safari-612.1.11-branch/Source

Versioning.

WebKit-7612.1.11.9

4:50 PM Changeset in webkit [276993] by jer.noble@apple.com

• 14 edits
  1 copy
  3 adds in trunk/Source

[Media in GPU Process] Move AudioSessionRoutingArbitratorProxy to the GPU process
​https://bugs.webkit.org/show_bug.cgi?id=217535
<rdar://problem/70152548>

Reviewed by Eric Carlson.

Source/WebCore:

Add a new shared object, SharedRoutingArbitrator, to be used both in the UIProcess (when media
in the GPU process is not enabled) and the GPUProcess (when it is).

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/audio/AudioSession.h:
• platform/audio/mac/SharedRoutingArbitrator.h: Added.
• platform/audio/mac/SharedRoutingArbitrator.mm: Added.

(WebCore::SharedRoutingArbitrator::Token::create):
(WebCore::SharedRoutingArbitrator::sharedInstance):
(WebCore::SharedRoutingArbitrator::isInRoutingArbitrationForToken):
(WebCore::SharedRoutingArbitrator::beginRoutingArbitrationForToken):
(WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken):

Source/WebKit:

Add a new, local-only object which can aggregate changes to the audio routing.
The UIProcess version of this object spans a process boundary, but this new
object can operate locally without an XPC communication channel. As part of this
change, the "SharedArbitrator" in AudioSessionRoutingArbitratorProxyCocoa has been
moved into WebCore to be used both there and in this new object.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::didClose):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp: Added.

(WebKit::LocalAudioSessionRoutingArbitrator::create):
(WebKit::LocalAudioSessionRoutingArbitrator::LocalAudioSessionRoutingArbitrator):
(WebKit::LocalAudioSessionRoutingArbitrator::~LocalAudioSessionRoutingArbitrator):
(WebKit::LocalAudioSessionRoutingArbitrator::processDidTerminate):
(WebKit::LocalAudioSessionRoutingArbitrator::beginRoutingArbitrationWithCategory):
(WebKit::LocalAudioSessionRoutingArbitrator::leaveRoutingAbritration):

• GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h:
• SourcesCocoa.txt:
• UIProcess/Media/AudioSessionRoutingArbitratorProxy.h:
• UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:

(WebKit::AudioSessionRoutingArbitratorProxy::AudioSessionRoutingArbitratorProxy):
(WebKit::AudioSessionRoutingArbitratorProxy::processDidTerminate):
(WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):
(WebKit::AudioSessionRoutingArbitratorProxy::endRoutingArbitration):
(): Deleted.
(WebKit::SharedArbitrator::sharedInstance): Deleted.
(WebKit::SharedArbitrator::isInRoutingArbitrationForArbitrator): Deleted.
(WebKit::SharedArbitrator::beginRoutingArbitrationForArbitrator): Deleted.
(WebKit::SharedArbitrator::endRoutingArbitrationForArbitrator): Deleted.

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/media/RemoteAudioSession.cpp:

(WebKit::RemoteAudioSession::setCategory):

4:35 PM Changeset in webkit [276992] by Russell Epstein

• 16 edits
  1 copy in branches/safari-612.1.12-branch/Source

Cherry-pick r276947. rdar://problem/77510833

Allow AppHighlight visibility to be toggled
​https://bugs.webkit.org/show_bug.cgi?id=225276

Reviewed by Wenson Hsieh.

Source/WebCore:

Add supporting infrastructure to allow highlights to be turned on and off.
This is done with a simple state and a forced repaint on the areas that have highlights.

• Modules/highlight/Highlight.cpp: (WebCore::Highlight::forceRepaint):
• Modules/highlight/Highlight.h:
• Modules/highlight/HighlightRegister.cpp: (WebCore::HighlightRegister::setActive):
• Modules/highlight/HighlightRegister.h: (WebCore::HighlightRegister::isActive):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::collectMarkedTextsForHighlights const):
• rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calculateHighlightColor const):

Source/WebKit:

Add supporting infrastructure to allow highlights to be turned on and off.

• Scripts/webkit/messages.py: (headers_for_type):
• UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex): (WebKit::WebPageProxy::setAppHighlightsActive):
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView canPerformAction:withSender:]): (-[WKContentView targetForAction:withSender:]):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setAppHighlightsActive):
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@276947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:35 PM Changeset in webkit [276991] by Russell Epstein

• 16 edits
  2 adds in branches/safari-612.1.12-branch

Cherry-pick r276871. rdar://problem/77530347

App highlight UI should be disabled when selecting text in image overlays
​https://bugs.webkit.org/show_bug.cgi?id=225260
rdar://77359313

Reviewed by Tim Horton.

Source/WebCore:

When both app highlights and image extraction are enabled, parts of the app highlights feature don't play well
with highlights created for text selections inside an image overlay. For the time being, address this by
disabling app highlights in image overlays.

These changes are exercised by a new API test on iOS, and a new layout test for macOS.

Tests: WebKit.AppHighlightsInImageOverlays

fast/images/image-extraction/mac/image-overlay-text-disables-app-highlight-menu-items.html

• page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

Don't add app highlight menu items in the case where we've selected text in an image overlay.

• testing/Internals.cpp: (WebCore::Internals::appHighlightContextMenuItemTitles const):

Add an internal testing hook to expose the localized names of the app highlight menu items to layout tests.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Add a bit to EditorState to indicate when a ranged selection is inside an image overlay.

• Shared/EditorState.cpp: (WebKit::EditorState::encode const): (WebKit::EditorState::decode):
• Shared/EditorState.h:
• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView shouldAllowAppHighlightCreation]): (-[WKContentView canPerformAction:withSender:]): (-[WKContentView targetForAction:withSender:]):

Make -targetForAction:withSender: return self only if we have a ranged selection that is not inside an image
overlay. Interestingly, UIKit doesn't seem to consult -canPerformAction:withSender: for actions that are added
through -[UIMenuController setMenuItems:], so we add the check here instead of inside -canPerformAction:
above.

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::editorState const):

Set the new bit here. Note that this (importantly) doesn't trigger layout, because VisibleSelection::range
just returns a (potentially uncanonicalized) SimpleRange. For the purposes of checking whether the selection
is inside an image overlay, this is sufficient.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:

Add a new API test to verify the behavior of -targetForAction:withSender: in WKContentView.

• WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping):
• WebKitTestRunner/TestOptions.h: (WTR::TestOptions::appHighlightsEnabled const):
• WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView):

Add support for a new TestOption that enables app highlights. See the new layout test for more information.

LayoutTests:

Add a new layout test to verify that the app higlight context menu items don't show up on macOS when right
clicking.

• fast/images/image-extraction/mac/image-overlay-text-disables-app-highlight-menu-items-expected.txt: Added.
• fast/images/image-extraction/mac/image-overlay-text-disables-app-highlight-menu-items.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@276871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:35 PM Changeset in webkit [276990] by Russell Epstein

• 16 edits
  1 delete in branches/safari-612.1.12-branch/Source

Revert "Cherry-pick r276947. rdar://problem/77510833"

This reverts commit r276976.

4:35 PM Changeset in webkit [276989] by Truitt Savell

• 2 edits in trunk/LayoutTests

[Big Sur] platform/mac-bigsur/media/media-source/media-source-webm-vorbis-partial.html is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=222495

Unreviewed test fix.

• media/media-source/media-source-webm-vorbis-partial.html: Fix relative file path.

4:21 PM Changeset in webkit [276988] by Jean-Yves Avenard

• 3 edits in trunk/LayoutTests

webrtc/video-vp8-videorange.html is faling on macmini8,1
​https://bugs.webkit.org/show_bug.cgi?id=225345
rdar://77403100

Reviewed by Eric Carlson.

On some hardware, compositing may render slightly differently.
We add a small fuzz factor when comparing the YUV component values.
Such difference in results would be visually indistinguishible.

• platform/mac/TestExpectations: Remove test entry.
• webrtc/video-vp8-videorange.html:

4:20 PM Changeset in webkit [276987] by Kate Cheney

• 2 edits in trunk/Source/WebKit

Remove internal NetworkSessionCocoa additions
​https://bugs.webkit.org/show_bug.cgi?id=225365
<rdar://problem/75693914>

Reviewed by Per Arne Vollan.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):

3:37 PM Changeset in webkit [276986] by Chris Dumez

• 6 edits
  2 adds in trunk

Blob contentType with charset renders html as plain text
​https://bugs.webkit.org/show_bug.cgi?id=225226

Reviewed by Alex Christensen.

Source/WebCore:

Our code would use the Blob's Content-Type (media type) as a MIME type internally. As a result, if the Blob's
media type would contain anything besides the MIME type (e.g. a charget), then it would lead to failures.

Test: fast/files/blob-with-charget-as-main-resource.html

• platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponseOnSuccess):

• platform/network/HTTPParsers.h:

Source/WebKit:

Our code would use the Blob's Content-Type (media type) as a MIME type internally. As a result, if the Blob's
media type would contain anything besides the MIME type (e.g. a charget), then it would lead to failures.

• NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):

LayoutTests:

Add layout test coverage.

• fast/files/blob-with-charget-as-main-resource-expected.html: Added.
• fast/files/blob-with-charget-as-main-resource.html: Added.

3:29 PM Changeset in webkit [276985] by Chris Dumez

• 2 edits in trunk/Tools

Unreviewed, try and re-enable AppleLanguagesTest.UpdateAppleLanguages on Apple Silicon.

The test has been updated and it may be passing now or at least fail with a more useful output.

• TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:

2:40 PM Changeset in webkit [276984] by Cameron McCormack

• 3 edits
  3 adds in trunk

Handle clamping of heights for images affected by background-size and EXIF orientation correctly
​https://bugs.webkit.org/show_bug.cgi?id=221005
<rdar://problem/73692426>

Reviewed by Simon Fraser.

Source/WebCore:

GraphicsContext::drawPlatformImage handles requests with source rects
whose heights are greater than the image (which can happen due to
rounding issues) by clamping the source rect. This clamping incorrectly
looks at the CGImage's height, which for an image rotated 90deg due to
EXIF orientation metadata, is the wrong dimension.

Test: fast/images/image-orientation-background-size-bug.html

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawPlatformImage):

LayoutTests:

• fast/images/image-orientation-background-size-bug-expected.html: Added.
• fast/images/image-orientation-background-size-bug.html: Added.
• fast/images/resources/green-504x378-90deg.jpg: Added. This is a

solid green 504x378 JPEG with an EXIF orientation tag requiring a
90deg rotation.

2:32 PM Changeset in webkit [276983] by achristensen@apple.com

• 4 edits in trunk

localStorage changes aren't reflected between WKWebViews using WKWebViewConfiguration._groupIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=225344
<rdar://77496721>

Reviewed by Brady Eidson.

Source/WebKit:

When we switched from using _pageGroup to _groupIdentifier, we also broke localStorage by making a new pageGroupID for each WKWebView.
This is the low-risk solution to this problem that remembers what pageGroupID we used for this same identifier, creating the effect of
using the same StorageNamespaceIdentifier for each _groupIdentifier like we did when we used _pageGroup.
See the comment in StorageAreaMap::dispatchLocalStorageEvent.

The higher-risk solution that needs to be done but probably shouldn't be merged to a branch at this point is to remove StorageNamespaceIdentifier.
I plan to do that in a follow-up patch.

• UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:

(TEST):

2:13 PM WebKitGTK/2.32.x edited by Adrian Perez de Castro

(diff)

1:48 PM Changeset in webkit [276982] by commit-queue@webkit.org

• 13 edits in trunk/Source/WebKitLegacy

Remove unused references to PageGroup from WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=225359

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-05-04
Reviewed by Sihui Liu.

Source/WebKitLegacy:

• Storage/StorageTracker.cpp:

Source/WebKitLegacy/mac:

• History/WebHistory.mm:
• History/WebHistoryInternal.h:
• Storage/WebStorageManager.mm:
• WebView/WebView.mm:

Source/WebKitLegacy/win:

• WebCoreSupport/WebPlatformStrategies.cpp:
• WebHistory.cpp:
• WebHistory.h:
• WebKitDLL.cpp:
• WebView.cpp:

1:44 PM Changeset in webkit [276981] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[Cocoa] Cache the value of MediaPlayerPrivateAVFoundationObjC::assetStatus()
​https://bugs.webkit.org/show_bug.cgi?id=225262

Reviewed by Eric Carlson.

Calling into assetStatus() requires querying the load state and value of nine different
AVAsset properties, which adds up if assetStatus() is called often. Once the assetStatus()
value reaches the Loaded state, cache that property, and that of the AVAsset.playable
property, so subsequent queries are just an ivar lookup.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus const):

1:32 PM Changeset in webkit [276980] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.32/Source/WebKit

Merge r276954 - [GTK] segmentation fault in WebKit::IconDatabase::loadIconForPageURL
​https://bugs.webkit.org/show_bug.cgi?id=225279

Patch by Jim Mason <​jmason@ibinx.com> on 2021-05-04
Reviewed by Carlos Garcia Campos.

• UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::loadIconForPageURL):
(WebKit::IconDatabase::setIconForPageURL):

1:27 PM Changeset in webkit [276979] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

[Cocoa] Allow HTMLMediaElement preload > "metadata" on iPad by default
​https://bugs.webkit.org/show_bug.cgi?id=223802

Reviewed by Eric Carlson.

Align default iPad WebKit behavior for media element preload with Mac WebKit behavior.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

12:29 PM Changeset in webkit [276978] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

REGRESSION (r276883): [Debug] ASSERTION FAILED: index != notFound in WebCore::PlatformMediaSessionManager::setCurrentSession()
​https://bugs.webkit.org/show_bug.cgi?id=225332
<rdar://problem/77476145>

Reviewed by Eric Carlson.

PlatformMediaSessionManager will throw an assert if the session being set as "current" via
sessionWillBeginPlayback() isn't active; we activate the session immediately after this line
inside lazyInitialize(), but this looks to be too late. A similar problem may occur in
HTMLMediaElement::playInternal(), so activate the session there too.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::willBeginPlayback):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playInternal):

12:25 PM Changeset in webkit [276977] by Adrian Perez de Castro

• 3 edits in releases/WebKitGTK/webkit-2.32/Source/WebCore

Merge r276915 - [GTK] Build with VIDEO=OFF fails
​https://bugs.webkit.org/show_bug.cgi?id=225316

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-03
Reviewed by Adrian Perez de Castro.

• platform/audio/PlatformMediaSession.cpp:

(WebCore::isPlayingAudio): Guard against invalid media types, when video is disabled we can
safely return false here as well.

• platform/graphics/opengl/GraphicsContextGLOpenGL.h: Include what we use (UniqueRef).

12:25 PM WebKitGTK/2.32.x edited by Adrian Perez de Castro

(diff)

12:11 PM Changeset in webkit [276976] by Russell Epstein

• 16 edits
  1 copy in branches/safari-612.1.12-branch/Source

Cherry-pick r276947. rdar://problem/77510833

Allow AppHighlight visibility to be toggled
​https://bugs.webkit.org/show_bug.cgi?id=225276

Reviewed by Wenson Hsieh.

Source/WebCore:

Add supporting infrastructure to allow highlights to be turned on and off.
This is done with a simple state and a forced repaint on the areas that have highlights.

• Modules/highlight/Highlight.cpp: (WebCore::Highlight::forceRepaint):
• Modules/highlight/Highlight.h:
• Modules/highlight/HighlightRegister.cpp: (WebCore::HighlightRegister::setActive):
• Modules/highlight/HighlightRegister.h: (WebCore::HighlightRegister::isActive):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::collectMarkedTextsForHighlights const):
• rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calculateHighlightColor const):

Source/WebKit:

Add supporting infrastructure to allow highlights to be turned on and off.

• Scripts/webkit/messages.py: (headers_for_type):
• UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex): (WebKit::WebPageProxy::setAppHighlightsActive):
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView canPerformAction:withSender:]): (-[WKContentView targetForAction:withSender:]):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setAppHighlightsActive):
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@276947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:03 PM Changeset in webkit [276975] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: add assertion for WI.View re-entrancy
​https://bugs.webkit.org/show_bug.cgi?id=224678

Reviewed by Joseph Pecoraro.

Add console.assert (which are removed from production builds) around each critical
WI.View subclass member function to prevent reentrancy.

• initialLayout
• sizeDidChange
• layout
• didLayoutSubtree

This is important because WI.View.prototype._layoutSubtree sets any related state after
calling any of the above (e.g. _didInitialLayout after initialLayout), meaning that any
checks for the related state (which sometimes control whether the function is called, such
as in the case of initialLayout) would think that the function hadn't been called yet. See
r276170 for an example of how this can happen and the potential problems it can cause.

• UserInterface/Views/View.js:

(WI.View.prototype._layoutSubtree):

• UserInterface/Base/Utilities.js:

(WI.setReentrantCheck): Added.
(WI.clearReentrantCheck): Added.

11:51 AM Changeset in webkit [276974] by commit-queue@webkit.org

• 6 edits in trunk/Source

Don't iterate NetworkProcessProxy::m_websiteDataStores
​https://bugs.webkit.org/show_bug.cgi?id=225337
<rdar://77233103>

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-05-04
Reviewed by Geoffrey Garen.

Source/WebKit:

There is evidence that this collection is mutated while iterating, and there are a lot of ways that might happen.
Instead, keep a Vector<Ref<WebsiteDataStore>>.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::networkProcessDidTerminate):

• UIProcess/Network/NetworkProcessProxyCocoa.mm:

(WebKit::NetworkProcessProxy::XPCEventHandler::handleXPCEvent const):

Source/WTF:

• wtf/Vector.h:

(WTF::copyToVectorOf):
Use a universal reference instead of const&.

• wtf/WeakHashSet.h:

WeakHashSet iteration returns T&, and we need this instead of WeakPtr<T> to be able to return a Ref from a map function.

11:43 AM Changeset in webkit [276973] by eric.carlson@apple.com

• 8 edits in trunk/Source/WebKit

[GPUP] Use MonotonicTime for elapsed time
​https://bugs.webkit.org/show_bug.cgi?id=225329
<rdar://problem/77472811>

Reviewed by Simon Fraser.

No new tests, no change of behavior.

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerPlaybackStateChanged):
(WebKit::RemoteMediaPlayerProxy::updateCachedState):
(WebKit::RemoteMediaPlayerProxy::performTaskAtMediaTime):
(WebKit::RemoteMediaPlayerProxy::setVideoPlaybackMetricsUpdateInterval):
(WebKit::RemoteMediaPlayerProxy::maybeUpdateCachedVideoMetrics):
(WebKit::RemoteMediaPlayerProxy::updateCachedVideoMetrics):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::pause):
(WebKit::MediaPlayerPrivateRemote::currentMediaTime const):
(WebKit::MediaPlayerPrivateRemote::playbackStateChanged):
(WebKit::MediaPlayerPrivateRemote::updateCachedState):
(WebKit::MediaPlayerPrivateRemote::videoPlaybackQualityMetrics):
(WebKit::MediaPlayerPrivateRemote::performTaskAtMediaTime):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
• WebProcess/GPU/media/RemoteMediaPlayerState.h:

(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):

11:34 AM Changeset in webkit [276972] by jiewen_tan@apple.com

• 4 edits in trunk/Source/WebKit

REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing
​https://bugs.webkit.org/show_bug.cgi?id=225225
rdar://77074618

Reviewed by Brent Fulgham.

Covered by exisiting tests.

• UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::runPresenter):
(WebKit::AuthenticatorManager::runPresenterInternal):

• UIProcess/WebAuthentication/AuthenticatorManager.h:
• UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.h:

Disables the modern UI in the mock testing environment.

11:19 AM Changeset in webkit [276971] by svillar@igalia.com

• 5 edits in trunk

ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
​https://bugs.webkit.org/show_bug.cgi?id=222711
<rdar://problem/75022692>

Reviewed by Alan Bujtas.

Source/WebCore:

Flexbox code was computing negative content sizes for FrameSet children because RenderFrameSet lacked
a implementation of computePreferredLogicalWidths(). Added basic preferred width computation
to RenderBox so that FrameSet and any other potential new RenderBox child could benefit from it.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computePreferredLogicalWidths): Added a basic implementation that calls
computePreferredLogicalWidths(minWidth,maxWidth,borderAndPadding) and clears the flag.

• rendering/RenderBox.h:

(WebCore::RenderBox::computePreferredLogicalWidths): Deleted default implementation.

LayoutTests:

• TestExpectations: Unskipped a test that is passing now.

11:14 AM Changeset in webkit [276970] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews] Ensure file handles are not leaked in unit tests
​https://bugs.webkit.org/show_bug.cgi?id=225360

Reviewed by Jonathan Bedard.

• CISupport/ews-build/email_unittest.py:

(EmailsDotJSONTest.test_valid_emails_json):
(EmailsDotJSONTest.test_emails_json_required_categories_present):

• CISupport/ews-build/loadConfig_unittest.py:

(ConfigDotJSONTest.get_config):

11:04 AM Changeset in webkit [276969] by Chris Dumez

• 4 edits in trunk/Source/WebKit

[iOS] Use async API to take RunningBoard assertions
​https://bugs.webkit.org/show_bug.cgi?id=225324
<rdar://76972252>

Reviewed by Geoffrey Garen.

Use async [RBSAssertion acquireWithInvalidationHandler:] API to take process assertions
instead of the synchronous [RBSAssertion acquireWithError:] API. This avoids risking
hanging the main thread for too long.

Note that [RBSAssertion isValid] returns false until the assertion is taken so I am
using our own "isValid" boolean to indicate if the RBSAssertion was invalidated or
or not. We use this flag to decide if we need to take the assertion again. We wouldn't
want to re-take the assertion simply because it is still in the process of being
acquired.

• UIProcess/ProcessAssertion.cpp:

(WebKit::ProcessAssertion::isValid const): Deleted.

• UIProcess/ProcessAssertion.h:

(WebKit::ProcessAssertion::isValid const):

• UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager assertion:didInvalidateWithError:]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):
(WebKit::ProcessAssertion::processAssertionWasInvalidated):
(-[WKProcessAssertionBackgroundTaskManager _hasBackgroundTask]): Deleted.
(-[WKRBSAssertionDelegate dealloc]): Deleted.
(-[WKRBSAssertionDelegate assertionWillInvalidate:]): Deleted.
(-[WKRBSAssertionDelegate assertion:didInvalidateWithError:]): Deleted.
(WebKit::ProcessAssertion::isValid const): Deleted.

10:41 AM Changeset in webkit [276968] by Russell Epstein

• 8 edits in branches/safari-612.1.12-branch/Source

Versioning.

WebKit-7612.1.12.3

10:33 AM Changeset in webkit [276967] by Kate Cheney

• 2 edits in trunk/Tools

Unreviewed, adding myself as a reviewer.

• Scripts/webkitpy/common/config/contributors.json:

10:14 AM Changeset in webkit [276966] by graouts@webkit.org

• 6 edits
  2 adds in trunk

REGRESSION (r260360): animation-wide timing function does not apply to 2-keyframe transform Web Animation
​https://bugs.webkit.org/show_bug.cgi?id=225301
<rdar://problem/77452933>

Reviewed by Dean Jackson.

Source/WebCore:

Core Animation has a limitation where an animation-wide cubic timing function with y values outside of the [0-1]
range are not applied correctly since those values are clipped. This is not the case with similar timing functions
applied to a keyframe interval. This is known issue covered by bug 215918.

We worked around this limitation for CSS Transitions in bug 215826. Indeed, in this case we know that the animation
has a single interval and no keyframe-specific timing function, so GraphicsLayerCA would check whether the Animation
object originated from a CSS Transition and set the animation-wide timing function on the generated AnimationValue.

With this patch we generalize this approach to any animation, no matter its origin, that has a single keyframe
interval with no timing function or a timing function that has a linear effect. To do this, we first check in
GraphicsLayerCA::addAnimation*() whether we are dealing with an animation that has an animation-wide cubic timing
function outside of the [0-1] range. If that is not the case, we return early and indicate that this animation
cannot be run accelerated.

If instead that is the case, we pass a new boolean flag down through the call stack to setupAnimation() and
timingFunctionForAnimationValue() where we choose to use the animation-wide timing function on the first keyframe
rather than the animation itself.

Test: webanimations/accelerated-web-animation-with-single-interval-and-easing-y-axis-above-1.html

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::timingFunctionIsCubicTimingFunctionWithYValueOutOfRange):
(WebCore::keyframeValueListHasSingleIntervalWithLinearOrEquivalentTimingFunction):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createKeyframeAnimation):
(WebCore::GraphicsLayerCA::createSpringAnimation):
(WebCore::GraphicsLayerCA::setupAnimation):
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerCA::setAnimationKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):

• platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests:

Add a test that runs a JS-orignated animation with a single interval and an animation-wide cubic timing
function with y values outside of the [0-1] range.

• platform/win/TestExpectations:
• webanimations/accelerated-web-animation-with-single-interval-and-easing-y-axis-above-1-expected.html: Added.
• webanimations/accelerated-web-animation-with-single-interval-and-easing-y-axis-above-1.html: Added.

10:14 AM Changeset in webkit [276965] by Chris Dumez

• 2 edits in trunk/Source/WTF

Drop std::filesystem logic in PlatformJSCOnly.cmake
​https://bugs.webkit.org/show_bug.cgi?id=225355

Reviewed by Alex Christensen.

Drop std::filesystem logic in PlatformJSCOnly.cmake as it is no longer needed after r276946.

• wtf/PlatformJSCOnly.cmake:

10:09 AM Changeset in webkit [276964] by Kyle Piddington

• 5 edits in trunk/LayoutTests

[Metal ANGLE] Update readpixel, sub, whole, and occlusionQuery tests to passing
​https://bugs.webkit.org/show_bug.cgi?id=225217

Tests are passing on bots, but checked in expected test results include failures.
Reviewed by Dean Jackson.

• webgl/2.0.0/deqp/functional/gles3/fboinvalidate/sub-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fboinvalidate/whole-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/occlusionquery_strict-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/readpixel-expected.txt:

10:03 AM Changeset in webkit [276963] by Ruben Turcios

• 16 edits
  1 copy in branches/safari-612.1.13-branch/Source

Cherry-pick r276947. rdar://problem/77511661

Allow AppHighlight visibility to be toggled
​https://bugs.webkit.org/show_bug.cgi?id=225276

Reviewed by Wenson Hsieh.

Source/WebCore:

Add supporting infrastructure to allow highlights to be turned on and off.
This is done with a simple state and a forced repaint on the areas that have highlights.

• Modules/highlight/Highlight.cpp: (WebCore::Highlight::forceRepaint):
• Modules/highlight/Highlight.h:
• Modules/highlight/HighlightRegister.cpp: (WebCore::HighlightRegister::setActive):
• Modules/highlight/HighlightRegister.h: (WebCore::HighlightRegister::isActive):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::collectMarkedTextsForHighlights const):
• rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calculateHighlightColor const):

Source/WebKit:

Add supporting infrastructure to allow highlights to be turned on and off.

• Scripts/webkit/messages.py: (headers_for_type):
• UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex): (WebKit::WebPageProxy::setAppHighlightsActive):
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView canPerformAction:withSender:]): (-[WKContentView targetForAction:withSender:]):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setAppHighlightsActive):
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@276947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:02 AM Changeset in webkit [276962] by dino@apple.com

• 5 edits
  2 copies in trunk/Source/WebCore

[WebXR] Move WebXROpaqueFramebuffer to its own file
​https://bugs.webkit.org/show_bug.cgi?id=225334

Reviewed by Sam Weinig.

Move WebXROpaqueFramebuffer out of WebXRWebGLLayer.

• Modules/webxr/WebXROpaqueFramebuffer.cpp: Copied from Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp.

(WebCore::WebXROpaqueFramebuffer::create):
(WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):

• Modules/webxr/WebXROpaqueFramebuffer.h: Copied from Source/WebCore/Modules/webxr/WebXRWebGLLayer.h.

(WebCore::WebXROpaqueFramebuffer::handle const):
(WebCore::WebXROpaqueFramebuffer::framebuffer const):
(WebCore::WebXROpaqueFramebuffer::width const):
(WebCore::WebXROpaqueFramebuffer::height const):

• Modules/webxr/WebXRWebGLLayer.cpp:

(WebCore::WebXROpaqueFramebuffer::create): Deleted.
(WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer): Deleted.
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer): Deleted.
(WebCore::WebXROpaqueFramebuffer::startFrame): Deleted.
(WebCore::WebXROpaqueFramebuffer::endFrame): Deleted.
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer): Deleted.

• Modules/webxr/WebXRWebGLLayer.h:

(WebCore::WebXROpaqueFramebuffer::handle const): Deleted.
(WebCore::WebXROpaqueFramebuffer::framebuffer const): Deleted.
(WebCore::WebXROpaqueFramebuffer::width const): Deleted.
(WebCore::WebXROpaqueFramebuffer::height const): Deleted.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

9:43 AM Changeset in webkit [276961] by Ruben Turcios

• 3 edits in branches/safari-612.1.13-branch/Source/WebCore

Cherry-pick r276893. rdar://problem/77510428

REGRESSION (r276633): fast/mediastream/media-stream-track-interrupted.html is consistently timing out
​https://bugs.webkit.org/show_bug.cgi?id=225204
<rdar://problem/77338070>

Reviewed by Eric Carlson.

Reverting to RecursiveLock since resuming a unit will make it notify to unmute sources.
Sources will want to restart audio, thus restarting the unit synchronously.
This triggers the unit to tell its clients that it is restarting, which creates a dead lock.
We should probably update the code to change this, but as a short term fix, we revert to a RecursiveLock.

Covered by fast/mediastream/media-stream-track-interrupted.html no longer timing out.

• platform/mediastream/mac/BaseAudioSharedUnit.cpp: (WebCore::BaseAudioSharedUnit::audioSamplesAvailable):
• platform/mediastream/mac/BaseAudioSharedUnit.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@276893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:37 AM Changeset in webkit [276960] by Ruben Turcios

• 1 copy in branches/safari-612.1.13-branch

New branch.

9:14 AM Changeset in webkit [276959] by dino@apple.com

• 2 edits in trunk/Source/WebCore

[WebXR] Remove renamed IDL files in Xcode project
​https://bugs.webkit.org/show_bug.cgi?id=225331

Reviewed by Sam Weinig.

The Xcode project had a bunch of references to files that were
renamed a while ago.

• WebCore.xcodeproj/project.pbxproj:

8:26 AM Changeset in webkit [276958] by Razvan Caliman

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: Inconsistent selection in source tree when grouped by path
​https://bugs.webkit.org/show_bug.cgi?id=225317

Reviewed by Devin Rousso.

Ensure origin tree elements for different domains in the Sources Tab behave as folder tree elements
in that they can be individually selected without triggering rendering of any resource.

In essence, restore behavior prior to ​https://trac.webkit.org/changeset/248912/webkit

The only exception is for document resources. Clicking on the origin tree element associated with a document resource,
triggers rendering of the corresponding document.

• UserInterface/Views/OriginTreeElement.js:

(WI.OriginTreeElement):

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addResource):

8:02 AM Changeset in webkit [276957] by svillar@igalia.com

• 2 edits in trunk/LayoutTests

Unreviewed, unskipped a test which works fine.

• TestExpectations:

7:26 AM Changeset in webkit [276956] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, fix-up bug URL after r276955

• platform/glib/TestExpectations:

7:01 AM Changeset in webkit [276955] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, GLIB WebRTC gardening

• platform/glib/TestExpectations: Flag test as crashing in debug bots.

6:48 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro

(diff)

5:38 AM Changeset in webkit [276954] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK] segmentation fault in WebKit::IconDatabase::loadIconForPageURL
​https://bugs.webkit.org/show_bug.cgi?id=225279

Patch by Jim Mason <​jmason@ibinx.com> on 2021-05-04
Reviewed by Carlos Garcia Campos.

• UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::loadIconForPageURL):
(WebKit::IconDatabase::setIconForPageURL):

4:13 AM Changeset in webkit [276953] by commit-queue@webkit.org

• 9 edits in trunk

[WebRTC][GStreamer] fast/mediastream/resize-trim.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=192888

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-04
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The test was failing because the GStreamer mock video source was producing garbled frames
and the pixel test in the canvas was failing to detect gray. The frame was garbled because
the test asked "exact" video width that was inferior to the capture video width and we were
not taking this into account when creating a MediaSample from the video frame.

MediaSampleGStreamer::createImageSample() can now optionally resize the video frame
according to the destinationSize, if it was specified.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toMediaSample):

• platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::createImageSample):

• platform/graphics/gstreamer/MediaSampleGStreamer.h:

(WebCore::MediaSampleGStreamer::createImageSample):

• platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:

(WebCore::MockRealtimeVideoSourceGStreamer::updateSampleBuffer):

• platform/mock/MockRealtimeVideoSource.h:

LayoutTests:

• platform/glib/TestExpectations: Unflag test.
• resources/platform-helper.js: Remove EFL cruft.

(videoCanvasPixelComparisonTolerance):
(isEfl): Deleted.

3:04 AM Changeset in webkit [276952] by youenn@apple.com

• 25 edits in trunk/Source

Use OptionSet for MediaProducer::MediaStateFlags
​https://bugs.webkit.org/show_bug.cgi?id=225227

Reviewed by Eric Carlson.

Source/WebCore:

Update code to use a safer MediaProducer::MediaStateFlags type.

No change of behavior, this is a refactoring.

• Modules/airplay/WebMediaSessionManager.cpp:

(WebCore::flagsAreSet):
(WebCore::mediaProducerStateString):
(WebCore::WebMediaSessionManager::showPlaybackTargetPicker):
(WebCore::WebMediaSessionManager::clientStateDidChange):
(WebCore::WebMediaSessionManager::configurePlaybackTargetClients):
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring):
(WebCore::WebMediaSessionManager::configureWatchdogTimer):

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::mediaState const):

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::sourceCaptureState):
(WebCore::MediaStreamTrack::captureState):

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::mediaState const):
(WebCore::AudioContext::visibilityStateChanged):

• dom/Document.cpp:

(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::updateIsPlayingMedia):

• dom/Document.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const):
(WebCore::HTMLMediaElement::mediaState const):

• html/HTMLMediaElement.h:
• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackStateChangePermitted const):

• page/MediaProducer.h:

(WebCore::MediaProducer::isCapturing):

• page/Page.cpp:

(WebCore::Page::updateIsPlayingMedia):

• page/Page.h:
• testing/Internals.cpp:

(WebCore::Internals::pageMediaState):

Source/WebKit:

Update code according safer MediaProducer::MediaStateFlags type.

• UIProcess/API/C/WKPage.cpp:

(WKPageGetMediaState):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView cameraCaptureState]):
(-[WKWebView microphoneCaptureState]):

• UIProcess/Cocoa/MediaUtilities.mm:

(WebKit::toWKMediaCaptureStateDeprecated):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::captureStateChanged):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateActivityState):
(WebKit::WebPageProxy::setMuted):
(WebKit::WebPageProxy::updatePlayingMediaDidChange):
(WebKit::WebPageProxy::updateReportedMediaCaptureState):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::mediaState const):

1:00 AM Changeset in webkit [276951] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

Unreviewed, fix GTK and WPE builds after r276947

• Headers.cmake: Add missing header 'Modules/highlight/HighlightVisibility.h'.

12:42 AM Changeset in webkit [276950] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GStreamer][Debug] Allow fastMallocs in audio threads
​https://bugs.webkit.org/show_bug.cgi?id=225306

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-04
Reviewed by Adrian Perez de Castro.

For the time being the GStreamer ports need to allocate audio buffers for WebRTC. This
deserves deeper investigation to avoid the allocations but for now the bots need to be fixed
ASAP.

• platform/mediastream/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeIncomingAudioSourceLibWebRTC::OnData):

• platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:

(WebCore::LibWebRTCAudioModule::pollAudioData):