⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 6, 2021:

11:15 PM Changeset in webkit [277161] by Fujii Hironori
  • 3 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo-wk1/TestExpectations:
  • platform/wincairo/TestExpectations:
11:11 PM Changeset in webkit [277160] by ntim@apple.com
  • 4 edits
    2 deletes in trunk/LayoutTests

Re-import css/mediaqueries/test_media_queries.html WPT
​https://bugs.webkit.org/show_bug.cgi?id=225469

Unreviewed. Test gardening.

Pulls in ​https://github.com/web-platform-tests/wpt/pull/28881 to fix device specific test failures.
Also removes platform-specific test expectations which were added to that issue.

LayoutTests/imported/w3c:

  • web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
  • web-platform-tests/css/mediaqueries/test_media_queries.html:

LayoutTests:

  • platform/gtk/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: Removed.
  • platform/wpe/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: Removed.
10:38 PM Changeset in webkit [277159] by Lauro Moura
  • 4 edits
    2 adds
    2 deletes in trunk/LayoutTests

[WPE] Garden a few more failures

Unreviewed test gardening.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/inline/crash-when-revert-has-trailing-line-break-expected.txt: Added to keep testing whether the crash happens instead of skipping.
  • platform/wpe/fonts/sans-serif-expected.txt: Rebaseline after r275515.
  • platform/wpe/fonts/serif-expected.txt: Ditto.
  • platform/wpe/http/tests/cache/network-error-during-revalidation-expected.txt: Removed. Using DumpJSConsoleLogInStdErr instead to reuse root baseline.
  • platform/wpe/http/tests/xmlhttprequest/state-after-network-error-expected.txt: Ditto.
  • platform/wpe/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Added after r275515.
10:00 PM Changeset in webkit [277158] by Chris Dumez
  • 15 edits in trunk

Port Filesystem::fileMetadata() & Filesystem::getFileModificationTime() to std::filesystem
​https://bugs.webkit.org/show_bug.cgi?id=225362

Reviewed by Darin Adler.

Source/JavaScriptCore:

Build fix.

  • Configurations/JavaScriptCore.xcconfig:

Source/WTF:

Port Filesystem::fileMetadata() & Filesystem::getFileModificationTime() to std::filesystem
and get rid of platform-specific implementations.

  • wtf/FileSystem.cpp:

(WTF::FileSystemImpl::toWallTime):
(WTF::FileSystemImpl::getFileModificationTime):
(WTF::FileSystemImpl::fileMetadata):

  • wtf/FileSystem.h:
  • wtf/glib/FileSystemGlib.cpp:
  • wtf/posix/FileSystemPOSIX.cpp:
  • wtf/win/FileSystemWin.cpp:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):
(TestWebKitAPI::runGetFileModificationTimeTest):

LayoutTests:

Add 0 to the list of allowed values for the size of a directory in the data transfer API as the result
is implementation-specific. On macOS, we used to return 256 on apfs and 272 on HFS+. We now return 0,
which is what Firefox does.

  • editing/pasteboard/entries-api/datatransfer-items-drop-getAsEntry-expected.txt:
  • editing/pasteboard/entries-api/datatransfer-items-drop-getAsEntry.html:
  • fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt:
  • fast/forms/file/entries-api/drag-folder-webkitEntries.html:
9:41 PM Changeset in webkit [277157] by Lauro Moura
  • 2 edits in trunk/Tools

[WPE] Garden web-process-crashed API test flakiness after SDK update

Unreviewed test gardening.

  • TestWebKitAPI/glib/TestExpectations.json:
8:11 PM Changeset in webkit [277156] by Russell Epstein
  • 8 edits in branches/safari-611-branch/Source

Versioning.

WebKit-7611.3.2

7:38 PM Changeset in webkit [277155] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[iOS] Allow file-read* and file-write-data for /dev/null and /dev/zero
​https://bugs.webkit.org/show_bug.cgi?id=225482
<rdar://problem/77503594>

Reviewed by Per Arne Vollan.

Revise sandbox to allow read and write-data access to /dev/null and /dev/zero.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
7:14 PM Changeset in webkit [277154] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ] http/wpt/mediarecorder/set-srcObject-MediaStream-Blob.html (layout-test) is a flaky text failure
Nhttps://bugs.webkit.org/show_bug.cgi?id=225500

Unreviewed test gardening.

Marking test as flaky (Pass Failure) while test is reviewed.

  • platform/mac-wk2/TestExpectations:
7:13 PM Changeset in webkit [277153] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Removed the assertion m_numParameters >= 0, it is always true as
m_numParameters is unsigned.
​https://bugs.webkit.org/show_bug.cgi?id=225457

Patch by Eleni Maria Stea <hikiko> on 2021-05-06
Reviewed by Yusuke Suzuki.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfArgumentValueProfiles):

6:56 PM Changeset in webkit [277152] by Robert Jenner
  • 1 edit
    6 adds in trunk/LayoutTests

REGRESSION (r272039): [Big Sur release WK2] imported/w3c/web-platform-t ests/media-source/mediasource-changetype-play-implicit.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=221143

Unreviewed test gardening.

Rebasing test for BigSur wk2.

  • platform/mac-bigsur-wk2/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt: Added.
6:48 PM Changeset in webkit [277151] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Retry asynchronously in WebProcessPool::getGPUProcessConnection() in case of failure
​https://bugs.webkit.org/show_bug.cgi?id=225486

Reviewed by Alex Christensen.

Retry asynchronously in WebProcessPool::getGPUProcessConnection(), similarly to what
we do in WebsiteDataStore::getNetworkProcessConnection(). As a result, we no longer
need to ref the WebProcessPool in the lambda and we avoid retrying unnecessarily
when the WebProcessPool is getting destroyed.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getGPUProcessConnection):

6:38 PM Changeset in webkit [277150] by Robert Jenner
  • 4 edits in trunk/LayoutTests

[ macOS iOS ] crypto/crypto-random-values-oom.html is a flakey timeout
​https://bugs.webkit.org/show_bug.cgi?id=223949

Unreviewed test gardening.

Updating test expectations to slow.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
6:31 PM Changeset in webkit [277149] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS ] webgl/1.0.3/conformance/glsl/constructors/glsl-construct-ivec2.html is a flakey timeout
​https://bugs.webkit.org/show_bug.cgi?id=224396

Unreviewed test gardening.

Updating expectations to slow.

  • platform/mac/TestExpectations:
6:12 PM Changeset in webkit [277148] by Jean-Yves Avenard
  • 2 edits in trunk/Source/WebCore

ArtworkImageLoader can call callback with null value.
​https://bugs.webkit.org/show_bug.cgi?id=225496
rdar://problem/77631799

Reviewed by Eric Carlson.

The ArtworkImageLoader can call the callback with null to indicate an error.

  • Modules/mediasession/MediaMetadata.cpp:

(WebCore::MediaMetadata::refreshArtworkImage): Add null check

6:09 PM Changeset in webkit [277147] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[MacOS] animations/keyframe-pseudo-shadow.html is flakey failing
​https://bugs.webkit.org/show_bug.cgi?id=221491

Unreviewed test garending.

Updating test expectation. Was previously set as Pass Failure, but is an Image failure. Added ImageOnly to Failure expectation.

  • platform/mac/TestExpectations:
5:56 PM Changeset in webkit [277146] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ] fast/scrolling/mac/overflow-scrollbars-toggle-dark-mode.html (layout-test) is a flaky
​https://bugs.webkit.org/show_bug.cgi?id=225498

Unreviewed test gardening.

Updated expectations to flaky ( Pass ImageOnlyFailure ) while test is reviewed.

  • platform/mac-wk2/TestExpectations:
5:46 PM Changeset in webkit [277145] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update test expectations after WPT re-imports in r277086 and r277091.

  • platform/glib/TestExpectations:
5:30 PM Changeset in webkit [277144] by dino@apple.com
  • 16 edits in trunk/LayoutTests

Rebaseline the following tests that now pass.
rdar://76714473

  • webgl/2.0.0/deqp/functional/gles3/fbomultisample.2_samples-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/fbomultisample.4_samples-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/fbomultisample.8_samples-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/00-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/01-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/02-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/03-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/04-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/05-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/06-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/primitiverestart/07-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/shadertexturefunction/texturegrad-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/textureformat/sized_depth_stencil-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/texturespecification/texstorage2d_format_depth_stencil-expected.txt:
  • webgl/2.0.0/deqp/functional/gles3/texturespecification/texstorage3d_format_depth_stencil-expected.txt:
5:17 PM Changeset in webkit [277143] by Kyle Piddington
  • 3 edits in trunk/Source/ThirdParty/ANGLE

[Metal ANGLE] Only clear dirty state bits after all state has been successfully set
​https://bugs.webkit.org/show_bug.cgi?id=225468
<rdar://77066752>

When running in release, if any ANGLE calls fail, we eventually return to this part of the code.
We can be left with an incomplete state, where we have an incomplete program or attachment,
but a 'clean' state. This can lead to errors such as setting nil render pipeline states, leading to
crashes.

To mitigate this, hold off on setting state bits until we've completly set up a program.

Reviewed by Dean Jackson.

  • src/libANGLE/renderer/metal/ContextMtl.mm:

(rx::ContextMtl::setupDraw):

  • src/libANGLE/renderer/metal/ProgramMtl.mm:
5:17 PM Changeset in webkit [277142] by yoshiaki.jitsukawa@sony.com
  • 18 edits
    2 copies
    4 adds in trunk

[OpenSSL] Implement CryptoAlgorithmRSA*
​https://bugs.webkit.org/show_bug.cgi?id=225294

Reviewed by Don Olmstead.

Implement RSA for OpenSSL.

Implement CryptoAlgorithmRSA_OAEP, CryptoAlgorithmRSA_PSS,
CryptoAlgorithmRSAES_PKCS1_v1_5, CryptoAlgorithmRSASA_PKCS1_v1_5,
and CryptoKeyRSA for OpenSSL.

.:

Note that if such OpenSSL version that does not support RSA_OAEP or
RSA_PSS, the WebCrypto API for those algorithm will return a
NotSupportedError.

  • Source/cmake/OptionsPlayStation.cmake:
  • Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

Note that if such OpenSSL version that does not support RSA_OAEP or
RSA_PSS, the WebCrypto API for those algorithm will return a
NotSupportedError.

Also note that OpenSSL accepts RSA_PSS salt length longer than the hash
length. This makes the
crypto/subtle/rsa-pss-import-key-sign-large-salt.html test fail.

Test: Existing crypto/subtle tests

  • crypto/keys/CryptoKeyRSA.h: Use the EVP_PKEY struct for the platform

key.

  • crypto/openssl/CryptoAlgorithmHMACOpenSSL.cpp: Move HMACAlgorithm()

to OpenSSLUtilities as DigestAlgorithm().

  • crypto/openssl/CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
Implemented.
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
Implemented.

  • crypto/openssl/CryptoAlgorithmRSASSA_PKCS1_v1_5OpenSSL.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
Implemented.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
Implemented.

  • crypto/openssl/CryptoAlgorithmRSA_OAEPOpenSSL.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt): Implemented.
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt): Implemented.

  • crypto/openssl/CryptoAlgorithmRSA_PSSOpenSSL.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign): Implemented.
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify): Implemented.

  • crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Registered RSAES_PKCS1_v_1_5, RSASSA_PKCS1_v1_5, RSA_OAEP, and RSA_PSS.

  • crypto/openssl/CryptoKeyRSAOpenSSL.cpp:

(WebCore::getRSAModulusLength):
(WebCore::convertToBytes):
(WebCore::convertToBigNumber):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::CryptoKeyRSA):
(WebCore::CryptoKeyRSA::isRestrictedToHash const):
(WebCore::CryptoKeyRSA::keySizeInBits const):
(WebCore::exponentVectorToUInt32):
(WebCore::CryptoKeyRSA::generatePair):
(WebCore::CryptoKeyRSA::importSpki):
(WebCore::CryptoKeyRSA::importPkcs8):
(WebCore::CryptoKeyRSA::exportSpki const):
(WebCore::CryptoKeyRSA::exportPkcs8 const):
(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::exportData const):

  • crypto/openssl/OpenSSLCryptoUniquePtr.h:

(WebCore::OpenSSLCryptoPtrDeleter<EVP_PKEY_CTX>::operator() const):
Added.
(WebCore::OpenSSLCryptoPtrDeleter<RSA>::operator() const): Added.
(WebCore::OpenSSLCryptoPtrDeleter<PKCS8_PRIV_KEY_INFO>::operator() const): Added.
(WebCore::OpenSSLCryptoPtrDeleter<BIGNUM>::operator() const): Added.
(WebCore::OpenSSLCryptoPtrDeleter<BN_CTX>::operator() const): Added.

  • crypto/openssl/OpenSSLUtilities.cpp:

(WebCore::digestAlgorithm): Added.
(WebCore::calculateDigest): Added.

  • crypto/openssl/OpenSSLUtilities.h:
  • platform/OpenSSL.cmake:

Source/WTF:

Note that if such OpenSSL version that does not support RSA_OAEP or
RSA_PSS, the WebCrypto API for those algorithm will return a
NotSupportedError.

  • wtf/Platform.h: Set HAVE_RSA_PSS for USE(OPENSSL)

LayoutTests:

Add wincairo platform expectations for
rsa-generate/import-key-malformed-parameters, modifying RSA-PSS
related results from NotSupported to appropriate errors.

  • platform/wincairo/TestExpectations: Unskip tests that are now supported.
  • platform/wincairo/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: Added.
  • platform/wincairo/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt: Added.
5:14 PM Changeset in webkit [277141] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ BigSur Debug ] webgl/1.0.3/conformance/glsl/misc/expression-list-in-declarator-initializer.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=225425

Unreviewed test gardening.

Updating test expectations to flaky ( Pass Timeout ) while test is reviewed.

  • platform/mac/TestExpectations:
5:13 PM Changeset in webkit [277140] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

r277122 caused a crash in GPU Process
​https://bugs.webkit.org/show_bug.cgi?id=225492
<rdar://problem/77630141>

Reviewed by Jer Noble.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Have the time observer
call back on the main queue.

4:39 PM Changeset in webkit [277139] by Russell Epstein
  • 1 copy in tags/Safari-611.2.7.1.4

Tag Safari-611.2.7.1.4.

4:38 PM Changeset in webkit [277138] by Robert Jenner
  • 2 edits in trunk/LayoutTests

N[ macOS wk2 ] fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html (layout-test) is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=225488

Unreviewed test gardening.

Updating test expectations to flaky ( Pass Timeout ) while test is reviewed.

  • platform/mac-wk2/TestExpectations:
4:35 PM Changeset in webkit [277137] by Russell Epstein
  • 1 copy in tags/Safari-611.2.7.0.3

Tag Safari-611.2.7.0.3.

4:15 PM Changeset in webkit [277136] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS ] imported/w3c/web-platform-tests/css/css-animations/translation-animation-subpixel-offset.html (layout-test) is a flakey ImageOnly failure
​https://bugs.webkit.org/show_bug.cgi?id=225484

Unreviewed test gardening.

Marking test as flaky ( Pass ImageOnlyFailure ) while test is reviewed.

  • platform/mac/TestExpectations:
4:01 PM Changeset in webkit [277135] by Chris Dumez
  • 62 edits in trunk

Regression(r254389?) navigator.languages returns all lowercase languages for ports using CF
​https://bugs.webkit.org/show_bug.cgi?id=225461

Reviewed by Darin Adler.

Source/WTF:

Stop lowercasing the languages returned by navigator.language / navigator.languages
as this does not match the specification [1][2] or other Web browsers. The proper format is
'en-US', not 'en-us'.

[1] ​https://html.spec.whatwg.org/#dom-navigator-language
[2] ​https://tools.ietf.org/html/bcp47

  • wtf/cf/LanguageCF.cpp:

(WTF::httpStyleLanguageCode):

Tools:

Update existing API tests to reflect behavior change.

  • TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:

(TEST):
(TEST_F):

LayoutTests:

Update existing tests to reflect behavior change.

  • fast/text/international/system-language/navigator-language/navigator-language-en-GB-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-en-GB.html:
  • fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-en-US.html:
  • fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-en.html:
  • fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-es-ES.html:
  • fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-es-MX.html:
  • fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-es.html:
  • fast/text/international/system-language/navigator-language/navigator-language-fr-CA-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html:
  • fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-fr.html:
  • fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-hi.html:
  • fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html:
  • fast/text/international/system-language/navigator-language/navigator-language-pt-PT-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html:
  • fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-ru.html:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-HK-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-Hans-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-TW-expected.txt:
  • fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html:
  • js/dom/navigator-language.html:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt:
  • platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-419-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-ja-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-HK-expected.txt:
  • platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK-expected.txt:
3:31 PM Changeset in webkit [277134] by Russell Epstein
  • 1 copy in tags/Safari-612.1.13

Tag Safari-612.1.13.

3:30 PM Changeset in webkit [277133] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Remove old and unused memory barrier abstractions
​https://bugs.webkit.org/show_bug.cgi?id=225487

Reviewed by Mark Lam.

We don't use memoryBarrierBlahBlah anymore.

  • wtf/Atomics.h:

(WTF::memoryBarrierAfterLock): Deleted.
(WTF::memoryBarrierBeforeUnlock): Deleted.

2:59 PM Changeset in webkit [277132] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[WPE] Garden accessibility failure and merge other expectations with glib one

Unreviewed test gardening.

  • platform/wpe/TestExpectations:
2:56 PM Changeset in webkit [277131] by Ruben Turcios
  • 1 copy in tags/Safari-612.1.11.10

Tag Safari-612.1.11.10.

2:56 PM Changeset in webkit [277130] by Ruben Turcios
  • 1 delete in tags/Safari-612.1.11.10

Delete tag.

2:49 PM Changeset in webkit [277129] by Russell Epstein
  • 2 edits in branches/safari-611.2.7.1-branch/Source/WebKit

Cherry-pick r276671. rdar://problem/77620890

HashTableConstIterator's consistency assertion fails while closing m_webIDBServers in NetworkProcess::didClose since r275846
​https://bugs.webkit.org/show_bug.cgi?id=225089

Reviewed by Chris Dumez.

The items of m_webIDBServers were removed while iterating
m_webIDBServers.

Move m_webIDBServers to a temporary HashMap before iterating.

  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::didClose):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@276671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:47 PM Changeset in webkit [277128] by Ruben Turcios
  • 8 edits in branches/safari-612.1.11-branch/Source

Versioning.

WebKit-7612.1.11.10

2:46 PM Changeset in webkit [277127] by Russell Epstein
  • 8 edits in branches/safari-611.2.7.1-branch/Source

Versioning.

WebKit-7611.2.7.1.4

2:39 PM Changeset in webkit [277126] by Ruben Turcios
  • 1 copy in tags/Safari-612.1.11.10

Tag Safari-612.1.11.10.

2:32 PM Changeset in webkit [277125] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[WPE][WebXR] Gardening regressions after r277099

Unreviewed test gardening.

  • platform/wpe/TestExpectations:
2:31 PM Changeset in webkit [277124] by Devin Rousso
  • 17 edits in trunk

Sampled Page Top Color: make hit tests consider elements with pointer-events: none
​https://bugs.webkit.org/show_bug.cgi?id=225419

Reviewed by Tim Horton.

Source/WebCore:

Test: SampledPageTopColor.HitTestCSSPointerEventsNone

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::ignoreCSSPointerEventsProperty const): Added.

  • rendering/InlineBox.h:

(WebCore::InlineBox::visibleToHitTesting const):

  • rendering/RenderElement.h:

(WebCore::RenderElement::visibleToHitTesting const):
Add RequestType::IgnoreCSSPointerEventsProperty that's used inside visibleToHitTesting
to control whether style().pointerEvents() == PointerEvents::None is checked.

  • dom/Document.cpp:

(WebCore::isValidPageSampleLocation):
Include the new RequestType::IgnoreCSSPointerEventsProperty since we're not hit testing
for interaction, rather we're hit testing in an attempt to see what will be painted.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::hitTestCulledInline):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::nodeAtPoint):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::nodeAtPoint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):
Pass the HitTestRequest to visibleToHitTesting.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(TEST.SampledPageTopColor.HitTestCSSPointerEventsNone): Added.

2:26 PM Changeset in webkit [277123] by Devin Rousso
  • 4 edits in trunk

Sampled Page Top Color: don't snapshot if the hit test location is a canvas
​https://bugs.webkit.org/show_bug.cgi?id=225418

Reviewed by Tim Horton.

Source/WebCore:

Tests: SampledPageTopColor.HitTestHTMLCanvasWithoutRenderingContext

SampledPageTopColor.HitTestHTMLCanvasWithRenderingContext

  • dom/Document.cpp:

(WebCore::isValidPageSampleLocation):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(TEST.SampledPageTopColor.HitTestHTMLCanvasWithoutRenderingContext): Added.
(TEST.SampledPageTopColor.HitTestHTMLCanvasWithRenderingContext): Added.

2:16 PM Changeset in webkit [277122] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore
REGRESSION (r276870): ASSERTION FAILED: !m_impl
!m_shouldEnableAssertions m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer

​https://bugs.webkit.org/show_bug.cgi?id=225371
<rdar://problem/77531907>

Reviewed by Eric Carlson.

In WebKitLegacy, the weakPtr created by createAVPlayer() is constructed on the WebThread, and
dereferenced on the main thread. However, the reason we use a WeakPtr for this call is a long-
since fixed bug in AVFoundation. We can just remove the WeakPtr and rely on AVFoundation to
not call our block after the observer has been removed in the destructor.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

2:14 PM Changeset in webkit [277121] by Russell Epstein
  • 2 edits in branches/safari-611.2.7.0-branch/Source/WebKit

Cherry-pick r277114. rdar://problem/77623232

Fix crash when WebsiteDataStore is destroyed with outstanding getNetworkProcessConnection request
​https://bugs.webkit.org/show_bug.cgi?id=225478
<rdar://77576148>

Reviewed by Chris Dumez.

In WebsiteDataStore::getNetworkProcessConnection if we don't get a connection the first time, we terminate the network process
and try again. This greatly increases our success rate. However, if we are cancelling the reply because of the destruction
of the WebsiteDataStore, we will end up doing bad things with partially destroyed objects, which ends up crashing.
In order to prevent this, use RunLoop::main.dispatch to retry on the next runloop iteration so that we will never be inside the
stack of WebsiteDataStore::~WebsiteDataStore when retrying. In that case, we will find that weakThis is null and send an empty
reply.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::getNetworkProcessConnection):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:14 PM Changeset in webkit [277120] by Russell Epstein
  • 2 edits in branches/safari-611.2.7.0-branch/Source/WebKit

Cherry-pick r276671. rdar://problem/77620826

HashTableConstIterator's consistency assertion fails while closing m_webIDBServers in NetworkProcess::didClose since r275846
​https://bugs.webkit.org/show_bug.cgi?id=225089

Reviewed by Chris Dumez.

The items of m_webIDBServers were removed while iterating
m_webIDBServers.

Move m_webIDBServers to a temporary HashMap before iterating.

  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::didClose):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@276671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:01 PM Changeset in webkit [277119] by aboya@igalia.com
  • 2 edits in trunk/LayoutTests

[EME][GStreamer] Unreviewed micro-gardening
​https://bugs.webkit.org/show_bug.cgi?id=225422

I'm adjusting the expectations to specify that
imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html
doesn't resolve as a failure.

  • platform/glib/TestExpectations:
1:55 PM Changeset in webkit [277118] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Make some things easier to dataLog in wasm
​https://bugs.webkit.org/show_bug.cgi?id=225472

Reviewed by Yusuke Suzuki.

  • wasm/WasmMemoryMode.cpp:

(WTF::printInternal):

  • wasm/WasmMemoryMode.h:
  • wasm/WasmWorklist.cpp:

(JSC::Wasm::Worklist::dump const):

  • wasm/WasmWorklist.h:
1:54 PM Changeset in webkit [277117] by fpizlo@apple.com
  • 14 edits in trunk/Source

Reduce use of dmb ish on ARM64
​https://bugs.webkit.org/show_bug.cgi?id=225465

Reviewed by Keith Miller.
Source/JavaScriptCore:


We use loadLoadFence a lot, often in situations like:

Foo* ptr = loadStuff;
loadLoadFence();
use ptr

On ARM64, we don't need a dmb ish here. This introduces a dependentLoadLoadFence() for these
cases; it's just a compiler fence on ARM64 and Intel.

We also used loadLoadFence in some places where I couldn't think of any good reason for the
fence other than paranoia. I got rid of those.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromCallLinkInfo):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::jitType const):

  • bytecode/ObjectAllocationProfile.h:

(JSC::ObjectAllocationProfileBase::structure):
(JSC::ObjectAllocationProfileWithPrototype::prototype):

  • bytecode/Watchpoint.h:

(JSC::WatchpointSet::state const):
(JSC::InlineWatchpointSet::state const):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::handlePutByVal):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):

  • runtime/GetterSetter.h:
  • runtime/InferredValue.h:

(JSC::InferredValue::state const):

  • runtime/Structure.h:

(JSC::Structure::tryRareData):

  • runtime/StructureInlines.h:

(JSC::Structure::propertyReplacementWatchpointSet):

Source/WTF:

  • wtf/Atomics.h:

(WTF::dependentLoadLoadFence):

1:49 PM Changeset in webkit [277116] by eric.carlson@apple.com
  • 13 edits in trunk/Source

[GPUP] Reduce MediaPlayer polling frequency when possible
​https://bugs.webkit.org/show_bug.cgi?id=225396
<rdar://problem/77562643>

Reviewed by Jer Noble.

Source/WebCore:

Add a currentTime changed callback to MediaPlayerPrivateInterface so a client
doens't have to poll for time changes.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setCurrentTimeDidChangeCallback):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setCurrentTimeDidChangeCallback):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTimeDidChangeCallback):
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentMediaTimeDidChange const):

Source/WebKit:

When the MediaPlayerPrivate supports the new "current time changed" callback, use it
know when currentTime changes instead of polling at a fixed frequency. Current time
changes much more frequently than the other state that needs to be pushed to the
web process periodically so split current time out of the "cached state" struct
and push it separately when it changes, which also allow us to reduce the polling
frequency significantly.

Some of the state we were updating every time the cached state timer fired only
changes at known times, so reduce the number of things updated every time state
is pushed.

  • GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::getConfiguration): Set the timeChanged callback.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerNetworkStateChanged): Update cached
readyState and networkState since they aren't updated by updateCachedState.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReadyStateChanged): Ditto.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerDurationChanged): Update cached duration.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCharacteristicChanged): Update hasAudio
and hasVideo.
(WebKit::RemoteMediaPlayerProxy::startUpdateCachedStateMessageTimer): Decrease the
time frequency to 200ms when the player supports the time change callback. Decrease
it to 250ms even when it doesn't because we interpolate time in the WP anyway.
(WebKit::RemoteMediaPlayerProxy::currentTimeChanged): Send the time change.
(WebKit::RemoteMediaPlayerProxy::updateCachedState): Send CurrentTimeChanged if
the player doesn't support the new callback. Don't update properties that change
at predictable times.

  • GPUProcess/media/RemoteMediaPlayerProxy.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::pause): Use m_cachedMediaTime and m_cachedMediaTimeQueryTime
instead of m_cachedState.currentTime and m_cachedState.timestamp.
(WebKit::MediaPlayerPrivateRemote::currentMediaTime const): Ditto.
(WebKit::MediaPlayerPrivateRemote::playbackStateChanged): Ditto.
(WebKit::MediaPlayerPrivateRemote::currentTimeChanged): Update time instance variables.
(WebKit::MediaPlayerPrivateRemote::updateCachedState):
(WebKit::MediaPlayerPrivateRemote::performTaskAtMediaTime): Use m_cachedMediaTime
and m_cachedMediaTimeQueryTime instead of m_cachedState.currentTime and m_cachedState.timestamp.

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
  • WebProcess/GPU/media/RemoteMediaPlayerState.h:

(WebKit::RemoteMediaPlayerState::encode const): Remove currentTime and timestamp.
(WebKit::RemoteMediaPlayerState::decode): Ditto.

1:42 PM Changeset in webkit [277115] by Jonathan Bedard
  • 2 edits in trunk/Tools

[webkit-patch] setup-git-clone uses master instead of main
​https://bugs.webkit.org/show_bug.cgi?id=225460
<rdar://problem/77616439>

Reviewed by Aakash Jain.

  • Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone.execute): Pair the remote branch ref with the Svn remote.

1:40 PM Changeset in webkit [277114] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix crash when WebsiteDataStore is destroyed with outstanding getNetworkProcessConnection request
​https://bugs.webkit.org/show_bug.cgi?id=225478
<rdar://77576148>

Reviewed by Chris Dumez.

In WebsiteDataStore::getNetworkProcessConnection if we don't get a connection the first time, we terminate the network process
and try again. This greatly increases our success rate. However, if we are cancelling the reply because of the destruction
of the WebsiteDataStore, we will end up doing bad things with partially destroyed objects, which ends up crashing.
In order to prevent this, use RunLoop::main.dispatch to retry on the next runloop iteration so that we will never be inside the
stack of WebsiteDataStore::~WebsiteDataStore when retrying. In that case, we will find that weakThis is null and send an empty
reply.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getNetworkProcessConnection):

1:26 PM Changeset in webkit [277113] by Chris Dumez
  • 2 edits in trunk/Tools

Add API test for FileSystem::fileExists() on a broken symbolic link
​https://bugs.webkit.org/show_bug.cgi?id=225476

Reviewed by Darin Adler.

Add API test for FileSystem::fileExists() on a broken symbolic link since this is a special
case. FileSystem::fileExists() currently tries to follow symbolic links and will thus return
false. The behavior is a little odd but I have verified that this is what our access()-based
implementation was returning also before I ported FileSystem::fileExists() to std::filesystem.

  • TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

1:11 PM Changeset in webkit [277112] by graouts@webkit.org
  • 14 edits
    2 adds in trunk

CSS custom properties on pseudo elements background gradients causes infinite layout and high CPU load
​https://bugs.webkit.org/show_bug.cgi?id=194332
<rdar://problem/47873895>

Reviewed by Simon Fraser.

Source/WebCore:

When a background-image uses a CSS custom property the resulting StyleGeneratedImage may not be the same
object as during prior style updates. This caused transitions to be triggered for all style updates for
such background-image values. To fix this, we modify the == operator for StyleGeneratedImage to use
arePointingToEqualData() with the CSSImageGeneratorValue member and added an == operator for the
CSSImageGeneratorValue class to call into the existing equals() methods. These equals() methods
are now overrides of the virtual CSSImageGeneratorValue method.

This change in behavior required a change in RenderElement::updateFillImages() to not only check whether
the images were identical, but to also check whether the renderer was registered as a client on the new
images. To do this, we add a new virtual hasClient() method on StyleImage.

Test: webanimations/css-transition-element-with-gradient-background-image-and-css-custom-property.html

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::operator== const):

  • css/CSSImageGeneratorValue.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::updateFillImages):

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::imagesIdentical): Deleted.

  • rendering/style/FillLayer.h:
  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::hasClient const):

  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::operator== const):
(WebCore::StyleGeneratedImage::hasClient const):

  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
  • rendering/style/StyleMultiImage.cpp:

(WebCore::StyleMultiImage::hasClient const):

  • rendering/style/StyleMultiImage.h:

LayoutTests:

Add a test where an element with a background-image set to a CSS gradient using a custom property as a color
stop changes another property targeted by a transition to check that there is no background-image transition
generated.

  • webanimations/css-transition-element-with-gradient-background-image-and-css-custom-property-expected.txt: Added.
  • webanimations/css-transition-element-with-gradient-background-image-and-css-custom-property.html: Added.
12:42 PM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
12:41 PM Changeset in webkit [277111] by Adrian Perez de Castro
  • 3 edits in releases/WebKitGTK/webkit-2.32/Source/WebCore

Merge r277100 - [WebAudio][GStreamer] socketpair leaks
​https://bugs.webkit.org/show_bug.cgi?id=225463

Reviewed by Žan Doberšek.

  • platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::~AudioSourceProviderGStreamer): Properly dispose of
the GStreamer pipeline and the resources it has hold on.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcChangeState): The ref returned by gst_buffer_pool_new() is transfer-full,
so we need to adopt it here.

12:41 PM Changeset in webkit [277110] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

It should be possible to --logJIT=true
​https://bugs.webkit.org/show_bug.cgi?id=225464

Reviewed by Mark Lam.

This makes it easy to just log when JITing happens. It's like --dumpDisassembly=true but
without the disassembly.

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassemblyImpl):

  • assembler/LinkBuffer.h:
  • runtime/Options.cpp:

(JSC::Options::recomputeDependentOptions):

  • runtime/OptionsList.h:
12:40 PM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
12:29 PM Changeset in webkit [277109] by Ruben Turcios
  • 8 edits in branches/safari-612.1.12-branch/Source

Versioning.

WebKit-7612.1.12.4

12:24 PM Changeset in webkit [277108] by Russell Epstein
  • 2 edits in branches/safari-611.2.7.0-branch/Source/WebKit

Apply patch. rdar://problem/77619719

12:21 PM Changeset in webkit [277107] by Russell Epstein
  • 8 edits in branches/safari-611.2.7.0-branch/Source

Versioning.

WebKit-7611.2.7.0.3

12:09 PM Changeset in webkit [277106] by sihui_liu@apple.com
  • 4 edits in trunk/Source/WebKit

Drop some unnecessary code in LocalStorageDatabase
​https://bugs.webkit.org/show_bug.cgi?id=225435

Reviewed by Chris Dumez.

No behavior change.

  • NetworkProcess/WebStorage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase): Remove two paremeters that are no longer needed after
dropping code.
(WebKit::LocalStorageDatabase::openDatabase):
(WebKit::LocalStorageDatabase::migrateItemTableIfNeeded): SQLiteTransaction() by default sets readOnly to false,
and it will be rolled back for failure in ~SQLiteTransaction.
(WebKit::LocalStorageDatabase::close):
(WebKit::LocalStorageDatabase::tryToOpenDatabase): Deleted. Merged to openDatabase.

  • NetworkProcess/WebStorage/LocalStorageDatabase.h:
  • NetworkProcess/WebStorage/StorageArea.cpp:

(WebKit::StorageArea::ensureDatabase const):

11:58 AM Changeset in webkit [277105] by fpizlo@apple.com
  • 3 edits in trunk/Tools

Make it easy to pass XPC variables to run-benchmark
​https://bugs.webkit.org/show_bug.cgi?id=225473

Reviewed by Stephanie Lewis.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_url):

  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(config_argument_parser):

11:40 AM Changeset in webkit [277104] by pvollan@apple.com
  • 6 edits in trunk/Source

Add sandbox extension flag to specify that path contains no symlinks
​https://bugs.webkit.org/show_bug.cgi?id=219428
<rdar://problem/66551986>

Reviewed by Brent Fulgham.

Source/WebKit:

In general, when SandboxExtension::createHandleWithoutResolvingPath is called, it is assumed that there are no symlinks
in the provided path. Add a 'canonical' flag, which can be used by platform APIs to verify that this is the case. This
patch also stops resolving symlinks with [NSString stringByResolvingSymlinksInPath] in favor of realpath, since realpath
correcly replaces /var with /private/var, which [NSString stringByResolvingSymlinksInPath] does not.

  • Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
(WebKit::stringByResolvingSymlinksInPath):
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):

  • Shared/SandboxExtension.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::webProcessDataStoreParameters):

Source/WTF:

Declare canonical sandbox flag.

  • wtf/spi/darwin/SandboxSPI.h:
11:34 AM Changeset in webkit [277103] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

EWS bubbles should show current status after pressing 'Retry failed builds' button
​https://bugs.webkit.org/show_bug.cgi?id=225411

Reviewed by Jonathan Bedard.

  • CISupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):

11:32 AM Changeset in webkit [277102] by Jonathan Bedard
  • 16 edits in trunk/Tools

[webkitcorepy] Add API to efficiently create a sequence of commits
​https://bugs.webkit.org/show_bug.cgi?id=224890
<rdar://problem/76975733>

Rubber-stamped by Aakash Jain.

While it is possible to simple iterate through a range of commits to define them,
every API we use to define commits has much more efficient techniques.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py:

(Contributor): Add revision to SVN_AUTHOR_RE and add regex without lines.
(Contributor.from_scm_log): Strip leading whitespace from author.

  • Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git._args_from_content):
(Git.commits): Use git log to efficiently compute a range of commits.

  • Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn._args_from_content):
(Svn.commits): Use svn log to efficiently compute a range of commits.

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:

(Git.init): Add git log mock.

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:

(Svn.init): Add svn log mock and more explicit svn info mock.
(Svn._log_range):

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:

(GitHub._commits_response): Return all parent commits to provided ref.
(GitHub.request):

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py:

(Svn.range): More efficiently compute the range.
(Svn.request):

  • Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:

(GitHub.request): Allow caller to disable pagination.
(GitHub.commit): Reduce number of requests required to compute order.
(GitHub.commits): Using the commits endpoint, more efficiently
compute a range of commits.

  • Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py:

(Svn): Generalize HISTORY_RE to match any single-line SVN XML response.
(Svn._cache_revisions): Replace HISTORY_RE with DATA_RE.
(Svn.commits): Use svn/rvr to efficiently compute a range of commits.

  • Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:

(ScmBase._commit_range): Return a pair of commits representing the range
the caller is requesting, and preform some basic sanity checks.
(ScmBase.commits): Declare function implemented by decedents.

  • Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
  • Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit.test_commits):
(TestGit.test_commits_branch):
(TestGitHub.test_commits):
(TestGitHub.test_commits_branch):

  • Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestLocalSvn.test_commits):
(TestLocalSvn.test_commits_branch):
(TestRemoteSvn.test_commits):
(TestRemoteSvn.test_commits_branch):

10:20 AM Changeset in webkit [277101] by Chris Dumez
  • 2 edits in trunk/Tools

REGRESSION (r272414?): [macOS] TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=221742
<rdar://problem/74220428>

Reviewed by Youenn Fablet.

Check that video.currentTime is changing to determine if the video is playing, instead of
relying on [webView _isPlayingAudio]. Also use a test page with a single video element instead
of multiple. I am hoping this will make the test more reliable or at least shade some light on
why this is flaky.

  • TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

10:13 AM Changeset in webkit [277100] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[WebAudio][GStreamer] socketpair leaks
​https://bugs.webkit.org/show_bug.cgi?id=225463

Reviewed by Žan Doberšek.

  • platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::~AudioSourceProviderGStreamer): Properly dispose of
the GStreamer pipeline and the resources it has hold on.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcChangeState): The ref returned by gst_buffer_pool_new() is transfer-full,
so we need to adopt it here.

10:05 AM Changeset in webkit [277099] by dino@apple.com
  • 7 edits in trunk/Source

[WebXR] Add IOSurface to FrameData::LayerData
​https://bugs.webkit.org/show_bug.cgi?id=225428
<rdar://problem/77586270>

Reviewed by Tim Horton.

Source/WebCore:

Original patch by Ada Chan.

Cocoa platforms will use IOSurfaces on FrameData::LayerData.
Add this member, allow it to be encoded and decoded, and fix up
some places where we were copying a FrameData unnecessarily, or
where we have to explicitly copy.

  • Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::onFrame): Use WTFMove instead of copying.

  • platform/graphics/cocoa/IOSurface.h: Export createFromSurface.
  • platform/xr/PlatformXR.h:

(PlatformXR::Device::FrameData::LayerData::encode const):
(PlatformXR::Device::FrameData::LayerData::decode):
(PlatformXR::Device::FrameData::decode):
(PlatformXR::Device::FrameData::copy const):

  • testing/WebFakeXRDevice.cpp:

(WebCore::SimulatedXRDevice::frameTimerFired):

Source/WTF:

Add USE(IOSURFACE_FOR_XR_LAYER_DATA) and make it true
for Cocoa platforms.

  • wtf/PlatformUse.h:
9:57 AM Changeset in webkit [277098] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update expectations after WPT re-import in r277073 and r277077.

  • platform/glib/TestExpectations:
9:54 AM Changeset in webkit [277097] by Wenson Hsieh
  • 13 edits
    2 adds in trunk

[iOS] UI process hangs when showing a modal JavaScript dialog while focusing an input field
​https://bugs.webkit.org/show_bug.cgi?id=225409
rdar://76792407

Reviewed by Darin Adler, Chris Dumez and Tim Horton.

Source/WebKit:

Consider the scenario where an input field has a focus event handler that shows a modal JavaScript dialog (e.g.
confirm, alert, prompt). We get the following sequence of events in this scenario:

(WEB) The text field is focused, and sends WebPageProxy::ElementDidFocus. A modal dialog is then triggered by

script inside the focus event handler, sending a message like WebPageProxy::RunJavaScriptAlert.

(UI) The UI process receives WebPageProxy::ElementDidFocus, and calls -reloadInputViews while showing the

keyboard. UIKit may then call back into -requestAutocorrectionContextWithCompletionHandler:, which
triggers sync IPC back to the web process. While waiting to receive a response message, we receive and
dispatch WebPageProxy::RunJavaScriptAlert.

At this point, the UI process is still waiting for a HandleAutocorrectionContext response IPC message, but the
web process is blocked on a response to the modal JavaScript dialog; since both processes are blocked on each
other, we're now in deadlock.

To mitigate this, we can preemptively send autocorrection context data right before we're about to synchronously
block in the web process on a modal dialog. In the UI process, we use this autocorrection context object to
immediately stop syncwaiting for a HandleAutocorrectionContext response. See below for more details.

Test: fast/events/ios/show-modal-alert-during-focus.html

  • Platform/IPC/Connection.cpp:

(IPC::Connection::SyncMessageState::dispatchMessages):
(IPC::Connection::waitForMessage):

Make a slight adjustment here so that waitForMessage bails if one of the messages we're dispatching underneath
SyncMessageState::dispatchMessages is the message we happen to be waiting for anyways. In this case, it's
necessary in order for the preemptive WebPageProxy::HandleAutocorrectionContext message sent by the web
process to unblock the UI process, which is waiting for a WebPageProxy::HandleAutocorrectionContext response.

  • UIProcess/PageClient.h:

(WebKit::PageClient::runModalJavaScriptDialog):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runModalJavaScriptDialog):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):

Wrap calls to runJavaScript(Alert|Confirm|Prompt) underneath a new page client method that takes a block,
runModalJavaScriptDialog. See -[WKContentView runModalJavaScriptDialog:] below for more details.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::runModalJavaScriptDialog):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):

Avoid blocking on the web process if it's waiting on a modal JavaScript dialog anyways; just use the last
autocorrection context we received from the web process (which we know must've been sent right before showing
the modal dialog anyways).

(-[WKContentView runModalJavaScriptDialog:]):

In the case where we're in the process of presenting the keyboard (or UCB) on iOS after focusing an input field,
avoid immediately allowing the client to show any modal UI until we're done managing keyboard logic in WebKit.
Without this adjustment, we'll end up trying to present the modal JavaScript dialog in the middle of UIKit's
call to -requestAutocorrectionContextWithCompletionHandler:, which then causes UIKit to throw an exception
underneath keyboard code.

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::prepareToRunModalJavaScriptDialog):

Add logic to preemptively compute and send WebAutocorrectionContext data to the UI process on iOS, in the case
where we're about to show a modal JavaScript dialog and there is an editable focused element. While the modal
dialog is shown, we'll use this information to immediately respond to UIKit's autocorrection context requests,
instead of trying to block on responses from the web process.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAutocorrectionContext):
(WebKit::WebPage::prepareToRunModalJavaScriptDialog):

LayoutTests:

Add a layout test that exercises the deadlock. In the case where we fail, this test will time out.

  • fast/events/ios/show-modal-alert-during-focus-expected.txt: Added.
  • fast/events/ios/show-modal-alert-during-focus.html: Added.
9:35 AM Changeset in webkit [277096] by Diego Pino Garcia
  • 1 edit
    3 adds in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening. Emit platform baselines after r277071.

Platform baselines are needed because platforms have different values
for screen resolution sizes, which are referred in the test results.

  • platform/gtk/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: Added.
9:23 AM Changeset in webkit [277095] by aboya@igalia.com
  • 2 edits in trunk/Source/WebCore

[MSE][GStreamer] Remove webKitMediaSrcFinalize
​https://bugs.webkit.org/show_bug.cgi?id=225458

Reviewed by Philippe Normand.

webKitMediaSrcFinalize was no longer necessary after moving to
WEBKIT_DEFINE_TYPE as requested by the reviewers. This patch cleans
that up.

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webkit_media_src_class_init):
(webKitMediaSrcFinalize): Deleted.

9:22 AM Changeset in webkit [277094] by mark.lam@apple.com
  • 8 edits
    1 add in trunk

Forbid further execution in jsc shell if execution is terminated.
​https://bugs.webkit.org/show_bug.cgi?id=225410
rdar://77548608

Reviewed by Michael Saboff.

JSTests:

  • stress/jsc-shell-forbid-execution-after-termination.js: Added.

Source/JavaScriptCore:

  1. Introduce a VM::m_executionForbidden flag.
  2. In the jsc shell, forbid further execution if termination was encountered.
  • jsc.cpp:

(runWithOptions):

  • runtime/VM.cpp:

(JSC::VM::drainMicrotasks):

  • runtime/VM.h:

(JSC::VM::executionForbidden const):
(JSC::VM::setExecutionForbidden):

Source/WebCore:

Re-implement WorkerOrWorkletScriptController::forbidExecution() and
isExecutionForbidden() using the VM's notion of the flag

  • workers/WorkerOrWorkletScriptController.cpp:

(WebCore::WorkerOrWorkletScriptController::forbidExecution):
(WebCore::WorkerOrWorkletScriptController::isExecutionForbidden const):

  • workers/WorkerOrWorkletScriptController.h:
9:08 AM Changeset in webkit [277093] by Darin Adler
  • 22 edits in trunk

Streamline codec parsing, replacing uses of HashMap with SortedArrayMap
​https://bugs.webkit.org/show_bug.cgi?id=225368

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/ContentType.cpp:

(WebCore::ContentType::parameter const): Use early return instead of nesting.
Strip HTML spaces, not all whitespace, and do it only once rather than twice.
Fixed a small bug where we search for the second quotation mark in a way that
could find the same quotation mark twice if there is a space before the first
one. Added FIXME comments about a few obvious problems in the parsing algorithm.
Improved efficiency by using StringView, saving the allocation of one temporary
StringImpl in the case where we have some HTML spaces to strip.
(WebCore::ContentType::containerType const): Simplified the implemementation
by taking advantage of the fact that our notFound value is designed to be used
as an argument to functions like String::left, telling them to return the
entire string. Strip HTML spaces, not all whitespace.

  • platform/graphics/HEVCUtilities.cpp:

(WebCore::parseHEVCCodecParameters): Take a StringView instead of a String
for greater flexibility and efficiency. Don't store codecName, which is
never used after verifying that it is a legal value here. Don't store the
generalTierFlag, which is never used after verifying that it is a legal
value here. Don't store the constraint flags, which are never used after
verifying that they are legal values here.
(WebCore::makeOptionalFromPointer): Added to make code below cleaner.
(WebCore::parseDoViCodecType): Renamed from codecStringForDoViCodecType
since it now returns an enumeration value instead of a string. Also
take a StringView instead of a String for greater flexibility and efficiency.
Also use a SortedArrayMap instead of a MemoryCompactLookupOnlyRobinHoodHashMap.
(WebCore::profileIDForAlphabeticDoViProfile): Take a StringView instead of
a String for greater flexibility and efficiency. Use a SortedArrayMap instead
of a MemoryCompactLookupOnlyRobinHoodHashMap.
(WebCore::isValidProfileIDForCodec): Take a codec enumeration value parameter
instead of a string.
(WebCore::parseDoViCodecParameters): Take a StringView instead of a String
for greater flexibility and efficiency. Store the codec as an enumeration
instead of a String. Don't create a temporary String just so we can call the
profileIDForAlphabeticDoViProfile function.

  • platform/graphics/HEVCUtilities.h: Renamed HEVCParameterSet and

DoViParameterSet to HEVCParameters and DoViParameters. The word "set" is not
helpful in these names. Removed codecName, generalTierFlag, and constraintFlags
from HEVCParameterSet. Changed the parse functions to take StringView instead
of String. Replaced the string codecName in DoViParameterSet with an enumeration
since there are only a few valid values.

  • platform/graphics/cocoa/HEVCUtilitiesCocoa.h: Use Optional return value

instead of a bool and an out argument.

  • platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:

(WebCore::validateHEVCParameters): Updated to return Optional.
(WebCore::codecType): Updated to take an enumeration value and no longer
need to return an optional. Also renamed from codecTypeForDoViCodecString
since the type now makes this clear without a long function name.
(WebCore::parseStringArrayFromDictionaryToUInt16Vector): Renamed from
CFStringArrayToNumberVector, and moved the dictionary lookup in here.
The old name was a little vague; "NumberVector" doesn't say 16-bit unsigned.
Simplified code by using an Objective-C for loop instead of a block and
enumeration. This cut the size of the function down quite a bit.
(WebCore::validateDoViParameters): Updated to return Optional. Also
refactored to use the imrpoved helper functions above.

  • platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:

(WebCore::videoCodecTypeFromRFC4281Type): Take a StringView instead of a String
for greater flexibility and efficiency.
(WebCore::computeMediaCapabilitiesInfo): Factored out this helper function
so we don't have such complicated callback logic. Refactored to use the new
versions of validateHEVCParameters, validateDoViParameters, and
validateVPParameters.
(WebCore::createMediaPlayerDecodingConfigurationCocoa): Moved most of the
code into computeMediaCapabilitiesInfo; this mostly deals with the callback.

  • platform/graphics/cocoa/VP9UtilitiesCocoa.h: Removed extraneous use of extern.

Added const for input-only reference arguments. Changed validateVPParameters to
return Optional instead of a bool with an out argument.

  • platform/graphics/cocoa/VP9UtilitiesCocoa.mm:

(WebCore::isVP9CodecConfigurationRecordSupported): Added const.
(WebCore::isVP8CodecConfigurationRecordSupported): Ditto.
(WebCore::isVPCodecConfigurationRecordSupported): Ditto.
(WebCore::validateVPParameters): Refactored to return Optional.

  • platform/network/HTTPHeaderMap.h: Removed unneeded includes.
  • platform/text/LocaleToScriptMapping.cpp: Moved PackedASCIILowerCodes from

here into the SortedArrayMap.h header.

  • testing/Internals.cpp:

(WebCore::Internals::parseHEVCCodecParameters): Tweaked since HEVCParameterSet
is now only the correct name here in the Internals class.
(WebCore::Internals::parseDoViCodecParameters): Ditto. Also added code to
expose the codec enumeration as a string. This is now a testing-only thing.
(WebCore::Internals::parseVPCodecParameters): Ditto.

  • testing/Internals.h: Tweaked the ParameterSet types since they now don't

exactly match the structures used in the real code.

  • testing/Internals.idl: Removed codecName, generalTierFlag, and

constraintFlags from HEVCParameterSet. Neither codecName nor constraintFlags
was used in any test. And the generalTierFlag test was something we can
do without; the parsed value isn't actually used in any WebKit code.

Source/WebKit:

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

Removed unneeded include.

  • Shared/WebsiteData/WebsiteData.h: Ditto.

Source/WTF:

  • wtf/SortedArrayMap.h: Moved PackedASCIILowerCodes here for reuse.

Slightly tweaked ComparableASCIISubsetLiteral to match better.

LayoutTests:

  • media/hevc-codec-parameters-expected.txt: Remove testing of generalTierFlag, which is ignored

by our actual media code after parsing.

  • media/hevc-codec-parameters.html: Ditto.
8:47 AM Changeset in webkit [277092] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix missing exception check in objectConstructorGetOwnPropertyDescriptors().
​https://bugs.webkit.org/show_bug.cgi?id=225413
rdar://77551530

Reviewed by Michael Saboff.

Need to handle TerminationException.

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptors):

8:34 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
8:30 AM Changeset in webkit [277091] by ntim@apple.com
  • 26 edits
    43 adds
    2 deletes in trunk/LayoutTests

Re-import css/css-fonts WPT
​https://bugs.webkit.org/show_bug.cgi?id=225455

Reviewed by Simon Fraser.

Base commit: ​https://github.com/web-platform-tests/wpt/commit/c4c81d21b9d606bedd0adb8f72bd0ecf15740e3e

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-font-loading/fontface-override-descriptor-getter-setter.sub-expected.txt: Added.
  • web-platform-tests/css/css-fonts/ascent-descent-override-expected.html: Added.
  • web-platform-tests/css/css-fonts/ascent-descent-override.html: Added.
  • web-platform-tests/css/css-fonts/downloadable-font-in-iframe-print-expected.html: Added.
  • web-platform-tests/css/css-fonts/downloadable-font-in-iframe-print.html: Added.
  • web-platform-tests/css/css-fonts/downloadable-font-print-expected.html: Added.
  • web-platform-tests/css/css-fonts/downloadable-font-print.html: Added.
  • web-platform-tests/css/css-fonts/fallback-url-to-local-expected.txt: Added.
  • web-platform-tests/css/css-fonts/fallback-url-to-local.html: Added.
  • web-platform-tests/css/css-fonts/font-display/font-display-expected.html:
  • web-platform-tests/css/css-fonts/font-display/font-display.html:
  • web-platform-tests/css/css-fonts/font-face-range-order.html:
  • web-platform-tests/css/css-fonts/font-feature-resolution-001-expected.html:
  • web-platform-tests/css/css-fonts/font-feature-resolution-001.html:
  • web-platform-tests/css/css-fonts/font-feature-resolution-002-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-feature-resolution-002.html: Added.
  • web-platform-tests/css/css-fonts/font-size-adjust-zero-1-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-size-adjust-zero-1.html: Added.
  • web-platform-tests/css/css-fonts/font-size-adjust-zero-2-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-size-adjust-zero-2.html: Added.
  • web-platform-tests/css/css-fonts/font-size-zero-1-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-size-zero-1-notref.html: Added.
  • web-platform-tests/css/css-fonts/font-size-zero-1-ref-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-size-zero-1-ref.html: Added.
  • web-platform-tests/css/css-fonts/font-size-zero-1.html: Added.
  • web-platform-tests/css/css-fonts/font-size-zero-2-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-size-zero-2.html: Added.
  • web-platform-tests/css/css-fonts/line-gap-override-expected.html: Added.
  • web-platform-tests/css/css-fonts/line-gap-override.html: Added.
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative.html:
  • web-platform-tests/css/css-fonts/metrics-override-normal-keyword-expected.html: Added.
  • web-platform-tests/css/css-fonts/metrics-override-normal-keyword.html: Added.
  • web-platform-tests/css/css-fonts/parsing/font-variation-settings-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variation-settings-computed.html:
  • web-platform-tests/css/css-fonts/parsing/font-variation-settings-invalid-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variation-settings-invalid.html:
  • web-platform-tests/css/css-fonts/parsing/font-variation-settings-valid-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variation-settings-valid.html:
  • web-platform-tests/css/css-fonts/rem-in-monospace-expected.html: Added.
  • web-platform-tests/css/css-fonts/rem-in-monospace.html: Added.
  • web-platform-tests/css/css-fonts/resources/markA.ttf: Added.
  • web-platform-tests/css/css-fonts/resources/markB.ttf: Added.
  • web-platform-tests/css/css-fonts/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-fonts/size-adjust-01-expected.html: Added.
  • web-platform-tests/css/css-fonts/size-adjust-01.html: Added.
  • web-platform-tests/css/css-fonts/size-adjust-02-expected.html: Added.
  • web-platform-tests/css/css-fonts/size-adjust-02.html: Added.
  • web-platform-tests/css/css-fonts/size-adjust-text-decoration.tentative-expected.html: Added.
  • web-platform-tests/css/css-fonts/size-adjust-text-decoration.tentative.html: Added.
  • web-platform-tests/css/css-fonts/size-adjust.tentative-expected.html: Added.
  • web-platform-tests/css/css-fonts/size-adjust.tentative.html: Added.
  • web-platform-tests/css/css-fonts/support/fonts/Lato-Medium-Liga.ttf: Added.
  • web-platform-tests/css/css-fonts/support/fonts/w3c-import.log:
  • web-platform-tests/css/css-fonts/variations/at-font-face-font-matching.html:
  • web-platform-tests/css/css-fonts/variations/font-parse-numeric-stretch-style-weight.html:
  • web-platform-tests/css/css-fonts/variations/font-variation-settings-parsing-expected.txt: Removed.
  • web-platform-tests/css/css-fonts/variations/font-variation-settings-parsing.html: Removed.
  • web-platform-tests/css/css-fonts/variations/variable-opsz-size-adjust-expected.html: Added.
  • web-platform-tests/css/css-fonts/variations/variable-opsz-size-adjust.html: Added.
  • web-platform-tests/css/css-fonts/variations/w3c-import.log:
  • web-platform-tests/css/css-fonts/w3c-import.log:

LayoutTests:

  • TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt:
8:30 AM Changeset in webkit [277090] by Adrian Perez de Castro
  • 3 edits in releases/WebKitGTK/webkit-2.32/Source/WebCore

Merge r277088 - [GStreamer] Fallback to texture mapper video orientation handling when glvideoflip is not available
​https://bugs.webkit.org/show_bug.cgi?id=225454

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-06
Reviewed by Xabier Rodriguez-Calvar.

r275412 introduced a new runtime dependency on gst-plugins-good's glvideoflip element, which
is not desirable for the 2.32 branch. This patch let's the player handle rotation tags if
the glvideoflip element wasn't found at runtime. Ideally we should probably not rely on
glvideoflip in the first place as it might induce a performance impact, to be handled in a
follow-up patch.

  • platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:

(webKitGLVideoSinkConstructed):
(webKitGLVideoSinkGetProperty):
(webkit_gl_video_sink_class_init):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createVideoSinkGL):

8:24 AM Changeset in webkit [277089] by Sam Sneddon
  • 5 edits in trunk/Tools

mark all SCM tests using SVN as slow, a couple as xfail; enable SCM
​https://bugs.webkit.org/show_bug.cgi?id=225156

Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SVNTest): Mark all tests with @slow
(GitSVNTest): Mark all tests with @slow

  • Scripts/webkitpy/conftest.py:

(pytest_configure): Define the "slow" marker
(pytest_addoption): Add --run-slow to opt-in
(pytest_collection_modifyitems): Implement --run-slow

  • Scripts/webkitpy/pytest.ini: remove "not scm_unitest"
  • Scripts/webkitpy/test/markers.py:

(slow): add our own wrapper around the pytest mark function

8:06 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
8:04 AM Changeset in webkit [277088] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] Fallback to texture mapper video orientation handling when glvideoflip is not available
​https://bugs.webkit.org/show_bug.cgi?id=225454

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-06
Reviewed by Xabier Rodriguez-Calvar.

r275412 introduced a new runtime dependency on gst-plugins-good's glvideoflip element, which
is not desirable for the 2.32 branch. This patch let's the player handle rotation tags if
the glvideoflip element wasn't found at runtime. Ideally we should probably not rely on
glvideoflip in the first place as it might induce a performance impact, to be handled in a
follow-up patch.

  • platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:

(webKitGLVideoSinkConstructed):
(webKitGLVideoSinkGetProperty):
(webkit_gl_video_sink_class_init):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createVideoSinkGL):

7:52 AM Changeset in webkit [277087] by Chris Dumez
  • 6 edits in trunk

imported/w3c/web-platform-tests/eventsource/format-utf-8.htm is failing on some platforms
​https://bugs.webkit.org/show_bug.cgi?id=225416
<rdar://77529801>

Reviewed by Youenn Fablet.

Source/WebCore:

The HTML specification [1] states that EventSource streams should always be decoded as UTF-8.
However, we had logic in WebKit that was checking the charset of the response and aborting
when the charset is not UTF-8. It looks like we were lucky until now that we would fail to
determine the charset of the response and proceed anyway. However, due to underlying system
changes, in the context of this test, we are now properly detecting the response charset as
"windows-1252" and (incorrectly) aborting. To address the issue, I no longer abort the
connection if the charset is not "utf-8". We do still log a console warning but we proceed
decoding the stream as UTF-8 no matter the response's charset, as per the specification.

[1] ​https://html.spec.whatwg.org/multipage/server-sent-events.html#event-stream-interpretation

No new tests, covered by existing test that is failing on some platforms.

  • page/EventSource.cpp:

(WebCore::EventSource::responseIsValid const):

LayoutTests:

Dump JS Console messages to stderr for this test as it will only get logged on some
platforms.

7:51 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
6:59 AM Changeset in webkit [277086] by ntim@apple.com
  • 66 edits
    7 copies
    29 adds in trunk/LayoutTests

Re-import css/css-flexbox WPT
​https://bugs.webkit.org/show_bug.cgi?id=225450

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-flexbox/align-items-baseline-overflow-non-visible-expected.html:
  • web-platform-tests/css/css-flexbox/align-items-baseline-overflow-non-visible.html:
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-001.html: Added.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-002.html: Added.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-003.html: Added.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-004.html: Added.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-005-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-005.html: Added.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-006-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-006.html: Added.
  • web-platform-tests/css/css-flexbox/flex-item-compressible-001.html:
  • web-platform-tests/css/css-flexbox/flex-item-compressible-002.html:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-baseline-horiz-001a-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-baseline-horiz-001b-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-baseline-horiz-006-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-baseline-horiz-007-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-baseline-horiz-008-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-horiz-001-block-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-horiz-001-table-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-horiz-002-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-horiz-003-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-horiz-004-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-align-self-baseline-horiz-001-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-align-self-baseline-vert-001-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-horiz-001a-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-horiz-001a.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-horiz-001b-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-horiz-001b.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-vert-001a-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-vert-001a.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-vert-001b-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-item-vert-001b.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-horiz-001-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-horiz-001.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-horiz-002-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-horiz-002.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-vert-001-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-vert-001.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-vert-002-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-vert-002.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-003a-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-003a.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-003b-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-003b.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-004a-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-004a.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-004b-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-004b.html:
  • web-platform-tests/css/css-flexbox/flexbox-items-as-stacking-contexts-002-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-items-as-stacking-contexts-002.html:
  • web-platform-tests/css/css-flexbox/flexbox-items-as-stacking-contexts-003-expected.html:
  • web-platform-tests/css/css-flexbox/flexbox-items-as-stacking-contexts-003.html:
  • web-platform-tests/css/css-flexbox/flexbox-justify-content-horiz-002-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-justify-content-vert-002-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-mbp-horiz-004-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-mbp-horiz-004.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-overflow-padding-001-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/flexbox-overflow-padding-001.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox-overflow-padding-002-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/flexbox-overflow-padding-002.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox-paint-ordering-002-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-paint-ordering-002.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-table-fixup-001-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox_align-items-center-3-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html.
  • web-platform-tests/css/css-flexbox/flexbox_align-items-center-3.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-left-001-expected.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-left-001.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-left-002-expected.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-left-002.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-right-001-expected.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-right-001.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-right-002-expected.html: Added.
  • web-platform-tests/css/css-flexbox/flexbox_justifycontent-right-002.html: Added.
  • web-platform-tests/css/css-flexbox/negative-overflow-expected.txt:
  • web-platform-tests/css/css-flexbox/negative-overflow.html:
  • web-platform-tests/css/css-flexbox/overflow-auto-005-expected.html:
  • web-platform-tests/css/css-flexbox/overflow-auto-005.html:
  • web-platform-tests/css/css-flexbox/overflow-top-left-expected.html:
  • web-platform-tests/css/css-flexbox/padding-overflow-crash-expected.html:
  • web-platform-tests/css/css-flexbox/padding-overflow-crash.html:
  • web-platform-tests/css/css-flexbox/select-element-zero-height-001-expected.html:
  • web-platform-tests/css/css-flexbox/select-element-zero-height-001.html:
  • web-platform-tests/css/css-flexbox/table-as-item-min-content-height-1.tentative-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-min-content-height-1.tentative.html: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-min-content-height-2.tentative-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-min-content-height-2.tentative.html: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-min-height-1-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-min-height-1.html: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-3.html:
  • web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-4-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-4.html: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-5-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-5.html: Added.
  • web-platform-tests/css/css-flexbox/w3c-import.log:

LayoutTests:

6:27 AM Changeset in webkit [277085] by ntim@apple.com
  • 5 edits
    14 adds in trunk/LayoutTests

Re-import css/css-display WPT
​https://bugs.webkit.org/show_bug.cgi?id=225448

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-display/display-contents-dynamic-fieldset-legend-001-expected.html: Added.
  • web-platform-tests/css/css-display/display-contents-dynamic-fieldset-legend-001.html: Added.
  • web-platform-tests/css/css-display/display-contents-fieldset-002-expected.html: Added.
  • web-platform-tests/css/css-display/display-contents-fieldset-002.html: Added.
  • web-platform-tests/css/css-display/display-contents-slot-attach-whitespace-expected.html: Added.
  • web-platform-tests/css/css-display/display-contents-slot-attach-whitespace.html: Added.
  • web-platform-tests/css/css-display/display-first-line-001.html:
  • web-platform-tests/css/css-display/display-math-on-non-mathml-elements-expected.txt: Added.
  • web-platform-tests/css/css-display/display-math-on-non-mathml-elements.html: Added.
  • web-platform-tests/css/css-display/display-math-on-pseudo-elements-001-expected.txt: Added.
  • web-platform-tests/css/css-display/display-math-on-pseudo-elements-001.html: Added.
  • web-platform-tests/css/css-display/display-math-on-pseudo-elements-002-expected.html: Added.
  • web-platform-tests/css/css-display/display-math-on-pseudo-elements-002.html: Added.
  • web-platform-tests/css/css-display/textarea-display-expected.txt: Added.
  • web-platform-tests/css/css-display/textarea-display.html: Added.
  • web-platform-tests/css/css-display/w3c-import.log:

LayoutTests:

5:58 AM Changeset in webkit [277084] by ntim@apple.com
  • 8 edits
    7 adds in trunk/LayoutTests

Re-import css/css-contain WPT
​https://bugs.webkit.org/show_bug.cgi?id=225445

Reviewed by Rob Buis.

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-contain/content-visibility/animation-display-lock-expected.txt: Added.
  • web-platform-tests/css/css-contain/content-visibility/animation-display-lock.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-035.html:
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-044-expected.txt:
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-044.html:
  • web-platform-tests/css/css-contain/content-visibility/content-visibility-continuations-crash.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/element-reassigned-to-skipped-slot-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/element-reassigned-to-skipped-slot.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree-expected.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html: Added.
  • web-platform-tests/css/css-contain/content-visibility/w3c-import.log:

LayoutTests:

5:11 AM Changeset in webkit [277083] by Martin Robinson
  • 15 edits in trunk/Source

[css-scroll-snap] Compute proximity information while snapping
​https://bugs.webkit.org/show_bug.cgi?id=224326

Reviewed by Simon Fraser.

Source/WebCore:

Have ScrollSnapOffsetsInfo carry snap area rectangles instead of scroll offset
ranges. This allows proximity information to be handled during snap point selection.
The geometry will be used in a future patch to follow spec behavior for snap
areas that overflow the snapport and when handling masonry layouts.

No new tests. This is just a refactor. It should not change behavior at all.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::setStateScrollingNodeSnapOffsetsAsFloat): Pass in the new template argument.

  • page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::isNearEnoughToOffsetForProximity): Added.
(WebCore::closestSnapOffsetWithInfoAndAxis): Modified to take in the ScrollSnapOffsetsInfo data
structure and axis along with the viewport size. This function now explicitly determines if a
snap point is too far away to affect scrolling due to scroll-snap proximity.
(WebCore::updateSnapOffsetsForScrollableArea): Add snap areas and snap area indices to SnapOffset.
(WebCore::convertOffsetInfo): Instead of converting scroll offset ranges, convert the snap
area rectangles.
(WebCore::FloatScrollSnapOffsetsInfo::convertUnits const): Ditto.
(WebCore::LayoutScrollSnapOffsetsInfo::convertUnits const): Ditto.
(WebCore::LayoutScrollSnapOffsetsInfo::closestSnapOffset const): Updated to reflect new
internal function.
(WebCore::FloatScrollSnapOffsetsInfo::closestSnapOffset const): Ditto.

  • page/scrolling/ScrollSnapOffsetsInfo.h:

(WebCore::ScrollSnapOffsetsInfo::isEqual const): Update to reflect new mem ers.
(WebCore::ScrollSnapOffsetsInfo::offsetsForAxis const): Changed template parameter name.

  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode): ::convertUnits
takes a new template parameter.

  • page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:

(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::handleWheelEvent): Pass in viewport size.

  • platform/ScrollController.cpp:

(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Ditto.
(WebCore::ScrollController::adjustScrollDestination): Ditto.

  • platform/ScrollSnapAnimatorState.cpp:

(WebCore::ScrollSnapAnimatorState::setupAnimationForState): Ditto.
(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset const): Ditto.
(WebCore::operator<<): No longer print snap offset ranges.

  • platform/ScrollSnapAnimatorState.h: Remove references to snap offset ranges.

Source/WebKit:

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<SnapOffset<float>>::encode): Add the snap area index to the encoded arguments.
(ArgumentCoder<SnapOffset<float>>::decode): Add the snap area index to the decoded arguments.
(ArgumentCoder<FloatScrollSnapOffsetsInfo>::encode): No longer encode ranges, but encode snap areas.
(ArgumentCoder<FloatScrollSnapOffsetsInfo>::decode): Ditto for decode.

  • Shared/WebCoreArgumentCoders.cpp: Remove code dealing with scroll offset ranges.
  • Shared/WebCoreArgumentCoders.h: Ditto.
  • UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling const): Pass
in viewport size to closestSnapOffset which is necessary for calculating proximity.

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Ditto.

5:07 AM Changeset in webkit [277082] by aboya@igalia.com
  • 2 edits in trunk/LayoutTests

[EME][GStreamer] Unreviewed micro-gardening
​https://bugs.webkit.org/show_bug.cgi?id=225422

This test was fixed by the WebKitMediaSrc rework in r277031,
rebaselined it.

  • platform/glib/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https-expected.txt:
4:25 AM Changeset in webkit [277081] by ntim@apple.com
  • 4 edits
    2 moves
    50 adds
    4 deletes in trunk/LayoutTests

Re-import css/css-will-change WPTs
​https://bugs.webkit.org/show_bug.cgi?id=225444

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-will-change/w3c-import.log:
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-contain-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-contain-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-filter-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-filter-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-height-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-height-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-offset-path-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-offset-path-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-perspective-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-perspective-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-position-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-position-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-transform-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-transform-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-transform-style-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-transform-style-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-translate-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-fixpos-cb-translate-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-001-expected.html: Removed.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-001.html: Removed.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-002-expected.html: Removed.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-003-expected.html: Removed.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-backdrop-filter-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-backdrop-filter-1.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-will-change/will-change-stacking-context-002.html.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-clip-path-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-clip-path-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-filter-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-filter-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-height-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-height-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-isolation-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-isolation-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-mask-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-mask-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-mix-blend-mode-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-mix-blend-mode-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-offset-path-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-offset-path-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-opacity-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-opacity-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-opacity-2-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-opacity-2.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-will-change/will-change-stacking-context-003.html.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-perspective-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-perspective-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-position-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-position-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-transform-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-transform-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-transform-style-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-transform-style-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-translate-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-translate-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-z-index-1-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-stacking-context-z-index-1.html: Added.
  • web-platform-tests/css/css-will-change/will-change-transform-huge-offset-scrolled-expected.html: Added.
  • web-platform-tests/css/css-will-change/will-change-transform-huge-offset-scrolled.html: Added.

LayoutTests:

4:11 AM Changeset in webkit [277080] by Philippe Normand
  • 9 edits in trunk

REGRESSION(r271341): media/media-fullscreen-inline.html times out on GTK
​https://bugs.webkit.org/show_bug.cgi?id=220540

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

When the GStreamer player client is an <audio> tag it won't render any video, but setting no
explicit video sink on playbin will not prevent video rendering per-se. In that situation
playbin will use autovideosink which will end-up creating a standalone window through
glimagesink or whatever has the highest rank. For now with playbin2 we can use fakevideosink
for such situation. For the playbin3 case we might be able to entirely deactivate video
rendering through stream selection.

Internals::isChangingPresentationMode was enabled for ports not implementing
VIDEO_PRESENTATION_MODE yet, because this test makes use of it.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::createVideoSink):

  • testing/Internals.cpp:

(WebCore::Internals::isChangingPresentationMode const):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Call webkitExitFullScreen() asynchronously to give time to the WebCore FullscreenManager to
notify the video element that it entered full-screen, and thus allowing the exitFullScreen()
call to go through.

  • media/media-fullscreen.js:

(fullscreenchange):
(async beginfullscreen):

  • platform/glib/TestExpectations:
  • platform/glib/media/media-fullscreen-inline-expected.txt:
3:55 AM Changeset in webkit [277079] by ntim@apple.com
  • 5 edits in trunk/LayoutTests/imported/w3c

Re-import css/css-counter-styles WPT

Unreviewed. Trivial WPT re-import.

  • web-platform-tests/css/css-counter-styles/counter-style-additive-symbols-syntax-expected.txt:
  • web-platform-tests/css/css-counter-styles/counter-style-additive-symbols-syntax.html:
  • web-platform-tests/css/css-counter-styles/counter-style-pad-syntax-expected.txt:
  • web-platform-tests/css/css-counter-styles/counter-style-pad-syntax.html:
3:35 AM Changeset in webkit [277078] by rniwa@webkit.org
  • 16 edits in trunk/Source/WebCore

Replace raw pointers in SVGElementRareData and SVGDocumentExtensions with WeakHashMap and WeakPtr
​https://bugs.webkit.org/show_bug.cgi?id=225440

Reviewed by Antti Koivisto.

Replaced the remaining use of raw pointers to Element in SVGElementRareData and SVGDocumentExtensions
with WeakHashSet and WeakPtr.

This patch also replaces SVGDocumentExtensions::m_elementDependencies with a new WeakHashMap
in SVGElementRareData for clarify & simplicity with a new terminology. When a SVG element A refers
to another element B via href, A's SVGElementRareData::m_referenceTarget is set to B, and A is added
to B's SVGElementRareData::m_referencingElements.

No new tests since there should be no observable behavior differences.

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::applyResultsToTarget):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources const):
(WebCore::SVGDocumentExtensions::isPendingResource const): Directly check the existence of
the id in m_pendingResources instead of calling isIdOfPendingResource.
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResource): Moved to the header to be inlined.
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval): Deleted. The code is
inlined in removeElementFromPendingResources instead.
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
(WebCore::SVGDocumentExtensions::takeElementFromPendingResourcesForRemovalMap): Renamed
from removeElementFromPendingResourcesForRemovalMap.
(WebCore::SVGDocumentExtensions::addElementToRebuild): Added.
(WebCore::SVGDocumentExtensions::removeElementToRebuild): Added.
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget): Deleted.
(WebCore::SVGDocumentExtensions::addElementReferencingTarget): Deleted.
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): Deleted.
(WebCore::SVGDocumentExtensions::clearTargetDependencies):
(WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget): Deleted.

  • svg/SVGDocumentExtensions.h:

(WebCore::SVGDocumentExtensions::removePendingResource):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFromAncestor): Moved the most of logic in SVGDocumentExtensions's
clearTargetDependencies and removeAllElementReferencesForTarget here.
(WebCore::SVGElement::instances const):
(WebCore::SVGElement::referencingElements const): Added.
(WebCore::SVGElement::addReferencingElement): Added.
(WebCore::SVGElement::removeReferencingElement): Added.
(WebCore::SVGElement::removeElementReference): Added.
(WebCore::SVGElement::setCorrespondingElement):
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
(WebCore::SVGElement::createAnimator):
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
(WebCore::SVGElement::updateRelativeLengthsInformation):
(WebCore::SVGElement::invalidateInstances):
(WebCore:: const): Deleted.

  • svg/SVGElement.h:

(WebCore::SVGElement::hasRelativeLengths const):
(WebCore::SVGElement::updateRelativeLengthsInformation):

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::addInstance):
(WebCore::SVGElementRareData::removeInstance):
(WebCore::SVGElementRareData::instances const):
(WebCore::SVGElementRareData::addReferencingElement):
(WebCore::SVGElementRareData::removeReferencingElement):
(WebCore::SVGElementRareData::referencingElements const):
(WebCore::SVGElementRareData::takeReferencingElements):
(WebCore::SVGElementRareData::referenceTarget const):
(WebCore::SVGElementRareData::setReferenceTarget):
(WebCore::SVGElementRareData::correspondingElement):
(WebCore::SVGElementRareData::setCorrespondingElement):
(): Deleted.
(WebCore::SVGElementRareData:: const): Deleted.

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::clearResourceReferences):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::clearResourceReferences):
(WebCore::SVGTextPathElement::buildPendingResource):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::invalidateDependentShadowTrees):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::clearResourceReferences):
(WebCore::SVGSMILElement::buildPendingResource):

  • svg/properties/SVGAttributeAnimator.cpp:

(WebCore::SVGAttributeAnimator::applyAnimatedStylePropertyChange):
(WebCore::SVGAttributeAnimator::removeAnimatedStyleProperty):
(WebCore::SVGAttributeAnimator::applyAnimatedPropertyChange):

2:44 AM Changeset in webkit [277077] by ntim@apple.com
  • 9 edits
    7 adds
    4 deletes in trunk/LayoutTests

Re-import css/css-color & css/css-color-adjust WPT
​https://bugs.webkit.org/show_bug.cgi?id=225438

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-color-adjust/META.yml: Added.
  • web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-opaque-cross-origin.sub-expected.html: Added.
  • web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-opaque-cross-origin.sub.html: Added.
  • web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-system-colors-expected.txt: Added.
  • web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-system-colors.html: Added.
  • web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/w3c-import.log:
  • web-platform-tests/css/css-color-adjust/w3c-import.log:
  • web-platform-tests/css/css-color/color-function-parsing.html:
  • web-platform-tests/css/css-color/color-function-parsing-expected.txt:
  • web-platform-tests/css/css-color/color-mix-basic-001.tentative-expected.txt: Added.
  • web-platform-tests/css/css-color/color-mix-basic-001.tentative.html: Added.
  • web-platform-tests/css/css-color/predefined-014-expected.html: Removed.
  • web-platform-tests/css/css-color/predefined-014.html: Removed.
  • web-platform-tests/css/css-color/predefined-015-expected.html: Removed.
  • web-platform-tests/css/css-color/predefined-015.html: Removed.
  • web-platform-tests/css/css-color/w3c-import.log:

LayoutTests:

2:17 AM Changeset in webkit [277076] by ntim@apple.com
  • 6 edits
    14 adds in trunk/LayoutTests/imported/w3c

Re-import css/css-cascade WPT
​https://bugs.webkit.org/show_bug.cgi?id=225437

Reviewed by Youenn Fablet.

  • web-platform-tests/css/css-cascade/all-prop-001-expected.html:
  • web-platform-tests/css/css-cascade/all-prop-001.html:
  • web-platform-tests/css/css-cascade/all-prop-revert-visited-expected.html: Added.
  • web-platform-tests/css/css-cascade/all-prop-revert-visited.html: Added.
  • web-platform-tests/css/css-cascade/all-prop-unset-visited-expected.html: Added.
  • web-platform-tests/css/css-cascade/all-prop-unset-visited.html: Added.
  • web-platform-tests/css/css-cascade/import-conditional-001-expected.xht: Added.
  • web-platform-tests/css/css-cascade/import-conditional-001.html: Added.
  • web-platform-tests/css/css-cascade/important-prop.html:
  • web-platform-tests/css/css-cascade/initial-background-color-expected.html: Added.
  • web-platform-tests/css/css-cascade/initial-background-color.html: Added.
  • web-platform-tests/css/css-cascade/support/test-green.css: Added.

(.test):

  • web-platform-tests/css/css-cascade/support/test-red.css: Added.

(.test):

  • web-platform-tests/css/css-cascade/support/w3c-import.log: Added.
  • web-platform-tests/css/css-cascade/unset-val-001.html:
  • web-platform-tests/css/css-cascade/unset-value-storage.html: Added.
  • web-platform-tests/css/css-cascade/unset-value-storage-expected.txt: Added.
  • web-platform-tests/css/css-cascade/w3c-import.log:
1:52 AM Changeset in webkit [277075] by Cameron McCormack
  • 3 edits in trunk/Source/WebCore

Split context state change item appending out of DisplayList::Recorder::canAppendItemOfType.
​https://bugs.webkit.org/show_bug.cgi?id=225424

Reviewed by Simon Fraser.

It's non-obvious from the name that canAppendItemOfType can also end
up appending an item. So let's split out the context state change
item out into a separate function.

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::canAppendItemOfType):
(WebCore::DisplayList::Recorder::appendStateChangeItemIfNecessary):
Added.

  • platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::append):
(WebCore::DisplayList::Recorder::itemNeedsState): Added this as a
constexpr helper function, to ensure we make a decision about needing
to call appendStateChangeItemIfNecessary at compile time.

1:40 AM Changeset in webkit [277074] by ntim@apple.com
  • 1 edit
    39 adds in trunk/LayoutTests/imported/w3c

Re-sync css/css-break WPTs
​https://bugs.webkit.org/show_bug.cgi?id=225436

Reviewed by Youenn Fablet.

  • web-platform-tests/css/css-break/animation/w3c-import.log: Added.
  • web-platform-tests/css/css-break/parsing/box-decoration-break-computed-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/box-decoration-break-computed.html: Added.
  • web-platform-tests/css/css-break/parsing/box-decoration-break-invalid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/box-decoration-break-invalid.html: Added.
  • web-platform-tests/css/css-break/parsing/box-decoration-break-valid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/box-decoration-break-valid.html: Added.
  • web-platform-tests/css/css-break/parsing/break-after-computed-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-after-computed.html: Added.
  • web-platform-tests/css/css-break/parsing/break-after-invalid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-after-invalid.html: Added.
  • web-platform-tests/css/css-break/parsing/break-after-valid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-after-valid.html: Added.
  • web-platform-tests/css/css-break/parsing/break-before-computed-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-before-computed.html: Added.
  • web-platform-tests/css/css-break/parsing/break-before-invalid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-before-invalid.html: Added.
  • web-platform-tests/css/css-break/parsing/break-before-valid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-before-valid.html: Added.
  • web-platform-tests/css/css-break/parsing/break-inside-computed-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-inside-computed.html: Added.
  • web-platform-tests/css/css-break/parsing/break-inside-invalid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-inside-invalid.html: Added.
  • web-platform-tests/css/css-break/parsing/break-inside-valid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/break-inside-valid.html: Added.
  • web-platform-tests/css/css-break/parsing/orphans-computed-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/orphans-computed.html: Added.
  • web-platform-tests/css/css-break/parsing/orphans-invalid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/orphans-invalid.html: Added.
  • web-platform-tests/css/css-break/parsing/orphans-valid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/orphans-valid.html: Added.
  • web-platform-tests/css/css-break/parsing/w3c-import.log: Added.
  • web-platform-tests/css/css-break/parsing/widows-computed-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/widows-computed.html: Added.
  • web-platform-tests/css/css-break/parsing/widows-invalid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/widows-invalid.html: Added.
  • web-platform-tests/css/css-break/parsing/widows-valid-expected.txt: Added.
  • web-platform-tests/css/css-break/parsing/widows-valid.html: Added.
1:38 AM Changeset in webkit [277073] by ntim@apple.com
  • 33 edits
    223 adds
    3 deletes in trunk/LayoutTests

Re-import css/css-backgrounds WPTs
​https://bugs.webkit.org/show_bug.cgi?id=225408

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-element-not-visible-at-current-viewport-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-element-not-visible-at-current-viewport.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-additive-keyframe-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-additive-keyframe.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-0-percent-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-0-percent.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-100-percent-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-100-percent.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-replace-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-replace.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fragmented-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-fragmented.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-in-body-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-in-body.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-non-zero-size-element-change-to-zero-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-non-zero-size-element-change-to-zero.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-single-keyframe-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-single-keyframe.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-three-keyframes1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-three-keyframes1.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-three-keyframes2-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-three-keyframes2.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-three-keyframes3-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-three-keyframes3.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-images-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-images.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table1.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table2-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table2.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table3-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table3.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table4-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-table4.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-zero-playbackRate-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-with-zero-playbackRate.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-zero-size-element-change-to-non-zero-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-zero-size-element-change-to-non-zero.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-zero-size-element-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation-zero-size-element.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-animation.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-transition-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-transition.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-transparent-animation-in-body-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/background-color-transparent-animation-in-body.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-animation-with-zero-alpha-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-animation-with-zero-alpha.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-transition-obscured-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-transition-obscured.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-transition-with-delay-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-transition-with-delay.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-transition-with-initially-transparent-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/background-color-transition-with-initially-transparent.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/invalidation/w3c-import.log: Added.
  • web-platform-tests/css/css-backgrounds/animations/two-background-color-animation-diff-length1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/two-background-color-animation-diff-length1.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/two-background-color-animation-diff-length2-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/two-background-color-animation-diff-length2.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/two-background-color-animation-diff-length3-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/two-background-color-animation-diff-length3.html: Added.
  • web-platform-tests/css/css-backgrounds/animations/w3c-import.log:
  • web-platform-tests/css/css-backgrounds/background-attachment-350.html:
  • web-platform-tests/css/css-backgrounds/background-attachment-353-expected.xht: Added.
  • web-platform-tests/css/css-backgrounds/background-attachment-353.html: Added.
  • web-platform-tests/css/css-backgrounds/background-attachment-fixed-inside-transform-1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-attachment-fixed-inside-transform-1.html: Added.
  • web-platform-tests/css/css-backgrounds/background-attachment-local/attachment-local-clipping-color-5.html:
  • web-platform-tests/css/css-backgrounds/background-attachment-local/attachment-local-clipping-image-5.html:
  • web-platform-tests/css/css-backgrounds/background-clip-content-box-002-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-clip-content-box-002.html: Added.
  • web-platform-tests/css/css-backgrounds/background-margin-iframe-root.html:
  • web-platform-tests/css/css-backgrounds/background-margin-root.html:
  • web-platform-tests/css/css-backgrounds/background-margin-transformed-root.html:
  • web-platform-tests/css/css-backgrounds/background-margin-will-change-root.html:
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1a-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1a.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1b-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1b.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1c-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1c.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1d-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1d.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1e-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-1e.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-2-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-2.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-3-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-3.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-4-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-round-4.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-10-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-10.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-1a-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-1a.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-1b-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-1b.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-1c-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-1c.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-2-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-2.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-3-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-3.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-4-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-4.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-5-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-5.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-6-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-6.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-7-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-7.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-8-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-8.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-9-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-repeat-space-9.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-006.html:
  • web-platform-tests/css/css-backgrounds/background-size-009.html:
  • web-platform-tests/css/css-backgrounds/background-size-014.html:
  • web-platform-tests/css/css-backgrounds/background-size-017.html:
  • web-platform-tests/css/css-backgrounds/background-size-041-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-041.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-042-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-042.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-043-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-043.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-044-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-044.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-percentage-root-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-size-percentage-root.html: Added.
  • web-platform-tests/css/css-backgrounds/bg-color-with-gradient-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/bg-color-with-gradient.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-displayed-with-transparent-border-color-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-displayed-with-transparent-border-color.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-image-type-003.htm:
  • web-platform-tests/css/css-backgrounds/border-image-repeat-1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-1.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-round-1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-round-1.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-round-2-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-round-2.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-1.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-2-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-2.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-3-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-3.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-4-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-4-ref-1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-4-ref-1.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-4.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-5-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-5-ref-1-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-5-ref-1.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-5.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-6-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-6.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-7-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-repeat-space-7.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-shorthand-002-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-shorthand-002.htm:
  • web-platform-tests/css/css-backgrounds/border-image-shorthand-003-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-shorthand-003.htm:
  • web-platform-tests/css/css-backgrounds/border-image-slice-005-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-slice-005.htm:
  • web-platform-tests/css/css-backgrounds/border-image-slice-007-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-image-slice-007.htm:
  • web-platform-tests/css/css-backgrounds/border-radius-012-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-radius-012.html: Added.
  • web-platform-tests/css/css-backgrounds/border-radius-clip-001-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-radius-clip-001.htm: Removed.
  • web-platform-tests/css/css-backgrounds/border-radius-clip-001.html: Added.
  • web-platform-tests/css/css-backgrounds/border-radius-clip-002-expected.htm: Added.
  • web-platform-tests/css/css-backgrounds/border-radius-clip-002.htm:
  • web-platform-tests/css/css-backgrounds/border-radius-clipping-002-expected.xht: Added.
  • web-platform-tests/css/css-backgrounds/border-radius-clipping-002.html: Added.
  • web-platform-tests/css/css-backgrounds/border-radius-clipping-expected.html: Removed.
  • web-platform-tests/css/css-backgrounds/border-radius-clipping.html: Removed.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-a-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-a.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-b-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-b.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-c-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-c.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-d-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-d.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-e-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/border-width-small-values-001-e.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-029-expected.xht: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-029.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-039-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-039.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-040-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-040.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-041-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-041.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-042-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-042.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-currentcolor-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-currentcolor.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-001-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-001.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-002-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-002.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-003-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-003.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-004-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-overlapping-004.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-radius-000-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-radius-000.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-radius-001-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/box-shadow-radius-001.html: Added.
  • web-platform-tests/css/css-backgrounds/css3-border-image-repeat-repeat-expected.html:
  • web-platform-tests/css/css-backgrounds/css3-border-image-repeat-repeat.html:
  • web-platform-tests/css/css-backgrounds/css3-border-image-repeat-stretch-expected.html:
  • web-platform-tests/css/css-backgrounds/css3-border-image-repeat-stretch.html:
  • web-platform-tests/css/css-backgrounds/hidpi/simple-bg-color-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/hidpi/simple-bg-color.html: Added.
  • web-platform-tests/css/css-backgrounds/hidpi/w3c-import.log: Added.
  • web-platform-tests/css/css-backgrounds/inline-background-rtl-001-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/inline-background-rtl-001.html: Added.
  • web-platform-tests/css/css-backgrounds/linear-gradient-calc-crash.html: Added.
  • web-platform-tests/css/css-backgrounds/linear-gradient-currentcolor-first-line-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/linear-gradient-currentcolor-first-line.html: Added.
  • web-platform-tests/css/css-backgrounds/parsing/background-image-invalid-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-image-invalid.html:
  • web-platform-tests/css/css-backgrounds/parsing/background-image-valid-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-image-valid.html:
  • web-platform-tests/css/css-backgrounds/simple-bg-color-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/simple-bg-color.html: Added.
  • web-platform-tests/css/css-backgrounds/support/100x100-gr-rr.png: Added.
  • web-platform-tests/css/css-backgrounds/support/100x100-green-with-red-corners.png: Added.
  • web-platform-tests/css/css-backgrounds/support/9grid40-30-20-10-green.png: Added.
  • web-platform-tests/css/css-backgrounds/support/9grid40-30-20-10-red-old.png: Added.
  • web-platform-tests/css/css-backgrounds/support/9grid40-30-20-10-red.png: Added.
  • web-platform-tests/css/css-backgrounds/support/aqua-yellow-32x32.png: Added.
  • web-platform-tests/css/css-backgrounds/support/aqua-yellow-37x37.png: Added.
  • web-platform-tests/css/css-backgrounds/support/blue-diamond-27x27.png: Added.
  • web-platform-tests/css/css-backgrounds/support/new-red-diamond-27x27.png: Added.
  • web-platform-tests/css/css-backgrounds/support/orange-intrinsic-none.svg: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-bl.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-bo.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-br.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-ct.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-le.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-ri.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-tl.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-to.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule-tr.png: Added.
  • web-platform-tests/css/css-backgrounds/support/reticule.png: Added.
  • web-platform-tests/css/css-backgrounds/support/w3c-import.log:
  • web-platform-tests/css/css-backgrounds/support/y.png: Added.
  • web-platform-tests/css/css-backgrounds/w3c-import.log:

LayoutTests:

12:45 AM Changeset in webkit [277072] by Cameron McCormack
  • 3 edits in trunk/Source/WebCore

Make DisplayList::dump print out the display list contents
​https://bugs.webkit.org/show_bug.cgi?id=225431

Reviewed by Simon Fraser.

  • platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::description const):
(WebCore::DisplayList::operator<<): This needs to move so that
argument-dependent lookup for the operator<< call in description()
works.

  • platform/graphics/displaylists/DisplayList.h:
12:36 AM Changeset in webkit [277071] by ntim@apple.com
  • 13 edits
    4 adds in trunk

[mediaqueries] Remove "on-demand" value for any-hover/hover & "forced" value for prefers-contrast
​https://bugs.webkit.org/show_bug.cgi?id=225400

Reviewed by Antti Koivisto.

These were both removed from the spec and currently never evaluate to true. They also won't eval to true after this change.
Only change is serialization, since the values will become invalid.

Also:

  • Re-synced css/mediaqueries WPTs
  • Adjusted any-hover/hover parsing tests accordingly.

LayoutTests/imported/w3c:

  • web-platform-tests/css/mediaqueries/mq-dynamic-empty-children-expected.txt: Added.
  • web-platform-tests/css/mediaqueries/mq-dynamic-empty-children.html: Added.
  • web-platform-tests/css/mediaqueries/prefers-contrast-expected.txt: Added.
  • web-platform-tests/css/mediaqueries/prefers-contrast.html: Added.
  • web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
  • web-platform-tests/css/mediaqueries/test_media_queries.html:
  • web-platform-tests/css/mediaqueries/w3c-import.log:

Source/WebCore:

  • css/CSSValueKeywords.in:
  • css/MediaQueryEvaluator.cpp:

(WebCore::prefersContrastEvaluate):

  • css/MediaQueryExpression.cpp:

(WebCore::isValidValueForIdentMediaFeature):

LayoutTests:

  • fast/media/mq-any-hover-cssom.html:
  • fast/media/mq-any-hover-cssom-expected.txt:
  • fast/media/mq-hover-cssom.html:
  • fast/media/mq-hover-cssom-expected.txt:
12:14 AM Changeset in webkit [277070] by ntim@apple.com
  • 3 edits in trunk/LayoutTests/imported/w3c

Re-sync css/css-box/parsing/padding-valid.html WPT

Unreviewed. Trivial WPT sync on one single test.

  • web-platform-tests/css/css-box/parsing/padding-valid-expected.txt:
  • web-platform-tests/css/css-box/parsing/padding-valid.html:

May 5, 2021:

11:43 PM Changeset in webkit [277069] by Megan Gardner
  • 11 edits in trunk/Source/WebCore

AppHighlight scrolls should be smooth
​https://bugs.webkit.org/show_bug.cgi?id=225395

Reviewed by Simon Fraser.

Leverage smooth scrolling experimental feature to allow AppHighlight scrolls
to be smooth.

  • Modules/highlight/AppHighlightStorage.cpp:

(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):

  • editing/Editor.cpp:

(WebCore::TemporarySelectionChange::setSelection):

  • editing/Editor.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::revealSelection):

  • editing/FrameSelection.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollTo const):

  • page/ScrollBehavior.cpp:

(WebCore::useSmoothScrolling):

  • platform/ScrollTypes.h:
8:37 PM Changeset in webkit [277068] by mark.lam@apple.com
  • 15 edits in trunk/Source

Introduce VM::hasPendingTerminationException() to make code a little more terse.
​https://bugs.webkit.org/show_bug.cgi?id=225412

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This is purely a refactoring patch. There is no behavior change.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):

  • jit/JITOperations.cpp:
  • runtime/ExceptionScope.h:

(JSC::ExceptionScope::assertNoExceptionExceptTermination):
(JSC::ExceptionScope::releaseAssertNoExceptionExceptTermination):

  • runtime/JSObject.h:

(JSC::JSObject::get const):

  • runtime/LazyPropertyInlines.h:

(JSC::ElementType>::callFunc):

  • runtime/VM.cpp:

(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::hasPendingTerminationException const):

  • runtime/VMTraps.cpp:

(JSC::VMTraps::deferTerminationSlow):

Source/WebCore:

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::handleResponseOnStreamingAction):

  • bindings/js/JSDOMPromise.cpp:

(WebCore::DOMPromise::whenPromiseIsSettled):

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::reject):

  • bindings/js/ReadableStream.cpp:

(WebCore::invokeReadableStreamFunction):
(WebCore::ReadableStream::lock):
(WebCore::checkReadableStream):

  • bindings/js/ReadableStreamDefaultController.cpp:

(WebCore::invokeReadableStreamDefaultControllerFunction):
(WebCore::ReadableStreamDefaultController::error):
(WebCore::ReadableStreamDefaultController::enqueue):

7:34 PM Changeset in webkit [277067] by Aditya Keerthi
  • 2 edits in trunk/Source/WebCore

[macOS] Use system colors for ActiveButtonText
​https://bugs.webkit.org/show_bug.cgi?id=225375
<rdar://problem/75863443>

Reviewed by Tim Horton.

Currently, the ActiveButtonText color keyword returns a hardcoded value
on macOS. This behavior is problematic since AppKit can make changes to
the button style, leaving us with illegible text when a button is
pressed.

To fix, return a system color for ActiveButtonText, so that our pressed
buttons are consistent with the rest of the system.

  • rendering/RenderThemeMac.mm:

(WebCore::activeButtonTextColor):

AppKit determines the pressed (active) text color using the cell's
interiorBackgroundStyle. There is not a single system color exposed for
the pressed text color, so it must be determined dynamically.

Unfortunately, this requires us to create an NSButtonCell to determine
the appropriate color. However, this logic is relatively inexpensive,
since we cache exposed system colors.

(WebCore::RenderThemeMac::systemColor const):

Remove the hardcoded value.

7:01 PM Changeset in webkit [277066] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ BigSur wk2 arm64 ] http/tests/inspector/network/resource-sizes-network.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=225430

Unrviewed test gardening.

Updating expectations to flaky (Pass Failure) while test is reviewed.

  • platform/mac-wk2/TestExpectations:
6:05 PM Changeset in webkit [277065] by Russell Epstein
  • 1 copy in tags/Safari-611.3.1

Tag Safari-611.3.1.

5:35 PM Changeset in webkit [277064] by Russell Epstein
  • 8 edits in branches/safari-611-branch/Source

Versioning.

WebKit-7611.3.1

5:30 PM Changeset in webkit [277063] by Diego Pino Garcia
  • 2 edits in trunk/Tools

[build.webkit.org] Add new post-commit builder WPE-Linux-64-bit-Release-Non-Unified-Build
​https://bugs.webkit.org/show_bug.cgi?id=225385

Reviewed by Aakash Jain.

This new post-commit builder will build WPE with Unified builds disabled.

By default, builders build WebKit using Unified sources to speed up
time compilation. Unfortunately, unified source compilation may hide
compilation errors sometimes. A common hidden error are missing headers
in some source files. This hidden compilation errors might be discovered
later when a group of source files are stashed together in a different
manner.

Having a Non-Unified source post-commit builder will help to detect
regressions in unified source compilation for a certain WebKit port,
in this case WPE Release. Usually when these regressions happen they
tend to happen too in other ports such as WebKitGTK, Win or PlayStation.

  • CISupport/build-webkit-org/config.json:
5:27 PM Changeset in webkit [277062] by Russell Epstein
  • 1 copy in tags/Safari-612.1.12.3

Tag Safari-612.1.12.3.

5:22 PM Changeset in webkit [277061] by Jonathan Bedard
  • 6 edits
    1 delete in trunk/Tools

[run-api-tests] Use webkitcorepy's TaskPool
​https://bugs.webkit.org/show_bug.cgi?id=225221
<rdar://problem/77352465>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitcorepy/setup.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
  • Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:

(TaskPool.enter): Ensure that mock has been imported before spawning child processes.

  • Scripts/run-api-tests: Moved from webkitpy/api_tests/run_api_tests.py.
  • Scripts/webkitpy/api_tests/run_api_tests.py: Moved to run-api-tests.
  • Scripts/webkitpy/api_tests/runner.py:

(_Worker): Representation of Worker process.
(_Worker.setup): Pass port object to worker process.
(_Worker.teardown): Un-set port object on worker process.
(_Worker.init): Construct object to hold a Worker process's variables.
(_Worker._run_single_test): Log test results, post results to parent.
(_Worker.run): Run shard with and post results to parent process.
(setup_shard): Run setup in Worker process.
(run_shard): Run test shard in Worker process.
(report_result): Receive result in the parent process.
((teardown_shard): Tear down Worker process.
(Runner.init):
(Runner.command_for_port):
(Runner._shard_tests): Split tests into shards to be efficiently run.
(Runner.run): Use TaskPool to run tests in sub processes.
(Runner.callback): Save results in parent process.
(Runner.result_map_by_status):
(Runner.handle): Deleted.
(_Worker._run_shard_with_binary): Deleted.
(_Worker.post): Deleted.
(_Worker.handle): Deleted.

5:19 PM Changeset in webkit [277060] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Gardened latest test failures.

imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html
is failing after r277031.

fast/canvas/canvas-composite-text-alpha.html is an image failure after r277024.

  • platform/glib/TestExpectations:
5:19 PM Changeset in webkit [277059] by Russell Epstein
  • 2 edits in branches/safari-611-branch/Source/WebKit

Merge Cherry-pick r276618. rdar://problem/77326484

5:19 PM Changeset in webkit [277058] by Russell Epstein
  • 3 edits in branches/safari-611-branch/Source/WebKit

Merge Cherry-pick r276852. rdar://problem/77468295

5:18 PM Changeset in webkit [277057] by Russell Epstein
  • 4 edits in branches/safari-611-branch/Source

Merge Cherry-pick r276742. rdar://problem/77326513

5:18 PM Changeset in webkit [277056] by Russell Epstein
  • 5 edits
    2 adds in branches/safari-611-branch

Merge Cherry-pick r276688. rdar://problem//77326513

5:09 PM Changeset in webkit [277055] by Kate Cheney
  • 5 edits in trunk/Source/WebKit

Remove network website data when a user clears an individual domain
​https://bugs.webkit.org/show_bug.cgi?id=225350
<rdar://problem/76029480>

Reviewed by Brent Fulgham.

Convert parameters to Optional values now that we use the function
for individual domains.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
We should check all possible website data entries and delete
network domain data if any of them contain a domain.

  • NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::removeNetworkWebsiteData):

  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::removeNetworkWebsiteData):

4:53 PM Changeset in webkit [277054] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ macOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https.html is a flaky text failure
​https://bugs.webkit.org/show_bug.cgi?id=225421

Unreviewed test gardening.

Marking test as flaky (Pass Failure), while under review.

  • platform/mac/TestExpectations:
4:38 PM Changeset in webkit [277053] by ntim@apple.com
  • 14 edits
    8 adds in trunk/LayoutTests

Re-sync css/css-animations WPTs
​https://bugs.webkit.org/show_bug.cgi?id=225404

Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-animations/nested-scale-animations-expected.html: Added.
  • web-platform-tests/css/css-animations/nested-scale-animations.html: Added.
  • web-platform-tests/css/css-animations/svg-transform-animation-expected.html: Added.
  • web-platform-tests/css/css-animations/svg-transform-animation.html: Added.
  • web-platform-tests/css/css-animations/transform-animation-under-large-scale-expected.html: Added.
  • web-platform-tests/css/css-animations/transform-animation-under-large-scale.html: Added.
  • web-platform-tests/css/css-animations/translation-animation-subpixel-offset-expected.html: Added.
  • web-platform-tests/css/css-animations/translation-animation-subpixel-offset.html: Added.
  • web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html:
  • web-platform-tests/css/css-animations/event-dispatch.tentative-expected.txt:
  • web-platform-tests/css/css-animations/event-dispatch.tentative.html:
  • web-platform-tests/css/css-animations/parsing/animation-invalid-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-invalid.html:
  • web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-shorthand.html:
  • web-platform-tests/css/css-animations/support/testcommon.js:

(armTimeoutWhenReady):

  • web-platform-tests/css/css-animations/w3c-import.log:

LayoutTests:

4:23 PM Changeset in webkit [277052] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit

Reduce sandbox telemetry
​https://bugs.webkit.org/show_bug.cgi?id=225417
<rdar://77489628>

Reviewed by Darin Adler.

Remove sandbox telemetry which is no longer needed.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:
4:19 PM Changeset in webkit [277051] by Amir Mark Jr.
  • 2 edits in trunk/LayoutTests

[MacOS wk2] http/tests/cache/disk-cache/disk-cache-remove-several-pending-writes.html is a flakey failure
​https://bugs.webkit.org/show_bug.cgi?id=223531

Unreviewed test gardening.

Removed debug from a previous test expectation for this bug.

  • platform/mac-wk2/TestExpectations:
4:06 PM Changeset in webkit [277050] by Cameron McCormack
  • 3 edits in trunk/Source/WebCore

Remove unused DisplayList::Recorder::ContextState::wasUsedForDrawing
​https://bugs.webkit.org/show_bug.cgi?id=225381

Reviewed by Simon Fraser.

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::canAppendItemOfType):
(WebCore::DisplayList::Recorder::restore):

  • platform/graphics/displaylists/DisplayListRecorder.h:
4:01 PM Changeset in webkit [277049] by Ruben Turcios
  • 5 edits in branches/safari-612.1.13-branch

Cherry-pick r277044. rdar://problem/77579966

Sampled Page Top Color: don't snapshot if the hit test location is an image or has an animation
​https://bugs.webkit.org/show_bug.cgi?id=225338

Reviewed by Tim Horton.

Source/WebCore:

Tests: SampledPageTopColor.HitTestHTMLImage

SampledPageTopColor.HitTestCSSBackgroundImage
SampledPageTopColor.HitTestCSSAnimation

  • dom/Document.h:
  • dom/Document.cpp: (WebCore::isValidPageSampleLocation): Added. (WebCore::samplePageColor): Added. (WebCore::Document::determineSampledPageTopColor): (WebCore::Document::isHitTestLocationThirdPartyFrame): Deleted. Refactor isHitTestLocationThirdPartyFrame (and the pixelColor lambda) into static functions that are right above Document::determineSampledPageTopColor for clarity and to allow for more flexibility. In order to check if the hit test node is an image (including having a CSS background-image) or has a CSS animation (or CSS transition), it's necessary to continue to hit test beyond one node as the image and/or node with the CSS animation may be an ancestor (or unrelated position: absolute node) to the HitTestResult::innerNode. `

<div style="background-image: url(...)">

<button>Lorum ipsum ... </button>

</div>

`

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm: (TEST.SampledPageTopColor.HitTestHTMLImage): (TEST.SampledPageTopColor.HitTestCSSBackgroundImage): (TEST.SampledPageTopColor.HitTestCSSAnimation):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:01 PM Changeset in webkit [277048] by Ruben Turcios
  • 2 edits in branches/safari-612.1.13-branch/Source/WebKit

Cherry-pick r277026. rdar://problem/77579962

REGRESSION (r276633): ASSERTION FAILED: !forbidMallocUseScopeCount
disableMallocRestrictionScopeCount

​https://bugs.webkit.org/show_bug.cgi?id=225374
<rdar://problem/77533237>

Reviewed by Chris Dumez.

Disable memory allocation checks in speech recognition code path.
No change of behavior.

  • WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp: (WebKit::SpeechRecognitionRealtimeMediaSourceManager::Source::storageChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:46 PM Changeset in webkit [277047] by Cameron McCormack
  • 6 edits in trunk/Source/WebCore

Rename DisplayList::Recorder::appendDrawGraphsItemWithCachedFont.
​https://bugs.webkit.org/show_bug.cgi?id=225382

Reviewed by Simon Fraser.

It appends a DrawGlyphsItem, not a DrawGraphsItem.

  • platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawGlyphs):
(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

  • platform/graphics/displaylists/DisplayListDrawGlyphsRecorderHarfBuzz.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

  • platform/graphics/displaylists/DisplayListDrawGlyphsRecorderWin.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::appendDrawGlyphsItemWithCachedFont):

  • platform/graphics/displaylists/DisplayListRecorder.h:
3:30 PM Changeset in webkit [277046] by Cameron McCormack
  • 2 edits in trunk/Source/WebCore

Fix copy paste error in Recorder::canAppendItemOfType.
​https://bugs.webkit.org/show_bug.cgi?id=225380

Reviewed by Simon Fraser.

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::canAppendItemOfType):

3:22 PM Changeset in webkit [277045] by Devin Rousso
  • 15 edits in trunk/Source

Sampled Page Top Color: tie into existing TCADA/RLTT systems so that the value is kept in sync with painting
​https://bugs.webkit.org/show_bug.cgi?id=225405

Reviewed by Tim Horton.

Instead of sending an IPC to the UIProcess whenever the logic to determine the sampled page
top color finishes, wait to dispatch the IPC until we're about to render (just like theme
color and page extended background color). On macOS, this means the IPC is dispatched inside
TiledCoreAnimationDrawingArea::updateRendering. On iOS, the Color is included as part of
the RemoteLayerTreeTransaction.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::determineSampledPageTopColor):

  • page/ChromeClient.h:

(WebCore::ChromeClient::sampledPageTopColorChanged const): Renamed from didSamplePageTopColor.

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::sampledPageTopColorChanged const): Renamed from didSamplePageTopColor.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::sampledPageTopColorChanged): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):
(WebKit::WebPage::flushPendingSampledPageTopColorChange): Added.
(WebKit::WebPage::didSamplePageTopColor): Deleted.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateRendering):

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::sampledPageTopColor const): Added.
(WebKit::RemoteLayerTreeTransaction::setSampledPageTopColor): Added.

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sampledPageTopColorChanged): Renamed from didSamplePageTopColor.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):

2:53 PM Changeset in webkit [277044] by Devin Rousso
  • 5 edits in trunk

Sampled Page Top Color: don't snapshot if the hit test location is an image or has an animation
​https://bugs.webkit.org/show_bug.cgi?id=225338

Reviewed by Tim Horton.

Source/WebCore:

Tests: SampledPageTopColor.HitTestHTMLImage

SampledPageTopColor.HitTestCSSBackgroundImage
SampledPageTopColor.HitTestCSSAnimation

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::isValidPageSampleLocation): Added.
(WebCore::samplePageColor): Added.
(WebCore::Document::determineSampledPageTopColor):
(WebCore::Document::isHitTestLocationThirdPartyFrame): Deleted.
Refactor isHitTestLocationThirdPartyFrame (and the pixelColor lambda) into static
functions that are right above Document::determineSampledPageTopColor for clarity and to
allow for more flexibility. In order to check if the hit test node is an image (including
having a CSS background-image) or has a CSS animation (or CSS transition), it's necessary
to continue to hit test beyond one node as the image and/or node with the CSS animation may
be an ancestor (or unrelated position: absolute node) to the HitTestResult::innerNode.
`

<div style="background-image: url(...)">

<button>Lorum ipsum ... </button>

</div>

`

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(TEST.SampledPageTopColor.HitTestHTMLImage):
(TEST.SampledPageTopColor.HitTestCSSBackgroundImage):
(TEST.SampledPageTopColor.HitTestCSSAnimation):

2:52 PM Changeset in webkit [277043] by aakash_jain@apple.com
  • 4 edits in trunk/Tools

[build.webkit.org] Add a build step to set appropriate permissions on uploaded test results
​https://bugs.webkit.org/show_bug.cgi?id=225415

Reviewed by Dewei Zhu.

  • CISupport/build-webkit-org/factories.py:

(TestFactory.init): Added the build-step.

  • CISupport/build-webkit-org/steps.py:

(ExtractTestResults.resultDirectoryURL):
(SetPermissions): Build step to set permissions on uploaded test result directory.

2:33 PM Changeset in webkit [277042] by Amir Mark Jr.
  • 2 edits in trunk/LayoutTests

[BigSur WK1] imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v* is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=221300

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:05 PM Changeset in webkit [277041] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled.html on windows
until the preference has been hooked up.

  • platform/win/TestExpectations:
1:44 PM Changeset in webkit [277040] by Ruben Turcios
  • 10 edits in branches/safari-612.1.13-branch

Cherry-pick r277030. rdar://problem/77573075

Sampled Page Top Color: take additional snapshots further down the page to see if the sampled top color is more than just a tiny strip
​https://bugs.webkit.org/show_bug.cgi?id=225323

Reviewed by Beth Dakin.

Source/WebCore:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

Tests: SampledPageTopColor.VerticalGradientBelowMaxDifference

SampledPageTopColor.VerticalGradientAboveMaxDifference

  • dom/Document.cpp: (WebCore::Document::determineSampledPageTopColor):

Source/WebKit:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _setSampledPageTopColorMinHeight:]): Added. (-[WKWebViewConfiguration _sampledPageTopColorMinHeight]): Added.
  • UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setupPageConfiguration:]): Provide SPI to configure the SampledPageTopColorMinHeight preference when creating the WKWebView.

Source/WTF:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

  • Scripts/Preferences/WebPreferences.yaml:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm: (createWebViewWithSampledPageTopColorMaxDifference): (createHTMLGradientWithColorStops): (TEST.SampledPageTopColor.ZeroMaxDifference): (TEST.SampledPageTopColor.NegativeMaxDifference): (TEST.SampledPageTopColor.SolidColor): (TEST.SampledPageTopColor.DifferentColorsWithoutOutlierBelowMaxDifference): (TEST.SampledPageTopColor.DifferentColorsWithLeftOutlierAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsWithMiddleOutlierAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsWithRightOutlierAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsIndividuallyAboveMaxDifference): (TEST.SampledPageTopColor.DifferentColorsCumulativelyAboveMaxDifference): (TEST.SampledPageTopColor.VerticalGradientBelowMaxDifference): Added. (TEST.SampledPageTopColor.VerticalGradientAboveMaxDifference): Added. (TEST.SampledPageTopColor.DISABLED_DisplayP3): (TEST.SampledPageTopColor.ExperimentalUseSampledPageTopColorForScrollAreaBackgroundColor):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 PM Changeset in webkit [277039] by ntim@apple.com
  • 5 edits in trunk

Invalid media query keyword values should not be parsable
​https://bugs.webkit.org/show_bug.cgi?id=225282

Reviewed by Dean Jackson.

Updated WPT expectations.

LayoutTests/imported/w3c:

  • web-platform-tests/css/mediaqueries/prefers-color-scheme-expected.txt:
  • web-platform-tests/css/mediaqueries/prefers-reduced-motion-expected.txt:

Source/WebCore:

  • css/MediaQueryExpression.cpp:

(WebCore::isValidValueForIdentMediaFeature):
(WebCore::featureWithValidIdent):

1:34 PM Changeset in webkit [277038] by achristensen@apple.com
  • 5 edits in trunk/Source

Add WebKitAdditions stubs for new NetworkLoadMetrics
​https://bugs.webkit.org/show_bug.cgi?id=225406
<rdar://77563372>

Reviewed by Jer Noble.

Source/WebCore:

I also removed some dead code and added static asserts that do what the dead code was intended to do.

  • platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics::isolatedCopy const):
(WebCore::NetworkLoadMetrics::operator== const):
(WebCore::NetworkLoadMetrics::encode const):
(WebCore::NetworkLoadMetrics::decode):
(WTF::Persistence::Coder<Optional<WebCore::NetworkLoadPriority>>::encode): Deleted.
(WTF::Persistence::Coder<Optional<WebCore::NetworkLoadPriority>>::decode): Deleted.

  • platform/network/cocoa/WebCoreNSURLSession.mm:

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

1:34 PM Changeset in webkit [277037] by Robert Jenner
  • 3 edits in trunk/LayoutTests

[ macOS/iOS Debug ] http/wpt/crypto/unwrap-rsa-key-crash.any.html (layout-test) is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=225315

Unreviewed test gardening.

Removing prior expectations.

  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
1:19 PM Changeset in webkit [277036] by yurys@chromium.org
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

[LibWebRTC][WPE][GTK] do not use system installed vpx headers when building webrtc
​https://bugs.webkit.org/show_bug.cgi?id=225401

Reviewed by Philippe Normand.

Use vpx headers from Source/ThirdParty/libwebrtc instead of those from the host system.

  • CMakeLists.txt: expose libvpx headers to webrtc
12:37 PM Changeset in webkit [277035] by sbarati@apple.com
  • 3 edits in trunk/JSTests

Update tests to use collectExtraSamplingProfilerData instead of collectSamplingProfilerDataForJSCShell
​https://bugs.webkit.org/show_bug.cgi?id=225398

Reviewed by Mark Lam.

I forgot to update the tests to use the new option name.

  • stress/sampling-profiler-code-origin.js:
  • stress/sampling-profiler-richards.js:
12:08 PM Changeset in webkit [277034] by dino@apple.com
  • 2 edits in trunk/Source/WebKit

Separated layers need to be configured
​https://bugs.webkit.org/show_bug.cgi?id=225378

Reviewed by Tim Horton.

Configure a layer as it becomes separated. The actual code will
come from WebKitAdditions.

  • Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(configureSeparatedLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):

11:47 AM Changeset in webkit [277033] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit

Add and adopt RemoteLayerBackingStore::Type (instead of "accelerates drawing" bit)
​https://bugs.webkit.org/show_bug.cgi?id=225384

Reviewed by Anders Carlsson.

No new tests, no behavior change, just refactoring.

  • Shared/RemoteLayerTree/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::type const):
(WebKit::RemoteLayerBackingStore::acceleratesDrawing const): Deleted.

  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):
(WebKit::RemoteLayerBackingStore::encode const):
(WebKit::RemoteLayerBackingStore::decode):
(WebKit::RemoteLayerBackingStore::pixelFormat const):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
(WebKit::RemoteLayerBackingStore::setBufferVolatility):

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::nameForBackingStoreType):
(WebKit::operator<<):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::updateBackingStore):
In preparation for adding another backing store type, refactor RemoteLayerBackingStore
to have a type enum instead of an "accelerates drawing" bit.

11:43 AM Changeset in webkit [277032] by Brent Fulgham
  • 9 edits in trunk/Source/WebKit

[Cocoa] Remove access to the unused 'nvram' system command
​https://bugs.webkit.org/show_bug.cgi?id=225370
<rdar://problem/66583129>

Reviewed by Per Arne Vollan.

Add a 'deny' rule for nvram, since we don't use it and have no reason to access it.

  • GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
11:34 AM Changeset in webkit [277031] by aboya@igalia.com
  • 22 edits
    5 adds
    2 deletes in trunk

[MSE][GStreamer] WebKitMediaSrc rework v2
​https://bugs.webkit.org/show_bug.cgi?id=225192

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

This patch (re)introduces a new source element for the MSE playback
pipeline. This is an iteration on the previous work on r249205 that
had to be reverted in r251365 because of flaky playbin3 bugs.

This new version avoids these pitfalls by avoiding flushes in
situations where they are avoidable and known to expose bugs.

This re-land shares many of the advantages that motivated the first
patch: seeks massively oversimplified and greater control by no longer
relying on appsrc. It can handle flushes of individual streams
natively.

Work has also gone into decoupling the state of the frame queue from
the state of WebKitMediaSrc so that the backend can survive
transitions from PAUSED to READY and back which
MediaPlayerPrivateGStreamer creates when playback ends. This latter
effort is not complete, and instead this version adds a special case
to inhibit downwards and back upwards transitions, avoiding any
issues.

It is expected that at this point this new backend is at least as
stable as the previous one. No LayoutTest has got worsened
expectations from adding this backend and some have improved.

  • platform/GStreamer.cmake:
  • platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:

(webKitGLVideoSinkFinalize):
(webKitGLVideoSinkSetMediaPlayerPrivate):

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<GstMiniObject>):
(WTF::derefGPtr<GstMiniObject>):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(WebCore::MediaPlayerPrivateGStreamer::invalidateCachedPosition):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:

(WebCore::TrackPrivateBaseGStreamer::setInitialCaps):
(WebCore::TrackPrivateBaseGStreamer::initialCaps):

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
(WebCore::AppendPipeline::appsinkCapsChanged):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromStreamingThread):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):

  • platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::demuxerSrcPadCaps):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::~MediaPlayerPrivateGStreamerMSE):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::play):
(WebCore::MediaPlayerPrivateGStreamerMSE::pause):
(WebCore::MediaPlayerPrivateGStreamerMSE::seek):
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
(WebCore::MediaPlayerPrivateGStreamerMSE::setReadyState):
(WebCore::MediaPlayerPrivateGStreamerMSE::propagateReadyStateToPlayer):
(WebCore::MediaPlayerPrivateGStreamerMSE::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamerMSE::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
(WebCore::MediaPlayerPrivateGStreamerMSE::unblockDurationChanges):
(WebCore::MediaPlayerPrivateGStreamerMSE::durationChanged):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::startSource):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

(WebCore::MediaPlayerPrivateGStreamerMSE::hasAllTracks const):
(WebCore::MediaPlayerPrivateGStreamerMSE::webKitMediaSrc):

  • platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp:

(WebCore::MediaSourcePrivateGStreamer::addSourceBuffer):
(WebCore::MediaSourcePrivateGStreamer::markEndOfStream):
(WebCore::MediaSourcePrivateGStreamer::unmarkEndOfStream):
(WebCore::MediaSourcePrivateGStreamer::waitForSeekCompleted):
(WebCore::MediaSourcePrivateGStreamer::seekCompleted):
(WebCore::MediaSourcePrivateGStreamer::startPlaybackIfHasAllTracks):

  • platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h:
  • platform/graphics/gstreamer/mse/MediaSourceTrackGStreamer.cpp: Added.

(WebCore::MediaSourceTrackGStreamer::MediaSourceTrackGStreamer):
(WebCore::MediaSourceTrackGStreamer::~MediaSourceTrackGStreamer):
(WebCore::MediaSourceTrackGStreamer::create):
(WebCore::MediaSourceTrackGStreamer::isReadyForMoreSamples):
(WebCore::MediaSourceTrackGStreamer::notifyWhenReadyForMoreSamples):
(WebCore::MediaSourceTrackGStreamer::enqueueObject):
(WebCore::MediaSourceTrackGStreamer::clearQueue):
(WebCore::MediaSourceTrackGStreamer::remove):

  • platform/graphics/gstreamer/mse/MediaSourceTrackGStreamer.h: Added.
  • platform/graphics/gstreamer/mse/PlaybackPipeline.h: Removed.
  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
(WebCore::SourceBufferPrivateGStreamer::flush):
(WebCore::SourceBufferPrivateGStreamer::enqueueSample):
(WebCore::SourceBufferPrivateGStreamer::isReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::allSamplesInTrackEnqueued):
(WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment):

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
  • platform/graphics/gstreamer/mse/TrackQueue.cpp: Added.

(WebCore::TrackQueue::TrackQueue):
(WebCore::TrackQueue::enqueueObject):
(WebCore::TrackQueue::clear):
(WebCore::TrackQueue::flush):
(WebCore::TrackQueue::notifyWhenLowLevel):
(WebCore::TrackQueue::pop):
(WebCore::TrackQueue::notifyWhenNotEmpty):
(WebCore::TrackQueue::resetNotEmptyHandler):
(WebCore::TrackQueue::checkLowLevel):
(WebCore::TrackQueue::durationEnqueued const):

  • platform/graphics/gstreamer/mse/TrackQueue.h: Added.

(WebCore::TrackQueue::isFull const):
(WebCore::TrackQueue::isEmpty const):
(WebCore::TrackQueue::hasNotEmptyHandler const):

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(WebKitMediaSrcPrivate::streamByName):
(WebKitMediaSrcPrivate::isStarted):
(WTF::adoptGRef):
(WTF::refGPtr<WebKitMediaSrcPad>):
(WTF::derefGPtr<WebKitMediaSrcPad>):
(webkit_media_src_pad_class_init):
(Stream::Stream):
(Stream::StreamingMembers::StreamingMembers):
(findPipeline):
(gstStreamType):
(streamTypeToString):
(webkit_media_src_class_init):
(webkit_media_src_init):
(webKitMediaSrcFinalize):
(webKitMediaSrcEmitStreams):
(webKitMediaSrcTearDownStream):
(webKitMediaSrcActivateMode):
(webKitMediaSrcPadLinked):
(webKitMediaSrcLoop):
(webKitMediaSrcStreamFlush):
(webKitMediaSrcFlush):
(webKitMediaSrcSeek):
(countStreamsOfType):
(webKitMediaSrcGetProperty):
(webKitMediaSrcChangeState):
(webKitMediaSrcSendEvent):
(webKitMediaSrcUriGetType):
(webKitMediaSrcGetProtocols):
(webKitMediaSrcGetUri):
(webKitMediaSrcSetUri):
(webKitMediaSrcUriHandlerInit):

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h:
  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h: Removed.

Tools:

WebKitMediaSrc is a GObject class and needs to follow some GObject
conventions that conflict with WebKit's. Make the checker aware of
this.

  • Scripts/webkitpy/style/checker.py:

LayoutTests:

Update expectations.

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt: Added.
11:17 AM Changeset in webkit [277030] by Devin Rousso
  • 10 edits in trunk

Sampled Page Top Color: take additional snapshots further down the page to see if the sampled top color is more than just a tiny strip
​https://bugs.webkit.org/show_bug.cgi?id=225323

Reviewed by Beth Dakin.

Source/WebCore:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

Tests: SampledPageTopColor.VerticalGradientBelowMaxDifference

SampledPageTopColor.VerticalGradientAboveMaxDifference

  • dom/Document.cpp:

(WebCore::Document::determineSampledPageTopColor):

Source/WebKit:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setSampledPageTopColorMinHeight:]): Added.
(-[WKWebViewConfiguration _sampledPageTopColorMinHeight]): Added.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):
Provide SPI to configure the SampledPageTopColorMinHeight preference when creating the WKWebView.

Source/WTF:

Add a SampledPageTopColorMinHeight setting that controls how far down the sampled page top
color needs to extend in order for us to not bail. If the value > 0, we take an additional
snapshot at (0, SampledPageTopColorMinHeight) and (width, SampledPageTopColorMinHeight),
comparing each to the snapshot directly above (e.g. (0, SampledPageTopColorMinHeight) is
compared to (0, 0)) using the SampledPageTopColorMaxDifference. Depending on the value, if
the color across the top of the page is only a small strip, these extra snapshot comparisons
will prevent a resulting color from being derived.

  • Scripts/Preferences/WebPreferences.yaml:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(createWebViewWithSampledPageTopColorMaxDifference):
(createHTMLGradientWithColorStops):
(TEST.SampledPageTopColor.ZeroMaxDifference):
(TEST.SampledPageTopColor.NegativeMaxDifference):
(TEST.SampledPageTopColor.SolidColor):
(TEST.SampledPageTopColor.DifferentColorsWithoutOutlierBelowMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsWithLeftOutlierAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsWithMiddleOutlierAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsWithRightOutlierAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsIndividuallyAboveMaxDifference):
(TEST.SampledPageTopColor.DifferentColorsCumulativelyAboveMaxDifference):
(TEST.SampledPageTopColor.VerticalGradientBelowMaxDifference): Added.
(TEST.SampledPageTopColor.VerticalGradientAboveMaxDifference): Added.
(TEST.SampledPageTopColor.DISABLED_DisplayP3):
(TEST.SampledPageTopColor.ExperimentalUseSampledPageTopColorForScrollAreaBackgroundColor):

11:12 AM Changeset in webkit [277029] by Chris Gambrell
  • 2 edits
    2 adds in trunk/LayoutTests

[LayoutTests] http/tests/css/object-fit-delayed-img-svg.html yields errors due to missing scripts
​https://bugs.webkit.org/show_bug.cgi?id=225246
<rdar://problem/77397227>

Reviewed by Jonathan Bedard.

  • http/tests/css/object-fit-delayed-img-svg.html:
  • http/tests/css/resources/circle.svg: Added.
  • http/tests/css/resources/delayedCircle.py: Added.
10:58 AM Changeset in webkit [277028] by youenn@apple.com
  • 3 edits
    2 adds in trunk

No need to error a fetch body stream if its request or response is stopped
​https://bugs.webkit.org/show_bug.cgi?id=225347

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: http/wpt/fetch/fetch-response-body-stop-in-worker.html

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::stop):
Nullify the source before we error it.

LayoutTests:

  • http/wpt/fetch/fetch-response-body-stop-in-worker-expected.txt: Added.
  • http/wpt/fetch/fetch-response-body-stop-in-worker.html: Added.
10:28 AM Changeset in webkit [277027] by mark.lam@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Enable incremental sweeping of GCAwareJITStubRoutines.
​https://bugs.webkit.org/show_bug.cgi?id=225376

Reviewed by Filip Pizlo.

This patch makes the following changes:

  1. Enhance JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines() to be able to run in an incremental time slice.
  1. Added JITStubRoutineSet::notifyHaveRoutinesToDelete() so that GCAwareJITStubRoutine::observeZeroRefCount() can flag that the GC may have some dead GCAwareJITStubRoutines to delete.
  1. Added JITStubRoutineSet::mayHaveRoutinesToDelete() so that clients can do a cheap check ahead of time to determine if there's work to do, and avoid calling JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines() altogether if not needed.
  1. Added Heap::mayHaveJITStubRoutinesToDelete() and Heap::deleteDeadJITStubRoutines() as wrappers around JITStubRoutineSet::mayHaveRoutinesToDelete() and JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines() because the use of the JITStubRoutineSet is a heap internal implementation detail.
  1. Enhanced the IncrementalSweeper to also call Heap::deleteDeadJITStubRoutines() if needed.
  1. Enhanced Heap::sweepSynchronously() to also call Heap::deleteDeadJITStubRoutines() if needed.
  1. Time slices for Heap::deleteDeadJITStubRoutines() is currently set at the current values:
    1. max of 1 ms (1/10 of the IncreamentalSweeper's time slice) when invoked from the IncreamentalSweeper.
    2. max of 5 ms when invoked from Heap::deleteUnmarkedCompiledCode().
    3. unlimited time (with a sanity check) when called from Heap::sweepSynchronously().

The choices of 1ms and 5ms were picked to not be too long, but would still delete
the bulk of the dead GCAwareJITStubRoutines quickly enough based on data from my
instrumented runs the CLI version of JetStream2.

I think these hardcoded values will do for now. If need be, we can try something
more sophisticated later.

  • CMakeLists.txt:
  • heap/Heap.cpp:

(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::sweepSynchronously):

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::mayHaveJITStubRoutinesToDelete):
(JSC::Heap::deleteDeadJITStubRoutines):

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/JITStubRoutineSet.h:

(JSC::JITStubRoutineSet::mayHaveRoutinesToDelete):
(JSC::JITStubRoutineSet::notifyHaveRoutinesToDelete):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::observeZeroRefCount):

  • jit/JITStubRoutine.h:

(JSC::JITStubRoutine::createSelfManagedRoutine): Deleted.

10:00 AM Changeset in webkit [277026] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit
REGRESSION (r276633): ASSERTION FAILED: !forbidMallocUseScopeCount
disableMallocRestrictionScopeCount

​https://bugs.webkit.org/show_bug.cgi?id=225374
<rdar://problem/77533237>

Reviewed by Chris Dumez.

Disable memory allocation checks in speech recognition code path.
No change of behavior.

  • WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp:

(WebKit::SpeechRecognitionRealtimeMediaSourceManager::Source::storageChanged):

9:45 AM Changeset in webkit [277025] by Russell Epstein
  • 1 edit in branches/safari-612.1.12-branch/Source/WebCore/html/HTMLElement.h

Unreviewed build fix. rdar://problem/77530347

Undefined symbols:

"WebCore::HTMLElement::isInsideImageOverlay(WebCore::SimpleRange const&)"

9:36 AM Changeset in webkit [277024] by weinig@apple.com
  • 24 edits
    3 copies
    6 adds in trunk

Add preliminary support for specifying a color space for 2D canvas
​https://bugs.webkit.org/show_bug.cgi?id=225286

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/canvas/CanvasRenderingContext2DSettings-colorSpace-disabled.html

fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled.html
fast/canvas/canvas-color-space-display-p3.html

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • html/canvas/CanvasRenderingContext2DSettings.idl:
  • html/canvas/CanvasRenderingContext2DSettings.h:

Add a new setting blocked member to the CanvasRenderingContext2DSettings
dictionary for specifying a color space.

  • html/canvas/PredefinedColorSpace.cpp: Added.
  • html/canvas/PredefinedColorSpace.h: Added.
  • html/canvas/PredefinedColorSpace.idl: Added.

Add a new IDL enumeration to represent the possible color spaces supported.
For ports that don't support DisplayP3, trying to use it will result in
type error from JS.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Add checks for color space and pixel format to 2d context reset optimation.
This can happen if the image buffer is allocated prior to the context being
requested (such as via canvas.toDataURL() or canvas.toBlob()).

(WebCore::HTMLCanvasElement::createImageBuffer const):
Pass the correct color space and pixel format (though
the later is always BGRA8 at the moment) to the ImageBuffer
create function to make a backing store in the right format.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::createBufferForPainting const):

  • html/HTMLVideoElement.h:

Pass color space and pixel format through to ensure the helper
buffer matches the correct color space.

  • html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise):
Pass the existing defaults to HTMLVideoElement::createBufferForPainting.
In the future, ImageBitmap will also gain color space and pixel
format specificity and this will be updated.

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::pixelFormat const):
(WebCore::CanvasRenderingContext::colorSpace const):

  • html/canvas/CanvasRenderingContext.h:

Add virtual base implementations of colorSpace and pixelFormat
which CanvasRenderingContext2D can override to return the
values specified in the CanvasRenderingContext2DSettings.

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fontProxy const):
Fix incorrect formatting.

(WebCore::CanvasRenderingContext2D::pixelFormat const):
(WebCore::CanvasRenderingContext2D::colorSpace const):
Add overrides, return m_settings.colorSpace for colorSpace.

  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::CanvasRenderingContext2DBase::createCompositingBuffer):
(WebCore::CanvasRenderingContext2DBase::createPattern):
(WebCore::CanvasRenderingContext2DBase::drawTextUnchecked):
Pass along the colorSpace and pixelFormat when creating buffers.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

Add missing includes that are now needed.

Source/WTF:

Add new experimental feature, CanvasColorSpaceEnabled, which blocks
access to the new ability to specify color spaces for 2D canvas.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):
Add CanvasColorSpaceEnabled for windows.

LayoutTests:

Add basic tests for color space in canvas support.

  • fast/canvas/CanvasRenderingContext2DSettings-colorSpace-disabled-expected.txt: Added.
  • fast/canvas/CanvasRenderingContext2DSettings-colorSpace-disabled.html: Added.
  • fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled-expected.txt: Added.
  • fast/canvas/CanvasRenderingContext2DSettings-colorSpace-enabled.html: Added.
  • fast/canvas/canvas-color-space-display-p3-expected.html: Added.
  • fast/canvas/canvas-color-space-display-p3.html: Added.
9:33 AM Changeset in webkit [277023] by Chris Lord
  • 7 edits
    5 deletes in trunk/LayoutTests

Update WPT OffscreenCanvas tests to respect [EnforceRange]
​https://bugs.webkit.org/show_bug.cgi?id=225391

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Synchronise with upstream WPT OffscreenCanvas tests.

  • web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny-expected.txt: Removed.
  • web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.html: Removed.
  • web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker-expected.txt: Removed.
  • web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker.html: Removed.
  • web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker.js: Removed.
  • web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl-expected.txt:
  • web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl.html:
  • web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl.worker-expected.txt:
  • web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/size.attributes.idl.worker.js:

(t.step):

LayoutTests:

WPT html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.html
passes after updating.

  • platform/glib/TestExpectations:
9:19 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
9:18 AM Changeset in webkit [277022] by Adrian Perez de Castro
  • 4 edits in releases/WebKitGTK/webkit-2.32

Merge r277014 - [SOUP] Wrong cookie timestamp in case of long expire time
​https://bugs.webkit.org/show_bug.cgi?id=225389

Reviewed by Adrian Perez de Castro.

Source/WebCore:

There's an overflow when converting the dates in both libsoup2 and libsoup3, but for two different reasons. In
the case of libsoup2 we are using an int for the conversion of milliseconds to seconds which is not enough. In
the case of libsoup3 we are passing the value in milliseconds to g_date_time_new_from_unix_utc() that expects
seconds.

  • platform/network/soup/CookieSoup.cpp:

(WebCore::msToSoupDate): Use int64_t instead of int for the cast.
(WebCore::Cookie::toSoupCookie const): Convert the value to seconds.

Tools:

Add a test case.

  • TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerLongExpires):
(beforeAll):

9:18 AM Changeset in webkit [277021] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.32

Merge r277015 - USE_64KB_PAGE_BLOCK build option is broken
​https://bugs.webkit.org/show_bug.cgi?id=225393

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-05
Reviewed by Adrian Perez de Castro.

Call SET_AND_EXPOSE_TO_BUILD().

  • Source/cmake/WebKitFeatures.cmake:
8:07 AM Changeset in webkit [277020] by Jean-Yves Avenard
  • 7 edits in trunk

imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html is a flakey
​https://bugs.webkit.org/show_bug.cgi?id=225386
rdar://74704447

Reviewed by Eric Carlson.

Source/WebKit:

When enabling/disabling a track, the web content process would send a message to the GPU process which in turn
would send a message back to the content process, notifying that the track configuration had changed, that would
then enable/disable again the track.
If the content process in between those IPC messages had modified the track (such as via JS call), it was
possible for the track status to get lost once the GPU message above got actioned.

Having the GPU process notify that a track configuration got changed when it was originally triggered by the
content process is unnecessary. We modify the RemoteAudioTrack and RemoteVideoTrack so that if the change came
from the web process, the GPU process doesn't send a message back with information that could already be obsolete.

No new tests. Fix an assertion failure in tests.

  • GPUProcess/media/RemoteAudioTrackProxy.cpp:

(WebKit::RemoteAudioTrackProxy::enabledChanged):

  • GPUProcess/media/RemoteAudioTrackProxy.h:
  • GPUProcess/media/RemoteVideoTrackProxy.cpp:

(WebKit::RemoteVideoTrackProxy::selectedChanged):

  • GPUProcess/media/RemoteVideoTrackProxy.h:

LayoutTests:

  • platform/mac-wk2/TestExpectations: Remove
8:02 AM Changeset in webkit [277019] by Chris Dumez
  • 2 edits in trunk/Tools

Unreviewed, reverting r276985.

This test is still failing on Apple Silicon

Reverted changeset:

"Unreviewed, try and re-enable
AppleLanguagesTest.UpdateAppleLanguages on Apple Silicon."
​https://commits.webkit.org/r276985

7:48 AM Changeset in webkit [277018] by Chris Dumez
  • 2 edits in trunk/Tools

REGRESSION (r272414?): [macOS] TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=221742
<rdar://problem/74220428>

Reviewed by Youenn Fablet.

Make sure the video is looping so that it cannot stop playing before the end of the test.
This is a speculative fix since I haven't been able to reproduce the issue.

  • TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

7:11 AM Changeset in webkit [277017] by commit-queue@webkit.org
  • 3 edits in trunk/Tools/buildstream

[Flatpak SDK] Update libwpe and wpebackend-fdo
​https://bugs.webkit.org/show_bug.cgi?id=225358

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-05
Reviewed by Adrian Perez de Castro.

  • elements/sdk/libwpe.bst: Update to version 1.10.
  • elements/sdk/wpebackend-fdo.bst: Update to 1.9.91, soon to be 1.10.
6:55 AM Changeset in webkit [277016] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] Wrap incoming audio buffers, complying with fastMalloc restrictions
​https://bugs.webkit.org/show_bug.cgi?id=225351

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-05-05
Reviewed by Xabier Rodriguez-Calvar.

The audio thread should avoid calling fastMalloc for performance reasons, so audio buffers
are now wrapped in GStreamer buffers and passed as read-only memories to the observers.

  • platform/mediastream/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeIncomingAudioSourceLibWebRTC::OnData):

6:40 AM WebKitGTK/2.32.x edited by Michael Catanzaro
(diff)
6:39 AM Changeset in webkit [277015] by commit-queue@webkit.org
  • 2 edits in trunk

USE_64KB_PAGE_BLOCK build option is broken
​https://bugs.webkit.org/show_bug.cgi?id=225393

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-05
Reviewed by Adrian Perez de Castro.

Call SET_AND_EXPOSE_TO_BUILD().

  • Source/cmake/WebKitFeatures.cmake:
6:24 AM Changeset in webkit [277014] by Carlos Garcia Campos
  • 4 edits in trunk

[SOUP] Wrong cookie timestamp in case of long expire time
​https://bugs.webkit.org/show_bug.cgi?id=225389

Reviewed by Adrian Perez de Castro.

Source/WebCore:

There's an overflow when converting the dates in both libsoup2 and libsoup3, but for two different reasons. In
the case of libsoup2 we are using an int for the conversion of milliseconds to seconds which is not enough. In
the case of libsoup3 we are passing the value in milliseconds to g_date_time_new_from_unix_utc() that expects
seconds.

  • platform/network/soup/CookieSoup.cpp:

(WebCore::msToSoupDate): Use int64_t instead of int for the cast.
(WebCore::Cookie::toSoupCookie const): Convert the value to seconds.

Tools:

Add a test case.

  • TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerLongExpires):
(beforeAll):

6:21 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
6:19 AM WebKitGTK/2.32.x edited by Adrian Perez de Castro
(diff)
6:14 AM Changeset in webkit [277013] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Use WeakHashSet instead of HashSet of raw pointes in Document and SVGDocumentExtensions
​https://bugs.webkit.org/show_bug.cgi?id=225390

Reviewed by Antti Koivisto.

Replaced Document's m_documentSuspensionCallbackElements and m_articleElements as well as
SVGDocumentExtensions's m_timeContainers and m_svgFontFaceElements with WeakHashSet.

Also moved m_svgUseElements from Document to SVGDocumentExtensions as a WeakHashSet.

This patch also deletes Document::m_mediaStreamStateChangeElements which was never used,
m_mainArticleElement a WeakPtr instead of a raw pointer, replaces SVGDocumentExtensions's
m_rebuildElements, which is a temporary Vector used during tree mutations, with a Vector
of Refs instead of raw pointers.

No new tests since there should be no observable behavior differences.

  • dom/Document.cpp:

(WebCore::Document::~Document): The release assert is moved to ~SVGDocumentExtensions.
(WebCore::Document::resolveStyle):
(WebCore::Document::suspend):
(WebCore::Document::resume):
(WebCore::Document::registerForDocumentSuspensionCallbacks):
(WebCore::Document::unregisterForDocumentSuspensionCallbacks):
(WebCore::Document::addSVGUseElement): Moved to SVGDocumentExtensions.
(WebCore::Document::removeSVGUseElement): Ditto.
(WebCore::Document::registerArticleElement):
(WebCore::Document::unregisterArticleElement):
(WebCore::Document::updateMainArticleElementAfterLayout):
(WebCore::Document::prepareCanvasesForDisplayIfNeeded):
(WebCore::Document::clearCanvasPreparation):
(WebCore::Document::canvasChanged):
(WebCore::Document::canvasDestroyed):

  • dom/Document.h:

(WebCore::Document:: const const): Deleted.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
(WebCore::HTMLCanvasElement::didMoveToNewDocument):
(WebCore::HTMLCanvasElement::removedFromAncestor):

  • style/StyleResolver.cpp:

(WebCore::Style::Resolver::addCurrentSVGFontFaceRules):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Moved the release assertion
from ~Document.
(WebCore::SVGDocumentExtensions::addTimeContainer):
(WebCore::SVGDocumentExtensions::removeTimeContainer):
(WebCore::SVGDocumentExtensions::addUseElementWithPendingShadowTreeUpdate): Moved here
Document::addSVGUseElement.
(WebCore::SVGDocumentExtensions::removeUseElementWithPendingShadowTreeUpdate): Ditto.
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::rebuildElements):
(WebCore::SVGDocumentExtensions::clearTargetDependencies):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):
(WebCore::SVGDocumentExtensions::registerSVGFontFaceElement):
(WebCore::SVGDocumentExtensions::unregisterSVGFontFaceElement):

  • svg/SVGDocumentExtensions.h:

(WebCore::SVGDocumentExtensions::useElementsWithPendingShadowTreeUpdate const): Added.
(WebCore::SVGDocumentExtensions::svgFontFaceElements const):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedIntoAncestor):
(WebCore::SVGUseElement::removedFromAncestor):
(WebCore::SVGUseElement::updateShadowTree):
(WebCore::SVGUseElement::invalidateShadowTree):

5:47 AM Changeset in webkit [277012] by commit-queue@webkit.org
  • 2 edits in trunk

Fix typo in comment in WebKitFeatures.cmake
​https://bugs.webkit.org/show_bug.cgi?id=225392

Unreviewed.

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-05

  • Source/cmake/WebKitFeatures.cmake:
5:43 AM WebKitGTK/2.32.x edited by Michael Catanzaro
(diff)
2:49 AM Changeset in webkit [277011] by Chris Lord
  • 6 edits in trunk

OffscreenCanvas should preserve context transform after transferToImageBitmap
​https://bugs.webkit.org/show_bug.cgi?id=225304

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline transferToImageBitmap tests.

  • web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt:
  • web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap.w-expected.txt:

Source/WebCore:

transferToImageBitmap should not affect the state of the canvas
context. Instead of returning the actual canvas buffer, to which the
drawing context is tightly bound, return a copy and clear the
original.

No new tests, rebaselined existing tests.

  • html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::transferToImageBitmap):
(WebCore::OffscreenCanvas::takeImageBuffer const):

  • html/canvas/CanvasRenderingContext2DBase.h:
1:53 AM Changeset in webkit [277010] by youenn@apple.com
  • 8 edits in trunk/Source/WebKit

Dynamically pass capture sandbox extensions to GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=225319

Reviewed by Eric Carlson.

Make sure to send the sandbox extensions for all WKWebView applications.
We do so once we are ready to start capture since TCC access should have been granted at that point.
Manually tested.

  • GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::initializeGPUProcess):
(WebKit::GPUProcess::updateSandboxAccess):

  • GPUProcess/GPUProcess.h:
  • GPUProcess/GPUProcess.messages.in:
  • GPUProcess/GPUProcessCreationParameters.cpp:

(WebKit::GPUProcessCreationParameters::encode const):
(WebKit::GPUProcessCreationParameters::decode):

  • GPUProcess/GPUProcessCreationParameters.h:
  • UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::GPUProcessProxy):
(WebKit::GPUProcessProxy::updateSandboxAccess):
(WebKit::GPUProcessProxy::updateCaptureAccess):
(WebKit::isSafari): Deleted.
(WebKit::shouldCreateCameraSandboxExtension): Deleted.
(WebKit::shouldCreateMicrophoneSandboxExtension): Deleted.

  • UIProcess/GPU/GPUProcessProxy.h:
12:17 AM Changeset in webkit [277009] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.32/Source/WebCore/platform/gtk/po

Merge r277005 - Updated Swedish translation
​https://bugs.webkit.org/show_bug.cgi?id=225309

Patch by Anders Jonsson <​anders.jonsson@norsjovallen.se> on 2021-05-04
Rubber-stamped by Carlos Garcia Campos.

  • sv.po:
Note: See TracTimeline for information about the timeline view.