Timeline

May 14, 2021:

10:46 PM Changeset in webkit [277535] by Chris Dumez

• 28 edits
  1 delete in trunk

Drop FileSystem::fileMetadata() / fileMetadataFollowingSymlinks()
​https://bugs.webkit.org/show_bug.cgi?id=225820

Reviewed by Darin Adler.

Source/JavaScriptCore:

Update our code base because of the FileSystem API changes.

• API/JSScript.mm:

(validateBytecodeCachePath):

Source/WebCore:

Update our code base because of the FileSystem API changes.

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
(WebCore::toFileSystemEntries):
(WebCore::fileTypeIgnoringHiddenFiles):
(WebCore::validatePathIsExpectedType):
(WebCore::DOMFileSystem::getParent):
(WebCore::DOMFileSystem::getEntry):
(WebCore::DOMFileSystem::getFile):

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

• fileapi/File.cpp:

(WebCore::File::isDirectory const):

• html/DirectoryFileListCreator.cpp:

(WebCore::appendDirectoryFiles):
(WebCore::gatherFileInformation):

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::ensureAssetCacheExistsForPath):

• platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::startTrackingModifications):

• platform/network/BlobRegistryImpl.cpp:
• platform/network/FormData.cpp:

(WebCore::FormData::prepareForUpload):

• platform/network/mac/BlobDataFileReferenceMac.mm:

(WebCore::BlobDataFileReference::generateReplacementFile):

Source/WebKit:

Update our code base because of the FileSystem API changes.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::getDirectorySize):
(WebKit::CacheStorage::Engine::getDirectories):
(WebKit::CacheStorage::Engine::clearAllCachesFromDisk):

• NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::traverseDirectory):

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::ensureSandboxCacheDirectory):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::isInternalInstall):

Source/WTF:

Drop FileSystem::fileMetadata() / fileMetadataFollowingSymlinks(). Those don't match very closely the
std::filesystem API we use internally and they are not very efficient because we gather several attributes
of a file but the callers are usually only interested in one thing (e.g. file type or file size).

Callers interested in the file size, can call the pre-existing FileSystem::fileSize(). For call sites
wanting to check if it is a hidden file, I introduced a new FileSystem::isHiddenFile() API. For call sites
interested in the file type, I replaced FileSystem::isDirectory() / FileSystem::isDirectoryFollowingSymlinks()
with more generic FileSystem::fileType() / FileSystem::fileTypeFollowingSymlinks().

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/FileMetadata.h: Removed.
• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::isHiddenFile):
(WTF::FileSystemImpl::fileTypePotentiallyFollowingSymLinks):
(WTF::FileSystemImpl::fileType):
(WTF::FileSystemImpl::fileTypeFollowingSymlinks):

• wtf/FileSystem.h:
• wtf/glib/FileSystemGlib.cpp:
• wtf/posix/FileSystemPOSIX.cpp:
• wtf/win/FileSystemWin.cpp:

Tools:

Update the FileSystem API tests accordingly.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

10:26 PM Changeset in webkit [277534] by wilander@apple.com

• 19 edits in trunk

Javascript can't access a SameSite=Strict cookie after page is loaded after a redirect from a third party site
​https://bugs.webkit.org/show_bug.cgi?id=208049
<rdar://problem/59701889>

Reviewed by Chris Dumez.

The HTTP WG has decided that SameSite=strict cookies should be returned in document.cookie
even in cases where they are not sent in the HTTP request for the page. Chromium and Gecko
now work according to those rules and the spec is being updated.

See:

• ​https://github.com/httpwg/http-extensions/issues/769
• ​https://github.com/httpwg/http-extensions/pull/1428/files.

Source/WebCore:

Here's an excerpt from the spec change:

'If a user agent does return cookies for a given call to a "non-HTTP" API with
an associated Document, then the user agent MUST compute the cookie-string
following the algorithm defined in {{retrieval-algorithm}}, indicating that the
retrieval is from a "non-HTTP" API. The retrieval-uri is the associated
Document's cookie URL {{COOKIE-URL}}, and the retrieval is same-site if the
Document's "site for cookies" is same-site with the top-level origin as defined
in {{document-requests}}.'

Existing layout tests changed and rebased.

• loader/CookieJar.cpp:

(WebCore::CookieJar::sameSiteInfo):

Now takes a IsCookieAccessForDOM parameter and forwards it to SameSiteInfo::create().

(WebCore::CookieJar::cookies const):

Now sends IsCookieAccessForDOM::Yes to CookieJar::sameSiteInfo().

(WebCore::CookieJar::setCookies):

Now sends IsCookieAccessForDOM::Yes to CookieJar::sameSiteInfo().

• loader/CookieJar.h:
• platform/network/SameSiteInfo.cpp:

(WebCore::SameSiteInfo::create):

Now takes a IsForDOMCookieAccess parameter and if it's IsForDOMCookieAccess::Yes and
the site is top site, sets isSameSite.

• platform/network/SameSiteInfo.h:

Now has an enum IsForDOMCookieAccess.

Source/WebKit:

Here's an excerpt from the spec change:

'If a user agent does return cookies for a given call to a "non-HTTP" API with
an associated Document, then the user agent MUST compute the cookie-string
following the algorithm defined in {{retrieval-algorithm}}, indicating that the
retrieval is from a "non-HTTP" API. The retrieval-uri is the associated
Document's cookie URL {{COOKIE-URL}}, and the retrieval is same-site if the
Document's "site for cookies" is same-site with the top-level origin as defined
in {{document-requests}}.'

Existing layout tests changed and rebased.

• WebProcess/WebPage/WebCookieJar.cpp:

(WebKit::WebCookieJar::cookies const):

Now sends WebCore::IsCookieAccessForDOM::Yes to WebCore::CookieJar::sameSiteInfo().

(WebKit::WebCookieJar::setCookies):

Now sends WebCore::IsCookieAccessForDOM::Yes to WebCore::CookieJar::sameSiteInfo().

LayoutTests:

Tests changed and rebased accordingly.

• http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/popup-cross-site-post.html:
• http/tests/cookies/same-site/popup-cross-site.html:
• http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html:
• http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.py:
• http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-from-cross-origin-page.py:
• http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.py:
• http/tests/cookies/same-site/user-load-cross-site-redirect-expected.txt:
• http/tests/cookies/same-site/user-load-cross-site-redirect.py:

10:02 PM Changeset in webkit [277533] by Jonathan Bedard

• 4 edits in trunk/Tools

[WebKitTestRunner] Forward WebContent termination reason
​https://bugs.webkit.org/show_bug.cgi?id=225818
<rdar://problem/78027164>

Reviewed by Chris Dumez.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage): Use didTerminate callback instead of didCrash callback.
(WTR::TestController::createWebViewWithOptions): Ditto.
(WTR::TestController::webProcessDidTerminate):
(WTR::TestController::processDidCrash): Renamed webProcessDidTerminate.

• WebKitTestRunner/TestController.h: Replace processDidCrash with webProcessDidTerminate.
• WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformRunUntil):

9:59 PM Changeset in webkit [277532] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Provide custom SetInlineFillGradient copy ctor
​https://bugs.webkit.org/show_bug.cgi?id=225688

Patch by Rob Buis <​rbuis@igalia.com> on 2021-05-14
Reviewed by Wenson Hsieh.

Provide custom SetInlineFillGradient copy ctor
to deal with invalid SetInlineFillGradient source.

• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::SetInlineFillGradient::SetInlineFillGradient):

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::SetInlineFillGradient::isValid const):

9:58 PM Changeset in webkit [277531] by Jonathan Bedard

• 3 edits in trunk/Tools

[run-webkit-tests] Handle missing simulator state plist
​https://bugs.webkit.org/show_bug.cgi?id=225833
<rdar://problem/78036930>

Rubber-stamped by Aakash Jain.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.state): If no device plist is found, assume the device is shut down.

• Scripts/webkitpy/xcode/simulated_device_unittest.py:

9:18 PM Changeset in webkit [277530] by Chris Dumez

• 32 edits
  17 deletes in trunk/Source

Drop legacy / prefixed WebAudio implementation
​https://bugs.webkit.org/show_bug.cgi?id=225832

Reviewed by Darin Adler.

Source/WebCore:

Drop legacy / prefixed WebAudio implementation now that it is no longer
present in shipping and we have received any reports of issues.

This drops all the legacy code but she should be able to clean up the
code further in follow-ups. In particular, I believe some code can
now be moved from BaseAudioContext to OfflineAudioContext.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::~AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::totalPitchRate):

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):

• Modules/webaudio/AudioContext.h:
• Modules/webaudio/AudioListener.h:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.cpp:
• Modules/webaudio/AudioNode.h:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioParam.h:
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):

• Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::isOfflineContext const):
(WebCore::BaseAudioContext::BaseAudioContext):

• Modules/webaudio/DynamicsCompressorNode.cpp:
• Modules/webaudio/DynamicsCompressorNode.h:
• Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::OfflineAudioContext):

• Modules/webaudio/OscillatorNode.h:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/WebKitAudioBufferSourceNode.h: Removed.
• Modules/webaudio/WebKitAudioBufferSourceNode.idl: Removed.
• Modules/webaudio/WebKitAudioContext.cpp: Removed.
• Modules/webaudio/WebKitAudioContext.h: Removed.
• Modules/webaudio/WebKitAudioContext.idl: Removed.
• Modules/webaudio/WebKitAudioListener.h: Removed.
• Modules/webaudio/WebKitAudioListener.idl: Removed.
• Modules/webaudio/WebKitAudioPannerNode.cpp: Removed.
• Modules/webaudio/WebKitAudioPannerNode.h: Removed.
• Modules/webaudio/WebKitAudioPannerNode.idl: Removed.
• Modules/webaudio/WebKitDynamicsCompressorNode.h: Removed.
• Modules/webaudio/WebKitDynamicsCompressorNode.idl: Removed.
• Modules/webaudio/WebKitOfflineAudioContext.cpp: Removed.
• Modules/webaudio/WebKitOfflineAudioContext.h: Removed.
• Modules/webaudio/WebKitOfflineAudioContext.idl: Removed.
• Modules/webaudio/WebKitOscillatorNode.h: Removed.
• Modules/webaudio/WebKitOscillatorNode.idl: Removed.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• testing/Internals.cpp:

(WebCore::Internals::setAudioContextRestrictions):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKitLegacy/win:

Stop explicitly disabled with prefixed WebAudio implementation given that
it no longer exists.

• WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:

Drop preference for prefixed WebAudio, which was disabled everywhere.

• Scripts/Preferences/WebPreferencesInternal.yaml:

8:34 PM Changeset in webkit [277529] by weinig@apple.com

• 3 edits
  2 moves in trunk/Source/WebCore

CustomPaintImage being in platform/graphics is a layering violation
​https://bugs.webkit.org/show_bug.cgi?id=225356

Reviewed by Darin Adler.

It is layering violation for a file in platform/ to reference classes
like RenderElement or PaintWorkletGlobalScope. This fixes this by moving
CustomPaintImage out of platform/graphics to html/, next to the existing
CustomPaintCanvas class.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/CustomPaintImage.cpp: Copied from Source/WebCore/platform/graphics/CustomPaintImage.cpp.
• html/CustomPaintImage.h: Copied from Source/WebCore/platform/graphics/CustomPaintImage.h.
• platform/graphics/CustomPaintImage.cpp: Removed.
• platform/graphics/CustomPaintImage.h: Removed.

8:15 PM Changeset in webkit [277528] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r269824): Random tile corruption when scrolling/zooming in macCatalyst
​https://bugs.webkit.org/show_bug.cgi?id=225837
<rdar://problem/75053997>

Reviewed by Simon Fraser.

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
Mark the newly front buffer non-volatile before painting into it.
This was lost in r269824. Oddly, this caused less trouble than
one might expect, except on some particular hardware.

7:05 PM Changeset in webkit [277527] by Darin Adler

• 22 edits in trunk

output element doesn't react properly to node tree mutations
​https://bugs.webkit.org/show_bug.cgi?id=196532

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

• web-platform-tests/custom-elements/builtin-coverage-expected.txt:

Updated since HTMLOptionElement now has a constructor. Still not passing, but closer to correct.

• web-platform-tests/custom-elements/form-associated/form-reset-callback-expected.txt:

Updated due to changes in HTMLOptionElement, but still not passing.

• web-platform-tests/html/semantics/forms/the-output-element/mutations.window-expected.txt:

Updated to reflect passing test.

• web-platform-tests/html/semantics/forms/the-output-element/mutations.window.js:

Updated to a newer version of the upstream version of this. Decided to just update this one file
rather than importing the latest version across more tests at this time.

Source/WebCore:

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAll): Refactored most of the functions
replaceAllChildren and replaceAllChildrenWithNewText into this new one,
and named it based on the name of the operation in the HTML specification.
The function is incomplete, but preserves existing behavior.
(WebCore::ContainerNode::stringReplaceAll): Refactored the rest of the
replaceAllChildrenWithNewText function and renamed to the name from the
HTML specification.

• dom/ContainerNode.h: Updated for the above changes.

• dom/Node.cpp:

(WebCore::Node::setTextContent): Updated for name change above.

• dom/Range.cpp:

(WebCore::Range::surroundContents): Ditto.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Ditto.

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText): Ditto.

• html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::HTMLOutputElement): Moved data member
initialization into the class definition.
(WebCore::HTMLOutputElement::create): Added an overload that takes just
a document, for use when invoked from as a constructor.
(WebCore::HTMLOutputElement::parseAttribute): Tightened the logic for the
for attribute. I decided it's better to call through to the base class, even
though we often don't do that for attributes that don't expect the base
class to pay attention to.
(WebCore::HTMLOutputElement::childrenChanged): Deleted. No need for this in
the improved HTML specification version of this element's algorithms.
(WebCore::HTMLOutputElement::reset): Updated based on the HTML specification,
using the default value algorithm rather than the default value mode flag we
were using before.
(WebCore::HTMLOutputElement::setValue): Updated based on the HTML specification,
always setting the default value override based on the current default value,
and using stringReplaceAll. There's no need for the old setTextContentInternal,
since that was all due to the need to avoid infinite recursion in childrenChanged.
(WebCore::HTMLOutputElement::defaultValue const): Updated based on the HTML
specification, deriving the default value from the default value override and
the descendant text content.
(WebCore::HTMLOutputElement::setDefaultValue): Updated based on the HTML
specification, doing a string replace all with the value if the default
value override is null, and updating the default value override otherwise.
(WebCore::HTMLOutputElement::htmlFor): Updated to rename m_tokens to m_forTokens.
(WebCore::HTMLOutputElement::setTextContentInternal): Deleted.

• html/HTMLOutputElement.h: Moved DOMTokenList to be a forward declaration

instead of an include. Adde a constructor that takes only a document to be used
from JavaScript. Made the canContainRangeEndPoint override be private like the
other overrides. Removed the childrenChange override and the
setTextContentInternal function. Removed m_isDefaultValueMode,
m_isSetTextContentInProgress, and m_defaultValue. Added m_defaultValueOverride.
Renamed m_tokens to m_forTokens.

• html/HTMLOutputElement.idl: Updated to match the HTML specification. This

involved adding a constructor, adding SameObject for the htmlFor attribute,
making the form attribute nullable, and removing [LegacyNullToEmptyString]
from the defaultValue and value attributes.

LayoutTests:

• TestExpectations: Removed an expectation for a directory that no longer exists.
• platform/mac-wk2/TestExpectations: Removed an expectation for a test that no longer exists.
• platform/mac/TestExpectations: Removed an expectation for a directory that no longer exists.

• platform/gtk/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:

Updated since HTMLOptionElement now has a constructor. Still not passing, but closer to correct.

6:50 PM Changeset in webkit [277526] by Jonathan Bedard

• 4 edits in trunk

Fix iOS 14.5 embedded build
​https://bugs.webkit.org/show_bug.cgi?id=225835
<rdar://problem/78039315>

Reviewed by Dewei Zhu.

Source/WebKit:

No new tests, build fix.

• WebProcess/cocoa/WebProcessCocoa.mm: Import mach.h.

Tools:

• Scripts/configure-xcode-for-embedded-development: Add mach.h, mach_error.h and task.h.

5:59 PM Changeset in webkit [277525] by weinig@apple.com

• 38 edits in trunk/Source

Source/WebCore:
Use PixelBufferFormat to specify ImageBuffer::getPixelData destination format allowing for more control over data conversion
​https://bugs.webkit.org/show_bug.cgi?id=225813

Reviewed by Darin Adler.

The reprevious signature of ImageBuffer::getPixelBuffer:

ImageBuffer::getPixelBuffer(AlphaPremultiplication, const IntRect&);

only allowed specifying the type of alpha premultiplication wanted, and hard coded
a pixel format of RGBA8 and color space of SRGB. To support accurate and efficient
access to pixel buffers with different pixel formats and color spaces we need to be
able to tell getPixelBuffer what we want up front, so that if the ImageBuffer already
has a DisplayP3 buffer, and we want DisplayP3 pixels, we don't first convert to SRGB
and then convert back to DisplayP3 (which would be slow and lose any out of gamut
data). The new signature allows us to specify the entire format triple:

ImageBuffer::getPixelBuffer(const PixelBufferFormat&, const IntRect&);

Additionally, ImageBuffer::putPixelBuffer() no longer needs to provide the source
AlphaPremultiplication either, as the PixelBuffer itself also contains that information.

Now that we are passing color space information, we need to support color space conversion,
so PixelBufferConversion was updated to support color space conversion on CG platforms
using vImageConvert_AnyToAny. This is not currently excersised, but will be in a subsequent
change where canvas ImageData gains a color space setting, at which point it can be tested.

We also don't currently support color space conversion on non-CG platforms. This won't
be a problem in the short term, as only CG platforms support DisplayP3, the only other
color space that can be specified currently, but as cleanup, we should add support for
color space conversion using the ColorConversion and ColorTransferFunction infrastructure
for other ports, moving the existing support for SRGB to/from LinearSRGB conversions from
ImageBufferCairoBackend and ImageBufferCairoImageSurfaceBackend.

• html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise):

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::getImageData const):
(WebCore::CanvasRenderingContext2DBase::putImageData):

• page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

• platform/graphics/ConcreteImageBuffer.h:

(WebCore::ConcreteImageBuffer::putPixelBuffer):

• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::putPixelBuffer):

• platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::convertToLuminanceMask):
(WebCore::ImageBufferBackend::getPixelBuffer const):
(WebCore::ImageBufferBackend::putPixelBuffer):

• platform/graphics/ImageBufferBackend.h:
• platform/graphics/PixelBufferConversion.cpp:

(WebCore::makeVImageCGImageFormat):
(WebCore::makeVImageBuffer):
(WebCore::convertImagePixelsAccelerated):
(WebCore::convertImagePixels):

• platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

• platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp:

(WebCore::ImageBufferCairoSurfaceBackend::getPixelBuffer const):
(WebCore::ImageBufferCairoSurfaceBackend::putPixelBuffer):

• platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h:
• platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::toCFData const):

• platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:

(WebCore::ImageBufferCGBitmapBackend::getPixelBuffer const):
(WebCore::ImageBufferCGBitmapBackend::putPixelBuffer):

• platform/graphics/cg/ImageBufferCGBitmapBackend.h:
• platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::getPixelBuffer const):
(WebCore::ImageBufferIOSurfaceBackend::putPixelBuffer):

• platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::PutPixelBuffer::PutPixelBuffer):
(WebCore::DisplayList::PutPixelBuffer::swap):
(WebCore::DisplayList::operator<<):

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::GetPixelBuffer::GetPixelBuffer):
(WebCore::DisplayList::GetPixelBuffer::outputFormat const):
(WebCore::DisplayList::PutPixelBuffer::encode const):
(WebCore::DisplayList::PutPixelBuffer::decode):
(WebCore::DisplayList::PutPixelBuffer::inputFormat const): Deleted.

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::getPixelBuffer):
(WebCore::DisplayList::Recorder::putPixelBuffer):

• platform/graphics/displaylists/DisplayListRecorder.h:
• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

• platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::convertPixelBufferToColorSpace):
(WebCore::FilterEffect::convertImageBufferToColorSpace):
(WebCore::FilterEffect::copyConvertedPixelBufferToDestination):
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):

• platform/graphics/filters/FilterEffect.h:
• platform/graphics/win/ImageBufferDirect2DBackend.cpp:

(WebCore::ImageBufferDirect2DBackend::getPixelBuffer const):
(WebCore::ImageBufferDirect2DBackend::putPixelBuffer):

• platform/graphics/win/ImageBufferDirect2DBackend.h:
• rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

Source/WebKit:
Use PixelBufferFormat to specify ImageBuffer::getPixelBuffer destination format allowing for more control over data conversion
​https://bugs.webkit.org/show_bug.cgi?id=225813

Reviewed by Darin Adler.

Update calls/implementations of getPixelBuffer/putPixelBuffer to adjust
to new signature.

• GPUProcess/graphics/RemoteImageBuffer.h:
• Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:

(WebKit::CGDisplayListImageBufferBackend::getPixelBuffer const):
(WebKit::CGDisplayListImageBufferBackend::putPixelBuffer):

• Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
• WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::getPixelBuffer const):
(WebKit::ImageBufferShareableBitmapBackend::putPixelBuffer):

• WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::putPixelBuffer):

• WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableIOSurfaceBackend::getPixelBuffer const):
(WebKit::ImageBufferShareableIOSurfaceBackend::putPixelBuffer):

• WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.h:

5:47 PM Changeset in webkit [277524] by Ross Kirsling

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r277221): 2 test262 tests failing
​https://bugs.webkit.org/show_bug.cgi?id=225819

Reviewed by Alexey Shvayka.

Undo the other part of r277221's code consolidation --
I'd forgotten that this exists to enforce a evaluation order on AggregateError's arguments.

• runtime/AggregateError.cpp:

(JSC::createAggregateError):

5:29 PM Changeset in webkit [277523] by Devin Rousso

• 12 edits
  2 adds in trunk

Sampled Page Top Color: move logic out of Document
​https://bugs.webkit.org/show_bug.cgi?id=225480
<rdar://problem/77984539>

Reviewed by Tim Horton.

Source/WebCore:

Having determineSampledPageTopColor be called in enqueuePaintTimingEntryIfNeeded as what
is basically a side effect is not great. The only reason it was there in the first place was
to take advantage of the logic that decided "is this the first contentful paint", but that
logic can be replicated elsewhere. Since the sampled page top color deals more with the page
as a whole instead of an individual Document (which includes subframes), it makes more
sense to have this logic be on a utility PageColorSampler that's used in Page instead.

Test: SampledPageTopColor.MainDocumentChange

• page/PageColorSampler.h: Added.
• page/PageColorSampler.cpp: Added.

(WebCore::isValidSampleLocation):
(WebCore::sampleColor):
(WebCore::colorDifference):
(WebCore::averageColor):
(WebCore::PageColorSampler::sampleTop):

• page/Page.h:
• page/Page.cpp:

(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::sampledPageTopColor const):
(WebCore::Page::didChangeMainDocument):

• dom/Document.h:

(WebCore::Document::sampledPageTopColor const): Deleted.

• dom/Document.cpp:

(WebCore::Document::enqueuePaintTimingEntryIfNeeded):
(WebCore::isValidPageSampleLocation): Deleted.
(WebCore::samplePageColor): Deleted.
(WebCore::colorDifference): Deleted.
(WebCore::averageColor): Deleted.
(WebCore::Document::determineSampledPageTopColor): Deleted.

• page/FrameView.h:
• page/FrameView.cpp:

(WebCore::FrameView::hasContentfulDescendants const): Added.
(WebCore::FrameView::hasContenfulDescendants const): Deleted.
Drive-by: Fix incorrect spelling.

• Source/WebCore/Headers.cmake:
• Source/WebCore/Sources.txt:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(TEST.SampledPageTopColor.MainDocumentChange): Added.

5:26 PM Changeset in webkit [277522] by Chris Dumez

• 6 edits in trunk

Port WTF::FileSystem::realPath() to std::filesystem
​https://bugs.webkit.org/show_bug.cgi?id=225828

Reviewed by Darin Adler.

Source/WTF:

Port WTF::FileSystem::realPath() to std::filesystem (in particular std::filesystem::canonical())
so that we no longer need platform-specific code.

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::realPath):

• wtf/posix/FileSystemPOSIX.cpp:
• wtf/win/FileSystemWin.cpp:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

5:18 PM Changeset in webkit [277521] by Alan Coon

• 8 edits in branches/safari-612.1.12-branch/Source

Versioning.

WebKit-7612.1.12.9

5:00 PM Changeset in webkit [277520] by eric.carlson@apple.com

• 5 edits
  2 adds in trunk

[GPUP] a media element with a data url and "crossorigin='anonymous'" doesn't load
​https://bugs.webkit.org/show_bug.cgi?id=225786
<rdar://77625185>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/data-url-cross-origin.html

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource): Set loader options sameOriginDataURLFlag
to SameOriginDataURLFlag::Set so data: urls are treated as same origin.

LayoutTests:

• media/data-url-cross-origin-expected.txt: Added.
• media/data-url-cross-origin.html: Added.
• media/media-file.js:

(findDataURL):

• media/sources-fallback-codecs.html:

4:46 PM Changeset in webkit [277519] by Peng Liu

• 4 edits in trunk

REGRESSION: [ Mac WK2 ] fast/mediastream/audio-track-enabled.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=221985

Reviewed by Eric Carlson.

Source/WebCore:

When MediaSessionManagerCocoa::updateSessionState() goes through all sessions, it
counts all WebAudio sessions regardless their states, and it may set the shared audio
session's category to be AudioSession::AmbientSound if the count of WebAudio sessions
is not zero.

However, when we close a page with WebAudio, we should not count the WebAudio session
here because the corresponding AudioContext is suspended and will be destroyed soon.
Without this patch, the shared audio session's category might be AudioSession::AmbientSound
after we close the WebAudio page.

• Modules/webaudio/AudioContext.h:

LayoutTests:

• platform/mac-wk2/TestExpectations:

4:34 PM Changeset in webkit [277518] by Patrick Angle

• 2 edits in trunk/Source/WebKit

Web Inspector: _WKInspector leaks WebInspectorUIProxy
​https://bugs.webkit.org/show_bug.cgi?id=225815

Reviewed by Tim Horton.

Add a missing call in _WKInspector's destructor to destruct the WebInspectorUIProxy in API object storage.

• UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector dealloc]):

4:30 PM Changeset in webkit [277517] by Alan Coon

• 1 copy in tags/Safari-612.1.12.8

Tag Safari-612.1.12.8.

4:20 PM Changeset in webkit [277516] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[showRenderTree] Do not integral floor the overflow values
​https://bugs.webkit.org/show_bug.cgi?id=225825

Reviewed by Simon Fraser.

Integral flooring may hide fractional values caused by rounding bugs.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::outputRenderObject const):

4:12 PM Changeset in webkit [277515] by Chris Dumez

• 23 edits in trunk

Drop "get" prefix from WTF::FileSystem's getFileModificationTime() / getFileCreationTime()
​https://bugs.webkit.org/show_bug.cgi?id=225812

Reviewed by Darin Adler.

Source/WebCore:

Update code base due to WTF API change.

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::removeAllDatabasesForFullOriginPath):

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabasesModifiedSince):

• fileapi/File.cpp:

(WebCore::File::lastModified const):

• page/Page.cpp:

(WebCore::Page::userStyleSheet const):

• platform/FileStream.cpp:

(WebCore::FileStream::getSize):

• platform/network/FormData.cpp:

(WebCore::FormDataElement::EncodedFileData::fileModificationTimeMatchesExpectation const):

• platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::parseResponseHeaders):

• platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::databaseCreationTime):
(WebCore::SQLiteFileSystem::databaseModificationTime):

Source/WebKit:

Update code base due to WTF API change.

• NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::fileTimes):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeMediaKeys):

• WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::removeAllMediaKeyStorageForOriginPath):

Source/WebKitLegacy/win:

Update code base due to WTF API change.

• Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):

Source/WTF:

We avoid the "get" prefix in WebKit.

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::fileModificationTime):

• wtf/FileSystem.h:
• wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::fileCreationTime):

• wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::fileCreationTime):

• wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::fileCreationTimeFromFindData):
(WTF::FileSystemImpl::fileModificationTimeFromFindData):
(WTF::FileSystemImpl::fileCreationTime):

Tools:

Update code base due to WTF API change.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::runGetFileModificationTimeTest):
(TestWebKitAPI::TEST_F):

4:08 PM Changeset in webkit [277514] by Chris Dumez

• 7 edits in trunk

Rename FileSystem::getVolumeFreeSpace() to FileSystem::volumeFreeSpace()
​https://bugs.webkit.org/show_bug.cgi?id=225811

Reviewed by Darin Adler.

Source/WebKit:

Update code base due to API change.

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::computeCapacity):

Source/WTF:

Rename FileSystem::getVolumeFreeSpace() to FileSystem::volumeFreeSpace() given that we
avoid the "get" prefix in WebKit. Also modernize the function by returning an
Optional<uint64_t> instead of using an out-parameter.

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::volumeFreeSpace):

• wtf/FileSystem.h:

Tools:

Update code base due to API change.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

3:32 PM Changeset in webkit [277513] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Add enclosing line top/bottom to showInlineTreeAndRuns
​https://bugs.webkit.org/show_bug.cgi?id=225821

Reviewed by Simon Fraser.

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::showInlineTreeAndRuns):

• page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):

3:27 PM Changeset in webkit [277512] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Add ScriptDisallowedScope to MediaPlayerPrivateAVFoundation
​https://bugs.webkit.org/show_bug.cgi?id=225797

Reviewed by Eric Carlson.

Deployed ScriptDisallowedScope to a bunch of functions in MediaPlayerPrivateAVFoundation.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):

3:26 PM Changeset in webkit [277511] by Robert Jenner

• 2 edits in trunk/LayoutTests

[ iOS14-Simulator ] wk2imported/w3c/web-platform-tests/css/css-will-change/will-change-transform-huge-offset-scrolled.html is a flaky ImageOnlyFailure
Nhttps://bugs.webkit.org/show_bug.cgi?id=225830

Unreviewed test gardening.

Setting expectation to Pass ImageOnlyFailure due to causing an EWS slowdown.

• platform/ios-simulator-wk2/TestExpectations:

3:23 PM Changeset in webkit [277510] by Wenson Hsieh

• 3 edits in trunk/Source/WebKit

Replace -[WKContentView _hasPendingImageExtraction] with a monotonically increasing ID
​https://bugs.webkit.org/show_bug.cgi?id=225823
rdar://77519437

Reviewed by Tim Horton.

Refactor some image extraction code by turning this boolean flag into a monotonically increasing
ObjectIdentifier instead; see the bug for more details.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _doAfterPendingImageExtraction:]):
(-[WKContentView _invokeAllActionsToPerformAfterPendingImageExtraction:]):

3:23 PM Changeset in webkit [277509] by Russell Epstein

• 1 copy in tags/Safari-612.1.15

Tag Safari-612.1.15.

3:18 PM Changeset in webkit [277508] by Jean-Yves Avenard

• 2 edits in trunk/Tools

TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
​https://bugs.webkit.org/show_bug.cgi?id=223282
rdar://75495585

Reviewed by Jer Noble.

• TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:

(TestWebKitAPI::TEST): Use WkView/NSWindow directly instead of using a
PlatformWebView. A PlatformWebView uses an OffscreenWindow which is a
NSWindow placed with a -10000 offset. This configuration appears to fail
to go into full screen in automation.

3:02 PM Changeset in webkit [277507] by Jean-Yves Avenard

• 6 edits in trunk

Bad media session artwork URL results in blue "broken image" icon being shown in Now Playing
​https://bugs.webkit.org/show_bug.cgi?id=225799
rdar://77990886

Reviewed by Eric Carlson.

Source/WebCore:

By default, when the image's URL doesn't point to an image the CachedImage
will return a default image consistent of a blue interrogation mark.
We need to explicitely check that an error occurred. The naming used in the
method didn't make this need obvious.

• Modules/mediasession/MediaMetadata.cpp:

(WebCore::ArtworkImageLoader::notifyFinished): Check for a status error.

• testing/Internals.cpp:

(WebCore::Internals::loadArtworkImage): Fix spelling

LayoutTests:

• fast/mediasession/metadata/artworkdownload-expected.txt:
• fast/mediasession/metadata/artworkdownload.html: Add test case.

2:35 PM Changeset in webkit [277506] by weinig@apple.com

• 2 edits in trunk/Tools

REGRESSION(r277313): [ Debug ] 2 TestWebKitAPI.IPCTestingAPI (API-Tests) are constant timeouts
​https://bugs.webkit.org/show_bug.cgi?id=225816
<rdar://problem/78025515>

Reviewed by Ryosuke Niwa.

• TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

Update test for rename from ImageData to PixelBuffer.

2:34 PM Changeset in webkit [277505] by Devin Rousso

• 29 edits
  1 add
  1 delete in trunk

Promote -[WKWebView _pageExtendedBackgroundColor] SPI to -[WKWebView underPageBackgroundColor] API
​https://bugs.webkit.org/show_bug.cgi?id=225615
<rdar://problem/76568094>

Reviewed by Wenson Hsieh.

Source/WebCore:

underPageBackgroundColor is a null_resettable property that will return (in order of validity)

• the most recent non-null value provided
• the CSS background-color of the <body> and/or <html> (this is the current value of _pageExtendedBackgroundColor)
• the underlying platform view's background color

Modifications to this property will not have any effect until control is returned to the runloop.

Tests: WKWebViewUnderPageBackgroundColor.OnLoad

WKWebViewUnderPageBackgroundColor.SingleSolidColor
WKWebViewUnderPageBackgroundColor.SingleBlendedColor
WKWebViewUnderPageBackgroundColor.MultipleSolidColors
WKWebViewUnderPageBackgroundColor.MultipleBlendedColors
WKWebViewUnderPageBackgroundColor.KVO
WKWebViewUnderPageBackgroundColor.MatchesScrollView

• page/Page.h:

(WebCore::Page::underPageBackgroundColorOverride const): Added.

• page/Page.cpp:

(WebCore::Page::setUnderPageBackgroundColorOverride): Added.
Hold the client-overriden value for underPageBackgroundColor so that it can be used when
drawing the overscroll layer.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForOverhangAreasBackgroundColor):
Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColor and
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

• dom/Document.cpp:

(WebCore::Document::themeColorChanged):
It's no longer necessary to force the overscroll area to redraw since that'll be handled by
a client calling -[WKWebView setUnderPageBackgroundColor:] (possibly in response to a
-[WKWebView themeColor] KVO notification).

Source/WebKit:

underPageBackgroundColor is a null_resettable property that will return (in order of validity)

• the most recent non-null value provided
• the CSS background-color of the <body> and/or <html> (this is the current value of _pageExtendedBackgroundColor)
• the underlying platform view's background color

Modifications to this property will not have any effect until control is returned to the runloop.

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView underPageBackgroundColor]): Added.
(-[WKWebView setUnderPageBackgroundColor:]): Added.
(+[WKWebView automaticallyNotifiesObserversOfUnderPageBackgroundColor]): Added.

• UIProcess/API/ios/WKWebViewIOS.mm:

(baseScrollViewBackgroundColor):
(scrollViewBackgroundColor):
Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColor and
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::underPageBackgroundColor const): Added.
(WebKit::WebPageProxy::setUnderPageBackgroundColorOverride): Added.
(WebKit::WebPageProxy::pageExtendedBackgroundColorDidChange):
(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Added.
(WebKit::WebPageProxy::scrollAreaBackgroundColor const): Deleted.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Added.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Added.
Store the client-overriden value for underPageBackgroundColor and manage state changes.

• UIProcess/PageClient.h:

(WebKit::PageClient::underPageBackgroundColorWillChange): Added.
(WebKit::PageClient::underPageBackgroundColorDidChange): Added.

• UIProcess/Cocoa/PageClientImplCocoa.h:
• UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::underPageBackgroundColorWillChange): Added.
(WebKit::PageClientImplCocoa::underPageBackgroundColorDidChange): Added.
Add ObjC KVO support for -[WKWebView underPageBackgroundColor].

• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::contentViewBackgroundColor): Added.
Provide a way to get the backgroundColor of the WKContentView. This is needed on iOS
because scrollViewBackgroundColor (now WebPageProxy::platformUnderPageBackgroundColor)
would use this value before falling back to the underlying platform view's background color.

• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUnderPageBackgroundColorOverride): Added.
Pass the client-overriden value for underPageBackgroundColor to the WebProcess so that it
can be used when drawing the overscroll layer.

• UIProcess/ViewSnapshotStore.cpp:

(WebKit::ViewSnapshotStore::recordSnapshot):
Go back to using the pageExtendedBackgroundColor (before r273083).

Source/WTF:

underPageBackgroundColor is a null_resettable property that will return (in order of validity)

• the most recent non-null value provided
• the CSS background-color of the <body> and/or <html> (this is the current value of _pageExtendedBackgroundColor)
• the underlying platform view's background color

Modifications to this property will not have any effect until control is returned to the runloop.

• Scripts/Preferences/WebPreferencesInternal.yaml:

Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColorand
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewUnderPageBackgroundColor.mm: Renamed from PageExtendedBackgroundColor.mm.

(defaultBackgroundColor): Added.
(TEST.WKWebViewUnderPageBackgroundColor.OnLoad):
(TEST.WKWebViewUnderPageBackgroundColor.SingleSolidColor): Added.
(TEST.WKWebViewUnderPageBackgroundColor.SingleBlendedColor): Added.
(TEST.WKWebViewUnderPageBackgroundColor.MultipleSolidColors): Added.
(TEST.WKWebViewUnderPageBackgroundColor.MultipleBlendedColors): Added.
(-[WKWebViewUnderPageBackgroundColorObserver initWithWebView:]): Added.
(-[WKWebViewUnderPageBackgroundColorObserver observeValueForKeyPath:ofObject:change:context:]): Added.
(TEST.WKWebViewUnderPageBackgroundColor.KVO):
(TEST.WKWebViewUnderPageBackgroundColor.MatchesScrollView): Added.
(TEST.WKWebViewUnderPageBackgroundColor.MultipleStyles): Deleted.
(-[WKWebViewPageExtendedBackgroundColorObserver initWithWebView:]): Deleted.
(-[WKWebViewPageExtendedBackgroundColorObserver observeValueForKeyPath:ofObject:change:context:]): Deleted.

• TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(createWebViewWithSampledPageTopColorMaxDifference):
(TEST.SampledPageTopColor.ExperimentalUseSampledPageTopColorForScrollAreaBackgroundColor): Deleted.

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewThemeColor.mm:

(createWebView): Deleted.
(TEST.WKWebView.ExperimentalUseThemeColorForScrollAreaBackgroundColor): Deleted.
Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColor and
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

2:26 PM Changeset in webkit [277504] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix a build after r277493

• editing/cocoa/AttributedString.h:

I removed an unneeded NSDictionary declaration that was being used here.

1:33 PM Changeset in webkit [277503] by Lauro Moura

• 2 edits in trunk/LayoutTests

[WPE] Bot exiting early with crashes in new window layout tests inside wl_proxy_marshal_constructor
​https://bugs.webkit.org/show_bug.cgi?id=225555

Unreviewed test gardening.

Basically revert the changes from r277223 as the SDK was updated with
a new wpebackend-fdo in r277436.

• platform/wpe/TestExpectations:

1:18 PM Changeset in webkit [277502] by Russell Epstein

• 8 edits in branches/safari-612.1.12-branch/Source

Versioning.

WebKit-7612.1.12.8

11:56 AM Changeset in webkit [277501] by Devin Rousso

• 7 edits in trunk

[iOS] contextmenu hints can be clipped by the WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=224204
<rdar://problem/77089174>

Reviewed by Wenson Hsieh.

Source/WebKit:

r275562 tried to fix this by moving the interaction previews to a separate UIWindow, but
this had the unfortunate consequence of placing those previews on top of everything in the
current UIWindow (e.g. above the share sheet). As such, WebKit can't use a UIWindow for
this as the WKWebView has no idea what the view hierarchy above it looks like.

Test: ContextMenu.HintPreviewContainer

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

Add new SPI -[WKUIDelegate _contextMenuHintPreviewContainerViewForWebView:] that's used as
the container for the UIPreviewTarget created for the contextmenu hint preview.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):
(-[WKContentView cleanUpInteractionPreviewContainers]): Added.
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _createPreviewContainerWithLayerName:]):
(-[WKContentView containerForDropPreviews]):
(-[WKContentView _removeContainerForDropPreviews]): Added.
(-[WKContentView containerForDragPreviews]):
(-[WKContentView _removeContainerForDragPreviews]): Added.
(-[WKContentView containerForContextMenuHintPreviews]):
(-[WKContentView _removeContainerForContextMenuHintPreviews]): Added.
(-[WKContentView cleanUpDragSourceSessionState]):
(-[WKContentView _removeContextMenuViewIfPossible]):
(-[WKContentView dropInteraction:concludeDrop:]):
(-[WKContentView _hideTargetedPreviewContainerViews]): Deleted.
Clean up and centralize logic around creating and removing interaction preview containers.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView didMoveToWindow]):
If the WKWebView is removed from it's parent, make sure to remove the contextmenu hint
preview as well as it could be outside the view hierarchy of the WKWebView from the SPI.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:

(-[TestContextMenuHintPreviewContainerUIDelegate webView:contextMenuWillPresentForElement:]): Added.
(-[TestContextMenuHintPreviewContainerUIDelegate _contextMenuHintPreviewContainerViewForWebView:]): Added.
(TEST.ContextMenu.HintPreviewContainer): Added.

11:34 AM Changeset in webkit [277500] by mark.lam@apple.com

• 9 edits in trunk/Source/JavaScriptCore

Implement Baseline JIT property access slow paths using JIT thunks.
​https://bugs.webkit.org/show_bug.cgi?id=225771

Reviewed by Yusuke Suzuki and Saam Barati.

This patch applies the following strategy to Baseline JIT property access slow paths:

1. If the slow path operation call is not patchable, emit a near call to a JIT thunk to do the entire operation call.

2. If the slow path operation call is patachable, emit a near call to a prepare call JIT thunk before the patchable operation call, and a near call to an exception check JIT thunk after.

This strategy reduces the amount of instructions emitted for all the slow paths.
Performance is expected to be neutral or slightly improved due to the reduced
compile times and better cache locality.

With this patch, --dumpLinkBufferStats shows the following changes in emitted
JIT code size (using a single run of the CLI version of JetStream2 on AS Mac)
comparing to current tip of tree:

Base New Diff

BaselineJIT: 84624776 (80.704475 MB) 77429400 (73.842430 MB) 0.91x (reduction)

DFG: 36415264 (34.728302 MB) 36160880 (34.485703 MB) 0.99x

Thunk: 23130336 (22.058807 MB) 23159024 (22.086166 MB) 1.00x

InlineCache: 21969728 (20.951965 MB) 22068348 (21.046017 MB) 1.00x

FTL: 6097336 (5.814873 MB) 6004736 (5.726562 MB) 0.98x

Wasm: 2301956 (2.195316 MB) 2429204 (2.316669 MB) 1.06x (probably noise)

YarrJIT: 1522488 (1.451958 MB) 1522488 (1.451958 MB) 1.00x

CSSJIT: 0

Uncategorized: 0

Comparing to tip of tree at the start of this effort to move put slow paths in
JIT thunks:

Base New Diff

BaselineJIT: 89089964 (84.962811 MB) 77429400 (73.842430 MB) 0.87x (reduction)

DFG: 39117360 (37.305222 MB) 36160880 (34.485703 MB) 0.92x (reduction)

Thunk: 23230968 (22.154778 MB) 23159024 (22.086166 MB) 1.00x

InlineCache: 22027416 (21.006981 MB) 22068348 (21.046017 MB) 1.00x

FTL: 6575772 (6.271145 MB) 6004736 (5.726562 MB) 0.91x (reduction)

Wasm: 2302724 (2.196049 MB) 2429204 (2.316669 MB) 1.05x (probably noise)

YarrJIT: 1538956 (1.467663 MB) 1522488 (1.451958 MB) 0.99x

CSSJIT: 0 0

Uncategorized: 0 0

This patch has passed the JSC tests on AS Mac, and also a subset of the JSC tests
(as a smoke test) on x86_64.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::offsetOfGlobalObject):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::callExceptionFuzz):
(JSC::AssemblyHelpers::emitExceptionCheck):
(JSC::AssemblyHelpers::emitNonPatchableExceptionCheck):

• jit/JIT.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::slow_op_get_by_val_prepareCallGenerator):
(JSC::JIT::emitSlow_op_get_private_name):
(JSC::JIT::slow_op_get_private_name_prepareCallGenerator):
(JSC::JIT::emitSlow_op_set_private_brand):
(JSC::JIT::emitSlow_op_check_private_brand):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::slow_op_put_by_val_prepareCallGenerator):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::slow_op_put_private_name_prepareCallGenerator):
(JSC::JIT::emitSlow_op_del_by_id):
(JSC::JIT::slow_op_del_by_id_prepareCallGenerator):
(JSC::JIT::emitSlow_op_del_by_val):
(JSC::JIT::slow_op_del_by_val_prepareCallGenerator):
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_direct):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::slow_op_get_by_id_prepareCallGenerator):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::slow_op_get_by_id_with_this_prepareCallGenerator):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::slow_op_put_by_id_prepareCallGenerator):
(JSC::JIT::emitSlow_op_in_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::slow_op_get_from_scopeGenerator):
(JSC::JIT::emitSlow_op_put_to_scope):
(JSC::JIT::slow_op_put_to_scopeGenerator):

• jit/JITThunks.cpp:

(JSC::JITThunks::preinitializeExtraCTIThunks):

• jit/SlowPathCall.cpp:

(JSC::JITSlowPathCall::call):

• jit/ThunkGenerators.cpp:

(JSC::checkExceptionGenerator):

• jit/ThunkGenerators.h:

11:26 AM Changeset in webkit [277499] by Chris Dumez

• 7 edits in trunk

Introduce FileSystem::updateFileModificationTime()
​https://bugs.webkit.org/show_bug.cgi?id=225810

Reviewed by Darin Adler.

Source/WebKit:

Call the new FileSystem::updateFileModificationTime() API to modify the
file modification time instead of having low-level platform-specific
file system code at the WebKit2 layer.

• NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::updateFileModificationTimeIfNeeded):

Source/WTF:

Introduce FileSystem::updateFileModificationTime() to update the modification time of a
file. The implementation is cross-platform and relies on std::filesystem. It allows us
to replace platform-specific code that we had at the WebKit2 layer.

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::updateFileModificationTime):

• wtf/FileSystem.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

10:54 AM Changeset in webkit [277498] by Chris Dumez

• 7 edits in trunk/Source

Drop unused FileSystem::homeDirectoryPath()
​https://bugs.webkit.org/show_bug.cgi?id=225808

Reviewed by Anders Carlsson.

Source/WebKitLegacy/win:

Fix Window-specific code that was calling FileSystem::homeDirectoryPath(),
which would always return the empty string on Windows. Call
FileSystem::roamingUserSpecificStorageDirectory() since it returns the
%AppData% folder and this is what the code actually wants.

• Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

Source/WTF:

Only Windows-specific code was calling FileSystem::homeDirectoryPath() but the Windows implementation
for this was always returning the empty string.

• wtf/FileSystem.h:
• wtf/cocoa/FileSystemCocoa.mm:

(WTF::FileSystemImpl::homeDirectoryPath): Deleted.

• wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::homeDirectoryPath): Deleted.

• wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::homeDirectoryPath): Deleted.

10:28 AM Changeset in webkit [277497] by commit-queue@webkit.org

• 15 edits in trunk

Wrong static position for out-of-flow positioned element with different writing-mode than its containing block
​https://bugs.webkit.org/show_bug.cgi?id=189513

Patch by Ziran Sun <Ziran Sun> on 2021-05-14
Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Updated the following WPT tests that are now passing.

• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001-expected.txt:
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002-expected.txt:
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003-expected.txt:
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004-expected.txt:
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005-expected.txt:
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007-expected.txt:
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010-expected.txt:

Source/WebCore:

The static distance computations (computeBlockStaticDistance & computeInlineStaticDistance) in RenderBox have
not been patched for mixed writing modes. This CL adds support for the case that child is orthogonal to its
container block when container block's text direction is LTR. It aims at fixing failures in
orthogonal-positioned-grid-descendants*.html tests. It is noted that this CL only covers specific case when child's
writing mode is vlr and parent is horizontal tb rather than all cases of mixed writing modes in the static distance
computations.

• rendering/RenderBox.cpp:

(WebCore::computeInlineStaticDistance):
(WebCore::computeBlockStaticDistance):

LayoutTests:

• TestExpectations: updating 22 css-writing-modes tests that are passing.

10:15 AM Changeset in webkit [277496] by Jonathan Bedard

• 2 edits in trunk/Tools

[run-api-tests] Use Python 3 (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=225427
<rdar://problem/77584713>

Reviewed by Aakash Jain.

• Scripts/run-api-tests: Change she-bang to Python 3.

10:15 AM Changeset in webkit [277495] by Alan Coon

• 1 copy in tags/Safari-612.1.14.3

Tag Safari-612.1.14.3.

10:00 AM Changeset in webkit [277494] by Alan Coon

• 8 edits in branches/safari-612.1.14-branch/Source

Versioning.

WebKit-7612.1.14.3

9:56 AM Changeset in webkit [277493] by achristensen@apple.com

• 14 edits in trunk

Resource Timing: secureConnectionStart == 0 when a connection is re-used
​https://bugs.webkit.org/show_bug.cgi?id=225733

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/resource-timing/resource_connection_reuse_mixed_content-expected.txt:

Source/WebCore:

Covered by a newly-passing web platform test, which was already passed by Chrome and Firefox.

• page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::secureConnectionStart const):

• platform/network/NetworkLoadMetrics.h:

I use a sentinel value to distinguish no secure connection from a reused secure connection.

• platform/network/ResourceHandle.h:
• platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):
(WebCore::copyTimingData):
Introduce a way to get timing data from CFNetwork using a more modern API.
(WebCore::timingValue): Deleted.

• platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask _timingData]):

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::getConnectionTimingData): Deleted.

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

LayoutTests:

• TestExpectations:

9:10 AM Changeset in webkit [277492] by Chris Dumez

• 39 edits in trunk

Rename FileSystem::getFileSize() to FileSystem::fileSize()
​https://bugs.webkit.org/show_bug.cgi?id=225798

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Update code path to due to the API change.

• inspector/remote/socket/RemoteInspectorSocket.cpp:

(Inspector::RemoteInspector::backendCommands const):

• jsc.cpp:

Source/WebCore:

Update code path to due to the API change.

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::databasesSizeForDirectory):

• Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::maximumSize):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::usage):
(WebCore::DatabaseTracker::quotaNoLock):
(WebCore::DatabaseTracker::quota):
(WebCore::DatabaseTracker::setQuota):
(WebCore::isZeroByteFile):

• Modules/webdatabase/DatabaseTracker.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

• loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::spaceNeeded):
(WebCore::ApplicationCacheStorage::loadCache):
(WebCore::ApplicationCacheStorage::flatFileAreaSize):

• platform/FileStream.cpp:

(WebCore::FileStream::getSize):

• platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):

• platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::loadFileToBuffer):

• platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::loadIndex):

• platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::databaseFileSize):

• platform/sql/SQLiteFileSystem.h:
• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::stringWithContentsOfFile):

• workers/service/server/SWScriptStorage.cpp:

(WebCore::shouldUseFileMapping):
(WebCore::SWScriptStorage::retrieve):

Source/WebKit:

Update code path to due to the API change.

• NetworkProcess/WebStorage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::setItem):

• NetworkProcess/WebStorage/LocalStorageDatabase.h:
• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::getDirectorySize):
(WebKit::CacheStorage::Engine::readSizeFile):

• NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::synchronize):

• NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::mapFile):

• NetworkProcess/cache/NetworkCacheIOChannelCurl.cpp:

(WebKit::NetworkCache::IOChannel::read):

• Shared/PersistencyUtils.cpp:

(WebKit::createForFile):

• UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::loadStorageFromDisk):

Source/WebKitLegacy:

Update code path to due to the API change.

• Storage/StorageTracker.cpp:

(WebKit::StorageTracker::diskUsageForOrigin):

• Storage/StorageTracker.h:

Source/WTF:

Rename FileSystem::getFileSize() to FileSystem::fileSize() as we usually avoid the "get"
prefix in WebKit. It is also more consistent with the std::filesystem::file_size() the
implementation relies on.

Also have it return an Optional<uint64_t> instead of taking a long long out-parameter, as
this is more modern.

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::fileSize):

• wtf/FileSystem.h:
• wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::fileSize):

• wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::fileSize):

• wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::getFileSizeFromByHandleFileInformationStructure):
(WTF::FileSystemImpl::fileSize):
(WTF::FileSystemImpl::MappedFileData::mapFileHandle):

Tools:

Update code path to due to the API change.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

• TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:

(TestWebKitAPI::TEST):

9:01 AM Changeset in webkit [277491] by Chris Dumez

• 22 edits in trunk

Rename FileSystem::pathGetFileName() to FileSystem::pathFileName()
​https://bugs.webkit.org/show_bug.cgi?id=225806

Reviewed by Alex Christensen.

Rename FileSystem::pathGetFileName() to FileSystem::pathFileName(), as we avoid "get" prefixes in WebKit.

Source/WebCore:

• Modules/entriesapi/FileSystemEntry.cpp:

(WebCore::FileSystemEntry::FileSystemEntry):

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

• fileapi/File.cpp:

(WebCore::File::computeNameAndContentType):

• fileapi/FileCocoa.mm:

(WebCore::File::computeNameAndContentTypeForReplacedFile):

• html/DirectoryFileListCreator.cpp:

(WebCore::gatherFileInformation):

• loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::store):

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::purgeOldDownloadFiles):

Source/WebKit:

• NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::origins const):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):

Source/WebKitLegacy/win:

• Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::fileExistsAndIsNotDisabled const):

• Plugins/PluginPackage.cpp:

(WebCore::PluginPackage::PluginPackage):

• WebDownloadCurl.cpp:

(WebDownload::didReceiveResponse):

Source/WTF:

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::pathFileName):
(WTF::FileSystemImpl::pathGetFileName): Deleted.

• wtf/FileSystem.h:

Tools:

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

8:54 AM Changeset in webkit [277490] by Jonathan Bedard

• 57 edits in trunk/Tools

[webkitpy] Remove unused imports
​https://bugs.webkit.org/show_bug.cgi?id=225776
<rdar://problem/77982408>

Reviewed by Dewei Zhu.

• Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py:
• Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
• Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
• Scripts/webkitpy/common/config/ports.py:
• Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
• Scripts/webkitpy/common/net/layouttestresults_unittest.py:
• Scripts/webkitpy/common/net/networktransaction_unittest.py:
• Scripts/webkitpy/common/system/zipfileset_unittest.py:
• Scripts/webkitpy/common/test_expectations_unittest.py:
• Scripts/webkitpy/inspector/main.py:
• Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
• Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
• Scripts/webkitpy/layout_tests/models/test_expectations.py:
• Scripts/webkitpy/layout_tests/models/test_run_results.py:
• Scripts/webkitpy/layout_tests/servers/websocket_server.py:
• Scripts/webkitpy/layout_tests/views/printing.py:
• Scripts/webkitpy/minibrowser/run_webkit_app.py:
• Scripts/webkitpy/performance_tests/perftest.py:
• Scripts/webkitpy/port/base.py:
• Scripts/webkitpy/port/builders.py:
• Scripts/webkitpy/port/config_unittest.py:
• Scripts/webkitpy/results/upload_unittest.py:
• Scripts/webkitpy/style/checkers/test_expectations.py:
• Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
• Scripts/webkitpy/style/checkers/text_unittest.py:
• Scripts/webkitpy/style/filereader_unittest.py:
• Scripts/webkitpy/style/optparser.py:
• Scripts/webkitpy/test/printer.py:
• Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
• Scripts/webkitpy/tool/bot/retrylogic_unittest.py:
• Scripts/webkitpy/tool/commands/queuestest.py:
• Scripts/webkitpy/tool/commands/rebaselineserver.py:
• Scripts/webkitpy/tool/commands/setupgitclone.py:
• Scripts/webkitpy/tool/commands/suggestnominations.py:
• Scripts/webkitpy/tool/commands/upload.py:
• Scripts/webkitpy/tool/main.py:
• Scripts/webkitpy/tool/mocktool.py:
• Scripts/webkitpy/tool/multicommandtool_unittest.py:
• Scripts/webkitpy/tool/servers/gardeningserver.py:
• Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
• Scripts/webkitpy/tool/servers/reflectionhandler.py:
• Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
• Scripts/webkitpy/tool/steps/wptchangeexport.py:
• Scripts/webkitpy/w3c/wpt_runner.py:
• Scripts/webkitpy/webdriver_tests/pytest_runner.py:
• Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
• Scripts/webkitpy/webdriver_tests/webdriver_test_result.py:
• Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
• Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

8:51 AM Changeset in webkit [277489] by Jonathan Bedard

• 4 edits in trunk/Tools

test-lldb-webkit failing with import of lldb
​https://bugs.webkit.org/show_bug.cgi?id=225792
<rdar://problem/77993980>

Reviewed by Dewei Zhu.

• CISupport/build-webkit-org/steps.py:

(RunLLDBWebKitTests): Invoke test-lldb-webkit with Python 3.

• CISupport/build-webkit-org/steps_unittest.py:
• Scripts/test-lldb-webkit: Change shebang to Python 3.

7:36 AM Changeset in webkit [277488] by Amir Mark Jr.

• 2 edits in trunk/LayoutTests

[MacOS] imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=225804

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:26 AM Changeset in webkit [277487] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.33.1

WebKitGTK 2.33.1

3:25 AM Changeset in webkit [277486] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.1 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.33.1.

3:22 AM Changeset in webkit [277485] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. [GTK] Fix make distcheck

.:

Use WEBKITGTK_API_DOC_VERSION instead of WEBKITGTK_API_VERSION or the documentation install rules.

• Source/PlatformGTK.cmake:

Tools:

Update library version now that we build with soup3 by default.

• Scripts/make-dist:

(Distcheck.check_symbols):
(ensure_version_if_possible):

May 13, 2021:

11:42 PM Changeset in webkit [277484] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Check for null element in paintSearchFieldResultsButton
​https://bugs.webkit.org/show_bug.cgi?id=225232

Patch by Rob Buis <​rbuis@igalia.com> on 2021-05-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

Check for null element in paintSearchFieldResultsButton.

Test: fast/css/searchfield-results-button-crash.html

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

LayoutTests:

Add test for this.

• fast/css/searchfield-results-button-crash-expected.txt: Added.
• fast/css/searchfield-results-button-crash.html: Added.

10:53 PM Changeset in webkit [277483] by commit-queue@webkit.org

• 5 edits in trunk/Source

Misc GCC warning cleanup
​https://bugs.webkit.org/show_bug.cgi?id=225777

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-13
Reviewed by Carlos Garcia Campos.

Source/WebCore:

• bindings/js/JSAudioNodeCustom.cpp:

(WebCore::toJSNewlyCreated): Add missing RELEASE_ASSERT_NOT_REACHED().

• svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Remove redundant condition.

Source/WebDriver:

Remove unused variable.

• glib/WebDriverServiceGLib.cpp:

(WebDriver::parseVersion):

10:52 PM Changeset in webkit [277482] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

[GTK] Wrong smooth animation sometimes with non-async scrolling
​https://bugs.webkit.org/show_bug.cgi?id=225764

Reviewed by Adrian Perez de Castro.

This is happening because sometimes when the scrollbars are added to the scroll view, the contents size hasn't
been updated yet, so that values saved by ScrollAnimationSmooth::updateVisibleLengths() are 0x0. After that the
updateVisibleLengths() is not called again when the contents size is updated, so scroll happens with the wrong
visible lengths. This doesn't happen with async scrolling because updateVisibleLengths() is called every time
layers are repositioned. For non-async scrolling it should be enough to update visible lengths when he contents
size changes.

• platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::contentsResized const):

• platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::ScrollAnimator::contentsResized const):

9:44 PM Changeset in webkit [277481] by Devin Rousso

• 3 edits in trunk/Source/WebCore

[Modern Media Controls] REGRESSION(r268308) AirPlay briefly disappears and then reappears when hovering over controls
​https://bugs.webkit.org/show_bug.cgi?id=225780
<rdar://problem/77984683>

Reviewed by Eric Carlson.

r268308 adjusted AVRoutePickerViewTargetPicker::isAvailable, which is used to control
whether AVRoutePickerViewTargetPicker (which uses the AVRouteDetectorMultipleRoutesDetectedDidChange
notification and actually stops listening for it in stopMonitoringPlaybackTargets) or
AVOutputDeviceMenuControllerTargetPicker (which uses ObjC KVO and doesn't actually do
anything in stopMonitoringPlaybackTargets when the last JS "webkitplaybacktargetavailabilitychanged"
event listener is removed, meaning that WebKit never senda a new value to the WebProcess) is
used. When using AVRoutePickerViewTargetPicker, WebKit calls -[AVRouteDetector setRouteDetectionEnabled:]
whenever the first JS "webkitplaybacktargetavailabilitychanged" event listener is added
(with the argument YES) and the last JS "webkitplaybacktargetavailabilitychanged" event
listener is removed (with the argument NO). In the latter scenario (which is the case with
builtin media controls), -[AVRouteDetector setRouteDetectionEnabled:] will dispatch a
AVRouteDetectorMultipleRoutesDetectedDidChange notification and mark itself as not having
multiple routes (-[AVRouteDetector multipleRoutesDetected]). This work is done in the
UIProcess and the result is sent to the WebProcess, meaning that even though there are no
more JS event listeners WebKit still updates the cached state of whether multiple routes
exist. This means that the next time a JS event listener is added, WebKit will ask the
UIProcess to update (which will re-enable route detection, which will dispatch a AVRouteDetectorMultipleRoutesDetectedDidChange
notification) but then immediately dispatch a JS "webkitplaybacktargetavailabilitychanged"
event using the cached state. Once the request from the UIProcess comes back, WebKit will
then dispatch *another* JS "webkitplaybacktargetavailabilitychanged" event with the new
non-cached value.

• platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.h:
• platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:

(WebCore::AVRoutePickerViewTargetPicker::startingMonitoringPlaybackTargets):
(WebCore::AVRoutePickerViewTargetPicker::stopMonitoringPlaybackTargets):
(WebCore::AVRoutePickerViewTargetPicker::availableDevicesDidChange):
Add a flag that ignores the next AVRouteDetectorMultipleRoutesDetectedDidChange
notification since it's guaranteed to be false after setRouteDetectionEnabled:NO.

9:39 PM Changeset in webkit [277480] by Darin Adler

• 2 edits in trunk/Source/JavaScriptCore

Follow-up fix for: Remove StringBuilder::appendNumber
​https://bugs.webkit.org/show_bug.cgi?id=225732
rdar://78000283

• heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::json): Removed a stray single quote mark that
meant we produced a JSON file that could not be parsed.

9:06 PM Changeset in webkit [277479] by Wenson Hsieh

• 13 edits
  2 adds
  2 deletes in trunk/Source

[Cocoa] Plumb data detector results through some platform objects
​https://bugs.webkit.org/show_bug.cgi?id=225775
Work towards rdar://75504956

Reviewed by Tim Horton and Devin Rousso.

Source/WebCore:

Introduce a new struct to hold data detection results, and add it to the existing results object when
ENABLE(DATA_DETECTION) is defined.

No change in behavior.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::canBePresentedByDataDetectors):
(WebCore::DataDetection::canPresentDataDetectorsUIForElement):
(WebCore::resultIsURL):
(WebCore::constructURLStringForResult):
(WebCore::buildQuery):
(WebCore::DataDetection::detectContentInRange):

Add a PAL namespace to each of these DataDetectorsCore softlinking call sites, since the soft link header now
exists in PAL.

• platform/ImageExtractionResult.h:

(WebCore::ImageExtractionDataDetectorInfo::ImageExtractionDataDetectorInfo):
(WebCore::ImageExtractionResult::isEmpty const):
(WebCore::ImageExtractionResult::encode const):
(WebCore::ImageExtractionResult::decode):

• platform/cocoa/DataDetectorsCoreSoftLink.h: Removed.
• platform/cocoa/DataDetectorsCoreSoftLink.mm: Removed.

Additionally, move DataDetectorsCoreSoftLink.{h|mm} out of WebCore/platform and into PAL as softlinking
headers, so that they can be imported in WebKit as well as WebCore.

Source/WebCore/PAL:

Move DataDetectorsCoreSoftLink.{h|mm} into PAL, so that it can be used in WebKit as well.

• PAL.xcodeproj/project.pbxproj:
• pal/PlatformMac.cmake:

Add the header and source file to the CMake build.

• pal/cocoa/DataDetectorsCoreSoftLink.h: Added.
• pal/cocoa/DataDetectorsCoreSoftLink.mm: Added.
• pal/spi/cocoa/DataDetectorsCoreSPI.h:

Explicitly import Foundation headers here, so that the forward declarations don't cause compilation failures in
non-internal SDKs.

Source/WebKit:

Add IPC encoding and decoding support for the new struct.

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<ImageExtractionDataDetectorInfo>::encodePlatformData):
(IPC::ArgumentCoder<ImageExtractionDataDetectorInfo>::decodePlatformData):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ImageExtractionDataDetectorInfo>::encode):
(IPC::ArgumentCoder<ImageExtractionDataDetectorInfo>::decode):

• Shared/WebCoreArgumentCoders.h:

8:30 PM Changeset in webkit [277478] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Skip WebXR tests after r277468

Unreviewed test gardening.

WebXR is not yet enabled in GTK.

• platform/gtk/TestExpectations:

7:13 PM Changeset in webkit [277477] by Patrick Angle

• 2 edits in trunk/Source/JavaScriptCore

[REGRESSION: r271876] Web Inspector: [Cocoa] Remote inspection crashes when using WEB_THREAD
​https://bugs.webkit.org/show_bug.cgi?id=225794

Reviewed by Devin Rousso.

For WEB_THREAD, move callback in dispatchAsyncOnTarget to block scope to ensure it is available for the
lifetime of the block.

• inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:

(Inspector::RemoteConnectionToTarget::dispatchAsyncOnTarget):

7:06 PM Changeset in webkit [277476] by aakash_jain@apple.com

• 2 edits in trunk/Tools

report-non-inclusive-language should skip symlinks
​https://bugs.webkit.org/show_bug.cgi?id=225789

Reviewed by Darin Adler.

• Scripts/report-non-inclusive-language: Skip symlinks since most likely the linked file would be checked

directly by the script while iterating the directory structure and would result in it being counted twice.
Also the script fails with an error if there is a symlink pointing to a non-existing file.

7:03 PM Changeset in webkit [277475] by ggaren@apple.com

• 4 edits in trunk/Source/JavaScriptCore

m_calleeSaveRegisters should not be a pointer to a pointer
​https://bugs.webkit.org/show_bug.cgi?id=225787

Reviewed by Keith Miller.

Ben found this through memory stress testing.

RegisterAtOffsetList is effectively just a pointer. unique_ptr<RegisterAtOffsetList>
is a pointer to a pointer. RegisterAtOffsetList is long-lived, so it
creates heap page fragmentation.

Worth 3MB on Ben's test.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setCalleeSaveRegisters):
(JSC::CodeBlock::calleeSaveRegisters const): Use a fence before setting
m_hasCalleeSaveRegisters to ensure that all writes have completed before
the struct becomes visible.

• bytecode/CodeBlock.h: Use RegisterAtOffsetList directly instead of

unique_ptr<RegisterAtOffsetList> to avoid a long-lived lonely 8 byte
allocation.

• ftl/FTLCompile.cpp:

(JSC::FTL::compile): Updated for type change.

6:48 PM Changeset in webkit [277474] by Russell Epstein

• 1 edit in branches/safari-612.1.15-branch/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h

Unreviewed build fix. rdar://problem/77992162

6:30 PM Changeset in webkit [277473] by Russell Epstein

• 1 copy in tags/Safari-612.1.14.2

Tag Safari-612.1.14.2.

6:19 PM Changeset in webkit [277472] by Russell Epstein

• 1 edit in branches/safari-612.1.14-branch/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h

Unreviewed build fix. rdar://problem/77990505

6:14 PM Changeset in webkit [277471] by Russell Epstein

• 8 edits in branches/safari-612.1.14-branch/Source

Versioning.

WebKit-7612.1.14.2

6:02 PM Changeset in webkit [277470] by Russell Epstein

• 35 edits in branches/safari-612.1.12-branch/Source

Cherry-pick r277453. rdar://problem/77996171

Add textIndicator bounce for AppHighlights on scroll.
​https://bugs.webkit.org/show_bug.cgi?id=225727

Reviewed by Tim Horton.

• Modules/highlight/AppHighlightStorage.cpp: (WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):
• loader/EmptyClients.cpp: (WebCore::EmptyChromeClient::setTextIndicator const):
• loader/EmptyClients.h:
• page/ChromeClient.h:
• page/TextIndicator.h:
• page/cocoa/WebTextIndicatorLayer.h:
• page/cocoa/WebTextIndicatorLayer.mm: (-[WebTextIndicatorLayer initWithFrame:textIndicator:margin:offset:]): (createBounceAnimation): (-[WebTextIndicatorLayer _animationDuration]):
• page/mac/TextIndicatorWindow.h:
• page/mac/TextIndicatorWindow.mm: (WebCore::TextIndicatorWindow::~TextIndicatorWindow): (WebCore::TextIndicatorWindow::clearTextIndicator): (WebCore::TextIndicatorWindow::setTextIndicator):

Use factored out textIndicator code to add a bounce to an appHighlight
when it is scrolled to.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm: (-[WKWindowVisibilityObserver _dictionaryLookupPopoverWillClose:]): (WebKit::WebViewImpl::setTextIndicator): (WebKit::WebViewImpl::clearTextIndicatorWithAnimation): (WebKit::WebViewImpl::dismissContentRelativeChildWindowsWithAnimationFromViewOnly): (WebKit::WebViewImpl::dismissContentRelativeChildWindowsFromViewOnly):
• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setTextIndicator): (WebKit::WebPageProxy::clearTextIndicator):
• UIProcess/WebPageProxy.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::setTextIndicator): (WebKit::PageClientImpl::clearTextIndicator): (WebKit::PageClientImpl::setTextIndicatorAnimationProgress):
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setUpTextIndicator:]): (-[WKContentView clearTextIndicator:]): (-[WKContentView setTextIndicatorAnimationProgress:]): (-[WKContentView teardownTextIndicatorLayer]): (-[WKContentView startFadeOut]):
• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::setTextIndicator): (WebKit::PageClientImpl::clearTextIndicator): (WebKit::PageClientImpl::didPerformDictionaryLookup):
• UIProcess/mac/WKImmediateActionController.mm: (-[WKImmediateActionController _animationControllerForText]):
• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setTextIndicator const):
• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):

• WebCoreSupport/WebChromeClient.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:02 PM Changeset in webkit [277469] by Russell Epstein

• 6 edits
  2 copies in branches/safari-612.1.12-branch

Cherry-pick r277330. rdar://problem/77996680

Factor out find bounce layer
​https://bugs.webkit.org/show_bug.cgi?id=225557

Reviewed by Tim Horton.

Factor out the text indicator bounce layer in preparation of making this
compatable with iOS.

No behavior change.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• page/mac/TextIndicatorWindow.h:
• page/mac/TextIndicatorWindow.mm: (WebCore::TextIndicatorWindow::setAnimationProgress): (WebCore::TextIndicatorWindow::clearTextIndicator): (WebCore::TextIndicatorWindow::setTextIndicator): (WebCore::TextIndicatorWindow::closeWindow): (WebCore::TextIndicatorWindow::startFadeOut): (indicatorWantsBounce): Deleted. (indicatorWantsContentCrossfade): Deleted. (indicatorWantsFadeIn): Deleted. (indicatorWantsManualAnimation): Deleted. (-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Deleted. (createBounceAnimation): Deleted. (createContentCrossfadeAnimation): Deleted. (createShadowFadeAnimation): Deleted. (createFadeInAnimation): Deleted. (-[WebTextIndicatorView _animationDuration]): Deleted. (-[WebTextIndicatorView hasCompletedAnimation]): Deleted. (-[WebTextIndicatorView present]): Deleted. (-[WebTextIndicatorView hideWithCompletionHandler:]): Deleted. (-[WebTextIndicatorView setAnimationProgress:]): Deleted. (-[WebTextIndicatorView isFlipped]): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:35 PM Changeset in webkit [277468] by dino@apple.com

• 18 edits
  13 adds
  3 deletes in trunk

[WebXR] Allow WebXR to be tested on PLATFORM(COCOA)
​https://bugs.webkit.org/show_bug.cgi?id=225578
<rdar://problem/77707283>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

New expected results.

• web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt: Added.
• web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt: Added.
• web-platform-tests/webxr/webxr-supported-by-feature-policy-expected.txt: Added.
• web-platform-tests/webxr/webxr_availability.http.sub-expected.txt: Added.
• web-platform-tests/webxr/webxr_feature_policy.https-expected.txt: Added.
• web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt: Added.
• web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt: Added.
• web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt: Added.
• web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt: Added.
• web-platform-tests/webxr/xrSession_visibilityState.https-expected.txt: Added.
• web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt: Added.
• web-platform-tests/webxr/xrWebGLLayer_framebuffer_scale.https-expected.txt: Added.
• web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https-expected.txt: Added.

Source/WebKit:

Remove checking for a WebXR feature flag.

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultWebXREnabled):

Source/WTF:

Compile-time enabled on all Cocoa platforms.

• wtf/PlatformEnableCocoa.h:

LayoutTests:

Remove the skip rule for the WebXR directory, and add more
specific expected results.

• TestExpectations:

4:39 PM Changeset in webkit [277467] by Alan Coon

• 1 copy in tags/Safari-612.1.12.7

Tag Safari-612.1.12.7.

4:35 PM Changeset in webkit [277466] by Alan Coon

• 5 edits in branches/safari-612.1.12-branch/Source

Cherry-pick r277464. rdar://problem/77993046

Work around WebCore failing to build due to NDEBUG getting undefined in release
​https://bugs.webkit.org/show_bug.cgi?id=225782
<rdar://problem/77982432>

Reviewed by Simon Fraser.

Source/WebCore/PAL:

• pal/spi/cg/CoreGraphicsSPI.h:
• pal/spi/ios/GraphicsServicesSPI.h: Apply a temporary workaround to preserve NDEBUG through these includes. There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.

Source/WebKit:

• Platform/spi/ios/UIKitSPI.h: Apply a temporary workaround to preserve NDEBUG through these includes. There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@277464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:31 PM Changeset in webkit [277465] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] Style fixes in steps.py
​https://bugs.webkit.org/show_bug.cgi?id=225784

Reviewed by Dewei Zhu.

• CISupport/ews-build/steps.py:

(CheckOutSource.init):
(ShowIdentifier.hideStepIf):
(BugzillaMixin.get_bugzilla_api_key):
(RunJavaScriptCoreTests.commandComplete):
(AnalyzeJSCTestsResults.send_email_for_pre_existing_failure):
(AnalyzeLayoutTestsResults._report_flaky_tests):
(DownloadBuiltProduct):
(AnalyzeAPITestsResults.analyzeResults.getAPITestFailures):
(AnalyzeAPITestsResults.send_email_for_pre_existing_failure):

4:27 PM Changeset in webkit [277464] by timothy_horton@apple.com

• 5 edits in trunk/Source

Work around WebCore failing to build due to NDEBUG getting undefined in release
​https://bugs.webkit.org/show_bug.cgi?id=225782
<rdar://problem/77982432>

Reviewed by Simon Fraser.

Source/WebCore/PAL:

• pal/spi/cg/CoreGraphicsSPI.h:
• pal/spi/ios/GraphicsServicesSPI.h:

Apply a temporary workaround to preserve NDEBUG through these includes.
There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.

Source/WebKit:

• Platform/spi/ios/UIKitSPI.h:

Apply a temporary workaround to preserve NDEBUG through these includes.
There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.

4:20 PM Changeset in webkit [277463] by Devin Rousso

• 3 edits in trunk/Source/WebCore

[iOS] REGRESSION(r271216) pointerevents/ios/pointer-events-no-mousedown-when-prevent-default-called-on-pointerdown.html is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=225734
<rdar://problem/77070765>

Reviewed by Tim Horton.

r271216 made it so that touchWithIdentifierWasRemoved is eagerly called when dispatching
"pointerup" for a touch event. This is problematic because (compatibility) mouse events
are dispatched after both pointer and touch events, meaning that if the CapturingData for
the touch event is removed, there's no way of knowing if the pointer event preventDefault.

Instead of fully removing the CapturingData entirely, change its state such that it's
marked as CapturingData::State::Finished and check for that instead.

• page/PointerCaptureController.h:
• page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::hasCancelledPointerEventForIdentifier const):
(WebCore::PointerCaptureController::dispatchEventForTouchAtIndex):
(WebCore::PointerCaptureController::pointerEventForMouseEvent):
(WebCore::PointerCaptureController::cancelPointer):

4:19 PM Changeset in webkit [277462] by Cameron McCormack

• 3 edits
  2 adds in trunk

Ensure scrollable transformed elements that are themselves within scrollable elements don't ignore border-radius
​https://bugs.webkit.org/show_bug.cgi?id=216978
<rdar://69660229>

Reviewed by Darin Adler.

Source/WebCore:

We use ShouldRespectOverflowClip to prevent clips from ancestors
from being used when we paint a scrollable layer (when
PaintLayerFlag::PaintingOverflowContents is set). We only look
at the ShouldRespectOverflowClip value when we're painting a layer
we're considering to be a clip rect root layer, and we unconditionally
apply ancestor clips for layers that aren't clip rect roots.

A non-root layer with a transform is handled by applying the transform
and painting the layer as a root layer (since we don't want to handle
computing the effect of ancestor clip rects past the transform). When
the transformed layer also has a border-radius, we incorrectly skip
marking its clip rect as being affected by radius, since we currently
do this at the same time as applying ancestor clip rects.

This patch splits out the setAffectedByRadius call so that it happens
even for transformed non-root layers.

Test: fast/layers/overflow-scroll-transform-border-radius.html

• rendering/RenderLayer.cpp:

(WebCore::ClipRects::setOverflowClipRectAffectedByRadius):
(WebCore::RenderLayer::calculateClipRects const):

LayoutTests:

• fast/layers/overflow-scroll-transform-border-radius-expected.html: Added.
• fast/layers/overflow-scroll-transform-border-radius.html: Added.

4:16 PM Changeset in webkit [277461] by Russell Epstein

• 4 edits in branches/safari-612.1.15-branch/Source

Apply patch. rdar://problem/77992162

4:16 PM Changeset in webkit [277460] by Chris Dumez

• 2 edits in trunk/Tools

Tweak ServiceWorkers.SuspendServiceWorkerProcessBasedOnClientProcesses to find out source of timeout
​https://bugs.webkit.org/show_bug.cgi?id=225770

Reviewed by Alexey Proskuryakov.

Wait for conditions with our own timeout so that the test fails with useful errors instead
of just a generic timeout. This just help us find out where in the test things go wrong.

• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

4:11 PM Changeset in webkit [277459] by Devin Rousso

• 2 edits in trunk/Source/WebCore

[macOS] experimental "Use theme color for scroll area background" isn't working
​https://bugs.webkit.org/show_bug.cgi?id=225726
<rdar://problem/77933000>

Reviewed by Tim Horton.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForOverhangAreasBackgroundColor):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Fix last remaining m_layerForOverhangAreas->setBackgroundColor to use the helper function
RenderLayerCompositor::updateLayerForOverhangAreasBackgroundColor instead so that all
paths that update the overscroll area color check the experimental settings too.

4:03 PM Changeset in webkit [277458] by Russell Epstein

• 1 copy in branches/safari-612.1.15-branch

New branch.

3:50 PM Changeset in webkit [277457] by Alan Coon

• 1 copy in tags/Safari-612.1.14.1

Tag Safari-612.1.14.1.

3:49 PM Changeset in webkit [277456] by Alan Coon

• 4 edits in branches/safari-612.1.14-branch/Source

Apply patch. rdar://problem/77990505

3:44 PM Changeset in webkit [277455] by Amir Mark Jr.

• 2 edits in trunk/LayoutTests

[BigSur] media/video-played-ranges-1.html is flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=223645

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:39 PM Changeset in webkit [277454] by Alan Coon

• 8 edits in branches/safari-612.1.14-branch/Source

Versioning.

WebKit-7612.1.14.1

2:57 PM Changeset in webkit [277453] by timothy_horton@apple.com

• 35 edits in trunk/Source

Add textIndicator bounce for AppHighlights on scroll.
​https://bugs.webkit.org/show_bug.cgi?id=225727

Reviewed by Tim Horton.

• Modules/highlight/AppHighlightStorage.cpp:

(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):

• loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::setTextIndicator const):

• loader/EmptyClients.h:
• page/ChromeClient.h:
• page/TextIndicator.h:
• page/cocoa/WebTextIndicatorLayer.h:
• page/cocoa/WebTextIndicatorLayer.mm:

(-[WebTextIndicatorLayer initWithFrame:textIndicator:margin:offset:]):
(createBounceAnimation):
(-[WebTextIndicatorLayer _animationDuration]):

• page/mac/TextIndicatorWindow.h:
• page/mac/TextIndicatorWindow.mm:

(WebCore::TextIndicatorWindow::~TextIndicatorWindow):
(WebCore::TextIndicatorWindow::clearTextIndicator):
(WebCore::TextIndicatorWindow::setTextIndicator):

Use factored out textIndicator code to add a bounce to an appHighlight
when it is scrolled to.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(-[WKWindowVisibilityObserver _dictionaryLookupPopoverWillClose:]):
(WebKit::WebViewImpl::setTextIndicator):
(WebKit::WebViewImpl::clearTextIndicatorWithAnimation):
(WebKit::WebViewImpl::dismissContentRelativeChildWindowsWithAnimationFromViewOnly):
(WebKit::WebViewImpl::dismissContentRelativeChildWindowsFromViewOnly):

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setTextIndicator):
(WebKit::WebPageProxy::clearTextIndicator):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setTextIndicator):
(WebKit::PageClientImpl::clearTextIndicator):
(WebKit::PageClientImpl::setTextIndicatorAnimationProgress):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpTextIndicator:]):
(-[WKContentView clearTextIndicator:]):
(-[WKContentView setTextIndicatorAnimationProgress:]):
(-[WKContentView teardownTextIndicatorLayer]):
(-[WKContentView startFadeOut]):

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::setTextIndicator):
(WebKit::PageClientImpl::clearTextIndicator):
(WebKit::PageClientImpl::didPerformDictionaryLookup):

• UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _animationControllerForText]):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setTextIndicator const):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):

• WebCoreSupport/WebChromeClient.h:

2:53 PM Changeset in webkit [277452] by Aditya Keerthi

• 5 edits
  2 adds in trunk

REGRESSION (r276945): [iOS] Focus rings are too large
​https://bugs.webkit.org/show_bug.cgi?id=225778
<rdar://problem/77858341>

Reviewed by Tim Horton.

Source/WebCore:

r276945 updated scaling logic to ensure that the scale of the base CTM
matches the device scale factor. The change itself makes our base CTM
more correct, but exposed a longstanding bug with our focus ring
implementation.

Focus rings are drawn using CoreGraphics, using CGFocusRingStyle. On
macOS, the style is initialized using NSInitializeCGFocusRingStyleForTime.
However, on iOS, we initialize the style ourselves, using UIKit constants.
Currently, the focus ring's style's radius is set to
+[UIFocusRingStyle cornerRadius], a constant of 8. This is the longstanding
issue. CGFocusRingStyle's radius is not a corner radius, but is the
width of the focus ring. In UIKit, this width is represented by
+[UIFocusRingStyle borderThickness], a constant of 3. WebKit has always
intended to match this width, as evidenced by the default outline-width
of 3px in the UA style sheet.

Considering the large disparity between the existing and expected radius
value, it may be surprising that this mistake has gone unnoticed since
2019, when focus rings were first introduced on iOS. This is where r276945
comes into play. Prior to r276945, the scale of the base CTM did not match
the device scale factor. This meant that CG scaled down the constant of 8
to 4 CSS pixels (1 (base CTM) / 2 (device scale factor)). After r276945,
the two scales are equal and the focus ring is drawn as 8 CSS pixels, much
larger than the expected 3px.

Test: fast/forms/ios/focus-ring-size.html

• platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::drawFocusRingAtTime):

To fix, use the correct SPI to get the focus ring width,
+[UIFocusRingStyle borderThickness]. This ensures that focus rings have
the right width, following r276945.

The change also fixes focus ring repaint issues that arose from the
fact that the outline-width was 3px, but the painted width was 4px.

Source/WebCore/PAL:

• pal/spi/ios/UIKitSPI.h:

LayoutTests:

Added a regression test to verify the size of the focus ring on iOS.
The test works by drawing an overlay on top of an input element, that
is just large enough to obscure the focus ring. If the focus ring is
too large, the ring will not obscured, leading to a mismatch failure.

• fast/forms/ios/focus-ring-size-expected.html: Added.
• fast/forms/ios/focus-ring-size.html: Added.

2:28 PM Changeset in webkit [277451] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add unit test using WKHTTPCookieStoreObserver and cookies received from HTTP
​https://bugs.webkit.org/show_bug.cgi?id=225773

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-05-13
Reviewed by Chris Dumez.

We only had tests that added cookies through the API, not through the network.
I thought it was broken but it isn't. Still worth adding the test.

• TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

(deleteAllCookies):
(TEST):

1:54 PM Changeset in webkit [277450] by weinig@apple.com

• 24 edits
  4 copies in trunk/Source

Split pixel buffer format data out into a new PixelBufferFormat struct
​https://bugs.webkit.org/show_bug.cgi?id=225707

Reviewed by Darin Adler.

Source/WebCore:

Splits out PixelBufferFormat into a new struct and adopts it by PixelBufferConversionView,
ConstPixelBufferConversionView and PixelBuffer. This also means that PixelBuffer now
tracks the alpha format of the underlying buffer which will come in handy.

• Headers.cmake:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

Add new files.

• platform/graphics/AlphaPremultiplication.cpp: Added.

(WebCore::operator<<):
Add AlphaPremultiplication.cpp and move TextStream support
here from GraphicsTypes.cpp.

• platform/graphics/GraphicsTypes.cpp:

Move AlphaPremultiplication TextStream to the more appropriate
AlphaPremultiplication.cpp.

• html/ImageData.cpp:

(WebCore::ImageData::create):

• html/ImageData.h:

(WebCore::ImageData::colorSpace const): Deleted.
(WebCore::ImageData::format const): Deleted.

• platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::toBGRAData const):
(WebCore::ImageBufferBackend::getPixelBuffer const):
(WebCore::ImageBufferBackend::putPixelBuffer):

• platform/graphics/ImageBufferBackend.h:
• platform/graphics/PixelBuffer.cpp:

(WebCore::PixelBuffer::computeBufferSize):
(WebCore::PixelBuffer::tryCreateForDecoding):
(WebCore::PixelBuffer::tryCreate):
(WebCore::PixelBuffer::PixelBuffer):
(WebCore::PixelBuffer::deepClone const):
(WebCore::operator<<):

• platform/graphics/PixelBuffer.h:

(WebCore::PixelBuffer::format const):
(WebCore::PixelBuffer::encode const):
(WebCore::PixelBuffer::decode):
(WebCore::PixelBuffer::colorSpace const): Deleted.

• platform/graphics/PixelBufferConversion.cpp:

(WebCore::convertImagePixelsAccelerated):
(WebCore::convertImagePixels):

• platform/graphics/PixelBufferConversion.h:
• platform/graphics/PixelBufferFormat.cpp: Added.

(WebCore::operator<<):

• platform/graphics/PixelBufferFormat.h: Added.

(WebCore::PixelBufferFormat::encode const):
(WebCore::PixelBufferFormat::decode):

• platform/graphics/PixelFormat.cpp: Added.

(WebCore::operator<<):

• platform/graphics/PixelFormat.h:
• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::readPixelsForPaintResults):

• platform/graphics/cg/GraphicsContextGLCG.cpp:

(WebCore::GraphicsContextGLOpenGL::paintToCanvas):

• platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::toCFData const):

• platform/graphics/cg/ImageBufferUtilitiesCG.cpp:

(WebCore::cfData):

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
Adopt PixelBufferFormat.

Source/WebKit:

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

Adopt PixelBufferFormat.

1:47 PM Changeset in webkit [277449] by Chris Dumez

• 31 edits in trunk

Rename FileSystem::directoryName() to FileSystem::parentPath()
​https://bugs.webkit.org/show_bug.cgi?id=225768

Reviewed by Darin Adler.

Rename FileSystem::directoryName() to FileSystem::parentPath() for clarity and
consistency with std::filesystem::parent_path() which is used internally.

Source/JavaScriptCore:

• API/JSScript.mm:

(validateBytecodeCachePath):

Source/WebCore:

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::DOMFileSystem):

• loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory):
(WebCore::ApplicationCacheStorage::checkForDeletedResources):

• platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::contentKeySession):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::purgeOldDownloadFiles):

• platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::openDatabase):

• platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::ensureDatabaseFileExists):

• platform/win/SearchPopupMenuDB.cpp:

(WebCore::SearchPopupMenuDB::openDatabase):

• workers/service/server/SWScriptStorage.cpp:

(WebCore::SWScriptStorage::store):

Source/WebKit:

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::openITPDatabase):

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::writeFile):

• Shared/glib/ProcessExecutablePathGLib.cpp:

(WebKit::getExecutablePath):

• UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconDatabase):

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkit_website_data_manager_get_disk_cache_directory):

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::platformSetNetworkParameters):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):

Source/WebKitLegacy:

• Storage/StorageTracker.cpp:

(WebKit::ensureDatabaseFileExists):

Source/WebKitLegacy/win:

• Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::loadPersistentMetadataCache):

Source/WTF:

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::readOrMakeSalt):
(WTF::FileSystemImpl::parentPath):
(WTF::FileSystemImpl::directoryName): Deleted.

• wtf/FileSystem.h:

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(findFontFallback):

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

• TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::moduleDirectory):

1:08 PM Changeset in webkit [277448] by Chris Dumez

• 20 edits in trunk

Rename FileSystem::fileIsDirectory(path, followSymlinks) to isDirectory(path) / isDirectoryFollowingSymlinks(path)
​https://bugs.webkit.org/show_bug.cgi?id=225772

Reviewed by Darin Adler.

Source/JavaScriptCore:

Update code base due to API naming change.

• API/JSScript.mm:

(validateBytecodeCachePath):

Source/WebCore:

Update code base due to API naming change.

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

• fileapi/File.cpp:

(WebCore::File::isDirectory const):

• html/DirectoryFileListCreator.cpp:

(WebCore::gatherFileInformation):

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::ensureAssetCacheExistsForPath):

• platform/network/FormData.cpp:

(WebCore::FormData::prepareForUpload):

Source/WebKit:

Update code base due to API naming change.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::getDirectorySize):
(WebKit::CacheStorage::Engine::getDirectories):
(WebKit::CacheStorage::Engine::clearAllCachesFromDisk):

• NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::traverseDirectory):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::isInternalInstall):

Source/WTF:

I don't think the "file" prefix is useful here so I am renaming the function to
isDirectory(). Also, instead of using an enum parameter to decide whether or
not to follow symlink, I am adding a separate function called
isDirectoryFollowingSymlinks(). This is consistent with the
fileMetadata() / fileMetadataFollowingSymlinks() pattern, which Darin said he
preferred.

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::isDirectory):
(WTF::FileSystemImpl::isDirectoryFollowingSymlinks):
(WTF::FileSystemImpl::fileIsDirectory): Deleted.

• wtf/FileSystem.h:

Tools:

Update code base due to API naming change.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

12:45 PM Changeset in webkit [277447] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Process suspension may be delayed by up to 5 seconds after there is no longer any database activity
​https://bugs.webkit.org/show_bug.cgi?id=225774

Reviewed by Geoffrey Garen.

Use a 1 second HysteresisActivity in WebSQLiteDatabaseTracker instead of a 5 seconds one.
I frequently see our processes' suspension getting delayed by 5 seconds when homing out of
MobileSafari due to database activity. This change should help with that.

• Shared/WebSQLiteDatabaseTracker.cpp:

(WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker):

12:43 PM Changeset in webkit [277446] by Chris Dumez

• 7 edits in trunk

Introduce FileSystem::hardLinkCount()
​https://bugs.webkit.org/show_bug.cgi?id=225767

Reviewed by Darin Adler.

Source/WebKit:

Leverage the FileSystem API instead of having platform-specific code.

• NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::synchronize):
(WebKit::NetworkCache::BlobStorage::shareCount):

Source/WTF:

Introduce FileSystem::hardLinkCount() to replace our platform-specific implementation
in NetworkCacheBlobStorage.

• wtf/FileSystem.cpp:

(WTF::FileSystemImpl::hardLinkCount):

• wtf/FileSystem.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

12:38 PM Changeset in webkit [277445] by Amir Mark Jr.

• 2 edits in trunk/LayoutTests

[MacOS Wk1] media/video-playback-quality.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=223770

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

12:23 PM Changeset in webkit [277444] by Jonathan Bedard

• 4 edits in trunk/Tools

[run-api-tests] Use Python 3 (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=225427
<rdar://problem/77584713>

Reviewed by Aakash Jain.

• CISupport/build-webkit-org/steps.py:

(RunAPITests): Use Python3 to invoke run-api-tests.

• CISupport/ews-build/steps.py:

(RunAPITests): Use Python3 to invoke run-api-tests.

• CISupport/ews-build/steps_unittest.py:

11:48 AM Changeset in webkit [277443] by Robert Jenner

• 3 edits in trunk/LayoutTests

[ BigSur iOS14 ] http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html (layout-test) is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=225668

Unreviewed test gardening.

Marking as slow to see if timeouts stop occurring.

• platform/ios-simulator-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

11:23 AM Changeset in webkit [277442] by jer.noble@apple.com

• 4 edits in trunk

[ macOS Wk2 ] media/media-fragments/TC0051.html is flakey crashing
​https://bugs.webkit.org/show_bug.cgi?id=222277
<rdar://problem/74600790>

Reviewed by Eric Carlson.

Source/WebCore:

In r274734, a workaround was added to detect a bug in the Photos.framework that would cause
an exception to be thrown if the URL provided to AVURLAsset had a malformed fragment identifier.
However, in an effort to reduce the runtime cost of this check, it was only done once, the first
time an AVURLAsset is created. This failed to account for the Photos.framework being dynamically
loaded and changing the behavior of AVURLAsset after the check had been performed.

Instead, fall back to a much simpler check: wrap the creation of the AVURLAsset in a @try/@catch
block, and if an exception was thrown, re-attempt to create the AVURLAsset with a manually
conformed URL.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::conformFragmentIdentifierForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::hasBrokenFragmentSupport): Deleted.

LayoutTests:

• platform/mac-wk2/TestExpectations:

11:16 AM Changeset in webkit [277441] by Robert Jenner

• 3 edits in trunk/LayoutTests

[ Catalina+ wk2 ] http/tests/webAPIStatistics/screen-functions-accessed-data-collection.html (layout-test) is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=225667

Unreviewed test gardening.

Accidentally broke a test when I applied it for all of mac instead of just for mac wk2. I have updated the slow expectation for just mac wk2.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

10:36 AM Changeset in webkit [277440] by Jonathan Bedard

• 4 edits in trunk/Tools

Few webkitpy unit-tests fails in non-PST timezones
​https://bugs.webkit.org/show_bug.cgi?id=225741

Reviewed by Aakash Jain.

• Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Scripts/libraries/webkitscmpy/webkitscmpy/init.py:
• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py: Ditto.

(Svn.request): Serve SVN content from California time (like our SVN server)

10:35 AM Changeset in webkit [277439] by weinig@apple.com

• 2 edits in trunk/Source/WebKit

CGDisplayList debug configuration fails to build
​https://bugs.webkit.org/show_bug.cgi?id=225729

Reviewed by Darin Adler.

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::nameForBackingStoreType):
Add missing case for RemoteLayerBackingStore::Type::CGDisplayList.

10:03 AM Changeset in webkit [277438] by aboya@igalia.com

• 6 edits in trunk/Source

[WTF] Add holdLock() overload for WTF::DataMutex
​https://bugs.webkit.org/show_bug.cgi?id=225652

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

All instantiations of DataMutex::LockedWrapper have been replaced by
holdLock(), for equivalent but more concise code.

This patch introduces no behavior changes.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcConstructed):
(webKitWebSrcGetProperty):
(webKitWebSrcSetContext):
(webKitWebSrcCreate):
(webKitWebSrcMakeRequest):
(webKitWebSrcStop):
(webKitWebSrcGetSize):
(webKitWebSrcIsSeekable):
(webKitWebSrcDoSeek):
(webKitWebSrcQuery):
(webKitWebSrcUnLock):
(webKitWebSrcUnLockStop):
(webKitWebSrcSetMediaPlayer):
(webKitSrcPassedCORSAccessCheck):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::accessControlCheckFailed):
(CachedResourceStreamingClient::loadFailed):
(CachedResourceStreamingClient::loadFinished):
(webKitSrcWouldTaintOrigin):

• platform/graphics/gstreamer/mse/MediaSourceTrackGStreamer.cpp:

(WebCore::MediaSourceTrackGStreamer::isReadyForMoreSamples):
(WebCore::MediaSourceTrackGStreamer::notifyWhenReadyForMoreSamples):
(WebCore::MediaSourceTrackGStreamer::enqueueObject):
(WebCore::MediaSourceTrackGStreamer::clearQueue):

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcActivateMode):
(webKitMediaSrcPadLinked):
(webKitMediaSrcLoop):
(webKitMediaSrcStreamFlush):

Source/WTF:

This patch adds a holdLock() overload for WTF::DataMutex as syntactic
sugar to simplify usage in a similar way to what holdLock() already
does for WTF::Locker.

• wtf/DataMutex.h:

(WTF::holdLock):

9:18 AM Changeset in webkit [277437] by Darin Adler

• 58 edits in trunk

Remove StringBuilder::appendNumber
​https://bugs.webkit.org/show_bug.cgi?id=225732

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• API/JSContextRef.cpp:

(BacktraceFunctor::operator() const): Use append instead of appendNumber.

• API/tests/PingPongStackOverflowTest.cpp:

(PingPongStackOverflowObject_hasInstance): Ditto.

• heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::json): Ditto.

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::toString const): Use makeString instead of StringBuilder.

• runtime/ConsoleClient.cpp:

(JSC::appendURLAndPosition): Ditto.
(JSC::ConsoleClient::printConsoleMessageWithArguments): Use append instead of appendNumber.

• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue): Ditto.

• runtime/Options.cpp:

(JSC::OptionReader::Option::dump const): Ditto.

• runtime/StackFrame.cpp:

(JSC::StackFrame::toString const): Use makeString instead of StringBuilder.

Source/WebCore:

• Modules/indexeddb/server/IndexValueStore.cpp:

(WebCore::IDBServer::IndexValueStore::loggingString const):
Use append instead of appendNumber.

• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::hostName): Use makeString instead of StringBuilder.

• contentextensions/CombinedURLFilters.cpp:

(WebCore::ContentExtensions::prefixTreeVertexToString):
Use append instead of appendNumber.

• contentextensions/Term.h:

(WebCore::ContentExtensions::Term::toString const): Ditto.

• css/CSSFontFeatureValue.cpp:

(WebCore::CSSFontFeatureValue::customCSSText const): Ditto.

• css/CSSTimingFunctionValue.cpp:

(WebCore::CSSStepsTimingFunctionValue::customCSSText const): Ditto.

• dom/Document.cpp:

(WebCore::Document::downgradeReferrerToRegistrableDomain): Use
makeString instead of StringBuilder.

• editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::generateUniquePrefix): Ditto.

• editing/cocoa/DataDetection.mm:

(WebCore::dataDetectorStringForPath): Use append instead of appendNumber.

• html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition): Ditto.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createContext2d): Use makeString
instead of StringBuilder.
(WebCore::HTMLCanvasElement::createImageBuffer const): Ditto.

• loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::toString const): Use append instead
of appendNumber.

• loader/SubresourceIntegrity.cpp:

(WebCore::integrityMismatchDescription): Use makeString instead of
StringBuilder.

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::rootMargin const): Use append instead
of appendNumber.

• page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::databaseIdentifier const): Use makeString
instead of StringBuilder.

• platform/Decimal.cpp:

(WebCore::Decimal::toString const): Use append instead of appendNumber.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::animationNameForTransition): Use makeString
instead of StringBuilder.

• platform/graphics/ca/TileController.cpp:

(WebCore::TileController::createTileLayer): Ditto.

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(printTransform): Use single append instead of a run of them.
(printLayer): Ditto, and use append instead of apppendNumber.
(PlatformCALayerWin::layerTreeAsString const): Ditto.

• platform/mediarecorder/MediaRecorderPrivateMock.cpp:

(WebCore::MediaRecorderPrivateMock::generateMockCounterString):
Use append instead of appendNumber.

• platform/network/ProxyServer.cpp:

(WebCore::appendProxyServerString): Ditto.

• rendering/RenderTreeAsText.cpp:

(WebCore::nodePosition): Ditto.

• svg/SVGPathUtilities.cpp:

(WebCore::buildStringFromPath): Ditto.

• testing/Internals.cpp:

(WebCore::Internals::parserMetaData): Use makeString instead of
StringBuilder.
(WebCore::appendOffsets): Use append instead of appendNumber.

• testing/MockPageOverlayClient.cpp:

(WebCore::MockPageOverlayClient::drawRect): Use makeString instead
of StringBuilder.
(WebCore::MockPageOverlayClient::mouseEvent): Ditto.

• xml/XMLErrors.cpp:

(WebCore::XMLErrors::appendErrorMessage): Use append instead of
appendNumber.

Source/WebDriver:

• SessionHost.cpp:

(WebDriver::SessionHost::sendCommandToBackend): Use append instead
of appendNumber.

• socket/HTTPServerSocket.cpp:

(WebDriver::HTTPRequestHandler::packHTTPMessage const): Ditto.

Source/WebKit:

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::buildList): Use append instead of appendNumber.
(WebKit::ResourceLoadStatisticsDatabaseStore::findNotVeryPrevalentResources): Ditto.
(WebKit::ResourceLoadStatisticsDatabaseStore::resourceToString const): Ditto.
(WebKit::ResourceLoadStatisticsDatabaseStore::attributionToString): Ditto.
(WebKit::ResourceLoadStatisticsDatabaseStore::privateClickMeasurementToString): Ditto.

• Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile): Ditto.

• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptCallback): Ditto.

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::loggingString): Ditto.

• WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:

(PageResourceLoadClient::didReceiveResponseForResource): Use makeString instead
of StringBuilder.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders): Use append instead of appendNumber.

Source/WebKitLegacy/win:

• WebKitStatistics.cpp:

(WebKitStatistics::comClassNameCounts): Use append instead of
appendNumber.

Source/WTF:

We originally added StringBuilder::appendNumber to resolve the ambiguity
between UChar and uint16_t, but that problem was solved long ago and it
is safe to use StringBuilder::append, including the variadic form, on all
types of numbers and we'll get the same results we did with appendNumber.

• wtf/JSONValues.cpp:

(WTF::JSONImpl::Value::writeJSON const): Use append instead of appendNumber.

• wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendNumber): Deleted.

• wtf/text/StringBuilder.h: Removed appendNumber.

• wtf/text/TextStream.cpp:

(WTF::TextStream::operator<<): Use append instead of appendNumber.

Tools:

• TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

Test append with a number instead of appendNumber.

• TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

Use append instead of appendNumber.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpResponseDescriptionSuitableForTestResult): Use append instead
of appendNumber.
(WTR::dumpFrameScrollPosition): Ditto.
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Use makeString
instead of StringBuilder.
(WTR::InjectedBundlePage::shouldCacheResponse): Ditto.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::attributesOfElement): Use append instead of appendNumber.
(WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
(WTR::stringAtOffset): Ditto.

9:01 AM Changeset in webkit [277436] by Lauro Moura

• 2 edits in trunk/Tools/buildstream

[Flatpak SDK] Update WPEBackend-fdo to 1.8.4
​https://bugs.webkit.org/show_bug.cgi?id=225735

Reviewed by Adrian Perez de Castro.

• elements/sdk/wpebackend-fdo.bst:

8:00 AM Changeset in webkit [277435] by Alan Bujtas

• 3 edits
  4 adds in trunk

[css-flexbox] Flex item construction may affect sibling flex item height computation
​https://bugs.webkit.org/show_bug.cgi?id=225489

Reviewed by Sergio Villar Senin.

Source/WebCore:

Flex item construction triggers layout both on the flex item and on its descendants (see constructFlexItem).
During this layout a percent height descendant may indirectly set an incorrect value on the flex container's
m_hasDefiniteHeight (this is due to the odd way we choose to resolve percent height values on the ancestor chain,
see setOverridingContainingBlockContentLogicalHeight(WTF::nullopt)).
Now this incorrect m_hasDefiniteHeight value (Indefinite) causes the next sibling's (also) percent height
resolve fail as it tells the flex item that the flex container can't help with resolving the percent height value.
As the result we end up with an incorrect, 0px height value for this sibling.
e.g.
<div style="height: 100px; display: flex; flex-direction: column;">

<div id=flexItemA style="height: 50px;"><div style="height: 100%;"></div></div>
<div id=flexItemB style="height: 50%;"></div>

</div>
By the time we get to the construction of flexItemB, the RenderFlexibleBox's (flex container) m_hasDefiniteHeight
is already (and incorrectly) set to Indefinite as the result of us trying to resolve flexItemA's descendant height percentage.
This Indefinite value makes the flexItemB's height resolution fail as we believe that the flex container has indefinite height
e.g "height: auto", while it is clearly resolvable (50% of 100px).
Now if we flip the order and flexItemB comes first, the test case passes fine.
It is very unfortunate that some descendant height resolving process can trigger a state change on the ancestor RenderFlexibleBox, but
fixing it would certainly require some substantial architectural change.
In this patch, we just reset the m_hasDefiniteHeight flag inside the loop to ensure that each flex item
starts with a fresh height percent resolve state.

Test: fast/flexbox/flex-column-with-percent-height-descendants.html

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutFlexItems):

LayoutTests:

• fast/flexbox/flex-column-with-percent-height-descendants-expected.html: Added.
• fast/flexbox/flex-column-with-percent-height-descendants.html: Added.

7:30 AM Changeset in webkit [277434] by Chris Fleizach

• 5 edits
  2 adds in trunk

AX: Crash at WebCore::Document::updateLayout
​https://bugs.webkit.org/show_bug.cgi?id=225677

Reviewed by Alan Bujtas.

Source/WebCore:

Handling notifications while during layout is risky because we can call back into an update method.
We have handled many other cases like this by deferring the notification, as we do here.
Special note: this test can't be made to crash because actual crash requires the accessibility
runtime to be initialized and posting real notifications to the system. But, we can verify that the
notification is still sent correctly under conditions that could lead to a crash.

Test: accessibility/mac/menu-selection-notification-crash.html

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::deferMenuListValueChange):
(WebCore::AXObjectCache::performDeferredCacheUpdate):

• accessibility/AXObjectCache.h:
• accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

LayoutTests:

• accessibility/mac/menu-selection-notification-crash-expected.txt: Added.
• accessibility/mac/menu-selection-notification-crash.html: Added.

7:12 AM Changeset in webkit [277433] by Peng Liu

• 5 edits in trunk/Source/WebKit

Subtitles in Safari fail to appear after switching language
​https://bugs.webkit.org/show_bug.cgi?id=225738

Reviewed by Jer Noble.

TextTrackPrivateRemote::setMode() calls InbandTextTrackPrivate::setMode(), but
it does not set the value of TextTrackPrivateRemote::mode properly. Therefore,
TextTrackPrivateRemote::mode will always be Disabled. When we switch text track
in the WebContent process side, we will only send the IPC message TextTrackSetMode
to RemoteMediaPlayerProxy in the GPU process to change the mode from Disabled
to Showing, but cannot change its value back to Disabled. When a user keeps
switching text track, all text tracks in the GPU process will become Showing,
and MediaPlayerPrivateAVFoundation cannot deal with that. As a result,
the WebContent process won't get the correct subtitles from the GPU process.
cueFormat() has the similar issue, it does not impact the functionality though.

Actually, TextTrackPrivateRemote can simply use the implementations of its
base class InbandTextTrackPrivate regarding mode and cue format.

In addition, TextTrackPrivateRemote does not need to get the "mode" value from
RemoteTextTrackProxy in the GPU process. So this patch removes the mode attribute
of TextTrackPrivateRemoteConfiguration.

• GPUProcess/media/RemoteTextTrackProxy.cpp:

(WebKit::RemoteTextTrackProxy::configuration):

• GPUProcess/media/TextTrackPrivateRemoteConfiguration.h:

(WebKit::TextTrackPrivateRemoteConfiguration::encode const):
(WebKit::TextTrackPrivateRemoteConfiguration::decode):

• WebProcess/GPU/media/TextTrackPrivateRemote.cpp:

(WebKit::TextTrackPrivateRemote::setMode):
(WebKit::TextTrackPrivateRemote::updateConfiguration):

• WebProcess/GPU/media/TextTrackPrivateRemote.h:

6:54 AM Changeset in webkit [277432] by eocanha@igalia.com

• 4 edits in trunk

[GStreamer] media/track/in-band/track-in-band-srt-mkv-kind.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=225697

Source/WebCore:

This is a tentative fix for the flaky crash (I can't reproduce it locally after 10000
repetitions). It makes sure that mediaPlayerPrivate and any parameter passed to
handleTextSample() can either survive or detected to be invalid when the lambda is ran in
the main thread.

Reviewed by Alicia Boya Garcia.

Covered by existing tests.

• platform/graphics/gstreamer/TextSinkGStreamer.cpp:

(webkitTextSinkHandleSample): Protect mediaPlayerPrivate and streadId and check if the mediaPlayerPrivate WeakRef is still alive.

LayoutTests:

Reviewed by Alicia Boya Garcia.

• platform/glib/TestExpectations: Unskipped test.

4:57 AM Changeset in webkit [277431] by dbezhetskov

• 2 edits in trunk/Tools

Add dbezhetskov as a commiter
​https://bugs.webkit.org/show_bug.cgi?id=225742

Reviewed by Caio Araujo Neponoceno de Lima.

• Scripts/webkitpy/common/config/contributors.json:

4:10 AM Changeset in webkit [277430] by Martin Robinson

• 17 edits
  18 adds in trunk/LayoutTests

Import new and updated css-scroll-snap WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=225653

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt:
• web-platform-tests/css/css-scroll-snap/input/keyboard.html:
• web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt:
• web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps.html:
• web-platform-tests/css/css-scroll-snap/scroll-margin-visibility-check-expected.txt: Added.
• web-platform-tests/css/css-scroll-snap/scroll-margin-visibility-check.html: Added.
• web-platform-tests/css/css-scroll-snap/scroll-padding-and-margin-expected.txt: Added.
• web-platform-tests/css/css-scroll-snap/scroll-padding-and-margin.html: Added.
• web-platform-tests/css/css-scroll-snap/scroll-snap-root-001-expected.html: Added.
• web-platform-tests/css/css-scroll-snap/scroll-snap-root-001.html: Added.
• web-platform-tests/css/css-scroll-snap/scroll-snap-root-002-expected.html: Added.
• web-platform-tests/css/css-scroll-snap/scroll-snap-root-002.html: Added.
• web-platform-tests/css/css-scroll-snap/scroll-snap-root-003-expected.html: Added.
• web-platform-tests/css/css-scroll-snap/scroll-snap-root-003.html: Added.
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/direction-rtl.html:
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/scroll-snap-initial-layout-000-expected.html: Added.
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/scroll-snap-initial-layout-000.html: Added.
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/scroll-snap-writing-mode-000-expected.html: Added.
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/scroll-snap-writing-mode-000.html: Added.
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/w3c-import.log:
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/writing-mode-horizontal-tb.html:
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/writing-mode-vertical-lr.html:
• web-platform-tests/css/css-scroll-snap/snap-after-initial-layout/writing-mode-vertical-rl.html:
• web-platform-tests/css/css-scroll-snap/snap-after-relayout/resnap-to-focused-expected.txt: Added.
• web-platform-tests/css/css-scroll-snap/snap-after-relayout/resnap-to-focused.html: Added.
• web-platform-tests/css/css-scroll-snap/snap-after-relayout/w3c-import.log:
• web-platform-tests/css/css-scroll-snap/snap-at-user-scroll-end-expected.txt: Added.
• web-platform-tests/css/css-scroll-snap/snap-at-user-scroll-end.html: Added.
• web-platform-tests/css/css-scroll-snap/support/common.js:

(async keyPress):

• web-platform-tests/css/css-scroll-snap/w3c-import.log:

LayoutTests:

• TestExpectations:
• platform/ios-wk2/TestExpectations:

3:39 AM Changeset in webkit [277429] by timothy_horton@apple.com

• 2 edits in trunk/Tools

ResizeReversePaginatedWebView fails on some OS versions on some hardware
​https://bugs.webkit.org/show_bug.cgi?id=224699
<rdar://76782199>

Reviewed by Megan Gardner.

• TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:

(TestWebKitAPI::didLayout):
This test does *not* care about the specific number of pages that are
generated; the key to the test is the scroll position check.

Since the page-count check in this test has caused lots of trouble
in the past (see the history) just remove it and replace it with a
check that we ended up paginated at all.

2:53 AM Changeset in webkit [277428] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

REGRESSION(r277262): test imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=225659

Reviewed by Adrian Perez de Castro.

Do not try to grab focus on WebView widget for synthesized mouse press and release events if the widget has
already the focus or is not the current toplevel focus widget.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSynthesizeMouseEvent):

2:49 AM Changeset in webkit [277427] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit

Unreviewed, reverting r277258.
​https://bugs.webkit.org/show_bug.cgi?id=225740

Caused layout test failures

Reverted changeset:

"[GTK] Use always async scrolling in accelerated compositing
mode"
​https://bugs.webkit.org/show_bug.cgi?id=225512
​https://trac.webkit.org/changeset/277258

1:00 AM Changeset in webkit [277426] by Carlos Garcia Campos

• 5 edits in trunk/Source/WebKit

[GTK][WPE] Add ArgumentCoder for GTlsCertificate
​https://bugs.webkit.org/show_bug.cgi?id=225509

Reviewed by Adrian Perez de Castro.

Move the GTlsCertificate serialization from CertificateInfo ArgumentCoder to its own.

• Shared/glib/ArgumentCodersGLib.cpp:

(IPC::ArgumentCoder<GRefPtr<GVariant>>::encode):
(IPC::ArgumentCoder<GRefPtr<GVariant>>::decode):
(IPC::ArgumentCoder<GRefPtr<GTlsCertificate>>::encode):
(IPC::ArgumentCoder<GRefPtr<GTlsCertificate>>::decode):
(IPC::encode): Deleted.
(IPC::decode): Deleted.

• Shared/glib/ArgumentCodersGLib.h:
• Shared/glib/UserMessage.cpp:

(WebKit::UserMessage::encode const):
(WebKit::UserMessage::decode):

• Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<CertificateInfo>::encode):
(IPC::ArgumentCoder<CertificateInfo>::decode):