Context Navigation

← Previous Period
Next Period →

Timeline

May 15, 2021:

11:36 PM Changeset in webkit [277564] by rniwa@webkit.org

22 edits in trunk

Delete WebSQL code from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=225739

Reviewed by Sihui Liu.

Source/WebCore:

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebSQLEnabled): Replaced setWebSQLDisabled.

Source/WebKit:

Deleted WebSQL code. We keep some code for website data store since it's possible
for user's device to still have WebSQL data, and we should be able to delete them.

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::monitoredDataTypes):

Shared/WebProcessDataStoreParameters.h:

(WebKit::WebProcessDataStoreParameters::encode const):
(WebKit::WebProcessDataStoreParameters::decode):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebSQLDisabled):
(WKPreferencesGetWebSQLDisabled):

UIProcess/API/C/WKPreferencesRef.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::webProcessDataStoreParameters):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setWebsiteDataStoreParameters):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformSetWebsiteDataStoreParameters):

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:

Deleted the experimental feature to disable WebSQL since we've been shipping this,
and made the flag to selectively enable WebSQL in WebKit1 an internal debug setting
since nobody should be enabling this now.

Scripts/Preferences/WebPreferencesExperimental.yaml:
Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

MiniBrowser/playstation/WebContext.cpp:

(WebContext::WebContext):

TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(runWebsiteDataStoreCustomPaths):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::configureWebsiteDataStoreTemporaryDirectories):

9:07 PM Changeset in webkit [277563] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC] Make redundant public helpers private in FormattingContext
https://bugs.webkit.org/show_bug.cgi?id=225747

Reviewed by Antti Koivisto.

layout/formattingContexts/FormattingContext.h:
layout/formattingContexts/FormattingGeometry.cpp:

(WebCore::Layout::FormattingGeometry::computedHeightValue const):

layout/formattingContexts/FormattingQuirks.cpp:

(WebCore::Layout::FormattingQuirks::heightValueOfNearestContainingBlockWithFixedHeight):

9:06 PM Changeset in webkit [277562] by Said Abou-Hallawa

5 edits in trunk/Source/WebKit

[GPU Process] Ensure RemoteRenderingBackendProxy is restored to its original state when GPUP connection is closed
https://bugs.webkit.org/show_bug.cgi?id=225781
<rdar://76678163>

Reviewed by Darin Adler.

GPUProcess may exit in different scenarios: a crash, under memory pressure
or when it is not being used; see r276148. In all cases, the state of
RemoteRenderingBackendProxy has to be restored to its original state when
it was created. gpuProcessConnectionDidClose() is supposed to do that.
But some members are not cleared in this function.

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::gpuProcessConnectionDidClose):
Make sure the resource cache and the getImageData memory and semaphore
are cleared.

(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):
Add this helper method to be called when a RemoteImageBufferProxy is first
created or when its backend is cleared.

(WebKit::RemoteRenderingBackendProxy::createImageBuffer):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
Add this new function to restore RemoteResourceCacheProxy to its original
state.

WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

(WebKit::RemoteResourceCacheProxy::imageBuffers const): Deleted.

8:32 PM Changeset in webkit [277561] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC] Make redundant public helpers private in TableFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=225748

Reviewed by Antti Koivisto.

layout/formattingContexts/table/TableFormattingContext.h:
layout/formattingContexts/table/TableFormattingGeometry.cpp:

(WebCore::Layout::TableFormattingGeometry::cellHeigh const):

layout/formattingContexts/table/TableFormattingQuirks.h:

(WebCore::Layout::TableFormattingQuirks::formattingContext const):
(WebCore::Layout::TableFormattingQuirks::geometry const): Deleted.

8:14 PM Changeset in webkit [277560] by weinig@apple.com

27 edits in trunk

Allow conditionally enabling OffscreenCanvas only for non-worker contexts
https://bugs.webkit.org/show_bug.cgi?id=225845

Reviewed by Darin Adler.

Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:
Source/cmake/WebKitFeatures.cmake:

Match current behavior of ENABLE_OFFSCREEN_CANVAS for ENABLE_OFFSCREEN_CANVAS_IN_WORKERS.

Source/WebCore:

Enable both compile time and runtime conditional enablement of just the
non-worker OffscreenCanvas code path.

To make this work a new IDL extended attribute was needed, ConditionalForWorker=FOO,
which allows specifying an additional macro to check for whether the constructor
should be exposed on workers. Ideally this would be generic for any context type,
but at the moment, the limited syntax of extended attributes makes that hard. If
generalization is needed (or a similar syntax is needed for something else) this can
be revisited.

To support runtime conditional exposure, the existing EnabledForContext, which calls
a static function on the implementation class passing the ScriptExecutationContext
is used. If conditional per context type ever becomes a common thing, we should add
another extended attribute (and add syntax to support like above) that allows specifying
both the context type and the setting name.

Other than that, uses of ENABLE_OFFSCREEN_CANVAS that guarded worker specific functionality
were replaced by ENABLE_OFFSCREEN_CANVAS_IN_WORKERS.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::computeMemoryCost const):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValue::SerializedScriptValue):

bindings/scripts/IDLAttributes.json:
bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttributes):

html/HTMLCanvasElement.idl:
html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::enabledForContext):

html/OffscreenCanvas.h:
html/OffscreenCanvas.idl:
html/canvas/OffscreenCanvasRenderingContext2D.cpp:

(WebCore::OffscreenCanvasRenderingContext2D::enabledForContext):

html/canvas/OffscreenCanvasRenderingContext2D.h:
html/canvas/OffscreenCanvasRenderingContext2D.idl:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setOffscreenCanvasInWorkersEnabled):
(WebCore::RuntimeEnabledFeatures::offscreenCanvasInWorkersEnabled const):

workers/DedicatedWorkerGlobalScope.h:
workers/DedicatedWorkerGlobalScope.idl:
workers/WorkerAnimationController.cpp:
workers/WorkerAnimationController.h:

Source/WTF:

Scripts/Preferences/WebPreferencesInternal.yaml:

Add new OffscreenCanvasInWorkersEnabled preference.

wtf/PlatformEnable.h:

Add new ENABLE_OFFSCREEN_CANVAS_IN_WORKERS macro.

Tools:

Scripts/webkitperl/FeatureList.pm:
WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::defaults):
Match current behavior of ENABLE_OFFSCREEN_CANVAS and OffscreenCanvasEnabled
for ENABLE_OFFSCREEN_CANVAS_IN_WORKERS and OffscreenCanvasInWorkersEnabled.

8:04 PM Changeset in webkit [277559] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC] Make redundant public helpers private in InlineFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=225749

Reviewed by Antti Koivisto.

layout/formattingContexts/inline/InlineFormattingContext.h:
layout/formattingContexts/inline/InlineFormattingGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::isAtSoftWrapOpportunity):

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const):

7:35 PM Changeset in webkit [277558] by Alan Bujtas

8 edits in trunk/Source/WebCore

[LFC] Make redundant public helpers private in BlockFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=225750

Reviewed by Antti Koivisto.

layout/formattingContexts/block/BlockFormattingContext.h:
layout/formattingContexts/block/BlockFormattingGeometry.cpp:

(WebCore::Layout::BlockFormattingGeometry::inFlowNonReplacedContentHeightAndMargin):
(WebCore::Layout::BlockFormattingGeometry::inFlowContentHeightAndMargin):

layout/formattingContexts/block/BlockFormattingQuirks.cpp:

(WebCore::Layout::BlockFormattingQuirks::stretchedInFlowHeight):

layout/formattingContexts/block/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockMarginCollapse::quirks const):
(WebCore::Layout::BlockMarginCollapse::marginBeforeCollapsesWithParentMarginBefore const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithParentMarginAfter const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter const):
(WebCore::Layout::BlockMarginCollapse::positiveNegativeMarginBefore const):

layout/formattingContexts/block/BlockMarginCollapse.h:
layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp:

(WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeValues const):
(WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeMarginBefore const):

layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingQuirks.cpp:

(WebCore::Layout::TableWrapperQuirks::overriddenTableHeight const):

7:18 PM Changeset in webkit [277557] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC] Make FormattingGeometry c'tors public
https://bugs.webkit.org/show_bug.cgi?id=225751

Reviewed by Antti Koivisto.

Remove unnecessary class friending.

layout/formattingContexts/FormattingGeometry.h:
layout/formattingContexts/block/BlockFormattingGeometry.h:
layout/formattingContexts/inline/InlineFormattingGeometry.h:
layout/formattingContexts/inline/InlineFormattingQuirks.h:
layout/formattingContexts/table/TableFormattingGeometry.h:

6:56 PM Changeset in webkit [277556] by Alan Bujtas

14 edits
1 move
1 add in trunk/Source/WebCore

[LFC] Move base formatting geometry to its own class
https://bugs.webkit.org/show_bug.cgi?id=225752

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometry const):

layout/formattingContexts/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::layoutState const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::layoutState): Deleted.
(WebCore::Layout::FormattingContext::Geometry::formattingContext const): Deleted.
(WebCore::Layout::FormattingContext::geometry const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::Geometry): Deleted.

layout/formattingContexts/FormattingContextGeometry.cpp: Removed.
layout/formattingContexts/block/BlockFormattingGeometry.cpp:

(WebCore::Layout::BlockFormattingGeometry::BlockFormattingGeometry):
(WebCore::Layout::BlockFormattingGeometry::inFlowNonReplacedContentHeightAndMargin):
(WebCore::Layout::BlockFormattingGeometry::inFlowNonReplacedContentWidthAndMargin):

layout/formattingContexts/block/BlockFormattingGeometry.h:

(WebCore::Layout::BlockFormattingGeometry::formattingContext const):

layout/formattingContexts/flex/FlexFormattingGeometry.cpp:

(WebCore::Layout::FlexFormattingGeometry::FlexFormattingGeometry):

layout/formattingContexts/flex/FlexFormattingGeometry.h:

(WebCore::Layout::FlexFormattingGeometry::formattingContext const):

layout/formattingContexts/inline/InlineFormattingGeometry.cpp:

(WebCore::Layout::InlineFormattingGeometry::InlineFormattingGeometry):
(WebCore::Layout::InlineFormattingGeometry::inlineBlockContentWidthAndMargin):

layout/formattingContexts/inline/InlineFormattingGeometry.h:

(WebCore::Layout::InlineFormattingGeometry::formattingContext const):

layout/formattingContexts/table/TableFormattingGeometry.cpp:

(WebCore::Layout::TableFormattingGeometry::TableFormattingGeometry):

layout/formattingContexts/table/TableFormattingGeometry.h:

(WebCore::Layout::TableFormattingGeometry::formattingContext const):

layout/formattingContexts/table/TableFormattingQuirks.h:

(WebCore::Layout::TableFormattingQuirks::geometry const):

6:50 PM Changeset in webkit [277555] by commit-queue@webkit.org

13 edits
3 deletes in trunk

Remove _WKWebsitePolicies
https://bugs.webkit.org/show_bug.cgi?id=224293

Patch by Alex Christensen <achristensen@webkit.org> on 2021-05-15
Reviewed by Darin Adler.

Source/WebKit:

Its last use was removed in rdar://problem/58064847 and we've released a Safari version since then.
It was replaced by WKWebpagePreferences

SourcesCocoa.txt:
UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateWebsitePolicies:]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/WKWebpagePreferences.mm:
UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h:
UIProcess/API/Cocoa/_WKWebsitePolicies.h:
UIProcess/API/Cocoa/_WKWebsitePolicies.mm: Removed.
UIProcess/API/Cocoa/_WKWebsitePoliciesInternal.h: Removed.
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::sendAudioComponentRegistrations):

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::draggingExited):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::WebViewImpl::setPromisedDataForImage):

WebKit.xcodeproj/project.pbxproj:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[CustomJavaScriptUserAgentDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[CustomNavigatorPlatformDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
(-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
(-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
(-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.

6:21 PM Changeset in webkit [277554] by Alan Bujtas

5 edits
1 move
1 add in trunk/Source/WebCore

[LFC] Move table formatting geometry to its own class
https://bugs.webkit.org/show_bug.cgi?id=225753

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/table/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::geometry const):

layout/formattingContexts/table/TableFormattingContext.h:

(WebCore::Layout::TableFormattingContext::Geometry::Geometry): Deleted.

layout/formattingContexts/table/TableFormattingContextGeometry.cpp: Removed.

6:05 PM Changeset in webkit [277553] by Chris Dumez

23 edits in trunk/Source/WebCore

Clean up BaseAudioContext now that legacy/prefixed WebAudio is gone
https://bugs.webkit.org/show_bug.cgi?id=225843

Reviewed by Darin Adler.

The BaseAudioContext class hierarchy used to be a bit complicated when
we supposed legacy WebAudio because OfflineAudioContext would subclass
BaseAudioContext directly, while WebKitOfflineAudioContext would
subclass BaseAudioContext via AudioContext. The class hierarchy is now
a lot simpler, BaseAudioContext is the base class and it has exactly
2 subclasses: OfflineAudioContext and AudioContext (for real-time
rendering). Now that the legacy WebAudio code is gone, this patch
cleans up BaseAudioContext and moves as much code as possible to its
subclasses (OfflineAudioContext & AudioContext).

Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setBuffer):

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::activeDOMObjectName const):

Modules/webaudio/AudioContext.h:

(isType):

Modules/webaudio/AudioContextState.h:
Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::setChannelCount):

Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):

Modules/webaudio/AudioWorkletNode.cpp:

(WebCore::AudioWorkletNode::create):

Modules/webaudio/BaseAudioContext.cpp:

(WebCore::generateContextID):
(WebCore::BaseAudioContext::BaseAudioContext):
(WebCore::BaseAudioContext::lazyInitialize):
(WebCore::BaseAudioContext::uninitialize):
(WebCore::BaseAudioContext::stop):
(WebCore::BaseAudioContext::createScriptProcessor):
(WebCore::BaseAudioContext::derefFinishedSourceNodes):
(WebCore::BaseAudioContext::lockInternal):
(WebCore::BaseAudioContext::tryLock):
(WebCore::BaseAudioContext::unlock):
(WebCore::BaseAudioContext::handlePostRenderTasks):
(WebCore::BaseAudioContext::deleteMarkedNodes):
(WebCore::BaseAudioContext::updateAutomaticPullNodes):
(WebCore::BaseAudioContext::postTask):
(WebCore::BaseAudioContext::workletIsReady):

Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::isInitialized const):
(WebCore::BaseAudioContext::currentSampleFrame const):
(WebCore::BaseAudioContext::currentTime const):
(WebCore::BaseAudioContext::sampleRate const):
(WebCore::BaseAudioContext::listener):
(WebCore::BaseAudioContext::incrementConnectionCount):
(WebCore::BaseAudioContext::isAudioThread const):
(WebCore::BaseAudioContext::isAudioThreadFinished const):
(WebCore::BaseAudioContext::isGraphOwner const):

Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):

Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):

Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::context):
(WebCore::DefaultAudioDestinationNode::context const):

Modules/webaudio/DefaultAudioDestinationNode.h:
Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):

Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::setFormat):

Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::OfflineAudioContext):
(WebCore::OfflineAudioContext::create):
(WebCore::OfflineAudioContext::uninitialize):
(WebCore::OfflineAudioContext::activeDOMObjectName const):
(WebCore::OfflineAudioContext::startRendering):
(WebCore::OfflineAudioContext::suspendRendering):
(WebCore::OfflineAudioContext::resumeRendering):
(WebCore::OfflineAudioContext::didSuspendRendering):
(WebCore::OfflineAudioContext::finishedRendering):
(WebCore::OfflineAudioContext::settleRenderingPromise):
(WebCore::OfflineAudioContext::dispatchEvent):

Modules/webaudio/OfflineAudioContext.h:

(isType):

Modules/webaudio/OfflineAudioContext.idl:
Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::context):
(WebCore::OfflineAudioDestinationNode::context const):

Modules/webaudio/OfflineAudioDestinationNode.h:
Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):

4:55 PM Changeset in webkit [277552] by Alan Bujtas

5 edits
1 move
1 add in trunk/Source/WebCore

[LFC] Move inline formatting geometry to its own class
https://bugs.webkit.org/show_bug.cgi?id=225754

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::geometry const):

layout/formattingContexts/inline/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::Geometry::Geometry): Deleted.

layout/formattingContexts/inline/InlineFormattingContextGeometry.cpp: Removed.

4:54 PM Changeset in webkit [277551] by berto@igalia.com

2 edits in trunk/Source/WTF

CeilingOnPageSize too low for Loongson CPUs
https://bugs.webkit.org/show_bug.cgi?id=221198
<rdar://problem/74089683>

Reviewed by Michael Catanzaro.

Increase the page size to 16KB in MIPS64.

wtf/PageBlock.h:

4:03 PM Changeset in webkit [277550] by Alan Bujtas

5 edits
1 move
1 add in trunk/Source/WebCore

[LFC] Move flex formatting geometry to its own class
https://bugs.webkit.org/show_bug.cgi?id=225755

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::geometry const):

layout/formattingContexts/flex/FlexFormattingContext.h:

(WebCore::Layout::FlexFormattingContext::Geometry::Geometry): Deleted.

layout/formattingContexts/flex/FlexFormattingContextGeometry.cpp: Removed.

3:47 PM WebKitGTK/2.32.x edited by Michael Catanzaro

(diff)

3:30 PM Changeset in webkit [277549] by Alan Bujtas

10 edits
1 move
1 add in trunk/Source/WebCore

[LFC] Move block formatting geometry to its own class
https://bugs.webkit.org/show_bug.cgi?id=225756

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/block/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::geometry const):

layout/formattingContexts/block/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::formattingContext const): Deleted.
(WebCore::Layout::BlockFormattingContext::geometry const): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::Geometry): Deleted.

layout/formattingContexts/block/BlockFormattingContextGeometry.cpp: Removed.
layout/formattingContexts/block/BlockFormattingQuirks.cpp:

(WebCore::Layout::BlockFormattingQuirks::stretchedInFlowHeight):

layout/formattingContexts/block/BlockFormattingQuirks.h:

(WebCore::Layout::BlockFormattingQuirks::formattingContext const):
(WebCore::Layout::BlockFormattingQuirks::geometry const): Deleted.

layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp:
layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp:
layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingQuirks.cpp:

(WebCore::Layout::TableWrapperQuirks::overriddenTableHeight const):

2:11 PM Changeset in webkit [277548] by Alan Bujtas

11 edits
1 copy
1 move in trunk/Source/WebCore

[LFC] Move base formatting quirks to its own class
https://bugs.webkit.org/show_bug.cgi?id=225757

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::quirks const):

layout/formattingContexts/FormattingContext.h:

(WebCore::Layout::FormattingContext::formattingState):
(WebCore::Layout::FormattingContext::Quirks::layoutState const): Deleted.
(WebCore::Layout::FormattingContext::Quirks::layoutState): Deleted.
(WebCore::Layout::FormattingContext::Quirks::formattingContext const): Deleted.
(WebCore::Layout::FormattingContext::quirks const): Deleted.
(WebCore::Layout::FormattingContext::Quirks::Quirks): Deleted.

layout/formattingContexts/FormattingContextQuirks.cpp: Removed.
layout/formattingContexts/block/BlockFormattingQuirks.cpp:

(WebCore::Layout::BlockFormattingQuirks::BlockFormattingQuirks):

layout/formattingContexts/block/BlockFormattingQuirks.h:

(WebCore::Layout::BlockFormattingQuirks::formattingContext const):

layout/formattingContexts/inline/InlineFormattingQuirks.cpp:

(WebCore::Layout::InlineFormattingQuirks::InlineFormattingQuirks):

layout/formattingContexts/inline/InlineFormattingQuirks.h:

(WebCore::Layout::InlineFormattingQuirks::formattingContext const):

layout/formattingContexts/table/TableFormattingQuirks.cpp:

(WebCore::Layout::TableFormattingQuirks::TableFormattingQuirks):

layout/formattingContexts/table/TableFormattingQuirks.h:

(WebCore::Layout::TableFormattingQuirks::formattingContext const):

1:46 PM Changeset in webkit [277547] by Said Abou-Hallawa

16 edits
6 adds in trunk

Implement CanvasRenderingContext2D.createConicGradient
https://bugs.webkit.org/show_bug.cgi?id=225539

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.conic-expected.txt:

Source/WebCore:

Proposal document:

https://github.com/fserb/canvas2D/blob/master/spec/conic-gradient.md

MDN documentation:

https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/createConicGradient

Tests: fast/canvas/canvas-conic-gradient-angle.html

fast/canvas/canvas-conic-gradient-center.html
fast/canvas/conicGradient-infinite-values.html

html/canvas/CanvasFillStrokeStyles.idl:
html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::CanvasGradient):
(WebCore::m_canvas):
(WebCore::CanvasGradient::create):

html/canvas/CanvasGradient.h:
html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::createConicGradient):

html/canvas/CanvasRenderingContext2DBase.h:

Source/WebInspectorUI:

UserInterface/Models/NativeFunctionParameters.js:
UserInterface/Models/Recording.js:

(WI.Recording.prototype.async swizzle):

UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._classNameForAction):

LayoutTests:

fast/canvas/canvas-conic-gradient-angle-expected.html: Added.
fast/canvas/canvas-conic-gradient-angle.html: Added.
fast/canvas/canvas-conic-gradient-center-expected.html: Added.
fast/canvas/canvas-conic-gradient-center.html: Added.
fast/canvas/conicGradient-infinite-values-expected.txt: Added.
fast/canvas/conicGradient-infinite-values.html: Added.
inspector/canvas/recording-html-2d-expected.txt:
inspector/canvas/recording-html-2d.html:
platform/win/TestExpectations:

1:22 PM Changeset in webkit [277546] by Alan Bujtas

5 edits
1 copy
1 move in trunk/Source/WebCore

[LFC] Move table formatting quirks to its own class
https://bugs.webkit.org/show_bug.cgi?id=225758

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/table/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::quirks const):

layout/formattingContexts/table/TableFormattingContext.h:

(WebCore::Layout::TableFormattingContext::Quirks::Quirks): Deleted.

layout/formattingContexts/table/TableFormattingContextQuirks.cpp: Removed.

12:50 PM Changeset in webkit [277545] by Alan Bujtas

6 edits
1 move
1 add in trunk/Source/WebCore

[LFC] Move inline formatting quirks to its own class
https://bugs.webkit.org/show_bug.cgi?id=225759

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::quirks const):

layout/formattingContexts/inline/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::Quirks::Quirks): Deleted.

layout/formattingContexts/inline/InlineFormattingContextQuirks.cpp: Removed.
layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

11:27 AM Changeset in webkit [277544] by Alan Bujtas

5 edits
1 copy
1 move in trunk/Source/WebCore

[LFC] Move table wrapper quirks to its own class
https://bugs.webkit.org/show_bug.cgi?id=225760

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::quirks const):

layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.h:

(WebCore::Layout::TableWrapperBlockFormattingContext::Quirks::Quirks): Deleted.

layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContextQuirks.cpp: Removed.

10:51 AM Changeset in webkit [277543] by weinig@apple.com

9 edits in trunk/Source/WebCore

Move CanvasRenderingContext2DSettings down to CanvasRenderingContext2DBase so it can be used there (and to support OffscreenCanvas)
https://bugs.webkit.org/show_bug.cgi?id=225836

Reviewed by Simon Fraser.

In subsequent changes, it will be useful to have CanvasRenderingContext2DSettings accessible
in CanvasRenderingContext2DBase for implementing color space support in ImageData.

While doing this, I noticed it was trivial to add support for passing the settings
to OffscreenCanvasRenderingContext2D, so I add that as well.

html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::getContext):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::pixelFormat const): Deleted.
(WebCore::CanvasRenderingContext2D::colorSpace const): Deleted.

html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::CanvasRenderingContext2DBase):
(WebCore::CanvasRenderingContext2DBase::pixelFormat const):
(WebCore::CanvasRenderingContext2DBase::colorSpace const):

html/canvas/CanvasRenderingContext2DBase.h:

(WebCore::CanvasRenderingContext2DBase::getContextAttributes const):

html/canvas/OffscreenCanvasRenderingContext2D.cpp:

(WebCore::OffscreenCanvasRenderingContext2D::OffscreenCanvasRenderingContext2D):

html/canvas/OffscreenCanvasRenderingContext2D.h:
html/canvas/PaintRenderingContext2D.cpp:

(WebCore::PaintRenderingContext2D::PaintRenderingContext2D):

10:50 AM Changeset in webkit [277542] by Alan Bujtas

8 edits
1 move
1 add in trunk/Source/WebCore

[LFC] Move block formatting quirks to its own class
https://bugs.webkit.org/show_bug.cgi?id=225761

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/FormattingContext.h:

(WebCore::Layout::FormattingContext::Quirks::layoutState const):
(WebCore::Layout::FormattingContext::Quirks::layoutState):
(WebCore::Layout::FormattingContext::Quirks::formattingContext const):
(WebCore::Layout::FormattingContext::quirks const):

layout/formattingContexts/block/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::quirks const):

layout/formattingContexts/block/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Quirks::formattingContext const): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::geometry const): Deleted.
(WebCore::Layout::BlockFormattingContext::quirks const): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::Quirks): Deleted.

layout/formattingContexts/block/BlockFormattingContextQuirks.cpp: Removed.
layout/formattingContexts/block/BlockMarginCollapse.cpp:
layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.h:

(WebCore::Layout::TableWrapperBlockFormattingContext::Quirks::Quirks):

9:59 AM Changeset in webkit [277541] by Alexey Shvayka

12 edits
1 add in trunk

Turn callGetter() / callSetter() into instance methods
https://bugs.webkit.org/show_bug.cgi?id=225831

Reviewed by Ross Kirsling.

JSTests:

microbenchmarks/put-slow-no-cache-setter.js: Added.

Source/JavaScriptCore:

Turn callGetter() / callSetter() into instance methods to simplify their signatures.
Rename base parameter to thisValue, avoiding similarity with slotBase().
Accept bool shouldThrow in callSetter() since ECMAMode is cumbersome to construct.
Replace isSetterNull(), which does LIKELY(inherits), with direct JSType check.
Introduce getCallData(VM&, JSCell*) overload to avoid extra checks / casts.
Move isValidCallee() to JSCell and handle primitives gracefully.

No behavior change. Advances provided callSetter() microbenchmark by 2%.

runtime/GetterSetter.cpp:

(JSC::GetterSetter::callGetter):
(JSC::GetterSetter::callSetter):
(JSC::callGetter): Deleted.
(JSC::callSetter): Deleted.

runtime/GetterSetter.h:
runtime/JSCJSValue.cpp:

(JSC::JSValue::isValidCallee): Deleted.

runtime/JSCJSValue.h:
runtime/JSCell.cpp:

(JSC::JSCell::isValidCallee const):

runtime/JSCell.h:
runtime/JSObject.cpp:

(JSC::JSObject::putInlineSlow):

runtime/JSObjectInlines.h:

(JSC::getCallData):
(JSC::getConstructData):

runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter const):

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayEntry::put):

9:21 AM Changeset in webkit [277540] by Alan Bujtas

8 edits
1 add in trunk/Source/WebCore

[LFC] Move BlockMarginCollapse to its own class
https://bugs.webkit.org/show_bug.cgi?id=225762

Reviewed by Antti Koivisto.

WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/FormattingContext.h:

(WebCore::Layout::FormattingContext::formattingState const):

layout/formattingContexts/block/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::updateMarginAfterForPreviousSibling):
(WebCore::Layout::BlockFormattingContext::marginCollapse const):

layout/formattingContexts/block/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::formattingState const):
(WebCore::Layout::BlockFormattingContext::Quirks::formattingContext const):
(WebCore::Layout::BlockFormattingContext::Quirks::geometry const):
(WebCore::Layout::BlockFormattingContext::quirks const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::layoutState): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::layoutState const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::formattingContext const): Deleted.
(WebCore::Layout::BlockFormattingContext::marginCollapse const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::MarginCollapse): Deleted.

layout/formattingContexts/block/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockMarginCollapse::BlockMarginCollapse):
(WebCore::Layout::BlockMarginCollapse::hasClearance const):
(WebCore::Layout::BlockMarginCollapse::marginBeforeCollapsesWithParentMarginAfter const):
(WebCore::Layout::BlockMarginCollapse::marginBeforeCollapsesWithParentMarginBefore const):
(WebCore::Layout::BlockMarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter const):
(WebCore::Layout::BlockMarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithSiblingMarginBeforeWithClearance const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithParentMarginBefore const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithParentMarginAfter const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithNextSiblingMarginBefore const):
(WebCore::Layout::BlockMarginCollapse::marginsCollapseThrough const):
(WebCore::Layout::BlockMarginCollapse::computedPositiveAndNegativeMargin const):
(WebCore::Layout::BlockMarginCollapse::marginValue const):
(WebCore::Layout::BlockMarginCollapse::positiveNegativeValues const):
(WebCore::Layout::BlockMarginCollapse::positiveNegativeMarginBefore const):
(WebCore::Layout::BlockMarginCollapse::positiveNegativeMarginAfter const):
(WebCore::Layout::BlockMarginCollapse::marginBeforeIgnoringCollapsingThrough):
(WebCore::Layout::BlockMarginCollapse::collapsedVerticalValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::hasClearance const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginAfter const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithSiblingMarginBeforeWithClearance const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginBefore const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginAfter const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithNextSiblingMarginBefore const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedPositiveAndNegativeMargin const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginValue const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::updateMarginAfterForPreviousSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeIgnoringCollapsingThrough): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues): Deleted.

layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp:

(WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeValues const):
(WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeMarginBefore const):
(WebCore::Layout::BlockMarginCollapse::precomputedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeValues const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeMarginBefore const): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedMarginBefore): Deleted.

layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeHeightAndMarginForTableBox):

7:26 AM Changeset in webkit [277539] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] REGRESSION: Kinetic scrolling on touchpad doesn't work with async scrolling off
https://bugs.webkit.org/show_bug.cgi?id=224182

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2021-05-15
Reviewed by Michael Catanzaro.

Don't clear the scroll history every time we scroll, that defeats the whole point of having
the scroll history.

platform/generic/ScrollAnimatorGeneric.cpp:

(WebCore::ScrollAnimatorGeneric::scrollToPositionWithoutAnimation):

5:47 AM Changeset in webkit [277538] by Antti Koivisto

7 edits
2 adds in trunk

Don't allow :visited link style in subtrees that use mix-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=225446
rdar://65686091

Reviewed by Darin Adler.
Source/WebCore:

Test: fast/css/visited-link-mix-blend-mode.html

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::visitedDependentColor const):

Return unvisited style in substrees that use mix-blend-mode.

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setBlendMode):
(WebCore::RenderStyle::isInSubtreeWithBlendMode const):

Add an inherited fake property for tracking this.

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

rendering/style/StyleRareInheritedData.h:

LayoutTests:

fast/css/visited-link-mix-blend-mode-expected.html: Added.
fast/css/visited-link-mix-blend-mode.html: Added.

4:00 AM Changeset in webkit [277537] by aakash_jain@apple.com

2 edits in trunk/Tools

report-non-inclusive-language should skip node_modules directory
https://bugs.webkit.org/show_bug.cgi?id=225827

Reviewed by Darin Adler.

Scripts/report-non-inclusive-language: Skip node_modules directory as it contains external code.

12:40 AM Changeset in webkit [277536] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit

Replace PlatformCAAnimationRemote::KeyframeValue with Variant
https://bugs.webkit.org/show_bug.cgi?id=225474

Patch by Ian Gilbert <iang@apple.com> on 2021-05-15
Reviewed by Ryosuke Niwa.

KeyframeValue was effectively a Variant. Replaced the existing class with a WTF::Variant.

No test as this does not change code behavior.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<RefPtr<WebCore::FilterOperation>>::encode):
(IPC::ArgumentCoder<RefPtr<WebCore::FilterOperation>>::decode):

Shared/WebCoreArgumentCoders.h:
WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h:
WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::animationValueFromKeyframeValue):
(WebKit::operator<<):
(WebKit::PlatformCAAnimationRemote::KeyframeValue::encode const): Deleted.
(WebKit::PlatformCAAnimationRemote::KeyframeValue::decode): Deleted.

May 14, 2021:

10:46 PM Changeset in webkit [277535] by Chris Dumez

28 edits
1 delete in trunk

Drop FileSystem::fileMetadata() / fileMetadataFollowingSymlinks()
https://bugs.webkit.org/show_bug.cgi?id=225820

Reviewed by Darin Adler.

Source/JavaScriptCore:

Update our code base because of the FileSystem API changes.

API/JSScript.mm:

(validateBytecodeCachePath):

Source/WebCore:

Update our code base because of the FileSystem API changes.

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
(WebCore::toFileSystemEntries):
(WebCore::fileTypeIgnoringHiddenFiles):
(WebCore::validatePathIsExpectedType):
(WebCore::DOMFileSystem::getParent):
(WebCore::DOMFileSystem::getEntry):
(WebCore::DOMFileSystem::getFile):

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

fileapi/File.cpp:

(WebCore::File::isDirectory const):

html/DirectoryFileListCreator.cpp:

(WebCore::appendDirectoryFiles):
(WebCore::gatherFileInformation):

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::ensureAssetCacheExistsForPath):

platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::startTrackingModifications):

platform/network/BlobRegistryImpl.cpp:
platform/network/FormData.cpp:

(WebCore::FormData::prepareForUpload):

platform/network/mac/BlobDataFileReferenceMac.mm:

(WebCore::BlobDataFileReference::generateReplacementFile):

Source/WebKit:

Update our code base because of the FileSystem API changes.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::getDirectorySize):
(WebKit::CacheStorage::Engine::getDirectories):
(WebKit::CacheStorage::Engine::clearAllCachesFromDisk):

NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::traverseDirectory):

Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::ensureSandboxCacheDirectory):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::isInternalInstall):

Source/WTF:

Drop FileSystem::fileMetadata() / fileMetadataFollowingSymlinks(). Those don't match very closely the
std::filesystem API we use internally and they are not very efficient because we gather several attributes
of a file but the callers are usually only interested in one thing (e.g. file type or file size).

Callers interested in the file size, can call the pre-existing FileSystem::fileSize(). For call sites
wanting to check if it is a hidden file, I introduced a new FileSystem::isHiddenFile() API. For call sites
interested in the file type, I replaced FileSystem::isDirectory() / FileSystem::isDirectoryFollowingSymlinks()
with more generic FileSystem::fileType() / FileSystem::fileTypeFollowingSymlinks().

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/FileMetadata.h: Removed.
wtf/FileSystem.cpp:

(WTF::FileSystemImpl::isHiddenFile):
(WTF::FileSystemImpl::fileTypePotentiallyFollowingSymLinks):
(WTF::FileSystemImpl::fileType):
(WTF::FileSystemImpl::fileTypeFollowingSymlinks):

wtf/FileSystem.h:
wtf/glib/FileSystemGlib.cpp:
wtf/posix/FileSystemPOSIX.cpp:
wtf/win/FileSystemWin.cpp:

Tools:

Update the FileSystem API tests accordingly.

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

10:26 PM Changeset in webkit [277534] by wilander@apple.com

19 edits in trunk

Javascript can't access a SameSite=Strict cookie after page is loaded after a redirect from a third party site
https://bugs.webkit.org/show_bug.cgi?id=208049
<rdar://problem/59701889>

Reviewed by Chris Dumez.

The HTTP WG has decided that SameSite=strict cookies should be returned in document.cookie
even in cases where they are not sent in the HTTP request for the page. Chromium and Gecko
now work according to those rules and the spec is being updated.

See:

Source/WebCore:

Here's an excerpt from the spec change:

'If a user agent does return cookies for a given call to a "non-HTTP" API with
an associated Document, then the user agent MUST compute the cookie-string
following the algorithm defined in {{retrieval-algorithm}}, indicating that the
retrieval is from a "non-HTTP" API. The retrieval-uri is the associated
Document's cookie URL {{COOKIE-URL}}, and the retrieval is same-site if the
Document's "site for cookies" is same-site with the top-level origin as defined
in {{document-requests}}.'

Existing layout tests changed and rebased.

loader/CookieJar.cpp:

(WebCore::CookieJar::sameSiteInfo):

Now takes a IsCookieAccessForDOM parameter and forwards it to SameSiteInfo::create().

(WebCore::CookieJar::cookies const):

Now sends IsCookieAccessForDOM::Yes to CookieJar::sameSiteInfo().

(WebCore::CookieJar::setCookies):

Now sends IsCookieAccessForDOM::Yes to CookieJar::sameSiteInfo().

loader/CookieJar.h:
platform/network/SameSiteInfo.cpp:

(WebCore::SameSiteInfo::create):

Now takes a IsForDOMCookieAccess parameter and if it's IsForDOMCookieAccess::Yes and
the site is top site, sets isSameSite.

platform/network/SameSiteInfo.h:

Now has an enum IsForDOMCookieAccess.

Source/WebKit:

Here's an excerpt from the spec change:

'If a user agent does return cookies for a given call to a "non-HTTP" API with
an associated Document, then the user agent MUST compute the cookie-string
following the algorithm defined in {{retrieval-algorithm}}, indicating that the
retrieval is from a "non-HTTP" API. The retrieval-uri is the associated
Document's cookie URL {{COOKIE-URL}}, and the retrieval is same-site if the
Document's "site for cookies" is same-site with the top-level origin as defined
in {{document-requests}}.'

Existing layout tests changed and rebased.

WebProcess/WebPage/WebCookieJar.cpp:

(WebKit::WebCookieJar::cookies const):

Now sends WebCore::IsCookieAccessForDOM::Yes to WebCore::CookieJar::sameSiteInfo().

(WebKit::WebCookieJar::setCookies):

Now sends WebCore::IsCookieAccessForDOM::Yes to WebCore::CookieJar::sameSiteInfo().

LayoutTests:

Tests changed and rebased accordingly.

http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
http/tests/cookies/same-site/popup-cross-site-post.html:
http/tests/cookies/same-site/popup-cross-site.html:
http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html:
http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.py:
http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-from-cross-origin-page.py:
http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.py:
http/tests/cookies/same-site/user-load-cross-site-redirect-expected.txt:
http/tests/cookies/same-site/user-load-cross-site-redirect.py:

10:02 PM Changeset in webkit [277533] by Jonathan Bedard

4 edits in trunk/Tools

[WebKitTestRunner] Forward WebContent termination reason
https://bugs.webkit.org/show_bug.cgi?id=225818
<rdar://problem/78027164>

Reviewed by Chris Dumez.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage): Use didTerminate callback instead of didCrash callback.
(WTR::TestController::createWebViewWithOptions): Ditto.
(WTR::TestController::webProcessDidTerminate):
(WTR::TestController::processDidCrash): Renamed webProcessDidTerminate.

WebKitTestRunner/TestController.h: Replace processDidCrash with webProcessDidTerminate.
WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformRunUntil):

9:59 PM Changeset in webkit [277532] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Provide custom SetInlineFillGradient copy ctor
https://bugs.webkit.org/show_bug.cgi?id=225688

Patch by Rob Buis <rbuis@igalia.com> on 2021-05-14
Reviewed by Wenson Hsieh.

Provide custom SetInlineFillGradient copy ctor
to deal with invalid SetInlineFillGradient source.

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::SetInlineFillGradient::SetInlineFillGradient):

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::SetInlineFillGradient::isValid const):

9:58 PM Changeset in webkit [277531] by Jonathan Bedard

3 edits in trunk/Tools

[run-webkit-tests] Handle missing simulator state plist
https://bugs.webkit.org/show_bug.cgi?id=225833
<rdar://problem/78036930>

Rubber-stamped by Aakash Jain.

Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.state): If no device plist is found, assume the device is shut down.

Scripts/webkitpy/xcode/simulated_device_unittest.py:

9:18 PM Changeset in webkit [277530] by Chris Dumez

32 edits
17 deletes in trunk/Source

Drop legacy / prefixed WebAudio implementation
https://bugs.webkit.org/show_bug.cgi?id=225832

Reviewed by Darin Adler.

Source/WebCore:

Drop legacy / prefixed WebAudio implementation now that it is no longer
present in shipping and we have received any reports of issues.

This drops all the legacy code but she should be able to clean up the
code further in follow-ups. In particular, I believe some code can
now be moved from BaseAudioContext to OfflineAudioContext.

CMakeLists.txt:
DerivedSources.make:
Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::~AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::totalPitchRate):

Modules/webaudio/AudioBufferSourceNode.h:
Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):

Modules/webaudio/AudioContext.h:
Modules/webaudio/AudioListener.h:
Modules/webaudio/AudioListener.idl:
Modules/webaudio/AudioNode.cpp:
Modules/webaudio/AudioNode.h:
Modules/webaudio/AudioNode.idl:
Modules/webaudio/AudioParam.h:
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):

Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::isOfflineContext const):
(WebCore::BaseAudioContext::BaseAudioContext):

Modules/webaudio/DynamicsCompressorNode.cpp:
Modules/webaudio/DynamicsCompressorNode.h:
Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::OfflineAudioContext):

Modules/webaudio/OscillatorNode.h:
Modules/webaudio/OscillatorNode.idl:
Modules/webaudio/WebKitAudioBufferSourceNode.h: Removed.
Modules/webaudio/WebKitAudioBufferSourceNode.idl: Removed.
Modules/webaudio/WebKitAudioContext.cpp: Removed.
Modules/webaudio/WebKitAudioContext.h: Removed.
Modules/webaudio/WebKitAudioContext.idl: Removed.
Modules/webaudio/WebKitAudioListener.h: Removed.
Modules/webaudio/WebKitAudioListener.idl: Removed.
Modules/webaudio/WebKitAudioPannerNode.cpp: Removed.
Modules/webaudio/WebKitAudioPannerNode.h: Removed.
Modules/webaudio/WebKitAudioPannerNode.idl: Removed.
Modules/webaudio/WebKitDynamicsCompressorNode.h: Removed.
Modules/webaudio/WebKitDynamicsCompressorNode.idl: Removed.
Modules/webaudio/WebKitOfflineAudioContext.cpp: Removed.
Modules/webaudio/WebKitOfflineAudioContext.h: Removed.
Modules/webaudio/WebKitOfflineAudioContext.idl: Removed.
Modules/webaudio/WebKitOscillatorNode.h: Removed.
Modules/webaudio/WebKitOscillatorNode.idl: Removed.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
testing/Internals.cpp:

(WebCore::Internals::setAudioContextRestrictions):

testing/Internals.h:
testing/Internals.idl:

Source/WebKitLegacy/win:

Stop explicitly disabled with prefixed WebAudio implementation given that
it no longer exists.

WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:

Drop preference for prefixed WebAudio, which was disabled everywhere.

Scripts/Preferences/WebPreferencesInternal.yaml:

8:34 PM Changeset in webkit [277529] by weinig@apple.com

3 edits
2 moves in trunk/Source/WebCore

CustomPaintImage being in platform/graphics is a layering violation
https://bugs.webkit.org/show_bug.cgi?id=225356

Reviewed by Darin Adler.

It is layering violation for a file in platform/ to reference classes
like RenderElement or PaintWorkletGlobalScope. This fixes this by moving
CustomPaintImage out of platform/graphics to html/, next to the existing
CustomPaintCanvas class.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
html/CustomPaintImage.cpp: Copied from Source/WebCore/platform/graphics/CustomPaintImage.cpp.
html/CustomPaintImage.h: Copied from Source/WebCore/platform/graphics/CustomPaintImage.h.
platform/graphics/CustomPaintImage.cpp: Removed.
platform/graphics/CustomPaintImage.h: Removed.

8:15 PM Changeset in webkit [277528] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

REGRESSION (r269824): Random tile corruption when scrolling/zooming in macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=225837
<rdar://problem/75053997>

Reviewed by Simon Fraser.

Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
Mark the newly front buffer non-volatile before painting into it.
This was lost in r269824. Oddly, this caused less trouble than
one might expect, except on some particular hardware.

7:05 PM Changeset in webkit [277527] by Darin Adler

22 edits in trunk

output element doesn't react properly to node tree mutations
https://bugs.webkit.org/show_bug.cgi?id=196532

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

web-platform-tests/custom-elements/builtin-coverage-expected.txt:

Updated since HTMLOptionElement now has a constructor. Still not passing, but closer to correct.

web-platform-tests/custom-elements/form-associated/form-reset-callback-expected.txt:

Updated due to changes in HTMLOptionElement, but still not passing.

web-platform-tests/html/semantics/forms/the-output-element/mutations.window-expected.txt:

Updated to reflect passing test.

web-platform-tests/html/semantics/forms/the-output-element/mutations.window.js:

Updated to a newer version of the upstream version of this. Decided to just update this one file
rather than importing the latest version across more tests at this time.

Source/WebCore:

dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAll): Refactored most of the functions
replaceAllChildren and replaceAllChildrenWithNewText into this new one,
and named it based on the name of the operation in the HTML specification.
The function is incomplete, but preserves existing behavior.
(WebCore::ContainerNode::stringReplaceAll): Refactored the rest of the
replaceAllChildrenWithNewText function and renamed to the name from the
HTML specification.

dom/ContainerNode.h: Updated for the above changes.

dom/Node.cpp:

(WebCore::Node::setTextContent): Updated for name change above.

dom/Range.cpp:

(WebCore::Range::surroundContents): Ditto.

editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Ditto.

html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText): Ditto.

html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::HTMLOutputElement): Moved data member
initialization into the class definition.
(WebCore::HTMLOutputElement::create): Added an overload that takes just
a document, for use when invoked from as a constructor.
(WebCore::HTMLOutputElement::parseAttribute): Tightened the logic for the
for attribute. I decided it's better to call through to the base class, even
though we often don't do that for attributes that don't expect the base
class to pay attention to.
(WebCore::HTMLOutputElement::childrenChanged): Deleted. No need for this in
the improved HTML specification version of this element's algorithms.
(WebCore::HTMLOutputElement::reset): Updated based on the HTML specification,
using the default value algorithm rather than the default value mode flag we
were using before.
(WebCore::HTMLOutputElement::setValue): Updated based on the HTML specification,
always setting the default value override based on the current default value,
and using stringReplaceAll. There's no need for the old setTextContentInternal,
since that was all due to the need to avoid infinite recursion in childrenChanged.
(WebCore::HTMLOutputElement::defaultValue const): Updated based on the HTML
specification, deriving the default value from the default value override and
the descendant text content.
(WebCore::HTMLOutputElement::setDefaultValue): Updated based on the HTML
specification, doing a string replace all with the value if the default
value override is null, and updating the default value override otherwise.
(WebCore::HTMLOutputElement::htmlFor): Updated to rename m_tokens to m_forTokens.
(WebCore::HTMLOutputElement::setTextContentInternal): Deleted.

html/HTMLOutputElement.h: Moved DOMTokenList to be a forward declaration

instead of an include. Adde a constructor that takes only a document to be used
from JavaScript. Made the canContainRangeEndPoint override be private like the
other overrides. Removed the childrenChange override and the
setTextContentInternal function. Removed m_isDefaultValueMode,
m_isSetTextContentInProgress, and m_defaultValue. Added m_defaultValueOverride.
Renamed m_tokens to m_forTokens.

html/HTMLOutputElement.idl: Updated to match the HTML specification. This

involved adding a constructor, adding SameObject for the htmlFor attribute,
making the form attribute nullable, and removing [LegacyNullToEmptyString]
from the defaultValue and value attributes.

LayoutTests:

TestExpectations: Removed an expectation for a directory that no longer exists.
platform/mac-wk2/TestExpectations: Removed an expectation for a test that no longer exists.
platform/mac/TestExpectations: Removed an expectation for a directory that no longer exists.

platform/gtk/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:

Updated since HTMLOptionElement now has a constructor. Still not passing, but closer to correct.

6:50 PM Changeset in webkit [277526] by Jonathan Bedard

4 edits in trunk

Fix iOS 14.5 embedded build
https://bugs.webkit.org/show_bug.cgi?id=225835
<rdar://problem/78039315>

Reviewed by Dewei Zhu.

Source/WebKit:

No new tests, build fix.

WebProcess/cocoa/WebProcessCocoa.mm: Import mach.h.

Tools:

Scripts/configure-xcode-for-embedded-development: Add mach.h, mach_error.h and task.h.

5:59 PM Changeset in webkit [277525] by weinig@apple.com

38 edits in trunk/Source

Source/WebCore:
Use PixelBufferFormat to specify ImageBuffer::getPixelData destination format allowing for more control over data conversion
https://bugs.webkit.org/show_bug.cgi?id=225813

Reviewed by Darin Adler.

The reprevious signature of ImageBuffer::getPixelBuffer:

ImageBuffer::getPixelBuffer(AlphaPremultiplication, const IntRect&);

only allowed specifying the type of alpha premultiplication wanted, and hard coded
a pixel format of RGBA8 and color space of SRGB. To support accurate and efficient
access to pixel buffers with different pixel formats and color spaces we need to be
able to tell getPixelBuffer what we want up front, so that if the ImageBuffer already
has a DisplayP3 buffer, and we want DisplayP3 pixels, we don't first convert to SRGB
and then convert back to DisplayP3 (which would be slow and lose any out of gamut
data). The new signature allows us to specify the entire format triple:

ImageBuffer::getPixelBuffer(const PixelBufferFormat&, const IntRect&);

Additionally, ImageBuffer::putPixelBuffer() no longer needs to provide the source
AlphaPremultiplication either, as the PixelBuffer itself also contains that information.

Now that we are passing color space information, we need to support color space conversion,
so PixelBufferConversion was updated to support color space conversion on CG platforms
using vImageConvert_AnyToAny. This is not currently excersised, but will be in a subsequent
change where canvas ImageData gains a color space setting, at which point it can be tested.

We also don't currently support color space conversion on non-CG platforms. This won't
be a problem in the short term, as only CG platforms support DisplayP3, the only other
color space that can be specified currently, but as cleanup, we should add support for
color space conversion using the ColorConversion and ColorTransferFunction infrastructure
for other ports, moving the existing support for SRGB to/from LinearSRGB conversions from
ImageBufferCairoBackend and ImageBufferCairoImageSurfaceBackend.

html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise):

html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::getImageData const):
(WebCore::CanvasRenderingContext2DBase::putImageData):

page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

platform/graphics/ConcreteImageBuffer.h:

(WebCore::ConcreteImageBuffer::putPixelBuffer):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::putPixelBuffer):

platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::convertToLuminanceMask):
(WebCore::ImageBufferBackend::getPixelBuffer const):
(WebCore::ImageBufferBackend::putPixelBuffer):

platform/graphics/ImageBufferBackend.h:
platform/graphics/PixelBufferConversion.cpp:

(WebCore::makeVImageCGImageFormat):
(WebCore::makeVImageBuffer):
(WebCore::convertImagePixelsAccelerated):
(WebCore::convertImagePixels):

platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp:

(WebCore::ImageBufferCairoSurfaceBackend::getPixelBuffer const):
(WebCore::ImageBufferCairoSurfaceBackend::putPixelBuffer):

platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h:
platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::toCFData const):

platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:

(WebCore::ImageBufferCGBitmapBackend::getPixelBuffer const):
(WebCore::ImageBufferCGBitmapBackend::putPixelBuffer):

platform/graphics/cg/ImageBufferCGBitmapBackend.h:
platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::getPixelBuffer const):
(WebCore::ImageBufferIOSurfaceBackend::putPixelBuffer):

platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::PutPixelBuffer::PutPixelBuffer):
(WebCore::DisplayList::PutPixelBuffer::swap):
(WebCore::DisplayList::operator<<):

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::GetPixelBuffer::GetPixelBuffer):
(WebCore::DisplayList::GetPixelBuffer::outputFormat const):
(WebCore::DisplayList::PutPixelBuffer::encode const):
(WebCore::DisplayList::PutPixelBuffer::decode):
(WebCore::DisplayList::PutPixelBuffer::inputFormat const): Deleted.

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::getPixelBuffer):
(WebCore::DisplayList::Recorder::putPixelBuffer):

platform/graphics/displaylists/DisplayListRecorder.h:
platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::convertPixelBufferToColorSpace):
(WebCore::FilterEffect::convertImageBufferToColorSpace):
(WebCore::FilterEffect::copyConvertedPixelBufferToDestination):
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):

platform/graphics/filters/FilterEffect.h:
platform/graphics/win/ImageBufferDirect2DBackend.cpp:

(WebCore::ImageBufferDirect2DBackend::getPixelBuffer const):
(WebCore::ImageBufferDirect2DBackend::putPixelBuffer):

platform/graphics/win/ImageBufferDirect2DBackend.h:
rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

Source/WebKit:
Use PixelBufferFormat to specify ImageBuffer::getPixelBuffer destination format allowing for more control over data conversion
https://bugs.webkit.org/show_bug.cgi?id=225813

Reviewed by Darin Adler.

Update calls/implementations of getPixelBuffer/putPixelBuffer to adjust
to new signature.

GPUProcess/graphics/RemoteImageBuffer.h:
Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:

(WebKit::CGDisplayListImageBufferBackend::getPixelBuffer const):
(WebKit::CGDisplayListImageBufferBackend::putPixelBuffer):

Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::getPixelBuffer const):
(WebKit::ImageBufferShareableBitmapBackend::putPixelBuffer):

WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::putPixelBuffer):

WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableIOSurfaceBackend::getPixelBuffer const):
(WebKit::ImageBufferShareableIOSurfaceBackend::putPixelBuffer):

WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.h:

5:47 PM Changeset in webkit [277524] by Ross Kirsling

2 edits in trunk/Source/JavaScriptCore

REGRESSION (r277221): 2 test262 tests failing
https://bugs.webkit.org/show_bug.cgi?id=225819

Reviewed by Alexey Shvayka.

Undo the other part of r277221's code consolidation --
I'd forgotten that this exists to enforce a evaluation order on AggregateError's arguments.

runtime/AggregateError.cpp:

(JSC::createAggregateError):

5:29 PM Changeset in webkit [277523] by Devin Rousso

12 edits
2 adds in trunk

Sampled Page Top Color: move logic out of Document
https://bugs.webkit.org/show_bug.cgi?id=225480
<rdar://problem/77984539>

Reviewed by Tim Horton.

Source/WebCore:

Having determineSampledPageTopColor be called in enqueuePaintTimingEntryIfNeeded as what
is basically a side effect is not great. The only reason it was there in the first place was
to take advantage of the logic that decided "is this the first contentful paint", but that
logic can be replicated elsewhere. Since the sampled page top color deals more with the page
as a whole instead of an individual Document (which includes subframes), it makes more
sense to have this logic be on a utility PageColorSampler that's used in Page instead.

Test: SampledPageTopColor.MainDocumentChange

page/PageColorSampler.h: Added.
page/PageColorSampler.cpp: Added.

(WebCore::isValidSampleLocation):
(WebCore::sampleColor):
(WebCore::colorDifference):
(WebCore::averageColor):
(WebCore::PageColorSampler::sampleTop):

page/Page.h:
page/Page.cpp:

(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::sampledPageTopColor const):
(WebCore::Page::didChangeMainDocument):

dom/Document.h:

(WebCore::Document::sampledPageTopColor const): Deleted.

dom/Document.cpp:

(WebCore::Document::enqueuePaintTimingEntryIfNeeded):
(WebCore::isValidPageSampleLocation): Deleted.
(WebCore::samplePageColor): Deleted.
(WebCore::colorDifference): Deleted.
(WebCore::averageColor): Deleted.
(WebCore::Document::determineSampledPageTopColor): Deleted.

page/FrameView.h:
page/FrameView.cpp:

(WebCore::FrameView::hasContentfulDescendants const): Added.
(WebCore::FrameView::hasContenfulDescendants const): Deleted.
Drive-by: Fix incorrect spelling.

Source/WebCore/Headers.cmake:
Source/WebCore/Sources.txt:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(TEST.SampledPageTopColor.MainDocumentChange): Added.

5:26 PM Changeset in webkit [277522] by Chris Dumez

6 edits in trunk

Port WTF::FileSystem::realPath() to std::filesystem
https://bugs.webkit.org/show_bug.cgi?id=225828

Reviewed by Darin Adler.

Source/WTF:

Port WTF::FileSystem::realPath() to std::filesystem (in particular std::filesystem::canonical())
so that we no longer need platform-specific code.

wtf/FileSystem.cpp:

(WTF::FileSystemImpl::realPath):

wtf/posix/FileSystemPOSIX.cpp:
wtf/win/FileSystemWin.cpp:

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

5:18 PM Changeset in webkit [277521] by Alan Coon

8 edits in branches/safari-612.1.12-branch/Source

Versioning.

WebKit-7612.1.12.9

5:00 PM Changeset in webkit [277520] by eric.carlson@apple.com

5 edits
2 adds in trunk

[GPUP] a media element with a data url and "crossorigin='anonymous'" doesn't load
https://bugs.webkit.org/show_bug.cgi?id=225786
<rdar://77625185>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/data-url-cross-origin.html

loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource): Set loader options sameOriginDataURLFlag
to SameOriginDataURLFlag::Set so data: urls are treated as same origin.

LayoutTests:

media/data-url-cross-origin-expected.txt: Added.
media/data-url-cross-origin.html: Added.
media/media-file.js:

(findDataURL):

media/sources-fallback-codecs.html:

4:46 PM Changeset in webkit [277519] by Peng Liu

4 edits in trunk

REGRESSION: [ Mac WK2 ] fast/mediastream/audio-track-enabled.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=221985

Reviewed by Eric Carlson.

Source/WebCore:

When MediaSessionManagerCocoa::updateSessionState() goes through all sessions, it
counts all WebAudio sessions regardless their states, and it may set the shared audio
session's category to be AudioSession::AmbientSound if the count of WebAudio sessions
is not zero.

However, when we close a page with WebAudio, we should not count the WebAudio session
here because the corresponding AudioContext is suspended and will be destroyed soon.
Without this patch, the shared audio session's category might be AudioSession::AmbientSound
after we close the WebAudio page.

Modules/webaudio/AudioContext.h:

LayoutTests:

platform/mac-wk2/TestExpectations:

4:34 PM Changeset in webkit [277518] by Patrick Angle

2 edits in trunk/Source/WebKit

Web Inspector: _WKInspector leaks WebInspectorUIProxy
https://bugs.webkit.org/show_bug.cgi?id=225815

Reviewed by Tim Horton.

Add a missing call in _WKInspector's destructor to destruct the WebInspectorUIProxy in API object storage.

UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector dealloc]):

4:30 PM Changeset in webkit [277517] by Alan Coon

1 copy in tags/Safari-612.1.12.8

Tag Safari-612.1.12.8.

4:20 PM Changeset in webkit [277516] by Alan Bujtas

2 edits in trunk/Source/WebCore

[showRenderTree] Do not integral floor the overflow values
https://bugs.webkit.org/show_bug.cgi?id=225825

Reviewed by Simon Fraser.

Integral flooring may hide fractional values caused by rounding bugs.

rendering/RenderObject.cpp:

(WebCore::RenderObject::outputRenderObject const):

4:12 PM Changeset in webkit [277515] by Chris Dumez

23 edits in trunk

Drop "get" prefix from WTF::FileSystem's getFileModificationTime() / getFileCreationTime()
https://bugs.webkit.org/show_bug.cgi?id=225812

Reviewed by Darin Adler.

Source/WebCore:

Update code base due to WTF API change.

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::removeAllDatabasesForFullOriginPath):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabasesModifiedSince):

fileapi/File.cpp:

(WebCore::File::lastModified const):

page/Page.cpp:

(WebCore::Page::userStyleSheet const):

platform/FileStream.cpp:

(WebCore::FileStream::getSize):

platform/network/FormData.cpp:

(WebCore::FormDataElement::EncodedFileData::fileModificationTimeMatchesExpectation const):

platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::parseResponseHeaders):

platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::databaseCreationTime):
(WebCore::SQLiteFileSystem::databaseModificationTime):

Source/WebKit:

Update code base due to WTF API change.

NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::fileTimes):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeMediaKeys):

WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::removeAllMediaKeyStorageForOriginPath):

Source/WebKitLegacy/win:

Update code base due to WTF API change.

Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):

Source/WTF:

We avoid the "get" prefix in WebKit.

wtf/FileSystem.cpp:

(WTF::FileSystemImpl::fileModificationTime):

wtf/FileSystem.h:
wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::fileCreationTime):

wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::fileCreationTime):

wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::fileCreationTimeFromFindData):
(WTF::FileSystemImpl::fileModificationTimeFromFindData):
(WTF::FileSystemImpl::fileCreationTime):

Tools:

Update code base due to WTF API change.

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::runGetFileModificationTimeTest):
(TestWebKitAPI::TEST_F):

4:08 PM Changeset in webkit [277514] by Chris Dumez

7 edits in trunk

Rename FileSystem::getVolumeFreeSpace() to FileSystem::volumeFreeSpace()
https://bugs.webkit.org/show_bug.cgi?id=225811

Reviewed by Darin Adler.

Source/WebKit:

Update code base due to API change.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::computeCapacity):

Source/WTF:

Rename FileSystem::getVolumeFreeSpace() to FileSystem::volumeFreeSpace() given that we
avoid the "get" prefix in WebKit. Also modernize the function by returning an
Optional<uint64_t> instead of using an out-parameter.

wtf/FileSystem.cpp:

(WTF::FileSystemImpl::volumeFreeSpace):

wtf/FileSystem.h:

Tools:

Update code base due to API change.

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

3:32 PM Changeset in webkit [277513] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] Add enclosing line top/bottom to showInlineTreeAndRuns
https://bugs.webkit.org/show_bug.cgi?id=225821

Reviewed by Simon Fraser.

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::showInlineTreeAndRuns):

page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):

3:27 PM Changeset in webkit [277512] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Add ScriptDisallowedScope to MediaPlayerPrivateAVFoundation
https://bugs.webkit.org/show_bug.cgi?id=225797

Reviewed by Eric Carlson.

Deployed ScriptDisallowedScope to a bunch of functions in MediaPlayerPrivateAVFoundation.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):

3:26 PM Changeset in webkit [277511] by Robert Jenner

2 edits in trunk/LayoutTests

[ iOS14-Simulator ] wk2imported/w3c/web-platform-tests/css/css-will-change/will-change-transform-huge-offset-scrolled.html is a flaky ImageOnlyFailure
Nhttps://bugs.webkit.org/show_bug.cgi?id=225830

Unreviewed test gardening.

Setting expectation to Pass ImageOnlyFailure due to causing an EWS slowdown.

platform/ios-simulator-wk2/TestExpectations:

3:23 PM Changeset in webkit [277510] by Wenson Hsieh

3 edits in trunk/Source/WebKit

Replace -[WKContentView _hasPendingImageExtraction] with a monotonically increasing ID
https://bugs.webkit.org/show_bug.cgi?id=225823
rdar://77519437

Reviewed by Tim Horton.

Refactor some image extraction code by turning this boolean flag into a monotonically increasing
ObjectIdentifier instead; see the bug for more details.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _doAfterPendingImageExtraction:]):
(-[WKContentView _invokeAllActionsToPerformAfterPendingImageExtraction:]):

3:23 PM Changeset in webkit [277509] by Russell Epstein

1 copy in tags/Safari-612.1.15

Tag Safari-612.1.15.

3:18 PM Changeset in webkit [277508] by Jean-Yves Avenard

2 edits in trunk/Tools

TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
https://bugs.webkit.org/show_bug.cgi?id=223282
rdar://75495585

Reviewed by Jer Noble.

TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:

(TestWebKitAPI::TEST): Use WkView/NSWindow directly instead of using a
PlatformWebView. A PlatformWebView uses an OffscreenWindow which is a
NSWindow placed with a -10000 offset. This configuration appears to fail
to go into full screen in automation.

3:02 PM Changeset in webkit [277507] by Jean-Yves Avenard

6 edits in trunk

Bad media session artwork URL results in blue "broken image" icon being shown in Now Playing
https://bugs.webkit.org/show_bug.cgi?id=225799
rdar://77990886

Reviewed by Eric Carlson.

Source/WebCore:

By default, when the image's URL doesn't point to an image the CachedImage
will return a default image consistent of a blue interrogation mark.
We need to explicitely check that an error occurred. The naming used in the
method didn't make this need obvious.

Modules/mediasession/MediaMetadata.cpp:

(WebCore::ArtworkImageLoader::notifyFinished): Check for a status error.

testing/Internals.cpp:

(WebCore::Internals::loadArtworkImage): Fix spelling

LayoutTests:

fast/mediasession/metadata/artworkdownload-expected.txt:
fast/mediasession/metadata/artworkdownload.html: Add test case.

2:35 PM Changeset in webkit [277506] by weinig@apple.com

2 edits in trunk/Tools

REGRESSION(r277313): [ Debug ] 2 TestWebKitAPI.IPCTestingAPI (API-Tests) are constant timeouts
https://bugs.webkit.org/show_bug.cgi?id=225816
<rdar://problem/78025515>

Reviewed by Ryosuke Niwa.

TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

Update test for rename from ImageData to PixelBuffer.

2:34 PM Changeset in webkit [277505] by Devin Rousso

29 edits
1 add
1 delete in trunk

Promote -[WKWebView _pageExtendedBackgroundColor] SPI to -[WKWebView underPageBackgroundColor] API
https://bugs.webkit.org/show_bug.cgi?id=225615
<rdar://problem/76568094>

Reviewed by Wenson Hsieh.

Source/WebCore:

underPageBackgroundColor is a null_resettable property that will return (in order of validity)

the most recent non-null value provided
the CSS background-color of the <body> and/or <html> (this is the current value of _pageExtendedBackgroundColor)
the underlying platform view's background color

Modifications to this property will not have any effect until control is returned to the runloop.

Tests: WKWebViewUnderPageBackgroundColor.OnLoad

WKWebViewUnderPageBackgroundColor.SingleSolidColor
WKWebViewUnderPageBackgroundColor.SingleBlendedColor
WKWebViewUnderPageBackgroundColor.MultipleSolidColors
WKWebViewUnderPageBackgroundColor.MultipleBlendedColors
WKWebViewUnderPageBackgroundColor.KVO
WKWebViewUnderPageBackgroundColor.MatchesScrollView

page/Page.h:

(WebCore::Page::underPageBackgroundColorOverride const): Added.

page/Page.cpp:

(WebCore::Page::setUnderPageBackgroundColorOverride): Added.
Hold the client-overriden value for underPageBackgroundColor so that it can be used when
drawing the overscroll layer.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForOverhangAreasBackgroundColor):
Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColor and
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

dom/Document.cpp:

(WebCore::Document::themeColorChanged):
It's no longer necessary to force the overscroll area to redraw since that'll be handled by
a client calling -[WKWebView setUnderPageBackgroundColor:] (possibly in response to a
-[WKWebView themeColor] KVO notification).

Source/WebKit:

underPageBackgroundColor is a null_resettable property that will return (in order of validity)

the most recent non-null value provided
the CSS background-color of the <body> and/or <html> (this is the current value of _pageExtendedBackgroundColor)
the underlying platform view's background color

Modifications to this property will not have any effect until control is returned to the runloop.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView underPageBackgroundColor]): Added.
(-[WKWebView setUnderPageBackgroundColor:]): Added.
(+[WKWebView automaticallyNotifiesObserversOfUnderPageBackgroundColor]): Added.

UIProcess/API/ios/WKWebViewIOS.mm:

(baseScrollViewBackgroundColor):
(scrollViewBackgroundColor):
Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColor and
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::underPageBackgroundColor const): Added.
(WebKit::WebPageProxy::setUnderPageBackgroundColorOverride): Added.
(WebKit::WebPageProxy::pageExtendedBackgroundColorDidChange):
(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Added.
(WebKit::WebPageProxy::scrollAreaBackgroundColor const): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Added.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Added.
Store the client-overriden value for underPageBackgroundColor and manage state changes.

UIProcess/PageClient.h:

(WebKit::PageClient::underPageBackgroundColorWillChange): Added.
(WebKit::PageClient::underPageBackgroundColorDidChange): Added.

UIProcess/Cocoa/PageClientImplCocoa.h:
UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::underPageBackgroundColorWillChange): Added.
(WebKit::PageClientImplCocoa::underPageBackgroundColorDidChange): Added.
Add ObjC KVO support for -[WKWebView underPageBackgroundColor].

UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::contentViewBackgroundColor): Added.
Provide a way to get the backgroundColor of the WKContentView. This is needed on iOS
because scrollViewBackgroundColor (now WebPageProxy::platformUnderPageBackgroundColor)
would use this value before falling back to the underlying platform view's background color.

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUnderPageBackgroundColorOverride): Added.
Pass the client-overriden value for underPageBackgroundColor to the WebProcess so that it
can be used when drawing the overscroll layer.

UIProcess/ViewSnapshotStore.cpp:

(WebKit::ViewSnapshotStore::recordSnapshot):
Go back to using the pageExtendedBackgroundColor (before r273083).

Source/WTF:

underPageBackgroundColor is a null_resettable property that will return (in order of validity)

the most recent non-null value provided
the CSS background-color of the <body> and/or <html> (this is the current value of _pageExtendedBackgroundColor)
the underlying platform view's background color

Modifications to this property will not have any effect until control is returned to the runloop.

Scripts/Preferences/WebPreferencesInternal.yaml:

Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColorand
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewUnderPageBackgroundColor.mm: Renamed from PageExtendedBackgroundColor.mm.

(defaultBackgroundColor): Added.
(TEST.WKWebViewUnderPageBackgroundColor.OnLoad):
(TEST.WKWebViewUnderPageBackgroundColor.SingleSolidColor): Added.
(TEST.WKWebViewUnderPageBackgroundColor.SingleBlendedColor): Added.
(TEST.WKWebViewUnderPageBackgroundColor.MultipleSolidColors): Added.
(TEST.WKWebViewUnderPageBackgroundColor.MultipleBlendedColors): Added.
(-[WKWebViewUnderPageBackgroundColorObserver initWithWebView:]): Added.
(-[WKWebViewUnderPageBackgroundColorObserver observeValueForKeyPath:ofObject:change:context:]): Added.
(TEST.WKWebViewUnderPageBackgroundColor.KVO):
(TEST.WKWebViewUnderPageBackgroundColor.MatchesScrollView): Added.
(TEST.WKWebViewUnderPageBackgroundColor.MultipleStyles): Deleted.
(-[WKWebViewPageExtendedBackgroundColorObserver initWithWebView:]): Deleted.
(-[WKWebViewPageExtendedBackgroundColorObserver observeValueForKeyPath:ofObject:change:context:]): Deleted.

TestWebKitAPI/Tests/WebKitCocoa/SampledPageTopColor.mm:

(createWebViewWithSampledPageTopColorMaxDifference):
(TEST.SampledPageTopColor.ExperimentalUseSampledPageTopColorForScrollAreaBackgroundColor): Deleted.

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewThemeColor.mm:

(createWebView): Deleted.
(TEST.WKWebView.ExperimentalUseThemeColorForScrollAreaBackgroundColor): Deleted.
Remove the experimental settings UseSampledPageTopColorForScrollAreaBackgroundColor and
UseThemeColorForScrollAreaBackgroundColor now that clients can override the default
overscroll area background color using -[WKWebView setUnderPageBackgroundColor:].

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

2:26 PM Changeset in webkit [277504] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix a build after r277493

editing/cocoa/AttributedString.h:

I removed an unneeded NSDictionary declaration that was being used here.

1:33 PM Changeset in webkit [277503] by Lauro Moura

2 edits in trunk/LayoutTests

[WPE] Bot exiting early with crashes in new window layout tests inside wl_proxy_marshal_constructor
https://bugs.webkit.org/show_bug.cgi?id=225555

Unreviewed test gardening.

Basically revert the changes from r277223 as the SDK was updated with
a new wpebackend-fdo in r277436.

platform/wpe/TestExpectations:

1:18 PM Changeset in webkit [277502] by Russell Epstein

8 edits in branches/safari-612.1.12-branch/Source

Versioning.

WebKit-7612.1.12.8

11:56 AM Changeset in webkit [277501] by Devin Rousso

7 edits in trunk

[iOS] contextmenu hints can be clipped by the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=224204
<rdar://problem/77089174>

Reviewed by Wenson Hsieh.

Source/WebKit:

r275562 tried to fix this by moving the interaction previews to a separate UIWindow, but
this had the unfortunate consequence of placing those previews on top of everything in the
current UIWindow (e.g. above the share sheet). As such, WebKit can't use a UIWindow for
this as the WKWebView has no idea what the view hierarchy above it looks like.

Test: ContextMenu.HintPreviewContainer

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

Add new SPI -[WKUIDelegate _contextMenuHintPreviewContainerViewForWebView:] that's used as
the container for the UIPreviewTarget created for the contextmenu hint preview.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):
(-[WKContentView cleanUpInteractionPreviewContainers]): Added.
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _createPreviewContainerWithLayerName:]):
(-[WKContentView containerForDropPreviews]):
(-[WKContentView _removeContainerForDropPreviews]): Added.
(-[WKContentView containerForDragPreviews]):
(-[WKContentView _removeContainerForDragPreviews]): Added.
(-[WKContentView containerForContextMenuHintPreviews]):
(-[WKContentView _removeContainerForContextMenuHintPreviews]): Added.
(-[WKContentView cleanUpDragSourceSessionState]):
(-[WKContentView _removeContextMenuViewIfPossible]):
(-[WKContentView dropInteraction:concludeDrop:]):
(-[WKContentView _hideTargetedPreviewContainerViews]): Deleted.
Clean up and centralize logic around creating and removing interaction preview containers.

UIProcess/ios/WKContentView.mm:

(-[WKContentView didMoveToWindow]):
If the WKWebView is removed from it's parent, make sure to remove the contextmenu hint
preview as well as it could be outside the view hierarchy of the WKWebView from the SPI.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:

(-[TestContextMenuHintPreviewContainerUIDelegate webView:contextMenuWillPresentForElement:]): Added.
(-[TestContextMenuHintPreviewContainerUIDelegate _contextMenuHintPreviewContainerViewForWebView:]): Added.
(TEST.ContextMenu.HintPreviewContainer): Added.

11:34 AM Changeset in webkit [277500] by mark.lam@apple.com

9 edits in trunk/Source/JavaScriptCore

Implement Baseline JIT property access slow paths using JIT thunks.
https://bugs.webkit.org/show_bug.cgi?id=225771

Reviewed by Yusuke Suzuki and Saam Barati.

This patch applies the following strategy to Baseline JIT property access slow paths:

If the slow path operation call is not patchable, emit a near call to a JIT thunk to do the entire operation call.

If the slow path operation call is patachable, emit a near call to a prepare call JIT thunk before the patchable operation call, and a near call to an exception check JIT thunk after.

This strategy reduces the amount of instructions emitted for all the slow paths.
Performance is expected to be neutral or slightly improved due to the reduced
compile times and better cache locality.

With this patch, --dumpLinkBufferStats shows the following changes in emitted
JIT code size (using a single run of the CLI version of JetStream2 on AS Mac)
comparing to current tip of tree:

Base New Diff

BaselineJIT: 84624776 (80.704475 MB) 77429400 (73.842430 MB) 0.91x (reduction)

DFG: 36415264 (34.728302 MB) 36160880 (34.485703 MB) 0.99x

Thunk: 23130336 (22.058807 MB) 23159024 (22.086166 MB) 1.00x

InlineCache: 21969728 (20.951965 MB) 22068348 (21.046017 MB) 1.00x

FTL: 6097336 (5.814873 MB) 6004736 (5.726562 MB) 0.98x

Wasm: 2301956 (2.195316 MB) 2429204 (2.316669 MB) 1.06x (probably noise)

YarrJIT: 1522488 (1.451958 MB) 1522488 (1.451958 MB) 1.00x

CSSJIT: 0

Uncategorized: 0

Comparing to tip of tree at the start of this effort to move put slow paths in
JIT thunks:

Base New Diff

BaselineJIT: 89089964 (84.962811 MB) 77429400 (73.842430 MB) 0.87x (reduction)

DFG: 39117360 (37.305222 MB) 36160880 (34.485703 MB) 0.92x (reduction)

Thunk: 23230968 (22.154778 MB) 23159024 (22.086166 MB) 1.00x

InlineCache: 22027416 (21.006981 MB) 22068348 (21.046017 MB) 1.00x

FTL: 6575772 (6.271145 MB) 6004736 (5.726562 MB) 0.91x (reduction)

Wasm: 2302724 (2.196049 MB) 2429204 (2.316669 MB) 1.05x (probably noise)

YarrJIT: 1538956 (1.467663 MB) 1522488 (1.451958 MB) 0.99x

CSSJIT: 0 0

Uncategorized: 0 0

This patch has passed the JSC tests on AS Mac, and also a subset of the JSC tests
(as a smoke test) on x86_64.

bytecode/CodeBlock.h:

(JSC::CodeBlock::offsetOfGlobalObject):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::callExceptionFuzz):
(JSC::AssemblyHelpers::emitExceptionCheck):
(JSC::AssemblyHelpers::emitNonPatchableExceptionCheck):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::slow_op_get_by_val_prepareCallGenerator):
(JSC::JIT::emitSlow_op_get_private_name):
(JSC::JIT::slow_op_get_private_name_prepareCallGenerator):
(JSC::JIT::emitSlow_op_set_private_brand):
(JSC::JIT::emitSlow_op_check_private_brand):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::slow_op_put_by_val_prepareCallGenerator):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::slow_op_put_private_name_prepareCallGenerator):
(JSC::JIT::emitSlow_op_del_by_id):
(JSC::JIT::slow_op_del_by_id_prepareCallGenerator):
(JSC::JIT::emitSlow_op_del_by_val):
(JSC::JIT::slow_op_del_by_val_prepareCallGenerator):
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_direct):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::slow_op_get_by_id_prepareCallGenerator):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::slow_op_get_by_id_with_this_prepareCallGenerator):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::slow_op_put_by_id_prepareCallGenerator):
(JSC::JIT::emitSlow_op_in_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::slow_op_get_from_scopeGenerator):
(JSC::JIT::emitSlow_op_put_to_scope):
(JSC::JIT::slow_op_put_to_scopeGenerator):

jit/JITThunks.cpp:

(JSC::JITThunks::preinitializeExtraCTIThunks):

jit/SlowPathCall.cpp:

(JSC::JITSlowPathCall::call):

jit/ThunkGenerators.cpp:

(JSC::checkExceptionGenerator):

jit/ThunkGenerators.h:

11:26 AM Changeset in webkit [277499] by Chris Dumez

7 edits in trunk

Introduce FileSystem::updateFileModificationTime()
https://bugs.webkit.org/show_bug.cgi?id=225810

Reviewed by Darin Adler.

Source/WebKit:

Call the new FileSystem::updateFileModificationTime() API to modify the
file modification time instead of having low-level platform-specific
file system code at the WebKit2 layer.

NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::updateFileModificationTimeIfNeeded):

Source/WTF:

Introduce FileSystem::updateFileModificationTime() to update the modification time of a
file. The implementation is cross-platform and relies on std::filesystem. It allows us
to replace platform-specific code that we had at the WebKit2 layer.

wtf/FileSystem.cpp:

(WTF::FileSystemImpl::updateFileModificationTime):

wtf/FileSystem.h:

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

10:54 AM Changeset in webkit [277498] by Chris Dumez

7 edits in trunk/Source

Drop unused FileSystem::homeDirectoryPath()
https://bugs.webkit.org/show_bug.cgi?id=225808

Reviewed by Anders Carlsson.

Source/WebKitLegacy/win:

Fix Window-specific code that was calling FileSystem::homeDirectoryPath(),
which would always return the empty string on Windows. Call
FileSystem::roamingUserSpecificStorageDirectory() since it returns the
%AppData% folder and this is what the code actually wants.

Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

Source/WTF:

Only Windows-specific code was calling FileSystem::homeDirectoryPath() but the Windows implementation
for this was always returning the empty string.

wtf/FileSystem.h:
wtf/cocoa/FileSystemCocoa.mm:

(WTF::FileSystemImpl::homeDirectoryPath): Deleted.

wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::homeDirectoryPath): Deleted.

wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::homeDirectoryPath): Deleted.

10:28 AM Changeset in webkit [277497] by commit-queue@webkit.org

15 edits in trunk

Wrong static position for out-of-flow positioned element with different writing-mode than its containing block
https://bugs.webkit.org/show_bug.cgi?id=189513

Patch by Ziran Sun <Ziran Sun> on 2021-05-14
Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Updated the following WPT tests that are now passing.

web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010-expected.txt:

Source/WebCore:

The static distance computations (computeBlockStaticDistance & computeInlineStaticDistance) in RenderBox have
not been patched for mixed writing modes. This CL adds support for the case that child is orthogonal to its
container block when container block's text direction is LTR. It aims at fixing failures in
orthogonal-positioned-grid-descendants*.html tests. It is noted that this CL only covers specific case when child's
writing mode is vlr and parent is horizontal tb rather than all cases of mixed writing modes in the static distance
computations.

rendering/RenderBox.cpp:

(WebCore::computeInlineStaticDistance):
(WebCore::computeBlockStaticDistance):

LayoutTests:

TestExpectations: updating 22 css-writing-modes tests that are passing.

10:15 AM Changeset in webkit [277496] by Jonathan Bedard

2 edits in trunk/Tools

[run-api-tests] Use Python 3 (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=225427
<rdar://problem/77584713>

Reviewed by Aakash Jain.

Scripts/run-api-tests: Change she-bang to Python 3.

10:15 AM Changeset in webkit [277495] by Alan Coon

1 copy in tags/Safari-612.1.14.3

Tag Safari-612.1.14.3.

10:00 AM Changeset in webkit [277494] by Alan Coon

8 edits in branches/safari-612.1.14-branch/Source

Versioning.

WebKit-7612.1.14.3

9:56 AM Changeset in webkit [277493] by achristensen@apple.com

14 edits in trunk

Resource Timing: secureConnectionStart == 0 when a connection is re-used
https://bugs.webkit.org/show_bug.cgi?id=225733

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/resource-timing/resource_connection_reuse_mixed_content-expected.txt:

Source/WebCore:

Covered by a newly-passing web platform test, which was already passed by Chrome and Firefox.

page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::secureConnectionStart const):

platform/network/NetworkLoadMetrics.h:

I use a sentinel value to distinguish no secure connection from a reused secure connection.

platform/network/ResourceHandle.h:
platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):
(WebCore::copyTimingData):
Introduce a way to get timing data from CFNetwork using a more modern API.
(WebCore::timingValue): Deleted.

platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask _timingData]):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::getConnectionTimingData): Deleted.

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

Source/WebKit:

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

LayoutTests:

TestExpectations:

9:10 AM Changeset in webkit [277492] by Chris Dumez

39 edits in trunk

Rename FileSystem::getFileSize() to FileSystem::fileSize()
https://bugs.webkit.org/show_bug.cgi?id=225798

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Update code path to due to the API change.

inspector/remote/socket/RemoteInspectorSocket.cpp:

(Inspector::RemoteInspector::backendCommands const):

jsc.cpp:

Source/WebCore:

Update code path to due to the API change.

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::databasesSizeForDirectory):

Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::maximumSize):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::usage):
(WebCore::DatabaseTracker::quotaNoLock):
(WebCore::DatabaseTracker::quota):
(WebCore::DatabaseTracker::setQuota):
(WebCore::isZeroByteFile):

Modules/webdatabase/DatabaseTracker.h:
editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::spaceNeeded):
(WebCore::ApplicationCacheStorage::loadCache):
(WebCore::ApplicationCacheStorage::flatFileAreaSize):

platform/FileStream.cpp:

(WebCore::FileStream::getSize):

platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):

platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::loadFileToBuffer):

platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::loadIndex):

platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::databaseFileSize):

platform/sql/SQLiteFileSystem.h:
rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::stringWithContentsOfFile):

workers/service/server/SWScriptStorage.cpp:

(WebCore::shouldUseFileMapping):
(WebCore::SWScriptStorage::retrieve):

Source/WebKit:

Update code path to due to the API change.

NetworkProcess/WebStorage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::setItem):

NetworkProcess/WebStorage/LocalStorageDatabase.h:
NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::getDirectorySize):
(WebKit::CacheStorage::Engine::readSizeFile):

NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::synchronize):

NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::mapFile):

NetworkProcess/cache/NetworkCacheIOChannelCurl.cpp:

(WebKit::NetworkCache::IOChannel::read):

Shared/PersistencyUtils.cpp:

(WebKit::createForFile):

UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::loadStorageFromDisk):

Source/WebKitLegacy:

Update code path to due to the API change.

Storage/StorageTracker.cpp:

(WebKit::StorageTracker::diskUsageForOrigin):

Storage/StorageTracker.h:

Source/WTF:

Rename FileSystem::getFileSize() to FileSystem::fileSize() as we usually avoid the "get"
prefix in WebKit. It is also more consistent with the std::filesystem::file_size() the
implementation relies on.

Also have it return an Optional<uint64_t> instead of taking a long long out-parameter, as
this is more modern.

wtf/FileSystem.cpp:

(WTF::FileSystemImpl::fileSize):

wtf/FileSystem.h:
wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::fileSize):

wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::fileSize):

wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::getFileSizeFromByHandleFileInformationStructure):
(WTF::FileSystemImpl::fileSize):
(WTF::FileSystemImpl::MappedFileData::mapFileHandle):

Tools:

Update code path to due to the API change.

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:

(TestWebKitAPI::TEST):

9:01 AM Changeset in webkit [277491] by Chris Dumez

22 edits in trunk

Rename FileSystem::pathGetFileName() to FileSystem::pathFileName()
https://bugs.webkit.org/show_bug.cgi?id=225806

Reviewed by Alex Christensen.

Rename FileSystem::pathGetFileName() to FileSystem::pathFileName(), as we avoid "get" prefixes in WebKit.

Source/WebCore:

Modules/entriesapi/FileSystemEntry.cpp:

(WebCore::FileSystemEntry::FileSystemEntry):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

fileapi/File.cpp:

(WebCore::File::computeNameAndContentType):

fileapi/FileCocoa.mm:

(WebCore::File::computeNameAndContentTypeForReplacedFile):

html/DirectoryFileListCreator.cpp:

(WebCore::gatherFileInformation):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::store):

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::purgeOldDownloadFiles):

Source/WebKit:

NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::origins const):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):

Source/WebKitLegacy/win:

Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::fileExistsAndIsNotDisabled const):

Plugins/PluginPackage.cpp:

(WebCore::PluginPackage::PluginPackage):

WebDownloadCurl.cpp:

(WebDownload::didReceiveResponse):

Source/WTF:

wtf/FileSystem.cpp:

(WTF::FileSystemImpl::pathFileName):
(WTF::FileSystemImpl::pathGetFileName): Deleted.

wtf/FileSystem.h:

Tools:

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

8:54 AM Changeset in webkit [277490] by Jonathan Bedard

57 edits in trunk/Tools

[webkitpy] Remove unused imports
https://bugs.webkit.org/show_bug.cgi?id=225776
<rdar://problem/77982408>

Reviewed by Dewei Zhu.

Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py:
Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
Scripts/webkitpy/common/net/layouttestresults_unittest.py:
Scripts/webkitpy/common/net/networktransaction_unittest.py:
Scripts/webkitpy/common/system/zipfileset_unittest.py:
Scripts/webkitpy/common/test_expectations_unittest.py:
Scripts/webkitpy/inspector/main.py:
Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
Scripts/webkitpy/layout_tests/controllers/manager.py:
Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/models/test_expectations.py:
Scripts/webkitpy/layout_tests/models/test_run_results.py:
Scripts/webkitpy/layout_tests/servers/websocket_server.py:
Scripts/webkitpy/layout_tests/views/printing.py:
Scripts/webkitpy/minibrowser/run_webkit_app.py:
Scripts/webkitpy/performance_tests/perftest.py:
Scripts/webkitpy/port/base.py:
Scripts/webkitpy/port/builders.py:
Scripts/webkitpy/port/config_unittest.py:
Scripts/webkitpy/results/upload_unittest.py:
Scripts/webkitpy/style/checkers/test_expectations.py:
Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
Scripts/webkitpy/style/checkers/text_unittest.py:
Scripts/webkitpy/style/filereader_unittest.py:
Scripts/webkitpy/style/optparser.py:
Scripts/webkitpy/test/printer.py:
Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
Scripts/webkitpy/tool/bot/retrylogic_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/commands/rebaselineserver.py:
Scripts/webkitpy/tool/commands/setupgitclone.py:
Scripts/webkitpy/tool/commands/suggestnominations.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/multicommandtool_unittest.py:
Scripts/webkitpy/tool/servers/gardeningserver.py:
Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
Scripts/webkitpy/tool/servers/reflectionhandler.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
Scripts/webkitpy/tool/steps/wptchangeexport.py:
Scripts/webkitpy/w3c/wpt_runner.py:
Scripts/webkitpy/webdriver_tests/pytest_runner.py:
Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
Scripts/webkitpy/webdriver_tests/webdriver_test_result.py:
Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

8:51 AM Changeset in webkit [277489] by Jonathan Bedard

4 edits in trunk/Tools

test-lldb-webkit failing with import of lldb
https://bugs.webkit.org/show_bug.cgi?id=225792
<rdar://problem/77993980>

Reviewed by Dewei Zhu.

CISupport/build-webkit-org/steps.py:

(RunLLDBWebKitTests): Invoke test-lldb-webkit with Python 3.

CISupport/build-webkit-org/steps_unittest.py:
Scripts/test-lldb-webkit: Change shebang to Python 3.

7:36 AM Changeset in webkit [277488] by Amir Mark Jr.

2 edits in trunk/LayoutTests

[MacOS] imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=225804

Unreviewed test gardening.