Context Navigation

← Previous Period
Next Period →

Timeline

Jun 17, 2021:

10:35 PM Changeset in webkit [279031] by Diego Pino Garcia

55 edits
10 copies
9 moves
27 adds in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening. Update baselines after r278974.

There are GTK and WPE tests that have the same text baseline but the
corresponding PNG image is different. In this case, I have preferred
to keep a specific text baseline for each port, instead of
promoting the text baseline to GLIB.

platform/gtk/svg/text/foreignObject-repaint-expected.txt: Copied from LayoutTests/platform/glib/svg/text/foreignObject-repaint-expected.txt.
platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.png:
platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
platform/gtk/svg/text/text-align-01-b-expected.png:
platform/gtk/svg/text/text-align-01-b-expected.txt:
platform/gtk/svg/text/text-align-02-b-expected.png:
platform/gtk/svg/text/text-align-02-b-expected.txt:
platform/gtk/svg/text/text-align-03-b-expected.png:
platform/gtk/svg/text/text-align-03-b-expected.txt:
platform/gtk/svg/text/text-align-04-b-expected.png:
platform/gtk/svg/text/text-align-04-b-expected.txt:
platform/gtk/svg/text/text-align-05-b-expected.png:
platform/gtk/svg/text/text-align-05-b-expected.txt:
platform/gtk/svg/text/text-align-06-b-expected.png:
platform/gtk/svg/text/text-align-06-b-expected.txt:
platform/gtk/svg/text/text-deco-01-b-expected.png:
platform/gtk/svg/text/text-deco-01-b-expected.txt:
platform/gtk/svg/text/text-fonts-01-t-expected.png:
platform/gtk/svg/text/text-fonts-01-t-expected.txt:
platform/gtk/svg/text/text-fonts-02-t-expected.png:
platform/gtk/svg/text/text-fonts-02-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-fonts-02-t-expected.txt.
platform/gtk/svg/text/text-intro-05-t-expected.png:
platform/gtk/svg/text/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-intro-05-t-expected.txt.
platform/gtk/svg/text/text-path-01-b-expected.png:
platform/gtk/svg/text/text-path-01-b-expected.txt:
platform/gtk/svg/text/text-spacing-01-b-expected.png:
platform/gtk/svg/text/text-spacing-01-b-expected.txt:
platform/gtk/svg/text/text-text-01-b-expected.png:
platform/gtk/svg/text/text-text-01-b-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-text-01-b-expected.txt.
platform/gtk/svg/text/text-text-03-b-expected.png:
platform/gtk/svg/text/text-text-03-b-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-text-03-b-expected.txt.
platform/gtk/svg/text/text-text-05-t-expected.png:
platform/gtk/svg/text/text-text-05-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-text-05-t-expected.txt.
platform/gtk/svg/text/text-text-07-t-expected.png:
platform/gtk/svg/text/text-text-07-t-expected.txt:
platform/gtk/svg/text/text-text-08-b-expected.png:
platform/gtk/svg/text/text-text-08-b-expected.txt:
platform/gtk/svg/text/text-tref-01-b-expected.png:
platform/gtk/svg/text/text-tref-01-b-expected.txt:
platform/gtk/svg/text/text-tselect-01-b-expected.png:
platform/gtk/svg/text/text-tselect-01-b-expected.txt:
platform/gtk/svg/text/text-tspan-01-b-expected.png:
platform/gtk/svg/text/text-tspan-01-b-expected.txt:
platform/gtk/svg/text/text-ws-01-t-expected.png:
platform/gtk/svg/text/text-ws-01-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-ws-01-t-expected.txt.
platform/gtk/svg/text/text-ws-02-t-expected.png:
platform/gtk/svg/text/text-ws-02-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-ws-02-t-expected.txt.
platform/gtk/svg/text/textPathBoundsBug-expected.txt: Copied from LayoutTests/platform/glib/svg/text/textPathBoundsBug-expected.txt.
platform/wpe/svg/text/foreignObject-repaint-expected.png: Added.
platform/wpe/svg/text/foreignObject-repaint-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/foreignObject-repaint-expected.txt.
platform/wpe/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
platform/wpe/svg/text/foreignObject-text-clipping-bug-expected.txt:
platform/wpe/svg/text/text-align-01-b-expected.png: Added.
platform/wpe/svg/text/text-align-01-b-expected.txt:
platform/wpe/svg/text/text-align-02-b-expected.png: Added.
platform/wpe/svg/text/text-align-02-b-expected.txt:
platform/wpe/svg/text/text-align-03-b-expected.png: Added.
platform/wpe/svg/text/text-align-03-b-expected.txt:
platform/wpe/svg/text/text-align-04-b-expected.png: Added.
platform/wpe/svg/text/text-align-04-b-expected.txt:
platform/wpe/svg/text/text-align-05-b-expected.png: Added.
platform/wpe/svg/text/text-align-05-b-expected.txt:
platform/wpe/svg/text/text-align-06-b-expected.png: Added.
platform/wpe/svg/text/text-align-06-b-expected.txt:
platform/wpe/svg/text/text-deco-01-b-expected.png: Added.
platform/wpe/svg/text/text-deco-01-b-expected.txt:
platform/wpe/svg/text/text-fonts-01-t-expected.png: Added.
platform/wpe/svg/text/text-fonts-01-t-expected.txt:
platform/wpe/svg/text/text-fonts-02-t-expected.png: Added.
platform/wpe/svg/text/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-fonts-02-t-expected.txt.
platform/wpe/svg/text/text-intro-05-t-expected.png: Added.
platform/wpe/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-intro-05-t-expected.txt.
platform/wpe/svg/text/text-path-01-b-expected.png: Added.
platform/wpe/svg/text/text-path-01-b-expected.txt:
platform/wpe/svg/text/text-spacing-01-b-expected.png: Added.
platform/wpe/svg/text/text-spacing-01-b-expected.txt:
platform/wpe/svg/text/text-text-01-b-expected.png: Added.
platform/wpe/svg/text/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-text-01-b-expected.txt.
platform/wpe/svg/text/text-text-03-b-expected.png: Added.
platform/wpe/svg/text/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-text-03-b-expected.txt.
platform/wpe/svg/text/text-text-05-t-expected.png: Added.
platform/wpe/svg/text/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-text-05-t-expected.txt.
platform/wpe/svg/text/text-text-07-t-expected.png: Added.
platform/wpe/svg/text/text-text-07-t-expected.txt:
platform/wpe/svg/text/text-text-08-b-expected.png: Added.
platform/wpe/svg/text/text-text-08-b-expected.txt:
platform/wpe/svg/text/text-tref-01-b-expected.png: Added.
platform/wpe/svg/text/text-tref-01-b-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/text-tref-01-b-expected.txt.
platform/wpe/svg/text/text-tselect-01-b-expected.png: Added.
platform/wpe/svg/text/text-tselect-01-b-expected.txt:
platform/wpe/svg/text/text-tspan-01-b-expected.png: Added.
platform/wpe/svg/text/text-tspan-01-b-expected.txt:
platform/wpe/svg/text/text-ws-01-t-expected.png: Added.
platform/wpe/svg/text/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-ws-01-t-expected.txt.
platform/wpe/svg/text/text-ws-02-t-expected.png: Added.
platform/wpe/svg/text/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-ws-02-t-expected.txt.
platform/wpe/svg/text/textPathBoundsBug-expected.png: Added.
platform/wpe/svg/text/textPathBoundsBug-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/textPathBoundsBug-expected.txt.
platform/wpe/tables/mozilla/bugs/bug106795-expected.png: Added.
platform/wpe/tables/mozilla/bugs/bug82946-2-expected.png: Added.

9:09 PM Changeset in webkit [279030] by Said Abou-Hallawa

20 edits
4 adds in trunk

[Cocoa] Disable hardware decoding in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=226869
<rdar://77548905>

Reviewed by Per Arne Vollan and Simon Fraser.

Source/WebCore:

Pass kCGImageSourceEnableRestrictedDecoding : kCFBooleanTrue when decoding
an image frame.

Test: fast/images/heic-as-background-image.html

platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions):

Source/WebCore/PAL:

SoftLink

VTRestrictVideoDecoders from VideoToolbox
FigPhotoSupportsHEVCHWDecode from MediaToobox

PAL.xcodeproj/project.pbxproj:
pal/cf/VideoToolboxSoftLink.cpp:
pal/cf/VideoToolboxSoftLink.h:
pal/cocoa/MediaToolboxSoftLink.cpp:
pal/cocoa/MediaToolboxSoftLink.h:
pal/spi/cg/ImageIOSPI.h:
pal/spi/cocoa/VideoToolboxSPI.h: Added.

Source/WebKit:

Restrict video decoders and disable hardware image decoders.

A temp extension is created for the service "com.apple.trustd.agent" to
allow temporarily calling FigPhotoSupportsHEVCHWDecode(). This function
needs access this service but we have recently closed access to it.

FigPhotoSupportsHEVCHWDecode() sets a local static variable by using the
service "com.apple.trustd.agent" when it is called for the first time.
Our purpose of calling it in this context is to initialize the static
variable only. And this is why we do not use its return value.

This solution is fragile. If MediaToolbox is changed such that it needs
'com.apple.trustd.agent' while decoding an image, the decoding will fail.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::restrictImageAndVideoDecoders):
(WebKit::WebProcess::initializeSandbox):

Source/WTF:

Add have macros for using:

kCGImageSourceEnableRestrictedDecoding
VTRestrictVideoDecoders()

wtf/PlatformHave.h:

LayoutTests:

Add a reference test for rendering the HEIF images.

TestExpectations:
fast/images/heic-as-background-image-expected.html: Added.
fast/images/heic-as-background-image.html: Added.
fast/images/resources/green-400x400.heic: Added.
platform/ios/TestExpectations:
platform/mac/TestExpectations:

7:06 PM Changeset in webkit [279029] by mark.lam@apple.com

7 edits in trunk/Source

Rename numberOfPACBits to maxNumberOfAllowedPACBits.
https://bugs.webkit.org/show_bug.cgi?id=227156

Reviewed by Saam Barati.

Source/JavaScriptCore:

Just renaming the constant to better describe what it represents. There are no
behavior changes.

assembler/MacroAssemblerARM64E.h:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::cageWithoutUntagging):
(JSC::AssemblyHelpers::cageConditionallyAndUntag):

llint/LowLevelInterpreter64.asm:

Source/WTF:

wtf/CagedPtr.h:

6:44 PM Changeset in webkit [279028] by mark.lam@apple.com

20 edits in trunk

Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).
https://bugs.webkit.org/show_bug.cgi?id=227147
rdar://78785309

Reviewed by Saam Barati.

Source/bmalloc:

For OS(DARWIN), define BOS_EFFECTIVE_ADDRESS_WIDTH in terms of MACH_VM_MAX_ADDRESS,
which is provided by the SDK. This ensures that it is correct for each target
OS(DARWIN) platform.

bmalloc/Algorithm.h:

(bmalloc::clzConstexpr):
(bmalloc::getMSBSetConstexpr):

bmalloc/BPlatform.h:
bmalloc/Gigacage.h:
bmalloc/ObjectTypeTable.h:
bmalloc/Packed.h:

Source/JavaScriptCore:

assembler/MacroAssemblerARM64E.h:
bytecode/CodeOrigin.h:
runtime/JSString.h:
runtime/OptionsList.h:

Source/WTF:

For OS(DARWIN), define OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) in terms of
MACH_VM_MAX_ADDRESS, which is provided by the SDK. This ensures that it is
correct for each target OS(DARWIN) platform.

Also update an assertion in WTFAssertions.cpp to verify that address bits are
less than 48. The purpose of this assertion is to ensure that our 64-bit NaN
boxing encoding for JSValues will work. Hence, we should use the encoding limit
for pointers of 48 bits. It no longer makes sense to assert based on
OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH), because OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH)
is defined in terms of MACH_VM_MAX_ADDRESS.

wtf/CagedPtr.h:
wtf/CompactPointerTuple.h:
wtf/PlatformOS.h:
wtf/WTFAssertions.cpp:
wtf/threads/Signals.cpp:

Tools:

TestWebKitAPI/Tests/WTF/Packed.cpp:

6:27 PM Changeset in webkit [279027] by Fujii Hironori

4 edits in trunk

[Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing
https://bugs.webkit.org/show_bug.cgi?id=227090

Reviewed by Yusuke Suzuki.

Source/WTF:

ArithmeticOperations::sub unexpectedly reported an overflow for
the result of std::numeric_limits<ResultType>::min() in MSVC code path.
For example, Checked<int, RecordOverflow>(INT_MIN + 1) - 1 was reported an overflow.

In the case of calculating (lhs - rhs), and lhs < 0 and rhs > 0,
the original code reported an overflow if (rhs > max() + lhs).
Mathematically, this condition checks (lhs - rhs < -max()).
It should use min() instead of max() in this case. It should be
(lhs - rhs < min()) mathematically.

wtf/CheckedArithmetic.h:

Tools:

TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::AllowMixedSignednessTest::run):

5:26 PM Changeset in webkit [279026] by Chris Dumez

7 edits in trunk

Add support for IDBCursor.request
https://bugs.webkit.org/show_bug.cgi?id=227152

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline some WPT tests now that they are passing.

web-platform-tests/IndexedDB/idbcursor-request.any-expected.txt:
web-platform-tests/IndexedDB/idbcursor-request.any.worker-expected.txt:
web-platform-tests/IndexedDB/idlharness.any-expected.txt:
web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:

Source/WebCore:

Add support for IDBCursor.request:

https://w3c.github.io/IndexedDB/#dom-idbcursor-request

Both Blink and Gecko already support this.

No new tests, rebaselined existing tests.

Modules/indexeddb/IDBCursor.idl:

5:00 PM Changeset in webkit [279025] by achristensen@apple.com

2 edits in trunk/Source/WTF

Add assertion in RunLoop::dispatch
https://bugs.webkit.org/show_bug.cgi?id=227154
<rdar://79243769>

Reviewed by Geoff Garen.

This should help us find what is scheduling null functions.

wtf/RunLoop.cpp:

(WTF::RunLoop::dispatch):
(WTF::RunLoop::dispatchAfter):

4:39 PM Changeset in webkit [279024] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Skip WebXR tests on iOS
https://bugs.webkit.org/show_bug.cgi?id=227151

Patch by Ada Chan <ada.chan@apple.com> on 2021-06-17
Reviewed by Tim Horton.

platform/ios/TestExpectations:

4:21 PM Changeset in webkit [279023] by commit-queue@webkit.org

3 edits in trunk/Source/ThirdParty/libwebrtc

Unreviewed, reverting r279011.
https://bugs.webkit.org/show_bug.cgi?id=227153

broke ios build

Reverted changeset:

"[Mac] libwebrtc CMBaseClass objects need alignment fixup"
https://bugs.webkit.org/show_bug.cgi?id=227137
https://trac.webkit.org/changeset/279011

4:02 PM Changeset in webkit [279022] by Russell Epstein

5 edits in branches/safari-611-branch/Source/WebKit

Apply patch. rdar://problem/79474174

3:59 PM Changeset in webkit [279021] by Russell Epstein

3 edits in branches/safari-611-branch/Source/ThirdParty/libwebrtc

Cherry-pick r279011. rdar://problem/79474211

[Mac] libwebrtc CMBaseClass objects need alignment fixup
https://bugs.webkit.org/show_bug.cgi?id=227137

Reviewed by Youenn Fablet.

Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp: (webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on x86_64 so function pointers are naturally aligned. Add static_asserts to ensure alignment and sizes are correct.
Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp: (webrtc::createWebKitVP9Decoder): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:59 PM Changeset in webkit [279020] by Russell Epstein

2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r278975. rdar://problem/79474077

Make FontFaceSet::Iterator's bounds check more robust
https://bugs.webkit.org/show_bug.cgi?id=227048
<rdar://problem/78871890>

Reviewed by Simon Fraser.

We were checking for one specific bad value, when we should have been checking for all bad values.

css/FontFaceSet.cpp: (WebCore::FontFaceSet::Iterator::next):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:59 PM Changeset in webkit [279019] by Russell Epstein

4 edits in branches/safari-611-branch/Source

Cherry-pick r278870. rdar://problem/79473993

[Mac] CoreMedia WrapperClass does not need alignment fixup
https://bugs.webkit.org/show_bug.cgi?id=226978
rdar://78864290

Reviewed by Geoffrey Garen and Dan Bernstein.

Source/WebCore:

platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::enqueueSample): static_assert CMBufferQueueRef callback struct alignment and version size.

Source/WebKit:

Shared/mac/MediaFormatReader/CoreMediaWrapped.h: (WebKit::CoreMediaWrapped<Wrapped>::vTable): Don't add padding to WrapperClass, it isn't necessary. static_assert CMBaseClass and WrapperClass alignment and .version sizes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:46 PM Changeset in webkit [279018] by Russell Epstein

8 edits in branches/safari-611-branch/Source

Versioning.

WebKit-7611.3.9

3:40 PM Changeset in webkit [279017] by Chris Dumez

10 edits in trunk/Source

Enable some more release logging in for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=227142

Reviewed by Eric Carlson.

Enable some more release logging in for ephemeral sessions, to faciliate debugging.

Source/WebCore:

workers/service/server/SWServer.cpp:

(WebCore::SWServer::SWServer):

Source/WebKit:

GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::isAlwaysOnLoggingAllowed const): Deleted.

GPUProcess/GPUConnectionToWebProcess.h:

(WebKit::GPUConnectionToWebProcess::sessionID const):

GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::logger):

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::insertObservedDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::relationshipExists const):
(WebKit::ResourceLoadStatisticsDatabaseStore::domainID const):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList):
(WebKit::ResourceLoadStatisticsDatabaseStore::populateFromMemoryStore):
(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistic):
(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistics):
(WebKit::ResourceLoadStatisticsDatabaseStore::incrementRecordsDeletedCountForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::recursivelyFindNonPrevalentDomainsThatRedirectedToThisDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAsPrevalentIfHasRedirectedToPrevalent):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsDatabaseStore::grandfatherDataForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::ensurePrevalentResourcesForDebugMode):
(WebKit::ResourceLoadStatisticsDatabaseStore::logFrameNavigation):
(WebKit::ResourceLoadStatisticsDatabaseStore::logCrossSiteLoadWithLinkDecoration):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearTopFrameUniqueRedirectsToSinceSameSiteStrictEnforcement):
(WebKit::ResourceLoadStatisticsDatabaseStore::setUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::logUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasHadUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::setPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::setDomainsAsPrevalent):
(WebKit::ResourceLoadStatisticsDatabaseStore::predicateValueForDomain const):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::setGrandfathered):
(WebKit::ResourceLoadStatisticsDatabaseStore::setIsScheduledForAllButCookieDataRemoval):
(WebKit::ResourceLoadStatisticsDatabaseStore::getMostRecentlyUpdatedTimestamp const):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubframeUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsDatabaseStore::ensureResourceStatisticsForRegistrableDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::removeDataForDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasUserGrantedStorageAccessThroughPrompt):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearGrandfathering):
(WebKit::ResourceLoadStatisticsDatabaseStore::pruneStatisticsIfNeeded):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateLastSeen):
(WebKit::ResourceLoadStatisticsDatabaseStore::setLastSeen):
(WebKit::ResourceLoadStatisticsDatabaseStore::setVeryPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateDataRecordsRemoved):
(WebKit::ResourceLoadStatisticsDatabaseStore::isCorrectSubStatisticsCount):
(WebKit::ResourceLoadStatisticsDatabaseStore::getDomainStringFromDomainID const):
(WebKit::ResourceLoadStatisticsDatabaseStore::appendSubStatisticList const):
(WebKit::ResourceLoadStatisticsDatabaseStore::resourceToString const):
(WebKit::ResourceLoadStatisticsDatabaseStore::domainIDExistsInDatabase):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateOperatingDatesParameters):
(WebKit::ResourceLoadStatisticsDatabaseStore::includeTodayAsOperatingDateIfNecessary):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertExpiredStatisticForTesting):
(WebKit::ResourceLoadStatisticsDatabaseStore::findPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAllUnattributedPrivateClickMeasurementAsExpiredForTesting):
(WebKit::ResourceLoadStatisticsDatabaseStore::removeUnattributed):
(WebKit::ResourceLoadStatisticsDatabaseStore::allAttributedPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearExpiredPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::privateClickMeasurementToString):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearSentAttribution):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAttributedPrivateClickMeasurementsAsExpiredForTesting):

UIProcess/API/Cocoa/WKWebView.mm:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getNetworkProcessConnection):

WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:

(WebKit::WebURLSchemeTaskProxy::startLoading):
(WebKit::WebURLSchemeTaskProxy::stopLoading):
(WebKit::WebURLSchemeTaskProxy::didPerformRedirection):
(WebKit::WebURLSchemeTaskProxy::didReceiveResponse):
(WebKit::WebURLSchemeTaskProxy::didReceiveData):
(WebKit::WebURLSchemeTaskProxy::didComplete):

3:35 PM Changeset in webkit [279016] by Kyle Piddington

3 edits
2 adds in trunk

[Metal ANGLE] Shaders with reserved metal keywords do not translate, nor do shaders with struct and variable names that are the same except prefixed by an underscore
https://bugs.webkit.org/show_bug.cgi?id=226660

Source/ThirdParty/ANGLE:

Fix keyword translation problem by correcting symbol space. This avoids renaming structs unnecessarily

Reviewed by Dean Jackson.

src/compiler/translator/TranslatorMetalDirect/RewriteKeywords.cpp:

(sh::Rewriter::createRenamed):

LayoutTests:

Reviewed by Dean Jackson.

fast/canvas/webgl/shader-with-reserved-keyword-expected.txt: Added.
fast/canvas/webgl/shader-with-reserved-keyword.html: Added.

3:20 PM Changeset in webkit [279015] by Chris Dumez

30 edits
2 copies
3 moves
26 adds
1 delete in trunk/LayoutTests

Resync DOM WPT tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=227144

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Resync DOM WPT tests from upstream ec5c1fc86b65142e7b.

resources/resource-files.json:
web-platform-tests/dom/*: Updated.
web-platform-tests/interfaces/dom.idl:

LayoutTests:

TestExpectations:
tests-options.json:

3:14 PM Changeset in webkit [279014] by Brent Fulgham

2 edits in trunk/Source/WebKit

Clear state after process crash so that we know to re-issue sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=227103
<rdar://problem/77588760>

Reviewed by Per Arne Vollan.

We dynamically extend access to certain mach services when the ATTACHMENT_ELEMENT feature
is enabled. If a process with this feature activated crashes and WebKit relaunches it, we
don't grant the new process the same extensions because we believe they were already
previously sent.

This patch clears the state after a process crash so that it properly handles the restart case.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::shutDown): Clear state.
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch): Clear state.

3:12 PM Changeset in webkit [279013] by sbarati@apple.com

2 edits in trunk/JSTests

Make microbenchmarks/delete-property-from-prototype-chain not time out on debug builds
https://bugs.webkit.org/show_bug.cgi?id=227148

Reviewed by Mark Lam.

microbenchmarks/delete-property-from-prototype-chain.js:

3:03 PM Changeset in webkit [279012] by Jonathan Bedard

5 edits
2 moves
1 add in trunk/Tools

[resultsdbpy] Adopt autoinstaller
https://bugs.webkit.org/show_bug.cgi?id=227096
<rdar://problem/79418080>

Rubber-stamped by Aakash Jain.

Scripts/libraries/resultsdbpy/container: Moved from insdie library.
Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Register required libraries.
Scripts/libraries/resultsdbpy/resultsdbpy/container: Moved to containing folder.
Scripts/libraries/resultsdbpy/resultsdbpy/example/main.py:
Scripts/libraries/resultsdbpy/resultsdbpy/run: Moved to containing folder.
Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Use specific imports
Scripts/libraries/resultsdbpy/run: Moved from insdie library.
Scripts/libraries/resultsdbpy/run-tests: Use autoinstalled libraries.
Scripts/libraries/resultsdbpy/setup.py: Bump version.

3:01 PM Changeset in webkit [279011] by eric.carlson@apple.com

3 edits in trunk/Source/ThirdParty/libwebrtc

[Mac] libwebrtc CMBaseClass objects need alignment fixup
https://bugs.webkit.org/show_bug.cgi?id=227137

Reviewed by Youenn Fablet.

Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:

(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on x86_64
so function pointers are naturally aligned. Add static_asserts to ensure alignment
and sizes are correct.

Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

(webrtc::createWebKitVP9Decoder): Ditto.

2:55 PM Changeset in webkit [279010] by rniwa@webkit.org

5 edits
2 adds in trunk

Crash in WebCore::SlotAssignment::assignedNodesForSlot
https://bugs.webkit.org/show_bug.cgi?id=224408
<rdar://problem/76805764>

Reviewed by Michael Catanzaro.

Source/WebCore:

Like webkit.org/b/225684, the release assertion failure was caused by RenderTreeUpdater::tearDownRenderers
traversing the slot element for which we're currently calling Element::insertedIntoAncestor but had not yet
called SlotAssignment::addSlotElementByName.

Fixed the bug by returning early in SlotAssignment::assignedNodesForSlot when this condition holds,
which is when the shadow root is connected to a document and HTMLSlotElement is in the middle of
HTMLSlotElement::insertedIntoAncestor.

It's not the most elegant solution but staying safe for now.

Test: fast/shadow-dom/insert-slot-child-of-shadow-host-render-tree-invalidation-crash.html

dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::assignedNodesForSlot):

html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::insertedIntoAncestor):

html/HTMLSlotElement.h:

(WebCore::HTMLSlotElement::isInInsertedIntoAncestor): Added.

LayoutTests:

Added a regression test.

fast/shadow-dom/insert-slot-child-of-shadow-host-render-tree-invalidation-crash-expected.txt: Added.
fast/shadow-dom/insert-slot-child-of-shadow-host-render-tree-invalidation-crash.html: Added.

2:27 PM Changeset in webkit [279009] by Jonathan Bedard

4 edits in trunk/Tools

[webkitcorepy] Retry downloads in Autoinstall
https://bugs.webkit.org/show_bug.cgi?id=227134
<rdar://problem/79462182>

Reviewed by Aakash Jain.

Scripts/libraries/webkitcorepy/setup.py: Bump version.
Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.Archive.download): Retry failed downloads
(AutoInstall): Allow for a single retry by default

2:12 PM Changeset in webkit [279008] by Fujii Hironori

3 edits in trunk/Source/JavaScriptCore

Reimplement JSC::CachePayload without FileSystem::unmapViewOfFile and FileSystem::MappedFileData::leakHandle
https://bugs.webkit.org/show_bug.cgi?id=227014

Reviewed by Yusuke Suzuki.

r247542 (Bug 199759) added FileSystem::unmapViewOfFile and
FileSystem::MappedFileData::leakHandle for JSC::CachePayload to
get the mapped address and to free the address.

However, Bug 227011 is going to add a file mapping handle to
FileSystem::MappedFileData for Windows port to create a
SharedMemory from a MappedFileData. Destruction of MappedFileData
should be done only by MappedFileData dtor.

runtime/CachePayload.cpp:

(JSC::CachePayload::makeMappedPayload):
(JSC::CachePayload::makeMallocPayload):
(JSC::CachePayload::makeEmptyPayload):
(JSC::CachePayload::CachePayload):
(JSC::CachePayload::data const):
(JSC::CachePayload::size const):
(JSC::CachePayload::~CachePayload): Deleted.
(JSC::CachePayload::operator=): Deleted.
(JSC::CachePayload::freeData): Deleted.

runtime/CachePayload.h: Use Variant for data.

(JSC::CachePayload::data const): Deleted.
(JSC::CachePayload::size const): Deleted.
(JSC::CachePayload::CachePayload): Deleted.

1:49 PM Changeset in webkit [279007] by Ben Nham

9 edits
1 move
1 delete in trunk/Source

Remove Mac-specific CPUTime functions
https://bugs.webkit.org/show_bug.cgi?id=227109

Reviewed by Yusuke Suzuki.

Source/WebKit:

Permit calling thread_selfusage, since it is used by clock_gettime(CLOCK_THREAD_CPUTIME_ID, tp).

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

There's no reason for the Mac-specific CPU time functions to exist, since getrusage and
clock_gettime work fine on Mac. It's actually slightly more efficient to use the POSIX calls
since getrusage returns CPU time for both current and terminated threads in a single
syscall, while using task_info requires two syscalls to do the same thing.

WTF.xcodeproj/project.pbxproj:
wtf/PlatformGTK.cmake:
wtf/PlatformJSCOnly.cmake:
wtf/PlatformPlayStation.cmake:
wtf/PlatformWPE.cmake:
wtf/cocoa/CPUTimeCocoa.cpp: Removed.
wtf/posix/CPUTimePOSIX.cpp: Renamed from Source/WTF/wtf/unix/CPUTimeUnix.cpp.

1:48 PM Changeset in webkit [279006] by Chris Dumez

4 edits in trunk

Trying to take empty snapshots of the view should not cause crashes
https://bugs.webkit.org/show_bug.cgi?id=227133

Reviewed by Tim Horton.

Source/WebKit:

Trying to take empty snapshots of the view should not cause crashes. We would previously
see crashes because:

We would end up doing divisions by zero
We would hit the ASSERT(size) in SharedMemory::allocate().

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:

(TEST):

1:07 PM Changeset in webkit [279005] by commit-queue@webkit.org

3 edits
2 adds in trunk/Tools

[iOS 15] Add iOS 15 simulator/device to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226779

Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/public_html/dashboard/Images/IOS15.png: Added.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS15Simulator.png: Added.
CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added references to iOS 15 device + simulator, shifted ordering down
CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added references to iOS 15 device + simulator

(table.queue-grid tr.platform.ios-simulator-15 img.logo):
(table.queue-grid tr.platform.ios-15 img.logo):

1:03 PM Changeset in webkit [279004] by Kate Cheney

11 edits in trunk/Source

Storage Access quirks should prompt up to twice if a user does not allow storage access
https://bugs.webkit.org/show_bug.cgi?id=227099
<rdar://problem/79409843>

Reviewed by John Wilander.

Source/WebCore:

Remove hasDeniedCrossPageStorageAccess functions. They are not needed
now that we are aligning storage access quirks with non-quirks by
using maxNumberOfTimesExplicitlyDeniedStorageAccess.

dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccessQuickCheck):
(WebCore::DocumentStorageAccess::requestStorageAccessForNonDocumentQuirk):

dom/DocumentStorageAccess.h:
dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

dom/Element.h:
loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::hasHadUserInteraction const):
(WebCore::ResourceLoadObserver::setHasDeniedCrossPageStorageAccess): Deleted.
(WebCore::ResourceLoadObserver::hasDeniedCrossPageStorageAccess const): Deleted.

page/Quirks.cpp:

(WebCore::isStorageAccessQuirkDomainAndElement):
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
(WebCore::hasDeniedCrossPageStorageAccess): Deleted.

page/Quirks.h:

Source/WebKit:

We should allow storage access prompts twice per document for quirks
just like for non-quirk cases. Previously we were only presenting
the quirk prompt once per web content process if the user denied. This
patch removes this code and utilizes maxNumberOfTimesExplicitlyDeniedStorageAccess
instead.

WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::hasDeniedCrossPageStorageAccess const): Deleted.
(WebKit::WebResourceLoadObserver::setHasDeniedCrossPageStorageAccess): Deleted.

WebProcess/WebCoreSupport/WebResourceLoadObserver.h:

1:00 PM Changeset in webkit [279003] by timothy_horton@apple.com

2 edits in trunk/Source/WTF

Adopt WKHoverGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=227116
<rdar://79442027>

Reviewed by Wenson Hsieh.

wtf/PlatformEnableCocoa.h:

11:57 AM Changeset in webkit [279002] by Aditya Keerthi

6 edits in trunk/Source/WebCore

REGRESSION (r277067): Incorrect text color for default-button appearance
https://bugs.webkit.org/show_bug.cgi?id=227129
<rdar://problem/79032808>

Reviewed by Tim Horton.

Buttons styled with '-webkit-appearance: default-button' currently rely
on the CSS value 'activebuttontext' for their text color. r277067
updated the color to use system colors, for consistency with the rest
of the platform.

In macOS Monterey, the 'activebuttontext' color and the default button
text color are not equivalent. 'Active' buttons no longer use
NSBackgroundStyleEmphasized, while default buttons still do.
Consequently, default buttons are rendered with an incorrect text color.

To fix, use the correct system color for the text color of default
buttons. To avoid changing the behavior of platforms other than
macOS, the 'activebuttontext' color remains the default text color
specified in RenderTheme.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::defaultButtonTextColor const):
(WebCore::RenderTheme::platformDefaultButtonTextColor const):

rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::platformDefaultButtonTextColor const):

rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle):

11:43 AM Changeset in webkit [279001] by commit-queue@webkit.org

3 edits
2 adds in trunk/Tools

[watchOS 8] Add watchOS 8 simulator/device to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226781

Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS8.png: Added.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator8.png: Added.
CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added references for watchOS 8 device + simulator; shifted order down for Windows platforms to make room
CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added references for watchOS 8 device + simulator

(table.queue-grid tr.platform.watchos-simulator-8 img.logo):
(table.queue-grid tr.platform.watchos-8 img.logo):

11:41 AM Changeset in webkit [279000] by commit-queue@webkit.org

3 edits
2 adds in trunk/Tools

[tvOS 15] Add tvOS 15 simulator/device to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226782

Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/public_html/dashboard/Images/TvOS15.png: Added.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS15Simulator.png: Added.
CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added references to tvOS 15 device + simulator
CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added references to tvOS 15 device + simulator

(table.queue-grid tr.platform.tvos-simulator-15 img.logo):
(table.queue-grid tr.platform.tvos-15 img.logo):

11:38 AM Changeset in webkit [278999] by commit-queue@webkit.org

3 edits
1 add in trunk/Tools

[Monterey] Add Seed 1 to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226747

Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/public_html/dashboard/Images/Monterey.png: Added.
CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added Monterey
CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added Monterey

(table.queue-grid tr.platform.macos-monterey img.logo):

11:24 AM Changeset in webkit [278998] by pvollan@apple.com

2 edits in trunk/Tools

[Win] Exception running layout tests
https://bugs.webkit.org/show_bug.cgi?id=227114

Reviewed by Jonathan Bedard.

Catch exception and print warning message.

Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:

(TaskPool.exit):

11:18 AM Changeset in webkit [278997] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

Adopt WKHoverGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=227116
<rdar://79442027>

Reviewed by Wenson Hsieh.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
(-[WKContentView gestureRecognizer:shouldReceivePress:]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView setUpHoverGestureRecognizer]):
(-[WKContentView hoverGestureRecognizerChanged:]):
Plumb mouse events from WKHoverGestureRecognizer to the page.

10:23 AM Changeset in webkit [278996] by Russell Epstein

1 copy in tags/Safari-612.1.19

Tag Safari-612.1.19.

10:17 AM Changeset in webkit [278995] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix crashes in ContentRuleListStore::lookupContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=227100
<rdar://78816611>

Reviewed by Chris Dumez.

To be extra careful, instead of just assuming that moveFile will always succeed,
when moveFile fails, try to delete the legacy path (which has a ContentExtension- instead of ContentRuleList- prefix)
and fail the lookup. This will only happen in Safari, which was the only client of _WKUserContentExtensionStore.
The legacy file is not useful to us because in r275078 I incremented CurrentContentRuleListFileVersion so the bytes on disk
need to be recompiled anyways. Safari already has logic to recompile it. This was just an attempt to use what we have and
not leave anything behind.

Also, to be extra careful, try deleting a file before moving a file on top of it.

UIProcess/API/APIContentRuleListStore.cpp:

compiledToFile:
(API::ContentRuleListStore::lookupContentRuleList):

10:16 AM Changeset in webkit [278994] by commit-queue@webkit.org

7 edits in trunk/Source/JavaScriptCore

Add a new pattern to instruction selector to utilize UBFX supported by ARM64
https://bugs.webkit.org/show_bug.cgi?id=226984

Patch by Yijia Huang <Yijia Huang> on 2021-06-17
Reviewed by Filip Pizlo.

UBFX, supported by ARM64, copies adjacent bits from the source register into
the least significant bits of a destination register in zero extension. The
instruction selector can utilize this to lowering certain patterns in B3 IR
before further Air optimization.

ubfx dest, src, lsb, width

tmp, tmp, imm, imm

This is equivalent to "dest = (src >> lsb) & ((1 << width) - 1)". Since wasm
introduces constant folding, then the pattern would be:

dest = (src >> lsb) & mask

where the mask should have a binary format in contiguous ones starting from
the least significant bit. For example:

0b00111111

To make the pattern matching in instruction selection beneficial to JIT, these
constraints should be introduced:

lsb >= 0
width > 0
lsb + width <= bit field limit (32 or 64)

Given:
B3 IR
Int @0 = ArgumentReg(%0)
Int @1 = lsb
Int @2 = 0b0011
Int @3 = ZShr(@0, @1)
Int @4 = BitAnd(@3, @2)
Void@5 = Return(@4, Terminal)

w/o UBFX Pattern:
Old optimized AIR
Urshift %x0, lsb, %x0, @3
And 0b0011, %x0, %x0, @4
Ret %x0, @5

w/ UBFX Pattern:
New optimized AIR
Ubfx %x0, lsb, 2, %x0, @4
Ret %x0, @5

Note:
Suppose a 32-bit version of (src >> 20) & 0x0FFF, it is equivalent to src >> 20.
In this case, Logical Shift Right should be utilized instead when:

lsb + width == bit field limit (32 or 64)

This case/pattern should be added and upadated in the future patch.

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::ubfx32):
(JSC::MacroAssemblerARM64::ubfx64):

assembler/testmasm.cpp:

(JSC::testUbfx32):
(JSC::testUbfx64):

b3/B3LowerToAir.cpp:
b3/air/AirOpcode.opcodes:
b3/testb3.h:
b3/testb3_2.cpp:

(testUbfx64PatternMatch):
(testUbfx32PatternMatch):
(addBitTests):

10:05 AM Changeset in webkit [278993] by achristensen@apple.com

27 edits
1 delete in trunk

Remove empty header WebTypesInternal.h
https://bugs.webkit.org/show_bug.cgi?id=227094

Reviewed by Fujii Hironori.

Source/WebKitLegacy:

WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

DefaultDelegates/WebDefaultUIDelegate.mm:
History/WebBackForwardList.mm:
History/WebHistory.mm:
History/WebHistoryItem.mm:
Misc/WebDownload.mm:
Misc/WebElementDictionary.mm:
Misc/WebNSDataExtras.h:
Misc/WebTypesInternal.h: Removed.
Plugins/WebBasePluginPackage.mm:
Plugins/WebNetscapePluginPackage.mm:
WebView/WebArchive.mm:
WebView/WebDelegateImplementationCaching.h:
WebView/WebHTMLRepresentation.mm:
WebView/WebHTMLView.mm:
WebView/WebPDFDocumentExtras.mm:
WebView/WebPDFRepresentation.mm:
WebView/WebTextCompletionController.mm:
WebView/WebTextIterator.mm:
WebView/WebViewData.h:
WebView/WebViewInternal.h:

Tools:

DumpRenderTree/mac/AccessibilityUIElementMac.mm:
DumpRenderTree/mac/DumpRenderTreePasteboard.h:
DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
DumpRenderTree/mac/TextInputControllerMac.m:

9:52 AM Changeset in webkit [278992] by achristensen@apple.com

4 edits in trunk

WKScriptMessageHandlerWithReply should raise an exception if replyHandler is called twice
https://bugs.webkit.org/show_bug.cgi?id=226863

Reviewed by Chris Dumez.

Source/WebKit:

We currently dereference null inside CompletionHandlerWithFinalizer.
This makes it more obvious what is going on.
Related to rdar://78865409 but not solving it.

UIProcess/API/Cocoa/WKUserContentController.mm:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:

(-[AsyncScriptMessageHandler userContentController:didReceiveScriptMessage:replyHandler:]):

9:36 AM Changeset in webkit [278991] by Angelos Oikonomopoulos

2 edits in trunk/Source/JavaScriptCore

[JSC] Work around apparent miscompilation on ARM/GCC >=8.4
https://bugs.webkit.org/show_bug.cgi?id=227125

Reviewed by Filip Pizlo.

This seems to be a GCC miscompilation, revealed by
https://bugs.webkit.org/show_bug.cgi?id=227078. Introduce a
workaround for the GCC versions that seem to be affected.

jit/RegisterSet.h:

9:34 AM Changeset in webkit [278990] by eric.carlson@apple.com

2 edits in trunk/Tools

[Mac EWS] TestWebKitAPI.WebKit.AudioBufferSize is flaky timing out on EWS
https://bugs.webkit.org/show_bug.cgi?id=227046
<rdar://problem/79360787>

Unreviewed, fix broken test.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add audio-buffer-size.html

to the Copy Resources step so tests can use it.

9:04 AM Changeset in webkit [278989] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews] Improve build summary about finding flaky test in ReRunWebKitTests
https://bugs.webkit.org/show_bug.cgi?id=227123

Reviewed by Jonathan Bedard.

CISupport/ews-build/steps.py:

(ReRunWebKitTests.evaluateCommand):

CISupport/ews-build/steps_unittest.py:

8:57 AM Changeset in webkit [278988] by eocanha@igalia.com

9 edits in trunk

[GTK] Unexpected timeout in http/tests/media/video-play-stall-seek.html
https://bugs.webkit.org/show_bug.cgi?id=196198

Reviewed by Philippe Normand.

Source/WebCore:

Increased default GstDowloadBuffer size to prevent a race condition. To do that, we need
to set the buffer-size of GstUriDecodebin (that will set the GstMultiQueue size, so we use
the default value that would be used if no changes had been made, and also leaves
GstDownloadBuffer size untouched, which wouldn't happen if no buffer-size had been set)
and then set the desired max-size-bytes on GstDownloadBuffer.

The race condition was that some times the player private readyState went up to
HAVE_ENOUGH_DATA and then back to HAVE_CURRENT_DATA (triggering the expected waiting event),
and some others times went directly to HAVE_CURRENT_DATA (no waiting event, test stalled).
Increasing the buffer size gave more time for the double transition to happen.

Still, these changes weren't enough to get the test passing, as with these changes the
multiqueue sucked all the data, downloadbuffer fell to a low percentage and updateStates()
paused the pipeline for rebuffering. The pipeline won't ever be unpaused because at that
point WebKitWebSrc has reached EOS (no more file to download, a side effect of the current
libsoup behaviour) and the buffering won't ever go up again (and trigger the unpause).

This was solved by setting the downloadbuffer high-percent property to 0 when a seek
is done after EOS has been received by WebKitWebSrc. This effectively forces the
downloadbuffer to report 100% buffered, which unpauses the pipeline and lets the playback
continue after seek.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::doSeek): Set high-percent when seeking after WebKitWebSrc EOS.
(WebCore::MediaPlayerPrivateGStreamer::sourceSetup): Manually set buffer-size to its default value.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Receive the custom EOS message from WebKitWebSrc and remember it.
(WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback): Manully set max-size-bytes to a higher than default value.
(WebCore::MediaPlayerPrivateGStreamer::downloadBufferFileCreatedCallback): Don't clean the reference to the downloadbuffer, as it'll be needed later.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Added m_hasWebKitWebSrcSentEOS to remember the EOS condition.
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcCreate): Notify the EOS condition using the bus, so the player private can handle it.
(CachedResourceStreamingClient::loadFailed): Extra useful logs.
(CachedResourceStreamingClient::loadFinished): Ditto.

LayoutTests:

Make test more stable and don't expect NETWORK_LOADING, because some network implementations,
like libsoup, just report end-of-stream and finish the download.

http/tests/media/video-play-stall-seek-expected.txt: Removed NETWORK_LOADING expectation.
http/tests/media/video-play-stall-seek.html: Stabilize the test by not listening to waiting events once the relevant one has been handled, and by pausing the video after the test has finished. Also re

8:53 AM Changeset in webkit [278987] by ddkilzer@apple.com

2 edits in trunk/Tools

REGRESSION (r278536): Wrong comment character used in coverage.xcconfig

coverage/coverage.xcconfig:
Change '#' to '' to fix the comment.

7:53 AM Changeset in webkit [278986] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed GStreamer mediastream gardening

platform/glib/TestExpectations: Unflag fast/mediastream/media-stream-renders-first-frame.html
platform/wpe/TestExpectations: Move getDisplayMedia expectations to glib file.

6:13 AM Changeset in webkit [278985] by Oriol Brufau

8 edits in trunk

[css-logical] Implement logical property groups
https://bugs.webkit.org/show_bug.cgi?id=226878

Reviewed by Antti Koivisto.

Source/WebCore:

In order to have proper CSSOM support for logical properties, we will
need to determine whether two properties belong to the same logical
property group but with a different mapping logic.

Before this patch, we only knew the physical properties belonging to the
same logical property group as a given logical property. But given a
physical property, we didn't know if there were logical properties that
could map to it.

Therefore this patch changes CSSProperties.json so that both logical and
physical properties specify their logical property group.

The code for resolving a logical property into its physical equivalent
is now automatically generated.

The CSSOM fix will be done in a follow-up (bug 226461).

This patch introduces no behavior changes.

css/CSSProperties.json:
css/CSSProperty.cpp:
css/makeprop.pl:

(nameToId):
(addProperty):

platform/RectEdges.h:

(WebCore::RectEdges::before):
(WebCore::RectEdges::after):
(WebCore::RectEdges::start):
(WebCore::RectEdges::end):
(WebCore::RectEdges::before const):
(WebCore::RectEdges::after const):
(WebCore::RectEdges::start const):
(WebCore::RectEdges::end const):

platform/text/WritingMode.h:

(WebCore::mapLogicalAxisToPhysicalAxis):

Tools:

Add validator for new codegen property "logical-property-group",
replacing the old "direction-aware-property".

Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONCSSPropertiesChecker.validate_logical_property_group):
(JSONCSSPropertiesChecker.check_codegen_properties):

6:05 AM Changeset in webkit [278984] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed GStreamer mediastream gardening

platform/glib/TestExpectations: Unflag 3 tests consistently passing.

5:59 AM Changeset in webkit [278983] by eocanha@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf*
https://bugs.webkit.org/show_bug.cgi?id=204686

Unreviewed WPE/GTK debug build fix.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack): Removed assert left there from a previous version of the patch.

5:38 AM Changeset in webkit [278982] by youenn@apple.com

4 edits
3 adds in trunk

Fix RTCDataChannelInit::decode
https://bugs.webkit.org/show_bug.cgi?id=226968
Source/WebCore:

Reviewed by Eric Carlson.

Test: imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel-service-worker.https.html

platform/mediastream/RTCDataChannelHandler.h:

(WebCore::RTCDataChannelInit::decode):
Make sure to use optionals of optionals.

LayoutTests:

<rdar://problem/79300038>

Reviewed by Eric Carlson.

http/wpt/webrtc/transfer-datachannel-service-worker.https-expected.txt: Added.
http/wpt/webrtc/transfer-datachannel-service-worker.https.html: Added.
http/wpt/webrtc/transfer-datachannel-service-worker.js: Added.

(onmessage):

platform/mac-wk1/TestExpectations:

5:00 AM Changeset in webkit [278981] by eocanha@igalia.com

4 edits in trunk/Source/WebCore

[GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf*
https://bugs.webkit.org/show_bug.cgi?id=204686

Reviewed by Philippe Normand.

Refactored the notifyPlayerOf{Audio,Video,Text} family of methods into a single notifyPlayerOfTrack() one.
Some Variant variables are needed in order to make several incompatible types work together and to auto-detect the type of track as an enum.

Covered by existing tests.

platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

(WebCore::InbandTextTrackPrivateGStreamer::create): Added method with a signature similar to the ones used by {Audio,Video}TrackPrivateGStreamer, so that it fits into the notifyPlayerOfTrack() template code.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack): Template method that unifies the old notifyPlayerOf{Audio,Video,Text}() implementations.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Deleted. Refactored into notifyPlayerOfTrack().
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::audioChangedCallback): Call the new notifyPlayerOfTrack() refactored implementation.
(WebCore::MediaPlayerPrivateGStreamer::textChangedCallback): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::videoChangedCallback): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidAudioTracks): Deleted. Now implemented directly inside notifyPlayerOfTrack().
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidTextTracks): Ditto.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Deleted notifyPlayerOf{Audio,Video,Text}(), added notifyPlayerOfTrack(), deleted purgeInvalid{Audio,Video,Text}Tracks().

3:50 AM Changeset in webkit [278980] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Close open connections
https://bugs.webkit.org/show_bug.cgi?id=227068

Reviewed by Brent Fulgham.

On macOS, close open connections in initializeSandboxParameters.

Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::initializeSandboxParameters):

2:49 AM Changeset in webkit [278979] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Unreviewed, reverting r278978.
https://bugs.webkit.org/show_bug.cgi?id=227115

The patch seems to be breaking the Debian and Ubuntu builds.

Reverted changeset:

"[GStreamer] Refactor
MediaPlayerPrivateGStreamer::notifyPlayerOf*"
https://bugs.webkit.org/show_bug.cgi?id=204686
https://trac.webkit.org/changeset/278978

2:18 AM Changeset in webkit [278978] by eocanha@igalia.com

4 edits in trunk/Source/WebCore

[GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf*
https://bugs.webkit.org/show_bug.cgi?id=204686

Reviewed by Philippe Normand.

Covered by existing tests.

platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Deleted notifyPlayerOf{Audio,Video,Text}(), added notifyPlayerOfTrack(), deleted purgeInvalid{Audio,Video,Text}Tracks().

1:38 AM Changeset in webkit [278977] by Carlos Garcia Campos

2 edits in trunk/Tools

[GLIB] Pass a GTlsCertificate to soup_server_new()
https://bugs.webkit.org/show_bug.cgi?id=227023

Reviewed by Michael Catanzaro.

Instead of using soup_server_set_ssl_cert_file() that will be removed from libsoup soon.

TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:

(WebKitTestServer::WebKitTestServer):

12:00 AM Changeset in webkit [278976] by Fujii Hironori

2 edits in trunk/Tools

[Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing
https://bugs.webkit.org/show_bug.cgi?id=227102

Reviewed by Ryosuke Niwa.

A heap corruption was detected while a Derived class object was
destroyed as a Base class object.

TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::Base::~Base): Made Base class dtor virtual.
(TestWebKitAPI::Derived::~Derived):

Jun 16, 2021:

11:19 PM Changeset in webkit [278975] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Make FontFaceSet::Iterator's bounds check more robust
https://bugs.webkit.org/show_bug.cgi?id=227048
<rdar://problem/78871890>

Reviewed by Simon Fraser.

We were checking for one specific bad value, when we should have been checking for all bad values.

css/FontFaceSet.cpp:

(WebCore::FontFaceSet::Iterator::next):

10:39 PM Changeset in webkit [278974] by Chris Dumez

96 edits
2 adds
2 deletes in trunk

Document's execCommand() / queryCommand*() should throw an exception on non-HTML/XHTML documents
https://bugs.webkit.org/show_bug.cgi?id=227016

Reviewed by Darin Adler.

Source/WebCore:

Update Document's execCommand() / queryCommand*() to throw an InvalidStateError when the document
is not an HTML/XHTML document. This matches Blink's behavior. Firefox is even stricter and throws
for all non HTML documents (including XHTML).

Test: fast/dom/Document/document-execcommand.html

dom/Document.cpp:

(WebCore::Document::execCommand):
(WebCore::Document::queryCommandEnabled):
(WebCore::Document::queryCommandIndeterm):
(WebCore::Document::queryCommandState):
(WebCore::Document::queryCommandSupported):
(WebCore::Document::queryCommandValue):

dom/Document.h:

Source/WebKitLegacy/mac:

Update ObjC bindings since the WebCore API now returns ExceptionOr<> types.

DOM/DOMDocument.mm:

(-[DOMDocument execCommand:userInterface:value:]):
(-[DOMDocument queryCommandEnabled:]):
(-[DOMDocument queryCommandIndeterm:]):
(-[DOMDocument queryCommandState:]):
(-[DOMDocument queryCommandSupported:]):
(-[DOMDocument queryCommandValue:]):

LayoutTests:

fast/dom/Document/document-execcommand-expected.txt: Added.
fast/dom/Document/document-execcommand.html: Added.

Add layout test coverage.

editing/pasteboard/createMarkup-assert-expected.txt: Removed.
editing/pasteboard/createMarkup-assert.xml: Removed.
platform/mac/svg/text/foreignObject-repaint-expected.txt:
platform/mac/svg/text/foreignObject-text-clipping-bug-expected.txt:
platform/mac/svg/text/text-align-01-b-expected.txt:
platform/mac/svg/text/text-align-02-b-expected.txt:
platform/mac/svg/text/text-align-03-b-expected.txt:
platform/mac/svg/text/text-align-04-b-expected.txt:
platform/mac/svg/text/text-align-05-b-expected.txt:
platform/mac/svg/text/text-align-06-b-expected.txt:
platform/mac/svg/text/text-deco-01-b-expected.txt:
platform/mac/svg/text/text-fonts-01-t-expected.txt:
platform/mac/svg/text/text-fonts-02-t-expected.txt:
platform/mac/svg/text/text-intro-05-t-expected.txt:
platform/mac/svg/text/text-path-01-b-expected.txt:
platform/mac/svg/text/text-spacing-01-b-expected.txt:
platform/mac/svg/text/text-text-01-b-expected.txt:
platform/mac/svg/text/text-text-03-b-expected.txt:
platform/mac/svg/text/text-text-04-t-expected.txt:
platform/mac/svg/text/text-text-05-t-expected.txt:
platform/mac/svg/text/text-text-07-t-expected.txt:
platform/mac/svg/text/text-text-08-b-expected.txt:
platform/mac/svg/text/text-tref-01-b-expected.txt:
platform/mac/svg/text/text-tselect-01-b-expected.txt:
platform/mac/svg/text/text-tselect-02-f-expected.txt:
platform/mac/svg/text/text-tspan-01-b-expected.txt:
svg/custom/bug78838-expected.txt:
svg/custom/bug79798-expected.txt:
svg/custom/delete-modified-text-in-defs-crash.svg:
svg/custom/layout-loop-expected.txt:
svg/text/text-positioning-remove-child-crash.svg:

Rebaseline / update existing tests due to behavior change.

8:45 PM Changeset in webkit [278973] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Passkeys don't work in Simulator
https://bugs.webkit.org/show_bug.cgi?id=227076
<rdar://79366832>

Patch by Garrett Davidson <garrett_davidson@apple.com> on 2021-06-16
Reviewed by Brent Fulgham.

Simulator does not support LAAccessControlOperationUseKeySign, so
-evaluateAccessControl:... returns an error. However, this check isn't actually necessary in
the simulator when using passkeys, so just skip it.

Tested registration and assertion in an app in Simulator.

UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:

(WebKit::LocalConnection::verifyUser):

8:26 PM Changeset in webkit [278972] by ysuzuki@apple.com

2 edits in trunk/Source/WTF

[JSC] Disable JITCage on macOS until we evaluate performance throughly
https://bugs.webkit.org/show_bug.cgi?id=227104

Reviewed by Mark Lam.

This patch disables JITCage on macOS until we evaluate performance throughly.

wtf/PlatformEnable.h:

8:09 PM Changeset in webkit [278971] by ysuzuki@apple.com

6 edits
1 add in trunk

[JSC] Optimize JSON.parse with small data by changing Identifier pool mechanism
https://bugs.webkit.org/show_bug.cgi?id=227101

Reviewed by Mark Lam.

Found that std::array<Identifier, 128> pool in LiteralParser is too costly for construction and destruction
if JSON.parse is invoked for small data. This patch changes this pool mechanism so that we do not waste effort
allocating null Identifiers to pre-populate the recent identifiers pool. Instead, we now use a m_recentIdentifiersIndex
uint8_t array to indicate whether there's a cached recent identifier for each given first character.

We also use KeywordLookup.h's COMPARE_XCHARS to perform "true" / "false" / "null" lexing in JSON parser.
Roughly 20% improvement in microbenchmark. And roughly 2-3% improvement in Speedometer2/Flight-TodoMVC.

ToT Patched

flight-todomvc-json 67.8755+-1.1202 ^{56.7114+-0.5048} definitely 1.1969x faster

runtime/Identifier.cpp:

(JSC::Identifier::add):
(JSC::Identifier::add8):

runtime/Identifier.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::add):

runtime/IdentifierInlines.h:

(JSC::Identifier::add):
(JSC::Identifier::fromString):

runtime/LiteralParser.cpp:

(JSC::compare3Chars):
(JSC::compare4Chars):
(JSC::LiteralParser<CharType>::makeIdentifier):
(JSC::LiteralParser<CharType>::Lexer::lex):

runtime/LiteralParser.h:

5:46 PM Changeset in webkit [278970] by Said Abou-Hallawa

4 edits in trunk/Source

takeSnapshotWithConfiguration() should wait for the next flush before it does callSnapshotRect()
https://bugs.webkit.org/show_bug.cgi?id=226257
<rdar://76411685>

Reviewed by Simon Fraser and Tim Horton.

Source/WebCore/PAL:

pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

This will ensure the latest IOSurfaces are pushed to backboardd before
taking the snapshot. Also we need create an implicit transaction to ensure
a commit will happen.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):

5:27 PM Changeset in webkit [278969] by Cameron McCormack

3 edits
2 adds in trunk

Make RenderLayer::hitTestLayer not assume its renderer is a RenderBox
https://bugs.webkit.org/show_bug.cgi?id=227004
<rdar://79265788>

Reviewed by Simon Fraser.

Source/WebCore:

An inline box might have a clip-path on it, so we can't assume that
the layer's renderer is a RenderBox. Avoid the assertion by hit testing
incorrectly for now.

Test: css3/masking/clip-path-hit-test-on-inline-iframe-parent.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

css3/masking/clip-path-hit-test-on-inline-iframe-parent-expected.txt: Added.
css3/masking/clip-path-hit-test-on-inline-iframe-parent.html: Added.

5:15 PM Changeset in webkit [278968] by Russell Epstein

1 copy in tags/Safari-612.1.18.1.3

Tag Safari-612.1.18.1.3.

4:39 PM Changeset in webkit [278967] by Jonathan Bedard

2 edits
19 moves
40 deletes in trunk/Tools

Clean up how platform images are handled in the bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226989

Patch by W.D. Xiong.

Renamed the _@2x.png files to _.png and removed old platforms that don't have queues anymore. Also renamed WatchOSSimulator7 to WatchOS7Simulator

CISupport/build-webkit-org/public_html/dashboard/Images/BigSur.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/BigSur@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/BigSur@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Catalina.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Catalina@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/Catalina@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/ElCapitan.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/ElCapitan@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/GTK.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/GTK@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/GTK@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/HighSierra.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/HighSierra@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS10.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS10@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS10Simulator.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS10Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS11.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS11@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS11Simulator.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS11Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS12.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS12@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS12Simulator.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS12Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS13.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS13@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS13Simulator.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS13Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS14.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS14@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS14@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS14Simulator.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS14Simulator@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS14Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS9.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS9@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS9Simulator.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOS9Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Mavericks.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Mavericks@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Mojave.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Mojave@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/Mojave@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/MountainLion.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/MountainLion@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/MountainLion@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/PlatformRing.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlatformRing@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/PlatformRing@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Sierra.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Sierra@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/SquirrelFish.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/SquirrelFish@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/SquirrelFish@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13Simulator.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14Simulator.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14Simulator@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14Simulator@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WPE.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WPE@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/WPE@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS6.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS6@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7Simulator.png: Copied from Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator7@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator6.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator6@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator6@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator7.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator7@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Windows10.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Windows10@2x.png.
CISupport/build-webkit-org/public_html/dashboard/Images/Windows10@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Windows7.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Windows7@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Windows8.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Windows8@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WindowsXP.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/WindowsXP@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Yosemite.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Images/Yosemite@2x.png: Removed.
CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Applied above changes

(table.queue-grid td.logo img.ring):
(table.queue-grid tr.platform.ios-simulator-14 img.logo):
(table.queue-grid tr.platform.ios-14 img.logo):
(table.queue-grid tr.platform.tvos-simulator-14 img.logo):
(table.queue-grid tr.platform.tvos-14 img.logo):
(table.queue-grid tr.platform.watchos-simulator-7 img.logo):
(table.queue-grid tr.platform.watchos-7 img.logo):
(table.queue-grid tr.platform.macos-catalina img.logo):
(table.queue-grid tr.platform.macos-bigsur img.logo):
(table.queue-grid tr.platform.wincairo-windows-10 img.logo):
(table.queue-grid tr.platform.windows-10 img.logo):
(table.queue-grid tr.platform.windows-7 img.logo):
(table.queue-grid tr.platform.linux-gtk img.logo):
(table.queue-grid tr.platform.linux-wpe img.logo):
(table.queue-grid tr.platform.linux-jsconly img.logo):

4:37 PM Changeset in webkit [278966] by mark.lam@apple.com

4 edits in trunk/Source

Adopt com.apple.security.cs.jit-write-allowlist on internal builds.
https://bugs.webkit.org/show_bug.cgi?id=222148
rdar://74284026

Reviewed by Per Arne Vollan.

Source/JavaScriptCore:

This will prevent various pthread permissions switching APIs from working.
We only want to adopt this for internal builds where we use the fast permission
switching macro instead. We can't adopt it for open source builds, where we
still rely on the pthread API.

Scripts/process-entitlements.sh:

Source/WebKit:

Scripts/process-entitlements.sh:

4:26 PM Changeset in webkit [278965] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Skip another WebGL 2 test.
https://bugs.webkit.org/show_bug.cgi?id=227093

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-06-16

platform/glib/TestExpectations:

4:09 PM Changeset in webkit [278964] by Chris Dumez

5 edits in trunk/Source/WebCore

Protect Element before calling dispatchMouseEvent() on it
https://bugs.webkit.org/show_bug.cgi?id=226767
<rdar://problem/79009112>

Reviewed by Ryosuke Niwa.

page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::dispatchMouseEvent):

page/PointerLockController.cpp:

(WebCore::PointerLockController::dispatchLockedMouseEvent):

page/Quirks.cpp:

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

3:41 PM Changeset in webkit [278963] by Jonathan Bedard

5 edits in trunk/Tools

[webkitscmpy] Support branch queries in mock git log
https://bugs.webkit.org/show_bug.cgi?id=225889
<rdar://problem/78122705>

Reviewed by Stephanie Lewis.

Scripts/libraries/webkitscmpy/setup.py: Bump version.
Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Add support for branches in

git log commands.

Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit.test_log):
(TestGit.test_branch_log):

3:39 PM Changeset in webkit [278962] by Chris Dumez

12 edits
1 copy
21 moves
81 adds
17 deletes in trunk/LayoutTests

Resync FileAPI tests from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=227089

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Resync FileAPI tests from upstream WPT b5949c67c948bc452e3.

web-platform-tests/FileAPI/*: Updated.

LayoutTests:

tests-options.json:

3:37 PM Changeset in webkit [278961] by Chris Dumez

18 edits
8 adds in trunk/LayoutTests/imported/w3c

Resync webaudio tests from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=227091

Reviewed by Geoffrey Garen.

Resync webaudio tests from upstream WPT b5949c67c948bc452e3.

web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold.html: Added.
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-nominal-range-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-nominal-range.html: Added.
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values.html:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion.html:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-throw-onmessage.https-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-throw-onmessage.https.html: Added.
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation.html:
web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/test-constantsourcenode.html:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv.html:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-setposition-throws-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-setposition-throws.html: Added.
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-periodicwave-interface/periodicWave.html:

3:27 PM Changeset in webkit [278960] by Ruben Turcios

1 copy in tags/Safari-611.3.8

Tag Safari-611.3.8.

3:26 PM Changeset in webkit [278959] by rmorisset@apple.com

2 edits in trunk/Source/JavaScriptCore

Don't look at the (non-existent) child2 of DelById
https://bugs.webkit.org/show_bug.cgi?id=227095

Reviewed by Mark Lam.

Trivial fix to a broken rebase: while it is ok to share most code between DelById and DelByVal, only the latter has a child2(), so it should not be accessed if we are compiling the former.
No new test, as it was caught by one of our existing tests.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileDelBy):

3:22 PM Changeset in webkit [278958] by Peng Liu

2 edits in trunk/Source/WebCore

Some http/tests/ are crashing with ASSERTION FAILED: isInRoutingArbitrationForToken(token)

m_setupArbitrationOngoing

https://bugs.webkit.org/show_bug.cgi?id=226896

Reviewed by Darin Adler.

A follow-up patch to fix an issue in r278922. Remove the call to contains()
before remove() on a WeakHashSet.

platform/audio/mac/SharedRoutingArbitrator.mm:

(WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken):

3:18 PM Changeset in webkit [278957] by Wenson Hsieh

15 edits
1 move
1 delete in trunk

[watchOS] Reenable modern text input UI for non-numeric text input types
https://bugs.webkit.org/show_bug.cgi?id=226988
rdar://78102953

Reviewed by Tim Horton.

Source/WebKit:

Refactor text input logic on watchOS such that we're able to present the new ("modern") UI for scribble text
input on watchOS 8, rather than legacy (in-process) scribble UI. Overall, this patch removes
WKQuickboardListViewController altogether. This had two subclasses: WKSelectMenuListViewController (used for
focused single and multiple select elements) and WKTextInputListViewController (used for text input types).
WKSelectMenuListViewController now inherits directly from PUICQuickboardListViewController, and
WKTextInputListViewController now inherits from PUICQuickboardMessageViewController; this inheritance from
PUICQuickboardMessageViewController instead of PUICQuickboardListViewController allows the
WKTextInputListViewController to show text suggestions using -setMessages: on
PUICQuickboardMessageViewController, instead of relying on custom WebKit code to insert text suggestions.

This means that we move the following pieces of functionality out of WKQuickboardListViewController, and into
either WKSelectMenuListViewController or WKTextInputListViewController:

Support for inserting and updating context views (i.e. the domain name header view in Quickboard) =>

WKTextInputListViewController.

Logic for determining whether or not we should show language selection UI => WKTextInputListViewController.

Support for laying out custom collection view cells in Quickboard => WKSelectMenuListViewController.

Platform/spi/watchos/PepperUICoreSPI.h:
SourcesCocoa.txt:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView createQuickboardTextInputContext]):
(-[WKContentView _createQuickboardController:]):

Refactor logic to create a PUICTextInputContext from the current focused element information out into a separate
helper method, -createQuickboardTextInputContext, and use it when both directly launching into
PUICQuickboardController and WKTextInputListViewController.

(canUseQuickboardControllerFor):

Remove a comment, now that we intend to continue using WKTextInputListViewController for non-keychain-AutoFill-
compatible text fields moving forward.

(-[WKContentView focusedFormControllerDidUpdateSuggestions:]):
(-[WKContentView allowsLanguageSelectionForListViewController:]):
(-[WKContentView textInputContextForListViewController:]):
(-[WKContentView textContentTypeForTesting]):
(-[WKContentView viewController:inputContextViewHeightForSize:]): Deleted.

Remove this delegate method, which was (effectively) unused since we just ask for
-inputContextViewForViewController: from the input delegate anyways.

(-[WKContentView allowsLanguageSelectionMenuForListViewController:]): Deleted.

Rename this to -allowsLanguageSelectionForListViewController:.

(-[WKContentView textContentTypeForListViewController:]): Deleted.

Replace this with -textInputContextForListViewController:, which returns a whole PUICTextInputContext instead
of just a text content type.

(-[WKContentView textSuggestionsForListViewController:]): Deleted.
(-[WKContentView listViewController:didSelectTextSuggestion:]): Deleted.

Remove several delegate methods that are no longer needed.

UIProcess/ios/forms/WKDatePickerViewController.h:
UIProcess/ios/forms/WKDatePickerViewController.mm:

(-[WKDatePickerViewController viewWillAppear:]):

Remove some (defunct) logic for overriding the status bar when showing Quickboard input view controllers. This
status bar mechanism (which was previously used to show label text for form controls) hasn't worked since
watchOS 6, and we need to implement this in a way that doesn't use PUICStatusBarGlobalContextViewAssertion.

UIProcess/ios/forms/WKQuickboardListViewController.mm: Removed.
UIProcess/ios/forms/WKQuickboardViewControllerDelegate.h: Renamed from Source/WebKit/UIProcess/ios/forms/WKQuickboardListViewController.h.
UIProcess/ios/forms/WKSelectMenuListViewController.h:
UIProcess/ios/forms/WKSelectMenuListViewController.mm:

(-[WKSelectMenuItemCell topToLabelBaselineSpecValue]):
(-[WKSelectMenuItemCell baselineToBottomSpecValue]):
(-[WKSelectMenuCollectionViewItemCell topToLabelBaselineSpecValue]):
(-[WKSelectMenuCollectionViewItemCell baselineToBottomSpecValue]):
(-[WKSelectMenuListViewController initWithDelegate:]):

See above comment for more details.

UIProcess/ios/forms/WKTextInputListViewController.h:
UIProcess/ios/forms/WKTextInputListViewController.mm:

(-[WKTextInputListViewController initWithDelegate:]):
(-[WKTextInputListViewController reloadContextView]):
(-[WKTextInputListViewController updateContextViewIfNeeded]):

Move logic for showing and updating the context view out of WKQuickboardListViewController, and into
WKTextInputListViewController. See comments above.

(-[WKTextInputListViewController requiresNumericInput]):
(-[WKTextInputListViewController additionalTrayButtons]):
(-[WKTextInputListViewController updateTextSuggestions:]):
(-[WKTextInputListViewController headerContentViewHeight]):
(-[WKTextInputListViewController headerContentView]):
(-[WKTextInputListViewController shouldShowLanguageButton]):
(-[WKTextInputListViewController supportsDictationInput]):
(-[WKTextInputListViewController shouldShowTrayView]):
(-[WKTextInputListViewController shouldShowTextField]):

Override this and return YES for text input types that don't require an additional numeric input tray button.
This allows PUICQuickboardMessageViewController to show a native text field containing the input text inside
quickboard, which (when tapped) presents modern text input UI.

Since showing the text field is apparently mutually exclusive to showing a tray view, we additionally override
-shouldShowTrayView and return NO for non-numeric text inputs.

(-[WKTextInputListViewController supportsArouetInput]):
(-[WKTextInputListViewController viewDidLoad]): Deleted.
(-[WKTextInputListViewController willPresentArouetViewController:]): Deleted.

There's no need to override this delegate method anymore, since the PUICTextInputContext's -initialText is
sufficient to ensure that the scribble text input UI is prepopulated with the focused text field's initial text
content.

(-[WKTextInputListViewController reloadTextSuggestions]): Deleted.

Rename this to -updateTextSuggestions:, and make it take a list of UITextSuggestions. This makes the code a
bit easier to follow and allows us to remove the -textSuggestionsForListViewController: delegate method.

(-[WKTextInputListViewController didSelectListItemAtIndexPath:]): Deleted.
(-[WKTextInputListViewController didSelectListItem:]): Deleted.
(-[WKTextInputListViewController _didSelectListItem:]): Deleted.
(-[WKTextInputListViewController numberOfListItems]): Deleted.
(-[WKTextInputListViewController heightForListItem:width:]): Deleted.
(-[WKTextInputListViewController cellForListItem:]): Deleted.
(-[WKTextInputListViewController listItemCellReuseIdentifier]): Deleted.
(-[WKTextInputListViewController listItemCellClass]): Deleted.
(-[WKTextInputListViewController itemCellForListItem:forIndexPath:]): Deleted.

Remove all this code for showing text suggestions in Quickboard UI. Since WKTextInputListViewController is now a
subclass of PUICQuickboardMessageViewController, we can now simply use the -messages property of to populate
quickboard with text suggestions.

UIProcess/ios/forms/WKTimePickerViewController.h:
WebKit.xcodeproj/project.pbxproj:

WebKitLibraries:

WebKitPrivateFrameworkStubs/watchos/7/PepperUICore.framework/PepperUICore.tbd:
WebKitPrivateFrameworkStubs/watchos/8/PepperUICore.framework/PepperUICore.tbd:

3:04 PM Changeset in webkit [278956] by Ruben Turcios

8 edits in branches/safari-612.1.18.1-branch/Source

Versioning.

WebKit-7612.1.18.1.3

2:34 PM Changeset in webkit [278955] by Jonathan Bedard

4 edits in trunk/Tools

[webkitscmpy] Cache more Git commands
https://bugs.webkit.org/show_bug.cgi?id=227082
<rdar://problem/79405244>

Reviewed by Stephanie Lewis.

Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.init): Reset branch cache.
(Git.default_branch): Memoize default_branch call.
(Git.branch): Prefer branch cache.
(Git.checkout): Reset branch cache.

1:51 PM Changeset in webkit [278954] by commit-queue@webkit.org

61 edits
58 copies
21 adds in trunk/LayoutTests

Allow WebXR tests to be run on Mac
https://bugs.webkit.org/show_bug.cgi?id=227054

Patch by Ada Chan <ada.chan@apple.com> on 2021-06-16
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Updated expected results.

web-platform-tests/webxr/events_input_source_recreation.https-expected.txt:
web-platform-tests/webxr/events_input_sources_change.https-expected.txt:
web-platform-tests/webxr/events_referenceSpace_reset_immersive.https-expected.txt: Added.
web-platform-tests/webxr/events_referenceSpace_reset_inline.https-expected.txt: Added.
web-platform-tests/webxr/events_session_select.https-expected.txt:
web-platform-tests/webxr/events_session_select_subframe.https-expected.txt:
web-platform-tests/webxr/events_session_squeeze.https-expected.txt:
web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt:
web-platform-tests/webxr/getInputPose_handedness.https-expected.txt:
web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt:
web-platform-tests/webxr/navigator_xr_sameObject.https-expected.txt:
web-platform-tests/webxr/render_state_update.https-expected.txt:
web-platform-tests/webxr/render_state_vertical_fov_immersive.https-expected.txt:
web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt:
web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt:
web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https-expected.txt:
web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt:
web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https-expected.txt:
web-platform-tests/webxr/xrDevice_disconnect_ends.https-expected.txt: Added.
web-platform-tests/webxr/xrDevice_requestSession_immersive.https-expected.txt:
web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https-expected.txt:
web-platform-tests/webxr/xrFrame_getPose.https-expected.txt:
web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https-expected.txt:
web-platform-tests/webxr/xrFrame_getViewerPose_getPose_identities.https-expected.txt: Added.
web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt:
web-platform-tests/webxr/xrFrame_session_sameObject.https-expected.txt:
web-platform-tests/webxr/xrInputSource_add_remove.https-expected.txt:
web-platform-tests/webxr/xrInputSource_emulatedPosition.https-expected.txt:
web-platform-tests/webxr/xrInputSource_profiles.https-expected.txt:
web-platform-tests/webxr/xrInputSource_sameObject.https-expected.txt:
web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt:
web-platform-tests/webxr/xrReferenceSpace_originOffset.https-expected.txt:
web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt:
web-platform-tests/webxr/xrReferenceSpace_originOffset_viewer.https-expected.txt:
web-platform-tests/webxr/xrReferenceSpace_relationships.https-expected.txt:
web-platform-tests/webxr/xrRigidTransform_constructor.https-expected.txt:
web-platform-tests/webxr/xrRigidTransform_inverse.https-expected.txt:
web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt:
web-platform-tests/webxr/xrSession_cancelAnimationFrame.https-expected.txt:
web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https-expected.txt:
web-platform-tests/webxr/xrSession_end.https-expected.txt:
web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt:
web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https-expected.txt:
web-platform-tests/webxr/xrSession_requestAnimationFrame_data_valid.https-expected.txt:
web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerPose.https-expected.txt:
web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https-expected.txt:
web-platform-tests/webxr/xrSession_requestReferenceSpace.https-expected.txt:
web-platform-tests/webxr/xrSession_requestSessionDuringEnd.https-expected.txt: Added.
web-platform-tests/webxr/xrSession_sameObject.https-expected.txt:
web-platform-tests/webxr/xrSession_viewer_referenceSpace.https-expected.txt:
web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt:
web-platform-tests/webxr/xrView_eyes.https-expected.txt:
web-platform-tests/webxr/xrView_match.https-expected.txt:
web-platform-tests/webxr/xrView_oneframeupdate.https-expected.txt:
web-platform-tests/webxr/xrView_sameObject.https-expected.txt:
web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt:
web-platform-tests/webxr/xrViewport_valid.https-expected.txt:
web-platform-tests/webxr/xrWebGLLayer_constructor.https-expected.txt:
web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https-expected.txt:
web-platform-tests/webxr/xrWebGLLayer_viewports.https-expected.txt:
web-platform-tests/webxr/xr_viewport_scale.https-expected.txt: Added.

LayoutTests:

Updated expected results and TestExpectations.
Copied old versions of expected results that were in imported/w3c/web-platform-tests/webxr
to platform/wpe/imported/w3c/web-platform-tests/webxr so test runs on wpe should not be
affected.

TestExpectations:
http/wpt/webxr/xrSession_end_device_reports_shutdown.https-expected.txt:
http/wpt/webxr/xrSession_ended_by_system.https-expected.txt:
http/wpt/webxr/xrSession_reject_multiple_end.https-expected.txt:
platform/mac/imported/w3c/web-platform-tests/webxr/getInputPose_pointer.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/webxr_feature_policy.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace_features.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/xrSession_visibilityState.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_scale.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/webxr/xr_viewport_scale.https-expected.txt: Added.
platform/wpe/http/wpt/webxr/xrSession_end_device_reports_shutdown.https-expected.txt: Copied from LayoutTests/http/wpt/webxr/xrSession_end_device_reports_shutdown.https-expected.txt.
platform/wpe/http/wpt/webxr/xrSession_ended_by_system.https-expected.txt: Copied from LayoutTests/http/wpt/webxr/xrSession_ended_by_system.https-expected.txt.
platform/wpe/http/wpt/webxr/xrSession_reject_multiple_end.https-expected.txt: Copied from LayoutTests/http/wpt/webxr/xrSession_reject_multiple_end.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/events_input_source_recreation.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_input_source_recreation.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/events_input_sources_change.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_input_sources_change.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/events_referenceSpace_reset_immersive.https-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/webxr/events_referenceSpace_reset_inline.https-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/webxr/events_session_select.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_session_select.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/events_session_select_subframe.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_session_select_subframe.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/events_session_squeeze.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_session_squeeze.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/getInputPose_handedness.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/getInputPose_handedness.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/render_state_update.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/render_state_update.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_immersive.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_immersive.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrDevice_disconnect_ends.https-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_getPose.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_getPose.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_session_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_session_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_add_remove.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_add_remove.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_emulatedPosition.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_emulatedPosition.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_profiles.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_profiles.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset_viewer.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset_viewer.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_relationships.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_relationships.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrRigidTransform_constructor.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_constructor.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrRigidTransform_inverse.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_inverse.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_end.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_end.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_data_valid.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_data_valid.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerPose.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerPose.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_viewer_referenceSpace.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_viewer_referenceSpace.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_eyes.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_eyes.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_match.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_match.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_oneframeupdate.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_oneframeupdate.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrViewport_valid.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrViewport_valid.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_viewports.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_viewports.https-expected.txt.

1:44 PM Changeset in webkit [278953] by Chris Dumez

17 edits in trunk/Source/WebKit

Enable release logging in the network process for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=227087

Reviewed by Geoffrey Garen.

Enable release logging in the network process for ephemeral sessions, to facilitate debugging. No domains
or other sensitive information is logged by WebKit.

NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::cancel):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):

NetworkProcess/Downloads/Download.h:
NetworkProcess/Downloads/DownloadMonitor.cpp:

(WebKit::DownloadMonitor::applicationWillEnterForeground):
(WebKit::DownloadMonitor::applicationDidEnterBackground):
(WebKit::DownloadMonitor::timerFired):

NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::startPreflight):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didReceiveResponse):
(WebKit::NetworkCORSPreflightChecker::didReceiveData):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):
(WebKit::NetworkCORSPreflightChecker::wasBlockedByRestrictions):

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::hasUploadStateChanged):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::resolveBlobReferences):
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
(WebKit::NetworkConnectionToWebProcess::preconnectTo):
(WebKit::NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded):

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::continueCheckingRequest):
(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::retrieveCacheEntryInternal):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::convertToDownload):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::didBlockAuthenticationChallenge):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):
(WebKit::NetworkResourceLoader::restartNetworkLoad):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
(WebKit::NetworkResourceLoader::didReceiveMainResourceResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
(WebKit::NetworkResourceLoader::validateCacheEntry):
(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):
(WebKit::NetworkResourceLoader::logSlowCacheRetrieveIfNeeded):
(WebKit::NetworkResourceLoader::startWithServiceWorker):
(WebKit::NetworkResourceLoader::serviceWorkerDidNotHandle):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponse):
(WebKit::PingLoad::didReceiveData):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::wasBlockedByRestrictions):
(WebKit::PingLoad::timeoutTimerFired):

NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::~ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::start):
(WebKit::ServiceWorkerFetchTask::contextClosed):
(WebKit::ServiceWorkerFetchTask::startFetch):
(WebKit::ServiceWorkerFetchTask::didReceiveRedirectResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveResponse):
(WebKit::ServiceWorkerFetchTask::didFinish):
(WebKit::ServiceWorkerFetchTask::didFail):
(WebKit::ServiceWorkerFetchTask::didNotHandle):
(WebKit::ServiceWorkerFetchTask::cannotHandle):
(WebKit::ServiceWorkerFetchTask::cancelFromClient):
(WebKit::ServiceWorkerFetchTask::continueDidReceiveFetchResponse):
(WebKit::ServiceWorkerFetchTask::continueFetchTaskWith):
(WebKit::ServiceWorkerFetchTask::timeoutTimerFired):
(WebKit::ServiceWorkerFetchTask::softUpdateIfNeeded):

NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::createFetchTask):
(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::scheduleJobInServer):
(WebKit::WebSWServerConnection::scheduleUnregisterJobInServer):

NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::retrieveRecords):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):

NetworkProcess/webrtc/NetworkMDNSRegister.cpp:

(WebKit::registerMDNSNameCallback):
(WebKit::NetworkMDNSRegister::registerMDNSName):

NetworkProcess/webrtc/NetworkRTCMonitor.cpp:

(WebKit::NetworkRTCMonitor::startUpdatingIfNeeded):
(WebKit::NetworkRTCMonitor::stopUpdating):
(WebKit::NetworkRTCMonitor::onNetworksChanged):

NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::NetworkRTCProvider::close):
(WebKit::NetworkRTCProvider::createSocket):

NetworkProcess/webrtc/NetworkRTCProvider.h:

1:12 PM Changeset in webkit [278952] by Brent Fulgham

9 edits in trunk/Source/WebKit

Sandbox profiles need to allow loading from /usr/appleinternal/lib on internal builds
https://bugs.webkit.org/show_bug.cgi?id=227079
<rdar://problem/79390957>

Reviewed by Per Arne Vollan.

We allow the specific directory "/usr/appleinternal/lib/sanitizers", but we actually need
access to "/usr/appleinternal/lib" in certain development environments.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

12:58 PM Changeset in webkit [278951] by Chris Dumez

5 edits
2 adds in trunk

FileReader.readAsArrayBuffer misses checking for the type of blob param
https://bugs.webkit.org/show_bug.cgi?id=226640
<rdar://problem/79193198>

Reviewed by Youenn Fablet.

Source/WebCore:

The Blob parameter to FileReader.readAsArrayBuffer / readAsBinaryString / readAsText / readAsDataURL
should not be nullable as per the specification:

https://w3c.github.io/FileAPI/#APIASynch

This patch aligns us with the specification and with the behavior of both Blink and Gecko.

Test: fast/files/filereader-invalid-blob.html

fileapi/FileReader.cpp:

(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):

fileapi/FileReader.h:
fileapi/FileReader.idl:

LayoutTests:

Add layout test coverage. I have verified that this test is passing in Firefox and Chrome as well.

fast/files/filereader-invalid-blob-expected.txt: Added.
fast/files/filereader-invalid-blob.html: Added.

12:14 PM Changeset in webkit [278950] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

Add Air opcode sub32/64(Reg, Imm, Reg) form for ARM64 and select this instruction in Air
https://bugs.webkit.org/show_bug.cgi?id=226937

Patch by Yijia Huang <Yijia Huang> on 2021-06-16
Reviewed by Yusuke Suzuki.

Previously, Air arm64 sub32/64 utilize sub(Imm, Tmp) at optlevel = 0 and
add(Tmp, -Imm) at optlevel > 0 to perform and optimize sub(Tmp, Imm, Tmp).
The issue with this is that we were not eliding redundant operations.

For example:
B3 IR
@0 = Trunc(ArgumentReg(0))
@1 = Const
@2 = Sub(@0, @1)
@3 = Return(@2)

Old optimized Air IR
OptLevel = 0
Move %x0, %tmp1, @0
Move $Const, %tmp2, @1
Move %tmp1, %tmp0, @2 Redundant
Sub $Const, %tmp0, @2
Move %tmp0, %x0, @3
Ret32 %x0, @3

To remove those redundant instructions, Air arm64 sub32/64 opcode should
indicate a new form sub(Tmp, Imm, Tmp).

New optimized Air IR
OptLevel = 0
Move %x0, %tmp1, @0
Move $Const, %tmp2, @1
Sub %tmp1, $Const, %tmp0, @2
Move %tmp0, %x0, @3
Ret32 %x0, @3

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::sub32):
(JSC::MacroAssemblerARM64::sub64):

assembler/testmasm.cpp:

(JSC::testSub32Args):
(JSC::testSub32Imm):
(JSC::testSub32ArgImm):
(JSC::testSub64Imm32):
(JSC::testSub64ArgImm32):
(JSC::testSub64Imm64):
(JSC::testSub64ArgImm64):

b3/B3ReduceStrength.cpp:
b3/air/AirOpcode.opcodes:
b3/testb3.h:
b3/testb3_2.cpp:

(testSubArgs32ZeroExtend):

b3/testb3_3.cpp:

(addArgTests):

12:12 PM Changeset in webkit [278949] by Amir Mark Jr.

2 edits in trunk/LayoutTests

[EWS MacOS WK1] imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-snap-003.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=227085

Unreviewed test gardening.

Updating test expectations to clear EWS warning.

platform/mac-wk1/TestExpectations:

12:12 PM Changeset in webkit [278948] by sihui_liu@apple.com

2 edits in trunk/Source/WebCore

Add lock for static cursorMap in MemoryCursor
https://bugs.webkit.org/show_bug.cgi?id=226806

Reviewed by Chris Dumez.

As cursorMap can be accessed from multiple WorkQueues.

Modules/indexeddb/server/MemoryCursor.cpp:

(WebCore::IDBServer::MemoryCursor::MemoryCursor):
(WebCore::IDBServer::MemoryCursor::~MemoryCursor):
(WebCore::IDBServer::MemoryCursor::cursorForIdentifier):

12:01 PM Changeset in webkit [278947] by timothy@apple.com

3 edits in trunk/Source/WebCore

REGRESSION (r273329): Logging of most errors like CSP and promise rejections fail logging to the system console
https://bugs.webkit.org/show_bug.cgi?id=227080

Unreviewed, reverting r273329.

dom/Document.cpp:

(WebCore::Document::didLogMessage):

page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::addMessage):

11:44 AM Changeset in webkit [278946] by Russell Epstein

1 edit in branches/safari-611-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicy.mm

Unreviewed API Test fix.

Fix API test breakage after changes in https://trac.webkit.org/changeset/275702/webkit

11:34 AM Changeset in webkit [278945] by rmorisset@apple.com

7 edits in trunk/Source/JavaScriptCore

Drop the FTL(DFG) graph after lowering to B3
https://bugs.webkit.org/show_bug.cgi?id=226556

Reviewed by Phil Pizlo.

This patch originally landed as r278463, was reverted in r278463.
I believe that the bug for which it was reverted actually comes from r278371, which was also reverted at the same time. So I am now relanding this.

The challenge in this patch was dealing with all of the Patchpoints created by FTLLowerDFGToB3: they get a lambda at that time, which they execute at the end of Air, and many of these lambdas were capturing a pointer to some parts of the DFG graph and reading through it when being executed.
In all cases but one it was easily fixed: they were only reading a few bits from a given node, so I just read these bits in FTLLowerDFGToB3, and captured them (by value) instead of the pointer to the node.
The exception was compileCallOrConstructVarargsSpread(): its patchpoint generator was walking through the graph, flattening a tree of PhantomSpread/PhantomNewArrayWithSpread/PhantomNewArrayBuffer/PhantomCreateRest, emitting some code along the way.
We now do this flattening of the tree in FTLLowerDFGToB3, store just enough information to later emit the required code in a vector, and capture that vector in the lambda (through a move capture, which is allowed since C++14). See struct VarargsSpreadArgumentToEmit for the information that we need to store in that vector.

I tested this change by completing a full run of JetStream2 with ASAN.
I also ran the stress tests with "spread" in their name in Debug mode.

b3/B3SparseCollection.h:

(JSC::B3::SparseCollection::clearAll):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::freeDFGIRAfterLowering):

dfg/DFGGraph.h:
ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileUnaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::getPrivateName):
(JSC::FTL::DFG::LowerDFGToB3::compilePrivateBrandAccess):
(JSC::FTL::DFG::LowerDFGToB3::cachedPutById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDelBy):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::VarargsSpreadArgumentToEmit::VarargsSpreadArgumentToEmit):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::compileInById):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOf):
(JSC::FTL::DFG::LowerDFGToB3::getById):
(JSC::FTL::DFG::LowerDFGToB3::getByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::emitBinarySnippet):
(JSC::FTL::DFG::LowerDFGToB3::emitBinaryBitOpSnippet):
(JSC::FTL::DFG::LowerDFGToB3::emitRightShiftSnippet):
(JSC::FTL::DFG::LowerDFGToB3::crash):

11:26 AM Changeset in webkit [278944] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

WebGL2 clientWaitSync does not flush when requested
https://bugs.webkit.org/show_bug.cgi?id=227064

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-06-16
Reviewed by Kenneth Russell.

Flush when clientWaitSync is called with SYNC_FLUSH_COMMANDS_BIT.
Theoretically the sync object might not be inserted to the command
buffer unless the wait flushes or client ensures flush by other
means.

No new tests, hard to observe externally.

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::clientWaitSync):

11:10 AM Changeset in webkit [278943] by Chris Dumez

2 edits in trunk/Source/WebCore

[Hardening] Better protect against overflows in the WebAudioBufferList constructor
https://bugs.webkit.org/show_bug.cgi?id=227077
<rdar://problem/78222665>

Reviewed by Geoffrey Garen.

Make sure sizeof(AudioBuffer) * std::max(1U, bufferCount) doesn't overflow.

platform/audio/cocoa/WebAudioBufferList.cpp:

(WebCore::WebAudioBufferList::WebAudioBufferList):

11:08 AM Changeset in webkit [278942] by fpizlo@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

RegisterSet should be smaller
https://bugs.webkit.org/show_bug.cgi?id=227078

Reviewed by Geoff Garen.

Previously, every RegisterSet would have an extra 64-bit word in it just to hold state
relevant to hashtable keys.

But RegisterSet is almost never used as a hashtable key.

This patch moves the hashtable key support into a subclass, HashableRegisterSet. That class
ends up only being used in one place.

On ARM64, this makes RegisterSet use 64 bits instead of 128 bits.

On X86_64, this makes RegisterSet use 32 bits instead of 64 bits.

JavaScriptCore.xcodeproj/project.pbxproj:
ftl/FTLSlowPathCallKey.h:

(JSC::FTL::SlowPathCallKey::SlowPathCallKey):

jit/HashableRegisterSet.h: Added.

(JSC::HashableRegisterSet::HashableRegisterSet):
(JSC::HashableRegisterSet::isEmptyValue const):
(JSC::HashableRegisterSet::isDeletedValue const):
(JSC::RegisterSetHash::hash):
(JSC::RegisterSetHash::equal):

jit/RegisterSet.h:

(): Deleted.
(JSC::RegisterSet::isEmptyValue const): Deleted.
(JSC::RegisterSet::isDeletedValue const): Deleted.
(JSC::RegisterSetHash::hash): Deleted.
(JSC::RegisterSetHash::equal): Deleted.

11:00 AM Changeset in webkit [278941] by achristensen@apple.com

13 edits
3 deletes in trunk/Source/WebKit

Clean up WebCookieManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=227074

Reviewed by Brady Eidson.

Remove dead code. WKCookieManagerSetClient is deprecated and doesn't do anything, so we don't need a client here.
Use smart pointers instead of raw pointers to be on the safe side.

Shared/API/APIObject.h:
Sources.txt:
SourcesCocoa.txt:
UIProcess/API/APIHTTPCookieStore.h:
UIProcess/API/APIInspectorExtension.cpp:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::registerObserver):
(WebKit::WebCookieManagerProxy::unregisterObserver):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
(WebKit::WebCookieManagerProxy::initializeClient): Deleted.
(WebKit::WebCookieManagerProxy::setCookieObserverCallback): Deleted.

UIProcess/WebCookieManagerProxy.h:

(WebKit::WebCookieManagerProxy::create): Deleted.

UIProcess/WebCookieManagerProxy.messages.in:
UIProcess/WebCookieManagerProxyClient.cpp: Removed.
UIProcess/WebCookieManagerProxyClient.h: Removed.
UIProcess/mac/WebCookieManagerProxyMac.mm: Removed.
WebKit.xcodeproj/project.pbxproj:

10:57 AM Changeset in webkit [278940] by Russell Epstein

2 edits in branches/safari-612.1.19-branch/Source/ThirdParty/libwebrtc

Cherry-pick r278886. rdar://problem/79405770

REGRESSION: [ BigSur iOS wk1 Debug ] imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=226928
<rdar://problem/79205526>

Reviewed by Eric Carlson.

Source/webrtc/rtc_base/task_queue_stdlib.cc: thread_ is created in TaskQueueStdlib constructor before other members pending_queue_ or delayed_queue_. It might happen that thread_ will start executing its callback which will read delayed_queue_ before it is initialized by TaskQueueStdlib constructor. Update to create thread_ before all other members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:40 AM Changeset in webkit [278939] by Amir Mark Jr.

2 edits in trunk/LayoutTests

Fix test expectations for plugin tests on arm64
https://bugs.webkit.org/show_bug.cgi?id=226783

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

10:16 AM Changeset in webkit [278938] by Ryan Haddad

2 edits in trunk/LayoutTests

REGRESSION (r274461): [macOS wk1] fast/repaint/canvas-object-fit.html is flakey text failing
https://bugs.webkit.org/show_bug.cgi?id=223283

Unreviewed test gardening.

platform/mac-wk1/TestExpectations: Re-add a flaky expectation.

9:09 AM Changeset in webkit [278937] by Tadeu Zagallo

4 edits
1 add in trunk

AssemblyHelpers should save/restore callee save FPRs
https://bugs.webkit.org/show_bug.cgi?id=227052
<rdar://77080162>

Reviewed by Mark Lam.

JSTests:

stress/callee-save-fpr.js: Added.

(_f):
(_g):
(_h):
(_i):
(assertEqual):

Source/JavaScriptCore:

We have 3 functions in AssemblyHelpers to save and restore callee save registers that were filtering
out any FPRs. This is an issue since we do have callee save FPRs in arm64 and these functions can be
called from the FTL, and FTL uses those callee saves. The test case shows how that's an issue with tail
calls on FTL: the callee saves are correctly stored in the prologue and restored in the epilogue, but
when emitting a tail call we use AssemblyHelpers::emitRestoreCalleeSaves to restore the callee saves,
which doesn't restore FPRs. This results in the callee save FPRs being trashed. To fix this we just need
to stop filtering out the FPRs, if they are listed as used by the code block they should be saved/restored
accordingly. I also changed DFGOSREntry to stop filtering out the callee save FPRs and instead assert
there aren't any, since they aren't currently used in the DFG, but it could help avoid the same issue in
the future.

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitSaveOrCopyCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):

8:41 AM Changeset in webkit [278936] by aboya@igalia.com

4 edits in trunk

[WTF] DataMutex: Assert on double locking on the same thread
https://bugs.webkit.org/show_bug.cgi?id=227069

Reviewed by Xabier Rodriguez-Calvar.

Source/WTF:

DataMutex used to use OwnerAwareLock to track what thread is holding
the mutex and emit assertion errors if a thread is found attempting to
lock a mutex held by that same thread. This turns deadlocks into
runtime errors.

OwnerAwareLock was removed when DataMutex got clang thread safety
annotations. This patch reintroduces the same logic, while keeping
thread-safety annotations.

This fixes WTF_DataMutex.DoubleLockDeathTest, which tested this
functionality and was previously regressed.

wtf/DataMutex.h:

Tools:

Update expectations to include the fixed test.

TestWebKitAPI/glib/TestExpectations.json:

8:16 AM Changeset in webkit [278935] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GStreamer] gst_element_get_request_pad deprecated in 1.20
https://bugs.webkit.org/show_bug.cgi?id=226974

Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-16
Reviewed by Xabier Rodriguez-Calvar.

In GStreamer 1.20 gst_element_get_request_pad() was renamed to gst_element_request_pad_simple(),
so create an alias for older versions.

platform/graphics/gstreamer/GStreamerAudioMixer.cpp:

(WebCore::GStreamerAudioMixer::registerProducer):

platform/graphics/gstreamer/GStreamerCommon.h:

8:14 AM Changeset in webkit [278934] by achristensen@apple.com

6 edits in trunk/Source/WebKit

Clean up API::HTTPCookieStore
https://bugs.webkit.org/show_bug.cgi?id=227058

Reviewed by Anders Carlsson.

This removes code that has been unused since r267763.
I also use smart pointers instead of raw pointers just to be on the safe side.

UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::cookiesDidChange):
(API::HTTPCookieStore::cookieManagerDestroyed): Deleted.

UIProcess/API/APIHTTPCookieStore.h:
UIProcess/WebCookieManagerProxy.h:
UIProcess/WebProcessPool.cpp:

(WebKit::generateListenerIdentifier): Deleted.
(WebKit::processPoolCreationListenerFunctionMap): Deleted.
(WebKit::WebProcessPool::registerProcessPoolCreationListener): Deleted.
(WebKit::WebProcessPool::unregisterProcessPoolCreationListener): Deleted.
(WebKit::WebProcessPool::notifyThisWebProcessPoolWasCreated): Deleted.

UIProcess/WebProcessPool.h:

7:37 AM Changeset in webkit [278933] by ntim@apple.com

8 edits in trunk

Make CSS.supports() return false for internal CSS properties
https://bugs.webkit.org/show_bug.cgi?id=224930

Reviewed by Antti Koivisto.

Test: LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html

Examples that are now rejected:

CSS.supports("background-repeat-x: inherit")
CSS.supports("background-repeat-x", "inherit")
CSS.supports("background-repeat-y: inherit")
CSS.supports("background-repeat-y", "inherit")

Source/WebCore:

css/DOMCSSNamespace.cpp:

(WebCore::DOMCSSNamespace::supports):

css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeDeclaration):

LayoutTests:

fast/backgrounds/background-repeat-x-y-parse-expected.txt:
fast/backgrounds/background-repeat-x-y-parse.html:
fast/css/webkit-mask-crash-implicit-expected.txt:
fast/css/webkit-mask-crash-implicit.html:

7:27 AM Changeset in webkit [278932] by commit-queue@webkit.org

3 edits
2 adds in trunk

[MSE] Crash when getting audioTracks, videoTracks, textTracks of sourceBuffer after executing MediaSource::removeSourceBuffer()
https://bugs.webkit.org/show_bug.cgi?id=227018

Patch by Toshio Ogasawara <toshio.ogasawara@access-company.com> on 2021-06-16
Reviewed by Eric Carlson.

Source/WebCore:

Fixed not to refer to m_source when isRemoved() is true in SourceBuffer::videoTracks(),
SourceBuffer::audioTracks(), SourceBuffer::textTracks().

Test: media/media-source/media-source-get-tracks-crash.html

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::videoTracks):
(WebCore::SourceBuffer::audioTracks):
(WebCore::SourceBuffer::textTracks):

LayoutTests:

media/media-source/media-source-get-tracks-crash-expected.txt: Added.
media/media-source/media-source-get-tracks-crash.html: Added.

6:44 AM Changeset in webkit [278931] by Alan Bujtas

20 edits
4 adds in trunk

Content moves up when hovering over a link on Hacker News
https://bugs.webkit.org/show_bug.cgi?id=226852
<rdar://78537231>

Reviewed by Antti Koivisto.

Source/WebCore:

Legacy line layout integral-rounds the root inline box's vertical position and this integral position
gets propagated down to the descendant inline boxes when descendantsHaveSameLineHeightAndBaseline() is true.
See LegacyInlineFlowBox::addToLine and LegacyInlineFlowBox::placeBoxesInBlockDirection for more details.
This patch attempts to mirror this behavior in IFC.

Test: fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes.html

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns const):

LayoutTests:

fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes-expected.html: Added.
fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes.html: Added.

6:36 AM Changeset in webkit [278930] by commit-queue@webkit.org

3 edits
2 adds in trunk

Nullptr crash in positionInParentBeforeNode via InsertTextCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=226870

Patch by Frederic Wang <fwang@igalia.com> on 2021-06-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

deleteSelection call In InsertTextCommand::doApply() can make the endingSelection() orphan.
If that happens, exit early to avoid dereferencing a nullptr pointer later.
Test: fast/editing/insert-text-orphaned-summary-crash.html

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::doApply):

LayoutTests:

Add regression test.

fast/editing/insert-text-orphaned-summary-crash-expected.txt: Added.
fast/editing/insert-text-orphaned-summary-crash.html: Added.

4:52 AM Changeset in webkit [278929] by commit-queue@webkit.org

4 edits in trunk/Source

ANGLE Metal gl sync objects do not work in case of listener being needed
https://bugs.webkit.org/show_bug.cgi?id=227024

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-06-16
Reviewed by Per Arne Vollan.

Source/ThirdParty/ANGLE:

Add an assert to notice when MTLSharedEventListener instantiation
fails. Without this, the fence implementation would not signal
the completion until the timeout would pass.

src/libANGLE/renderer/metal/DisplayMtl.mm:

(rx::DisplayMtl::getOrCreateSharedEventListener):

Source/WebKit:

Make MTLSharedEventListener instantiatable by adding IOKit messages
39 and 40 to IOSurfaceRootUserClientMessageFilter.

The MTLSharedEventListener init would fail, and ANGLE would fail to
make the shared event signal the event listener. This would cause
all glClientWaitSync calls to wait the full timeout time.

No new tests, WebGL2 sync object implementation does not support
non-zero timeout values that would be needed to detect the failure.
Standalone test-cases would need the test runner being sandboxed,
which is not implemented currently.

WebProcess/com.apple.WebProcess.sb.in:

2:45 AM Changeset in webkit [278928] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r278846.
https://bugs.webkit.org/show_bug.cgi?id=227060

Speculative revert based on failure history of Speedometer2

Reverted changeset:

"Add Air opcode sub32/64(Reg, Imm, Reg) form for ARM64 and
select this instruction in Air"
https://bugs.webkit.org/show_bug.cgi?id=226937
https://trac.webkit.org/changeset/278846

1:56 AM Changeset in webkit [278927] by pvollan@apple.com

10 edits in trunk/Source

Update Media Accessibility preferences in the WebContent process from the UI process
https://bugs.webkit.org/show_bug.cgi?id=227031
<rdar://78614882>

Reviewed by Eric Carlson.

Due to stricter sandboxing in the WebContent process, Media Accessibility preferences should be updated from the UI process.
Source/WebCore:

The preferences for caption display mode and preferred caption languages are being cached, and the cached value will be used
if it has been set.

WebCore.xcodeproj/project.pbxproj:
page/CaptionUserPreferences.h:
page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::cachedCaptionDisplayMode):
(WebCore::cachedPreferredLanguages):
(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode const):
(WebCore::CaptionUserPreferencesMediaAF::platformCaptionDisplayMode):
(WebCore::CaptionUserPreferencesMediaAF::setCachedCaptionDisplayMode):
(WebCore::CaptionUserPreferencesMediaAF::preferredLanguages const):
(WebCore::CaptionUserPreferencesMediaAF::platformPreferredLanguages):
(WebCore::CaptionUserPreferencesMediaAF::setCachedPreferredLanguages):

page/CaptionUserPreferencesMediaAF.h:

Source/WebKit:

The preferences for caption display mode and preferred caption languages will be sent to the WebContent process on process
startup and when the preference has been changed.

Shared/AccessibilityPreferences.cpp:

(IPC::ArgumentCoder<WebKit::AccessibilityPreferences>::encode):
(IPC::ArgumentCoder<WebKit::AccessibilityPreferences>::decode):

Shared/AccessibilityPreferences.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::accessibilityPreferences):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::accessibilityPreferencesDidChange):

1:40 AM Changeset in webkit [278926] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE Metal AutoObjCPtr == nullptr comparison is inverted
https://bugs.webkit.org/show_bug.cgi?id=227026

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-06-16
Reviewed by Anders Carlsson.

Make it more correct and add != nullptr variant for
consistency.

Use std::nullptr_t instead of const std::nullptr_t &
in all functions for consistency.

src/libANGLE/renderer/metal/mtl_common.h:

(rx::mtl::AutoObjCPtr::operator== const):
(rx::mtl::AutoObjCPtr::operator!= const):

1:15 AM Changeset in webkit [278925] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] clang analysis: Unlocked access in ImageDecoderGStreamer.cpp
https://bugs.webkit.org/show_bug.cgi?id=226495

Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-16
Reviewed by Adrian Perez de Castro.

Remove unlocked access to the the m_messageDispatched instance variable. Also there is no
need to wait on the condition if the dispatching happens synchronously in the current
thread. No need to notify the condition either before dispatching, the only call to wait()
is after the asynchronous dispatch has been scheduled.

platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::InnerDecoder::preparePipeline):

1:11 AM Changeset in webkit [278924] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening, add some new Timing-Allow-Origin failures
https://bugs.webkit.org/show_bug.cgi?id=227008

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-06-16

platform/glib/TestExpectations:

12:37 AM Changeset in webkit [278923] by Martin Robinson

34 edits in trunk/Source

Replace invalidSnapOffsetIndex with std::optional<unsigned>
https://bugs.webkit.org/show_bug.cgi?id=226654

Reviewed by Simon Fraser.

Use std::optional<unsigned> in order to represent the situation
where we do not have a snap point selected rather than UINT_MAX.

Source/WebCore:

No new tests. This should not change behavior.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setActiveScrollSnapIndices):

page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::indicesOfNearestSnapOffsets): Return a std::pair instead of splitting the
return values into the argument list.
(WebCore::closestSnapOffsetWithInfoAndAxis):
(WebCore::LayoutScrollSnapOffsetsInfo::closestSnapOffset const):
(WebCore::FloatScrollSnapOffsetsInfo::closestSnapOffset const):

page/scrolling/ScrollSnapOffsetsInfo.h:
page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::setCurrentHorizontalSnapPointIndex):
(WebCore::ScrollingStateScrollingNode::setCurrentVerticalSnapPointIndex):
(WebCore::ScrollingStateScrollingNode::dumpProperties const):

page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::currentHorizontalSnapPointIndex const):
(WebCore::ScrollingStateScrollingNode::currentVerticalSnapPointIndex const):

page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::setActiveScrollSnapIndices):

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::dumpProperties const):

page/scrolling/ScrollingTreeScrollingNode.h: Move some methods into the

source file to satisfy the style checker. WEBCORE_EXPORT is applied to the
entire class declaration.

page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::currentSnapPointIndicesDidChange):
(WebCore::ThreadedScrollingTree::setActiveScrollSnapIndices):

page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::activeScrollSnapIndexForAxis const):

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::activeScrollSnapIndexForAxis const):
(WebCore::ScrollAnimator::setActiveScrollSnapIndexForAxis):

platform/ScrollAnimator.h:
platform/ScrollController.cpp:

(WebCore::ScrollController::activeScrollSnapIndexForAxis const):
(WebCore::ScrollController::setActiveScrollSnapIndexForAxis): When there is no new
snap index, we need to actively change the value to std::nullopt. This wasn't
necessary because ScrollableArea was covering up this case in the past as a side-effect.
(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset):
(WebCore::ScrollController::resnapAfterLayout): Also resnap if the snapped index is
greater than the current one. This case was being covered up by a side-effect in
ScrollableArea.

platform/ScrollController.h:
platform/ScrollSnapAnimatorState.cpp:

(WebCore::ScrollSnapAnimatorState::setupAnimationForState):
(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset const): Return a std::pair
instead of splitting the output values into the argument list.

platform/ScrollSnapAnimatorState.h:

(WebCore::ScrollSnapAnimatorState::activeSnapIndexForAxis const):
(WebCore::ScrollSnapAnimatorState::setActiveSnapIndexForAxis):

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::currentHorizontalSnapPointIndex const):
(WebCore::ScrollableArea::currentVerticalSnapPointIndex const):
(WebCore::ScrollableArea::setCurrentHorizontalSnapPointIndex):
(WebCore::ScrollableArea::setCurrentVerticalSnapPointIndex):
(WebCore::ScrollableArea::resnapAfterLayout):

platform/ScrollableArea.h:

Source/WebKit:

Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::decode):

UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::currentSnapPointIndicesDidChange):

UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::currentSnapPointIndicesDidChange):

UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::adjustTargetContentOffsetForSnapping):
(WebKit::RemoteScrollingCoordinatorProxy::shouldSnapForMainFrameScrolling const):

UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::currentSnapPointIndicesDidChange const):

Context Navigation

Timeline

Jun 17, 2021:

Jun 16, 2021:

Download in other formats: