Timeline

Jun 26, 2021:

10:42 PM Changeset in webkit [279311] by jh718.park@samsung.com

• 3 edits in trunk/Source/WebCore

Unreviewed. Remove the build warnings below since r279050.
warning: redundant move in return statement [-Wredundant-move]

No new tests, no new behavioral changes.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeCounterStyleAdditiveSymbols):

• css/parser/CSSPropertyParserWorkerSafe.cpp:

(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI):

7:06 PM Changeset in webkit [279310] by Wenson Hsieh

• 4 edits in trunk/Source/WebKit

[iOS] Safari sometimes hangs under sync IPC in -[WKWebView _setSuppressSoftwareKeyboard:]
​https://bugs.webkit.org/show_bug.cgi?id=227424
rdar://79745385

Reviewed by Tim Horton.

When activating streamlined AutoFill, Safari calls UIKit SPI (-_setSuppressSoftwareKeyboard:) on WKWebView to
ensure that the normal software keyboard doesn't briefly appear instead of the AutoFill input view; after
requesting AutoFill credentials, Safari then stops suppressing the software keyboard by setting the SPI property
back to NO. In WebKit, we override -[WKWebView _setSuppressSoftwareKeyboard:], such that WKContentView's
keyboard suppression state follows the web view's state (this is necessary, since WKContentView is the actual
-firstResponder when editing focused text inputs). However, when changing software keyboard suppression from
YES to NO, UIKit reloads input views and (in the process) calls into
-requestAutocorrectionContextWithCompletionHandler:, which then makes a sync IPC call into the web process.

To avoid this sync IPC call, we refactor the implementation of -[WKWebView _setSuppressSoftwareKeyboard:],
such that we don't immediately attempt to unsuppress the software keyboard by calling into WKContentView.
Instead, we asynchronously request an autocorrection context from the web process, and then call
-[WKContentView _setSuppressSoftwareKeyboard:NO] after the autocorrection context request completes (using
the last known autocorrection context data in the UI process rather than making a sync IPC call).

• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _setSuppressSoftwareKeyboard:]):

Call into -updateSoftwareKeyboardSuppressionStateFromWebView below.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):

Invoke -unsuppressSoftwareKeyboardUsingLastAutocorrectionContextIfNeeded to ensure that we stop software
keyboard suppression if the web process terminates while we're waiting for autocorrection context data to
arrive.

(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKContentView _handleAutocorrectionContext:]):
(-[WKContentView updateSoftwareKeyboardSuppressionStateFromWebView]):

Add a new helper that keeps WKContentView's software keyboard suppression state in sync with the WKWebView's
software keyboard suppression state. In the case where we're supressing the software keyboard, we can simply
call into -[WKContentView _setSuppressSoftwareKeyboard:] right away, since UIKit won't try to request an
autocorrection context.

However, in the case where we're unsuppressing the software keyboard, set a new flag, don't immediately forward
the call to WKContentView. Instead, set the _unsuppressSoftwareKeyboardAfterNextAutocorrectionContextUpdate
flag to YES and call into WebPageProxy to request an updated autocorrection context. Upon receiving the response
in -[WKContentView _handleAutocorrectionContext:], we then unset the flag and unsuppress the software keyboard
(crucially, using _lastAutocorrectionContext instead of making a synchronous call back to the web content
process).

(-[WKContentView unsuppressSoftwareKeyboardUsingLastAutocorrectionContextIfNeeded]):

6:07 PM Changeset in webkit [279309] by weinig@apple.com

• 68 edits
  4 copies in trunk

[Modern Media Controls] Modern media controls should not need to know about specific platforms in shared code
​https://bugs.webkit.org/show_bug.cgi?id=227423

Reviewed by Eric Carlson.

Source/WebCore:

Rather than requiring the shared media control classes to know specifics about
the various platforms via the LayoutTraits flags, we now abstract those decisions
via a new polymorphic LayoutTraits class, which each platform subclasses and
implements.

This will gives better separation and will allow easier experimentation with new
control patterns.

• DerivedSources-input.xcfilelist:
• DerivedSources.make:
• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• Modules/modern-media-controls/js-files:

Adds new files for layout traits and its subclasses.

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::layoutTraitsClassName const):
(WebCore::MediaControlsHost::platform const): Deleted.

• Modules/mediacontrols/MediaControlsHost.h:
• Modules/mediacontrols/MediaControlsHost.idl:

Replace platform accessor with a new layoutTraitsClassName, which allows
the platform to spcecify which of the trait subclasses to use.

• Modules/modern-media-controls/controls/layout-traits.js: Added.
• Modules/modern-media-controls/controls/ios-layout-traits.js: Added.
• Modules/modern-media-controls/controls/macos-layout-traits.js: Added.
• Modules/modern-media-controls/controls/watchos-layout-traits.js: Added.

Add new layout trait files.

• Modules/modern-media-controls/controls/fullscreen-button.js:
• Modules/modern-media-controls/controls/icon-service.js:
• Modules/modern-media-controls/controls/ios-inline-media-controls.js:
• Modules/modern-media-controls/controls/layout-item.js:
• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
• Modules/modern-media-controls/controls/macos-inline-media-controls.js:
• Modules/modern-media-controls/controls/media-controls.js:
• Modules/modern-media-controls/controls/play-pause-button.js:
• Modules/modern-media-controls/controls/time-control.js:
• Modules/modern-media-controls/controls/watchos-media-controls.js:
• Modules/modern-media-controls/media/media-controller.js:
• Modules/modern-media-controls/media/tracks-support.js:

Replace explicit checks for platform with queries to the layout traits interface.

LayoutTests:

Update tests and results to use LayoutTraits class.

• media/modern-media-controls/airplay-button/airplay-button-on.html:
• media/modern-media-controls/airplay-button/airplay-button.html:
• media/modern-media-controls/airplay-placard/airplay-placard.html:
• media/modern-media-controls/button/button-active-state.html:
• media/modern-media-controls/button/button-click-on-edges.html:
• media/modern-media-controls/button/button-focus-state.html:
• media/modern-media-controls/button/button-icon-name-expected.txt:
• media/modern-media-controls/button/button-icon-name.html:
• media/modern-media-controls/button/button-on.html:
• media/modern-media-controls/forward-button/forward-button.html:
• media/modern-media-controls/fullscreen-button/fullscreen-button.html:
• media/modern-media-controls/icon-service/icon-service-expected.txt:
• media/modern-media-controls/icon-service/icon-service.html:
• media/modern-media-controls/invalid-placard/invalid-placard-constrained-metrics-expected.txt:
• media/modern-media-controls/invalid-placard/invalid-placard-constrained-metrics.html:
• media/modern-media-controls/invalid-placard/invalid-placard.html:
• media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-constructor.html:
• media/modern-media-controls/layout-item/layout-item-expected.txt:
• media/modern-media-controls/layout-item/layout-item.html:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor-expected.txt:
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor.html:
• media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
• media/modern-media-controls/media-controls/media-controls-appear-when-focus.html:
• media/modern-media-controls/media-controls/media-controls-constructor-expected.txt:
• media/modern-media-controls/media-controls/media-controls-constructor.html:
• media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics-expected.txt:
• media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html:
• media/modern-media-controls/mute-button/mute-button.html:
• media/modern-media-controls/overflow-button/overflow-button.html:
• media/modern-media-controls/pip-button/pip-button.html:
• media/modern-media-controls/pip-placard/pip-placard.html:
• media/modern-media-controls/placard/placard-expected.txt:
• media/modern-media-controls/placard/placard.html:
• media/modern-media-controls/play-pause-button/play-pause-button.html:
• media/modern-media-controls/rewind-button/rewind-button.html:
• media/modern-media-controls/skip-back-button/skip-back-button.html:
• media/modern-media-controls/skip-forward-button/skip-forward-button.html:
• media/modern-media-controls/time-control/time-control-expected.txt:
• media/modern-media-controls/time-control/time-control.html:
• media/modern-media-controls/tracks-button/tracks-button.html:
• media/modern-media-controls/watchos-media-controls/watchos-media-controls-constructor-expected.txt:
• media/modern-media-controls/watchos-media-controls/watchos-media-controls-constructor.html:

5:48 PM Changeset in webkit [279308] by dino@apple.com

• 4 edits in trunk/Source/WebCore

Build fix for iOS Simulator. MTLSharedTexture is not available
on that configuration.

• Modules/webxr/WebXROpaqueFramebuffer.cpp:

(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
• platform/graphics/opengl/GraphicsContextGLOpenGL.h:

Jun 25, 2021:

10:10 PM Changeset in webkit [279307] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GLIB] Update test expectations after r279217
​https://bugs.webkit.org/show_bug.cgi?id=227410

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-06-25

• platform/glib/TestExpectations:

7:26 PM Changeset in webkit [279306] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][TFC] Remove redundant struct ResolvedItem
​https://bugs.webkit.org/show_bug.cgi?id=227405

Reviewed by Sam Weinig.

• layout/formattingContexts/table/TableLayout.cpp:

(WebCore::Layout::distributeAvailableSpace):

6:47 PM Changeset in webkit [279305] by Brent Fulgham

• 9 edits in trunk/Source/WebKit

[macOS] Add logging and clean up AppSSO flows
​https://bugs.webkit.org/show_bug.cgi?id=227379

Reviewed by Kate Cheney.

This patch adds detailed logging to understand the flows through the AppSSO authentication code,
and adds clean-up code in more places to ensure that the modal sheet used by AppSSO is dismissed
in cases where the authentication has completed (or failed).

• UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.mm:

(WebKit::NavigationSOAuthorizationSession::shouldStartInternal): Adds new logging.
(WebKit::NavigationSOAuthorizationSession::webViewDidMoveToWindow): Ditto.
(WebKit::NavigationSOAuthorizationSession::pageActiveURLDidChangeDuringWaiting const): Ditto.

• UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm:

(WebKit::PopUpSOAuthorizationSession::shouldStartInternal): Adds new logging.
(WebKit::PopUpSOAuthorizationSession::fallBackToWebPathInternal): Ditto.
(WebKit::PopUpSOAuthorizationSession::abortInternal): Ditto.
(WebKit::PopUpSOAuthorizationSession::completeInternal): Ditto.
(WebKit::PopUpSOAuthorizationSession::close): Ditto.
(WebKit::PopUpSOAuthorizationSession::initSecretWebView): Ditto.

• UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm:

(WebKit::RedirectSOAuthorizationSession::fallBackToWebPathInternal): Adds new logging.
(WebKit::RedirectSOAuthorizationSession::abortInternal): Ditto.
(WebKit::RedirectSOAuthorizationSession::completeInternal): Ditto.
(WebKit::RedirectSOAuthorizationSession::beforeStart): Ditto.

• UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm:

(WebKit::SOAuthorizationCoordinator::tryAuthorize): Adds new logging.

• UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.h:
• UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:

(WebKit::SOAuthorizationSession::stateString const): Added.
(WebKit::SOAuthorizationSession::~SOAuthorizationSession): Add new logging, and ensure modal sheet is dismissed.
(WebKit::SOAuthorizationSession::becomeCompleted): Added new logging.
(WebKit::SOAuthorizationSession::shouldStart): Ditto.
(WebKit::SOAuthorizationSession::start): Ditto.
(WebKit::SOAuthorizationSession::continueStartAfterGetAuthorizationHints): Ditto.
(WebKit::SOAuthorizationSession::continueStartAfterDecidePolicy): Ditto.
(WebKit::SOAuthorizationSession::fallBackToWebPath): Add new logging, and ensure modal sheet is dismissed.
(WebKit::SOAuthorizationSession::abort): Ditto.
(WebKit::SOAuthorizationSession::complete): Ditto.
(WebKit::SOAuthorizationSession::presentViewController): Added new logging, and dismiss modal if an existing
view is in place.
(WebKit::SOAuthorizationSession::dismissModalSheetIfNecessary): Added.
(WebKit::SOAuthorizationSession::dismissViewController): Use new helper function.

• UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm:

(WebKit::SubFrameSOAuthorizationSession::fallBackToWebPathInternal): Adds new logging.
(WebKit::SubFrameSOAuthorizationSession::abortInternal): Ditto.
(WebKit::SubFrameSOAuthorizationSession::completeInternal): Ditto.
(WebKit::SubFrameSOAuthorizationSession::beforeStart): Ditto.
(WebKit::SubFrameSOAuthorizationSession::didFinishLoad): Ditto.
(WebKit::SubFrameSOAuthorizationSession::loadRequestToFrame): Ditto.

• UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm:

(-[WKSOAuthorizationDelegate authorization:presentViewController:withCompletion:]): Adds new logging.
(-[WKSOAuthorizationDelegate authorizationDidNotHandle:]): Ditto.
(-[WKSOAuthorizationDelegate authorizationDidCancel:]): Ditto.
(-[WKSOAuthorizationDelegate authorizationDidComplete:]): Ditto.
(-[WKSOAuthorizationDelegate authorization:didCompleteWithHTTPAuthorizationHeaders:]): Ditto.
(-[WKSOAuthorizationDelegate authorization:didCompleteWithHTTPResponse:httpBody:]): Ditto.
(-[WKSOAuthorizationDelegate authorization:didCompleteWithError:]): Ditto.
(-[WKSOAuthorizationDelegate setSession:]): Ditto.

5:49 PM Changeset in webkit [279304] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

[iOS] Web process sometimes crashes under findDataDetectionResultElementInImageOverlay
​https://bugs.webkit.org/show_bug.cgi?id=227412
rdar://79588091

Reviewed by Devin Rousso.

Speculatively fix the crash by ensuring that the hit-tested text node inside an image overlay is inside the
shadow root of the element responding to click events, and that the element responding to click events contains
an image overlay.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::elementPositionInformation):

5:39 PM Changeset in webkit [279303] by mmaxfield@apple.com

• 4 edits in trunk/Source

[macOS] WebGL content is unable to use the discrete GPU
​https://bugs.webkit.org/show_bug.cgi?id=227408
<rdar://problem/79216506>

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

There appears to be a key collision:

Source/ThirdParty/ANGLE/include/platform/PlatformMethods.h:#define EGL_PLATFORM_ANGLE_PLATFORM_METHODS_ANGLEX 0x3482
Source/ThirdParty/ANGLE/include/EGL/eglext_angle.h:#define EGL_POWER_PREFERENCE_ANGLE 0x3482

Both these keys seem to be accepted by EGL_GetPlatformDisplayEXT().

This patch just changes the value of one of them to a value I picked out of a hat, just so they don't conflict.
We should work with upstream to either:
A) Find a better solution (maybe disambiguate these values based on which function is accepting them), or
B) Make a robust way to make sure keys don't collide in the future.

• include/platform/PlatformMethods.h:

Source/WebCore:

Simply pass along the power preference into ANGLE. This is read in
DisplayMtl::getMetalDeviceMatchingAttribute().

No new tests. I _think_ this is untestable, because the web exposed power preference is being set correctly.
We’re correctly reporting to the web content that they have successfully asked for a high power context.
We’re just not honoring that internally. If the test is a performance test, or checks the renderer string,
that test would be hardware-dependent, and couldn’t be a regular layout test.

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::InitializeEGLDisplay):

5:23 PM Changeset in webkit [279302] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION (r278746): [Mac wk 1] media/media-fullscreen-return-to-inline.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=227367.

Unreviewed test gardening.

Patch by Eric Hutchison <Eric Hutchison> on 2021-06-25

• platform/mac-wk1/TestExpectations:

5:09 PM Changeset in webkit [279301] by mmaxfield@apple.com

• 5 edits
  1 add in trunk

[macOS] -[NSString _web_widthWithFont:] returns 0
​https://bugs.webkit.org/show_bug.cgi?id=227385
<rdar://problem/79430938>

Reviewed by Simon Fraser.

Source/WebCore:

Simply take the iOS codepath on macOS.

Test: WebKitLegacyStringWidth.ThaiWidthForWeb

• platform/graphics/FontCascade.cpp:
• platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::FontCascade::FontCascade):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/StringWidth.mm: Added.

(TEST):

4:17 PM Changeset in webkit [279300] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION: http/tests/preload/onload_event.html is a flaky timeout on Big Sur wk1 Release
​https://bugs.webkit.org/show_bug.cgi?id=227366

Unreviewed test gardening

Patch by Ayumi Kojima <Ayumi Kojima> on 2021-06-25

• platform/mac-wk1/TestExpectations:

4:04 PM Changeset in webkit [279299] by guijemont@igalia.com

• 2 edits in trunk/JSTests

Unskip stress/call-apply-exponential-bytecode-size.js on most platforms
​https://bugs.webkit.org/show_bug.cgi?id=227354

Reviewed by Yusuke Suzuki.

Instead of skipping, we increase the JIT memory size for this test on
platforms that have less than 64 MB by default.

• stress/call-apply-exponential-bytecode-size.js:

3:06 PM Changeset in webkit [279298] by dino@apple.com

• 8 edits in trunk/Source/WebCore

Add support for MTLSharedTextures in WebXR
​https://bugs.webkit.org/show_bug.cgi?id=227245
<rdar://problem/79591620>

Reviewed by Tim Horton.

Source/WebCore:

Sometimes, the IOSurface passed to WebXR come from a shared MTLTexture. In
this case we can't treat the IOSurface data as a regular single-plane
image. Instead we should use it to recreate the MTLTexture and then
bind that to WebGL's framebuffer.

• Modules/webxr/WebXROpaqueFramebuffer.cpp: Use some new binding methods on GraphicsContextGLOpenGL

if given a shared texture.
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):

• Modules/webxr/WebXROpaqueFramebuffer.h:
• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: New methods to link an

IOSurface to a GL texture, going through a MTLSharedTexture.
(WebCore::GraphicsContextGLOpenGL::attachIOSurfaceToSharedTexture):
(WebCore::GraphicsContextGLOpenGL::detachIOSurfaceFromSharedTexture):

• platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• platform/xr/PlatformXR.h: Add a new "isShared" member to LayerData

to differentiate between normal IOSurfaces and those that came
from a shared texture.
(PlatformXR::Device::FrameData::LayerData::encode const):
(PlatformXR::Device::FrameData::LayerData::decode):

Source/WebCore/PAL:

Define MTLSharedTextureHandle's initWithIOSurface.

• pal/spi/cocoa/MetalSPI.h:

1:50 PM Changeset in webkit [279297] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Set ImageBitmap experimental feature flag to true
​https://bugs.webkit.org/show_bug.cgi?id=227140

Patch by Kenneth Russell <​kbr@chromium.org> on 2021-06-25
Reviewed by Dean Jackson.

Web developers - most recently Google's Meet team - have asked for
ImageBitmap support in WebKit. The implementation was
substantially upgraded during development of WebGL 2.0, and is
thoroughly tested on the EWS. Change the default value for
ImageBitmap's experimental flag to true; this can be removed
completely after one release cycle.

• Scripts/Preferences/WebPreferencesExperimental.yaml:

12:51 PM Changeset in webkit [279296] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix null crash in AudioMediaStreamTrackRendererCocoa::start
​https://bugs.webkit.org/show_bug.cgi?id=227386
<rdar://79045120>

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-06-25
Reviewed by Youenn Fablet.

AudioMediaStreamTrackRendererInternalUnitManager::Proxy::~Proxy calls those callbacks with nullptr.
So can LocalAudioMediaStreamTrackRendererInternalUnit::retrieveFormatDescription when createAudioUnitIfNeeded
has an early return or hasn't been called yet.

When this happens, let's not crash.

• platform/mediastream/cocoa/AudioMediaStreamTrackRendererCocoa.cpp:

(WebCore::AudioMediaStreamTrackRendererCocoa::start):

12:06 PM Changeset in webkit [279295] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Add missing methods to IOKit filter
​https://bugs.webkit.org/show_bug.cgi?id=227398
<rdar://79487528>

Reviewed by Brent Fulgham.

Add missing methods to the IOAccelerator IOKit filter on macOS.

• WebProcess/com.apple.WebProcess.sb.in:

11:50 AM Changeset in webkit [279294] by Patrick Angle

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: Scope Chain sidebar panel is stripping repeating whitespace from strings
​https://bugs.webkit.org/show_bug.cgi?id=227234

Reviewed by Devin Rousso.

String and Regular Expression values in Object Trees were having white-space: nowrap; applied to them, which
was redundant because white-space: pre; was already defined for .formatted-string and .formatted-regexp,
which makes sure that the text does not wrap unless it contains a newline, and these previews have newlines
replaced with a Unicode symbol to visually represent a newline without breaking to a new line.

• UserInterface/Views/ObjectTreeView.css:

(.object-tree-property :matches(.formatted-string, .formatted-regexp)): Deleted.

11:46 AM Changeset in webkit [279293] by Ruben Turcios

• 1 copy in tags/Safari-612.1.20.2

Tag Safari-612.1.20.2.

11:45 AM Changeset in webkit [279292] by Ruben Turcios

• 2 edits in branches/safari-612.1.20-branch/Source/WebCore/PAL

Cherry-pick r279290. rdar://problem/79788549

Unreviewed, fix the macOS Monterey build

Some internal builders are still attempting to build WebKit for macOS Monterey using an SDK without the fix for
rdar://74299451. Restore the forward staging declaration for -initWithDataProvider:contentType:previewTitle:
in the meantime.

• pal/spi/mac/QuickLookMacSPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@279290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:42 AM Changeset in webkit [279291] by Ruben Turcios

• 8 edits in branches/safari-612.1.20-branch/Source

Versioning.

WebKit-7612.1.20.2

11:08 AM Changeset in webkit [279290] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore/PAL

Unreviewed, fix the macOS Monterey build

Some internal builders are still attempting to build WebKit for macOS Monterey using an SDK without the fix for
rdar://74299451. Restore the forward staging declaration for -initWithDataProvider:contentType:previewTitle:
in the meantime.

• pal/spi/mac/QuickLookMacSPI.h:

10:55 AM Changeset in webkit [279289] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

WIRELESS_PLAYBACK_TARGET guards protect unrelated code
​https://bugs.webkit.org/show_bug.cgi?id=227404

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-06-25
Reviewed by Eric Carlson.

The dispatchEvent(), addEventListener() and removeEventListener() are now unconditionally
implemented. The WIRELESS_PLAYBACK_TARGET guards were refactored to enclose only the code
specific to this feature.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent):
(WebCore::HTMLMediaElement::setWirelessPlaybackTarget):
(WebCore::HTMLMediaElement::setShouldPlayToPlaybackTarget):
(WebCore::HTMLMediaElement::playbackTargetPickerWasDismissed):
(WebCore::HTMLMediaElement::remoteHasAvailabilityCallbacksChanged):
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::removeEventListener):

• html/HTMLMediaElement.h:

10:12 AM Changeset in webkit [279288] by Ryan Haddad

• 67 edits in trunk/Source

Unreviewed, reverting r279208.
​https://bugs.webkit.org/show_bug.cgi?id=227381

Broke the Apple Windows build.

Reverted changeset:

"Not all uses of AudioToolbox framework use soft linking"
​https://bugs.webkit.org/show_bug.cgi?id=227250
​https://trac.webkit.org/changeset/279208

9:31 AM Changeset in webkit [279287] by Peng Liu

• 4 edits in trunk/Source/WebKit

Explicitly invalidate WKFullScreenViewController after a video exits fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=227372

Reviewed by Eric Carlson.

Since WKFullScreenWindowController owns WKFullScreenViewController,
we had better let WKFullScreenWindowController manage the life cycle
of WKFullScreenViewController.

• UIProcess/ios/fullscreen/WKFullScreenViewController.h:
• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController initWithWebView:]):
(-[WKFullScreenViewController invalidate]):
(-[WKFullScreenViewController dealloc]):
(-[WKFullScreenViewController showUI]):
(-[WKFullScreenViewController hideUI]):
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController setAnimatingViewAlpha:]):
(-[WKFullScreenViewController setPrefersStatusBarHidden:]):
(-[WKFullScreenViewController setPrefersHomeIndicatorAutoHidden:]):
(-[WKFullScreenViewController setPlaying:]):
(-[WKFullScreenViewController setPictureInPictureActive:]):
(-[WKFullScreenViewController setAnimating:]):
(-[WKFullScreenViewController _manager]):
(-[WKFullScreenViewController _effectiveFullscreenInsets]):
(-[WKFullScreenViewController _cancelAction:]):
(-[WKFullScreenViewController _togglePiPAction:]):
(-[WKFullScreenViewController _touchDetected:]):
(-[WKFullScreenViewController _statusBarFrameDidChange:]):
(-[WKFullScreenViewController _updateWebViewFullscreenInsets]):
(-[WKFullScreenViewController _showPhishingAlert]):

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _completedExitFullScreen]):

8:42 AM Changeset in webkit [279286] by svillar@igalia.com

• 5 edits in trunk

[css-flexbox] Improve computation of intrinsic sizes of flex items with aspect ratio
​https://bugs.webkit.org/show_bug.cgi?id=227395

Reviewed by Rob Buis.

Source/WebCore:

Before computing the intrinsic sizes of flex items we first clear the overriding sizes of the item
that might have been set before in order to get the proper intrinsic size. However there is one
situation in which having an overriding size is desirable and it's when the cross size should
be set to the flex container's definite cross size. That's one of the exceptions for definite/indefinite
sizes mentioned in the specs (see ​https://drafts.csswg.org/css-flexbox/#definite-sizes).

In the aforementioned case we should temporarily set that overriding size in the cross axis so that
the intrinsic size could be computed with that constrain.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeChildIntrinsicLogicalWidths const): Set the overriding size
in the cross axis to compute the intrinsic size.
(WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing const):
(WebCore::RenderFlexibleBox::childCrossSizeShouldUseContainerCrossSize const): Added a missing check,
the cross size of the child must be auto, otherwise the rule does not apply.
(WebCore::RenderFlexibleBox::computeCrossSizeForChildUsingContainerCrossSize const): Refactored from
computeMainSizeFromAspectRatioUsing() as it's now used in two different places.

• rendering/RenderFlexibleBox.h:

LayoutTests:

• TestExpectations: Unskipped 3 tests that are now passing.

8:39 AM Changeset in webkit [279285] by Philippe Normand

• 4 edits in trunk/Source/WebCore

[GStreamer] TextCombiner has unlinked internal encoders
​https://bugs.webkit.org/show_bug.cgi?id=227362

Reviewed by Xabier Rodriguez-Calvar.

Each combiner pad can receive multiple caps events for the same stream, so we can't really
rely on those to modify the internal topology of the combiner. Instead we can check the
sticky events from the pad chain function, this is done at most once per pad. In case a caps
event was sticked to the pad, the combiner now reacts properly.

This issue was detected while running
media/track/in-band/track-in-band-kate-ogg-cues-added-once.html with playbin3 enabled. 6
different encoders where added to the combiner while only 2 are needed actually.

• platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webKitTextCombinerHandleCaps):

• platform/graphics/gstreamer/TextCombinerGStreamer.h:
• platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp:

(webkitTextCombinerPadChain):
(webkitTextCombinerPadConstructed):

8:28 AM Changeset in webkit [279284] by svillar@igalia.com

• 3 edits
  2 adds in trunk

Nullptr crash in StyledMarkupAccumulator::traverseNodesForSerialization
​https://bugs.webkit.org/show_bug.cgi?id=226821

Reviewed by Ryosuke Niwa.

Source/WebCore:

r276394 fixed an issue in serialization when transversing the nodes. It added a new condition
to the ASSERT that was checking that its OK not to have a next pointer when there is a valid
pastEnd in the case of pastEnd being a descendant of the pointer traversing the node tree.

However that descendant check was not including the shadow DOM. This is precisely the case
detected by the test case this patch is adding.

Test: editing/selection/setSelection-shadow-dom-crash.html

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):

LayoutTests:

• editing/selection/setSelection-shadow-dom-crash-expected.txt: Added.
• editing/selection/setSelection-shadow-dom-crash.html: Added.

8:12 AM Changeset in webkit [279283] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Build warnings in AudioFileReader since r279123
​https://bugs.webkit.org/show_bug.cgi?id=227348

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-06-25
Reviewed by Xabier Rodriguez-Calvar.

Simplify the code handling the giostreamsrc creation, now that it is the only option possible.

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::decodeAudioForBusCreation):

8:06 AM Changeset in webkit [279282] by commit-queue@webkit.org

• 8 edits in trunk/Source

Unreviewed, reverting r279266.
​https://bugs.webkit.org/show_bug.cgi?id=227402

Causes crash loop

Reverted changeset:

"Remove references to order files"
​https://bugs.webkit.org/show_bug.cgi?id=227377
​https://trac.webkit.org/changeset/279266

7:51 AM Changeset in webkit [279281] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, GStreamer gardening

• platform/glib/TestExpectations: Mark a mediastream as flaky.

7:51 AM Changeset in webkit [279280] by Ziran Sun

• 2 edits in trunk/Tools

Add myself to contributor list
​https://bugs.webkit.org/show_bug.cgi?id=227400

Reviewed by Sergio Villar Senin.

• Scripts/webkitpy/common/config/contributors.json:

7:08 AM Changeset in webkit [279279] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit

[GLib] Guard Cairo inclusions in shared GLib API implementation files
​https://bugs.webkit.org/show_bug.cgi?id=227370

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2021-06-25
Reviewed by Philippe Normand.

For cross-port GLib API implementation, different Cairo inclusions are
moved into appropriate build guards tha match the build guards where
Cairo is then used.

• UIProcess/API/glib/WebKitFaviconDatabase.cpp:
• UIProcess/API/glib/WebKitProtocolHandler.cpp:

(WebKit::WebKitProtocolHandler::handleGPU):

• UIProcess/API/glib/WebKitWebView.cpp:

6:58 AM Changeset in webkit [279278] by Ziran Sun

• 6 edits in trunk

[css-grid] Consider container's writing mode to get grid item's margin
​https://bugs.webkit.org/show_bug.cgi?id=226877

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Update test results.

• web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-008-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-011-expected.txt:

Source/WebCore:

When computing the logical offset of a non-static absolute positioned grid item, we need
to pass its container's style in order to resolve the child margin correctly, especially
for the case when the item has flipped block writing mode (vertical-rl).

This change is an import of the Chromium change at
​https://chromium-review.googlesource.com/c/chromium/src/+/2577365

• rendering/RenderBox.h:

(WebCore::RenderBox::marginLogicalLeft const):
(WebCore::RenderBox::marginLogicalRight const):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalOffsetForOutOfFlowChild const):

6:49 AM Changeset in webkit [279277] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Minor debugging improvements in mediastream source element
​https://bugs.webkit.org/show_bug.cgi?id=227396

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-06-25
Reviewed by Xabier Rodriguez-Calvar.

• platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Give representative name to

the appsrc elements embedded in the MediaStreamSource element. Also add logging calls
related with tracks observation.

5:37 AM Changeset in webkit [279276] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

Unskip structure-storedPrototype-should-only-assert-on-the-mutator-thread.js on arm and mips
​https://bugs.webkit.org/show_bug.cgi?id=227222

Tested with 50 iterations in both arm and mips.

Unreviewed Gardening.

Patch by Mikhail R. Gadelha <Mikhail R. Gadelha> on 2021-06-25

• stress/structure-storedPrototype-should-only-assert-on-the-mutator-thread.js:

5:28 AM Changeset in webkit [279275] by Paulo Matos

• 2 edits in trunk/JSTests

Unskip materialized-regexp-has-correct-last-index-set-by-match on arm and mips
​https://bugs.webkit.org/show_bug.cgi?id=227213

Unreviewed Gardening.

• stress/materialized-regexp-has-correct-last-index-set-by-match.js:

4:22 AM Changeset in webkit [279274] by svillar@igalia.com

• 3 edits in trunk/Source/WebCore

[css-flexbox] Cleanup OverridingSizesScope RAII class
​https://bugs.webkit.org/show_bug.cgi?id=227394

Reviewed by Rob Buis.

In r279268 we added a new RAII class which adds an overriding sizes free scope to perform
layout computations. That class heavily uses the different set/get/clear methods for overriding
sizes. We can use a macro with subsitutions there to reduce the amount of required code.

Also moving the computeChildIntrinsicLogicalWidths() method to the private section as it does
not require protected visibility.

No new tests as it's just a code refactoring that does not modify the functionality.

• rendering/RenderFlexibleBox.cpp:

(WebCore::OverridingSizesScope::OverridingSizesScope):
(WebCore::OverridingSizesScope::~OverridingSizesScope):
(WebCore::OverridingSizesScope::setOrClearOverridingSize): Deleted.

• rendering/RenderFlexibleBox.h:

2:55 AM Changeset in webkit [279273] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

Unskip materialize-regexp-cyclic-regexp.js on ARM and MIPS
​https://bugs.webkit.org/show_bug.cgi?id=227223

Tested with 50 iterations in both arm and mips.

Unreviewed Gardening.

Patch by Mikhail R. Gadelha <Mikhail R. Gadelha> on 2021-06-25

• stress/materialize-regexp-cyclic-regexp.js:

2:03 AM Changeset in webkit [279272] by Martin Robinson

• 2 edits in trunk/Source/WebCore

[css-scroll-snap] Simplify snap point selection helpers
​https://bugs.webkit.org/show_bug.cgi?id=227062

Reviewed by Frédéric Wang.

Combine indicesOfNearestSnapOffsets and findFirstSnapStopOffsetBetweenOriginAndDestination
and have the helper return the geometric previous and next snap points. This makes the
code a bit easier to read, slightly more efficient, and prepares for looking at
the geometric previous and next snap points for certain upcoming CSS Scroll Snap features.

Previously, indicesOfNearestSnapOffsets used a binary search and findFirstSnapStopOffsetBetweenOriginAndDestination
used a linear search. This change replaces these two functions with a single linear search.
While findFirstSnapStopOffsetBetweenOriginAndDestination is only called for directional scrolling,
directional scrolling is more common than non-directional scrolling (which is typically only called
by scrollIntoView() and other JS scrolling APIs). I have tested this change with a large table of
snap points and performance does not seem to be changed. In addition, a future change should mean
that this searchForPotentialSnapPoints should be called much less.

No new tests. This should not change behavior in any way.

• page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::searchForPotentialSnapPoints): Added this new helper which is the combination
of indicesOfNearestSnapOffsets and findFirstSnapStopOffsetBetweenOriginAndDestination.
(WebCore::closestSnapOffsetWithInfoAndAxis): Use the new helper.

1:59 AM Changeset in webkit [279271] by svillar@igalia.com

• 4 edits in trunk

[css-flexbox] Do not clamp flex base size with {min|max}-{height|width}
​https://bugs.webkit.org/show_bug.cgi?id=225590

Reviewed by Alan Bujtas.

Source/WebCore:

When computing flex base size we should not clamp it with neither min-{height|width}
nor max-{height|width}. That would be done later and will be called the hypothetical
main size.

For most of the cases we were already doing it, however there are some particular cases
in which we have to call the generic layout code which does clamp the sizes using min
and max sizes. In order to make those code paths work, we reset the min|max values to
their initial ones (so they effectively become inactive) and then we set the original
values back after computing the base size.

• rendering/RenderFlexibleBox.cpp:

(WebCore::ScopedUnboundedBox::ScopedUnboundedBox): New scoped class that sets min|max sizes
to their initial values on instantiation and restores the original values on destruction.
(WebCore::ScopedUnboundedBox::~ScopedUnboundedBox):
(WebCore::RenderFlexibleBox::constructFlexItems): Wrap the base size computation with a
ScopedUnboundedBox.

LayoutTests:

The patch allows us to pass 3 new tests. We're adding percentage-max-height-003.html to
the list of expected failures because these changes make it fail. This is not really a
regression however because although the size of the deepest flex item was correct (and thus
allowed us to pass the test) the other sizes were completely wrong. So it's more an issue
of the test not being complete enough and passing artificially than anything else.

• TestExpectations: Unskipped 3 tests & skipped 1.

1:43 AM Changeset in webkit [279270] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening, mark more WebXR tests as unsupported
​https://bugs.webkit.org/show_bug.cgi?id=227358

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-06-25

• platform/gtk/TestExpectations:

1:31 AM Changeset in webkit [279269] by Ziran Sun

• 86 edits
  3 copies
  330 adds in trunk/LayoutTests

Resync web-platform-tests/css/css-grid tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=223593

Reviewed by Sergio Villar Senin and Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-002.html: Added.
• web-platform-tests/css/css-grid/abspos/descendant-static-position-004-expected.html:
• web-platform-tests/css/css-grid/abspos/descendant-static-position-004.html:
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-img-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-rtl-last-baseline-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-safe-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-safe-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-vertWM-last-baseline-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-img-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-rtl-last-baseline-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-001.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-justify-self-vertWM-last-baseline-004.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-002-expected.xht: Added.
• web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-002.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-003-expected.xht: Added.
• web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-003.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-004-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-004.html: Added.
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013-expected.txt:
• web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015-expected.txt:
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-018-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-018.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-019-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-019.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-020-expected.xht: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-020.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-021-expected.xht: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-021.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-022-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-022.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-negative-indices-001-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-negative-indices-001.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-negative-indices-002-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-negative-indices-002.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-negative-indices-003-expected.html: Added.
• web-platform-tests/css/css-grid/abspos/positioned-grid-items-negative-indices-003.html: Added.
• web-platform-tests/css/css-grid/abspos/support/colors-8x16.png: Added.
• web-platform-tests/css/css-grid/abspos/support/w3c-import.log:
• web-platform-tests/css/css-grid/abspos/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-011-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-011.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-012-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-012.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-013-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-013.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-014-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-014.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-017-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-017.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-018-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-018.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-029-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-029.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-030-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-030.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-031-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-031.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-035-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-035.html:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-036-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-036.html:
• web-platform-tests/css/css-grid/alignment/grid-baseline-004-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-baseline-004.html:
• web-platform-tests/css/css-grid/alignment/grid-baseline-align-cycles-001.html:
• web-platform-tests/css/css-grid/alignment/grid-content-alignment-overflow-002-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-content-alignment-overflow-002.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-content-distribution-026-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
• web-platform-tests/css/css-grid/alignment/grid-content-distribution-026.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-content-distribution-027-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/alignment/grid-content-distribution-027.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-content-distribution-028-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/alignment/grid-content-distribution-028.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-gutters-015-expected.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-gutters-015.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-gutters-016-expected.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-gutters-016.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-001-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-001.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-002-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-002.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-008-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-008.html:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-012-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-012.html:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-016-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-016.html:
• web-platform-tests/css/css-grid/alignment/grid-self-alignment.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html:
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-001-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-001.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-002-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-002.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-003.tentative-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-003.tentative.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-004-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-004.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-005-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-005.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-006-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-006.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-007-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-007.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-008-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-008.html: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-009-expected.xht: Added.
• web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-009.html: Added.
• web-platform-tests/css/css-grid/alignment/support/25x50-green.png: Added.
• web-platform-tests/css/css-grid/alignment/support/50x50-green.png: Added.
• web-platform-tests/css/css-grid/alignment/support/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/w3c-import.log:
• web-platform-tests/css/css-grid/dynamic-grid-with-auto-fill-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/dynamic-grid-with-auto-fill.html: Added.
• web-platform-tests/css/css-grid/dynamic-grid-within-flexbox-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/dynamic-grid-within-flexbox.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-001.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-aspect-ratio-002.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-dynamic-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-dynamic-001.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-dynamic-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-dynamic-002.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-dynamic-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-dynamic-003.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-003-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-003.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-004-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-004.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-004-expected.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-004.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-005-expected.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-multiple-values-005.html: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-repeat-max-width-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-definition/grid-repeat-max-width-001.html: Added.
• web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
• web-platform-tests/css/css-grid/grid-item-percentage-quirk-001.html:
• web-platform-tests/css/css-grid/grid-item-percentage-quirk-002.html:
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-001.html: Added.
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-002.html: Added.
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-003.html: Added.
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-items/aspect-ratio-004.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html:
• web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-001-expected.xht: Added.
• web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-001.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-002.tentative-expected.xht: Added.
• web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-002.tentative.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-003.tentative-expected.xht: Added.
• web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-003.tentative.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-015-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-015.html: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-001-expected.xht: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-001.html: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-002-expected.xht: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-002.html: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-007-expected.xht: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-007.html: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-010-expected.xht: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-010.html: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-011-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-items/replaced-element-011.html: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-012-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-items/replaced-element-012.html: Added.
• web-platform-tests/css/css-grid/grid-items/replaced-element-013-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-items/replaced-element-013.html: Added.
• web-platform-tests/css/css-grid/grid-items/w3c-import.log:
• web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-003-expected.html:
• web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-003.html:
• web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-009-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-003-expected.html.
• web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-009.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-003.html.
• web-platform-tests/css/css-grid/grid-model/grid-button-001-expected.txt:
• web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-001.html:
• web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-002.html:
• web-platform-tests/css/css-grid/grid-model/w3c-import.log:
• web-platform-tests/css/css-grid/grid-within-flexbox-definite-change-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
• web-platform-tests/css/css-grid/grid-within-flexbox-definite-change.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002.html:
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003.html:
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004.html:
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005.html:
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006.html:
• web-platform-tests/css/css-grid/layout-algorithm/flex-and-intrinsic-sizes-001-expected.txt:
• web-platform-tests/css/css-grid/layout-algorithm/flex-and-intrinsic-sizes-001.html:
• web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-rows-indefinite-height-expected.xht: Added.
• web-platform-tests/css/css-grid/layout-algorithm/flex-sizing-rows-indefinite-height.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002-expected.txt:
• web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html:
• web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001-expected.txt:
• web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html:
• web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002-expected.txt:
• web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html:
• web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-size-with-orthogonal-items-expected.txt:
• web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-size-with-orthogonal-items.html:
• web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-003-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-003.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-004-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-content-004.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-multi-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-multi-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-stretch-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-stretch-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-stretch-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-align-tracks-stretch-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-003-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-003.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-004-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-004.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-005-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-005.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-006-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-fragmentation-006.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-gap-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-gap-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-content-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-content-baseline-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-self-baseline-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-self-baseline-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-self-baseline-002a-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-self-baseline-002a.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-self-baseline-002b-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-item-self-baseline-002b.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-placement-named-lines-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-placement-named-lines-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-placement-named-lines-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-placement-named-lines-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent-expected.txt: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-003-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-003.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-004-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-004.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-005-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-005.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-006-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-intrinsic-sizing-006.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-003-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-003.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-004-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-004.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-005-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-005.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-006-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-006.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-007-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-item-placement-007.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-003-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-003.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-004-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-content-004.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-multi-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-multi-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-stretch-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-stretch-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-stretch-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-justify-tracks-stretch-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-order-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-order-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-order-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-order-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-parsing-expected.txt: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-parsing.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-subgrid-001-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-subgrid-001.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-subgrid-002-expected.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/masonry-subgrid-002.html: Added.
• web-platform-tests/css/css-grid/masonry/tentative/w3c-import.log: Added.
• web-platform-tests/css/css-grid/subgrid/abs-pos-004-expected.html: Added.
• web-platform-tests/css/css-grid/subgrid/abs-pos-004.html: Added.
• web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-004-expected.html: Added.
• web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-004.html: Added.
• web-platform-tests/css/css-grid/subgrid/w3c-import.log:
• web-platform-tests/css/css-grid/support/grid-child-utils.js:
• web-platform-tests/css/css-grid/table-grid-item-005-expected.txt: Added.
• web-platform-tests/css/css-grid/table-grid-item-005.html: Added.
• web-platform-tests/css/css-grid/table-grid-item-dynamic-002-expected.html: Added.
• web-platform-tests/css/css-grid/table-grid-item-dynamic-002.html: Added.
• web-platform-tests/css/css-grid/table-grid-item-dynamic-003-expected.html: Added.
• web-platform-tests/css/css-grid/table-grid-item-dynamic-003.html: Added.
• web-platform-tests/css/css-grid/table-grid-item-dynamic-004-expected.html: Added.
• web-platform-tests/css/css-grid/table-grid-item-dynamic-004.html: Added.
• web-platform-tests/css/css-grid/w3c-import.log:

LayoutTests:

• TestExpectations:
• platform/ios-wk2/TestExpectations:

1:09 AM Changeset in webkit [279268] by svillar@igalia.com

• 5 edits in trunk/Source/WebCore

[css-flexbox] Move flex item preferred width computation specifics to RenderFlexibleBox class
​https://bugs.webkit.org/show_bug.cgi?id=226822

Reviewed by Alan Bujtas.

RenderBlock had some specific code for flex items that cleared the overriding sizes before
computing the {min|max}PreferredWidths and then restored them afterwards. That is done to
properly compute flex items intrinsic sizes. That code is flexbox specific so we better move
it to RenderFlexibleBox. In order to do that a new virtual method was added to RenderBlock which
just calls minPreferredLogicalWidth() and maxPreferredLogicalWidth() for every block except
flexbox containers.

In the case of flexbox containers, it wraps those calls with a RAII class that properly
clears the overriding sizes on instantiation and clears them on destruction. Now that the RAII
class is available we use it also for another existing code path that requires to
temporarily set an overriding size in a given scope.

No need for new tests as there is no change in behaviour.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeChildIntrinsicLogicalWidths const): New virtual method.
(WebCore::RenderBlock::computeChildPreferredLogicalWidths const): Call computeChildIntrinsicLogicalWidths().

• rendering/RenderBlock.h:
• rendering/RenderFlexibleBox.cpp:

(WebCore::OverridingSizesScope::OverridingSizesScope): New RAII class to set/clear overriding sizes in a scope.
(WebCore::OverridingSizesScope::~OverridingSizesScope):
(WebCore::OverridingSizesScope::setOrClearOverridingSize):
(WebCore::RenderFlexibleBox::computeChildIntrinsicLogicalWidths const): Redefinition for flexbox containers.
(WebCore::RenderFlexibleBox::childIntrinsicLogicalHeight const): Removed constness from attribute.
(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth): Ditto.
(WebCore::RenderFlexibleBox::crossAxisIntrinsicExtentForChild): Ditto.

• rendering/RenderFlexibleBox.h:

12:13 AM Changeset in webkit [279267] by graouts@webkit.org

• 13 edits in trunk/Source

[Model] Create a sandbox extension for a temporary directory to store model resources
​https://bugs.webkit.org/show_bug.cgi?id=227359

Reviewed by Tim Horton.

The SPIs we will use to render <model> resources expect a file URL to load and render the model.
Before we adopt these SPIs, we extend the sandbox to allow writing to a temporary directory where
we will store these resources.

Source/WebCore:

• Modules/model-element/HTMLModelElement.cpp:

(WebCore::sharedModelElementCacheDirectory):
(WebCore::HTMLModelElement::setModelElementCacheDirectory):
(WebCore::HTMLModelElement::modelElementCacheDirectory):

• Modules/model-element/HTMLModelElement.h:

Source/WebKit:

• Shared/WebProcessDataStoreParameters.h:

(WebKit::WebProcessDataStoreParameters::encode const):
(WebKit::WebProcessDataStoreParameters::decode):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::webProcessDataStoreParameters):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultModelElementCacheDirectory):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedModelElementCacheDirectory const):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
(WebKit::WebsiteDataStoreConfiguration::copy const):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

(WebKit::WebsiteDataStoreConfiguration::modelElementCacheDirectory const):
(WebKit::WebsiteDataStoreConfiguration::setModelElementCacheDirectory):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setWebsiteDataStoreParameters):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformSetWebsiteDataStoreParameters):