Timeline
Aug 13, 2021:
- 9:47 PM Changeset in webkit [281056] by
-
- 5 edits in trunk/Source/WebKit
Check quarantine bits before rendering local files
https://bugs.webkit.org/show_bug.cgi?id=229073
<rdar://problem/81430251>
Reviewed by Brent Fulgham.
We shouldn't load files unless they have no quarantine flags or
have been marked user approved.
- Platform/spi/mac/QuarantineSPI.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::isQuarantinedAndNotUserApproved):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadFile):
- UIProcess/WebPageProxy.h:
- 7:28 PM Changeset in webkit [281055] by
-
- 43 edits1 add in trunk
Add Cross-Origin-Embedder-Policy support for Blob URLs
https://bugs.webkit.org/show_bug.cgi?id=229041
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/html/cross-origin-embedder-policy/blob.https-expected.txt:
- web-platform-tests/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https-expected.txt:
- web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https-expected.txt:
Source/WebCore:
Add Cross-Origin-Embedder-Policy (COEP) support for Blob URLs. We do the same thing as for COOP,
we pass the COEP policy when registering the Blob URL and store it in the BlobData. When we need
the construct a Blob resource response as a result of a load, we add the right COEP headers
based on the BlobData's COEP policy.
No new tests, rebaselined existing tests.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::startLoadingBlobURL):
- fileapi/Blob.cpp:
(WebCore::BlobURLRegistry::registerURL):
(WebCore::Blob::Blob):
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
- fileapi/ThreadableBlobRegistry.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
- loader/CrossOriginEmbedderPolicy.cpp:
(WebCore::addCrossOriginEmbedderPolicyHeaders):
- loader/CrossOriginEmbedderPolicy.h:
(WebCore::operator==):
- loader/CrossOriginOpenerPolicy.cpp:
(WebCore::addCrossOriginOpenerPolicyHeaders):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
- platform/network/BlobData.h:
(WebCore::BlobData::crossOriginEmbedderPolicy const):
(WebCore::BlobData::setCrossOriginEmbedderPolicy):
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLOptionallyFileBacked):
- platform/network/BlobRegistryImpl.h:
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
Source/WebKit:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLOptionallyFileBacked):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createBlobRegistry):
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
- WebProcess/FileAPI/BlobRegistryProxy.h:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebPlatformStrategies.mm:
Source/WebKitLegacy/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
LayoutTests:
Update test expectations to unskip tests that are now passing.
- 5:47 PM Changeset in webkit [281054] by
-
- 11 edits in trunk
[iOS 15] fast/events/touch/ios/long-press-on-link.html is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=229095
rdar://80386326
Reviewed by Tim Horton.
Source/WebKit:
This test crashes when run immediately after another test that attempts to present the context menu and ends
with the context menu still showing (in this case, fast/events/touch/ios/long-press-on-image.html). Running
these tests back to back causes us to immediately dismiss the context menu interaction while transitioning to
the second test, which triggers the context menu interaction's dismissal animation.
This animation ends in the middle of the next test (long-press-on-link.html), after the long press has begun and
the context menu interaction has already requested a targeted hint preview, but (importantly) before the context
menu peek animation actually begins (i.e.-contextMenuInteraction:willDisplayMenuForConfiguration:animator:).
As a result, we tear down the hint container too early (with the hint view still in the view hierarchy), and
subsequently crash with an exception when UIKit tries to perform coordinate space conversions with the now-
unparented view.
To fix this, we make two small adjustments:
- Avoid unparenting the context menu hint container if it still has subviews.
- Add plumbing to ensure that the context menu hint container is unparented once all of its subviews have
been removed (and the container isn't being used for anything else).
- Platform/spi/ios/UIKitSPI.h:
Add an SPI declaration for the
-_didRemoveSubview:subclassing hook.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKTargetedPreviewContainer initWithContentView:]):
(-[WKTargetedPreviewContainer _didRemoveSubview:]):
Add a new subclass for WKTargetedPreviewContainer that notifies WKContentView when its last subview has been
removed, such that WKContentView can tear down the container view if needed.
(-[WKContentView cleanUpInteraction]):
(-[WKContentView removeContextMenuViewIfPossibleForActionSheetAssistant:]):
(-[WKContentView _targetedPreviewContainerDidRemoveLastSubview:]):
(-[WKContentView _createPreviewContainerWithLayerName:]):
(-[WKContentView _removeContextMenuHintContainerIfPossible]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKContentView _removeContextMenuViewIfPossible]): Deleted.
Additionally rename
-_removeContextMenuViewIfPossibleto-_removeContextMenuHintContainerIfPossible, to make
it clear that this method is about removing the container view for context menu hints (and not the hints
themselves).
- UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsDropdown _removeContextMenuInteraction]):
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker removeContextMenuInteraction]):
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel removeContextMenuInteraction]):
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker removeContextMenuInteraction]):
LayoutTests:
Remove the failing test expectation (and remove a passing expectation for iOS 14 which is no longer necessary
after this fix).
- platform/ios-14/TestExpectations:
- platform/ios/TestExpectations:
- 5:35 PM Changeset in webkit [281053] by
-
- 8 edits in branches/safari-612.1.27.0-branch/Source
Versioning.
WebKit-7612.1.27.0.23
- 5:34 PM Changeset in webkit [281052] by
-
- 1 copy in tags/Safari-612.1.27.0.22
Tag Safari-612.1.27.0.22.
- 3:38 PM Changeset in webkit [281051] by
-
- 1 copy in tags/Safari-612.1.27.0.9
Tag Safari-612.1.27.0.9.
- 3:34 PM Changeset in webkit [281050] by
-
- 8 edits in branches/safari-612.1.27.0.6-branch/Source
Versioning.
WebKit-7612.1.27.0.9
- 3:25 PM Changeset in webkit [281049] by
-
- 2 edits in branches/safari-612.1.27.0-branch/Source/WebKit
Cherry-pick r281044. rdar://problem/81918718
[Cocoa] RemoteMediaPlayerProxy does not receive acceleratedRenderingStateChanged() when video element switches sources
https://bugs.webkit.org/show_bug.cgi?id=229092
<rdar://81902163>
Reviewed by Eric Carlson.
Follow up to r280723; in that patch, a call to acceleratedRenderingStateChanged() was added to
the MediaPlayerPrivateRemote, but only for non-Cocoa ports. Add the same method to the constructor
for the Cocoa version as well.
- WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm: (WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:23 PM Changeset in webkit [281048] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r281012
https://bugs.webkit.org/show_bug.cgi?id=228861
Add missing constructor signature when USE(CFURLCONNECTION) is true.
- platform/network/cf/ResourceError.h:
- platform/network/cf/ResourceErrorCF.cpp: Add missing constructor signature.
(WebCore::ResourceError::ResourceError):
- 3:18 PM Changeset in webkit [281047] by
-
- 1 copy in tags/Safari-612.1.27.2.3
Tag Safari-612.1.27.2.3.
- 3:14 PM Changeset in webkit [281046] by
-
- 2 edits in branches/safari-612.1.27.2-branch/Source/JavaScriptCore
Cherry-pick r280996. rdar://problem/81901248
Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054
Reviewed by Keith Miller and Robin Morisset.
This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.
Verified with a diff of
otool -tvdumps of the built JavaScriptCore binaries,
that there are no diffs in the generated code from this change.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:14 PM Changeset in webkit [281045] by
-
- 3 edits in branches/safari-612.1.27.2-branch/Source/JavaScriptCore
Cherry-pick r280984. rdar://problem/81901248
Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962
<rdar://79883337>
Reviewed by Mark Lam.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash): (JSC::ARM64EHash::setUpdatedHash): (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::finalize): (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::putIntegralUnchecked): (JSC::AssemblerBuffer::hash const):
- assembler/LinkBuffer.cpp: (JSC::LinkBuffer::copyCompactAndLinkCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:14 PM Changeset in webkit [281044] by
-
- 2 edits in trunk/Source/WebKit
[Cocoa] RemoteMediaPlayerProxy does not receive acceleratedRenderingStateChanged() when video element switches sources
https://bugs.webkit.org/show_bug.cgi?id=229092
<rdar://81902163>
Reviewed by Eric Carlson.
Follow up to r280723; in that patch, a call to acceleratedRenderingStateChanged() was added to
the MediaPlayerPrivateRemote, but only for non-Cocoa ports. Add the same method to the constructor
for the Cocoa version as well.
- WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
- 3:13 PM Changeset in webkit [281043] by
-
- 8 edits in branches/safari-612.1.27.2-branch/Source
Versioning.
WebKit-7612.1.27.2.3
- 3:09 PM Changeset in webkit [281042] by
-
- 1 copy in tags/Safari-612.1.27.3.4
Tag Safari-612.1.27.3.4.
- 3:08 PM Changeset in webkit [281041] by
-
- 2 edits in branches/safari-612.1.27.3-branch/Source/JavaScriptCore
Cherry-pick r280996. rdar://problem/81901248
Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054
Reviewed by Keith Miller and Robin Morisset.
This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.
Verified with a diff of
otool -tvdumps of the built JavaScriptCore binaries,
that there are no diffs in the generated code from this change.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:08 PM Changeset in webkit [281040] by
-
- 3 edits in branches/safari-612.1.27.3-branch/Source/JavaScriptCore
Cherry-pick r280984. rdar://problem/81901248
Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962
<rdar://79883337>
Reviewed by Mark Lam.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash): (JSC::ARM64EHash::setUpdatedHash): (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::finalize): (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::putIntegralUnchecked): (JSC::AssemblerBuffer::hash const):
- assembler/LinkBuffer.cpp: (JSC::LinkBuffer::copyCompactAndLinkCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:05 PM Changeset in webkit [281039] by
-
- 8 edits in branches/safari-612.1.27.3-branch/Source
Versioning.
WebKit-7612.1.27.3.4
- 3:04 PM Changeset in webkit [281038] by
-
- 2 edits in trunk/LayoutTests
[ Win EWS ] http/tests/misc/webtiming-slow-load.py is failing.
https://bugs.webkit.org/show_bug.cgi?id=229099
Unreviewed test gardening.
- platform/win/TestExpectations:
- 3:03 PM Changeset in webkit [281037] by
-
- 1 copy in tags/Safari-612.1.28.1
Tag Safari-612.1.28.1.
- 2:42 PM Changeset in webkit [281036] by
-
- 2 edits in trunk/LayoutTests
[ Win EWS ] fast/forms/caps-lock-indicator-width.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=229098
Unreviewed test gardening.
- platform/win/TestExpectations:
- 2:22 PM Changeset in webkit [281035] by
-
- 8 edits in branches/safari-612.1.28-branch/Source
Versioning.
WebKit-7612.1.28.1
- 2:03 PM Changeset in webkit [281034] by
-
- 1 copy in tags/Safari-612.1.28
Tag Safari-612.1.28.
- 2:02 PM Changeset in webkit [281033] by
-
- 1 delete in tags/Safari-612.1.28
Delete tag.
- 1:53 PM Changeset in webkit [281032] by
-
- 20 edits in trunk/Source/WebKit
SandboxExtension::Handle creation should return std::optional instead of bool
https://bugs.webkit.org/show_bug.cgi?id=228875
Patch by Alex Christensen <achristensen@webkit.org> on 2021-08-13
Reviewed by Youenn Fablet.
This modernizes the code somewhat.
This makes it easier to write code that realizes that handle creation can fail.
This is a step towards removing the unnecessary abstraction HandleArray.
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
- Platform/IPC/FormDataReference.h:
(IPC::FormDataReference::encode const):
- Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandle):
(WebKit::createHandlesForResources):
(WebKit::SandboxExtension::createReadOnlyHandlesForFiles):
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
(WebKit::SandboxExtension::createHandleForTemporaryFile):
(WebKit::SandboxExtension::createHandleForGenericExtension):
(WebKit::SandboxExtension::createHandleForMachLookup):
(WebKit::SandboxExtension::createHandlesForMachLookup):
(WebKit::SandboxExtension::createHandleForReadByAuditToken):
(WebKit::SandboxExtension::createHandleForIOKitClassExtension):
(WebKit::SandboxExtension::createHandlesForIOKitClassExtensions):
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::createHandle):
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
(WebKit::SandboxExtension::createHandleForTemporaryFile):
(WebKit::SandboxExtension::createHandleForGenericExtension):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::addPlatformLoadParameters):
(WebKit::WebPageProxy::createSandboxExtensionsIfNeeded): Deleted.
(WebKit::WebPageProxy::scrollingUpdatesDisabledForTesting): Deleted.
(WebKit::WebPageProxy::startDrag): Deleted.
(WebKit::WebPageProxy::setPromisedDataForImage): Deleted.
(WebKit::WebPageProxy::setDragCaretRect): Deleted.
(WebKit::WebPageProxy::platformRegisterAttachment): Deleted.
(WebKit::WebPageProxy::platformCloneAttachment): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection): Deleted.
(WebKit::WebPageProxy::insertDictatedTextAsync): Deleted.
(WebKit::WebPageProxy::platformDictationAlternatives): Deleted.
(WebKit::WebPageProxy::errorForUnpermittedAppBoundDomainNavigation): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorConnection): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorBoundInterfaceIdentifier): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorSourceApplicationBundleIdentifier): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorSourceApplicationSecondaryIdentifier): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorAddMessageReceiver): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorRemoveMessageReceiver): Deleted.
(WebKit::WebPageProxy::didStartSpeaking): Deleted.
(WebKit::WebPageProxy::didFinishSpeaking): Deleted.
(WebKit::WebPageProxy::didPauseSpeaking): Deleted.
(WebKit::WebPageProxy::didResumeSpeaking): Deleted.
(WebKit::WebPageProxy::speakingErrorOccurred): Deleted.
(WebKit::WebPageProxy::boundaryEventOccurred): Deleted.
(WebKit::WebPageProxy::voicesDidChange): Deleted.
(WebKit::WebPageProxy::didCreateContextInWebProcessForVisibilityPropagation): Deleted.
(WebKit::WebPageProxy::didCreateContextInGPUProcessForVisibilityPropagation): Deleted.
(WebKit::WebPageProxy::grantAccessToPreferenceService): Deleted.
(WebKit::WebPageProxy::mediaUsageManager): Deleted.
(WebKit::WebPageProxy::addMediaUsageManagerSession): Deleted.
(WebKit::WebPageProxy::updateMediaUsageManagerSessionState): Deleted.
(WebKit::WebPageProxy::removeMediaUsageManagerSession): Deleted.
(WebKit::convertPlatformImageToBitmap): Deleted.
(WebKit::WebPageProxy::requestThumbnailWithOperation): Deleted.
(WebKit::WebPageProxy::requestThumbnailWithFileWrapper): Deleted.
(WebKit::WebPageProxy::requestThumbnailWithPath): Deleted.
(WebKit::WebPageProxy::scheduleActivityStateUpdate): Deleted.
(WebKit::WebPageProxy::addActivityStateUpdateCompletionHandler): Deleted.
(WebKit::WebPageProxy::createAppHighlightInSelectedRange): Deleted.
(WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex): Deleted.
(WebKit::WebPageProxy::setAppHighlightsVisibility): Deleted.
(WebKit::WebPageProxy::appHighlightsVisibility): Deleted.
(WebKit::WebPageProxy::appHighlightsOverlayRect): Deleted.
(WebKit::WebPageProxy::setUpHighlightsObserver): Deleted.
(WebKit::WebPageProxy::createNetworkExtensionsSandboxExtensions): Deleted.
(WebKit::WebPageProxy::canHandleContextMenuTranslation const): Deleted.
(WebKit::WebPageProxy::handleContextMenuTranslation): Deleted.
(WebKit::WebPageProxy::requestActiveNowPlayingSessionInfo): Deleted.
(WebKit::WebPageProxy::setLastNavigationWasAppInitiated): Deleted.
(WebKit::WebPageProxy::lastNavigationWasAppInitiated): Deleted.
(WebKit::WebPageProxy::grantAccessToAssetServices): Deleted.
(WebKit::WebPageProxy::revokeAccessToAssetServices): Deleted.
(WebKit::WebPageProxy::switchFromStaticFontRegistryToUserFontRegistry): Deleted.
(WebKit::WebPageProxy::fontdMachExtensionHandle): Deleted.
(WebKit::WebPageProxy::contentsOfUserInterfaceItem): Deleted.
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::getPasteboardPathnamesForType):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess): Deleted.
(WebKit::WebProcessPool::platformInvalidateContext): Deleted.
(WebKit::WebProcessPool::parentBundleDirectory): Deleted.
(WebKit::WebProcessPool::networkingCachesDirectory): Deleted.
(WebKit::WebProcessPool::webContentCachesDirectory): Deleted.
(WebKit::WebProcessPool::containerTemporaryDirectory): Deleted.
(WebKit::WebProcessPool::setJavaScriptConfigurationFileEnabledFromDefaults): Deleted.
(WebKit::WebProcessPool::omitPDFSupport): Deleted.
(WebKit::WebProcessPool::processSuppressionEnabled const): Deleted.
(WebKit::WebProcessPool::displayBrightness): Deleted.
(WebKit::WebProcessPool::backlightLevelDidChangeCallback): Deleted.
(WebKit::WebProcessPool::accessibilityPreferencesChangedCallback): Deleted.
(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback): Deleted.
(WebKit::WebProcessPool::colorPreferencesDidChangeCallback): Deleted.
(WebKit::WebProcessPool::remoteWebInspectorEnabledCallback): Deleted.
(WebKit::WebProcessPool::startObservingPreferenceChanges): Deleted.
(WebKit::WebProcessPool::registerNotificationObservers): Deleted.
(WebKit::WebProcessPool::unregisterNotificationObservers): Deleted.
(WebKit::WebProcessPool::isURLKnownHSTSHost const): Deleted.
(WebKit::WebProcessPool::nominalFramesPerSecondForDisplay): Deleted.
(WebKit::WebProcessPool::startDisplayLink): Deleted.
(WebKit::WebProcessPool::stopDisplayLink): Deleted.
(WebKit::WebProcessPool::stopDisplayLinks): Deleted.
(WebKit::WebProcessPool::setDisplayLinkPreferredFramesPerSecond): Deleted.
(WebKit::WebProcessPool::setDisplayLinkForDisplayWantsFullSpeedUpdates): Deleted.
(WebKit::WebProcessPool::setCookieStoragePartitioningEnabled): Deleted.
(WebKit::WebProcessPool::clearPermanentCredentialsForProtectionSpace): Deleted.
(WebKit::networkProcessLatencyQOS): Deleted.
(WebKit::networkProcessThroughputQOS): Deleted.
(WebKit::webProcessLatencyQOS): Deleted.
(WebKit::webProcessThroughputQOS): Deleted.
(WebKit::WebProcessPool::applicationIsAboutToSuspend): Deleted.
(WebKit::WebProcessPool::notifyProcessPoolsApplicationIsAboutToSuspend): Deleted.
(WebKit::WebProcessPool::initializeClassesForParameterCoding): Deleted.
(WebKit::WebProcessPool::allowedClassesForParameterCoding const): Deleted.
(WebKit::WebProcessPool::notifyPreferencesChanged): Deleted.
(WebKit::webProcessPoolHighDynamicRangeDidChangeCallback): Deleted.
(WebKit::WebProcessPool::registerHighDynamicRangeChangeCallback): Deleted.
(WebKit::WebProcessPool::systemWillSleep): Deleted.
(WebKit::WebProcessPool::systemDidWake): Deleted.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::publishProgress):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::GPUProcessProxy):
(WebKit::addCameraSandboxExtensions):
(WebKit::addMicrophoneSandboxExtension):
(WebKit::addTCCDSandboxExtension):
(WebKit::gpuProcessSessionParameters):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
(WebKit::NetworkProcessProxy::retrieveCacheStorageParameters):
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp:
(WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::addSource):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
- UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::willCreateMediaStream):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::webProcessDataStoreParameters):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::startMemorySampler):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::parameters):
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerFileBlobURL):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::load):
- 1:14 PM Changeset in webkit [281031] by
-
- 4 edits in branches/safari-612.1.27.0-branch/Tools
Cherry-pick r281023. rdar://problem/81868773
[webkitscmpy] Fix SVN relative URL parsing
https://bugs.webkit.org/show_bug.cgi?id=229075
<rdar://problem/81868773>
Reviewed by Aakash Jain.
- Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py: (Svn.branch): Check if relative URL path contains local path before stripping local path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:30 PM Changeset in webkit [281030] by
-
- 4 edits in trunk
Use profile auto level for WebRTC H264 encoder on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=229071
<rdar://80345048>
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
AS H264 encoder will fail if its profile is too low compared to the size of the video.
Use autolevel to prevent this.
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
LayoutTests:
- platform/mac/TestExpectations:
- 12:29 PM Changeset in webkit [281029] by
-
- 4 edits1 add in trunk
EnumeratorNextUpdatePropertyName always needs to be able to handle IndexedMode
https://bugs.webkit.org/show_bug.cgi?id=229087
Reviewed by Filip Pizlo.
JSTests:
- stress/for-in-own-structure-and-generic-with-late-add-indexed.js: Added.
(test):
(Foo):
Source/JavaScriptCore:
Right now, this operation incorrectly assumes that EnumeratorNextUpdateIndexAndMode will guarantee
the mode matches the seen mode set. But no speculation is guaranteed and adding such a guarantee
would require adding checkpoints, which is likely not worth it. Instead, this patch just makes
sure we always handle the allocation for IndexedMode.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileEnumeratorNextUpdatePropertyName):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- 12:10 PM Changeset in webkit [281028] by
-
- 1 copy in tags/Safari-611.4.0.1
Tag Safari-611.4.0.1.
- 12:10 PM Changeset in webkit [281027] by
-
- 1 delete in tags/Safari-611.4.0.1
Delete tag.
- 11:58 AM Changeset in webkit [281026] by
-
- 2 edits in branches/safari-611.3.10.0-branch/Source/WebCore
Cherry-pick r278729. rdar://problem/80310242
Fix incorrect check in AudioNode.disconnect()
https://bugs.webkit.org/show_bug.cgi?id=226818
<rdar://problem/79076999>
Reviewed by Eric Carlson.
- Modules/webaudio/AudioNode.cpp: (WebCore::AudioNode::disconnect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:58 AM Changeset in webkit [281025] by
-
- 22 edits2 deletes in trunk
Unreviewed, reverting r281009.
Timing not quite right
Reverted changeset:
"Unprefix -webkit-backface-visibility"
https://bugs.webkit.org/show_bug.cgi?id=170983
https://commits.webkit.org/r281009
- 11:39 AM Changeset in webkit [281024] by
-
- 1 copy in tags/Safari-611.4.0.1
Tag Safari-611.4.0.1.
- 10:24 AM Changeset in webkit [281023] by
-
- 4 edits in trunk/Tools
[webkitscmpy] Fix SVN relative URL parsing
https://bugs.webkit.org/show_bug.cgi?id=229075
<rdar://problem/81868773>
Reviewed by Aakash Jain.
- Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn.branch): Check if relative URL path contains local path before stripping local path.
- 9:50 AM Changeset in webkit [281022] by
-
- 68 edits11 deletes in branches/safari-612.1.28-branch
Revert r280760. rdar://problem/81903894
- 9:39 AM Changeset in webkit [281021] by
-
- 2 edits in trunk/LayoutTests
[ BigSur Debug wk2 EWS ] webrtc/video-interruption.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=229076
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 8:57 AM Changeset in webkit [281020] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows.
https://bugs.webkit.org/show_bug.cgi?id=228325.
Unreviewed test gardening.
- platform/win/TestExpectations:
- 8:38 AM Changeset in webkit [281019] by
-
- 3 edits in branches/safari-612.1.28-branch/Source/WebCore
Cherry-pick r281008. rdar://problem/81901037
Fix bounds checks for WhitespaceCache string lengths
https://bugs.webkit.org/show_bug.cgi?id=229066
<rdar://81850871>
Reviewed by Simon Fraser.
When the whitespace string length is maximumWhitespaceStringLength,
we read from and write to one element past the end of m_codes and
m_indexes. Since we don't need to store codes and indexes for zero
length strings, subtract one from the index we use.
- html/parser/HTMLConstructionSite.cpp: (WebCore::WhitespaceCache::lookup):
- html/parser/HTMLConstructionSite.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:30 AM Changeset in webkit [281018] by
-
- 2 edits in branches/safari-612.1.27.0-branch/Source/JavaScriptCore
Cherry-pick r280996. rdar://problem/81901248
Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054
Reviewed by Keith Miller and Robin Morisset.
This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.
Verified with a diff of
otool -tvdumps of the built JavaScriptCore binaries,
that there are no diffs in the generated code from this change.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:30 AM Changeset in webkit [281017] by
-
- 3 edits in branches/safari-612.1.27.0-branch/Source/JavaScriptCore
Cherry-pick r280984. rdar://problem/81901248
Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962
<rdar://79883337>
Reviewed by Mark Lam.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash): (JSC::ARM64EHash::setUpdatedHash): (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::finalize): (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::putIntegralUnchecked): (JSC::AssemblerBuffer::hash const):
- assembler/LinkBuffer.cpp: (JSC::LinkBuffer::copyCompactAndLinkCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:29 AM Changeset in webkit [281016] by
-
- 8 edits in branches/safari-612.1.27.0-branch/Source
Versioning.
WebKit-7612.1.27.0.22
- 7:40 AM Changeset in webkit [281015] by
-
- 3 edits in trunk/Tools
[WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=229067
Reviewed by Carlos Garcia Campos.
- TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebKitWebViewProcessCrashed): Make warnings non-fatal while waiting for the crash.
- TestWebKitAPI/glib/TestExpectations.json: Remove expectation
- 7:16 AM Changeset in webkit [281014] by
-
- 3 edits in trunk/Source/WebCore
Check for dialog existence in top layer in HTMLDialogElement::showModal & close
https://bugs.webkit.org/show_bug.cgi?id=227907
Reviewed by Antti Koivisto.
Test: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
Test expectations are unchanged because the test uses elementFromPoint, meaning that behaviour difference isn't noticeable
until top layer rendering bits are implemented (which would change elementFromPoint's result by shuffling z-order based on top layer elements).
- dom/Element.h:
(WebCore::Element::isInTopLayer const):
- html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):
- 4:57 AM Changeset in webkit [281013] by
-
- 2 edits in trunk/Source/WebCore
nexttrack and previoustrack MediaSession handlers not working
https://bugs.webkit.org/show_bug.cgi?id=229068
rdar://80100092
Reviewed by Youenn Fablet.
Map between MediaSession action next/previousTrack and RemoteControlCommandType ones
were inverted.
There is no infrastrure in place to ensure that the right MRMediaRemoteCommand is
used with the MediaRemote backend, which prevents automating the test.
- Modules/mediasession/MediaSession.cpp:
(WebCore::platformCommandForMediaSessionAction):
- 3:22 AM Changeset in webkit [281012] by
-
- 62 edits in trunk
Overly verbose catchable fetch error messages lead to cross-origin leaks
https://bugs.webkit.org/show_bug.cgi?id=228861
Reviewed by Brent Fulgham.
LayoutTests/imported/w3c:
Rebasing tests with new error message.
- web-platform-tests/FileAPI/url/url-with-fetch.any-expected.txt:
- web-platform-tests/FileAPI/url/url-with-fetch.any.worker-expected.txt:
- web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt:
- web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt:
- web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub-expected.txt:
- web-platform-tests/fetch/api/cors/cors-cookies.any.worker-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
- web-platform-tests/fetch/http-cache/cc-request.any-expected.txt:
- web-platform-tests/fetch/http-cache/cc-request.any.worker-expected.txt:
- web-platform-tests/html/cross-origin-embedder-policy/coep-on-response-from-service-worker.https-expected.txt:
- web-platform-tests/html/cross-origin-embedder-policy/none-sw-from-none.https-expected.txt:
- web-platform-tests/html/cross-origin-embedder-policy/none-sw-from-require-corp.https-expected.txt:
- web-platform-tests/html/cross-origin-embedder-policy/require-corp-sw-from-none.https-expected.txt:
- web-platform-tests/html/cross-origin-embedder-policy/require-corp-sw-from-require-corp.https-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/credentials.sub-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/credentials.sub-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/module/credentials.sub-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials-setTimeout.sub-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials.sub-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-referrer-policy.https-expected.txt:
- web-platform-tests/service-workers/service-worker/import-scripts-cross-origin.https-expected.txt:
- web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:
- web-platform-tests/wasm/jsapi/table/constructor-reftypes.tentative.any.worker-expected.txt:
- web-platform-tests/wasm/jsapi/table/grow-reftypes.tentative.any.worker-expected.txt:
- web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any.worker-expected.txt:
Source/WebCore:
Standardize error messages to get more uniform with other browsers.
To continue supporting service worker errors going to page errors,
we add a boolean to ResourceError to control whether sanitizing the error message or not.
This allows to keep error messages from service worker type exceptions to be exposed in window environments through fetch rejection.
Also handle ScriptModuleLoader since it is doing its own SRI checks.
Covered by rebased tests.
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::loadingException const):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didFail):
- platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::sanitizedDescription const):
(WebCore::ResourceErrorBase::isSanitized const):
(WebCore::ResourceErrorBase::setAsSanitized):
(WebCore::ResourceErrorBase::ResourceErrorBase):
- platform/network/cf/ResourceError.h:
(WebCore::ResourceError::ResourceError):
- platform/network/curl/ResourceError.h:
(WebCore::ResourceError::ResourceError):
- platform/network/soup/ResourceError.h:
(WebCore::ResourceError::ResourceError):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
- workers/service/FetchEvent.cpp:
(WebCore::FetchEvent::createResponseError):
(WebCore::FetchEvent::respondWith):
(WebCore::FetchEvent::promiseIsSettled):
- workers/service/FetchEvent.h:
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse):
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
- bindings/js/ScriptModuleLoader.cpp:
(WebCore::ScriptModuleLoader::notifyFinished):
Source/WebKit:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceError>::encode):
(IPC::ArgumentCoder<ResourceError>::decode):
LayoutTests:
- http/tests/contentextensions/block-ping-resource-type-raw-expected.txt:
- http/tests/contentextensions/fetch-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
- http/tests/subresource-integrity/sri-module-expected.txt:
- http/tests/workers/service/shift-reload-navigation-expected.txt:
- http/tests/workers/resources/worker-importScripts.js: changed error logging for better readability.
- http/tests/workers/worker-importScripts-expected.txt:
- http/wpt/service-workers/cors-preflight-star.any-serviceworker-expected.txt:
- js/dom/modules/module-fetch-failure-not-cached-expected.txt:
- platform/mac-wk1/http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
- platform/mac-wk1/http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/FileAPI/url/url-with-fetch.any-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/FileAPI/url/url-with-fetch.any.worker-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.any-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.any.worker-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/cc-request.any-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/cc-request.any.worker-expected.txt:
- 2:38 AM Changeset in webkit [281011] by
-
- 3 edits in trunk/Source/WebCore
Crash in MockMediaSourcePrivate
https://bugs.webkit.org/show_bug.cgi?id=226795
Reviewed by Darin Adler.
The MockMediaPlayerMediaSource uses callOnMainThread() to execute advanceCurrentTime(). It might
happen that the object is destructed before the callback is executed as it isn't a ref counted
object. That leads to a crash on ASAN builds.
Made the object capable of creating weak ptrs so that we could check whether the _this_ object
has been freed in the meantime or not. For the former case we just bail out.
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::play): Create a WeakPtr.
(WebCore::MockMediaPlayerMediaSource::seekWithTolerance): Ditto.
(WebCore::MockMediaPlayerMediaSource::seekCompleted): Ditto.
- platform/mock/mediasource/MockMediaPlayerMediaSource.h: inherit from CanMakeWeakPtr.
- 1:40 AM Changeset in webkit [281010] by
-
- 11 edits in trunk
Get lint-test-expectations passing
https://bugs.webkit.org/show_bug.cgi?id=228999
Reviewed by Ryan Haddad.
Tools:
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder._is_test_file): Added a list of patterns for tests to skip
and ensured that 'boot.xml' and 'root.xml' (spurious files created during
the run of the WebKit1 bot) are on the list.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
(LayoutTestFinderTests.test_is_test_file): Added a test for the changes.
LayoutTests:
- TestExpectations: Remove expectation for non-existent test.
- platform/ios-simulator/TestExpectations: Ditto.
- platform/ios-wk2/TestExpectations: Ditto.
- platform/ios/TestExpectations: Dito.
- platform/mac-wk1/TestExpectations: Ditto. Also, the expectations for the non-test
'boot.xml' and 'root.xml' have been moved to workarounds in webkitpy.
- platform/mac/TestExpectations: Remove references to non-existent tests. Also combined
one expectation that was not linting due to a problem like the one described in bug
120081.
- platform/win/TestExpectations: Ditto.
Aug 12, 2021:
- 11:46 PM Changeset in webkit [281009] by
-
- 22 edits2 adds in trunk
Unprefix -webkit-backface-visibility
https://bugs.webkit.org/show_bug.cgi?id=170983
Patch by Alex Christensen <achristensen@webkit.org> on 2021-08-12
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-transforms/css-transform-property-existence-expected.txt: Added.
- web-platform-tests/css/css-transforms/css-transform-property-existence.html: Added.
- web-platform-tests/css/css-transforms/parsing/backface-visibility-computed-expected.txt:
- web-platform-tests/css/css-transforms/parsing/backface-visibility-valid-expected.txt:
- web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
This has already been done by Chrome and Firefox.
Keep the prefixed version as an alias.
Test: imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence.html
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSProperties.json:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
LayoutTests:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/ios/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- 10:45 PM Changeset in webkit [281008] by
-
- 3 edits in trunk/Source/WebCore
Fix bounds checks for WhitespaceCache string lengths
https://bugs.webkit.org/show_bug.cgi?id=229066
<rdar://81850871>
Reviewed by Simon Fraser.
When the whitespace string length is maximumWhitespaceStringLength,
we read from and write to one element past the end of m_codes and
m_indexes. Since we don't need to store codes and indexes for zero
length strings, subtract one from the index we use.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::WhitespaceCache::lookup):
- html/parser/HTMLConstructionSite.h:
- 8:58 PM Changeset in webkit [281007] by
-
- 3 edits in trunk/Source/WebKit
REGRESSION (r280951): [ Big Sur ] TestWebKitAPI.AudioRoutingArbitration.Close is failing
https://bugs.webkit.org/show_bug.cgi?id=229040
Reviewed by Eric Carlson.
Function
AudioSessionRoutingArbitratorProxy::processDidTerminate()should
be called only in the case that the corresponding WebContent process exits,
whereasGPUProcessConnection::didClose()(in WebContent process) deals with
the case that the GPU process crashes.
No new tests. Fix an API test failure.
- UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:
(WebKit::AudioSessionRoutingArbitratorProxy::processDidTerminate):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::gpuProcessExited):
- 8:34 PM Changeset in webkit [281006] by
-
- 2 edits in trunk/Tools
[WPE] Gardening web-process-crashed API test failure
Unreviewed test gardening.
- TestWebKitAPI/glib/TestExpectations.json:
- 7:06 PM Changeset in webkit [281005] by
-
- 2 edits in branches/safari-611.3.10.0-branch/Source/JavaScriptCore
Cherry-pick r280996. rdar://problem/81752592
Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054
Reviewed by Keith Miller and Robin Morisset.
This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.
Verified with a diff of
otool -tvdumps of the built JavaScriptCore binaries,
that there are no diffs in the generated code from this change.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:06 PM Changeset in webkit [281004] by
-
- 3 edits in branches/safari-611.3.10.0-branch/Source/JavaScriptCore
Cherry-pick r280984. rdar://problem/81752592
Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962
<rdar://79883337>
Reviewed by Mark Lam.
- assembler/AssemblerBuffer.h: (JSC::ARM64EHash::makeDiversifier): (JSC::ARM64EHash::nextValue): (JSC::ARM64EHash::bitsForDiversifier): (JSC::ARM64EHash::currentHash): (JSC::ARM64EHash::setUpdatedHash): (JSC::ARM64EHash::ARM64EHash): (JSC::ARM64EHash::update): (JSC::ARM64EHash::finalize): (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::putIntegralUnchecked): (JSC::AssemblerBuffer::hash const):
- assembler/LinkBuffer.cpp: (JSC::LinkBuffer::copyCompactAndLinkCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:40 PM Changeset in webkit [281003] by
-
- 1 copy in tags/Safari-612.1.27.0.8
Tag Safari-612.1.27.0.8.
- 6:26 PM Changeset in webkit [281002] by
-
- 3 edits5 adds in trunk/LayoutTests
[GTK][WPE] Gardening of layout test failures
Unreviewed gardening
Rebaseline tests after r280953 and r279838 and report and mark new expected failures.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/header-parsing.https-expected.txt: Added.
- platform/gtk/TestExpectations:
- 6:13 PM Changeset in webkit [281001] by
-
- 2 edits in trunk/Source/WebCore
ThreadSanitizer: data race in WebCore::CARingBufferStorageVector::setCurrentFrameBounds() / getCurrentFrameBounds()
<https://webkit.org/b/229014>
<rdar://problem/81817224>
Reviewed by Chris Dumez.
This turned out to be a false-positive since reads and writes
are protected differently, and it's okay if a read returns data
from the ring buffer that is one slot older than the current
write.
Covered by layout tests running with TSan:
fast/mediastream/getUserMedia-webaudio.html
fast/mediastream/mediastreamtrack-audio-clone.html
imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-insertDTMF.https.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-track-stats.https.html
imported/w3c/web-platform-tests/webrtc/protocol/missing-fields.html
webrtc/audio-peer-connection-g722.html
webrtc/audio-peer-connection-webaudio.html
webrtc/audio-replace-track.html
webrtc/peer-connection-audio-mute.html
webrtc/peer-connection-audio-mute2.html
webrtc/peer-connection-createMediaStreamDestination.html
webrtc/peer-connection-remote-audio-mute.html
webrtc/peer-connection-remote-audio-mute2.html
- platform/audio/cocoa/CARingBuffer.cpp:
(WebCore::CARingBufferStorageVector::getCurrentFrameBounds):
(WebCore::CARingBufferStorageVector::currentStartFrame const):
(WebCore::CARingBufferStorageVector::currentEndFrame const):
- Add SUPPRESS_TSAN attribute since reads are protected by std::atomic<int32_t> m_timeBoundsQueuePtr only being incremented after the next m_timeBoundsQueue slot is updated. Writes are potected by Locker locker { m_currentFrameBoundsLock }.
- 5:36 PM Changeset in webkit [281000] by
-
- 1 copy in tags/Safari-612.1.27.0.21
Tag Safari-612.1.27.0.21.
- 5:08 PM Changeset in webkit [280999] by
-
- 2 edits in trunk/Source/WebKitLegacy/mac
Regression(r273194) Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased
https://bugs.webkit.org/show_bug.cgi?id=229056
Reviewed by Geoffrey Garen.
Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased. I got this wrong
in r273194.
- Misc/WebNSObjectExtras.mm:
(-[WebMainThreadInvoker forwardInvocation:]):
- 5:04 PM Changeset in webkit [280998] by
-
- 8 edits in branches/safari-612.1.27.0.6-branch/Source
Cherry-pick r280776. rdar://problem/81861548
[Cocoa|GPU] platformLayer() not always added to remotedly hosted context; black video while playing
https://bugs.webkit.org/show_bug.cgi?id=228873
<rdar://81271107>
Reviewed by Eric Carlson.
Source/WebCore:
Coalesce calls to renderingModeChanged() by setting a flag to call renderingModeChanged() in
the next run loop, and call into this coalescing method, setNeedsRenderingModeChanged(),
whenever the MediaPlayerPrivateAVFoundation subclasses create or destroy a video layer
or software painting context. This ensures that the MediaPlayerClient is always notified
when the rendering mode changes, regardless of why that change occurred.
Drive-by fix: replace the call in createVideoLayer() to "callOnMainThread()"
with "ensureOnMainThread()". The call to "callOnMainThread()" was added to avoid a
deadlock in WebKitLegacy, and "ensureOnMainThread()" has the correct behavior there, but
will be synchronous in WebKit.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering): (WebCore::MediaPlayerPrivateAVFoundation::setNeedsRenderingModeChanged): (WebCore::MediaPlayerPrivateAVFoundation::renderingModeChanged): (WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::MediaPlayerPrivateAVFoundationCF::destroyVideoLayer): (WebCore::AVFWrapper::createAVCFVideoLayer): (WebCore::AVFWrapper::createImageGenerator): (WebCore::AVFWrapper::destroyImageGenerator):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoOutput):
Source/WebKit:
Currently, the RemoteMediaPlayerProxy will insert its MediaPlayer's platformLayer() into the
remotely hosted context when it receives a "firstVideoFrameAvailable()" notification.
However this is problematic for two reasons: AVPlayerLayer may not become "ready for
playback" when it is not in an active CALayer heirarchy, and for
MediaPlayerPrivateAVFoundation, firstVideoFrameAvailable() is only fired during
updateStates(), which is not guaranteed to occur unless another state change occurs.
Instead, reparent the MediaPlayer's platformLayer() when we receive a
mediaPlayerRenderingModeChanged() notification, which notifies the client whenever a
platformLayer() is created or destroyed.
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
- GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm: (WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable): (WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:01 PM Changeset in webkit [280997] by
-
- 8 edits in branches/safari-612.1.27.0.6-branch/Source
Versioning.
WebKit-7612.1.27.0.8
- 4:49 PM Changeset in webkit [280996] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054
Reviewed by Keith Miller and Robin Morisset.
This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.
Verified with a diff of
otool -tvdumps of the built JavaScriptCore binaries,
that there are no diffs in the generated code from this change.
- assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):
- 4:34 PM Changeset in webkit [280995] by
-
- 1 copy in tags/Safari-612.1.15.4.16
Tag Safari-612.1.15.4.16.
- 4:31 PM Changeset in webkit [280994] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 ] imported/w3c/web-platform-tests/FileAPI/url/url-in-tags.window.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=229058
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:30 PM Changeset in webkit [280993] by
-
- 2 edits in branches/safari-612.1.15.4-branch/Source/WebInspectorUI/WebInspectorUI.vcxproj
Apply patch. rdar://problem/81727006
- 4:26 PM Changeset in webkit [280992] by
-
- 2 edits in trunk/Tools
REGRESSION (iPadOS 14): [ iPadOS wk2 ] TestWebKitAPI.ServiceWorkers.SuspendNetworkProcess is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217714
<rdar://problem/70296664>
Reviewed by Geoffrey Garen.
Give the database some time to get written out to disk before we try and suspend the network process, to try
and address the flakiness.
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- 4:17 PM Changeset in webkit [280991] by
-
- 8 edits in branches/safari-612.1.15.4-branch/Source
Versioning.
WebKit-7612.1.15.4.16
- 4:02 PM Changeset in webkit [280990] by
-
- 2 edits in trunk/LayoutTests
[ MacOS EWS ] 3 inspector/canvas/* tests are flaky failing/ crashing.
https://bugs.webkit.org/show_bug.cgi?id=229043
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:50 PM Changeset in webkit [280989] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Adding execution contexts after page load doesn't show a hidden execution selector
https://bugs.webkit.org/show_bug.cgi?id=229053
Reviewed by Devin Rousso.
Add a handler for execution contexts being added to update the display of the execution context list, as when
there is only a single context at page load the dropdown will be hidden and thus needs to be shown when an
execution context is added after page load.
- UserInterface/Views/QuickConsole.js:
(WI.QuickConsole):
(WI.QuickConsole.prototype._handleFrameExecutionContextAdded):
- 3:27 PM Changeset in webkit [280988] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, reverting r280977.
Seems to have broken a test in debug
Reverted changeset:
"Migrate Performance::resourceTimingBufferFullTimerFired to
HTML event loop"
https://bugs.webkit.org/show_bug.cgi?id=229044
https://commits.webkit.org/r280977
- 3:24 PM Changeset in webkit [280987] by
-
- 5 edits in branches/safari-612.1.27.0-branch/Source/WebKit
Cherry-pick r280981. rdar://problem/81870941
[GPU Process] REGRESSION: WebContent often crashes when using iCloud photos
https://bugs.webkit.org/show_bug.cgi?id=228969
<rdar://81761078>
Reviewed by Simon Fraser.
Terminating the GPUProcess is very stressful situation which has to be
handled carefully. The side effect of each function which is called through
gpuProcessConnectionDidClose() has to be understood to get the right
sequence of calls. There are problems in releasing all kinds of resources.
- Releasing NativeImage: Calling clearNativeImageMap() after clearing the backend of the ImageBuffers was causing a problem. When clearing the backend of an ImageBuffer, it will clear its DisplayList which may have the last reference to a NativeImage. The destructor of NativeImage calls releaseRemoteResource() before it is removed from the the NativeImageMap. This will send a message to the relaunched GPUP to release a NativeImage which is not in its cache.
- Releasing Font: clearFontMap() was always calling releaseRemoteResource() even if it is called form remoteResourceCacheWasDestroyed(). This should not happen because the connection with GPUProcess has been closed.
- Releasing ImageBuffer: This happen when a DisplayList of an ImageBuffer 'A' holds the last reference to another ImageBuffer 'B' and we call clearBackend() for 'A'. clearBackend() will clear the DisplayList of 'A' and causes the deletion of 'B'. In this case we should not call releaseImageBuffer() for 'B' because the GPUPProcess is closed.
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h: (WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy): If the ImageBuffer is being released because of the clean-up we do when the GPUProcess is terminated, we should not release the corresponding RemoteImageBuffer since it is already gone.
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: (WebKit::RemoteRenderingBackendProxy::isGPUProcessConnectionClosed const): This will return true if we are deleting a RemoteImageBufferProxy through RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed().
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: (WebKit::RemoteResourceCacheProxy::releaseAllRemoteFonts): This function will be used to release the remote fonts. It should be called from RemoteResourceCacheProxy::releaseMemory() where we sure the GPUP is alive and all the fonts are cached there.
(WebKit::RemoteResourceCacheProxy::clearFontMap):
The part of releasing the remote fonts was moved from this function to
releaseAllRemoteFonts().
(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
- Clearing the NativeImages and the Fonts has to come before clearing the backends of the ImageBuffers. The reason is clearBackend() clears the DisplayList which may release the last reference of a NativeImage or Font. We want to detach the NativeImages and the Fonts from the cache before then.
- We should have two different loops: one for clearing the backends of the ImageBuffers and another one for recreating these backends. The reason for this is clearBackend() clears the DisplayList which may release the last reference of a another source RemoteImageBufferProxy used by a DrawImageBuffer item for example.
(WebKit::RemoteResourceCacheProxy::releaseMemory):
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:13 PM Changeset in webkit [280986] by
-
- 7 edits in trunk
[ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing
https://bugs.webkit.org/show_bug.cgi?id=228285
rdar://81118724
Reviewed by Tim Horton and Aditya Keerthi.
Source/WebKit:
Add SPI declarations. See Tools/ChangeLog for more details.
- Platform/spi/ios/TextInputSPI.h:
- Platform/spi/ios/UIKitSPI.h:
Tools:
These three editing tests occasionally fail when synthesizing a double-tap gesture in order to select a word in
editable content. This happens because unless UIKit has observed at least one keypress event (e.g. from a
previous editing test), it presents the software keyboard underneath-[UIKeyboardImpl showKeyboardIfNeeded]
when setting the selection via UITextSelectionInteraction. This causes the input view frame to expand from the
collapsed (UCB) height of 44pt to the full software keyboard height, which in turn causes the second touch in
the synthesized double tap gesture to _sometimes_ hit-test to the wrong location, resulting in these test
failures.
To mitigate this, ensure that we have consistent behavior in layout tests when changing the text selection in
editable content by directly setting a TextInput default to make the keyboard behave as if it has previously
seen a keypress via the hardware keyboard.
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
LayoutTests:
Remove the flaky test failure expectations.
- platform/ios-wk2/TestExpectations:
- 1:49 PM Changeset in webkit [280985] by
-
- 2 edits in trunk/LayoutTests
[ MacOS EWS ] inspector/canvas/recording-webgl-snapshots.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=229043
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:45 PM Changeset in webkit [280984] by
-
- 3 edits in trunk/Source/JavaScriptCore
Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962
<rdar://79883337>
Reviewed by Mark Lam.
- assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):
(JSC::ARM64EHash::setUpdatedHash):
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::finalize):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::hash const):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
- 1:35 PM Changeset in webkit [280983] by
-
- 2 edits in trunk/Tools
Add myself (Patrick Angle) to watchlist for Inspector code changes
https://bugs.webkit.org/show_bug.cgi?id=229046
Reviewed by Darin Adler.
- Scripts/webkitpy/common/config/watchlist:
- 1:28 PM Changeset in webkit [280982] by
-
- 1 copy in tags/Safari-612.1.28
Tag Safari-612.1.28.
- 1:28 PM Changeset in webkit [280981] by
-
- 5 edits in trunk/Source/WebKit
[GPU Process] REGRESSION: WebContent often crashes when using iCloud photos
https://bugs.webkit.org/show_bug.cgi?id=228969
<rdar://81761078>
Reviewed by Simon Fraser.
Terminating the GPUProcess is very stressful situation which has to be
handled carefully. The side effect of each function which is called through
gpuProcessConnectionDidClose() has to be understood to get the right
sequence of calls. There are problems in releasing all kinds of resources.
- Releasing NativeImage: Calling clearNativeImageMap() after clearing the
backend of the ImageBuffers was causing a problem. When clearing the
backend of an ImageBuffer, it will clear its DisplayList which may have
the last reference to a NativeImage. The destructor of NativeImage calls
releaseRemoteResource() before it is removed from the the NativeImageMap.
This will send a message to the relaunched GPUP to release a NativeImage
which is not in its cache.
- Releasing Font: clearFontMap() was always calling releaseRemoteResource()
even if it is called form remoteResourceCacheWasDestroyed(). This should
not happen because the connection with GPUProcess has been closed.
- Releasing ImageBuffer: This happen when a DisplayList of an ImageBuffer
'A' holds the last reference to another ImageBuffer 'B' and we call
clearBackend() for 'A'. clearBackend() will clear the DisplayList of 'A'
and causes the deletion of 'B'. In this case we should not call
releaseImageBuffer() for 'B' because the GPUPProcess is closed.
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):
If the ImageBuffer is being released because of the clean-up we do when
the GPUProcess is terminated, we should not release the corresponding
RemoteImageBuffer since it is already gone.
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
(WebKit::RemoteRenderingBackendProxy::isGPUProcessConnectionClosed const):
This will return true if we are deleting a RemoteImageBufferProxy through
RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed().
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::releaseAllRemoteFonts):
This function will be used to release the remote fonts. It should be called
from RemoteResourceCacheProxy::releaseMemory() where we sure the GPUP is
alive and all the fonts are cached there.
(WebKit::RemoteResourceCacheProxy::clearFontMap):
The part of releasing the remote fonts was moved from this function to
releaseAllRemoteFonts().
(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
- Clearing the NativeImages and the Fonts has to come before clearing
the backends of the ImageBuffers. The reason is clearBackend() clears the
DisplayList which may release the last reference of a NativeImage or Font.
We want to detach the NativeImages and the Fonts from the cache before then.
- We should have two different loops: one for clearing the backends of
the ImageBuffers and another one for recreating these backends. The reason
for this is clearBackend() clears the DisplayList which may release the
last reference of a another source RemoteImageBufferProxy used by a
DrawImageBuffer item for example.
(WebKit::RemoteResourceCacheProxy::releaseMemory):
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
- 1:16 PM Changeset in webkit [280980] by
-
- 12 edits4 adds in trunk
Allow testing of the final UIView tree on iOS platforms
https://bugs.webkit.org/show_bug.cgi?id=229016
Reviewed by Tim Horton.
Source/WebKit:
Test: remote-layer-tree/ios/uiview-tree-basic.html
- UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
- UIProcess/API/ios/WKWebViewTestingIOS.mm:
(allowListedClassToString):
(dumpUIView):
(-[WKWebView _uiViewTreeAsText]):
Add partner SPI called _uiViewTreeAsText that dumps the WKWebView's
UIView tree as constructed via remote layer creation. It currently
dumps some basic properties of each view and uses an allow list of
class names so changes to implementation details in frameworks below
us, like UIKit, don't cause tests to fail.
Tools:
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::uiViewTreeAsText const):
- WebKitTestRunner/ios/UIScriptControllerIOS.h:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::uiViewTreeAsText const):
Pipe new _uiViewTreeAsText SPI through to UIScriptController, matching the pattern
established by scrollingTreeAsText.
LayoutTests:
- remote-layer-tree: Added.
- remote-layer-tree/ios: Added.
- remote-layer-tree/ios/uiview-tree-basic-expected.txt: Added.
- remote-layer-tree/ios/uiview-tree-basic.html: Added.
Add basic test case excercising UIView tree dumping to ensure
it is working properly.
- resources/ui-helper.js:
(window.UIHelper.getUIViewTree):
Add helper to use get the UIView tree as text.
- TestExpectations:
- platform/ios/TestExpectations:
Ensure these tests are only run on iOS.
- 1:16 PM Changeset in webkit [280979] by
-
- 8 edits in branches/safari-612.1.28-branch/Source
Versioning.
WebKit-7612.1.28
- 1:00 PM Changeset in webkit [280978] by
-
- 1 copy in branches/safari-612.1.28-branch
New branch.
- 12:25 PM Changeset in webkit [280977] by
-
- 3 edits in trunk/Source/WebCore
Migrate Performance::resourceTimingBufferFullTimerFired to HTML event loop
https://bugs.webkit.org/show_bug.cgi?id=229044
Patch by Alex Christensen <achristensen@webkit.org> on 2021-08-12
Reviewed by Geoff Garen.
Covered by existing tests.
There should be no change in behavior.
- page/Performance.cpp:
(WebCore::Performance::Performance):
(WebCore::Performance::addResourceTiming):
(WebCore::Performance::dispatchResourceTimingBufferFullEvent):
(WebCore::Performance::contextDestroyed): Deleted.
(WebCore::Performance::resourceTimingBufferFullTimerFired): Deleted.
- page/Performance.h:
- 12:16 PM Changeset in webkit [280976] by
-
- 5 edits in trunk/Source
[macOS] Enter fullscreen animation interferes with auto-hiding menu bar
https://bugs.webkit.org/show_bug.cgi?id=229039
<rdar://79150656>
Reviewed by Eric Carlson.
Source/WebCore:
Add a new utility method to calculate the available screen rect taking menu bar
hiding into account.
- platform/PlatformScreen.h:
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenRectAvoidingMenuBar):
Source/WebKit:
When entering fullscreen, if a user has unchecked the "auto-hide menu bar in fullscreen"
setting, the fullscreen animation will enter to the full screen frame, then snap down once
the animation completes to reveal the menu bar. Instead, use a WebCore utility method to
calculate the screen's frame taking that menu bar into account, and use it for the initial
enter fullscreen animation.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
- 12:13 PM Changeset in webkit [280975] by
-
- 8 edits in branches/safari-612.1.27.0-branch/Source
Cherry-pick r280776. rdar://problem/81861548
[Cocoa|GPU] platformLayer() not always added to remotedly hosted context; black video while playing
https://bugs.webkit.org/show_bug.cgi?id=228873
<rdar://81271107>
Reviewed by Eric Carlson.
Source/WebCore:
Coalesce calls to renderingModeChanged() by setting a flag to call renderingModeChanged() in
the next run loop, and call into this coalescing method, setNeedsRenderingModeChanged(),
whenever the MediaPlayerPrivateAVFoundation subclasses create or destroy a video layer
or software painting context. This ensures that the MediaPlayerClient is always notified
when the rendering mode changes, regardless of why that change occurred.
Drive-by fix: replace the call in createVideoLayer() to "callOnMainThread()"
with "ensureOnMainThread()". The call to "callOnMainThread()" was added to avoid a
deadlock in WebKitLegacy, and "ensureOnMainThread()" has the correct behavior there, but
will be synchronous in WebKit.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering): (WebCore::MediaPlayerPrivateAVFoundation::setNeedsRenderingModeChanged): (WebCore::MediaPlayerPrivateAVFoundation::renderingModeChanged): (WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::MediaPlayerPrivateAVFoundationCF::destroyVideoLayer): (WebCore::AVFWrapper::createAVCFVideoLayer): (WebCore::AVFWrapper::createImageGenerator): (WebCore::AVFWrapper::destroyImageGenerator):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoOutput):
Source/WebKit:
Currently, the RemoteMediaPlayerProxy will insert its MediaPlayer's platformLayer() into the
remotely hosted context when it receives a "firstVideoFrameAvailable()" notification.
However this is problematic for two reasons: AVPlayerLayer may not become "ready for
playback" when it is not in an active CALayer heirarchy, and for
MediaPlayerPrivateAVFoundation, firstVideoFrameAvailable() is only fired during
updateStates(), which is not guaranteed to occur unless another state change occurs.
Instead, reparent the MediaPlayer's platformLayer() when we receive a
mediaPlayerRenderingModeChanged() notification, which notifies the client whenever a
platformLayer() is created or destroyed.
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
- GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm: (WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable): (WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:07 PM Changeset in webkit [280974] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r271348): Web Inspector: Table headers have vertical scrollbar
https://bugs.webkit.org/show_bug.cgi?id=228671
<rdar://problem/81638278>
Reviewed by Devin Rousso.
- UserInterface/Views/Table.css:
(.table > .header):
Set overflow hidden for the y axis, not just x axis.
- 11:58 AM Changeset in webkit [280973] by
-
- 6 edits1 add in trunk
Fix some
NSAttributedStringinconsistencies between WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=229013
<rdar://problem/81215696>
Reviewed by Timothy Hatcher.
Source/WebCore:
NSAttributedStringnow uses WK2, which has caused us to discover some inconsistencies (and bugs).
Tests: NSAttributedStringWebKitAdditions.DefaultFontSize
NSAttributedStringWebKitAdditions.MultipleParagraphs
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_blockLevelElementForNode):
Check the given node before looking at the parent as it could already be a block. This
allows for sequental<p>to each have their own positioning instead of only the first one.
(HTMLConverter::computedAttributesForElement):
Fix typo that usedmargin-rightinstead ofmargin-bottomwhen settingparagraphSpacing.
Source/WebKit:
NSAttributedStringnow uses WK2, which has caused us to discover some inconsistencies (and bugs).
- UIProcess/API/Cocoa/NSAttributedString.mm:
(+[_WKAttributedStringWebViewCache configuration]):
Change the default font size to 12 to match WK1.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/NSAttributedStringWebKitAdditions.mm: Added.
(TEST.NSAttributedStringWebKitAdditions.DefaultFontSize):
(TEST.NSAttributedStringWebKitAdditions.MultipleParagraphs):
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 10:13 AM Changeset in webkit [280972] by
-
- 11 edits in trunk
Adopt span in RTCRtpSFrameTransform
https://bugs.webkit.org/show_bug.cgi?id=229029
Reviewed by Eric Carlson.
Source/WebCore:
Transition to Span for improved readability, no change of behavior.
- Modules/mediastream/RTCEncodedFrame.cpp:
(WebCore::RTCEncodedFrame::data const):
- Modules/mediastream/RTCRtpSFrameTransform.cpp:
(WebCore::processFrame):
(WebCore::RTCRtpSFrameTransform::initializeTransformer):
(WebCore::transformFrame):
(WebCore::RTCRtpSFrameTransform::createStreams):
- Modules/mediastream/RTCRtpSFrameTransformer.cpp:
(WebCore::RTCRtpSFrameTransformer::decryptFrame):
(WebCore::RTCRtpSFrameTransformer::encryptFrame):
(WebCore::RTCRtpSFrameTransformer::transform):
- Modules/mediastream/RTCRtpSFrameTransformer.h:
- Modules/mediastream/RTCRtpScriptTransformer.cpp:
(WebCore::RTCRtpScriptTransformer::writable):
- Modules/mediastream/RTCRtpTransformableFrame.h:
(): Deleted.
- Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:
(WebCore::LibWebRTCRtpTransformableFrame::data const):
(WebCore::LibWebRTCRtpTransformableFrame::setData):
- Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.h:
Tools:
- TestWebKitAPI/Tests/WebCore/RTCRtpSFrameTransformerTests.cpp:
(TestWebKitAPI::TEST):
- 9:26 AM Changeset in webkit [280971] by
-
- 3 edits2 adds in branches/safari-612.1.27.0-branch
Cherry-pick r280931. rdar://problem/81852494
REGRESSION (r278392) performance.measure should never throw an InvalidAccessError for fetchStart
https://bugs.webkit.org/show_bug.cgi?id=229008
<rdar://79960877>
Patch by Alex Christensen <achristensen@webkit.org> on 2021-08-11
Reviewed by Chris Dumez.
Source/WebCore:
Test: http/tests/performance/performance-measure-fetch-start.html
PerformanceTiming::fetchStart is returning 0 when we get a main resource from the cache sometimes.
This is causing PerformanceUserTiming::convertMarkToTimestamp to throw an error, which it should.
Like PerformanceResourceTiming::fetchStart we need to fall back to ResourceLoadTiming::startTime
if the NetworkLoadMetrics doesn't have any useful data for us.
- page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::fetchStart const):
LayoutTests:
- http/tests/performance/performance-measure-fetch-start-expected.txt: Added.
- http/tests/performance/performance-measure-fetch-start.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:20 AM Changeset in webkit [280970] by
-
- 8 edits in branches/safari-612.1.27.0-branch/Source
Versioning.
WebKit-7612.1.27.0.21
- 8:48 AM Changeset in webkit [280969] by
-
- 2 edits in trunk/Tools
Unreviewed API test build fix with recent MacOS SDK.
- TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(verifyCertificateAndPublicKey):
- 8:47 AM Changeset in webkit [280968] by
-
- 26 edits16 moves in trunk/Source/WebCore
Removal of "TypedOM" prefix for CSSOM Object names
https://bugs.webkit.org/show_bug.cgi?id=229028
Patch by Johnson Zhou <qiaosong_zhou@apple.com> on 2021-08-12
Reviewed by Alex Christensen.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSStyleValueCustom.cpp: Renamed from Source/WebCore/bindings/js/JSTypedOMCSSStyleValueCustom.cpp.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- css/typedom/CSSNumericValue.cpp: Renamed from Source/WebCore/css/typedom/TypedOMCSSUnitValue.cpp.
- css/typedom/CSSNumericValue.h: Renamed from Source/WebCore/css/typedom/TypedOMCSSNumericValue.h.
- css/typedom/CSSNumericValue.idl: Renamed from Source/WebCore/css/typedom/TypedOMCSSNumericValue.idl.
- css/typedom/CSSStyleImageValue.cpp: Renamed from Source/WebCore/css/typedom/TypedOMCSSImageValue.cpp.
(WebCore::CSSStyleImageValue::CSSStyleImageValue):
(WebCore::CSSStyleImageValue::document const):
- css/typedom/CSSStyleImageValue.h: Renamed from Source/WebCore/css/typedom/TypedOMCSSImageValue.h.
- css/typedom/CSSStyleImageValue.idl: Renamed from Source/WebCore/css/typedom/TypedOMCSSImageValue.idl.
- css/typedom/CSSStyleValue.cpp: Renamed from Source/WebCore/css/typedom/TypedOMCSSStyleValue.cpp.
- css/typedom/CSSStyleValue.h: Renamed from Source/WebCore/css/typedom/TypedOMCSSStyleValue.h.
- css/typedom/CSSStyleValue.idl: Renamed from Source/WebCore/css/typedom/TypedOMCSSStyleValue.idl.
- css/typedom/CSSUnitValue.cpp: Renamed from Source/WebCore/css/typedom/TypedOMCSSNumericValue.cpp.
- css/typedom/CSSUnitValue.h: Renamed from Source/WebCore/css/typedom/TypedOMCSSUnitValue.h.
- css/typedom/CSSUnitValue.idl: Renamed from Source/WebCore/css/typedom/TypedOMCSSUnitValue.idl.
- css/typedom/CSSUnparsedValue.cpp: Renamed from Source/WebCore/css/typedom/TypedOMCSSUnparsedValue.cpp.
- css/typedom/CSSUnparsedValue.h: Renamed from Source/WebCore/css/typedom/TypedOMCSSUnparsedValue.h.
- css/typedom/CSSUnparsedValue.idl: Renamed from Source/WebCore/css/typedom/TypedOMCSSUnparsedValue.idl.
- css/typedom/StylePropertyMapReadOnly.cpp:
(WebCore::StylePropertyMapReadOnly::reifyValue):
(WebCore::StylePropertyMapReadOnly::customPropertyValueOrDefault):
- css/typedom/StylePropertyMapReadOnly.h:
- css/typedom/StylePropertyMapReadOnly.idl:
- dom/StyledElement.cpp:
- html/CustomPaintImage.cpp:
(WebCore::extractComputedProperty):
(WebCore::CustomPaintImage::doCustomPaint):
- html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createPromise):
- html/ImageBitmap.h:
- html/canvas/CanvasDrawImage.idl:
- html/canvas/CanvasFillStrokeStyles.idl:
- html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::checkOrigin):
- html/canvas/CanvasRenderingContext.h:
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::size):
(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::CanvasRenderingContext2DBase::createPattern):
- html/canvas/CanvasRenderingContext2DBase.h:
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::processArgument):
(WebCore::InspectorCanvas::indexForData):
- inspector/InspectorCanvas.h:
- inspector/InspectorCanvasCallTracer.cpp:
- inspector/InspectorCanvasCallTracer.h:
- inspector/agents/InspectorCanvasAgent.cpp:
- page/WindowOrWorkerGlobalScope.idl:
- 8:23 AM Changeset in webkit [280967] by
-
- 2 edits in trunk/Tools
[check-github-mirror-integrity] Differentiate between slow sync and collapsed commits
https://bugs.webkit.org/show_bug.cgi?id=229004
<rdar://problem/81795644>
Reviewed by Aakash Jain.
- Scripts/check-github-mirror-integrity: Use commit timestamps to differentiate between a slow sync between svn.webkit.org
and GitHub and git-svn combining commits
- 6:53 AM Changeset in webkit [280966] by
-
- 4 edits1 delete in trunk/Tools
[GTK] Simplify TestWebKitAccessibility
https://bugs.webkit.org/show_bug.cgi?id=229032
Reviewed by Michael Catanzaro.
We don't really need to have a different process to test a11y. We can remove AccessibilityTestServer and use the
same test executable. That way we don't need to spawn a process and use DBus for the communication.
- TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp: Removed.
- TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
(AccessibilityTest::findTestApplication): Find the accessible application corresponding to the test executable.
(AccessibilityTest::waitUntilChildrenRemoved): Use the WebViewTest main loop.
(testAtspiBasicHierarchy): Use WebViewTest::loadHtml.
- TestWebKitAPI/glib/PlatformGTK.cmake:
- TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
(main): Set the program name to the executable name. It helps to a11y test to find the accessible app.
- 6:52 AM Changeset in webkit [280965] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests always fails to start accessibility daemons
https://bugs.webkit.org/show_bug.cgi?id=229031
Reviewed by Michael Catanzaro.
This is because it uses exec_prefix variable from atspi2 pkg-config file to try to find the executables, but
atspi2 pkg-config file doesn't have a exec_prefix variable anymore. It was always set to $prefix, so we can just
use prefix variable instead.
- Scripts/run-gtk-tests:
(GtkTestRunner._lookup_atspi2_binary):
- 6:51 AM Changeset in webkit [280964] by
-
- 2 edits in trunk/Source/WebKit
[ATK] Critical warnings on children-changed::add signal emission
https://bugs.webkit.org/show_bug.cgi?id=229030
Reviewed by Michael Catanzaro.
Implement AtkObjectClass::ref_state_set.
- WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp:
(webkitWebPageAccessibilityObjectRefStateSet): Return our child state set.
(webkit_web_page_accessibility_object_class_init): Add an implementation for AtkObjectClass::ref_state_set.
- 6:35 AM Changeset in webkit [280963] by
-
- 4 edits in trunk
webgl/1.0.x/conformance/textures/misc/texture-corner-case-videos.html fails on Cocoa
https://bugs.webkit.org/show_bug.cgi?id=228821
<rdar://problem/81562236>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-08-12
Reviewed by Kenneth Russell.
When uploading the WebGL texture content from videos, use the video
visible data size instead of video element size. The video data can
be scaled with its filters, but we should upload only the original
pixels.
The GPU codepath already did this, but CPU codepath did not.
This change fixes the CPU codepath.
Fixes webgl/1.0.x/conformance/textures/misc/texture-corner-case-videos.html
webgl/2.0.y/conformance/textures/misc/texture-corner-case-videos.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImageSourceHelper):
(WebCore::WebGLRenderingContextBase::videoFrameToImage):
(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):
- html/canvas/WebGLRenderingContextBase.h:
- 6:01 AM Changeset in webkit [280962] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
ANGLE Cocoa compiles contents of ContextEAGL on mac
https://bugs.webkit.org/show_bug.cgi?id=228987
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-08-12
Reviewed by Kenneth Russell.
Add include guards that are consistent with other EAGL files.
- src/libANGLE/renderer/gl/eagl/ContextEAGL.cpp:
- 4:43 AM Changeset in webkit [280961] by
-
- 2 edits in trunk/Source/WebKitLegacy/mac
REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing
https://bugs.webkit.org/show_bug.cgi?id=228926
<rdar://problem/81715332>
Reviewed by Eric Carlson.
isFeatureFlagEnabled is called when creating/initializing WebPreferences.
It used to check for WebView, which triggers the execution of WebView initialize method
while DumpRenderTree is in the middle of creating its testing setup, including its storage testing sessions.
Instead, check for WebResource to remove this side effect and get back to past DumpRenderTree initialization.
- WebView/WebPreferencesDefaultValues.mm:
(WebKit::isFeatureFlagEnabled):
- 4:27 AM Changeset in webkit [280960] by
-
- 29 edits14 copies95 moves103 adds27 deletes in trunk/LayoutTests
Update import of css/css-position from WPT
https://bugs.webkit.org/show_bug.cgi?id=228988
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/css/css-position/crashtests/position-absolute-crash-014.html: Added.
- web-platform-tests/css/css-position/crashtests/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/resources/w3c-import.log.
- web-platform-tests/css/css-position/fixed-z-index-blend-expected.html:
- web-platform-tests/css/css-position/fixed-z-index-blend.html:
- web-platform-tests/css/css-position/invalidate-opacity-negative-z-index-expected.html: Added.
- web-platform-tests/css/css-position/invalidate-opacity-negative-z-index.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-ltr-ltr-in-multicol-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-ltr-ltr-in-multicol.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-ltr-rtl-in-multicol.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-ltr-rtl-in-multicol.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-rtl-ltr-in-multicol.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-rtl-ltr-in-multicol.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-rtl-rtl-in-multicol-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vlr-rtl-rtl-in-multicol.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-ltr-ltr-in-multicol-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-ltr-ltr-in-multicol.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-ltr-rtl-in-multicol.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-ltr-rtl-in-multicol.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-rtl-ltr-in-multicol.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-rtl-ltr-in-multicol.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-rtl-rtl-in-multicol-expected.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/vrl-rtl-rtl-in-multicol.html: Added.
- web-platform-tests/css/css-position/multicol/static-position/w3c-import.log: Added.
- web-platform-tests/css/css-position/multicol/vlr-ltr-ltr-in-multicols-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vlr-ltr-ltr-in-multicols.html: Added.
- web-platform-tests/css/css-position/multicol/vlr-ltr-rtl-in-multicols.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vlr-ltr-rtl-in-multicols.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/vlr-rtl-ltr-in-multicols.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vlr-rtl-ltr-in-multicols.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/vlr-rtl-rtl-in-multicols-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vlr-rtl-rtl-in-multicols.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-ltr-ltr-in-multicols-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-ltr-ltr-in-multicols.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-ltr-rtl-in-multicols.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-ltr-rtl-in-multicols.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-rtl-ltr-in-multicols.tentative-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-rtl-ltr-in-multicols.tentative.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-rtl-rtl-in-multicols-expected.html: Added.
- web-platform-tests/css/css-position/multicol/vrl-rtl-rtl-in-multicols.html: Added.
- web-platform-tests/css/css-position/multicol/w3c-import.log: Added.
- web-platform-tests/css/css-position/parsing/inset-after-computed-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-after-computed.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-after-invalid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-after-invalid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-after-valid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-after-valid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-before-computed-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-before-computed.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-before-invalid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-before-invalid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-before-valid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-before-valid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-computed-expected.txt: Added.
- web-platform-tests/css/css-position/parsing/inset-computed.html: Added.
- web-platform-tests/css/css-position/parsing/inset-end-computed-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-end-computed.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-end-invalid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-end-invalid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-end-valid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-end-valid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-invalid-expected.txt: Added.
- web-platform-tests/css/css-position/parsing/inset-invalid.html: Added.
- web-platform-tests/css/css-position/parsing/inset-start-computed-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-start-computed.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-start-invalid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-start-invalid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-start-valid-expected.txt: Removed.
- web-platform-tests/css/css-position/parsing/inset-start-valid.html: Removed.
- web-platform-tests/css/css-position/parsing/inset-valid-expected.txt: Added.
- web-platform-tests/css/css-position/parsing/inset-valid.html: Added.
- web-platform-tests/css/css-position/parsing/w3c-import.log:
- web-platform-tests/css/css-position/position-absolute-center-001-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-absolute-center-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative.html.
- web-platform-tests/css/css-position/position-absolute-center-002-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-002.tentative-expected.xht.
- web-platform-tests/css/css-position/position-absolute-center-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-002.tentative.html.
- web-platform-tests/css/css-position/position-absolute-dynamic-auto-overflow-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-absolute-dynamic-auto-overflow.html: Added.
- web-platform-tests/css/css-position/position-absolute-dynamic-list-marker.html:
- web-platform-tests/css/css-position/position-absolute-fit-content-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-absolute-fit-content.html: Added.
- web-platform-tests/css/css-position/position-absolute-iframe-print-001.sub-expected.html: Added.
- web-platform-tests/css/css-position/position-absolute-iframe-print-001.sub.html: Added.
- web-platform-tests/css/css-position/position-absolute-iframe-print-002.sub-expected.html: Added.
- web-platform-tests/css/css-position/position-absolute-iframe-print-002.sub.html: Added.
- web-platform-tests/css/css-position/position-absolute-in-inline-003-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-absolute-in-inline-003.html: Added.
- web-platform-tests/css/css-position/position-absolute-in-inline-004-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-absolute-in-inline-004.html: Added.
- web-platform-tests/css/css-position/position-absolute-large-negative-inset-expected.html: Added.
- web-platform-tests/css/css-position/position-absolute-large-negative-inset.html: Added.
- web-platform-tests/css/css-position/position-absolute-replaced-intrinsic-size.tentative-expected.html: Added.
- web-platform-tests/css/css-position/position-absolute-replaced-intrinsic-size.tentative.html: Added.
- web-platform-tests/css/css-position/position-absolute-replaced-no-intrinsic-size.tentative-expected.html: Added.
- web-platform-tests/css/css-position/position-absolute-replaced-no-intrinsic-size.tentative.html: Added.
- web-platform-tests/css/css-position/position-absolute-replaced-with-display-table-expected.html: Added.
- web-platform-tests/css/css-position/position-absolute-replaced-with-display-table.html: Added.
- web-platform-tests/css/css-position/position-fixed-overflow-print-expected.html: Added.
- web-platform-tests/css/css-position/position-fixed-overflow-print.html: Added.
- web-platform-tests/css/css-position/position-fixed-scroll-nested-fixed-expected.html: Added.
- web-platform-tests/css/css-position/position-fixed-scroll-nested-fixed.html: Added.
- web-platform-tests/css/css-position/position-relative-001-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-relative-001.html: Added.
- web-platform-tests/css/css-position/position-relative-002-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-relative-002.html: Added.
- web-platform-tests/css/css-position/position-relative-003-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-relative-003.html: Added.
- web-platform-tests/css/css-position/position-relative-004-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-relative-004.html: Added.
- web-platform-tests/css/css-position/position-relative-005-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-relative-005.html: Added.
- web-platform-tests/css/css-position/position-relative-006-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-relative-006.html: Added.
- web-platform-tests/css/css-position/position-relative-007-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-center-001.tentative-expected.xht.
- web-platform-tests/css/css-position/position-relative-007.html: Added.
- web-platform-tests/css/css-position/position-relative-008-expected.html: Added.
- web-platform-tests/css/css-position/position-relative-008.html: Added.
- web-platform-tests/css/css-position/position-relative-009-expected.html: Added.
- web-platform-tests/css/css-position/position-relative-009.html: Added.
- web-platform-tests/css/css-position/position-relative-010-expected.html: Added.
- web-platform-tests/css/css-position/position-relative-010.html: Added.
- web-platform-tests/css/css-position/position-relative-011-expected.html: Added.
- web-platform-tests/css/css-position/position-relative-011.html: Added.
- web-platform-tests/css/css-position/position-relative-012-expected.html: Added.
- web-platform-tests/css/css-position/position-relative-012.html: Added.
- web-platform-tests/css/css-position/position-relative-013-expected.html: Added.
- web-platform-tests/css/css-position/position-relative-013.html: Added.
- web-platform-tests/css/css-position/position-relative-table-tfoot-top-absolute-child.html:
- web-platform-tests/css/css-position/position-sticky-input-box-gets-focused-after-scroll-expected.txt: Removed.
- web-platform-tests/css/css-position/position-sticky-offset-overflow-expected.txt: Removed.
- web-platform-tests/css/css-position/position-sticky-parsing-expected.txt: Removed.
- web-platform-tests/css/css-position/positon-absolute-scrollable-overflow-001-expected.txt: Added.
- web-platform-tests/css/css-position/positon-absolute-scrollable-overflow-001.html: Added.
- web-platform-tests/css/css-position/resources/position-absolute-iframe-child-002.sub.html: Added.
- web-platform-tests/css/css-position/resources/position-absolute-iframe-child.html: Added.
- web-platform-tests/css/css-position/resources/w3c-import.log:
- web-platform-tests/css/css-position/static-position/vlr-ltr-ltr-expected.html:
- web-platform-tests/css/css-position/static-position/vlr-ltr-ltr.html:
- web-platform-tests/css/css-position/static-position/vlr-ltr-rtl.tentative-expected.html:
- web-platform-tests/css/css-position/static-position/vlr-ltr-rtl.tentative.html:
- web-platform-tests/css/css-position/static-position/vlr-rtl-ltr.tentative-expected.html:
- web-platform-tests/css/css-position/static-position/vlr-rtl-ltr.tentative.html:
- web-platform-tests/css/css-position/static-position/vlr-rtl-rtl-expected.html:
- web-platform-tests/css/css-position/static-position/vlr-rtl-rtl.html:
- web-platform-tests/css/css-position/static-position/vrl-ltr-ltr-expected.html:
- web-platform-tests/css/css-position/static-position/vrl-ltr-ltr.html:
- web-platform-tests/css/css-position/static-position/vrl-ltr-rtl.tentative-expected.html:
- web-platform-tests/css/css-position/static-position/vrl-ltr-rtl.tentative.html:
- web-platform-tests/css/css-position/static-position/vrl-rtl-ltr.tentative-expected.html:
- web-platform-tests/css/css-position/static-position/vrl-rtl-ltr.tentative.html:
- web-platform-tests/css/css-position/static-position/vrl-rtl-rtl-expected.html:
- web-platform-tests/css/css-position/static-position/vrl-rtl-rtl.html:
- web-platform-tests/css/css-position/sticky/position-sticky-bottom-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-bottom-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-bottom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-bottom.html.
- web-platform-tests/css/css-position/sticky/position-sticky-change-top-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-change-top-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-change-top.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-change-top.html.
- web-platform-tests/css/css-position/sticky/position-sticky-child-multicolumn-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-child-multicolumn-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-child-multicolumn.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-child-multicolumn.html.
- web-platform-tests/css/css-position/sticky/position-sticky-fixed-ancestor-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-fixed-ancestor-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-fixed-ancestor-iframe-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-fixed-ancestor-iframe-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-fixed-ancestor-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-fixed-ancestor-iframe.html.
- web-platform-tests/css/css-position/sticky/position-sticky-fixed-ancestor.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-fixed-ancestor.html.
- web-platform-tests/css/css-position/sticky/position-sticky-flexbox-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-flexbox-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-flexbox.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-flexbox.html.
- web-platform-tests/css/css-position/sticky/position-sticky-get-bounding-client-rect-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-get-bounding-client-rect-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-get-bounding-client-rect.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-get-bounding-client-rect.html.
- web-platform-tests/css/css-position/sticky/position-sticky-grid-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-grid-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-grid.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-grid.html.
- web-platform-tests/css/css-position/sticky/position-sticky-hyperlink-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-hyperlink-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-hyperlink.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-hyperlink.html.
- web-platform-tests/css/css-position/sticky/position-sticky-inflow-position-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-inflow-position-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-inflow-position.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-inflow-position.html.
- web-platform-tests/css/css-position/sticky/position-sticky-inline-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-inline-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-inline.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-inline.html.
- web-platform-tests/css/css-position/sticky/position-sticky-input-box-gets-focused-after-scroll-expected.txt: Added.
- web-platform-tests/css/css-position/sticky/position-sticky-input-box-gets-focused-after-scroll.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-input-box-gets-focused-after-scroll.html.
- web-platform-tests/css/css-position/sticky/position-sticky-large-top-2.tentative-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-large-top-2.tentative-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-large-top-2.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-large-top-2.tentative.html.
- web-platform-tests/css/css-position/sticky/position-sticky-large-top.tentative-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-large-top.tentative-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-large-top.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-large-top.tentative.html.
- web-platform-tests/css/css-position/sticky/position-sticky-left-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-left-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-left.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-left.html.
- web-platform-tests/css/css-position/sticky/position-sticky-margins-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-margins-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-margins.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-margins.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-bottom-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-bottom-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-bottom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-bottom.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-inline-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-inline-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-inline.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-inline.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-left-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-left-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-left.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-left.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-right-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-right-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-right.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-right.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-table-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-table-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-table.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-table.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-thead-th-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-table-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-thead-th.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-table.html.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-top-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-top-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-nested-top.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-nested-top.html.
- web-platform-tests/css/css-position/sticky/position-sticky-offset-overflow-expected.txt: Added.
- web-platform-tests/css/css-position/sticky/position-sticky-offset-overflow.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-offset-overflow.html.
- web-platform-tests/css/css-position/sticky/position-sticky-offset-top-left-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-offset-top-left-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-offset-top-left.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-offset-top-left.html.
- web-platform-tests/css/css-position/sticky/position-sticky-overflow-hidden-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-overflow-hidden-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-overflow-hidden.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-overflow-hidden.html.
- web-platform-tests/css/css-position/sticky/position-sticky-overflow-padding-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-overflow-padding-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-overflow-padding.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-overflow-padding.html.
- web-platform-tests/css/css-position/sticky/position-sticky-parsing-expected.txt: Added.
- web-platform-tests/css/css-position/sticky/position-sticky-parsing.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-parsing.html.
- web-platform-tests/css/css-position/sticky/position-sticky-rendering-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-rendering-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-rendering.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-rendering.html.
- web-platform-tests/css/css-position/sticky/position-sticky-right-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-right-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-right.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-right.html.
- web-platform-tests/css/css-position/sticky/position-sticky-root-scroller-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-root-scroller-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-root-scroller.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-root-scroller.html.
- web-platform-tests/css/css-position/sticky/position-sticky-scroll-reposition-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-scroll-reposition-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-scroll-reposition.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-scroll-reposition.html.
- web-platform-tests/css/css-position/sticky/position-sticky-scroll-with-clip-and-abspos-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-scroll-with-clip-and-abspos-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-scroll-with-clip-and-abspos.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-scroll-with-clip-and-abspos.html.
- web-platform-tests/css/css-position/sticky/position-sticky-scrollIntoView-expected.txt: Added.
- web-platform-tests/css/css-position/sticky/position-sticky-scrollIntoView.html: Added.
- web-platform-tests/css/css-position/sticky/position-sticky-scrolled-remove-sibling-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-scrolled-remove-sibling-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-scrolled-remove-sibling.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-scrolled-remove-sibling.html.
- web-platform-tests/css/css-position/sticky/position-sticky-stacking-context-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-stacking-context-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-stacking-context.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-stacking-context.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-parts-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-parts-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-parts.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-parts.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-tfoot-bottom-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-tfoot-bottom-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-tfoot-bottom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-tfoot-bottom.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-bottom-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-bottom-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-bottom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-bottom.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-left-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-left-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-left.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-left.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-right-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-right-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-right.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-right.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-top-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-top-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-th-top.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-th-top.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-thead-top-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-thead-top-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-thead-top.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-thead-top.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-tr-bottom-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-tr-bottom-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-tr-bottom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-tr-bottom.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-tr-top-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-tr-top-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-table-tr-top.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-table-tr-top.html.
- web-platform-tests/css/css-position/sticky/position-sticky-top-and-bottom-expected.txt: Added.
- web-platform-tests/css/css-position/sticky/position-sticky-top-and-bottom.html: Added.
- web-platform-tests/css/css-position/sticky/position-sticky-top-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-top-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-top.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-top.html.
- web-platform-tests/css/css-position/sticky/position-sticky-transforms-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-transforms-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-transforms-translate-expected.txt.
- web-platform-tests/css/css-position/sticky/position-sticky-transforms-translate.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-transforms-translate.html.
- web-platform-tests/css/css-position/sticky/position-sticky-transforms.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-transforms.html.
- web-platform-tests/css/css-position/sticky/position-sticky-writing-modes-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-writing-modes-expected.html.
- web-platform-tests/css/css-position/sticky/position-sticky-writing-modes.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-sticky-writing-modes.html.
- web-platform-tests/css/css-position/sticky/sticky-after-input-expected.txt: Added.
- web-platform-tests/css/css-position/sticky/sticky-after-input.html: Added.
- web-platform-tests/css/css-position/sticky/w3c-import.log: Added.
- web-platform-tests/css/css-position/w3c-import.log:
LayoutTests:
- TestExpectations: Update test expectations.
- platform/mac-wk1/TestExpectations: Ditto.
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-scrollIntoView-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-position/sticky/sticky-after-input-expected.txt: Added.
- 3:16 AM Changeset in webkit [280959] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly
https://bugs.webkit.org/show_bug.cgi?id=228986
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-08-12
Reviewed by Kenneth Russell.
Remove following from ANGLE (dynamic) target:
- HLSL translator and tree ops used only by it
- Vulkan translator output
- libgl API validation implementation
- API trace capture implementation (was only partially compiled)
The features are not part of Cocoa use of ANGLE, and should
not be compiled as such.
Does not affect the binary size more than few kilobytes.
- ANGLE.xcodeproj/project.pbxproj:
- Configurations/ANGLE-dynamic.xcconfig:
- 2:37 AM Changeset in webkit [280958] by
-
- 18 edits2 copies4 adds in trunk
Implement SFrameTransform error handling
https://bugs.webkit.org/show_bug.cgi?id=228947
Reviewed by Eric Carlson.
Source/WebCore:
Add support for RTCRtpSFrameTransformErrorEvent.
When RTCRtpSFrameTransformer encounters an issue, dispatch a task to RTCRtpSFrameTransform context and fire a corresponding event.
This follows https://w3c.github.io/webrtc-encoded-transform/#sframe-transform-algorithm, except that:
- we are not yet exposing some fields in RTCRtpSFrameTransformErrorEvent.
- we are using errorType instead of type which should be fixed in the spec.
Test: imported/w3c/web-platform-tests/webrtc-encoded-transform/sframe-transform-error.html
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/mediastream/RTCRtpSFrameTransform.cpp:
(WebCore::RTCRtpSFrameTransform::RTCRtpSFrameTransform):
(WebCore::errorTypeFromInformation):
(WebCore::processFrame):
(WebCore::RTCRtpSFrameTransform::hasKey const):
(WebCore::RTCRtpSFrameTransform::initializeTransformer):
(WebCore::transformFrame):
(WebCore::RTCRtpSFrameTransform::createStreams):
(WebCore::RTCRtpSFrameTransform::writable):
(WebCore::RTCRtpSFrameTransform::virtualHasPendingActivity const):
- Modules/mediastream/RTCRtpSFrameTransform.h:
- Modules/mediastream/RTCRtpSFrameTransform.idl:
- Modules/mediastream/RTCRtpSFrameTransformErrorEvent.cpp: Added.
(WebCore::RTCRtpSFrameTransformErrorEvent::create):
(WebCore::RTCRtpSFrameTransformErrorEvent::RTCRtpSFrameTransformErrorEvent):
(WebCore::RTCRtpSFrameTransformErrorEvent::eventInterface const):
- Modules/mediastream/RTCRtpSFrameTransformErrorEvent.h: Added.
- Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl: Added.
- Modules/mediastream/RTCRtpSFrameTransformer.cpp:
(WebCore::RTCRtpSFrameTransformer::hasKey const):
(WebCore::RTCRtpSFrameTransformer::decryptFrame):
(WebCore::RTCRtpSFrameTransformer::encryptFrame):
(WebCore::RTCRtpSFrameTransformer::transform):
- Modules/mediastream/RTCRtpSFrameTransformer.h:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- dom/EventNames.in:
- dom/EventTargetFactory.in:
Tools:
- TestWebKitAPI/Tests/WebCore/RTCRtpSFrameTransformerTests.cpp:
(TestWebKitAPI::TEST):
LayoutTests:
- http/wpt/webrtc/sframe-transform-error-worker.js: Added.
(onrtctransform.async event):
- http/wpt/webrtc/sframe-transform-error.html: Added.
- http/wpt/webrtc/sframe-transform-error-expected: Added.