⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 18, 2021:

9:04 PM Changeset in webkit [281223] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Bug 229264: Leak of CMBufferQueueRef (up to 752 bytes each) in com.apple.WebKit.GPU.Development process
<​https://webkit.org/b/229264>
<rdar://problem/82101153>

Reviewed by Anders Carlsson.

Covered by running layout tests with --leaks plus future patch
to check for leaks in the GPU process.

  • platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:

(WebCore::VideoSampleBufferCompressor::initialize):

  • Use adoptCF() to fix the leak since CMBufferQueueCreate() returns a retained object.
8:42 PM Changeset in webkit [281222] by ysuzuki@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

[JSC] Remove op_has_indexed_property related code
​https://bugs.webkit.org/show_bug.cgi?id=229271

Reviewed by Saam Barati.

After our new for-in protocol, op_has_indexed_property is removed.
As a result, we can remove many ByValInfo code that is used only
for op_has_indexed_property.

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::emitLoadForArrayMode): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileHasIndexedProperty): Deleted.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileHasIndexedProperty): Deleted.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDoubleLoad): Deleted.
(JSC::JIT::emitContiguousLoad): Deleted.
(JSC::JIT::emitArrayStorageLoad): Deleted.

8:40 PM Changeset in webkit [281221] by ddkilzer@apple.com
  • 6 edits in trunk

Bug 229265: run-webkit-tests --leaks should check for leaks in the GPU process
<​https://webkit.org/b/229265>
<rdar://problem/82101453>

Reviewed by Alex Christensen.

Source/WebKit:

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetGPUProcessIdentifier): Add.

  • UIProcess/API/C/WKPagePrivate.h:

(WKPageGetGPUProcessIdentifier): Add.

  • Add function to return the PID for the GPU process.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::findAndDumpWebKitProcessIdentifiers):

  • Include the GPU process PID if it's enabled when sending a list of PIDs back to run-webkit-tests.

(WTR::TestController::gpuProcessName): Add.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::databaseProcessName): Delete.

  • The implementation was removed a while ago.

(WTR::TestController::gpuProcessName): Add.

8:34 PM Changeset in webkit [281220] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

Leak of CMSampleBufferRef (up to 2.25 KB each) in com.apple.WebKit.GPU.Development process
<​https://webkit.org/b/229262>
<rdar://problem/82076765>

Reviewed by Darin Adler.

Covered by running layout tests with --leaks plus future patch
to check for leaks in the GPU process.

  • platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:

(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):

  • Update signature to return RetainPtr<CMSampleBufferRef>.
  • platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:

(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):

  • Update signature to return RetainPtr<CMSampleBufferRef>.
  • Rename sampleBuffer to rawSampleBuffer to match similar pattern used in other code, then use sampleBuffer to store rawSampleBuffer wrapped in a RetainPtr<>.

(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):

  • Add get() to buffer variable since it is now a RetainPtr<>.
6:15 PM Changeset in webkit [281219] by clopez@igalia.com
  • 3 edits
    11 adds in trunk/LayoutTests

[GTK][WPE] Gardening of layout tests

Unreviewed test gardening.

Mark expected failures after r281108 and others and update list of flaky tests.
Rebaseline tests after r281136, r281127 and r281097.

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
5:34 PM Changeset in webkit [281218] by Fujii Hironori
  • 5 edits in trunk/LayoutTests

[Fetch API][WebKit1] http/tests/fetch/keepalive-fetch-2.html is randomly failing
​https://bugs.webkit.org/show_bug.cgi?id=229247

Unreviewed test gardening.

WebKit1 doesn't properly support keepalive fetch. Marked it as
flaky. Increased the number of fetches for testing WebKit2 more.

  • http/tests/fetch/keepalive-fetch-2.html:
  • http/tests/fetch/resources/keepalive-fetch-2-window.html:
  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
5:20 PM Changeset in webkit [281217] by rniwa@webkit.org
  • 2 edits in trunk/Source/WTF

[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
​https://bugs.webkit.org/show_bug.cgi?id=229250

Reviewed by Wenson Hsieh.

Disable the assertion when Web Thread is enabled for now.

  • wtf/CheckedRef.h:

(WTF::SingleThreadIntegralWrapper::assertThread const):

5:20 PM Changeset in webkit [281216] by Jonathan Bedard
  • 3 edits in trunk/Tools

[run-webkit-tests] Remember failures when repeating test
​https://bugs.webkit.org/show_bug.cgi?id=229217
<rdar://problem/81919223>

Reviewed by Ryan Haddad.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.update_summary_with_result): Replace existing result with unexpected result so
that unexpected results always take precedence over expected ones.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.add): Do not replace existing result.

4:14 PM Changeset in webkit [281215] by Chris Dumez
  • 7 edits in trunk

Unreviewed, reverting r281206.

Reverting because of branching, will re-land soon

Reverted changeset:

"Implement Crypto.randomUUID()"
​https://bugs.webkit.org/show_bug.cgi?id=229240
​https://commits.webkit.org/r281206

3:04 PM Changeset in webkit [281214] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Revert "Cherry-pick r280463. rdar://problem/82088775"

This reverts commit r281207.

3:04 PM Changeset in webkit [281213] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Revert "Cherry-pick r280505. rdar://problem/82088775"

This reverts commit r281208.

3:00 PM Changeset in webkit [281212] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1 Debug] imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229252.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:41 PM Changeset in webkit [281211] by Lauro Moura
  • 2 edits in trunk/Tools

REGRESSION(r279169) [WebDriver] WPT Tools now requires python3 to launch the server
​https://bugs.webkit.org/show_bug.cgi?id=229248

Reviewed by Chris Dumez.

239066@main updated the layout test WPT tools to
94d018bb5d7c0d46df7ba1 and this version requires Python3 to run the
WPT server.

  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:

(WebDriverW3CWebServer.start):

2:17 PM Changeset in webkit [281210] by Megan Gardner
  • 5 edits in trunk/Source

Remove unneeded UIKitSPI declarations
​https://bugs.webkit.org/show_bug.cgi?id=210075

Reviewed by Wenson Hsieh.

Source/WebKit:

No code changes, just using the now fully public API.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(gestureRecognizerModifierFlags): Deleted.

Source/WTF:

Remove unneeded feature define.

  • wtf/PlatformHave.h:
1:21 PM Changeset in webkit [281209] by Fujii Hironori
  • 3 edits in trunk/LayoutTests

[Win] http/tests/fetch/keepalive-fetch-2.html is randomly failing
​https://bugs.webkit.org/show_bug.cgi?id=229247

Unreviewed test gardening.

  • platform/win/TestExpectations: Marked it as flaky.
  • platform/wincairo-wk1/TestExpectations: Ditto.
12:51 PM Changeset in webkit [281208] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Cherry-pick r280505. rdar://problem/82088775

putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
​https://bugs.webkit.org/show_bug.cgi?id=227963

Reviewed by Alexey Shvayka.

JSTests:

  • stress/reflect-set-custom-value.js:

Source/JavaScriptCore:

Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
test both the reified and non-reified cases.

  • runtime/JSObject.cpp: (JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
  • tools/JSDollarVM.cpp:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@280505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:51 PM Changeset in webkit [281207] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Cherry-pick r280463. rdar://problem/82088775

definePropertyOnReceiver should check if receiver canPerformFastPutInline
​https://bugs.webkit.org/show_bug.cgi?id=227963
<rdar://80259710>

Reviewed by Alexey Shvayka.

JSTests:

  • stress/reflect-set-custom-value.js: Added.

Source/JavaScriptCore:

definePropertyOnReceiver has a fast path if the slot is not opaque and the receiver doesn't
have a custom defineOwnProperty implementation, in which case it calls putInlineFast (and
transitively putDirectInternal<PutModePut>). The issue is that putDirectInternal does not
handle customValues correctly: it just overwrites the property without changing the attributes.
To fix that, we should first check if the property might be a custom value, and if that's the case
we now call definePropertyOnReceiverSlow, which has been updated to handle custom values correctly.
I also added assertions to putInlineFastReplacingStaticPropertyIfNeeded and putDirectInternal
to make sure we don't accidentally overwrite custom values in the future.

  • runtime/JSObject.cpp: (JSC::definePropertyOnReceiverSlow): (JSC::JSObject::definePropertyOnReceiver): (JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
  • runtime/JSObjectInlines.h: (JSC::JSObject::putDirectInternal):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@280463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:13 PM Changeset in webkit [281206] by Chris Dumez
  • 7 edits in trunk

Implement Crypto.randomUUID()
​https://bugs.webkit.org/show_bug.cgi?id=229240

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

  • web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt:
  • web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt:

Source/WebCore:

Implement Crypto.randomUUID():

Chrome already implements this and Firefox seems to be working on it
(​https://bugzilla.mozilla.org/show_bug.cgi?id=1705264).

No new tests, rebaselined existing tests.

  • page/Crypto.cpp:

(WebCore::Crypto::randomUUID const):

  • page/Crypto.h:
  • page/Crypto.idl:
12:05 PM Changeset in webkit [281205] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac Debug] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=229244.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:32 AM Changeset in webkit [281204] by Russell Epstein
  • 1 edit
    2 adds in branches/safari-612.1.27.0-branch/LayoutTests

Cherry-pick r281195. rdar://problem/82083653

Add a layout test for webkit.org/b/229200
​https://bugs.webkit.org/show_bug.cgi?id=229222
rdar://81636256

Reviewed by Simon Fraser.

Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
browser and verifying that the page does not hang (and outputs the expected PASS messages).

  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:31 AM Changeset in webkit [281203] by Russell Epstein
  • 2 edits in branches/safari-612.1.27.0-branch/Source/WebKit

Cherry-pick r281186. rdar://problem/82083653

REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
​https://bugs.webkit.org/show_bug.cgi?id=229200
rdar://81636256

Reviewed by Myles C. Maxfield.

The changes in ​https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
of cached fonts and images in display list items in the web and GPU processes, via a useCount counter variable
that's incremented in the web process whenever the font or image is used in a display list item and decremented
in the GPU process whenever the item is processed.

However, the code to increment useCount in the web process currently only triggers at most once per rendering
update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
update, the web process' notion of useCount will fall out of sync with the GPU process' notion of useCount.

In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
early, which causes the GPU process to prematurely purge the font from the cache, and subsequently wait for the
cached font to arrive (which will never arrive, since the web process has already released the font).

In other words, the timeline of events between the web and GPU processes looks like this (where f is a cached
web font, A_f is a drawing command that uses f, and B_f is another drawing command that uses f).

WEB GPU
==============================================================

  1. Cache f
  2. Append A_f
    1. Cache f
    2. Play back A_f
  3. Append B_f
  4. Release f (use count was 1 here)
    1. Release f (use count dropped from 1 to 0)
    2. Play back B_f ...and then display list playback stops due to f not being in the cache.

To address this, we simply move the useCount increment in the web process out of the rendering update check.
The original intent of the fix for bug #228216 was to allow for useCount to increment as many times as needed
per rendering update, so this limitation was unintentional.

Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).

  • WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: (WebKit::RemoteResourceCacheProxy::recordFontUse):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:31 AM Changeset in webkit [281202] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch/Source/JavaScriptCore

Cherry-pick r281178. rdar://problem/82083485

Add an option for canonicalizePrePostIncrements
​https://bugs.webkit.org/show_bug.cgi?id=229211
<rdar://problem/82050126>

Reviewed by Mark Lam.

The current phase has bugs. Let's disable it for now until the bugs
are fixed. See discussion about the bugs I spotted in:
​https://bugs.webkit.org/show_bug.cgi?id=228538

  • b3/B3Generate.cpp: (JSC::B3::generateToAir):
  • b3/testb3_3.cpp: (addShrTests):
  • runtime/OptionsList.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:04 AM Changeset in webkit [281201] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

[MacOS] Use com.apple.webkit.microphone extension to gate microphone access in GPUProcess sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229238

Reviewed by Eric Carlson.

Manually tested.

  • GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Align to iOS and only allow microphone access in sandbox if com.apple.webkit.microphone is sent to GPUProcess.

  • Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCaptureAudioInGPUProcessEnabled):
Do audio capture in UIProcess for non Safari applications until rdar://problem/29448368 is fixed.

10:57 AM Changeset in webkit [281200] by Andres Gonzalez
  • 9 edits
    2 adds in trunk

Add layout test for WebAccessibilityObjectWrapper handler for attribute AXLineForTextMarker on MacOS.
​https://bugs.webkit.org/show_bug.cgi?id=229220
<rdar://problem/82057459>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/line-index-for-textmarker.html

There was not a layout test that exercised directly the handler for the
AXLineForTextMarker attribute in [WebAccessibilityObjectWrapper
accessibilityAttributeValue:withParameter:].
This patch adds the above test to exercise this method for textarea and
contenteditable elements. The text in these elements includes soft and
hard linebreaks, which are important test cases for this API.
The handler for AXLineForTextMarker in turn calls
AccessibilityObject::lineForPosition, and analyzing this method, made a
minor optimization by getting rid off of an unnecessary local variable
and object copy.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::lineForPosition const):

Tools:

Added AccessibilityUIElement::lineIndexForTextMarker.

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::lineIndexForTextMarker const):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::lineIndexForTextMarker const):

LayoutTests:

  • accessibility/mac/line-index-for-textmarker-expected.txt: Added.
  • accessibility/mac/line-index-for-textmarker.html: Added.
  • platform/mac-wk1/TestExpectations:
10:45 AM Changeset in webkit [281199] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebKit

Do not terminate relaunched network process when getting network process connection
​https://bugs.webkit.org/show_bug.cgi?id=229236

Reviewed by Chris Dumez.

When UI process fails to get network process connection for the first time, it will retry on next runloop
iteration. On the retry, it terminates existing network process and relaunch a network process, because the
failure may indicate something is wrong in the network process. If existing network process is different from
the one on first try, the existing process can be functional and we should not terminate it.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getNetworkProcessConnection):

10:42 AM Changeset in webkit [281198] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Update feature statuses in features.json
​https://bugs.webkit.org/show_bug.cgi?id=229212

Reviewed by Wenson Hsieh.

Update the status of various features in features.json to reflect their current state.

Remove "enabled-by-default": true from features that are marked as Supported.

  • features.json:
10:19 AM Changeset in webkit [281197] by Jonathan Bedard
  • 4 edits in trunk/Tools

[git-webkit] "IndexError: list index out of range" using log
​https://bugs.webkit.org/show_bug.cgi?id=229232

Reviewed by Ryan Haddad.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:

(FilteredCommand.pager):

10:16 AM Changeset in webkit [281196] by Megan Gardner
  • 2 edits in trunk/Source/WebCore

Add Highlight API to features.json
​https://bugs.webkit.org/show_bug.cgi?id=208226

Reviewed by Simon Fraser.

  • features.json:
9:58 AM Changeset in webkit [281195] by Wenson Hsieh
  • 1 edit
    2 adds in trunk/LayoutTests

Add a layout test for webkit.org/b/229200
​https://bugs.webkit.org/show_bug.cgi?id=229222
rdar://81636256

Reviewed by Simon Fraser.

Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
browser and verifying that the page does not hang (and outputs the expected PASS messages).

  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.
9:58 AM Changeset in webkit [281194] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1] css/css-position/position-relative-table* tests fail.
​https://bugs.webkit.org/show_bug.cgi?id=203449.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
9:50 AM Changeset in webkit [281193] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r280723): Protected HLS + EME playback fails with "temporary error"
​https://bugs.webkit.org/show_bug.cgi?id=229201
<rdar://81807216>

Reviewed by Eric Carlson.

In r280723, we stopped unconditionally creating an AVPlayerLayer when we create an AVPlayer. However,
we will still create an AVPlayerItemVideoOutput when we create an AVPlayerItem. This leaves our
AVPlayer in a state where AVFoundation will throw a "temporary error; try again later" when given
an otherwise valid protected HLS stream and key data through EME.

To work around this behavior, delay creating the AVPlayerItemVideoOutput until explicitly told to
create video renderers, typically simultaneous to creating an AVPlayerLayer.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):

9:46 AM Changeset in webkit [281192] by commit-queue@webkit.org
  • 11 edits in trunk

REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files
​https://bugs.webkit.org/show_bug.cgi?id=229152

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-08-18
Reviewed by Philippe Normand.

Source/JavaScriptCore:

  • PlatformGTK.cmake:
  • javascriptcoregtk.pc.in:

Source/WebKit:

CMake is expanding templates in the pkg-config files that are not supposed to be expanded.
Oops! Let's switch back to using @SVN_REVISION@ instead of ${SVN_REVISION} as the template
for inserting the SVN revision into the pkg-config file, so we can tell CMake to leave the
${} variables alone.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • Shared/glib/BuildRevision.h.in:
  • gtk/webkit2gtk-web-extension.pc.in:
  • gtk/webkit2gtk.pc.in:

Tools:

  • glib/apply-build-revision-to-files.py:

(main):

9:34 AM Changeset in webkit [281191] by Jonathan Bedard
  • 3 edits
    2 adds in trunk/Tools

[webkitcorepy] Add CallByNeed object
​https://bugs.webkit.org/show_bug.cgi?id=229148
<rdar://problem/81817705>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitcorepy/setup.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version, export Defer object.
  • Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py: Added.

(CallByNeed):
(CallByNeed.init):
(CallByNeed.getattribute): Depending on the request attribute, either return it or attempt to
resolve the underlying value before returning the attribute of the resolved value.
(CallByNeed.value): Resolve and return underlying object.
(CallByNeed.call): Ditto.
(CallByNeed.repr): Resolve object and return representation.
(CallByNeed.str): Resolve object and return string conversion.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/call_by_need_unittest.py: Added.

(TestCallByNeed):
(TestCallByNeed.test_basic):
(TestCallByNeed.test_string_conversion):
(TestCallByNeed.test_attribute_forwarding):
(TestCallByNeed.test_failed_attribute_forwarding):

9:22 AM Changeset in webkit [281190] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ MacOS EWS ] inspector/canvas/recording-2d-memoryLimit.html is flaky crashing..
​https://bugs.webkit.org/show_bug.cgi?id=229237

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:59 AM Changeset in webkit [281189] by Martin Robinson
  • 6 edits in trunk

[css-scroll-snap] Don't snap to offscreen snap areas in unidirectional scrolls
​https://bugs.webkit.org/show_bug.cgi?id=227949
<rdar://problem/80895783>

Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt: This bidirectional

scrolling test no longer snaps because we don't have support for choosing between two candidates
properly yet.

  • web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt: Updated to show newly passing test.
  • web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt: Ditto.

Source/WebCore:

No new tests. This is covered by two existing WPT tests.

  • page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::componentForAxis): Added this helper.
(WebCore::hasCompatibleSnapArea): Added this helper that checks to see if any of the snap areas
at a given scroll snap position are compatible with the viewport.
(WebCore::adjustPreviousAndNextForOnscreenSnapAreas): Adjusts the selected previous and next snap
positions by looking backward and forward for the first compatible snap position.
(WebCore::closestSnapOffsetWithInfoAndAxis): Use the new helper.

8:25 AM Changeset in webkit [281188] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Crash under JSIntersectionObserverCallback::handleEvent()
​https://bugs.webkit.org/show_bug.cgi?id=229196
<rdar://82016054>

Reviewed by Geoffrey Garen.

Early return in IntersectionObserver::notify() if the callback has already been destroyed.
This is not supposed to happen as we're supposed to be keeping the JSIntersectionObserver
wrapper alive as long as the IntersectionObserver may fire events, which should keep the
callback alive too. However, despite Ryosuke's fix in r280549, the crash is still happening
in the wild. To address the crash, I am simply doing an early return for now, similarly to
what we already do in MutationObserver::deliver(), while keeping a debug assertion around
in hope of finding the root cause at some point.

No new tests, we do not not how this is happening yet.

  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::notify):

8:10 AM Changeset in webkit [281187] by Russell Epstein
  • 8 edits in branches/safari-612.1.28-branch/Source

Versioning.

WebKit-7612.1.28.4

6:42 AM Changeset in webkit [281186] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
​https://bugs.webkit.org/show_bug.cgi?id=229200
rdar://81636256

Reviewed by Myles C. Maxfield.

The changes in ​https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
of cached fonts and images in display list items in the web and GPU processes, via a useCount counter variable
that's incremented in the web process whenever the font or image is used in a display list item and decremented
in the GPU process whenever the item is processed.

However, the code to increment useCount in the web process currently only triggers at most once per rendering
update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
update, the web process' notion of useCount will fall out of sync with the GPU process' notion of useCount.

In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
early, which causes the GPU process to prematurely purge the font from the cache, and subsequently wait for the
cached font to arrive (which will never arrive, since the web process has already released the font).

In other words, the timeline of events between the web and GPU processes looks like this (where f is a cached
web font, A_f is a drawing command that uses f, and B_f is another drawing command that uses f).

WEB GPU
==============================================================

  1. Cache f
  2. Append A_f
    1. Cache f
    2. Play back A_f
  3. Append B_f
  4. Release f (use count was 1 here)
    1. Release f (use count dropped from 1 to 0)
    2. Play back B_f ...and then display list playback stops due to f not being in the cache.

To address this, we simply move the useCount increment in the web process out of the rendering update check.
The original intent of the fix for bug #228216 was to allow for useCount to increment as many times as needed
per rendering update, so this limitation was unintentional.

Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).

  • WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::recordFontUse):

6:30 AM Changeset in webkit [281185] by Martin Robinson
  • 6 edits in trunk

position: sticky with display: inline-block
​https://bugs.webkit.org/show_bug.cgi?id=224415
<rdar://problem/76811968>

Reviewed by Simon Fraser.

Source/WebCore:

Improve sticky positioning applied to inline items. The first improvement is to
skip anonymous RenderBlock parents of inline display items when looking for the
containing block used to calculate sticky constraints. These anonymous parents
are not the containing block that constrains the movement of these kind of stickily
positioned items. Instead look for containing block for the anonymous parent,
which does limit the scroll boundaries of inline stickily position items.

Previously, when converting the frame rect from the coordinate space of the stickily
positioned item to that of the scrolling container, the code used to apply the offset
from the containing block to the scrolling ancestor directly to the frame rect. That
doesn't work when the containing block that determines sticky constraints is not the
direct containing block of the stickily positioned items (as it is for inlines).

Instead, the code now just maps the frame rect directly from the item parent to
the scrolling ancestor. This simplifies things a bit and allows it to work with
inline stickily positioned items.

Finally, this change adds comments to make it clearer what this method is doing.

No new tests. This is covered by existing WPT tests. Specifically the following
tests are now passing:

imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-hyperlink.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-nested-table.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-table-parts.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-table-th-bottom.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-nested-thead-th.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::positionOffsetValue): enclosingClippingBoxForStickyPosition now returns a pair
to avoid passing in a pointer. Only look at the first part of the pair here.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): Modified this method
to return a pair in order to avoid dealing with input parameters. This allows simplifying this
method, making the code a bit simpler.
(WebCore::RenderBoxModelObject::enclosingClippingBoxForStickyPosition const): Deleted.
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): Make two changes
to this method to improve sticky positioning for inline elements. The first change is
to be a bit better about finding the appropriate containing block for calculating sticky
constraints. The second is to more resiliently move from coordinate systems. In addition,
improve the comments for this method to make it clearer what is happening at each step.

  • rendering/RenderBoxModelObject.h: Updated method declaration.

LayoutTests:

a false pass previously.

2:13 AM Changeset in webkit [281184] by Martin Robinson
  • 2 edits in trunk/Tools

[Flatpak SDK] Increase the startup performance of webkit-flatpak
​https://bugs.webkit.org/show_bug.cgi?id=229185

Reviewed by Philippe Normand.

Improve flatpakutils.py by ensuring that we don't make redundant
calls to flatpak during initialization of the data structures. This
saves 5 seconds on every call to build-webkit and run-webkit-tests.

Before:

$ time ./Tools/Scripts/webkit-flatpak -c true
real 0m6,297s
user 0m0,786s
sys 0m0,513s

After:

$ time ./Tools/Scripts/webkit-flatpak -c true
real 0m1,243s
user 0m0,375s
sys 0m0,162s

  • flatpak/flatpakutils.py:

(FlatpakPackages.init): Separate the update into another
method so that it can be called directly when a package is installed.
Add new packages directly to self.packages.
(FlatpakRepos.init): Ensure that we only update our repositories
and package list once we've initialized our list of repositories.
(FlatpakRepos.add): Return True if this method actually changed anything
and accept a parameter determining whether an update is done to
the repository and package list.
(FlatpakRepos.is_package_installed): Added this method which replaces
FlatpakRepo.is_app_installed.
(FlatpakRepo.init): Remove the app registry because it is duplicated
by FlatpakPackages.
(FlatpakPackage.is_installed): Now call FlatpakRepos.is_package_installed.
(WebkitFlatpak._reset_repository): Set up both repositories here and
pass then as part of the FlatpakRepos constructor.
(WebkitFlatpak.main): Separate out the check which deletes the Flatpak
repository from the one that checks if the packages are installed. This
makes sure we don't install packages and then immediately delete them.
(WebkitFlatpak.check_installed_packages): rename _get_packages to _get_dependency_packages
in order to make it clear that it doesn't return installed packages.
(WebkitFlatpak._get_dependency_packages): Ditto.
(WebkitFlatpak.install_all): Ditto.
(FlatpakRepo.is_app_installed): Deleted.
(WebkitFlatpak._get_packages): Deleted.

1:26 AM Changeset in webkit [281183] by calvaris@igalia.com
  • 5 edits
    1 add in trunk/Source

[GStreamer][EME] Try to parse XML init datas that could possibly come from MPD manifests
​https://bugs.webkit.org/show_bug.cgi?id=229145

Reviewed by Alicia Boya Garcia.

Source/WebCore:

Added GStreamerEMEUtilities to include implementation of
InitData::extractCencIfNeeded. This tries to parse the possible
XML inside an init data that could come from MPD manifests. If it
succeeds, it keeps the parsed init data, if not, it returns the
original one.

Based on a patch by Philippe Normand.

  • platform/GStreamer.cmake:
  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.

(WebCore::markupStartElement):
(WebCore::markupEndElement):
(WebCore::markupText):
(WebCore::markupPassthrough):
(WebCore::markupError):
(WebCore::InitData::extractCencIfNeeded):

  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::InitData::InitData):

Source/WTF:

  • wtf/glib/GUniquePtr.h: Added deleter for GMarkupParseContext.

Aug 17, 2021:

11:50 PM Changeset in webkit [281182] by Devin Rousso
  • 9 edits in trunk/Source

Web Inspector: match the undocked tab bar style when docked bottom/side
​https://bugs.webkit.org/show_bug.cgi?id=212398

Reviewed by Timothy Hatcher.

Source/WebCore:

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::platformVersionName const):
Add macOS Monterey.

Source/WebInspectorUI:

This will avoid confusion when switching from docked to undocked (and vice versa) as the tab
bar UI will no longer be significantly different.

  • UserInterface/Views/TabBar.js:

(WI.TabBar):
(WI.TabBar.prototype.layout):
(WI.TabBar.prototype.layout.measureWidth):
(WI.TabBar.prototype._recordTabBarItemSizesAndPositions):
(WI.TabBar.prototype._applyTabBarItemSizesAndPositions):
(WI.TabBar.prototype._clearTabBarItemSizesAndPositions):
(WI.TabBar.prototype._handleMouseDown):
(WI.TabBar.prototype._handleMouseMoved):
(WI.TabBar.get horizontalPadding): Deleted.
(WI.TabBar.prototype._recordTabBarItemSizesAndPositions.add): Deleted.

  • UserInterface/Views/TabBar.css:

(.tab-bar):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar): Added.
(.tab-bar > .tabs > .item):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(.tab-bar > .tabs:not(.calculate-width) > .item:not(.pinned)):
(.tab-bar > .tabs > .item:nth-child(n + 2 of :not(.hidden)), .tab-bar > .tabs:not(.hide-border-start) > .item:nth-child(1 of :not(.hidden)), .tab-bar > .tabs.dragging-tab > .item.selected):
(.tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden))):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(.tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover, .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover + .item):
(.tab-bar > .tabs:not(.animating) > .item:last-child:not(.selected, .disabled):hover):
(body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item): Added.
(body.window-inactive .tab-bar > .tabs > .item):
(body.window-inactive .tab-bar > .tabs > .item:not(.disabled).selected):
(.tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected):
(body.window-inactive .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body.window-inactive .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body.window-inactive .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(@media (prefers-color-scheme: dark) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover > .icon):
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body.big-sur .tab-bar): Deleted.
(body:not(.docked) .tab-bar): Deleted.
(body.big-sur:not(.docked) .tab-bar): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar): Deleted.
(body.big-sur:not(.docked).window-inactive .tab-bar, body:not(.big-sur):not(.docked).window-inactive .tab-bar): Deleted.
(body.docked.window-inactive .tab-bar): Deleted.
(body.docked.bottom .tab-bar > .border.top): Deleted.
(body.big-sur.docked .tab-bar > .border.bottom): Deleted.
(body.docked .tab-bar .tabs): Deleted.
(body.docked .tab-bar > .tabs > .flexible-space): Deleted.
(body.docked.bottom .tab-bar > .tabs > .flexible-space): Deleted.
(body:not(.docked) .tab-bar > .tabs > .item): Deleted.
(body.big-sur:not(.docked) .tab-bar > .tabs > .item): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.calculate-width) > .item:not(.pinned)): Deleted.
(body.docked .tab-bar > .tabs > .item): Deleted.
(body:not(.docked) .tab-bar > .tabs > .item:nth-child(n + 3 of :not(.hidden)), body:not(.docked) .tab-bar > .tabs:not(.hide-border-start) > .item:nth-child(2 of :not(.hidden)), .tab-bar > .tabs.dragging-tab > .item.selected): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden))): Deleted.
(body.docked .tab-bar > .tabs > .item.pinned): Deleted.
(body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body.docked .tab-bar > .tabs > .item:not(.disabled):matches(.selected, :hover)): Deleted.
(body.docked .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(body.docked .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover, body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover + .item): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:last-child:not(.selected, .disabled):hover): Deleted.
(body:not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item, body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(body:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body.docked.window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body:not(.docked) .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body:not(.docked) .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body:not(.docked) .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected): Deleted.
(body:not(.docked).window-inactive .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body:not(.docked).window-inactive .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body:not(.docked).window-inactive .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur .tab-bar, body:not(.big-sur) .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.docked .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.docked.bottom .tab-bar > .border.top): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(@media (prefers-color-scheme: dark) body.docked .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(@media (prefers-color-scheme: dark) body.docked .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body.docked.window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover > .icon): Deleted.
(@media (prefers-color-scheme: dark) body:not(.docked).window-inactive .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar, body:not(.big-sur):not(.docked).window-inactive .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.

  • UserInterface/Views/TabBarItem.js:

(WI.TabBarItem.get horizontalMargin): Deleted.

  • remove the flexible space filler elements (and associated CSS) before and after the tabs
  • remove any .docked CSS
  • remove the (now unnecessary) :not(.docked) from all CSS related to the WI.TabBar
  • replace .big-sur with .mac-platform.big-sur for clarity
  • add .mac-platform.monterey alongside any .mac-platform.big-sur
  • UserInterface/Base/Main.js:

(WI.undockedTitleAreaHeight):

  • UserInterface/Views/Main.css:

(body:is(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive #undocked-title-area): Added.
(body.big-sur #undocked-title-area): Deleted.
(body:not(.big-sur) #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur) #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur.window-inactive #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur).window-inactive #undocked-title-area): Deleted.

  • UserInterface/Views/Variables.css:

(body:is(.mac-platform.monterey, .mac-platform.big-sur)): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur):not(.docked)): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur):not(.docked)): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur)): Added.
(body.big-sur): Deleted.
(body.mac-platform:not(.big-sur):not(.docked)): Deleted.
(body.mac-platform.big-sur:not(.docked)): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur): Deleted.
Add support for macOS Monterey.

11:26 PM Changeset in webkit [281181] by achristensen@apple.com
  • 2 edits in trunk/LayoutTests

Mark test as flaky: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
​https://bugs.webkit.org/show_bug.cgi?id=229181

r281147 changed this test from flaky to differently flaky.
It used to pass sometimes because the whole document would load before any script was executed, so there was no PerformanceNavigationTiming
object to update as the document loaded. r281147 fixed that, making it basically always pass when loaded over the real internet.
Now, sometimes it loads locally so fast that Performance::reduceTimeResolution makes some of the values 0, which is allowed by the spec but not
by the tests. In practice, pages don't load over the internet in less than 1ms, so this isn't much of an issue, just in our test bots.
I'll propose a fix for the web platform test, but for now I mark it as flaky.

8:55 PM Changeset in webkit [281180] by Russell Epstein
  • 8 edits in branches/safari-612.1.27.0-branch/Source

Versioning.

WebKit-7612.1.27.0.26

8:30 PM Changeset in webkit [281179] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GLIB] test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html is a flaky timeout since r278004
​https://bugs.webkit.org/show_bug.cgi?id=229219

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-17

  • platform/glib/TestExpectations:
7:27 PM Changeset in webkit [281178] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add an option for canonicalizePrePostIncrements
​https://bugs.webkit.org/show_bug.cgi?id=229211
<rdar://problem/82050126>

Reviewed by Mark Lam.

The current phase has bugs. Let's disable it for now until the bugs
are fixed. See discussion about the bugs I spotted in:
​https://bugs.webkit.org/show_bug.cgi?id=228538

  • b3/B3Generate.cpp:

(JSC::B3::generateToAir):

  • b3/testb3_3.cpp:

(addShrTests):

  • runtime/OptionsList.h:
7:20 PM Changeset in webkit [281177] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

[curl] Kept alive NetworkResourceLoaders should be cancelled by NetworkLoad::didCompleteWithError on PolicyAction::Ignore of didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=228095
<rdar://problem/81393898>

Unreviewed test failure fix.

  • http/tests/fetch/resources/get-set-temp-file.py: chmod +x.
5:57 PM Changeset in webkit [281176] by Russell Epstein
  • 1 copy in tags/Safari-612.1.28.3

Tag Safari-612.1.28.3.

5:55 PM Changeset in webkit [281175] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebKit

Fix crash in TestWebKitAPI.NetworkProcess.CrashWhenNotAssociatedWithDataStore
​https://bugs.webkit.org/show_bug.cgi?id=229209
rdar://82040197

Reviewed by Geoffrey Garen.

When getting network process connection fails, we don't need to retry or crash UI process if web process is
already gone.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getNetworkProcessConnection):

5:12 PM Changeset in webkit [281174] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ MacOS wk2 Debug ] http/wpt/webrtc/sframe-transform-error.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229206

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:05 PM Changeset in webkit [281173] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

[ Win EWS ] Rebaselining 2 http/tests/security/contentSecurityPolicy/worker-* tests.
​https://bugs.webkit.org/show_bug.cgi?id=229216

Unreviewed test gardening.

  • platform/win/http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
  • platform/win/http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
4:56 PM Changeset in webkit [281172] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac Guard-Malloc] imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-2.html is a flaky failure.
rdar://82053210.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:26 PM Changeset in webkit [281171] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] http/tests/security/no-javascript-refresh-percent-escaped.py is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=229215

Unreviewed test gardening.

  • platform/win/TestExpectations:
4:20 PM Changeset in webkit [281170] by Robert Jenner
  • 2 edits in trunk/LayoutTests

REGRESSION (r271146): [ iOS ] editing/selection/ios/scrolling-to-focused-element-inside-iframe.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=228200

Unreviewed test gardening.

  • platform/ios/TestExpectations:
4:10 PM Changeset in webkit [281169] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] performance-api/performance-timeline-api.html needs to be rebaselined.
​https://bugs.webkit.org/show_bug.cgi?id=229214

Unreviewed test gardening.

  • platform/win/performance-api/performance-timeline-api-expected.txt:
3:54 PM Changeset in webkit [281168] by Robert Jenner
  • 1 edit
    4 adds in trunk/LayoutTests

REBASELINE : [ iOS ] 3X imported/w3c/web-platform-t ests/css/css-typed-om layout-tests are constant text failures
​https://bugs.webkit.org/show_bug.cgi?id=229207

Unreviewed test gardening/ iOS rebaseline.

  • platform/ios/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
  • platform/ios/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
  • platform/ios/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
3:16 PM Changeset in webkit [281167] by Jonathan Bedard
  • 4 edits in trunk/Tools

[webkitcorepy] Return SourceFileLoader in find_module
​https://bugs.webkit.org/show_bug.cgi?id=229172
<rdar://problem/82006256>

Reviewed by Stephanie Lewis.

  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.find_module): Return SourceFileLoader object in Python 3.

2:42 PM Changeset in webkit [281166] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Mac wk2 ] http/tests/webAPIStatistics/screen-functions-accessed-data-collection.html is a flaky timeout.
rdar://82047046

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:22 PM Changeset in webkit [281165] by Russell Epstein
  • 8 edits in branches/safari-612.1.28-branch/Source

Versioning.

WebKit-7612.1.28.3

2:14 PM Changeset in webkit [281164] by Russell Epstein
  • 1 copy in tags/Safari-612.1.27.0.25

Tag Safari-612.1.27.0.25.

2:14 PM Changeset in webkit [281163] by Russell Epstein
  • 8 edits in branches/safari-612.1.27.0-branch/Source

Versioning

WebKit-7612.1.27.0.25

1:44 PM Changeset in webkit [281162] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

Rebaselining [ Win EWS ] http/tests/misc/webtiming-slow-load.py.
​https://bugs.webkit.org/show_bug.cgi?id=229099

Unreviewed test gardening.

  • platform/win/TestExpectations:
  • platform/win/http/tests/misc/webtiming-slow-load-expected.txt:
1:37 PM Changeset in webkit [281161] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-double-write.https.html is a constant failure.
rdar://82044002.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:32 PM Changeset in webkit [281160] by ddkilzer@apple.com
  • 9 edits in trunk/Source/ThirdParty/ANGLE

[Metal ANGLE] Fix over-autorelease of rx::DisplayMtl::getMetalDeviceMatchingAttribute() and various Objective-C leaks
<​https://webkit.org/b/229128>
<rdar://problem/81964007>

Reviewed by Alex Christensen.

  • src/libANGLE/renderer/metal/DisplayMtl.h:

(rx::DisplayMtl::getMetalDeviceMatchingAttribute):

  • Change to return mtl::AutoObjCPtr<> to make ownership clear.

(rx::DisplayMtl::mMetalDevice):

  • No need to initialize to nil.
  • src/libANGLE/renderer/metal/DisplayMtl.mm:

(rx::DisplayMtl::initializeImpl):

  • Update for changes to getMetalDeviceMatchingAttribute().

(rx::DisplayMtl::getMetalDeviceMatchingAttribute):

  • Change to return mtl::AutoObjCPtr<> to make ownership clear.
  • Fix leak of deviceList, externalGPUs, integratedGPUs, and discreteGPUs.
  • Use mtl::adoptObjCObj<>() to prevent leak of MTLCreateSystemDefaultDevice().
  • src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:
  • Fix leak of captureDescriptor in two different if blocks.
  • src/libANGLE/renderer/metal/ProgramMtl.mm:
  • Fix leak of funcConstants in early return on error path.
  • src/libANGLE/renderer/metal/ProvokingVertexHelper.mm:

(rx::ProvokingVertexHelper::getSpecializedShader):

  • Fix leak of fcValues.
  • src/libANGLE/renderer/metal/SurfaceMtl.mm:
  • Fix leak of captureDescriptor in two different if blocks.
  • src/libANGLE/renderer/metal/mtl_common.h:

(rx::mtl::WrappedObject::retainAssign):

  • Move statement inside #if/#endif that isn't needed for ARC.

(rx::mtl::WrappedObject::unretainAssign): Add.
(rx::mtl::AutoObjCPtr::AutoObjCPtr): Add.
(rx::mtl::adoptObjCObj): Add.

  • Add a helper method to adopt an Objective-C object to eliminate the need to autorelease a +1 retained object before an mtl::AutoObjCPtr<> object wraps it. Modeled after WTF::RetainPtr<> in WebKit.
  • src/libANGLE/renderer/metal/mtl_state_cache.mm:

(rx::mtl::RenderPipelineCache::createRenderPipelineState):
(rx::mtl::ProvokingVertexComputePipelineCache::createComputePipelineState):

  • Use adoptObjCObj<>() to fix potential leak on the early return path since these methods return an mtl::AutoObjCPtr<>.
1:19 PM Changeset in webkit [281159] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk2 Debug arm64,iOS 15 wk2] imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.html is a flaky failure.
rdar://82043074.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:57 PM Changeset in webkit [281158] by Fujii Hironori
  • 3 edits
    4 adds in trunk

[curl] Kept alive NetworkResourceLoaders should be cancelled by NetworkLoad::didCompleteWithError on PolicyAction::Ignore of didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=228095
<rdar://problem/81393898>

Reviewed by Don Olmstead.

Source/WebKit:

If a page dispatches a keepalive fetch and the page is navigated
away, the alive NetworkResourceLoader is transferred to the
NetworkSession by NetworkConnectionToWebProcess::transferKeptAliveLoad.
After the NetworkResourceLoader receives a response, it is canceled
by PolicyAction::Ignore.

However, NetworkDataTaskCurl didn't properly cancel the kept alive
NetworkResourceLoader. They remained in m_keptAliveLoads of
NetworkSession even after the requests were canceled.

Test: http/tests/fetch/keepalive-fetch-2.html

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): Call didCompleteWithError on PolicyAction::Ignore.

LayoutTests:

  • http/tests/fetch/keepalive-fetch-2-expected.txt: Added.
  • http/tests/fetch/keepalive-fetch-2.html: Added.
  • http/tests/fetch/resources/get-set-temp-file.py: Added.
  • http/tests/fetch/resources/keepalive-fetch-2-window.html: Added.
12:34 PM Changeset in webkit [281157] by jer.noble@apple.com
  • 6 edits in trunk/Source

De-duplicate the Cocoa-specific MediaPlayerPrivateRemote constructor
​https://bugs.webkit.org/show_bug.cgi?id=229193

Reviewed by Eric Carlson.

Source/WebCore:

Don't include a Objective-C header in a file which will be included by C++ source; forward-declare
the class instead.

  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

Source/WebKit:

Rather than have two, separate implementations of the MediaPlayerPrivateRemote constructor (one for Cocoa),
just wrap the initializer for the Cocoa-specific ivar in PLATFORM(COCOA) guards.

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):

  • WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote): Deleted.

12:23 PM Changeset in webkit [281156] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed. Skip failing MIPS tests
​https://bugs.webkit.org/show_bug.cgi?id=229198

Patch by Mikhail R. Gadelha <Mikhail R. Gadelha> on 2021-08-17

JSTests:

  • ChakraCore.yaml:

LayoutTests:

  • platform/wpe/TestExpectations:
12:11 PM Changeset in webkit [281155] by Lauro Moura
  • 2 edits in trunk/Tools

[GLIB] Avoid getting stuck searching for revision in some cases
​https://bugs.webkit.org/show_bug.cgi?id=229199

Reviewed by Philippe Normand.

With an empty .git/svn, the git svn info command might get stuck.

  • glib/apply-build-revision-to-files.py:

(get_build_revision):

12:02 PM Changeset in webkit [281154] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk1 Debug Intel] inspector/css/getMatchedStylesForNodeMarkerPseudoId.html is a flaky failure).
rdar://82039967.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:48 AM Changeset in webkit [281153] by Russell Epstein
  • 1 copy in tags/Safari-612.1.28.2

Tag Safari-612.1.28.2.

11:48 AM Changeset in webkit [281152] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk1 Debug] inspector/timeline/timeline-event-TimerInstall.html is a flaky crash.
rdar://82039288.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:41 AM Changeset in webkit [281151] by Russell Epstein
  • 2 edits in branches/safari-612.1.28-branch/Source/WebInspectorUI/WebInspectorUI.vcxproj

Cherry-pick r281121. rdar://problem/82038333

Apply patch. rdar://problem/81915461

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@281121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:41 AM Changeset in webkit [281150] by Russell Epstein
  • 6 edits in branches/safari-612.1.28-branch/Source

Cherry-pick r280597. rdar://problem/82038333

Speculative build fix. rdar://79147214.

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [281149] by Russell Epstein
  • 8 edits in branches/safari-612.1.28-branch/Source

Versioning.

WebKit-7612.1.28.2

10:46 AM Changeset in webkit [281148] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk2 Release] performance-api/paint-timing/paint-timing-with-worker.html is a flaky crash.
rdar://82036119.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:30 AM Changeset in webkit [281147] by commit-queue@webkit.org
  • 12 edits in trunk

Document load events should update timing in PerformanceNavigationTiming even after its instantiation
​https://bugs.webkit.org/show_bug.cgi?id=229181

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-17
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/navigation-timing/nav2_test_attributes_values-expected.txt:

Source/WebCore:

When we make a PerformanceNavigationTiming object, we copy the DocumentLoadTiming and DocumentEventTiming values.
If PerformanceNavigationTiming is accessed before the document has finished loading, we still need to update the timing values.

Covered by a newly passing WPT test, which Chrome and Firefox already pass.

  • dom/Document.cpp:

(WebCore::Document::documentEventTimingFromNavigationTiming):
(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):

  • dom/Document.h:
  • loader/DocumentLoadTiming.h:

(WebCore::DocumentLoadTiming::setLoadEventStart):
(WebCore::DocumentLoadTiming::setLoadEventEnd):
(WebCore::DocumentLoadTiming::markLoadEventStart): Deleted.
(WebCore::DocumentLoadTiming::markLoadEventEnd): Deleted.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

  • page/Performance.h:
  • page/PerformanceNavigationTiming.h:

LayoutTests:

This test now always passes in WK2.

10:25 AM Changeset in webkit [281146] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Star wk2 Release] performance-api/performance-observer-no-document-leak.html is a flaky crash.
rdar://82035182.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:05 AM Changeset in webkit [281145] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk2 Release] security/contentSecurityPolicy/image-with-file-url-allowed-by-img-src-star.html is flaky image-only fail.
rdar://82034073.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:41 AM Changeset in webkit [281144] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Mark webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=229192

This test now consistently either passes or fails and no longer times out.

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-17

  • platform/gtk/TestExpectations:
9:38 AM Changeset in webkit [281143] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2] webanimations/translate-property-and-translate-animation-with-delay-on-forced-layer.html is a flaky image-only fail.
rdar://82032946.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:36 AM Changeset in webkit [281142] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] fast/forms/number/number-spinbutton-state.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=229194

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:28 AM Changeset in webkit [281141] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] svg/custom/animate-initial-pause-unpause.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=229195

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:07 AM Changeset in webkit [281140] by achristensen@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests/imported/w3c

Remove unused test expectation file

  • web-platform-tests/resource-timing/idlharness-expected.txt: Removed.
9:01 AM Changeset in webkit [281139] by Razvan Caliman
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Do not show contextual documentation popup in the Changes panel
​https://bugs.webkit.org/show_bug.cgi?id=229001
<rdar://problem/81792379>

Reviewed by Devin Rousso.

Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.

  • UserInterface/Views/ChangesDetailsSidebarPanel.js:

(WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):

8:42 AM Changeset in webkit [281138] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Debug wk2 ] ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData).
​https://bugs.webkit.org/show_bug.cgi?id=223750

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:14 AM Changeset in webkit [281137] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Win10 wk1] animations/shadow-host-child-change.html is a constant failure.
​https://bugs.webkit.org/show_bug.cgi?id=229191.

Unreviewed test gardening.

  • platform/win/TestExpectations:
7:11 AM Changeset in webkit [281136] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Incorrect repaint when inline level box style change triggers line height change
​https://bugs.webkit.org/show_bug.cgi?id=229140
<rdar://problem/81980863>

Reviewed by Alan Bujtas.

Source/WebCore:

If an existing block shrinks vertically as a result of layout we fail to invalidate the
old content area for repaint, thus potentially leaving painting artefacts behind.
This is often hidden by the content shift triggering other repaints.

Test: fast/repaint/line-layout-block-shrink.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutModernLines):

Adjust the repaint area to include the content size before the layout.

LayoutTests:

  • fast/repaint/line-layout-block-shrink-expected.txt: Added.
  • fast/repaint/line-layout-block-shrink.html: Added.
6:47 AM Changeset in webkit [281135] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

REGRESSION(r218083): [GStreamer] webrtc unexpected failures
​https://bugs.webkit.org/show_bug.cgi?id=229187

Reviewed by Xabier Rodriguez-Calvar.

The stream-collection messages actually don't need to be handled synchronously in the
mediastream cases. The limitations of the MSE backend do not apply there.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

6:09 AM Changeset in webkit [281134] by Jean-Yves Avenard
  • 11 edits
    2 adds in trunk

Implement API to ensure MediaRemote key mapping is correct
​https://bugs.webkit.org/show_bug.cgi?id=229070
<rdar://problem/81894480>

Reviewed by Eric Carlson.

Source/WebCore:

This change adds Internals entries to test bug 229068.
While we do not mock the MediaRemote service, we still go one step further in
ensuring that the mappings between MediaSession action handlers and
PlatformMediaSession are correct.

Test: media/media-session/actionHandlerInternalMappings.html

  • platform/NowPlayingManager.cpp:

(WebCore::NowPlayingManager::supportedCommands const):

  • platform/NowPlayingManager.h:
  • platform/audio/PlatformMediaSession.h:
  • platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::supportedCommands const):

  • platform/audio/cocoa/MediaSessionManagerCocoa.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::supportedCommands const):

  • testing/Internals.cpp:

(WebCore::Internals::platformSupportedCommands const):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/media-session/actionHandlerInternalMappings-expected.txt: Added.
  • media/media-session/actionHandlerInternalMappings.html: Added.
3:16 AM Changeset in webkit [281133] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r278981): [GStreamer][Debug] Assert crashes when running media/track tests
​https://bugs.webkit.org/show_bug.cgi?id=229123
<rdar://problem/81978494>

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-17
Reviewed by Xabier Rodriguez-Calvar.

Implement a dummy id() method for InbandTextTrackPrivateGStreamer.

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
12:22 AM Changeset in webkit [281132] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

LayoutTests imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-* are flakey
​https://bugs.webkit.org/show_bug.cgi?id=229169

Reviewed by Eric Carlson.

When a data:// URL is passed to AVFoundation, the loading of that URL is handled by WebCoreAVFResourceLoader,
which in turn relies on a PlatformMediaResourceLoader to turn the data URL into a data buffer. However, in the
case of the GPU process, this means dispatching the request from GPU, to WebContent, to Network process and to
send the data back from the Network, to WebContent, to GPU process. If a synchronous operation (like painting)
is underway, the data response can block until that synchronous operation completes. If that operation is a
paint, and the data requested is required to complete that paint, the paint will fail.

For the narrow case of a data:// URL, it's not necessary to dispatch to another process to turn that URL into
data; it can happen locally, avoiding the hop to another process and the subsequent deadlock.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

(WebCore::WebCoreAVFResourceLoader::logger const):

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::DataURLResourceMediaLoader::DataURLResourceMediaLoader):
(WebCore::WebCoreAVFResourceLoader::~WebCoreAVFResourceLoader):
(WebCore::WebCoreAVFResourceLoader::startLoading):

Note: See TracTimeline for information about the timeline view.