⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 22, 2021:

11:28 PM Changeset in webkit [281438] by ysuzuki@apple.com
  • 38 edits in trunk

[JSC] Remove already-shipped wasm option flags
​https://bugs.webkit.org/show_bug.cgi?id=229386

Reviewed by Ross Kirsling.

JSTests:

  • wasm/references/element_active_mod.js:
  • wasm/references/element_parsing.js:
  • wasm/references/externref_globals.js:
  • wasm/references/externref_modules.js:
  • wasm/references/externref_table.js:
  • wasm/references/externref_table_import.js:
  • wasm/references/func_ref.js:
  • wasm/references/globals.js:
  • wasm/references/is_null.js:
  • wasm/references/memory_copy.js:
  • wasm/references/memory_copy_shared.js:
  • wasm/references/memory_fill_shared.js:
  • wasm/references/multitable.js:
  • wasm/references/parse_unreachable.js:
  • wasm/references/table_js_api.js:
  • wasm/references/table_misc.js:
  • wasm/references/validation.js:
  • wasm/stress/immutable-globals.js:
  • wasm/stress/local-ref.js:
  • wasm/stress/mutable-globals.js:
  • wasm/stress/table-grow-table-size.js:

Source/JavaScriptCore:

This patch removes some wasm option flags which are already shipped.

  • runtime/OptionsList.h:
  • wasm/WasmFormat.h:

(JSC::Wasm::isValueType):

  • wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

  • wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

  • wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::parseBlockSignature):

  • wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseType):
(JSC::Wasm::SectionParser::parseElement):
(JSC::Wasm::SectionParser::parseData):
(JSC::Wasm::SectionParser::parseDataCount):

  • wasm/js/JSWebAssembly.cpp:

(JSC::JSWebAssembly::finishCreation):

  • wasm/js/WebAssemblyGlobalConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

Tools:

  • Scripts/run-jsc-stress-tests:

LayoutTests:

  • workers/wasm-references.html:
11:22 PM Changeset in webkit [281437] by bshafiei@apple.com
  • 1 copy in tags/Safari-612.1.27.3.7

Tag Safari-612.1.27.3.7.

11:17 PM Changeset in webkit [281436] by bshafiei@apple.com
  • 2 edits in branches/safari-612.1.27.3-branch/Source/JavaScriptCore

Apply patch. rdar://problem/82196634

10:46 PM Changeset in webkit [281435] by bshafiei@apple.com
  • 8 edits in branches/safari-612.1.27.3-branch/Source

Versioning.

WebKit-7612.1.27.3.7

10:12 PM Changeset in webkit [281434] by mark.lam@apple.com
  • 2 edits in tags/Safari-612.1.27.3.5/Source/JavaScriptCore

Build fix for bad cherry-pick of r281178.
rdar://problem/82083485

Not reviewed.

  • b3/testb3_3.cpp:
9:25 PM Changeset in webkit [281433] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[iOS] Unreviewed test gardening.

  • platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt:
8:55 PM Changeset in webkit [281432] by Alan Bujtas
  • 6 edits in trunk

[LFC][IFC] Add support for vertical-align: super
​https://bugs.webkit.org/show_bug.cgi?id=228235

Reviewed by Antti Koivisto.

Source/WebCore:

  • layout/formattingContexts/inline/InlineFormattingGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

LayoutTests:

  • platform/mac/css1/text_properties/vertical_align-expected.txt:
7:24 PM Changeset in webkit [281431] by Kate Cheney
  • 9 edits
    8 adds in trunk

Report correct blocked URI in CSP violation report
​https://bugs.webkit.org/show_bug.cgi?id=226316
<rdar://problem/78552912>

Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/report-blocked-uri-after-blocked-redirect.html

http/tests/security/contentSecurityPolicy/report-blocked-uri-after-multiple-redirects.html

Currently for a blocked redirection we report the blocked URI as the
target URL. This is not up to spec and we should actually report the
requested URL.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy):

  • loader/DocumentThreadableLoader.h:
  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allowConnectToSource const):
(WebCore::ContentSecurityPolicy::reportViolation const):

  • page/csp/ContentSecurityPolicy.h:

Source/WebKit:

Currently for a blocked redirection we report the blocked URI as the
target URL. This is not up to spec and we should actually report the
requested URL.

  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::check):
(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::checkRequest):
(WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy):

  • NetworkProcess/NetworkLoadChecker.h:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/report-blocked-uri-after-blocked-redirect-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-after-blocked-redirect.html: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-after-multiple-redirects-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-after-multiple-redirects.html: Added.
  • platform/mac-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-after-multiple-redirects-expected.txt: Added.
  • platform/mac-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-after-blocked-redirect-expected.txt: Added.
  • platform/win/http/tests/security/contentSecurityPolicy/report-blocked-uri-after-blocked-redirect-expected.txt: Added.
  • platform/win/http/tests/security/contentSecurityPolicy/report-blocked-uri-after-multiple-redirects-expected.txt: Added.

WebKitLegacy and Win have different console logging.

6:41 PM Changeset in webkit [281430] by Lauro Moura
  • 5 edits in trunk

[WPE][WebDriver] Basic fullscreen support for the headless backend
​https://bugs.webkit.org/show_bug.cgi?id=229380

Reviewed by Adrian Perez de Castro.

Tools:

r280774 added support for fullscreen in the WindowViewBackend, but
many webdriver tests started failing as they run in the headless
backend.

This commits adds basic support in HeadlessBackend to make some
tests pass. Currently, just storing the fullscreen state and
forwarding the events to the WPE backend functions.

A number of tests are still failing due to the missing multiple window
support (required through the session fixtures), but also there are
still some failing that expect the view to be started in
non-fullscreen mode, which does not happen in the headless backend.

  • wpe/backends/HeadlessViewBackend.cpp:

(WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
(WPEToolingBackends::HeadlessViewBackend::onDOMFullScreenRequest):
(WPEToolingBackends::HeadlessViewBackend::dispatchFullscreenEvent):

  • wpe/backends/HeadlessViewBackend.h:

WebDriverTests:

  • TestExpectations.json: Skip some tests still failing, mainly due to multiple window support missing.
6:06 PM Changeset in webkit [281429] by ysuzuki@apple.com
  • 147 edits in trunk

[JSC] Remove already-shipped JS feature flags
​https://bugs.webkit.org/show_bug.cgi?id=229387

Reviewed by Ross Kirsling.

JSTests:

  • microbenchmarks/class-fields-private/get-private-name.js:
  • microbenchmarks/class-fields-private/monomorphic-get-private-field.js:
  • microbenchmarks/class-fields-private/polymorphic-get-private-field.js:
  • microbenchmarks/class-fields-private/polymorphic-put-private-field.js:
  • microbenchmarks/class-fields-private/put-private-field.js:
  • stress/class-fields-private-as-function.js:
  • stress/class-fields-private-cached-bytecode.js:
  • stress/class-fields-private-freeze-out-of-line.js:
  • stress/class-fields-private-freeze.js:
  • stress/class-fields-private-harmony.js:
  • stress/class-fields-private-on-proxy.js:
  • stress/class-fields-private-out-of-line.js:
  • stress/class-fields-private-prevent-extensions-out-of-line.js:
  • stress/class-fields-private-prevent-extensions.js:
  • stress/class-fields-private-seal-out-of-line.js:
  • stress/class-fields-private-seal.js:
  • stress/class-fields-private-use-eval.js:
  • stress/class-fields-static-harmony.js:
  • stress/class-fields-static-private-harmony.js:
  • stress/class-fields-stress-instance.js:
  • stress/class-private-method-access.js:
  • stress/dfg-get-private-name-by-id-generic.js:
  • stress/dfg-get-private-name-by-id-osr-bad-identifier.js:
  • stress/dfg-get-private-name-by-id.js:
  • stress/dfg-get-private-name-by-offset-osr-bad-identifier.js:
  • stress/dfg-get-private-name-by-offset-osr-bad-structure.js:
  • stress/dfg-get-private-name-by-offset.js:
  • stress/dfg-get-private-name-by-val-generic.js:
  • stress/dfg-put-private-name-check-barrier-insertion.js:
  • stress/dfg-put-private-name-compiled-as-put-by-id-direct.js:
  • stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js:
  • stress/ftl-get-private-name-by-id.js:
  • stress/ftl-get-private-name-by-offset-multi.js:
  • stress/get-private-name-cache-failure.js:
  • stress/get-private-name-with-constant-ident.js:
  • stress/get-private-name-with-constant-symbol.js:
  • stress/get-private-name-with-different-symbol.js:
  • stress/get-private-name-with-primitive.js:
  • stress/get-private-name.js:
  • stress/optional-chaining-and-private-fields.js:
  • stress/private-accesor-duplicate-name-early-errors.js:
  • stress/private-accessor-static-non-static.js:
  • stress/private-brand-installed-after-super-call-from-arrow-function.js:
  • stress/private-brand-installed-after-super-call-from-eval.js:
  • stress/private-getter-brand-check.js:
  • stress/private-getter-inner-class.js:
  • stress/private-in-error.js:
  • stress/private-in.js:
  • stress/private-members-get-and-set.js:
  • stress/private-method-and-field-named-constructor.js:
  • stress/private-method-brand-check.js:
  • stress/private-method-change-attribute-from-branded-structure.js:
  • stress/private-method-change-prototype-from-branded-structure.js:
  • stress/private-method-check-private-brand-ic.js:
  • stress/private-method-check-structure-miss.js:
  • stress/private-method-comparison.js:
  • stress/private-method-delete-property-from-branded-structure.js:
  • stress/private-method-extends-brand-check.js:
  • stress/private-method-get-and-call.js:
  • stress/private-method-invalid-multiple-brand-installation.js:
  • stress/private-method-invalidate-compiled-with-constant-symbol.js:
  • stress/private-method-nested-class.js:
  • stress/private-method-on-sealed-objects.js:
  • stress/private-method-on-uncacheable-dictionary.js:
  • stress/private-method-polymorphic-with-constant-symbol.js:
  • stress/private-method-set-brand-should-have-write-barrier.js:
  • stress/private-method-untyped-use.js:
  • stress/private-method-with-uncacheable-dictionary-transition.js:
  • stress/private-methods-and-accessors-postfix-node.js:
  • stress/private-methods-and-accessors-prefix-node.js:
  • stress/private-methods-inline-cache.js:
  • stress/private-methods-megamorphic-ic.js:
  • stress/private-methods-on-proxy.js:
  • stress/private-methods-poly-ic-multiple-classes.js:
  • stress/private-methods-poly-ic-single-class.js:
  • stress/private-name-access-in-computed-property.js:
  • stress/private-names-available-on-direct-eval.js:
  • stress/private-names-available-on-eval-during-field-initialization.js:
  • stress/private-setter-brand-check.js:
  • stress/private-setter-inner-class.js:
  • stress/put-by-val-direct-addprivate.js:
  • stress/put-by-val-direct-putprivate.js:
  • stress/put-private-name-by-id-set-do-not-add-structure-trasition.js:
  • stress/put-private-name-check-structure-miss.js:
  • stress/put-private-name-constant-folding-to-mult-put-by-offset.js:
  • stress/put-private-name-constant-folding-to-put-by-offset.js:
  • stress/put-private-name-generic.js:
  • stress/put-private-name-invalid-define.js:
  • stress/put-private-name-invalid-store.js:
  • stress/put-private-name-invalidate-compiled-with-constant-symbol.js:
  • stress/put-private-name-polymorphic-with-constant-symbol.js:
  • stress/put-private-name-untyped-use.js:
  • stress/put-private-name-with-constant-symbol.js:
  • stress/put-private-name-with-different-identifier.js:
  • stress/put-private-name-with-primitive.js:
  • stress/static-private-methods-and-accessor-inner-class.js:
  • stress/static-private-methods-and-accessor-multiple-evaluation.js:
  • stress/static-private-methods-and-accessors-postfix-node.js:
  • stress/static-private-methods-and-accessors-prefix-node.js:
  • stress/v8-cleanup-from-different-realm.js:
  • stress/v8-cleanup-proxy-from-different-realm.js:
  • stress/v8-finalization-registry-basics.js:
  • stress/v8-finalizationregistry-and-weakref.js:
  • stress/v8-finalizationregistry-keeps-holdings-alive.js:
  • stress/v8-finalizationregistry-scheduled-for-cleanup-multiple-times.js:
  • stress/v8-multiple-dirty-finalization-registries.js:
  • stress/v8-reentrant-gc-from-cleanup.js:
  • stress/v8-stress-finalizationregistry-dirty-enqueue.js:
  • stress/v8-undefined-holdings.js:
  • stress/v8-unregister-after-cleanup.js:
  • stress/v8-unregister-before-cleanup.js:
  • stress/v8-unregister-called-twice.js:
  • stress/v8-unregister-inside-cleanup2.js:
  • stress/v8-unregister-inside-cleanup3.js:
  • stress/v8-unregister-many.js:
  • stress/v8-weak-unregistertoken.js:
  • test262/config.yaml:

Source/JavaScriptCore:

These features are already shipped. So removing these runtime flags to clean up source code and
remove untested path.

  • API/JSObjectRef.cpp:

(JSObjectMakeError):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallValueNode::emitBytecode):

  • parser/Lexer.cpp:

(JSC::Lexer<T>::lexWithoutClearingLineTerminator):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseBinaryExpression):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseUnaryExpression):

  • runtime/AggregateErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/ErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/JSGlobalObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor<errorType>::constructImpl):
(JSC::NativeErrorConstructor<errorType>::callImpl):

  • runtime/Options.cpp:

(JSC::Options::recomputeDependentOptions):

  • runtime/OptionsList.h:
  • wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

Tools:

  • Scripts/run-jsc-benchmarks:

LayoutTests:

  • js/script-tests/weakref-async-is-collected.js:
  • js/script-tests/weakref-eventually-collects-values.js:
  • js/script-tests/weakref-finalizationregistry.js:
  • js/script-tests/weakref-microtasks-dont-collect.js:
  • js/script-tests/weakref-weakset-consistency.js:
  • js/weakref-async-is-collected.html:
  • js/weakref-eventually-collects-values.html:
  • js/weakref-finalizationregistry.html:
  • js/weakref-microtasks-dont-collect.html:
  • js/weakref-weakset-consistency.html:
  • webaudio/finished-audio-buffer-source-nodes-should-be-collectable.html:
6:02 PM Changeset in webkit [281428] by Kocsen Chung
  • 1 copy in tags/Safari-612.1.28.5

Tag Safari-612.1.28.5.

5:59 PM Changeset in webkit [281427] by Kocsen Chung
  • 4 edits in branches/safari-612.1.28-branch/Source

Cherry-pick r281384. rdar://problem/82224622

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [281426] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

Tiny cleanups in CSS parsing code
​https://bugs.webkit.org/show_bug.cgi?id=229369

Reviewed by Alan Bujtas.

Use references for non-nullable pointers, and pass nullptr instead of 0 to other pointer parameters.

No new tests because there is no behavior change.

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):

  • css/StyleSheetContents.h:
  • css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):

  • css/parser/CSSParser.h:
  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parseStyleSheet):

  • css/parser/CSSParserImpl.h:
5:46 PM Changeset in webkit [281425] by Kocsen Chung
  • 8 edits in branches/safari-612.1.28-branch/Source

Versioning.

WebKit-7612.1.28.5

5:03 PM Changeset in webkit [281424] by Alan Bujtas
  • 5 edits
    2 adds in trunk

[LFC][IFC] Add support for out-of-flow box static positioning
​https://bugs.webkit.org/show_bug.cgi?id=229103

Reviewed by Antti Koivisto.

Source/WebCore:

This patch is in preparation for enabling positioned content for IFC handling.

In this patch we compute the static position for out-of-flow content inside the inline formatting context.
As per spec, the static position of an out-of-flow box is computed as if the position was set to static.
However it does not mean that the out-of-flow box should be involved in the inline layout process.
Instead we figure out this static position after the inline layout by looking at
the previous sibling (or parent) box's geometry and place the out-of-flow box at the logical right position.

  • layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::lineLayoutForIntergration):
(WebCore::Layout::InlineFormattingContext::computeStaticPositionForOutOfFlowContent):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::collectContentIfNeeded):
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded): Deleted.

  • layout/formattingContexts/inline/InlineFormattingContext.h:

LayoutTests:

  • fast/inline/out-of-flow-with-static-position-in-ifc-expected.html: Added.
  • fast/inline/out-of-flow-with-static-position-in-ifc.html: Added.
4:45 PM Changeset in webkit [281423] by mmaxfield@apple.com
  • 5 edits in trunk/Source/WebCore

REGRESSION(r281389): canUseSimplifiedTextMeasuring() needs to match with WidthIterator::applyCSSVisibilityRules()
​https://bugs.webkit.org/show_bug.cgi?id=229388

Reviewed by Alan Bujtas.

WidthIterator::applyCSSVisibilityRules() has some special handling for specific characters.
If those characters are present, we need to make sure we actually use WidthIterator::applyCSSVisibilityRules()
instead of taking the fast path in FontCascade::widthForSimpleText().

This is split out from ​https://bugs.webkit.org/show_bug.cgi?id=215643, and will be tested by that bug's test.

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::canUseSimplifiedTextMeasuring):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::characterCanUseSimplifiedTextMeasuring):
(WebCore::WidthIterator::applyCSSVisibilityRules):

  • platform/graphics/WidthIterator.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const):

3:18 PM Changeset in webkit [281422] by Alan Bujtas
  • 25 edits in trunk

[LFC][IFC] Add support for vertical-align: sub
​https://bugs.webkit.org/show_bug.cgi?id=228217

Reviewed by Antti Koivisto.

Source/WebCore:

Adjust legacy's integral alignment too.

  • layout/formattingContexts/inline/InlineFormattingGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

LayoutTests:

  • platform/mac/css1/text_properties/vertical_align-expected.txt:
  • platform/mac/fast/selectors/018b-expected.txt:
  • platform/mac/fast/text/whitespace/020-expected.txt:
3:09 PM Changeset in webkit [281421] by ysuzuki@apple.com
  • 2 edits in trunk/JSTests

Unreviewed, speculative fix for old ICU
​https://bugs.webkit.org/show_bug.cgi?id=229385

  • stress/intl-locale-info.js:

(shouldBe):

2:26 PM Changeset in webkit [281420] by Wenson Hsieh
  • 6 edits
    2 adds in trunk

[iOS] Fix and reenable several layout tests to account for the changes in rdar://80384564
​https://bugs.webkit.org/show_bug.cgi?id=229316

Reviewed by Tim Horton.

Source/WebKit:

After rdar://80384564, UIKit's non-editable text tap recognizer will no longer cause us to clear the active text
selection range when tapping outside of currently selected text in the page. Instead, WebKit's synthetic click
gesture recognizer should now manages clearing the selection (unless the page has prevented the "mousedown"
event).

With just the UIKit-side change, this already mostly works as expected since commitPotentialTapFailed() clears
out non-editable selections. However, there is one scenario in which we do want to clear out the selection when
tapping that isn't covered by the synthetic click gesture: when tapping on an element that does not handle or
prevent "mousedown"; this behavior is exercised by the existing layout test
editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html. To preserve this behavior, we
add a call to clearSelectionAfterTapIfNeeded() when completing a synthetic click, in the case where the
"mousedown" event was not swallowed.

These 3 tests should pass after the changes in rdar://80384564:

  • editing/selection/ios/change-selection-by-tapping-with-existing-selection.html
  • editing/selection/preserve-selection-when-clicking-button.html
  • editing/selection/ios/persist-selection-after-tapping-on-element-with-mousedown-handler.html

And these WebKit-side changes are needed to keep these 2 tests passing:

  • editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html
  • fast/images/text-recognition/ios/reselect-word-in-image-overlay.html
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::completeSyntheticClick):

LayoutTests:

See WebKit/ChangeLog for more details.

  • fast/images/text-recognition/ios/reselect-word-in-image-overlay.html:

Add a short delay to avoid timing out, due to the second long press gesture to select text not triggering.

  • platform/ios-14/TestExpectations:

Remove iOS 14-specific PASS expectations, and remove the more generic FAIL expectation in the ios directory.
Instead, just mark these three layout tests as FAIL on iOS 15, and PASS elsewhere.

  • platform/ios-15/TestExpectations: Added.
  • platform/ios/TestExpectations:
2:04 PM Changeset in webkit [281419] by mmaxfield@apple.com
  • 10 edits
    61 moves in trunk

Control characters (Unicode category Cc) should be rendered visibly
​https://bugs.webkit.org/show_bug.cgi?id=149128
<rdar://problem/79224941>

Reviewed by Alan Bujtas.

LayoutTests/imported/w3c:

These tests were erroneously marked as reference tests, when they should be reference-mismatch tests.

  • web-platform-tests/css/css-text/white-space/control-chars-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-001-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-002-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-002-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-003-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-003-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-004-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-004-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-005-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-005-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-006-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-006-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-007-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-007-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-008-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-008-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-00B-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00B-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-00C-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00C-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-00E-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00E-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-00F-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-00F-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-010-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-010-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-011-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-011-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-012-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-012-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-013-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-013-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-014-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-014-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-015-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-015-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-016-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-016-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-017-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-017-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-018-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-018-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-019-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-019-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-01A-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01A-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-01B-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01B-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-01C-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01C-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-01D-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01D-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-01E-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01E-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-01F-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-01F-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-07F-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-07F-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-080-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-080-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-081-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-081-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-082-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-082-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-083-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-083-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-084-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-084-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-085-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-085-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-086-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-086-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-087-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-087-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-088-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-088-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-089-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-089-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-08A-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-08A-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-08B-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-08B-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-08C-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-08C-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-08D-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-08D-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-08E-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-08E-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-08F-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-08F-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-090-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-090-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-091-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-091-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-092-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-092-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-093-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-093-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-094-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-094-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-095-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-095-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-096-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-096-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-097-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-097-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-098-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-098-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-099-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-099-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-09A-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-09A-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-09B-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-09B-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-09C-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-09C-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-09D-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-09D-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-09E-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-09E-expected.html.
  • web-platform-tests/css/css-text/white-space/control-chars-09F-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-09F-expected.html.

Source/WebCore:

We can map these glyphs to the .notdef glyph, which is (supposed to be) visible.

Tests: fast/dom/52776.html

fast/text/fixed-pitch-control-characters.html
fast/text/wide-zero-width-space.html
fast/text/zero-width-characters.html
imported/w3c/web-platform-tests/css/css-text/white-space*

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::applyCSSVisibilityRules):

LayoutTests:

Update existing tests.

  • fast/text/fixed-pitch-control-characters-expected.txt:
  • fast/text/wide-zero-width-space.html:
  • fast/text/zero-width-characters.html:
  • platform/ios/fast/dom/52776-expected.txt:
  • platform/mac/fast/dom/52776-expected.txt:
  • platform/mac/fast/text/wide-zero-width-space-expected.txt: This actually shows that there's a difference between the fast text codepath and the complex text codepath, but that's okay for now because the complex text codepath is going away. Also, it's not practical to fix this in the complex text codepath, because that would require a CoreText change. So, for now, we can just encode the behavior difference in our test, and when the complex codepath finally goes away, this test will be updated to be working correctly again.
1:47 PM Changeset in webkit [281418] by Kocsen Chung
  • 1 copy in tags/Safari-612.1.27.3.6

Tag Safari-612.1.27.3.6.

1:43 PM Changeset in webkit [281417] by Kocsen Chung
  • 4 edits in branches/safari-612.1.27.3-branch/Source

Cherry-pick r281384. rdar://problem/82218746

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 PM Changeset in webkit [281416] by Kocsen Chung
  • 8 edits in branches/safari-612.1.27.3-branch/Source

Versioning.

WebKit-7612.1.27.3.6

1:33 PM Changeset in webkit [281415] by Kocsen Chung
  • 1 copy in tags/Safari-612.1.27.2.4

Tag Safari-612.1.27.2.4.

1:29 PM Changeset in webkit [281414] by Kocsen Chung
  • 4 edits in branches/safari-612.1.27.2-branch/Source

Cherry-pick r281384. rdar://problem/82218737

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:28 PM Changeset in webkit [281413] by Kocsen Chung
  • 8 edits in branches/safari-612.1.27.2-branch/Source

Versioning.

WebKit-7612.1.27.2.4

1:11 PM Changeset in webkit [281412] by Jonathan Bedard
  • 6 edits in trunk/Tools

[git-webkit] Add pull-request command (Part 5)
​https://bugs.webkit.org/show_bug.cgi?id=229089
<rdar://problem/81908751>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.modified): Return a list of modified files in the current checkout.

  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:

(Git.init): Add 'git diff' mock commands.

  • Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

(TestGit.test_modified):
(TestGit.test_modified_no_staged):
(TestGit.test_modified_staged):

12:50 PM Changeset in webkit [281411] by Kocsen Chung
  • 1 copy in tags/Safari-607.3.15

Tag Safari-607.3.15.

12:50 PM Changeset in webkit [281410] by Kocsen Chung
  • 1 copy in tags/Safari-611.3.10.0.2

Tag Safari-611.3.10.0.2.

12:49 PM Changeset in webkit [281409] by Kocsen Chung
  • 1 copy in tags/Safari-611.3.10.1.7

Tag Safari-611.3.10.1.7.

12:49 PM Changeset in webkit [281408] by Kocsen Chung
  • 1 copy in tags/Safari-611.4.1.0.2

Tag Safari-611.4.1.0.2.

12:48 PM Changeset in webkit [281407] by Kocsen Chung
  • 1 copy in tags/Safari-612.1.27.0.30

Tag Safari-612.1.27.0.30.

10:25 AM Changeset in webkit [281406] by Kocsen Chung
  • 4 edits in branches/safari-607-branch/Source

Cherry-pick r281384. rdar://problem/82218742

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:25 AM Changeset in webkit [281405] by Kocsen Chung
  • 2 edits in branches/safari-607-branch/Source/WTF

Cherry-pick r242732. rdar://problem/82218742

Crash under WebCore::IDBDatabase::connectionToServerLost
​https://bugs.webkit.org/show_bug.cgi?id=195563
<rdar://problem/37193655>

CrossThreadTask should protect callee if it is ThreadSafeRefCounted.

Reviewed by Geoffrey Garen.

  • wtf/CrossThreadTask.h: (WTF::createCrossThreadTask):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:22 AM Changeset in webkit [281404] by Kocsen Chung
  • 4 edits in branches/safari-611.3.10.0-branch/Source

Cherry-pick r281384. rdar://problem/82218729

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:15 AM Changeset in webkit [281403] by Kocsen Chung
  • 8 edits in branches/safari-611.3.10.0-branch/Source

Versioning.

WebKit-7611.3.10.0.2

10:08 AM Changeset in webkit [281402] by Kocsen Chung
  • 33 edits
    2 deletes in branches/safari-611.3.10.0-branch

Revert to original content from 611.3.10.0.1

9:38 AM Changeset in webkit [281401] by Kocsen Chung
  • 4 edits in branches/safari-612.1.27.0-branch/Source

Cherry-pick r281384. rdar://problem/82218749

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:35 AM Changeset in webkit [281400] by Kocsen Chung
  • 8 edits in branches/safari-612.1.27.0-branch/Source

Versioning.

WebKit-7612.1.27.0.30

9:29 AM Changeset in webkit [281399] by Jonathan Bedard
  • 4 edits in trunk/Tools

[git-webkit] Add pull-request command (Part 4)
​https://bugs.webkit.org/show_bug.cgi?id=229089
<rdar://problem/81908751>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git): Match BitBucket ssh urls when constructing remotes.

8:35 AM Changeset in webkit [281398] by Simon Fraser
  • 18 edits in trunk/Source/WebKit

Use the strongly typed PageGroupIdentifier in place of uint64_t
​https://bugs.webkit.org/show_bug.cgi?id=229356

Reviewed by Alex Christensen.

Replace uses of uint64_t for page group identifiers with PageGroupIdentifier.

There are two places where we convert between StorageNamespaceIdentifier and
PageGroupIdentifier because, as the comments state, those are equivalent.

  • Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):
(headers_for_type):

  • Shared/IdentifierTypes.h:
  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h:
  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::get):
(WebKit::pageGroupData):
(WebKit::generatePageGroupID): Deleted.

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::pageGroupID const):

  • WebProcess/Databases/WebDatabaseProvider.cpp:

(WebKit::WebDatabaseProvider::getOrCreate):
(WebKit::WebDatabaseProvider::WebDatabaseProvider):

  • WebProcess/Databases/WebDatabaseProvider.h:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):

  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/WebPage/WebPageGroupProxy.h:

(WebKit::WebPageGroupProxy::pageGroupID const):
(WebKit::WebPageGroupProxy::localStorageNamespaceIdentifier const):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):
(WebKit::WebProcess::establishWorkerContextConnectionToNetworkProcess):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/WebStorage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::pageGroupID const):

  • WebProcess/WebStorage/StorageNamespaceImpl.h:
12:35 AM Changeset in webkit [281397] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r280984 and r280996.
​https://bugs.webkit.org/show_bug.cgi?id=229384

Speedometer2 0.3-0.5% regression

Reverted changesets:

"Update ARM64EHash"
​https://bugs.webkit.org/show_bug.cgi?id=228962
​https://commits.webkit.org/r280984

"Refactor some ARM64EHash code."
​https://bugs.webkit.org/show_bug.cgi?id=229054
​https://commits.webkit.org/r280996

12:25 AM Changeset in webkit [281396] by Kocsen Chung
  • 8 edits in branches/safari-611.4.1.0-branch/Source

Versioning.

WebKit-7611.4.1.0.2

12:19 AM Changeset in webkit [281395] by Kocsen Chung
  • 1 copy in branches/safari-611.4.1.0-branch

New branch.

12:10 AM Changeset in webkit [281394] by Kocsen Chung
  • 4 edits in branches/safari-611.3.10.0-branch/Source

Cherry-pick r281384. rdar://problem/82195071

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Aug 21, 2021:

11:23 PM Changeset in webkit [281393] by Kocsen Chung
  • 7 edits in branches/safari-607-branch/Source

Versioning.

WebKit-7607.3.15

11:22 PM Changeset in webkit [281392] by Kocsen Chung
  • 4 edits in branches/safari-611.3.10.1-branch/Source

Cherry-pick r281384. rdar://problem/82195071

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:52 PM Changeset in webkit [281391] by Kocsen Chung
  • 8 edits in branches/safari-611.3.10.1-branch/Source

Versioning.

WebKit-7611.3.10.1.7

10:46 PM Changeset in webkit [281390] by Kocsen Chung
  • 8 edits in branches/safari-611.3.10.0-branch/Source

Versioning.

WebKit-7611.4.0.2

10:41 PM Changeset in webkit [281389] by mmaxfield@apple.com
  • 10 edits
    3 adds in trunk

overwriteCodePoint() in createAndFillGlyphPage() is wrong
​https://bugs.webkit.org/show_bug.cgi?id=215643
<rdar://problem/67430461>

Reviewed by Alan Bujtas.

Source/WebCore:

The CSS spec says that certain characters have to be invisible. Previously, we were doing this
by just treating these characters as if they were the zero width space character. However, this
is wrong for 2 reasons:

  1. If the primary font supports the desired character but doesn't support the zero width space

character, we'll fallback past it and trigger a download for secondary fonts until
we find one that supports the ZWS character (which the page didn't even ask for!)

  1. Shaping is Turing-complete, and expects that the correct glyphIDs are fed into the shaper.

We can't just arbitrarily swap out glyphIDs before shaping just because we feel like it.

Instead, the solution is to handle these invisible characters after font fallback, and after
shaping. This patch does it just like we handle adding letter-spacing, word-spacing, and
justification after shaping - by iterating over the glyphs output by the shaper and seeing if
any need to be adjusted.

This patch also includes a fix for the situation where the glyph buffer might be left in an
inconsistent state, where the array of glyphs is shorter than the array of characters -
this new codepath added in this patch revealed this existing problem, and fixes it here too.

Test: fast/text/zwj-ligature.html

  • platform/graphics/Font.cpp:

(WebCore::createAndFillGlyphPage):
(WebCore::overrideControlCharacters): Deleted.

  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::glyphAt const):
(WebCore::GlyphBuffer::deleteGlyphWithoutAffectingSize):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::applyCSSVisibilityRules):
(WebCore::WidthIterator::advance):

  • platform/graphics/WidthIterator.h:

Source/WTF:

  • wtf/unicode/CharacterNames.h:

LayoutTests:

  • fast/text/resources/Ahem-GSUB-ligatures.ttf: Added.
  • fast/text/zwj-ligature-expected.html: Added.
  • fast/text/zwj-ligature.html: Added.
  • platform/mac/fast/text/format-control-expected.txt: Progression! A new ligature is formed that wasn't formed before.

Also, this ligature is formed in both Chrome and Firefox, so we match them now.

  • platform/win/TestExpectations:
9:28 PM Changeset in webkit [281388] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][Integration] Do not create an InlineFormattingContext object for constructing display lines and runs
​https://bugs.webkit.org/show_bug.cgi?id=228061

Reviewed by Sam Weinig.

We've got all we need in the inlineFormattingState object.

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

  • layout/integration/LayoutIntegrationInlineContentBuilder.h:
  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

9:24 PM Changeset in webkit [281387] by Alan Bujtas
  • 12 edits in trunk

[LFC][IFC] Add support for -webkit-text-security: disc
​https://bugs.webkit.org/show_bug.cgi?id=229047

Reviewed by Antti Koivisto.
Source/WebCore:

The disc glyph affects layout, so let's replace the text before we start measuring the inline content.

  • layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForStyle):

  • layout/integration/LayoutIntegrationCoverage.h:

LayoutTests:

Let's dump the actual disc characters.

  • platform/ios-simulator/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt:
  • platform/ios/fast/css/text-overflow-input-expected.txt:
  • platform/ios/fast/forms/basic-inputs-expected.txt:
  • platform/ios/fast/forms/input-value-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
8:31 PM Changeset in webkit [281386] by Alan Bujtas
  • 5 edits in trunk

[IFC][Integration] Enable modern line layout for placeholder elements
​https://bugs.webkit.org/show_bug.cgi?id=228887

Reviewed by Antti Koivisto.

Source/WebCore:

Apparently placeholders don't do strange things anymore (this check is originated in SLL).

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

LayoutTests:

  • platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt:
8:26 PM Changeset in webkit [281385] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] The layout test fast/visual-viewport/resize-event-fired-window-resized.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=229379

Unreviewed test gardening.

  • platform/win/TestExpectations:
6:33 PM Changeset in webkit [281384] by sihui_liu@apple.com
  • 4 edits in trunk/Source

IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
​https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted<T>.

Reviewed by Brady Eidson.

  • wtf/CrossThreadTask.h:
5:26 PM Changeset in webkit [281383] by ysuzuki@apple.com
  • 10 edits in trunk

[JSC] Remove Intl runtime feature flags for already shipped ones
​https://bugs.webkit.org/show_bug.cgi?id=229371

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-datetimeformat-day-period.js:
  • test262/config.yaml:

Source/JavaScriptCore:

Since they are already shipped, we should remove these runtime flags.

  • builtins/DatePrototype.js:

(globalPrivate.toDateTimeOptionsAnyAll):
(globalPrivate.toDateTimeOptionsTimeTime):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions const):

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::finishCreation):

  • runtime/OptionsList.h:
4:01 PM Changeset in webkit [281382] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[IFC][Integration] Group non-standard CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=228855
<rdar://problem/81880442>

Reviewed by Antti Koivisto.

List of unsupported non-standard CSS properties (consider it a priority list).

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForStyle):

3:34 PM Changeset in webkit [281381] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] The layout test http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=229372

Unreviewed test gardening.

  • platform/win/TestExpectations:
3:04 PM Changeset in webkit [281380] by pvollan@apple.com
  • 6 edits in trunk/Source

[Win] Crash under FontCache::lastResortFallbackFont
​https://bugs.webkit.org/show_bug.cgi?id=228186

Reviewed by Myles C. Maxfield.

Source/WebCore:

Add null check to resolve crash in FontCache::lastResortFallbackFont. Additionally, return early in BitmapImage::getHBITMAPOfSize
when the bits per pixel in the bitmap is of unexpected size, since that will cause a crash under this function. This can happen
if an event is being handled while already in the Windows paint handler.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::lastResortFallbackFont):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::CGContextWithHDC):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):

Source/WebKitLegacy/win:

Add null check for bitmapDC. Proceeding without a valid bitmapDC will cause a crash. When painting is being done while already in the Windows paint handler,
we can end up with a bitmapDC which is null.

  • WebView.cpp:

(WebView::paintIntoBackingStore):

12:19 PM Changeset in webkit [281379] by Jonathan Bedard
  • 3 edits
    2 adds in trunk/Tools

[git-webkit] Add pull-request command (Part 3)
​https://bugs.webkit.org/show_bug.cgi?id=229089
<rdar://problem/81908751>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version, export pull-request.
  • Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:

(PullRequest.State):
(PullRequest.create_body): Create pull-request body from commits and comment.
(PullRequest.parse_body): Turn a body from a pull-request into a comment string and partial commits.
(PullRequest.init):
(PullRequest.repr):

  • Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

(TestPullRequest):
(TestPullRequest.test_representation):
(TestPullRequest.test_create_body_single):
(TestPullRequest.test_parse_body_single):
(TestPullRequest.test_create_body_multiple):
(TestPullRequest.test_parse_body_multiple):
(TestPullRequest.test_create_body_empty):
(TestPullRequest.test_parse_body_empty):
(TestPullRequest.test_create_body_comment):
(TestPullRequest.test_parse_body_single):

12:18 PM Changeset in webkit [281378] by mmaxfield@apple.com
  • 8 edits
    3 adds in trunk

[Cocoa] Single characters don't get shaped in the fast text codepath
​https://bugs.webkit.org/show_bug.cgi?id=186804

Reviewed by Alan Bujtas.

Source/WebCore:

Previously, single characters weren't shaped in the fast text codepath,
because shaping in the fast text codepath was just for kerning and
ligatures. Kerning didn't need to shape individual characters because
kerning only applies to pairs of characters, and ligatures didn't need
to shape individual characters because two characters are required to
form a ligature. However, now that we want to replace the complex text
codepath with a new-and-improved fast text codepath, we have to perform
all shaping in the fast text codepath, regardless of how many characters
are present.

Test: fast/text/single-character-shaping.html

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::commitCurrentFontRange):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::shouldApplyFontTransforms const): Deleted.

  • platform/graphics/WidthIterator.h:
  • platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::applyTransforms): Keep kerning disabled for single glyphs,
because of performance. This will be able to be removed when rdar://82195405
is fixed.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):

Tools:

Huge thanks to Laurence Penney to contributing this test font!!!

  • Scripts/webkitpy/common/config/contributors.json:

LayoutTests:

Huge thanks to Laurence Penney to contributing this test font!!!

  • fast/text/resources/UniversTofu-GSUB-rvrn.ttf: Added. The license is Apache 2.0.
  • fast/text/single-character-shaping-expected.html: Added.
  • fast/text/single-character-shaping.html: Added.
11:19 AM Changeset in webkit [281377] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[IFC][Integration] Add painting support for vertical text content
​https://bugs.webkit.org/show_bug.cgi?id=228940

Reviewed by Antti Koivisto.

Translate the logical layout coordinates to physical paint coordinates by taking the writing mode into account.
(e.g. writing-mode: vertical-rl;

run logical rect: [0, 0][20x18]
in a flipped block box: [10, 10][100x50]
with the paint offset: [8, 8]

translates to: [90, 8][20x18]

)

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::paintTextRunUsingPhysicalCoordinates):

  • layout/integration/LayoutIntegrationLineLayout.h:
11:15 AM Changeset in webkit [281376] by Simon Fraser
  • 17 edits
    1 add in trunk/Source

Use MediaKeySystemRequestIdentifier, rather than mysterious uint64_t values, in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=229310

Reviewed by Youenn Fablet.

WebCore already had an ObjectIdentifer<> type for media system key requests, MediaKeySystemRequestIdentifier.
Use it in the WebKit layer.

  • Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):
(headers_for_type):

  • UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp:

(WebKit::MediaKeySystemPermissionRequestManagerProxy::denyRequest):
(WebKit::MediaKeySystemPermissionRequestManagerProxy::grantRequest):
(WebKit::MediaKeySystemPermissionRequestManagerProxy::createRequestForFrame):

  • UIProcess/MediaKeySystemPermissionRequestManagerProxy.h:
  • UIProcess/MediaKeySystemPermissionRequestProxy.cpp:

(WebKit::MediaKeySystemPermissionRequestProxy::MediaKeySystemPermissionRequestProxy):

  • UIProcess/MediaKeySystemPermissionRequestProxy.h:

(WebKit::MediaKeySystemPermissionRequestProxy::create):
(WebKit::MediaKeySystemPermissionRequestProxy::mediaKeySystemID const):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestMediaKeySystemPermissionForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp:

(WebKit::MediaKeySystemPermissionRequestManager::sendMediaKeySystemRequest):
(WebKit::MediaKeySystemPermissionRequestManager::mediaKeySystemWasGranted):
(WebKit::MediaKeySystemPermissionRequestManager::mediaKeySystemWasDenied):

  • WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mediaKeySystemWasGranted):
(WebKit::WebPage::mediaKeySystemWasDenied):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
9:17 AM Changeset in webkit [281375] by ysuzuki@apple.com
  • 12 edits
    1 add in trunk

[JSC] Intl.DisplayNames v2
​https://bugs.webkit.org/show_bug.cgi?id=227832

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-displaynames-v2.js: Added.

(shouldBe):
(shouldThrow):
(vm.icuVersion):

  • stress/intl-displaynames.js:

(vm.icuVersion):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements Intl.DisplayNames v2[1].
Newly added names are calendar names and date time field names.
For the language name, language display option is added.

[1]: ​https://github.com/tc39/intl-displaynames-v2

  • runtime/CommonIdentifiers.h:
  • runtime/IntlCache.cpp:

(JSC::IntlCache::getFieldDisplayName):

  • runtime/IntlCache.h:
  • runtime/IntlDisplayNames.cpp:

(JSC::IntlDisplayNames::initializeDisplayNames):
(JSC::IntlDisplayNames::of const):
(JSC::IntlDisplayNames::resolvedOptions const):
(JSC::IntlDisplayNames::typeString):
(JSC::IntlDisplayNames::languageDisplayString):

  • runtime/IntlDisplayNames.h:
  • runtime/IntlObject.cpp:

(JSC::isUnicodeLocaleIdentifierType):
(JSC::canonicalizeUnicodeLocaleID):
(JSC::canonicalizeLocaleList):
(JSC::defaultLocale):
(JSC::mapBCP47ToICUCalendarKeyword):
(JSC::mapICUCollationKeywordToBCP47):
(JSC::canonicalizeLanguageTag): Deleted.

  • runtime/IntlObject.h:
7:33 AM Changeset in webkit [281374] by ysuzuki@apple.com
  • 10 edits
    1 add in trunk

[JSC] Intl Locale Info
​https://bugs.webkit.org/show_bug.cgi?id=227830

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-locale-info.js: Added.

(shouldBe):
(throw.new.Error):
(let.enGB.new.Intl.Locale.shouldBe):
(let.l.new.Intl.Locale.shouldBe):

  • test262/config.yaml:

Source/JavaScriptCore:

This patch implements Intl.Locale's extension (Intl Locale Info proposal)[1], which is already stage 3.
Intl.Locale#{calendars,collations,hourCycles,numberingSystems,timeZones} can return array of preferred
configuration for the given locale. And Intl.Locale#textInfo can return text layout direction and Intl.Locale#weekInfo
can return weekday information (e.g. when weekend starts).

[1]: ​https://github.com/tc39/proposal-intl-locale-info

  • runtime/IntlLocale.cpp:

(JSC::createArrayFromStringVector):
(JSC::IntlLocale::calendars):
(JSC::IntlLocale::collations):
(JSC::IntlLocale::hourCycles):
(JSC::IntlLocale::numberingSystems):
(JSC::IntlLocale::timeZones):
(JSC::IntlLocale::textInfo):
(JSC::IntlLocale::weekInfo):

  • runtime/IntlLocale.h:
  • runtime/IntlLocalePrototype.cpp:

(JSC::JSC_DEFINE_CUSTOM_GETTER):

6:49 AM Changeset in webkit [281373] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[IFC][Integration] Do not scan the content for overflowing glyph when line-box-contain is set to glyph
​https://bugs.webkit.org/show_bug.cgi?id=228895
<rdar://problem/81651487>

Reviewed by Antti Koivisto.

This is in preparation for removing content scanning completely.

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForText):
(WebCore::LayoutIntegration::canUseForFontAndText):

  • layout/integration/LayoutIntegrationCoverage.h:
6:42 AM Changeset in webkit [281372] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

Fix spelling: MidWorkdBreak -> MidWordBreak

Unreviewed.

  • layout/formattingContexts/inline/InlineContentBreaker.cpp:

(WebCore::Layout::InlineContentBreaker::tryBreakingTextRun const):

  • layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::midWordBreak):
(WebCore::Layout::TextUtil::midWorkdBreak): Deleted.

  • layout/formattingContexts/inline/text/TextUtil.h:
6:02 AM Changeset in webkit [281371] by ysuzuki@apple.com
  • 5 edits
    1 add in trunk

[JSC] Extend Intl TimeZoneName Option
​https://bugs.webkit.org/show_bug.cgi?id=227831

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-extended-timezone-names.js: Added.

(shouldBe):
(timeZoneTest):

  • test262/config.yaml:

Source/JavaScriptCore:

​https://github.com/tc39/proposal-intl-extend-timezonename

This patch implements Extend Intl TimeZoneName proposal, which adds "shortOffset", "longOffset", "shortGeneric", "longGeneric"
timeZoneName variants.

  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::timeZoneNameString):

  • runtime/IntlDateTimeFormat.h:
5:28 AM Changeset in webkit [281370] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Enable String,TypedArray#at
​https://bugs.webkit.org/show_bug.cgi?id=229354

Reviewed by Saam Barati.

Enable String and TypedArray's at method.

  • runtime/OptionsList.h:
5:10 AM Changeset in webkit [281369] by ysuzuki@apple.com
  • 11 edits in trunk

[JSC] Enable Array#findLast method
​https://bugs.webkit.org/show_bug.cgi?id=229355

Reviewed by Saam Barati.

JSTests:

  • stress/unscopables.js:

Source/JavaScriptCore:

This patch enables Array#findLast and Array#findLastIndex methods.

(JSC::ArrayPrototype::finishCreation):

  • runtime/OptionsList.h:

LayoutTests:

  • inspector/model/remote-object-get-properties-expected.txt:
  • js/Object-getOwnPropertyNames-expected.txt:
  • js/array-unscopables-properties-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/array-unscopables-properties.js:
12:56 AM Changeset in webkit [281368] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GLIB] Do not assume log success in apply-build-revision-to-files
​https://bugs.webkit.org/show_bug.cgi?id=229335

Patch by Daniel Kolesa <Daniel Kolesa> on 2021-08-21
Reviewed by Philippe Normand.

If the origin reference does not exist for any reason, this will
fail the build. Since we have no reference point, just assume
unknown like if it wasn't a git repo.

  • glib/apply-build-revision-to-files.py:

(get_build_revision):

12:01 AM Changeset in webkit [281367] by youenn@apple.com
  • 8 edits
    2 adds in trunk

Prevent AudioSession category from moving out of PlayAndRecord too quickly
​https://bugs.webkit.org/show_bug.cgi?id=229327
<rdar://81997024>

Reviewed by Eric Carlson.

Source/WebCore:

If category is PlayAndRecord, we stick to PlayAndRecord until audio is no longer playing at which point we
transition to whatever category is most appropriate.
Introduce PlatformMediaSession::isPlaying in addition to canProduceAudio to compute whether audio is being played.

Test: http/tests/media/media-stream/audio-capture-and-category.https.html

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::isPlaying const):

  • Modules/webaudio/AudioContext.h:
  • html/HTMLMediaElement.h:
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::isPlaying const):

  • platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSessionClient::isPlaying const):

  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::updateSessionState):

LayoutTests:

  • http/tests/media/media-stream/audio-capture-and-category.https-expected.txt: Added.
  • http/tests/media/media-stream/audio-capture-and-category.https.html: Added.
Note: See TracTimeline for information about the timeline view.