⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 26, 2021:

11:18 PM Changeset in webkit [281687] by mmaxfield@apple.com
  • 15 edits
    6 adds in trunk

Synthetic bold additional advances need to be applied after shaping
​https://bugs.webkit.org/show_bug.cgi?id=189448
<rdar://problem/40994395>

Reviewed by Alan Bujtas.

Source/WebCore:

We implement synthetic bold by drawing every glyph twice, the second time 1px to the right of the
first time. This effectively means that the advance of such glyphs needs to be increased by 1px.
Previously, we were doing this before shaping, which is a problem for some fonts which clobber the
input advances during shaping, and emit totally new advances. Osaka is one such font. In order to
make sure that these fonts have their synthetic bold advances correctly increased, we need to do
the increasing after text shaping, rather than before it.

This patch temporarily disables LFC when synthetic bold is in effect. I will teach LFC how to handle
synthetic bold in a follow-up patch.

Test: fast/text/osaka-synthetic-bold.html

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForText):

  • platform/graphics/Font.h:

(WebCore::Font::syntheticBoldOffset const):
(WebCore::Font::widthForGlyph const):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::adjustForSyntheticBold):
(WebCore::WidthIterator::applyCSSVisibilityRules):

  • platform/graphics/WidthIterator.h:
  • platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::platformWidthForGlyph const):
(WebCore::Font::platformBoundsForGlyph const):

LayoutTests:

These tests are progressions.

  • fast/text/osaka-synthetic-bold-expected.txt: Added.
  • fast/text/osaka-synthetic-bold.html: Added.
  • platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
  • platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
  • platform/mac-mojave/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fonts/cursive-expected.png: Added.
  • platform/mac/fonts/cursive-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
  • platform/mac/TestExpectations:
  • platform/win/fast/text-indicator/text-indicator-estimated-color-with-implicit-newline-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
10:42 PM Changeset in webkit [281686] by ysuzuki@apple.com
  • 3 edits
    1 add in trunk

Float32Arrays.sort() return undefined when length < 2
​https://bugs.webkit.org/show_bug.cgi?id=229575

Reviewed by Saam Barati.

JSTests:

  • stress/typed-array-sort-small.js: Added.

(shouldBe):
(throw.new.Error):

Source/JavaScriptCore:

TypedArray#sort should return |this| even when we don't perform sorting.

  • builtins/TypedArrayPrototype.js:

(sort):

9:58 PM Changeset in webkit [281685] by commit-queue@webkit.org
  • 12 edits in trunk

Caret should respect text background color
​https://bugs.webkit.org/show_bug.cgi?id=117493

Patch by Joone Hur <Joone Hur> on 2021-08-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

An earlier fix for caret color, which we are now improving, was this commit:
​https://trac.webkit.org/changeset/152612/webkit

This patch allows the caret to become visible in the black background
by getting the caret color from the element containing
the text, not the root editable element that has the contentEditable attribute.

  • editing/FrameSelection.cpp:

(WebCore::CaretBase::computeCaretColor):

LayoutTests:

Rebaselined caret rendering tests.

  • editing/caret/caret-color.html:
  • editing/caret/color-span-inside-editable-background-expected.html:
  • editing/caret/color-span-inside-editable-expected.html:
  • fast/css/caret-color-auto-expected.html:
  • platform/ios-wk2/editing/caret/caret-color-expected.png:
  • platform/ios/editing/caret/caret-color-expected.txt:
  • platform/mac/editing/caret/caret-color-expected.png:
  • platform/mac/editing/caret/caret-color-expected.txt:
  • platform/win/editing/caret/caret-color-expected.txt:
9:26 PM Changeset in webkit [281684] by ysuzuki@apple.com
  • 24 edits
    5 copies
    5 adds
    3 deletes in trunk

[JSC] op_put_private_name should use modern IC and remove ByValInfo
​https://bugs.webkit.org/show_bug.cgi?id=229544

Reviewed by Saam Barati.

JSTests:

Move class-fields-private benchmarks into microbenchmarks.
Added several microbenchmarks and stress tests.

  • microbenchmarks/class-private-field-polymorphic.js: Added.

(shouldBe):
(test.A.prototype.put):

  • microbenchmarks/get-private-name.js: Renamed from JSTests/microbenchmarks/class-fields-private/get-private-name.js.
  • microbenchmarks/monomorphic-get-private-field.js: Renamed from JSTests/microbenchmarks/class-fields-private/monomorphic-get-private-field.js.
  • microbenchmarks/polymorphic-get-private-field.js: Renamed from JSTests/microbenchmarks/class-fields-private/polymorphic-get-private-field.js.
  • microbenchmarks/polymorphic-put-private-field.js: Renamed from JSTests/microbenchmarks/class-fields-private/polymorphic-put-private-field.js.
  • microbenchmarks/put-by-val-polymorphic-properties.js: Added.

(shouldBe):
(test):

  • microbenchmarks/put-private-field.js: Renamed from JSTests/microbenchmarks/class-fields-private/put-private-field.js.
  • stress/class-private-field-megamorphic.js: Added.

(shouldBe):

  • stress/class-private-field-polymorphic.js: Added.

(shouldBe):
(test.A.prototype.put):

  • stress/put-by-val-polymorphic-properties.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

This patch makes op_put_private_name use new PutByVal IC. This allows op_put_private_name to support
polymorphic properties, and we can finally remove Baseline's adhoc IC and ByValInfo completely.

Added microbenchmark showed 3x improvement due to polymorphic PutPrivateName IC.

ToT Patched

class-private-field-polymorphic 9.3666+-0.0332 3.1199+-0.0182 definitely 3.0022x faster

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • bytecode/ByValInfo.cpp: Removed.
  • bytecode/ByValInfo.h: Removed.
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::getICStatusMap):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::findByValInfo): Deleted.
(JSC::CodeBlock::addByValInfo): Deleted.

  • bytecode/CodeBlock.h:
  • bytecode/ICStatusMap.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetPrivateName):
(JSC::DFG::SpeculativeJIT::compilePutPrivateName):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStoreBarrierInsertionPhase.cpp:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutPrivateName):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::link):
(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JIT.h:

(JSC::ByValCompilationInfo::ByValCompilationInfo): Deleted.

  • jit/JITInlines.h:

(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase): Deleted.
(JSC::JIT::emitArrayProfileOutOfBoundsSpecialCase): Deleted.

  • jit/JITOperations.cpp:

(JSC::putPrivateNameOptimize):
(JSC::putPrivateName):
(JSC::JSC_DEFINE_JIT_OPERATION):

  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::slow_op_put_private_name_prepareCallGenerator):
(JSC::JIT::emitPutByValWithCachedId): Deleted.
(JSC::JIT::emitPutPrivateNameWithCachedId): Deleted.
(JSC::JIT::emitByValIdentifierCheck): Deleted.
(JSC::JIT::privateCompilePutPrivateNameWithCachedId): Deleted.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emitSlow_op_put_private_name):

  • jit/Repatch.cpp:

(JSC::appropriateGenericPutByFunction):
(JSC::appropriateOptimizingPutByFunction):
(JSC::resetPutBy):

Tools:

  • Scripts/run-jsc-benchmarks:
8:52 PM Changeset in webkit [281683] by Simon Fraser
  • 3 edits
    2 adds in trunk

CSS keyframed animations don't respect edges in 4 value background-position
​https://bugs.webkit.org/show_bug.cgi?id=228995

Reviewed by Darin Adler.

For some background-position animations we'd fail to set backgroundOriginX/Y in the
destination style's FillLayer, because this is not set in the destination style initially.

So have FillLayerPositionPropertyWrapper::blend() always set it.

Source/WebCore:

Test: animations/background-position.html

  • animation/CSSPropertyAnimation.cpp:

LayoutTests:

  • animations/background-position-expected.html: Added.
  • animations/background-position.html: Added.
8:48 PM Changeset in webkit [281682] by Simon Fraser
  • 7 edits in trunk

Remove some historical iOS CGContext flipping
​https://bugs.webkit.org/show_bug.cgi?id=229589

Reviewed by Tim Horton.

Source/WebCore:

Remove some iOS-only code that flipped the CGContext CTM for pattern drawing. Back
in the mists of time there were some iOS-only differences in image flipping, but those
have long since disappeared.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::drawPatternCallback):
(WebCore::GraphicsContextCG::drawPattern):

LayoutTests:

Mark some iOS tests as passing now. A couple of tests that were skipped everywhere now
only fail on macOS.

  • TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
8:37 PM Changeset in webkit [281681] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

[Cocoa] Enforce the policy against WebKit causing Core Text font download prompts in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=229391

Reviewed by Alan Bujtas.

Source/WebCore:

For most apps, if you ask Core Text to create a font which is a mobileasset font, it will
show a synchronous blocking prompt asking the user if they want to download the font.
However, this policy isn't a great one for web content, because webpages will request tons
of fonts all the time, and it's totally likely that many of them will be mobileasset fonts.
Because of this, WebKit has a policy where we will opt out of showing these prompts, by
specifying kCTFontEnabledAttribute:kCFBooleanTrue in the attributes dictionary.

We do this in some places, but we forgot one additional place. This patch adds it to this
place, and adds a test which intentionally requests a MobileAsset font and makes sure the
test doesn't timeout (by showing a blocking prompt forever).

Test: fast/text/mobileasset-font.html

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::autoActivateFont):

LayoutTests:

Make sure content which uses these fonts doesn't cause a blocking prompt.

  • fast/text/mobileasset-font-expected-mismatch.html: Added.
  • fast/text/mobileasset-font.html: Added.
  • platform/mac/TestExpectations: Skip the test on Catalina, because apparently the prompts can't be skipped?
8:08 PM Changeset in webkit [281680] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][Integration] Use the line runs to check for legacy integral positioning
​https://bugs.webkit.org/show_bug.cgi?id=228069
<rdar://problem/81087857>

Reviewed by Antti Koivisto.

Now that the line runs list has all the inline boxes (including spanning inline boxes), we
can use this list to check for legacy integral positioning and not directly iterating the LineBox's non-rootinlinebox list.
While this may be a bit more expensive, the legacy positioning is temporary and will be removed shortly.

This is in preparation for keeping the inline box structure private to the layout code.

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns const):

  • layout/integration/LayoutIntegrationInlineContentBuilder.h:
7:06 PM Changeset in webkit [281679] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

Fix a typo in ArgumentCoder<Ref<Font>>::decode()
​https://bugs.webkit.org/show_bug.cgi?id=229596

Reviewed by Tim Horton.

Change renderingRersouceIdentifier to renderingResourceIdentifier.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Ref<Font>>::decode):

6:53 PM Changeset in webkit [281678] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GLIB] Skip the webgl/pending/conformance2 tests, as WebGL2 is not yet supported
​https://bugs.webkit.org/show_bug.cgi?id=229598

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-26

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
6:13 PM Changeset in webkit [281677] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ Catalina+ Debug wk2 ] fast/speechrecognition/start-recognition-after-gum.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=228209

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:53 PM Changeset in webkit [281676] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2 Debug] imported/w3c/web-platform-tests/fetch/http-cache/invalidate.any.worker.html is a flaky failure.

​https://bugs.webkit.org/show_bug.cgi?id=229595.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:32 PM Changeset in webkit [281675] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ Win EWS] js/dfg-int16array.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=229594

Unreviewed test gardening.

  • platform/win/TestExpectations:
5:29 PM Changeset in webkit [281674] by Eric Hutchison
  • 3 edits in trunk/LayoutTests

[Mac] media/modern-media-controls/seek-backward-support/seek-backward-support.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229473.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
4:24 PM Changeset in webkit [281673] by Jonathan Bedard
  • 6 edits in trunk/Tools

[kill-old-processes] Invoke with Python 3
​https://bugs.webkit.org/show_bug.cgi?id=229576
<rdar://problem/82397885>

Rubber-stamped by Darin Adler.

  • CISupport/build-webkit-org/steps.py:

(KillOldProcesses): Invoke with Python 3.

  • CISupport/build-webkit-org/steps_unittest.py:

(TestKillOldProcesses.test_success):
(TestKillOldProcesses.test_failure):

  • CISupport/ews-build/steps.py:

(KillOldProcesses): Invoke with Python 3.

  • CISupport/ews-build/steps_unittest.py:
  • CISupport/kill-old-processes: Change shebang to Python 3.
4:09 PM Changeset in webkit [281672] by Russell Epstein
  • 1 copy in tags/Safari-612.1.29.14.3

Tag Safari-612.1.29.14.3.

4:08 PM Changeset in webkit [281671] by Russell Epstein
  • 8 edits
    4 moves
    1 add in branches/safari-612.1.29.14-branch/Source/WebInspectorUI

Cherry-pick r281663. rdar://problem/82411437

Web Inspector: Rename ContextualDocumentation* to CSSDocumentation to reduce path length and improve code readability
​https://bugs.webkit.org/show_bug.cgi?id=229525

Reviewed by Devin Rousso.

Reduce the length and complexity of naming around the documentation that was added for CSS properties by
using CSSDocumentation to refer to the feature instead of ContextualDocumentation.

  • Localizations/en.lproj/localizedStrings.js:
  • Scripts/copy-user-interface-resources.pl:
  • UserInterface/External/CSSDocumentation/CSSDocumentation.js: Renamed from Source/WebInspectorUI/UserInterface/External/ContextualDocumentationDatabase/ContextualDocumentationDatabase.js.
  • UserInterface/External/CSSDocumentation/LICENSE: Renamed from Source/WebInspectorUI/UserInterface/External/ContextualDocumentationDatabase/LICENSE.
  • UserInterface/Main.html:
  • UserInterface/Views/CSSDocumentationPopover.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ContextualDocumentationPopover.css.
  • UserInterface/Views/CSSDocumentationPopover.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ContextualDocumentationPopover.js. (WI.CSSDocumentationPopover.prototype._getDocumentationDetails):
  • UserInterface/Views/ComputedStyleSection.css: (.computed-style-section .property-trace-item .property :is(.name, .colon, .semicolon, .css-documentation-button)): (.sidebar > .panel.details.css-style > .content > .computed .computed-property-item > .property > .content > .css-documentation-button): (.sidebar > .panel.details.css-style > .content > .computed .computed-property-item:not(:hover) > .property > .content > .css-documentation-button): (.computed-style-section .property-trace-item .property :is(.name, .colon, .semicolon, .contextual-documentation-button)): Deleted. (.sidebar > .panel.details.css-style > .content > .computed .computed-property-item > .property > .content > .contextual-documentation-button): Deleted. (.sidebar > .panel.details.css-style > .content > .computed .computed-property-item:not(:hover) > .property > .content > .contextual-documentation-button): Deleted.
  • UserInterface/Views/Main.css: (.css-documentation-button): (.css-documentation-button:active): (@media (prefers-color-scheme: dark) .css-documentation-button): (.contextual-documentation-button): Deleted. (.contextual-documentation-button:active): Deleted. (@media (prefers-color-scheme: dark) .contextual-documentation-button): Deleted.
  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css: (.spreadsheet-style-declaration-editor > .property:not(:hover) > .content > .css-documentation-button,): (.spreadsheet-style-declaration-editor > .property:not(:hover) > .content > .contextual-documentation-button,): Deleted.
  • UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype.update): (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit): (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur): (WI.SpreadsheetStyleProperty.prototype.willDismissPopover): (WI.SpreadsheetStyleProperty.prototype._addCSSDocumentationButton): (WI.SpreadsheetStyleProperty.prototype._handleCSSDocumentationButtonClicked): (WI.SpreadsheetStyleProperty.prototype._presentCSSDocumentation): (WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton): Deleted. (WI.SpreadsheetStyleProperty.prototype._handleContextualDocumentationButtonClicked): Deleted. (WI.SpreadsheetStyleProperty.prototype._presentContextualDocumentation): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:08 PM Changeset in webkit [281670] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Rebase fast/text/capitalize-boundaries.html after changes in r281422
​https://bugs.webkit.org/show_bug.cgi?id=228217

Unreviewed test gardening.

  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
4:07 PM Changeset in webkit [281669] by Russell Epstein
  • 8 edits in branches/safari-612.1.29.14-branch/Source

Versioning.

WebKit-7612.1.29.14.3

4:02 PM Changeset in webkit [281668] by Wenson Hsieh
  • 11 edits in trunk/Source/WebKit

Add type-safe transaction identifiers for EditorState and FocusedElementInformation
​https://bugs.webkit.org/show_bug.cgi?id=229571

Reviewed by Tim Horton.

Make transactionID a monotonic object identifier instead of a generic TransactionID, and replace
FocusedElementIdentifier (which is currently type-defined to uint64_t) with its own monotonic object
identifier type.

In a future patch, I plan to implement a mechanism to synchronize EditorState and FocusedElementInformation
updates, which would require one or both of these objects to hold both types of transactional identifiers; in
order to do this, we need to ensure that these two identifiers are distinct types, so that they can't be easily
mixed up.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode const):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:
  • Shared/FocusedElementInformation.cpp:

(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

  • Shared/FocusedElementInformation.h:
  • Shared/IdentifierTypes.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateEditorState):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView updateCurrentFocusedElementInformation:]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):
(WebKit::WebPage::elementDidFocus):

  • WebProcess/WebPage/WebPage.h:

Additionally rename m_currentFocusedElementIdentifier to m_lastFocusedElementInformationIdentifier, for
consistency with m_lastEditorStateIdentifier.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::focusedElementInformation):

3:50 PM Changeset in webkit [281667] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations: Remove an expectation that was added to the wrong file.
3:46 PM Changeset in webkit [281666] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk2 Debug] http/tests/misc/acid3.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229592.

Unreviewed test gardening .

  • platform/mac-wk2/TestExpectations:
3:43 PM Changeset in webkit [281665] by sbarati@apple.com
  • 3 edits
    1 add in trunk

r281485 was not sufficient in where it called disablePeepholeOptimization
​https://bugs.webkit.org/show_bug.cgi?id=229582
<rdar://82346980>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite-2.js: Added.

(foo):

Source/JavaScriptCore:

r281485 accidentally deleted a place where we called disablePeepholeOptimization
that was necessary. Basically, after we seek where the current instruction
in BytecodeGenerator is, we need to disablePeepholeOptimization.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ForInContext::finalize):

3:43 PM Changeset in webkit [281664] by Ryan Haddad
  • 2 edits in trunk/Tools

watchOS simulator image missing on bot watchers dashboard
​https://bugs.webkit.org/show_bug.cgi?id=229587

Reviewed by Jonathan Bedard.

  • CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.watchos-simulator-7 img.logo):

3:32 PM Changeset in webkit [281663] by Patrick Angle
  • 8 edits
    2 copies
    2 moves
    1 add
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: Rename ContextualDocumentation* to CSSDocumentation to reduce path length and improve code readability
​https://bugs.webkit.org/show_bug.cgi?id=229525

Reviewed by Devin Rousso.

Reduce the length and complexity of naming around the documentation that was added for CSS properties by
using CSSDocumentation to refer to the feature instead of ContextualDocumentation.

  • Localizations/en.lproj/localizedStrings.js:
  • Scripts/copy-user-interface-resources.pl:
  • UserInterface/External/CSSDocumentation/CSSDocumentation.js: Renamed from Source/WebInspectorUI/UserInterface/External/ContextualDocumentationDatabase/ContextualDocumentationDatabase.js.
  • UserInterface/External/CSSDocumentation/LICENSE: Renamed from Source/WebInspectorUI/UserInterface/External/ContextualDocumentationDatabase/LICENSE.
  • UserInterface/Main.html:
  • UserInterface/Views/CSSDocumentationPopover.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ContextualDocumentationPopover.css.
  • UserInterface/Views/CSSDocumentationPopover.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ContextualDocumentationPopover.js.

(WI.CSSDocumentationPopover.prototype._getDocumentationDetails):

  • UserInterface/Views/ComputedStyleSection.css:

(.computed-style-section .property-trace-item .property :is(.name, .colon, .semicolon, .css-documentation-button)):
(.sidebar > .panel.details.css-style > .content > .computed .computed-property-item > .property > .content > .css-documentation-button):
(.sidebar > .panel.details.css-style > .content > .computed .computed-property-item:not(:hover) > .property > .content > .css-documentation-button):
(.computed-style-section .property-trace-item .property :is(.name, .colon, .semicolon, .contextual-documentation-button)): Deleted.
(.sidebar > .panel.details.css-style > .content > .computed .computed-property-item > .property > .content > .contextual-documentation-button): Deleted.
(.sidebar > .panel.details.css-style > .content > .computed .computed-property-item:not(:hover) > .property > .content > .contextual-documentation-button): Deleted.

  • UserInterface/Views/Main.css:

(.css-documentation-button):
(.css-documentation-button:active):
(@media (prefers-color-scheme: dark) .css-documentation-button):
(.contextual-documentation-button): Deleted.
(.contextual-documentation-button:active): Deleted.
(@media (prefers-color-scheme: dark) .contextual-documentation-button): Deleted.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor > .property:not(:hover) > .content > .css-documentation-button,):
(.spreadsheet-style-declaration-editor > .property:not(:hover) > .content > .contextual-documentation-button,): Deleted.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.update):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
(WI.SpreadsheetStyleProperty.prototype.willDismissPopover):
(WI.SpreadsheetStyleProperty.prototype._addCSSDocumentationButton):
(WI.SpreadsheetStyleProperty.prototype._handleCSSDocumentationButtonClicked):
(WI.SpreadsheetStyleProperty.prototype._presentCSSDocumentation):
(WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton): Deleted.
(WI.SpreadsheetStyleProperty.prototype._handleContextualDocumentationButtonClicked): Deleted.
(WI.SpreadsheetStyleProperty.prototype._presentContextualDocumentation): Deleted.

3:29 PM Changeset in webkit [281662] by Alan Bujtas
  • 6 edits in trunk

REGRESSION(r275754): Using MarkOnlyThis to make the preferred width dirty introduces unexpected state
​https://bugs.webkit.org/show_bug.cgi?id=229586
<rdar://82141454>

LayoutTests/imported/w3c:

Unreviewed revert of r275754.

  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-002-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002-expected.txt:

Source/WebCore:

Unreviewed revert.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::shouldRecalculateMinMaxWidthsAffectedByAncestor): Deleted.

3:07 PM Changeset in webkit [281661] by Cameron McCormack
  • 3 edits in trunk/Source/WebKit

Manually release SharedBitmap if CGBitmapContextCreateWithData fails and doesn't do it
​https://bugs.webkit.org/show_bug.cgi?id=229428
<rdar://problem/82264138>

Reviewed by Darin Adler.

  • Shared/ShareableBitmap.h:
  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::releaseBitmapContextData):

3:07 PM Changeset in webkit [281660] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[EWS] compile-webkit-without-patch failed, but bot ran layout tests anyway and blamed the patch for a pre-existing failure
​https://bugs.webkit.org/show_bug.cgi?id=229533

Reviewed by Jonathan Bedard.

When the compile-webkit-without-patch step fails, instead of running further layout-tests, retry the build and email
bot watcher's. The retried build will hopefully be picked up by other bot eventually. This is similar to what we do
in case of other infrastructure issues like kill-old-processes step failure.

  • CISupport/ews-build/steps.py:

(CompileWebKitWithoutPatch.init): Added retry_build_on_failure parameter.
(CompileWebKitWithoutPatch.evaluateCommand): If build failed unexpectedly, retry it and email bot watchers.
(CompileWebKitWithoutPatch.send_email_for_unexpected_build_failure):
(ReRunWebKitTests.evaluateCommand):
(ReRunAPITests.evaluateCommand):

3:05 PM Changeset in webkit [281659] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html is a flaky fail/crash/timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229588.

Unreviewed test gardening .

  • platform/mac/TestExpectations:
2:59 PM Changeset in webkit [281658] by Patrick Angle
  • 4 edits in trunk/LayoutTests

[ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing
​https://bugs.webkit.org/show_bug.cgi?id=229459

Reviewed by Devin Rousso.

Increase timings slightly to widen the window during which we receive messages while paused in the debugger and
also delay the echo server's response further.

  • http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py:

(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html:
  • platform/mac/TestExpectations:
2:38 PM Changeset in webkit [281657] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ Catalina+ wk1 ] css2.1/20110323/replaced-intrinsic-003.htm is a flaky text failure
​https://bugs.webkit.org/show_bug.cgi?id=228211

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:26 PM Changeset in webkit [281656] by Eric Hutchison
  • 3 edits in trunk/LayoutTests

[Mac,iOS wk2] imported/w3c/web-platform-tests/navigation-timing/test_performance_attributes.sub.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229585.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
2:18 PM Changeset in webkit [281655] by Russell Epstein
  • 1 copy in tags/Safari-612.1.29.14.2

Tag Safari-612.1.29.14.2.

2:17 PM Changeset in webkit [281654] by Russell Epstein
  • 2 edits in branches/safari-612.1.29.14-branch/Source/JavaScriptCore

Cherry-pick r281647. rdar://problem/82406933

[AppleWin] JSC build failure
​https://bugs.webkit.org/show_bug.cgi?id=229578

Reviewed by Don Olmstead.

Add new build dependency between LLIntOffsetsExtractor and JSCBuiltins targets.

  • CMakeLists.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:16 PM Changeset in webkit [281653] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[GLIB] mark fast/text/trak-optimizeLegibility.html as a skip
​https://bugs.webkit.org/show_bug.cgi?id=229572

optimizeLegibility doesn't affect text rendering on GLIB platforms,
effectively being always enabled.

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-26

  • platform/glib/TestExpectations:
  • platform/gtk/fast/text/trak-optimizeLegibility-expected.txt: Removed.
  • platform/wpe/fast/text/trak-optimizeLegibility-expected.txt: Removed.
2:14 PM Changeset in webkit [281652] by Russell Epstein
  • 8 edits in branches/safari-612.1.29.14-branch/Source

Versioning.

WebKit-7612.1.29.14.2

1:51 PM Changeset in webkit [281651] by Eric Hutchison
  • 3 edits in trunk/LayoutTests

REGRESSION: [BigSur wk2 Release, iOS15] animations/fill-mode-forwards.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229584.

Unreviewed test gardening.

  • platform/ios-15/TestExpectations:
  • platform/mac-wk2/TestExpectations:
1:44 PM Changeset in webkit [281650] by mmaxfield@apple.com
  • 9 edits
    2 adds in trunk

Drawing small caps web fonts into canvas causes the GPU process to hang
​https://bugs.webkit.org/show_bug.cgi?id=229401
<rdar://problem/82282054>

Reviewed by Wenson Hsieh.

Source/WebCore:

Web fonts retain their downloaded data in case they need to send that data to the GPU process
to render into canvas. Small caps fonts are implemented by creating a "derivative" variant font.
When we were creating these derivative fonts, we weren't forwarding this downloaded data to
those new fonts. Without it, the font fails to transfer across IPC.

Test: fast/text/small-caps-canvas.html

  • platform/graphics/FontPlatformData.cpp:

(WebCore::makeOptionalFromPointer):
(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/HEVCUtilities.cpp:

(WebCore::makeOptionalFromPointer):

  • platform/graphics/coretext/FontCoreText.cpp:

(WebCore::createDerivativeFont):
(WebCore::Font::createFontWithoutSynthesizableFeatures const):
(WebCore::Font::platformCreateScaledFont const):

  • platform/graphics/coretext/FontPlatformDataCoreText.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

  • fast/text/small-caps-canvas-expected.txt: Added.
  • fast/text/small-caps-canvas.html: Added.
1:39 PM Changeset in webkit [281649] by Simon Fraser
  • 2 edits in trunk/Tools

Add to run-webkit-tests a --expect-pass argument as a synonym for --force
​https://bugs.webkit.org/show_bug.cgi?id=229581

Reviewed by Wenson Hsieh.

I am eternally confused that -f and --force are different things. Add --expect-pass
as a synonym for --force to reduce my confusion.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

1:21 PM Changeset in webkit [281648] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r256659): We try to remove fonts from the CSSFontFace which were never added
​https://bugs.webkit.org/show_bug.cgi?id=229535
<rdar://problem/78857440>

Reviewed by Darin Adler.

After r256659, asking for a failed CSSFontFace's families() returns nullopt. It's possible to add
a failed font to a CSSFontFaceSet (of course). When we do that, we recognize the font is failed
and don't update our internal data structures, because there's no need to - we can't do anything
useful with a failed font.

If you _then_ try to remove the font from the CSSFontFace, we don't call families(), but instead
just pull out the raw m_families member, and look in our internal data structures for it, but we
don't find it, because it was never added.

  • css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::addToFacesLookupTable):
(WebCore::CSSFontFaceSet::removeFromFacesLookupTable):

12:37 PM Changeset in webkit [281647] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[AppleWin] JSC build failure
​https://bugs.webkit.org/show_bug.cgi?id=229578

Reviewed by Don Olmstead.

Add new build dependency between LLIntOffsetsExtractor and JSCBuiltins targets.

  • CMakeLists.txt:
12:33 PM Changeset in webkit [281646] by Aditya Keerthi
  • 2 edits in trunk/Source/WebKit

[iOS] Photo picker appears at incorrect locations when opened using a trackpad
​https://bugs.webkit.org/show_bug.cgi?id=229568
rdar://80268735

Reviewed by Wenson Hsieh.

On iOS, file inputs that accept photos give the user the option to
select from a photo picker rather than a standard document picker.
The photo picker is presented as a popover, and uses the content
view's lastInteractionLocation to determine the source rect.
However, lastInteractionLocation is not updated when mouse events
are recognized, leading to the popover being presented at the location
of the most recent tap / long press / touch event.

To fix, ensure lastInteractionLocation is updated when a mouse down
event is recognized.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView mouseGestureRecognizerChanged:]):

12:31 PM Changeset in webkit [281645] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[IFC] Use the inline run list in showRenderTree to print inline level box information
​https://bugs.webkit.org/show_bug.cgi?id=228070

Reviewed by Antti Koivisto.

showInlineTreeAndRuns is the last client of the InlineFormattingState::lineBoxes.
Let's use the inline run list instead to print the inline level box geometry information. It provides slightly less
information than before but it is sufficient for now.

This is in preparation for keeping the inline box structure private to the layout code.

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::showInlineTreeAndRuns):

12:30 PM Changeset in webkit [281644] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[FreeType] Avoid yucky strong alias computations in font fallback code
​https://bugs.webkit.org/show_bug.cgi?id=228927

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-08-26
Reviewed by Myles C. Maxfield.

If built against the upcoming Fontconfig 2.13.95, we can avoid compiling a bunch of arcane
font matching code. It will be a while before we can require Fontconfig 2.13.95, so use
preprocessor guards for now.

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::areStronglyAliased):
(WebCore::FontCache::createFontPlatformData):

12:22 PM Changeset in webkit [281643] by Eric Hutchison
  • 3 edits in trunk/LayoutTests

Update test expectations for webgl tests.
​https://bugs.webkit.org/show_bug.cgi?id=228703.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • webgl/TestExpectations:
12:22 PM Changeset in webkit [281642] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

Update test expectations for 4 media tests.
​https://bugs.webkit.org/show_bug.cgi?id=229474.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:09 PM Changeset in webkit [281641] by Wenson Hsieh
  • 3 edits in trunk/LayoutTests

[iOS] editing/input/cocoa/autocorrect-on.html occasionally fails with a text diff
​https://bugs.webkit.org/show_bug.cgi?id=229560
rdar://82191308

Reviewed by Andy Estes.

Adjust the test so that it doesn't require "Tset" to be autocorrected to "Test". Instead, just check that it was
changed from "Tset" to anything else.

  • editing/input/cocoa/autocorrect-on-expected.txt:
  • editing/input/cocoa/autocorrect-on.html:
12:03 PM Changeset in webkit [281640] by mmaxfield@apple.com
  • 14 edits in trunk/Source/WebKit

Clean up logging #includes
​https://bugs.webkit.org/show_bug.cgi?id=229547

Reviewed by Eric Carlson.

It's actually harmful to include the wrong framework's Logging.h file,
because they conflict with each other. You'll end up with errors like
Unknown symbol "WebCore::WebKit2LogLayout".

No new tests because there is no behavior change.

  • GPUProcess/GPUConnectionToWebProcess.cpp:
  • GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::logChannel const):

  • Shared/mac/MediaFormatReader/MediaFormatReader.cpp:

(WebKit::logChannel):

  • Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:

(WebKit::MediaSampleCursor::logChannel const):

  • Shared/mac/MediaFormatReader/MediaTrackReader.cpp:

(WebKit::MediaTrackReader::logChannel const):

  • UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp:

(WebKit::RemoteMediaSessionCoordinatorProxy::logChannel const):

  • UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp:

(WebKit::logChannel):

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::logChannel const):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::logChannel const):

  • WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:

(WebKit::MediaSourcePrivateRemote::logChannel const):

  • WebProcess/GPU/media/RemoteAudioSourceProvider.cpp:

(WebKit::RemoteAudioSourceProvider::logChannel const):

  • WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::logChannel const):

  • WebProcess/MediaSession/RemoteMediaSessionCoordinator.cpp:

(WebKit::RemoteMediaSessionCoordinator::logChannel const):

11:52 AM Changeset in webkit [281639] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ BigSur arm64 EWS ] ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData) on security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html (flaky crash).
​https://bugs.webkit.org/show_bug.cgi?id=229505

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:44 AM Changeset in webkit [281638] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Segfault in stress/typedarray-every.js (32bit)
​https://bugs.webkit.org/show_bug.cgi?id=229546

Reviewed by Saam Barati.

ARMv7 does not have enough registers. Adding workaround by using getEffectiveAddress.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateWithGuard):

11:40 AM Changeset in webkit [281637] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Catalina EWS ] webgl/2.0.0/* tests are flaky crashing ASSERTION FAILED: !needsLayout().
​https://bugs.webkit.org/show_bug.cgi?id=229580.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:28 AM Changeset in webkit [281636] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

REGRESSION (281486?):[BigSur wk2 Debug] http/tests/loading/preload-img-test.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=229579.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:04 AM Changeset in webkit [281635] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

Update test expectations for media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html.
​https://bugs.webkit.org/show_bug.cgi?id=229474.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:52 AM Changeset in webkit [281634] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[iOS] 3 service worker tests failing.
​https://bugs.webkit.org/show_bug.cgi?id=229573.

Unreviewed test gardening.

  • platform/ios-14/TestExpectations:
10:49 AM Changeset in webkit [281633] by Wenson Hsieh
  • 3 edits
    1 add
    1 delete in trunk/Tools

TestWebKitAPI._WKActivatedElementInfo.InfoForRotatedImage is failing on iOS 15
​https://bugs.webkit.org/show_bug.cgi?id=229531
rdar://82100466

Reviewed by Said Abou-Hallawa.

Due to changes in underlying system frameworks in iOS 15, the red "corner" of the rotated image in this test now
ends up with a color of 0xFFF51800 instead of 0xFFF51900. Resolve this by refactoring the test so that it's
robust against these kinds of minute differences.

To achieve this, we first run the test over a version of the test image without EXIF rotation data (test.jpg) to
measure the expected values of the red, green, yellow and blue corners; we then verify that these color values
are present in the corresponding rotated corners of the image with EXIF rotation.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Removed.
  • TestWebKitAPI/Tests/WebKitCocoa/test.jpg: Added.
10:04 AM Changeset in webkit [281632] by Chris Dumez
  • 5 edits in trunk

REGRESSION (r281516): [AppleSilicon WK2] fast/loader/reload-zero-byte-plugin.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=229532
<rdar://problem/82370692>

Tools:

Unreviewed, partial revert of r281516 to drop the changes to WebKitTestRunner's injected bundle
as I suspect this is what caused this regression. The WKTR changes were made to try and address
the flakiness of imported/w3c/web-platform-tests/IndexedDB/serialize-sharedarraybuffer-throws.https.html
but it turns out that the test is still flaky with the WKTR change.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):

LayoutTests:

Unreviewed, unskip test that should not longer be timing out.

  • platform/mac-wk2/TestExpectations:
9:55 AM Changeset in webkit [281631] by commit-queue@webkit.org
  • 23 edits in trunk

Unreviewed, reverting r281616.
​https://bugs.webkit.org/show_bug.cgi?id=229570

It is crashing in iOS Debug

Reverted changeset:

"Signaling state check when applying a local or remote
description is no longer aligned with the WebRTC spec"
​https://bugs.webkit.org/show_bug.cgi?id=229138
​https://commits.webkit.org/r281616

9:41 AM Changeset in webkit [281630] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Add new experimental feature flag for sanitizing links
​https://bugs.webkit.org/show_bug.cgi?id=229451

Patch by Risul Islam <​risul_islam@apple.com> on 2021-08-26
Reviewed by Kate Cheney.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
9:35 AM Changeset in webkit [281629] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[iOS wk2 release] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229567.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
9:27 AM Changeset in webkit [281628] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[iOS wk2 iPad] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-form-submission.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229566.

Unreviewed test gardening.

  • platform/ipad/TestExpectations:
9:25 AM Changeset in webkit [281627] by Jonathan Bedard
  • 4 edits in trunk/Tools

[run-webkit-tests] Use Python 3 (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=226658
<rdar://problem/78882016>

Reviewed by Aakash Jain.

  • CISupport/build-webkit-org/steps.py:

(RunWebKitTests): Change invocation to Python 3.

  • CISupport/build-webkit-org/steps_unittest.py:
  • CISupport/kill-old-processes:

(main): run-webkit-tests may be invoked with Python 3.

9:24 AM Changeset in webkit [281626] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

[ iOS MacOS ] imported/w3c/web-platform-tests/encoding/sharedarraybuffer.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229565

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
9:02 AM Changeset in webkit [281625] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[iOS wk2 release] imported/w3c/web-platform-tests/css/css-display/display-contents-blockify-dynamic.html is a flaky timeout).
​https://bugs.webkit.org/show_bug.cgi?id=229563.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
8:51 AM Changeset in webkit [281624] by Eric Hutchison
  • 3 edits in trunk/LayoutTests

[iOS14 wk2, BigSur wk2] http/tests/navigation/page-cache-video.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229561.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
8:39 AM Changeset in webkit [281623] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[iOS14] http/tests/navigation/page-cache-getUserMedia-pending-promise.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229558.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
6:05 AM Changeset in webkit [281622] by eocanha@igalia.com
  • 2 edits in trunk/LayoutTests

[GLIB][Media] imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-without-codecs-parameter.html fails after r281617
​https://bugs.webkit.org/show_bug.cgi?id=229548

Unreviewed test gardening.

The patch from ​https://bugs.webkit.org/show_bug.cgi?id=210341 caused a regression in
mediasource-changetype-play-without-codecs-parameter.html. The test tries to change the
media type and codecs of a SourceBuffer on the fly. That operation is unsupported in glib
ports, so there is a custom expectation file that expects failures on the transitions
between supported types. Bug 210341 adds audio/mpeg (without container) as a new supported
format, so new "failures" appear in the test. This patch adds expectations for those new
failures.

  • platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-without-codecs-parameter-expected.txt:
5:45 AM Changeset in webkit [281621] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

WebGL calls into static GraphicsContextGLOpenGL functions needlessly
​https://bugs.webkit.org/show_bug.cgi?id=229402

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-08-26
Reviewed by Kenneth Russell.

The calls are problematic:

  • No other call sites than WebGL layer
  • The functionality is not needed for ANGLE, but present
  • GraphicsContextGL is now an interface with multiple implementations, GraphicsContextGLOpenGL is just one implementation

Move the functions into WebGL, inside #if !USE(ANGLE) blocks.
From there, they're simpler to move into !ANGLE specific files,
if possible.

This is work towards making it possible to remove ANGLE specific #if
blocks from WebGL implementation.

No new tests, refactor.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::getClearBitsByAttachmentType):
(WebCore::getClearBitsByFormat):
(WebCore::isAttachmentComplete):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::getChannelBitsByFormat):
(WebCore::possibleFormatAndTypeForInternalFormat):
(WebCore::WebGLRenderingContextBase::copyTexSubImage2D):
(WebCore::WebGLRenderingContextBase::isTexInternalFormatColorBufferCombinationValid):

  • platform/graphics/GraphicsContextGL.cpp:
  • platform/graphics/GraphicsContextGL.h:
  • platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
5:30 AM Changeset in webkit [281620] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

RemoteGraphicsContextGL refers to GraphicsContextGLOpenGL::SimulatedEventForTesting
​https://bugs.webkit.org/show_bug.cgi?id=229405

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-08-26
Reviewed by Kenneth Russell.

Instead, refer via the defining base class, i.e. use
GraphicsContextGL::SimulatedEventForTesting.
Fixes problems if we try to move ANGLE implementation out of
GraphicsContextGLOpenGL.

No new tests, refactor.

  • GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::simulateEventForTesting):

  • GPUProcess/graphics/RemoteGraphicsContextGL.h:
5:28 AM Changeset in webkit [281619] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[GLIB] Update baselines after r281512
​https://bugs.webkit.org/show_bug.cgi?id=229530

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-26

  • platform/glib/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/glib/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
3:13 AM Changeset in webkit [281618] by ysuzuki@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] DataIC should not embed StructureStubInfo pointer
​https://bugs.webkit.org/show_bug.cgi?id=229541

Reviewed by Mark Lam.

We should not embed pointer to StructureStubInfo::countdown if DataIC is used.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::store8):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::offsetOfCountdown):

2:29 AM Changeset in webkit [281617] by eocanha@igalia.com
  • 11 edits in trunk

[GStreamer][MSE] Implement the "sequence" mode in SourceBuffer for the GStreamer ports
​https://bugs.webkit.org/show_bug.cgi?id=210341

Reviewed by Alicia Boya Garcia.

LayoutTests/imported/w3c:

  • web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt: Added extra blank line in expectations, like in many other expectations files.

Source/WebCore:

Declare audio/mpeg support and handle it properly in AppendPipeline. This media type
doesn't have any container format, so an identity element is used in place of the
demuxer (dummy demuxer). As this element isn't an actual demuxer, the standard
no-more-pads signal isn't present, so its behaviour is simulated when the first buffer
is emitted by the element (detected by a probe).

A parser element is needed to process the data (mpegaudioparse for mpeg audio v1,
aacparse for mpeg audio v2 & v4). The existing createOptionalParserForFormat()
infrastructure is used for that after analyzing the caps, and an identity element is
now also used instead in the cases when a parser isn't needed. This simplifies the code
that links the pipeline elements, as now there aren't any optional (non existing)
elements in place, just GstIdentity instances there.

Still, the selection of the proper mpeg/aac parser requires precise caps. A new typefind
element is now used after the appsrc (when needed, and another identity element when
not).

Return TypeError in SourceBuffer::setMode(), instead of InvalidAccessError. The MSE spec
changed this behaviour at some point before June 2016 and the WebKit code never reflected
the change, still returning the deprecated InvalidAccessError when generate timestamps
flag equals true and new mode equals "segments".

Finally, the MediaSample::setTimestamps() method has been implemented for the GStreamer
port. It had an empty implementation and no problem had been detected before because
the "sequence" SourceBuffer mode had never been used until now.

Covered by existing tests.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::setMode): Return TypeError.

  • platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::initializeDecoders): Declare audio/mpeg support.

  • platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::setTimestamps): Implement method.

  • platform/graphics/gstreamer/MediaSampleGStreamer.h: Removed setTimestamps() empty implementation.
  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline): Support audio/mpeg by instancing a typefind element when needed (or identity when not), using an identity element instead of a demuxer and simulating what would be done in the no-more-pads signal handlers, but using a probe to detect the first buffer traversing the parser.
(WebCore::createOptionalParserForFormat): Use the mpegversion caps field to instance the right kind of parser when detecting the audio/mpeg media type in the caps. An identity element is now returned in case no parser is needed.
(WebCore::AppendPipeline::Track::initializeElements): Simplify element linking now that the parser (or identity) is always guaranteed to exist.
(WebCore::AppendPipeline::streamTypeToString): Added default branch to switch to fix build warning.

  • platform/graphics/gstreamer/mse/AppendPipeline.h: Added m_typefind. Reordered some attributes and added comments to improve readability.

LayoutTests:

  • platform/glib/TestExpectations: Unskipped test
12:57 AM Changeset in webkit [281616] by youenn@apple.com
  • 23 edits in trunk

Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec
​https://bugs.webkit.org/show_bug.cgi?id=229138

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebasing tests.
Some tests are going from PASS to FAIL:

  • LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https.html: we do not support yet rollback.
  • LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-pranswer.html: is no longer throwing the right exception (and we are not supporting pranswer yet).
  • LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription.html: we are throwing with a different exception.
  • web-platform-tests/webrtc/RTCPeerConnection-SLD-SRD-timing.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation-stress-glare-linear.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation-stress-glare.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-restartIce.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-pranswer-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-rollback-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-rollback-expected.txt:
  • web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:

Source/WebCore:

These checks have been removed from the spec and are no longer valid.
Covered by rebased tests.

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::setLocalDescription):
(WebCore::PeerConnectionBackend::setRemoteDescription):
(WebCore::isLocalDescriptionTypeValidForState): Deleted.
(WebCore::isRemoteDescriptionTypeValidForState): Deleted.

  • testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnection::SetLocalDescription):
(WebCore::MockLibWebRTCPeerConnection::SetRemoteDescription):

  • testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

  • fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
  • fast/mediastream/RTCPeerConnection-stable-expected.txt:
12:39 AM Changeset in webkit [281615] by ysuzuki@apple.com
  • 54 edits
    4 moves in trunk/Source/JavaScriptCore

[JSC] Polymorphic PutByVal
​https://bugs.webkit.org/show_bug.cgi?id=229229

Reviewed by Saam Barati.

This patch changes PutByVal IC to modern style. This polymorphic PutByVal can handle multiple array types and multiple identifiers.
Also, this removes adhoc IC code in Baseline so that it paves the way to unlinked Baseline JIT by cleaning up IC.

Several interesting points of the design.

  1. We need to pass ArrayProfile* via GPRReg to IC since we need to profile mayStoreToHole, which is still important to avoid the slow path.
  2. Transition / Replace IC need to record propertyRegs if it exists not to clobber these registers. This is important in DFG / FTL since IC should not clobber these registers unless it is flushed. It also makes Baseline code smaller since we do not reload them in the slow path call.
  3. Added a path folding String/Symbol when emitting PutByVal in DFG / FTL. This edge-case is found via a microbenchmark. Let's consider the case: one put_by_val site has one identifier "foo", but it has so many different Structures. Previously, we emit JITPutByIdGenerator adhocly, and still we cache this "foo" identifier in cachedId. In DFG / FTL, while we cannot make it PutByOffset, we can emit PutById since we know that identifier is always "foo". But after this patch's change, such a site becomes slow-path. And then this identifier information is missed, and we were emitting PutByVal for that. For now, we attempt to fold to one identifier in DFGByteCodeParser so that we can still attempt to make it PutById, which can be PutByOffset in constant folding phase. We would like to handle this one identifier slow-path case in PutByStatus / GetByStatus in the future patch.
  4. Now, DFG OSR exit does not query to ByValInfo for setter calls since JITPutByValGenerator use StructureStubInfo in Baseline.

Results of Microbenchmarks look good.

ToT Patched

put-by-val-direct-large-index 94.6265+-0.9076 93.4550+-0.7121 might be 1.0125x faster
inlined-put-by-val-with-string-transition

23.7131+-0.3282 22.7679+-0.1137 definitely 1.0415x faster

put-by-val-with-string-slightly-polymorphic

1.9852+-0.0284 1.9580+-0.0224 might be 1.0139x faster

get-and-put-by-val-double-index-dont-fall-off-a-cliff

185.4762+-0.5737 ? 185.6325+-0.5819 ?

polymorphic-put-by-val-with-string 30.9903+-0.1207 30.8097+-0.1285
put-by-val-machine-int 1.8803+-0.0384 1.8707+-0.0440
fold-put-by-val-with-symbol-to-multi-put-by-offset

4.8463+-0.1148 4.7839+-0.0547 might be 1.0130x faster

put-by-val-with-string-replace-and-transition

8.8730+-1.5934 6.2276+-0.0585 definitely 1.4248x faster

fold-put-by-val-with-string-to-multi-put-by-offset

4.8183+-0.0841 ? 4.8233+-0.0892 ?

put-by-val-direct 0.2845+-0.0091 ? 0.2901+-0.0088 ? might be 1.0196x slower
put-by-val-with-symbol-replace-and-transition

6.3527+-0.0686 ? 6.3933+-0.0961 ?

put-by-val-with-symbol 9.3556+-3.1421 7.1509+-0.1019 might be 1.3083x faster
put-by-val-with-symbol-slightly-polymorphic

2.0052+-0.0309 1.9781+-0.0397 might be 1.0137x faster

put-by-val-negative-array-index 14.9572+-0.1221 14.5636+-0.1044 definitely 1.0270x faster
put-by-val-with-string 11.6345+-4.3048 7.0919+-0.0918 definitely 1.6405x faster
put-by-val-large-index-blank-indexing-type

3.1425+-0.1165 3.1236+-0.0378

inlined-put-by-val-with-symbol-transition

23.4932+-0.3186 22.8469+-0.0873 definitely 1.0283x faster

polymorphic-put-by-val-with-symbol 36.6046+-1.6519 30.8597+-0.1474 definitely 1.1862x faster

Speedometer2 showed roughly 0.2-0.3% progression.

| subtest | ms | ms | b / a | pValue (significance using False Discovery Rate) |

| Elm-TodoMVC |121.916667 |121.958333 |1.000342 | 0.876802 |
| VueJS-TodoMVC |26.263333 |26.006667 |0.990227 | 0.263868 |
| EmberJS-TodoMVC |127.080000 |127.866667 |1.006190 | 0.011497 (significant) |
| BackboneJS-TodoMVC |48.920000 |49.318333 |1.008143 | 0.003395 (significant) |
| Preact-TodoMVC |19.828333 |19.828333 |1.000000 | 1.000000 |
| AngularJS-TodoMVC |134.011667 |132.080000 |0.985586 | 0.000000 (significant) |
| Vanilla-ES2015-TodoMVC |63.726667 |63.838333 |1.001752 | 0.408404 |
| Inferno-TodoMVC |65.153333 |63.753333 |0.978512 | 0.000000 (significant) |
| Flight-TodoMVC |78.133333 |78.780000 |1.008276 | 0.097794 |
| Angular2-TypeScript-TodoMVC |40.415000 |40.100000 |0.992206 | 0.287630 |
| VanillaJS-TodoMVC |51.931667 |52.500000 |1.010944 | 0.004149 (significant) |
| jQuery-TodoMVC |226.056667 |225.073333 |0.995650 | 0.007796 (significant) |
| EmberJS-Debug-TodoMVC |341.210000 |340.978333 |0.999321 | 0.623386 |
| React-TodoMVC |87.198333 |86.893333 |0.996502 | 0.042189 |
| React-Redux-TodoMVC |146.506667 |145.958333 |0.996257 | 0.018801 (significant) |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |61.450000 |61.870000 |1.006835 | 0.000049 (significant) |

a mean = 254.85111
b mean = 255.25735
pValue = 0.1856561656
(Bigger means are better.)
1.002 times better
Results ARE NOT significant

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • bytecode/AccessCase.cpp:

(JSC::AccessCase::create):
(JSC::AccessCase::guardedByStructureCheckSkippingConstantIdentifierCheck const):
(JSC::AccessCase::requiresIdentifierNameMatch const):
(JSC::AccessCase::requiresInt32PropertyCheck const):
(JSC::AccessCase::needsScratchFPR const):
(JSC::AccessCase::forEachDependentCell const):
(JSC::AccessCase::doesCalls const):
(JSC::AccessCase::canReplace const):
(JSC::AccessCase::generateWithGuard):
(JSC::AccessCase::generateImpl):
(JSC::AccessCase::toTypedArrayType):
(JSC::AccessCase::canBeShared):

  • bytecode/AccessCase.h:

(JSC::SharedJITStubSet::Hash::Key::Key):
(JSC::SharedJITStubSet::Hash::Key::operator==):
(JSC::SharedJITStubSet::Searcher::Translator::equal):

  • bytecode/ArrayProfile.h:

(JSC::ArrayProfile::offsetOfMayStoreToHole):
(JSC::ArrayProfile::offsetOfLastSeenStructureID):

  • bytecode/GetterSetterAccessCase.cpp:

(JSC::GetterSetterAccessCase::emitDOMJITGetter):

  • bytecode/ICStatusMap.h:
  • bytecode/InlineAccess.cpp:

(JSC::getScratchRegister):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):
(WTF::printInternal):

  • bytecode/PutByStatus.cpp: Renamed from Source/JavaScriptCore/bytecode/PutByIdStatus.cpp.

(JSC::PutByStatus::appendVariant):
(JSC::PutByStatus::shrinkToFit):
(JSC::PutByStatus::computeFromLLInt):
(JSC::PutByStatus::PutByStatus):
(JSC::PutByStatus::computeFor):
(JSC::PutByStatus::computeForStubInfo):
(JSC::PutByStatus::makesCalls const):
(JSC::PutByStatus::slowVersion const):
(JSC::PutByStatus::singleIdentifier const):
(JSC::PutByStatus::visitAggregateImpl):
(JSC::PutByStatus::markIfCheap):
(JSC::PutByStatus::finalize):
(JSC::PutByStatus::merge):
(JSC::PutByStatus::filter):
(JSC::PutByStatus::dump const):

  • bytecode/PutByStatus.h: Renamed from Source/JavaScriptCore/bytecode/PutByIdStatus.h.
  • bytecode/PutByVariant.cpp: Renamed from Source/JavaScriptCore/bytecode/PutByIdVariant.cpp.

(JSC::PutByVariant::PutByVariant):
(JSC::PutByVariant::operator=):
(JSC::PutByVariant::replace):
(JSC::PutByVariant::transition):
(JSC::PutByVariant::setter):
(JSC::PutByVariant::oldStructureForTransition const):
(JSC::PutByVariant::fixTransitionToReplaceIfNecessary):
(JSC::PutByVariant::writesStructures const):
(JSC::PutByVariant::reallocatesStorage const):
(JSC::PutByVariant::makesCalls const):
(JSC::PutByVariant::attemptToMerge):
(JSC::PutByVariant::attemptToMergeTransitionWithReplace):
(JSC::PutByVariant::visitAggregateImpl):
(JSC::PutByVariant::markIfCheap):
(JSC::PutByVariant::finalize):
(JSC::PutByVariant::dump const):
(JSC::PutByVariant::dumpInContext const):

  • bytecode/PutByVariant.h: Renamed from Source/JavaScriptCore/bytecode/PutByIdVariant.h.

(JSC::PutByVariant::PutByVariant):
(JSC::PutByVariant::identifier const):
(JSC::PutByVariant::overlaps):

  • bytecode/RecordedStatuses.cpp:

(JSC::RecordedStatuses::addPutByStatus):
(JSC::RecordedStatuses::visitAggregateImpl):
(JSC::RecordedStatuses::addPutByIdStatus): Deleted.

  • bytecode/RecordedStatuses.h:
  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::reset):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::filterICStatus):

  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::emitPutById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::handlePutPrivateNameById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::handlePutByVal):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::tryFoldAsPutByOffset):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addPutByVal):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasPutByStatus):
(JSC::DFG::Node::putByStatus):
(JSC::DFG::Node::hasPutByIdStatus): Deleted.
(JSC::DFG::Node::putByIdStatus): Deleted.

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::callerReturnPC):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStoreBarrierInsertionPhase.cpp:
  • dfg/DFGValidate.cpp:
  • dfg/DFGVarargsForwardingPhase.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):

  • generator/DSL.rb:
  • jit/ICStats.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::link):

  • jit/JIT.h:
  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByValGenerator::JITPutByValGenerator):
(JSC::JITPutByValGenerator::generateFastPath):
(JSC::JITPutByValGenerator::finalize):

  • jit/JITInlineCacheGenerator.h:
  • jit/JITInlines.h:

(JSC::JIT::emitArrayProfilingSiteWithCell):
(JSC::JIT::chooseArrayMode): Deleted.

  • jit/JITOperations.cpp:

(JSC::JSC_DEFINE_JIT_OPERATION):
(JSC::putByVal):
(JSC::directPutByVal):
(JSC::putByValOptimize):
(JSC::directPutByValOptimize):
(JSC::tryPutByValOptimize): Deleted.
(JSC::tryDirectPutByValOptimize): Deleted.

  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::slow_op_put_by_val_prepareCallGenerator):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::slow_op_put_private_name_prepareCallGenerator):
(JSC::JIT::emitGenericContiguousPutByVal): Deleted.
(JSC::JIT::emitArrayStoragePutByVal): Deleted.
(JSC::JIT::privateCompilePutByVal): Deleted.
(JSC::JIT::privateCompilePutByValWithCachedId): Deleted.
(JSC::JIT::emitIntTypedArrayPutByVal): Deleted.
(JSC::JIT::emitFloatTypedArrayPutByVal): Deleted.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal): Deleted.
(JSC::JIT::emitArrayStoragePutByVal): Deleted.

  • jit/Repatch.cpp:

(JSC::appropriateGenericPutByFunction):
(JSC::appropriateOptimizingPutByFunction):
(JSC::tryCachePutBy):
(JSC::repatchPutBy):
(JSC::tryCacheArrayPutByVal):
(JSC::repatchArrayPutByVal):
(JSC::tryCacheInBy):
(JSC::resetPutBy):
(JSC::appropriateGenericPutByIdFunction): Deleted.
(JSC::appropriateOptimizingPutByIdFunction): Deleted.
(JSC::tryCachePutByID): Deleted.
(JSC::repatchPutByID): Deleted.
(JSC::resetPutByID): Deleted.

  • jit/Repatch.h:
  • llint/LowLevelInterpreter.h:
12:25 AM Changeset in webkit [281614] by Fujii Hironori
  • 2 edits in trunk/Source/WebKit

[curl] REGRESSION(r281158): fetch('​http://localhost/') from about:blank doesn't emit the console error message
​https://bugs.webkit.org/show_bug.cgi?id=229515

Unreviewed, reverting r281158.

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):

Aug 25, 2021:

8:37 PM Changeset in webkit [281613] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Crash in GraphicsContextGLOpenGL::reshapeDisplayBufferBacking
​https://bugs.webkit.org/show_bug.cgi?id=229309

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-25
Reviewed by Myles C. Maxfield.

Source/WebCore:

Test: fast/canvas/xr-compatible-crash.html

Null check m_swapChain because reshapeDisplayBufferBacking can be called before it is set.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::addContextObject):

  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::reshapeDisplayBufferBacking):

LayoutTests:

  • fast/canvas/xr-compatible-crash.html: Added.
  • fast/canvas/xr-compatible-crash-expected.txt: Added.
8:08 PM Changeset in webkit [281612] by Aditya Keerthi
  • 7 edits in trunk

[iOS] Unable to select files when the accept attribute is set to "*/*"
​https://bugs.webkit.org/show_bug.cgi?id=229456
rdar://82346315

Reviewed by Chris Dumez.

Source/WebKit:

"*/*" is a valid MIME type string representing all media types. However,
the UniformTypeIdentifiers framework (as well as the now deprecated
CoreServices type identifiers API) does not map wildcard MIME types.

In order to restrict UIDocumentPickerViewController to the types of
files specified in the accept attribute, all MIME type strings are
converted into UTTypes. However, when attempting to retrieve a UTType
for "*/*", the system dynamically generates a type, since the string is
unregistered. Then, since no files conform to the dynamic type, all
files in the document picker are greyed out, and the user is unable
to access the "Photo Library" and "Take Photo or Video" items.

To fix, return an empty set of type identifiers whenever "*/*" is
present in the list of MIME types, ensuring there are no restrictions
on the types of files that can be selected.

Note that the same issue does not occur on macOS, since all MIME types
are mapped to a set of file extensions, rather than UTTypes. Furthermore,
on macOS, the embedding app, not WebKit, is responsible for displaying
the file picker.

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

LayoutTests:

Updated tests to verify that setting the accept attribute to "*/*" does
not impose any restrictions on the types of files that can be selected,
and gives the user access to all menu options.

  • fast/forms/ios/file-upload-panel-accept-expected.txt:
  • fast/forms/ios/file-upload-panel-accept.html:
  • fast/forms/ios/file-upload-panel-expected.txt:
  • fast/forms/ios/file-upload-panel.html:
8:07 PM Changeset in webkit [281611] by Chris Dumez
  • 2 edits in trunk/LayoutTests

REGRESSION (r281516): [AppleSilicon WK2] fast/loader/reload-zero-byte-plugin.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=229532
<rdar://problem/82370692>

Unreviewed, temporarily skip the test on macOS WK2 while I investigate, so that the bots don't
complain.

  • platform/mac-wk2/TestExpectations:
6:38 PM Changeset in webkit [281610] by Wenson Hsieh
  • 22 edits in trunk

Remove some iOS-specific compile-time guards that are no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=229500

Reviewed by Tim Horton.

Source/WebCore:

See WebKit/ChangeLog for more details.

  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):

  • platform/PlatformKeyboardEvent.h:
  • platform/ios/KeyEventIOS.mm:

(WebCore::isFunctionKey):

Source/WebKit:

Remove two compile-time flags that were no longer necessary after WebKit's minimum supported iOS version became
iOS 14: USE(UIKIT_KEYBOARD_ADDITIONS) and HAVE(NONDESTRUCTIVE_IMAGE_PASTE_SUPPORT_QUERY).

HAVE(NONDESTRUCTIVE_IMAGE_PASTE_SUPPORT_QUERY) was only needed for a workaround in our test infrastructure,
while USE(UIKIT_KEYBOARD_ADDITIONS) was only introduced to maintain basic hardware keyboard functionality in
iOS 12, while supporting improvements to hardware keyboard support in iOS 13.

The latter now only guards PLATFORM(IOS) || PLATFORM(MACCATALYST). However, there's no reason the codepaths
for hardware keyboard support can't exist on watchOS as well (especially since most of hardware keyboard
support is already implemented there -- just unreachable because it's not possible to attach a hardware keyboard
to an Apple watch). We can remove this feature flag, and simply delete code that was formerly guarded by
!USE(UIKIT_KEYBOARD_ADDITIONS).

  • Platform/spi/ios/UIKitSPI.h:
  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::encode const):
(WebKit::WebKeyboardEvent::decode):

  • Shared/WebKeyboardEvent.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):
(-[WKContentView _disableAutomaticKeyboardUI]):
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _setMarkedText:highlights:selectedRange:]):
(-[WKContentView textInputTraits]):
(-[WKContentView _handleKeyUIEvent:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
(-[WKContentView _elementDidBlur]):
(-[WKContentView _hardwareKeyboardAvailabilityChanged]):
(-[WKContentView _selectionChanged]):
(-[WKContentView keyCommands]): Deleted.
(-[WKContentView handleKeyEvent:]): Deleted.

  • UIProcess/ios/WKSyntheticFlagsChangedWebEvent.h:
  • UIProcess/ios/WKSyntheticFlagsChangedWebEvent.mm:
  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover initWithView:hasGroups:]):
(-[WKSelectTableViewController hasText]): Deleted.
(-[WKSelectTableViewController insertText:]): Deleted.
(-[WKSelectTableViewController deleteBackward]): Deleted.

  • WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

(WebKit::WebEditorClient::handleInputMethodKeydown):

Source/WTF:

Remove the feature flags. See WebKit/ChangeLog for more details.

  • wtf/PlatformHave.h:
  • wtf/PlatformUse.h:

Tools:

Remove this workaround, which was only required to keep an API test passing on iOS 13.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):
(overrideKeyboardDelegateSupportsImagePaste): Deleted.

5:47 PM Changeset in webkit [281609] by Alan Coon
  • 2 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r281595. rdar://problem/82365117

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Build fix after ​https://commits.webkit.org/240941@main.

  • Scripts/generate-derived-sources.sh:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:47 PM Changeset in webkit [281608] by Alan Coon
  • 2 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r281577. rdar://problem/82365117

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Skip unneeded commands when preprocessing sandbox on iOS.

  • Scripts/generate-derived-sources.sh:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:43 PM Changeset in webkit [281607] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r281513?): [ JSC Catalina+ Debug ] 16 stress/intl-enumeration.js (JSC Tests) are flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=229526

Reviewed by Mark Lam.

Fix debug JSC test failures by using RELEASE_AND_RETURN.

  • runtime/IntlObject.cpp:

(JSC::availableCalendars):
(JSC::availableCollations):
(JSC::availableCurrencies):
(JSC::availableNumberingSystems):
(JSC::availableTimeZones):

5:39 PM Changeset in webkit [281606] by Simon Fraser
  • 12 edits in trunk/Source/WebKit

Replace the uint64_t used to identify form submits with a strongly typed identifier
​https://bugs.webkit.org/show_bug.cgi?id=229513

Reviewed by Alex Christensen.

Introduce FormSubmitListenerIdentifier and use it in place of a uint64_t.

  • Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):
(headers_for_type):

  • Shared/IdentifierTypes.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::setUpWillSubmitFormListener):
(WebKit::WebFrame::continueWillSubmitForm):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::continueWillSubmitForm):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:01 PM Changeset in webkit [281605] by Alan Coon
  • 3 edits
    1 move in branches/safari-612-branch

Cherry-pick r281500. rdar://problem/82350929

(r281473) stress/for-in-has-own-property-shouldnt-flush-registers.js failing on Debug
​https://bugs.webkit.org/show_bug.cgi?id=229448

Reviewed by Mark Lam.

JSTests:

Fix typo in test name.

  • stress/for-in-in-by-val-should-flush-registers.js: Renamed from JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js.

Source/JavaScriptCore:

Add missing exception checks.

  • dfg/DFGOperations.cpp: (JSC::DFG::JSC_DEFINE_JIT_OPERATION):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:01 PM Changeset in webkit [281604] by Alan Coon
  • 1 edit in branches/safari-612-branch/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig

Cherry-pick r281250. rdar://problem/82354967

Build fix after r281245.

Link with Metal.framework.

  • Configurations/WebCoreTestSupport.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:01 PM Changeset in webkit [281603] by Alan Coon
  • 7 edits
    4 adds in branches/safari-612-branch

Cherry-pick r281245. rdar://problem/82354967

WebGL via Metal experimental feature does not correctly toggle metal backend
​https://bugs.webkit.org/show_bug.cgi?id=229267
<rdar://81855735>

Source/WebCore:

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

GraphicsContextGLAttributes defines 'useMetal' as 'true' by default.
Since this branch was only checking if Metal was enabled via the
setting, rather than checking the status of the flag, the metal backend
was never disabled, even when requested.

Tests: webgl/webgl-metal-disabled.html

webgl/webgl-metal-enabled.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::create):
  • testing/Internals.cpp: (WebCore::Internals::requestedMetal):
  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/Internals.mm: (WebCore::Internals::platformSupportsMetal):

LayoutTests:

Add tests to verify WebGL feature flag works as intended.

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

  • webgl/webgl-metal-disabled-expected.txt: Added.
  • webgl/webgl-metal-disabled.html: Added.
  • webgl/webgl-metal-enabled-expected.txt: Added.
  • webgl/webgl-metal-enabled.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:00 PM Changeset in webkit [281602] by Truitt Savell
  • 2 edits in trunk/LayoutTests

25 webkit imported/w3c/web-platform-tests/css/ layout tests failing with black bars
rdar://82132196

Unreviewed test gardening.

4:58 PM Changeset in webkit [281601] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Catalina GPU] fast/canvas/webgl/lose-context-on-timeout.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229523.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:52 PM Changeset in webkit [281600] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

Update test expectations for fast/events/ios/key-events-comprehensive/key-events-meta-shift.html.
<rdar://80385777>.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
4:39 PM Changeset in webkit [281599] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

[iOS] Visual Look Up animates from the wrong rect when the web view is scaled
​https://bugs.webkit.org/show_bug.cgi?id=229518
rdar://82147473

Reviewed by Darin Adler.

When adopting QLPreviewControllerDelegate's animated transition methods for rdar://76020349, I mistakenly
thought that the outContentRect passed into -previewController:transitionImageForPreviewItem:contentRect:
would be in source view (WKContentView) coordinates; instead, QuickLook expects this contentRect to be in
window coordinates.

Fix this by first converting _visualSearchPreviewImageBounds to window coordinates.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView previewController:transitionImageForPreviewItem:contentRect:]):

4:15 PM Changeset in webkit [281598] by Alan Coon
  • 8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7612.2.3

4:07 PM Changeset in webkit [281597] by eric.carlson@apple.com
  • 10 edits in trunk/Source

[GPUP] RemoteAudioSession doesn't implement begin/endInterruption
​https://bugs.webkit.org/show_bug.cgi?id=229514
rdar://80896732

Reviewed by Jer Noble.

Source/WebCore:

Move the code necessary to deal with interruptions from AudioSessionIOS to the
base class so it can be shared with RemoteAudioSession.

Tested manually.

  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::addInterruptionObserver): Move implementation from AudioSessionIOS
so it can be shared.
(WebCore::AudioSession::removeInterruptionObserver): Ditto.
(WebCore::AudioSession::beginInterruption): Ditto.
(WebCore::AudioSession::endInterruption): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::categoryOverride const): Ditto.

  • platform/audio/AudioSession.h:
  • platform/audio/ios/AudioSessionIOS.h:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSessionIOS::setCategoryOverride): Deleted.
(WebCore::AudioSessionIOS::categoryOverride const): Deleted.
(WebCore::AudioSessionIOS::addInterruptionObserver): Deleted.
(WebCore::AudioSessionIOS::removeInterruptionObserver): Deleted.
(WebCore::AudioSessionIOS::beginInterruption): Deleted.
(WebCore::AudioSessionIOS::endInterruption): Deleted.

  • platform/audio/mac/AudioSessionMac.h:
  • platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSessionMac::setCategoryOverride): Deleted.

Source/WebKit:

  • WebProcess/GPU/media/RemoteAudioSession.cpp:

(WebKit::RemoteAudioSession::setIsPlayingToBluetoothOverride): Remove
ENABLE_ROUTING_ARBITRATION guard because it isn't used in the base class.

  • WebProcess/GPU/media/RemoteAudioSession.h: Change the order virtual methods are declared

so they match the base class, to make it easier to spot differences.

3:52 PM Changeset in webkit [281596] by mmaxfield@apple.com
  • 2 edits in trunk

Add command to enable logging in the docs
​https://bugs.webkit.org/show_bug.cgi?id=229419

Reviewed by Dean Jackson.

  • Introduction.md:
3:45 PM Changeset in webkit [281595] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Build fix after ​https://commits.webkit.org/240941@main.

  • Scripts/generate-derived-sources.sh:
3:34 PM Changeset in webkit [281594] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance2.
​https://bugs.webkit.org/show_bug.cgi?id=189672.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:12 PM Changeset in webkit [281593] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk1] pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229522.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
3:05 PM Changeset in webkit [281592] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac] pointer-lock/lock-already-locked.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229521.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:00 PM Changeset in webkit [281591] by Alan Coon
  • 1 edit in branches/safari-612.1.29-branch/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig

Cherry-pick r281250. rdar://problem/82354939

Build fix after r281245.

Link with Metal.framework.

  • Configurations/WebCoreTestSupport.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:00 PM Changeset in webkit [281590] by Alan Coon
  • 7 edits
    4 adds in branches/safari-612.1.29-branch

Cherry-pick r281245. rdar://problem/82354939

WebGL via Metal experimental feature does not correctly toggle metal backend
​https://bugs.webkit.org/show_bug.cgi?id=229267
<rdar://81855735>

Source/WebCore:

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

GraphicsContextGLAttributes defines 'useMetal' as 'true' by default.
Since this branch was only checking if Metal was enabled via the
setting, rather than checking the status of the flag, the metal backend
was never disabled, even when requested.

Tests: webgl/webgl-metal-disabled.html

webgl/webgl-metal-enabled.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::create):
  • testing/Internals.cpp: (WebCore::Internals::requestedMetal):
  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/Internals.mm: (WebCore::Internals::platformSupportsMetal):

LayoutTests:

Add tests to verify WebGL feature flag works as intended.

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

  • webgl/webgl-metal-disabled-expected.txt: Added.
  • webgl/webgl-metal-disabled.html: Added.
  • webgl/webgl-metal-enabled-expected.txt: Added.
  • webgl/webgl-metal-enabled.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:47 PM Changeset in webkit [281589] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1] media/media-session/actionHandlerInternalMappings.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229519.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:37 PM Changeset in webkit [281588] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

REGRESSION(r281297): 2 webrtc tests failing.
​https://bugs.webkit.org/show_bug.cgi?id=229517.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:19 PM Changeset in webkit [281587] by Yijia Huang
  • 8 edits in trunk/Source/JavaScriptCore

[ARM64] Fix pre-index address mode
​https://bugs.webkit.org/show_bug.cgi?id=229175

Reviewed by Saam Barati.

This patch fixes the canonicalization phase for pre/post-increment address mode
due to the potential bugs commented on in the previous patch
​https://bugs.webkit.org/show_bug.cgi?id=228538. And this patch removed the
temporary fix in ​https://bugs.webkit.org/show_bug.cgi?id=229211.

Previously, the pre-index address mode for Load instruction convert the pattern
to the canonical form like this:

address = Add(base, offset) address = Add(base, offset)
... --> newMemory = Load(base, offset)
... ...
memory = Load(base, offset) memory = Identity(newMemory)

which is wrong. Assume "..." contains a store to a memory location that aliases for address:

address = Add(base, offset) address = Add(base, offset)
... --> newMemory = Load(base, offset)
... ...
Store(value1, address) Store(value1, address)
memory = Load(base, offset) memory = Identity(newMemory)

The loaded value should always be value1 which is not true after the conversion.
So, moving the load above the store is semantically incorrect because it's not identical to
the behavior of the original program. In this case, maybe we should apply alias analysis to
detect the violations of reference updating.

To solve this problem, we moves the address value to just before the memory value instead of
moving memory value upward.

Convert Pre-Index Load Pattern to the Canonical Form:

address = Add(base, offset) address = Nop
... ...
... newAddress = Add(base, offset)
memory = Load(base, offset) --> memory = Load(base, offset)
... ...
parent = B3Opcode(address, ...) parent = B3Opcode(newAddress, ...)

Convert Pre-Index Store Pattern to the Canonical Form:

address = Add(base, offset) address = Nop
... ...
... newAddress = Add(base, offset)
memory = Store(value1, base, offset) --> memory = Store(value1, base, offset)
... ...
parent = B3Opcode(address, ...) parent = B3Opcode(newAddress, ...)

To move the address value downward, we need to make sure that no use reference of address between
the address and memory values.

  • b3/B3CanonicalizePrePostIncrements.cpp:

(JSC::B3::canonicalizePrePostIncrements):

  • b3/B3Generate.cpp:

(JSC::B3::generateToAir):

  • b3/B3ValueKey.h:
  • b3/B3ValueKeyInlines.h:

(JSC::B3::ValueKey::ValueKey):

  • b3/testb3.h:
  • b3/testb3_3.cpp:

(testLoadWithStorePreIndex32):
(testStorePreIndex32):
(testStorePreIndex64):
(testStorePostIndex32):
(testStorePostIndex64):
(addShrTests):

  • runtime/OptionsList.h:
2:18 PM Changeset in webkit [281586] by Jonathan Bedard
  • 5 edits in trunk/Tools

[git-webkit] Use Python 3 in CI
​https://bugs.webkit.org/show_bug.cgi?id=229498
<rdar://problem/82342387>

Reviewed by Aakash Jain.

  • CISupport/build-webkit-org/steps.py:

(ShowIdentifier.start): Invoke git-webkit with Python 3.

  • CISupport/build-webkit-org/steps_unittest.py:

(TestShowIdentifier.test_success):
(TestShowIdentifier.test_failure):

  • CISupport/ews-build/steps.py:

(ShowIdentifier.start): Invoke git-webkit with Python 3.

  • CISupport/ews-build/steps_unittest.py:
2:18 PM Changeset in webkit [281585] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2 Release] imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229516.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:15 PM Changeset in webkit [281584] by Chris Dumez
  • 4 edits in trunk/LayoutTests

[Mac wk2] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=229511
<rdar://problem/82356082>

Unreviewed, address test flakiness by silencing console logging.

LayoutTests/imported/w3c:

  • web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https-expected.txt:

LayoutTests:

2:11 PM Changeset in webkit [281583] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

Update test expectations for imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https.html .
​https://bugs.webkit.org/show_bug.cgi?id=229511.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:11 PM Changeset in webkit [281582] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229511.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:06 PM Changeset in webkit [281581] by Jonathan Bedard
  • 4 edits in trunk/Tools

[resultsdbpy] Handle E configuration comparisons
​https://bugs.webkit.org/show_bug.cgi?id=229477
<rdar://problem/82316775>

Reviewed by Stephanie Lewis.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Bump version.
  • Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js:

(Configuration.prototype.compare): Ignore "E" version names in both directions.

  • Scripts/libraries/resultsdbpy/setup.py: Bump version.
2:06 PM Changeset in webkit [281580] by Simon Fraser
  • 12 edits
    426 adds
    2 deletes in trunk/LayoutTests

Update css-masking WPT
​https://bugs.webkit.org/show_bug.cgi?id=229373

Reviewed by Tim Horton.
LayoutTests/imported/w3c:

Re-import css-masking tests from WPT fe104253de3197002a2600a4ed7e3b5e18fc9121.

  • resources/import-expectations.json:
  • web-platform-tests/css/css-masking/META.yml: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-composition-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-composition.html: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-001.html: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-002.html: Added.
  • web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/mask-image-interpolation.html: Added.
  • web-platform-tests/css/css-masking/animations/mask-position-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/mask-position-interpolation.html: Added.
  • web-platform-tests/css/css-masking/animations/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-nested-twice-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-nested-twice.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-006-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-006.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-007-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-007.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-008-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-008.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-009-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-009.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-010-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-010.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-invisible-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-invisible.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-syling-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-syling.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-006-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-006.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-007-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-007.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-child-changes-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-child-changes.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-clippathunits-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-clippathunits.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-href-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-href.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-id-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-id.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-invalid.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-negative-scale-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-negative-scale.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-precision-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-precision-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-userspaceonuse-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-userspaceonuse-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-opacity-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-opacity.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-transform-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-transform.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-and-nested-clip-path-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-and-nested-clip-path.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-006-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-006.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-007-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-007.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-008-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-008.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-009-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-009.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-010-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-010.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip-transform-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip-transform.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip-transform-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip-transform.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-circle-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-004-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-content-clip-004-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-ellipse-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-invisible-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-negative-scale-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-on-marker-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-on-marker-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-precision-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-recursion-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-shape-inset-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-hole-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-text-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-text-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-text-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-and-nested-clip-path-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-content-clip-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-content-clip-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-nested-clip-path-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-nested-clip-path-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-nested-clip-path-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path/animations/clip-path-animation-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/animations/clip-path-animation.html: Added.
  • web-platform-tests/css/css-masking/clip-path/animations/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-blending-offset-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-blending-offset.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-descendant-text-mutated-001.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-inset-round-percent-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-inset-round-percent.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-with-zoom-expected.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-with-zoom.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-expected.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest-expected.html: Removed.
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-backdrop-filter-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-backdrop-filter.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-font-loading-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-font-loading.html: Added.
  • web-platform-tests/css/css-masking/clip-path/w3c-import.log:
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-001.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-002.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-filter-order-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-filter-order.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-fixed-pos-transform-descendant-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-fixed-pos-transform-descendant-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-stacking-context-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-stacking-context.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-005-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-005.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-006-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-006.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-scroll-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-scroll.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order-2-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order-2.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order.html: Added.
  • web-platform-tests/css/css-masking/clip/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-001.html: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-002.html: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-userspaceonuse-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-userspaceonuse-001.html: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-shape-polygon-and-box-shadow-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-shape-polygon-and-box-shadow.html: Added.
  • web-platform-tests/css/css-masking/hit-test/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/idlharness-expected.txt: Added.
  • web-platform-tests/css/css-masking/idlharness.html: Added.
  • web-platform-tests/css/css-masking/inheritance.sub-expected.txt: Added.
  • web-platform-tests/css/css-masking/inheritance.sub.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-clip-exclude-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-clip-exclude.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-data-url-image-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-data-url-image.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split-2-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split-2.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-svg-child-will-change-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-svg-child-will-change.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image-hash-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image-hash.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-local-mask-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-local-mask.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-remote-mask-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-remote-mask.html: Added.
  • web-platform-tests/css/css-masking/mask-image/reference/1x1-black-30-alpha.png: Added.
  • web-platform-tests/css/css-masking/mask-image/reference/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-image/support/image-with-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-image/support/image.svg: Added.
  • web-platform-tests/css/css-masking/mask-image/support/mask.svg: Added.
  • web-platform-tests/css/css-masking/mask-image/support/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-image/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-empty-container-with-filter-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-empty-container-with-filter.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-negative-scale-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-negative-scale.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-text-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-text-001.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-001.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-002.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-003.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/mask-green-square-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/mask-negative-scale-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/mask-text-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/parsing/clip-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-valid.sub.html: Added.
  • web-platform-tests/css/css-masking/parsing/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/resources/blue-20.png: Added.
  • web-platform-tests/css/css-masking/resources/green-20.png: Added.
  • web-platform-tests/css/css-masking/resources/stripes-20.png: Added.
  • web-platform-tests/css/css-masking/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/w3c-import.log: Added.

LayoutTests:

Re-import css-masking tests from WPT fe104253de3197002a2600a4ed7e3b5e18fc9121.

  • TestExpectations:
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-001-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-002-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-003-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-004-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-005-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-010-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/mask-svg-content/mask-text-001-expected.txt: Added.
  • platform/ios/TestExpectations:
  • platform/mac/imported/w3c/web-platform-tests/css/css-masking/clip-path/svg-clipPath-expected.txt: Removed.
2:01 PM Changeset in webkit [281579] by Aditya Keerthi
  • 9 edits
    2 adds in trunk

[iOS] Crash when tapping <select> element and calling window.open()
​https://bugs.webkit.org/show_bug.cgi?id=229468
rdar://82122972

Reviewed by Wenson Hsieh.

Source/WebKit:

UIKit throws an exception when attempting to present a context menu
for a view that is not in a window.

One instance where this can occur in Safari is when a call to
window.open() is made in response to a touch on a select element.
In this scenario, the call to window.open() opens a new tab, unparenting
the current webview. However, the touch also focuses the element, and
WebKit attempts to present a context menu in an unparented view.

To fix, guard against the case where the view is not parented, and do
not attempt to present a context menu.

Test: fast/forms/ios/show-select-menu-in-unparented-view-crash.html

  • UIProcess/ios/WKActionSheetAssistant.mm:

Note that the helper method used in other classes is not used in
WKActionSheetAssistant, since the hosting view is not always a
WKContentView.

(-[WKActionSheetAssistant showDataDetectorsUIForPositionInformation:]):
(-[WKActionSheetAssistant showMediaControlsContextMenu:items:completionHandler:]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView presentContextMenu:atLocation:]):

Added a helper method to ensure the view is parented prior to presenting
a context menu.

(-[WKContentView imageAnalysisGestureDidTimeOut:]):

  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(-[WKDataListSuggestionsDropdown _showSuggestions]):

  • UIProcess/ios/forms/WKDateTimeInputControl.mm:

(-[WKDateTimePicker showDateTimePicker]):

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel showDocumentPickerMenu]):

  • UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKSelectPicker showSelectPicker]):

LayoutTests:

Added a test to verify a crash does not occur when tapping a <select>
element and unparenting the webview.

  • fast/forms/ios/show-select-menu-in-unparented-view-crash-expected.txt: Added.
  • fast/forms/ios/show-select-menu-in-unparented-view-crash.html: Added.
1:55 PM Changeset in webkit [281578] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening after r228617.

1:33 PM Changeset in webkit [281577] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Skip unneeded commands when preprocessing sandbox on iOS.

  • Scripts/generate-derived-sources.sh:
12:59 PM Changeset in webkit [281576] by Wenson Hsieh
  • 7 edits in trunk

[iOS 15] editing/input/cocoa/autocorrect-on.html times out when run after editing/input/cocoa/autocorrect-off.html
​https://bugs.webkit.org/show_bug.cgi?id=229486
rdar://82191308

Reviewed by Tim Horton.

Source/WebKit:

See changes in Tools for more details.

  • Platform/spi/ios/TextInputSPI.h:
  • Platform/spi/ios/UIKitSPI.h:

Tools:

The layout test (autocorrect-on.html) fails when run immediately after autocorrect-off.html, in the same
directory. This occurs because autocorrect-on.html attempts to verify that typing a period after "Tset" will
autocorrect to "Test"; however, the previous test disables autocorrection and types "Tset.", which causes UIKit
keyboard autocorrection code to add "Tset" to its lexicon. This means that we end up not autocorrecting to
"Test" in autocorrect-on.html.

In the past (r265376), to mitigate this, we set -[UIKeyboardImpl correctionLearningAllowed] to NO. However,
after what appears to be a recent TextInput change, this fails to prevent the test runner from learning "Tset"
while running autocorrect-off.html.

We take a more heavy-handed approach in this mitigation, and instead use swizzling to prevent UIKeyboardImpl
from notifying kbd when text candidates are "accepted".

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(overrideSyncInputManagerToAcceptedAutocorrection):
(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

Remove the failing test expectations.

  • platform/ios-wk2/TestExpectations:
12:50 PM Changeset in webkit [281575] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][IFC] Line spanning inline boxes should also be in the run list
​https://bugs.webkit.org/show_bug.cgi?id=228059
<rdar://problem/81077420>

Reviewed by Antti Koivisto.

Consider the following case:

<div><span>first line text<br>second line text<br>third line text</span></div>

Here is the list of runs we generate for the content above:

[inline box][first line text][hard linebreak][second line text][hard linebreak][third line text]

This list does not include the spanning inline boxes, i.e. the missing inline box on the second and the third line.
The integration code then looks inside the LineBox to find these spanning inline boxes (see createDisplayNonRootInlineBoxes)

In this patch we start including such spanning inline boxes in the run list.

[inline box][first line text][hard linebreak][inline box][second line text][hard linebreak][inline box][third line text]

This is also in preparation for making LineBox completely internal to the layout code.

  • layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

  • layout/formattingContexts/inline/InlineLineRun.h:

(WebCore::Layout::LineRun::isText const):
(WebCore::Layout::LineRun::isLineBreak const):
(WebCore::Layout::LineRun::isAtomicInlineLevelBox const):
(WebCore::Layout::LineRun::isInlineBox const):
(WebCore::Layout::LineRun::isRootInlineBox const):
(WebCore::Layout::LineRun::type const):
(WebCore::Layout::LineRun::hasContent const):
(WebCore::Layout::LineRun::isLineSpanning const):
(WebCore::Layout::LineRun::LineRun):

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const): Deleted.

  • layout/integration/LayoutIntegrationInlineContentBuilder.h:
12:40 PM Changeset in webkit [281574] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

[GLIB] Update baselines after r281419
​https://bugs.webkit.org/show_bug.cgi?id=229503

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-25

  • platform/gtk/fast/text/fixed-pitch-control-characters-expected.png:
  • platform/gtk/fast/text/fixed-pitch-control-characters-expected.txt: Added.
  • platform/gtk/fast/text/wide-zero-width-space-expected.png:
  • platform/gtk/fast/text/wide-zero-width-space-expected.txt:
  • platform/wpe/fast/text/fixed-pitch-control-characters-expected.txt: Added.
  • platform/wpe/fast/text/wide-zero-width-space-expected.txt:
11:59 AM Changeset in webkit [281573] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229509.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:49 AM Changeset in webkit [281572] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

[ iOS EWS ] editing/inserting/insert-paragraph-separator-with-html-elements-crash.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=228718

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/ipad/TestExpectations:
11:48 AM Changeset in webkit [281571] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Infinite loop in for...in after r280760
​https://bugs.webkit.org/show_bug.cgi?id=229493

Patch by Xan Lopez <Xan Lopez> on 2021-08-25
Reviewed by Yusuke Suzuki.

A missing instruction in the 32bit branch can potentially cause
infinite loops when using for-in. No new test, this is already
covered by (among others) LayoutTests/js/reserved-words.html.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileEnumeratorNextUpdateIndexAndMode):

11:46 AM Changeset in webkit [281570] by Russell Epstein
  • 8 edits in branches/safari-612.1.29-branch/Source

Versioning.

WebKit-7612.1.29.3

11:45 AM Changeset in webkit [281569] by commit-queue@webkit.org
  • 22 edits in trunk

Add onsecuritypolicyviolation on GlobalEventHandlers
​https://bugs.webkit.org/show_bug.cgi?id=229381

Patch by Sonia Singla <​ssingla@igalia.com> on 2021-08-25
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

  • web-platform-tests/html/dom/idlharness.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-windowless-body-expected.txt:
  • web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:

Source/WebCore:

onsecuritypolicyviolation attribute has been added to
GlobalEventHandlers by ​https://github.com/whatwg/html/pull/2651

This patch supports it.

Tests: imported/w3c/web-platform-tests/dom/idlharness.window.html

imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events.html
imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt
imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html

  • dom/GlobalEventHandlers.idl:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createEventHandlerNameMap):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
11:42 AM Changeset in webkit [281568] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1]imported/w3c/web-platform-tests/css/css-fonts/downloadable-font-in-iframe-print.html is a flaky image-only failure.
​https://bugs.webkit.org/show_bug.cgi?id=229506.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:34 AM Changeset in webkit [281567] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ BigSur arm64 EWS ] security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=229505

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:13 AM Changeset in webkit [281566] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

Added expectations for ios-wk2: security/contentSecurityPolicy/video-with-blob-url-allowed-by-media-src-star.html and security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html are flaky.
​https://bugs.webkit.org/show_bug.cgi?id=155196

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
10:59 AM Changeset in webkit [281565] by keith_miller@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Add for-in OwnStructureMode optimizations to LLInt
​https://bugs.webkit.org/show_bug.cgi?id=229038

Reviewed by Saam Barati.

This patch adds the optimizations we have for OwnStructureMode in
the Baseline to the LLInt. The patch also adds redundant self move
(i.e. move a, a) elimination to arm64. Finally, a bunch of the
property offset functions are now marked constexpr and return
intptr_t rather than size_t as the values can be negative.

There's also a minor fix to disable MSVC's signed to unsigned
cast warning for LLIntOffsetsExtractor as we don't care about
signedness for extracting constants.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileEnumeratorGetByVal):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_enumerator_get_by_val):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/arm64.rb:
  • offlineasm/generate_offset_extractor.rb:
  • runtime/Butterfly.h:

(JSC::Butterfly::indexOfPropertyStorage):

  • runtime/JSObject.h:

(JSC::offsetInButterfly):

  • runtime/PropertyOffset.h:

(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isValidOffset):
(JSC::isInlineOffset):
(JSC::isOutOfLineOffset):
(JSC::offsetInInlineStorage):
(JSC::offsetInOutOfLineStorage):
(JSC::offsetInRespectiveStorage):
(JSC::numberOfOutOfLineSlotsForMaxOffset):
(JSC::numberOfSlotsForMaxOffset):
(JSC::offsetForPropertyNumber):

10:46 AM Changeset in webkit [281564] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[IFC][Integration] Non-empty inline boxes may affect overflow scroll
​https://bugs.webkit.org/show_bug.cgi?id=229436

Reviewed by Antti Koivisto.

Use a more focused check whether an inline box (<span>) should contribute to scroll overflow.

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const):

  • layout/integration/LayoutIntegrationLine.h:

(WebCore::LayoutIntegration::NonRootInlineBox::NonRootInlineBox):
(WebCore::LayoutIntegration::NonRootInlineBox::hasScrollableContent const):
(WebCore::LayoutIntegration::NonRootInlineBox::canContributeToLineOverflow const): Deleted.

10:43 AM Changeset in webkit [281563] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk2 Debug] http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229502.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:42 AM Changeset in webkit [281562] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] storage/indexeddb/getdatabases.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229457

Unreviewed test gardening.

  • platform/win/TestExpectations:
10:37 AM Changeset in webkit [281561] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

[ MacOs iOS EWS ] imported/w3c/web-platform-tests/IndexedDB/serialize-sharedarraybuffer-throws.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229501

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
10:00 AM Changeset in webkit [281560] by Eric Hutchison
  • 4 edits in trunk/LayoutTests

Update test expectations for webrtc/datachannel/multiple-connections.html.
​https://bugs.webkit.org/show_bug.cgi?id=209878.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
9:47 AM Changeset in webkit [281559] by Russell Epstein
  • 1 copy in tags/Safari-612.1.29.2

Tag Safari-612.1.29.2.

9:42 AM Changeset in webkit [281558] by Russell Epstein
  • 8 edits in branches/safari-612.1.29-branch/Source

Versioning.

WebKit-7612.1.29.2

9:41 AM Changeset in webkit [281557] by Peng Liu
  • 8 edits in trunk

[Monterey] LayoutTest media/element-containing-pip-video-going-into-fullscreen.html is flaky timeout/crash
​https://bugs.webkit.org/show_bug.cgi?id=229453
<rdar://80346428>

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Fix a flaky test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
We need to initialize m_changingVideoFullscreenMode to false in the constructor.
Otherwise, it might be initialized to true and ignore requests to change video
presentation mode.

Source/WebKit:

  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::exitFullscreenWithoutAnimationToMode):
When the mock video presentation mode is enabled, the UI process still needs to
notify the Web process that the mode change has been done.

  • WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::didCleanupFullscreen):
Return immediately if the element is not in fullscreen to avoid
an assertion later in enterVideoFullscreenForVideoElement().

LayoutTests:

  • media/element-containing-pip-video-going-into-fullscreen.html:

Enable the mock video presentation mode for testing.

  • platform/mac-wk2/TestExpectations:
9:38 AM Changeset in webkit [281556] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

AX: Return radiobuttons part of ad-hoc radiogroups from AX search queries
​https://bugs.webkit.org/show_bug.cgi?id=229415

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-08-25
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/search-predicate-for-adhoc-radio-groups.html

Enable the ability for WebKit UI element accessibility searches to find
ad-hoc radiogroups. An ad-hoc radiogroup is a group of radiobuttons
connected only by name attribute, missing an appropriate role="radiogroup"
container.

  • accessibility/AccessibilityObject.cpp:

(WebCore::Accessibility::isRadioButtonInDifferentAdhocGroup): Added.
(WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex):
When searching for radiogroups, also return radiobuttons in different
ad-hoc radiogroups.

LayoutTests:

Add test to ensure WebKit UI element accessibility searches can find
ad-hoc radiogroups. An ad-hoc radiogroup is a group of radiobuttons
connected only by name attributes, missing an appropriate role="radiogroup"
container.

  • accessibility/mac/search-predicate-for-adhoc-radio-groups-expected.txt: Added.
  • accessibility/mac/search-predicate-for-adhoc-radio-groups.html: Added.
  • platform/mac-wk1/TestExpectations: Skip new test due to lack of

AccessibilityUIElement::domIdentifier implementation.

7:49 AM Changeset in webkit [281555] by commit-queue@webkit.org
  • 12 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r281523.
​https://bugs.webkit.org/show_bug.cgi?id=229494

broke cloop build

Reverted changeset:

"Add for-in OwnStructureMode optimizations to LLInt"
​https://bugs.webkit.org/show_bug.cgi?id=229038
​https://commits.webkit.org/r281523

6:50 AM Changeset in webkit [281554] by Kate Cheney
  • 5 edits in trunk/Source/WebCore

WebCrypto uses deprecated CCKeyDerivationHMac
​https://bugs.webkit.org/show_bug.cgi?id=229443
<rdar://problem/48896021>

Reviewed by Brent Fulgham.

Source/WebCore:

No new tests because no behavior change. This should be covered by
existing webrtc tests which use this functionality.

Replace deprecated CCKeyDerivationHMac with CCDeriveKey.

  • crypto/mac/CryptoUtilitiesCocoa.cpp:

(WebCore::keyDerivationHMAC):
(WebCore::deriveHDKFBits):

  • crypto/mac/CryptoUtilitiesCocoa.h:

Source/WebCore/PAL:

  • pal/spi/cocoa/CommonCryptoSPI.h:
3:11 AM Changeset in webkit [281553] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[LibWPE] Properly retrieve eglGetPlatformDisplayEXT entrypoint
​https://bugs.webkit.org/show_bug.cgi?id=229234

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2021-08-25
Reviewed by Carlos Garcia Campos.

  • platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:

(WebCore::PlatformDisplayLibWPE::initialize): Along with testing for the
EGL_EXT_platform_base extension, the eglGetPlatformDisplayEXT entrypoint
should be specifically looked up when that extension is present.
EGL_KHR_platform_base check-and-lookup should be done separately, but
should be removed in the near future since the KHR-type variant of this
extension doesn't actually exist.

3:07 AM Changeset in webkit [281552] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[GLIB] Mark wide gamut canvas tests as unsupported
​https://bugs.webkit.org/show_bug.cgi?id=229483

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-25

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.srgb-expected.txt: Removed.
2:45 AM Changeset in webkit [281551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add missing null check in AccessibilitySVGElement::inheritsPresentationalRole
​https://bugs.webkit.org/show_bug.cgi?id=228884

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-08-25
Reviewed by Darin Adler.

  • accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::inheritsPresentationalRole const): Check parent element is not nullptr before
trying to use it.

12:42 AM Changeset in webkit [281550] by commit-queue@webkit.org
  • 3 edits in trunk/Source/ThirdParty/ANGLE

ANGLE Metal index buffer restart range cache is could be maintained more consistently
​https://bugs.webkit.org/show_bug.cgi?id=227451

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-08-25
Reviewed by Kenneth Russell.

  • src/libANGLE/renderer/metal/BufferMtl.h:

(rx::BufferMtl::RestartRangeCache::RestartRangeCache):
Add optional<RestartRangeCache> which contains the ranges and
the index type used to build the ranges.

  • src/libANGLE/renderer/metal/BufferMtl.mm:

(rx::BufferMtl::markConversionBuffersDirty):
(rx::BufferMtl::clearConversionBuffers):
Invalidate the range cache when clearing conversion buffers.
Otherwise the cache would be left in inconsistent state vs.
the contents of the index buffer in cases of code like:
BufferMtl::setDataImpl() ...

if (...) {

markConversionBufferDirty();

} else {

clearConversionBuffers();

}

(rx::BufferMtl::getRestartIndices):

Note: See TracTimeline for information about the timeline view.