⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 12, 2021:

8:22 PM Changeset in webkit [282320] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

[Cocoa] Drawing the rounded system ui font into canvas causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=230187
<rdar://problem/81436658>

Reviewed by Wenson Hsieh.

Source/WebKit:

It turns out that r281792 didn't do the right thing. It was trying to differentiate between
system fonts and installed fonts by looking at various values in the font's attribute dictionary.
However, the right way to do this is to treat the dictionary as opaque, and let
kCTFontOptionsSystemUIFont do the heavy lifting to make sure the font round-trips properly.

Test: fast/text/canvas-fonts.html

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::createCTFont):
(IPC::findFontDescriptor):

LayoutTests:

  • fast/text/canvas-fonts-expected.txt: Added.
  • fast/text/canvas-fonts.html: Added.
7:14 PM Changeset in webkit [282319] by Alan Bujtas
  • 6 edits in trunk/Source/WebCore

[LFC][IFC] Add scrollable overflow to LineGeometry
​https://bugs.webkit.org/show_bug.cgi?id=230200

Reviewed by Antti Koivisto.

This is in preparation for making the integration line structure redundant.
(LineGeometry should be able to contain all the geometry information required for layout/paint/hittest).

  • layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::LineBoxBuilder::build):

  • layout/formattingContexts/inline/InlineLineGeometry.h:

(WebCore::Layout::LineGeometry::scrollableOverflow const):
(WebCore::Layout::LineGeometry::LineGeometry):

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::lineOverflowWidth):
(WebCore::LayoutIntegration::InlineContentBuilder::InlineContentBuilder):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

  • layout/integration/LayoutIntegrationInlineContentBuilder.h:
  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

1:52 PM Changeset in webkit [282318] by Fujii Hironori
  • 130 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

Rebaselined after r282256 and r282306.

  • platform/wincairo/css1/basic/contextual_selectors-expected.txt:
  • platform/wincairo/css1/basic/id_as_selector-expected.txt:
  • platform/wincairo/css1/basic/inheritance-expected.txt:
  • platform/wincairo/css1/box_properties/border-expected.txt:
  • platform/wincairo/css1/box_properties/border_bottom-expected.txt:
  • platform/wincairo/css1/box_properties/border_bottom_width-expected.txt:
  • platform/wincairo/css1/box_properties/border_left-expected.txt:
  • platform/wincairo/css1/box_properties/border_right_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_top-expected.txt:
  • platform/wincairo/css1/box_properties/clear_float-expected.txt:
  • platform/wincairo/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/wincairo/css1/box_properties/float_margin-expected.txt:
  • platform/wincairo/css1/box_properties/margin-expected.txt:
  • platform/wincairo/css1/box_properties/margin_bottom-expected.txt:
  • platform/wincairo/css1/box_properties/margin_top-expected.txt:
  • platform/wincairo/css1/box_properties/padding-expected.txt:
  • platform/wincairo/css1/box_properties/padding_bottom-expected.txt:
  • platform/wincairo/css1/box_properties/padding_top-expected.txt:
  • platform/wincairo/css1/box_properties/width-expected.txt:
  • platform/wincairo/css1/color_and_background/background_attachment-expected.txt:
  • platform/wincairo/css1/font_properties/font-expected.txt:
  • platform/wincairo/css1/font_properties/font_size-expected.txt:
  • platform/wincairo/css1/font_properties/font_weight-expected.txt:
  • platform/wincairo/css1/formatting_model/floating_elements-expected.txt:
  • platform/wincairo/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/wincairo/css1/pseudo/firstletter-expected.txt:
  • platform/wincairo/css1/pseudo/firstline-expected.txt:
  • platform/wincairo/css1/text_properties/vertical_align-expected.txt:
  • platform/wincairo/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/wincairo/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/wincairo/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
  • platform/wincairo/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
  • platform/wincairo/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/wincairo/fast/css/acid2-expected.txt:
  • platform/wincairo/fast/css/acid2-pixel-expected.txt:
  • platform/wincairo/fast/css/empty-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/fieldset-display-row-expected.txt:
  • platform/wincairo/fast/css/first-child-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/last-child-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/only-child-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/wincairo/fast/dynamic/013-expected.txt:
  • platform/wincairo/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
  • platform/wincairo/fast/line-grid/line-grid-contains-value-expected.txt:
  • platform/wincairo/fast/text/capitalize-boundaries-expected.txt:
  • platform/wincairo/fast/text/whitespace/024-expected.txt:
  • platform/wincairo/http/tests/misc/acid2-expected.txt:
  • platform/wincairo/http/tests/misc/acid2-pixel-expected.txt:
12:43 PM Changeset in webkit [282317] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (r280758): WebKit project won't open in Xcode 11.4

Unreviewed Xcode project fix.

  • WebKit.xcodeproj/project.pbxproj:
  • Change objectVersion back to 52. There was no need to make this change in the original patch, and other projects use even older values for objectVersion. Found by git bisect.
11:40 AM Changeset in webkit [282316] by Simon Fraser
  • 3 edits
    4 adds in trunk

Implement getClientRects() for SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=230197

Reviewed by Sam Weinig.

Source/WebCore:

For SVG elements we can just use absoluteQuads().

Test: svg/custom/getClientRects.xhtml

  • dom/Element.cpp:

(WebCore::Element::getClientRects):

LayoutTests:

  • svg/custom/getClientRects-expected.txt: Added.
  • svg/custom/getClientRects.xhtml: Added.

Sep 11, 2021:

6:41 PM Changeset in webkit [282315] by Simon Fraser
  • 8 edits in trunk

css/css-transforms/translate-getComputedStyle.html fails
​https://bugs.webkit.org/show_bug.cgi?id=230178

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

The interpolation test appears to regress, but do so because we now correctly output calc()
in computed style (we just serialize the calc incorrectly).

  • web-platform-tests/css/css-transforms/animation/translate-composition-expected.txt:
  • web-platform-tests/css/css-transforms/animation/translate-interpolation-expected.txt:
  • web-platform-tests/css/css-transforms/transforms-support-calc-expected.txt:
  • web-platform-tests/css/css-transforms/translate-getComputedStyle-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

​https://drafts.csswg.org/css-transforms-2/#propdef-translate says that the computed value of
the translate property is "the keyword none or a pair of computed <length-percentage> values
and an absolute length" and has a note saying "Note: The resolved value of the translate
property is the computed value, and thus getComputedStyle() includes percentage values in
its results." so implement that.

Tested by imported/w3c/web-platform-tests/css/css-transforms/translate-getComputedStyle.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTranslate):

5:32 PM Changeset in webkit [282314] by Wenson Hsieh
  • 8 edits in trunk/Source/WebKit

Remove support for -[WKWebView _needsSiteSpecificViewportQuirks]
​https://bugs.webkit.org/show_bug.cgi?id=230193

Reviewed by Tim Horton.

This SPI is no longer needed; for the brief moment it existed, it was only used to allow Safari's lowered bar
(which previously overlapped page content) to additionally apply obscured bottom insets on a handful of
webpages.

This method has no internal clients (including Safari).

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _needsSiteSpecificViewportQuirks]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessTermination):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

  • WebProcess/WebPage/WebPage.h:
12:24 PM Changeset in webkit [282313] by ddkilzer@apple.com
  • 6 edits
    1 add in trunk/Source

CFNotificationCenterAddObserver() should use weak observers
<​https://webkit.org/b/230168>
<rdar://problem/82987695>

Reviewed by Darin Adler.

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • Add CFNotificationCenterSPI.h to the project.
  • pal/spi/cf/CFNotificationCenterSPI.h: Add.

Source/WebKit:

  • UIProcess/API/Cocoa/WKWebView.mm:

(hardwareKeyboardAvailabilityChangedCallback):

  • Use RetainPtr to store observer for the duration of the function, and add an early return if it is nil.

(-[WKWebView _initializeWithConfiguration:]):

  • Use _CFNotificationObserverIsObjC to fix the bug.
  • Extract local variables and change notificationName cast to be ARC-ready. Remove notificationName from autoreleasePool.

(-[WKWebView dealloc]):

  • Extract local variable and change notificationName cast to be ARC-ready. Remove notificationName from autoreleasePool.

Source/WebKitLegacy/mac:

  • WebView/WebHTMLView.mm:

(hardwareKeyboardAvailabilityChangedCallback):

  • Modernize syntax for WeakObjCPtr constructor.

(-[WebHTMLView initWithFrame:]):

  • Use _CFNotificationObserverIsObjC to fix the bug.
  • Extract local variables and change notificationName cast to be ARC-ready. Remove notificationName from autoreleasePool.

(-[WebHTMLView dealloc]):

  • Extract local variable and change notificationName cast to be ARC-ready. Remove notificationName from autoreleasePool.
10:43 AM Changeset in webkit [282312] by Simon Fraser
  • 2 edits in trunk/Tools

Add an lldb summary provider for the WebCore::Length type
​https://bugs.webkit.org/show_bug.cgi?id=230185

Reviewed by Alan Bujtas.

Make Length types easier to visualize when debugging in lldb.

  • lldb/lldb_webkit.py:

(lldb_init_module):
(WebCoreLength_SummaryProvider):
(WebCoreLengthProvider):
(WebCoreLengthProvider.init):
(WebCoreLengthProvider.get_type):
(WebCoreLengthProvider.get_type_string):
(WebCoreLengthProvider.is_auto):
(WebCoreLengthProvider.is_undefined):
(WebCoreLengthProvider.is_calculated):
(WebCoreLengthProvider.is_fixed):
(WebCoreLengthProvider.is_percent):
(WebCoreLengthProvider.has_quirk):
(WebCoreLengthProvider.is_float):
(WebCoreLengthProvider.get_numeric_value):

9:10 AM Changeset in webkit [282311] by Antti Koivisto
  • 14 edits in trunk/Source/WebCore

Move rest of the LegacyInlineTextBox painting code to TextBoxPainter
​https://bugs.webkit.org/show_bug.cgi?id=230188

Reviewed by Alan Bujtas.

Move the remaining painting code.

  • rendering/LegacyEllipsisBox.h:
  • rendering/LegacyInlineBox.cpp:

(WebCore::LegacyInlineBox::selectionState const):
(WebCore::LegacyInlineBox::selectionState): Deleted.

  • rendering/LegacyInlineBox.h:
  • rendering/LegacyInlineFlowBox.cpp:

(WebCore::LegacyInlineFlowBox::selectionState const):
(WebCore::LegacyInlineFlowBox::selectionState): Deleted.

  • rendering/LegacyInlineFlowBox.h:
  • rendering/LegacyInlineTextBox.cpp:

(WebCore::LegacyInlineTextBox::selectionState const):
(WebCore::LegacyInlineTextBox::paint):
(WebCore::LegacyInlineTextBox::selectionState): Deleted.
(WebCore::createMarkedTextFromSelectionInBox): Deleted.

  • rendering/LegacyInlineTextBox.h:
  • rendering/LegacyRootInlineBox.cpp:

(WebCore::LegacyRootInlineBox::selectionState const):
(WebCore::LegacyRootInlineBox::selectionState): Deleted.

  • rendering/LegacyRootInlineBox.h:
  • rendering/MarkedText.cpp:

(WebCore::MarkedText::collectForHighlights):

  • rendering/MarkedText.h:
  • rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::TextBoxPainter):
(WebCore::TextBoxPainter::~TextBoxPainter):
(WebCore::TextBoxPainter::paint):
(WebCore::createMarkedTextFromSelectionInBox):
(WebCore::TextBoxPainter::paintBackground):
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
(WebCore::TextBoxPainter::paintForeground):
(WebCore::TextBoxPainter::paintDecoration):
(WebCore::TextBoxPainter::paintCompositionUnderline):
(WebCore::TextBoxPainter::paintPlatformDocumentMarker):
(WebCore::TextBoxPainter::computePaintRect):

  • rendering/TextBoxPainter.h:
7:59 AM Changeset in webkit [282310] by Russell Epstein
  • 1 copy in tags/Safari-612.1.29.41.3

Tag Safari-612.1.29.41.3.

7:56 AM Changeset in webkit [282309] by Russell Epstein
  • 8 edits in branches/safari-612.1.29.41-branch/Source

Versioning.

WebKit-7612.1.29.41.3

7:03 AM Changeset in webkit [282308] by Philippe Normand
  • 26 edits
    5 adds
    17 deletes in trunk/Tools/buildstream

[Flatpak SDK] Update to FDO 21.08
​https://bugs.webkit.org/show_bug.cgi?id=229918

Reviewed by Carlos Alberto Lopez Perez.

Highlights:

  • GCC 11.2
  • clang 12
  • ICU 69.1
  • Mesa as extension again
  • Ruby 3 (as side effect we now ship the webrick gem)
  • Our SDK branch number is now the same as FDO SDK
  • Some of our recipes no longer needed because maintained in FDO SDK

The actual runtime upgrade will happen after ​https://bugs.webkit.org/show_bug.cgi?id=229919
lands.

  • Pipfile: Update to bst 1.6.3.
  • Pipfile.lock: Ditto
  • elements/flatpak/sdk.bst: Remove rust extension as in parent SDK and re-add GL extension.
  • elements/freedesktop-sdk.bst: Bump to 21.08, remove vendored patches
  • elements/qt5/qtbase.bst: Fix libdrm dependency, we no longer ship this recipe.
  • elements/qt5/qtwayland.bst: Ditto.
  • elements/sdk-build-depends/libusb.bst: Removed.
  • elements/sdk-build-depends/rapidjson.bst: Fix build for GCC-11
  • elements/sdk-platform.bst: Add openssl in runtime, since it moved out of bootstrap in

parent SDK. Sync list of recipes, order alphabetically.

  • elements/sdk/cargo-c.bst: Switch to internal rustc component.
  • elements/sdk/gst-plugin-closedcaption.bst: Ditto.
  • elements/sdk/gst-plugin-dav1d.bst: Ditto.
  • elements/sdk/gst-plugins-bad.bst: Sync dependencies.
  • elements/sdk/gst-plugins-base.bst: Add a few build fix patches, sync dependencies.
  • elements/sdk/gst-plugins-good.bst: Ditto.
  • elements/sdk/gtk+-3.bst: Bump to 3.24.30 + build fix patch.
  • elements/sdk/icecc.bst: Bump to 1.3.1, sync dependencies.
  • elements/sdk/libdrm.bst: Removed.
  • elements/sdk/libgcrypt.bst: Bump to 1.8.8.
  • elements/sdk/libsoup.bst: Removed.
  • elements/sdk/libsoup3.bst: Sync dependencies.
  • elements/sdk/libzstd.bst: Removed.
  • elements/sdk/lzo2.bst: Removed.
  • elements/sdk/mesa.bst: Removed.
  • elements/sdk/monado.bst: Ditto.
  • elements/sdk/nghttp2.bst: Removed.
  • elements/sdk/openjpeg.bst: Removed.
  • elements/sdk/openxr.bst: Build with clang to avoid std filesystem issues with GCC.
  • elements/sdk/pycairo.bst: Removed.
  • elements/sdk/pygobject.bst: Removed.
  • elements/sdk/python2.bst: Bump to 2.7.18.
  • elements/sdk/ruby-webrick.bst: Added.
  • elements/sdk/sccache.bst: Switch to internal rustc component.
  • elements/sdk/xorg-server.bst: Sync dependencies.
  • elements/test-infra/httpd.bst: Ditto.
  • patches/fdo-0001-dav1d-Bump-to-version-0.8.2.patch: Removed.
  • patches/fdo-0001-libvpx-Enable-high-bit-depth-support.patch: Removed.
  • patches/fdo-0001-pango-Bump-to-1.47.patch: Removed.
  • patches/gst-plugins-base-0001-gst-don-t-use-volatile-to-mean-atomic.patch: Added.
  • patches/gst-plugins-base-0001-gstgl-Fix-build-when-Meson-0.58.0rc1.patch: Added.
  • patches/gst-plugins-good-0001-gst-don-t-use-volatile-to-mean-atomic.patch: Added.
  • patches/gtk-gcc11-build-fix.patch: Added.
  • patches/mesa/0001-i915-Prevent-invalid-framebuffer-usage.patch: Removed.
  • patches/mesa/0002-i965-Prevent-invalid-framebuffer-usage.patch: Removed.
  • patches/mesa/mesa_libdrm_deps.patch: Removed.
  • patches/nettle-no-debug.diff: Removed.
  • project.conf: Sync our branch with parent SDK.
4:34 AM Changeset in webkit [282307] by Philippe Normand
  • 30 edits
    6 adds in trunk

[GLIB] MediaSession is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=217991
<rdar://problem/70740119>

Reviewed by Michael Catanzaro.

.:

Enable MediaSession as an experimental build feature in CMake ports. The spec status is
currently Draft.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Implementation of a GLib MediaSessionManager, able to provide a MPRIS DBus service, so that
third-party host tools can query the media playback status and potentially emit remote
control commands as well.

Covered by media-session layout tests now unskipped.

  • Modules/mediasession/MediaImage.h:
  • Modules/mediasession/MediaSession.cpp:

(WebCore::logChannel):
(WebCore::logClassName):

  • Modules/mediasession/MediaSession.h:
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • platform/LogInitialization.cpp:

(WebCore::getLogChannel):

  • platform/PlatformScreen.h:
  • platform/RemoteCommandListener.cpp:

(WebCore::RemoteCommandListener::resetCreationFunction):

  • platform/SourcesGLib.txt:
  • platform/audio/PlatformMediaSessionManager.cpp:
  • platform/audio/glib/MediaSessionManagerGLib.cpp: Added.

(WebCore::PlatformMediaSessionManager::create):
(WebCore::MediaSessionManagerGLib::MediaSessionManagerGLib):
(WebCore::MediaSessionManagerGLib::~MediaSessionManagerGLib):
(WebCore::getCommand):
(WebCore::handleMethodCall):
(WebCore::getProperty):
(WebCore::handleGetProperty):
(WebCore::handleSetProperty):
(WebCore::MediaSessionManagerGLib::setupMpris):
(WebCore::MediaSessionManagerGLib::busAcquired):
(WebCore::MediaSessionManagerGLib::nameLost):
(WebCore::MediaSessionManagerGLib::beginInterruption):
(WebCore::MediaSessionManagerGLib::scheduleSessionStatusUpdate):
(WebCore::MediaSessionManagerGLib::sessionWillBeginPlayback):
(WebCore::MediaSessionManagerGLib::sessionDidEndRemoteScrubbing):
(WebCore::MediaSessionManagerGLib::addSession):
(WebCore::MediaSessionManagerGLib::removeSession):
(WebCore::MediaSessionManagerGLib::setCurrentSession):
(WebCore::MediaSessionManagerGLib::sessionWillEndPlayback):
(WebCore::MediaSessionManagerGLib::sessionStateChanged):
(WebCore::MediaSessionManagerGLib::clientCharacteristicsChanged):
(WebCore::MediaSessionManagerGLib::sessionCanProduceAudioChanged):
(WebCore::MediaSessionManagerGLib::addSupportedCommand):
(WebCore::MediaSessionManagerGLib::removeSupportedCommand):
(WebCore::MediaSessionManagerGLib::nowPlayingEligibleSession):
(WebCore::MediaSessionManagerGLib::updateNowPlayingInfo):
(WebCore::MediaSessionManagerGLib::getPlaybackStatusAsGVariant):
(WebCore::MediaSessionManagerGLib::getActiveSessionPosition):
(WebCore::MediaSessionManagerGLib::dispatch):
(WebCore::MediaSessionManagerGLib::emitPropertiesChanged):

  • platform/audio/glib/MediaSessionManagerGLib.h: Added.

(WebCore::MediaSessionManagerGLib::nameAcquired):
(WebCore::MediaSessionManagerGLib::getMetadataAsGVariant const):
(WebCore::MediaSessionManagerGLib::providePresentingApplicationPIDIfNecessary):

  • platform/glib/ApplicationGLib.cpp: Added.

(WebCore::setApplicationName):
(WebCore::getApplicationName):
(WebCore::setApplicationID):
(WebCore::getApplicationID):

  • platform/glib/ApplicationGLib.h: Added.
  • platform/glib/RemoteCommandListenerGLib.cpp: Added.

(WebCore::RemoteCommandListenerGLib::create):
(WebCore::RemoteCommandListenerGLib::updateSupportedCommands):
(WebCore::RemoteCommandListenerGLib::RemoteCommandListenerGLib):

  • platform/glib/RemoteCommandListenerGLib.h: Added.
  • platform/graphics/ImageFrame.h:
  • platform/graphics/ImageOrientation.h:

Source/WebKit:

Pass Application name and unique ID from the UIProcess to the WebProcess in WPE and GTK
ports. The Bubblewrap launcher was also adapted to allow DBus MPRIS name ownership in the
sandboxed WebProcess.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsConstructed):

  • UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::applicationId):
(WebKit::createFlatpakInfo):
(WebKit::XDGDBusProxyLauncher::launch):

  • UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • WebProcess/glib/WebProcessGLib.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

GRefPtr template specialization for GDBusNodeInfo.

  • wtf/glib/GRefPtr.cpp:

(WTF::refGPtr):
(WTF::derefGPtr):

  • wtf/glib/GRefPtr.h:

LayoutTests:

  • platform/glib/TestExpectations: Unskip media-session tests.
Note: See TracTimeline for information about the timeline view.