Context Navigation

← Previous Period
Next Period →

Timeline

Sep 15, 2021:

10:48 PM Changeset in webkit [282488] by Russell Epstein

8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7612.2.7

9:39 PM Changeset in webkit [282487] by commit-queue@webkit.org

29 edits in trunk

Fixes for build-webkit --minimal
https://bugs.webkit.org/show_bug.cgi?id=229780

Patch by Philip Chimento <pchimento@igalia.com> on 2021-09-15
Reviewed by Fujii Hironori.

Remove ENABLE_INTERSECTION_OBSERVER build-time option. This option is
quite broken if you try to disable it.

Source/cmake/OptionsFTW.cmake:
Source/cmake/OptionsMac.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Covered by existing tests.

Remove ENABLE_INTERSECTION_OBSERVER build-time option. This option is
quite broken if you try to disable it.

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::intersectionObserversInitialUpdateTimerFired):
(WebCore::Document::scheduleRenderingUpdate):

dom/Document.h:

(WebCore::Document::intersectionObserverDataIfExists):

dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::didMoveToNewDocument):

dom/Element.h:
dom/ElementRareData.cpp:
dom/ElementRareData.h:

(WebCore::ElementRareData::setIntersectionObserverData):

page/IntersectionObserver.cpp:
page/IntersectionObserver.h:
page/IntersectionObserver.idl:
page/IntersectionObserverCallback.h:
page/IntersectionObserverCallback.idl:
page/IntersectionObserverEntry.cpp:
page/IntersectionObserverEntry.h:
page/IntersectionObserverEntry.idl:
page/Page.cpp:

(WebCore::Page::updateRendering):
(WebCore::operator<<):

page/Page.h:
testing/Internals.cpp:

(WebCore::Internals::numberOfIntersectionObservers const):

testing/Internals.h:
testing/Internals.idl:

Source/WTF:

Remove ENABLE_INTERSECTION_OBSERVER build-time option. This option is
quite broken if you try to disable it.

Scripts/Preferences/WebPreferencesExperimental.yaml:
wtf/PlatformEnableCocoa.h:

Tools:

Remove ENABLE_INTERSECTION_OBSERVER build-time option. This option is
quite broken if you try to disable it.

Scripts/webkitperl/FeatureList.pm: Remove intersection-observer option

8:06 PM Changeset in webkit [282486] by mmaxfield@apple.com

3 edits in trunk/Source/WebCore

Fix Xcode build

Unreviewed.

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:

6:40 PM Changeset in webkit [282485] by commit-queue@webkit.org

2 edits in trunk/Tools

Fixes for build-webkit --minimal
https://bugs.webkit.org/show_bug.cgi?id=229780

Patch by Philip Chimento <pchimento@igalia.com> on 2021-09-15
Reviewed by Fujii Hironori.

Remove the fast-jit-permissions, legacy-css-vendor-prefixes,
webassembly-streaming-api, and webgpu options. These don't seem to exist
anymore within the codebase and print an error if they are used.

Scripts/webkitperl/FeatureList.pm:

6:08 PM Changeset in webkit [282484] by commit-queue@webkit.org

282 edits
2 copies
12 adds in trunk

Add IDL skeleton for SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=230293

Patch by Alex Christensen <achristensen@webkit.org> on 2021-09-15
Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

web-platform-tests/content-security-policy/connect-src/connect-src-eventsource-allowed.sub-expected.txt:
web-platform-tests/content-security-policy/form-action/form-action-src-blocked.sub-expected.txt:
web-platform-tests/content-security-policy/frame-src/frame-src-same-document.sub-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worklet-audio-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worklet-audio-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/worklet-audio-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-self/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worklet-audio-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/worklet-audio-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/script-tag.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/script-tag.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-classic.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-classic.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-import-data.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-import.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-import.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-module.http-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-module.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/worklet-audio-import-data.https-expected.txt:
web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/worklet-audio.https-expected.txt:
web-platform-tests/content-security-policy/inside-worker/sharedworker-connect-src.sub-expected.txt:
web-platform-tests/content-security-policy/inside-worker/sharedworker-report-only.sub-expected.txt:
web-platform-tests/content-security-policy/inside-worker/sharedworker-script-src.sub-expected.txt:
web-platform-tests/content-security-policy/reporting-api/reporting-api-works-on-frame-ancestors.https.sub-expected.txt:
web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-expected.txt:
web-platform-tests/content-security-policy/sandbox/shared-worker-sandbox-expected.txt:
web-platform-tests/content-security-policy/script-src/worker-data-set-timeout.sub-expected.txt:
web-platform-tests/content-security-policy/script-src/worker-importscripts.sub-expected.txt:
web-platform-tests/content-security-policy/script-src/worker-set-timeout.sub-expected.txt:
web-platform-tests/fetch/api/cors/data-url-shared-worker-expected.txt:
web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https-expected.txt:
web-platform-tests/fetch/metadata/sharedworker.https.sub-expected.txt:
web-platform-tests/fetch/sec-metadata/sharedworker.tentative.https.sub-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window-expected.txt:
web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker.https-expected.txt:
web-platform-tests/html/browsers/offline/no-appcache-in-shared-workers-historical.https-expected.txt:
web-platform-tests/html/cross-origin-embedder-policy/cache-storage-reporting-shared-worker.https-expected.txt:
web-platform-tests/html/cross-origin-embedder-policy/credentialless/reporting-subresource-corp.tentative.https-expected.txt:
web-platform-tests/html/cross-origin-embedder-policy/credentialless/shared-worker.tentative.https-expected.txt:
web-platform-tests/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https-expected.txt:
web-platform-tests/html/cross-origin-embedder-policy/reporting-subresource-corp.https-expected.txt:
web-platform-tests/html/cross-origin-embedder-policy/shared-workers.https-expected.txt:
web-platform-tests/html/cross-origin-embedder-policy/worker-inheritance.sub.https-expected.txt:
web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/nested-sharedworker-success.https-expected.txt:
web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.https-expected.txt:
web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/utf-8-expected.txt:
web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/windows-1252-expected.txt:
web-platform-tests/html/semantics/scripting-1/the-script-element/evaluation-order-1-nothrow-sharedworker-expected.txt:
web-platform-tests/html/semantics/scripting-1/the-script-element/evaluation-order-1-sharedworker-expected.txt:
web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-nothrow-sharedworker-expected.txt:
web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-sharedworker-expected.txt:
web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-2-import-sharedworker-expected.txt:
web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-3-dynamic-sharedworker-expected.txt:
web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.sharedworker-expected.txt:
web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/Worker_Self_Origin-expected.txt:
web-platform-tests/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/no-referrer-when-downgrade/http-rp/same-origin/http-http/shared-worker/no-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/no-referrer-when-downgrade/meta-referrer/same-origin/http-http/shared-worker/no-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/no-referrer/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/no-referrer/http-rp/same-origin/http-http/shared-worker/no-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/no-referrer/meta-referrer/same-origin/http-http/shared-worker/no-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-http/shared-worker/no-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-http/shared-worker/no-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/origin/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/origin/http-rp/same-origin/http-http/shared-worker/no-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/origin/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/origin/meta-referrer/same-origin/http-http/shared-worker/no-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/same-origin/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/same-origin/http-rp/same-origin/http-http/shared-worker/no-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/same-origin/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/same-origin/meta-referrer/same-origin/http-http/shared-worker/no-redirect/same-origin-insecure.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/same-insecure.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin-when-cross-origin/http-rp/same-origin/http-http/shared-worker/no-redirect/same-insecure.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/same-insecure.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin-when-cross-origin/meta-referrer/same-origin/http-http/shared-worker/no-redirect/same-insecure.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin/http-rp/same-origin/http-http/shared-worker/no-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/strict-origin/meta-referrer/same-origin/http-http/shared-worker/no-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/unsafe-url/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/unsafe-url/http-rp/same-origin/http-http/shared-worker/no-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/unsafe-url/meta-referrer/same-origin/http-http/shared-worker/no-redirect/generic.http-expected.txt:
web-platform-tests/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/shared-worker/keep-origin-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/unset-referrer-policy/http-rp/same-origin/http-http/shared-worker/no-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/shared-worker/keep-origin-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/referrer-policy/unset-referrer-policy/meta-referrer/same-origin/http-http/shared-worker/no-redirect/insecure-protocol.http-expected.txt:
web-platform-tests/service-workers/service-worker/clients-get-client-types.https-expected.txt:
web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt:
web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
web-platform-tests/wasm/serialization/module/broadcastchannel-success-and-failure-expected.txt:
web-platform-tests/wasm/serialization/module/window-sharedworker-failure-expected.txt:
web-platform-tests/webmessaging/broadcastchannel/workers-expected.txt:
web-platform-tests/workers/SharedWorker-constructor-expected.txt:
web-platform-tests/workers/SharedWorker-detach-frame-in-error-event-expected.txt:
web-platform-tests/workers/SharedWorker-exception-expected.txt:
web-platform-tests/workers/SharedWorker-exception-propagation-expected.txt:
web-platform-tests/workers/SharedWorker-script-error-expected.txt:
web-platform-tests/workers/SharedWorker-simple-expected.txt:
web-platform-tests/workers/SharedWorkerPerformanceNow-expected.txt:
web-platform-tests/workers/SharedWorker_blobUrl-expected.txt:
web-platform-tests/workers/SharedWorker_dataUrl-expected.txt:
web-platform-tests/workers/abrupt-completion-expected.txt:
web-platform-tests/workers/baseurl/alpha/importScripts-in-sharedworker-expected.txt:
web-platform-tests/workers/baseurl/alpha/xhr-in-sharedworker-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/connect-event-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/dummy-name-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/dummy-shared-worker-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/empty-name-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/global-members-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/interface-objects-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/name-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/no-arguments-ctor-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/null-arguments-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/number-arguments-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/port-onmessage-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/port-properties-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/port-readonly-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/same-origin-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/setting-port-members-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/undefined-arguments-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/unexpected-global-properties-expected.txt:
web-platform-tests/workers/constructors/SharedWorker/unresolvable-url-expected.txt:
web-platform-tests/workers/data-url-shared-expected.txt:
web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/name/getting-expected.txt:
web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/name/setting-expected.txt:
web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/onconnect-expected.txt:
web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-sharedworker-expected.txt:
web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt:
web-platform-tests/workers/modules/shared-worker-import-csp-expected.txt:
web-platform-tests/workers/modules/shared-worker-import-data-url-cross-origin-expected.txt:
web-platform-tests/workers/modules/shared-worker-import-data-url.window-expected.txt:
web-platform-tests/workers/modules/shared-worker-import-failure-expected.txt:
web-platform-tests/workers/modules/shared-worker-import-meta-expected.txt:
web-platform-tests/workers/modules/shared-worker-import-referrer-expected.txt:
web-platform-tests/workers/modules/shared-worker-import.window-expected.txt:
web-platform-tests/workers/modules/shared-worker-options-credentials-expected.txt:
web-platform-tests/workers/modules/shared-worker-options-type-expected.txt:
web-platform-tests/workers/modules/shared-worker-parse-error-failure-expected.txt:
web-platform-tests/workers/name-property-expected.txt:
web-platform-tests/workers/semantics/encodings/002-expected.txt:
web-platform-tests/workers/semantics/encodings/004-expected.txt:
web-platform-tests/workers/semantics/multiple-workers/001-expected.txt:
web-platform-tests/workers/semantics/multiple-workers/004-expected.txt:
web-platform-tests/workers/semantics/multiple-workers/008-expected.txt:
web-platform-tests/workers/semantics/multiple-workers/exposure.any-expected.txt:
web-platform-tests/workers/semantics/reporting-errors/001-expected.txt:
web-platform-tests/workers/semantics/reporting-errors/002-expected.txt:
web-platform-tests/workers/semantics/reporting-errors/003-expected.txt:
web-platform-tests/workers/semantics/reporting-errors/004-expected.txt:
web-platform-tests/workers/semantics/run-a-worker/002-expected.txt:
web-platform-tests/workers/semantics/run-a-worker/003-expected.txt:
web-platform-tests/workers/semantics/structured-clone/shared-expected.txt:
web-platform-tests/workers/semantics/xhr/003-expected.txt:
web-platform-tests/workers/semantics/xhr/004-expected.txt:
web-platform-tests/workers/semantics/xhr/006-expected.txt:
web-platform-tests/workers/shared-worker-from-blob-url.window-expected.txt:
web-platform-tests/workers/shared-worker-name-via-options-expected.txt:
web-platform-tests/workers/shared-worker-options-mismatch-expected.txt:
web-platform-tests/workers/shared-worker-parse-error-failure-expected.txt:
web-platform-tests/xhr/open-url-redirected-sharedworker-origin-expected.txt:

Source/WebCore:

CMakeLists.txt:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
bindings/js/WebCoreJSClientData.h:
bindings/scripts/preprocess-idls.pl:
dom/EventTargetFactory.in:
workers/SharedWorker.cpp: Added.

(WebCore::SharedWorker::SharedWorker):
(WebCore::SharedWorker::port const):
(WebCore::SharedWorker::scriptExecutionContext const):
(WebCore::SharedWorker::eventTargetInterface const):

workers/SharedWorker.h: Added.
workers/SharedWorker.idl: Added.
workers/SharedWorkerGlobalScope.cpp: Added.

(WebCore::SharedWorkerGlobalScope::name const):
(WebCore::SharedWorkerGlobalScope::close):

workers/SharedWorkerGlobalScope.h: Added.

(isType):

workers/SharedWorkerGlobalScope.idl: Added.
workers/Worker.cpp:

(WebCore::Worker::Worker):
(WebCore::Worker::create):

workers/Worker.h:
workers/Worker.idl:
workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::isSharedWorkerGlobalScope const):

workers/WorkerOptions.h: Copied from Source/WebCore/workers/Worker.idl.
workers/WorkerOptions.idl: Copied from Source/WebCore/workers/Worker.idl.

Source/WTF:

Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

6:02 PM Changeset in webkit [282483] by Chris Dumez

6 edits in trunk

Implement network process crash recovery for BroadcastChannel
https://bugs.webkit.org/show_bug.cgi?id=230236

Reviewed by Alex Christensen.

Source/WebKit:

Have the WebBroadcastChannelRegistry register its BroadcastChannels with the network
process after a network process crash. This is useful so that cross-WebProcess
communication can keep happening via existing BroadcastChannel after a network process
crash.

WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp:

(WebKit::WebBroadcastChannelRegistry::networkProcessCrashed):

WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::networkProcessConnectionClosed):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(-[BroadcastChannelMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):

5:26 PM Changeset in webkit [282482] by timothy_horton@apple.com

2 edits in trunk/Tools

Remove the "core.webKitBranchBuild" prompt from setup-git-clone
https://bugs.webkit.org/show_bug.cgi?id=230323

Reviewed by Jonathan Bedard.

Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone.execute):
"core.webKitBranchBuild" is an advanced feature and also doesn't work
at all for Apple folks (leading to a myriad of bizarro build problems).
Folks who want it can use the documentation (UsingGitWithWebKit on the Wiki),
but in general, until it's well supported, it's best if we don't encourage it.

5:03 PM Changeset in webkit [282481] by Eric Hutchison

2 edits in trunk/LayoutTests/imported/w3c

[Catalina Release] imported/w3c/web-platform-tests/css/css-transforms/crashtests/transform-marquee-resize-div-image-001.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=230327.

Unreviewed re-baseline.

web-platform-tests/css/css-transforms/crashtests/transform-marquee-resize-div-image-001-expected.txt:

4:50 PM Changeset in webkit [282480] by Simon Fraser

13 edits
3 moves in trunk/Source/WebCore

Rename ScrollController to ScollingEffectsController
https://bugs.webkit.org/show_bug.cgi?id=230312

Reviewed by Tim Horton.

ScrollController is about rubberbanding, momentum etc, which are scrolling "effects",
so rename to ScrollingEffectsController.

ScrollController is the name I want to ultimately use for ScrollAnimator.

PlatformMac.cmake:
Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
page/EventHandler.cpp:

(WebCore::EventHandler::scrollableAreaCanHandleEvent):

page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::startAnimationCallback):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::stopAnimationCallback):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):

platform/KeyboardScrollingAnimator.cpp:

(WebCore::KeyboardScrollingAnimator::KeyboardScrollingAnimator):

platform/KeyboardScrollingAnimator.h:
platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::startAnimationCallback):
(WebCore::ScrollAnimator::stopAnimationCallback):

platform/ScrollAnimator.h:
platform/ScrollingEffectsController.cpp: Renamed from Source/WebCore/platform/ScrollController.cpp.

(WebCore::ScrollingEffectsController::ScrollingEffectsController):
(WebCore::ScrollingEffectsController::animationCallback):
(WebCore::ScrollingEffectsController::startOrStopAnimationCallbacks):
(WebCore::ScrollingEffectsController::beginKeyboardScrolling):
(WebCore::ScrollingEffectsController::stopKeyboardScrolling):
(WebCore::ScrollingEffectsController::setIsAnimatingRubberBand):
(WebCore::ScrollingEffectsController::setIsAnimatingScrollSnap):
(WebCore::ScrollingEffectsController::setIsAnimatingKeyboardScrolling):
(WebCore::ScrollingEffectsController::usesScrollSnap const):
(WebCore::ScrollingEffectsController::setSnapOffsetsInfo):
(WebCore::ScrollingEffectsController::snapOffsetsInfo const):
(WebCore::ScrollingEffectsController::activeScrollSnapIndexForAxis const):
(WebCore::ScrollingEffectsController::setActiveScrollSnapIndexForAxis):
(WebCore::ScrollingEffectsController::setNearestScrollSnapIndexForAxisAndOffset):
(WebCore::ScrollingEffectsController::adjustScrollDestination):
(WebCore::ScrollingEffectsController::updateActiveScrollSnapIndexForClientOffset):
(WebCore::ScrollingEffectsController::resnapAfterLayout):
(WebCore::ScrollingEffectsController::updateKeyboardScrollingAnimatingState):
(WebCore::ScrollingEffectsController::~ScrollingEffectsController):
(WebCore::ScrollingEffectsController::stopAllTimers):
(WebCore::ScrollingEffectsController::scrollPositionChanged):
(WebCore::ScrollingEffectsController::updateScrollSnapAnimatingState):
(WebCore::ScrollingEffectsController::updateRubberBandAnimatingState):

platform/ScrollingEffectsController.h: Renamed from Source/WebCore/platform/ScrollController.h.
platform/mac/ScrollingEffectsController.mm: Renamed from Source/WebCore/platform/mac/ScrollController.mm.

(WebCore::ScrollingEffectsController::~ScrollingEffectsController):
(WebCore::ScrollingEffectsController::stopAllTimers):
(WebCore::ScrollingEffectsController::handleWheelEvent):
(WebCore::ScrollingEffectsController::wheelDeltaBiasingTowardsVertical):
(WebCore::ScrollingEffectsController::directionFromEvent):
(WebCore::ScrollingEffectsController::updateRubberBandAnimatingState):
(WebCore::ScrollingEffectsController::scrollPositionChanged):
(WebCore::ScrollingEffectsController::isUserScrollInProgress const):
(WebCore::ScrollingEffectsController::isRubberBandInProgress const):
(WebCore::ScrollingEffectsController::isScrollSnapInProgress const):
(WebCore::ScrollingEffectsController::stopRubberbanding):
(WebCore::ScrollingEffectsController::startRubberbandAnimation):
(WebCore::ScrollingEffectsController::stopSnapRubberbandAnimation):
(WebCore::ScrollingEffectsController::snapRubberBand):
(WebCore::ScrollingEffectsController::shouldRubberBandInHorizontalDirection const):
(WebCore::ScrollingEffectsController::shouldRubberBandInDirection const):
(WebCore::ScrollingEffectsController::isRubberBandInProgressInternal const):
(WebCore::ScrollingEffectsController::updateRubberBandingState):
(WebCore::ScrollingEffectsController::updateRubberBandingEdges):
(WebCore::ScrollingEffectsController::shouldOverrideMomentumScrolling const):
(WebCore::ScrollingEffectsController::scheduleStatelessScrollSnap):
(WebCore::ScrollingEffectsController::statelessSnapTransitionTimerFired):
(WebCore::ScrollingEffectsController::startDeferringWheelEventTestCompletionDueToScrollSnapping):
(WebCore::ScrollingEffectsController::stopDeferringWheelEventTestCompletionDueToScrollSnapping):
(WebCore::ScrollingEffectsController::processWheelEventForScrollSnap):
(WebCore::ScrollingEffectsController::updateGestureInProgressState):
(WebCore::ScrollingEffectsController::startScrollSnapAnimation):
(WebCore::ScrollingEffectsController::stopScrollSnapAnimation):
(WebCore::ScrollingEffectsController::updateScrollSnapAnimatingState):

4:13 PM Changeset in webkit [282479] by Eric Hutchison

2 edits in trunk/LayoutTests

Update test expectations for security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html.
https://bugs.webkit.org/show_bug.cgi?id=229505.

Unreviewed test gardening .

TestExpectations:

3:18 PM Changeset in webkit [282478] by sbarati@apple.com

47 edits in trunk/Source/JavaScriptCore

Move some profiling to UnlinkedCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=230078
<rdar://problem/82947571>

Reviewed by Yusuke Suzuki.

This patch moves ValueProfiles and ArrayProfiles for non-call opcodes into
UnlinkedCodeBlock. This way, the data is shared between the linked CodeBlocks
of the same UnlinkedCodeBlock. The profiling bet here is that when the same code
runs in a different global object, it largely runs in the same way. We've made
this same bet in other ways with our profiling, and it largely makes sense
to do for ValueProfile and ArrayProfile since they both hold global object
independent data.

Because ArrayProfiles are now shared between CodeBlocks, the existing m_usesOriginalArrayStructures
bit is slightly harder to track now, since the ArrayProfile may see inputs from a different
global object, an array may be an original array in one lexical global object,
but not another. So we now track when an ArrayProfile sees a different global
object than the lexical global object, and when we observe exits in the DFG,
we propagate that bit to the m_usesOriginalArrayStructures bit.

This patch also makes it so we no longer hold the CodeBlock lock when
processing ValueProfiles and ArrayProfiles. We now allow multiple compiler
threads to race against each other when updating these profiles. This is fine.
It may end up with incomplete data in the profiles, but it won't corrupt them.

This patch also makes it so we finalized visited UnlinkedCodeBlocks to finalize
their value profiles. We no longer do that work inside CodeBlock for the
ValueProfiles that UnlinkedCodeBlock owns. This also means that we have to
WriteBarrier UnlinkedCodeBlock when executing in the LLInt, Baseline, and
other areas, such as OSR exit, and in the GC when a CodeBlock was executing.
That way we're guaranteed to visit the UnlinkedCodeBlock, add it to the
visited set, and then finalize it at the end of GC.

This patch also makes it so that inside CodeBlock::finishCreation, we finish
linking before we do anything that can throw an exception. It's not valid to
finalize a CodeBlock that isn't linked.

This was measured as a 0.5-1% speedup on Speedometer2.

bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):

bytecode/ArrayProfile.h:

(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::observedArrayModes const):
(JSC::ArrayProfile::mayInterceptIndexedAccesses const):
(JSC::ArrayProfile::mayStoreToHole const):
(JSC::ArrayProfile::outOfBounds const):
(JSC::ArrayProfile::usesOriginalArrayStructures const):
(JSC::ArrayProfile::setDoesNotUseOriginalArrayStructures):
(JSC::ArrayProfile::observedDifferentGlobalObject const):

bytecode/BytecodeList.rb:
bytecode/BytecodeOperandsForCheckpoint.h:

(JSC::valueProfileForImpl):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::initializeTemplateObjects):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::visitChildren):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::getArrayProfile):
(JSC::CodeBlock::updateAllValueProfilePredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllArrayPredictions):
(JSC::CodeBlock::tryGetValueProfileForBytecodeIndex):
(JSC::CodeBlock::valueProfilePredictionForBytecodeIndex):

bytecode/CodeBlock.h:

(JSC::CodeBlock::offsetOfUnlinkedCodeBlock):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::metadata):

bytecode/CodeBlockInlines.h:

(JSC::CodeBlock::forEachValueProfile):
(JSC::CodeBlock::forEachArrayProfile):

bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::hasAnyExitsAt const):

bytecode/DFGExitProfile.h:
bytecode/GetByIdMetadata.h:

(JSC::GetByIdModeMetadata::setArrayLengthMode):

bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
(JSC::LazyOperandValueProfileParser::prediction const):

bytecode/MetadataTable.cpp:

(JSC::DeallocTable::withOpcodeType):

bytecode/MetadataTable.h:

(JSC::MetadataTable::get):
(JSC::MetadataTable::forEach):
(JSC::MetadataTable::getWithoutAligning):
(JSC::MetadataTable::getImpl): Deleted.

bytecode/Opcode.h:
bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::visitChildrenImpl):
(JSC::UnlinkedCodeBlock::allocateSharedProfiles):
(JSC::UnlinkedCodeBlock::finalizeUnconditionally):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::hasAnyExitsAt const):
(JSC::UnlinkedCodeBlock::hasAnyExitsAt):
(JSC::UnlinkedCodeBlock::valueProfile):
(JSC::UnlinkedCodeBlock::arrayProfile):
(JSC::UnlinkedCodeBlock::numValueProfiles const):
(JSC::UnlinkedCodeBlock::numArrayProfiles const):

bytecode/UnlinkedCodeBlockGenerator.cpp:

(JSC::UnlinkedCodeBlockGenerator::finalize):

bytecode/UnlinkedMetadataTable.cpp:

(JSC::UnlinkedMetadataTable::finalize):

bytecode/UnlinkedMetadataTable.h:

(JSC::UnlinkedMetadataTable::isFinalized):
(JSC::UnlinkedMetadataTable::hasMetadata):

bytecode/UnlinkedMetadataTableInlines.h:

(JSC::UnlinkedMetadataTable::numEntries):

bytecode/ValueProfile.h:

(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::clearBuckets):
(JSC::ValueProfileBase::briefDescription):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(JSC::ValueProfile::offsetOfFirstBucket):
(JSC::ValueProfileBase::classInfo const): Deleted.

dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):

dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::withSpeculationFromProfile const):
(JSC::DFG::ArrayMode::withProfile const):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::handleVarargsInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::handlePutByVal):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):

dfg/DFGGraph.h:
dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):

dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

heap/CodeBlockSetInlines.h:

(JSC::CodeBlockSet::iterateViaSubspaces):

heap/Heap.cpp:

(JSC::Heap::finalizeMarkedUnconditionalFinalizers):
(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::runEndPhase):
(JSC::Heap::addCoreConstraints):

jit/JIT.h:
jit/JITInlines.h:

(JSC::JIT::emitValueProfilingSiteIfProfiledOpcode):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_enter):
(JSC::JIT::op_enter_handlerGenerator):

jit/JITOperations.cpp:

(JSC::putByValOptimize):
(JSC::directPutByValOptimize):
(JSC::JSC_DEFINE_JIT_OPERATION):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::generateGetByValSlowCase):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emitSlow_op_in_by_val):
(JSC::JIT::generateOpGetFromScopeThunk):
(JSC::JIT::slow_op_get_from_scopeGenerator):
(JSC::JIT::emit_op_enumerator_get_by_val):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emitSlow_op_in_by_val):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::performLLIntGetByID):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::getByVal):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

runtime/CachedTypes.cpp:

(JSC::CachedCodeBlock::numValueProfiles const):
(JSC::CachedCodeBlock::numArrayProfiles const):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::CachedCodeBlock<CodeBlockType>::encode):

runtime/CommonSlowPaths.cpp:

(JSC::iteratorNextTryFastImpl):
(JSC::JSC_DEFINE_COMMON_SLOW_PATH):

runtime/JSScope.cpp:

(JSC::abstractAccess):
(JSC::JSScope::abstractResolve):

runtime/VM.cpp:
runtime/VM.h:

(JSC::VM::forEachUnlinkedCodeBlockSpace):
(JSC::VM::forEachCodeBlockSpace): Deleted.

3:12 PM Changeset in webkit [282477] by Patrick Angle

2 edits in trunk/Source/WebInspectorUI

Web Inspector: TreeOutline should return early when failing to find an ancestor while populating the tree
https://bugs.webkit.org/show_bug.cgi?id=230287

Reviewed by Devin Rousso.

When an ancestor can not be found, we should return to prevent additional work (which will fail) from being done.

UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.findTreeElement):

2:51 PM Changeset in webkit [282476] by Ayumi Kojima

3 edits in trunk/LayoutTests

[ iOS Mac Debug ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coop-navigated-history-popup.https.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=230268

Unreviewed test gardening.

platform/ios-wk2/TestExpectations: Removed [ Debug ]
platform/mac-wk2/TestExpectations: Updated bug number

2:49 PM Changeset in webkit [282475] by Patrick Angle

2 edits in trunk/Source/WebInspectorUI

Web Inspector: DOMTreeUpdater doesn't complete deferred updating/clear updated lists when a node isn't found in the tree
https://bugs.webkit.org/show_bug.cgi?id=230289

Reviewed by Devin Rousso.

Instead of an early return when a tree element can't be found, we should continue on to the next updated node
and finish out by clearing the collections of updated nodes, otherwise a node that will never be findable again
will cause extra work to be done on every update.

UserInterface/Views/DOMTreeUpdater.js:

(WI.DOMTreeUpdater.prototype._updateModifiedNodes):

2:43 PM Changeset in webkit [282474] by Robert Jenner

2 edits in trunk/LayoutTests

[ Monterey wk2 ] imported/w3c/web-platform-tests/service-workers/service-worker/import-scripts-cross-origin.https.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=228200

Unreviewed test gardening. Removing no longer needed test expectation.

platform/mac-wk2/TestExpectations:

2:41 PM Changeset in webkit [282473] by Ayumi Kojima

2 edits in trunk/LayoutTests

[ BigSur ] fast/canvas/canvas-draw-canvas-on-canvas-flushing-order.html is a flaky image failure.
https://bugs.webkit.org/show_bug.cgi?id=230313

Unreviewed test gardening.

platform/mac/TestExpectations:

2:02 PM Changeset in webkit [282472] by Devin Rousso

2 edits in trunk/Source/WebCore

Unreviewed, build fix after r282464

Modules/applepay/ApplePayDetailsUpdateData.h:

(WebCore::ApplePayDetailsUpdateData::encode const):
(WebCore::ApplePayDetailsUpdateData::decodeData):

1:59 PM Changeset in webkit [282471] by clopez@igalia.com

36 edits
13 adds
2 deletes in trunk/LayoutTests

[GTK][WPE] Gardening of tests: report new failures and rebaseline tests.

Unreviewed test gardening.

Mark some expected new failures and also rebaseline several tests.

rebaseline after r282356

imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle.html
imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em.html
imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em.html

rebaseline after r282341

imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-empty-inline.html
imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-shy.html
imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline.html
imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline.html

rebaseline after r282143

imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

rebaseline after r282357

imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html

rebaseline after r282441

imported/w3c/web-platform-tests/resize-observer/svg.html

rebaseline after r282306

tables/mozilla/bugs/bug39209.html
tables/mozilla/bugs/bug44505.html
tables/mozilla/marvin/x_col_valign_baseline.xml
tables/mozilla/marvin/x_colgroup_valign_baseline.xml
tables/mozilla_expected_failures/bugs/bug1725.html
fast/forms/file/file-input-direction.html
fast/multicol/span/span-as-immediate-child-property-removal.html
fast/replaced/width100percent-button.html
fast/table/mozilla-bug10296-vertical-align-1.html
fast/table/mozilla-bug10296-vertical-align-2.html
fast/table/rowspan-paint-order-vertical.html

platform/glib/TestExpectations:
platform/glib/imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-shy-expected.txt: Added.
platform/gtk/TestExpectations:
platform/gtk/fast/forms/file/file-input-direction-expected.txt:
platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
platform/gtk/fast/replaced/width100percent-button-expected.txt:
platform/gtk/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
platform/gtk/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-empty-inline-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt: Removed.
platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
platform/gtk/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
platform/wpe/fast/forms/file/file-input-direction-expected.txt: Added.
platform/wpe/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
platform/wpe/fast/replaced/width100percent-button-expected.txt:
platform/wpe/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
platform/wpe/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
platform/wpe/fast/table/rowspan-paint-order-vertical-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt: Removed.
platform/wpe/tables/mozilla/bugs/bug39209-expected.txt:
platform/wpe/tables/mozilla/bugs/bug44505-expected.txt:
platform/wpe/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
platform/wpe/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
platform/wpe/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:

1:43 PM Changeset in webkit [282470] by ysuzuki@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, build failure on Big Sur

Whether encoder / decoder are used is relying on the Internal code expanded by the macro.

Modules/applepay/ApplePayDetailsUpdateData.h:

(WebCore::ApplePayDetailsUpdateData::encode const):
(WebCore::ApplePayDetailsUpdateData::decodeData):

1:18 PM Changeset in webkit [282469] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Avoid GCC warnings introduced in r282125
https://bugs.webkit.org/show_bug.cgi?id=230154

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-09-15
Reviewed by Fujii Hironori.

Yusuke suggested casting to UChar to avoid -Wswitch-out-of-range. This works!

Also, avoid -Wredundant-move by removing one unnecessary WTFMove.

runtime/ISO8601.cpp:

(JSC::ISO8601::parseTimeZoneBracketedAnnotation):
(JSC::ISO8601::canBeTimeZone):
(JSC::ISO8601::parseTimeZone):

1:17 PM Changeset in webkit [282468] by ysuzuki@apple.com

6 edits
2 adds in trunk

[JSC] Optimize leaf object creation in JSON.parse
https://bugs.webkit.org/show_bug.cgi?id=230298

Reviewed by Keith Miller.

JSTests:

microbenchmarks/json-parse-leaf-object.js: Added.

Source/JavaScriptCore:

This patch optimizes JSON.parse.

Use table in isJSONWhiteSpace.
Extract primitive value creation as parsePrimitiveValue function to use it in different place.
Add leaf-object creation fast path. Previously, when creating a leaf-object from JSON.parse we are too generic and jumping around the code. Instead we add a fast path that does not perform unnecessary operations and code gets tight.

It offers 3-4% improvement in microbenchmarks.

ToT Patched

vanilla-es2015-babel-webpack-todomvc-json-parse

104.7169+-0.1113 ^{101.4836+-0.2168} definitely 1.0319x faster

flight-todomvc-json-parse 53.9074+-0.0957 ^{52.1347+-0.0802} definitely 1.0340x faster
vanilla-es2015-todomvc-json-parse 104.9373+-0.1631 ^{101.4978+-0.1073} definitely 1.0339x faster
vanilla-todomvc-json-parse 79.1330+-0.0963 ^{76.7568+-0.1606} definitely 1.0310x faster

This offers 0.2% improvement in Speedometer2.

| subtest | ms | ms | b / a | pValue (significance using False Discovery Rate) |

| Elm-TodoMVC |116.860000 |116.825000 |0.999700 | 0.901070 |
| VueJS-TodoMVC |24.658333 |24.763333 |1.004258 | 0.571728 |
| EmberJS-TodoMVC |126.666667 |126.335000 |0.997382 | 0.289517 |
| BackboneJS-TodoMVC |48.435000 |48.523333 |1.001824 | 0.455638 |
| Preact-TodoMVC |17.585000 |17.368333 |0.987679 | 0.247658 |
| AngularJS-TodoMVC |129.576667 |129.398333 |0.998624 | 0.625634 |
| Vanilla-ES2015-TodoMVC |62.746667 |62.241667 |0.991952 | 0.000019 (significant) |
| Inferno-TodoMVC |63.741667 |63.495000 |0.996130 | 0.448861 |
| Flight-TodoMVC |78.021667 |77.306667 |0.990836 | 0.087137 |
| Angular2-TypeScript-TodoMVC |39.823333 |39.923333 |1.002511 | 0.736279 |
| VanillaJS-TodoMVC |50.073333 |49.791667 |0.994375 | 0.136495 |
| jQuery-TodoMVC |221.300000 |221.586667 |1.001295 | 0.418008 |
| EmberJS-Debug-TodoMVC |340.145000 |339.965000 |0.999471 | 0.691490 |
| React-TodoMVC |85.698333 |85.650000 |0.999436 | 0.761586 |
| React-Redux-TodoMVC |140.510000 |140.785000 |1.001957 | 0.285922 |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |60.928333 |60.500000 |0.992970 | 0.000069 (significant) |

a mean = 262.15844
b mean = 262.72261
pValue = 0.0428052487
(Bigger means are better.)
1.002 times better
Results ARE significant

runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::makeIdentifier):
(JSC::isJSONWhiteSpace):
(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::parsePrimitiveValue):
(JSC::LiteralParser<CharType>::parse):

runtime/LiteralParser.h:

LayoutTests:

js/dom/JSON-parse-expected.txt:

1:06 PM Changeset in webkit [282467] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, skip a layout worklet test as it is not supported.

TestExpectations:

1:02 PM Changeset in webkit [282466] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, skip a couple of SharedWorker tests.

These tests are flaky and we do not support SharedWorkers at the moment.

TestExpectations:

12:52 PM Changeset in webkit [282465] by commit-queue@webkit.org

2 edits in trunk/Tools

Cache resource paths in run-jsc-stress-tests for speedup
https://bugs.webkit.org/show_bug.cgi?id=230263

Patch by Geza Lore <gezalore@gmail.com> on 2021-09-15
Reviewed by Adrian Perez de Castro.

A large portion of the serial startup time of run-jsc-stress-tests is
just re-computing file system paths of bundle resources over and over
again. Cache results for a 40% speedup of the test enumeration phase.

Scripts/run-jsc-stress-tests:

11:37 AM Changeset in webkit [282464] by Devin Rousso

14 edits in trunk/Source

[Payment Request] Clean up some WKA hooks
https://bugs.webkit.org/show_bug.cgi?id=230182
<rdar://problem/78824639>

Reviewed by Tim Horton.

Source/WebCore:

Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
(WebCore::merge):

Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::convertAndValidate):

testing/MockPaymentCoordinator.h:
testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeShippingMethodSelection):
(WebCore::MockPaymentCoordinator::completeShippingContactSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):
(WebCore::MockPaymentCoordinator::completeCouponCodeChange):
(WebCore::MockPaymentCoordinator::merge):
Instead of using #define, create actual functions so that the code in WKA is cleaner.

Modules/applepay/ApplePayRequestBase.h:
Modules/applepay/ApplePayRequestBase.cpp:

(WebCore::convertAndValidate):
Remove unnecessary WKA hooks.

Modules/applepay/PaymentSummaryItems.h:
Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm:

(WebCore::platformRecurringSummaryItem): Added.
(WebCore::platformDeferredSummaryItem): Added.
(WebCore::platformSummaryItem): Added.
(WebCore::toPKPaymentSummaryItem): Deleted.
Expose functions that convert ApplePayLineItem to PKPaymentSummaryItem (and subclasses).

Source/WebCore/PAL:

pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

Platform/cocoa/PaymentAuthorizationPresenter.mm:

(WebKit::merge):
(WebKit::PaymentAuthorizationPresenter::completePaymentMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingContactSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completeCouponCodeChange):

Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::merge):
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
Instead of using #define, create actual functions so that the code in WKA is cleaner.

11:06 AM Changeset in webkit [282463] by Ziran Sun

7 edits in trunk

[css-grid] Overflow should be computed with the actual logical bottom
https://bugs.webkit.org/show_bug.cgi?id=226981

Reviewed by Javier Fernandez.

When computing the overflow area in the grid container, we need to obtain the result of ClientLogicalBottom
function. This value should be retrieved after computing the actual logical height rather than before.

For grid, width/height of the overflow rect should be the width/height of the grid area of the items rather than
the width/height of the container block. As per https://github.com/w3c/csswg-drafts/issues/3653, child's margins
along with padding should contribute to the scrollable overflow area.

Test: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-overflow-002.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clientLogicalBottomAfterRepositioning):
(WebCore::RenderBlock::computeOverflow):

rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalLeftForChild const):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::clientLogicalBottomAfterRepositioning): Deleted.

rendering/RenderFlexibleBox.h:
rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

11:05 AM Changeset in webkit [282462] by Alan Coon

1 copy in tags/Safari-613.1.1.5

Tag Safari-613.1.1.5.

10:57 AM Changeset in webkit [282461] by Alan Coon

8 edits in branches/safari-613.1.1-branch/Source

Versioning.

WebKit-7613.1.1.5

10:52 AM Changeset in webkit [282460] by Alan Coon

1 copy in tags/Safari-613.1.1.4

Tag Safari-613.1.1.4.

10:07 AM Changeset in webkit [282459] by youenn@apple.com

2 edits in trunk/Source/WebCore

imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html is failing after https://trac.webkit.org/changeset/282445/webkit
https://bugs.webkit.org/show_bug.cgi?id=230308

Reviewed by Eric Carlson.

Covered by no longer failing test.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnDataChannel):
We need to create the data channel object at the time we fire the event,
so that JS can transfer it synchronously in the same event loop.
This got regressed as we were creating the data channel, enqueuing a task to fire the data channel event.

9:55 AM Changeset in webkit [282458] by Russell Epstein

8 edits in branches/safari-613.1.1-branch/Source

Versioning.

WebKit-7613.1.1.4

9:08 AM Changeset in webkit [282457] by Martin Robinson

5 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-writing-modes.html depends on scrollbar placement and width
https://bugs.webkit.org/show_bug.cgi?id=230305

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Modify this test so that scrollbars are not shown, which should make it independent
of scrollbar size and placement.

web-platform-tests/css/css-position/sticky/position-sticky-writing-modes-expected.html:
web-platform-tests/css/css-position/sticky/position-sticky-writing-modes.html:

LayoutTests:

TestExpectations: Unskip newly passing test.

8:23 AM Changeset in webkit [282456] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[WPE][GTK] Silence -Wswitch warning enumeration value ‘ExceededProcessCountLimit’ not handled in switch
https://bugs.webkit.org/show_bug.cgi?id=230280

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-09-15
Reviewed by Darin Adler.

UIProcess/API/glib/WebKitNavigationClient.cpp:

7:57 AM Changeset in webkit [282455] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

AX: Move platform specific code for isolated tree mode to the platform files
https://bugs.webkit.org/show_bug.cgi?id=230301
<rdar://problem/83138024>

Unreviewed follow up after r282450.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): Remove PreventKeyboardDOMEventDispatch property set that
I forgot in r282450, since it's now done in initializePlatformProperties().

7:53 AM Changeset in webkit [282454] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.34/Source/WebCore

Merge r282453 - Fix size calculation in ImageBufferCairoImageSurfaceBackend::create()
https://bugs.webkit.org/show_bug.cgi?id=229365

Reviewed by Don Olmstead.

platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::calculateSafeBackendSize): Check the result of
cairo_format_stride_for_width() and the multiplication doesn't overflow.
(WebCore::ImageBufferCairoImageSurfaceBackend::create): Use tryFastCalloc() instead of tryFastZeroedMalloc().

7:52 AM Changeset in webkit [282453] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Fix size calculation in ImageBufferCairoImageSurfaceBackend::create()
https://bugs.webkit.org/show_bug.cgi?id=229365

Reviewed by Don Olmstead.

platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

7:21 AM Changeset in webkit [282452] by Antti Koivisto

2 edits in trunk/Source/WebCore

[LFC][Integration] TextBoxSelectableRange::additionalLengthAtEnd miscomputed
https://bugs.webkit.org/show_bug.cgi?id=230306

Reviewed by Alan Bujtas.

It should be non-zero only if the run contains a hyphen. This doesn't yet affect
anything, but it will.

layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::selectableRange const):

6:46 AM Changeset in webkit [282451] by Aditya Keerthi

5 edits
2 adds in trunk

[iOS] Search inputs with '-webkit-appearance: textfield' should have a textfield background color
https://bugs.webkit.org/show_bug.cgi?id=229883
rdar://82146288

Reviewed by Tim Horton.

Source/WebCore:

In iOS 15, search inputs have a gray background color by default.
Some sites, such as booking.com, request that the input appear like
a textfield, by specifying '-webkit-appearance: textfield', over the
default 'searchfield'. This request was previously ignored, but there
was no observable difference since search inputs and text inputs had
the same default styling before iOS 15.

Now that the default styling is different, the appearance should be
honored, so that sites get the background color they expect.

Test: fast/forms/ios/form-control-refresh/search/textfield-appearance-background.html

rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustTextFieldStyle const):

Exclude any elements that have a textfield appearance by default from
the background color adjustment, so that their background color can be
customized.

LayoutTests:

fast/forms/ios/form-control-refresh/search/textfield-appearance-background-expected.txt: Added.
fast/forms/ios/form-control-refresh/search/textfield-appearance-background.html: Added.
platform/ios/fast/css/input-search-padding-expected.txt: Rebaseline.

6:44 AM Changeset in webkit [282450] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

AX: Move platform specific code for isolated tree mode to the platform files
https://bugs.webkit.org/show_bug.cgi?id=230301
<rdar://problem/83138024>

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-09-15
Reviewed by Adrian Perez de Castro.

Add missing ifdefs in the headers and move the mac specific code to mac files.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::isolatedTreeRootObject):
(WebCore::AXObjectCache::clientSupportsIsolatedTree): Deleted.
(WebCore::AXObjectCache::isIsolatedTreeEnabled): Deleted.
(WebCore::AXObjectCache::initializeSecondaryAXThread): Deleted.
(WebCore::AXObjectCache::usedOnAXThread): Deleted.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::children):
(WebCore::AXIsolatedObject::preventKeyboardDOMEventDispatch const): Deleted.
(WebCore::AXIsolatedObject::setPreventKeyboardDOMEventDispatch): Deleted.
(WebCore::AXIsolatedObject::convertRectToPlatformSpace const): Deleted.

accessibility/isolatedtree/AXIsolatedObject.h:
accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:

(WebCore::AXIsolatedObject::initializePlatformProperties):
(WebCore::AXIsolatedObject::convertRectToPlatformSpace const):
(WebCore::AXIsolatedObject::preventKeyboardDOMEventDispatch const):
(WebCore::AXIsolatedObject::setPreventKeyboardDOMEventDispatch):

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::clientSupportsIsolatedTree):
(WebCore::AXObjectCache::isIsolatedTreeEnabled):
(WebCore::AXObjectCache::initializeSecondaryAXThread):
(WebCore::AXObjectCache::usedOnAXThread):

6:33 AM Changeset in webkit [282449] by Antti Koivisto

10 edits in trunk/Source/WebCore

[Layout][Integration] Remove unnecessary Run typedef
https://bugs.webkit.org/show_bug.cgi?id=230303

Reviewed by Alan Bujtas.

Use Layout::Run directly instead of LayoutIntegration::Run.

layout/integration/LayoutIntegrationInlineContent.cpp:

(WebCore::LayoutIntegration:: const):
(WebCore::LayoutIntegration::InlineContent::indexForRun const):
(WebCore::LayoutIntegration::InlineContent::firstRunForLayoutBox const):

layout/integration/LayoutIntegrationInlineContent.h:

(WebCore::LayoutIntegration::InlineContent::lineForRun const):

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paintTextRunUsingPhysicalCoordinates):

layout/integration/LayoutIntegrationLineLayout.h:
layout/integration/LayoutIntegrationPagination.cpp:

(WebCore::LayoutIntegration::makeAdjustedContent):

layout/integration/LayoutIntegrationRunIterator.cpp:

(WebCore::LayoutIntegration::textRunFor):

layout/integration/LayoutIntegrationRunIterator.h:
layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::run const):

rendering/TextPainter.cpp:

(WebCore::TextPainter::clearGlyphDisplayLists):

5:20 AM Changeset in webkit [282448] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

AX: Remove AXCoreObject::containsText
https://bugs.webkit.org/show_bug.cgi?id=230299
<rdar://problem/83134668>

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-09-15
Reviewed by Adrian Perez de Castro.

It's only used by isAccessibilityTextSearchMatch() in AccessibilityObject.cpp. We can move the implementation
there and avoid to include TextIterator.h in AccessibilityObjectInterface.h.

accessibility/AccessibilityObject.cpp:

(WebCore::Accessibility::isAccessibilityTextSearchMatch):

accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::containsText const): Deleted.

accessibility/isolatedtree/AXIsolatedTree.cpp:
accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
page/mac/ServicesOverlayController.mm:

5:09 AM Changeset in webkit [282447] by Martin Robinson

9 edits in trunk

offsetLeft on display:inline element in vertical-rl parent can return a negative number
https://bugs.webkit.org/show_bug.cgi?id=230217

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt:
web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt:

Source/WebCore:

No new tests. This is covered by imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-inline.html.

rendering/RenderInline.cpp:

(WebCore::RenderInline::firstInlineBoxTopLeft const): When calculating offsetLeft and offsetTop instead
of using topLeft unconditionally, use LegacyInlineBox::locationIncludingFlipping which takes into
account writing mode.

LayoutTests:

TestExpectations: Unskip a newly passing test.
platform/ios-simulator-wk2/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt:
platform/ios-simulator-wk2/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt:

2:53 AM Changeset in webkit [282446] by timothy_horton@apple.com

2 edits
1 delete in trunk/Source/WebKit

Remove the "Replace WebKitAdditions in Framework Headers" build phase
https://bugs.webkit.org/show_bug.cgi?id=230300

Reviewed by Wenson Hsieh.

WebKit.xcodeproj/project.pbxproj:
mac/replace-webkit-additions-includes.py: Removed.

As Wenson pointed out in bug 230198, this build phase is currently unused.
It's also wasting a quarter of the WebKit-only null build time, so let's
just remove it and hope we never need it again (but if we do, it's in the history!).
This gets us down to 11 seconds on the same benchmark mentioned in r282367.

2:11 AM Changeset in webkit [282445] by youenn@apple.com

25 edits in trunk

Use event queue to fire RTCPeerConnection events
https://bugs.webkit.org/show_bug.cgi?id=229944
<rdar://problem/83045723>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/RTCPeerConnection-createOffer-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-explicit-rollback-iceGatheringState-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation-stress-glare-linear.https-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation-stress-glare.https-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt:
web-platform-tests/webrtc/no-media-call-expected.txt:

Source/WebCore:

Instead of using a dedicated task queue in peer connection to handle the suspend cases,
we now rely on queueTask to do this.
We do this for both promise resolution and dispatching events.

This allows to better order some promise resolutions and some event dispatching as well.
Previously, we were sometimes resolving a promise, then scheduling a task to fire an event.
The promise resolution callbacks in that case are expected to run first, in the same event loop,
then the event listeners are supposed to be executed.
It was not happening since we were not in the event loop, so the event was fired then the promise resolution callbacks executed.

Drive-by fix to reject createOffer/createAnswer in case signaling state is not correct as per
https://w3c.github.io/webrtc-pc/#dfn-creating-an-offer and https://w3c.github.io/webrtc-pc/#dfn-creating-an-answer.
Drive-by fix to not fire open event when data channel is closing as per https://w3c.github.io/webrtc-pc/#announcing-a-data-channel-as-open.

Update mock backend to correctly report signaling state.

Covered by updated tests.
Some tests are still flaky which might mean we still have some races that need to be investigated.

Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createOfferFailed):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::createAnswerFailed):
(WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setLocalDescriptionFailed):
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setRemoteDescriptionFailed):
(WebCore::PeerConnectionBackend::iceGatheringStateChanged):
(WebCore::PeerConnectionBackend::newICECandidate):
(WebCore::PeerConnectionBackend::doneGatheringCandidates):

Modules/mediastream/PeerConnectionBackend.h:
Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::didChangeReadyState):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::resume):
(WebCore::RTCPeerConnection::setSignalingState):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::updateConnectionState):
(WebCore::RTCPeerConnection::processIceTransportStateChange):
(WebCore::RTCPeerConnection::updateNegotiationNeededFlag):
(WebCore::RTCPeerConnection::scheduleEvent):

Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnDataChannel):
(WebCore::toRTCIceGatheringState):
(WebCore::LibWebRTCMediaEndpoint::OnIceGatheringChange):

testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnection::signaling_state):

testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt:
fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt:
fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
webrtc/peerconnection-page-cache-long.html:

The peer connection object might not be in disconnected state synchronously in
pageshow event handler. In that case, we should wait for disconnected state.

1:19 AM Changeset in webkit [282444] by youenn@apple.com

9 edits in trunk/Source

Migrate to libwebrtc non-racy setRemoteDescription/setLocalDescription variants
https://bugs.webkit.org/show_bug.cgi?id=230262

Reviewed by Darin Adler.

Source/ThirdParty/libwebrtc:

Configurations/libwebrtc.iOS.exp:
Configurations/libwebrtc.iOSsim.exp:
Configurations/libwebrtc.mac.exp:

Source/WebCore:

We were using the old versions of libwebrtc SetLocalDescription/SetRemoteDescription.
As per the header file, these versions are potentially racy.
This patch migrates to new versions of the same API which in addition take more modern parameters instead of raw pointers.
We also modernize a bit the code by using methods manipulating unique_ptr instead of raw pointers.
Drive-by fix: Add support for getting back to new for ICE gathering state. This was missing and without it,
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-explicit-rollback-iceGatheringState.html would time out.
Update mock to implement the new method versions.

Covered by existing tests.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::sessionDescriptionType):
(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription):
(WebCore::LibWebRTCMediaEndpoint::OnIceGatheringChange):

Modules/mediastream/libwebrtc/LibWebRTCObservers.h:
testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnection::SetLocalDescription):
(WebCore::MockLibWebRTCPeerConnection::SetRemoteDescription):

testing/MockLibWebRTCPeerConnection.h:

12:26 AM Changeset in webkit [282443] by Said Abou-Hallawa

3 edits
2 adds in trunk

Linear gradient sometimes is drawn incorrectly and sometimes hangs
https://bugs.webkit.org/show_bug.cgi?id=230145
<rdar://82428383>

Reviewed by Simon Fraser.

Source/WebCore:

Gradient::paint() has a few flaws:

1) We have to use atan2() instead of acos() to get the angle of the vector

(p0, p1) in the correct quadrant. acos() returns an angle between [0, pi].

2) The order in the case of 'repeat' and 'reflect' should be the following:

-- Move the points forward towards the bounding box.
-- Draw gradient and move the points forward till they are not

intersecting the bounding box.

-- Move the points backward towards the bounding box.
-- Draw gradient and move the points backward till they are not

intersecting the bounding box.

Tests: svg/gradients/gradient-flipped-start-end-points-expected.svg

svg/gradients/gradient-flipped-start-end-points.svg

platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::paint):

LayoutTests:

svg/gradients/gradient-flipped-start-end-points-expected.svg: Added.
svg/gradients/gradient-flipped-start-end-points.svg: Added.

12:19 AM Changeset in webkit [282442] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

CSSFontFaceSrcValue.cssText should be quoted consistently with other browsers
https://bugs.webkit.org/show_bug.cgi?id=230273

Reviewed by Darin Adler.

Addressing post-review comments.

fast/css/font-face-src-parsing-expected.txt:
fast/css/font-face-src-parsing.html:

Sep 14, 2021:

11:16 PM Changeset in webkit [282441] by Simon Fraser

23 edits
4 copies
4 adds
1 delete in trunk

Implement the borderBoxSize/contentBoxSize parts of ResizeObserver
https://bugs.webkit.org/show_bug.cgi?id=230242

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

New results. WebKit seems to fire the "resize loop error" more than
other browsers, which seems to be an issue with the spec[1].

[1] https://github.com/w3c/csswg-drafts/issues/6610

web-platform-tests/resize-observer/idlharness.window-expected.txt:
web-platform-tests/resize-observer/observe-expected.txt:
web-platform-tests/resize-observer/svg-expected.txt:

Source/WebCore:

The Resize Observer spec has been updated to allow authors to observe
"content-box", "border-box" and "device-pixel-content-box". Add support
for the first two, adding ResizeObserverSize, ResizeObserverBoxOptions and
ResizeObserverOptions per spec.

ResizeObserverEntry also contains borderBoxSize and contentBoxSize now,
so support that.

Add some helpers to make it easier to get box logical sizes.

"device-pixel-content-box" is not yet supported because it's expensive to compute[2].

[1] https://drafts.csswg.org/resize-observer
[2] https://github.com/w3c/csswg-drafts/issues/6608

Tested by WPT.

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
page/ResizeObservation.cpp:

(WebCore::ResizeObservation::create):
(WebCore::ResizeObservation::ResizeObservation):
(WebCore::ResizeObservation::updateObservationSize):
(WebCore::ResizeObservation::computeObservedSizes const):
(WebCore::ResizeObservation::computeContentRect const):
(WebCore::ResizeObservation::borderBoxSize const):
(WebCore::ResizeObservation::contentBoxSize const):
(WebCore::ResizeObservation::snappedContentBoxSize const):
(WebCore::ResizeObservation::elementSizeChanged const):
(WebCore::ResizeObservation::~ResizeObservation): Deleted.
(WebCore::ResizeObservation::computeObservedSize const): Deleted.

page/ResizeObservation.h:

(WebCore::ResizeObservation::observedBox const):

page/ResizeObserver.cpp:

(WebCore::ResizeObserver::observe):
(WebCore::ResizeObserver::gatherObservations):
(WebCore::ResizeObserver::deliverObservations):

page/ResizeObserver.h:
page/ResizeObserver.idl:
page/ResizeObserverBoxOptions.h: Added.
page/ResizeObserverBoxOptions.idl: Copied from Source/WebCore/page/ResizeObserverEntry.idl.
page/ResizeObserverEntry.h:

(WebCore::ResizeObserverEntry::create):
(WebCore::ResizeObserverEntry::contentRect const):
(WebCore::ResizeObserverEntry::borderBoxSize const):
(WebCore::ResizeObserverEntry::contentBoxSize const):
(WebCore::ResizeObserverEntry::ResizeObserverEntry):
(WebCore::ResizeObserverEntry::m_contentBoxSizes):

page/ResizeObserverEntry.idl:
page/ResizeObserverOptions.h: Added.
page/ResizeObserverOptions.idl: Copied from Source/WebCore/page/ResizeObserverEntry.idl.
page/ResizeObserverSize.h: Added.

(WebCore::ResizeObserverSize::create):
(WebCore::ResizeObserverSize::inlineSize const):
(WebCore::ResizeObserverSize::blockSize const):
(WebCore::ResizeObserverSize::ResizeObserverSize):

page/ResizeObserverSize.idl: Copied from Source/WebCore/page/ResizeObserverEntry.idl.
rendering/RenderBox.h:

(WebCore::RenderBox::logicalSize const):
(WebCore::RenderBox::borderBoxLogicalSize const):
(WebCore::RenderBox::contentLogicalSize const):

rendering/RenderElement.h:

(WebCore::adjustLayoutSizeForAbsoluteZoom):

rendering/style/RenderStyle.h:

(WebCore::adjustLayoutSizeForAbsoluteZoom):

LayoutTests:

Give macOS a platform expectation for this test since its results seem to be the odd one out.

platform/ios/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt: Removed.
platform/mac/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt.

11:14 PM Changeset in webkit [282440] by commit-queue@webkit.org

4 edits in trunk

Fix button-min-width.html
https://bugs.webkit.org/show_bug.cgi?id=229984

Patch by Rob Buis <rbuis@igalia.com> on 2021-09-14
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-sizing/button-min-width-expected.txt:

Source/WebCore:

Do not use theme min-width/min-height values unless
it is bigger than the actual CSS property values.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

11:01 PM Changeset in webkit [282439] by calvaris@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer][EME] Accomodate cbcs as cipher-mode instead of mime
https://bugs.webkit.org/show_bug.cgi?id=230265

Reviewed by Philippe Normand.

In https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1013
it was decided that there should not be x-cbcs as mime type but
rather x-cenc with cbcs as cipher-mode.

Fly-by change, we will return GST_FLOW_NOT_SUPPORTED when we get
skip and crypt cbcs encryption scheme.

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(transformInPlace):

10:38 PM Changeset in webkit [282438] by commit-queue@webkit.org

4 edits in trunk

imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change* tests fail
https://bugs.webkit.org/show_bug.cgi?id=203508

Patch by Rob Buis <rbuis@igalia.com> on 2021-09-14
Reviewed by Simon Fraser.

Source/WebCore:

For replaced elements like images, non specified min/max logical widths are a
reason for re-layout after intrinsic size change (for example min-width: min-content).

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):

LayoutTests:

TestExpectations:

10:09 PM Changeset in webkit [282437] by Russell Epstein

1 copy in tags/Safari-612.2.4.1.2

Tag Safari-612.2.4.1.2.

10:08 PM Changeset in webkit [282436] by Russell Epstein

1 copy in tags/Safari-612.2.4.0.1

Tag Safari-612.2.4.0.1.

10:01 PM Changeset in webkit [282435] by Russell Epstein

8 edits in branches/safari-612.2.4.0-branch/Source

Versioning.

WebKit-7612.2.4.0.1

9:57 PM Changeset in webkit [282434] by Russell Epstein

1 copy in tags/Safari-612.2.6

Tag Safari-612.2.6.

9:24 PM Changeset in webkit [282433] by Kocsen Chung

8 edits in branches/safari-612.2.4.1-branch/Source

Versioning.

WebKit-7612.2.4.1.2

9:21 PM Changeset in webkit [282432] by Russell Epstein

1 copy in branches/safari-612.2.4.0-branch

New branch.

8:39 PM Changeset in webkit [282431] by don.olmstead@sony.com

2 edits in trunk/Tools

Rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION
https://bugs.webkit.org/show_bug.cgi?id=230279
<rdar://problem/83118683>

Reviewed by John Wilander.

Followup renaming the variables in FeatureList.pm.

Scripts/webkitperl/FeatureList.pm:

7:28 PM Changeset in webkit [282430] by don.olmstead@sony.com

18 edits in trunk/Source

Non-unified build fixes, mid September 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=230110

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

runtime/TemporalPlainTimeConstructor.cpp:
runtime/TemporalPlainTimePrototype.cpp:

Source/WebCore:

css/calc/CSSCalcOperationNode.cpp:
css/calc/CSSCalcPrimitiveValueNode.cpp:
layout/formattingContexts/FormattingQuirks.cpp:
layout/formattingContexts/inline/invalidation/InlineDamage.h:
layout/formattingContexts/inline/invalidation/InlineInvalidation.h:
loader/CrossOriginOpenerPolicy.cpp:
loader/DocumentWriter.cpp:
rendering/TextBoxPainter.cpp:

Source/WebKit:

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementNetworkLoader.cpp:

(WebKit::PCM::NetworkLoader::start):

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementNetworkLoader.h:
NetworkProcess/storage/OriginStorageManager.h:

6:13 PM Changeset in webkit [282429] by wilander@apple.com

106 edits in trunk

Rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION
https://bugs.webkit.org/show_bug.cgi?id=230279
<rdar://problem/83118683>

Reviewed by Darin Adler.

Source/cmake/OptionsFTW.cmake:
Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsPlayStation.cmake:
Source/cmake/OptionsWPE.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

dom/BroadcastChannel.cpp:

(WebCore::shouldPartitionOrigin):

dom/Document+StorageAccess.idl:
dom/Document.cpp:

(WebCore::Document::referrer):

dom/Document.h:
dom/DocumentStorageAccess.cpp:
dom/DocumentStorageAccess.h:
history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

history/CachedPage.h:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

loader/EmptyClients.cpp:
loader/EmptyFrameLoaderClient.h:
loader/FrameLoaderClient.h:
loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestInternal):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

page/ChromeClient.h:
page/CrossSiteNavigationDataTransfer.h:
page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

page/Quirks.cpp:

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

page/Quirks.h:
platform/network/NetworkStorageSession.cpp:
platform/network/NetworkStorageSession.h:
platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::cookiesForURL const):
(WebCore::NetworkStorageSession::setCookiesFromDOM const):

platform/network/curl/NetworkStorageSessionCurl.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):

platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::getRawCookies const):
(WebCore::cookiesForSession):

Source/WebKit:

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:

(WebKit::ResourceLoadStatisticsStore::updateClientSideCookiesAgeCap):

NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::clearPageSpecificData):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::restrictRequestReferrerToOriginIfNeeded):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntryInternal):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::validateCacheEntryForMaxAgeCapValidation):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::invalidateAndCancel):

NetworkProcess/NetworkSession.h:
NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::storeRedirect):

NetworkProcess/cache/NetworkCacheEntry.cpp:
NetworkProcess/cache/NetworkCacheEntry.h:
NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):

NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):

NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl):
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
(WebKit::NetworkDataTaskCurl::blockCookies):
(WebKit::NetworkDataTaskCurl::unblockCookies):
(WebKit::NetworkDataTaskCurl::shouldBlockCookies):

NetworkProcess/curl/NetworkSessionCurl.cpp:

(WebKit::NetworkSessionCurl::NetworkSessionCurl):

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::createRequest):

Shared/ResourceLoadStatisticsParameters.h:

(WebKit::ResourceLoadStatisticsParameters::encode const):
(WebKit::ResourceLoadStatisticsParameters::decode):

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
Shared/WebProcessDataStoreParameters.h:

(WebKit::WebProcessDataStoreParameters::encode const):
(WebKit::WebProcessDataStoreParameters::decode):

Shared/WebsiteData/WebsiteData.cpp:

(WebKit::WebsiteData::encode const):
(WebKit::WebsiteData::decode):
(WebKit::WebsiteData::isolatedCopy const):

Shared/WebsiteData/WebsiteData.h:
UIProcess/API/C/WKPage.cpp:

(WKPageLoadedSubresourceDomains):
(WKPageClearLoadedSubresourceDomains):

UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreRemoveITPDataForDomain):
(WKWebsiteDataStoreDoesStatisticsDomainIDExistInDatabase):
(WKWebsiteDataStoreSetResourceLoadStatisticsEnabled):
(WKWebsiteDataStoreIsStatisticsEphemeral):
(WKWebsiteDataStoreSetResourceLoadStatisticsDebugModeWithCompletionHandler):
(WKWebsiteDataStoreSetResourceLoadStatisticsPrevalentResourceForDebugMode):
(WKWebsiteDataStoreSetStatisticsLastSeen):
(WKWebsiteDataStoreSetStatisticsMergeStatistic):
(WKWebsiteDataStoreSetStatisticsExpiredStatistic):
(WKWebsiteDataStoreSetStatisticsPrevalentResource):
(WKWebsiteDataStoreSetStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreDumpResourceLoadStatistics):
(WKWebsiteDataStoreIsStatisticsPrevalentResource):
(WKWebsiteDataStoreIsStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubresourceUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubFrameUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsRedirectingTo):
(WKWebsiteDataStoreSetStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsOnlyInDatabaseOnce):
(WKWebsiteDataStoreSetStatisticsGrandfathered):
(WKWebsiteDataStoreIsStatisticsGrandfathered):
(WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsCrossSiteLoadWithLinkDecoration):
(WKWebsiteDataStoreSetStatisticsTimeToLiveUserInteraction):
(WKWebsiteDataStoreStatisticsProcessStatisticsAndDataRecords):
(WKWebsiteDataStoreStatisticsUpdateCookieBlocking):
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WKWebsiteDataStoreSetStatisticsIsRunningTest):
(WKWebsiteDataStoreSetStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsMinimumTimeBetweenDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsGrandfatheringTime):
(WKWebsiteDataStoreSetStatisticsMaxStatisticsEntries):
(WKWebsiteDataStoreSetStatisticsPruneEntriesDownTo):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStore):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
(WKWebsiteDataStoreStatisticsDeleteCookiesForTesting):
(WKWebsiteDataStoreStatisticsHasLocalStorage):
(WKWebsiteDataStoreSetStatisticsCacheMaxAgeCap):
(WKWebsiteDataStoreStatisticsHasIsolatedSession):
(WKWebsiteDataStoreSetResourceLoadStatisticsShouldDowngradeReferrerForTesting):
(WKWebsiteDataStoreSetResourceLoadStatisticsShouldBlockThirdPartyCookiesForTesting):
(WKWebsiteDataStoreSetResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting):
(WKWebsiteDataStoreSetResourceLoadStatisticsToSameSiteStrictCookiesForTesting):
(WKWebsiteDataStoreSetResourceLoadStatisticsFirstPartyHostCNAMEDomainForTesting):
(WKWebsiteDataStoreSetResourceLoadStatisticsThirdPartyCNAMEDomainForTesting):
(WKWebsiteDataStoreStatisticsResetToConsistentState):
(WKWebsiteDataStoreGetAllStorageAccessEntries):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _seedResourceLoadStatisticsForTestingWithFirstParty:thirdParty:shouldScheduleNotification:completionHandler:]):

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsDebugMode]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsDebugMode:]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsTestingCallback:]):
(-[WKWebsiteDataStore _loadedSubresourceDomainsFor:completionHandler:]):
(-[WKWebsiteDataStore _clearLoadedSubresourceDomainsFor:]):
(-[WKWebsiteDataStore _getAllStorageAccessEntriesFor:completionHandler:]):
(-[WKWebsiteDataStore _scheduleCookieBlockingUpdate:]):
(-[WKWebsiteDataStore _logUserInteraction:completionHandler:]):
(-[WKWebsiteDataStore _setPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _getIsPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _clearPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _clearResourceLoadStatistics:]):
(-[WKWebsiteDataStore _getResourceLoadStatisticsDataSummary:]):
(-[WKWebsiteDataStore _isRelationshipOnlyInDatabaseOnce:thirdParty:completionHandler:]):
(-[WKWebsiteDataStore _isRegisteredAsSubresourceUnderFirstParty:thirdParty:completionHandler:]):
(-[WKWebsiteDataStore _statisticsDatabaseHasAllTables:]):
(-[WKWebsiteDataStore _processStatisticsAndDataRecords:]):
(-[WKWebsiteDataStore _setThirdPartyCookieBlockingMode:onlyOnSitesWithoutUserInteraction:completionHandler:]):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

UIProcess/Network/NetworkProcessProxy.cpp:
UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::webProcessDataStoreParameters):

UIProcess/WebProcessPool.h:
UIProcess/WebProcessProxy.cpp:
UIProcess/WebProcessProxy.h:
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::platformSetNetworkParameters):

UIProcess/WebsiteData/WebsiteDataRecord.cpp:

(WebKit::WebsiteDataRecord::isolatedCopy const):

UIProcess/WebsiteData/WebsiteDataRecord.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::resourceLoadStatisticsEnabled const):
(WebKit::WebsiteDataStore::resourceLoadStatisticsDebugMode const):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::isResourceLoadStatisticsEphemeral const):
(WebKit::WebsiteDataStore::parameters):

UIProcess/WebsiteData/WebsiteDataStore.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchWillChangeDocument):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
WebProcess/WebPage/WebCookieJar.cpp:

(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::setCookies):
(WebKit::WebCookieJar::cookiesEnabled const):
(WebKit::WebCookieJar::cookieRequestHeaderFieldValue const):
(WebKit::WebCookieJar::getRawCookies const):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setWebsiteDataStoreParameters):
(WebKit::WebProcess::setResourceLoadStatisticsEnabled):
(WebKit::WebProcess::clearResourceLoadStatistics):
(WebKit::WebProcess::flushResourceLoadStatistics):
(WebKit::WebProcess::seedResourceLoadStatisticsForTesting):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

Source/WTF:

wtf/PlatformEnableCocoa.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

5:31 PM Changeset in webkit [282428] by Eric Hutchison

2 edits in trunk/LayoutTests

Remove test expectations for imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry.html.
https://bugs.webkit.org/show_bug.cgi?id=229516.

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

5:16 PM Changeset in webkit [282427] by Eric Hutchison

2 edits in trunk/LayoutTests

Remove test expectations for imported/w3c/web-platform-tests/css/css-fonts/downloadable-font-in-iframe-print.html.
https://bugs.webkit.org/show_bug.cgi?id=229506.

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

5:14 PM Changeset in webkit [282426] by Chris Dumez

2 edits in trunk/Source/WTF

Enable BroadcastChannel for modern WebKit
https://bugs.webkit.org/show_bug.cgi?id=230235

Reviewed by Geoffrey Garen.

Scripts/Preferences/WebPreferencesExperimental.yaml:

5:08 PM Changeset in webkit [282425] by Ayumi Kojima

3 edits in trunk/LayoutTests

[MacOS wk2 & iOS] 2 fast/canvas tests are flaky timeouts.
https://bugs.webkit.org/show_bug.cgi?id=228082

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

4:58 PM Changeset in webkit [282424] by commit-queue@webkit.org

3 edits in trunk/Tools

[builtins-generator-tests] Invoke with Python 3
https://bugs.webkit.org/show_bug.cgi?id=229879

Patch by Kevin Neal <kevin_neal@apple.com> on 2021-09-14
Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/steps.py:

(RunBuiltinsTests):

Scripts/run-builtins-generator-tests:

(main): Deleted.

4:56 PM Changeset in webkit [282423] by Ayumi Kojima

2 edits in trunk/LayoutTests

REGRESSION: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is timing out on some bots.
https://bugs.webkit.org/show_bug.cgi?id=227973

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

4:52 PM Changeset in webkit [282422] by Eric Hutchison

2 edits in trunk/LayoutTests

Remove test expectations for 3 iOS tests.
https://bugs.webkit.org/show_bug.cgi?id=229573.

Unreviewed test gardening.

platform/ios-14/TestExpectations:

4:47 PM Changeset in webkit [282421] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Fix -Wredundant-move warnings
https://bugs.webkit.org/show_bug.cgi?id=230282

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-09-14
Reviewed by Alex Christensen.

Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<CString>::decode):

Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<CertificateInfo>::decode):

3:57 PM Changeset in webkit [282420] by commit-queue@webkit.org

5 edits
3 adds in trunk/LayoutTests

[GLIB] Update platform test expectations and baselines after WPT import in r282287
https://bugs.webkit.org/show_bug.cgi?id=230281

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-09-14

platform/glib/TestExpectations:
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-001-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt:
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/css-transform-inherit-rotate-expected.png: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/css-transform-inherit-rotate-expected.txt: Added.
platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

3:42 PM Changeset in webkit [282419] by Wenson Hsieh

10 edits in trunk/Source

[macOS] Avoid computing post-layout EditorState data unless necessary
https://bugs.webkit.org/show_bug.cgi?id=230204
<rdar://problem/83078713>

Reviewed by Devin Rousso.

Source/WebCore:

See WebKit/ChangeLog for more details.

page/Page.h:

(WebCore::Page::isEditable const): Mark this getter const.
(WebCore::Page::isEditable): Deleted.

Source/WebKit:

Add a new codepath on macOS that allows us to entirely avoid post-layout EditorState computation in the case
where it's not needed for anything; in particular, unless the text touch bar may be presented or the UI delegate
implements the -webView:didChangeFontAttributes: method, the post-layout portion of EditorState is not needed
at all.

See below for more details.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:

Plumb a bit indicating whether user interaction is required in order to show the text touch bar. See
WebPage::shouldAvoidComputingPostLayoutDataForEditorState below for more details.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):
(WebKit::WebPage::updateEditorStateAfterLayoutIfEditabilityChanged):

When computing EditorState.isContentEditable, use VisibleSelection's hasEditableStyle method instead of
isContentEditable. Unlike the latter, the former does not trigger style resolution.

(WebKit::WebPage::didStartPageTransition):

Make a slight adjustment to only set the m_hasEverFocusedElementDueToUserInteractionSincePageTransition bit if
the user is actually interacting with text form control or editable element. This allows us to still avoid
computing post-layout editor state data in cases where the user has clicked on non-editable elements on the
page, such that text editing controls in the touch bar are still not being shown.

(WebKit::WebPage::didChangeSelectionOrOverflowScrollPosition):
(WebKit::WebPage::sendEditorStateUpdate):

Don't bother scheduling another post-layout EditorState in the case where post-layout data is missing, but we're
avoiding post-layout data computation altogether due to shouldAvoidComputingPostLayoutDataForEditorState
returning true.

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::requiresPostLayoutDataForEditorState const):
(WebKit::WebPage::shouldAvoidComputingPostLayoutDataForEditorState const):
(WebKit::WebPage::platformNeedsLayoutForEditorState const): Deleted.

Rename this to requiresPostLayoutDataForEditorState, to avoid some confusion with the new method,
shouldAvoidComputingPostLayoutDataForEditorState. The former is a way for platforms to indicate that post-
layout data *must* be included, even if layout is not up to date yet upon computing the EditorState. The latter
is a way for platforms to indicate that we can completely avoid all post-layout editor state computation,
regardless of whether or not layout is up to date.

By default, if both of the above methods return false, we compute and include post-layout data only if layout
is up-to-date when computing the EditorState, and schedule a subsequent "full" EditorState update after the
next rendering update in the case where layout was *not* up-to-date already (indicated by the EditorState's
isMissingPostLayoutData flag).

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requiresPostLayoutDataForEditorState const):
(WebKit::WebPage::platformNeedsLayoutForEditorState const): Deleted.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldAvoidComputingPostLayoutDataForEditorState const):

Only return true here if the user interaction requirements for showing text editing controls on the touch bar
have not been met, and the UI delegate method for observing font attributes is also not implemented by the
client.

3:41 PM Changeset in webkit [282418] by Ayumi Kojima

2 edits in trunk/LayoutTests

[ Catalina EWS ] http/tests/media/hls/range-request.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=229424

Unreviewed test gardening.

platform/mac/TestExpectations: Removed expectation

3:28 PM Changeset in webkit [282417] by Eric Hutchison

2 edits in trunk/LayoutTests

Remove test expectations for pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html.
https://bugs.webkit.org/show_bug.cgi?id=229522.

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

3:25 PM Changeset in webkit [282416] by Ryan Haddad

15 edits in trunk

Unreviewed, reverting r282408.

Breaks internal builds.

Reverted changeset:

"Enable RTCRtpScriptTransform by default"
https://bugs.webkit.org/show_bug.cgi?id=230220
https://commits.webkit.org/r282408

3:19 PM Changeset in webkit [282415] by mmaxfield@apple.com

9 edits
2 adds in trunk

CSSFontFaceSrcValue.cssText should be quoted consistently with other browsers
https://bugs.webkit.org/show_bug.cgi?id=230273
<rdar://problem/79644124>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

This is being upstreamed in https://github.com/web-platform-tests/wpt/pull/30784.

web-platform-tests/css/css-fonts/font-family-src-quoted-expected.txt: Added.
web-platform-tests/css/css-fonts/font-family-src-quoted.html: Added.
web-platform-tests/css/cssom/cssom-fontfacerule-expected.txt:

Source/WebCore:

In a src: line like "src: local(foobar)", Firefox and Chrome will both quote
"foobar" when reading out of the OM. Same thing with "src: url(foobar)".
We should match them.

Test: imported/w3c/web-platform-tests/css/css-fonts/font-family-src-quoted.html

css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::customCSSText const):

css/CSSMarkup.cpp:

(WebCore::serializeIdentifier):
(WebCore::serializeString):

Source/WTF:

wtf/unicode/CharacterNames.h:

LayoutTests:

fast/css/font-face-src-parsing-expected.txt:

3:11 PM Changeset in webkit [282414] by Ayumi Kojima

2 edits in trunk/LayoutTests

Run tests in fast/forms/ios by default in EWS.
https://bugs.webkit.org/show_bug.cgi?id=229656

Unreviewed test gardening.

platform/ipad/TestExpectations:

3:09 PM Changeset in webkit [282413] by Ross Kirsling

2 edits in trunk/Source/JavaScriptCore

[Win] JSRemoteInspector.h missing stdint include
https://bugs.webkit.org/show_bug.cgi?id=230275

Reviewed by Don Olmstead.

API/JSRemoteInspector.h:

Include stdint for uint8_t definition on Windows.

2:52 PM Changeset in webkit [282412] by commit-queue@webkit.org

2 edits in trunk

Add dvh@apple.com to the list of contributors.
https://bugs.webkit.org/show_bug.cgi?id=230276

Patch by Hoa Dinh <dvh@apple.com> on 2021-09-14
Reviewed by Jonathan Bedard.

metadata/contributors.json:

2:29 PM Changeset in webkit [282411] by Russell Epstein

1 copy in tags/Safari-612.1.29.41.4

Tag Safari-612.1.29.41.4.

2:27 PM Changeset in webkit [282410] by Russell Epstein

8 edits in branches/safari-612.1.29.41-branch/Source

Versioning.

WebKit-7612.1.29.41.4

2:14 PM Changeset in webkit [282409] by Jonathan Bedard

6 edits in trunk/Tools

[git-webkit] Reset author time when editing commits (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=230224
<rdar://problem/83065417>

Reviewed by Stephanie Lewis.

Scripts/libraries/webkitscmpy/setup.py: Bump version.
Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.pull): Force-update ref of pulled branch, reset author time of all rebased commits.

Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Add update-ref mock.
Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

(TestDoPullRequest):

1:21 PM Changeset in webkit [282408] by youenn@apple.com

15 edits in trunk

Enable RTCRtpScriptTransform by default
https://bugs.webkit.org/show_bug.cgi?id=230220
Source/WebCore:

Reviewed by Eric Carlson.

No change of behavior, renaming WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled
and WebRTCSFrameTransformEnabled.

Modules/mediastream/RTCEncodedAudioFrame.idl:
Modules/mediastream/RTCEncodedVideoFrame.idl:
Modules/mediastream/RTCRtpReceiver+Transform.idl:
Modules/mediastream/RTCRtpSFrameTransform.idl:
Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
Modules/mediastream/RTCRtpScriptTransform.idl:
Modules/mediastream/RTCRtpScriptTransformer.idl:
Modules/mediastream/RTCRtpSender+Transform.idl:
Modules/mediastream/RTCTransformEvent.idl:
workers/DedicatedWorkerGlobalScope.idl:

Source/WTF:

Reviewed by Eric Carlson.

Splitting WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled and WebRTCSFrameTransformEnabled.
Keeping WebRTCSFrameTransformEnabled as off by default until SFrame solidifies and mark WebRTCEncodedTransformEnabled as on by default.

Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

<rdar://problem/83090247>

Reviewed by Eric Carlson.

http/wpt/webrtc/no-webrtc-transform.html:

Migrate to new internal setting.

1:18 PM Changeset in webkit [282407] by Ayumi Kojima

3 edits in trunk/LayoutTests

[ iOS Mac Debug ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coop-navigated-history-popup.https.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=230268

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

1:14 PM Changeset in webkit [282406] by Fujii Hironori

2 edits in trunk/Source/WebKit

Enable IPCMessages debug logging for non-Cocoa ports
https://bugs.webkit.org/show_bug.cgi?id=230081
<rdar://problem/82939596>

Reviewed by Don Olmstead.

Platform/IPC/MessageArgumentDescriptions.h: Added some #if to

align with the generated MessageArgumentDescriptions.cpp.

1:09 PM Changeset in webkit [282405] by Fujii Hironori

2 edits in trunk/Source/WTF

StackTrace outputs a garbage prefix because WTF::StackTrace::m_prefix is filled with the stack content
https://bugs.webkit.org/show_bug.cgi?id=230207

Reviewed by Yusuke Suzuki.

r278474 (Bug 226390) added a new member m_prefix to StackTrace at
the bottom of the structure. However, StackTrace isn't a normal
structure. The members are filled with the stack content.

wtf/StackTrace.h: Moved the m_prefix to the top of the members.

1:06 PM Changeset in webkit [282404] by Jonathan Bedard

3 edits in trunk/Tools

[git-webkit] Reset author time when editing commits (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=230224
<rdar://problem/83065417>

Reviewed by Stephanie Lewis.

Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Capture 'git commit date=now'.
Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:

(PullRequest.create_commit): Always reset commit date.

12:59 PM Changeset in webkit [282403] by Darin Adler

12 edits in trunk

URLs in CSS variables must be resolved against the base URL of the stylesheet, not the document
https://bugs.webkit.org/show_bug.cgi?id=230243

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/variables/url-with-variable-is-sheet-relative.html

css/CSSPendingSubstitutionValue.h: Removed baseURL, since CSSVariableReferenceValue now

contains an appropriate parsing context, which includes the base URL.

css/CSSVariableReferenceValue.cpp:

(WebCore::CSSVariableReferenceValue::CSSVariableReferenceValue): Store a CSSParserContext.
(WebCore::CSSVariableReferenceValue::create): Ditto.

css/CSSVariableReferenceValue.h: Updated for the above.

css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences): Use the context from the
variable reference, not the current one in the parser.

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseValueStart): Pass a parser context when creating a
CSSVariableReferenceValue.

css/parser/CSSVariableParser.cpp:

(WebCore::CSSVariableParser::parseDeclarationValue): Ditto.

style/StyleBuilder.cpp:

(WebCore::Style::Builder::resolvedVariableValue): Remove the special case for
CSSPendingSubstitutionValue since CSSParser::parseValueWithVariableReferences
now takes care of this.

LayoutTests:

fast/css/variables/support/styles/url-with-variable-is-sheet-relative.css: Added 10 more test cases.
fast/css/variables/url-with-variable-is-sheet-relative-expected.html: Ditto.
fast/css/variables/url-with-variable-is-sheet-relative.html: Ditto.

12:53 PM Changeset in webkit [282402] by commit-queue@webkit.org

2 edits
6 adds in trunk/LayoutTests/imported/w3c

Add wpts for sin,cos,tan
https://bugs.webkit.org/show_bug.cgi?id=230129

Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2021-09-14
Reviewed by Simon Fraser.

web-platform-tests/css/support/numeric-testcommon.js:

(test_math_used):
Added helper function for testing approximate equals.

12:31 PM Changeset in webkit [282401] by Alan Bujtas

4 edits
4 adds in trunk/Source/WebCore

[LFC][IFC] Introduce InlineInvalidation/InlineDamage
https://bugs.webkit.org/show_bug.cgi?id=229225
<rdar://problem/82324227>

Reviewed by Antti Koivisto.

This is in preparation for supporting partial inline layout.

The initial implementation is going to only support a single type of damage (content changed, style changed etc) on a single line.
Anything more involved either

folds into a full damage type of layout (i.e. no range support) e.g changing multiple images on different lines triggers vertical alignment on all the lines
triggers the lowest level type of layout e.g. changing content on the first line while resizing the containing block folds into NeedsContentUpdateAndLineLayout.

CMakeLists.txt:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/formattingContexts/inline/invalidation/InlineDamage.h: Added.

(WebCore::Layout::InlineDamage::type const):
(WebCore::Layout::InlineDamage::line const):
(WebCore::Layout::InlineDamage::setDamageType):
(WebCore::Layout::InlineDamage::setDamagedLine):

layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp: Added.

(WebCore::Layout::InlineInvalidation::InlineInvalidation):
(WebCore::Layout::InlineInvalidation::styleChanged):
(WebCore::Layout::InlineInvalidation::textInserted):
(WebCore::Layout::InlineInvalidation::textWillBeRemoved):
(WebCore::Layout::InlineInvalidation::inlineLevelBoxInserted):
(WebCore::Layout::InlineInvalidation::inlineLevelBoxWillBeRemoved):

layout/formattingContexts/inline/invalidation/InlineInvalidation.h: Added.

12:26 PM Changeset in webkit [282400] by commit-queue@webkit.org

1 edit
21 adds in trunk/LayoutTests

[GLIB] Create platform specific baselines for new web platform tests imported in r282287
https://bugs.webkit.org/show_bug.cgi?id=230272

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-09-14

platform/glib/imported/w3c/web-platform-tests/css/css-transforms/crashtests/large-scaley-001-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/crashtests/preserve3d-scene-001-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/crashtests/w-negative-001-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/crashtests/w-negative-002-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/crashtests/w-negative-003-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/large-matrix-crash-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/text-perspective-001-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/css/css-transforms/crashtests/preserve3d-scene-002-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/css/css-transforms/rotate-180-degrees-001-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/css/css-transforms/rotate-270-degrees-001-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/css/css-transforms/rotate-90-degrees-001-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/css/css-transforms/crashtests/preserve3d-scene-002-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/css/css-transforms/crashtests/transform-marquee-resize-div-image-001-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/css/css-transforms/rotate-180-degrees-001-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/css/css-transforms/rotate-270-degrees-001-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/css/css-transforms/rotate-90-degrees-001-expected.txt: Added.

11:51 AM Changeset in webkit [282399] by Kate Cheney

2 edits in trunk/Source/WTF

Followup to https://bugs.webkit.org/show_bug.cgi?id=217784

Reviewed by Wenson Hsieh.

Update platform name for watchOS.

Scripts/Preferences/WebPreferences.yaml:

11:42 AM Changeset in webkit [282398] by mmaxfield@apple.com

6 edits in trunk/Source

[Cocoa] Migrate to CTFontHasTable() from CTFontCopyAvailableTables()
https://bugs.webkit.org/show_bug.cgi?id=230248

Reviewed by Anders Carlsson.

Source/WebCore:

CTFontHasTable() has been around for a while, but it's only actually
faster than CTFontCopyAvailableTables() on certain operating systems.

No new tests because there is no behavior change.

platform/graphics/coretext/FontCoreText.cpp:

(WebCore::fontHasTable):
(WebCore::fontHasEitherTable):

Source/WebCore/PAL:

pal/spi/cf/CoreTextSPI.h:

Source/WTF:

wtf/PlatformUse.h:

11:38 AM Changeset in webkit [282397] by mmaxfield@apple.com

35 edits in trunk

Implement text-decoration-skip-ink
https://bugs.webkit.org/show_bug.cgi?id=230244

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
web-platform-tests/css/css-text-decor/inheritance-expected.txt:
web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-computed-expected.txt:
web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-valid-expected.txt:
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-expected.txt:
web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

Source/WebCore:

First, there was "text-decoration-skip: ink", and that was what we implemented in WebKit. That had a
problem, though, which was that you couldn't add a value into the set without resetting the entire
property, so the CSSWG split it up into a bunch of constituent properties:

text-decoration-skip-self
text-decoration-skip-box
text-decoration-skip-inset
text-decoration-skip-spaces
text-decoration-skip-ink

text-decoration-skip was turned into a shorthand for all of these constituent properties.

Chrome and Firefox, however, implemented text-decoration-skip-ink rather than text-decoration-skip.
From what I understand, Firefox isn't interested in implementing the shorthand until they implement
all the longhands. Therefore, because WebKit implements only the shorthand and Firefox implements only
the longhand, authors have to write two different properties in their style for the two different
browsers. That's unfortunate, so this patch makes WebKit follow the CSSWG, and turns
text-decoration-skip into a shorthand, and adds support for text-decoration-skip-ink. Therefore,
there's no new behavior here; it's just a new way of accessing the same functionality we already have.

The spec actually removed the "ink" value from the text-decoration-skip shorthand, but we have to
maintain it because of compat. So, this patch maps "text-decoration-skip: ink" to
"text-decoration-skip-ink: auto". There's an issue in the spec about this:
https://drafts.csswg.org/css-text-decor-4/#issue-070668ae

Back when we implemented text-decoration-skip: ink, we only implemented the "ink" value, and none of
the other values. This patch also doesn't implement the other values.

Also, previously, we used to parse "text-decoration-skip: objects" but we didn't do anything with it.
This patch removes parsing support for that, so @supports works properly.

Covered by existing tests.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationSkipToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
(WebCore::renderTextDecorationSkipFlagsToCSSValue): Deleted.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextDecorationSkipInk const):

css/CSSProperties.json:
css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::textDecorationSkipValue const):

css/StyleProperties.h:
css/html.css:

(ins, del):

css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeTextDecorationSkip):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseShorthand):
(WebCore::consumeTextDecorationSkip): Deleted.

css/parser/CSSPropertyParser.h:
rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintTextDecoration):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline const):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textDecorationSkipInk const):
(WebCore::RenderStyle::setTextDecorationSkipInk):
(WebCore::RenderStyle::initialTextDecorationSkipInk):
(WebCore::RenderStyle::textDecorationSkip const): Deleted.
(WebCore::RenderStyle::setTextDecorationSkip): Deleted.
(WebCore::RenderStyle::initialTextDecorationSkip): Deleted.

rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

rendering/style/RenderStyleConstants.h:
rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

rendering/style/StyleRareInheritedData.h:
style/InlineTextBoxStyle.cpp:

(WebCore::minLogicalTopForTextDecorationLine):
(WebCore::maxLogicalBottomForTextDecorationLine):

style/PropertyCascade.cpp:

(WebCore::Style::shouldApplyPropertyInParseOrder):

style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::valueToDecorationSkip): Deleted.
(WebCore::Style::BuilderConverter::convertTextDecorationSkip): Deleted.

LayoutTests:

fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt:
fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html:
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

10:08 AM Changeset in webkit [282396] by Sam Sneddon

22 edits in trunk

Support the x resolution unit
https://bugs.webkit.org/show_bug.cgi?id=229777

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Rebaseline for more passing tests.

web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:

Source/WebCore:

Covered by existing (progressing) tests.

css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::isStringType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor):
(WebCore::CSSPrimitiveValue::unitTypeString):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):
(WebCore::CSSPrimitiveValue::equals const):

css/CSSPrimitiveValue.h:
css/CSSUnits.cpp:

(WebCore::unitCategory):
(WebCore::operator<<):

css/CSSUnits.h:
css/DeprecatedCSSOMPrimitiveValue.cpp:

(WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType const):
(WebCore::DeprecatedCSSOMPrimitiveValue::getFloatValue const):

css/calc/CSSCalcCategoryMapping.cpp:

(WebCore::hasDoubleValue):

css/parser/CSSParserToken.cpp:

(WebCore::cssPrimitiveValueUnitFromTrie):

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeResolutionCSSPrimitiveValueWithKnownTokenTypeDimension):
(WebCore::CSSPropertyParserHelpers::consumeResolution):
(WebCore::CSSPropertyParserHelpers::consumeImageSet):

css/parser/CSSPropertyParserHelpers.h:

(WebCore::CSSPropertyParserHelpers::consumeResolution):
Remove the optional allowX argument now it's part of the normal syntax.

LayoutTests:

Update tests so that they expect the x unit to serialize as the x unit
(and not magically change to the dppx unit).

fast/css/cursor-parsing-image-set-expected.txt:
fast/css/cursor-parsing-image-set.html:
fast/css/image-set-parsing-expected.txt:
fast/css/image-set-parsing-generated-expected.txt:
fast/css/image-set-parsing-generated.html:
fast/css/image-set-parsing.html:
fast/css/image-set-setting-expected.txt:
fast/css/image-set-setting.html:
fast/css/image-set-unprefixed.html:

10:02 AM Changeset in webkit [282395] by youenn@apple.com

9 edits in trunk/Source/WebCore

Refactor WritableStream to better integrate https://streams.spec.whatwg.org/#create-writable-stream
https://bugs.webkit.org/show_bug.cgi?id=230219

Reviewed by Sihui Liu.

Previously to create a WritableStream as https://streams.spec.whatwg.org/#create-writable-stream,
we were still going through the WritableStream constructor taking an underlying sink.
We refactor code to stop doing that, which will make it easy to introduce https://streams.spec.whatwg.org/#writablestream-set-up
which is now used in other web specifications.

To do so, we introduce a createFromUnderlyingSink built-in function that creates a WritableStream from an InternalWritableStream.
Covered by existing tests.

Modules/streams/StreamInternals.js:

(extractHighWaterMark): Make sure extractHighWaterMark returns a number as WebIDL defines HWM as a double.

Modules/streams/WritableStream.cpp:

(WebCore::WritableStream::create):

Modules/streams/WritableStream.h:
Modules/streams/WritableStreamInternals.js:

(createWritableStream):
(createInternalWritableStreamFromUnderlyingSink):

bindings/js/InternalWritableStream.cpp:

(WebCore::InternalWritableStream::createFromUnderlyingSink):
(WebCore::InternalWritableStream::fromObject):
(WebCore::InternalWritableStream::create): Deleted.

bindings/js/InternalWritableStream.h:
bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

bindings/js/WebCoreBuiltinNames.h:

9:48 AM Changeset in webkit [282394] by Ayumi Kojima

4 edits in trunk/LayoutTests

REGRESSION (r281981): [iOS, BigSur+] webrtc/datachannel/getStats-no-prflx-remote-candidate.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=229877

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:

9:21 AM Changeset in webkit [282393] by Chris Dumez

21 edits in trunk/Source

[Hardening] Validate IDBValue's blob paths in WebIDBServer::putOrAdd()
https://bugs.webkit.org/show_bug.cgi?id=230233
<rdar://79562514>

Reviewed by Brady Eidson.

Source/WebCore:

Rename writeBlobsToTemporaryFiles() to writeBlobsToTemporaryFilesForIndexedDB() for clarity
since it is currently only used for IndexedDB and we wouldn't want to expand usage to
other things.

bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):

platform/network/BlobRegistry.h:
platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFilesForIndexedDB):

platform/network/BlobRegistryImpl.h:

Source/WebKit:

When the SerializedScriptValue contains BlobURLs, IDBTransaction::putOrAddOnServer()
calls SerializedScriptValue::writeBlobsToDiskForIndexedDB() before sending the
WebIDBServer::PutOrAdd IPC to the network process. writeBlobsToDiskForIndexedDB()
sends a NetworkProcessConnection::writeBlobsToTemporaryFilesForIndexedDB IPC to the
network process and the network process will write the blobs to temporary files and
then return the file paths to those temporary files to the WebProcess. The file paths
are then stored inside the IDBValue object that gets sent in the WebIDBServer::PutOrAdd
IPC.

This patch hardens our IPC by validating in WebIDBServer::PutOrAdd() that the IDBValue's
Blob file paths were indeed file paths previously created by the network process on behalf
of the WebProcess sending the IPC. If it is not, we ignore the IPC.

NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::putOrAdd):
(WebKit::WebIDBServer::removeConnection):
(WebKit::WebIDBServer::registerTemporaryBlobFilePaths):

NetworkProcess/IndexedDB/WebIDBServer.h:
NetworkProcess/IndexedDB/WebIDBServer.messages.in:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFilesForIndexedDB):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkProcessPlatformStrategies.cpp:

(WebKit::NetworkProcessPlatformStrategies::createBlobRegistry):

WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFilesForIndexedDB):

WebProcess/FileAPI/BlobRegistryProxy.h:
WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFilesForIndexedDB):

WebProcess/Network/NetworkProcessConnection.h:

Source/WebKitLegacy/mac:

WebCoreSupport/WebPlatformStrategies.mm:

Source/WebKitLegacy/win:

WebCoreSupport/WebPlatformStrategies.cpp:

9:11 AM Changeset in webkit [282392] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[GLIB] Update test baselines after r282307
https://bugs.webkit.org/show_bug.cgi?id=230267

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-09-14

platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt:

8:56 AM Changeset in webkit [282391] by commit-queue@webkit.org

2 edits in trunk/Tools

Provide a way to update the commit message with an updated list of changed files/functions
https://bugs.webkit.org/show_bug.cgi?id=230195

Patch by Hoa Dinh <dvh@apple.com> on 2021-09-14
Reviewed by Jonathan Bedard.

Add a new parameter --only-files to request generation of only the part of the changed files/functions.

Scripts/prepare-ChangeLog:

(main):
(generateNewChangeLogs):

8:53 AM Changeset in webkit [282390] by Antti Koivisto

2 edits in trunk/Source/WebCore

Don't schedule text rendering updates for a non-rendered Document
https://bugs.webkit.org/show_bug.cgi?id=230246
rdar://81905586

Reviewed by Anders Carlsson.

Memory use could grow without limit as these updates would not get cleared until
the document was destroyed.

No test, hard to make a reasonable regression test as the memory growth is not extreme.

dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Bail out if the Document has no render tree.

8:45 AM Changeset in webkit [282389] by Ayumi Kojima

3 edits in trunk/LayoutTests

[ Mac wk2 iOS ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-explicit-rollback-iceGatheringState.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=230266

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

8:18 AM Changeset in webkit [282388] by Ayumi Kojima

3 edits in trunk/LayoutTests

[ MacOS & iOS ] imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=228089

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

6:49 AM Changeset in webkit [282387] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] Remove unnecessary exception checks in DFGOperations
https://bugs.webkit.org/show_bug.cgi?id=230247

Patch by Xan Lopez <Xan Lopez> on 2021-09-14
Reviewed by Caio Araujo Neponoceno de Lima.

JSValue::decode cannot throw an exception, remove a couple of
unnecessary RETURN_IF_EXCEPTION() calls.

dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

6:19 AM Changeset in webkit [282386] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC][IFC] InlineDisplayContentBuilder should not operate on the global inline run list
https://bugs.webkit.org/show_bug.cgi?id=230232

Reviewed by Antti Koivisto.

InlineDisplayContentBuilder builds one line worth of runs. It should not have access to the global (all runs in the formatting context) run list.

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::createRunsAndUpdateGeometryForLineContent):
(WebCore::Layout::InlineDisplayContentBuilder::createRunsAndUpdateGeometryForLineSpanningInlineBoxes):
(WebCore::Layout::InlineDisplayContentBuilder::collectInkOverflowForInlineBoxRuns):

layout/formattingContexts/inline/InlineDisplayContentBuilder.h:
layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

layout/formattingContexts/inline/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::addRuns):
(WebCore::Layout::InlineFormattingState::addRun): Deleted.

layout/formattingContexts/inline/InlineLineRun.h:

3:13 AM Changeset in webkit [282385] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

[JSC] ASSERT failed in stress/for-in-tests.js (32bit)
https://bugs.webkit.org/show_bug.cgi?id=229543

Patch by Xan López <Xan Lopez> on 2021-09-14
Reviewed by Yusuke Suzuki.

Since r280760 DFG::SpeculativeJIT::compileEnumeratorGetByVal uses
too many registers for 32bit. Revert to the slow path as a
temporary measure to avoid crashes, we'll try to reenable the
optimizations later on (see bug #230189).

dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION): define a generic call
operation for compileEnumeratorGetByVal.

dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp: move the current version of

compileEnumeratorGetByVal to 64bit, since it won't work on 32bit.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileEnumeratorGetByVal): call the generic call op always.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileEnumeratorGetByVal): use the previous version here.

runtime/CommonSlowPaths.cpp:

(JSC::JSC_DEFINE_COMMON_SLOW_PATH): refactor a bit the slow path
for enumeratorGetByVal so it can be called from DFG as a call
operation.

runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opEnumeratorGetByVal):

2:36 AM Changeset in webkit [282384] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.34/Source/WebKit

Merge r282383 - REGRESSION(r274929): [CoordinatedGraphics] DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor is no longer used
https://bugs.webkit.org/show_bug.cgi?id=230214

Reviewed by Adrian Perez de Castro.

That means we use the right display refresh monitor in the threaded compositor but a different one for rendering
update scheduler.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::displayRefreshMonitorFactory const): Remove platform ifdef, DrawingArea
unconditionally inherits from DisplayRefreshMonitorFactory and the default implementation of
createDisplayRefreshMonitor() returns nullptr.

2:32 AM Changeset in webkit [282383] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

REGRESSION(r274929): [CoordinatedGraphics] DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor is no longer used
https://bugs.webkit.org/show_bug.cgi?id=230214

Reviewed by Adrian Perez de Castro.

That means we use the right display refresh monitor in the threaded compositor but a different one for rendering
update scheduler.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

12:46 AM Changeset in webkit [282382] by calvaris@igalia.com

3 edits
4 adds in trunk

[GStreamer] Enable H265 codec
https://bugs.webkit.org/show_bug.cgi?id=229920

Reviewed by Philippe Normand.

Source/WebCore:

Check for H265 decoder and parser and add the corresponding
variants.

Test: media/media-can-play-h265-video.html

platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::initializeDecoders):

LayoutTests:

media/media-can-play-h265-video-expected.txt: Added.
media/media-can-play-h265-video.html: Added.
platform/ios/media/media-can-play-h265-video-expected.txt: Added.
platform/mac/media/media-can-play-h265-video-expected.txt: Added.

12:40 AM Changeset in webkit [282381] by youenn@apple.com

15 edits in trunk/LayoutTests/imported/w3c

Migrate some WPT WebRTC tests our of legacy offerToReceive parameters
https://bugs.webkit.org/show_bug.cgi?id=230000

Reviewed by Eric Carlson.

offerToReceive options are legacy options tested in WPT webrtc-legacy folder.
Move to addTransceiver instead.

web-platform-tests/webrtc/RTCPeerConnection-explicit-rollback-iceGatheringState-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-explicit-rollback-iceGatheringState.html:
web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState.html:
web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html:
web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html:
web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-rollback.html:
web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-offer.html:
web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html:
web-platform-tests/webrtc/RTCPeerConnection-transceivers.https-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-transceivers.https.html:
web-platform-tests/webrtc/protocol/RTCPeerConnection-payloadTypes.html:

12:18 AM Changeset in webkit [282380] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix bug in calc functions sin/cos/tan
https://bugs.webkit.org/show_bug.cgi?id=230133

Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2021-09-14
Reviewed by Myles Maxfield.

WPTs added in seperate patch: https://bugs.webkit.org/show_bug.cgi?id=230129.

css/calc/CSSCalcOperationNode.cpp:

(WebCore::CSSCalcOperationNode::simplifyNode):
Fix bug where sin,cos,tan functions are applied twice when root.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed