Context Navigation

← Previous Period
Next Period →

Timeline

Oct 3, 2021:

11:37 PM Changeset in webkit [283488] by Antti Koivisto

5 edits
2 adds in trunk/Source/WebCore

Move RuleSet builder to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=231137

Reviewed by Alan Bujtas.

There is quite a bit of code for it.

There is lots of room for refactoring and cleanups here. This patch does none of it.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
style/RuleSet.cpp:

(WebCore::Style::RuleSet::addRule):
(WebCore::Style::RuleSet::addRulesFromSheet):
(WebCore::Style::RuleSet::Builder::addChildRules): Deleted.
(WebCore::Style::RuleSet::Builder::addRulesFromSheet): Deleted.
(WebCore::Style::RuleSet::Builder::~Builder): Deleted.
(WebCore::Style::RuleSet::Builder::addStyleRule): Deleted.
(WebCore::Style::RuleSet::Builder::registerLayers): Deleted.
(WebCore::Style::RuleSet::Builder::pushCascadeLayer): Deleted.
(WebCore::Style::RuleSet::Builder::popCascadeLayer): Deleted.
(WebCore::Style::RuleSet::Builder::updateCascadeLayerOrder): Deleted.
(WebCore::Style::RuleSet::Builder::addMutatingRulesToResolver): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::pushAndEvaluate): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::pop): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::didMutateResolver): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::addRuleIfNeeded): Deleted.

MediaQueryCollector (an implementation detail of the Builder) moves too.

style/RuleSet.h:
style/RuleSetBuilder.cpp: Added.

(WebCore::Style::RuleSetBuilder::~RuleSetBuilder):
(WebCore::Style::RuleSetBuilder::addChildRules):
(WebCore::Style::RuleSetBuilder::addRulesFromSheet):
(WebCore::Style::RuleSetBuilder::addStyleRule):
(WebCore::Style::RuleSetBuilder::registerLayers):
(WebCore::Style::RuleSetBuilder::pushCascadeLayer):
(WebCore::Style::RuleSetBuilder::popCascadeLayer):
(WebCore::Style::RuleSetBuilder::updateCascadeLayerOrder):
(WebCore::Style::RuleSetBuilder::addMutatingRulesToResolver):
(WebCore::Style::RuleSetMediaQueryCollector::pushAndEvaluate):
(WebCore::Style::RuleSetMediaQueryCollector::pop):
(WebCore::Style::RuleSetMediaQueryCollector::didMutateResolver):
(WebCore::Style::RuleSetMediaQueryCollector::addRuleIfNeeded):

style/RuleSetBuilder.h: Added.

10:37 PM Changeset in webkit [283487] by Lauro Moura

2 edits in trunk/Source/WebKit

[GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
https://bugs.webkit.org/show_bug.cgi?id=231153

Reviewed by Alexey Proskuryakov.

Revert back to the previous NOP behavior of bindAccessibilityTree()
for GTK4, leaving the assert for the debug mode with an informative
message in the log.

Covered by existing tests.

UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

9:34 PM Changeset in webkit [283486] by Alan Bujtas

4 edits in trunk

[LFC][IFC] Do not take hanging whitespace sequence into account while finding expansion opportunities
https://bugs.webkit.org/show_bug.cgi?id=231132

Reviewed by Antti Koivisto.

Source/WebCore:

Ignore hanging whitespace for expansion opportunities.
This patch fixes imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::applyRunExpansion):

LayoutTests:

TestExpectations:

6:07 PM Changeset in webkit [283485] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] HangingTrailingContent should cache width/length
https://bugs.webkit.org/show_bug.cgi?id=231128

Reviewed by Antti Koivisto.

Compute the length of the hanging trailing whitespace sequence.
This is in preparation for fixing imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::resetTrailingContent):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineLevelBox):
(WebCore::Layout::Line::HangingTrailingContent::add):
(WebCore::Layout::Line::HangingTrailingContent::HangingTrailingContent): Deleted.
(WebCore::Layout::Line::HangingTrailingContent::width const): Deleted.

layout/formattingContexts/inline/InlineLine.h:

(WebCore::Layout::Line::HangingTrailingContent::length const):
(WebCore::Layout::Line::HangingTrailingContent::width const):
(WebCore::Layout::Line::HangingTrailingContent::reset):

4:09 PM Changeset in webkit [283484] by weinig@apple.com

2 edits in trunk/Source/WebCore

WebXRSession's m_environmentBlendMode and m_interactionMode are never initialized
https://bugs.webkit.org/show_bug.cgi?id=231144

Reviewed by Dean Jackson.

The m_environmentBlendMode and m_interactionMode members of WebXRSession were
not being initialized to anything and therefor were giving random data. This
is not really testable, as the result is just that the tests no longer flake.

Modules/webxr/WebXRSession.h:

4:03 PM Changeset in webkit [283483] by ddkilzer@apple.com

4 edits in trunk/Source/WebCore

Build fix: Attribute IOSurfaces created by camera and decoders to responsible WebProcess
<https://bugs.webkit.org/show_bug.cgi?id=231075>
<rdar://problem/83767168>

Unreviewed build fix.

Source/WebCore:

platform/graphics/cocoa/IOSurface.mm:
Remove IOSurfaceSPI.h header already included by IOSurface.h. This should force this source file to be rebuilt as well.

Source/WebCore/PAL:

pal/spi/cocoa/IOSurfaceSPI.h:

(IOSurfaceMemoryLedgerTags):

Define enums for both HAVE(IOSURFACE_SET_OWNERSHIP) and HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY).

4:00 PM Changeset in webkit [283482] by don.olmstead@sony.com

14 edits in trunk/Source

Non-unified build fixes, early October 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=231143

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

jit/BaselineJITCode.cpp:

Source/WebCore:

Modules/filesystemaccess/FileSystemHandle.cpp:
Modules/push-api/PushMessageData.h:
html/track/InbandTextTrack.cpp:
inspector/agents/InspectorCanvasAgent.h:
loader/CrossOriginOpenerPolicy.cpp:
rendering/LegacyLineLayout.cpp:
rendering/RenderBlockFlow.cpp:

Source/WebKit:

NetworkProcess/NetworkResourceLoadParameters.h:
UIProcess/API/C/WKContext.cpp:

(WKContextTerminateGPUProcess):

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

2:57 PM Changeset in webkit [283481] by Alan Bujtas

6 edits in trunk

Incorrect preferred width computation when trimmable leading whitespace is present
https://bugs.webkit.org/show_bug.cgi?id=231139

Reviewed by Antti Koivisto.

Source/WebCore:

stripFrontSpaces should be reset to the default value whenever we are at the beginning of the line, while computing the preferred trimmed width.
This is already done for line break boxes (<br>) but not when the force line break comes from a text content with
preserved linebreak ("\n").

See WPT progressions.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

rendering/RenderText.cpp:

(WebCore::RenderText::trimmedPreferredWidths):

rendering/RenderText.h:

LayoutTests:

TestExpectations: IFC already supports these cases. Preferred width computation produced an incorrect shrink-fit width.

2:29 PM Changeset in webkit [283480] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore/PAL

Build fix: GPU Process microphone attribution SPI adoption
<https://bugs.webkit.org/show_bug.cgi?id=231034>
<rdar://problem/83732537>

pal/spi/cocoa/AVFoundationSPI.h:

(-[AVAudioSession setHostProcessAttribution:error:]):

Add SPI declaration for open source bots.

2:03 PM Changeset in webkit [283479] by Lauro Moura

2 edits in trunk/Source/JavaScriptCore

Remove control reaches end of non-void function warning

Unreviewed. Warning introduced in r283139.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::isConstantOwnedByUnlinkedCodeBlock const):

2:02 PM Changeset in webkit [283478] by basuke.suzuki@sony.com

3 edits in trunk/Source/WebKit

[PlayStation] Pass logging channel parameter to WebProcess from environment variable
https://bugs.webkit.org/show_bug.cgi?id=230726
<rdar://problem/83740947>

Reviewed by Fujii Hironori.

Added release log configuration environment variables to PlayStation port.

UIProcess/playstation/WebProcessPoolPlayStation.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

WebProcess/playstation/WebProcessPlayStation.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

12:32 PM Changeset in webkit [283477] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Line functions can compute the "extra horizontal space"
https://bugs.webkit.org/show_bug.cgi?id=231127

Reviewed by Antti Koivisto.

This is in preparation for making applyRunExpansion hanging whitespace aware.

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::removeCollapsibleContent):
(WebCore::Layout::Line::applyRunExpansion):
(WebCore::Layout::Line::visuallyCollapseHangingOverflow):

layout/formattingContexts/inline/InlineLine.h:
layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):

12:31 PM Changeset in webkit [283476] by ddkilzer@apple.com

16 edits
2 adds in trunk

WTF::RetainPtr<> allows assignment of two pointer types that are not assignable
<https://webkit.org/b/230406>
<rdar://problem/83241893>

Reviewed by Darin Adler.

Source/WebKit:

Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(transformTrustToData):

Change return type to match object.

(encodeError):

Use bridge_cast() to fix assignment.

(transformDataToTrust):

Change return type to match object.

(decodeError):

Use bridge_id_cast() to fix assignment.
Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):

Use bridge_id_cast() to fix assignment.

UIProcess/mac/WebDataListSuggestionsDropdownMac.h:
Use correct name of class that actually exists.

Source/WebKitLegacy/mac:

Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage pluginWithPath:]):

Use explicit type with RetainPtr<> to match return type.

Source/WTF:

wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):
(WTF::RetainPtr::checkType): Add.

Add type check for move constructor.

wtf/cocoa/TypeCastsCocoa.h:
Change #include to #import.

(WTF_CF_TO_NS_BRIDGE_TRANSFER): Add.
(WTF_CF_TO_NS_BRIDGE_TRANSFER): Add.

Helper macros for bridge_cast() and bridge_id_cast().

(WTF_DECLARE_CF_NS_BRIDGE_CAST): Add.

Macro used to define bridge_cast() functions for all known toll-free-bridged types.

(WTF::bridge_cast): Add.

Helper macro for toll-free-bridge casting from a known CF type to and from their Objective-C NS type. Prevents ref churn for rvale RetainPtr<> objects.

(WTF::bridge_id_cast): Add.

Helper macro for casting from any CFTypeRef to id. Prevents ref churn for rvalue RetainPtr<> objects.

(WTF::checked_objc_cast):

Simplified to match dynamic_objc_cast<> implementation in RetainPtr.h.

wtf/cocoa/VectorCocoa.h:

(WTF::createNSArray):

Change return type to match object.

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(dump):

Use bridge_cast() to fix assignment.
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add RetainPtrARC.mm and TypeCastsCocoaARC.mm to the project.
TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:
Update for dual compilation with MRR and with ARC. Change -retainCount methods to CFGetRetainCount().
Add @autoreleasepool blocks around groups of tests to find over-released bugs sooner (for future changes).
Add more CFGetRetainCount() to catch unexpected auto-released objects as well as leaks.

(TestWebKitAPI::helloWorldCStringLength): Add.
(TestWebKitAPI::TEST):

Add tests for bridge_cast() and bridge_id_cast().
Remove invalid tests after changing RetainPtr<> move constructor to check types.
TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoaARC.mm: Add.
Run tests in TypeCastsCocoa.mm with ARC enabled.
TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:

(TestWebKitAPI::TEST):

Update for dual compilation with MRR and with ARC. Change -retainCount methods to CFGetRetainCount().
Make it possible to name tests differently for MRR vs. ARC using RETAIN_PTR_TEST_NAME macro.
TestWebKitAPI/Tests/WTF/ns/RetainPtrARC.mm: Add.
Run tests in RetainPtr.mm with ARC enabled.
TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:

(readFile):

Use bridge_cast() to fix assignment.
Drive-by fix to keep NSData out of autoreleasePool.

11:48 AM Changeset in webkit [283475] by Alan Coon

1 copy in tags/Safari-612.2.9.1.3

Tag Safari-612.2.9.1.3.

11:46 AM Changeset in webkit [283474] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC][IFC] Moving hanging whitespace sequence handling to Line
https://bugs.webkit.org/show_bug.cgi?id=231126

Reviewed by Antti Koivisto.

Let the Line handle the whitespace hanging. Line::HangingTrailingContent will eventually gain more functionality.
This is also in preparation for fixing imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::visuallyCollapseHangingOverflow):
(WebCore::Layout::Line::HangingTrailingContent::HangingTrailingContent):
(WebCore::Layout::Line::HangingTrailingContent::width const):

layout/formattingContexts/inline/InlineLine.h:

(WebCore::Layout::Line::hangingWhitespaceWidth const):
(WebCore::Layout::Line::Run::shouldTrailingWhitespaceHang const):
(WebCore::Layout::Line::Run::isOverflowWhitespaceHanging const): Deleted. shouldTrailingWhitespaceHang is a more descriptive name.

layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::hangingGlyphWidth): Deleted.

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):

layout/formattingContexts/inline/InlineLineBuilder.h:

11:41 AM Changeset in webkit [283473] by Alan Coon

1 copy in tags/Safari-612.2.9.0.3

Tag Safari-612.2.9.0.3.

11:30 AM Changeset in webkit [283472] by Alan Coon

1 copy in tags/Safari-612.2.9.2.2

Tag Safari-612.2.9.2.2.

11:28 AM Changeset in webkit [283471] by Alan Coon

1 copy in tags/Safari-612.2.9.3.2

Tag Safari-612.2.9.3.2.

10:22 AM Changeset in webkit [283470] by Simon Fraser

7 edits in trunk/Source

WebCore::Length incorrectly uses memcpy() for copy constructors/operator and IPC encoding/decoding
https://bugs.webkit.org/show_bug.cgi?id=230744

Reviewed by David Kilzer.
Source/WebCore:

Copy-constructing Length by memcpy is sketchy; replace with code that initializes the appropriate
fields based on type, taking care to deref() and ref() the calc handle.

Expose isFloat() for encoding.

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValueIfCategory): Add a bit of calc logging.

platform/Length.cpp:

(WebCore::Length::Length):

platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::isFloat const):

Source/WebKit:

Safe encoding/decoding of Length requires that we encode the enum and fields separately,
and don't allow calc types (there isn't enough context in the receiving process to resolve
calc).

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Length>::encode):
(IPC::ArgumentCoder<Length>::decode):

Shared/WebCoreArgumentCoders.h:

10:19 AM Changeset in webkit [283469] by basuke.suzuki@sony.com

8 edits in trunk

Enable release log to stderr
https://bugs.webkit.org/show_bug.cgi?id=230725
<rdar://problem/83740529>

Reviewed by Michael Catanzaro.

Introduced new flags, USE_LOG_STDERR for release logging to stderr.

Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

SQLiteDatabase uses hard-coded %{public} format specifiers. Replace them with defined
macro.

No new tests because there is no behavior change.

platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::prepareStatementSlow):
(WebCore::SQLiteDatabase::prepareStatement):
(WebCore::SQLiteDatabase::prepareHeapStatementSlow):
(WebCore::SQLiteDatabase::prepareHeapStatement):

Source/WTF:

Define new compiler definitions, USE_LOG_STDERR for release logging. We don't have
modern logging backend so that dumping out to stdout/stderr is still very valuable.

wtf/Assertions.cpp:
wtf/Assertions.h:
wtf/Logger.h:

(WTF::Logger::log):
(WTF::Logger::logVerbose):

10:10 AM Changeset in webkit [283468] by mmaxfield@apple.com

2 edits in trunk/Tools

Some layout tests with Japanese glyphs fail if Japanese is included in the system "Preferred Languages" settings
https://bugs.webkit.org/show_bug.cgi?id=231112

Reviewed by Simon Fraser.

Simply set the default locale to en-US. Tests can still override it.

WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::defaults):

10:02 AM Changeset in webkit [283467] by Alan Coon

1 edit in branches/safari-611.4.2.0-branch/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp

Apply patch. rdar://problem/81175635

10:02 AM Changeset in webkit [283466] by Alan Coon

8 edits
8 adds in branches/safari-611.4.2.0-branch

Cherry-pick r281431. rdar://problem/81175635

This reverts r283414.

8:52 AM Changeset in webkit [283465] by Simon Fraser

3 edits
2 adds in trunk

REGRESSION (r283335): rubber-banding no longer locks to an axis
https://bugs.webkit.org/show_bug.cgi?id=231131

Reviewed by Tim Horton.

Source/WebCore:

r283335 introduced a bug where pulling down to rubber-band would result in sideways
motion even when the gesture was mostly vertical.

ScrollingEffectsController::modifyScrollDeltaForStretching() has some axis-locking behavior
that was broken by r283335, so restore the old behavior.

Test: fast/scrolling/mac/rubberband-axis-locking.html

platform/mac/ScrollingEffectsController.mm:

(WebCore::ScrollingEffectsController::modifyScrollDeltaForStretching):
(WebCore::isHorizontalSide): Deleted.
(WebCore::isVerticalSide): Deleted.

LayoutTests:

fast/scrolling/mac/rubberband-axis-locking-expected.txt: Added.
fast/scrolling/mac/rubberband-axis-locking.html: Added.

6:59 AM Changeset in webkit [283464] by Antti Koivisto

33 edits
2 adds in trunk/Source/WebCore

[LFC][Integration] More run->box renaming and other iterator cleanups
https://bugs.webkit.org/show_bug.cgi?id=231135

Reviewed by Alan Bujtas.

Also move TextBoxIterator to a file of its own.

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::localCaretRectForCharacterOffset):

dom/Position.cpp:

(WebCore::hasInlineRun):
(WebCore::Position::upstream const):
(WebCore::Position::downstream const):
(WebCore::searchAheadForBetterMatch):
(WebCore::Position::inlineRunAndOffset const):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextRun):
(WebCore::TextIterator::handleTextNodeFirstLetter):

editing/TextIterator.h:
layout/integration/InlineIteratorBox.cpp:

(WebCore::InlineIterator::BoxIterator::BoxIterator):
(WebCore::InlineIterator::BoxIterator::operator== const):
(WebCore::InlineIterator::BoxIterator::atEnd const):
(WebCore::InlineIterator::Box::line const):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLine):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLine):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLineIgnoringLineBreak):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLineIgnoringLineBreak):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLineInLogicalOrder):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLineInLogicalOrder):
(WebCore::InlineIterator::boxFor):
(WebCore::InlineIterator::Box::modernPath const):
(WebCore::InlineIterator::Box::legacyPath const):
(WebCore::InlineIterator::TextBox::nextTextRun const): Deleted.
(WebCore::InlineIterator::TextBox::nextTextRunInTextOrder const): Deleted.
(WebCore::InlineIterator::TextBox::selectionRect const): Deleted.
(WebCore::InlineIterator::TextBox::isCombinedText const): Deleted.
(WebCore::InlineIterator::TextBox::fontCascade const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator): Deleted.
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextRun): Deleted.
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextRunInTextOrder): Deleted.
(WebCore::InlineIterator::firstTextRunFor): Deleted.
(WebCore::InlineIterator::firstTextRunInTextOrderFor): Deleted.
(WebCore::InlineIterator::textRunFor): Deleted.
(WebCore::InlineIterator::textRunsFor): Deleted.
(WebCore::InlineIterator::runFor): Deleted.

layout/integration/InlineIteratorBox.h:

(WebCore::InlineIterator::BoxIterator::BoxIterator):
(WebCore::InlineIterator::BoxIterator::operator* const):
(WebCore::InlineIterator::BoxIterator::operator-> const):
(WebCore::InlineIterator::Box::legacyInlineBox const):
(WebCore::InlineIterator::Box::inlineBox const):
(WebCore::InlineIterator::TextBox::renderer const): Deleted.
(WebCore::InlineIterator::TextBox::legacyInlineBox const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator): Deleted.
(WebCore::InlineIterator::TextBoxIterator::operator++): Deleted.
(WebCore::InlineIterator::TextBoxIterator::operator* const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::operator-> const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::get const): Deleted.
(WebCore::InlineIterator::TextRunRange::TextRunRange): Deleted.
(WebCore::InlineIterator::TextRunRange::begin const): Deleted.
(WebCore::InlineIterator::TextRunRange::end const): Deleted.
(WebCore::InlineIterator::TextBox::hasHyphen const): Deleted.
(WebCore::InlineIterator::TextBox::TextBox): Deleted.
(WebCore::InlineIterator::TextBox::text const): Deleted.
(WebCore::InlineIterator::TextBox::start const): Deleted.
(WebCore::InlineIterator::TextBox::end const): Deleted.
(WebCore::InlineIterator::TextBox::length const): Deleted.
(WebCore::InlineIterator::TextBox::offsetForPosition const): Deleted.
(WebCore::InlineIterator::TextBox::positionForOffset const): Deleted.
(WebCore::InlineIterator::TextBox::selectableRange const): Deleted.
(WebCore::InlineIterator::TextBox::createTextRun const): Deleted.
(isType): Deleted.

layout/integration/InlineIteratorBoxLegacyPath.h:

(WebCore::InlineIterator::BoxLegacyPath::BoxLegacyPath):
(WebCore::InlineIterator::BoxLegacyPath::traverseNextTextBox):
(WebCore::InlineIterator::BoxLegacyPath::traverseNextTextBoxInTextOrder):
(WebCore::InlineIterator::BoxLegacyPath::operator== const):
(WebCore::InlineIterator::BoxLegacyPath::traverseNextInlineBoxInCacheOrder):
(WebCore::InlineIterator::BoxLegacyPath::traversePreviousInlineBoxInCacheOrder):
(WebCore::InlineIterator::BoxIteratorLegacyPath::BoxIteratorLegacyPath): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::isText const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::rect const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::isHorizontal const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::dirOverride const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::isLineBreak const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::minimumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::maximumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::bidiLevel const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::hasHyphen const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::text const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::start const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::end const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::length const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::offsetForPosition const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::positionForOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::selectableRange const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::createTextRun const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::renderer const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextTextRun): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextTextRunInTextOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traversePreviousOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traversePreviousOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::operator== const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::atEnd const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::legacyInlineBox const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::rootInlineBox const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::inlineTextBox const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::initializeLogicalOrderCacheForLine): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextInlineBoxInCacheOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traversePreviousInlineBoxInCacheOrder): Deleted.

layout/integration/InlineIteratorBoxModernPath.h:

(WebCore::InlineIterator::BoxModernPath::BoxModernPath):
(WebCore::InlineIterator::BoxModernPath::traverseNextTextBox):
(WebCore::InlineIterator::BoxModernPath::traverseNextTextBoxInTextOrder):
(WebCore::InlineIterator::BoxModernPath::operator== const):
(WebCore::InlineIterator::BoxIteratorModernPath::BoxIteratorModernPath): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::isText const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::rect const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::isHorizontal const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::dirOverride const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::isLineBreak const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::minimumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::maximumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::bidiLevel const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::hasHyphen const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::text const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::start const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::end const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::length const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::offsetForPosition const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::positionForOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::selectableRange const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::createTextRun const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::renderer const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextTextRun): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextTextRunInTextOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traversePreviousOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traversePreviousOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::operator== const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::atEnd const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::box const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::inlineContent const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextLeaf): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traversePreviousLeaf): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::setAtEnd): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::boxes const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::line const): Deleted.

layout/integration/InlineIteratorLineLegacyPath.h:

(WebCore::InlineIterator::LineIteratorLegacyPath::firstRun const):
(WebCore::InlineIterator::LineIteratorLegacyPath::lastRun const):
(WebCore::InlineIterator::LineIteratorLegacyPath::logicalStartRun const):
(WebCore::InlineIterator::LineIteratorLegacyPath::logicalEndRun const):

layout/integration/InlineIteratorLineModernPath.h:

(WebCore::InlineIterator::LineIteratorModernPath::firstRun const):
(WebCore::InlineIterator::LineIteratorModernPath::lastRun const):
(WebCore::InlineIterator::LineIteratorModernPath::logicalStartRun const):
(WebCore::InlineIterator::LineIteratorModernPath::logicalEndRun const):

layout/integration/InlineIteratorTextBox.cpp: Added.

(WebCore::InlineIterator::TextBox::nextTextBox const):
(WebCore::InlineIterator::TextBox::nextTextBoxInTextOrder const):
(WebCore::InlineIterator::TextBox::selectionRect const):
(WebCore::InlineIterator::TextBox::isCombinedText const):
(WebCore::InlineIterator::TextBox::fontCascade const):
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator):
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextBox):
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextBoxInTextOrder):
(WebCore::InlineIterator::firstTextBoxFor):
(WebCore::InlineIterator::firstTextBoxInTextOrderFor):
(WebCore::InlineIterator::textBoxFor):
(WebCore::InlineIterator::textBoxesFor):

layout/integration/InlineIteratorTextBox.h: Added.

(WebCore::InlineIterator::TextBox::renderer const):
(WebCore::InlineIterator::TextBox::legacyInlineBox const):
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator):
(WebCore::InlineIterator::TextBoxIterator::operator++):
(WebCore::InlineIterator::TextBoxIterator::operator* const):
(WebCore::InlineIterator::TextBoxIterator::operator-> const):
(WebCore::InlineIterator::TextBoxIterator::get const):
(WebCore::InlineIterator::TextBoxRange::TextBoxRange):
(WebCore::InlineIterator::TextBoxRange::begin const):
(WebCore::InlineIterator::TextBoxRange::end const):
(WebCore::InlineIterator::TextBox::hasHyphen const):
(WebCore::InlineIterator::TextBox::TextBox):
(WebCore::InlineIterator::TextBox::text const):
(WebCore::InlineIterator::TextBox::start const):
(WebCore::InlineIterator::TextBox::end const):
(WebCore::InlineIterator::TextBox::length const):
(WebCore::InlineIterator::TextBox::offsetForPosition const):
(WebCore::InlineIterator::TextBox::positionForOffset const):
(WebCore::InlineIterator::TextBox::selectableRange const):
(WebCore::InlineIterator::TextBox::createTextRun const):
(isType):

layout/integration/LayoutIntegrationCoverage.h:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::textBoxesFor const):
(WebCore::LayoutIntegration::LineLayout::boxFor const):
(WebCore::LayoutIntegration::LineLayout::textRunsFor const): Deleted.
(WebCore::LayoutIntegration::LineLayout::runFor const): Deleted.

layout/integration/LayoutIntegrationLineLayout.h:
rendering/CaretRectComputation.cpp:
rendering/LegacyInlineTextBox.h:
rendering/LegacyLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

rendering/RenderElement.cpp:

(WebCore::RenderElement::getLeadingCorner const):

rendering/RenderImage.cpp:

(WebCore::RenderImage::collectSelectionGeometries):

rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::linesBoundingBox const):
(WebCore::RenderLineBreak::absoluteRects const):
(WebCore::RenderLineBreak::absoluteQuads const):
(WebCore::RenderLineBreak::collectSelectionGeometries):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects const):
(WebCore::RenderText::collectSelectionGeometries):
(WebCore::collectAbsoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange const):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunLocation const):
(WebCore::RenderText::linesBoundingBox const):
(WebCore::RenderText::collectSelectionGeometriesForLineBoxes):
(WebCore::RenderText::caretMinOffset const):
(WebCore::RenderText::caretMaxOffset const):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil const):
(WebCore::containsOffset):
(WebCore::RenderText::hasRenderedText const):

rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):

rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::TextBoxPainter):
(WebCore::TextBoxPainter::paintDecoration):
(WebCore::TextBoxPainter::calculateUnionOfAllDocumentMarkerBounds):

rendering/TextBoxPainter.h:
rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintTextDecoration):

rendering/TextDecorationPainter.h:

(WebCore::TextDecorationPainter::setTextBox):
(WebCore::TextDecorationPainter::setTextBoxIterator): Deleted.

rendering/style/RenderStyle.cpp:
style/InlineTextBoxStyle.cpp:

12:16 AM Changeset in webkit [283463] by timothy_horton@apple.com

398 edits in trunk/Source/WebCore

Setting and RuntimeEnabledFeature names in IDL files should match those used elsewhere
https://bugs.webkit.org/show_bug.cgi?id=231129

Rubber-stamped by Sam Weinig.

No new tests; no functional change.

For ease of searching the project, the Setting/RuntimeEnabledFeature names inside
IDL files should match the names used in C++ code (specifically, they shouldn't
magically elide the -Enabled suffix, so that if you search for XFeatureEnabled,
you don't miss the IDL uses).

Modules/applepay/ApplePaySession.idl:
Modules/applepay/ApplePaySetup.idl:
Modules/applepay/ApplePaySetupFeature.idl:
Modules/async-clipboard/Clipboard.idl:
Modules/async-clipboard/ClipboardItem.idl:
Modules/async-clipboard/Navigator+Clipboard.idl:
Modules/beacon/Navigator+Beacon.idl:
Modules/cache/DOMCache.idl:
Modules/cache/DOMCacheStorage.idl:
Modules/cache/WindowOrWorkerGlobalScope+Caches.idl:
Modules/contact-picker/ContactsManager.idl:
Modules/contact-picker/Navigator+Contacts.idl:
Modules/credentialmanagement/BasicCredential.idl:
Modules/credentialmanagement/CredentialsContainer.idl:
Modules/credentialmanagement/Navigator+Credentials.idl:
Modules/encryptedmedia/MediaKeyMessageEvent.idl:
Modules/encryptedmedia/MediaKeySession.idl:
Modules/encryptedmedia/MediaKeyStatusMap.idl:
Modules/encryptedmedia/MediaKeySystemAccess.idl:
Modules/encryptedmedia/MediaKeys.idl:
Modules/encryptedmedia/Navigator+EME.idl:
Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
Modules/encryptedmedia/legacy/WebKitMediaKeySession.idl:
Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
Modules/entriesapi/DOMFileSystem.idl:
Modules/entriesapi/FileSystemDirectoryEntry.idl:
Modules/entriesapi/FileSystemDirectoryReader.idl:
Modules/entriesapi/FileSystemEntry.idl:
Modules/entriesapi/FileSystemFileEntry.idl:
Modules/entriesapi/HTMLInputElement+EntriesAPI.idl:
Modules/fetch/FetchRequest.idl:
Modules/filesystemaccess/FileSystemDirectoryHandle.idl:
Modules/filesystemaccess/FileSystemFileHandle.idl:
Modules/filesystemaccess/FileSystemHandle.idl:
Modules/filesystemaccess/StorageManager+FileSystemAccess.idl:
Modules/gamepad/Gamepad.idl:
Modules/gamepad/GamepadButton.idl:
Modules/gamepad/GamepadEvent.idl:
Modules/gamepad/Navigator+Gamepad.idl:
Modules/geolocation/GeolocationCoordinates.idl:
Modules/highlight/Highlight.idl:
Modules/highlight/HighlightRegister.idl:
Modules/mediacapabilities/AudioConfiguration.idl:
Modules/mediacapabilities/MediaCapabilities.idl:
Modules/mediacapabilities/MediaCapabilitiesDecodingInfo.idl:
Modules/mediacapabilities/MediaCapabilitiesEncodingInfo.idl:
Modules/mediacapabilities/MediaCapabilitiesInfo.idl:
Modules/mediacapabilities/MediaDecodingConfiguration.idl:
Modules/mediacapabilities/MediaEncodingConfiguration.idl:
Modules/mediacapabilities/Navigator+MediaCapabilities.idl:
Modules/mediacapabilities/VideoConfiguration.idl:
Modules/mediacontrols/MediaControlsHost.idl:
Modules/mediarecorder/BlobEvent.idl:
Modules/mediarecorder/MediaRecorder.idl:
Modules/mediarecorder/MediaRecorderErrorEvent.idl:
Modules/mediasession/MediaMetadataInit.idl:
Modules/mediasession/MediaMetadataPlaylistMixin.idl:
Modules/mediasession/MediaSessionActionDetails.idl:
Modules/mediasession/MediaSessionCoordinator.idl:
Modules/mediasession/MediaSessionCoordinatorMixin.idl:
Modules/mediasession/MediaSessionPlaylistMixin.idl:
Modules/mediasession/Navigator+MediaSession.idl:
Modules/mediasource/AudioTrack+MediaSource.idl:
Modules/mediasource/DOMURL+MediaSource.idl:
Modules/mediasource/MediaSource.idl:
Modules/mediasource/SourceBuffer.idl:
Modules/mediasource/SourceBufferList.idl:
Modules/mediasource/TextTrack+MediaSource.idl:
Modules/mediasource/VideoPlaybackQuality.idl:
Modules/mediasource/VideoTrack+MediaSource.idl:
Modules/mediastream/MediaDevices.idl:
Modules/mediastream/Navigator+MediaDevices.idl:
Modules/mediastream/RTCAnswerOptions.idl:
Modules/mediastream/RTCCertificate.idl:
Modules/mediastream/RTCConfiguration.idl:
Modules/mediastream/RTCDTMFSender.idl:
Modules/mediastream/RTCDTMFToneChangeEvent.idl:
Modules/mediastream/RTCDataChannel.idl:
Modules/mediastream/RTCDataChannelEvent.idl:
Modules/mediastream/RTCDtlsTransport.idl:
Modules/mediastream/RTCDtlsTransportState.idl:
Modules/mediastream/RTCEncodedAudioFrame.idl:
Modules/mediastream/RTCEncodedVideoFrame.idl:
Modules/mediastream/RTCError.idl:
Modules/mediastream/RTCErrorEvent.idl:
Modules/mediastream/RTCIceCandidate.idl:
Modules/mediastream/RTCIceCandidateInit.idl:
Modules/mediastream/RTCIceConnectionState.idl:
Modules/mediastream/RTCIceGatheringState.idl:
Modules/mediastream/RTCIceServer.idl:
Modules/mediastream/RTCIceTransport.idl:
Modules/mediastream/RTCIceTransportState.idl:
Modules/mediastream/RTCOfferAnswerOptions.idl:
Modules/mediastream/RTCOfferOptions.idl:
Modules/mediastream/RTCPeerConnection.idl:
Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl:
Modules/mediastream/RTCPeerConnectionIceEvent.idl:
Modules/mediastream/RTCPeerConnectionState.idl:
Modules/mediastream/RTCPriorityType.idl:
Modules/mediastream/RTCRtcpParameters.idl:
Modules/mediastream/RTCRtpCapabilities.idl:
Modules/mediastream/RTCRtpCodecCapability.idl:
Modules/mediastream/RTCRtpCodecParameters.idl:
Modules/mediastream/RTCRtpCodingParameters.idl:
Modules/mediastream/RTCRtpContributingSource.idl:
Modules/mediastream/RTCRtpDecodingParameters.idl:
Modules/mediastream/RTCRtpEncodingParameters.idl:
Modules/mediastream/RTCRtpFecParameters.idl:
Modules/mediastream/RTCRtpHeaderExtensionParameters.idl:
Modules/mediastream/RTCRtpParameters.idl:
Modules/mediastream/RTCRtpReceiver+Transform.idl:
Modules/mediastream/RTCRtpReceiver.idl:
Modules/mediastream/RTCRtpRtxParameters.idl:
Modules/mediastream/RTCRtpSFrameTransform.idl:
Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
Modules/mediastream/RTCRtpScriptTransform.idl:
Modules/mediastream/RTCRtpScriptTransformer.idl:
Modules/mediastream/RTCRtpSendParameters.idl:
Modules/mediastream/RTCRtpSender+Transform.idl:
Modules/mediastream/RTCRtpSender.idl:
Modules/mediastream/RTCRtpSynchronizationSource.idl:
Modules/mediastream/RTCRtpTransceiver.idl:
Modules/mediastream/RTCRtpTransceiverDirection.idl:
Modules/mediastream/RTCSctpTransport.idl:
Modules/mediastream/RTCSctpTransportState.idl:
Modules/mediastream/RTCSdpType.idl:
Modules/mediastream/RTCSessionDescription.idl:
Modules/mediastream/RTCSignalingState.idl:
Modules/mediastream/RTCStatsReport.idl:
Modules/mediastream/RTCTrackEvent.idl:
Modules/mediastream/RTCTransformEvent.idl:
Modules/model-element/HTMLModelElement.idl:
Modules/paymentrequest/MerchantValidationEvent.idl:
Modules/paymentrequest/PaymentAddress.idl:
Modules/paymentrequest/PaymentMethodChangeEvent.idl:
Modules/paymentrequest/PaymentRequest.idl:
Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
Modules/paymentrequest/PaymentResponse.idl:
Modules/permissions/Navigator+Permissions.idl:
Modules/permissions/PermissionDescriptor.idl:
Modules/permissions/PermissionStatus.idl:
Modules/permissions/Permissions.idl:
Modules/pictureinpicture/Document+PictureInPicture.idl:
Modules/pictureinpicture/DocumentOrShadowRoot+PictureInPicture.idl:
Modules/pictureinpicture/EnterPictureInPictureEvent.idl:
Modules/pictureinpicture/HTMLVideoElement+PictureInPicture.idl:
Modules/pictureinpicture/PictureInPictureWindow.idl:
Modules/push-api/PushEvent.idl:
Modules/push-api/PushMessageData.idl:
Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:
Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl:
Modules/remoteplayback/RemotePlayback.idl:
Modules/remoteplayback/RemotePlaybackAvailabilityCallback.idl:
Modules/speech/SpeechRecognition.idl:
Modules/speech/SpeechRecognitionAlternative.idl:
Modules/speech/SpeechRecognitionErrorEvent.idl:
Modules/speech/SpeechRecognitionEvent.idl:
Modules/speech/SpeechRecognitionResult.idl:
Modules/speech/SpeechRecognitionResultList.idl:
Modules/storage/StorageManager.idl:
Modules/streams/TransformStream.idl:
Modules/streams/TransformStreamDefaultController.idl:
Modules/webaudio/AnalyserNode.idl:
Modules/webaudio/AudioBuffer.idl:
Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioContext.idl:
Modules/webaudio/AudioParamMap.idl:
Modules/webaudio/AudioProcessingEvent.idl:
Modules/webaudio/AudioWorklet.idl:
Modules/webaudio/AudioWorkletNode.idl:
Modules/webaudio/AudioWorkletNodeOptions.idl:
Modules/webaudio/BaseAudioContext.idl:
Modules/webaudio/BiquadFilterNode.idl:
Modules/webaudio/ChannelMergerNode.idl:
Modules/webaudio/ChannelSplitterNode.idl:
Modules/webaudio/ConstantSourceNode.idl:
Modules/webaudio/ConstantSourceOptions.idl:
Modules/webaudio/ConvolverNode.idl:
Modules/webaudio/DelayNode.idl:
Modules/webaudio/DynamicsCompressorNode.idl:
Modules/webaudio/GainNode.idl:
Modules/webaudio/IIRFilterNode.idl:
Modules/webaudio/MediaElementAudioSourceNode.idl:
Modules/webaudio/MediaStreamAudioDestinationNode.idl:
Modules/webaudio/MediaStreamAudioSourceNode.idl:
Modules/webaudio/OfflineAudioContext.idl:
Modules/webaudio/OscillatorNode.idl:
Modules/webaudio/PannerNode.idl:
Modules/webaudio/PeriodicWave.idl:
Modules/webaudio/StereoPannerNode.idl:
Modules/webaudio/WaveShaperNode.idl:
Modules/webauthn/AuthenticatorAssertionResponse.idl:
Modules/webauthn/AuthenticatorAttestationResponse.idl:
Modules/webauthn/AuthenticatorResponse.idl:
Modules/webauthn/PublicKeyCredential.idl:
Modules/webdatabase/Database.idl:
Modules/webdatabase/SQLError.idl:
Modules/webdatabase/SQLResultSet.idl:
Modules/webdatabase/SQLResultSetRowList.idl:
Modules/websockets/WebSocket.idl:
Modules/webxr/Navigator+WebXR.idl:
Modules/webxr/WebXRBoundedReferenceSpace.idl:
Modules/webxr/WebXRFrame.idl:
Modules/webxr/WebXRInputSource.idl:
Modules/webxr/WebXRInputSourceArray.idl:
Modules/webxr/WebXRLayer.idl:
Modules/webxr/WebXRPose.idl:
Modules/webxr/WebXRReferenceSpace.idl:
Modules/webxr/WebXRRenderState.idl:
Modules/webxr/WebXRRigidTransform.idl:
Modules/webxr/WebXRSession.idl:
Modules/webxr/WebXRSpace.idl:
Modules/webxr/WebXRSystem.idl:
Modules/webxr/WebXRView.idl:
Modules/webxr/WebXRViewerPose.idl:
Modules/webxr/WebXRViewport.idl:
Modules/webxr/WebXRWebGLLayer.idl:
Modules/webxr/XREnvironmentBlendMode.idl:
Modules/webxr/XREye.idl:
Modules/webxr/XRHandedness.idl:
Modules/webxr/XRInputSourceEvent.idl:
Modules/webxr/XRInputSourcesChangeEvent.idl:
Modules/webxr/XRInteractionMode.idl:
Modules/webxr/XRReferenceSpaceEvent.idl:
Modules/webxr/XRReferenceSpaceType.idl:
Modules/webxr/XRRenderStateInit.idl:
Modules/webxr/XRSessionEvent.idl:
Modules/webxr/XRSessionInit.idl:
Modules/webxr/XRSessionMode.idl:
Modules/webxr/XRTargetRayMode.idl:
Modules/webxr/XRVisibilityState.idl:
Modules/webxr/XRWebGLLayerInit.idl:
accessibility/AccessibilityRole.idl:
accessibility/AriaAttributes.idl:
animation/KeyframeEffect.idl:
animation/WebAnimation.idl:
bindings/scripts/CodeGeneratorJS.pm:

(GenerateRuntimeEnableConditionalString):

bindings/scripts/test/TestConditionalIncludes.idl:
bindings/scripts/test/TestConditionallyReadWrite.idl:
bindings/scripts/test/TestDefaultToJSON.idl:
bindings/scripts/test/TestEnabledBySetting.idl:
bindings/scripts/test/TestEnabledBySettingSupplemental.idl:
bindings/scripts/test/TestEnabledForContext.idl:
bindings/scripts/test/TestGlobalObject.idl:
bindings/scripts/test/TestMixinInterface.idl:
bindings/scripts/test/TestNamespaceObject.idl:
bindings/scripts/test/TestNode.idl:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestPartialNamespaceObject.idl:
bindings/scripts/test/TestSupplemental.idl:
css/CSSCounterStyleRule.idl:
css/CSSPaintCallback.idl:
css/CSSPaintSize.idl:
css/CSSProperties.json:
css/CSSRule.idl:
css/DOMCSSCustomPropertyDescriptor.idl:
css/DOMCSSNamespace+CSSNumericFactory.idl:
css/DOMCSSNamespace+CSSPainting.idl:
css/DOMCSSNamespace+CSSPropertiesandValues.idl:
css/DOMCSSNamespace.idl:
css/ElementCSSInlineStyle.idl:
css/makeprop.pl:
css/typedom/CSSKeywordValue.idl:
css/typedom/CSSNumericValue.idl:
css/typedom/CSSOMVariableReferenceValue.idl:
css/typedom/CSSStyleImageValue.idl:
css/typedom/CSSStyleValue.idl:
css/typedom/CSSUnitValue.idl:
css/typedom/CSSUnparsedValue.idl:
css/typedom/StylePropertyMap.idl:
css/typedom/StylePropertyMapReadOnly.idl:
css/typedom/numeric/CSSMathInvert.idl:
css/typedom/numeric/CSSMathMax.idl:
css/typedom/numeric/CSSMathMin.idl:
css/typedom/numeric/CSSMathNegate.idl:
css/typedom/numeric/CSSMathProduct.idl:
css/typedom/numeric/CSSMathSum.idl:
css/typedom/numeric/CSSMathValue.idl:
css/typedom/numeric/CSSNumericArray.idl:
css/typedom/numeric/CSSNumericBaseType.idl:
css/typedom/transform/CSSMatrixComponent.idl:
css/typedom/transform/CSSPerspective.idl:
css/typedom/transform/CSSRotate.idl:
css/typedom/transform/CSSScale.idl:
css/typedom/transform/CSSSkew.idl:
css/typedom/transform/CSSSkewX.idl:
css/typedom/transform/CSSSkewY.idl:
css/typedom/transform/CSSTransformComponent.idl:
css/typedom/transform/CSSTransformValue.idl:
css/typedom/transform/CSSTranslate.idl:
dom/Attr.idl:
dom/BeforeLoadEvent.idl:
dom/BroadcastChannel.idl:
dom/DataTransfer.idl:
dom/DataTransferItem.idl:
dom/DataTransferItemList.idl:
dom/DeviceMotionEvent.idl:
dom/DeviceOrientationEvent.idl:
dom/Document+Fullscreen.idl:
dom/Document+StorageAccess.idl:
dom/Document+UndoMananger.idl:
dom/Element+Fullscreen.idl:
dom/Element.idl:
dom/ElementContentEditable.idl:
dom/GlobalEventHandlers.idl:
dom/IdleDeadline.idl:
dom/InputEvent.idl:
dom/TextDecoderStream.idl:
dom/TextDecoderStreamDecoder.idl:
dom/TextEncoderStream.idl:
dom/TextEncoderStreamEncoder.idl:
fileapi/File.idl:
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLAttachmentElement.idl:
html/HTMLButtonElement.idl:
html/HTMLCanvasElement.idl:
html/HTMLDataListElement.idl:
html/HTMLDialogElement.idl:
html/HTMLElement.idl:
html/HTMLFieldSetElement.idl:
html/HTMLFormElement.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLKeygenElement.idl:
html/HTMLLinkElement.idl:
html/HTMLMediaElement+AudioOutput.idl:
html/HTMLMediaElement.idl:
html/HTMLMenuItemElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOutputElement.idl:
html/HTMLScriptElement.idl:
html/HTMLSelectElement.idl:
html/HTMLTextAreaElement.idl:
html/ImageBitmap.idl:
html/ImageData.idl:
html/ImageDataSettings.idl:
html/MediaEncryptedEvent.idl:
html/OffscreenCanvas.idl:
html/WebKitMediaKeyError.idl:
html/canvas/CanvasPath.idl:
html/canvas/CanvasRenderingContext2D.idl:
html/canvas/CanvasRenderingContext2DSettings.idl:
html/canvas/ImageBitmapRenderingContext.idl:
html/canvas/OffscreenCanvasRenderingContext2D.idl:
html/canvas/PaintRenderingContext2D.idl:
html/canvas/WebGL2RenderingContext.idl:
html/canvas/WebGLTransformFeedback.idl:
html/canvas/WebGLVertexArrayObject.idl:
html/track/AudioTrack.idl:
html/track/TextTrack.idl:
html/track/TextTrackCue.idl:
html/track/VideoTrack.idl:
page/DOMSelection.idl:
page/DOMWindow+RequestIdleCallback.idl:
page/DOMWindow+VisualViewport.idl:
page/IntersectionObserver.idl:
page/IntersectionObserverEntry.idl:
page/Navigator+IsLoggedIn.idl:
page/NavigatorServiceWorker.idl:
page/NavigatorShare.idl:
page/NavigatorStorage.idl:
page/PerformanceNavigationTiming.idl:
page/PerformancePaintTiming.idl:
page/PerformanceResourceTiming.idl:
page/PerformanceServerTiming.idl:
page/ResizeObserver.idl:
page/ResizeObserverEntry.idl:
page/UndoItem.idl:
page/UndoManager.idl:
page/VisualViewport.idl:
page/WindowOrWorkerGlobalScope.idl:
testing/FakeXRBoundsPoint.idl:
testing/FakeXRButtonStateInit.idl:
testing/FakeXRInputSourceInit.idl:
testing/FakeXRRigidTransformInit.idl:
testing/FakeXRViewInit.idl:
testing/WebFakeXRDevice.idl:
testing/WebFakeXRInputController.idl:
testing/WebXRTest.idl:
testing/XRSimulateUserActivationFunction.idl:
workers/DedicatedWorkerGlobalScope.idl:
workers/SharedWorker.idl:
workers/SharedWorkerGlobalScope.idl:
workers/service/ExtendableEvent.idl:
workers/service/ExtendableMessageEvent.idl:
workers/service/FetchEvent.idl:
workers/service/ServiceWorker.idl:
workers/service/ServiceWorkerClient.idl:
workers/service/ServiceWorkerClients.idl:
workers/service/ServiceWorkerContainer.idl:
workers/service/ServiceWorkerGlobalScope.idl:
workers/service/ServiceWorkerRegistration.idl:
workers/service/ServiceWorkerWindowClient.idl:
worklets/PaintWorkletGlobalScope.idl:

Oct 2, 2021:

9:41 PM Changeset in webkit [283462] by commit-queue@webkit.org

10 edits in trunk/Tools

Migrate some tests from TCPServer to HTTPServer
https://bugs.webkit.org/show_bug.cgi?id=231130

Patch by Alex Christensen <achristensen@webkit.org> on 2021-10-02
Reviewed by Chris Dumez.

The former runs logic on a non-main thread and has a destructor that waits for all threads to join,
which often causes timeouts in tests. This is progress towards removing TCPServer, which has been
replaced by HTTPServer.

TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):
(respondToRangeRequests):

9:04 PM Changeset in webkit [283461] by ysuzuki@apple.com

2 edits in trunk/JSTests

[JSC] Update test262 config.yaml since OSS WebKit now uses ICU 64.2 header
https://bugs.webkit.org/show_bug.cgi?id=231121

Reviewed by Mark Lam.

test262/config.yaml:

7:13 PM Changeset in webkit [283460] by ysuzuki@apple.com

4 edits in trunk

[JSC] DateTimeFormat.resolvedOptions shouldn't return an object with other date/time properties if dateStyle or timeStyle are set
https://bugs.webkit.org/show_bug.cgi?id=231041

Reviewed by Ross Kirsling.

JSTests:

stress/intl-date-time-format-date-time-style-basic.js:

(shouldBe.JSON.stringify.o.resolvedOptions):
(shouldBe):
(shouldBe.o.format): Deleted.

Source/JavaScriptCore:

When "dateStyle" or "timestyle" option is specified in Intl.DateTimeFormat, we should not expose detailed
resolved format information in resolvedOptions, since specifying these options is not what the user of
this Intl.DateTimeFormat intended. This is specified in the spec[1] step 5-d.

[1]: https://tc39.es/ecma402/#sec-intl.datetimeformat.prototype.resolvedoptions

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::resolvedOptions const):

7:12 PM Changeset in webkit [283459] by ysuzuki@apple.com

4 edits in trunk/Source/JavaScriptCore

[JSC] Enable Intl.DisplayNames without ICU version check
https://bugs.webkit.org/show_bug.cgi?id=231122

Reviewed by Ross Kirsling.

Now every port requires ICU 61.2 or later. Since Intl.DisplayNames requires ICU 61, we can enable it without ICU version check.
This simplifies Intl.DisplayNames code.

runtime/IntlDisplayNames.cpp:

(JSC::IntlDisplayNames::initializeDisplayNames):
(JSC::IntlDisplayNames::of const):

runtime/IntlDisplayNames.h:
runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

7:11 PM Changeset in webkit [283458] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix warnings in perl script
https://bugs.webkit.org/show_bug.cgi?id=231124

Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2021-10-02
Reviewed by Simon Fraser.

Fix for warnings when running script.

css/makevalues.pl:

6:36 PM Changeset in webkit [283457] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit

Replace WKProcessPoolWeakObserver (Direct) category with (direct) property attribute
<https://webkit.org/b/231119>

Reviewed by Anders Carlsson.

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(-[WKProcessPoolWeakObserver initWithWeakPtr:]):

Merge WKProcessPoolWeakObserver (Direct) category into primary interface, and use the (direct) property attribute instead.

5:24 PM Changeset in webkit [283456] by Chris Dumez

2 edits in trunk/Source/WebKit

REGRESSION (r275455): ASSERTION FAILED: process->hasOneRef() seen with TestWebKitAPI.WKProcessPool.WarmInitialProcess
https://bugs.webkit.org/show_bug.cgi?id=231106

Reviewed by Geoffrey Garen.

r275455 added a dispatch_async() which captures a Ref<> to a WebProcessProxy. This may cause the WebProcessProxy to
outlive its WebProcessPool (prewarmed WebProcessProxies to not ref their WebProcessPool), which is not supported.
We could fix the crash by also capturing a Ref<> to the WebProcessPool in the lambda. However, in this particular
instance, it does not seem useful to extend the lifetime of the WebProcessProxy / WebProcessPool so I opted to use
a WeakPtr.

No new tests, covered by existing API test crashing in debug.

UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::sendAudioComponentRegistrations):

3:54 PM Changeset in webkit [283455] by Russell Epstein

7 edits in branches/safari-612.2.9.3-branch/Source

Cherry-pick r283444. rdar://problem/83784775

Remove JSC hack after r283410
https://bugs.webkit.org/show_bug.cgi?id=230261

Reviewed by Mark Lam.

Source/JavaScriptCore:

runtime/JSObject.cpp: (JSC::JSObject::getOwnPropertyDescriptor):
runtime/PropertySlot.h:

Source/WebCore:

We revert a hack for accessors in JSC since this is not necessary.

bindings/scripts/CodeGeneratorJS.pm: (GetJSCAttributesForAttribute):
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjDOMConstructor::construct): (WebCore::jsTestObj_searchGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::setJSTestObj_searchSetter): (WebCore::JSC_DEFINE_CUSTOM_SETTER):
bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:53 PM Changeset in webkit [283454] by Russell Epstein

3 edits in branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts

Revert "Apply patch. rdar://problem/83784775"

This reverts commit r283426.

3:51 PM Changeset in webkit [283453] by Russell Epstein

7 edits in branches/safari-612.2.9.2-branch/Source

Cherry-pick r283444. rdar://problem/83784741

Remove JSC hack after r283410
https://bugs.webkit.org/show_bug.cgi?id=230261

Reviewed by Mark Lam.

Source/JavaScriptCore:

runtime/JSObject.cpp: (JSC::JSObject::getOwnPropertyDescriptor):
runtime/PropertySlot.h:

Source/WebCore:

We revert a hack for accessors in JSC since this is not necessary.

bindings/scripts/CodeGeneratorJS.pm: (GetJSCAttributesForAttribute):
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjDOMConstructor::construct): (WebCore::jsTestObj_searchGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::setJSTestObj_searchSetter): (WebCore::JSC_DEFINE_CUSTOM_SETTER):
bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:51 PM Changeset in webkit [283452] by Russell Epstein

3 edits in branches/safari-612.2.9.2-branch/Source/WebCore/bindings/scripts

Revert "Apply patch. rdar://problem/83784741"

This reverts commit r283422.

3:51 PM Changeset in webkit [283451] by Russell Epstein

7 edits in branches/safari-612.2.9.1-branch/Source

Cherry-pick r283444. rdar://problem/83784764

Remove JSC hack after r283410
https://bugs.webkit.org/show_bug.cgi?id=230261

Reviewed by Mark Lam.

Source/JavaScriptCore:

runtime/JSObject.cpp: (JSC::JSObject::getOwnPropertyDescriptor):
runtime/PropertySlot.h:

Source/WebCore:

We revert a hack for accessors in JSC since this is not necessary.

bindings/scripts/CodeGeneratorJS.pm: (GetJSCAttributesForAttribute):
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjDOMConstructor::construct): (WebCore::jsTestObj_searchGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::setJSTestObj_searchSetter): (WebCore::JSC_DEFINE_CUSTOM_SETTER):
bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:51 PM Changeset in webkit [283450] by Russell Epstein

3 edits in branches/safari-612.2.9.1-branch/Source/WebCore/bindings/scripts

Revert "Apply patch. rdar://problem/83784764"

This reverts commit r283421.

3:45 PM Changeset in webkit [283449] by Russell Epstein

7 edits in branches/safari-612.2.9.0-branch/Source

Cherry-pick r283444. rdar://problem/83784757

Remove JSC hack after r283410
https://bugs.webkit.org/show_bug.cgi?id=230261

Reviewed by Mark Lam.

Source/JavaScriptCore:

runtime/JSObject.cpp: (JSC::JSObject::getOwnPropertyDescriptor):
runtime/PropertySlot.h:

Source/WebCore:

We revert a hack for accessors in JSC since this is not necessary.

bindings/scripts/CodeGeneratorJS.pm: (GetJSCAttributesForAttribute):
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjDOMConstructor::construct): (WebCore::jsTestObj_searchGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::setJSTestObj_searchSetter): (WebCore::JSC_DEFINE_CUSTOM_SETTER):
bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:44 PM Changeset in webkit [283448] by Russell Epstein

3 edits in branches/safari-612.2.9.0-branch/Source/WebCore/bindings/scripts

Revert "Apply patch. rdar://problem/83784757"

This reverts commit r283424.

3:18 PM Changeset in webkit [283447] by commit-queue@webkit.org

1 edit
6 adds in trunk/LayoutTests/imported/w3c

WPTs for hypot,sqrt,pow calc functions
https://bugs.webkit.org/show_bug.cgi?id=231053

Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2021-10-02
Reviewed by Simon Fraser.

web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt: Added.
web-platform-tests/css/css-values/hypot-pow-sqrt-computed.html: Added.
web-platform-tests/css/css-values/hypot-pow-sqrt-invalid-expected.txt: Added.
web-platform-tests/css/css-values/hypot-pow-sqrt-invalid.html: Added.
web-platform-tests/css/css-values/hypot-pow-sqrt-serialize-expected.txt: Added.
web-platform-tests/css/css-values/hypot-pow-sqrt-serialize.html: Added.

2:24 PM Changeset in webkit [283446] by ysuzuki@apple.com

2 edits in trunk/JSTests

Unreviewed, add reported test to our stress tests
https://bugs.webkit.org/show_bug.cgi?id=230827

While we cannot reproduce the issue successfully, adding it to our stress tests to ensure that this will never happen.

stress/intl-datetimeformat.js:

1:30 PM Changeset in webkit [283445] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

[JSC] Enable HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS on Darwin OSS build
https://bugs.webkit.org/show_bug.cgi?id=231120

Reviewed by Ross Kirsling.

We now assume that ICU is 64.2 or later in Darwin since Mojave WebKit build is no longer supported.
We enable HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS on Darwin OSS build.

runtime/IntlDateTimeFormat.h:

12:15 PM Changeset in webkit [283444] by ysuzuki@apple.com

7 edits in trunk/Source

Remove JSC hack after r283410
https://bugs.webkit.org/show_bug.cgi?id=230261

Reviewed by Mark Lam.

Source/JavaScriptCore:

runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyDescriptor):

runtime/PropertySlot.h:

Source/WebCore:

We revert a hack for accessors in JSC since this is not necessary.

bindings/scripts/CodeGeneratorJS.pm:

(GetJSCAttributesForAttribute):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjDOMConstructor::construct):
(WebCore::jsTestObj_searchGetter):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
(WebCore::setJSTestObj_searchSetter):
(WebCore::JSC_DEFINE_CUSTOM_SETTER):

bindings/scripts/test/TestObj.idl:

7:01 AM Changeset in webkit [283443] by Antti Koivisto

35 edits
8 moves in trunk/Source/WebCore

[LFC][Integration] Move inline iterators to InlineIterator namespace and rename Run* to Box*
https://bugs.webkit.org/show_bug.cgi?id=231118

Reviewed by Alan Bujtas.

Improve naming and namespacing of the iterator types.

Iterator types move from LayoutIntegration to InlineIterator namespace.

Also the iterator and the iterated type is named from Run to Box for accuracy and
the confusing word Path is dropped (since there are no name conflits in the new namespace).

This patch does not yet change any accessors or variable names to match the run->box renaming.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::localCaretRectForCharacterOffset):

dom/Position.cpp:

(WebCore::hasInlineRun):
(WebCore::Position::upstream const):
(WebCore::Position::downstream const):
(WebCore::searchAheadForBetterMatch):
(WebCore::Position::inlineRunAndOffset const):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

editing/InlineRunAndOffset.h:
editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::previousLeafOnLine const):
(WebCore::RenderedPosition::nextLeafOnLine const):

editing/RenderedPosition.h:

(WebCore::RenderedPosition::line const):

editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextRun):
(WebCore::TextIterator::handleTextNodeFirstLetter):

editing/TextIterator.h:
editing/VisiblePosition.cpp:
editing/VisibleUnits.cpp:

(WebCore::isTextOrLineBreakRun):
(WebCore::previousTextOrLineBreakRun):
(WebCore::nextTextOrLineBreakRun):
(WebCore::startTextOrLineBreakRun):
(WebCore::endTextOrLineBreakRun):
(WebCore::logicallyPreviousRun):
(WebCore::logicallyNextRun):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::absoluteLineDirectionPointToLocalPointInBlock):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks const):

layout/integration/InlineIteratorBox.cpp: Renamed from Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp.

(WebCore::InlineIterator::BoxIterator::BoxIterator):
(WebCore::InlineIterator::BoxIterator::operator== const):
(WebCore::InlineIterator::BoxIterator::atEnd const):
(WebCore::InlineIterator::Box::nextOnLine const):
(WebCore::InlineIterator::Box::previousOnLine const):
(WebCore::InlineIterator::Box::nextOnLineIgnoringLineBreak const):
(WebCore::InlineIterator::Box::previousOnLineIgnoringLineBreak const):
(WebCore::InlineIterator::Box::line const):
(WebCore::InlineIterator::Box::style const):
(WebCore::InlineIterator::TextBox::nextTextRun const):
(WebCore::InlineIterator::TextBox::nextTextRunInTextOrder const):
(WebCore::InlineIterator::TextBox::selectionRect const):
(WebCore::InlineIterator::TextBox::isCombinedText const):
(WebCore::InlineIterator::TextBox::fontCascade const):
(WebCore::InlineIterator::Box::selectionState const):
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator):
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextRun):
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextRunInTextOrder):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLine):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLine):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLineIgnoringLineBreak):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLineIgnoringLineBreak):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLineInLogicalOrder):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLineInLogicalOrder):
(WebCore::InlineIterator::firstTextRunFor):
(WebCore::InlineIterator::firstTextRunInTextOrderFor):
(WebCore::InlineIterator::textRunFor):
(WebCore::InlineIterator::runFor):
(WebCore::InlineIterator::Box::modernPath const):
(WebCore::InlineIterator::Box::legacyPath const):

layout/integration/InlineIteratorBox.h: Renamed from Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h.

(WebCore::InlineIterator::TextBox::renderer const):
(WebCore::InlineIterator::TextBox::legacyInlineBox const):
(WebCore::InlineIterator::BoxIterator::BoxIterator):
(WebCore::InlineIterator::BoxIterator::operator!= const):
(WebCore::InlineIterator::BoxIterator::operator* const):
(WebCore::InlineIterator::BoxIterator::operator-> const):
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator):
(WebCore::InlineIterator::TextBoxIterator::operator++):
(WebCore::InlineIterator::TextBoxIterator::operator* const):
(WebCore::InlineIterator::TextBoxIterator::operator-> const):
(WebCore::InlineIterator::TextBoxIterator::get const):
(WebCore::InlineIterator::TextRunRange::TextRunRange):
(WebCore::InlineIterator::TextRunRange::begin const):
(WebCore::InlineIterator::Box::Box):
(WebCore::InlineIterator::Box::isText const):
(WebCore::InlineIterator::Box::rect const):
(WebCore::InlineIterator::Box::isHorizontal const):
(WebCore::InlineIterator::Box::dirOverride const):
(WebCore::InlineIterator::Box::isLineBreak const):
(WebCore::InlineIterator::Box::minimumCaretOffset const):
(WebCore::InlineIterator::Box::maximumCaretOffset const):
(WebCore::InlineIterator::Box::bidiLevel const):
(WebCore::InlineIterator::Box::renderer const):
(WebCore::InlineIterator::Box::legacyInlineBox const):
(WebCore::InlineIterator::Box::inlineBox const):
(WebCore::InlineIterator::TextBox::hasHyphen const):
(WebCore::InlineIterator::TextBox::TextBox):
(WebCore::InlineIterator::TextBox::text const):
(WebCore::InlineIterator::TextBox::start const):
(WebCore::InlineIterator::TextBox::end const):
(WebCore::InlineIterator::TextBox::length const):
(WebCore::InlineIterator::TextBox::offsetForPosition const):
(WebCore::InlineIterator::TextBox::positionForOffset const):
(WebCore::InlineIterator::TextBox::selectableRange const):
(WebCore::InlineIterator::TextBox::createTextRun const):
(isType):

layout/integration/InlineIteratorBoxLegacyPath.h: Renamed from Source/WebCore/layout/integration/LayoutIntegrationRunIteratorLegacyPath.h.

(WebCore::InlineIterator::BoxIteratorLegacyPath::BoxIteratorLegacyPath):
(WebCore::InlineIterator::BoxIteratorLegacyPath::operator== const):
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextInlineBoxInCacheOrder):
(WebCore::InlineIterator::BoxIteratorLegacyPath::traversePreviousInlineBoxInCacheOrder):

layout/integration/InlineIteratorBoxModernPath.h: Renamed from Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h.

(WebCore::InlineIterator::BoxIteratorModernPath::BoxIteratorModernPath):
(WebCore::InlineIterator::BoxIteratorModernPath::operator== const):
(WebCore::InlineIterator::BoxIteratorModernPath::boxes const):
(WebCore::InlineIterator::BoxIteratorModernPath::line const):

layout/integration/InlineIteratorLine.cpp: Renamed from Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp.

(WebCore::InlineIterator::LineIterator::LineIterator):
(WebCore::InlineIterator::Line::next const):
(WebCore::InlineIterator::Line::previous const):
(WebCore::InlineIterator::Line::firstRun const):
(WebCore::InlineIterator::Line::lastRun const):
(WebCore::InlineIterator::Line::logicalStartRun const):
(WebCore::InlineIterator::Line::logicalEndRun const):
(WebCore::InlineIterator::Line::logicalStartRunWithNode const):
(WebCore::InlineIterator::Line::logicalEndRunWithNode const):
(WebCore::InlineIterator::Line::closestRunForPoint const):
(WebCore::InlineIterator::Line::closestRunForLogicalLeftPosition const):
(WebCore::InlineIterator::Line::blockDirectionPointInLine const):
(WebCore::InlineIterator::Line::selectionTopAdjustedForPrecedingBlock const):
(WebCore::InlineIterator::Line::selectionHeightAdjustedForPrecedingBlock const):
(WebCore::InlineIterator::Line::selectionState const):
(WebCore::InlineIterator::Line::firstSelectedBox const):
(WebCore::InlineIterator::Line::lastSelectedBox const):

layout/integration/InlineIteratorLine.h: Renamed from Source/WebCore/layout/integration/LayoutIntegrationLineIterator.h.

(WebCore::InlineIterator::LineIterator::operator* const):
(WebCore::InlineIterator::LineIterator::operator-> const):
(WebCore::InlineIterator::Line::Line):
(WebCore::InlineIterator::Line::top const):
(WebCore::InlineIterator::Line::bottom const):
(WebCore::InlineIterator::Line::selectionTop const):
(WebCore::InlineIterator::Line::selectionTopForHitTesting const):
(WebCore::InlineIterator::Line::selectionBottom const):
(WebCore::InlineIterator::Line::selectionHeight const):
(WebCore::InlineIterator::Line::lineBoxTop const):
(WebCore::InlineIterator::Line::lineBoxBottom const):
(WebCore::InlineIterator::Line::selectionRect const):
(WebCore::InlineIterator::Line::y const):
(WebCore::InlineIterator::Line::contentLogicalLeft const):
(WebCore::InlineIterator::Line::contentLogicalRight const):
(WebCore::InlineIterator::Line::contentLogicalWidth const):
(WebCore::InlineIterator::Line::logicalHeight const):
(WebCore::InlineIterator::Line::isHorizontal const):
(WebCore::InlineIterator::Line::baselineType const):
(WebCore::InlineIterator::Line::containingBlock const):
(WebCore::InlineIterator::Line::legacyRootInlineBox const):
(WebCore::InlineIterator::Line::isFirst const):

layout/integration/InlineIteratorLineLegacyPath.h: Renamed from Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h.

layout/integration/InlineIteratorLineModernPath.h: Renamed from Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h.

(WebCore::InlineIterator::LineIteratorModernPath::LineIteratorModernPath):
(WebCore::InlineIterator::LineIteratorModernPath::firstRun const):
(WebCore::InlineIterator::LineIteratorModernPath::lastRun const):
(WebCore::InlineIterator::LineIteratorModernPath::logicalStartRun const):
(WebCore::InlineIterator::LineIteratorModernPath::logicalEndRun const):
(WebCore::InlineIterator::LineIteratorModernPath::lines const):
(WebCore::InlineIterator::LineIteratorModernPath::line const):

layout/integration/LayoutIntegrationInlineContent.cpp:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::textRunsFor const):
(WebCore::LayoutIntegration::LineLayout::runFor const):
(WebCore::LayoutIntegration::LineLayout::firstLine const):
(WebCore::LayoutIntegration::LineLayout::lastLine const):

layout/integration/LayoutIntegrationLineLayout.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::TextBoxIterator::TextBoxIterator):
(WebCore::TextBoxIterator::operator==):
(WebCore::TextBoxIterator::operator!=):
(WebCore::GraphicsContext::drawBidiText):
(WebCore::TextRunIterator::TextRunIterator): Deleted.
(WebCore::TextRunIterator::offset const): Deleted.
(WebCore::TextRunIterator::increment): Deleted.
(WebCore::TextRunIterator::atEnd const): Deleted.
(WebCore::TextRunIterator::current const): Deleted.
(WebCore::TextRunIterator::direction const): Deleted.
(WebCore::TextRunIterator::operator==): Deleted.
(WebCore::TextRunIterator::operator!=): Deleted.

rendering/CaretRectComputation.cpp:

(WebCore::computeCaretRectForLinePosition):
(WebCore::computeCaretRectForText):

rendering/LegacyInlineTextBox.h:
rendering/LegacyLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForBorderFit const):
(WebCore::RenderBlockFlow::adjustSelectionTopForPrecedingBlock const):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::positionForRun):
(WebCore::RenderBlockFlow::findClosestTextAtAbsolutePoint):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

rendering/RenderBox.cpp:
rendering/RenderElement.cpp:

(WebCore::RenderElement::getLeadingCorner const):

rendering/RenderImage.cpp:

(WebCore::RenderImage::collectSelectionGeometries):

rendering/RenderLineBreak.cpp:

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects const):
(WebCore::RenderText::collectSelectionGeometries):
(WebCore::boundariesForTextRun):
(WebCore::ellipsisRectForTextRun):
(WebCore::collectAbsoluteQuads):
(WebCore::localQuadForTextRun):
(WebCore::RenderText::absoluteQuadsForRange const):
(WebCore::lineDirectionPointFitsInBox):
(WebCore::createVisiblePositionForBox):
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunLocation const):
(WebCore::RenderText::linesBoundingBox const):
(WebCore::RenderText::collectSelectionGeometriesForLineBoxes):
(WebCore::RenderText::caretMinOffset const):
(WebCore::RenderText::caretMaxOffset const):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil const):
(WebCore::containsOffset):
(WebCore::RenderText::hasRenderedText const):

rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):

rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::TextBoxPainter):
(WebCore::TextBoxPainter::paintDecoration):
(WebCore::textPosition):
(WebCore::TextBoxPainter::calculateUnionOfAllDocumentMarkerBounds):
(WebCore::TextBoxPainter::calculateDocumentMarkerBounds):

rendering/TextBoxPainter.h:
rendering/TextDecorationPainter.h:

(WebCore::TextDecorationPainter::setTextBoxIterator):
(WebCore::TextDecorationPainter::setTextRunIterator): Deleted.

style/InlineTextBoxStyle.cpp:

(WebCore::minLogicalTopForTextDecorationLine):
(WebCore::maxLogicalBottomForTextDecorationLine):
(WebCore::computeUnderlineOffset):
(WebCore::visualOverflowForDecorations):

style/InlineTextBoxStyle.h:

6:51 AM Changeset in webkit [283442] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Pass in the correct style when adding a run to Line
https://bugs.webkit.org/show_bug.cgi?id=231100

Reviewed by Antti Koivisto.

This is in preparation for supporting first-line style.

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineBuilder::handleInlineContent):
(WebCore::Layout::LineBuilder::commitPartialContent):
(WebCore::Layout::LineBuilder::rebuildLine):

6:40 AM Changeset in webkit [283441] by cathiechen

4 edits in trunk/Source/WebCore

[Performance] Optimize RenderLayer::establishesTopLayer
https://bugs.webkit.org/show_bug.cgi?id=231016

Reviewed by Simon Fraser.

This patch added isInTopLayerOrBackdrop to reduce the times of calling renderer().element() in RenderLayer::establishesTopLayer.
And isInTopLayerOrBackdrop can be shared in Adjuster.

dom/Element.h:

(WebCore::isInTopLayerOrBackdrop):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::establishesTopLayer const):

style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):
(WebCore::Style::Adjuster::adjustDisplayContentsStyle const):

6:34 AM Changeset in webkit [283440] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Do not reuse the overflowing width on the next line when first line style is different
https://bugs.webkit.org/show_bug.cgi?id=231107

Reviewed by Antti Koivisto.

Let's compute the leading text content width at the next line (instead of reusing the overflowing trailing width), when the first line style is present and font-cascades differ.

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::handleInlineContent):

5:38 AM Changeset in webkit [283439] by Ziran Sun

7 edits in trunk

[css-grid] Accommodate spanning items crossing flexible tracks
https://bugs.webkit.org/show_bug.cgi?id=230252

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Three tests are passing and the test expectation files are updated.

web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001-expected.txt:
web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002-expected.txt:
web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-003-expected.txt:

Source/WebCore:

CSS spec has added one more step at https://drafts.csswg.org/css-grid/#algo-spanning-flex-items
for resolving intrinsic track sizes. Basically, increasing sizes to accommodate spanning items
crossing flexible tracks instead of ignoring their contents completely.

This patch is an import of obrufau's work in chromium. Initial CL is at
https://chromium-review.googlesource.com/c/chromium/src/+/1492337/16..20.
The performance issue caused by the patch were fixed at https://bugs.webkit.org/show_bug.cgi?id=207852
for webkit and https://bugs.chromium.org/p/chromium/issues/detail?id=1021929 for chromium.
This change also addresses web compat issue raised at https://github.com/w3c/csswg-drafts/issues/4783.

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::initialGrowthLimit const):
(WebCore::GridTrackSizingAlgorithm::spanningItemCrossesFlexibleSizedTracks const):
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItems):
(WebCore::getSizeDistributionWeight):
(WebCore::distributeItemIncurredIncreaseToTrack):
(WebCore::distributeItemIncurredIncreases):
(WebCore::GridTrackSizingAlgorithm::distributeSpaceToTracks const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):

rendering/GridTrackSizingAlgorithm.h:

(WebCore::GridTrackSizingAlgorithmStrategy::distributeSpaceToTracks const):

4:57 AM Changeset in webkit [283438] by youenn@apple.com

22 edits
1 add in trunk

Add support for ServiceWorkerGlobalScope push event handler
https://bugs.webkit.org/show_bug.cgi?id=231008
<rdar://problem/83710760>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/push-api/idlharness.https.any.serviceworker-expected.txt:

Source/WebCore:

Implement https://w3c.github.io/push-api/#receiving-a-push-message step 6.
In particular we ensure that if any waitUntil promise rejects, the push event is considered to fail.
This status should then be sent back to the emiter of the push message to decide whether to acknowledge the message, retry it or discard it.

We keep push API completion handler in a map to ensure we respond to them even if the service worker gets terminated while processing the push event.

Add necessary internals API to enable testing within the service worker itself.

Covered by added subtests in http/wpt/service-workers/pushEvent.any.serviceworker.html.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl: Added.
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/EventNames.h:
testing/ServiceWorkerInternals.cpp:
testing/ServiceWorkerInternals.h:
testing/ServiceWorkerInternals.idl:
workers/service/context/SWContextManager.cpp:
workers/service/context/SWContextManager.h:
workers/service/context/ServiceWorkerThread.cpp:
workers/service/context/ServiceWorkerThread.h:
workers/service/context/ServiceWorkerThreadProxy.cpp:
workers/service/context/ServiceWorkerThreadProxy.h:

LayoutTests:

http/wpt/push-api/pushEvent.any.js:
http/wpt/push-api/pushEvent.any.serviceworker-expected.txt:

2:07 AM Changeset in webkit [283437] by commit-queue@webkit.org

6 edits
2 adds in trunk/Source

[GLib] Media session manager unable to handle more than one session
https://bugs.webkit.org/show_bug.cgi?id=230250

Patch by Philippe Normand <pnormand@igalia.com> on 2021-10-02
Reviewed by Adrian Perez de Castro.

Source/WebCore:

Each session now maintains its own connection to the D-Bus session, allowing to safely
expose the corresponding MPRIS objecs on the bus. Most of the D-Bus and GVariant handling
has been refactored to the new MediaSessionGLib module.

platform/SourcesGLib.txt:
platform/audio/glib/MediaSessionGLib.cpp: Added.

(WebCore::getCommand):
(WebCore::handleMethodCall):
(WebCore::getMprisProperty):
(WebCore::handleGetProperty):
(WebCore::handleSetProperty):
(WebCore::MediaSessionGLib::create):
(WebCore::MediaSessionGLib::MediaSessionGLib):
(WebCore::MediaSessionGLib::~MediaSessionGLib):
(WebCore::MediaSessionGLib::nameLost):
(WebCore::MediaSessionGLib::emitPositionChanged):
(WebCore::MediaSessionGLib::updateNowPlaying):
(WebCore::MediaSessionGLib::getMetadataAsGVariant):
(WebCore::MediaSessionGLib::getPlaybackStatusAsGVariant):
(WebCore::MediaSessionGLib::emitPropertiesChanged):
(WebCore::MediaSessionGLib::playbackStatusChanged):
(WebCore::MediaSessionGLib::getActiveSessionPosition):

platform/audio/glib/MediaSessionGLib.h: Added.

(WebCore::MediaSessionGLib::manager const):

platform/audio/glib/MediaSessionManagerGLib.cpp:

(WebCore::PlatformMediaSessionManager::create):
(WebCore::MediaSessionManagerGLib::MediaSessionManagerGLib):
(WebCore::MediaSessionManagerGLib::addSession):
(WebCore::MediaSessionManagerGLib::removeSession):
(WebCore::MediaSessionManagerGLib::sessionStateChanged):
(WebCore::MediaSessionManagerGLib::clientCharacteristicsChanged):
(WebCore::MediaSessionManagerGLib::updateNowPlayingInfo):

platform/audio/glib/MediaSessionManagerGLib.h:

(WebCore::MediaSessionManagerGLib::mprisInterface const):

Source/WTF:

wtf/glib/GRefPtr.h: Forward-declare GDBusConnection.

2:04 AM Changeset in webkit [283436] by commit-queue@webkit.org

3 edits in trunk

[GTK][WPE] Enable bwrap launcher build on bots
https://bugs.webkit.org/show_bug.cgi?id=230969

Patch by Philippe Normand <pnormand@igalia.com> on 2021-10-02
Reviewed by Michael Catanzaro.

Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed