Context Navigation

← Previous Period
Next Period →

Timeline

Nov 6, 2021:

9:07 PM Changeset in webkit [285389] by commit-queue@webkit.org

6 edits in trunk

AX: WebKit1 PluginViewBase objects with an associated widget()->platformWidget() should be considered attachments
https://bugs.webkit.org/show_bug.cgi?id=232759

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-06
Reviewed by Chris Fleizach.

Source/WebCore:

In https://bugs.webkit.org/show_bug.cgi?id=229556 (AX: Make PDFs
loaded via <embed> accessible), we changed AccessibilityRenderObject::isAttachment
to return false if the underlying object represented a PluginViewBase
under the assumption that if a PluginViewBase existed, the object must
be a WebKit2 plugin. That assumption is wrong, because in certain
scenarios an object can be a WebKit1 PluginViewBase (e.g. attachments
inserted by WebKit1 webviews).

This patch changes isAttachment to only return false if the
PluginViewBase doesn't also have an associated platformWidget, which
should be present in WebKit1 only.

This patch also fixes a bug in the Mac -[WebAccessibilityObjectWrapper
subrole]. For objects with a role of group and no children, we
returned a subrole of AXEmptyGroup. However, we didn't check for the
presence of renderWidgetChildren that a group may have.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isAttachment const):
Consider PluginViewBase objects with an associated platformWidget to
be attachments.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper subrole]):
Don't return AXEmptyGroup subrole for objects with
renderWidgetChildren.

LayoutTests:

This patch changes the Mac WebAccessibilityObjectWrapper to not return
an AXEmptyGroup subrole for objects with renderWidgetChildren.

accessibility/mac/basic-embed-pdf-accessibility-expected.txt:
accessibility/mac/basic-embed-pdf-accessibility.html:

Add expectation that the embed container doesn't have an AXEmptyGroup
subrole.

5:34 PM Changeset in webkit [285388] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Fix GTK build after r285381.
https://bugs.webkit.org/show_bug.cgi?id=232657

Unreviewed.

No new tests because there is no behavior change.

Modules/WebGPU/GPUShaderModuleDescriptor.h:

4:58 PM Changeset in webkit [285387] by Simon Fraser

14 edits in trunk/Source/WebCore

Improve ScrollAnimation logging
https://bugs.webkit.org/show_bug.cgi?id=232789

Reviewed by Wenson Hsieh.

Add ScrollAnimation::debugDescription() and implement in concrete subclasses so each
can dump more information about the animation. In particular, the destination of
a momentum scroll is useful for debugging.

Improve logging at some locations that start animations.

platform/ScrollAnimation.cpp:

(WebCore::operator<<):

platform/ScrollAnimation.h:
platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::debugDescription const):

platform/ScrollAnimationKinetic.h:
platform/ScrollAnimationMomentum.cpp:

(WebCore::ScrollAnimationMomentum::debugDescription const):

platform/ScrollAnimationMomentum.h:
platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::debugDescription const):

platform/ScrollAnimationSmooth.h:
platform/ScrollingEffectsController.cpp:

(WebCore::ScrollingEffectsController::startAnimatedScrollToDestination):
(WebCore::ScrollingEffectsController::startMomentumScrollWithInitialVelocity):

platform/ScrollingEffectsController.h:
platform/mac/ScrollAnimationRubberBand.h:
platform/mac/ScrollAnimationRubberBand.mm:

(WebCore::ScrollAnimationRubberBand::debugDescription const):

platform/mac/ScrollingEffectsController.mm:

(WebCore::ScrollingEffectsController::startRubberBandAnimation): The return value isn't used
by the caller but is a convenient way to avoid an unused variable warning.

4:39 PM Changeset in webkit [285386] by ddkilzer@apple.com

6 edits
81 deletes in trunk

Remove empty directories from from svn.webkit.org repository as of r285357
<https://webkit.org/b/232773>

Unreviewed clean up.

LayoutTests:

canvas: Removed.
platform/glib/imported/w3c/web-platform-tests/cors: Removed.
platform/glib/imported/w3c/web-platform-tests/dom/events: Removed.
platform/glib/imported/w3c/web-platform-tests/eventsource: Removed.
platform/glib/imported/w3c/web-platform-tests/svg/shapes/scripted: Removed.
platform/gtk/fast/forms/fieldset: Removed.
platform/gtk/imported/w3c/web-platform-tests/css/css-images: Removed.
platform/gtk/imported/w3c/web-platform-tests/media-source: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/animations: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/embedded: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/pservers: Removed.
platform/gtk/imported/w3c/web-platform-tests/svg/struct: Removed.
platform/gtk/media/W3C: Removed.
platform/gtk/media/media-source: Removed.
platform/gtk/media/mediacapabilities: Removed.
platform/gtk/webaudio: Removed.
platform/ios-14-wk2/imported/w3c/web-platform-tests/css: Removed.
platform/ios-simulator/webgl/2.0.0/conformance/buffers: Removed.
platform/ios-simulator/webgl/2.0.0/conformance/glsl: Removed.
platform/ios-simulator/webgl/2.0.0/conformance/reading: Removed.
platform/ios-wk2/fast/clip: Removed.
platform/ios-wk2/fast/dom/Window: Removed.
platform/ios-wk2/fast/multicol: Removed.
platform/ios-wk2/http/tests/adClickAttribution: Removed.
platform/ios-wk2/http/tests/security: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/html/webappapis: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting: Removed.
platform/ios/compositing/contents-opaque: Removed.
platform/ios/css3/calc: Removed.
platform/ios/fast/events/constructors: Removed.
platform/ios/imported/w3c/web-platform-tests/cors: Removed.
platform/ios/imported/w3c/web-platform-tests/fetch/api/basic: Removed.
platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element: Removed.
platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element: Removed.
platform/ios/imported/w3c/web-platform-tests/html/semantics/interactive-elements: Removed.
platform/ios/imported/w3c/web-platform-tests/web-animations: Removed.
platform/mac-mojave/imported/w3c/web-platform-tests/WebCryptoAPI: Removed.
platform/mac-wk1/fast/canvas: Removed.
platform/mac-wk1/http/wpt/html/browsers: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/css/geometry: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/joint-session-history: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/svg: Removed.
platform/mac-wk1/inspector/model: Removed.
platform/mac-wk2/canvas: Removed.
platform/mac-wk2/editing/style: Removed.
platform/mac-wk2/fast/frames/flattening: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/embedded-content: Removed.
platform/mac-wk2/media: Removed.
platform/mac/canvas: Removed.
platform/mac/editing/mac/selection: Removed.
platform/mac/fast/dom/HTMLImageElement/resources: Removed.
platform/mac/imported/w3c/web-platform-tests/IndexedDB: Removed.
platform/mac/imported/w3c/web-platform-tests/cors: Removed.
platform/mac/imported/w3c/web-platform-tests/css/css-masking: Removed.
platform/mac/security: Removed.
platform/mac/userscripts: Removed.
platform/win-7sp0/media/W3C/audio: Removed.
platform/win/canvas: Removed.
platform/wincairo/css3/calc: Removed.
platform/wk2/http/tests/contentdispositionattachmentsandbox: Removed.
platform/wk2/http/tests/contentextensions: Removed.
platform/wk2/imported/w3c/web-platform-tests/html/browsers: Removed.
platform/wpe/imported/w3c/web-platform-tests/css/css-images: Removed.
platform/wpe/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy: Removed.
platform/wpe/imported/w3c/web-platform-tests/html/webappapis: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/embedded: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/pservers: Removed.
platform/wpe/imported/w3c/web-platform-tests/svg/struct: Removed.

Source/ThirdParty/ANGLE:

src/id: Removed.
src/libANGLE/renderer/metal/shaders/compiled: Removed.
src/tests/perf_tests/restricted_traces: Removed.

Source/WebKitLegacy/mac:

Plugins/Hosted: Removed.

Tools:

WebKitTestRunner/WebKitTestRunnerApp/en.lproj: Removed.

Tools/buildstream:

patches/fdo: Removed.
patches/mesa: Removed.

Websites/perf.webkit.org:

public/js: Removed.
public/v2/js: Removed.

4:30 PM Changeset in webkit [285385] by mmaxfield@apple.com

4 edits in trunk/Source/WebCore

Fixing style checks in WebGPU bindings code
https://bugs.webkit.org/show_bug.cgi?id=232790

Unreviewed.

No new tests because there is no behavior change.

Modules/WebGPU/GPUCompilationMessage.cpp:
Modules/WebGPU/GPUComputePipeline.h:
Modules/WebGPU/GPUDevice.h:

4:17 PM Changeset in webkit [285384] by mmaxfield@apple.com

11 edits
28 copies in trunk/Source/WebCore

font-synthesis inline/computed style should be in canonical order.
https://bugs.webkit.org/show_bug.cgi?id=186344

Patch by Joonghun Park <jh718.park@samsung.com> on 2021-11-06
Reviewed by Myles C. Maxfield.

Per the spec, https://drafts.csswg.org/css-fonts/#font-synthesis.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontSynthesisFromStyle):

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontSynthesis):

4:07 PM Changeset in webkit [285383] by jh718.park@samsung.com

32 edits in trunk

font-synthesis inline/computed style should be in canonical order.
https://bugs.webkit.org/show_bug.cgi?id=186344

Reviewed by Myles C. Maxfield.

Per the spec, https://drafts.csswg.org/css-fonts/#font-synthesis.

LayoutTests/imported/w3c:

web-platform-tests/css/css-fonts/inheritance-expected.txt:
web-platform-tests/css/css-fonts/parsing/font-synthesis-computed-expected.txt:
web-platform-tests/css/css-fonts/parsing/font-synthesis-valid-expected.txt:
web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontSynthesisFromStyle):

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontSynthesis):

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-font-family-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css3-text/font-synthesis-parse-expected.txt:
fast/css3-text/font-synthesis-parse.html:
fast/text/font-synthesis-parsing-expected.txt:
fast/text/font-synthesis-parsing.html:
platform/glib/fast/css/getComputedStyle/computed-style-expected.txt:
platform/glib/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/glib/svg/css/getComputedStyle-basic-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/ios/svg/css/getComputedStyle-basic-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/mac/svg/css/getComputedStyle-basic-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

4:04 PM Changeset in webkit [285382] by mmaxfield@apple.com

20 edits
69 copies
9 adds in trunk/Source/WebCore

[WebGPU] Bindings Part 7: Bring back command encoder bindings code
https://bugs.webkit.org/show_bug.cgi?id=232661

Reviewed by Dean Jackson.

This is the seventh chunk of bindings code, brought back from r280467.
This chunk includes the command encoder objects.
The objects have no methods inside them yet - those will come later.

No new tests because there is no behavior change yet.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/WebGPU/GPUColorDict.h: Copied from Source/WebCore/Modules/WebGPU/GPURenderPipeline.cpp.
Modules/WebGPU/GPUColorDict.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUCommandBuffer.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.

(WebCore::GPUCommandBuffer::label const):
(WebCore::GPUCommandBuffer::setLabel):

Modules/WebGPU/GPUCommandBuffer.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.

(WebCore::GPUCommandBuffer::create):
(WebCore::GPUCommandBuffer::GPUCommandBuffer):

Modules/WebGPU/GPUCommandBuffer.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUCommandBufferDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUCommandBufferDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPUCommandEncoder.cpp: Added.

(WebCore::GPUCommandEncoder::label const):
(WebCore::GPUCommandEncoder::setLabel):
(WebCore::GPUCommandEncoder::beginRenderPass):
(WebCore::GPUCommandEncoder::beginComputePass):
(WebCore::GPUCommandEncoder::copyBufferToBuffer):
(WebCore::GPUCommandEncoder::copyBufferToTexture):
(WebCore::GPUCommandEncoder::copyTextureToBuffer):
(WebCore::GPUCommandEncoder::copyTextureToTexture):
(WebCore::GPUCommandEncoder::fillBuffer):
(WebCore::GPUCommandEncoder::pushDebugGroup):
(WebCore::GPUCommandEncoder::popDebugGroup):
(WebCore::GPUCommandEncoder::insertDebugMarker):
(WebCore::GPUCommandEncoder::writeTimestamp):
(WebCore::GPUCommandEncoder::resolveQuerySet):
(WebCore::GPUCommandEncoder::finish):

Modules/WebGPU/GPUCommandEncoder.h: Added.

(WebCore::GPUCommandEncoder::create):

Modules/WebGPU/GPUCommandEncoder.idl: Added.
Modules/WebGPU/GPUCommandEncoderDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUCommandEncoderDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPUCompilationMessage.h:

(WebCore::GPUCompilationMessage::GPUCompilationMessage): Deleted.

Modules/WebGPU/GPUComputePassDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPURenderPipeline.cpp.
Modules/WebGPU/GPUComputePassDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUComputePassEncoder.cpp: Added.

(WebCore::GPUComputePassEncoder::label const):
(WebCore::GPUComputePassEncoder::setLabel):
(WebCore::GPUComputePassEncoder::setPipeline):
(WebCore::GPUComputePassEncoder::dispatch):
(WebCore::GPUComputePassEncoder::dispatchIndirect):
(WebCore::GPUComputePassEncoder::beginPipelineStatisticsQuery):
(WebCore::GPUComputePassEncoder::endPipelineStatisticsQuery):
(WebCore::GPUComputePassEncoder::endPass):
(WebCore::GPUComputePassEncoder::setBindGroup):
(WebCore::GPUComputePassEncoder::pushDebugGroup):
(WebCore::GPUComputePassEncoder::popDebugGroup):
(WebCore::GPUComputePassEncoder::insertDebugMarker):

Modules/WebGPU/GPUComputePassEncoder.h: Copied from Source/WebCore/Modules/WebGPU/GPURenderPipeline.h.

(WebCore::GPUComputePassEncoder::create):

Modules/WebGPU/GPUComputePassEncoder.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUComputePassTimestampLocation.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUComputePassTimestampLocation.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPUComputePassTimestampWrite.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPUComputePassTimestampWrite.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUDevice.cpp:

(WebCore::GPUDevice::createShaderModule):
(WebCore::GPUDevice::createComputePipeline):
(WebCore::GPUDevice::createRenderPipeline):
(WebCore::GPUDevice::createComputePipelineAsync):
(WebCore::GPUDevice::createRenderPipelineAsync):
(WebCore::GPUDevice::createCommandEncoder):
(WebCore::GPUDevice::createRenderBundleEncoder):
(WebCore::GPUDevice::createQuerySet):

Modules/WebGPU/GPUDevice.h:
Modules/WebGPU/GPUDevice.idl:
Modules/WebGPU/GPUExtent3DDict.h:
Modules/WebGPU/GPUImageCopyBuffer.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUImageCopyBuffer.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPUImageCopyExternalImage.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPUImageCopyExternalImage.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUImageCopyTexture.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPUImageCopyTexture.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUImageCopyTextureTagged.h: Copied from Source/WebCore/Modules/WebGPU/GPURenderPipeline.cpp.
Modules/WebGPU/GPUImageCopyTextureTagged.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUImageDataLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUImageDataLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPULoadOp.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPULoadOp.idl: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUOrigin2DDict.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPUOrigin2DDict.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUOrigin3DDict.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPUOrigin3DDict.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUPipelineStatisticName.h: Copied from Source/WebCore/Modules/WebGPU/GPURenderPipeline.cpp.
Modules/WebGPU/GPUPipelineStatisticName.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUPowerPreference.idl:
Modules/WebGPU/GPUProgrammablePassEncoder.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUQuerySet.cpp: Copied from Source/WebCore/Modules/WebGPU/GPURenderPipeline.cpp.

(WebCore::GPUQuerySet::label const):
(WebCore::GPUQuerySet::setLabel):
(WebCore::GPUQuerySet::destroy):

Modules/WebGPU/GPUQuerySet.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.

(WebCore::GPUQuerySet::create):

Modules/WebGPU/GPUQuerySet.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUQuerySetDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPUQuerySetDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPUQueryType.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUQueryType.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPUQueue.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUTexture.cpp.

(WebCore::GPUQueue::label const):
(WebCore::GPUQueue::setLabel):
(WebCore::GPUQueue::submit):
(WebCore::GPUQueue::onSubmittedWorkDone):
(WebCore::GPUQueue::writeBuffer):
(WebCore::GPUQueue::writeTexture):
(WebCore::GPUQueue::copyExternalImageToTexture):

Modules/WebGPU/GPUQueue.h: Copied from Source/WebCore/Modules/WebGPU/GPURenderPipeline.h.

(WebCore::GPUQueue::create):

Modules/WebGPU/GPUQueue.idl: Added.
Modules/WebGPU/GPURenderBundle.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.

(WebCore::GPURenderBundle::label const):
(WebCore::GPURenderBundle::setLabel):

Modules/WebGPU/GPURenderBundle.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.

(WebCore::GPURenderBundle::create):

Modules/WebGPU/GPURenderBundle.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPURenderBundleDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPURenderBundleDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPURenderBundleEncoder.cpp: Added.

(WebCore::GPURenderBundleEncoder::label const):
(WebCore::GPURenderBundleEncoder::setLabel):
(WebCore::GPURenderBundleEncoder::setPipeline):
(WebCore::GPURenderBundleEncoder::setIndexBuffer):
(WebCore::GPURenderBundleEncoder::setVertexBuffer):
(WebCore::GPURenderBundleEncoder::draw):
(WebCore::GPURenderBundleEncoder::drawIndexed):
(WebCore::GPURenderBundleEncoder::drawIndirect):
(WebCore::GPURenderBundleEncoder::drawIndexedIndirect):
(WebCore::GPURenderBundleEncoder::setBindGroup):
(WebCore::GPURenderBundleEncoder::pushDebugGroup):
(WebCore::GPURenderBundleEncoder::popDebugGroup):
(WebCore::GPURenderBundleEncoder::insertDebugMarker):
(WebCore::GPURenderBundleEncoder::finish):

Modules/WebGPU/GPURenderBundleEncoder.h: Added.

(WebCore::GPURenderBundleEncoder::create):

Modules/WebGPU/GPURenderBundleEncoder.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPURenderBundleEncoderDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPURenderBundleEncoderDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPURenderEncoderBase.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPURenderPassColorAttachment.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPURenderPassColorAttachment.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPURenderPassDepthStencilAttachment.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPURenderPassDepthStencilAttachment.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPURenderPassDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPURenderPassDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPURenderPassEncoder.cpp: Added.

(WebCore::GPURenderPassEncoder::label const):
(WebCore::GPURenderPassEncoder::setLabel):
(WebCore::GPURenderPassEncoder::setPipeline):
(WebCore::GPURenderPassEncoder::setIndexBuffer):
(WebCore::GPURenderPassEncoder::setVertexBuffer):
(WebCore::GPURenderPassEncoder::draw):
(WebCore::GPURenderPassEncoder::drawIndexed):
(WebCore::GPURenderPassEncoder::drawIndirect):
(WebCore::GPURenderPassEncoder::drawIndexedIndirect):
(WebCore::GPURenderPassEncoder::setBindGroup):
(WebCore::GPURenderPassEncoder::pushDebugGroup):
(WebCore::GPURenderPassEncoder::popDebugGroup):
(WebCore::GPURenderPassEncoder::insertDebugMarker):
(WebCore::GPURenderPassEncoder::setViewport):
(WebCore::GPURenderPassEncoder::setScissorRect):
(WebCore::GPURenderPassEncoder::setBlendConstant):
(WebCore::GPURenderPassEncoder::setStencilReference):
(WebCore::GPURenderPassEncoder::beginOcclusionQuery):
(WebCore::GPURenderPassEncoder::endOcclusionQuery):
(WebCore::GPURenderPassEncoder::beginPipelineStatisticsQuery):
(WebCore::GPURenderPassEncoder::endPipelineStatisticsQuery):
(WebCore::GPURenderPassEncoder::executeBundles):
(WebCore::GPURenderPassEncoder::endPass):

Modules/WebGPU/GPURenderPassEncoder.h: Added.

(WebCore::GPURenderPassEncoder::create):

Modules/WebGPU/GPURenderPassEncoder.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPURenderPassLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPURenderPassLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPURenderPassTimestampLocation.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPURenderPassTimestampLocation.idl: Copied from Source/WebCore/Modules/WebGPU/GPUPowerPreference.idl.
Modules/WebGPU/GPURenderPassTimestampWrite.h: Copied from Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h.
Modules/WebGPU/GPURenderPassTimestampWrite.idl: Copied from Source/WebCore/Modules/WebGPU/GPURequestAdapterOptions.idl.
Modules/WebGPU/GPURenderPipeline.cpp:

(WebCore::GPURenderPipeline::label const):
(WebCore::GPURenderPipeline::setLabel):

Modules/WebGPU/GPURenderPipeline.h:

(WebCore::GPURenderPipeline::label const): Deleted.
(WebCore::GPURenderPipeline::setLabel): Deleted.

Modules/WebGPU/GPURequestAdapterOptions.idl:
Modules/WebGPU/GPUShaderModule.cpp:

(WebCore::GPUShaderModule::label const):
(WebCore::GPUShaderModule::setLabel):

Modules/WebGPU/GPUShaderModule.h:

(WebCore::GPUShaderModule::label const): Deleted.
(WebCore::GPUShaderModule::setLabel): Deleted.

Modules/WebGPU/GPUStoreOp.h: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUStoreOp.idl: Copied from Source/WebCore/Modules/WebGPU/GPUShaderModule.cpp.
Modules/WebGPU/GPUTexture.cpp:

(WebCore::GPUTexture::label const):
(WebCore::GPUTexture::setLabel):
(WebCore::GPUTexture::createView const):
(WebCore::GPUTexture::destroy):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

3:38 PM Changeset in webkit [285381] by mmaxfield@apple.com

11 edits
70 copies in trunk/Source/WebCore

[WebGPU] Bindings Part 6: Bring back compilation bindings code
https://bugs.webkit.org/show_bug.cgi?id=232657

Reviewed by Dean Jackson.

This is the sixth chunk of bindings code, brought back from r280467.
This chunk includes the objects related to shader compilation.
The objects have no methods inside them yet - those will come later.

No new tests because there is no behavior change yet.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/WebGPU/GPUBlendComponent.h: Added.
Modules/WebGPU/GPUBlendComponent.idl: Added.
Modules/WebGPU/GPUBlendFactor.h: Added.
Modules/WebGPU/GPUBlendFactor.idl: Added.
Modules/WebGPU/GPUBlendOperation.h: Added.
Modules/WebGPU/GPUBlendOperation.idl: Added.
Modules/WebGPU/GPUBlendState.h: Added.
Modules/WebGPU/GPUBlendState.idl: Added.
Modules/WebGPU/GPUColorTargetState.h: Added.
Modules/WebGPU/GPUColorTargetState.idl: Added.
Modules/WebGPU/GPUColorWrite.h: Added.
Modules/WebGPU/GPUColorWrite.idl: Added.
Modules/WebGPU/GPUCompilationInfo.cpp: Added.

(WebCore::GPUCompilationInfo::messages const):

Modules/WebGPU/GPUCompilationInfo.h: Added.

(WebCore::GPUCompilationInfo::create):

Modules/WebGPU/GPUCompilationInfo.idl: Added.
Modules/WebGPU/GPUCompilationMessage.cpp: Added.

(WebCore::GPUCompilationMessage::message const):
(WebCore::GPUCompilationMessage::type const):
(WebCore::GPUCompilationMessage::lineNum const):
(WebCore::GPUCompilationMessage::linePos const):
(WebCore::GPUCompilationMessage::offset const):
(WebCore::GPUCompilationMessage::length const):

Modules/WebGPU/GPUCompilationMessage.h: Added.

(WebCore::GPUCompilationMessage::create):
(WebCore::GPUCompilationMessage::GPUCompilationMessage):

Modules/WebGPU/GPUCompilationMessage.idl: Added.
Modules/WebGPU/GPUCompilationMessageType.h: Added.
Modules/WebGPU/GPUCompilationMessageType.idl: Added.
Modules/WebGPU/GPUComputePipeline.cpp: Added.

(WebCore::GPUComputePipeline::label const):
(WebCore::GPUComputePipeline::setLabel):
(WebCore::GPUComputePipeline::getBindGroupLayout):

Modules/WebGPU/GPUComputePipeline.h: Added.

(WebCore::GPUComputePipeline::create):

Modules/WebGPU/GPUComputePipeline.idl: Added.
Modules/WebGPU/GPUComputePipelineDescriptor.h: Added.
Modules/WebGPU/GPUComputePipelineDescriptor.idl: Added.
Modules/WebGPU/GPUCullMode.h: Added.
Modules/WebGPU/GPUCullMode.idl: Added.
Modules/WebGPU/GPUDepthStencilState.h: Added.
Modules/WebGPU/GPUDepthStencilState.idl: Added.
Modules/WebGPU/GPUFragmentState.h: Added.
Modules/WebGPU/GPUFragmentState.idl: Added.
Modules/WebGPU/GPUFrontFace.h: Added.
Modules/WebGPU/GPUFrontFace.idl: Added.
Modules/WebGPU/GPUIndexFormat.h: Added.
Modules/WebGPU/GPUIndexFormat.idl: Added.
Modules/WebGPU/GPUMultisampleState.h: Added.
Modules/WebGPU/GPUMultisampleState.idl: Added.
Modules/WebGPU/GPUPipelineBase.idl: Added.
Modules/WebGPU/GPUPipelineDescriptorBase.h: Added.
Modules/WebGPU/GPUPipelineDescriptorBase.idl: Added.
Modules/WebGPU/GPUPrimitiveState.h: Added.
Modules/WebGPU/GPUPrimitiveState.idl: Added.
Modules/WebGPU/GPUPrimitiveTopology.h: Added.
Modules/WebGPU/GPUPrimitiveTopology.idl: Added.
Modules/WebGPU/GPUProgrammableStage.h: Added.
Modules/WebGPU/GPUProgrammableStage.idl: Added.
Modules/WebGPU/GPURenderPipeline.cpp: Added.

(WebCore::GPURenderPipeline::getBindGroupLayout):

Modules/WebGPU/GPURenderPipeline.h: Added.

(WebCore::GPURenderPipeline::create):
(WebCore::GPURenderPipeline::label const):
(WebCore::GPURenderPipeline::setLabel):

Modules/WebGPU/GPURenderPipeline.idl: Added.
Modules/WebGPU/GPURenderPipelineDescriptor.h: Added.
Modules/WebGPU/GPURenderPipelineDescriptor.idl: Added.
Modules/WebGPU/GPUShaderModule.cpp: Added.

(WebCore::GPUShaderModule::compilationInfo):

Modules/WebGPU/GPUShaderModule.h: Added.

(WebCore::GPUShaderModule::create):
(WebCore::GPUShaderModule::label const):
(WebCore::GPUShaderModule::setLabel):

Modules/WebGPU/GPUShaderModule.idl: Added.
Modules/WebGPU/GPUShaderModuleDescriptor.h: Added.
Modules/WebGPU/GPUShaderModuleDescriptor.idl: Added.
Modules/WebGPU/GPUStencilFaceState.h: Added.
Modules/WebGPU/GPUStencilFaceState.idl: Added.
Modules/WebGPU/GPUStencilOperation.h: Added.
Modules/WebGPU/GPUStencilOperation.idl: Added.
Modules/WebGPU/GPUVertexAttribute.h: Added.
Modules/WebGPU/GPUVertexAttribute.idl: Added.
Modules/WebGPU/GPUVertexBufferLayout.h: Added.
Modules/WebGPU/GPUVertexBufferLayout.idl: Added.
Modules/WebGPU/GPUVertexFormat.h: Added.
Modules/WebGPU/GPUVertexFormat.idl: Added.
Modules/WebGPU/GPUVertexState.h: Added.
Modules/WebGPU/GPUVertexState.idl: Added.
Modules/WebGPU/GPUVertexStepMode.h: Added.
Modules/WebGPU/GPUVertexStepMode.idl: Added.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

3:16 PM Changeset in webkit [285380] by mmaxfield@apple.com

12 edits
41 copies in trunk/Source/WebCore

[WebGPU] Bindings Part 5: Bring back Pipeline bindings code
https://bugs.webkit.org/show_bug.cgi?id=232612

Reviewed by Dean Jackson.

This is the fifth chunk of bindings code, brought back from r280467.
This chunk includes the PipelineLayout object. Interestingly, it
doesn't actually have any methods. Its presence is just used when
creating pipelines.

No new tests because there is no behavior change yet.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/WebGPU/GPUAdapter.cpp:

(WebCore::GPUAdapter::requestDevice):

Modules/WebGPU/GPUBindGroup.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.

(WebCore::GPUBindGroup::label const):
(WebCore::GPUBindGroup::setLabel):

Modules/WebGPU/GPUBindGroup.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.

(WebCore::GPUBindGroup::create):

Modules/WebGPU/GPUBindGroup.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupEntry.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupEntry.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupLayout.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.

(WebCore::GPUBindGroupLayout::label const):
(WebCore::GPUBindGroupLayout::setLabel):

Modules/WebGPU/GPUBindGroupLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.

(WebCore::GPUBindGroupLayout::create):

Modules/WebGPU/GPUBindGroupLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupLayoutDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupLayoutDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupLayoutEntry.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBindGroupLayoutEntry.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBufferBinding.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBufferBinding.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBufferBindingLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBufferBindingLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBufferBindingType.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUBufferBindingType.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUDevice.cpp:

(WebCore::GPUDevice::createBindGroupLayout):
(WebCore::GPUDevice::createPipelineLayout):
(WebCore::GPUDevice::createBindGroup):

Modules/WebGPU/GPUDevice.h:
Modules/WebGPU/GPUDevice.idl:
Modules/WebGPU/GPUExternalTextureBindingLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUExternalTextureBindingLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUPipelineLayout.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.

(WebCore::GPUPipelineLayout::label const):
(WebCore::GPUPipelineLayout::setLabel):

Modules/WebGPU/GPUPipelineLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.

(WebCore::GPUPipelineLayout::create):

Modules/WebGPU/GPUPipelineLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUPipelineLayoutDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUPipelineLayoutDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUSamplerBindingLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUSamplerBindingLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUSamplerBindingType.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUSamplerBindingType.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUShaderStage.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUShaderStage.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUStorageTextureAccess.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUStorageTextureAccess.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUStorageTextureBindingLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUStorageTextureBindingLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUTextureBindingLayout.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUTextureBindingLayout.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUTextureSampleType.h: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Modules/WebGPU/GPUTextureSampleType.idl: Copied from Source/WebCore/Modules/WebGPU/GPUAdapter.cpp.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

3:02 PM Changeset in webkit [285379] by mmaxfield@apple.com

11 edits
11 copies in trunk/Source/WebCore

[WebGPU] Bindings part 4: Bring back Sampler bindings code
https://bugs.webkit.org/show_bug.cgi?id=232610

Reviewed by Dean Jackson.

This is the fourth chunk of bindings code, brought back from r280467.
This chunk includes the Sampler object. Interestingly, it doesn't actually
have any methods. Its presence is just used inside bind groups.

No new tests because there is no behavior change yet.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/WebGPU/GPUAddressMode.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUAddressMode.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUCompareFunction.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUCompareFunction.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUDevice.cpp:

(WebCore::GPUDevice::createSampler):

Modules/WebGPU/GPUDevice.h:
Modules/WebGPU/GPUDevice.idl:
Modules/WebGPU/GPUFilterMode.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUFilterMode.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUSampler.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUSampler::label const):
(WebCore::GPUSampler::setLabel):

Modules/WebGPU/GPUSampler.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUSampler::create):

Modules/WebGPU/GPUSampler.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUSamplerDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUSamplerDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

2:50 PM Changeset in webkit [285378] by mmaxfield@apple.com

11 edits
25 copies
2 adds in trunk/Source/WebCore

[WebGPU] Bindings Part 3: Bring back Texture bindings code
https://bugs.webkit.org/show_bug.cgi?id=232609

Reviewed by Dean Jackson.

This is the third chunk of bindings code, brought back from r280467.
This chunk includes the Texture object. Its methods are just stubbed out
and do nothing - those implementations will come later.

No new tests because there is no behavior change yet.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/WebGPU/GPUDevice.cpp:

(WebCore::GPUDevice::createTexture):
(WebCore::GPUDevice::importExternalTexture):

Modules/WebGPU/GPUDevice.h:
Modules/WebGPU/GPUDevice.idl:
Modules/WebGPU/GPUExtent3DDict.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUExtent3DDict.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUExternalTexture.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUExternalTexture::label const):
(WebCore::GPUExternalTexture::setLabel):

Modules/WebGPU/GPUExternalTexture.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUExternalTexture::create):

Modules/WebGPU/GPUExternalTexture.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUExternalTextureDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUExternalTextureDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTexture.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUTexture::createView const):
(WebCore::GPUTexture::destroy):
(WebCore::GPUTexture::label const):
(WebCore::GPUTexture::setLabel):

Modules/WebGPU/GPUTexture.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUTexture::create):

Modules/WebGPU/GPUTexture.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureAspect.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureAspect.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureDimension.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureDimension.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureFormat.h: Added.
Modules/WebGPU/GPUTextureFormat.idl: Added.
Modules/WebGPU/GPUTextureUsage.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureUsage.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureView.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUTextureView::label const):
(WebCore::GPUTextureView::setLabel):

Modules/WebGPU/GPUTextureView.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.

(WebCore::GPUTextureView::create):

Modules/WebGPU/GPUTextureView.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureViewDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureViewDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureViewDimension.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUTextureViewDimension.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

2:08 PM Changeset in webkit [285377] by mmaxfield@apple.com

16 edits
10 copies in trunk/Source/WebCore

[WebGPU] Bindings part 2: Bring back Buffer bindings code
https://bugs.webkit.org/show_bug.cgi?id=232560

Reviewed by Alex Christensen.

This is the second chunk of bindings code, brought back from r280467.
This chunk includes the Buffer object. Its methods are just stubbed out
and do nothing - those implementations will come later.

No new tests because there is no behavior change yet.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/WebGPU/GPUBuffer.cpp: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.cpp.

(WebCore::GPUBuffer::label const):
(WebCore::GPUBuffer::setLabel):
(WebCore::GPUBuffer::mapAsync):
(WebCore::GPUBuffer::getMappedRange):
(WebCore::GPUBuffer::unmap):
(WebCore::GPUBuffer::destroy):

Modules/WebGPU/GPUBuffer.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.cpp.

(WebCore::GPUBuffer::create):

Modules/WebGPU/GPUBuffer.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUBufferDescriptor.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.cpp.
Modules/WebGPU/GPUBufferDescriptor.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUBufferUsage.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.cpp.
Modules/WebGPU/GPUBufferUsage.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/WebGPU/GPUDevice.cpp:

(WebCore::GPUDevice::destroy):
(WebCore::GPUDevice::createBuffer):

Modules/WebGPU/GPUDevice.h:
Modules/WebGPU/GPUDevice.idl:
Modules/WebGPU/GPUIntegralTypes.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.cpp.
Modules/WebGPU/GPUMapMode.h: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.cpp.
Modules/WebGPU/GPUMapMode.idl: Copied from Source/WebCore/Modules/WebGPU/GPUDevice.idl.
Modules/applepay/ApplePayCancelEvent.cpp:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

1:50 PM Changeset in webkit [285376] by mmaxfield@apple.com

19 edits
30 adds in trunk/Source

[WebGPU] Bindings part 1: Bring back Adapter/Device bindings code
https://bugs.webkit.org/show_bug.cgi?id=232550

Reviewed by Alex Christensen.

Source/WebCore:

This is the first chunk of bindings code, brought back from r280467.
This chunk includes the Adapter and Device object. The Device object
has no methods inside it yet - those will come later.

No new tests because there is no behavior change yet.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/WebGPU/GPU.cpp: Added.

(WebCore::GPU::requestAdapter):

Modules/WebGPU/GPU.h: Added.

(WebCore::GPU::create):

Modules/WebGPU/GPU.idl: Added.
Modules/WebGPU/GPUAdapter.cpp: Added.

(WebCore::GPUAdapter::name const):
(WebCore::GPUAdapter::features const):
(WebCore::GPUAdapter::limits const):
(WebCore::GPUAdapter::isFallbackAdapter const):
(WebCore::GPUAdapter::requestDevice):

Modules/WebGPU/GPUAdapter.h: Added.

(WebCore::GPUAdapter::create):

Modules/WebGPU/GPUAdapter.idl: Added.
Modules/WebGPU/GPUDevice.cpp: Added.

(WebCore::GPUDevice::label const):
(WebCore::GPUDevice::setLabel):
(WebCore::GPUDevice::features const):
(WebCore::GPUDevice::limits const):

Modules/WebGPU/GPUDevice.h: Added.

(WebCore::GPUDevice::create):
(WebCore::GPUDevice::GPUDevice):

Modules/WebGPU/GPUDevice.idl: Added.
Modules/WebGPU/GPUDeviceDescriptor.h: Added.
Modules/WebGPU/GPUDeviceDescriptor.idl: Added.
Modules/WebGPU/GPUFeatureName.h: Added.
Modules/WebGPU/GPUFeatureName.idl: Added.
Modules/WebGPU/GPUObjectBase.idl: Added.
Modules/WebGPU/GPUObjectDescriptorBase.h: Added.
Modules/WebGPU/GPUObjectDescriptorBase.idl: Added.
Modules/WebGPU/GPUPowerPreference.h: Added.
Modules/WebGPU/GPUPowerPreference.idl: Added.
Modules/WebGPU/GPUPredefinedColorSpace.h: Added.
Modules/WebGPU/GPUPredefinedColorSpace.idl: Added.
Modules/WebGPU/GPURequestAdapterOptions.h: Added.
Modules/WebGPU/GPURequestAdapterOptions.idl: Added.
Modules/WebGPU/GPUSupportedFeatures.cpp: Added.

(WebCore::GPUSupportedFeatures::initializeSetLike const):

Modules/WebGPU/GPUSupportedFeatures.h: Added.

(WebCore::GPUSupportedFeatures::create):

Modules/WebGPU/GPUSupportedFeatures.idl: Added.
Modules/WebGPU/GPUSupportedLimits.cpp: Added.

(WebCore::GPUSupportedLimits::maxTextureDimension1D const):
(WebCore::GPUSupportedLimits::maxTextureDimension2D const):
(WebCore::GPUSupportedLimits::maxTextureDimension3D const):
(WebCore::GPUSupportedLimits::maxTextureArrayLayers const):
(WebCore::GPUSupportedLimits::maxBindGroups const):
(WebCore::GPUSupportedLimits::maxDynamicUniformBuffersPerPipelineLayout const):
(WebCore::GPUSupportedLimits::maxDynamicStorageBuffersPerPipelineLayout const):
(WebCore::GPUSupportedLimits::maxSampledTexturesPerShaderStage const):
(WebCore::GPUSupportedLimits::maxSamplersPerShaderStage const):
(WebCore::GPUSupportedLimits::maxStorageBuffersPerShaderStage const):
(WebCore::GPUSupportedLimits::maxStorageTexturesPerShaderStage const):
(WebCore::GPUSupportedLimits::maxUniformBuffersPerShaderStage const):
(WebCore::GPUSupportedLimits::maxUniformBufferBindingSize const):
(WebCore::GPUSupportedLimits::maxStorageBufferBindingSize const):
(WebCore::GPUSupportedLimits::minUniformBufferOffsetAlignment const):
(WebCore::GPUSupportedLimits::minStorageBufferOffsetAlignment const):
(WebCore::GPUSupportedLimits::maxVertexBuffers const):
(WebCore::GPUSupportedLimits::maxVertexAttributes const):
(WebCore::GPUSupportedLimits::maxVertexBufferArrayStride const):
(WebCore::GPUSupportedLimits::maxInterStageShaderComponents const):
(WebCore::GPUSupportedLimits::maxComputeWorkgroupStorageSize const):
(WebCore::GPUSupportedLimits::maxComputeInvocationsPerWorkgroup const):
(WebCore::GPUSupportedLimits::maxComputeWorkgroupSizeX const):
(WebCore::GPUSupportedLimits::maxComputeWorkgroupSizeY const):
(WebCore::GPUSupportedLimits::maxComputeWorkgroupSizeZ const):
(WebCore::GPUSupportedLimits::maxComputeWorkgroupsPerDimension const):

Modules/WebGPU/GPUSupportedLimits.h: Added.

(WebCore::GPUSupportedLimits::create):

Modules/WebGPU/GPUSupportedLimits.idl: Added.
Modules/WebGPU/NavigatorGPU.idl: Added.
Modules/applepay/PaymentCoordinator.cpp:
Modules/mediasource/SourceBuffer.h:
Modules/webauthn/PublicKeyCredentialRequestOptions.h:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
bindings/scripts/CodeGenerator.pm:

(ProcessDocument):

dom/EventTargetFactory.in:
page/Navigator.idl:
page/NavigatorBase.cpp:

(WebCore::NavigatorBase::NavigatorBase):

page/NavigatorBase.h:

(WebCore::NavigatorBase::gpu):

page/WorkerNavigator.idl:

Source/WTF:

Scripts/Preferences/WebPreferences.yaml:

12:43 PM Changeset in webkit [285375] by Simon Fraser

6 edits in trunk/Source

WheelEventDeltaFilter::shouldApplyFilteringForEvent can be a static function
https://bugs.webkit.org/show_bug.cgi?id=232786

Reviewed by Wenson Hsieh.
Source/WebCore:

This function just looks at event phase. It can be static.

page/EventHandler.cpp:

(WebCore::EventHandler::defaultWheelEventHandler):

page/WheelEventDeltaFilter.cpp:

(WebCore::WheelEventDeltaFilter::shouldApplyFilteringForEvent):
(WebCore::WheelEventDeltaFilter::shouldApplyFilteringForEvent const): Deleted.

page/WheelEventDeltaFilter.h:

Source/WebKit:

This function just looks at event phase. It can be static.

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

12:41 PM Changeset in webkit [285374] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Process all replacement, control and opaque inline items.
https://bugs.webkit.org/show_bug.cgi?id=232772

Reviewed by Antti Koivisto.

Keep track of each inline item position in the paragraph content (including the opaque items with nullopt position) in a vector.
(This offset vector is always in sync with the InlineItems vector (i.e. nth value refers to the nth inline item)
Note that it needs to grow together with the InlineItems as we split inline text content on bidi boundaries.)

Walk the InlineItems up to the bidi end position and assign the computed bidi level to each entry.
Split the inline text item on the bidi boundary as needed.
Post-process the opaque items (items that are not part of the paragraph content).

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::buildBidiParagraph):
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

layout/formattingContexts/inline/InlineTextItem.cpp:

(WebCore::Layout::InlineTextItem::split):
(WebCore::Layout::InlineTextItem::splitAt): Deleted.

layout/formattingContexts/inline/InlineTextItem.h:

12:20 PM Changeset in webkit [285373] by Antti Koivisto

26 edits
8 deletes in trunk/Source/WebCore

Remove separate classes for CSS wide keywords (initial/inherit/unset/revert)
https://bugs.webkit.org/show_bug.cgi?id=232750

Reviewed by Sam Weinig.

Remove CSSInitialValue, CSSInheritedValue, CSSRevertValue and CSSUnsetValue classes.
They can all be handled by CSSPrimitiveValue.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDeprecatedCSSOMValueCustom.cpp:

(WebCore::toJSNewlyCreated):

Avoid changing the class type visible in CSSOM.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationStyleFlagsToCSSValue):
(WebCore::renderTextDecorationSkipToCSSValue):

css/CSSInheritedValue.cpp: Removed.
css/CSSInheritedValue.h: Removed.
css/CSSInitialValue.cpp: Removed.
css/CSSInitialValue.h: Removed.
css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::isCSSWideKeyword const):

css/CSSPrimitiveValue.h:
css/CSSRevertValue.cpp: Removed.
css/CSSRevertValue.h: Removed.
css/CSSUnsetValue.cpp: Removed.
css/CSSUnsetValue.h: Removed.
css/CSSValue.cpp:

(WebCore::CSSValue::cssValueType const):
(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::treatAsInheritedValue const):
(WebCore::CSSValue::treatAsInitialValue const):
(WebCore::CSSValue::isInitialValue const):
(WebCore::CSSValue::isImplicitInitialValue const):
(WebCore::CSSValue::isInheritValue const):
(WebCore::CSSValue::isUnsetValue const):
(WebCore::CSSValue::isRevertValue const):
(WebCore::CSSValue::isCSSWideKeyword const):

css/CSSValue.h:

(WebCore::CSSValue::CSSValue):
(WebCore::CSSValue::isInheritedValue const): Deleted.
(WebCore::CSSValue::isInitialValue const): Deleted.
(WebCore::CSSValue::isUnsetValue const): Deleted.
(WebCore::CSSValue::isRevertValue const): Deleted.
(WebCore::CSSValue::isGlobalKeyword const): Deleted.

css/CSSValuePool.cpp:

(WebCore::StaticCSSValuePool::StaticCSSValuePool):

css/CSSValuePool.h:

(WebCore::CSSValuePool::createImplicitInitialValue):
(WebCore::CSSValuePool::createInheritedValue): Deleted.
(WebCore::CSSValuePool::createExplicitInitialValue): Deleted.
(WebCore::CSSValuePool::createUnsetValue): Deleted.
(WebCore::CSSValuePool::createRevertValue): Deleted.

css/DeprecatedCSSOMPrimitiveValue.h:

(WebCore::DeprecatedCSSOMPrimitiveValue::isCSSWideKeyword const):

css/SelectorChecker.cpp:
css/StyleProperties.cpp:

(WebCore::StyleProperties::borderRadiusValue const):
(WebCore::StyleProperties::pageBreakPropertyValue const):

css/parser/CSSParserFastPaths.cpp:

(WebCore::parseKeywordValue):

css/parser/CSSParserIdioms.h:

(WebCore::isCSSWideKeyword):
(WebCore::isValidCustomIdentifier):

Separate the concept of valid custom identifier from that of CSS-wide keyword. The former also excludes the obsolete "default" keyword.

css/parser/CSSPropertyParser.cpp:

(WebCore::maybeConsumeCSSWideKeyword):

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeCustomIdent):
(WebCore::CSSPropertyParserHelpers::consumeCounterStyleNameInPrelude):
(WebCore::CSSPropertyParserHelpers::concatenateFamilyName):
(WebCore::CSSPropertyParserHelpers::isCSSWideKeyword): Deleted.

editing/EditingStyle.cpp:

(WebCore::fontWeightIsBold):

editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::propertyValueForNode):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverterCaches::colorPropertyValueForNode):

html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle const):

style/ElementRuleCollector.cpp:

(WebCore::Style::ElementRuleCollector::addMatchedProperties):

style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::addMatch):
(WebCore::Style::PropertyCascade::resolveDirectionAndWritingMode const):

style/StyleBuilder.cpp:

(WebCore::Style::Builder::applyProperty):
(WebCore::Style::Builder::resolveValue):

svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::parseAttribute):

11:35 AM Changeset in webkit [285372] by Kocsen Chung

1 copy in tags/Safari-612.3.4

Tag Safari-612.3.4.

8:51 AM Changeset in webkit [285371] by commit-queue@webkit.org

6 edits
2 moves in trunk

AX: Rename usages DefinitionList to DescriptionList and DescriptionListDefinition to DescriptionListDetail
https://bugs.webkit.org/show_bug.cgi?id=232775

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-06
Reviewed by Chris Fleizach.

Rename usages of "definition list" to "description list" and
DescriptionListDefinition to DescriptionListDetail, as the latter
versions of each pair are what the corresponding HTML elements are
actually called.

Tools:

https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element
https://html.spec.whatwg.org/multipage/grouping-content.html#the-dd-element

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::isInDescriptionListDetail const): Added.
(WTR::AccessibilityUIElement::isInDescriptionListTerm const): Added.
(WTR::AccessibilityUIElement::isInDefinitionListDefinition const): Deleted.
(WTR::AccessibilityUIElement::isInDefinitionListTerm const): Deleted.

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

Rename isInDefinitionListDefinition to isInDescriptionListDetail and
isInDefinitionListTerm to isInDescriptionListTerm.

WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

LayoutTests:

Note this patch does this renaming everywhere except the interface
layers, e.g. WebAccessibilityObjectWrapperIOS.

https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element
https://html.spec.whatwg.org/multipage/grouping-content.html#the-dd-element

accessibility/ios-simulator/description-list-expected.txt: Renamed from LayoutTests/accessibility/ios-simulator/definition-list-expected.txt.
accessibility/ios-simulator/description-list.html: Renamed from LayoutTests/accessibility/ios-simulator/definition-list.html.

6:24 AM Changeset in webkit [285370] by ntim@apple.com

1 edit
1 add in trunk/LayoutTests/imported/w3c

Unreviewed, add missing green-dialog-and-backdrop.html
https://bugs.webkit.org/show_bug.cgi?id=232784

This should have been part of r285368 to avoid resource-files.json referencing an non-existing file.

web-platform-tests/html/semantics/interactive-elements/the-dialog-element/green-dialog-and-backdrop.html: Added.

5:59 AM Changeset in webkit [285369] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Build the paragraph content when all the inline items are processed
https://bugs.webkit.org/show_bug.cgi?id=232771

Reviewed by Antti Koivisto.

This patch simplifies the inline collection logic and helps with the upcoming "resolve the bidi ranges" patch.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::build):
(WebCore::Layout::buildBidiParagraph): Let's build the paragraph content at once.
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxStart):
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxEnd):
(WebCore::Layout::InlineItemsBuilder::handleInlineLevelBox):
(WebCore::Layout::InlineItemsBuilder::enterBidiContext): Deleted.
(WebCore::Layout::InlineItemsBuilder::exitBidiContext): Deleted.
(WebCore::Layout::InlineItemsBuilder::buildPreviousTextContent): Deleted.

layout/formattingContexts/inline/InlineItemsBuilder.h:

(WebCore::Layout::InlineItemsBuilder::hasSeenBidiContent const):

5:05 AM Changeset in webkit [285368] by ntim@apple.com

22 edits
1 delete in trunk/LayoutTests

Re-import html/semantics/interactive-elements/the-dialog-element WPT
https://bugs.webkit.org/show_bug.cgi?id=232784

Unreviewed, reverting some changes made by r285346, and upstreamed them.

Upstream commit: https://github.com/web-platform-tests/wpt/commit/301143db2eced1c387ca4927c03cf2be41056a83

LayoutTests/imported/w3c:

resources/resource-files.json:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/resources/green-dialog-and-backdrop.html: Removed.
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/resources/w3c-import.log:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-clip-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-clip.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-filter-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-filter.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-mask-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-mask.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-opacity-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-opacity.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-clip-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-clip.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-hidden-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-hidden.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-scroll-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-scroll.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform-expected.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:

LayoutTests:

TestExpectations:

Nov 5, 2021:

11:58 PM Changeset in webkit [285367] by Simon Fraser

12 edits
2 adds in trunk

Simplify code that makes use of WheelEventDeltaFilter
https://bugs.webkit.org/show_bug.cgi?id=232536

Reviewed by Wenson Hsieh.

Source/WebCore:

Push the decision about which kinds of wheel events to apply filtering to down into
WheelEventDeltaFilter, which simplifies call sites. WheelEventDeltaFilterMac::updateFromEvent()
now determines when to call into m_predominantAxisFilter based on the event phase. We
also simplify the timing logic by computing WallTime from when the WheelEventDeltaFilterMac
is constructed.

EventHandler code is cleaned up to simplify the logic a little but the behavior should
be the same.

Test: fast/scrolling/mac/wheel-event-deltas-are-not-filtered.html

page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEventInternal):
(WebCore::EventHandler::handleWheelEventInAppropriateEnclosingBox):
(WebCore::EventHandler::clearLatchedState):
(WebCore::EventHandler::defaultWheelEventHandler): Move the filtering code out of the latching
#ifdef.
(WebCore::EventHandler::recordWheelEventForDeltaFilter): Deleted.

page/EventHandler.h:
page/WheelEventDeltaFilter.cpp:

(WebCore::WheelEventDeltaFilter::shouldApplyFilteringForEvent const):
(WebCore::WheelEventDeltaFilter::eventCopyWithFilteredDeltas const):
(WebCore::BasicWheelEventDeltaFilter::updateFromEvent):
(WebCore::BasicWheelEventDeltaFilter::updateWithDelta):
(WebCore::BasicWheelEventDeltaFilter::reset):
(WebCore::BasicWheelEventDeltaFilter::dominantAxis const):
(WebCore::WheelEventDeltaFilter::isFilteringDeltas const): Deleted.
(WebCore::BasicWheelEventDeltaFilter::updateFromDelta): Deleted.
(WebCore::BasicWheelEventDeltaFilter::beginFilteringDeltas): Deleted.
(WebCore::BasicWheelEventDeltaFilter::endFilteringDeltas): Deleted.
(WebCore::BasicWheelEventDeltaFilter::dominantScrollGestureDirection const): Deleted.

page/WheelEventDeltaFilter.h:
page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::recordWheelEventForDeltaFilter): Deleted.

page/mac/WheelEventDeltaFilterMac.h:
page/mac/WheelEventDeltaFilterMac.mm:

(WebCore::WheelEventDeltaFilterMac::WheelEventDeltaFilterMac):
(WebCore::WheelEventDeltaFilterMac::updateFromEvent):
(WebCore::WheelEventDeltaFilterMac::reset):
(WebCore::WheelEventDeltaFilterMac::beginFilteringDeltas): Deleted.
(WebCore::WheelEventDeltaFilterMac::updateFromDelta): Deleted.
(WebCore::WheelEventDeltaFilterMac::endFilteringDeltas): Deleted.

platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::copyWithDeltaAndVelocity const): Take a FloatSize for the delta.
(WebCore::PlatformWheelEvent::copyWithDeltasAndVelocity const): Deleted.

Source/WebKit:

Push the decision about which kinds of wheel events to apply filtering to down into
WheelEventDeltaFilter, which simplifies call sites.

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

LayoutTests:

Add a test to verify that wheel events sent to JS aren't affected by the wheel event
delta filter.

fast/scrolling/mac/wheel-event-deltas-are-not-filtered-expected.txt: Added.
fast/scrolling/mac/wheel-event-deltas-are-not-filtered.html: Added.
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow.html:

Adjust the test for the fact that the momentum phase is now axis-locked.

11:53 PM Changeset in webkit [285366] by Simon Fraser

7 edits in trunk/Source/WebCore

Make it possible to avoid retargeting a ScrollingMomentumCalculator
https://bugs.webkit.org/show_bug.cgi?id=232778

Reviewed by Wenson Hsieh.

Calling -[_NSScrollingMomentumCalculator setDestinationOrigin:] to the same origin it's
already targeting has side effects related to rubber-banding which a future patch needs to
avoid. However, ScrollingMomentumCalculator is structured to expect that
setRetargetedScrollOffset() is called, otherwise m_retargetedScrollOffset is left unset.

Fix so that if the ScrollingMomentumCalculator's destination is already correct when no
retargeting is necessary. We continue to store the std::optional m_retargetedScrollOffset,
but always initialize m_initialDestinationOffset.

Now ScrollAnimationMomentum::startAnimatedScrollWithInitialVelocity() can avoid
calling setRetargetedScrollOffset() if the modifier function doesn't alter the
target scroll offset.

ScrollingMomentumCalculatorMac had some undesirable behavior in the
!gEnablePlatformMomentumScrollingPrediction code path; we need to ensure that
_NSScrollingMomentumCalculator agrees about the predicted destination.

Tested by existing scroll snap tests.

platform/ScrollAnimationMomentum.cpp:

(WebCore::ScrollAnimationMomentum::startAnimatedScrollWithInitialVelocity):
(WebCore::ScrollAnimationMomentum::updateScrollExtents):

platform/ScrollingEffectsController.cpp:

(WebCore::ScrollingEffectsController::startMomentumScrollWithInitialVelocity):

platform/ScrollingMomentumCalculator.cpp:

(WebCore::ScrollingMomentumCalculator::setRetargetedScrollOffset):
(WebCore::BasicScrollingMomentumCalculator::BasicScrollingMomentumCalculator):
(WebCore::BasicScrollingMomentumCalculator::linearlyInterpolatedOffsetAtProgress):
(WebCore::BasicScrollingMomentumCalculator::initializeInterpolationCoefficientsIfNecessary):
(WebCore::BasicScrollingMomentumCalculator::initializeSnapProgressCurve):

platform/ScrollingMomentumCalculator.h:

(WebCore::ScrollingMomentumCalculator::destinationScrollOffset const):
(WebCore::ScrollingMomentumCalculator::destinationScrollOffsetDidChange):
(WebCore::ScrollingMomentumCalculator::retargetedScrollOffset const): Deleted.
(WebCore::ScrollingMomentumCalculator::retargetedScrollOffsetDidChange): Deleted.

platform/mac/ScrollingMomentumCalculatorMac.h:
platform/mac/ScrollingMomentumCalculatorMac.mm:

(WebCore::ScrollingMomentumCalculatorMac::ScrollingMomentumCalculatorMac):
(WebCore::ScrollingMomentumCalculatorMac::scrollOffsetAfterElapsedTime):
(WebCore::ScrollingMomentumCalculatorMac::predictedDestinationOffset):
(WebCore::ScrollingMomentumCalculatorMac::destinationScrollOffsetDidChange):
(WebCore::ScrollingMomentumCalculatorMac::setMomentumCalculatorDestinationOffset):
(WebCore::ScrollingMomentumCalculatorMac::requiresMomentumScrolling):
(WebCore::ScrollingMomentumCalculatorMac::ensurePlatformMomentumCalculator):
(WebCore::ScrollingMomentumCalculatorMac::retargetedScrollOffsetDidChange): Deleted.

9:49 PM Changeset in webkit [285365] by Megan Gardner

3 edits in trunk/Source/WebCore

Lookup for text would not show after clicking the page and using key commands to launch.
https://bugs.webkit.org/show_bug.cgi?id=232766
rdar://74562619

Reviewed by Wenson Hsieh.

When triggering the lookup command with command-control-D or the triple finger tap on mac, if you have previously
clicked the page, the lookup would time out and the popover would never show. This was because after clicking on the page,
an invisible caret selection would exist, which would change the path taken for highlighting and temporarily selecting text to
be sent to data detectors.
The solution was to set ignoreSelectionChanges on the temporary selection, and also to stop propagating temporary selection changes to accessibility, as
that should not be necessary and that is the code that cause a sync message (RootViewToScreen) to be sent to the UI process while it was sync awaiting our
reply to the sync message (DidPerformImmediateActionHitTest) sent earlier for the original request for data detectors.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAndRevealSelection):

page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange):

9:33 PM Changeset in webkit [285364] by Alan Bujtas

2 edits in trunk/LayoutTests

Rebaseline for fast/text/midword-break-after-breakable-char.html
https://bugs.webkit.org/show_bug.cgi?id=232777
<rdar://84995628>

Unreviewed.

platform/mac/fast/text/midword-break-after-breakable-char-expected.txt: soft-hyphen font fallback measuring progression.

9:27 PM Changeset in webkit [285363] by Alan Bujtas

2 edits in trunk/LayoutTests

Rebaseline for fast/text/basic/014.html
https://bugs.webkit.org/show_bug.cgi?id=232776
<rdar://84995386>

Unreviewed.

platform/mac/fast/text/basic/014-expected.txt:

8:52 PM Changeset in webkit [285362] by Lauro Moura

2 edits in trunk/LayoutTests

[GLIB] Gardening some offscreencanvas failures after recent WPT update

Unreviewed test gardening.

platform/glib/TestExpectations:

8:02 PM Changeset in webkit [285361] by Chris Dumez

2 edits in trunk/Source/WebKit

[iOS] IPC decoder for ResourceRequest loses systemPreviewInfo when there is platform data
https://bugs.webkit.org/show_bug.cgi?id=232769

Reviewed by Wenson Hsieh.

The IPC decoder for ResourceRequest decodes systemPreviewInfo and sets it on the ResourceRequest.
It then uses different code paths to decode the rest of the ResourceRequest based on whether or not
there is underlying platform data. If there is underlying platform data, we call decodePlatformData()
which creates a brand-new ResourceRequest, and thus loses the systemPreviewInfo we've just set.

To address the issue, we now decode extra data members *after* decoding platform data instead of
*before*.

This was causing the ProcessSwap.SameOriginSystemPreview API test to fail on iOS with the patch for
Bug 231727.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceRequest>::decode):

6:42 PM Changeset in webkit [285360] by Russell Epstein

1 copy in tags/Safari-613.1.7

Tag Safari-613.1.7.

5:51 PM Changeset in webkit [285359] by Wenson Hsieh

7 edits
1 add in trunk

[iOS] Mail compose becomes unresponsive after pasting in text and attempting to type
https://bugs.webkit.org/show_bug.cgi?id=232764
rdar://84669661

Reviewed by Geoff Garen.

Source/WebCore:

After some recent changes in UIKit, keyboard code now calls into -requestDocumentContext:completionHandler:
after inserting text with the software keyboard, and specifically requests sentence-granularity text context
near the selection. This triggered an existing bug in WebKit, where we hang underneath
WebPage::requestDocumentEditingContext when trying to move backwards by sentence granularity, when computing
contextBeforeStart; this hang occurs because it's possible for the logic in nextSentenceBoundaryInDirection
(inside WebCore) to return a visible position that is in the opposite direction, relative to the given starting
position and direction. In turn, this means we end up revisiting visible positions while moving to the next
sentence boundary.

To prevent this, we make two minor adjustments in editing code. First, in nextSentenceBoundaryInDirection(),
we use result instead of the given vp when trying to find the next sentence boundary, in the case where the
given visible position is not already within a sentence. This was presumably the original intent of this code,
which is to "iterate to the start of the next sentence (when moving downstream) or the end of the previous
sentence (when moving upstream)". However, since vp is currently used here instead, we end up moving in the
wrong direction and return the start of the current sentence when moving downstream, or the end of the current
sentence when moving upstream.

Fixing this issue is actually already sufficient in order to address the hangs encountered in the radar;
however, the test case still hits subsequent debug assertions in moveByGranularityRespectingWordBoundary, due
to atBoundaryOfGranularity never returning true, even for visible positions that are at the start or end of
sentences. In lieu of debug assertions, this causes -requestDocumentContext to effectively ignore the given
granularity and traverse too far in either direction, due to atBoundaryOfGranularity always being false (we
avoid infinitely looping and bail because after fixing the first bug above, nextPosition eventually becomes
null).

To address this assertion, we make a second tweak to atBoundaryOfGranularity that allows us to return true
if the given position is already at a sentence boundary (instead of marching to the previous or next sentence
and then moving in the opposite direction). The latter was added in r253561 to fix some corner cases where
startOfSentence() or endOfSentence() would end up moving us past the next (or previous) sentence, but this
seems to break some existing scenarios where the given position is already at the start or end of the sentence.

Test: DocumentEditingContext.RequestSentencesAfterTextInsertion

editing/VisibleUnits.cpp:

(WebCore::atBoundaryOfGranularity):
(WebCore::nextSentenceBoundaryInDirection):

See above for more details.

Tools:

Add an API test that exercises the hang (and also verifies that we don't hit any debug assertions in the
process).

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/simple-editor.html: Added.
TestWebKitAPI/ios/UIKitSPI.h:

Drive-by fixes: remove some old staging declarations for UIKit SPI that has long been in the internal iOS 15
SDK. Remove the staging categories and definitions, and move them to the non-internal SDK section instead.

4:55 PM Changeset in webkit [285358] by Patrick Griffis

3 edits in trunk/Source/WebCore

[GLIB] Be more careful about calling LowPowerModeNotifier's callback
https://bugs.webkit.org/show_bug.cgi?id=232767

Reviewed by Michael Catanzaro.

This callback is expected to only be called when the value changes
otherwise it will hit asserts elsewhere such as in NetworkCache.

platform/LowPowerModeNotifier.h:
platform/glib/LowPowerModeNotifierGLib.cpp:

(WebCore::LowPowerModeNotifier::LowPowerModeNotifier):
(WebCore::LowPowerModeNotifier::isLowPowerModeEnabled const):

4:06 PM Changeset in webkit [285357] by Nikos Mouchtaris

26 edits in trunk/Source

Make scroll bar mode an enum class
https://bugs.webkit.org/show_bug.cgi?id=232651

Reviewed by Simon Fraser.

Source/WebCore:

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::scrollingMode const):

html/HTMLFrameOwnerElement.h:

(WebCore::HTMLFrameOwnerElement::scrollingMode const):

page/Frame.cpp:

(WebCore::Frame::createView):

page/Frame.h:
page/FrameView.cpp:

(WebCore::FrameView::resetScrollbars):
(WebCore::FrameView::init):
(WebCore::FrameView::updateCanHaveScrollbars):
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::adjustScrollbarsForLayout):
(WebCore::FrameView::performFixedWidthAutoSize):
(WebCore::FrameView::performSizeToContentAutoSize):
(WebCore::FrameView::isScrollable):
(WebCore::FrameView::enableAutoSizeMode):

page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

page/scrolling/ScrollingCoordinatorTypes.h:
page/scrolling/ScrollingTreeScrollingNode.h:
platform/ScrollTypes.cpp:

(WebCore::operator<<):

platform/ScrollTypes.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::setCanHaveScrollbars):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::platformScrollbarModes const):

platform/ScrollView.h:
platform/ScrollableArea.h:

(WebCore::ScrollableArea::horizontalScrollbarMode const):
(WebCore::ScrollableArea::verticalScrollbarMode const):
(WebCore::ScrollableArea::canHaveScrollbars const):

platform/ios/wak/WAKScrollView.mm:

(-[WAKScrollView horizontalScrollingMode]):
(-[WAKScrollView verticalScrollingMode]):

rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::performLayoutWithFlattening):

rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::flattenFrame const):

rendering/RenderLayer.cpp:

(WebCore::frameElementAndViewPermitScroll):

rendering/RenderLayerBacking.cpp:

(WebCore::computePageTiledBackingCoverage):

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setAlwaysShowsHorizontalScroller):
(WebKit::WebPage::setAlwaysShowsVerticalScroller):

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):

WebView/WebView.mm:

(-[WebView setAlwaysShowVerticalScroller:]):
(-[WebView alwaysShowVerticalScroller]):
(-[WebView setAlwaysShowHorizontalScroller:]):
(-[WebView alwaysShowHorizontalScroller]):

3:42 PM Changeset in webkit [285356] by Ryan Haddad

5 edits in trunk/Tools

[steps.py] Update macOS versions in build_to_name_mapping
https://bugs.webkit.org/show_bug.cgi?id=232732

Reviewed by Jonathan Bedard.

CISupport/ews-build/steps.py:

(PrintConfiguration.convert_build_to_os_name):

CISupport/ews-build/steps_unittest.py:
CISupport/build-webkit-org/steps.py:

(PrintConfiguration.convert_build_to_os_name):

CISupport/build-webkit-org/steps_unittest.py:

3:20 PM Changeset in webkit [285355] by Lauro Moura

3 edits in trunk/LayoutTests

[GLIB] Gardening more timeouts

Unreviewed test gardening.

platform/glib/TestExpectations:
platform/wpe/TestExpectations:

3:00 PM Changeset in webkit [285354] by Lauro Moura

2 edits in trunk/Tools

[Flatpak SDK] Print SDK version after update
https://bugs.webkit.org/show_bug.cgi?id=232725

Reviewed by Adrian Perez de Castro.

Print the actual installed version after the update step, even if
nothing was updated. This should help tracking the SDK versions across
builds on the bots.

flatpak/flatpakutils.py:

(WebkitFlatpak.main):

1:32 PM Changeset in webkit [285353] by Ryan Haddad

2 edits in trunk/Tools

Bring up queues for Monterey
https://bugs.webkit.org/show_bug.cgi?id=232186

Unreviewed follow-up fix.

CISupport/build-webkit-org/config.json: Should have used bot185, not bot186.

12:53 PM Changeset in webkit [285352] by Russell Epstein

2 edits in branches/safari-613.1.7-branch/Source/WebCore

Cherry-pick r285305. rdar://problem/85082384

[ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
https://bugs.webkit.org/show_bug.cgi?id=232676

Patch by Alex Christensen <achristensen@webkit.org> on 2021-11-04
Reviewed by Eric Carlson.

In WebKitLegacy on iOS, WebCoreAVFPullDelegate.initWithPlayer is being called on the web thread,
but outputMediaDataWillChange is being called on the main run loop then accessing _player in a non-thread-safe manner.
To fix this, I call callOnMainThread to access _player on the web thread. To fix the assertion that happens after this
fix, I made MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange able to be called on the non-main run loop.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange): (-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:53 PM Changeset in webkit [285351] by Russell Epstein

2 edits in branches/safari-613.1.7-branch/Source/WebCore

Cherry-pick r285231. rdar://problem/85082384

[ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
https://bugs.webkit.org/show_bug.cgi?id=232676

Patch by Alex Christensen <achristensen@webkit.org> on 2021-11-03
Reviewed by Eric Carlson.

In r284743 we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
Remove some unsafe early returns.

platform/ios/VideoFullscreenInterfaceAVKit.mm: (-[WebAVPlayerLayer layoutSublayers]): (-[WebAVPlayerLayer resolveBounds]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:33 PM Changeset in webkit [285350] by commit-queue@webkit.org

22 edits
1 copy
1 add in trunk

Restructure WKContentRuleList Action storage during compilation and interpretation
https://bugs.webkit.org/show_bug.cgi?id=232692

Patch by Alex Christensen <achristensen@webkit.org> on 2021-11-05
Reviewed by Brady Eidson.

Source/WebCore:

This uses a std::variant of each type's metadata instead of an enum type and a String.
This is necessary cleanup before implementing actions with more complex metadata.

I also separated out DeserializedAction, which is deserialized from the compiled WKContentRuleList
from Action, which is parsed from the JSON and doesn't have an identifier.

This is covered by numerous tests, which also needed syntax updating for the new structure types.
There is no change in behavior and the serialization and deserialization is all the same.

contentextensions/ContentExtension.cpp:

(WebCore::ContentExtensions::ContentExtension::findFirstIgnorePreviousRules const):
(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):

contentextensions/ContentExtensionActions.h:

(WebCore::ContentExtensions::ActionWithoutMetadata::isolatedCopy):
(WebCore::ContentExtensions::ActionWithoutMetadata::operator== const):
(WebCore::ContentExtensions::ActionWithoutMetadata::serialize const):
(WebCore::ContentExtensions::ActionWithoutMetadata::deserialize):
(WebCore::ContentExtensions::ActionWithoutMetadata::serializedLength):
(WebCore::ContentExtensions::ActionWithStringMetadata::isolatedCopy):
(WebCore::ContentExtensions::ActionWithStringMetadata::operator== const):
(WebCore::ContentExtensions::ActionWithStringMetadata::serialize const):
(WebCore::ContentExtensions::ActionWithStringMetadata::deserialize):
(WebCore::ContentExtensions::ActionWithStringMetadata::serializedLength):
(WebCore::ContentExtensions::hasStringArgument): Deleted.

contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::resolvePendingDisplayNoneActions):
(WebCore::ContentExtensions::serializeActions):
(WebCore::ContentExtensions::serializeString): Deleted.

contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadAction):

contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::deserializeString):
(WebCore::ContentExtensions::serializeString):
(WebCore::ContentExtensions::stringSerializedLength):
(WebCore::ContentExtensions::VariantDeserializerHelper::serializedLength):
(WebCore::ContentExtensions::Action::deserialize):
(WebCore::ContentExtensions::Action::serializedLength):
(WebCore::ContentExtensions::Action::isolatedCopy const):
(WebCore::ContentExtensions::Action::deserializeType): Deleted.

contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Action::Action):
(WebCore::ContentExtensions::Action::operator== const):
(WebCore::ContentExtensions::Action::operator!= const):
(WebCore::ContentExtensions::Action::data const):
(WebCore::ContentExtensions::DeserializedAction::DeserializedAction):
(WebCore::ContentExtensions::DeserializedAction::actionID const):
(WebCore::ContentExtensions::Action::type const): Deleted.
(WebCore::ContentExtensions::Action::actionID const): Deleted.
(WebCore::ContentExtensions::Action::stringArgument const): Deleted.

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForPingLoad):

Source/WTF:

wtf/CrossThreadCopier.h:
wtf/StdLibExtras.h:

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::testRequest):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::actionsEqual):
(WebCore::ContentExtensions::operator<<): Deleted.

12:08 PM Changeset in webkit [285349] by timothy_horton@apple.com

2 edits in trunk/Tools

generate-xcfilelists doesn't work if build path contains a +
https://bugs.webkit.org/show_bug.cgi?id=232493

Reviewed by Simon Fraser.

Scripts/webkitpy/generate_xcfilelists_lib/generators.py:

(BaseGenerator._generate_derived):
(BaseGenerator._replaceSinglePrefix):
(BaseGenerator._replacePrefix):
(BaseGenerator._unexpand._try_unexpand):
(BaseGenerator._replace): Deleted.
The xcfilelist generator had a regex injection issue that resulted in
paths with not-very-special characters causing it to infinitely
regenerate the xcfilelists; we can just use simple string prefix
replacement instead.

11:57 AM Changeset in webkit [285348] by Russell Epstein

3 edits in trunk

Cherry-pick r284635. rdar://problem/85039977

[JSC] Inserted GetTypedArrayLengthAsInt52 for PutByVal should have NodeResultInt52
https://bugs.webkit.org/show_bug.cgi?id=232059

Reviewed by Saam Barati.

JSTests:

stress/inserted-gettypedarraylengthasint52-should-have-int52-result-for-put-by-val.js: Added. (foo.bar): (foo):

Source/JavaScriptCore:

When inserting GetTypedArrayLengthAsInt52 after fixup phase, we must set NodeResultInt52.

dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::handleNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:46 AM Changeset in webkit [285347] by Nikos Mouchtaris

13 edits in trunk/Source

Make scroll elasticity an enum class
https://bugs.webkit.org/show_bug.cgi?id=232646

Reviewed by Simon Fraser.

Source/WebCore:

page/FrameView.cpp:

(WebCore::FrameView::FrameView):

page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:
page/scrolling/ScrollingCoordinatorTypes.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):

platform/ScrollTypes.cpp:

(WebCore::operator<<):

platform/ScrollTypes.h:
platform/ScrollableArea.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::allowsVerticalStretching const):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching const):

rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::setHasHorizontalScrollbar):
(WebCore::RenderLayerScrollableArea::setHasVerticalScrollbar):

Source/WebKit:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setEnableVerticalRubberBanding):
(WebKit::WebPage::setEnableHorizontalRubberBanding):

11:14 AM Changeset in webkit [285346] by Chris Dumez

275 edits
58 copies
19 moves
914 adds
59 deletes in trunk/LayoutTests

Resync web-platform-tests/html from upstream
https://bugs.webkit.org/show_bug.cgi?id=232449

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Resync web-platform-tests/html from upstream 038de3e0ddeaf9e20b.

resources/resource-files.json:
web-platform-tests/html/*: Updated.

LayoutTests:

TestExpectations:
tests-options.json:

10:43 AM Changeset in webkit [285345] by Devin Rousso

17 edits in trunk

[css-values-4] viewport units should be floats
https://bugs.webkit.org/show_bug.cgi?id=231644
<rdar://problem/84172685>

Reviewed by Tim Horton.

Source/WebCore:

Views can be fractional pixels wide. We should not round, especially since viewport units
are used as percentage values (e.g. 50dvh is "50% of the height of the current viewport").

Tests: CSSViewportUnits.EmptyUnobscuredSizeOverrides

CSSViewportUnits.SameUnobscuredSizeOverrides
CSSViewportUnits.DifferentUnobscuredSizeOverrides

page/FrameView.h:
page/FrameView.cpp:

(WebCore::FrameView::setSizeForCSSSmallViewportUnits):
(WebCore::FrameView::overrideWidthForCSSSmallViewportUnits):
(WebCore::FrameView::sizeForCSSSmallViewportUnits const):
(WebCore::FrameView::setSizeForCSSLargeViewportUnits):
(WebCore::FrameView::overrideWidthForCSSLargeViewportUnits):
(WebCore::FrameView::sizeForCSSLargeViewportUnits const):
(WebCore::FrameView::calculateSizeForCSSViewportUnitsOverride const):
(WebCore::FrameView::sizeForCSSDynamicViewportUnits const):
(WebCore::FrameView::sizeForCSSDefaultViewportUnits const):

rendering/RenderView.h:
rendering/RenderView.cpp:

(WebCore::RenderView::sizeForCSSSmallViewportUnits const):
(WebCore::RenderView::sizeForCSSLargeViewportUnits const):
(WebCore::RenderView::sizeForCSSDynamicViewportUnits const):
(WebCore::RenderView::sizeForCSSDefaultViewportUnits const):

Source/WebKit:

Views can be fractional pixels wide. We should not round, especially since viewport units
are used as percentage values (e.g. 50dvh is "50% of the height of the current viewport").

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setViewportSizeForCSSViewportUnits:]):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setViewportSizeForCSSViewportUnits):

Shared/WebPageCreationParameters.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewportSizeForCSSViewportUnits):
(WebKit::WebPage::viewportSizeForCSSViewportUnits const):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateViewportSizeForCSSViewportUnits):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:

(evaluateForNumber):
(getElementHeight):
(TEST.CSSViewportUnits.AllSame):
(TEST.CSSViewportUnits.EmptyUnobscuredSizeOverrides):
(TEST.CSSViewportUnits.SameUnobscuredSizeOverrides):
(TEST.CSSViewportUnits.DifferentUnobscuredSizeOverrides):

TestWebKitAPI/Tests/WebKit/ViewportSizeForViewportUnits.mm:

(TEST.WebKit.ViewportSizeForViewportUnits):

10:34 AM Changeset in webkit [285344] by graouts@webkit.org

2 edits in trunk/Source/WebCore

[Media Controls] Volume button orientation is always stuck to right-to-left
https://bugs.webkit.org/show_bug.cgi?id=232761

Reviewed by Dean Jackson.

Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.set usesLTRUserInterfaceLayoutDirection):

10:18 AM Changeset in webkit [285343] by commit-queue@webkit.org

37 edits
2 adds in trunk

Implement parsing and animation support for offset-path
https://bugs.webkit.org/show_bug.cgi?id=231801

Patch by Kiet Ho <Kiet Ho> on 2021-11-05
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Updated relevant test expectations.

web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
web-platform-tests/css/motion/animation/offset-path-interpolation-001-expected.txt:
web-platform-tests/css/motion/animation/offset-path-interpolation-002-expected.txt:
web-platform-tests/css/motion/animation/offset-path-interpolation-003-expected.txt:
web-platform-tests/css/motion/animation/offset-path-interpolation-004-expected.txt:
web-platform-tests/css/motion/animation/offset-path-interpolation-005-expected.txt:
web-platform-tests/css/motion/inheritance-expected.txt:
web-platform-tests/css/motion/offset-path-serialization-expected.txt:
web-platform-tests/css/motion/offset-supports-calc-expected.txt:
web-platform-tests/css/motion/parsing/offset-path-computed-expected.txt:
web-platform-tests/css/motion/parsing/offset-path-parsing-valid-expected.txt:
web-platform-tests/css/motion/parsing/offset-shorthand-expected.txt:

Source/WebCore:

Implements parsing and animation support for offset-path based on clip-path.
offset-path additionally supports ray() shape, which will be implemented in a future patch.

Tests: imported/w3c/web-platform-tests/css/motion/inheritance.html

imported/w3c/web-platform-tests/css/motion/offset-path-serialization.html
imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-001.html
imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-002.html
imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-003.html
imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-004.html
imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-005.html
imported/w3c/web-platform-tests/css/motion/parsing/offset-path-computed.html
imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-invalid.html
imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-valid.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Added animation support for offset-path.

css/BasicShapeFunctions.cpp:

(WebCore::copySVGPathByteStream):
(WebCore::valueForBasicShape): Added enum to specify conversions done on the
resulting SVG path. So far, the only available conversion is converting relative
draw commands in a path to absolute. This is required when getting the computed value of
offset-path.

css/BasicShapeFunctions.h:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForPathOperation): Moved logic to get value of PathOperation
into a separate method.
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle): Added support for
offset-path.

css/CSSProperties.json: Added entry for offset-path.
css/parser/CSSPropertyParser.cpp:

(WebCore::consumePathOperation): Renamed from consumeClipPath.
(WebCore::CSSPropertyParser::parseSingleValue): Added support for parsing offset-path.

rendering/style/RenderStyle.h: Added support for offset-path.

(WebCore::RenderStyle::offsetPath const):
(WebCore::RenderStyle::setOffsetPath):
(WebCore::RenderStyle::initialOffsetPath):

rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):

rendering/style/StyleRareNonInheritedData.h: Added storage space for offset-path.
style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertPathOperation): Renamed from convertClipPath

svg/SVGPathAbsoluteConverter.cpp: Added helper class to convert relative draw

commands in an SVG path to absolute.
(WebCore::SVGPathAbsoluteConverter::SVGPathAbsoluteConverter):
(WebCore::SVGPathAbsoluteConverter::incrementPathSegmentCount):
(WebCore::SVGPathAbsoluteConverter::continueConsuming):
(WebCore::SVGPathAbsoluteConverter::moveTo):
(WebCore::SVGPathAbsoluteConverter::lineTo):
(WebCore::SVGPathAbsoluteConverter::curveToCubic):
(WebCore::SVGPathAbsoluteConverter::closePath):
(WebCore::SVGPathAbsoluteConverter::lineToHorizontal):
(WebCore::SVGPathAbsoluteConverter::lineToVertical):
(WebCore::SVGPathAbsoluteConverter::curveToCubicSmooth):
(WebCore::SVGPathAbsoluteConverter::curveToQuadratic):
(WebCore::SVGPathAbsoluteConverter::curveToQuadraticSmooth):
(WebCore::SVGPathAbsoluteConverter::arcTo):

svg/SVGPathAbsoluteConverter.h: Added.
svg/SVGPathUtilities.cpp:

(WebCore::convertSVGPathByteStreamToAbsoluteCoordinates):

svg/SVGPathUtilities.h:

LayoutTests:

Updated relevant test expectations.

platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

9:32 AM Changeset in webkit [285342] by graouts@webkit.org

2 edits in trunk/Source/WebCore

[Media Controls] range buttons don't prevent scrolling while dragging
https://bugs.webkit.org/show_bug.cgi?id=232757
<rdar://problem/83637971>

Reviewed by Dean Jackson.

Since we are using Pointer Events to implement the dragging interaction for RangeButton,
we need to set touch-action: none to prevent any default user-agent behavior.

Modules/modern-media-controls/controls/range-button.css:

(button.range):

9:10 AM Changeset in webkit [285341] by Jonathan Bedard

2 edits in trunk/Tools

[ic-stats.py] Change shebang to Python 3
https://bugs.webkit.org/show_bug.cgi?id=232721
<rdar://problem/85030782>

Reviewed by Alexey Proskuryakov.

Scripts/ic-stats.py:

1:23 AM Changeset in webkit [285340] by Carlos Garcia Campos

13 edits in trunk/Source

AX: rename actionVerb() as localizedActionVerb()
https://bugs.webkit.org/show_bug.cgi?id=232711
<rdar://problem/85015496>

Reviewed by Andres Gonzalez.

Source/WebCore:

Since it's returning the localized name. In ATSPI there are two methods in the action interface GetName and
GetLocalizedName, so this patch also adds actionVerb() returning the unlocalized action name.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::localizedActionVerb const):
(WebCore::AccessibilityObject::actionVerb const):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::localizedActionVerb const):

accessibility/AccessibilityObjectInterface.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::actionVerb const): Deleted.

accessibility/AccessibilityRenderObject.h:
accessibility/atk/WebKitAccessibleHyperlink.cpp:

(webkitAccessibleHyperlinkActionGetName):

accessibility/atk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionGetName):

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):

accessibility/isolatedtree/AXIsolatedObject.h:
accessibility/isolatedtree/AXIsolatedTree.h:

Source/WebKitLegacy/win:

AccessibleBase.cpp:

(AccessibleBase::get_accDefaultAction): Use localizedActionVerb().

1:22 AM Changeset in webkit [285339] by Carlos Garcia Campos

7 edits in trunk

[GTK][a11y] Embedded objects are not correctly handled by text interface with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=232622

Reviewed by Andres Gonzalez.

Source/WebCore:

Make sure text iterator is emitting object replacement characters when converting offsets to/from visible positions.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForIndex const):
(WebCore::AccessibilityRenderObject::indexForVisiblePosition const):

accessibility/atspi/AccessibilityObjectTextAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::boundsForSelection const):

editing/Editing.cpp:

(WebCore::indexForVisiblePosition):
(WebCore::visiblePositionForIndex):

editing/Editing.h:

Tools:

Add a test case to check handling of embedded objects by text interface.

TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(testTextReplacedObjects):
(beforeAll):

1:21 AM Changeset in webkit [285338] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Unreviewed. [GTK][WPE] Fix compile warning after r284675

accessibility/AXObjectCache.cpp:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed