Timeline

Nov 13, 2021:

11:37 PM Changeset in webkit [285787] by Simon Fraser

• 12 edits
  4 adds in trunk

Run a ScrollAnimationMomentum for the momentum phase of a scroll
​https://bugs.webkit.org/show_bug.cgi?id=232897

Reviewed by Tim Horton.
Source/WebCore:

Run an animation for the momentum phase of a scroll, rather than scrolling in response
to wheel events, because it produces a smoother result with fewer dropped frames.

We re-use ScrollAnimationMomentum which is already used for scroll snap, but have to
allow it to yield unclamped coordinates, since using it for momentum can result in
rubber-banding.

When we get the momentum "began" event, we start the ScrollAnimationMomentum
using initial velocity computed from WheelEventDeltaFilter. ScrollingEffectsController then
ignores the reset of the momentum "changed" events.

We have to stop this animation when we receive a "begin" or "mayBegin" event, since
this indicates that the user has put fingers down on the trackpad.

Rename m_dragEndedScrollingVelocity to m_scrollingVelocityForScrollSnap for clarity
(at some point we should merge this with m_scrollingVelocityForMomentumAnimation).

Tests: fast/scrolling/mac/momentum-animator-in-overflow.html

fast/scrolling/mac/momentum-animator.html

• page/WheelEventDeltaFilter.cpp:

(WebCore::WheelEventDeltaFilter::shouldApplyFilteringForEvent):

• page/WheelEventDeltaFilter.h:
• platform/PlatformWheelEvent.cpp:

(WebCore::operator<<):

• platform/ScrollAnimationMomentum.cpp:

(WebCore::ScrollAnimationMomentum::startAnimatedScrollWithInitialVelocity):
(WebCore::ScrollAnimationMomentum::stop):
(WebCore::ScrollAnimationMomentum::serviceAnimation):

• platform/ScrollAnimationMomentum.h:
• platform/ScrollingEffectsController.cpp:

(WebCore::ScrollingEffectsController::ScrollingEffectsController):
(WebCore::ScrollingEffectsController::stopAnimatedNonRubberbandingScroll):
(WebCore::ScrollingEffectsController::startMomentumScrollWithInitialVelocity):

• platform/ScrollingEffectsController.h:

(WebCore::ScrollingEffectsController::momentumScrollingAnimatorEnabled const):

• platform/mac/ScrollingEffectsController.mm:

(WebCore::phaseToString):
(WebCore::ScrollingEffectsController::handleWheelEvent):
(WebCore::ScrollingEffectsController::startRubberBandAnimation):
(WebCore::ScrollingEffectsController::startRubberBandAnimationIfNecessary):
(WebCore::ScrollingEffectsController::processWheelEventForScrollSnap):

Source/WTF:

Set the MomentumScrollingAnimatorEnabled internal setting to off by default
while we bring up tests.

• Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:

Some tests that enable the momentum animator.

• fast/scrolling/mac/momentum-animator-expected.txt: Added.
• fast/scrolling/mac/momentum-animator-in-overflow-expected.txt: Added.
• fast/scrolling/mac/momentum-animator-in-overflow.html: Added.
• fast/scrolling/mac/momentum-animator.html: Added.

9:05 PM Changeset in webkit [285786] by timothy_horton@apple.com

• 8 edits
  1 copy in trunk/Source/WebCore

Clean up IOKit SPI headers
​https://bugs.webkit.org/show_bug.cgi?id=233093

Reviewed by Simon Fraser.

Source/WebCore:

• platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
• platform/gamepad/mac/HIDGamepadProvider.h:
• platform/gamepad/mac/HIDGamepadProvider.mm:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/spi/cg/CoreGraphicsSPI.h:
• pal/spi/cocoa/IOKitSPI.h:
• pal/spi/ios/IOKitSPIIOS.h: Added.
• pal/spi/mac/IOKitSPIMac.h:

IOKit vends a much different set of public API on iOS vs. macOS,
so we have separate SPI headers to reduce the confusion.

Unfortunately, the SPI header for iOS was not explicitly named as such,
and started being used in some macOS code. For a while, this didn't lead
to any trouble because the aforementioned macOS code didn't ALSO have
the public SDK headers included, but a future patch from Simon will
use IOKitSPI.h in a place where the macOS IOKit public headers are included,
and thus we must make the split more explicit.

Rename IOKitSPI.h to IOKitSPIIOS.h; make IOKitSPI choose the right one.
Add some SPI defintions to IOKitSPIMac.h that were missing (which the
dependent code was getting via the iOS header on macOS).

4:19 PM Changeset in webkit [285785] by Said Abou-Hallawa

• 4 edits in trunk

REGRESSION (r285618): [mac-wk1] ASSERTION FAILED: cgContext == [currentContext CGContext]
​https://bugs.webkit.org/show_bug.cgi?id=233008
rdar://85311948

Reviewed by Wenson Hsieh.

Source/WebCore:

The assertion fails when loading the expected html page because one of
the elements has a CSS filter named "(#noop)" but the filter "noop" is
not defined.

The reason for the assertion to fail is we switch the PaintInfo to the
context of the CSSFilter::sourceImage() and we do not restore it back.
In fact CSSFilter::buildFilterFunctions() should fail since the filter
has only a reference filter and this reference filter does not exit. The
bug is CSSFilter::buildFilterFunctions() does not fail in this case.

Before r285618, CSSFilter::buildFilterFunctions() was not adding
SourceGraphic to m_functions. It was added as the input of the first
FilterEffect. This was fine since we were applying the lastEffect which
goes backward till it reaches the SourceGraphic.

But the plan is to apply the FilterFunctions from the first to the last
without having to go backward, so we need to add the SourceGraphic to
m_functions explicitly. The bug happens when no FilterFunction is built
successfully and we return 'true' because m_functions is not empty. It
has the SourceGraphic.

The fix is to add the SourceGraphic only when there is at least another
FilterFunction will be added to m_functions.

• rendering/CSSFilter.cpp:

(WebCore::CSSFilter::buildFilterFunctions):

LayoutTests:

Unskip the test http/tests/css/filters-on-iframes-transform.html which
was skipped in r285656.

• platform/mac-wk1/TestExpectations:

3:28 PM Changeset in webkit [285784] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Inline box end's padding/border/margin should be taken into account when computing horizontal position for bidi content
​https://bugs.webkit.org/show_bug.cgi?id=233083

Reviewed by Antti Koivisto.

Let's decouple the "display box rect" and the "content right in visual order" computation.
There are runs (e.g. inline box end) that don't need to call displayBoxRect() but they
still affect the "content right in visual order" (<span style="border-right: 10px solid green">).

• layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent): add the additional lineRun.isInlineBoxEnd() case.

3:21 PM Changeset in webkit [285783] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Add support for optional bidi character coverage checking
​https://bugs.webkit.org/show_bug.cgi?id=233049

Reviewed by Antti Koivisto.

This is in preparation for enabling bidi for IFC.

• layout/formattingContexts/inline/InlineItemsBuilder.cpp:
• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForFontAndText):
(WebCore::LayoutIntegration::canUseForRenderInlineChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

3:04 PM Changeset in webkit [285782] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][Integration] Bring showRenderTree for IFC integration back
​https://bugs.webkit.org/show_bug.cgi?id=233000

Reviewed by Antti Koivisto.

Currently showRenderTree comes back blank for IFC content.

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::showInlineContent):

• layout/integration/LayoutIntegrationBoxTree.h:
• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::outputLineTree const):

3:04 PM Changeset in webkit [285781] by Simon Fraser

• 9 edits in trunk

Implement UIScriptController.sendEventStream() for DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=233090

Reviewed by Wenson Hsieh.
Tools:

Implement UIScriptControllerMac::sendEventStream(), sharing some event dispatching code from
EventSendingController.

• DumpRenderTree/mac/EventSendingController.h:
• DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
(-[EventSendingController sendScrollEventAt:deltaX:deltaY:units:wheelPhase:momentumPhase:timestamp:]):

• DumpRenderTree/mac/UIScriptControllerMac.h:
• DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::gesturePhaseFromString):
(WTR::momentumPhaseFromString):
(WTR::eventSenderFromView):
(WTR::UIScriptControllerMac::sendEventStream):

LayoutTests:

Convert one test that runs in WK1 to use sendEventStream().

• fast/scrolling/overflow-scroll-past-max.html:
• resources/ui-helper.js:

1:59 PM Changeset in webkit [285780] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Inline box end (opaque to bidi) should get the bidi level from its adjacent content
​https://bugs.webkit.org/show_bug.cgi?id=233082

Reviewed by Antti Koivisto.

While the inline box start item (<span>) gets the bidi level from the next (adjacent) content, inline box end (</span>)
should get it from the previous content (these are opaque inline items).

e.g <span>bidi content</span>
both the inline box start and the inline box end items get their bidi level from the "bidi content" inline text item.

• layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

1:58 PM Changeset in webkit [285779] by Jonathan Bedard

• 7 edits in trunk/Tools

Unreviewed, reverting r285772.

Ownership issues in some XCode installs

Reverted changeset:

"[webkitpy] Symlink daemons into simulator runtime root"
​https://bugs.webkit.org/show_bug.cgi?id=233080
​https://commits.webkit.org/r285772

1:57 PM Changeset in webkit [285778] by commit-queue@webkit.org

• 16 edits in trunk/LayoutTests

AX: Make 7 more layout tests async so that they pass in --release --accessibility-isolated-tree mode
​https://bugs.webkit.org/show_bug.cgi?id=233085

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-13
Reviewed by Chris Fleizach.

This patch makes 7 more tests async so that they pass in --release
--accessibility-isolated-tree mode. This patch also adds some helper
functions to accessibility-helper.js.

• accessibility/ancestor-computation.html:

Move waitForElement to accessibility-helpers.js and rename to
waitForElementById.

• accessibility/color-well-expected.txt:
• accessibility/color-well.html:
• accessibility/mac/scrollbars.html:
• accessibility/placeholder-expected.txt:
• accessibility/placeholder.html:
• accessibility/progressbar-expected.txt:
• accessibility/progressbar.html:
• accessibility/range-alter-by-percent-expected.txt:
• accessibility/range-alter-by-percent.html:
• accessibility/range-alter-by-step-expected.txt:
• accessibility/range-alter-by-step.html:
• accessibility/spinbutton-value-expected.txt:
• accessibility/spinbutton-value.html:

Make tests async so they pass in isolated tree mode.
Minor updates to expectations:

• Some variables renamed for better readability
• Sometimes there is one more or one less newline after the test rewrites

• resources/accessibility-helper.js:

(async waitForElementById): Added. Originally defined in
accessibility/ancestor-computation.html.
(async waitForExpression): Added.

10:49 AM Changeset in webkit [285777] by mmaxfield@apple.com

• 2 edits in trunk

[WebGPU] Add WebGPU.xcodeproj to WebKit.xcworkspace
​https://bugs.webkit.org/show_bug.cgi?id=233078

Reviewed by Dean Jackson.

Mechanical change. When building WebGPU becomes required,
people using this workspace will need it.

• WebKit.xcworkspace/contents.xcworkspacedata:

10:38 AM Changeset in webkit [285776] by commit-queue@webkit.org

• 9 edits in trunk

AX: Make accessibility/mac/header.html test async to fix it for isolated tree mode
​https://bugs.webkit.org/show_bug.cgi?id=233017

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-13
Reviewed by Andres Gonzalez.

Tools:

This patch implements the domIdentifier attribute for DumpRenderTree
elements. When making this test async, I wanted to use this attribute,
hence the implementation in this patch.

• DumpRenderTree/AccessibilityUIElement.cpp:

(domIdentifierCallback): Added.
(AccessibilityUIElement::getJSClass):
Add "domIdentifer" entry to staticValues[].

• DumpRenderTree/AccessibilityUIElement.h:

Add AccessibilityUIElement::domIdentifier const definition.

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::domIdentifier const): Added.

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::domIdentifier const): Added.

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::domIdentifier const):Added.

LayoutTests:

This test needs to be made async, as we need to wait for
accessibilityController.focusedElement to be synced with the DOM
focused element before running our expectations. This fixes the
test in isolated tree mode.

• accessibility/mac/header-expected.txt:

Remove extra newline at end of the file.

• accessibility/mac/header.html:

Make test async.

8:44 AM Changeset in webkit [285775] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS][GPUP] Remove logging of used syscalls
​https://bugs.webkit.org/show_bug.cgi?id=232839
<rdar://problem/85168823>

Reviewed by Brent Fulgham.

Based on telemetry, remove logging of used unix syscalls in the GPU process on macOS.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

8:13 AM Changeset in webkit [285774] by pvollan@apple.com

• 3 edits in trunk/Source/WebKit

[macOS][GPUP] Add telemetry for syscalls
​https://bugs.webkit.org/show_bug.cgi?id=232888
<rdar://problem/85207011>

Reviewed by Brent Fulgham.

Add more telemetry for syscalls in the GPU process' sandbox on macOS. Also add entitlement for the GPU
process to use message filtering.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• Scripts/process-entitlements.sh:

8:09 AM Changeset in webkit [285773] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS][GPUP] Add system call logging
​https://bugs.webkit.org/show_bug.cgi?id=233079
<rdar://problem/85362041>

Reviewed by Brent Fulgham.

Add telemetry for system calls in the GPU process' sandbox on iOS.

• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Nov 12, 2021:

8:45 PM Changeset in webkit [285772] by Jonathan Bedard

• 7 edits in trunk/Tools

[webkitpy] Symlink daemons into simulator runtime root
​https://bugs.webkit.org/show_bug.cgi?id=233080
<rdar://problem/85362551>

Reviewed by Brady Eidson.

• Scripts/webkitpy/api_tests/manager.py:

(Manager._initialize_devices): Symlink daemons in the WebKit.framework into
simulator runtime root.

• Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.symlink):

• Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.symlink):

• Scripts/webkitpy/port/darwin.py:

(DarwinPort.path_to_daemons):

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager.Runtime.init): Add root.
(SimulatedDeviceManager._create_device_with_runtime): Pass runtime.
(SimulatedDevice.init): Link to runtime.

• Scripts/webkitpy/xcode/simulated_device_unittest.py:

Canonical link: ​https://commits.webkit.org/244216@main

7:22 PM Changeset in webkit [285771] by timothy@apple.com

• 3 edits in trunk/Source/WebCore

webView._isBeingInspected does not work with Service Worker pages
​https://bugs.webkit.org/show_bug.cgi?id=233062
rdar://problem/85354982

Reviewed by Devin Rousso.

• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend): Call updateServiceWorkerPageFrontendCount().
(WebCore::WorkerInspectorController::disconnectFrontend): Ditto.
(WebCore::WorkerInspectorController::updateServiceWorkerPageFrontendCount): Added.

• inspector/WorkerInspectorController.h: Added updateServiceWorkerPageFrontendCount().

6:26 PM Changeset in webkit [285770] by Darin Adler

• 15 edits in trunk

Make sort-Xcode-project-file idempotent
​https://bugs.webkit.org/show_bug.cgi?id=233077

Reviewed by Wenson Hsieh.

Source/bmalloc:

• libpas/libpas.xcodeproj/project.pbxproj: Sorted.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj: Sorted.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj: Sorted.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj: Sorted.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj/project.pbxproj: Sorted.

Tools:

• Scripts/sort-Xcode-project-file:

(sortChildrenByFileName): Fix the "directories first" rule to work in a straightforward
way that is symmetric, and make the rest of the rules fall through when two files are
equal for the same reason. Also remove almost all names from the special list of filenames
to treat as files even though they have no extension. For example, "jsc" is a directory
in WebCore and it's not needed to sort products correctly in JavaScriptCore. And
"minidom" is both a product and a directory.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.

6:12 PM Changeset in webkit [285769] by Said Abou-Hallawa

• 3 edits
  2 adds in trunk

REGRESSION(r285481): Infinite recursion with cyclic filter reference
​https://bugs.webkit.org/show_bug.cgi?id=232972
rdar://85264240

Reviewed by Wenson Hsieh.

Source/WebCore:

Before r285481, we were creating the ImageBuffer of the referenced SVGElement
for the FEImage through RenderSVGResourceFilter::postApplyResource(). Now
we create this ImageBuffer through RenderSVGResourceFilter::applyResource().
The difference is at the end of RenderSVGResourceFilter::applyResource()
we add an entry to m_rendererFilterDataMap. This entry was preventing
trying to rebuild the SVGFilter for the same renderer if there is a
cyclic reference.

The fix is to add the entry in m_rendererFilterDataMap before creating the
SVGFilter. If an error happens, this entry will be removed before returning.

Test: svg/filters/feImage-cyclic-reference.svg

• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

• svg/filters/feImage-cyclic-reference-expected.txt: Added.
• svg/filters/feImage-cyclic-reference.svg: Added.

5:23 PM Changeset in webkit [285768] by Russell Epstein

• 1 copy in tags/Safari-612.3.6.1.1

Tag Safari-612.3.6.1.1.

5:22 PM Changeset in webkit [285767] by Russell Epstein

• 1 delete in tags/Safari-612.3.6.1.1

Delete tag.

5:18 PM Changeset in webkit [285766] by Russell Epstein

• 1 edit in branches/safari-612.3.6.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h

Unreviewed build fix. rdar://problem/83159358

error: out-of-line definition of 'isolatedSession' does not match any declaration in 'WebKit::SessionSet'

5:16 PM Changeset in webkit [285765] by Jonathan Bedard

• 9 edits in trunk/Tools

[git-webkit] Checkout pull-requests
​https://bugs.webkit.org/show_bug.cgi?id=233042
<rdar://problem/85343364>

Reviewed by Dewei Zhu.

In GitHub, pull-requests are somewhat difficult to checkout because they're
attached to a specific user's mirror of WebKit. Automate this process.

• Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git): Add username:branch regex.
(Git.checkout): Allow checking out of branches by username:branch.

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:

(Git.init): Add git checkout -B.
(Git.checkout): -B will force checkout a branch, even if one already exists.

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:

(GitHub): Embed error message in 404 response.

• Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:

(Checkout.main): Allow direct checkout of pull-request instead of relying
exclusively on branches.

• Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:

(Clean.main): Add newline.

• Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:

(TestCheckout.test_no_pr_github):
(TestCheckout.test_no_pr_bitbucket):
(TestCheckout.test_pr_github):
(TestCheckout.test_pr_bitbucket):

Canonical link: ​https://commits.webkit.org/244211@main

5:16 PM Changeset in webkit [285764] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Null check m_spanElement
​https://bugs.webkit.org/show_bug.cgi?id=230894

Patch by Rob Buis <​rbuis@igalia.com> on 2021-11-12
Reviewed by Wenson Hsieh.

Source/WebCore:

Null check m_spanElement in ReplaceNodeWithSpanCommand::doUnapply, since
it may not be created by ReplaceNodeWithSpanCommand::doApply.

Test: editing/execCommand/default-paragraph-separator-crash.html

• editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::ReplaceNodeWithSpanCommand::doUnapply):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):

LayoutTests:

• editing/execCommand/default-paragraph-separator-crash-expected.txt: Added.
• editing/execCommand/default-paragraph-separator-crash.html: Added.

4:55 PM Changeset in webkit [285763] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit

_WKWebAuthenticationPanel should expose a way to encode CTAP commands
​https://bugs.webkit.org/show_bug.cgi?id=232977
<rdar://85279329>

Patch by Garrett Davidson <​davidson.garrettm@gmail.com> on 2021-11-12
Reviewed by David Kilzer.

Expose the existing CTAP command encoding through _WKWebAuthenticationPanel.

Covered by existing tests.

• UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
• UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(coreUserVerificationAvailability):
(+[_WKWebAuthenticationPanel getClientDataJSONForAuthenticationType:challenge:origin:])
(+[_WKWebAuthenticationPanel encodeMakeCredentialCommandWithClientDataJSON:options:userVerificationAvailability:]):
(+[_WKWebAuthenticationPanel encodeGetAssertionCommandWithClientDataJSON:options:userVerificationAvailability:]):

4:11 PM Changeset in webkit [285762] by Russell Epstein

• 1 copy in tags/Safari-612.3.6.2.1

Tag Safari-612.3.6.2.1.

4:08 PM Changeset in webkit [285761] by Russell Epstein

• 1 copy in tags/Safari-612.3.6.0.1

Tag Safari-612.3.6.0.1.

4:08 PM Changeset in webkit [285760] by commit-queue@webkit.org

• 72 edits
  94 adds
  2 deletes in trunk/JSTests

[JSC] update test262
​https://bugs.webkit.org/show_bug.cgi?id=233058

For picking up changes to the ShadowRealms test set.

Patch by Joseph Griego <​jgriego@igalia.com> on 2021-11-12
Reviewed by Yusuke Suzuki.

• test262/expectations.yaml:
• test262/harness/arrayContains.js: Removed.
• test262/harness/async-gc.js:
• test262/latest-changes-summary.txt:
• test262/test/built-ins/Array/prototype/every/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/filter/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/find/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/findIndex/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/findLast/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/findLastIndex/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/forEach/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/map/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/reduce/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/reduceRight/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/Array/prototype/some/callbackfn-resize-arraybuffer.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/DataView/prototype/byteLength/resizable-array-buffer-auto.js:

(catch):

• test262/test/built-ins/DataView/prototype/byteOffset/resizable-array-buffer-auto.js:

(catch):

• test262/test/built-ins/FinalizationRegistry/gc-has-one-chance-to-call-cleanupCallback.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/callback-not-callable-throws.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/cleanup-prevented-with-reference.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/cleanup-prevented-with-unregister.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/custom-this.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/holdings-multiple-values.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/length.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/name.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/prop-desc.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/reentrancy.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/return-undefined-with-gc.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/return-undefined.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/this-does-not-have-internal-cells-throws.js:
• test262/test/built-ins/FinalizationRegistry/prototype/cleanupSome/this-not-object-throws.js:
• test262/test/built-ins/FinalizationRegistry/prototype/unregister/unregister-cleaned-up-cell.js:
• test262/test/built-ins/Object/getOwnPropertyNames/15.2.3.4-4-2.js:
• test262/test/built-ins/RegExp/match-indices/indices-array-non-unicode-match.js:
• test262/test/built-ins/RegExp/match-indices/indices-array-unicode-match.js:
• test262/test/built-ins/RegExp/match-indices/indices-array-unicode-property-names.js:
• test262/test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-proto-from-caller-realm.js:
• test262/test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-throws-typeerror-from-caller-realm.js: Added.

(realm.Reflect.construct):

• test262/test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-throws-typeerror-on-non-primitive-arguments.js: Added.

(Symbol.toPrimitive):
(toString):
(valueOf):
(apply):

• test262/test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-throws-typeerror-on-non-primitive-returns.js: Added.

(r.evaluate):

• test262/test/built-ins/ShadowRealm/prototype/evaluate/wrapped-functions-accepts-callable-objects.js:
• test262/test/built-ins/SharedArrayBuffer/prototype/prop-desc.js: Added.
• test262/test/built-ins/Temporal/Duration/compare/calendar-fields-iterable.js:
• test262/test/built-ins/Temporal/Duration/compare/relativeto-string-zoneddatetime-wrong-offset.js: Added.
• test262/test/built-ins/Temporal/Duration/compare/relativeto-sub-minute-offset.js: Added.
• test262/test/built-ins/Temporal/Duration/prototype/add/calendar-fields-iterable.js:
• test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-no-time-units.js: Added.

(const.result.instance.add.new.Temporal.Duration):

• test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-string-zoneddatetime-wrong-offset.js: Added.

(instance.add.new.Temporal.Duration):

• test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-sub-minute-offset.js: Added.

(const.result.instance.add.new.Temporal.Duration):
(instance.add.new.Temporal.Duration):

• test262/test/built-ins/Temporal/Duration/prototype/round/calendar-fields-iterable.js:
• test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-string-zoneddatetime-wrong-offset.js: Added.
• test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-sub-minute-offset.js: Added.
• test262/test/built-ins/Temporal/Duration/prototype/subtract/calendar-fields-iterable.js:
• test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-no-time-units.js: Added.

(const.result.instance.subtract.new.Temporal.Duration):

• test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-string-zoneddatetime-wrong-offset.js: Added.

(instance.subtract.new.Temporal.Duration):

• test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-sub-minute-offset.js: Added.

(const.result.instance.subtract.new.Temporal.Duration):
(instance.subtract.new.Temporal.Duration):

• test262/test/built-ins/Temporal/Duration/prototype/total/calendar-fields-iterable.js:
• test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-string-zoneddatetime-wrong-offset.js: Added.
• test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-sub-minute-offset.js: Added.
• test262/test/built-ins/Temporal/Instant/prototype/toString/timezone-offset.js: Added.

(test):

• test262/test/built-ins/Temporal/Instant/prototype/toString/timezone-string-datetime.js:
• test262/test/built-ins/Temporal/Instant/prototype/toString/timezone.js:
• test262/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-higher-units.js:
• test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/PlainTime/compare/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/PlainTime/from/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/PlainTime/prototype/equals/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/PlainTime/prototype/since/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/PlainTime/prototype/until/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/TimeZone/prototype/getOffsetStringFor/basic.js: Added.

(test):

• test262/test/built-ins/Temporal/ZonedDateTime/from/zoneddatetime-sub-minute-offset.js: Added.

(string_appeared_here.forEach):

• test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/sub-minute-offset.js: Added.
• test262/test/built-ins/Temporal/ZonedDateTime/prototype/getISOFields/offset.js: Added.

(test):

• test262/test/built-ins/Temporal/ZonedDateTime/prototype/offset/basic.js: Added.

(test):

• test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/sub-minute-offset.js: Added.
• test262/test/built-ins/Temporal/ZonedDateTime/prototype/toJSON/balance-negative-time-units.js:
• test262/test/built-ins/Temporal/ZonedDateTime/prototype/toJSON/offset.js: Added.

(test):

• test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/balance-negative-time-units.js:
• test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/offset.js: Added.

(test):

• test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/sub-minute-offset.js: Added.
• test262/test/built-ins/Temporal/ZonedDateTime/prototype/with/offset-property-sub-minute.js: Added.

(string_appeared_here.forEach):

• test262/test/built-ins/Temporal/ZonedDateTime/prototype/with/receiver-offset-broken.js: Added.

(ObservedCalendar):
(ObservedCalendar.prototype.toString):
(ObservedCalendar.prototype.mergeFields):
(ObservedCalendar.prototype.resetCalls):

• test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/plaintime-propertybag-no-time-units.js: Added.
• test262/test/built-ins/Temporal/getOwnPropertyNames.js:
• test262/test/built-ins/TypedArray/prototype/every/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/filter/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/find/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/findIndex/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/findLast/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/findLastIndex/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/forEach/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/map/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/reduce/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/reduceRight/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/TypedArray/prototype/some/callbackfn-resize.js: Added.

(testWithTypedArrayConstructors):

• test262/test/built-ins/WeakRef/prototype/deref/gc-cleanup-not-prevented-with-wr-deref.js:
• test262/test/harness/arrayContains.js: Removed.
• test262/test/harness/testTypedArray.js:
• test262/test/intl402/Collator/prototype/resolvedOptions/order.js:
• test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/order-dayPeriod.js:
• test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/order-fractionalSecondDigits.js:
• test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/order-style.js:
• test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/order.js:
• test262/test/intl402/ListFormat/prototype/resolvedOptions/order.js:
• test262/test/intl402/NumberFormat/constructor-options-roundingMode-invalid.js: Added.

(brokenToString.toString):

• test262/test/intl402/NumberFormat/constructor-options-throwing-getters-rounding-mode.js: Added.

(get roundingMode):

• test262/test/intl402/NumberFormat/constructor-signDisplay-negative.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-ceil.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-expand.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-floor.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-half-ceil.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-half-even.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-half-expand.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-half-floor.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-half-trunc.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/format-rounding-mode-trunc.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-currency-de-DE.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-currency-en-US.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-currency-ja-JP.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-currency-ko-KR.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-currency-zh-TW.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-de-DE.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-en-US.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-ja-JP.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-ko-KR.js: Added.
• test262/test/intl402/NumberFormat/prototype/format/signDisplay-negative-zh-TW.js: Added.
• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-currency-de-DE.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-currency-en-US.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-currency-ja-JP.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-currency-ko-KR.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-currency-zh-TW.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-de-DE.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-en-US.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-ja-JP.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-ko-KR.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-negative-zh-TW.js: Added.

(verifyFormatParts):
(verifyFormatParts.nf.formatToParts):

• test262/test/intl402/NumberFormat/prototype/resolvedOptions/order.js:
• test262/test/intl402/NumberFormat/prototype/resolvedOptions/roundingMode.js: Added.
• test262/test/intl402/PluralRules/prototype/resolvedOptions/order.js:
• test262/test/intl402/RelativeTimeFormat/prototype/resolvedOptions/order.js:
• test262/test/intl402/Segmenter/prototype/resolvedOptions/order.js:
• test262/test/language/block-scope/syntax/for-in/acquire-properties-from-array.js:
• test262/test/language/block-scope/syntax/for-in/acquire-properties-from-object.js:
• test262/test/language/expressions/dynamic-import/usage/nested-arrow-assignment-expression-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-arrow-import-then-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-async-arrow-function-await-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-async-arrow-function-return-await-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-async-function-await-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-async-function-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-async-function-return-await-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-async-gen-await-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-async-gen-return-await-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-block-import-then-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-do-while-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-else-import-then-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-function-import-then-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-if-braceless-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-if-import-then-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/nested-while-import-then-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/syntax-nested-block-labeled-eval-script-code-host-resolves-module-code.js:
• test262/test/language/expressions/dynamic-import/usage/top-level-import-then-eval-script-code-host-resolves-module-code.js:
• test262/test262-Revision.txt:

4:07 PM Changeset in webkit [285759] by Russell Epstein

• 1 copy in tags/Safari-612.3.6.1.1

Tag Safari-612.3.6.1.1.

4:01 PM Changeset in webkit [285758] by guijemont@igalia.com

• 2 edits in trunk/JSTests

Unskip typeProfiler/getter-richards.js on armv7
​https://bugs.webkit.org/show_bug.cgi?id=233050

Unreviewed gardening.

Our arm bots are now fast enough to run this, it does still timeout on
some of our test mips devices though.

• typeProfiler/getter-richards.js:

3:56 PM Changeset in webkit [285757] by bshafiei@apple.com

• 1 copy in tags/Safari-613.1.7.4

Tag Safari-613.1.7.4.

3:54 PM Changeset in webkit [285756] by Russell Epstein

• 3 edits in branches/safari-612.3.6.1-branch/Source/WebKit

Revert r285690. rdar://problem/83381842

3:54 PM Changeset in webkit [285755] by Russell Epstein

• 2 edits in branches/safari-612.3.6.1-branch/Source/WebCore

Revert r285691. rdar://problem/83381842

3:54 PM Changeset in webkit [285754] by Russell Epstein

• 3 edits in branches/safari-612.3.6.1-branch/Source/WebCore

Revert r285680. rdar://problem/85004449

3:54 PM Changeset in webkit [285753] by Russell Epstein

• 3 edits in branches/safari-612.3.6.0-branch/Source/WebKit

Revert r285683. rdar://problem/83381842

3:54 PM Changeset in webkit [285752] by Russell Epstein

• 2 edits in branches/safari-612.3.6.0-branch/Source/WebCore

Revert r285684. rdar://problem/83381842

3:54 PM Changeset in webkit [285751] by Russell Epstein

• 3 edits in branches/safari-612.3.6.0-branch/Source/WebCore

Revert r285682. rdar://problem/85004449

3:48 PM Changeset in webkit [285750] by bshafiei@apple.com

• 2 edits in branches/safari-613.1.7-branch/Source/WebCore/PAL

Cherry-pick r285744. rdar://problem/85341122

Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Replace these static NSString definitions with soft-linked constants instead.

• pal/spi/cocoa/NSAttributedStringSPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@285744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:47 PM Changeset in webkit [285749] by bshafiei@apple.com

• 8 edits in branches/safari-613.1.7-branch/Source

Versioning.

WebKit-7613.1.7.4

3:45 PM Changeset in webkit [285748] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS][GPUP] Allow access to syscalls
​https://bugs.webkit.org/show_bug.cgi?id=232825
<rdar://problem/85164522>

Reviewed by Brent Fulgham.

Based on telemetry, add access to unix syscalls in the GPU process on iOS.

• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

3:17 PM Changeset in webkit [285747] by Chris Dumez

• 4 edits
  2 adds in trunk

Crash when accessing reason property of a newly created AbortSignal
​https://bugs.webkit.org/show_bug.cgi?id=233066
<rdar://problem/85249306>

Reviewed by Geoffrey Garen.

Source/WebCore:

Make sure AbortSignal.reason get initialized to jsUndefined() by default
and not a default-constructed JSValue.

Test: fast/dom/AbortSignal-reason-crash.html

• dom/AbortSignal.cpp:

(WebCore::AbortSignal::AbortSignal):

• dom/AbortSignal.h:

LayoutTests:

Add layout test coverage.

• fast/dom/AbortSignal-reason-crash-expected.txt: Added.
• fast/dom/AbortSignal-reason-crash.html: Added.

3:11 PM Changeset in webkit [285746] by sihui_liu@apple.com

• 6 edits
  1 add in trunk

Set default general storage directory to websiteDataDirectory
​https://bugs.webkit.org/show_bug.cgi?id=232985

Reviewed by Geoffrey Garen.

Source/WebKit:

New API test: FileSystemAccess.MigrateToNewStorageDirectory

• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultGeneralStorageDirectory):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:
• TestWebKitAPI/Tests/WebKitCocoa/file-system-access.salt: Added.

3:00 PM Changeset in webkit [285745] by Ryan Haddad

• 19 edits in trunk

Unreviewed, reverting r285583.

Seems to have caused many layout tests to become flaky
failures

Reverted changeset:

"[css-contain] Support contain:paint"
​https://bugs.webkit.org/show_bug.cgi?id=224742
​https://commits.webkit.org/r285583

2:47 PM Changeset in webkit [285744] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore/PAL

Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Replace these static NSString definitions with soft-linked constants instead.

• pal/spi/cocoa/NSAttributedStringSPI.h:

2:32 PM Changeset in webkit [285743] by Chris Dumez

• 2 edits in trunk/LayoutTests

Regression(r285639) fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1
​https://bugs.webkit.org/show_bug.cgi?id=233043
<rdar://problem/85343956>

Unreviewed, unskip the test now that Alexey reverted r285639.

• platform/mac-wk1/TestExpectations:

2:20 PM Changeset in webkit [285742] by timothy@apple.com

• 3 edits in trunk/Source/WebKit

Remove non-completionHandler version of -[WKWebView _loadServiceWorker:]
​https://bugs.webkit.org/show_bug.cgi?id=233069
rdar://problem/85355540

Reviewed by Chris Dumez.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _loadServiceWorker:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed _loadServiceWorker:.

2:14 PM Changeset in webkit [285741] by Peng Liu

• 12 edits in trunk

Promote WKPreferences._fullScreenEnabled to API
​https://bugs.webkit.org/show_bug.cgi?id=230784
<rdar://83255308>

Reviewed by Jer Noble.

Source/WebKit:

• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences isElementFullscreenEnabled]):
(-[WKPreferences setElementFullscreenEnabled:]):

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView fullscreenState]):

• UIProcess/Cocoa/FullscreenClient.h:
• UIProcess/Cocoa/FullscreenClient.mm:

(WebKit::FullscreenClient::willEnterFullscreen):
(WebKit::FullscreenClient::didEnterFullscreen):
(WebKit::FullscreenClient::willExitFullscreen):
(WebKit::FullscreenClient::didExitFullscreen):

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::WebViewImpl):

• UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::willEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::didEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::willExitFullScreen):
(WebKit::WebFullScreenManagerProxy::didExitFullScreen):

• UIProcess/WebFullScreenManagerProxy.h:

(WebKit::WebFullScreenManagerProxy::fullscreenState const):

Tools:

• MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate defaultConfiguration]):

2:11 PM Changeset in webkit [285740] by commit-queue@webkit.org

• 11 edits in trunk

Implement custom element definition's *disable shadow* flag
​https://bugs.webkit.org/show_bug.cgi?id=233023

Patch by Alexey Shvayka <​ashvayka@apple.com> on 2021-11-12
Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing or failing later on.

• web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
• web-platform-tests/custom-elements/upgrading-expected.txt:
• web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:

Source/WebCore:

This change implements *disable shadow* flag that precludes attachShadow() [1]
as well as upgrading an element with already attached shadow root [2].

Aligns WebKit with Blink and Gecko.
Preserves the fast path for non-custom elements.

[1] ​https://dom.spec.whatwg.org/#ref-for-concept-custom-element-definition-disable-shadow
[2] ​https://html.spec.whatwg.org/multipage/custom-elements.html#upgrades:concept-custom-element-definition-disable-shadow

Tests: imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html

imported/w3c/web-platform-tests/custom-elements/upgrading.html
imported/w3c/web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element.html

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::JSCustomElementInterface):
(WebCore::JSCustomElementInterface::upgradeElement):

• bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::disableShadow):
(WebCore::JSCustomElementInterface::isShadowDisabled const):

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::addElementDefinition):

• dom/CustomElementRegistry.h:

(WebCore::CustomElementRegistry::isShadowDisabled const):

• dom/Element.cpp:

(WebCore::canAttachAuthorShadowRoot):

1:23 PM Changeset in webkit [285739] by Chris Dumez

• 6 edits in trunk

Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI
​https://bugs.webkit.org/show_bug.cgi?id=233059

Reviewed by Geoffrey Garen.

Source/WebKit:

Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI until we reach
agreement on a suitable API name.

• UIProcess/API/Cocoa/WKWebpagePreferences.h:
• UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):
(-[WKWebpagePreferences _captivePortalModeEnabled]):
(-[WKWebpagePreferences setCaptivePortalModeEnabled:]): Deleted.
(-[WKWebpagePreferences captivePortalModeEnabled]): Deleted.

• UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:

Tools:

Update API test accordingly.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

1:22 PM Changeset in webkit [285738] by commit-queue@webkit.org

• 44 edits
  9 deletes in trunk

Unreviewed, reverting r285639.
​https://bugs.webkit.org/show_bug.cgi?id=233065

Causes Geolocation test crashes

Reverted changeset:

"JSCallbackData should use lexical global object for errors
and lifecycle"
​https://bugs.webkit.org/show_bug.cgi?id=232387
​https://commits.webkit.org/r285639

12:38 PM Changeset in webkit [285737] by Chris Dumez

• 3 edits
  1 copy
  1 add
  1 delete in trunk/Source/WebKit

Rename ProcessLauncherMac.mm to ProcessLauncherCocoa.mm
​https://bugs.webkit.org/show_bug.cgi?id=233045
<rdar://problem/85347107>

Reviewed by Brent Fulgham.

Follow-up to r285729 to rename to ProcessLauncherCocoa.mm instead of ProcessLauncherDarwin.mm
given that the implementation is using NSBundle.

• SourcesCocoa.txt:
• UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: Renamed from Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm.

(WebKit::serviceName):
(WebKit::shouldLeakBoost):
(WebKit::systemDirectoryPath):
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):
(WebKit::ProcessLauncher::terminateXPCConnection):
(WebKit::terminateWithReason):

• WebKit.xcodeproj/project.pbxproj:

12:15 PM Changeset in webkit [285736] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

REGRESSION (r285698): Build correction after refactoring id handling
​https://bugs.webkit.org/show_bug.cgi?id=233052
<rdar://problem/85347865>

Reviewed by Chris Dumez.

Build fix after r285698. The new 'toNSData' method needs its namespace included.

• UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

(WebKit::toASCDescriptor):
(WebKit::configureRegistrationRequestContext):
(WebKit::configurationAssertionRequestContext):
(WebKit::toNSData): Deleted.

12:09 PM Changeset in webkit [285735] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS][GPUP] Block access to mach register
​https://bugs.webkit.org/show_bug.cgi?id=232259
<rdar://problem/84624488>

Reviewed by Brent Fulgham.

Based on telemetry, block access to mach register in the GPU process on macOS.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

11:50 AM Changeset in webkit [285734] by don.olmstead@sony.com

• 6 edits in trunk

[WinCairo] Add Little-CMS support
​https://bugs.webkit.org/show_bug.cgi?id=233024

Reviewed by Michael Catanzaro.

.:

Search for LCMS2 and if its present turn it on for WinCairo.

• Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

Centralize addition of LCMS2::LCMS2 to the root CMakeLists in WebCore.

• CMakeLists.txt:
• PlatformGTK.cmake:
• PlatformWPE.cmake:

11:13 AM Changeset in webkit [285733] by Jonathan Bedard

• 8 edits in trunk/Tools

[git-webkit] Open closed pull-request when running pr
​https://bugs.webkit.org/show_bug.cgi?id=232765
<rdar://problem/85084318>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:

(BitBucket.request): Ensure displayId is set when updating PR.

• Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:

(GitHub.request): Make sure that new pull-requests are open.

• Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:

(PullRequest.main): Open closed pull-requests.

• Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:

(GitHub.PRGenerator.update): Only set head if user specifies head.

• Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

Canonical link: ​https://commits.webkit.org/244192@main

11:02 AM Changeset in webkit [285732] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Null check host in SlotAssignment::assignSlots
​https://bugs.webkit.org/show_bug.cgi?id=230899

Patch by Rob Buis <​rbuis@igalia.com> on 2021-11-12
Reviewed by Darin Adler.

Source/WebCore:

Null check host in SlotAssignment::assignSlots.

Tests: fast/shadow-dom/shadow-root-gc-crash.html

• dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::assignSlots):

LayoutTests:

• fast/shadow-dom/shadow-root-gc-crash-expected.txt: Added.
• fast/shadow-dom/shadow-root-gc-crash.html: Added.

10:29 AM Changeset in webkit [285731] by Chris Dumez

• 11 edits in trunk

Disable MathML when in Captive Portal Mode
​https://bugs.webkit.org/show_bug.cgi?id=233013
<rdar://84567129>

Reviewed by Brent Fulgham.

Source/WebCore:

Add runtime feature flag for MathML and update implementation in WebCore to only support
MathML when the flag is on.

• bindings/js/WebCoreBuiltinNames.h:
• dom/Document.cpp:

(WebCore::Document::createElement):

• mathml/MathMLElement.idl:
• mathml/MathMLMathElement.idl:

Source/WebKit:

Turn off MathML support when in Captive Portal Mode.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WTF:

Add runtime feature flag for MathML.

• Scripts/Preferences/WebPreferences.yaml:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

10:15 AM Changeset in webkit [285730] by mark.lam@apple.com

• 454 edits in trunk/Source

Refactor allocateCell() and tryAllocateCell() to take VM& instead of Heap&.
​https://bugs.webkit.org/show_bug.cgi?id=233028
rdar://85329680

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

allocateCell() and tryAllocateCell() can fetch Heap& from VM& themselves. This
allows us to make all the client code more terse, and also makes it easier to
redirect the underlying heap to allocate from later for global GC work.
Additionally, this will help make the global GC patch less of a mega patch and
easier to review later.

• API/JSAPIGlobalObject.h:
• API/JSAPIValueWrapper.h:
• API/JSCallbackConstructor.h:
• API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::create):

• API/JSCallbackObject.cpp:

(JSC::JSCallbackObject<JSGlobalObject>::create):

• API/JSCallbackObject.h:
• API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunction::create):

• API/glib/JSAPIWrapperGlobalObject.cpp:

(JSC::JSCallbackObject<JSAPIWrapperGlobalObject>::create):

• API/glib/JSCCallbackFunction.cpp:

(JSC::JSCCallbackFunction::create):

• bytecode/EvalCodeBlock.h:
• bytecode/ExecutableToCodeBlockEdge.cpp:

(JSC::ExecutableToCodeBlockEdge::create):

• bytecode/FunctionCodeBlock.h:
• bytecode/ModuleProgramCodeBlock.h:
• bytecode/ProgramCodeBlock.h:
• bytecode/UnlinkedEvalCodeBlock.h:
• bytecode/UnlinkedFunctionCodeBlock.h:
• bytecode/UnlinkedFunctionExecutable.h:
• bytecode/UnlinkedModuleProgramCodeBlock.h:
• bytecode/UnlinkedProgramCodeBlock.h:
• debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::create):

• inspector/JSInjectedScriptHost.h:
• inspector/JSInjectedScriptHostPrototype.h:
• inspector/JSJavaScriptCallFrame.h:
• inspector/JSJavaScriptCallFramePrototype.h:
• jsc.cpp:

(JSCMemoryFootprint::create):
(JSFileDescriptor::create):

• runtime/AggregateErrorConstructor.h:
• runtime/AggregateErrorPrototype.h:
• runtime/ArrayConstructor.h:
• runtime/ArrayIteratorPrototype.h:
• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::create):

• runtime/AsyncFromSyncIteratorPrototype.cpp:

(JSC::AsyncFromSyncIteratorPrototype::create):

• runtime/AsyncFunctionConstructor.h:
• runtime/AsyncFunctionPrototype.h:
• runtime/AsyncGeneratorFunctionConstructor.h:
• runtime/AsyncGeneratorFunctionPrototype.h:
• runtime/AsyncGeneratorPrototype.h:
• runtime/AsyncIteratorPrototype.h:
• runtime/AtomicsObject.cpp:

(JSC::AtomicsObject::create):

• runtime/BigIntConstructor.h:
• runtime/BigIntObject.cpp:

(JSC::BigIntObject::create):

• runtime/BigIntPrototype.h:
• runtime/BooleanConstructor.h:
• runtime/BooleanObject.h:

(JSC::BooleanObject::create):

• runtime/BooleanPrototype.h:
• runtime/BrandedStructure.cpp:

(JSC::BrandedStructure::create):

• runtime/CachedTypes.cpp:

(JSC::CachedProgramCodeBlock::decode const):
(JSC::CachedModuleCodeBlock::decode const):
(JSC::CachedEvalCodeBlock::decode const):
(JSC::CachedFunctionCodeBlock::decode const):
(JSC::CachedFunctionExecutable::decode const):

• runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::createEmpty):

• runtime/ConsoleObject.h:
• runtime/CustomGetterSetter.h:

(JSC::CustomGetterSetter::create):

• runtime/DOMAttributeGetterSetter.h:
• runtime/DateConstructor.h:
• runtime/DateInstance.h:
• runtime/DatePrototype.h:
• runtime/DirectArguments.cpp:

(JSC::DirectArguments::createUninitialized):

• runtime/DirectEvalExecutable.cpp:

(JSC::DirectEvalExecutable::create):

• runtime/ErrorConstructor.h:
• runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):

• runtime/ErrorPrototype.h:
• runtime/Exception.cpp:

(JSC::Exception::create):

• runtime/FinalizationRegistryConstructor.h:
• runtime/FinalizationRegistryPrototype.h:
• runtime/FunctionConstructor.h:
• runtime/FunctionExecutable.h:
• runtime/FunctionPrototype.h:
• runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::create):

• runtime/GeneratorFunctionConstructor.h:
• runtime/GeneratorFunctionPrototype.h:
• runtime/GeneratorPrototype.h:
• runtime/GetterSetter.h:
• runtime/HashMapImpl.h:
• runtime/IndirectEvalExecutable.cpp:

(JSC::IndirectEvalExecutable::createImpl):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createFunctionThatMasqueradesAsUndefined):

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::create):

• runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructor::create):

• runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototype::create):

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::create):

• runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructor::create):

• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::create):

• runtime/IntlDisplayNames.cpp:

(JSC::IntlDisplayNames::create):

• runtime/IntlDisplayNamesConstructor.cpp:

(JSC::IntlDisplayNamesConstructor::create):

• runtime/IntlDisplayNamesPrototype.cpp:

(JSC::IntlDisplayNamesPrototype::create):

• runtime/IntlListFormat.cpp:

(JSC::IntlListFormat::create):

• runtime/IntlListFormatConstructor.cpp:

(JSC::IntlListFormatConstructor::create):

• runtime/IntlListFormatPrototype.cpp:

(JSC::IntlListFormatPrototype::create):

• runtime/IntlLocale.cpp:

(JSC::IntlLocale::create):

• runtime/IntlLocaleConstructor.cpp:

(JSC::IntlLocaleConstructor::create):

• runtime/IntlLocalePrototype.cpp:

(JSC::IntlLocalePrototype::create):

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::create):

• runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructor::create):

• runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::create):

• runtime/IntlObject.cpp:

(JSC::IntlObject::create):

• runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::create):

• runtime/IntlPluralRulesConstructor.cpp:

(JSC::IntlPluralRulesConstructor::create):

• runtime/IntlPluralRulesPrototype.cpp:

(JSC::IntlPluralRulesPrototype::create):

• runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::create):

• runtime/IntlRelativeTimeFormatConstructor.cpp:

(JSC::IntlRelativeTimeFormatConstructor::create):

• runtime/IntlRelativeTimeFormatPrototype.cpp:

(JSC::IntlRelativeTimeFormatPrototype::create):

• runtime/IntlSegmentIterator.cpp:

(JSC::IntlSegmentIterator::create):

• runtime/IntlSegmentIteratorPrototype.cpp:

(JSC::IntlSegmentIteratorPrototype::create):

• runtime/IntlSegmenter.cpp:

(JSC::IntlSegmenter::create):

• runtime/IntlSegmenterConstructor.cpp:

(JSC::IntlSegmenterConstructor::create):

• runtime/IntlSegmenterPrototype.cpp:

(JSC::IntlSegmenterPrototype::create):

• runtime/IntlSegments.cpp:

(JSC::IntlSegments::create):

• runtime/IntlSegmentsPrototype.cpp:

(JSC::IntlSegmentsPrototype::create):

• runtime/IteratorPrototype.h:
• runtime/JSArray.h:

(JSC::JSArray::createWithButterfly):

• runtime/JSArrayBuffer.cpp:

(JSC::JSArrayBuffer::create):

• runtime/JSArrayBufferConstructor.h:
• runtime/JSArrayBufferPrototype.cpp:

(JSC::JSArrayBufferPrototype::create):

• runtime/JSArrayIterator.cpp:

(JSC::JSArrayIterator::create):
(JSC::JSArrayIterator::createWithInitialValues):

• runtime/JSAsyncFunction.cpp:

(JSC::JSAsyncFunction::createImpl):

• runtime/JSAsyncGenerator.cpp:

(JSC::JSAsyncGenerator::create):

• runtime/JSAsyncGeneratorFunction.cpp:

(JSC::JSAsyncGeneratorFunction::createImpl):

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::createWithLength):

• runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):

• runtime/JSCallee.h:

(JSC::JSCallee::create):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::allocateCell):
(JSC::tryAllocateCell):

• runtime/JSCustomGetterFunction.cpp:

(JSC::JSCustomGetterFunction::create):

• runtime/JSCustomSetterFunction.cpp:

(JSC::JSCustomSetterFunction::create):

• runtime/JSDataView.cpp:

(JSC::JSDataView::create):

• runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::create):

• runtime/JSFinalizationRegistry.cpp:

(JSC::JSFinalizationRegistry::create):

• runtime/JSFunction.cpp:

(JSC::JSFunction::create):

• runtime/JSFunction.h:

(JSC::JSFunction::createImpl):

• runtime/JSGenerator.cpp:

(JSC::JSGenerator::create):

• runtime/JSGeneratorFunction.cpp:

(JSC::JSGeneratorFunction::createImpl):

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::create):

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::create):
(JSC::JSGenericTypedArrayView<Adaptor>::createWithFastVector):
(JSC::JSGenericTypedArrayView<Adaptor>::createUninitialized):

• runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::create):

• runtime/JSGlobalLexicalEnvironment.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::createWithCustomMethodTable):

• runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::tryCreate):

• runtime/JSInternalPromise.cpp:

(JSC::JSInternalPromise::create):

• runtime/JSInternalPromiseConstructor.cpp:

(JSC::JSInternalPromiseConstructor::create):

• runtime/JSInternalPromisePrototype.cpp:

(JSC::JSInternalPromisePrototype::create):

• runtime/JSLexicalEnvironment.h:

(JSC::JSLexicalEnvironment::create):

• runtime/JSMap.cpp:

(JSC::JSMap::clone):

• runtime/JSMap.h:
• runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::createWithInitialValues):

• runtime/JSMapIterator.h:
• runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::create):

• runtime/JSModuleLoader.h:
• runtime/JSModuleNamespaceObject.h:
• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::create):

• runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::create):

• runtime/JSONObject.h:
• runtime/JSObject.h:

(JSC::JSFinalObject::createWithButterfly):

• runtime/JSPromise.cpp:

(JSC::JSPromise::create):

• runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::create):

• runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::create):

• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::create):

• runtime/JSProxy.h:

(JSC::JSProxy::create):

• runtime/JSScriptFetchParameters.h:
• runtime/JSScriptFetcher.h:
• runtime/JSSet.cpp:

(JSC::JSSet::clone):

• runtime/JSSet.h:
• runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::createWithInitialValues):

• runtime/JSSetIterator.h:
• runtime/JSSourceCode.h:
• runtime/JSString.cpp:

(JSC::JSString::createEmptyString):
(JSC::StringObject::create):

• runtime/JSString.h:

(JSC::JSString::create):
(JSC::JSString::createHasOtherOwner):

• runtime/JSStringIterator.h:
• runtime/JSTemplateObjectDescriptor.cpp:

(JSC::JSTemplateObjectDescriptor::create):

• runtime/JSTypedArrayViewConstructor.h:
• runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::create):

• runtime/JSWeakMap.h:
• runtime/JSWeakObjectRef.h:
• runtime/JSWeakSet.h:
• runtime/JSWithScope.cpp:

(JSC::JSWithScope::create):

• runtime/MapConstructor.h:
• runtime/MapIteratorPrototype.h:
• runtime/MapPrototype.h:
• runtime/MathObject.h:
• runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::create):

• runtime/NativeErrorConstructor.h:
• runtime/NativeErrorPrototype.h:
• runtime/NativeExecutable.cpp:

(JSC::NativeExecutable::create):

• runtime/NullGetterFunction.h:
• runtime/NullSetterFunction.h:
• runtime/NumberConstructor.h:
• runtime/NumberObject.h:

(JSC::NumberObject::create):

• runtime/NumberPrototype.h:
• runtime/ObjectConstructor.h:
• runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::create):

• runtime/ProgramExecutable.h:
• runtime/PropertyTable.cpp:

(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):

• runtime/ProxyConstructor.cpp:

(JSC::ProxyConstructor::create):

• runtime/ProxyObject.h:
• runtime/ProxyRevoke.cpp:

(JSC::ProxyRevoke::create):

• runtime/ReflectObject.h:
• runtime/RegExp.cpp:

(JSC::RegExp::createWithoutCaching):

• runtime/RegExpConstructor.h:
• runtime/RegExpObject.h:
• runtime/RegExpPrototype.h:
• runtime/RegExpStringIteratorPrototype.h:
• runtime/ScopedArguments.cpp:

(JSC::ScopedArguments::createUninitialized):

• runtime/ScopedArgumentsTable.cpp:

(JSC::ScopedArgumentsTable::create):
(JSC::ScopedArgumentsTable::tryCreate):

• runtime/SetConstructor.h:
• runtime/SetIteratorPrototype.h:
• runtime/SetPrototype.h:
• runtime/ShadowRealmConstructor.h:
• runtime/ShadowRealmObject.cpp:

(JSC::ShadowRealmObject::create):

• runtime/ShadowRealmPrototype.h:
• runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::create):

• runtime/StrictEvalActivation.h:
• runtime/StringConstructor.h:
• runtime/StringIteratorPrototype.h:
• runtime/StringObject.h:

(JSC::StringObject::create):

• runtime/StringPrototype.cpp:

(JSC::StringPrototype::create):

• runtime/StructureChain.cpp:

(JSC::StructureChain::create):

• runtime/StructureInlines.h:

(JSC::Structure::create):
(JSC::Structure::createStructure):

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::create):

• runtime/Symbol.cpp:

(JSC::SymbolObject::create):
(JSC::Symbol::create):
(JSC::Symbol::createWithDescription):

• runtime/SymbolConstructor.h:
• runtime/SymbolObject.h:
• runtime/SymbolPrototype.h:
• runtime/SymbolTable.h:
• runtime/TemporalCalendar.cpp:

(JSC::TemporalCalendar::create):

• runtime/TemporalCalendarConstructor.cpp:

(JSC::TemporalCalendarConstructor::create):

• runtime/TemporalCalendarPrototype.cpp:

(JSC::TemporalCalendarPrototype::create):

• runtime/TemporalDuration.cpp:

(JSC::TemporalDuration::create):

• runtime/TemporalDurationConstructor.cpp:

(JSC::TemporalDurationConstructor::create):

• runtime/TemporalDurationPrototype.cpp:

(JSC::TemporalDurationPrototype::create):

• runtime/TemporalInstant.cpp:

(JSC::TemporalInstant::create):

• runtime/TemporalInstantConstructor.cpp:

(JSC::TemporalInstantConstructor::create):

• runtime/TemporalInstantPrototype.cpp:

(JSC::TemporalInstantPrototype::create):

• runtime/TemporalNow.cpp:

(JSC::TemporalNow::create):

• runtime/TemporalObject.cpp:

(JSC::TemporalObject::create):

• runtime/TemporalPlainTime.cpp:

(JSC::TemporalPlainTime::create):

• runtime/TemporalPlainTimeConstructor.cpp:

(JSC::TemporalPlainTimeConstructor::create):

• runtime/TemporalPlainTimePrototype.cpp:

(JSC::TemporalPlainTimePrototype::create):

• runtime/TemporalTimeZone.cpp:

(JSC::TemporalTimeZone::createFromID):
(JSC::TemporalTimeZone::createFromUTCOffset):

• runtime/TemporalTimeZoneConstructor.cpp:

(JSC::TemporalTimeZoneConstructor::create):

• runtime/TemporalTimeZonePrototype.cpp:

(JSC::TemporalTimeZonePrototype::create):

• runtime/WeakMapConstructor.h:
• runtime/WeakMapPrototype.h:
• runtime/WeakObjectRefConstructor.h:
• runtime/WeakObjectRefPrototype.h:
• runtime/WeakSetConstructor.h:
• runtime/WeakSetPrototype.h:
• testRegExp.cpp:
• tools/JSDollarVM.cpp:
• tools/JSDollarVM.h:
• wasm/js/JSToWasmICCallee.cpp:

(JSC::JSToWasmICCallee::create):

• wasm/js/JSWebAssembly.cpp:

(JSC::JSWebAssembly::create):

• wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::create):

• wasm/js/JSWebAssemblyException.h:
• wasm/js/JSWebAssemblyGlobal.cpp:

(JSC::JSWebAssemblyGlobal::tryCreate):

• wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::tryCreate):

• wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::tryCreate):

• wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::createStub):

• wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::tryCreate):

• wasm/js/JSWebAssemblyTag.cpp:

(JSC::JSWebAssemblyTag::create):

• wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::WebAssemblyCompileErrorConstructor::create):

• wasm/js/WebAssemblyCompileErrorPrototype.cpp:

(JSC::WebAssemblyCompileErrorPrototype::create):

• wasm/js/WebAssemblyExceptionConstructor.cpp:

(JSC::WebAssemblyExceptionConstructor::create):

• wasm/js/WebAssemblyExceptionPrototype.cpp:

(JSC::WebAssemblyExceptionPrototype::create):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::create):

• wasm/js/WebAssemblyGlobalConstructor.cpp:

(JSC::WebAssemblyGlobalConstructor::create):

• wasm/js/WebAssemblyGlobalPrototype.cpp:

(JSC::WebAssemblyGlobalPrototype::create):

• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::WebAssemblyInstanceConstructor::create):

• wasm/js/WebAssemblyInstancePrototype.cpp:

(JSC::WebAssemblyInstancePrototype::create):

• wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::WebAssemblyLinkErrorConstructor::create):

• wasm/js/WebAssemblyLinkErrorPrototype.cpp:

(JSC::WebAssemblyLinkErrorPrototype::create):

• wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::WebAssemblyMemoryConstructor::create):

• wasm/js/WebAssemblyMemoryPrototype.cpp:

(JSC::WebAssemblyMemoryPrototype::create):

• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::WebAssemblyModuleConstructor::create):

• wasm/js/WebAssemblyModulePrototype.cpp:

(JSC::WebAssemblyModulePrototype::create):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::create):

• wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::WebAssemblyRuntimeErrorConstructor::create):

• wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:

(JSC::WebAssemblyRuntimeErrorPrototype::create):

• wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::WebAssemblyTableConstructor::create):

• wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::WebAssemblyTablePrototype::create):

• wasm/js/WebAssemblyTagConstructor.cpp:

(JSC::WebAssemblyTagConstructor::create):

• wasm/js/WebAssemblyTagPrototype.cpp:

(JSC::WebAssemblyTagPrototype::create):

• wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::create):

Source/WebCore:

• bindings/js/JSDOMAsyncIterator.h:
• bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor<JSClass>::create):

• bindings/js/JSDOMConstructor.h:

(WebCore::JSDOMConstructor<JSClass>::create):

• bindings/js/JSDOMConstructorNotCallable.h:

(WebCore::JSDOMConstructorNotCallable<JSClass>::create):

• bindings/js/JSDOMConstructorNotConstructable.h:

(WebCore::JSDOMConstructorNotConstructable<JSClass>::create):

• bindings/js/JSDOMIterator.h:
• bindings/js/JSDOMLegacyFactoryFunction.h:

(WebCore::JSDOMLegacyFactoryFunction<JSClass>::create):

• bindings/js/JSDOMWindowProperties.h:
• bindings/js/JSFileSystemDirectoryHandleIterator.h:
• bindings/js/JSIDBSerializationGlobalObject.cpp:

(WebCore::JSIDBSerializationGlobalObject::create):

• bindings/js/JSWindowProxy.cpp:

(WebCore::JSWindowProxy::create):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateIterableDefinition):
(GeneratePrototypeDeclaration):

• bindings/scripts/test/JS/JSDOMWindow.h:

(WebCore::JSDOMWindow::create):

• bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.h:

(WebCore::JSDedicatedWorkerGlobalScope::create):

• bindings/scripts/test/JS/JSExposedStar.cpp:

(WebCore::JSExposedStarDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSExposedStar.h:

(WebCore::JSExposedStar::create):

• bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:
• bindings/scripts/test/JS/JSExposedToWorkerAndWindow.h:

(WebCore::JSExposedToWorkerAndWindow::create):

• bindings/scripts/test/JS/JSPaintWorkletGlobalScope.h:

(WebCore::JSPaintWorkletGlobalScope::create):

• bindings/scripts/test/JS/JSServiceWorkerGlobalScope.h:

(WebCore::JSServiceWorkerGlobalScope::create):

• bindings/scripts/test/JS/JSSharedWorkerGlobalScope.h:

(WebCore::JSSharedWorkerGlobalScope::create):

• bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::JSTestCEReactionsDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestCEReactions.h:

(WebCore::JSTestCEReactions::create):

• bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::JSTestCEReactionsStringifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestCEReactionsStringifier.h:

(WebCore::JSTestCEReactionsStringifier::create):

• bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::JSTestCallTracerDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestCallTracer.h:

(WebCore::JSTestCallTracer::create):

• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::JSTestClassWithJSBuiltinConstructorDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:

(WebCore::JSTestClassWithJSBuiltinConstructor::create):

• bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:

(WebCore::JSTestConditionalIncludesDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestConditionalIncludes.h:

(WebCore::JSTestConditionalIncludes::create):

• bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp:

(WebCore::JSTestConditionallyReadWriteDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestConditionallyReadWrite.h:

(WebCore::JSTestConditionallyReadWrite::create):

• bindings/scripts/test/JS/JSTestDOMJIT.cpp:

(WebCore::JSTestDOMJITDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDOMJIT.h:

(WebCore::JSTestDOMJIT::create):

• bindings/scripts/test/JS/JSTestDefaultToJSON.cpp:

(WebCore::JSTestDefaultToJSONDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDefaultToJSON.h:

(WebCore::JSTestDefaultToJSON::create):

• bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp:

(WebCore::JSTestDefaultToJSONFilteredByExposedDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.h:

(WebCore::JSTestDefaultToJSONFilteredByExposed::create):

• bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp:

(WebCore::JSTestDefaultToJSONIndirectInheritanceDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.h:

(WebCore::JSTestDefaultToJSONIndirectInheritance::create):

• bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp:

(WebCore::JSTestDefaultToJSONInheritDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDefaultToJSONInherit.h:

(WebCore::JSTestDefaultToJSONInherit::create):

• bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp:

(WebCore::JSTestDefaultToJSONInheritFinalDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.h:

(WebCore::JSTestDefaultToJSONInheritFinal::create):

• bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.cpp:

(WebCore::JSTestDelegateToSharedSyntheticAttributeDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.h:

(WebCore::JSTestDelegateToSharedSyntheticAttribute::create):

• bindings/scripts/test/JS/JSTestDomainSecurity.cpp:

(WebCore::JSTestDomainSecurityDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestDomainSecurity.h:

(WebCore::JSTestDomainSecurity::create):

• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestEnabledBySetting.h:

(WebCore::JSTestEnabledBySetting::create):

• bindings/scripts/test/JS/JSTestEnabledForContext.cpp:

(WebCore::JSTestEnabledForContextDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestEnabledForContext.h:

(WebCore::JSTestEnabledForContext::create):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::create):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::create):

• bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp:

(WebCore::JSTestGenerateAddOpaqueRootDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.h:

(WebCore::JSTestGenerateAddOpaqueRoot::create):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachable::create):

• bindings/scripts/test/JS/JSTestGlobalObject.h:

(WebCore::JSTestGlobalObject::create):

• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestIndexedSetterNoIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h:

(WebCore::JSTestIndexedSetterNoIdentifier::create):

• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::JSTestIndexedSetterThrowingExceptionDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h:

(WebCore::JSTestIndexedSetterThrowingException::create):

• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestIndexedSetterWithIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h:

(WebCore::JSTestIndexedSetterWithIdentifier::create):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceDOMConstructor::construct):
(WebCore::jsTestInterfacePrototypeFunction_entriesCaller):

• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:

(WebCore::JSTestInterfaceLeadingUnderscoreDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h:

(WebCore::JSTestInterfaceLeadingUnderscore::create):

• bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::JSTestIterableDOMConstructor::prototypeForStructure):
(WebCore::jsTestIterablePrototypeFunction_entriesCaller):

• bindings/scripts/test/JS/JSTestIterable.h:

(WebCore::JSTestIterable::create):

• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:

(WebCore::JSTestJSBuiltinConstructor::create):

• bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:

(WebCore::JSTestLegacyFactoryFunctionDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestLegacyFactoryFunction.h:

(WebCore::JSTestLegacyFactoryFunction::create):

• bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp:

(WebCore::JSTestLegacyNoInterfaceObjectPrototype::finishCreation):

• bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.h:

(WebCore::JSTestLegacyNoInterfaceObject::create):

• bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestLegacyOverrideBuiltInsDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.h:

(WebCore::JSTestLegacyOverrideBuiltIns::create):

• bindings/scripts/test/JS/JSTestMapLike.cpp:

(WebCore::JSTestMapLikeDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestMapLike.h:

(WebCore::JSTestMapLike::create):

• bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp:

(WebCore::JSTestMapLikeWithOverriddenOperationsDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.h:

(WebCore::JSTestMapLikeWithOverriddenOperations::create):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterNoIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:

(WebCore::JSTestNamedAndIndexedSetterNoIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::JSTestNamedAndIndexedSetterThrowingExceptionDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:

(WebCore::JSTestNamedAndIndexedSetterThrowingException::create):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterWithIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:

(WebCore::JSTestNamedAndIndexedSetterWithIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::JSTestNamedDeleterNoIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:

(WebCore::JSTestNamedDeleterNoIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::JSTestNamedDeleterThrowingExceptionDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:

(WebCore::JSTestNamedDeleterThrowingException::create):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::JSTestNamedDeleterWithIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:

(WebCore::JSTestNamedDeleterWithIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::JSTestNamedDeleterWithIndexedGetterDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:

(WebCore::JSTestNamedDeleterWithIndexedGetter::create):

• bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::JSTestNamedGetterCallWithDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedGetterCallWith.h:

(WebCore::JSTestNamedGetterCallWith::create):

• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::JSTestNamedGetterNoIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h:

(WebCore::JSTestNamedGetterNoIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::JSTestNamedGetterWithIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h:

(WebCore::JSTestNamedGetterWithIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedSetterNoIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:

(WebCore::JSTestNamedSetterNoIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::JSTestNamedSetterThrowingExceptionDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:

(WebCore::JSTestNamedSetterThrowingException::create):

• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedSetterWithIdentifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:

(WebCore::JSTestNamedSetterWithIdentifier::create):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:

(WebCore::JSTestNamedSetterWithIndexedGetter::create):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterAndSetterDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:

(WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::create):

• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestNamedSetterWithLegacyOverrideBuiltInsDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.h:

(WebCore::JSTestNamedSetterWithLegacyOverrideBuiltIns::create):

• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.h:

(WebCore::JSTestNamedSetterWithLegacyUnforgeableProperties::create):

• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.h:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns::create):

• bindings/scripts/test/JS/JSTestNamespaceObject.h:

(WebCore::JSTestNamespaceObject::create):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::jsTestNodePrototypeFunction_entriesCaller):

• bindings/scripts/test/JS/JSTestNode.h:
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjDOMConstructor::construct):

• bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):

• bindings/scripts/test/JS/JSTestOperationConditional.cpp:

(WebCore::JSTestOperationConditionalDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestOperationConditional.h:

(WebCore::JSTestOperationConditional::create):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::create):

• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h:

(WebCore::JSTestOverloadedConstructorsWithSequence::create):

• bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::JSTestPluginInterfaceDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestPluginInterface.h:

(WebCore::JSTestPluginInterface::create):

• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h:

(WebCore::JSTestPromiseRejectionEvent::create):

• bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp:

(WebCore::JSTestReadOnlyMapLikeDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestReadOnlyMapLike.h:

(WebCore::JSTestReadOnlyMapLike::create):

• bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp:

(WebCore::JSTestReadOnlySetLikeDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestReadOnlySetLike.h:

(WebCore::JSTestReadOnlySetLike::create):

• bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp:

(WebCore::JSTestReportExtraMemoryCostDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestReportExtraMemoryCost.h:

(WebCore::JSTestReportExtraMemoryCost::create):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):

• bindings/scripts/test/JS/JSTestSetLike.cpp:

(WebCore::JSTestSetLikeDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestSetLike.h:

(WebCore::JSTestSetLike::create):

• bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp:

(WebCore::JSTestSetLikeWithOverriddenOperationsDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.h:

(WebCore::JSTestSetLikeWithOverriddenOperations::create):

• bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::JSTestStringifierDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestStringifier.h:

(WebCore::JSTestStringifier::create):

• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::JSTestStringifierAnonymousOperationDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.h:

(WebCore::JSTestStringifierAnonymousOperation::create):

• bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::JSTestStringifierNamedOperationDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestStringifierNamedOperation.h:

(WebCore::JSTestStringifierNamedOperation::create):

• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::JSTestStringifierOperationImplementedAsDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.h:

(WebCore::JSTestStringifierOperationImplementedAs::create):

• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::JSTestStringifierOperationNamedToStringDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.h:

(WebCore::JSTestStringifierOperationNamedToString::create):

• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::JSTestStringifierReadOnlyAttributeDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.h:

(WebCore::JSTestStringifierReadOnlyAttribute::create):

• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::JSTestStringifierReadWriteAttributeDOMConstructor::prototypeForStructure):

• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.h:

(WebCore::JSTestStringifierReadWriteAttribute::create):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsDOMConstructor::construct):

• bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::create):

• bindings/scripts/test/JS/JSWorkerGlobalScope.h:

(WebCore::JSWorkerGlobalScope::create):

• bindings/scripts/test/JS/JSWorkletGlobalScope.h:

(WebCore::JSWorkletGlobalScope::create):

• bridge/objc/ObjCRuntimeObject.h:
• bridge/objc/objc_instance.mm:

(JSC::Bindings::ObjcInstance::getMethod):

• bridge/objc/objc_runtime.h:
• bridge/runtime_array.h:
• bridge/runtime_method.h:
• bridge/runtime_object.h:

9:52 AM Changeset in webkit [285729] by Chris Dumez

• 3 edits
  1 copy
  1 add
  1 delete in trunk/Source/WebKit

Rename ProcessLauncherMac.mm to ProcessLauncherDarwin.mm
​https://bugs.webkit.org/show_bug.cgi?id=233045

Reviewed by Brent Fulgham.

Rename ProcessLauncherMac.mm to ProcessLauncherDarwin.mm since this implementation is used by both macOS and iOS.
I chose the Darwin naming (as opposed to the Cocoa one) because the implementation only relies on libXPC and mach.

• SourcesCocoa.txt:
• UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm: Renamed from Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm.

(WebKit::serviceName):
(WebKit::shouldLeakBoost):
(WebKit::systemDirectoryPath):
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):
(WebKit::ProcessLauncher::terminateXPCConnection):
(WebKit::terminateWithReason):

• WebKit.xcodeproj/project.pbxproj:

9:40 AM Changeset in webkit [285728] by graouts@webkit.org

• 3 edits
  2 adds in trunk

[Web Animations] Accelerated animations with a single keyframe don't account for prior forward-filling animations
​https://bugs.webkit.org/show_bug.cgi?id=233041
<rdar://problem/85236241>

Reviewed by Dean Jackson.

Source/WebCore:

Test: webanimations/accelerated-animation-after-forward-filling-animation.html

When starting an accelerated animation, we would fill any implicit keyframes based on the unanimated style.
We now also apply all animations below this animation in the target's effect stack such that a previous
forward-filling animation is accounted for.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::applyPendingAcceleratedActions):

LayoutTests:

Add a new test that runs a forward-filling animation for transform, waits for its completion,
then runs another transform animation with an implicit initial keyframe, ensuring that the
result of the first forward-filling animation is accounted for when computing the initial
keyframe.

This test would fail prior to this patch.

• webanimations/accelerated-animation-after-forward-filling-animation-expected.html: Added.
• webanimations/accelerated-animation-after-forward-filling-animation.html: Added.

9:37 AM Changeset in webkit [285727] by Patrick Angle

• 2 edits in trunk/LayoutTests

Web Inspector: Mark inspector/page/setShowPaintRects.html as flakey in test expectations for Mac
​https://bugs.webkit.org/show_bug.cgi?id=233048

Unreviewed test gardening.

• platform/mac/TestExpectations: Add expectation for inspector/page/setShowPaintRects.html while the flakey

failure is investigated.

8:53 AM Changeset in webkit [285726] by Chris Dumez

• 5 edits in trunk/Source

Unreviewed, partial revert of r285565 to resolve a PLT5 regression.
<rdar://85269156>

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::isolatedSession):
(WebKit::SessionSet::isolatedSession):
(WebKit::NetworkSessionCocoa::hasIsolatedSession const):
(WebKit::NetworkSessionCocoa::clearIsolatedSessions):
(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):

Source/WTF:

• wtf/PlatformHave.h:

8:52 AM Changeset in webkit [285725] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Move subtree update logic in ImageOverlay::updateWithTextRecognitionResult() into a separate helper
​https://bugs.webkit.org/show_bug.cgi?id=233010

Reviewed by Aditya Keerthi.

Split updateWithTextRecognitionResult() into two phases: the first of which updates the UA shadow DOM to
reflect the given text recognition results, and a second phase that updates inline styles for each of the image
overlay elements by mapping normalized OCR quads onto rotated bounding rects in client coordinates. This will
make it easier to add support for representing TextRecognitionBlockData as image overlay content in the next
patch.

• dom/ImageOverlay.cpp:

(WebCore::ImageOverlay::imageOverlayLineClass):
(WebCore::ImageOverlay::imageOverlayTextClass):
(WebCore::ImageOverlay::updateSubtree):

Now that this is all namespaced inside ImageOverlay, we can also simplify some of these names. Instead of
TextRecognitionLineElements and TextRecognitionElements, we can just call them LineElements and Elements.

(WebCore::ImageOverlay::updateWithTextRecognitionResult):

8:39 AM Changeset in webkit [285724] by Adrian Perez de Castro

• 11 edits in trunk/Source

Some C++ source files use #pragma once
​https://bugs.webkit.org/show_bug.cgi?id=233040

Source/WebCore:

Reviewed by Chris Dumez.

Remove spurious usage of "#pragma once" in implementation files.

No new tests needed.

• Modules/WebGPU/GPUBuffer.cpp:
• Modules/WebGPU/GPUCommandEncoder.cpp:
• Modules/WebGPU/GPUComputePassEncoder.cpp:
• Modules/WebGPU/GPUQuerySet.cpp:
• Modules/WebGPU/GPUQueue.cpp:
• Modules/WebGPU/GPURenderBundleEncoder.cpp:
• Modules/WebGPU/GPURenderPassEncoder.cpp:
• page/PerformanceNavigationTiming.cpp:

Source/WebKit:

Remove spurious usage of "#pragma once" in implementation files.

Reviewed by Chris Dumez.

• WebProcess/WebCoreSupport/WebCaptionPreferencesDelegate.cpp:

8:38 AM Changeset in webkit [285723] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS][GPUP] Remove sandbox write access to files
​https://bugs.webkit.org/show_bug.cgi?id=232247
<rdar://problem/84620023>

Reviewed by Brent Fulgham.

Based on telemetry, remove sandbox write access to files in the GPU process on macOS.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

8:32 AM Changeset in webkit [285722] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS][GPU] Remove access to IOKit classes
​https://bugs.webkit.org/show_bug.cgi?id=232344
<rdar://problem/84684751>

Reviewed by Darin Adler.

Based on telemetry, remove access to unused IOKit classes in the GPU process' sandbox on iOS.

• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

8:31 AM Changeset in webkit [285721] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS][GPUP] Add syscalls to sandbox
​https://bugs.webkit.org/show_bug.cgi?id=232210
<rdar://problem/84584844>

Reviewed by Brent Fulgham.

Based on telemetry, add syscalls to the GPU process' sandbox on macOS.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

8:18 AM Changeset in webkit [285720] by Chris Dumez

• 8 edits in trunk

WebKit is unable to recover if a WebProcess gets terminated while it is launching
​https://bugs.webkit.org/show_bug.cgi?id=233001
<rdar://85302938>

Reviewed by Brent Fulgham.

Source/WebKit:

While investigating <rdar://83941760>, I found that the WebAuthn Process would get
jetsammed, which would cause us to call WebProcessPool::terminateAllWebContentProcesses().
I also noticed that if one of these WebProcesses was still launching at the time
of the termination, then the WebProcessProxy / WebPageProxy would keep thinking the
WebProcess is still launching and would never attempt to relaunch it. This would result
in a blank and unresponsive WKWebView which wouldn't be able to do any loads.

The issue was due to ProcessLauncher::terminateProcess() calling invalidate(), which
it would not only terminate the XPC connection, it would also null out m_client. As a
result, we wouldn't notify the client that the process failed to launch. To address
the issue, I move the XPC connection termination logic out of invalidate() and into
its own terminateXPCConnection() function. I then called terminateXPCConnection()
instead of invalidate() inside ProcessLauncher::terminateProcess().

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _terminateAllWebContentProcesses]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::invalidate):

• UIProcess/Launcher/ProcessLauncher.h:
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):
(WebKit::ProcessLauncher::terminateXPCConnection):

Tools:

Add API test coverage, this test was timing out before the fix.

• TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm:

(TEST):

7:59 AM Changeset in webkit [285719] by Chris Dumez

• 2 edits in trunk/LayoutTests

fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1
​https://bugs.webkit.org/show_bug.cgi?id=233043

Unreviewed, skip test to make EWS happy while the issue is being investigated.

• platform/mac-wk1/TestExpectations:

7:44 AM Changeset in webkit [285718] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GLib] Developer build with release logs disabled fails
​https://bugs.webkit.org/show_bug.cgi?id=232931

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-11-12
Reviewed by Adrian Perez de Castro.

• platform/audio/PlatformMediaSession.cpp: Remove ifdef around convertEnumerationToString

functions, required by Internals.

6:57 AM Changeset in webkit [285717] by Chris Dumez

• 4 edits in trunk

Disable getUserMedia() when in Captive Portal Mode
​https://bugs.webkit.org/show_bug.cgi?id=233021

Reviewed by Brent Fulgham.

Source/WebKit:

Disable getUserMedia() when in Captive Portal Mode.

No new tests, covered by updated API test.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

6:40 AM Changeset in webkit [285716] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Add inline box margin-start support for visual ordering (bidi)
​https://bugs.webkit.org/show_bug.cgi?id=233022

Reviewed by Antti Koivisto.

Line run geometry is margin box based (only applicable for inline level boxes), while
the displayRect() returns border box based geometry (again, only relevant for inline level boxes).
When computing the border box based left position using the distanceFromLogicalPreviousRun (line run based)
we have to offset it with the margin value.

• layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent):

6:25 AM Changeset in webkit [285715] by Adrian Perez de Castro

• 4 edits in trunk/Source

Non-unified build fixes, early November 2021 edition, bis x2

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

• jit/JITWorklist.cpp: Add missing DeferGCInlines.h header.

Source/WebCore:

• platform/gamepad/GamepadConstants.h: Use wtf/Forward.h instead of manually

forward-declaring the WTF::String type in the file.

4:48 AM Changeset in webkit [285714] by ntim@apple.com

• 3 edits in trunk/Source/WebCore

Re-use isCSSWideKeyword in CSSCustomPropertyValue::createWithID
​https://bugs.webkit.org/show_bug.cgi?id=233035

Reviewed by Antti Koivisto.

• css/CSSCustomPropertyValue.cpp:

(WebCore::CSSCustomPropertyValue::createWithID):

• css/CSSCustomPropertyValue.h:

4:28 AM Changeset in webkit [285713] by Antti Koivisto

• 3 edits
  2 adds in trunk

Stack overflow with revert and revert-layer
​https://bugs.webkit.org/show_bug.cgi?id=233033
rdar://85336439

Reviewed by Antoine Quint.

Source/WebCore:

Test: fast/css/revert-layer-stack-overflow.html

We end up using a rollback cascade made for revert-layer to do revert and that leads to eternal recursion.

• style/StyleBuilder.cpp:

(WebCore::Style::Builder::ensureRollbackCascadeForRevert):
(WebCore::Style::Builder::ensureRollbackCascadeForRevertLayer):

Key the rollback cascade map with the reverted values instead of the original ones since the same
original keys produce different rollbacks depending on whether it is made for revert or revert-layer.

LayoutTests:

• fast/css/revert-layer-stack-overflow-expected.txt: Added.
• fast/css/revert-layer-stack-overflow.html: Added.

3:43 AM Changeset in webkit [285712] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

[JSC][32bit] Unskip JSTests/microbenchmarks/redefine-property-accessor-dictionary.js
​https://bugs.webkit.org/show_bug.cgi?id=233034

Unreviewed gardening.

This is skipped for memoryLimited *and* mips|arm systems, but a)
seems to run fine on both setups and b) is almost identical to the
other tests/benchmarks that landed in the same patch, that do not
have that limitation. Optimistically remove the skip and let's see
if it sticks.

Patch by Xan Lopez <Xan Lopez> on 2021-11-12

• microbenchmarks/redefine-property-accessor-dictionary.js:

2:54 AM Changeset in webkit [285711] by Razvan Caliman

• 5 edits
  1 copy
  1 move
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Extract reusable logic from ResourceQueryController, ResourceQueryResult and ResourceQueryMatch
​https://bugs.webkit.org/show_bug.cgi?id=231604
<rdar://problem/84160281>

Reviewed by Devin Rousso.

Extract reusable logic from ResourceQueryController into a generic QueryController
to enable subclassing for other specialized use cases.

• UserInterface/Controllers/QueryController.js: Added.

(WI.QueryController.prototype.executeQuery):
(WI.QueryController.prototype.findQueryMatches.pushMatch):
(WI.QueryController.prototype.findQueryMatches.matchNextSpecialCharacter):
(WI.QueryController.prototype.findQueryMatches.backtrack):
(WI.QueryController.prototype.findQueryMatches):
(WI.QueryController):

Keep only the reusable matching logic in QueryController.
Subclasses like ResourceQueryController are responsible for agregating
the data to be queried, customization for special characters and sorting results.

• UserInterface/Controllers/ResourceQueryController.js:

(WI.ResourceQueryController.prototype.executeQuery):
(WI.ResourceQueryController.prototype._findQueryMatches.pushMatch): Deleted.
(WI.ResourceQueryController.prototype._findQueryMatches.matchNextSpecialCharacter): Deleted.
(WI.ResourceQueryController.prototype._findQueryMatches.backtrack): Deleted.
(WI.ResourceQueryController.prototype._findQueryMatches): Deleted.

• UserInterface/Main.html:

• UserInterface/Models/QueryMatch.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceQueryMatch.js.

ResourceQueryMatch doesn't contain any resource-specific logic. It can be generalized to QueryMatch.

• UserInterface/Models/QueryResult.js: Copied from Source/WebInspectorUI/UserInterface/Models/ResourceQueryResult.js.

(WI.QueryResult):
(WI.QueryResult.prototype.get value):
(WI.QueryResult.prototype.get rank):
(WI.QueryResult.prototype.get matchingTextRanges):
(WI.QueryResult.prototype._calculateRank.getMultiplier):
(WI.QueryResult.prototype._calculateRank):
(WI.QueryResult.prototype._createMatchingTextRanges):

A generic QueryResult can be extracted from ResourceQueryResult containing
the reusable logic for ranking results and identifing matching text ranges.

• UserInterface/Models/ResourceQueryResult.js:

(WI.ResourceQueryResult):
(WI.ResourceQueryResult.prototype.get resource):
(WI.ResourceQueryResult.prototype.test_createMatchesMask):
(WI.ResourceQueryResult.prototype.get rank): Deleted.
(WI.ResourceQueryResult.prototype.get matchingTextRanges): Deleted.
(WI.ResourceQueryResult.prototype._calculateRank.getMultiplier): Deleted.
(WI.ResourceQueryResult.prototype._calculateRank): Deleted.
(WI.ResourceQueryResult.prototype._createMatchingTextRanges): Deleted.

ResourceQueryResult extends QueryResult with resource-specifc members:

• the cookie property which holds the optional line and column info used when jumping to matched files
• the resource property which maps to the generic QueryResult.value; this is used in tests and when sorting in ResourceQueryController

• UserInterface/Test.html:

2:50 AM Changeset in webkit [285710] by Antti Koivisto

• 3 edits
  2 adds in trunk

REGRESSION(r285624) Using revert keyword with a css variable hits assert
​https://bugs.webkit.org/show_bug.cgi?id=233031
rdar://85332271

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/selectors/variable-revert-crash.html

• style/StyleBuilderState.h:

Default initialization set the variable to a value that is not in the enumeration.

LayoutTests:

• fast/selectors/variable-revert-crash-expected.txt: Added.
• fast/selectors/variable-revert-crash.html: Added.

2:17 AM Changeset in webkit [285709] by svillar@igalia.com

• 20 edits in trunk

[css-flexbox] Add flex-basis: content support
​https://bugs.webkit.org/show_bug.cgi?id=221479

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-flexbox/parsing/flex-basis-computed-expected.txt: Replaced FAIL

by PASS expectations.

• web-platform-tests/css/css-flexbox/parsing/flex-basis-valid-expected.txt: Ditto.
• web-platform-tests/css/css-flexbox/parsing/flex-shorthand-expected.txt: Ditto.

Source/WebCore:

Add support for the content keyword as a valid value for the flex-basis property.
It indicates an automated size based on the contents of the flex item. It's typically
equivalent to the max-content size but it has some adjustments for aspect ratios,
orthogonal flows and intrinsic sizing constraints.

Apart from adding the parsing support, it required very little adjustments in the
flexbox code after the refactoring in r284359.

This makes WebKit pass all of the flex-basis:content tests in WPT. We're talking
about 6 tests testing the feature and 6 subtests related to parsing.

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Handle Content in switch.
(WebCore::CSSPrimitiveValue::init): Initialization for content CSS value.

• css/CSSProperties.json:
• css/LengthFunctions.cpp: Replaced LengthOrAuto by LengthSizing.

(WebCore::valueForLength): Handle Content in switch.
(WebCore::floatValueForLength): Ditto.

• css/LengthFunctions.h:

(WebCore::minimumValueForLength): Ditto.

• css/calc/CSSCalcValue.cpp:

(WebCore::createCSS): Ditto.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFlexBasis): Consume CSSValueContent.
(WebCore::CSSPropertyParser::consumeFlex): Ditto.

• platform/Length.cpp:

(WebCore::operator<<): Added printing support for content.

• platform/Length.h:

(WebCore::Length::initialize): Added enum for content.
(WebCore::Length::isContent const): New method.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing const): Handle content in switch.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::childMainSizeIsDefinite): Treat content as indefinite lenght.
(WebCore::RenderFlexibleBox::computeFlexBaseSizeForChild): Compute flex-basis using max-content
if flex-basis:content is specified.

• style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertLengthSizing): Handle content in switch.

Source/WebKit:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Length>::encode): Handle content in switch.
(IPC::ArgumentCoder<Length>::decode): Ditto.

LayoutTests:

• TestExpectations: Unskipped all the flexbox-flex-basis-content tests that work fine now.

12:59 AM Changeset in webkit [285708] by commit-queue@webkit.org

• 13 edits
  3 adds in trunk/LayoutTests

[GLIB] Update test expectations and baselines. Unreviewed test gardening.
​https://bugs.webkit.org/show_bug.cgi?id=232957

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-11-12

• platform/glib/TestExpectations:
• platform/glib/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
• platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
• platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Added.
• platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
• platform/gtk/TestExpectations:
• platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Added.
• platform/gtk/fast/selectors/018b-expected.txt:
• platform/gtk/fast/text/capitalize-boundaries-expected.txt:
• platform/gtk/fast/text/whitespace/020-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: