Context Navigation

← Previous Period
Next Period →

Timeline

Nov 22, 2021:

6:28 PM Changeset in webkit [286126] by Simon Fraser

6 edits in trunk/Source/WebCore

Have ScrollAnimator::scrollToPositionWithAnimation() take a clamping argument
https://bugs.webkit.org/show_bug.cgi?id=233438

Reviewed by Cameron McCormack.

Create symmetry between scrollToPositionWithAnimation() and scrollToPositionWithoutAnimation()
by adding a ScrollClamping argument to the former. Neither need to be virtual.

ScrollAnimator::cancelAnimations() does not need to be virtual.

Rename ScrollableArea::constrainScrollPosition() to ScrollableArea::constrainedScrollPosition()
because it just returns a new position.

platform/KeyboardScrollingAnimator.cpp:

(WebCore::KeyboardScrollingAnimator::updateKeyboardScrollPosition):
(WebCore::KeyboardScrollingAnimator::stopKeyboardScrollAnimation):

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scrollToPositionWithAnimation):
(WebCore::ScrollAnimator::adjustScrollPositionToBoundsIfNecessary):
(WebCore::ScrollAnimator::adjustScrollPositionIfNecessary const):

platform/ScrollAnimator.h:
platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollToPositionWithAnimation):

platform/ScrollableArea.h:

(WebCore::ScrollableArea::constrainedScrollPosition const):
(WebCore::ScrollableArea::constrainScrollPosition const): Deleted.

6:24 PM Changeset in webkit [286125] by Wenson Hsieh

17 edits
7 deletes in trunk

Remove old concurrent display list logic that's no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=233433

Reviewed by Sam Weinig.

Source/WebCore:

Now that concurrent display lists (i.e. for 2D canvas and DOM rendering in the GPU process) uses the same shared
IPC streaming mechanism as WebGL, we can remove the old concurrent display list processing logic around display
lists and the remote rendering backend in WebKit2.

No change in behavior, since this code is now all (effectively) unused.

platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::append):

platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::safeCopy const):
(WebCore::DisplayList::ItemBuffer::swapWritableBufferIfNeeded):

Additionally remove a couple of display list items that were only used for concurrent display list processing.
In a followup, we should remove more logic around this area pertaining to display list reader and writer
clients, and the display list replayer delegate.

platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

platform/graphics/displaylists/DisplayListItemType.h:
platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::operator<<):

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::MetaCommandChangeItemBuffer::MetaCommandChangeItemBuffer): Deleted.
(WebCore::DisplayList::MetaCommandChangeItemBuffer::identifier const): Deleted.
(WebCore::DisplayList::MetaCommandChangeItemBuffer::isValid const): Deleted.
(WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::MetaCommandChangeDestinationImageBuffer): Deleted.
(WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::identifier const): Deleted.
(WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::isValid const): Deleted.

platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

Source/WebKit:

See WebCore ChangeLog for more details.

GPUProcess/graphics/DisplayListReaderHandle.cpp: Removed.
GPUProcess/graphics/DisplayListReaderHandle.h: Removed.
GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackendState.h: Removed.
GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:

Add missing include to fix the build with unified sources.

Shared/GPUProcessWakeupMessageArguments.h: Removed.
Shared/SharedDisplayListHandle.h: Removed.
Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/GPU/graphics/DisplayListWriterHandle.cpp: Removed.
WebProcess/GPU/graphics/DisplayListWriterHandle.h: Removed.
WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
WebProcess/Network/webrtc/LibWebRTCNetworkManager.h:

Add another missing include to fix the build with unified sources.

Tools:

See WebCore ChangeLog for more details.

TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:

(TestWebKitAPI::TEST):

5:46 PM Changeset in webkit [286124] by mmaxfield@apple.com

19 edits in trunk/Source

[WebGPU] Use OptionSet where it makes sense to
https://bugs.webkit.org/show_bug.cgi?id=233434

Reviewed by Wenson Hsieh.

Source/WebCore:

The fact that the IDL has a bunch of hardcoded const variables doesn't mean we have to.

No new tests because there is no behavior change.

Modules/WebGPU/GPUBufferUsage.h:

(WebCore::convertBufferUsageFlagsToBacking):

Modules/WebGPU/GPUColorWrite.h:

(WebCore::convertColorWriteFlagsToBacking):

Modules/WebGPU/GPUMapMode.h:

(WebCore::convertMapModeFlagsToBacking):

Modules/WebGPU/GPUShaderStage.h:

(WebCore::convertShaderStageFlagsToBacking):

Modules/WebGPU/GPUTextureUsage.h:

(WebCore::convertTextureUsageFlagsToBacking):

Source/WebCore/PAL:

pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp:

(PAL::WebGPU::ConvertToBackingContext::convertBufferUsageFlagsToBacking):
(PAL::WebGPU::ConvertToBackingContext::convertColorWriteFlagsToBacking):
(PAL::WebGPU::ConvertToBackingContext::convertMapModeFlagsToBacking):
(PAL::WebGPU::ConvertToBackingContext::convertShaderStageFlagsToBacking):
(PAL::WebGPU::ConvertToBackingContext::convertTextureUsageFlagsToBacking):

pal/graphics/WebGPU/WebGPUBufferUsage.h:
pal/graphics/WebGPU/WebGPUColorWrite.h:
pal/graphics/WebGPU/WebGPUMapMode.h:
pal/graphics/WebGPU/WebGPUShaderStage.h:
pal/graphics/WebGPU/WebGPUTextureUsage.h:

5:46 PM Changeset in webkit [286123] by mmaxfield@apple.com

4 edits in trunk

rem in media queries should be calculated using font-size:initial, not root element font-size
https://bugs.webkit.org/show_bug.cgi?id=156684
<rdar://problem/25778616>

Reviewed by Antti Koivisto.

Source/WebCore:

The CSS spec says:

Relative units in media queries are based on the initial value, which means that units are never based on results of declarations.

Tests: imported/w3c/web-platform-tests/css/mediaqueries/relative-units-001.html

imported/w3c/web-platform-tests/css/mediaqueries/mq-calc-005.html

css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evaluate const):

LayoutTests:

TestExpectations:

4:51 PM Changeset in webkit [286122] by Cameron McCormack

3 edits in trunk/Source/WebCore

Fix some license find/replace errors
https://bugs.webkit.org/show_bug.cgi?id=233435

Reviewed by Sam Weinig.

platform/graphics/FontCascadeDescription.h:
platform/graphics/FontDescription.h:

3:32 PM Changeset in webkit [286121] by Antti Koivisto

2 edits in trunk/Source/WebCore

[LFC][Integration] Use IFC for preferred width computation for inline boxes
https://bugs.webkit.org/show_bug.cgi?id=232616

Reviewed by Alan Bujtas.

rendering/RenderBlockFlow.cpp:

3:23 PM Changeset in webkit [286120] by Fujii Hironori

2 edits in trunk/Source/WebKit

[MSVC] IPC\DaemonConnection.h(80): warning C4661: 'void WebKit::Daemon::ConnectionToMachService<WebKit::PCM::ConnectionTraits>::initializeConnectionIfNeeded(void) const': no suitable definition provided for explicit template instantiation request
https://bugs.webkit.org/show_bug.cgi?id=233413

Reviewed by Ross Kirsling.

WinCairo build reports the following warnings.

Source\WebKit\Platform\IPC\DaemonConnection.h(80): warning C4661: 'void WebKit::Daemon::ConnectionToMachService<WebKit::PCM::ConnectionTraits>::initializeConnectionIfNeeded(void) const': no suitable definition provided for explicit template instantiation request
Source\WebKit\Platform\IPC\DaemonConnection.h(77): note: see declaration of 'WebKit::Daemon::ConnectionToMachService<WebKit::PCM::ConnectionTraits>::initializeConnectionIfNeeded'
Source\WebKit\Platform/IPC/DaemonConnection.cpp(40): warning C4661: 'void WebKit::Daemon::ConnectionToMachService<WebKit::PCM::ConnectionTraits>::initializeConnectionIfNeeded(void) const': no suitable definition provided for explicit template instantiation request
Source\WebKit\Platform\IPC\DaemonConnection.h(77): note: see declaration of 'WebKit::Daemon::ConnectionToMachService<WebKit::PCM::ConnectionTraits>::initializeConnectionIfNeeded'

Platform/IPC/DaemonConnection.cpp:

(WebKit::Daemon::ConnectionToMachService<Traits>::initializeConnectionIfNeeded const):
Added.

1:30 PM Changeset in webkit [286119] by Simon Fraser

8 edits in trunk/Source/WebCore

Clarify the behavior of ScrollAnimator::scroll()
https://bugs.webkit.org/show_bug.cgi?id=233403

Unreviewed.

Address patch feedback from Chris Lord.

dom/Element.cpp:

(WebCore::Element::scrollByUnits):

page/FrameView.cpp:

(WebCore::FrameView::adjustVerticalPageScrollStepForFixedContent):
(WebCore::FrameView::adjustScrollStepForFixedContent): Deleted.

page/FrameView.h:
platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::singleAxisScroll):

platform/ScrollTypes.h:

(WebCore::axisFromDirection):
(WebCore::valueForAxis):
(WebCore::setValueForAxis):

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::adjustVerticalPageScrollStepForFixedContent):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::adjustScrollStepForFixedContent): Deleted.

platform/ScrollableArea.h:

12:42 PM Changeset in webkit [286118] by Fujii Hironori

3 edits in trunk/Source/WebCore

[MSVC] RenderBlock.cpp(2259): warning C4239: nonstandard extension used: 'initializing': conversion from 'WebCore::Length' to 'WebCore::Length &'
https://bugs.webkit.org/show_bug.cgi?id=233412

Reviewed by Don Olmstead.

WinCairo build reported the following warnings.

Source\WebCore\rendering/RenderBlock.cpp(2259): warning C4239: nonstandard extension used: 'initializing': conversion from 'WebCore::Length' to 'WebCore::Length &'
Source\WebCore\rendering/RenderBlock.cpp(2259): note: A non-const reference may only be bound to an lvalue
Source\WebCore\rendering/RenderBox.cpp(3116): warning C4239: nonstandard extension used: 'initializing': conversion from 'WebCore::Length' to 'WebCore::Length &'
Source\WebCore\rendering/RenderBox.cpp(3116): note: A non-const reference may only be bound to an lvalue

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight const):
Changed "auto&" to "const auto&".

12:35 PM Changeset in webkit [286117] by Jean-Yves Avenard

3 edits in trunk/Source/WebCore

Remove unused getEOTHeader method in OpenTypeUtilities.cpp
https://bugs.webkit.org/show_bug.cgi?id=233411
rdar://85656827

Reviewed by Youenn Fablet.

No change in behaviour.

platform/graphics/opentype/OpenTypeUtilities.cpp:
platform/graphics/opentype/OpenTypeUtilities.h:

12:34 PM Changeset in webkit [286116] by Chris Fleizach

15 edits
3 adds in trunk

AX: WebKit: need a method to get visible text and frame of an element on screen
https://bugs.webkit.org/show_bug.cgi?id=233336

Reviewed by Andres Gonzalez.

Source/WebCore:

Implement visibleCharacterRange for static text elements so that Books can determine the visible
content on a page.

Test: accessibility/visible-character-range.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::visibleCharacterRange const):
(WebCore::AccessibilityObject::unobscuredContentRect const):

accessibility/AccessibilityObject.h:
accessibility/AccessibilityObjectInterface.h:
accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityVisibleContentRect]):
(accessibleElementsForObjects):
(-[WebAccessibilityObjectWrapper accessibilityFindMatchingObjects:]):
(-[WebAccessibilityObjectWrapper positionForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]):
(-[WebAccessibilityObjectWrapper stringForRange:]):
(-[WebAccessibilityObjectWrapper frameForRange:]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicand]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Deleted.
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]): Deleted.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::visibleCharacterRange const):
(WebCore::AXIsolatedObject::unobscuredContentRect const):

accessibility/isolatedtree/AXIsolatedObject.h:
accessibility/mac/WebAccessibilityObjectWrapperBase.h:
accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(makeNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityVisibleCharacterRange]):
(makeNSRange):
(makeDOMRange):
(-[WebAccessibilityObjectWrapperBase baseUpdateBackingStore]):
(-[WebAccessibilityObjectWrapperBase lineRectsAndText]):
(convertToNSArray): Deleted.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper childrenVectorArray]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Deleted.

LayoutTests:

accessibility/ios-simulator/visible-character-range-expected.txt: Added.
accessibility/visible-character-range-expected.txt: Added.
accessibility/visible-character-range.html: Added.
platform/ios/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

12:01 PM Changeset in webkit [286115] by Simon Fraser

23 edits in trunk/Source/WebCore

Clarify the behavior of ScrollAnimator::scroll()
https://bugs.webkit.org/show_bug.cgi?id=233403

Reviewed by Sam Weinig.

ScrollAnimator::scroll() was hard to reason about. It used ScrollbarOrientation but didn't
do anything with scrollbars. It took ScrollGranularity, "step" and "multiplier" and it
wasn't clear whether step had already accounted for ScrollGranularity, and whether
multiplier was anything other than 1 or -1. One of the behaviors was DoDirectionalSnapping
but it wasn't clear if the "directional" or "snapping" part of that was important. It also
called itself.

Bring clarity by using 'unsigned stepCount' in all the callers, using ScrollEventAxis
instead of ScrollbarOrientation, and having a single "delta" argument. It no longer
calls itself, instead just continuing from the snapping branch.

Add some helpers that ease interactions with FloatPoint/FloatSize and ScrollEventAxis.

dom/Element.cpp:

(WebCore::Element::scrollByUnits):

dom/Element.h:
page/FrameView.cpp:

(WebCore::FrameView::adjustScrollStepForFixedContent):

page/FrameView.h:
platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::deltaFromStep):
(WebCore::ScrollAnimator::handleWheelEvent):

platform/ScrollAnimator.h:
platform/ScrollSnapAnimatorState.cpp:

(WebCore::ScrollSnapAnimatorState::adjustedScrollDestination const):

platform/ScrollTypes.h:

(WebCore::axisFromDirection):
(WebCore::valueForAxis):
(WebCore::setValueForAxis):

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::adjustScrollStepForFixedContent):
(WebCore::ScrollableArea::scroll):

platform/ScrollableArea.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollLayer):
(WebCore::RenderBox::scroll):
(WebCore::RenderBox::logicalScroll):

rendering/RenderBox.h:
rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::scroll):
(WebCore::RenderEmbeddedObject::logicalScroll):

rendering/RenderEmbeddedObject.h:
rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::scroll):

rendering/RenderLayerScrollableArea.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):

rendering/RenderListBox.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):

rendering/RenderTextControlSingleLine.h:

10:14 AM Changeset in webkit [286114] by commit-queue@webkit.org

2 edits in trunk

Add alexg's GitHub username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=233425

Unreviewed.

Patch by Alejandro G. Castro <alex@igalia.com> on 2021-11-22

metadata/contributors.json:

10:13 AM Changeset in webkit [286113] by Antti Koivisto

368 edits in trunk

[LFC][Integration] Remove dirOverride
https://bugs.webkit.org/show_bug.cgi?id=233423

Reviewed by Alan Bujtas.

Source/WebCore:

This legacy inline box bit is used to set directionOverride bit when creating a TextRun for the box.
However that bit is never needed in cases these TextRuns are created for (painting and editing).

In practice dirOverride only affects render tree dumps and can be removed.

layout/integration/InlineIteratorBox.h:

(WebCore::InlineIterator::Box::dirOverride const): Deleted.

layout/integration/InlineIteratorBoxLegacyPath.h:

(WebCore::InlineIterator::BoxLegacyPath::isHorizontal const):
(WebCore::InlineIterator::BoxLegacyPath::dirOverride const): Deleted.

layout/integration/InlineIteratorBoxModernPath.h:

(WebCore::InlineIterator::BoxModernPath::isHorizontal const):
(WebCore::InlineIterator::BoxModernPath::createTextRun const):
(WebCore::InlineIterator::BoxModernPath::dirOverride const): Deleted.

rendering/LegacyInlineBox.h:

(WebCore::LegacyInlineBox::InlineBoxBitfields::InlineBoxBitfields):
(WebCore::LegacyInlineBox::dirOverride const): Deleted.
(WebCore::LegacyInlineBox::setDirOverride): Deleted.

rendering/LegacyInlineTextBox.cpp:

(WebCore::LegacyInlineTextBox::createTextRun const):

rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::constructLine):

rendering/RenderTreeAsText.cpp:

(WebCore::write):

rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun const):

rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGInlineTextBox):

LayoutTests:

platform/glib/imported/w3c/web-platform-tests/svg/import/text-intro-09-b-manual-expected.txt:
platform/glib/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
platform/glib/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
platform/glib/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
platform/glib/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
platform/glib/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
platform/glib/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
platform/glib/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
platform/glib/svg/custom/glyph-selection-bidi-mirror-expected.txt:
platform/glib/svg/custom/glyph-selection-non-bmp-expected.txt:
platform/glib/svg/text/bidi-embedded-direction-expected.txt:
platform/glib/svg/text/bidi-text-query-expected.txt:
platform/gtk/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
platform/gtk/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
platform/gtk/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
platform/gtk/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
platform/gtk/fast/borders/bidi-002-expected.txt:
platform/gtk/fast/borders/bidi-009a-expected.txt:
platform/gtk/fast/borders/bidi-012-expected.txt:
platform/gtk/fast/borders/rtl-border-02-expected.txt:
platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/gtk/fast/css/rtl-ordering-expected.txt:
platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
platform/gtk/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/gtk/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
platform/gtk/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/gtk/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/gtk/fast/css/textCapitalizeEdgeCases-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
platform/gtk/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt:
platform/gtk/fast/dom/HTMLElement/bdo-expected.txt:
platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
platform/gtk/fast/inline/inline-borders-with-bidi-override-expected.txt:
platform/gtk/fast/text/atsui-rtl-override-selection-expected.txt:
platform/gtk/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
platform/gtk/fast/text/international/bidi-AN-after-L-expected.txt:
platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/gtk/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/gtk/fast/text/international/bidi-override-expected.txt:
platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/gtk/fast/text/shaping/shaping-script-order-expected.txt:
platform/gtk/fast/text/shaping/shaping-selection-rect-expected.txt:
platform/gtk/fast/text/text-letter-spacing-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/svg/import/text-intro-02-b-manual-expected.txt:
platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/text-intro-02-b-manual-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/text-intro-09-b-manual-expected.txt:
platform/ios-wk1/fast/borders/bidi-002-expected.txt:
platform/ios-wk2/fast/text/atsui-rtl-override-selection-expected.txt:
platform/ios-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/ios/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
platform/ios/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
platform/ios/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
platform/ios/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
platform/ios/fast/borders/bidi-009a-expected.txt:
platform/ios/fast/borders/bidi-012-expected.txt:
platform/ios/fast/borders/rtl-border-02-expected.txt:
platform/ios/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/ios/fast/css/rtl-ordering-expected.txt:
platform/ios/fast/css/text-overflow-ellipsis-expected.txt:
platform/ios/fast/css/text-overflow-ellipsis-strict-expected.txt:
platform/ios/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/ios/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
platform/ios/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/ios/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/ios/fast/css/textCapitalizeEdgeCases-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
platform/ios/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt:
platform/ios/fast/dom/HTMLElement/bdo-expected.txt:
platform/ios/fast/forms/select-visual-hebrew-expected.txt:
platform/ios/fast/forms/visual-hebrew-text-field-expected.txt:
platform/ios/fast/inline/inline-borders-with-bidi-override-expected.txt:
platform/ios/fast/text/atsui-rtl-override-selection-expected.txt:
platform/ios/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
platform/ios/fast/text/international/bidi-AN-after-L-expected.txt:
platform/ios/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/ios/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/ios/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/ios/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
platform/ios/fast/text/international/bidi-european-terminators-expected.txt:
platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/ios/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/ios/fast/text/international/bidi-override-expected.txt:
platform/ios/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/ios/fast/text/shaping/shaping-script-order-expected.txt:
platform/ios/fast/text/shaping/shaping-selection-rect-expected.txt:
platform/ios/fast/text/text-letter-spacing-expected.txt:
platform/ios/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
platform/ios/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
platform/ios/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
platform/ios/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
platform/ios/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
platform/ios/svg/custom/glyph-selection-bidi-mirror-expected.txt:
platform/ios/svg/text/bidi-embedded-direction-expected.txt:
platform/mac-catalina/fast/css/rtl-ordering-expected.txt:
platform/mac-catalina/fast/forms/select-visual-hebrew-expected.txt:
platform/mac-catalina/fast/forms/visual-hebrew-text-field-expected.txt:
platform/mac-catalina/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/mac-mojave/fast/css/rtl-ordering-expected.txt:
platform/mac-mojave/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/mac/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
platform/mac/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
platform/mac/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
platform/mac/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
platform/mac/fast/borders/bidi-002-expected.txt:
platform/mac/fast/borders/bidi-009a-expected.txt:
platform/mac/fast/borders/bidi-012-expected.txt:
platform/mac/fast/borders/rtl-border-02-expected.txt:
platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/mac/fast/css/rtl-ordering-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/mac/fast/css/textCapitalizeEdgeCases-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt:
platform/mac/fast/dom/HTMLElement/bdo-expected.txt:
platform/mac/fast/forms/select-visual-hebrew-expected.txt:
platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
platform/mac/fast/inline/inline-borders-with-bidi-override-expected.txt:
platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/mac/fast/text/international/bidi-override-expected.txt:
platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/mac/fast/text/text-letter-spacing-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/import/text-intro-02-b-manual-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/import/text-intro-09-b-manual-expected.txt:
platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
platform/mac/svg/batik/text/textBiDi-expected.txt:
platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.txt:
platform/mac/svg/text/bidi-embedded-direction-expected.txt:
platform/mac/svg/text/bidi-text-anchor-direction-expected.txt:
platform/mac/svg/text/bidi-text-query-expected.txt:
platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
platform/win-7sp0/svg/text/bidi-text-query-expected.txt:
platform/win/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
platform/win/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
platform/win/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
platform/win/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
platform/win/fast/borders/bidi-002-expected.txt:
platform/win/fast/borders/bidi-009a-expected.txt:
platform/win/fast/borders/bidi-012-expected.txt:
platform/win/fast/borders/rtl-border-02-expected.txt:
platform/win/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/win/fast/css/rtl-ordering-expected.txt:
platform/win/fast/css/text-overflow-ellipsis-expected.txt:
platform/win/fast/css/text-overflow-ellipsis-strict-expected.txt:
platform/win/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/win/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
platform/win/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/win/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/win/fast/css/textCapitalizeEdgeCases-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt:
platform/win/fast/dom/HTMLElement/bdo-expected.txt:
platform/win/fast/forms/select-visual-hebrew-expected.txt:
platform/win/fast/forms/visual-hebrew-text-field-expected.txt:
platform/win/fast/inline/inline-borders-with-bidi-override-expected.txt:
platform/win/fast/text/atsui-rtl-override-selection-expected.txt:
platform/win/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
platform/win/fast/text/international/bidi-AN-after-L-expected.txt:
platform/win/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/win/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
platform/win/fast/text/international/bidi-european-terminators-expected.txt:
platform/win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/win/fast/text/international/bidi-override-expected.txt:
platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/win/fast/text/shaping/shaping-script-order-expected.txt:
platform/win/fast/text/shaping/shaping-selection-rect-expected.txt:
platform/win/fast/text/text-letter-spacing-expected.txt:
platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
platform/win/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
platform/win/svg/custom/glyph-selection-bidi-mirror-expected.txt:
platform/win/svg/custom/glyph-selection-non-bmp-expected.txt:
platform/win/svg/text/bidi-embedded-direction-expected.txt:
platform/win/svg/text/bidi-text-anchor-direction-expected.txt:
platform/win/svg/text/bidi-text-query-expected.txt:
platform/wincairo/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
platform/wincairo/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
platform/wincairo/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
platform/wincairo/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
platform/wincairo/fast/borders/bidi-002-expected.txt:
platform/wincairo/fast/borders/bidi-009a-expected.txt:
platform/wincairo/fast/borders/bidi-012-expected.txt:
platform/wincairo/fast/borders/rtl-border-02-expected.txt:
platform/wincairo/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/wincairo/fast/css/rtl-ordering-expected.txt:
platform/wincairo/fast/css/text-overflow-ellipsis-expected.txt:
platform/wincairo/fast/css/text-overflow-ellipsis-strict-expected.txt:
platform/wincairo/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/wincairo/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
platform/wincairo/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/wincairo/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/wincairo/fast/css/textCapitalizeEdgeCases-expected.txt:
platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
platform/wincairo/fast/dom/HTMLElement/bdo-expected.txt:
platform/wincairo/fast/forms/select-visual-hebrew-expected.txt:
platform/wincairo/fast/forms/visual-hebrew-text-field-expected.txt:
platform/wincairo/fast/inline/inline-borders-with-bidi-override-expected.txt:
platform/wincairo/fast/text/atsui-rtl-override-selection-expected.txt:
platform/wincairo/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
platform/wincairo/fast/text/international/bidi-AN-after-L-expected.txt:
platform/wincairo/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/wincairo/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/wincairo/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/wincairo/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
platform/wincairo/fast/text/international/bidi-european-terminators-expected.txt:
platform/wincairo/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/wincairo/fast/text/international/bidi-override-expected.txt:
platform/wincairo/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/wincairo/fast/text/shaping/shaping-script-order-expected.txt:
platform/wincairo/fast/text/shaping/shaping-selection-rect-expected.txt:
platform/wincairo/fast/text/text-letter-spacing-expected.txt:
platform/wincairo/svg/custom/glyph-selection-bidi-mirror-expected.txt:
platform/wpe/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
platform/wpe/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
platform/wpe/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
platform/wpe/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
platform/wpe/fast/borders/bidi-002-expected.txt:
platform/wpe/fast/borders/bidi-009a-expected.txt:
platform/wpe/fast/borders/bidi-012-expected.txt:
platform/wpe/fast/borders/rtl-border-02-expected.txt:
platform/wpe/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/wpe/fast/css/rtl-ordering-expected.txt:
platform/wpe/fast/css/text-overflow-ellipsis-expected.txt:
platform/wpe/fast/css/text-overflow-ellipsis-strict-expected.txt:
platform/wpe/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/wpe/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
platform/wpe/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/wpe/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/wpe/fast/css/textCapitalizeEdgeCases-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt:
platform/wpe/fast/dom/HTMLElement/bdo-expected.txt:
platform/wpe/fast/inline/inline-borders-with-bidi-override-expected.txt:
platform/wpe/fast/text/atsui-rtl-override-selection-expected.txt:
platform/wpe/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
platform/wpe/fast/text/international/bidi-AN-after-L-expected.txt:
platform/wpe/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/wpe/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/wpe/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/wpe/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
platform/wpe/fast/text/international/bidi-european-terminators-expected.txt:
platform/wpe/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/wpe/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/wpe/fast/text/international/bidi-override-expected.txt:
platform/wpe/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/wpe/fast/text/text-letter-spacing-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-02-b-manual-expected.txt:
platform/wpe/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
platform/wpe/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
platform/wpe/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
platform/wpe/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
platform/wpe/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
platform/wpe/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
platform/wpe/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
platform/wpe/svg/text/bidi-text-anchor-direction-expected.txt:

9:53 AM Changeset in webkit [286112] by Antti Koivisto

9 edits
2 adds in trunk/Source/WebCore

Factor child change invalidation into class
https://bugs.webkit.org/show_bug.cgi?id=233311

Reviewed by Alan Bujtas.

Use similar pattern as ClassChangeInvalidation and others where we create a stack object scoped
over a DOM mutation. This will allow more sophisticated ruleset based invalidation in
future.

This patch moves the invalidation code from childrenChanged() to the new ChildChangeInvalidation class.
ChildChangeInvalidation is instantiated in ContainerNode and CharacterData mutation functions
that call childrenChanged(). It uses the same ChildChange argument type as childrenChanged().

There are no changes to invalidation functionality in this patch.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/CharacterData.cpp:

(WebCore::makeChildChange):
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore::CharacterData::notifyParentAfterChange):

dom/CharacterData.h:
dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):
(WebCore::makeChildChangeForRemoval):
(WebCore::ContainerNode::removeNodeWithScriptAssertion):
(WebCore::makeChildChangeForInsertion):
(WebCore::executeNodeInsertionWithScriptAssertion):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::replaceAll):
(WebCore::ContainerNode::appendChildWithoutPreInsertionValidityCheck):
(WebCore::ContainerNode::parserAppendChild):
(WebCore::affectsElements):

dom/Element.cpp:

(WebCore::invalidateForSiblingCombinators):
(WebCore::Element::childTypeAllowed const):
(WebCore::Element::childrenChanged):
(WebCore::Element::finishParsingChildren):
(WebCore::checkForEmptyStyleChange): Deleted.
(WebCore::invalidateForForwardPositionalRules): Deleted.
(WebCore::invalidateForBackwardPositionalRules): Deleted.
(WebCore::checkForSiblingStyleChanges): Deleted.

dom/Element.h:
style/ChildChangeInvalidation.cpp: Added.

(WebCore::Style::ChildChangeInvalidation::ChildChangeInvalidation):
(WebCore::Style::ChildChangeInvalidation::~ChildChangeInvalidation):
(WebCore::Style::ChildChangeInvalidation::invalidateAfterChange):
(WebCore::Style::ChildChangeInvalidation::checkForEmptyStyleChange):
(WebCore::Style::invalidateForForwardPositionalRules):
(WebCore::Style::invalidateForBackwardPositionalRules):
(WebCore::Style::ChildChangeInvalidation::checkForSiblingStyleChanges):

style/ChildChangeInvalidation.h: Added.

(WebCore::Style::ChildChangeInvalidation::parentElement):

style/StyleAdjuster.h:

4:14 AM Changeset in webkit [286111] by commit-queue@webkit.org

21 edits
1 add
1 delete in trunk

[JSC] Make sharing of unlinked baseline code possible on JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=232624

Patch by Geza Lore <Geza Lore> on 2021-11-22
Reviewed by Yusuke Suzuki.

PerformanceTests/SunSpider:

Add extra SunSpider run on 32-bit platforms exerciseing baseline JIT
code sharing.

with-baseline-code-sharing.yaml: Added.

Source/JavaScriptCore:

This patch contains a few different changes, which taken together make
it possible to share the unlinked baseline JIT code between different
CodeBlocks on JSVALUE32_64 platforms. Note that by default, code
sharing is disabled on JSVALUE32_64 due to the increased executable
memory usage it may cause. The reson the executable memory usage might
increase is that the UnlinkedCodeBlock has a longer lifetime than the
corresponding linked CodeBlocks (due to the CodeCache I'm told), and
when using code sharing, it holds a reference to the JITed code. This
then prevents recycling of executable memory while the
UnlinkedCodeBlock is live, while without sharing we could have
reclaimed some of the executable memory earlier.

The high level changes in this pach are:

A lot of baseline implementations of the opcodes that needed

changing for the unlinked baseline are now unified between the
JSVALUE64 and JSVALUE32_64 platforms. Note that while this required
adding some abstraction, the code generated by the baseline JIT on
JSVALUE64 should be identical using this abstraction compared to
before.

I added a JSRInfo class which defines standard names for certain

JSValueReg instances. This enables a lot of the unification in the
point above to be expressed in a very simple manner, with very little
transformation of the existing code. Again, this should have no impact
on the generated code on JSVALUE64, apart from some register
substitutions.

The sizes of the resolve_scope and get_from_scope ops increased

significantly with the unlinked baseline. This can cause issues on
some JSVALUE32_64 targets where memory is more precious, so for these
two ops I swapped in the implementations under EXTRA_CTI_THUNKS, which
implement these using shared stubs. These stubs work on all platforms
that support ENABLE(JIT), so they are now the only implementation and
I have removed the basic bloated versions.

Removed some unused code and fields I discovered while working on

this, strictly speaking this is not necessary for the functional
change.

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::storeValue):
(JSC::AssemblyHelpers::isNull):
(JSC::AssemblyHelpers::isNotNull):
(JSC::AssemblyHelpers::emitTurnUndefinedIntoNull):
(JSC::AssemblyHelpers::noOverlap):
(JSC::AssemblyHelpers::noOverlapImpl):
(JSC::AssemblyHelpers::noOverlapImplRegMask):

jit/GPRInfo.h:
jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::compileAndLinkWithoutFinalizing):
(JSC::JIT::link):
(JSC::JIT::privateCompileExceptionHandlers):

jit/JIT.h:
jit/JITArithmetic.cpp:

(JSC::JIT::emit_compareAndJumpImpl):
(JSC::JIT::emit_compareUnsignedAndJumpImpl):
(JSC::JIT::emit_compareUnsignedImpl):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emitBinaryDoubleOp):

jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):

jit/JITCall.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileOpCall):
(JSC::JIT::emit_op_iterator_open):
(JSC::JIT::emit_op_iterator_next):

jit/JITInlines.h:

(JSC::JIT::getConstantOperand):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::emitValueProfilingSiteIfProfiledOpcode):
(JSC::JIT::emitValueProfilingSite):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitPutVirtualRegister):
(JSC::JIT::emitGetVirtualRegisterPayload):
(JSC::JIT::emitGetVirtualRegisterTag):
(JSC::JIT::emitLoadDouble):
(JSC::loadAddrOfCodeBlockConstantBuffer):
(JSC::JIT::loadCodeBlockConstant):
(JSC::JIT::loadCodeBlockConstantPayload):
(JSC::JIT::loadCodeBlockConstantTag):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_typeof_is_undefined):
(JSC::JIT::emit_op_is_undefined_or_null):
(JSC::JIT::emit_op_set_function_name):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::valueIsFalseyGenerator):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jeq_ptr):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_jeq):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::valueIsTruthyGenerator):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_jneq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::compileOpStrictEqJump):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_instanceof_custom):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_array_with_size):
(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):
(JSC::JIT::emit_op_get_argument):
(JSC::JIT::emit_op_get_prototype_of):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_is_empty):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_cell_with_type):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_to_property_key):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jundefined_or_null):
(JSC::JIT::emit_op_jnundefined_or_null):
(JSC::JIT::emit_op_jeq_ptr):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_jeq):
(JSC::JIT::compileOpEqJumpSlow):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_jneq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::compileOpStrictEqJump):
(JSC::JIT::emitSlow_op_jstricteq):
(JSC::JIT::emitSlow_op_jnstricteq):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_to_numeric):
(JSC::JIT::emit_op_to_string):
(JSC::JIT::emit_op_to_object):
(JSC::JIT::emit_op_get_parent_scope):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_check_tdz):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter_by_id):
(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::generateOpResolveScopeThunk):
(JSC::JIT::slow_op_resolve_scopeGenerator):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::generateOpGetFromScopeThunk):
(JSC::JIT::slow_op_get_from_scopeGenerator):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emit_op_get_from_arguments):
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):
(JSC::JIT::emit_op_get_property_enumerator):
(JSC::JIT::emit_op_enumerator_next):
(JSC::JIT::emit_op_enumerator_get_by_val):
(JSC::JIT::emitSlow_op_enumerator_get_by_val):
(JSC::JIT::emit_op_enumerator_in_by_val):
(JSC::JIT::emit_op_enumerator_has_own_property):
(JSC::JIT::emitWriteBarrier):

jit/JITPropertyAccess32_64.cpp: Removed.
jit/JSInterfaceJIT.h:
jit/ThunkGenerators.cpp:

(JSC::popThunkStackPreservesAndHandleExceptionGenerator):

jit/ThunkGenerators.h:
runtime/OptionsList.h:

Tools:

Add extra SunSpider run on 32-bit platforms exerciseing baseline JIT
code sharing.

Scripts/run-javascriptcore-tests:

(runJSCStressTests):

12:48 AM Changeset in webkit [286110] by youenn@apple.com

2 edits in trunk/Source/ThirdParty/libwebrtc

Remove h264_bitstream_parser spurious logging
https://bugs.webkit.org/show_bug.cgi?id=233361

Reviewed by Eric Carlson.

Source/webrtc/common_video/h264/h264_bitstream_parser.cc:

12:46 AM Changeset in webkit [286109] by Angelos Oikonomopoulos

9 edits
3 adds in trunk/Tools

Move detection of flaky JSC tests to run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=232529

Reviewed by Jonathan Bedard.

Currently, flaky detection happens by
ReRunJavaScriptCoreTests. Unfortunately, this means that we end up
rerunning all JSC tests when there's even a single failure. Even
worse, when the tree is broken (as sometimes happens on ARM32 and
MIPS) we end up

running the tests once (they fail)
running all tests again
running all tests again without the patch

This means the queue slows down a lot, since it runs all JSC
stress tests 3 times.

This patch attempts to eliminate step 2, while also being more
reliable about handling flaky tests. Since we no longer need to
rerun the whole test suite, we can spend more CPU time on
identifying tests that might be flaky. The user can pass in
--treat-failing-as-flaky=passPercentage,maxTries,maxFailing. If
less than maxFailing tests failed, we run them again (up to
maxTries) until we can tell whether they pass more than
passPercentage of the time. This should result in less false
positives compared to ReRunJavaScriptCoreTests, as we'll no longer
declare a flaky test a failure if it happens to fail two times in
a row. In order to remove ReRunJavaScriptCoreTests, the patch
unconditionally enables --treat-failing-as-flaky by default in the
JSC EWS queues.

Implementation-wise, the patch generalizes the existing retry loop in
run-jsc-stress-tests (for dealing with flaky remote hosts) to (a) work
with any runner and (b) also retry flaky tests. As flaky handling is
impractical to test manually, it also abstracts-out the retry logic so
that we can test with predetermined results. This means we need to
e.g. pass the runlist around instead of treating it as a global,
capturing the main logic in classes and having a subclass provide
methods to be called back and so on. The patch does not shy away from
refactoring code when it makes sense but also doesn't go out of its
way to refactor (e.g. there's still a lot of duplication between the
default and ruby writers).

Downsides: we can no longer detect flakiness in the binary tests
(testair, testb3, ...). However, I'm not aware of any instance of
flakiness in those tests. The retry loop is now being used for all
runners, which means the results analysis path for e.g. the make
runner is now a bit more complicated. Detecting flaky tests needs
code somewhere, but this moves the detection code before the
result reporting, so is a bit riskier. The self tests should
counterbalance this.

CISupport/ews-build/steps.py:

Kill ReRunJavaScriptCoreTests and enable --treat-failing-as-flaky.
Defaults to 60% pass percentage, 10 maxTries and a limit of 200
failing tests.
(RunJavaScriptCoreTests):
(RunJavaScriptCoreTests.init):
(RunJavaScriptCoreTests.start):
(RunJavaScriptCoreTests.evaluateCommand):
(RunJavaScriptCoreTests.commandComplete):
(RunJavaScriptCoreTests.getResultSummary):
(RunJavaScriptCoreTests._addToLog):
(AnalyzeJSCTestsResults.start):
(ReRunJavaScriptCoreTests): Deleted.
(ReRunJavaScriptCoreTests.evaluateCommand): Deleted.

CISupport/ews-build/steps_unittest.py:

Update to match the changes in steps.py. Some testcases no longer
apply.

Scripts/jsc-stress-test-helpers/shell-runner.sh:

Don't deduce the test list manually, expect it as an argument instead.

Scripts/run-javascriptcore-tests:

Propagate info on test flakiness.
(runJSCStressTests):

Scripts/run-jsc-stress-tests:

Refactor the execution logic to use the abstracted-out code in
executor.rb. Use the retry loop on every runner.

Scripts/webkitruby/jsc-stress-test-writer-default.rb:

Update the test-writer files for the changes to run-jsc-stress-tests.
Move prepareFooRunner and testRunnerCommand to a class so that we can
keep state (for the new argument to the shell runner).

Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
Scripts/webkitruby/jsc-stress-test/executor.rb: Added.

Implement a generic retry loop and define an array of virtual
tests (using predefined test results for each iteration).

Scripts/webkitruby/jsc-stress-test/test-result-evaluator.rb: Added.

Encapsulate the logic on whether a test has passed or not
(Did we get any results? Were those results enough to declare a
flaky/non-flaky test a pass?) and add a number of tests.

Nov 21, 2021:

7:06 PM Changeset in webkit [286108] by cathiechen

1 edit
1 add in trunk/PerformanceTests

[Performance test][css-contain] Add case to test contain: layout inside a complex document
https://bugs.webkit.org/show_bug.cgi?id=232883

Reviewed by Rob Buis.

This case test the performance of changing the content of a layout containment which is
inside a complex document.

Layout/css-contain-layout-size-inside-complex-document.html: Added.

3:58 PM Changeset in webkit [286107] by Alan Bujtas

15 edits in trunk

[LFC][Integration] Enable bidi content for non-inline-box cases
https://bugs.webkit.org/show_bug.cgi?id=232980
<rdar://problem/85281410>

Reviewed by Antti Koivisto.

Source/WebCore:

layout/integration/LayoutIntegrationCoverage.cpp:

LayoutTests:

platform/ios/fast/dom/52776-expected.txt: progression
platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: progression
platform/ios/fast/text/international/bidi-neutral-run-expected.txt: rebaseline
platform/ios/fast/text/international/bidi-override-expected.txt: see FIXME
platform/ios/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: see FIXME

platform/mac/fast/dom/52776-expected.txt:
platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/mac/fast/text/international/bidi-neutral-run-expected.txt:

3:41 PM Changeset in webkit [286106] by Wenson Hsieh

4 edits
3 adds in trunk/Tools

Add an API test for batch image analysis (-[WKWebView _startImageAnalysis:])
https://bugs.webkit.org/show_bug.cgi?id=233331

Reviewed by Sam Weinig.

Add a new API teset to exercise the -_startImageAnalysis: SPI introduced in r285949, along with helper
functions to simulate VKImageAnalysis results from VisionKitCore. See below for more details.

TestWebKitAPI/SourcesCocoa.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(-[TestWKWebView waitForImageAnalysisRequests:]):
(TestWebKitAPI::createWebViewWithTextRecognitionEnhancements):
(TestWebKitAPI::swizzledProcessRequestWithResults):
(TestWebKitAPI::swizzledProcessRequestWithError):
(TestWebKitAPI::TEST):
(TestWebKitAPI::swizzledProcessRequest): Deleted.

Add an API test that uses -_startImageAnalysis: to perform batch image analysis over 5 image elements on the
page, and verify that the text results are injected back into the page.

TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html: Added.
TestWebKitAPI/cocoa/ImageAnalysisTestingUtilities.h: Added.
TestWebKitAPI/cocoa/ImageAnalysisTestingUtilities.mm: Added.

(-[TestVKQuad initWithTopLeft:topRight:bottomLeft:bottomRight:]):
(-[TestVKWKTextInfo initWithString:quad:]):
(-[TestVKWKTextInfo string]):
(-[TestVKWKTextInfo quad]):
(-[TestVKWKLineInfo initWithString:quad:children:]):
(-[TestVKWKLineInfo children]):
(-[TestVKImageAnalysis initWithLines:]):
(-[TestVKImageAnalysis allLines]):
(TestWebKitAPI::createQuad):
(TestWebKitAPI::createTextInfo):
(TestWebKitAPI::createLineInfo):
(TestWebKitAPI::createImageAnalysis):
(TestWebKitAPI::createImageAnalysisWithSimpleFixedResults):

Add helper functions to create and return mock objects that represent VKImageAnalysis, VKWKLineInfo,
VKWKTextInfo and VKQuad.

1:28 PM Changeset in webkit [286105] by Jean-Yves Avenard

3 edits in trunk/Source/WebCore

Remove unused HTMLModelElement::modelData() method.
https://bugs.webkit.org/show_bug.cgi?id=233406
rdar://85640503

Reviewed by Sam Weinig.

No change in observable behaviour.

Modules/model-element/HTMLModelElement.cpp:

(WebCore::HTMLModelElement::notifyFinished):

Modules/model-element/HTMLModelElement.h:

12:43 PM Changeset in webkit [286104] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Add support for caching bidi InlineTextItem widths
https://bugs.webkit.org/show_bug.cgi?id=233402

Reviewed by Antti Koivisto.

Let's do a "text content measure" pass when the inline item boundaries are finalized (including bidi split).

layout/formattingContexts/inline/InlineItem.h:

(WebCore::Layout::InlineItem::setWidth):

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::build):
(WebCore::Layout::InlineItemsBuilder::computeInlineTextItemWidths):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):

layout/formattingContexts/inline/InlineItemsBuilder.h:

12:10 PM Changeset in webkit [286103] by Fujii Hironori

3 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

platform/wincairo-wk1/TestExpectations:
platform/wincairo/TestExpectations:

10:35 AM Changeset in webkit [286102] by Andres Gonzalez

3 edits in trunk/Tools

Dispatch all AccessibilityUIElement parameterized attribute requests to the AX thread for isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=233377
<rdar://problem/85613334>

Reviewed by Chris Fleizach.

To simulate AT client requests in isolated tree mode, all parameterized
attribute requests should be dispatched to the AX thread.
This patch adds AccessibilityUIElement::attributeValueForParameter that
does the appropriate dispatch to the AX thread.

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::attributeValue):
(WTR::AccessibilityUIElement::attributeValue const):
(WTR::AccessibilityUIElement::attributeValueForParameter const):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):
(WTR::AccessibilityUIElement::searchTextWithCriteria):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::lineIndexForTextMarker const):
(WTR::AccessibilityUIElement::misspellingTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::textMarkerRangeForRange):
(WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
(WTR::_convertMathMultiscriptPairsToString):

10:33 AM Changeset in webkit [286101] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Cache measured width even if canUseSimplifiedTextMeasuring is false
https://bugs.webkit.org/show_bug.cgi?id=233404

Reviewed by Antti Koivisto.

Just because some content goes through the non-simplified text measuring codepath, it does not
necessary mean we can't cache the measured value on the inline item (actually, we can cache these values just fine in most cases).

This is in preparation for being able to cache bidi content measured widths.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::canCacheMeasuredWidthOnInlineTextItem):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):

10:22 AM Changeset in webkit [286100] by Ziran Sun

4 edits in trunk

[css-grid] svg image as grid items should use the overriding logical width/height when defined to compute the logical height/width
https://bugs.webkit.org/show_bug.cgi?id=228105

Reviewed by Javier Fernandez.

Source/WebCore:

This is a reland of r280290. It's got reverted because another patch r280078 caused crash and had been
reverted. r280290 is a dependent patch for r280078.

As discussed at https://github.com/w3c/csswg-drafts/issues/6286#issuecomment-866986544, degenerate
aspect ratios derived from SVG width/height attributes fall back to viewbox aspect ratio
(whether due to negative values or zero values).

When computing the logical height/width using an intrinsic aspect ratio, RenderReplaced uses the
overridingLogicalWidth/overridingLogicalHeight whenever defined as long as the flex or
grid item has an intrinsic size. For an SVG graphic though, it's common to have an intrinsic aspect
ratio but not to have an intrinsic width or height. For this special case, we still should use
overridingLogicalWidth/overridingLogicalHeight for logical height/width calculations.

rendering/RenderReplaced.cpp:

(WebCore::hasIntrinsicSize):
(WebCore::RenderReplaced::computeReplacedLogicalWidth const):
(WebCore::RenderReplaced::computeReplacedLogicalHeight const):

LayoutTests:

TestExpectations: unskip two tests that are now passing.

8:51 AM Changeset in webkit [286099] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] Introduce canCacheMeasuredWidthOnInlineTextItem
https://bugs.webkit.org/show_bug.cgi?id=233399

Reviewed by Antti Koivisto.

This patch is in preparation for decoupling simplified text measuring and measured width caching.
(Caching should solely be position and (maybe) context dependent.)

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::canCacheMeasuredWidthOnInlineTextItem const):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):

layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::canUseSimplifiedTextMeasuringForFirstLine): Deleted.

layout/formattingContexts/inline/text/TextUtil.h:
layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree): whitespace is not part of the first-line style set.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed