⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 1, 2022:

11:22 PM Changeset in webkit [287509] by graouts@webkit.org
  • 8 edits in trunk

"animation" shorthand does not parse values in the right order
​https://bugs.webkit.org/show_bug.cgi?id=234788

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark a new WPT progression.

  • web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt:

Source/WebCore:

The animation-name should be parsed last, not first.

  • css/CSSProperties.json:

LayoutTests:

Update the order in which animation-name is serialized in the "animation" shorthand
for some non-WPT tests.

  • fast/css/longhand-overrides-shorthand-prefixing-expected.txt:
  • fast/css/longhand-overrides-shorthand-prefixing.html:
  • fast/css/transform-inline-style-remove-expected.txt:
5:06 PM Changeset in webkit [287508] by Diego Pino Garcia
  • 5 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening, update flakey tests expectations
​https://bugs.webkit.org/show_bug.cgi?id=234760

Remove tests that have been constantly passing for the last 4000 revisions, as well as update state of tests
that have been constantly failing with a single state.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt:
  • platform/gtk/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt:
  • platform/wpe/TestExpectations:
4:19 PM Changeset in webkit [287507] by Jean-Yves Avenard
  • 11 edits in trunk/Source/WebCore

ScalableImageDecoder should be using SharedBuffer instead of DataSegment
​https://bugs.webkit.org/show_bug.cgi?id=233441
rdar://problem/85854204

Reviewed by Darin Adler.

DataSegment should be a SharedBuffer's implementation details and not
be used outside SharedBuffer's code.
Historically, using the inner DataSegment was required as it was thread
safe while SharedBuffer wasn't: This is no longer the case.
SharedBuffer and DataSegment are semantically very similar, so this is
mostly a find/replace change.
Flattening the FragmentedSharedBuffer is still required as most decoders
require reading the raw bytes.

No change in observable behaviour.

  • platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::setSize):
(WebCore::ImageBackingStore::ImageBackingStore):

  • platform/image-decoders/ScalableImageDecoder.h:
  • platform/image-decoders/avif/AVIFImageReader.cpp:

(WebCore::AVIFImageReader::parseHeader):
(WebCore::AVIFImageReader::decodeFrame):

  • platform/image-decoders/avif/AVIFImageReader.h:
  • platform/image-decoders/bmp/BMPImageReader.h:

(WebCore::BMPImageReader::readUint16):
(WebCore::BMPImageReader::readUint32):
(WebCore::BMPImageReader::setData):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::setData):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):

  • platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp:

(WebCore::JPEG2000ImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

4:09 PM Changeset in webkit [287506] by Jean-Yves Avenard
  • 4 edits in trunk

make SharedBuffer::copy() return a contiguous SharedBuffer
​https://bugs.webkit.org/show_bug.cgi?id=234622
rdar://problem/86829527

Reviewed by Darin Adler.

Source/WebCore:

make SharedBuffer::copy() return a contiguous SharedBuffer

API tests added.

  • platform/SharedBuffer.cpp:

(WebCore::FragmentedSharedBuffer::copy const):

Tools:

  • TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

3:06 PM Changeset in webkit [287505] by Wenson Hsieh
  • 5 edits in trunk

Modal containers are incorrectly detected in navigation elements and fixed document elements
​https://bugs.webkit.org/show_bug.cgi?id=234669
rdar://87030613

Reviewed by Darin Adler.

Source/WebCore:

Avoid false positives when detecting modal containers in the following scenarios:

  • Fixed-position document elements that contain the search term.
  • Text that contains the search term inside fixed-position navigation elements.

Additionally, ensure that we unhide the current modal container in the event of a false positive where we find
no element that fulfills the criteria for being a classifiable control.

Tests: ModalContainerObservation.IgnoreFixedDocumentElement

ModalContainerObservation.IgnoreNavigationElements
ModalContainerObservation.ShowModalContainerAfterFalsePositive

  • page/ModalContainerObserver.cpp:

(WebCore::accessibilityRole):

Move this static helper function farther up this source file, so that we can use it inside
updateModalContainerIfNeeded().

(WebCore::isInsideNavigationElement):
(WebCore::ModalContainerObserver::updateModalContainerIfNeeded):
(WebCore::ModalContainerPolicyDecisionScope::ModalContainerPolicyDecisionScope):
(WebCore::ModalContainerPolicyDecisionScope::~ModalContainerPolicyDecisionScope):
(WebCore::ModalContainerPolicyDecisionScope::continueHidingModalContainerAfterScope):
(WebCore::ModalContainerPolicyDecisionScope::document const):

Add a RAII helper object to ensure that the modal container is revealed at the end of the modal container policy
decision scope, unless continueHidingModalContainerAfterScope() is invoked. Since this class contains a
WeakPtr<Document> already, we can replace the WeakPtr<Document> we're currently plumbing through each of the
async callbacks with only the ModalContainerPolicyDecisionScope, and just grab the document (or null if it was
destroyed) from the scope object.

This helper object allows us to avoid sprinkling ad-hoc calls to revealModalContainer() when exiting modal
container classification codepaths.

(WebCore::ModalContainerObserver::collectClickableElementsTimerFired):

  • page/ModalContainerObserver.h:

Tools:

Add several new API tests to exercise the changes.

  • TestWebKitAPI/Tests/WebKitCocoa/ModalContainerObservation.mm:

(-[ModalContainerWebView initWithFrame:configuration:]):
(-[ModalContainerWebView loadHTML:]):
(-[ModalContainerWebView _webView:decidePolicyForModalContainer:decisionHandler:]):
(TestWebKitAPI::TEST):

2:54 PM Changeset in webkit [287504] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][IFC] Unexpected line break with leading collapsed whitespace
​https://bugs.webkit.org/show_bug.cgi?id=234786

Reviewed by Antti Koivisto.

Source/WebCore:

We use Line::hasContent to decide whether an overflowing content should be wrapped to the next line.
Line is considered empty unless it has at least one content-type run.

Test: fast/inline/unexpected-line-break-on-empty-content.html

  • layout/formattingContexts/inline/InlineLine.h:

(WebCore::Layout::Line::hasContent const):

LayoutTests:

  • fast/inline/unexpected-line-break-on-empty-content-expected.html: Added.
  • fast/inline/unexpected-line-break-on-empty-content.html: Added.
1:03 PM Changeset in webkit [287503] by Wenson Hsieh
  • 2 edits in trunk/Tools

[Cocoa] Simplify some FontAttributes API tests
​https://bugs.webkit.org/show_bug.cgi?id=234770

Reviewed by Darin Adler.

Simplify some of the logic around FontAttributes.FontAttributesAfterChangingSelection:

  1. Instead of defining PlatformColor/PlatformFont, use CocoaColor/CocoaFont from WebCore.
  2. Remove the Nullity flag in ShadowExpectation and ColorExpectation (and use std::optional instead to

indicate that the shadow or font attribute should be null).

  1. Change a several rvalue references to be plain values instead (when passinng expectation structs that only

contain a handful of scalar values).

  • TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:

(TestWebKitAPI::checkColor):
(TestWebKitAPI::checkShadow):
(TestWebKitAPI::checkFont):
(TestWebKitAPI::TEST):
(TestWebKitAPI::ColorExpectation::ColorExpectation): Deleted.
(TestWebKitAPI::ShadowExpectation::ShadowExpectation): Deleted.

8:25 AM Changeset in webkit [287502] by jeffm@apple.com
  • 22 edits in trunk

Update user-visible copyright strings to include 2022
​https://bugs.webkit.org/show_bug.cgi?id=234263

Reviewed by Anders Carlsson.

.:

  • Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:

Source/JavaScriptCore:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebGPU:

  • Info.plist:

Source/WebKit:

  • GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist:
  • GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:
  • Info.plist:
  • NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist:
  • NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist:
  • WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist:
  • WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist:
  • WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
  • WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

Source/WebKitLegacy/mac:

  • Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
7:34 AM Changeset in webkit [287501] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Simple RTL content triggers redundant horizontal positioning
​https://bugs.webkit.org/show_bug.cgi?id=234772

Reviewed by Antti Koivisto.

RTL content with inline boxes require a second pass horizontal positioning.
Currently we trigger this second pass even when the content does not have any inline box.
(e.g <div>content<span>with inline box</span></div> <div>content with no inline box</div>)

  • layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): !0 parentDisplayBoxNodeIndex means non-root inline box.
(WebCore::Layout::DisplayBoxTree::hasInlineBox const): Deleted.

6:55 AM Changeset in webkit [287500] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][IFC] Incorrect word-spacing gaps between RTL runs
​https://bugs.webkit.org/show_bug.cgi?id=234771

Reviewed by Antti Koivisto.

Source/WebCore:

"word-spacing" acts as a margin for word separator type of runs.
In this patch we take this margin into account the same way we do for atomic inline level boxes with margins.

Test: fast/text/word-spacing-rtl.html

  • layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::Run::Run):

  • layout/formattingContexts/inline/InlineLine.h:

(WebCore::Layout::Line::Run::isText const):
(WebCore::Layout::Line::Run::isWordSeparator const):

  • layout/formattingContexts/inline/display/InlineDisplayBox.h:

(WebCore::InlineDisplay::Box::isText const):
(WebCore::InlineDisplay::Box::isWordSeparator const):
(WebCore::InlineDisplay::Box::isNonRootInlineLevelBox const):
(WebCore::InlineDisplay::Box::type const): Deleted.

  • layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

LayoutTests:

  • fast/text/word-spacing-rtl-expected.html: Added.
  • fast/text/word-spacing-rtl.html: Added.
6:15 AM Changeset in webkit [287499] by ntim@apple.com
  • 42 edits
    1 copy
    5 moves
    68 adds in trunk/LayoutTests

Re-import css/css-writing-modes WPT
​https://bugs.webkit.org/show_bug.cgi?id=234764

Reviewed by Dean Jackson.

Upstream commit: ​https://github.com/web-platform-tests/wpt/commit/e433ff38f5230f3fec9c6fd434b942c7bffbfc67

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-writing-modes/astral-bidi/adlam-anti-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/astral-bidi/adlam-anti-ref-expected.html.
  • web-platform-tests/css/css-writing-modes/astral-bidi/cypriot-anti-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/astral-bidi/cypriot-anti-ref-expected.html.
  • web-platform-tests/css/css-writing-modes/astral-bidi/w3c-import.log:
  • web-platform-tests/css/css-writing-modes/bidi-dynamic-iframe-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/bidi-dynamic-iframe-001.html: Added.
  • web-platform-tests/css/css-writing-modes/bidi-plaintext-br-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/bidi-plaintext-br-001.html: Added.
  • web-platform-tests/css/css-writing-modes/block-flow-direction-slr-062.xht:
  • web-platform-tests/css/css-writing-modes/block-flow-direction-srl-061.xht:
  • web-platform-tests/css/css-writing-modes/block-flow-direction-vlr-022.xht:
  • web-platform-tests/css/css-writing-modes/block-flow-direction-vrl-021.xht:
  • web-platform-tests/css/css-writing-modes/crashtests/orthogonal-percent-height-multicol-crash.html: Added.
  • web-platform-tests/css/css-writing-modes/crashtests/orthogonal-scroll-percent-height-crash.html: Added.
  • web-platform-tests/css/css-writing-modes/crashtests/orthogonal-table-in-flex-crash.html: Added.
  • web-platform-tests/css/css-writing-modes/crashtests/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/astral-bidi/w3c-import.log.
  • web-platform-tests/css/css-writing-modes/crashtests/wm-body-propagation-crash.html: Added.
  • web-platform-tests/css/css-writing-modes/direction-propagation-body-contain-root-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/direction-propagation-body-contain-root.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-001.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-002-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-002.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-001.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-002-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-002.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-001.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-002-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-002.html: Added.
  • web-platform-tests/css/css-writing-modes/full-width-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/full-width-001-expected.html.
  • web-platform-tests/css/css-writing-modes/full-width-002-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/full-width-002-expected.html.
  • web-platform-tests/css/css-writing-modes/full-width-003-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/full-width-003-expected.html.
  • web-platform-tests/css/css-writing-modes/inline-box-orthogonal-child-with-margins-expected.html:
  • web-platform-tests/css/css-writing-modes/inline-box-orthogonal-child-with-margins.html:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-003.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-005.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-007.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-009.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-011.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-013.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-021.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vlr-023.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vrl-002.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vrl-004.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vrl-006.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vrl-008.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vrl-010.xht:
  • web-platform-tests/css/css-writing-modes/line-box-height-vrl-012.xht:
  • web-platform-tests/css/css-writing-modes/logical-physical-mapping-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/logical-physical-mapping-001.html: Added.
  • web-platform-tests/css/css-writing-modes/padding-percent-orthogonal-dynamic-expected.txt: Added.
  • web-platform-tests/css/css-writing-modes/padding-percent-orthogonal-dynamic.html: Added.
  • web-platform-tests/css/css-writing-modes/replaced-content-image-004-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/replaced-content-image-004.html: Added.
  • web-platform-tests/css/css-writing-modes/sizing-orthog-vrl-in-htb-013-expected.xht:
  • web-platform-tests/css/css-writing-modes/sizing-orthog-vrl-in-htb-013.xht:
  • web-platform-tests/css/css-writing-modes/slr-alongside-vlr-floats-expected.html:
  • web-platform-tests/css/css-writing-modes/slr-alongside-vlr-floats.html:
  • web-platform-tests/css/css-writing-modes/srl-alongside-vrl-floats-expected.html:
  • web-platform-tests/css/css-writing-modes/srl-alongside-vrl-floats.html:
  • web-platform-tests/css/css-writing-modes/support/WidthTest-Regular.otf: Added.
  • web-platform-tests/css/css-writing-modes/support/tcy.css: Added.

(.tcy):
(.fake-tcy):

  • web-platform-tests/css/css-writing-modes/support/w3c-import.log:
  • web-platform-tests/css/css-writing-modes/support/width-test.css: Added.

(@font-face):
(.test):

  • web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001a-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001a.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-001.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-002-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-002.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-003-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-003.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-004-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-004.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005a-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005a.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006a-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006a.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-007-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-combine-upright-compression-007.html: Added.
  • web-platform-tests/css/css-writing-modes/text-orientation-upright-directionality-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-orientation-upright-directionality-001.html: Added.
  • web-platform-tests/css/css-writing-modes/text-shadow-orientation-upright-001-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/text-shadow-orientation-upright-001.html: Added.
  • web-platform-tests/css/css-writing-modes/vlr-text-orientation-sideways-alongside-vlr-floats-expected.html:
  • web-platform-tests/css/css-writing-modes/vlr-text-orientation-sideways-alongside-vlr-floats.html:
  • web-platform-tests/css/css-writing-modes/vrl-inline-paint-invalidation-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/vrl-inline-paint-invalidation.html: Added.
  • web-platform-tests/css/css-writing-modes/vrl-text-orientation-sideways-alongside-vrl-floats-expected.html:
  • web-platform-tests/css/css-writing-modes/vrl-text-orientation-sideways-alongside-vrl-floats.html:
  • web-platform-tests/css/css-writing-modes/w3c-import.log:
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-001-expected.txt: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-001.html: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-002-expected.txt: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-002.html: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-contain-root-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-contain-root.html: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-001.html:
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-002-expected.html:
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-002.html:
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-003-expected.html: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-003.html: Added.
  • web-platform-tests/css/css-writing-modes/wm-propagation-svg-root-scrollbar.svg:

LayoutTests:

Dec 31, 2021:

10:03 PM Changeset in webkit [287498] by Tyler Wilcock
  • 3 edits in trunk/Source/WebCore

Reduce repetition in Internals "set page activity state" methods
​https://bugs.webkit.org/show_bug.cgi?id=234768

Reviewed by Darin Adler.

setPageVisibility, setPageIsFocusedAndActive, and
setPageIsInWindow all modify page activity state, and repeat a lot
of the same logic to do so. This patch refactors this into a common
updatePageActivityState method.

  • testing/Internals.cpp:

(WebCore::Internals::setPageVisibility):
(WebCore::Internals::setPageIsFocusedAndActive):
(WebCore::Internals::setPageIsInWindow):
Refactor to use the new updatePageActivityState method.
(WebCore::Internals::updatePageActivityState):
Added.

  • testing/Internals.h:
4:22 PM Changeset in webkit [287497] by Wenson Hsieh
  • 4 edits in trunk

Include a few more tag names to search when running modal container detection
​https://bugs.webkit.org/show_bug.cgi?id=234652

Reviewed by Darin Adler.

Source/WebCore:

Broaden the list of tag names that we heuristically scan for the search term. This particular modal container
detection failure was due to the search term appearing inside a b element, though I'm adding a few additional
types just to be safe. Since we're checking more than just few tag names, we also take this opportunity to
convert this into a compact AtomString hashtable of tag names that we should scan in the process of detecting
modal containers.

Test: ModalContainerObservation.DetectSearchTermInBoldTag

  • page/ModalContainerObserver.cpp:

(WebCore::matchesSearchTerm):

Tools:

Add an API test that's representative of the website where modal container observation failed (due to the search
term being inside a b element).

  • TestWebKitAPI/Tests/WebKitCocoa/ModalContainerObservation.mm:

(TestWebKitAPI::TEST):

3:33 PM Changeset in webkit [287496] by Wenson Hsieh
  • 20 edits
    1 move in trunk/Source

Refactor some Cocoa-specific code in WebCore::FontAttributes to be platform-agnostic
​https://bugs.webkit.org/show_bug.cgi?id=234757

Source/WebCore:

Reviewed by Darin Adler.

Replace the UIFont/NSFont currently in WebCore::FontAttributes with a WebCore::Font instead. This removes a bit
of platform-specific logic in an otherwise platform-agnostic class (with the exception of a couple Cocoa-
specific helper methods). This additionally lets us remove some platform-specific logic for computing font
attributes (i.e. platformFontAttributesAtSelectionStart) below.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp:

(WebCore::Editor::fontAttributesAtSelectionStart):
(WebCore::Editor::platformFontAttributesAtSelectionStart const): Deleted.

  • editing/Editor.h:
  • editing/FontAttributes.h:

(WebCore::TextList::encode const):
(WebCore::TextList::decode):

Drive-by fix: instead of static_cast-ing to a uint8_t and encoding/decoding the raw value, encode and decode
the ListStyleType as a normal enum instead. This also ensures that we validate the enum value upon decoding.

(WebCore::FontAttributes::encodingRequiresPlatformData const): Deleted.

  • editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::platformFontAttributesAtSelectionStart const): Deleted.

  • editing/cocoa/FontAttributesCocoa.mm:

(WebCore::FontAttributes::createDictionary const):

Only grab the NSFont or UIFont from the WebCore::Font object once we're in this Cocoa-specific helper.

  • platform/graphics/cocoa/FontCocoa.h: Added.

Moved here from CocoaFont.h in WebKit. See WebKit/ChangeLog for more details.

  • rendering/style/RenderStyleConstants.h:

Add EnumTraits for ListStyleType, so that it can be encoded/decoded.

Source/WebKit:

See comments below (as well as WebCore/ChangeLog) for more details.

Reviewed by Darin Adler.

  • Platform/cocoa/CocoaFont.h: Removed.

Move this file into WebCore, as FontCocoa.h.

  • Shared/Cocoa/ArgumentCodersCocoa.mm:
  • Shared/Cocoa/CoreTextHelpers.h:
  • Shared/Cocoa/CoreTextHelpers.mm:

Adjust a few places that currently import CocoaFont.h to import WebCore/FontCocoa.h instead. Additonally, change
CocoaFont to WebCore::CocoaFont where necessary.

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::FontAttributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontAttributes>::decodePlatformData): Deleted.

Remove platform-specific FontAttributes encoding/decoding logic. This is no longer needed, since we just
propagate a Font instead of an NSFont or UIFont.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<RefPtr<Font>>::encode):
(IPC::ArgumentCoder<RefPtr<Font>>::decode):

Add argument coders for RefPtr<Font> that encode the font only if it's non-null.

(IPC::ArgumentCoder<FontAttributes>::encode):
(IPC::ArgumentCoder<FontAttributes>::decode):

Remove the calls to encodePlatformData/decodePlatformData, and instead encode the RefPtr<WebCore::Font>.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/playstation/WebCoreArgumentCodersPlayStation.cpp:

(IPC::ArgumentCoder<FontAttributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<FontAttributes>::decodePlatformData): Deleted.

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<FontAttributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<FontAttributes>::decodePlatformData): Deleted.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(IPC::ArgumentCoder<FontAttributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<FontAttributes>::decodePlatformData): Deleted.

Remove some method stubs that are now unnecessary.

  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(fontOfSize):

  • WebKit.xcodeproj/project.pbxproj:
12:08 PM Changeset in webkit [287495] by Alan Bujtas
  • 3 edits
    2 adds in trunk

REGRESSION (r287028): Incorrect root inline box horizontal position when text-align offset is present
​https://bugs.webkit.org/show_bug.cgi?id=234767

Reviewed by Antti Koivisto.

Source/WebCore:

Display line has the content's visual left (rtl vs ltr) which should be used to position the root inline box.
We use the same offset when construcing the non-root display boxes.

Test: fast/text/root-inline-box-offset-with-text-align.html

  • layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::build):

LayoutTests:

  • fast/text/root-inline-box-offset-with-text-align-expected.html: Added.
  • fast/text/root-inline-box-offset-with-text-align.html: Added.
11:46 AM Changeset in webkit [287494] by Wenson Hsieh
  • 6 edits in trunk

Updating the file name of attachment-backed images should automatically set the alt attribute
​https://bugs.webkit.org/show_bug.cgi?id=234747
rdar://85899879

Reviewed by Darin Adler.

Source/WebCore:

Make a small adjustment when updating attachment attributes for attachment-backed images (i.e. when using
-[_WKAttachmentInfo setFileWrapper:contentType:completion:]), such that the alt attribute of the image is
set to the attachment element's title. While convenient for all internal clients of the _WKAttachment SPI
(i.e. Mail, Notes), this has the added benefit of preserving the attachment's file name when copying and pasting
across different web views (where a new API::Attachment is generated on paste), instead of defaulting to the
last path component of the blob URL corresponding to the image data in the web archive.

Test: WKAttachmentTests.CopyAndPasteImageBetweenWebViews

  • editing/Editor.cpp:

(WebCore::Editor::notifyClientOfAttachmentUpdates):

  • html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::enclosingImageElement const):
(WebCore::HTMLAttachmentElement::updateAttributes):
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):
(WebCore::HTMLAttachmentElement::hasEnclosingImage const): Deleted.

Replace hasEnclosingImage() with enclosingImageElement(), a helper that returns the enclosing image element
(or null if there is none). We use the latter in a couple of places above, where we modify some attributes on
the enclosing image in response to attribute and data updates.

  • html/HTMLAttachmentElement.h:

Tools:

Add a new API test to exercise this scenario -- i.e. copying an attachment-backed image in one web view, pasting
it into another web view, and confirming that the pasted attachment preserves the _WKAttachment file name.

  • TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(-[TestWKWebView ensureAttachmentForImageElement]):
(TestWebKitAPI::TEST):

6:21 AM Changeset in webkit [287493] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[LFC][IFC] Take grapheme clusters into account when keeping the first "character" on the line
​https://bugs.webkit.org/show_bug.cgi?id=234758

Reviewed by Antti Koivisto.

When dealing with complex fonts, we have to start looking beyond code points and taking
larger cluster of code units into account.

This patch is in preparation for enabling complex font codepath.

  • layout/formattingContexts/inline/InlineContentBreaker.cpp:

(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):

  • layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::firstUserPerceivedCharacterLength): user-perceived character is a unicode term.
see ​https://unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries

  • layout/formattingContexts/inline/text/TextUtil.h:
  • layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

  • layout/layouttree/LayoutInlineTextBox.cpp:

(WebCore::Layout::InlineTextBox::InlineTextBox):
(WebCore::Layout::m_canUseSimpleFontCodePath):
(WebCore::Layout::m_canUseSimplifiedContentMeasuring): Deleted.

  • layout/layouttree/LayoutInlineTextBox.h:

(WebCore::Layout::InlineTextBox::canUseSimpleFontCodePath const):

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):

  • layout/layouttree/LayoutTreeBuilder.h:
2:11 AM Changeset in webkit [287492] by Diego Pino Garcia
  • 4 edits in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening, move several fast/scrolling tests failures to GLIB
​https://bugs.webkit.org/show_bug.cgi?id=234759

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
1:13 AM Changeset in webkit [287491] by ntim@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: fix assert text in Gradient.js

Unreviewed.

Wrong assert text was added in r287409, it should be radial instead of conic gradients.

  • UserInterface/Models/Gradient.js:

(WI.RadialGradient.prototype.set angleValue):
(WI.RadialGradient.prototype.set angleUnits):

Note: See TracTimeline for information about the timeline view.