Context Navigation

← Previous Period
Next Period →

Timeline

Jan 2, 2022:

11:39 PM Changeset in webkit [287531] by ysuzuki@apple.com

7 edits
1 add in trunk

[JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases
https://bugs.webkit.org/show_bug.cgi?id=234794

Reviewed by Alexey Shvayka.

JSTests:

test262/expectations.yaml:

Source/JavaScriptCore:

This patch consistently uses emitPutProperty / emitGetPropertyValue so that we handle private names
in edge cases.

bytecompiler/NodesCodegen.cpp:

(JSC::TaggedTemplateNode::emitBytecode):
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::AssignmentElementNode::bindValue const):

10:30 PM Changeset in webkit [287530] by Diego Pino Garcia

3 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening, update baseline for imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window.html
https://bugs.webkit.org/show_bug.cgi?id=207258

platform/glib/TestExpectations:
platform/glib/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt:

9:52 PM Changeset in webkit [287529] by Manuel Rego Casasnovas

12 edits
2 adds in trunk

Access key should work on focusable element.
https://bugs.webkit.org/show_bug.cgi?id=72359

Reviewed by Darin Adler.

Source/WebCore:

Elements that have "accesskey" attribute and are focusable should be focused when you use the access key,
this is happening for some elements but not all.
To fix the issue this patch moves accessKeyAction() implementation from some subclasses to HTMLElement,
which makes us match other browsers.

This patch changes the behavior for HTMLAnchorElement, as it was not focused before, but that matches other browsers too.

Test: fast/dom/accesskey-focus-element.html

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::accessKeyAction): Deleted.

html/HTMLAnchorElement.h:
html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::accessKeyAction): Deleted.

html/HTMLButtonElement.h:
html/HTMLElement.cpp:

(WebCore::HTMLElement::accessKeyAction):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::accessKeyAction): Deleted.

html/HTMLSelectElement.h:

LayoutTests:

Add new test to check the behavior of accesskey on focusable and not focusable DIV, together with other elements
like INPUT, SELECT and A.
Update expectations for fast/forms/access-key.html test, as now more elements are focused than before.
Apart from that we had to modify accessibility/mac/search-predicate-visited-links.html as that was pressing a link
and the link is now focused.

This will make us also pass css/selectors/focus-visible-024.html from WPT, but that test cannot run properly on WebKit
due to webkit.org/b/234139.

accessibility/mac/search-predicate-visited-links.html: Update test due to change of behavior.
fast/dom/accesskey-focus-element-expected.txt: Added.
fast/dom/accesskey-focus-element.html: Added.
fast/forms/access-key-expected.txt: Update expectations.
platform/ios/TestExpectations: Skip new accesskey test.

9:40 PM Changeset in webkit [287528] by Diego Pino Garcia

2 edits
2 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening, emit baseline for imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html
https://bugs.webkit.org/show_bug.cgi?id=224967

platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt: Added.

7:43 PM Changeset in webkit [287527] by Diego Pino Garcia

2 edits in trunk/Source/WebCore

[GTK] Unreviewed build fix after r287519
https://bugs.webkit.org/show_bug.cgi?id=234802

layout/integration/InlineIteratorInlineBox.cpp:

(WebCore::InlineIterator::firstInlineBoxFor):
(WebCore::InlineIterator::firstRootInlineBoxFor):

6:22 PM Changeset in webkit [287526] by Diego Pino Garcia

2 edits in trunk/LayoutTests

[WPE] [Debug] Unreviewed test gardening, remove WebXR tests failures no longer crashing
https://bugs.webkit.org/show_bug.cgi?id=225379

platform/wpe/TestExpectations:

4:49 PM Changeset in webkit [287525] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Add ASSERT(middle >= left && middle < right) to TextUtil::breakWord
https://bugs.webkit.org/show_bug.cgi?id=234801

Reviewed by Antti Koivisto.

Before adding support for surrogate pairs, the implicit integral flooring guaranteed that
(left + right) / 2 always produced a middle point where left >= middle and middle < right.
With introducing surrogate pair support, the middle point may end up being equal to the right position.
(when the (left + right) / 2 falls right in the middle of a surrogate pair, we advance the index
to the _end_ of the pair (and later we adjust it by calling U16_SET_CP_START)).

In this patch, we revert this behavior back so that the middle point is always < right.
We also make sure that left/right/middle are all fall on cluster boundary by calling nextUserPerceivedCharacterIndex.
This patch is also in preparation for introducing grapheme cluster support.

layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::breakWord):

3:42 PM Changeset in webkit [287524] by graouts@webkit.org

6 edits in trunk

LayoutTests/imported/w3c:
[Web Animations] getKeyframes() should handle multiple 0% and 100% keyframes
https://bugs.webkit.org/show_bug.cgi?id=234799

Reviewed by Dean Jackson.

Mark a WPT progression.

web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:

Source/WebCore:
[Web Animations] getKeyframes() should handle multiple keyframes for the same offset
https://bugs.webkit.org/show_bug.cgi?id=234799

Reviewed by Dean Jackson.

A @keyframes rule may specify multiple keyframes for the same offset. We currently have support
for merging such keyframes into consolidated keyframes in Style::Resolver::keyframeStylesForAnimation()
but WPT shows that it's lacking since it doesn't account for animation-timing-function. Indeed, we
need to be careful not to merge keyframes with the same offset but a different timing function.

So we now use a std::pair<> using an offset and a timing function to compute de-duplicated keyframes.
But this showed an issue with StepsTimingFunction::operator== where we would not return true for
steps(1) and steps(1, end) since we only checked for equality for the optional keyword and did not
account for the default "end" value should the keyword not be explicit.

This ensured we correctly de-duplicated keyframes accounting for not only the offset but also
the timing function. But this then highlighted a different issue which was that our getKeyframes()
only ever expected one keyframe respectively for the 0% or 100% offsets when filling in implicit
values, which we'd just added support for in bug 234795.

So in KeyframeEffect::getKeyframes() we now compile a list of properties not explicitly specified
on any of the 0% or 100% keyframes and, as we process the first of a 0% or 100% keyframe, we set
the implicit properties.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getKeyframes):

platform/animation/TimingFunction.h:
style/StyleResolver.cpp:

(WebCore::Style::Resolver::keyframeStylesForAnimation):

1:37 PM Changeset in webkit [287523] by Alan Bujtas

2 edits in trunk/LayoutTests

[iOS] Rebaselining after r287519.

Unreviewed.

platform/ios/fast/table/table-continuation-outline-paint-crash-expected.txt:

12:19 PM Changeset in webkit [287522] by Wenson Hsieh

6 edits
1 add in trunk

[WebKit2] Camera continuity is disabled in richly editable content
https://bugs.webkit.org/show_bug.cgi?id=234773
rdar://46323417

Reviewed by Darin Adler.

Source/WebKit:

-[WKWebView validRequestorForSendType:returnType:] currently never returns a nonnull result when the given
send type is nil, because WebViewImpl::validRequestorForSendAndReturnTypes only sets isValidSendType to
anything other than false if sendType is nonnull. Instead of doing this, we should match legacy WebKit
behavior by treating the send type as "valid" if it's nil.

Test: NSResponderTests.ValidRequestorForReturnTypes

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::validRequestorForSendAndReturnTypes):

Source/WebKitLegacy/mac:

Drive-by fix: add a missing ALLOW_DEPRECATED_DECLARATIONS_END for the unbalanced BEGIN declaration.

WebView/WebHTMLView.mm:

(+[WebHTMLView _insertablePasteboardTypes]):

Tools:

Add an API test to verify that the result of -validRequestorForSendType:returnType: isn't always nil in the
case where there is no send type.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/NSResponderTests.mm: Added.

(TestWebKitAPI::TEST):

11:05 AM Changeset in webkit [287521] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Followup to r287494
https://bugs.webkit.org/show_bug.cgi?id=234747
rdar://85899879

Reviewed by Darin Adler.

Use auto instread of RefPtr when storing the result of enclosingImageElement() in a few places; this
method already returns a RefPtr.

html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateAttributes):
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

10:48 AM Changeset in webkit [287520] by Antti Koivisto

10 edits in trunk/Source/WebCore

[LFC][Integration] RenderBlockFlow::containsNonZeroBidiLevel should use iterator
https://bugs.webkit.org/show_bug.cgi?id=234796

Reviewed by Alan Bujtas.

Also rename Line::first/lastRun -> Line::first/lastLeafBox for consistency and accuracy.

editing/VisibleUnits.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks const):

layout/integration/InlineIteratorLine.cpp:

(WebCore::InlineIterator::Line::firstLeafBox const):
(WebCore::InlineIterator::Line::lastLeafBox const):
(WebCore::InlineIterator::Line::closestRunForLogicalLeftPosition const):
(WebCore::InlineIterator::Line::selectionState const):
(WebCore::InlineIterator::Line::firstSelectedBox const):
(WebCore::InlineIterator::Line::lastSelectedBox const):
(WebCore::InlineIterator::Line::firstRun const): Deleted.
(WebCore::InlineIterator::Line::lastRun const): Deleted.

layout/integration/InlineIteratorLine.h:
layout/integration/InlineIteratorLineLegacyPath.h:

(WebCore::InlineIterator::LineIteratorLegacyPath::firstLeafBox const):
(WebCore::InlineIterator::LineIteratorLegacyPath::lastLeafBox const):
(WebCore::InlineIterator::LineIteratorLegacyPath::firstRun const): Deleted.
(WebCore::InlineIterator::LineIteratorLegacyPath::lastRun const): Deleted.

layout/integration/InlineIteratorLineModernPath.h:

(WebCore::InlineIterator::LineIteratorModernPath::firstLeafBox const):
(WebCore::InlineIterator::LineIteratorModernPath::lastLeafBox const):
(WebCore::InlineIterator::LineIteratorModernPath::firstRun const): Deleted.
(WebCore::InlineIterator::LineIteratorModernPath::lastRun const): Deleted.

layout/integration/InlineIteratorLogicalOrderTraversal.h:

(WebCore::InlineIterator::leafBoxesInLogicalOrder):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::containsNonZeroBidiLevel const):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

style/InlineTextBoxStyle.cpp:

(WebCore::minLogicalTopForTextDecorationLine):
(WebCore::maxLogicalBottomForTextDecorationLine):

10:30 AM Changeset in webkit [287519] by Antti Koivisto

14 edits in trunk

[LFC][Integration] Support outlines
https://bugs.webkit.org/show_bug.cgi?id=234766

Reviewed by Alan Bujtas.

Source/WebCore:

Outlines should not require legacy line layout.

layout/integration/InlineIteratorInlineBox.cpp:

(WebCore::InlineIterator::firstInlineBoxFor):
(WebCore::InlineIterator::firstRootInlineBoxFor):

Add iterator support for getting inline boxes from renderer.

layout/integration/InlineIteratorInlineBox.h:
layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForRenderInlineChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

layout/integration/LayoutIntegrationCoverage.h:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::firstInlineBoxFor const):
(WebCore::LayoutIntegration::LineLayout::firstRootInlineBox const):
(WebCore::LayoutIntegration::LineLayout::paint):

Support outline painting.

layout/integration/LayoutIntegrationLineLayout.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):

Port to use iterator.

rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):

Port to use iterator.

LayoutTests:

fast/repaint/focus-ring-repaint-expected.txt:
platform/ios/fast/table/table-continuation-outline-paint-crash-expected.txt:
platform/mac/fast/table/table-continuation-outline-paint-crash-expected.txt:

9:59 AM Changeset in webkit [287518] by graouts@webkit.org

4 edits in trunk

[Web Animations] getKeyframes() should ensure that all properties are present on 0% and 100% keyframes
https://bugs.webkit.org/show_bug.cgi?id=234795

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark a WPT progressions.

web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:

Source/WebCore:

Keyframes at 0% and 100% may not explicitly specify properties animated on intermediate keyframes, so
in the case of such keyframes, we must ensure we output the non-animated value for properties not
explicitly specified on the keyframe style.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getKeyframes):

8:12 AM Changeset in webkit [287517] by graouts@webkit.org

6 edits in trunk

[Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule
https://bugs.webkit.org/show_bug.cgi?id=234793

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark a new WPT progression.

web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:

Source/WebCore:

If the keyframes for an animation result from a declarative source, let's not output any data if none of the properties
are animatable.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getKeyframes):

rendering/style/KeyframeList.cpp:

(WebCore::KeyframeList::containsAnimatableProperty const):

rendering/style/KeyframeList.h:

7:38 AM Changeset in webkit [287516] by commit-queue@webkit.org

7 edits in trunk/Source/JavaScriptCore

Remove unused AbstractMacroAssembler::repatchJumpToNop() function
https://bugs.webkit.org/show_bug.cgi?id=234777

Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-01-02
Reviewed by Yusuke Suzuki.

Remove the unused AbstractMacroAssembler::repatchJumpToNop() function,
along with the underlying relinkJumpToNop() functions on ISA-specific
assembler classes.

assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::relinkJumpToNop): Deleted.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::relinkJumpToNop): Deleted.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::repatchJumpToNop): Deleted.

assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::relinkJumpToNop): Deleted.

assembler/RISCV64Assembler.h:

(JSC::RISCV64Assembler::relinkJumpToNop): Deleted.

assembler/X86Assembler.h:

(JSC::X86Assembler::relinkJumpToNop): Deleted.

7:07 AM Changeset in webkit [287515] by Alan Bujtas

2 edits in trunk/Source/WebCore

InlineTextItems should never split inside surrogate pairs
https://bugs.webkit.org/show_bug.cgi?id=234791

Reviewed by Antti Koivisto.

This check was added (r285016) to handle the case if the start position in TextUtil::breakWord is
inside a surrogate pair. However we should never have surrogate pairs split across InlineTextItems.
This incorrect state was caused by the bogus "let's keep the first character on the current line" logic
-which could also lead to a visually broken rendering.
(Note that fast/text/word-break-letter-spacing-utf16-surrogates.html passes without the early return)

layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::breakWord):
(WebCore::Layout::TextUtil::firstUserPerceivedCharacterLength):

7:05 AM Changeset in webkit [287514] by Alan Bujtas

4 edits
2 adds in trunk

[LFC][IFC] Nested inline box continuation fails to omit margin/border/padding start/end values
https://bugs.webkit.org/show_bug.cgi?id=234789

Reviewed by Antti Koivisto.

Source/WebCore:

Nested inline boxes inside continuation do not have block parents. It's sufficient to check
for the continuation bits.

Test: fast/inline/unexpected-start-end-decoration-with-nested-continuation.html

layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateInlineBoxDimensions):

LayoutTests:

fast/inline/unexpected-start-end-decoration-with-nested-continuation-expected.html: Added.
fast/inline/unexpected-start-end-decoration-with-nested-continuation.html: Added.

2:32 AM Changeset in webkit [287513] by commit-queue@webkit.org

9 edits in trunk/Source/JavaScriptCore

[RISCV64] Make DFG, FTL, B3, WASM buildable on CPU(RISCV64)
https://bugs.webkit.org/show_bug.cgi?id=234775

Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-01-02
Reviewed by Yusuke Suzuki.

Enable building DFG, FTL, B3 and WASM subsystems on 64-bit RISC-V.
Necessary guards and missing bits are added to make things buildable,
but actual enabling of these features at build-time is left for later.
Even when enabled at build-time in the future, there'll likey be open
issues that will require disabling different features at run-time.

MacroAssemblerRISCV64::setCarry() no-op method is added for now. Carry
flag retrieval isn't exactly possible on RISC-V, so the uses of it will
have to be addressed some other way.

The patchpointScratchRegister value is defined for CPU(RISCV64). As
on ARM64, the value matches MacroAssemblerRISCV64::dataTempRegister.

In B3, we follow ARM64 in the pinned extended-offset-address use and
stack argument lowering.

in WASM, we can again mirror ARM64 around LLInt callee registers and
slots as well as executing the epilogue of a OSR-entry callee.

assembler/MacroAssembler.h: Provide lea64() for CPU(RISCV64) as well.
assembler/MacroAssemblerRISCV64.h:
b3/B3Common.cpp:

(JSC::B3::pinnedExtendedOffsetAddrRegister):

b3/air/AirLowerStackArgs.cpp:

(JSC::B3::Air::lowerStackArgs):

jit/GPRInfo.h:
wasm/WasmCallee.cpp:

(JSC::Wasm::LLIntCallee::calleeSaveRegisters):

wasm/WasmLLIntPlan.cpp:

(JSC::Wasm::LLIntPlan::didCompleteCompilation):

wasm/WasmOperations.cpp:

(JSC::Wasm::doOSREntry):

1:12 AM Changeset in webkit [287512] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

[RISCV64] Enable building LLInt WebAssembly via the riscv64 offlineasm backend
https://bugs.webkit.org/show_bug.cgi?id=234776

Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-01-02
Reviewed by Yusuke Suzuki.

Sprinkle RISCV64 conditions around WebAssembly.asm as appropriate.
For division, we can reuse the divi(s)/divq(s) instructions already
available in offlineasm. RISC-V additionally provides remainder
instructions, so the necessary offlineasm instructions are added
and used for RISCV64.

In the offlineasm riscv64 backend, the division and remainder
instruction handling is improved to properly cover signed and unsigned
variants. For other instructions used in LLint WebAssembly
implementation like left or right rotation, trailing- or leading-zero
counting, order-based floating-point comparison, load-reserved and
store-conditional operations, the riscv64WASMPlaceholder helper is used
to generate an ebreak instruction that will halt the program at runtime
but will not throw a build-time error. Proper implementations will be
provided once WebAssembly support on RISCV64 is taken up.

llint/WebAssembly.asm:
offlineasm/instructions.rb:
offlineasm/riscv64.rb:

1:07 AM Changeset in webkit [287511] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

[RISCV64] Get testmasm building for CPU(RISCV64)
https://bugs.webkit.org/show_bug.cgi?id=234774

Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-01-02
Reviewed by Yusuke Suzuki.

Add missing MacroAssemblerRISCV64 methods used in testmasm. Placeholders
are used for now, proper implementations will be introduced later.

In testmasm itself, we avoid testing the condition-flags register values
since, like on MIPS, that register isn't available on RISC-V.

assembler/MacroAssemblerRISCV64.h:
assembler/testmasm.cpp:

(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

12:20 AM Changeset in webkit [287510] by ysuzuki@apple.com

18 edits
74 adds
3 deletes in trunk

[JSC] Replace UDIS86 with Zydis
https://bugs.webkit.org/show_bug.cgi?id=234765

Reviewed by Michael Saboff.

Source/JavaScriptCore:

UDIS86 is not updated from 2014. Since it is missing relatively new SIMD opcodes,
we cannot disassemble these opcodes when implementing Wasm SIMD.
This patch replaces UDIS86 with Zydis, which is actively developed and used in
SpiderMonkey too. It is under MIT license.

This patch imports Zydis v3.2.1.

Import header and C files of Zydis and Zycore in a flattened manner.
Add directory names to the files (e.g. Zydis/Decoder.c => ZydisDecoder.c) to make it easy to build in JSC build.
Replace header includes from #include <Zydis/XXX.h> to #include "ZydisXXX.h".
Fix compile errors with our stricter compiler flags.
Remove Zycore API files and ZycoreArgParse.[hc] since they are not used.

We didn't add files to Sources.txt since unified builds do not support C files currently.

Source/WTF:

wtf/PlatformEnable.h:

Jan 1, 2022:

11:22 PM Changeset in webkit [287509] by graouts@webkit.org

8 edits in trunk

"animation" shorthand does not parse values in the right order
https://bugs.webkit.org/show_bug.cgi?id=234788

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark a new WPT progression.

web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt:

Source/WebCore:

The animation-name should be parsed last, not first.

css/CSSProperties.json:

LayoutTests:

Update the order in which animation-name is serialized in the "animation" shorthand
for some non-WPT tests.

fast/css/longhand-overrides-shorthand-prefixing-expected.txt:
fast/css/longhand-overrides-shorthand-prefixing.html:
fast/css/transform-inline-style-remove-expected.txt:

5:06 PM Changeset in webkit [287508] by Diego Pino Garcia

5 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening, update flakey tests expectations
https://bugs.webkit.org/show_bug.cgi?id=234760

Remove tests that have been constantly passing for the last 4000 revisions, as well as update state of tests
that have been constantly failing with a single state.

platform/gtk/TestExpectations:
platform/gtk/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt:
platform/gtk/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt:
platform/wpe/TestExpectations:

4:19 PM Changeset in webkit [287507] by Jean-Yves Avenard

11 edits in trunk/Source/WebCore

ScalableImageDecoder should be using SharedBuffer instead of DataSegment
https://bugs.webkit.org/show_bug.cgi?id=233441
rdar://problem/85854204

Reviewed by Darin Adler.

DataSegment should be a SharedBuffer's implementation details and not
be used outside SharedBuffer's code.
Historically, using the inner DataSegment was required as it was thread
safe while SharedBuffer wasn't: This is no longer the case.
SharedBuffer and DataSegment are semantically very similar, so this is
mostly a find/replace change.
Flattening the FragmentedSharedBuffer is still required as most decoders
require reading the raw bytes.

No change in observable behaviour.

platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::setSize):
(WebCore::ImageBackingStore::ImageBackingStore):

platform/image-decoders/ScalableImageDecoder.h:
platform/image-decoders/avif/AVIFImageReader.cpp:

(WebCore::AVIFImageReader::parseHeader):
(WebCore::AVIFImageReader::decodeFrame):

platform/image-decoders/avif/AVIFImageReader.h:
platform/image-decoders/bmp/BMPImageReader.h:

(WebCore::BMPImageReader::readUint16):
(WebCore::BMPImageReader::readUint32):
(WebCore::BMPImageReader::setData):

platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::setData):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):

platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp:

(WebCore::JPEG2000ImageDecoder::decode):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

4:09 PM Changeset in webkit [287506] by Jean-Yves Avenard

4 edits in trunk

make SharedBuffer::copy() return a contiguous SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=234622
rdar://problem/86829527

Reviewed by Darin Adler.

Source/WebCore:

make SharedBuffer::copy() return a contiguous SharedBuffer

API tests added.

platform/SharedBuffer.cpp:

(WebCore::FragmentedSharedBuffer::copy const):

Tools:

TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

3:06 PM Changeset in webkit [287505] by Wenson Hsieh

5 edits in trunk

Modal containers are incorrectly detected in navigation elements and fixed document elements
https://bugs.webkit.org/show_bug.cgi?id=234669
rdar://87030613

Reviewed by Darin Adler.

Source/WebCore:

Avoid false positives when detecting modal containers in the following scenarios:

Fixed-position document elements that contain the search term.
Text that contains the search term inside fixed-position navigation elements.

Additionally, ensure that we unhide the current modal container in the event of a false positive where we find
no element that fulfills the criteria for being a classifiable control.

Tests: ModalContainerObservation.IgnoreFixedDocumentElement

ModalContainerObservation.IgnoreNavigationElements
ModalContainerObservation.ShowModalContainerAfterFalsePositive

page/ModalContainerObserver.cpp:

(WebCore::accessibilityRole):

Move this static helper function farther up this source file, so that we can use it inside
updateModalContainerIfNeeded().

(WebCore::isInsideNavigationElement):
(WebCore::ModalContainerObserver::updateModalContainerIfNeeded):
(WebCore::ModalContainerPolicyDecisionScope::ModalContainerPolicyDecisionScope):
(WebCore::ModalContainerPolicyDecisionScope::~ModalContainerPolicyDecisionScope):
(WebCore::ModalContainerPolicyDecisionScope::continueHidingModalContainerAfterScope):
(WebCore::ModalContainerPolicyDecisionScope::document const):

Add a RAII helper object to ensure that the modal container is revealed at the end of the modal container policy
decision scope, unless continueHidingModalContainerAfterScope() is invoked. Since this class contains a
WeakPtr<Document> already, we can replace the WeakPtr<Document> we're currently plumbing through each of the
async callbacks with only the ModalContainerPolicyDecisionScope, and just grab the document (or null if it was
destroyed) from the scope object.

This helper object allows us to avoid sprinkling ad-hoc calls to revealModalContainer() when exiting modal
container classification codepaths.

(WebCore::ModalContainerObserver::collectClickableElementsTimerFired):

page/ModalContainerObserver.h:

Tools:

Add several new API tests to exercise the changes.

TestWebKitAPI/Tests/WebKitCocoa/ModalContainerObservation.mm:

(-[ModalContainerWebView initWithFrame:configuration:]):
(-[ModalContainerWebView loadHTML:]):
(-[ModalContainerWebView _webView:decidePolicyForModalContainer:decisionHandler:]):
(TestWebKitAPI::TEST):

2:54 PM Changeset in webkit [287504] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][IFC] Unexpected line break with leading collapsed whitespace
https://bugs.webkit.org/show_bug.cgi?id=234786

Reviewed by Antti Koivisto.

Source/WebCore:

We use Line::hasContent to decide whether an overflowing content should be wrapped to the next line.
Line is considered empty unless it has at least one content-type run.

Test: fast/inline/unexpected-line-break-on-empty-content.html

layout/formattingContexts/inline/InlineLine.h:

(WebCore::Layout::Line::hasContent const):

LayoutTests:

fast/inline/unexpected-line-break-on-empty-content-expected.html: Added.
fast/inline/unexpected-line-break-on-empty-content.html: Added.

1:03 PM Changeset in webkit [287503] by Wenson Hsieh

2 edits in trunk/Tools

[Cocoa] Simplify some FontAttributes API tests
https://bugs.webkit.org/show_bug.cgi?id=234770

Reviewed by Darin Adler.

Simplify some of the logic around FontAttributes.FontAttributesAfterChangingSelection:

Instead of defining PlatformColor/PlatformFont, use CocoaColor/CocoaFont from WebCore.
Remove the Nullity flag in ShadowExpectation and ColorExpectation (and use std::optional instead to

indicate that the shadow or font attribute should be null).

Change a several rvalue references to be plain values instead (when passinng expectation structs that only

contain a handful of scalar values).

TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:

(TestWebKitAPI::checkColor):
(TestWebKitAPI::checkShadow):
(TestWebKitAPI::checkFont):
(TestWebKitAPI::TEST):
(TestWebKitAPI::ColorExpectation::ColorExpectation): Deleted.
(TestWebKitAPI::ShadowExpectation::ShadowExpectation): Deleted.

8:25 AM Changeset in webkit [287502] by jeffm@apple.com

22 edits in trunk

Update user-visible copyright strings to include 2022
https://bugs.webkit.org/show_bug.cgi?id=234263

Reviewed by Anders Carlsson.

Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:

Source/JavaScriptCore:

Info.plist:

Source/WebCore:

Info.plist:

Source/WebGPU:

Info.plist:

Source/WebKit:

GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist:
GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:
Info.plist:
NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist:
NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist:
WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist:
WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist:
WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

Source/WebKitLegacy/mac:

Info.plist:

WebKitLibraries:

win/tools/scripts/COPYRIGHT-END-YEAR:

7:34 AM Changeset in webkit [287501] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Simple RTL content triggers redundant horizontal positioning
https://bugs.webkit.org/show_bug.cgi?id=234772

Reviewed by Antti Koivisto.

RTL content with inline boxes require a second pass horizontal positioning.
Currently we trigger this second pass even when the content does not have any inline box.
(e.g <div>content<span>with inline box</span></div> <div>content with no inline box</div>)

layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): !0 parentDisplayBoxNodeIndex means non-root inline box.
(WebCore::Layout::DisplayBoxTree::hasInlineBox const): Deleted.

6:55 AM Changeset in webkit [287500] by Alan Bujtas

6 edits
2 adds in trunk

[LFC][IFC] Incorrect word-spacing gaps between RTL runs
https://bugs.webkit.org/show_bug.cgi?id=234771

Reviewed by Antti Koivisto.

Source/WebCore:

"word-spacing" acts as a margin for word separator type of runs.
In this patch we take this margin into account the same way we do for atomic inline level boxes with margins.

Test: fast/text/word-spacing-rtl.html

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::Run::Run):

layout/formattingContexts/inline/InlineLine.h:

(WebCore::Layout::Line::Run::isText const):
(WebCore::Layout::Line::Run::isWordSeparator const):

layout/formattingContexts/inline/display/InlineDisplayBox.h:

(WebCore::InlineDisplay::Box::isText const):
(WebCore::InlineDisplay::Box::isWordSeparator const):
(WebCore::InlineDisplay::Box::isNonRootInlineLevelBox const):
(WebCore::InlineDisplay::Box::type const): Deleted.

layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

LayoutTests:

fast/text/word-spacing-rtl-expected.html: Added.
fast/text/word-spacing-rtl.html: Added.

6:15 AM Changeset in webkit [287499] by ntim@apple.com

42 edits
1 copy
5 moves
68 adds in trunk/LayoutTests

Re-import css/css-writing-modes WPT
https://bugs.webkit.org/show_bug.cgi?id=234764

Reviewed by Dean Jackson.

Upstream commit: https://github.com/web-platform-tests/wpt/commit/e433ff38f5230f3fec9c6fd434b942c7bffbfc67

LayoutTests/imported/w3c:

resources/resource-files.json:
web-platform-tests/css/css-writing-modes/astral-bidi/adlam-anti-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/astral-bidi/adlam-anti-ref-expected.html.
web-platform-tests/css/css-writing-modes/astral-bidi/cypriot-anti-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/astral-bidi/cypriot-anti-ref-expected.html.
web-platform-tests/css/css-writing-modes/astral-bidi/w3c-import.log:
web-platform-tests/css/css-writing-modes/bidi-dynamic-iframe-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/bidi-dynamic-iframe-001.html: Added.
web-platform-tests/css/css-writing-modes/bidi-plaintext-br-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/bidi-plaintext-br-001.html: Added.
web-platform-tests/css/css-writing-modes/block-flow-direction-slr-062.xht:
web-platform-tests/css/css-writing-modes/block-flow-direction-srl-061.xht:
web-platform-tests/css/css-writing-modes/block-flow-direction-vlr-022.xht:
web-platform-tests/css/css-writing-modes/block-flow-direction-vrl-021.xht:
web-platform-tests/css/css-writing-modes/crashtests/orthogonal-percent-height-multicol-crash.html: Added.
web-platform-tests/css/css-writing-modes/crashtests/orthogonal-scroll-percent-height-crash.html: Added.
web-platform-tests/css/css-writing-modes/crashtests/orthogonal-table-in-flex-crash.html: Added.
web-platform-tests/css/css-writing-modes/crashtests/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/astral-bidi/w3c-import.log.
web-platform-tests/css/css-writing-modes/crashtests/wm-body-propagation-crash.html: Added.
web-platform-tests/css/css-writing-modes/direction-propagation-body-contain-root-expected.html: Added.
web-platform-tests/css/css-writing-modes/direction-propagation-body-contain-root.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-001.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-002-expected.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-rtl-002.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-001.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-002-expected.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-002.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-001.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-002-expected.html: Added.
web-platform-tests/css/css-writing-modes/dynamic-offset-vrl-rtl-002.html: Added.
web-platform-tests/css/css-writing-modes/full-width-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/full-width-001-expected.html.
web-platform-tests/css/css-writing-modes/full-width-002-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/full-width-002-expected.html.
web-platform-tests/css/css-writing-modes/full-width-003-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/full-width-003-expected.html.
web-platform-tests/css/css-writing-modes/inline-box-orthogonal-child-with-margins-expected.html:
web-platform-tests/css/css-writing-modes/inline-box-orthogonal-child-with-margins.html:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-003.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-005.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-007.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-009.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-011.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-013.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-021.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vlr-023.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vrl-002.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vrl-004.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vrl-006.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vrl-008.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vrl-010.xht:
web-platform-tests/css/css-writing-modes/line-box-height-vrl-012.xht:
web-platform-tests/css/css-writing-modes/logical-physical-mapping-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/logical-physical-mapping-001.html: Added.
web-platform-tests/css/css-writing-modes/padding-percent-orthogonal-dynamic-expected.txt: Added.
web-platform-tests/css/css-writing-modes/padding-percent-orthogonal-dynamic.html: Added.
web-platform-tests/css/css-writing-modes/replaced-content-image-004-expected.html: Added.
web-platform-tests/css/css-writing-modes/replaced-content-image-004.html: Added.
web-platform-tests/css/css-writing-modes/sizing-orthog-vrl-in-htb-013-expected.xht:
web-platform-tests/css/css-writing-modes/sizing-orthog-vrl-in-htb-013.xht:
web-platform-tests/css/css-writing-modes/slr-alongside-vlr-floats-expected.html:
web-platform-tests/css/css-writing-modes/slr-alongside-vlr-floats.html:
web-platform-tests/css/css-writing-modes/srl-alongside-vrl-floats-expected.html:
web-platform-tests/css/css-writing-modes/srl-alongside-vrl-floats.html:
web-platform-tests/css/css-writing-modes/support/WidthTest-Regular.otf: Added.
web-platform-tests/css/css-writing-modes/support/tcy.css: Added.

(.tcy):
(.fake-tcy):

web-platform-tests/css/css-writing-modes/support/w3c-import.log:
web-platform-tests/css/css-writing-modes/support/width-test.css: Added.

(@font-face):
(.test):

web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001a-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001a.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-001.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-002-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-002.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-003-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-003.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-004-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-004.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005a-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-005a.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006a-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-006a.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-007-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-combine-upright-compression-007.html: Added.
web-platform-tests/css/css-writing-modes/text-orientation-upright-directionality-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-orientation-upright-directionality-001.html: Added.
web-platform-tests/css/css-writing-modes/text-shadow-orientation-upright-001-expected.html: Added.
web-platform-tests/css/css-writing-modes/text-shadow-orientation-upright-001.html: Added.
web-platform-tests/css/css-writing-modes/vlr-text-orientation-sideways-alongside-vlr-floats-expected.html:
web-platform-tests/css/css-writing-modes/vlr-text-orientation-sideways-alongside-vlr-floats.html:
web-platform-tests/css/css-writing-modes/vrl-inline-paint-invalidation-expected.html: Added.
web-platform-tests/css/css-writing-modes/vrl-inline-paint-invalidation.html: Added.
web-platform-tests/css/css-writing-modes/vrl-text-orientation-sideways-alongside-vrl-floats-expected.html:
web-platform-tests/css/css-writing-modes/vrl-text-orientation-sideways-alongside-vrl-floats.html:
web-platform-tests/css/css-writing-modes/w3c-import.log:
web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-001-expected.txt: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-001.html: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-002-expected.txt: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-body-computed-direction-002.html: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-body-contain-root-expected.html: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-body-contain-root.html: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-001.html:
web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-002-expected.html:
web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-002.html:
web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-003-expected.html: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-003.html: Added.
web-platform-tests/css/css-writing-modes/wm-propagation-svg-root-scrollbar.svg:

Context Navigation

Timeline

Jan 2, 2022:

Jan 1, 2022:

Download in other formats: