⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 5, 2022:

9:51 PM Changeset in webkit [287674] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Text-decoration color not changing back after input blur with outline removed
​https://bugs.webkit.org/show_bug.cgi?id=234800
<rdar://problem/87145636>

Reviewed by Antti Koivisto.

Source/WebCore:

This patch fixes the case when a decoration type of style value changes on the input
element (e.g. text-decoration-color) and the inner renderer does not get notified through the usual styleDidChange
flow because the property is non-inherited.

Test: fast/forms/dynamic-text-decoration-change.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

LayoutTests:

  • fast/forms/dynamic-text-decoration-change-expected.html: Added.
  • fast/forms/dynamic-text-decoration-change.html: Added.
8:40 PM Changeset in webkit [287673] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

[GPU Process] Small ImageBuffers cause the web process to crash
​https://bugs.webkit.org/show_bug.cgi?id=232470
<rdar://problem/84626560>

Reviewed by Tim Horton.

Source/WebKit:

The problem is when the (floating point) size < 1x1, but the size*resolution is >= 1x1.
In this situation, calculateSafeBackendSize() is correctly determining that this
isn't a zero-sized ImageBuffer, but when we go to actually pass the size to the GPU
process, we call this:

IntSize logicalSize() const override { return IntSize(m_parameters.logicalSize); }

So, the logical size gets truncated down to 0, and then the GPU process fails to allocate
the ImageBuffer, and then the web process blocks on the GPU process indefinitely, and then
eventually times out and then crashes. I'm going to deal with that last step (the crash
itself) in a secondary patch - if the web process doesn't hear from the GPU process, it
shouldn't crash.

This patch simply exposes a floatLogicalSize() function on ImageBuffer, so we can get
the full-fidelity logical size to pass that to the GPU process.

This patch is just enough to stop WebKit from crashing. I'm going to continue looking into this bug in
​https://bugs.webkit.org/show_bug.cgi?id=225377.

Test: compositing/device-pixel-image-buffer-hidpi.html

  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):

LayoutTests:

  • compositing/device-pixel-image-buffer-hidpi-expected.html: Added.
  • compositing/device-pixel-image-buffer-hidpi.html: Added.
7:54 PM Changeset in webkit [287672] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

border radii may have missing values
​https://bugs.webkit.org/show_bug.cgi?id=234866

Patch by Brandon Stewart <Brandon> on 2022-01-05
Reviewed by Antti Koivisto.

Add test to verify behavior of CSS border radii.

  • fast/css/border-radius-invalid-pair-expected.txt: Added.
  • fast/css/border-radius-invalid-pair.html: Added.
7:08 PM Changeset in webkit [287671] by Wenson Hsieh
  • 6 edits
    1 add in trunk

Modal container observer should detect and suppress elements that prevent user interaction
​https://bugs.webkit.org/show_bug.cgi?id=234695

Reviewed by Tim Horton.

Source/WebCore:

Add support for additionally detecting and hiding viewport-constrained elements whose sole (apparent) purpose
is to prevent the user from interacting with the rest of the page, after suppressing a detected modal
container. See comments below for more details.

Test: ModalContainerObservation.HideUserInteractionBlockingElement

  • page/ModalContainerObserver.cpp:

(WebCore::ModalContainerObserver::setContainer):

When setting (and hiding) a detected modal container, queue an internal task to try and identify an element
underneath the modal container that may be preventing user interaction with the rest of the page (note that this
must be queued as an async task because it may trigger layout, unlike updateModalContainerIfNeeded). See below
for more information.

(WebCore::ModalContainerObserver::hideUserInteractionBlockingElementIfNeeded):

Implement a simple heuristic to detect elements that block user interaction after the modal container has been
hidden. To do this, we hit-test five locations relative to the absolute rect for fixed-position elements: one
hit-test in the center of the rect, and 4 more near all of the corners (shifted by 1px towards the center).

If all 5 hit-tests find the same viewport-constrained element with no rendered children that isn't also the
document or body element, we flag it as the m_userInteractionBlockingElement and hide it during style
adjustment in the same way as the modal container (see below).

(WebCore::ModalContainerObserver::revealModalContainer):

  • page/ModalContainerObserver.h:

(WebCore::ModalContainerObserver::shouldHide const):

Add m_userInteractionBlockingElement and hide both the modal container as well as this new element during
style adjustment.

Tools:

Add an API test (as well as a new test page) to exercise the fix.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/modal-container-with-overlay.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/ModalContainerObservation.mm:

(TestWebKitAPI::TEST):

6:57 PM Changeset in webkit [287670] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Layers: add reference page button
​https://bugs.webkit.org/show_bug.cgi?id=234901

Reviewed by Patrick Angle.

  • UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView.prototype.initialLayout):

  • UserInterface/Views/Layers3DContentView.css:

(.content-view.layers-3d .reference-page-link-container): Added.

6:55 PM Changeset in webkit [287669] by graouts@webkit.org
  • 5 edits in trunk

Refactor computed style code for transition-property and the transition shorthand
​https://bugs.webkit.org/show_bug.cgi?id=234872

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaseline some test output.

  • web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt:
  • web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt:

Source/WebCore:

There's no reason for the "transition-property" and "transition" properties to be
handled any differently to any other "transition-" property or the "animation"
shorthand.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::animationShorthandValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
(WebCore::transitionPropertyValue): Deleted.

6:51 PM Changeset in webkit [287668] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION(287556): Domain name not shown in Activity Monitor
​https://bugs.webkit.org/show_bug.cgi?id=234903

Reviewed by Brent Fulgham.

After r287556, domain names are no longer shown in Activity Monitor. The Networking process is responsible for setting
process information on behalf of the WebContent process. Before r287556, this worked because a connection to the associated
mach service was established before entering the sandbox. After r287556 we explicitly need to allow access to the service,
since the sandbox has been applied when process information is set. In practice, access to the service was already allowed
before, since an open connection to the service was established before entering the sandbox.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
6:28 PM Changeset in webkit [287667] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[ Monterey Debug arm64 ] ASSERTION FAILED: result == &worker ./workers/service/server/SWServer.cpp(837) : void WebCore::SWServer::workerContextTerminated(WebCore::SWServerWorker &)
​https://bugs.webkit.org/show_bug.cgi?id=233219
<rdar://problem/85478756>

Reviewed by Darin Adler.

The crash would occur when we get notified by the service worker process that a given service worker
was terminated right after we've determined that we no longer needed a given service worker process
and called markAllWorkersForRegistrableDomainAsTerminated(). This race would cause
SWServer::workerContextTerminated() to get called twice for the same worker. During the second call,
we would retrieve a null worker from the HashMap and hit the assertion. I updated the call to ignore
the call to workerContextTerminated() if the worker was already removed from the HashMap and added
an assertion to make sure we've already marked the service worker as "not running" in this case.

No new tests, covered by existing API test that is flakily crashing in debug.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::workerContextTerminated):

6:16 PM Changeset in webkit [287666] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows and Linux builds
​https://bugs.webkit.org/show_bug.cgi?id=234405

  • platform/ThemeTypes.h:

Missing semicolon.

6:12 PM Changeset in webkit [287665] by wilander@apple.com
  • 2 edits in trunk/Source/WTF

Change version number for HAVE_RSA_PSS_OID
​https://bugs.webkit.org/show_bug.cgi?id=234904
<rdar://86646280>

Reviewed by Alex Christensen.

  • wtf/PlatformHave.h:
6:09 PM Changeset in webkit [287664] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS][WP] Allow syscall used on process launch
​https://bugs.webkit.org/show_bug.cgi?id=234898
<rdar://86914492>

Reviewed by Brent Fulgham.

Allow syscall used on WebContent process launch on iOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
5:39 PM Changeset in webkit [287663] by Megan Gardner
  • 24 edits
    3 adds
    4 deletes in trunk

Remove unneeded webkit specific CSS attribute for Image Control Menu.
​https://bugs.webkit.org/show_bug.cgi?id=234405

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/images/mac/image-controls-basic.html

We do not actually need a specific CSS attribute to achieve the image control menu,
so we should remove it to keep WebKit specific clutter out of our CSS implementation
and we should keep track of the presence of the image control menu fully internally.
Doing this also exposed several issues, including the fact that we had already run out
of space for the storing of the ControlPart in RenderStyle. Also added a check to make
sure that will not happen again.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/parser/CSSParserIdioms.cpp:

(WebCore::isValueAllowedInMode):

  • dom/mac/ImageControlsMac.cpp:

(WebCore::ImageControlsMac::isInsideImageControls):

  • dom/mac/ImageControlsMac.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::setAttachmentElement):
(WebCore::HTMLImageElement::updateImageControls):

  • html/HTMLImageElement.h:
  • html/shadow/mac/imageControlsMac.css:

(div#image-controls button#image-controls-button):

  • platform/ThemeTypes.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::nodeForImageData const):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::autoAppearanceForElement const):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::isImageControl const):

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isImageControl const):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setAppearance):
(WebCore::RenderStyle::setEffectiveAppearance):

  • rendering/style/StyleRareNonInheritedData.h:
  • testing/Internals.cpp:

(WebCore::Internals::hasImageControls const):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

We need to move this test to be a mac specific one, as it now has mac specific
test harnessing (using hasImageControls) and it is testing a feature that is only on mac.
Also changed the test to be resistent to the async nature of adding
the shadow dom elements, and checking the shadow dom directly rather than the resulting layout,
which is prone to pixel errors.

  • TestExpectations:
  • fast/images/image-controls-basic-expected.txt:
  • fast/images/image-controls-basic.html: Removed.
  • fast/images/mac/image-controls-basic-expected.txt: Added.
  • fast/images/mac/image-controls-basic.html: Added.
  • platform/mac-catalina/fast/images/image-controls-basic-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/fast/images/image-controls-basic-expected.txt: Removed.
5:21 PM Changeset in webkit [287662] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[selectors] :focus-visible not matching on accessKey focus after focusing something via mouse
​https://bugs.webkit.org/show_bug.cgi?id=234077

Unreviewed test gardening.

  • platform/ios/TestExpectations: Disable test for iOS since it relies upon mouse events.
5:06 PM Changeset in webkit [287661] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: reference page button is not vertically aligned with Audit version text
​https://bugs.webkit.org/show_bug.cgi?id=234900

Reviewed by Patrick Angle.

  • UserInterface/Views/AuditNavigationSidebarPanel.css:

(.content-view.tab.audit .content-view .reference-page-link-container):

4:49 PM Changeset in webkit [287660] by Devin Rousso
  • 2 edits in trunk/Source/WebKit

REGRESSION(r285521): errors provided to ApplePaySession.prototype.completeCouponCodeChange are ignored
​https://bugs.webkit.org/show_bug.cgi?id=234893
<rdar://problem/86780827>

Reviewed by Tim Horton.

  • Platform/cocoa/PaymentAuthorizationPresenter.mm:

(WebKit::PaymentAuthorizationPresenter::completeCouponCodeChange):
Make sure to actually set the errors of the PKPaymentRequestCouponCodeUpdate using the
errors inside ApplePayShippingMethodUpdate. This was accidentally removed in r285521.

4:25 PM Changeset in webkit [287659] by Jonathan Bedard
  • 2 edits in trunk

[EWS] Add Commit Queue and EWS GitHub usernames
​https://bugs.webkit.org/show_bug.cgi?id=234905
<rdar://problem/87169628>

Reviewed by Ryan Haddad.

  • metadata/contributors.json:

Canonical link: ​https://commits.webkit.org/245756@main

3:55 PM Changeset in webkit [287658] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

REGRESSION (r287609?): imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=234906

Unreviewed test gardening.

3:48 PM Changeset in webkit [287657] by Chris Dumez
  • 3 edits in trunk/LayoutTests

[ MacOS EWS ] imported/w3c/web-platform-tests/html/dom/idlharness.https.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=229831
<rdar://problem/82694768>

Unreviewed, rebaseline test and unskip.

  • platform/mac-wk2/TestExpectations:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
3:44 PM Changeset in webkit [287656] by Chris Dumez
  • 3 edits in trunk/LayoutTests

[ iOS ] imported/w3c/web-platform-tests/html/dom/idlharness.https.html is flaky failing after rebaselining
​https://bugs.webkit.org/show_bug.cgi?id=230407
<rdar://problem/83242343>

Unreviewed, rebaseline test on iOS and unskip it.

  • platform/ios-wk2/TestExpectations:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
3:35 PM Changeset in webkit [287655] by Chris Dumez
  • 5 edits in trunk/LayoutTests

[ iOS Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=231030
<rdar://problem/83727147>

Unreviewed, skip test in debug since it is slow and may flakily time out otherwise.

  • TestExpectations:
  • platform/glib/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk1/TestExpectations:
3:21 PM Changeset in webkit [287654] by Russell Epstein
  • 7 edits in branches/safari-612-branch/Source/WebCore

Cherry-pick r287110. rdar://problem/87124750

Clean-up: Adopt Page::forEachDocument in some missed spots
​https://bugs.webkit.org/show_bug.cgi?id=234324
<rdar://problem/85443831>

Reviewed by Darin Adler.

Switch manual loops to our 'forEachDocument' style in a few places that were missed
in earlier refactoring.

No change in behavior.

  • history/BackForwardCache.cpp: (WebCore::setBackForwardCacheState)
  • page/EventHandler.cpp: (WebCore::removeDraggedContentDocumentMarkersFromAllFramesInPage):
  • page/Frame.cpp: (WebCore::Frame::orientationChanged):
  • page/Page.cpp: (WebCore::Page::~Page): (WebCore::Page::forEachDocumentFromMainFrame): Added. (WebCore::Page::forEachDocument): Use new method. (WebCore::Page::forEachFrameFromMainFrame): Added. (WebCore::Page::windowScreenDidChange): (WebCore::Page::userAgentChanged):
  • page/ios/FrameIOS.mm: (WebCore::Frame::dispatchPageHideEventBeforePause): (WebCore::Frame::dispatchPageShowEventBeforeResume):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:02 PM Changeset in webkit [287653] by timothy_horton@apple.com
  • 10 edits in trunk/Source

Move more SDK checks to linkedOnOrAfter()
​https://bugs.webkit.org/show_bug.cgi?id=234875

Reviewed by Sam Weinig.

Source/WebCore:

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):

  • platform/Timer.cpp:

(WebCore::shouldSuppressThreadSafetyCheck):

  • platform/cocoa/VersionChecks.h:

Source/WebKit:

  • Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCSSOMViewScrollingAPIEnabled):

Source/WebKitLegacy/mac:

  • WebView/WebPreferencesDefaultValues.mm:

(WebKit::defaultJavaScriptCanOpenWindowsAutomatically):

  • WebView/WebView.mm:

(needsLaBanquePostaleQuirks):

1:58 PM Changeset in webkit [287652] by Kyle Piddington
  • 138 edits
    5 adds in trunk/Source/ThirdParty/ANGLE

Roll ANGLE to aabfe8747d 12-17-2021
​https://bugs.webkit.org/show_bug.cgi?id=234523

Reviewed by Kenneth Russell.

The changelog has been removed to improve readability.
The following ANGLE commits were merged:

aabfe8747 Metal: Use the context device to Texture::resize
34ea81111 Reland "Vulkan: Don't expose MSRTT on SwiftShader"
624e3c3d5 Fix dangerous use of AutoObjCPtr after ownership identity change
4a148e9d9 Revert "Vulkan: Suppress VUID-vkCmdDraw-blendEnable"
ede0b8b71 Avoid ANGLE_MTL_AUTORELEASE inside ASSERT, it leaks on Release
cb4f441c8 Roll vulkan-deps from 39f3a18bdfbe to 5568048d205e (8 revisions)
2f78b48db Roll Chromium from 14ca75d254a5 to 81decb7250e1 (191 revisions)
001221f0e Metal: upstream fix from WebKit for texture leak.
dca434bdc Roll Chromium from 3f6c88f5581a to 14ca75d254a5 (401 revisions)
b9f2d9cc1 Use text expectations to skip a test
6c894e829 Vulkan: Replace BufferVk::getBufferAndOffset() with getBuffer()
f2736f6dc Tests: Add My Talking Tom Friends trace.
a93a3930b Vulkan: Track enabled in VertexArray
83a670ab0 Vulkan: Implement BufferPool using VMA's virtual allocator
836797166 Vulkan: Dirty vertex buffers if default attrib values changed
543f5750f (origin/chromium/4771) Vulkan: Disable protected memory for ARM
c7446ac42 Add support for GL_MESA_framebuffer_flip_y 1/*
60383b41e Tests: Add Dota Underlords trace.
f26687a03 Tests: Add My Talking Tom 2 trace.
438de17ee Roll vulkan-deps from a8221eed5970 to 39f3a18bdfbe (5 revisions)
e7413adff system_utils_posix: Check for SEGV_MAPERR si_code.
6e5fd8165 Support more ImageLayout in ConvertImageLayoutToGLImageLayout
b26bb13ab Metal: Remove references to xfbActiveUnpaused uniform
bb5bab031 Roll Chromium from 2dae07eeb163 to 3f6c88f5581a (414 revisions)
c4d434b91 Metal: Enable OES_fbo_render_mipmap
670679918 Metal: Fix Webkit warnings in ANGLE build
bda493258 Add guards for 64 bit types on 32bit systems
e7c9dbb88 Skip SimpleStateChangeTestES3.OutOfBoundsByteAttribute on Pixel4 GLES
89e11878b Vulkan: Fix the UAF issue with BufferData
ee1d3cf74 Metal: Integrate Metal Binary Shader generation
3e7e2758f Metal: Fix macOS ANGLE build on Catalina (10.15) SDK
05a44dd24 Vulkan: Set content undefined on eglSwapBuffers
26fa0fe68 Tests: Add Asphalt 9 trace
5275f487e Vulkan: Disable async command queue with Vulkan SCBs
feb599ad8 Invalidate EGL handles during eglTerminate
32e23bb9d Expand WebGLCompressedTextureAvailabilityTest
d6b9a2597 end2end_tests: Add SwS + AsyncQueue testing.
a0eb6146c Update warning message for invalid include
cac81f077 Return full error info when opening a library with dlopen
90c3038e5 Vulkan: Fix desc set updates with Vulkan SCBs
8419f4fcd Roll vulkan-deps from c03890076954 to a8221eed5970 (2 revisions)
db367bd71 Roll Chromium from 0c0a3654694f to 2dae07eeb163 (450 revisions)
bfc7f09ae Revert "Upgrade restricted traces to new trace format."
800c6971c Modified buffer fallback format to smaller storage format
709d87278 Revert "Trace Tests: Remove auto-generated code."
3da54250b Skip MultithreadingTest.MultiContextDrawWithSwapBuffers
7f1a0f89b Switch to non-deprecated bbagent, remove defunct experiments.
9d49d8438 Add WebGLCompressedTextureAvailabilityTest

1:58 PM Changeset in webkit [287651] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Fix the build

  • Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebWheelEvent):

1:44 PM Changeset in webkit [287650] by mark.lam@apple.com
  • 9 edits in branches/safari-612-branch/Source/JavaScriptCore

Cherry-pick r287421. rdar://problem/84260429

2021-12-23 Mark Lam <​mark.lam@apple.com>

Make DeferredWorkTimer::addPendingWork() return a Ticket.
​https://bugs.webkit.org/show_bug.cgi?id=234628
rdar://84260429

Reviewed by Yusuke Suzuki.

  1. Make Ticket a unique token instead of the JSObject* target object. The Ticket is now a pointer to the TicketData in the pending work list.
  1. Instead of taking a Ticket argument, DeferredWorkTimer::addPendingWork() now takes a JSObject* target argument explicitly, and returns the Ticket for the added TicketData instead.

All the relevant DeferredWorkTimer APIS already take a Ticket as an argument.
This ensures that addPendingWork() is called before we start doing work with
these APIs (especially scheduleWorkSoon()).

  1. Previously, addPendingWork() will only save one instance of TicketData for a given JSObject* key. With this patch, we'll register a new TicketData instance for every call to addPendingWork(), and return a unique Ticket for it.

This is needed because it may be possible for 2 different clients to call
addPendingWork() and scheduleWorkSoon() with the same target JSObject* but with
different sets of dependencies.

Secondly, even is the both sets of dependencies are identical, a client may
call addPendingWork() and scheduleWorkSoon() with the same JSObject* target
more than once because it intended to schedule more than 1 task to run.

Note that DeferredWorkTimer::doWork() consumes the corresponding TicketData
(i.e. removes it from the m_pendingTickets list) for each task as it is run.
To ensure that the dependencies for each task is protected, we'll either need
to ref count the TicketData for the same target object (and hold off on removing
it from the list), or we'll need to register a different TicketData instance
for each task. Ref counting can solve the second issue above, but does not
solve the first. So, this patch goes with the more generic solution to allow
each task to have its own TicketData instance (and, its own unique Ticket).

  1. Previously, if the client cancels pending work, we would remove the TicketData immediately from the m_pendingTickets list. This opens up an opportunity for the same TicketData memory to be re-allocated by another client. This, in turn, would make the Ticket token not unique and potentially allow a cancelled ticket to be reused before DeferredWorkTimer::doWork() is called.

This patch changes DeferredWorkTimer::cancelPendingWork() to only clear the
contents of the TicketData instead. TicketData::scriptExecutionOwner being
null is used as an indication that the ticket has been cancelled. Since the
TicketData itself is not "freed" yet, all TicketData will remain unique until
DeferredWorkTimer::doWork().

Consequently, DeferredWorkTimer::doWork() will now check for cancelled tickets
and remove them from the m_pendingTickets list.

  1. JSFinalizationRegistry was previously calling DeferredWorkTimer::hasPendingWork() to check if it has already scheduled a task, so as not to reschedule again until after the previously scheduled task has been run. This does not play nice with the new Ticket API, because this hasPendingWork() check needs to be done before calling addPendingWork(), and hence, the Ticket is not available yet.

Fortunately, JSFinalizationRegistry should know if it has already scheduled
a task itself. This patch adds a m_hasAlreadyScheduledWork flag to
JSFinalizationRegistry that can be used for this check instead.

  • jsc.cpp: (JSC_DEFINE_HOST_FUNCTION):
  • runtime/DeferredWorkTimer.cpp: (JSC::DeferredWorkTimer::TicketData::TicketData): (JSC::DeferredWorkTimer::TicketData::vm): (JSC::DeferredWorkTimer::TicketData::cancel): (JSC::DeferredWorkTimer::doWork): (JSC::DeferredWorkTimer::addPendingWork): (JSC::DeferredWorkTimer::hasPendingWork): (JSC::DeferredWorkTimer::hasDependancyInPendingWork): (JSC::DeferredWorkTimer::cancelPendingWork):
  • runtime/DeferredWorkTimer.h: (JSC::DeferredWorkTimer::TicketData::target):
  • runtime/JSFinalizationRegistry.cpp: (JSC::JSFinalizationRegistry::finalizeUnconditionally):
  • runtime/JSFinalizationRegistry.h:
  • wasm/WasmStreamingCompiler.cpp: (JSC::Wasm::StreamingCompiler::StreamingCompiler): (JSC::Wasm::StreamingCompiler::~StreamingCompiler): (JSC::Wasm::StreamingCompiler::didComplete): (JSC::Wasm::StreamingCompiler::fail): (JSC::Wasm::StreamingCompiler::cancel):
  • wasm/WasmStreamingCompiler.h:
  • wasm/js/JSWebAssembly.cpp: (JSC::JSWebAssembly::webAssemblyModuleValidateAsync): (JSC::instantiate): (JSC::compileAndInstantiate): (JSC::JSWebAssembly::webAssemblyModuleInstantinateAsync):
1:36 PM Changeset in webkit [287649] by Russell Epstein
  • 1 copy in tags/Safari-613.1.12.1.2

Tag Safari-613.1.12.1.2.

1:36 PM Changeset in webkit [287648] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS][WP] Unable to consume mach extension
​https://bugs.webkit.org/show_bug.cgi?id=234889
<rdar://86870109>

Reviewed by Brent Fulgham.

The WebContent process on iOS is unable to consume mach extensions to the frontboard service.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
1:11 PM Changeset in webkit [287647] by Russell Epstein
  • 7 edits
    4 deletes in branches/safari-612-branch

Revert "Cherry-pick r287353. rdar://problem/87125345"

This reverts commit r287633.

12:08 PM Changeset in webkit [287646] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

NetworkRTCProvider::attributedBundleIdentifierFromPageIdentifier should check for m_connection
​https://bugs.webkit.org/show_bug.cgi?id=234845
<rdar://82120356>

Reviewed by Eric Carlson.

NetworkRTCProvider may call attributedBundleIdentifierFromPageIdentifier in a background thread,
which will then hop to main thread to get its session.
NetworkRTCProvider might have been closed when getting to main thread so we need to check m_connection.

  • NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::attributedBundleIdentifierFromPageIdentifier):

11:59 AM Changeset in webkit [287645] by Russell Epstein
  • 1 copy in tags/Safari-613.1.12.3

Tag Safari-613.1.12.3.

11:54 AM Changeset in webkit [287644] by Russell Epstein
  • 4 edits in branches/safari-613.1.12-branch/Source/ThirdParty

Cherry-pick r287642. rdar://problem/87072368

REGRESSION (r287382): libANGLE is built into a wrong location on iOS
​https://bugs.webkit.org/show_bug.cgi?id=234857

Reviewed by Saam Barati.

Reverted to the prior logic to compute INSTALL_PATH. Then added an optional prefix
for the alternate root framework location.

Source/ThirdParty/ANGLE:

  • Configurations/ANGLE-dynamic.xcconfig:

Source/ThirdParty/libwebrtc:

  • Configurations/libwebrtc.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:52 AM Changeset in webkit [287643] by Russell Epstein
  • 9 edits in branches/safari-613.1.12-branch/Source

Versioning.

WebKit-7613.1.12.3

11:42 AM Changeset in webkit [287642] by msaboff@apple.com
  • 4 edits in trunk/Source/ThirdParty

REGRESSION (r287382): libANGLE is built into a wrong location on iOS
​https://bugs.webkit.org/show_bug.cgi?id=234857

Reviewed by Saam Barati.

Reverted to the prior logic to compute INSTALL_PATH. Then added an optional prefix
for the alternate root framework location.

Source/ThirdParty/ANGLE:

  • Configurations/ANGLE-dynamic.xcconfig:

Source/ThirdParty/libwebrtc:

  • Configurations/libwebrtc.xcconfig:
11:29 AM Changeset in webkit [287641] by timothy_horton@apple.com
  • 10 edits in trunk/Source

Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
​https://bugs.webkit.org/show_bug.cgi?id=234535
<rdar://problem/86338105>

Reviewed by Simon Fraser.

Source/WebKit:

Currently, synthetic momentum dispatch is strictly tied to the duration
of the real platform momentum phase, which has two unfortunate implications:

  • if our phase runs shorter than the platform phase, we'll keep dispatching zero-delta events until the platform momentum ends
  • more importantly, if our phase runs longer, it will be abruptly terminated when the platform momentum ends

In practice, our synthetic phase is very close in duration to the system one,
so the impact is minimal. But, to be safe, disentagle the two durations,
using a new bit from the platform to determine if the system momentum phase
was interrupted by the user (e.g. by tapping the trackpad) or naturally,
and ignoring the ended event in the natural case, allowing synthetic
events to continue being dispatched.

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode const):
(WebKit::WebWheelEvent::decode):

  • Shared/WebWheelEvent.h:

(WebKit::WebWheelEvent::momentumEndType const):

  • Shared/WebWheelEventCoalescer.cpp:

(WebKit::WebWheelEventCoalescer::coalesce):
Plumb momentumEndType along on WebWheelEvent. Platforms that don't
provide information about the interruption reason will always say Unknown.

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebWheelEvent):
Only bother looking up the CGEvent/IOHIDEvent once, and extract all
relevant details in one go.

  • WebProcess/WebPage/MomentumEventDispatcher.cpp:

(WebKit::MomentumEventDispatcher::handleWheelEvent):
Don't interrupt the synthetic momentum phase if the momentum-ended event
comes from the natural end of the deceleration instead of an interruption
(or an unknown reason).

Keep track of whether we're in the middle of a platform momentum phase
that we chose (at momentum-begin time) to override. When deciding
whether to eat an incoming event, take *both* this new bit and whether
we are currently in the middle of a synthetic phase into account. It
is important to continue eating incoming events in the case where
the synthetic phase ended early (so active became false) but the
platform phase continues.

(WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent):
(WebKit::MomentumEventDispatcher::didEndMomentumPhase):
Adjust some logging wording to be more precise.

(WebKit::MomentumEventDispatcher::setScrollingAccelerationCurve):
Make this log public so that the curve value is visible in logs.

(WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime):
Make consumeDeltaForCurrentTime inform the client via an optional when
we are at the end of the delta table.

(WebKit::MomentumEventDispatcher::displayWasRefreshed):
Stop the synthetic momentum phase as soon as we run out of deltas.

(WebKit::MomentumEventDispatcher::computeNextDelta):

  • WebProcess/WebPage/MomentumEventDispatcher.h:

Source/WTF:

  • wtf/PlatformHave.h:

Add a HAVE for kIOHIDEventScrollMomentumInterrupted.

11:19 AM Changeset in webkit [287640] by Russell Epstein
  • 4 edits in branches/safari-613.1.12.1-branch

Cherry-pick r287609. rdar://problem/85917218

Unreviewed, reverting r285915.
​https://bugs.webkit.org/show_bug.cgi?id=234873

causes crashes

Reverted changeset:

"border-radius inline style should serialize with valid
syntax"
​https://bugs.webkit.org/show_bug.cgi?id=183994
​https://commits.webkit.org/r285915

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:19 AM Changeset in webkit [287639] by Russell Epstein
  • 11 edits in branches/safari-613.1.12.1-branch

Cherry-pick r287377. rdar://problem/86829012

WebsiteDataStore::excludeDirectoryFromBackup should set attribute for existing directories
​https://bugs.webkit.org/show_bug.cgi?id=234404

Reviewed by Youenn Fablet.

Source/WebKit:

createDirectoryAtURL returning false means directory cannot be created, but the cause can be that directory
already exists; so we should set exclude attribute on the directory no matter createDirectoryAtURL returns true
or false. Also, we can use existing FileSystem functions.

API test: WKWebView.LocalStorageDirectoryExcludedFromBackup

  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::excludeDirectoryFromBackup): Deleted.
  • UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::parameters):
  • UIProcess/WebsiteData/WebsiteDataStore.h:

Source/WTF:

  • wtf/FileSystem.cpp: (WTF::FileSystemImpl::excludeFromBackup): (WTF::FileSystemImpl::canExcludeFromBackup): Deleted.
  • wtf/FileSystem.h:
  • wtf/cocoa/FileSystemCocoa.mm: (WTF::FileSystemImpl::excludeFromBackup):
  • wtf/mac/FileSystemMac.mm: (WTF::FileSystem::canExcludeFromBackup): Deleted. (WTF::FileSystem::excludeFromBackup): Deleted.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:19 AM Changeset in webkit [287638] by Russell Epstein
  • 5 edits in branches/safari-613.1.12.1-branch

Cherry-pick r285827. rdar://problem/85917218

Revert r285235
​https://bugs.webkit.org/show_bug.cgi?id=233142

Unreviewed.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt:

Source/WebCore:

Causes crash with simple repro

<div id=t style="border-radius: unset"></div>
<script>
t.style.borderRadius;
</script>

  • css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::borderRadiusValue const): Deleted.
  • css/StyleProperties.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@285827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:09 AM Changeset in webkit [287637] by Russell Epstein
  • 9 edits in branches/safari-613.1.12.1-branch/Source

Versioning.

WebKit-7613.1.12.1.2

10:27 AM Changeset in webkit [287636] by Patrick Angle
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: revert-layer should be autocompleted
​https://bugs.webkit.org/show_bug.cgi?id=234646

Reviewed by Devin Rousso.

  • UserInterface/Controllers/CSSManager.js:
  • UserInterface/Models/CSSKeywordCompletions.js:
10:21 AM Changeset in webkit [287635] by Russell Epstein
  • 3 edits
    2 adds in branches/safari-612-branch

Cherry-pick r287593. rdar://problem/86910670

"canceled" wheel events to non-zero deltas cause scrolling jumps in PDFs and CodeMirror
​https://bugs.webkit.org/show_bug.cgi?id=234825

Reviewed by Tim Horton.

Source/WebKit:

On some macOS versions, interrupting a momentum scroll via a two-finger tap on the trackpad can
result in the following sequence of wheel events: momentumPhase:end -> phase:mayBegin -> phase:cancelled,
and that last canceled event can have non-zero deltas (rdar://86653042).

Protect against this by zeroing out the deltas for cancelled wheel events when constructing WebEvents
from NSEvents. Code in Element::dispatchWheelEvent() ensures that we don't dispatch wheel events with
zero deltas to script, fixing CodeMirror.

Jumps only affected PDFs (and scrollable selects) because those are the code paths that don't go via
ScrollingEffectsController, which already ignores Cancelled events.

Test: fast/scrolling/mac/canceled-event-with-non-zero-deltas.html

  • Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):

LayoutTests:

  • fast/scrolling/mac/canceled-event-with-non-zero-deltas-expected.txt: Added.
  • fast/scrolling/mac/canceled-event-with-non-zero-deltas.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287634] by Russell Epstein
  • 2 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r287578. rdar://problem/86228553

Momentum Event Dispatcher: Disable noisy logging
​https://bugs.webkit.org/show_bug.cgi?id=234178
<rdar://problem/86228553>

Reviewed by Wenson Hsieh.

  • WebProcess/WebPage/MomentumEventDispatcher.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287633] by Russell Epstein
  • 7 edits
    4 adds in branches/safari-612-branch

Cherry-pick r287353. rdar://problem/87125345

Use requester when calling updateRequestAndAddExtraFields
​https://bugs.webkit.org/show_bug.cgi?id=234507
<rdar://problem/85049490>

Reviewed by Brent Fulgham.

Source/WebCore:

In case of navigation loads, the requester is the fetch request client.
As such, it should be the one used to determine whether the request is cross-origin is not.
Pass the requester to updateRequestAndAddExtraFields to do the correct computation.
Validate that some request fields are now correctly observed in service workers.

Test: http/wpt/service-workers/navigation-iframe-site.https.html

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • testing/ServiceWorkerInternals.cpp:
  • testing/ServiceWorkerInternals.h:
  • testing/ServiceWorkerInternals.idl:

LayoutTests:

  • http/wpt/service-workers/navigation-iframe-site-worker.js: Added.
  • http/wpt/service-workers/navigation-iframe-site.https-expected.txt: Added.
  • http/wpt/service-workers/navigation-iframe-site.https.html: Added.
  • http/wpt/service-workers/resources/navigation-iframe-site-frame.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287632] by Russell Epstein
  • 2 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r287313. rdar://problem/87124922

IPC streams should not accept 0-length stream buffers
​https://bugs.webkit.org/show_bug.cgi?id=234552
<rdar://79725420>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-12-21
Reviewed by Antti Koivisto.

Make decoding 0-length stream buffers fail. These buffers are not useful.

No new tests, tests need additional implementation, will be added
in subsequent commits.

  • Platform/IPC/StreamConnectionBuffer.cpp: (IPC::StreamConnectionBuffer::StreamConnectionBuffer): (IPC::StreamConnectionBuffer::decode):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287631] by Russell Epstein
  • 3 edits in branches/safari-612-branch/Source/WebCore

Cherry-pick r287286. rdar://problem/87124952

Don't include SVGImageForContainers in allCachedSVGImages
​https://bugs.webkit.org/show_bug.cgi?id=234364

Patch by Matt Woodrow <Matt Woodrow> on 2021-12-20
Reviewed by Dean Jackson.

  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::image const): (WebCore::CachedImage::hasSVGImage const): (WebCore::CachedImage::image): Deleted.
  • loader/cache/CachedImage.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287630] by Russell Epstein
  • 2 edits in branches/safari-612-branch/Source/WebCore

Cherry-pick r287240. rdar://problem/86026618

Fix pointer to blob data in BlobResourceHandle::readDataSync()
<​https://webkit.org/b/234459>
<rdar://86026618>

Reviewed by Chris Dumez.

  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::readDataSync):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287629] by Russell Epstein
  • 2 edits in branches/safari-612-branch/Source/WebCore

Cherry-pick r287048. rdar://problem/87125012

Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemoryDisplayList()
​https://bugs.webkit.org/show_bug.cgi?id=234264

Patch by Gabriel Nava Marino <​gnavamarino@apple.com> on 2021-12-14
Reviewed by Myles C. Maxfield.

The client is not adhearing to the DisplayList Iterator's API contract in MemoryDisplayList::~InMemoryDisplayList():
"Part of the iterator's API contract is that if the item is nullopt, you're not allowed to keep
iterating - doing this will lead to an infinite loop."

Here we now do so by breaking out of iteration if the item is nullopt.

  • platform/graphics/displaylists/InMemoryDisplayList.cpp: (WebCore::DisplayList::InMemoryDisplayList::~InMemoryDisplayList):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287628] by Russell Epstein
  • 15 edits in branches/safari-612-branch

Cherry-pick r287039. rdar://problem/85015428

Move FTP disabling from NetworkLoad::start to NetworkDataTask::NetworkDataTask
​https://bugs.webkit.org/show_bug.cgi?id=234280
Source/WebKit:

<rdar://85015428>

Reviewed by Brady Eidson.

A NetworkLoad synchronously failing has caused several issues.
This issue is when a WKDownload is prevented in this way, we don't have a WKDownload in the UI process yet,
and we haven't assigned it an identifier in the network process yet either, so we dereference null and send
unreceived messages in many places. To fix this issue, I move the FTP check to the NetworkDataTask constructor
like we do with blocked port checks and invalid URL checks. I also found that there is a race condition with
CFNetwork also failing to load an empty FTP URL, so we need to prevent us from asking CFNetwork to start a load
for which we have scheduled a failure.

Covered by an API test which used to hit all the horrible failures and now passes reliably.

  • NetworkProcess/NetworkCORSPreflightChecker.cpp: (WebKit::NetworkCORSPreflightChecker::wasBlockedByDisabledFTP):
  • NetworkProcess/NetworkCORSPreflightChecker.h:
  • NetworkProcess/NetworkDataTask.cpp: (WebKit::NetworkDataTask::NetworkDataTask): (WebKit::NetworkDataTask::scheduleFailure):
  • NetworkProcess/NetworkDataTask.h:
  • NetworkProcess/NetworkLoad.cpp: (WebKit::NetworkLoad::start): (WebKit::NetworkLoad::wasBlockedByDisabledFTP):
  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/PingLoad.cpp: (WebKit::PingLoad::wasBlockedByDisabledFTP):
  • NetworkProcess/PingLoad.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::resume):
  • Shared/WebErrors.cpp: (WebKit::ftpDisabledError):
  • Shared/WebErrors.h:

Tools:

Reviewed by Brady Eidson.

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [287627] by Russell Epstein
  • 6 edits in branches/safari-612-branch

Cherry-pick r286940. rdar://problem/85388372

Implement step 17 of main fetch algorithm
​https://bugs.webkit.org/show_bug.cgi?id=234140

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-csp.https.html:
  • web-platform-tests/service-workers/service-worker/resources/fetch-csp-iframe.html.sub.headers:

Source/WebCore:

The step was implemented for non DocumentThreadableLoader resources, we need to also do the same step within DocumentThreadableLoader.

Covered by existing updated tests.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287626] by Russell Epstein
  • 3 edits
    1 add in branches/safari-612-branch

Cherry-pick r286283. rdar://problem/87125362

[JSC] jumpForTypedArrayOutOfBounds should use asAnyInt since it uses isAnyInt
​https://bugs.webkit.org/show_bug.cgi?id=233610
rdar://85820476

Reviewed by Saam Barati.

JSTests:

  • stress/anyint-index.js: Added. (foo):

Source/JavaScriptCore:

Since we are using isAnyInt, then we should use asAnyInt. asUInt32 will crash
if the value is double AnyInt etc.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287625] by Russell Epstein
  • 3 edits
    1 add in branches/safari-612-branch

Cherry-pick r286275. rdar://problem/87125258

[JSC] slice should be aware of TerminationException
​https://bugs.webkit.org/show_bug.cgi?id=233593
rdar://85823844

Reviewed by Mark Lam.

JSTests:

  • stress/slice-termination-exception.js: Added. (async infiniteLoop):

Source/JavaScriptCore:

Since termination exception can happen at any time, assertNoException is wrong.

  • runtime/ArrayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287624] by Russell Epstein
  • 4 edits
    1 add in branches/safari-612-branch

Cherry-pick r286249. rdar://problem/87124979

[JSC] private name operation should use RETURN_IF_EXCEPTION
​https://bugs.webkit.org/show_bug.cgi?id=233577
rdar://85813869

Reviewed by Mark Lam.

JSTests:

  • stress/termination-error-in-private-name.js: Added. (C):

Source/JavaScriptCore:

Because of TerminatedExecutionError, error can be thrown at any time.

  • jit/JITOperations.cpp: (JSC::JSC_DEFINE_JIT_OPERATION): (JSC::putPrivateNameOptimize): (JSC::putPrivateName):
  • llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287623] by Russell Epstein
  • 6 edits
    1 add in branches/safari-612-branch

Cherry-pick r286228. rdar://problem/87125189

[JSC] GetTypedArrayLengthAsInt52 can get Array::Generic ArrayMode
​https://bugs.webkit.org/show_bug.cgi?id=233571
rdar://85812164

Reviewed by Mark Lam.

JSTests:

  • stress/get-typed-array-length-as-int52-generic.js: Added. (foo.bar): (foo):

Source/JavaScriptCore:

If speculation is not populated enough, then GetTypedArrayLengthAsInt52 can get Array::Generic.
In that case, we should convert it to Array::ForceExit as it is done in GetArrayLength.
And blessArrayOperation inserts ForceOSRExit. So GetTypedArrayLengthAsInt52 won't be compiled.

  • dfg/DFGClobberize.h: (JSC::DFG::clobberize):
  • dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode):
  • dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compileGetTypedArrayLengthAsInt52):
  • ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayLengthAsInt52):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287622] by Russell Epstein
  • 2 edits in branches/safari-612-branch/JSTests

Cherry-pick r286153. rdar://problem/87124911

Skip new stress test get-array-length-reuse.js if memory-limited
​https://bugs.webkit.org/show_bug.cgi?id=233299
rdar://85502079

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-11-24
Reviewed by Yusuke Suzuki.

  • stress/get-array-length-reuse.js:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287621] by Russell Epstein
  • 3 edits
    1 add in branches/safari-612-branch

Cherry-pick r285978. rdar://problem/87124911

[JSC] TypedArray GetArrayLength should not use Reuse
​https://bugs.webkit.org/show_bug.cgi?id=233299
rdar://85502079

Reviewed by Robin Morisset.

JSTests:

  • stress/get-array-length-reuse.js: Added. (foo):

Source/JavaScriptCore:

We should not perform OSR exit after assigning a value to a reused register, otherwise,
OSR exit cannot recover the proper value. Now TypedArray GetArrayLength can perform
OSR exit after loading a length, so we should not use reused register for length.

  • dfg/DFGSpeculativeJIT.cpp:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@285978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287620] by Russell Epstein
  • 3 edits
    2 adds in branches/safari-612-branch

Cherry-pick r285710. rdar://problem/87125070

REGRESSION(r285624) Using revert keyword with a css variable hits assert
​https://bugs.webkit.org/show_bug.cgi?id=233031
rdar://85332271

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/selectors/variable-revert-crash.html

  • style/StyleBuilderState.h:

Default initialization set the variable to a value that is not in the enumeration.

LayoutTests:

  • fast/selectors/variable-revert-crash-expected.txt: Added.
  • fast/selectors/variable-revert-crash.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@285710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287619] by Russell Epstein
  • 2 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r285431. rdar://problem/87124705

WKSyntheticTapGestureRecognizer's action targets should be weak pointers
​https://bugs.webkit.org/show_bug.cgi?id=232812

Reviewed by Tim Horton.

Make WKSyntheticTapGestureRecognizer robust against the case where it outlives its WKContentView, by making its
"reset", "gesture identified", and "gesture failed" targets weak pointers instead of raw pointers.

  • UIProcess/ios/WKSyntheticTapGestureRecognizer.mm: (-[WKSyntheticTapGestureRecognizer lastTouchedScrollView]):

Drive-by fix: we can also make _lastTouchedScrollView use the weak ivar attribute instead of WeakObjCPtr,
now that weak is enabled in WebKit2.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@285431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287618] by Russell Epstein
  • 4 edits in branches/safari-612-branch

Cherry-pick r284980. rdar://problem/84223894

Fix CARingBuffer mix mode
​https://bugs.webkit.org/show_bug.cgi?id=232427
Source/WebCore:

Reviewed by Eric Carlson.

Like done for Copy, we need to use the destination offset to write data properly.

Covered by API test.

  • platform/audio/cocoa/CARingBuffer.cpp:

Tools:

<rdar://problem/84747657>

Reviewed by Eric Carlson.

  • TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@284980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287617] by Russell Epstein
  • 8 edits in branches/safari-612-branch/Source/ThirdParty/libwebrtc

Cherry-pick r283610. rdar://problem/83435926

ObjectiveC WebRTC frame buffers are autoreleased late, especially on Debug builds
​https://bugs.webkit.org/show_bug.cgi?id=231162

Reviewed by David Kilzer.

Instead of waiting for the autorelease pool to release these objects, we explicitly release them by calling close.
This ensures that pixel buffers get released very quickly.

  • Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
  • Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer+Private.h:
  • Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer.mm:
  • Source/webrtc/sdk/objc/base/RTCI420Buffer.h:
  • Source/webrtc/sdk/objc/base/RTCVideoFrameBuffer.h:
  • Source/webrtc/sdk/objc/components/video_frame_buffer/RTCCVPixelBuffer.h:
  • Source/webrtc/sdk/objc/components/video_frame_buffer/RTCCVPixelBuffer.mm:
  • Source/webrtc/sdk/objc/native/src/objc_frame_buffer.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@283610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:10 AM Changeset in webkit [287616] by pvollan@apple.com
  • 5 edits in trunk/Source/WebKit

[macCatalyst][GPUP][NetworkProcess] Block WindowServer connections
​https://bugs.webkit.org/show_bug.cgi?id=234432
<rdar://problem/85990387>

Reviewed by Brent Fulgham.

Block WindowServer connections on macCatalyst.

  • GPUProcess/mac/GPUProcessMac.mm:

(WebKit::GPUProcess::initializeProcess):

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::initializeProcess):

  • Shared/Cocoa/AuxiliaryProcessCocoa.mm:

(WebKit::AuxiliaryProcess::setApplicationIsDaemon):

  • WebAuthnProcess/mac/WebAuthnProcessMac.mm:

(WebKit::WebAuthnProcess::initializeProcess):

7:48 AM Changeset in webkit [287615] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[macOS][WP] Block sandbox access to syscall
​https://bugs.webkit.org/show_bug.cgi?id=234846
<rdar://problem/87093120>

Reviewed by Brent Fulgham.

Block sandbox access to syscall which only is needed on MacCatalyst.

  • WebProcess/com.apple.WebProcess.sb.in:
7:41 AM Changeset in webkit [287614] by Jonathan Bedard
  • 4 edits in trunk/Tools

Running layout tests sometimes throws an AssertionError in python2.7/multiprocessing
​https://bugs.webkit.org/show_bug.cgi?id=234487

Reviewed by Simon Fraser.

  • Scripts/libraries/webkitcorepy/setup.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
  • Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:

(_BiDirectionalQueue.send): Log failed queue put.

3:26 AM Changeset in webkit [287613] by youenn@apple.com
  • 9 edits
    2 adds in trunk

MediaRecorder should support the bitsPerSecond option
​https://bugs.webkit.org/show_bug.cgi?id=234784

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/mediacapture-record/MediaRecorder-bitrate.https-expected.txt:

Source/WebCore:

In case bitsPerSecond is set, we now compute audioBitsPerSecond and videoBitsPerSecond value according to it.
We set audioBitsPerSecond to a tenth of bitsPerSecond and set videoBitsPerSecond to the remaining available bandwidth.
We then use minimum values of 8kbps for audio and 80kbps for video.
As per spec, we compute these values at creation, start and stop times.
We introduce dedicated class members for audio and video bitrates, similarly to the spec defining corresponding slots.

Test: http/wpt/mediarecorder/MediaRecorder-bitrate.html

  • Modules/mediarecorder/MediaRecorder.cpp:
  • Modules/mediarecorder/MediaRecorder.h:
  • platform/mediarecorder/MediaRecorderPrivate.cpp:
  • platform/mediarecorder/MediaRecorderPrivate.h:
  • platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

LayoutTests:

  • http/wpt/mediarecorder/MediaRecorder-bitrate-expected.txt: Added.
  • http/wpt/mediarecorder/MediaRecorder-bitrate.html: Added.
2:46 AM Changeset in webkit [287612] by youenn@apple.com
  • 19 edits
    10 adds in trunk

Fetch using FormData with file doesn't go through Service Worker
​https://bugs.webkit.org/show_bug.cgi?id=187461
<rdar://problem/41975544>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/response/response-consume-expected.txt:
  • web-platform-tests/fetch/api/response/response-consume-stream.any-expected.txt:
  • web-platform-tests/fetch/api/response/response-consume-stream.any.worker-expected.txt:

Source/WebCore:

Add support for reading formData based bodies through streams or regular methods like text.
For that purpose, we add FormDataConsumer which allows serializing form datas that may contain files or blobs.
Add the ability to load blobs from BlobLoader using the internal URL (stored in FormData) in lieu of passing a blob object.
Enable fetch events for form data based fetch events.

Test: http/wpt/service-workers/form-data-upload.html

  • Modules/fetch/FetchBody.cpp:
  • Modules/fetch/FetchBody.h:
  • Modules/fetch/FetchBodyConsumer.cpp:
  • Modules/fetch/FetchBodyConsumer.h:
  • Modules/fetch/FormDataConsumer.cpp: Added.
  • Modules/fetch/FormDataConsumer.h: Added.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/BlobLoader.h:
  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
  • workers/service/context/ServiceWorkerFetch.cpp:

LayoutTests:

In addition to adding a test to http/wpt/fetch/request-consume-stream.html, we fix the other tests that should all be passing.
Add http/wpt/service-workers/form-data-upload.html and translate exiting http/tests scripts for the WPT server.

  • http/wpt/fetch/request-consume-stream-expected.txt:
  • http/wpt/fetch/request-consume-stream.html:
  • http/wpt/service-workers/form-data-upload-expected.txt: Added.
  • http/wpt/service-workers/form-data-upload-worker.js: Added.
  • http/wpt/service-workers/form-data-upload.html: Added.
  • http/wpt/service-workers/resources/create-temp-file-iframe.html: Added.
  • http/wpt/service-workers/resources/reset-temp-file.py: Added.
  • http/wpt/service-workers/resources/temp-file-utils.js: Added.
  • http/wpt/service-workers/resources/touch-temp-file.py: Added.
  • http/wpt/service-workers/resources/write-temp-file.py: Added.
2:35 AM Changeset in webkit [287611] by youenn@apple.com
  • 20 edits
    3 copies
    6 adds
    2 deletes in trunk

Make sure secure websocket connections in service workers can trigger authentication challenge callbacks
​https://bugs.webkit.org/show_bug.cgi?id=234809
<rdar://85888177>

Reviewed by Chris Dumez.

Source/WebCore:

  • dom/Document.h:

Source/WebKit:

In case we are not using fast server trust evaluation, we are going to the UIProcess to check certificates.
This is an issue for web socket loads triggered for service workers that have an invalid certificate.
Before the patch, the challenge was not provided a top origin, so the default action would be triggered by UIProcess.
To make sure this is working as expected, we now always pass the origin if it is the same as the top origin for web socket challenges.
This makes sure we get a page with the same top origin and the challenge callback is called on the page.

Covered by updated tests.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkSession.cpp:
  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/NetworkSocketChannel.cpp:
  • NetworkProcess/NetworkSocketChannel.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:
  • NetworkProcess/cocoa/WebSocketTaskCocoa.h:
  • NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
  • NetworkProcess/soup/NetworkSessionSoup.cpp:
  • NetworkProcess/soup/NetworkSessionSoup.h:
  • WebProcess/Network/WebSocketChannel.cpp:

LayoutTests:

  • http/tests/workers/service/serviceworker-websocket.https-expected.txt:
  • http/tests/workers/service/serviceworker-websocket.https.html:
  • platform/gtk/http/tests/workers/service/serviceworker-websocket.https-expected.txt: Copied from LayoutTests/http/tests/workers/service/serviceworker-websocket.https-expected.txt.
  • platform/ios-wk2/http/tests/workers/service/serviceworker-websocket.https-expected.txt: Removed.
  • platform/mac-bigsur-wk2/http/tests/workers/service/serviceworker-websocket.https-expected.txt: Copied from LayoutTests/http/tests/workers/service/serviceworker-websocket.https-expected.txt.
  • platform/mac-catalina-wk2/http/tests/workers/service/serviceworker-websocket.https-expected.txt: Copied from LayoutTests/http/tests/workers/service/serviceworker-websocket.https-expected.txt.
2:01 AM Changeset in webkit [287610] by Martin Robinson
  • 11 edits in trunk

Change offsetParent to match spec change
​https://bugs.webkit.org/show_bug.cgi?id=161788
<rdar://problem/28230510>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-contain/content-visibility/content-visibility-038-expected.txt: Rebase test that fails differently now.
  • web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-containing-block-expected.txt: Ditto.
  • web-platform-tests/css/cssom-view/offsetParent_element_test.html: Increase the test coverage for this test case.
  • web-platform-tests/svg/extensibility/foreignObject/containing-block-expected.txt: Part of this test now passes.

Source/WebCore:

No new tests. This is covered by new test statements in web-platform-tests/css/cssom-view/offsetParent_element_test.html.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent const): Update the offsetParent algorithm to return all elements
that create containing blocks for absolutely positioned items and not just positioned elements.

LayoutTests:

  • fast/clip/hit-test-with-clip-path.html: Rewrite this test to use getBoundingClientRect.
  • fast/forms/resources/common.js:

(searchCancelButtonPosition): Ditto.

  • fast/forms/search-transformed.html: Ditto.
1:52 AM Changeset in webkit [287609] by commit-queue@webkit.org
  • 6 edits in trunk

Unreviewed, reverting r285915.
​https://bugs.webkit.org/show_bug.cgi?id=234873

causes crashes

Reverted changeset:

"border-radius inline style should serialize with valid
syntax"
​https://bugs.webkit.org/show_bug.cgi?id=183994
​https://commits.webkit.org/r285915

12:41 AM Changeset in webkit [287608] by youenn@apple.com
  • 6 edits
    1 add in trunk

Tighten ServiceWorkerRegistrationKey::fromDatabaseKey
​https://bugs.webkit.org/show_bug.cgi?id=234838

Reviewed by Chris Dumez.

Source/WebCore:

Add missing input validation checks.
Covered by API test.
In addition, validate that the registration key matches the other database fields.

  • workers/service/ServiceWorkerRegistrationKey.cpp:
  • workers/service/ServiceWorkerRegistrationKey.h:
  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::importRecords):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/ServiceWorkerRoutines.cpp: Added.
12:24 AM Changeset in webkit [287607] by youenn@apple.com
  • 5 edits
    2 adds in trunk

WebPageProxy::requestUserMediaPermissionForSpeechRecognition should return early in case of no capture devices
​https://bugs.webkit.org/show_bug.cgi?id=234837
<rdar://87055505>

Reviewed by Chris Dumez.

Source/WebKit:

Test: fast/speechrecognition/start-recognition-without-devices.html

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForSpeechRecognition):

LayoutTests:

  • fast/speechrecognition/start-recognition-without-devices-expected.txt: Added.
  • fast/speechrecognition/start-recognition-without-devices.html: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
12:22 AM Changeset in webkit [287606] by Martin Robinson
  • 4 edits in trunk

CSS transform property should take into account transform reference box
​https://bugs.webkit.org/show_bug.cgi?id=234144
<rdar://problem/86630206>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-transforms/transform-percent-009-expected.txt:

Source/WebCore:

No new tests. This is covered by the existing WPT test:

web-platform-tests/css/css-transforms/transform-percent-009.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTransform): Use the transform reference box when computing the
computed transform instead of always using the border box. This function is
modified to take in a RenderElement to avoid casting. All callers pass a RenderElement.

12:02 AM Changeset in webkit [287605] by Fujii Hironori
  • 2 edits in trunk/Tools

[Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray
​https://bugs.webkit.org/show_bug.cgi?id=234870

Reviewed by Darin Adler.

r23462 added the following code.

if (arrPtr && SUCCEEDED(::SafeArrayUnlock(arrPtr)))

::SafeArrayDestroy(arrPtr);

However, the array wasn't locked. SafeArrayUnlock always failed.
Thus, SafeArrayDestroy wasn't called.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dumpHistoryItem): Don't use SafeArrayUnlock. Fixed a typo 'arrary'.

Jan 4, 2022:

11:52 PM Changeset in webkit [287604] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Protect frame from destruction in HTMLMediaElement::setupAndCallJS
​https://bugs.webkit.org/show_bug.cgi?id=234259

Patch by Frédéric Wang <​fwang@igalia.com> on 2022-01-04
Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/media/media-element-frame-destroyed-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setupAndCallJS): Protect the frame before executing the JS code,
so that it is not destroyed before its associated ScriptController.

LayoutTests:

Add non-regression test, embedded in multiple iframes to make regression easily reproducible.

  • http/conf/mime.types: Ensure that ts files are served with MIME type video/mp2t as that's required

to make the non-regression test work properly.

  • http/tests/media/media-element-frame-destroyed-crash-expected.txt: Added.
  • http/tests/media/media-element-frame-destroyed-crash.html: Added.
  • http/tests/media/resources/empty.ts: Added.
  • http/tests/media/resources/media-element-frame-destroyed-crash-subframe.html: Added.
11:33 PM Changeset in webkit [287603] by graouts@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderStyle::transitionForProperty() is unused
​https://bugs.webkit.org/show_bug.cgi?id=234860

Reviewed by Dean Jackson.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::transitionForProperty const): Deleted.

  • rendering/style/RenderStyle.h:
11:03 PM Changeset in webkit [287602] by graouts@webkit.org
  • 10 edits
    2 deletes in trunk

WPT test css/css-transitions/parsing/transition-shorthand.html has failures
​https://bugs.webkit.org/show_bug.cgi?id=234856

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions, all tests in css/css-transitions/parsing/transition-shorthand.html now pass.

  • web-platform-tests/css/css-transitions/parsing/transition-shorthand-expected.txt:

Source/WebCore:

Parse the "transition" shorthand the same way we parse the "animation" shorthand
and teach ComputedStyleExtractor::addValueForAnimationPropertyToList() about
"transition-property" so that it correctly returns a CSSValue for it.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::addValueForAnimationPropertyToList):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeAnimationShorthand):

LayoutTests:

This historical test transitions/transitions-parsing.html is wrong and WPT has exhaustive
coverage for parsing of transition properties, so let's remove it.

Rebaselining some other tests.

  • fast/css/shorthand-mismatched-list-crash-expected.txt:
  • fast/css/shorthand-mismatched-list-crash.html:
  • fast/css/transform-inline-style-expected.txt:
  • fast/css/transform-inline-style-remove-expected.txt:
  • transitions/transitions-parsing-expected.txt: Removed.
  • transitions/transitions-parsing.html: Removed.
6:03 PM Changeset in webkit [287601] by Russell Epstein
  • 1 copy in tags/Safari-613.1.12.1.1

Tag Safari-613.1.12.1.1.

5:26 PM Changeset in webkit [287600] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

ASSERTION FAILED: pathnames.size() == sandboxExtensionsHandleArray.size() in WebKit::WebPlatformStrategies::getPathnamesForType()
​https://bugs.webkit.org/show_bug.cgi?id=234851
rdar://87100377

Reviewed by Darin Adler.

The new API test added r287547 (WKAttachmentTestsMac.InsertNonExistentImageFileAsAttachment) exercises inserting
a nonexistent file as a "progress" attachment element when the WebKit attachment API is enabled. This test is
the first on macOS that attempts to paste file paths pointing to nonexistent files on disk, and so it hits an
existing assertion due to the number of sandbox extensions opened underneath getPasteboardPathnamesForType()
not matching the number of file paths found on the pasteboard.

This assertion is benign, since we do not expect to be able to read from the missing file path in the web
process, so it's expected that we don't have a corresponding sandbox extension for missing files. To address
this, we adjust WebPasteboardProxy::getPasteboardPathnamesForType() such that it always returns an equal
number of path names and pathnames. Each missing path name simply corresponds to a SandboxExtension::Handle
with a null m_sandboxExtension, which is skipped in the web process upon consumption.

  • UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::getPasteboardPathnamesForType):

5:04 PM Changeset in webkit [287599] by Diego Pino Garcia
  • 4 edits in trunk/LayoutTests

[WPE] fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=212959

Unreviewed test gardening.

This test is no longer flakey for WPE. Updated test expectations.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
5:02 PM Changeset in webkit [287598] by Diego Pino Garcia
  • 4 edits in trunk/LayoutTests

[GTK] media/video-as-img-output-pts.html test is flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=224112

Reviewed by Philippe Normand.

Refactored test to make it similar to other Media test (i.e
media/video-page-visibility-restriction.html).

  • media/video-as-img-output-pts-expected.txt:
  • media/video-as-img-output-pts.html:
  • platform/glib/TestExpectations:
4:48 PM Changeset in webkit [287597] by Fujii Hironori
  • 15 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo-wk1/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wincairo/fast/css/text-overflow-input-expected.txt:
  • platform/wincairo/fast/dom/52776-expected.txt:
  • platform/wincairo/fast/dom/HTMLElement/bdo-expected.txt:
  • platform/wincairo/fast/inline-block/003-expected.txt:
  • platform/wincairo/fast/text/fixed-pitch-control-characters-expected.txt:
  • platform/wincairo/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/wincairo/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/wincairo/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/wincairo/fast/text/international/bidi-override-expected.txt:
  • platform/wincairo/fast/text/text-letter-spacing-expected.txt:
  • platform/wincairo/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
4:20 PM Changeset in webkit [287596] by ysuzuki@apple.com
  • 33 edits in trunk/Source/JavaScriptCore

[JSC] Remove m_calleeSaveRegisters from CodeBlock::JITData and rename it to BaselineJITData
​https://bugs.webkit.org/show_bug.cgi?id=234555

Reviewed by Saam Barati.

This patch removes m_calleeSaveRegisters from CodeBlock::JITData, and moving it to each JITCode.
This is reasonable since m_calleeSaveRegisters information belongs to JITCode, not CodeBlock.
And in LLInt, Baseline, and DFG cases, m_calleeSaveRegisters is the same. So we do not have this
field in these JITCode. Only FTL can have m_calleeSaveRegisters.

By removing m_calleeSaveRegisters from CodeBlock::JITData, now it only includes Baseline JIT related
data. So this patch renames CodeBlock::JITData to BaselineJITData.

We also use TrailingArray for BaselineJITData so that we can remove one level indirection when loading
JITConstantPool from JITData.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setupWithUnlinkedBaselineCode):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeJITInlineCaches):
(JSC::CodeBlock::getICStatusMap):
(JSC::CodeBlock::findStubInfo):
(JSC::CodeBlock::resetBaselineJITData):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::findPC):
(JSC::CodeBlock::ensureJITDataSlow): Deleted.
(JSC::CodeBlock::setCalleeSaveRegisters): Deleted.
(JSC::CodeBlock::resetJITData): Deleted.
(JSC::CodeBlock::calleeSaveRegisters const): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::offsetOfBaselineJITData):
(JSC::CodeBlock::baselineJITData):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::JITData::offsetOfJITConstantPool): Deleted.
(JSC::CodeBlock::ensureJITData): Deleted.
(JSC::CodeBlock::offsetOfJITData): Deleted.
(JSC::CodeBlock::baselineJITConstantPool): Deleted.

  • bytecode/Repatch.cpp:

(JSC::linkPolymorphicCall):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::emitRestoreCalleeSaves):
(JSC::DFG::JITCompiler::emitSaveCalleeSaves):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::calleeSaveSlot):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLJITCode.h:

(JSC::FTL::JITCode::calleeSaveRegisters const):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::calleeSaveRegistersForUnwinding):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::executableFor):
(JSC::AssemblyHelpers::emitSaveOrCopyLLIntBaselineCalleeSavesFor):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitSaveThenMaterializeTagRegisters):
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor): Deleted.
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor): Deleted.
(JSC::AssemblyHelpers::emitSaveCalleeSaves): Deleted.
(JSC::AssemblyHelpers::emitRestoreCalleeSaves): Deleted.

  • jit/BaselineJITCode.h:
  • jit/CallFrameShuffleData.cpp:
  • jit/CallFrameShuffleData.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::emitMaterializeMetadataAndConstantPoolRegisters):
(JSC::JIT::emitSaveCalleeSaves):
(JSC::JIT::compileAndLinkWithoutFinalizing):

  • jit/JIT.h:
  • jit/JITCode.cpp:

(JSC::JITCode::calleeSaveRegisters const):

  • jit/JITCode.h:
  • jit/JITInlines.h:

(JSC::JIT::loadConstant):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/RegisterAtOffsetList.cpp:

(JSC::RegisterAtOffsetList::dfgCalleeSaveRegisters):

  • jit/RegisterAtOffsetList.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • tools/VMInspector.cpp:

(JSC::VMInspector::dumpRegisters):

4:19 PM Changeset in webkit [287595] by Ryan Haddad
  • 9 edits in trunk

Unreviewed, reverting r287374.

Caused assertion failures on Monterey

Reverted changeset:

"Re-enable CustomDisplayName and DefaultDisplayName API tests
on Monterey"
​https://bugs.webkit.org/show_bug.cgi?id=234613
​https://commits.webkit.org/r287374

3:49 PM Changeset in webkit [287594] by Russell Epstein
  • 2 edits in branches/safari-613.1.12.1-branch/Source/WebKit

Cherry-pick r287413. rdar://problem/86808395

Allow a necessary syscall in the WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=234641
<rdar://problem/86808395>

Reviewed by Alan Bujtas.

Telemetry and testing logs indicate that we need to allow
'SYS_memorystatus_control' in our WebContent sandbox.

We allow this in all other sandboxes, so this was likely an oversight.

  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:48 PM Changeset in webkit [287593] by Simon Fraser
  • 3 edits
    2 adds in trunk

"canceled" wheel events to non-zero deltas cause scrolling jumps in PDFs and CodeMirror
​https://bugs.webkit.org/show_bug.cgi?id=234825

Reviewed by Tim Horton.

Source/WebKit:

On some macOS versions, interrupting a momentum scroll via a two-finger tap on the trackpad can
result in the following sequence of wheel events: momentumPhase:end -> phase:mayBegin -> phase:cancelled,
and that last canceled event can have non-zero deltas (rdar://86653042).

Protect against this by zeroing out the deltas for cancelled wheel events when constructing WebEvents
from NSEvents. Code in Element::dispatchWheelEvent() ensures that we don't dispatch wheel events with
zero deltas to script, fixing CodeMirror.

Jumps only affected PDFs (and scrollable selects) because those are the code paths that don't go via
ScrollingEffectsController, which already ignores Cancelled events.

Test: fast/scrolling/mac/canceled-event-with-non-zero-deltas.html

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebWheelEvent):

LayoutTests:

  • fast/scrolling/mac/canceled-event-with-non-zero-deltas-expected.txt: Added.
  • fast/scrolling/mac/canceled-event-with-non-zero-deltas.html: Added.
3:31 PM Changeset in webkit [287592] by Wenson Hsieh
  • 4 edits in trunk

Use ICU instead of relying on hard-coded string equality checks in ModalContainerControlClassifier
​https://bugs.webkit.org/show_bug.cgi?id=234677

Reviewed by Tim Horton.

Source/WebKit:

Followup to r287420 - use ICU to check for more strings that resemble either the lowercase or uppercase letter
"x", rather than relying on a hard-coded set of symbols. Note that ICU's "confusables" list currently does not
consider both ✖ and ✕ to be lookalikes to the letter "x"; since these symbols are actually known to appear in
modal containers on several websites, we'll still need to check for these two symbols separately.

Test: ModalContainerObservation.ClassifyMultiplySymbol

  • UIProcess/Cocoa/ModalContainerControlClassifier.mm:

(WebKit::SpoofChecker::~SpoofChecker):

Add a helper class that wraps calls to uspoof_areConfusableUTF8, and also ensures balanced calls to
uspoof_open and uspoof_close when creating a new ICU spoof checker. Use this in the
WKModalContainerClassifierInput class below to check for more types of strings that look like the letter "x".

(WebKit::SpoofChecker::areConfusable):
(WebKit::SpoofChecker::checker):
(-[WKModalContainerClassifierInput initWithTokenizer:rawInput:]):

Tools:

Augment the existing API test so that it additionally tests a symbol ("small roman numeral ten") that would not
have been covered as one of the three hard-coded symbol strings in the earlier fix.

  • TestWebKitAPI/Tests/WebKitCocoa/ModalContainerObservation.mm:

(TestWebKitAPI::TEST):

3:05 PM Changeset in webkit [287591] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] fast/text/combining-mark-paint.html is failing (complex text)
​https://bugs.webkit.org/show_bug.cgi?id=234834

Reviewed by Antti Koivisto.

Apparently it's perfectly valid to have zero width unicode character (e.g. macron) and
still affect the line height.

  • layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::fallbackFontsForRunWithIterator):

2:51 PM Changeset in webkit [287590] by Devin Rousso
  • 9 edits in trunk

Web Inspector: Sources: expanding a grouping of blackboxed call frames should be persistent
​https://bugs.webkit.org/show_bug.cgi?id=234614
<rdar://problem/86989232>

Reviewed by Patrick Angle.

Source/WebInspectorUI:

If the developer has explicitly decided to show blackboxed call frames, we should respect
that decision. Requiring them to re-expand after _every_ debugger action is very hostile.
So long as the blackboxed call frames remain the same we should persist the expansion. Only
if the location of those blackboxed frames changes should we re-collapse.

  • UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.rememberBlackboxedCallFrameGroupToAutoExpand): Added.
(WI.DebuggerManager.prototype.shouldAutoExpandBlackboxedCallFrameGroup): Added.
(WI.DebuggerManager.prototype._didResumeInternal):

  • UserInterface/Views/BlackboxedGroupTreeElement.js:

(WI.BlackboxedGroupTreeElement.prototype.expand):
Keep a list of blackboxed call frame groupings that have been expanded by the developer.
Use this list to decide whether "new" blackboxed call frame grouping should be auto-expanded
by default (i.e. if every WI.CallFrame is identical with something in the list). Clear the
list when resuming, as we're only trying to keep expanded blackboxed call frame groupings
within the same call stack (i.e. while stepping).

  • UserInterface/Base/Utilities.js:

(Array.prototype.groupBy): Deleted.

  • UserInterface/Views/ThreadTreeElement.js:

(WI.ThreadTreeElement.prototype.refresh):
Remove the custom Array.prototype.groupBy since it's no longer needed (and there's now a
builtin function with the same name). Instead, just keep an index of the first blackboxed
call frame and iterate until either the end of the call stack or a non-blackboxed call frame
is found, sliceing from the saved index to the current item to make a blackboxed call
frame group. If that blackboxed call frame group should be auto-expanded (see above), create
a WI.CallFrameTreeElement for each blackboxed call frame instead of one WI.BlackboxedGroupTreeElement.

  • UserInterface/Models/CallFrame.js:

(WI.CallFrame.prototype.isEqual): Added.
Add a convenience function to compare two WI.CallFrame. Right now it just looks at the
WI.SourceCodeLocation, since for most purposes that's really how one would identify a
WI.CallFrame (i.e. it's probably more important to know "is this the same spot in code"
as opposed to "do we have the same this object").

LayoutTests:

  • inspector/unit-tests/array-utilities.html:
  • inspector/unit-tests/array-utilities-expected.txt:

Remove the custom Array.prototype.groupBy since it's no longer needed (and there's now a
builtin function with the same name).

2:14 PM Changeset in webkit [287589] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS][WP] Add telemetry for syscall violations
​https://bugs.webkit.org/show_bug.cgi?id=234859

Reviewed by Brent Fulgham.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
1:58 PM Changeset in webkit [287588] by Wenson Hsieh
  • 5 edits in trunk

ModalContainerObserver should search for text in subframes
​https://bugs.webkit.org/show_bug.cgi?id=234446
rdar://86897770

Reviewed by Tim Horton.

Source/WebCore:

Adds support for detecting modal containers when the search term is embedded inside a subframe in the top
document. To do this, we make a few adjustments to ModalContainerObserver, detailed in the comments below. This
supports both scenarios in which (1) a subframe that has not yet loaded is added to the top document and then
later gains occurrences of the search term, and (2) a subframe that already contains the search term in rendered
text is made visible inside the top document.

Test: ModalContainerObservation.ModalContainerInSubframe

  • page/ModalContainerObserver.cpp:

(WebCore::ModalContainerObserver::isNeededFor):

Install a ModalContainerObserver for child documents in the case where the parent document already has a modal
container observer that is waiting for this frame to finish its first visually non-empty layout (see the comment
in ModalContainerObserver::updateModalContainerIfNeeded(), below).

(WebCore::containsMatchingText):

Pull out logic for searching all text renderer descendants underneath a given renderer into a separate helper
function.

(WebCore::ModalContainerObserver::searchForModalContainerOnBehalfOfFrameOwnerIfNeeded):

Used for a ModalContainerObserver in a child frame to notify the ModalContainerObserver in the parent document
when the child document has finished layout. If this child document's owner element is one of the elements in
m_frameOwnersAndContainersToSearchAgain, we invalidate the corresponding viewport-constrained container that
we've previously searched (i.e. by removing it from m_elementsToIgnoreWhenSearching) and re-search the
container.

(WebCore::ModalContainerObserver::updateModalContainerIfNeeded):

Make a couple of adjustments:

  • For modal container observers that are not in the top document: delegate the modal container update out

to the parent document's modal container observer, by calling the helper method above.

  • For modal container observers that are in the top document: add logic to search content in subframes

inside of viewport-constrained containers as a fallback in the case where the search term does not
appear in content at the top document.

(WebCore::ModalContainerObserver::setContainer):

Pull out logic for tracking the currently detected modal container into a separate helper method that takes
the modal container element, as well as the frame owner element where we observed the search term (or null if
the search term was observed in the top document).

(WebCore::ModalContainerObserver::container const):
(WebCore::ModalContainerObserver::frameOwnerForControls const):

Replace m_container with a std::pair containing the current modal container (i.e. what is currently just
m_container, as well as a weak pointer to the associated frame owner element where we discovered the search
term). We use a std::pair here because these two elements should always be set and cleared out in tandem.

(WebCore::ModalContainerObserver::collectClickableElementsTimerFired):
(WebCore::ModalContainerObserver::revealModalContainer):

Replace uses of m_container with the container() method.

(WebCore::ModalContainerObserver::collectClickableElements):

If a frame owner element is set, use the subframe's content document element as the container for collecting
clickable controls instead of using the actual modal container element in the top document.

  • page/ModalContainerObserver.h:

(WebCore::ModalContainerObserver::shouldHide const):

Use container() instead of m_container.

Tools:

Add an API test to exercise the change. See WebCore/ChangLog for more details.

  • TestWebKitAPI/Tests/WebKitCocoa/ModalContainerObservation.mm:

(TestWebKitAPI::TEST):

1:44 PM Changeset in webkit [287587] by Jonathan Bedard
  • 4 edits in trunk/Tools

[git-webkit] Open closed pull-request when running pr (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=232765
<rdar://problem/85084318>

Reviewed by Dewei Zhu.

  • Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Tools/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Tools/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:

(PullRequest.main): Log found pull-request instead of undefined candidates.

Canonical link: ​https://commits.webkit.org/245716@main

1:42 PM Changeset in webkit [287586] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Add icon for collapsed blackboxed section
​https://bugs.webkit.org/show_bug.cgi?id=219806
<rdar://problem/72240360>

Reviewed by Patrick Angle.

  • UserInterface/Views/BlackboxedGroupTreeElement.css:

(.tree-outline .item.blackboxed-group .icon):
(@media (prefers-color-scheme: dark) .tree-outline .item.blackboxed-group .icon):
Use Hide.svg#black and Hide.svg#white.

  • UserInterface/Images/TypeIcons.svg:

Remove #Blackboxed-dark and #Blackboxed-light.

1:38 PM Changeset in webkit [287585] by stephan.szabo@sony.com
  • 2 edits in trunk/Source/JavaScriptCore

[PlayStation] Fix non-ninja build of zydis
​https://bugs.webkit.org/show_bug.cgi?id=234854

Unreviewed build fix

  • PlatformPlayStation.cmake: Set Zycore.c as CXX
1:34 PM Changeset in webkit [287584] by Kate Cheney
  • 3 edits in trunk/Source/WebKit

CrashTracer: com.apple.WebKit.Networking at com.apple.WebKit: WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess
​https://bugs.webkit.org/show_bug.cgi?id=234852
<rdar://problem/87068976>

Reviewed by Brent Fulgham.

Return early if a sqlite statement is null or fails to bind because this
will cause a crash when trying to step. Even in cases where it won't
crash, we should not continue in the function because this may have
undefined behavior.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::getThirdPartyDataForSpecificFirstPartyDomains const):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::includeTodayAsOperatingDateIfNecessary):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertExpiredStatisticForTesting):

  • NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:

(WebKit::PCM::Database::earliestTimesToSend):

1:29 PM Changeset in webkit [287583] by commit-queue@webkit.org
  • 34 edits
    4 copies
    4 moves in trunk/LayoutTests

[WPE] Update test baselines after recent LFC-related changes.
​https://bugs.webkit.org/show_bug.cgi?id=234853

Unreviewed test gardening.

This updates WPE test baselines to account for the changes in
r283550, r283875, r284303, r286107, r286133, r286848, r286928, r287453, r287482, and r287485.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-01-04

  • platform/gtk/fast/backgrounds/border-radius-split-background-expected.txt: Copied from LayoutTests/platform/glib/fast/backgrounds/border-radius-split-background-expected.txt.
  • platform/gtk/fast/backgrounds/border-radius-split-background-image-expected.txt: Copied from LayoutTests/platform/glib/fast/backgrounds/border-radius-split-background-image-expected.txt.
  • platform/gtk/fast/borders/border-image-outset-split-inline-expected.txt: Copied from LayoutTests/platform/glib/fast/borders/border-image-outset-split-inline-expected.txt.
  • platform/gtk/fast/borders/border-styles-split-expected.txt: Copied from LayoutTests/platform/glib/fast/borders/border-styles-split-expected.txt.
  • platform/wpe/fast/backgrounds/border-radius-split-background-expected.txt: Renamed from LayoutTests/platform/glib/fast/backgrounds/border-radius-split-background-expected.txt.
  • platform/wpe/fast/backgrounds/border-radius-split-background-image-expected.txt: Renamed from LayoutTests/platform/glib/fast/backgrounds/border-radius-split-background-image-expected.txt.
  • platform/wpe/fast/block/basic/016-expected.txt:
  • platform/wpe/fast/borders/bidi-012-expected.txt:
  • platform/wpe/fast/borders/border-image-outset-split-inline-expected.txt: Renamed from LayoutTests/platform/glib/fast/borders/border-image-outset-split-inline-expected.txt.
  • platform/wpe/fast/borders/border-styles-split-expected.txt: Renamed from LayoutTests/platform/glib/fast/borders/border-styles-split-expected.txt.
  • platform/wpe/fast/borders/rtl-border-04-expected.txt:
  • platform/wpe/fast/borders/rtl-border-05-expected.txt:
  • platform/wpe/fast/box-shadow/basic-shadows-expected.txt:
  • platform/wpe/fast/css/first-line-text-decoration-expected.txt:
  • platform/wpe/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
  • platform/wpe/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/wpe/fast/css/text-overflow-input-expected.txt:
  • platform/wpe/fast/dom/52776-expected.txt:
  • platform/wpe/fast/dom/HTMLElement/bdo-expected.txt:
  • platform/wpe/fast/inline-block/003-expected.txt:
  • platform/wpe/fast/text/cg-fallback-bolding-expected.txt:
  • platform/wpe/fast/text/firstline/001-expected.txt:
  • platform/wpe/fast/text/fixed-pitch-control-characters-expected.txt:
  • platform/wpe/fast/text/format-control-expected.txt:
  • platform/wpe/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/wpe/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/wpe/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/wpe/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/wpe/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/wpe/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/wpe/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/wpe/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/wpe/fast/text/international/bidi-listbox-expected.txt:
  • platform/wpe/fast/text/international/bidi-menulist-expected.txt:
  • platform/wpe/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/wpe/fast/text/international/bidi-override-expected.txt:
  • platform/wpe/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/wpe/fast/text/text-letter-spacing-expected.txt:
  • platform/wpe/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/wpe/http/tests/misc/acid3-expected.txt:
  • platform/wpe/tables/mozilla/core/bloomberg-expected.txt:
1:25 PM Changeset in webkit [287582] by ysuzuki@apple.com
  • 14 edits
    2 deletes in trunk/Source/JavaScriptCore

[JSC] Remove JSWebAssemblyCalleeGroup cell
​https://bugs.webkit.org/show_bug.cgi?id=234780

Reviewed by Saam Barati.

This cell is not observable to users. And this cell just holds Wasm-to-JS stubs,
but it is the same to all memory modes. Thus, we should just generate it in VM-linked
Wasm::Module (it means, we should have it in JSWebAssemblyModule), and we do not need
to have / allocate JSWebAssemblyCalleeGroup cell.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::deleteAllCodeBlocks):

  • heap/Heap.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • wasm/WasmBinding.h:
  • wasm/js/JSWebAssemblyCalleeGroup.cpp: Removed.
  • wasm/js/JSWebAssemblyCalleeGroup.h: Removed.
  • wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::visitChildrenImpl):
(JSC::JSWebAssemblyInstance::finalizeCreation):

  • wasm/js/JSWebAssemblyInstance.h:
  • wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::createStub):
(JSC::JSWebAssemblyModule::visitChildrenImpl):
(JSC::JSWebAssemblyModule::clearJSCallICs):
(JSC::JSWebAssemblyModule::finalizeUnconditionally):
(JSC::JSWebAssemblyModule::generateWasmToJSStubs):
(JSC::JSWebAssemblyModule::calleeGroup): Deleted.
(JSC::JSWebAssemblyModule::setCalleeGroup): Deleted.

  • wasm/js/JSWebAssemblyModule.h:
  • wasm/js/WebAssemblyModuleConstructor.cpp:
  • wasm/js/WebAssemblyWrapperFunction.h:
12:59 PM Changeset in webkit [287581] by Fujii Hironori
  • 2 edits in trunk

clang-format: Change SpaceAfterTemplateKeyword to false
​https://bugs.webkit.org/show_bug.cgi?id=234655

Reviewed by Don Olmstead.

Bug 183302 added the initial .clang-format file which were
including SpaceAfterTemplateKeyword:true. However, even though it
is undocumented, typical WebKit code is using a style having no
space ater the template keyword.

  • .clang-format:
11:21 AM Changeset in webkit [287580] by achristensen@apple.com
  • 2 edits in trunk/Tools

Re-disable WKInspectorExtensionDelegate.ExtensionTabNavigatedCallbacks API test in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=232857

I enabled it with an unrelated change and it is timing out, so re-disable it.

  • TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtensionDelegate.mm:

(TEST):

11:14 AM Changeset in webkit [287579] by Kate Cheney
  • 2 edits in trunk/Source/WebKit

Partial revert of ​https://trac.webkit.org/changeset/287371/webkit

RS by John Wilander.

Keep logging in for test debugging purposes.

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):

11:09 AM Changeset in webkit [287578] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Momentum Event Dispatcher: Disable noisy logging
​https://bugs.webkit.org/show_bug.cgi?id=234178
<rdar://problem/86228553>

Reviewed by Wenson Hsieh.

  • WebProcess/WebPage/MomentumEventDispatcher.h:
10:29 AM Changeset in webkit [287577] by Russell Epstein
  • 8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7612.4.9

10:21 AM Changeset in webkit [287576] by Russell Epstein
  • 42 edits
    5 copies in branches/safari-613.1.12.1-branch

Cherry-pick r287574. rdar://problem/86855896

[Cocoa] Hang in AVTrackPrivateAVFObjCImpl::bitrate()
​https://bugs.webkit.org/show_bug.cgi?id=234753

Reviewed by Eric Carlson.

Source/WebCore:

In r286908, WebCore added new queries onto existing AVAssetTrack objects; however, querying
those properties will block if data for those properties is not yet available. The media element
could block moving to the HAVE_METADATA state until those properties are fully loaded, however
this might regress PLT, so instead, we will check the load state of those properties before returning
values.

However, to make the properties exposed through VideoTrackConfiguration.idl/AudioTrackConfiguration.idl
dynamic, changes need to be signaled and propagated upward through the layers between AVAssetTrack and
the DOM. Rather than make individual notifications for each property in a Configuration struct, make one
notification that handles any change to the Configuration struct at all and push that upward to clients.

Since these properties are being grouped together at a lower-level, they do not need to be tracked
individually, and Video/AudioTrackConfigurationInit can just be aliased to a platform-defined struct.

  • html/track/AudioTrack.cpp: (WebCore::AudioTrack::configurationChanged): (WebCore::AudioTrack::updateConfigurationFromPrivate):
  • html/track/AudioTrack.h:
  • html/track/AudioTrackConfiguration.h: (WebCore::AudioTrackConfiguration::setState): (): Deleted.
  • html/track/VideoTrack.cpp: (WebCore::VideoTrack::configurationChanged): (WebCore::VideoTrack::updateConfigurationFromPrivate):
  • html/track/VideoTrack.h:
  • html/track/VideoTrackConfiguration.h: (WebCore::VideoTrackConfiguration::setState): (WebCore::VideoTrackConfiguration::colorSpace const): (WebCore::VideoTrackConfiguration::setColorSpace): (WebCore::VideoTrackConfiguration::VideoTrackConfiguration): (): Deleted.
  • platform/graphics/AudioTrackPrivate.h: (WebCore::AudioTrackPrivate::configuration const): (WebCore::AudioTrackPrivate::setConfiguration): (WebCore::AudioTrackPrivate::codec const): Deleted. (WebCore::AudioTrackPrivate::setCodec): Deleted. (WebCore::AudioTrackPrivate::sampleRate const): Deleted. (WebCore::AudioTrackPrivate::setSampleRate): Deleted. (WebCore::AudioTrackPrivate::numberOfChannels const): Deleted. (WebCore::AudioTrackPrivate::setNumberOfChannels): Deleted. (WebCore::AudioTrackPrivate::bitrate const): Deleted. (WebCore::AudioTrackPrivate::setBitrate): Deleted.
  • platform/graphics/AudioTrackPrivateClient.h:
  • platform/graphics/PlatformVideoColorSpace.h: (WebCore::operator==): (WebCore::operator!=):
  • platform/graphics/VideoTrackPrivate.h: (WebCore::VideoTrackPrivate::configuration const): (WebCore::VideoTrackPrivate::setConfiguration): (WebCore::VideoTrackPrivate::codec const): Deleted. (WebCore::VideoTrackPrivate::setCodec): Deleted. (WebCore::VideoTrackPrivate::width const): Deleted. (WebCore::VideoTrackPrivate::setWidth): Deleted. (WebCore::VideoTrackPrivate::height const): Deleted. (WebCore::VideoTrackPrivate::setHeight): Deleted. (WebCore::VideoTrackPrivate::colorSpace const): Deleted. (WebCore::VideoTrackPrivate::setColorSpace): Deleted. (WebCore::VideoTrackPrivate::framerate const): Deleted. (WebCore::VideoTrackPrivate::setFramerate): Deleted. (WebCore::VideoTrackPrivate::bitrate const): Deleted. (WebCore::VideoTrackPrivate::setBitrate): Deleted.
  • platform/graphics/VideoTrackPrivateClient.h:
  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h: (WebCore::AVTrackPrivateAVFObjCImpl::setVideoTrackConfigurationObserver): (WebCore::AVTrackPrivateAVFObjCImpl::setAudioTrackConfigurationObserver):
  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm: (WebCore::assetTrackConfigurationKeyNames): (WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): (WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack): (WebCore::AVTrackPrivateAVFObjCImpl::videoTrackConfiguration const): (WebCore::AVTrackPrivateAVFObjCImpl::audioTrackConfiguration const):
  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: (WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): (WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): (WebCore::AudioTrackPrivateAVFObjC::audioTrackConfigurationChanged):
  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp: (WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): (WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): (WebCore::VideoTrackPrivateAVFObjC::videoTrackConfigurationChanged):
  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm: (WebCore::VideoTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):
  • platform/graphics/cocoa/VideoTrackPrivateWebM.cpp: (WebCore::VideoTrackPrivateWebM::VideoTrackPrivateWebM): (WebCore::VideoTrackPrivateWebM::updateConfiguration):
  • platform/graphics/cocoa/VideoTrackPrivateWebM.h:

Source/WebKit:

Propagate changes to TrackConfigurations upwards from the GPU process -> WebContent process.

  • GPUProcess/media/AudioTrackPrivateRemoteConfiguration.h: (WebKit::AudioTrackPrivateRemoteConfiguration::encode const): (WebKit::AudioTrackPrivateRemoteConfiguration::decode):
  • GPUProcess/media/RemoteAudioTrackProxy.cpp: (WebKit::RemoteAudioTrackProxy::configuration): (WebKit::RemoteAudioTrackProxy::configurationChanged):
  • GPUProcess/media/RemoteAudioTrackProxy.h:
  • GPUProcess/media/RemoteVideoTrackProxy.cpp: (WebKit::RemoteVideoTrackProxy::configuration):
  • GPUProcess/media/RemoteVideoTrackProxy.h:
  • GPUProcess/media/TrackPrivateRemoteConfiguration.h: (WebKit::TrackPrivateRemoteConfiguration::encode const): (WebKit::TrackPrivateRemoteConfiguration::decode):
  • GPUProcess/media/VideoTrackPrivateRemoteConfiguration.h: (WebKit::VideoTrackPrivateRemoteConfiguration::encode const): (WebKit::VideoTrackPrivateRemoteConfiguration::decode):
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/GPU/media/AudioTrackPrivateRemote.cpp: (WebKit::AudioTrackPrivateRemote::AudioTrackPrivateRemote): (WebKit::AudioTrackPrivateRemote::updateConfiguration):
  • WebProcess/GPU/media/AudioTrackPrivateRemote.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::addRemoteAudioTrack): (WebKit::MediaPlayerPrivateRemote::remoteAudioTrackConfigurationChanged): (WebKit::MediaPlayerPrivateRemote::addRemoteVideoTrack): (WebKit::MediaPlayerPrivateRemote::remoteVideoTrackConfigurationChanged):
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
  • WebProcess/GPU/media/VideoTrackPrivateRemote.cpp: (WebKit::VideoTrackPrivateRemote::VideoTrackPrivateRemote): (WebKit::VideoTrackPrivateRemote::updateConfiguration):
  • WebProcess/GPU/media/VideoTrackPrivateRemote.h: (WebKit::VideoTrackPrivateRemote::create):

LayoutTests:

Now that these properties are dynamic, test them with testExpectedEventually.

  • media/track/audio-track-configuration.html:
  • media/track/video-track-alternate-groups-expected.txt:
  • media/track/video-track-configuration.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:10 AM Changeset in webkit [287575] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WebAssembly i32.atomic.wait timeout value incorrectly interpreted by factor 1000
​https://bugs.webkit.org/show_bug.cgi?id=234833

Reviewed by Michael Saboff.

Wasm atomics' timeout should be interpreted as nanoseconds.

  • wasm/WasmOperations.cpp:

(JSC::Wasm::wait):

10:08 AM Changeset in webkit [287574] by jer.noble@apple.com
  • 42 edits
    5 copies in trunk

[Cocoa] Hang in AVTrackPrivateAVFObjCImpl::bitrate()
​https://bugs.webkit.org/show_bug.cgi?id=234753

Reviewed by Eric Carlson.

Source/WebCore:

In r286908, WebCore added new queries onto existing AVAssetTrack objects; however, querying
those properties will block if data for those properties is not yet available. The media element
could block moving to the HAVE_METADATA state until those properties are fully loaded, however
this might regress PLT, so instead, we will check the load state of those properties before returning
values.

However, to make the properties exposed through VideoTrackConfiguration.idl/AudioTrackConfiguration.idl
dynamic, changes need to be signaled and propagated upward through the layers between AVAssetTrack and
the DOM. Rather than make individual notifications for each property in a Configuration struct, make one
notification that handles any change to the Configuration struct at all and push that upward to clients.

Since these properties are being grouped together at a lower-level, they do not need to be tracked
individually, and Video/AudioTrackConfigurationInit can just be aliased to a platform-defined struct.

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::configurationChanged):
(WebCore::AudioTrack::updateConfigurationFromPrivate):

  • html/track/AudioTrack.h:
  • html/track/AudioTrackConfiguration.h:

(WebCore::AudioTrackConfiguration::setState):
(): Deleted.

  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::configurationChanged):
(WebCore::VideoTrack::updateConfigurationFromPrivate):

  • html/track/VideoTrack.h:
  • html/track/VideoTrackConfiguration.h:

(WebCore::VideoTrackConfiguration::setState):
(WebCore::VideoTrackConfiguration::colorSpace const):
(WebCore::VideoTrackConfiguration::setColorSpace):
(WebCore::VideoTrackConfiguration::VideoTrackConfiguration):
(): Deleted.

  • platform/graphics/AudioTrackPrivate.h:

(WebCore::AudioTrackPrivate::configuration const):
(WebCore::AudioTrackPrivate::setConfiguration):
(WebCore::AudioTrackPrivate::codec const): Deleted.
(WebCore::AudioTrackPrivate::setCodec): Deleted.
(WebCore::AudioTrackPrivate::sampleRate const): Deleted.
(WebCore::AudioTrackPrivate::setSampleRate): Deleted.
(WebCore::AudioTrackPrivate::numberOfChannels const): Deleted.
(WebCore::AudioTrackPrivate::setNumberOfChannels): Deleted.
(WebCore::AudioTrackPrivate::bitrate const): Deleted.
(WebCore::AudioTrackPrivate::setBitrate): Deleted.

  • platform/graphics/AudioTrackPrivateClient.h:
  • platform/graphics/PlatformVideoColorSpace.h:

(WebCore::operator==):
(WebCore::operator!=):

  • platform/graphics/VideoTrackPrivate.h:

(WebCore::VideoTrackPrivate::configuration const):
(WebCore::VideoTrackPrivate::setConfiguration):
(WebCore::VideoTrackPrivate::codec const): Deleted.
(WebCore::VideoTrackPrivate::setCodec): Deleted.
(WebCore::VideoTrackPrivate::width const): Deleted.
(WebCore::VideoTrackPrivate::setWidth): Deleted.
(WebCore::VideoTrackPrivate::height const): Deleted.
(WebCore::VideoTrackPrivate::setHeight): Deleted.
(WebCore::VideoTrackPrivate::colorSpace const): Deleted.
(WebCore::VideoTrackPrivate::setColorSpace): Deleted.
(WebCore::VideoTrackPrivate::framerate const): Deleted.
(WebCore::VideoTrackPrivate::setFramerate): Deleted.
(WebCore::VideoTrackPrivate::bitrate const): Deleted.
(WebCore::VideoTrackPrivate::setBitrate): Deleted.

  • platform/graphics/VideoTrackPrivateClient.h:
  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:

(WebCore::AVTrackPrivateAVFObjCImpl::setVideoTrackConfigurationObserver):
(WebCore::AVTrackPrivateAVFObjCImpl::setAudioTrackConfigurationObserver):

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::assetTrackConfigurationKeyNames):
(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl):
(WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack):
(WebCore::AVTrackPrivateAVFObjCImpl::videoTrackConfiguration const):
(WebCore::AVTrackPrivateAVFObjCImpl::audioTrackConfiguration const):

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC):
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
(WebCore::AudioTrackPrivateAVFObjC::audioTrackConfigurationChanged):

  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:

(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC):
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack):
(WebCore::VideoTrackPrivateAVFObjC::videoTrackConfigurationChanged):

  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm:

(WebCore::VideoTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):

  • platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:

(WebCore::VideoTrackPrivateWebM::VideoTrackPrivateWebM):
(WebCore::VideoTrackPrivateWebM::updateConfiguration):

  • platform/graphics/cocoa/VideoTrackPrivateWebM.h:

Source/WebKit:

Propagate changes to TrackConfigurations upwards from the GPU process -> WebContent process.

  • GPUProcess/media/AudioTrackPrivateRemoteConfiguration.h:

(WebKit::AudioTrackPrivateRemoteConfiguration::encode const):
(WebKit::AudioTrackPrivateRemoteConfiguration::decode):

  • GPUProcess/media/RemoteAudioTrackProxy.cpp:

(WebKit::RemoteAudioTrackProxy::configuration):
(WebKit::RemoteAudioTrackProxy::configurationChanged):

  • GPUProcess/media/RemoteAudioTrackProxy.h:
  • GPUProcess/media/RemoteVideoTrackProxy.cpp:

(WebKit::RemoteVideoTrackProxy::configuration):

  • GPUProcess/media/RemoteVideoTrackProxy.h:
  • GPUProcess/media/TrackPrivateRemoteConfiguration.h:

(WebKit::TrackPrivateRemoteConfiguration::encode const):
(WebKit::TrackPrivateRemoteConfiguration::decode):

  • GPUProcess/media/VideoTrackPrivateRemoteConfiguration.h:

(WebKit::VideoTrackPrivateRemoteConfiguration::encode const):
(WebKit::VideoTrackPrivateRemoteConfiguration::decode):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/GPU/media/AudioTrackPrivateRemote.cpp:

(WebKit::AudioTrackPrivateRemote::AudioTrackPrivateRemote):
(WebKit::AudioTrackPrivateRemote::updateConfiguration):

  • WebProcess/GPU/media/AudioTrackPrivateRemote.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::addRemoteAudioTrack):
(WebKit::MediaPlayerPrivateRemote::remoteAudioTrackConfigurationChanged):
(WebKit::MediaPlayerPrivateRemote::addRemoteVideoTrack):
(WebKit::MediaPlayerPrivateRemote::remoteVideoTrackConfigurationChanged):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
  • WebProcess/GPU/media/VideoTrackPrivateRemote.cpp:

(WebKit::VideoTrackPrivateRemote::VideoTrackPrivateRemote):
(WebKit::VideoTrackPrivateRemote::updateConfiguration):

  • WebProcess/GPU/media/VideoTrackPrivateRemote.h:

(WebKit::VideoTrackPrivateRemote::create):

LayoutTests:

Now that these properties are dynamic, test them with testExpectedEventually.

  • media/track/audio-track-configuration.html:
  • media/track/video-track-alternate-groups-expected.txt:
  • media/track/video-track-configuration.html:
10:05 AM Changeset in webkit [287573] by achristensen@apple.com
  • 2 edits in trunk/Tools

Re-enable URLSchemeHandler.Leaks1 API test
​https://bugs.webkit.org/show_bug.cgi?id=234625

Reviewed by Darin Adler.

The test seems to not time out any more. I think it has been fixed without re-enabling the test.

  • TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:

(TEST):

9:35 AM Changeset in webkit [287572] by Russell Epstein
  • 2 edits in branches/safari-613.1.12.1-branch/Source/WebCore

Cherry-pick r287158. rdar://problem/86837893

Add an experimental VideoTrackConfiguration class and accessor on VideoTrack
​https://bugs.webkit.org/show_bug.cgi?id=230841
<rdar://problem/83837876>

Reviewed by Eric Carlson.

Follow up patch to address post-review comments.

Darin pointed out that CFStringCompare() is likely more expensive than
CFEqual() as the former determines order as well as equality, and a
safeCFEqual() already exists. And while safeCFEqual() has different
behavior than the safeCFStringEquals() lambda when passed two null values,
in every case where safeCFStringEquals() is used, the first parameter has
already been nil-checked. So safeCFStringEquals() is unnecessary and
safeCFEqual() should be used instead.

  • platform/graphics/avfoundation/FormatDescriptionUtilities.cpp: (WebCore::colorSpaceFromFormatDescription):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:35 AM Changeset in webkit [287571] by Russell Epstein
  • 2 edits in branches/safari-613.1.12.1-branch/Source/WebCore

Cherry-pick r286953. rdar://problem/86837893

Unreviewed build fix; add a convenience function to safely compare possibly null CFStringRefs.

  • platform/graphics/avfoundation/FormatDescriptionUtilities.cpp: (WebCore::presentationSizeFromFormatDescription): (WebCore::colorSpaceFromFormatDescription):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:31 AM Changeset in webkit [287570] by Russell Epstein
  • 9 edits in branches/safari-613.1.12.1-branch/Source

Versioning.

WebKit-7613.1.12.1.1

9:14 AM Changeset in webkit [287569] by Russell Epstein
  • 1 copy in branches/safari-613.1.12.1-branch

New branch.

8:11 AM Changeset in webkit [287568] by graouts@webkit.org
  • 7 edits in trunk

[Web Animations] changing the timing of a transition such that it's finished should no longer have it marked as running
​https://bugs.webkit.org/show_bug.cgi?id=234823

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progression.

  • web-platform-tests/css/css-transitions/CSSTransition-effect.tentative-expected.txt:

Source/WebCore:

Many factors could contribute to an animation entering its finished state. In case it's a transition,
we must remove it from the list of running transitions immediately, so we add a new virtual method when
the finished state is entered such that CSSTransition can implement this method and do the necessary
cleanup.

  • animation/CSSTransition.cpp:

(WebCore::CSSTransition::animationDidFinish):

  • animation/CSSTransition.h:
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::updateFinishedState):

  • animation/WebAnimation.h:

(WebCore::WebAnimation::animationDidFinish):

7:52 AM Changeset in webkit [287567] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

Unreviewed, reverting r283546.
​https://bugs.webkit.org/show_bug.cgi?id=234844

Causes bad scrolling behavior on Discourse pages

Reverted changeset:

"[css-position-sticky] scrollIntoView should not take into
account sticky positioning offsets"
​https://bugs.webkit.org/show_bug.cgi?id=230689
​https://commits.webkit.org/r283546

7:27 AM Changeset in webkit [287566] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK][a11y] Take into account the active descendant when setting focus related states with ATSPI
​https://bugs.webkit.org/show_bug.cgi?id=234751

Reviewed by Joanmarie Diggs.

  • accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::state const):

7:10 AM Changeset in webkit [287565] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GTK][a11y] Ensure ATSPI wrappers are destroyed in the main thread
​https://bugs.webkit.org/show_bug.cgi?id=234808

Reviewed by Joanmarie Diggs.

Sometimes they can be destroyed in the a11y thread, since we keep a reference when unregistering the objects.

  • accessibility/atspi/AccessibilityObjectAtspi.h:
  • accessibility/atspi/AccessibilityRootAtspi.h:
7:09 AM Changeset in webkit [287564] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK][a11y] Use invalid as role for detached objects in ATSPI
​https://bugs.webkit.org/show_bug.cgi?id=234835

Reviewed by Joanmarie Diggs.

We are using unknown by mistake.

  • accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::role const):

5:29 AM Changeset in webkit [287563] by Manuel Rego Casasnovas
  • 6 edits
    2 adds in trunk

[selectors] :focus-visible not matching on accessKey focus after focusing something via mouse
​https://bugs.webkit.org/show_bug.cgi?id=234077
<rdar://problem/86572561>

Reviewed by Antti Koivisto.

Source/WebCore:

This patch adds Element::focusForBindings() to differentitate when this is called from JavaScript.
If that's the case it pass a new FocusTrigger::Bindings value to Element::focus(),
so we can differentiate when this was called from some internal code or from JavaScript.

When Element::focus() has been called internally, we always want to show the focus ring
(thus pass FocusVisibility::Visible). However when it's called from a script
we'll set it to Visible or Invisible depending on if the previously focused element
was focused via mouse click or not (this is needed to pass
the css/selectors/focus-visible-script-focus-* tests from WPT repository).

Test: fast/selectors/focus-visible-accesskey.html

  • dom/Element.cpp:

(WebCore::Element::focus):
(WebCore::Element::focusForBindings):

  • dom/Element.h:

(WebCore::Element::focusForBindings):

  • dom/FocusOptions.h:
  • html/HTMLOrForeignElement.idl:

LayoutTests:

Writing an internal test as WPT tests for this don't work due to webkit.org/b/234139.

  • fast/selectors/focus-visible-accesskey-expected.txt: Added.
  • fast/selectors/focus-visible-accesskey.html: Added.
5:05 AM Changeset in webkit [287562] by commit-queue@webkit.org
  • 2 edits in trunk/Source/bmalloc

[PAS] constant-logical-operand clang warnings
​https://bugs.webkit.org/show_bug.cgi?id=234814

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-01-04
Reviewed by Martin Robinson.

  • libpas/src/libpas/pas_config_prefix.h: Use double exclamation marks in declarations to

force the compiler to interpret them as booleans and avoid constant-logical-operand
warnings.

Note: See TracTimeline for information about the timeline view.