⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 13, 2022:

11:51 PM Changeset in webkit [288009] by graouts@webkit.org
  • 55 edits
    13 copies
    13 moves
    172 adds
    6 deletes in trunk/LayoutTests

Update WPT for css/css-pseudo
​https://bugs.webkit.org/show_bug.cgi?id=235197

Unreviewed WPT import.

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/css/css-pseudo/README.md:
  • web-platform-tests/css/css-pseudo/active-selection-011.html:
  • web-platform-tests/css/css-pseudo/active-selection-012-expected.html:
  • web-platform-tests/css/css-pseudo/active-selection-012.html:
  • web-platform-tests/css/css-pseudo/active-selection-016.html:
  • web-platform-tests/css/css-pseudo/active-selection-018.html:
  • web-platform-tests/css/css-pseudo/active-selection-021.html:
  • web-platform-tests/css/css-pseudo/active-selection-025.html:
  • web-platform-tests/css/css-pseudo/active-selection-027.html:
  • web-platform-tests/css/css-pseudo/active-selection-031.html:
  • web-platform-tests/css/css-pseudo/active-selection-041-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-041-expected.html.
  • web-platform-tests/css/css-pseudo/active-selection-043.html:
  • web-platform-tests/css/css-pseudo/active-selection-045.html:
  • web-platform-tests/css/css-pseudo/active-selection-051-ref.html: Added.
  • web-platform-tests/css/css-pseudo/active-selection-056.html:
  • web-platform-tests/css/css-pseudo/active-selection-057.html:
  • web-platform-tests/css/css-pseudo/active-selection-063.html:
  • web-platform-tests/css/css-pseudo/backdrop-animate-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/before-after-dynamic-custom-property-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/cascade-highlight-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012-expected.html.
  • web-platform-tests/css/css-pseudo/cascade-highlight-001.html:
  • web-platform-tests/css/css-pseudo/cascade-highlight-002.html:
  • web-platform-tests/css/css-pseudo/cascade-highlight-004-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012-expected.html.
  • web-platform-tests/css/css-pseudo/cascade-highlight-004.html:
  • web-platform-tests/css/css-pseudo/cascade-highlight-005-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012-expected.html.
  • web-platform-tests/css/css-pseudo/cascade-highlight-005.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/cascade-highlight-004.html.
  • web-platform-tests/css/css-pseudo/file-selector-button-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-001-expected.html.
  • web-platform-tests/css/css-pseudo/file-selector-button-after-part-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-after-part-expected.html.
  • web-platform-tests/css/css-pseudo/file-selector-button-inherit-expected.txt: Added.
  • web-platform-tests/css/css-pseudo/file-selector-button-inherit.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-001.html:
  • web-platform-tests/css/css-pseudo/first-letter-002.html:
  • web-platform-tests/css/css-pseudo/first-letter-003.html:
  • web-platform-tests/css/css-pseudo/first-letter-004-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-004.html:
  • web-platform-tests/css/css-pseudo/first-letter-005-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-and-whitespace-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-background-image-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-block-to-inline-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-exclude-block-child-marker-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-exclude-inline-child-marker-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-exclude-inline-marker-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-hi-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-hi-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-hi-001.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-hi-002-expected.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-hi-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-hi-002.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-list-item-dynamic-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-of-html-root-crash-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-opacity-001-not-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-opacity-001-ref-expected.html.
  • web-platform-tests/css/css-pseudo/first-letter-opacity-001-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-opacity-001-ref-expected.html.
  • web-platform-tests/css/css-pseudo/first-letter-opacity-float-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-punctuation-and-space-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-punctuation-and-space.html:
  • web-platform-tests/css/css-pseudo/first-letter-punctuation-dynamic-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-skip-empty-span-nested-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-skip-empty-span-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-skip-marker-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-width-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-with-quote-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-letter-with-span-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-and-marker-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-and-placeholder-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-change-inline-color-nested-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-change-inline-color-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-line-height-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-line-height-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-line-height-001.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-line-height-002-expected.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-line-height-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-line-height-002.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-on-ancestor-block-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-opacity-001-not-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-opacity-001-ref-expected.html.
  • web-platform-tests/css/css-pseudo/first-line-opacity-001-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-opacity-001-ref-expected.html.
  • web-platform-tests/css/css-pseudo/first-line-replaced-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-with-before-after-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-with-inline-block-before-ref.html: Added.
  • web-platform-tests/css/css-pseudo/first-line-with-out-of-flow-ref.html: Added.
  • web-platform-tests/css/css-pseudo/grammar-error-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/grammar-error-001.html.
  • web-platform-tests/css/css-pseudo/grammar-error-001.html:
  • web-platform-tests/css/css-pseudo/grammar-spelling-errors-001.html:
  • web-platform-tests/css/css-pseudo/grammar-spelling-errors-002.html:
  • web-platform-tests/css/css-pseudo/highlight-cascade-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-001.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-002-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-002.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-003-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-003-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-003.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-004-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-004-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-cascade-004.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-painting-001-expected.html:
  • web-platform-tests/css/css-pseudo/highlight-painting-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-001-expected.html.
  • web-platform-tests/css/css-pseudo/highlight-painting-001.html:
  • web-platform-tests/css/css-pseudo/highlight-painting-002-expected.html:
  • web-platform-tests/css/css-pseudo/highlight-painting-002-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-002-expected.html.
  • web-platform-tests/css/css-pseudo/highlight-painting-002.html:
  • web-platform-tests/css/css-pseudo/highlight-painting-003-expected.html:
  • web-platform-tests/css/css-pseudo/highlight-painting-003-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003-expected.html.
  • web-platform-tests/css/css-pseudo/highlight-painting-003.html:
  • web-platform-tests/css/css-pseudo/highlight-painting-004-expected.html:
  • web-platform-tests/css/css-pseudo/highlight-painting-004-ref1.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-004-expected.html.
  • web-platform-tests/css/css-pseudo/highlight-painting-004-ref2.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-painting-004-ref3.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-painting-004.html:
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-001.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-002-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-002.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-003-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-003-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-003.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-004-notref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.tentative-expected-mismatch.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.tentative.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-005-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-005.tentative-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-005.tentative.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-006-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-006-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-paired-cascade-006.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-styling-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-styling-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-styling-001.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-styling-002-expected.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-styling-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-styling-002.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-z-index-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-z-index-001.html:
  • web-platform-tests/css/css-pseudo/highlight-z-index-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/highlight-z-index-002.html:
  • web-platform-tests/css/css-pseudo/marker-and-other-pseudo-elements-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-animate-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-color-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-003-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-004-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-005-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-006-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-007-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-008-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-009-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-011-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-012-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-013-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-014-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-015-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-016-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-017-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-018-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-019-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-020-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-021-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-022-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-023-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-content-024-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-font-properties-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-font-variant-numeric-default-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-font-variant-numeric-default-ref-expected.html.
  • web-platform-tests/css/css-pseudo/marker-font-variant-numeric-normal-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-font-variant-numeric-normal-ref-expected.html.
  • web-platform-tests/css/css-pseudo/marker-hyphens-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-inherit-line-height-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-inherit-values-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-intrinsic-contribution-002-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-line-break-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-line-height-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-tab-size-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-text-align-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-text-combine-upright-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-text-decoration-skip-ink-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-text-emphasis-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-text-shadow-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-text-transform-default-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-text-transform-uppercase-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-unicode-bidi-default-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-unicode-bidi-default-ref-expected.html.
  • web-platform-tests/css/css-pseudo/marker-unicode-bidi-normal-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-unicode-bidi-normal-ref-expected.html.
  • web-platform-tests/css/css-pseudo/marker-word-break-ref.html: Added.
  • web-platform-tests/css/css-pseudo/marker-word-spacing-ref.html: Added.
  • web-platform-tests/css/css-pseudo/outside-marker-paint-order-ref.html: Added.
  • web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
  • web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
  • web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation.html:
  • web-platform-tests/css/css-pseudo/parsing/marker-supported-properties.html:
  • web-platform-tests/css/css-pseudo/placeholder-inherit-expected.txt: Added.
  • web-platform-tests/css/css-pseudo/placeholder-inherit.html: Added.
  • web-platform-tests/css/css-pseudo/placeholder-input-number-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/placeholder-input-number-expected.html.
  • web-platform-tests/css/css-pseudo/selection-background-painting-order-expected.html: Added.
  • web-platform-tests/css/css-pseudo/selection-background-painting-order-ref1.html: Added.
  • web-platform-tests/css/css-pseudo/selection-background-painting-order-ref2.html: Added.
  • web-platform-tests/css/css-pseudo/selection-background-painting-order.html: Added.
  • web-platform-tests/css/css-pseudo/selection-contenteditable-011.html:
  • web-platform-tests/css/css-pseudo/selection-decoration-p1-expected.html: Removed.
  • web-platform-tests/css/css-pseudo/selection-decoration-p2-expected.html: Removed.
  • web-platform-tests/css/css-pseudo/selection-decoration-p2.html: Removed.
  • web-platform-tests/css/css-pseudo/selection-decoration-p3-expected.html: Removed.
  • web-platform-tests/css/css-pseudo/selection-decoration-p4-expected.html: Removed.
  • web-platform-tests/css/css-pseudo/selection-decoration-p4.html: Removed.
  • web-platform-tests/css/css-pseudo/selection-input-011.html:
  • web-platform-tests/css/css-pseudo/selection-originating-decoration-color-expected.html: Added.
  • web-platform-tests/css/css-pseudo/selection-originating-decoration-color-ref.html: Added.
  • web-platform-tests/css/css-pseudo/selection-originating-decoration-color.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/selection-decoration-p3.html.
  • web-platform-tests/css/css-pseudo/selection-originating-strikethrough-order-expected.html: Added.
  • web-platform-tests/css/css-pseudo/selection-originating-strikethrough-order-ref.html: Added.
  • web-platform-tests/css/css-pseudo/selection-originating-strikethrough-order.html: Added.
  • web-platform-tests/css/css-pseudo/selection-originating-underline-order-expected.html: Added.
  • web-platform-tests/css/css-pseudo/selection-originating-underline-order-ref.html: Added.
  • web-platform-tests/css/css-pseudo/selection-originating-underline-order.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/selection-decoration-p1.html.
  • web-platform-tests/css/css-pseudo/selection-overlay-and-grammar-001.html:
  • web-platform-tests/css/css-pseudo/selection-overlay-and-spelling-001.html:
  • web-platform-tests/css/css-pseudo/selection-paint-image-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/selection-paint-image-expected.html.
  • web-platform-tests/css/css-pseudo/selection-textarea-011.html:
  • web-platform-tests/css/css-pseudo/spelling-error-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/spelling-error-001.html.
  • web-platform-tests/css/css-pseudo/spelling-error-001.html:
  • web-platform-tests/css/css-pseudo/target-text-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-001.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-002-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-002.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-003-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-003.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-004-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-004.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-005-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-005.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-006-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-006.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-007-expected.txt: Added.
  • web-platform-tests/css/css-pseudo/target-text-007.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-001.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-002-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-002.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-003-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-003.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-004-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-dynamic-004.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-lime-green-ref.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-lime-ref.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-text-decoration-001-expected.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-text-decoration-001-ref.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-text-decoration-001.html: Added.
  • web-platform-tests/css/css-pseudo/target-text-two-words-ref.html: Added.
  • web-platform-tests/css/css-pseudo/textpath-selection-011-expected.html:
  • web-platform-tests/css/css-pseudo/textpath-selection-011-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/textpath-selection-011-expected.html.
  • web-platform-tests/css/css-pseudo/textpath-selection-011.html:
  • web-platform-tests/css/css-pseudo/w3c-import.log:

LayoutTests:

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
10:15 PM Changeset in webkit [288008] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Don't call invalidateRectsForAllMarkers() for every layer in the updateLayerPositions() traversal
​https://bugs.webkit.org/show_bug.cgi?id=235211

Reviewed by Alan Bujtas.

RenderLayer::updateLayerPositions() called renderer().document().markers().invalidateRectsForAllMarkers()
but that is called on every layer in the recursive updateLayerPositions() traveral. Yet it only needs
to be called once.

So differentiate the entry points for layer traversal from the recursive traversal functions
by using "recursive" in the naming of the latter, and move two of those entrypoints from
RenderLayerScrollableArea back to RenderLayer so everything is in the same file.

Now the entrypoints can call willUpdateLayerPositions() which does the invalidateRectsForAllMarkers().

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayerPositionsAfterScrolling):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::willUpdateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterStyleChange):
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::recursiveUpdateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll):
(WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll):
(WebCore::RenderLayer::recursiveUpdateLayerPositionsAfterScroll):
(WebCore::RenderLayer::updateLayerPositions): Deleted.
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Deleted.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::recursiveUpdateLayerPositionsAfterScroll):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Deleted.

  • rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::scrollTo):
(WebCore::RenderLayerScrollableArea::updateLayerPositionsAfterDocumentScroll): Deleted.
(WebCore::RenderLayerScrollableArea::updateLayerPositionsAfterOverflowScroll): Deleted.

  • rendering/RenderLayerScrollableArea.h:
8:37 PM Changeset in webkit [288007] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[RISCV64] riscv64 backend should lower offlineasm instructions
​https://bugs.webkit.org/show_bug.cgi?id=234952
<rdar://problem/87440612>

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2022-01-13
Reviewed by Yusuke Suzuki.

In the riscv64 offlineasm backend, instead of handling higher-level
offlineasm instructions with different operand combinations and manually
juggling temp registers, use the approach of aggressively lowering these
opcodes into sequences of RISC-V instructions.

Addresses and immediate values are lowered into usable forms where
necessary. Different lowering phases handle any offlineasm instruction
so that the resulting opcodes can be, with accompanying operands, used
trivially to construct the RISC-V assembly.

Lowered RISC-V opcodes use the 'rv_' prefix so that they can be easily
diassociated from any offlineasm opcode that might share the same name.
The prefix is removed when the assembly is finally generated.

  • offlineasm/riscv64.rb:
7:25 PM Changeset in webkit [288006] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[Cleanup] Line::selectionState logic is slightly confusing and redundant
​https://bugs.webkit.org/show_bug.cgi?id=235187

Reviewed by Antti Koivisto.

Go from a seemingly random set of conditions to a incremental state change (None -> Start -> Inside -> End).

(This also removes redundant code like "if (state == None
((boxState == Start boxState == End) && (state == None state == Inside)))"

and clears up what "state" here actually means.)

  • layout/integration/InlineIteratorLine.cpp:

(WebCore::InlineIterator::Line::selectionState const):

7:14 PM Changeset in webkit [288005] by Chris Dumez
  • 9 edits in trunk

Unable to have new lines in HTMLTextArea's placeholder text
​https://bugs.webkit.org/show_bug.cgi?id=235205

Reviewed by Wenson Hsieh.

Source/WebCore:

Unlike the placeholder for HTMLInputElement, the placeholder for HTMLTextAreaElement needs
to allow new lines as per:

This aligns our behavior with Blink and Gecko.

No new tests, unskipped existing WPT tests.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::placeholder const):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder const): Deleted.

  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):

LayoutTests:

Unskip WPT tests that are no longer failing.

7:06 PM Changeset in webkit [288004] by Chris Dumez
  • 6 edits in trunk

html/semantics/scripting-1/the-script-element/script-type-and-language-empty.html WPT test is failing
​https://bugs.webkit.org/show_bug.cgi?id=235202

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-type-and-language-empty-expected.txt:

Source/WebCore:

Per ​https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script (step 8), we should assume
the type is "text/javascript" if the type attribute is present and its value is the empty string.
Our logic in ScriptElement::determineScriptType() was slightly wrong and didn't get this case right
because it was doing an isEmpty() check which could mean both that the attribute is missing or present
with a value that is the empty string.

No new tests, rebaselined existing test.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::determineScriptType const):

6:53 PM Changeset in webkit [288003] by Cameron McCormack
  • 3 edits
    2 adds in trunk

Only apply automatic minimum block-size aspect-ratio rules to non-replaced elements
​https://bugs.webkit.org/show_bug.cgi?id=235058
<rdar://85505101>

Reviewed by Alan Bujtas.

Source/WebCore:

The rules in ​https://www.w3.org/TR/css-sizing-4/#aspect-ratio-minimum
that define the automatic minimum size of an element subject to an
aspect-ratio only apply if the element is non-replaced.

In constrainLogicalHeightByMinMax specifically, when min-height is
auto, after applying the aspect-ratio to produce an automatic minimum
height, we bump it up to the content height if the element has
children. This, presumably, is to account for the way the height of a
block is computed in CSS 2.2. (As CSS 2.2 doesn't have an auto value
for min-height, and a CSS Block Layout module has not been written in
terms of CSS Sizing concepts, there is no clear definition of
automatic minimum sizing for blocks at the moment.) If we erroneously
apply this to a replaced element, such as an image or video, it can
get a computed min-height equal to the intrinsic height of the image,
which may be much larger than expected.

This commit adds an is<RenderReplaced>() check for both automatic
minimum logical width and height calculations, although I was unable to
produce a test to exercise the logical width case (which does not take
the intrinsic size into account when computing the automatic minimum).

Test: fast/css/aspect-ratio-min-height-replaced.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
(WebCore::RenderBox::constrainLogicalHeightByMinMax const):

LayoutTests:

Test that replaced elements with child content (in this case, a
<video> element's controls in the UA shadow tree) don't influence the
automatic minimum size calculation.

  • fast/css/aspect-ratio-min-height-replaced-expected.html: Added.
  • fast/css/aspect-ratio-min-height-replaced.html: Added.
6:40 PM Changeset in webkit [288002] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Link Wasm code on the same thread that JITs
​https://bugs.webkit.org/show_bug.cgi?id=235201

Reviewed by Yusuke Suzuki and Mark Lam.

This is preparing us for the changes that'll be needed by
​https://bugs.webkit.org/show_bug.cgi?id=235192.

It should also be a small perf improvement, as we're now linking
in parallel instead of doing it after all compilations have finished.

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompileB3):

  • wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::prepareImpl):
(JSC::Wasm::BBQPlan::compileFunction):
(JSC::Wasm::BBQPlan::didCompleteCompilation):
(JSC::Wasm::BBQPlan::initializeCallees):

  • wasm/WasmBBQPlan.h:
5:57 PM Changeset in webkit [288001] by Russell Epstein
  • 1 copy in tags/Safari-613.1.13

Tag Safari-613.1.13.

5:15 PM Changeset in webkit [288000] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Move the code that computes layer content visibility into its own function
​https://bugs.webkit.org/show_bug.cgi?id=235195

Reviewed by Alan Bujtas.

Just move into its own function the code with the odd-looking RenderObject walk that looks
for visibility:visible non-layer children in a visibility:hidden ancestor.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateDescendantDependentFlags):
(WebCore::RenderLayer::computeHasVisibleContent const):

  • rendering/RenderLayer.h:
5:01 PM Changeset in webkit [287999] by commit-queue@webkit.org
  • 23 edits in trunk/Source

[XCBuild] Add "product dependencies" which influence workspace build order
​https://bugs.webkit.org/show_bug.cgi?id=235094

Source/JavaScriptCore:

Some ancillary targets (e.g. script-only targets like Derived Sources) do not have implicit
dependencies visible to Xcode. In workspace builds, we need to give XCBuild additional
information to ensure that they always run after their dependencies.

This patch adds "Product Dependencies" phases, which are Copy Files phases that copy the
_product_ of another dependency. The product names are also added to
EXCLUDED_SOURCE_FILE_NAMES, making the actual copy a no-op, but these phases give XCBuild
enough metadata to infer the relationship between targets.

For example, JavaScriptCore's "Generate Unified Sources" target depends on headers from WTF,
so it lists libWTF.a in its Product Dependencies. Xcode sees the relationship between the
target doing the copy (Generate Unified Sources) and the target which produces the product
(WTF) and schedules them accordingly.

Because these dependencies are _implicit_ and the copy phases are no-ops, they do not
influence command-line or production builds where each project is built separately.

Patch by Elliott Williams <Elliott Williams> on 2022-01-13
Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Add EXCLUDED_SOURCE_FILE_NAMES
  • Configurations/JavaScriptCore.xcconfig: Inherit EXCLUDED_SOURCE_FILE_NAMES
  • JavaScriptCore.xcodeproj/project.pbxproj: Add Product Dependencies

Source/WebCore:

Patch by Elliott Williams <Elliott Williams> on 2022-01-13
Reviewed by Alexey Proskuryakov.

No tests, build system only.

  • Configurations/Base.xcconfig: Add EXCLUDED_SOURCE_FILE_NAMES
  • Configurations/WebCore.xcconfig: Inherit EXCLUDED_SOURCE_FILE_NAMES
  • WebCore.xcodeproj/project.pbxproj: Add Product Dependencies

Source/WebCore/PAL:

Patch by Elliott Williams <Elliott Williams> on 2022-01-13
Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Add EXCLUDED_SOURCE_FILE_NAMES
  • Configurations/PAL.xcconfig: Inherit EXCLUDED_SOURCE_FILE_NAMES
  • PAL.xcodeproj/project.pbxproj: Add Product Dependencies

Source/WebInspectorUI:

Patch by Elliott Williams <Elliott Williams> on 2022-01-13
Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Add EXCLUDED_SOURCE_FILE_NAMES
  • WebInspectorUI.xcodeproj/project.pbxproj: Add Product Dependencies

Source/WebKit:

Patch by Elliott Williams <Elliott Williams> on 2022-01-13
Reviewed by Alexey Proskuryakov.

  • Configurations/WebKit.xcconfig: Add EXCLUDED_SOURCE_FILE_NAMES
  • WebKit.xcodeproj/project.pbxproj: Add Product Dependencies

Source/WTF:

Patch by Elliott Williams <Elliott Williams> on 2022-01-13
Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Add EXCLUDED_SOURCE_FILE_NAMES
  • Configurations/WTF.xcconfig: Inherit EXCLUDED_SOURCE_FILE_NAMES
  • WTF.xcodeproj/project.pbxproj: Add Product Dependencies
3:47 PM Changeset in webkit [287998] by Adrian Perez de Castro
  • 5 edits in trunk/Source/WebCore

Non-unified build fixes, mid January 2022 edition
​https://bugs.webkit.org/show_bug.cgi?id=235180

Unreviewed non-unified build fixes.

No new tests needed.

  • platform/graphics/filters/SourceAlpha.cpp: Add missing ImageBuffer.h header.
  • svg/SVGFEPointLightElement.cpp: Add missing FilterEffectVector.h header.
  • svg/SVGFESpotLightElement.cpp: Add missing headers FilterEffectVector.h,

GeometryUtilities.h, and ImageBuffer.h.

  • svg/graphics/filters/SVGFilterBuilder.h: Add missing FilterEffectVector.h header.
3:44 PM Changeset in webkit [287997] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Sometimes cannot scroll after using internal trackpad
​https://bugs.webkit.org/show_bug.cgi?id=235206
<rdar://problem/87274541>

Reviewed by Simon Fraser.

  • WebProcess/WebPage/MomentumEventDispatcher.cpp:

(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
(WebKit::MomentumEventDispatcher::setScrollingAccelerationCurve):

  • WebProcess/WebPage/MomentumEventDispatcher.h:

We store std::optional<ScrollingAccelerationCurve> in a map, but then
when looking at whether we have a curve (to decide whether or not to even
use MomentumEventDispatcher), we check if the map has *any* value for the
given page... even an unengaged optional. To fix, check if the optional is engaged.

3:19 PM Changeset in webkit [287996] by Chris Dumez
  • 11 edits in trunk

Implement HTMLScriptElement.supports(type) method
​https://bugs.webkit.org/show_bug.cgi?id=229929
<rdar://problem/82933899>

Reviewed by Geoff Garen and Darin Adler.

LayoutTests/imported/w3c:

Rebaseline test now that more checks are passing.

  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-supports-expected.txt:

Source/WebCore:

Implement HTMLScriptElement.supports(type) method which was fairly recently
introduced in the HTML specification:

Blink and Gecko already implement this.

No new tests, rebaselined existing tests.

  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl:

LayoutTests:

Rebaseline test now that more checks are passing.

  • platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
3:04 PM Changeset in webkit [287995] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Avoid unnecessary call to windowScreenDidChange
​https://bugs.webkit.org/show_bug.cgi?id=235198
<rdar://87458502>

Reviewed by Geoffrey Garen.

It is a page load performance progression to avoid this call in initWithDrawingAreaProxy.

  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(-[WKOneShotDisplayLinkHandler initWithDrawingAreaProxy:]):

2:45 PM Changeset in webkit [287994] by fpizlo@apple.com
  • 3 edits in trunk/Source/bmalloc

[libpas] pas_segregated_page_lock_with_mode in try_lock mode should check that the page still uses the lock after the try_lock
​https://bugs.webkit.org/show_bug.cgi?id=235203

Reviewed by Yusuke Suzuki.

The bug I was trying to find by assertions in bug 235190 is that lock_with_mode has an incorrect
implementation of the try_lock case. It forgets to check if the lock it acquired is the right one
after locking.

I don't know how to test this without writing a test that is very gross. It's a super subtle race
condition - one that would be hard to reliably trigger even if I used the race_test_hooks
functionality.

  • libpas/src/libpas/pas_local_allocator.c:

(stop_impl):

  • libpas/src/libpas/pas_segregated_page_inlines.h:

(pas_segregated_page_switch_lock_with_mode):

1:53 PM Changeset in webkit [287993] by commit-queue@webkit.org
  • 5 edits
    2 moves
    3 adds in trunk

null ptr deref while trying to access DeferredPromise::promise()
​https://bugs.webkit.org/show_bug.cgi?id=234447

Patch by Gabriel Nava Marino <​gnavamarino@apple.com> on 2022-01-13
Reviewed by Darin Adler.

Source/WebCore:

The sequence of steps is as follows:
1) In Document::~Document() the parent class ScriptExecutionContext::~ScriptExecutionContext() destroys the context

on all m_destructionObservers.

2) One of these objects is a DeferredPromise created earlier and stored in the JSCustomElementRegistry's promiseMap.
3) Destroying the context via DOMGuardedObject::contextDestroyed() nulls out m_globalObject.
4) Later, an event listener is invoked and tries to access the DeferredPromise stored in the

JSCustomElementRegistry's promiseMap.

5) However, this DeferredPromise has a null m_globalObject and we crash after trying to access it.

We should check in DeferredPromise::promise() if isEmpty().
This is true when the DeferredPromise's context has been destroyed in DOMGuardedObject::contextDestroyed().

Tests: fast/js-promise/js-promise-from-detached-iframe.html

fast/js-promise/js-promise-invalid-context-access.html

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::promise const):

LayoutTests:

  • fast/js-promise/js-promise-from-detached-iframe-expected.txt: Renamed from LayoutTests/fast/js-promise-from-detached-iframe-expected.txt.
  • fast/js-promise/js-promise-from-detached-iframe.html: Renamed from LayoutTests/fast/js-promise-from-detached-iframe.html.
  • fast/js-promise/js-promise-invalid-context-access-expected.txt: Added.
  • fast/js-promise/js-promise-invalid-context-access.html: Added.
  • platform/ios/TestExpectations:
  • platform/win/TestExpectations:
1:25 PM Changeset in webkit [287992] by Wenson Hsieh
  • 6 edits
    1 add in trunk

Crash in Document::updateStyleIfNeeded() when removing a node containing the drag caret
​https://bugs.webkit.org/show_bug.cgi?id=235184
rdar://74845918

Reviewed by Darin Adler.

Source/WebCore:

While performing drag and drop over editable content, DragCaretController handles updating and painting a drag
caret, which indicates where the dragged content will be inserted upon drop. If the node containing this drag
caret is disconnected, DragCaretController::nodeWillBeRemoved() resets the drag caret position and issues a
repaint on the renderer responsible for drawing the drag caret. This call to nodeWillBeRemoved() occurs in the
middle of node removal, so it's encapsulated by a ScriptDisallowedScope::InMainThread scope which causes a
release assertion in WebKit2 if anything tries to trigger layout or style updates.

Currently, if the node being removed would cause the caret position to be removed as well, DragCaretController
calls into setCaretPosition() with a null visible position, which then calls into invalidateCaretRect with
the current caret position's anchor node. In turn, invalidateCaretRect contains logic to issue a repaint on
the anchor node's renderer if the node is editable. However, to check whether the node is editable, we use the
helper function WebCore::isEditableNode(), which triggers a style update if needed, only in the case where:

  1. A style recalc is needed, and...
  2. The document contains an element with the -webkit-user-modify CSS property.

As such, dirtying element styles right before removing the drag caret's anchor node from the document while
dispatching a drag or drop event in an editor with -webkit-user-modify: read-write; is sufficient to
trigger the release assertion and cause a crash.

To address this, instead of calling clear() inside of DragCaretController::nodeWillBeRemoved(), we can
instead directly invalidate the caret rect using the current drag caret anchor (passing in true for
caretRectChanged() since we already know that the drag caret is being cleared out), and then reset the current
drag caret position and caret rect. This allows us to avoid the isEditableNode() check in this scenario when
deciding whether to trigger paint invalidation, which is unnecessary because we already know that the node
containing the caret is being removed, so the renderer is going to be repainted anyways. We also pull this logic
out into a separate helper method, clearCaretPositionWithoutUpdatingStyle(), to make it clear that we must
avoid triggering style recalc here.

Test: DragAndDropTests.DoNotCrashWhenRemovingNodeOnDrop

  • editing/FrameSelection.cpp:

(WebCore::DragCaretController::nodeWillBeRemoved):
(WebCore::DragCaretController::clearCaretPositionWithoutUpdatingStyle):

  • editing/FrameSelection.h:

Tools:

Add a test to exercise the crash using drag and drop in WebKit2, on both iOS and macOS.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/remove-node-on-drop.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:

(TEST):

1:12 PM Changeset in webkit [287991] by fpizlo@apple.com
  • 4 edits in trunk/Source/bmalloc

[libpas] add assertions that we aren't switching to a NULL lock
​https://bugs.webkit.org/show_bug.cgi?id=235190

Reviewed by Yusuke Suzuki.

This adds a pas_panic call when pas_local_allocator_stop sees a NULL page->lock_ptr. That's one
possible explanation of a very rare crash I'm seeing where return_memory_to_page fails its assertion
that we are holding the page lock.

This also adds TESTING asserts in a bunch of other places. The PAS_TESTING_ASSERTS about this are in
places that are perf-sensitive, so we probably cannot assert in production. The hope behind those is
that it will help to catch this issue in test_pas.

  • libpas/src/libpas/pas_local_allocator.c:

(stop_impl):

  • libpas/src/libpas/pas_segregated_page.c:

(pas_segregated_page_switch_lock_and_rebias_while_ineligible_impl):

  • libpas/src/libpas/pas_segregated_page_inlines.h:

(pas_segregated_page_lock_with_unbias_not_utility):
(pas_segregated_page_lock_with_unbias):
(pas_segregated_page_lock):
(pas_segregated_page_switch_lock_impl):
(pas_segregated_page_switch_lock_with_mode):

1:11 PM Changeset in webkit [287990] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS][Networking] Add access to required network service
​https://bugs.webkit.org/show_bug.cgi?id=235188
<rdar://86781432>

Reviewed by Brent Fulgham.

Add access to required network service in the Networking process on iOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
1:03 PM Changeset in webkit [287989] by Russell Epstein
  • 1 copy in tags/Safari-612.4.9.1.4

Tag Safari-612.4.9.1.4.

12:59 PM Changeset in webkit [287988] by Russell Epstein
  • 8 edits in branches/safari-612.4.9.1-branch/Source

Versioning.

WebKit-7612.4.9.1.4

12:34 PM Changeset in webkit [287987] by graouts@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove use of PseudoElement in ComputedStyleExtractor
​https://bugs.webkit.org/show_bug.cgi?id=235158

Reviewed by Darin Adler.

When we fixed bug 234987, the easiest thing was to add some code that uses PseudoElement,
which was already used in several places in ComputedStyleExtractor. However, we want to
remove code using PseudoElement, not add more.

This patch does that throughout ComputedStyleExtractor and also removes some use in
KeyframeEffect by always invalidating the host instead of going through PseudoElement,
which wasn't necessary anymore.

We also had to modify Styleable::renderer() to return nullptr for the "::marker" case
in case there is no content set for the marker, because essentially there is nothing
being rendered for the marker and it would cause ComputedStyleExtractor::propertyValue()
to return computed value instead of "auto" for width and height for instance.

  • animation/KeyframeEffect.cpp:

(WebCore::invalidateElement):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::styledRenderer const):
(WebCore::hasValidStyleForProperty):
(WebCore::computeRenderStyleForProperty):
(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::getLayerCount):
(WebCore::ComputedStyleExtractor::styledElement const): Deleted.

  • css/CSSComputedStyleDeclaration.h:
  • style/Styleable.cpp:

(WebCore::Styleable::renderer const):

12:22 PM Changeset in webkit [287986] by timothy_horton@apple.com
  • 8 edits in trunk/Source

Fix a few Objective-C object leaks due to early returns in init
​https://bugs.webkit.org/show_bug.cgi?id=235162
<rdar://problem/87489048>

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

  • API/JSValue.mm:

(-[JSValue initWithValue:inContext:]):

Source/WebCore:

  • platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController init]):

Source/WebKit:

  • UIProcess/ios/WKHoverPlatter.mm:

(-[WKHoverPlatter initWithView:delegate:]):

Source/WebKitLegacy/mac:

  • Storage/WebDatabaseQuotaManager.mm:

(WebCore::if):

12:10 PM Changeset in webkit [287985] by Ross Kirsling
  • 4 edits in trunk/Tools

PlayStation MiniBrowser should accept a command-line URL argument
​https://bugs.webkit.org/show_bug.cgi?id=235193

Reviewed by Don Olmstead.

Windows MiniBrowser can be launched from the command line with a URL argument for the initial page to load;
this patch allows PlayStation MiniBrowser to do similarly.

  • MiniBrowser/playstation/MainWindow.cpp:

(MainWindow::MainWindow):

  • MiniBrowser/playstation/MainWindow.h:
  • MiniBrowser/playstation/main.cpp:

(main):

11:11 AM Changeset in webkit [287984] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove the code inside USE(OPENGL) && ENABLE(WEBGL2)
​https://bugs.webkit.org/show_bug.cgi?id=235178

Patch by Alejandro G. Castro <​alex@igalia.com> on 2022-01-13
Reviewed by Dean Jackson.

No port is supporting WebGL2 without ANGLE nowadays, that code is
historical and we can remove it.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::getRestartIndex): Deleted.

  • platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::primitiveRestartIndex): Deleted.

  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
11:03 AM Changeset in webkit [287983] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK][WPE][WebGL2] compilation fixes
​https://bugs.webkit.org/show_bug.cgi?id=225563

Patch by Alejandro G. Castro <​alex@igalia.com> on 2022-01-13
Reviewed by Chris Lord.

Fix the compilation and add the ANGLE dependency, the architecture
is still not the final one but it is handy to use WebGL2 demos for
testing already.

.:

  • Source/cmake/OptionsGTK.cmake: Added dependency with ANGLE.
  • Source/cmake/OptionsWPE.cmake: Added dependency with

ANGLE. Remove the default ENABLE_WEBGL2 because it is the same
default value in WebKitFeatures.cmake.

Source/WebCore:

We are still not enabling the tests until we have the final
architecture.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::drawElements): Leftover code,
there is no port using OpenGL directly to support WebGL2 anymore.
(WebCore::WebGLRenderingContextBase::drawElementsInstanced):
Ditto.

10:58 AM Changeset in webkit [287982] by Said Abou-Hallawa
  • 13 edits
    2 adds in trunk

Referenced SVG filter uses always sRGB color space for its result
​https://bugs.webkit.org/show_bug.cgi?id=235159

Reviewed by Simon Fraser.

Source/WebCore:

Do not setOperatingColorSpace() of the lastEffect() of the referenced
SVGFilter to DestinationColorSpace::SRGB(). This will have the pixels
of the result FilterImage of the lastEffect() in the color space which
is defined by the color-interpolation style of the effect SVGElement.

Test: css3/filters/reference-filter-color-space.html

  • platform/graphics/filters/Filter.h:
  • rendering/CSSFilter.cpp:

(WebCore::CSSFilter::create):
Move checking the CoreImage support to this function.

(WebCore::CSSFilter::buildFilterFunctions):
Remove resetting m_functions and m_outsets from this function since it
is now called only once from CSSFilter::create().

(WebCore::CSSFilter::lastEffect const): Deleted.

  • rendering/CSSFilter.h:
  • svg/graphics/filters/SVGFilter.h:

LayoutTests:

The new test defines a <feComponentTransfer> effect with linear component
functions. The values of these functions make the lookup tables have zeros
in the first 65 elements. The test applies the filter to a <div> with green
background.

-- With sRGB color-space, the green channel value is 0x80. So the value

in the lookup table is not zero. So the result filter image in this
case is a some green square.

-- With linearRGB color-space , the green channel value is 0x37. So the

value in the lookup table is zero. So the result filter image in this
case is a black square.

Because the color-space will be linearRGB, the expected test case should
have black squares.

  • css3/filters/reference-filter-color-space-expected.html: Added.
  • css3/filters/reference-filter-color-space.html: Added.
  • css3/filters/reference-filter-set-filter-regions.html:
  • fast/gradients/conic-gradient-alpha-unpremultiplied.html:
  • fast/gradients/conic-gradient-extended-stops.html:
  • fast/gradients/conic-gradient.html:
  • fast/gradients/conic-repeating-last-stop.html:
  • fast/hidpi/filters-turbulence.html:

Add color-interpolation-filters="sRGB" to get the old result so they match
the expected pages.

  • platform/win/TestExpectations:

LinearSRGB color space is not supported on Windows.

10:21 AM Changeset in webkit [287981] by Alan Bujtas
  • 4 edits
    2 adds in trunk

REGRESSION (r278561): Right clicking a link selects the full line with unrelated text
​https://bugs.webkit.org/show_bug.cgi?id=235172
<rdar://84069534>

Reviewed by Dean Jackson.

Source/WebCore:

r278561 slightly change highlightStateForTextBox's behavior which now (correctly) returns HighlightState::None when the
RenderText content is not part of the current selection. Prior to r278561, it returned the RenderText's original selection state
which in this case was HighlightState::End.

<div><span>A<br>B<span style="position: absolute"></span></span>C</div>

In this specific case when we select the outer <span>, we end up with the following selection states for the generated line boxes:

(B) -> "Inside"
(C) -> "None"

while previously (C) came back as "End" (note that the absolute positioned element does not generate line boxes).

Now as Line::selectionState traverses through the line boxes, it comes across an unexpected "Inside -> None" transition at the selection end boundary (B -> C)
which incorrectly leaves the line state in "Inside" and we paint the selection all the way to the end of the block.

Test: fast/editing/selection-with-absolute-positioned-empty-content.html

  • layout/integration/InlineIteratorLine.cpp:

(WebCore::InlineIterator::Line::selectionState const):

LayoutTests:

  • fast/editing/selection-with-absolute-positioned-empty-content-expected.txt: Added.
  • fast/editing/selection-with-absolute-positioned-empty-content.html: Added.
9:16 AM Changeset in webkit [287980] by Peng Liu
  • 3 edits in trunk/Source/WebCore

Clean up MediaPlaybackTargetPicker::Client
​https://bugs.webkit.org/show_bug.cgi?id=235128

Reviewed by Eric Carlson.

Small cleanup to remove an unused function and change override to final.

  • Modules/airplay/WebMediaSessionManager.h:
  • platform/graphics/MediaPlaybackTargetPicker.h:
8:22 AM Changeset in webkit [287979] by Patrick Angle
  • 7 edits
    2 adds in trunk

Web Inspector: Implement frameURL option for devtools.inspectedWindow.eval command
​https://bugs.webkit.org/show_bug.cgi?id=222568

Reviewed by Devin Rousso.

Source/WebInspectorUI:

New test: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtension.mm

Add support for evaluating script from an extension in a specific frame on the page by referring to it by the
frame's URL. Frame URLs are matched in three steps, first looking for an exact URL match, including query
parameters and fragment identifier. If no match is found and the provided options.frameURL does not have any
fragment identifier or query parameters, a check is then made against each known frame again, this time
excluding their fragment identifier. If that check still fails to find a frame for the URL, we perform one more
pass, this time excluding the fragment identifier and query parameters for each known frame.

  • UserInterface/Controllers/WebInspectorExtensionController.js:

(WI.WebInspectorExtensionController.prototype.evaluateScriptForExtension):
(WI.WebInspectorExtensionController.prototype.reloadForExtension):

  • Drive-by removal of trailing spaces.

(WI.WebInspectorExtensionController.prototype._frameForFrameURL):

Source/WebKit:

New test: Tools/TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtension.mm

Correct the API to indicate that frameURL and contextSecurityOrigin are nullable parameters.

  • UIProcess/API/Cocoa/_WKInspectorExtension.h:

Tools:

Add test coverage for evaluating script on an inspected page from an extension, including evaluating on an inner
frame.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtension.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtensionEvaluateScriptOnPage.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtensionEvaluateScriptOnPageInnerFrame.html: Added.
7:22 AM Changeset in webkit [287978] by Jonathan Bedard
  • 3 edits in trunk/Tools

[EWS] Load contributors from stand-alone class
​https://bugs.webkit.org/show_bug.cgi?id=235161
<rdar://problem/87491516>

Reviewed by Aakash Jain.

  • Tools/CISupport/ews-build/steps.py:

(Contributors): Moved from ValidateCommiterAndReviewer.
(ValidateCommiterAndReviewer.load_contributors_from_disk): Moved to Contributors.
(ValidateCommiterAndReviewer.load_contributors_from_github): Ditto.
(ValidateCommiterAndReviewer.load_contributors): Ditto.

  • Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/246007@main

6:41 AM Changeset in webkit [287977] by Ziran Sun
  • 5 edits in trunk

[css-grid] Fix rounding of distributed free space to flexible tracks
​https://bugs.webkit.org/show_bug.cgi?id=234917

LayoutTests/imported/w3c:

Reviewed by Darin Adler.

Source/WebCore:

Reviewed by Darin Adler.

When computing the growth size for flex sized tracks, the flexFraction multiplied by the flex factor can result
in a non-integer size. However, we floor the stretched size to fit in a LayoutUnit. This means that we may lose
the fractional part of the computation which can cause the entire free space not being distributed evenly. This
fix is to sum up the leftover fractional part from every flexible track to avoid this issue.

It is an import of Chromium GridNG CL at ​https://chromium-review.googlesource.com/c/chromium/src/+/3193674.

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::computeFlexSizedTracksGrowth const):

5:04 AM Changeset in webkit [287976] by svillar@igalia.com
  • 7 edits in trunk

[css-flexbox] Incorrect height of flex items with aspect-ratio whenever the cross axis intrinsic size is larger than the viewport
​https://bugs.webkit.org/show_bug.cgi?id=234564
<rdar://problem/86958389>

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

Automatic preferred sizes were considered always indefinite. However whenever they correspond to
the (physical) width we could consider them as definite. This allows us to use that size instead of
the flex item intrinsic size when computing the transferred size contribution. This way, flex items
with aspect ratio and large intrinsic size are not abnormally stretched due to the min-size:auto
computation.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing const): Use availableLogical{Width|Height}
to compute the cross size when then automatic preferred size is the physical width.
(WebCore::RenderFlexibleBox::childCrossAxisIsPhysicalWidth const):
(WebCore::RenderFlexibleBox::childCrossSizeShouldUseContainerCrossSize const): Handle the cases of
automatic preferred widths.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Adjusted the canvas-css-size-after-height-change-with-display-flex.html test case and expectations so it behaves as other engines.

  • TestExpectations: Unskipped a test that is passing now.
  • fast/canvas/canvas-css-size-after-height-change-with-display-flex-expected.html:
  • fast/canvas/canvas-css-size-after-height-change-with-display-flex.html:
1:42 AM Changeset in webkit [287975] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/web-locks/clientids.tentative.https.html is consistently passing on bots
​https://bugs.webkit.org/show_bug.cgi?id=235173

Unreviewed.

  • platform/wk2/TestExpectations:

Unflake imported/w3c/web-platform-tests/web-locks/clientids.tentative.https.html TestExpectation.

12:52 AM Changeset in webkit [287974] by Diego Pino Garcia
  • 2 edits
    1 delete in trunk/LayoutTests

[GTK] fast/events/overflow-viewport-renderer-deleted.html does not load
​https://bugs.webkit.org/show_bug.cgi?id=176021

Unreviewed test gardening.

The test has its own baseline and was marked as Missing in
TestExpectations. The test passes if removing the WebKitGTK baseline
and the Missing expected result.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.

Jan 12, 2022:

11:31 PM Changeset in webkit [287973] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

[:has() pseudo-class] Collect invalidation selectors for child invalidation
​https://bugs.webkit.org/show_bug.cgi?id=235103

Reviewed by Dean Jackson.

Collect selectors we can use to test if :has status actually changed before invalidating.

This patch doesn't yet use the the selector.

  • style/ChildChangeInvalidation.cpp:

(WebCore::Style::ChildChangeInvalidation::invalidateForChangedElement):

Use the pseudo class invalidation keys for looking up :has selectors too
instead of having a custom mechanism for doing the same thing.

  • style/PseudoClassChangeInvalidation.cpp:

(WebCore::Style::makePseudoClassInvalidationKeys):

  • style/PseudoClassChangeInvalidation.h:
  • style/RuleFeature.cpp:

(WebCore::Style::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):

Always return a selector for consistency.

(WebCore::Style::makePseudoClassInvalidationKey):
(WebCore::Style::RuleFeatureSet::collectFeatures):
(WebCore::Style::RuleFeatureSet::add):
(WebCore::Style::RuleFeatureSet::clear):
(WebCore::Style::RuleFeatureSet::shrinkToFit):

  • style/RuleFeature.h:
  • style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::collectFeatures const):
(WebCore::Style::ScopeRuleSets::hasPseudoClassInvalidationRuleSets const):
(WebCore::Style::ScopeRuleSets::tagInvalidationRuleSets const): Deleted.

We don't need keep around tag rule sets anymore.

  • style/StyleScopeRuleSets.h:
11:10 PM Changeset in webkit [287972] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening, remove some tests expected to fail but passing

There are several tests which have been passing consistently for the last 1000 revisions.

  • platform/glib/TestExpectations:
  • platform/wpe/TestExpectations:
9:00 PM Changeset in webkit [287971] by Diego Pino Garcia
  • 2 edits
    30 moves in trunk/LayoutTests

[WPE] Several accessibilty tests don't have expected results
​https://bugs.webkit.org/show_bug.cgi?id=201983

Unreviewed test gardening.

These tests had a baseline for WebKitGTK which actually can be reused for WPE.

  • platform/glib/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/glib/accessibility/aria-combobox-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-combobox-hierarchy-expected.txt.
  • platform/glib/accessibility/aria-hidden-false-works-in-subtrees-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt.
  • platform/glib/accessibility/aria-inherits-presentational-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-inherits-presentational-expected.txt.
  • platform/glib/accessibility/aria-menubar-menuitems-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-menubar-menuitems-expected.txt.
  • platform/glib/accessibility/aria-role-on-label-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-role-on-label-expected.txt.
  • platform/glib/accessibility/aria-selected-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-selected-expected.txt.
  • platform/glib/accessibility/aria-selected-menu-items-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-selected-menu-items-expected.txt.
  • platform/glib/accessibility/aria-switch-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-switch-text-expected.txt.
  • platform/glib/accessibility/aria-table-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-table-hierarchy-expected.txt.
  • platform/glib/accessibility/css-content-attribute-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/css-content-attribute-expected.txt.
  • platform/glib/accessibility/datetime-attribute-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/datetime-attribute-expected.txt.
  • platform/glib/accessibility/form-control-value-settable-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/form-control-value-settable-expected.txt.
  • platform/glib/accessibility/generated-content-with-display-table-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/generated-content-with-display-table-crash-expected.txt.
  • platform/glib/accessibility/image-with-alt-and-map-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-with-alt-and-map-expected.txt.
  • platform/glib/accessibility/img-fallsback-to-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/img-fallsback-to-title-expected.txt.
  • platform/glib/accessibility/math-fenced-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-fenced-expected.txt.
  • platform/glib/accessibility/math-foreign-content-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-foreign-content-expected.txt.
  • platform/glib/accessibility/math-mo-fences-and-separators-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-mo-fences-and-separators-expected.txt.
  • platform/glib/accessibility/math-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-text-expected.txt.
  • platform/glib/accessibility/meter-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/meter-element-expected.txt.
  • platform/glib/accessibility/platform-name-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/platform-name-expected.txt.
  • platform/glib/accessibility/svg-element-with-aria-role-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/svg-element-with-aria-role-expected.txt.
  • platform/glib/accessibility/table-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-hierarchy-expected.txt.
  • platform/glib/accessibility/w3c-svg-content-language-attribute-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/w3c-svg-content-language-attribute-expected.txt.
  • platform/glib/accessibility/w3c-svg-description-calculation-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/w3c-svg-description-calculation-expected.txt.
  • platform/glib/accessibility/w3c-svg-elements-not-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/w3c-svg-elements-not-exposed-expected.txt.
  • platform/glib/accessibility/w3c-svg-name-calculation-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/w3c-svg-name-calculation-expected.txt.
  • platform/glib/accessibility/w3c-svg-presentational-role-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/w3c-svg-presentational-role-expected.txt.
  • platform/glib/accessibility/w3c-svg-roles-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/w3c-svg-roles-expected.txt.
  • platform/wpe/TestExpectations:
7:23 PM Changeset in webkit [287970] by wilander@apple.com
  • 6 edits
    2 adds in trunk

PCM: Same-site triggering events should support ephemeral measurement
​https://bugs.webkit.org/show_bug.cgi?id=235160
<rdar://87423294>

Reviewed by Alex Christensen.

Source/WebCore:

We added ephemeral measurement for direct response advertising in ​https://bugs.webkit.org/show_bug.cgi?id=228984.
We added support for same-site triggering events in ​https://bugs.webkit.org/show_bug.cgi?id=233173.
These two features should work together.

The bug was that WebKit::NetworkSession::handlePrivateClickMeasurementConversion()
only checked for cross-site triggering events when handling ephemeral measurements.

Test: http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-ephemeral.html

  • loader/PrivateClickMeasurement.cpp:

(WebCore::PrivateClickMeasurement::isNeitherSameSiteNorCrossSiteTriggeringEvent):

New convenience function to enhance readability in
WebKit::NetworkSession::handlePrivateClickMeasurementConversion().

  • loader/PrivateClickMeasurement.h:

Source/WebKit:

We added ephemeral measurement for direct response advertising in ​https://bugs.webkit.org/show_bug.cgi?id=228984.
We added support for same-site triggering events in ​https://bugs.webkit.org/show_bug.cgi?id=233173.
These two features should work together.

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::handlePrivateClickMeasurementConversion):

This function previously only checked for cross-site triggering events when
handling ephemeral measurements. Now it also checks for same-site triggering
events.

LayoutTests:

  • http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-ephemeral-expected.txt: Added.
  • http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-ephemeral.html: Added.
7:21 PM Changeset in webkit [287969] by Andres Gonzalez
  • 5 edits in trunk/Source/WebCore

Process deferred ChildrenChanged notifications before creating an isolated subtree.
​https://bugs.webkit.org/show_bug.cgi?id=235115
<rdar://problem/87458790>

Reviewed by Chris Fleizach.

Fixes ~20 tests in isolated tree mode.

Before creating an isolated subtree, it is necessary to handle any
pending, deferred children change so that the AXObject tree is updated.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::processDeferredChildrenChangedList):
Added this method in order to be called from AXIsolatedTree::createSubtree.
(WebCore::AXObjectCache::performDeferredCacheUpdate):

  • accessibility/AXObjectCache.h:
  • accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::createSubtree):
Calls AXObjectCache::processDeferredChildrenChangedList once before
start creating a new subtree.

  • accessibility/isolatedtree/AXIsolatedTree.h:
6:52 PM Changeset in webkit [287968] by fpizlo@apple.com
  • 12 edits
    5 adds in trunk/Source/bmalloc

[libpas] thread_local_cache should not be allocated in the compact heap (cherry pick 11afcedfb5968f6894379ff1a41dd449ba7745f6)
​https://bugs.webkit.org/show_bug.cgi?id=235096

Reviewed by Yusuke Suzuki.

Thread local caches can get quite large because of how libpas uses them, we can allocate one per
thread, and we reallocate them with exponential resizing, so there's a lot of wasted space and a
decent amount of fragmentation. This shows up as occasional crashes trying to allocate a thread local
cache out of the compact heap.

This moves thread local caches out of the compact heap. They were only ever there because partial views
sometimes need to point to the local_allocator's bitvector, but that's part of the thread local cache.
So, that means that either the partial views' bits pointer cannot be a compact pointer, or the
thread_local_cache needs to be in the compact heap. So, the thread_local_cache ended up in the compact
heap to keep that pointer small.

This change works around the problem: it's rare that the partial views' bits pointer points at
the local_allocator's bits, and none of the fast path cases where we access that pointer will ever see
it in that state. So, this makes the pointer either point to a utility-heap-allocated box that contains
the full pointer, or it points at the actual array allocated in the compact heap. The utility heap is
in the compact heap, so the compact pointer can point at either one. The implementation of this is
encapsulated as pas_lenient_compact_ptr. It's a bit gross; storing to it only works when you're holding
the heap lock, for example.

This is perf-neutral on Speedometer. This is perf-neutral on JS2 cli with full JSC isoheaps (i.e. the
patch from bug 231938). It's a 0.4% regression on RAMification with full JSC isoheaps, but I'm not
going to worry about that because trunk doesn't have full JSC isoheaps, and JSC isoheaps requires some
change like this to work reliably (currently it'll randomly run out of compact heap).

  • bmalloc.xcodeproj/project.pbxproj:
  • libpas/libpas.xcodeproj/project.pbxproj:
  • libpas/src/libpas/pas_enumerate_segregated_heaps.c:

(enumerate_partial_view):

  • libpas/src/libpas/pas_full_alloc_bits_inlines.h:

(pas_full_alloc_bits_create_for_partial_but_not_primordial):
(pas_full_alloc_bits_create_for_partial):

  • libpas/src/libpas/pas_lenient_compact_ptr.h: Added.
  • libpas/src/libpas/pas_lenient_compact_ptr_inlines.h: Added.
  • libpas/src/libpas/pas_lenient_compact_unsigned_ptr.c: Added.
  • libpas/src/libpas/pas_lenient_compact_unsigned_ptr.h: Added.
  • libpas/src/libpas/pas_local_allocator.c:

(pas_local_allocator_move):

  • libpas/src/libpas/pas_local_allocator_inlines.h:

(pas_local_allocator_set_up_free_bits):
(pas_local_allocator_start_allocating_in_primordial_partial_view):
(pas_local_allocator_bless_primordial_partial_view_before_stopping):

  • libpas/src/libpas/pas_segregated_partial_view.c:

(pas_segregated_partial_view_create):
(compute_summary):

  • libpas/src/libpas/pas_segregated_partial_view.h:
  • libpas/src/libpas/pas_segregated_view_allocator_inlines.h:

(pas_segregated_view_will_start_allocating):

  • libpas/src/libpas/pas_thread_local_cache.c:

(deallocate):
(allocate_cache):

  • libpas/src/test/LotsOfHeapsAndThreads.cpp: Added.

(std::testLotsOfHeapsAndThreads):
(addLotsOfHeapsAndThreadsTests):

  • libpas/src/test/TestHarness.cpp:

(main):

6:17 PM Changeset in webkit [287967] by Fujii Hironori
  • 10 edits
    2 adds in trunk/Source

[WinCairo] Tiling scroll support
​https://bugs.webkit.org/show_bug.cgi?id=233676

Reviewed by Don Olmstead.

Source/WebCore:

Added a new class TextureMapperSparseBackingStore that supports
partially tiling the layer and removing tiles outside of the
coverage rect.

  • Headers.cmake:
  • platform/TextureMapper.cmake:
  • platform/graphics/texmap/TextureMapperSparseBackingStore.cpp: Added.

(WebCore::TextureMapperSparseBackingStore::TextureMapperSparseBackingStore):
(WebCore::TextureMapperSparseBackingStore::setSize):
(WebCore::TextureMapperSparseBackingStore::removeUncoveredTiles):
(WebCore::TextureMapperSparseBackingStore::adjustedTransformForRect):
(WebCore::TextureMapperSparseBackingStore::paintToTextureMapper):
(WebCore::TextureMapperSparseBackingStore::drawBorder):
(WebCore::TextureMapperSparseBackingStore::drawRepaintCounter):
(WebCore::TextureMapperSparseBackingStore::tileDimension const):
(WebCore::TextureMapperSparseBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperSparseBackingStore.h: Added.

Source/WebKit:

Added a new class WCTiledBacking that implements TiledBacking.

Copied computeVisibleAndCoverageRect,
transformByApplyingAnchorPoint and layerTransform from
GraphicsLayerAC.

  • GPUProcess/graphics/wc/WCScene.cpp:

(WebKit::WCScene::update):

  • WebProcess/WebPage/wc/DrawingAreaWC.cpp:

(WebKit::DrawingAreaWC::DrawingAreaWC):
(WebKit::DrawingAreaWC::updatePreferences):
(WebKit::DrawingAreaWC::shouldUseTiledBackingForFrameView const):
(WebKit::DrawingAreaWC::setNeedsDisplayInRect):
(WebKit::DrawingAreaWC::scroll):
(WebKit::flushLayerImageBuffers):
(WebKit::DrawingAreaWC::sendUpdateAC):
(WebKit::DrawingAreaWC::RootLayerClient::RootLayerClient): Deleted.
(WebKit::DrawingAreaWC::RootLayerClient::paintContents): Deleted.
(WebKit::DrawingAreaWC::RootLayerClient::deviceScaleFactor const): Deleted.

  • WebProcess/WebPage/wc/DrawingAreaWC.h:
  • WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

(WebKit::GraphicsLayerWC::GraphicsLayerWC):
(WebKit::GraphicsLayerWC::setNeedsDisplay):
(WebKit::GraphicsLayerWC::setNeedsDisplayInRect):
(WebKit::GraphicsLayerWC::setBackgroundColor):
(WebKit::GraphicsLayerWC::setDrawsContent):
(WebKit::GraphicsLayerWC::noteLayerPropertyChanged):
(WebKit::GraphicsLayerWC::flushCompositingState):
(WebKit::GraphicsLayerWC::flushCompositingStateForThisLayerOnly):
(WebKit::GraphicsLayerWC::tiledBacking const):
(WebKit::GraphicsLayerWC::createImageBuffer):
(WebKit::accumulatesTransform):
(WebKit::GraphicsLayerWC::transformByApplyingAnchorPoint const):
(WebKit::GraphicsLayerWC::layerTransform const):
(WebKit::GraphicsLayerWC::computeVisibleAndCoverageRect const):
(WebKit::GraphicsLayerWC::recursiveCommitChanges):

  • WebProcess/WebPage/wc/GraphicsLayerWC.h:
  • WebProcess/WebPage/wc/WCUpateInfo.h:

(WebKit::WCLayerUpateInfo::encode const):
(WebKit::WCLayerUpateInfo::decode):

6:04 PM Changeset in webkit [287966] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening, merge common WebRTC test failures

Merge common WebRTC test failures filed under bug webkit.org/b/187064.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
5:29 PM Changeset in webkit [287965] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

::backdrop pseudo element should react to event listeners
​https://bugs.webkit.org/show_bug.cgi?id=233072

Unreviewed test gardening.

  • platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-receives-element-events-expected.txt:

Add a missing newline.

5:17 PM Changeset in webkit [287964] by Ryan Haddad
  • 4 edits in trunk

Unreviewed, reverting r287944.

Breaks Monterey build.

Reverted changeset:

"Build WebKitSwift when building with make or build-webkit"
​https://bugs.webkit.org/show_bug.cgi?id=235093
​https://commits.webkit.org/r287944

5:15 PM Changeset in webkit [287963] by Fujii Hironori
  • 3 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo-wk1/TestExpectations:
  • platform/wincairo/TestExpectations:
5:13 PM Changeset in webkit [287962] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Unreviewed, reverting r287955.
​https://bugs.webkit.org/show_bug.cgi?id=235166

Reverting, since this can be fixed without a sandbox change.

Reverted changeset:

"[macOS] Add required system call"
​https://bugs.webkit.org/show_bug.cgi?id=235155
​https://commits.webkit.org/r287955

4:36 PM Changeset in webkit [287961] by mark.lam@apple.com
  • 5 edits in trunk/Source

[Re-landing] Update hashThreadState() to exclude opaque_flags.
​https://bugs.webkit.org/show_bug.cgi?id=235081
rdar://86282584

Reviewed by Keith Miller.

Source/JavaScriptCore:

Removed some unused code.

  • runtime/MachineContext.h:

(JSC::MachineContext::stackPointer):
(JSC::MachineContext::framePointer):
(JSC::MachineContext::instructionPointer):
(JSC::MachineContext::linkRegister):
(JSC::MachineContext::setStackPointer): Deleted.
(JSC::MachineContext::setFramePointer): Deleted.
(JSC::MachineContext::setLinkRegister): Deleted.

Source/WTF:

The opaque_flags may be used by the OS, and may be altered without our knowledge.
Hence, our hash should not include the opaque_flags field.

Also remove some unused code.

  • wtf/PlatformRegisters.h:
  • wtf/threads/Signals.cpp:

(WTF::hashThreadState):

4:30 PM Changeset in webkit [287960] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r287912.
​https://bugs.webkit.org/show_bug.cgi?id=235164

ARM64/ARM64E Speedometer2 50% regression, probably breaking
something

Reverted changeset:

"[RISCV64] riscv64 backend should lower offlineasm
instructions"
​https://bugs.webkit.org/show_bug.cgi?id=234952
​https://commits.webkit.org/r287912

4:00 PM Changeset in webkit [287959] by Megan Gardner
  • 15 edits in trunk/Source

Add to Contact menu item does nothing on mac.
​https://bugs.webkit.org/show_bug.cgi?id=235154
Source/WebCore:

Reviewed by Tim Horton.

Add to Context menu item for telephone numbers did not actually show the contact card.
This was because the delgate did not tell the menu where to display the card from, so it just failed.
Plumbing that information through fixes the issue.

  • page/ChromeClient.h:

(WebCore::ChromeClient::handleTelephoneNumberClick):

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::handleClick):

Source/WebKit:

rdar://80213097

Reviewed by Tim Horton.

Add to Context menu item for telephone numbers did not actually show the contact card.
This was because the delgate did not tell the menu where to display the card from, so it just failed.
Plumbing that information through fixes the issue.

  • Platform/mac/MenuUtilities.h:
  • Platform/mac/MenuUtilities.mm:

(-[WKEmptyPresenterHighlightDelegate initWithRect:]):
(-[WKEmptyPresenterHighlightDelegate revealContext:rectsForItem:]):
(-[WKEmptyPresenterHighlightDelegate revealContext:shouldUseDefaultHighlightForItem:]):
(WebKit::menuForTelephoneNumber):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showTelephoneNumberMenu):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::handleTelephoneNumberClick):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::handleTelephoneNumberClick):

3:58 PM Changeset in webkit [287958] by Diego Pino Garcia
  • 2 edits
    1 add in trunk/LayoutTests

[GLIB] Unreviewed test gardening, emit baseline for WPT test css/css-cascade/all-prop-initial-xml.html
​https://bugs.webkit.org/show_bug.cgi?id=209330

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Added.
3:45 PM Changeset in webkit [287957] by J Pascoe
  • 4 edits in trunk

[WebAuthn] Fix freebie call without user gesture not being given
​https://bugs.webkit.org/show_bug.cgi?id=235078
rdar://87327557

Reviewed by Brent Fulgham.

Source/WebKit:

This logic was previously always requiring a user gesture. The desired
behavior of giving pages a single "freebie" webauthn call without gesture
was lost in a refactor.

Tested manually on iOS device with webauthn.me.

  • WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:

(WebKit::WebAuthenticatorCoordinator::processingUserGesture):

Tools:

Updated API test to reflect user gesture freebie.

  • TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-no-mock.html:
3:36 PM Changeset in webkit [287956] by commit-queue@webkit.org
  • 18 edits in trunk

[Xcode] Configure each project for the legacy build system
​https://bugs.webkit.org/show_bug.cgi?id=235091
Source/bmalloc:

Patch by Elliott Williams <Elliott Williams> on 2022-01-12
Reviewed by Darin Adler.

  • bmalloc.xcodeproj/project.pbxproj:

Source/WebGPU:

Patch by Elliott Williams <Elliott Williams> on 2022-01-12
Reviewed by Darin Adler.

  • WebGPU.xcodeproj/project.pbxproj:

Source/WebInspectorUI:

Patch by Elliott Williams <Elliott Williams> on 2022-01-12
Reviewed by Darin Adler.

  • WebInspectorUI.xcodeproj/project.pbxproj:

Source/WTF:

Beta versions of Xcode do not recognize the -UseNewBuildSystem=NO flag, so we need to
manually declare use of PBXBuild in our projects.

Patch by Elliott Williams <Elliott Williams> on 2022-01-12
Reviewed by Darin Adler.

  • WTF.xcodeproj/project.pbxproj:

Tools:

Patch by Elliott Williams <Elliott Williams> on 2022-01-12
Reviewed by Darin Adler.

  • ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
  • EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
  • FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
  • ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/project.pbxproj:
  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3:17 PM Changeset in webkit [287955] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[macOS] Add required system call
​https://bugs.webkit.org/show_bug.cgi?id=235155

Patch by Brandon Stewart <Brandon> on 2022-01-12
Reviewed by Per Arne Vollan.

Add missing system call that is required by Core Graphics.

  • WebProcess/com.apple.WebProcess.sb.in:
3:13 PM Changeset in webkit [287954] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

Live Text is sometimes horizontally clipped when injecting TextRecognitionBlockData
​https://bugs.webkit.org/show_bug.cgi?id=235122

Reviewed by Devin Rousso.

Source/WebCore:

The current heuristic for sizing Live Text paragraphs avoids vertical overflow, but does not avoid horizontal
overflow. Line breaking inside the fixed-width container prevents the latter in most cases, but not in the
scenario where the recognized text block is a single word with no opportunity for line break.

Address this by adjusting the sizing heuristic to shrink both the width and height to fit within the target size
(rather than just fitting the height).

Test: fast/images/text-recognition/image-overlay-block-horizontal-overflow.html

  • dom/ImageOverlay.cpp:

(WebCore::ImageOverlay::updateWithTextRecognitionResult):

LayoutTests:

Add a test to verify that a single, very long word in injected text recognition block data does not trigger
horizontal overflow.

  • fast/images/text-recognition/image-overlay-block-horizontal-overflow-expected.html: Added.
  • fast/images/text-recognition/image-overlay-block-horizontal-overflow.html: Added.
2:59 PM Changeset in webkit [287953] by Wenson Hsieh
  • 18 edits in trunk

[macOS] [WK2] NSFontPanel UI (font color, text decorations, font shadow) doesn't update on selection change
​https://bugs.webkit.org/show_bug.cgi?id=190120
rdar://44897405

Reviewed by Darin Adler.

Source/WebCore:

Add a boolean hasMultipleFonts flag to FontAttributes, and pass it as an out-reference when computing the
font at the current selection. See WebKit/ChangeLog for more details.

  • editing/Editor.cpp:

(WebCore::Editor::fontAttributesAtSelectionStart):

  • editing/FontAttributes.h:

Source/WebKit:

Currently, in WebKit2, there is no mechanism for updating the NSFontManager with new font attributes when the
selection changes. While we do update the selected NSFont, we do so by requesting font family and font size via
an IPC request, FontAtSelection, but this does not include attributes like underline, strike-through, color,
and text shadows.

Instead, we can remove this FontAtSelection IPC request mechanism entirely, and request FontAttributes. This
allows us to set the currently selected NSFont on the NSFontManager, and also update the font manager with the
full dictionary of font attributes.

Test: FontAttributes.FontAttributesAfterChangingSelection

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<FontAttributes>::encode):
(IPC::ArgumentCoder<FontAttributes>::decode):

Encode and decode the new hasMultipleFonts flag in FontAttributes. Additionally, take this opportunity to
modernize some of the decoding-side logic by decoding each member into a std::optional and creating the final
deserialized FontAttributes at the end.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateFontManagerIfNeeded):

Rather than grabbing just the font family and font size using fontAtSelection, request FontAttributes instead
and convert it to a NSDictionary to call -[NSFontManager setSelectedAttributes:isMultiple:].

(WebKit::WebViewImpl::typingAttributesWithCompletionHandler):
(WebKit::WebViewImpl::changeFontAttributesFromSender):
(WebKit::WebViewImpl::changeFontFromFontManager):

Remove code to update the font manager after changing font attributes. This is unnecessary because the process
of executing an edit command in order to change typing style will trigger an editor state update anyways, which
then causes us to request new font attributes.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestFontAttributesAtSelectionStart):

Move the check for cached fontattributes to WebPageProxy, from WebViewImpl. This allows us to get rid of a
helper function on WebPageProxy to grab the current cached font attributes.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didUpdateEditorState):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::didUpdateEditorState):

Set cached FontAttributes (if present) *prior* to dispatching a selection change. This allows any subsequent
request for font attributes at the selection to return immediately with the result.

(WebKit::WebPageProxy::fontAtSelection): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Remove the FontAtSelectionCallback IPC message (and all associated code). This codepath was previously only
exercised when updating the font panel on macOS, and is no longer necessary because we just use
requestFontAttributesAtSelectionStart instead, which allows us to grab not only the NSFont, but also all
platform typing attributes at the selection.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::fontAtSelection): Deleted.

Tools:

Augment and adjust some existing API tests. See WebKit/ChangeLog for more information.

  • TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:

Augment an existing API test, FontAttributes.FontAttributesAfterChangingSelection, to additionally check shared
NSFontManager state (foreground/background color, shadow color and radius, etc.) on macOS.

(TestWebKitAPI::webViewForTestingFontAttributes):

On macOS, additionally make the font panel visible so that we can test font panel state.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/FontManagerTests.mm:

Relax some constraints on FontManagerTests.ChangeFontWithPanel, so that it verifies that the platform font in
the NSFontManager has all of the same attributes as the expectation, rather than being equal to the exact same
font object.

Adjust an existing API test, FontManagerTests.ChangeAttributesWithFontEffectsBox, to also vary the length of
font shadows. Updating font attributes on the font manager exposed an issue with this API test where, because
the font panel's attributes are never updated, the value of the shadow length slider remains at the default
value of 0.125, producing a shadow length of 1.25px. However, now that the selection moves to non-shadowed text
before moving to shadowed text again, we need to explicitly set the shadow length slider's value when testing
the second shadowed text selection.

(webViewForFontManagerTesting):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/mac/NSFontPanelTesting.h:
  • TestWebKitAPI/mac/NSFontPanelTesting.mm:

Add some additional testing helpers to query the state of controls in the font panel (e.g. font shadow sliders,
foreground color well, and strike-through/underline popup menu state).

(-[NSFontPanel underlineToolbarButton]):
(-[NSFontPanel strikeThroughToolbarButton]):
(-[NSFontPanel foregroundColorToolbarColorWell]):
(-[NSFontPanel chooseUnderlineMenuItemWithTitle:]):
(-[NSFontPanel chooseStrikeThroughMenuItemWithTitle:]):
(-[NSFontPanel shadowLengthSlider]):
(-[NSFontPanel hasShadow]):
(-[NSFontPanel shadowLength]):
(-[NSFontPanel setShadowLength:]):
(-[NSFontPanel hasUnderline]):
(-[NSFontPanel hasStrikeThrough]):
(-[NSFontPanel foregroundColor]):

2:49 PM Changeset in webkit [287952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Verify startNode is prior to the beyondEnd node
​https://bugs.webkit.org/show_bug.cgi?id=230712

Patch by Brandon Stewart <Brandon> on 2022-01-12
Reviewed by Wenson Hsieh.

Verify that the startNode is prior to the beyondEnd. If this condition is not met,
this will lead to undesirable situations when traversing through the nodes.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

2:37 PM Changeset in webkit [287951] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKitLegacy/mac

_paintBehaviorForDestinationContext should consider kCGContextTypeDisplayList type contexts as potentially being snapshots
​https://bugs.webkit.org/show_bug.cgi?id=234626
<rdar://83501315>

Patch by Matt Woodrow <Matt Woodrow> on 2022-01-12
Reviewed by Simon Fraser.

_paintBehaviorForDestinationContext currently always returns Normal for contexts that aren't a bitmap context.
AppKit now provides a context that is of type kCGContextTypeDisplayList, and we want to still potentially consider it a
snapshot paint (if the other conditions below are met). This ensure images are sync decoded for consumers that just
want a single paint.

  • WebView/WebFrame.mm:

(-[WebFrame _paintBehaviorForDestinationContext:]):

1:54 PM Changeset in webkit [287950] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, reverting r287908.
​https://bugs.webkit.org/show_bug.cgi?id=235156

Broke M1 Monterey JSC

Reverted changeset:

"Update hashThreadState() to exclude opaque_flags."
​https://bugs.webkit.org/show_bug.cgi?id=235081
​https://commits.webkit.org/r287908

1:17 PM Changeset in webkit [287949] by Jonathan Bedard
  • 5 edits in trunk/Tools

[EWS] Accept GitHub hooks (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=235033
<rdar://problem/87345269>

Reviewed by Aakash Jain

Trigger a subset of queues for incoming GitHub pull-requests.

  • Tools/CISupport/ews-build/config.json: Enable webkitperl, webkitpy, services and style checks.
  • Tools/CISupport/ews-build/loadConfig_unittest.py:

(ConfigDotJSONTest):
(ConfigDotJSONTest.test_multiple_scheduers_for_builder):

  • Tools/CISupport/ews-build/master.cfg: Accept GitHub hooks, specify variables

to extract from incoming request.

  • Tools/CISupport/ews-build/steps.py:

(GitHub):
(GitHub.repository_urls): Concatenate all valid projects with the base URL.
(GitHub.pr_url): Given a repository and pull-request number, return the URL
for that pull-request.
(ConfigureBuild.add_pr_details):
(GitHubMixin): Deleted.

Canonical link: ​https://commits.webkit.org/245977@main

1:17 PM Changeset in webkit [287948] by Fujii Hironori
  • 3 edits in trunk/Source/WebCore

[MediaFoundation] Invalidate only the videa area using MediaPlayer::repaint(), not the whole FrameView
​https://bugs.webkit.org/show_bug.cgi?id=235088

Reviewed by Don Olmstead.

r192176 added MediaPlayerPrivateMediaFoundation::invalidateFrameView()
to render the next frame. It was, as per the method name,
invalidating the whole FrameView.

This approach doesn't render video frames with TiledBacking (Bug
233676). Calling MediaPlayer::repaint() is the correct way to
invalidate the video area.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::invalidateVideoArea): Call MediaPlayer::repaint().
(WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processInputNotify):
(WebCore::MediaPlayerPrivateMediaFoundation::invalidateFrameView): Deleted.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
12:56 PM Changeset in webkit [287947] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ iOS EWS ] imported/w3c/web-platform-tests/dom/events/focus-event-document-move.html is a constant text failure
​https://bugs.webkit.org/show_bug.cgi?id=235150

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
12:45 PM Changeset in webkit [287946] by graouts@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Update Web Inspector to not use legacy webkit-prefixed transition events
​https://bugs.webkit.org/show_bug.cgi?id=235119

Reviewed by Joseph Pecoraro.

Came across this while working on bug 235113, we shouldn't be using webkit-prefixed events.

  • UserInterface/Views/TabBar.js:

(WI.TabBar.prototype.insertTabBarItem.animateTabs):
(WI.TabBar.prototype.insertTabBarItem.removeStyles):
(WI.TabBar.prototype.insertTabBarItem):
(WI.TabBar.prototype.removeTabBarItem.animateTabs):
(WI.TabBar.prototype.removeTabBarItem.removeStyles):
(WI.TabBar.prototype.removeTabBarItem):
(WI.TabBar.prototype._finishExpandingTabsAfterClose.):
(WI.TabBar.prototype._finishExpandingTabsAfterClose):

12:24 PM Changeset in webkit [287945] by graouts@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector should expose newer CSS Animations, CSS Transitions and Web Animations events
​https://bugs.webkit.org/show_bug.cgi?id=235117

Reviewed by Joseph Pecoraro.

Came across this while working on bug 235113, the more recent events added to
CSS Animations, CSS Transitions and Web Animations are not used in the Web Inspector.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

12:17 PM Changeset in webkit [287944] by commit-queue@webkit.org
  • 4 edits in trunk

Build WebKitSwift when building with make or build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=235093

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-01-12
Reviewed by Alexey Proskuryakov.

Source/WebKit:

For various internal reasons, we have to have no depency between the two,
but we command line builders want to build and test it just like everyone else.

  • Makefile:

Tools:

  • Scripts/build-webkit:
12:06 PM Changeset in webkit [287943] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

[Live Text] Image overlay text is misaligned on rfi.fr
​https://bugs.webkit.org/show_bug.cgi?id=235118

Reviewed by Aditya Keerthi.

Source/WebCore:

Reset any text-indent to 0 when injecting Live Text into image elements, to ensure that any text-indent
value set on the image doesn't propagate into UA shadow DOM content.

Test: fast/images/text-recognition/image-overlay-with-text-indent.html

  • html/shadow/imageOverlay.css:

(div.image-overlay-line, .image-overlay-text, div.image-overlay-block):

LayoutTests:

Add a new test case to exercise the bug.

  • fast/images/text-recognition/image-overlay-with-text-indent-expected.html: Added.
  • fast/images/text-recognition/image-overlay-with-text-indent.html: Added.
11:53 AM Changeset in webkit [287942] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ Win EWS ] webanimations/accelerated-animation-after-forward-filling-animation.html is a constant image only failure
​https://bugs.webkit.org/show_bug.cgi?id=235126

Unreviewed test gardening.

  • platform/win/TestExpectations: Adding ImageOnlyFailure expectation to speed up WindowsEWS.
11:46 AM Changeset in webkit [287941] by ysuzuki@apple.com
  • 2 edits in trunk/Source/WTF

[JSC] Enable libpas jit-heap when libpas is enabled
​https://bugs.webkit.org/show_bug.cgi?id=235042

Reviewed by Filip Pizlo.

Previously, we enabled jit-heap only in ARM64 macOS.
We should enable it when libpas is enabled.

  • wtf/PlatformUse.h:
11:19 AM Changeset in webkit [287940] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ Win EWS ] webanimations/frame-rate/animation-frame-rate.html is a constant text failure
​https://bugs.webkit.org/show_bug.cgi?id=235124

Unreviewed test gardening.

  • platform/win/TestExpectations: Adding Failure expectation for Windows to speed up Windows EWS.
11:18 AM Changeset in webkit [287939] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Correctly dirty z-order lists when showing a modal dialog
​https://bugs.webkit.org/show_bug.cgi?id=232762
<rdar://problem/85082354>

Reviewed by Alan Bujtas.

When showing a dialog element which is split into continuations, we need to ensure
to call establishesTopLayerWillChange()/establishesTopLayerDidChange() on the
layers of all the continuation renderers.

  • dom/Element.cpp:

(WebCore::forEachRenderLayer): Call the provided function on the layers for all
the associated render objects. It's a little cumbersome because layers relate to
RenderLayerModelObject, but continuations relate to RenderBoxModelObject.
(WebCore::Element::addToTopLayer):
(WebCore::Element::removeFromTopLayer):
(WebCore::renderLayerForElement): Deleted.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::forRendererAndContinuations):

  • rendering/RenderBoxModelObject.h: Provider a static helper to call a function

on a renderer and all its continuations, if any.

11:05 AM Changeset in webkit [287938] by Russell Epstein
  • 1 copy in tags/Safari-613.1.12.1.8

Tag Safari-613.1.12.1.8.

11:05 AM Changeset in webkit [287937] by Russell Epstein
  • 9 edits in branches/safari-613.1.12.1-branch/Source

Versioning.

WebKit-7613.1.12.1.8

10:56 AM Changeset in webkit [287936] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Add some functions to Color to make debugging using color indicators easier
​https://bugs.webkit.org/show_bug.cgi?id=234886

Reviewed by Darin Adler.

Add two helpers to Color to aid debugging, allowing easy access to components in simplified form.

  • platform/graphics/Color.cpp:

(WebCore::Color::debugRGBA const):
(WebCore::Color::debugDescription const):

  • platform/graphics/Color.h:
10:55 AM Changeset in webkit [287935] by Robert Jenner
  • 2 edits in trunk/LayoutTests

REGRESSION(r286828?): [ Win EWS ] fast/css/contain-invalidate-if-disabled.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=235123

Unreviewed test gardening.

  • platform/win/TestExpectations: Adding Failure expectaton to speed up Windows EWS.
10:49 AM Changeset in webkit [287934] by Razvan Caliman
  • 6 edits in trunk

Web Inspector: Unhandled exception when moving cursor mid-token after receiving CSS property name completions
​https://bugs.webkit.org/show_bug.cgi?id=234393
<rdar://problem/86578732>

Reviewed by Patrick Angle.

Source/WebInspectorUI:

A faulty check for mid-token completions in WI.CSSKeywordCompletions.forPartialPropertyName(), which are still
unsupported, prevented an early return and completions were provided unexpectedly. This had knock-on effects in
WI.SpreadsheetTextField which is not set up to handle cases where the caret is placed within the completion query.
Calculating the adjusted caret position could return a negative index and throw an unhandled exception.

Web Inspector does not currently explicitly support mid-token completions. See ​https://webkit.org/b/227157

The implementation of fuzzy matching for CSS completions in ​https://webkit.org/b/234092
means that, unhindered, the completion provider for CSS property names _can_ return mid-token completions.
Typing a query like margin, then moving the caret to the beginning and correcting to s|margin will return
completions like [s]croll-[margin]. Accepting the completion results in a malformed SpreadsheetTextField.value
by concatenation within the prefix itself. As the user types mid-token, the prefix becomes ambiguous.

Fixing the condition in WI.CSSKeywordCompletions.forPartialPropertyName() now inhibits unintentional
mid-token completions when fuzzy matching is enabled.

  • UserInterface/Models/CSSKeywordCompletions.js:

(WI.CSSKeywordCompletions.forPartialPropertyName):

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._showSuggestionsView):

LayoutTests:

  • inspector/unit-tests/css-keyword-completions-expected.txt:
  • inspector/unit-tests/css-keyword-completions.html:
10:44 AM Changeset in webkit [287933] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[AppleWin] Some fast/shadow-dom/fullscreen-in-* tests are crashing after r287698
​https://bugs.webkit.org/show_bug.cgi?id=234933

Unreviewed test gardening.

  • platform/win/TestExpectations: Missed adding a crash expectation to 'accessibility/insert-children-assert.html' which is part of this bug.
10:38 AM Changeset in webkit [287932] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[AppleWin] Some fast/shadow-dom/fullscreen-in-* tests are crashing after r287698
​https://bugs.webkit.org/show_bug.cgi?id=234933

Unreviewed test gardening.

  • platform/win/TestExpectations: Adding crash expectation to tests because they were slowing down Windows EWS.
10:22 AM Changeset in webkit [287931] by Russell Epstein
  • 1 copy in tags/Safari-613.1.12.1.7

Tag Safari-613.1.12.1.7.

10:17 AM Changeset in webkit [287930] by jer.noble@apple.com
  • 10 edits in trunk/Source/WebKit

[iOS] Page loading hangs for ~10s on WebProcess launch
​https://bugs.webkit.org/show_bug.cgi?id=235089

Reviewed by Eric Carlson.

WebPage::setMuted() will result in calling into the current audioCaptureFactory,
which will be by default CoreAudioAudioCaptureFactory unless replaced.
CoreAudioAudioCaptureFactory will in turn call into AVAudioSession, which will block
for multiple seconds due to the WebContent process sandbox.

Change the order in which these calls occur by configuring the audioCaptureFactory
in platformInitialize(), which occurs near the top of the constructor. This requires
access to the WebPageCreationParameters passed into the constructor, modify that method
to take a WebPageCreationParameters, and modify all the platform-specific definitions of
that method.

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::platformInitialize):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_appHighlightsVisible):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize): Deleted.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitializeAccessibility):
(WebKit::WebPage::platformInitialize): Deleted.

  • WebProcess/WebPage/playstation/WebPagePlayStation.cpp:

(WebKit::WebPage::platformInitialize):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformInitialize):

  • WebProcess/WebPage/wpe/WebPageWPE.cpp:

(WebKit::WebPage::platformInitialize):

10:15 AM Changeset in webkit [287929] by Russell Epstein
  • 9 edits in branches/safari-613.1.12.1-branch/Source

Versioning.

WebKit-7613.1.12.1.7

9:57 AM Changeset in webkit [287928] by youenn@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

VP9-SVS no video stream from remote peer on some devices
​https://bugs.webkit.org/show_bug.cgi?id=231074
<rdar://problem/84024646>

Reviewed by Eric Carlson.

  • Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.m:

(-[RTCDefaultVideoDecoderFactory initWithH265:vp9Profile0:vp9Profile2:vp9VTB:]):
Do not use VTIsHardwareDecodeSupported('vp09') to know whether WebProcess can use VTB since sandboxing can control this.

8:56 AM Changeset in webkit [287927] by svillar@igalia.com
  • 41 edits
    1 copy
    9 adds in trunk/LayoutTests

[css-flexbox] Import WPT tests - January edition
​https://bugs.webkit.org/show_bug.cgi?id=235102

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

This import brings some new tests. Apart from that several expectations were moved from FAIL to PASS.

  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-002-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-002.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-004-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-004.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-006-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-006.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-008-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-008.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-002-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-002.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-004-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-004.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-006-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-006.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-008-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-008.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-002-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-002.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-003-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-003.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-004-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-004.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-006-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-006.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-007-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-007.html:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-008-expected.txt:
  • web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-008.html:
  • web-platform-tests/css/css-flexbox/abspos/w3c-import.log:
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-007-expected.html: Added.
  • web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-007.html: Added.
  • web-platform-tests/css/css-flexbox/fieldset-as-item-dynamic-expected.html: Added.
  • web-platform-tests/css/css-flexbox/fieldset-as-item-dynamic.html: Added.
  • web-platform-tests/css/css-flexbox/flex-basis-intrinsics-001-expected.txt:
  • web-platform-tests/css/css-flexbox/flex-basis-intrinsics-001.html:
  • web-platform-tests/css/css-flexbox/flex-grow-001-ref.xht: Added.
  • web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-014.html:
  • web-platform-tests/css/css-flexbox/flexbox-justify-content-wmvert-002-expected.txt:
  • web-platform-tests/css/css-flexbox/flexbox-justify-content-wmvert-002.html:
  • web-platform-tests/css/css-flexbox/flexbox-justify-content-wmvert-003-expected.txt: Added.
  • web-platform-tests/css/css-flexbox/flexbox-justify-content-wmvert-003.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-justify-content-wmvert-002.html.
  • web-platform-tests/css/css-flexbox/order/order-with-column-reverse-ref.html: Added.
  • web-platform-tests/css/css-flexbox/order/order-with-row-reverse-ref.html: Added.
  • web-platform-tests/css/css-flexbox/scrollbars-auto-expected.html:
  • web-platform-tests/css/css-flexbox/scrollbars-expected.html:
  • web-platform-tests/css/css-flexbox/support/large-green-rectangle.svg: Added.
  • web-platform-tests/css/css-flexbox/support/w3c-import.log:
  • web-platform-tests/css/css-flexbox/w3c-import.log:

LayoutTests:

8:54 AM Changeset in webkit [287926] by graouts@webkit.org
  • 5 edits in trunk

css/css-transitions/pseudo-elements-002.html WPT is a failure
​https://bugs.webkit.org/show_bug.cgi?id=234987

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark WPT progression.

  • web-platform-tests/css/css-transitions/pseudo-elements-002-expected.txt:
  • web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt:

Source/WebCore:

When checking for style validity, we would only check the element itself and not its host
in the case where the element were a PseudoElement. Ideally, we'd eradicate all use of
PseudoElement throughout this source file, but this is a start, and I'll attempt a
refactor in a followup patch.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::hasValidStyleForProperty):

8:51 AM Changeset in webkit [287925] by graouts@webkit.org
  • 22 edits
    14 deletes in trunk

Remove WebKitTransitionEvent and WebKitAnimationEvent
​https://bugs.webkit.org/show_bug.cgi?id=235113

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions.

  • web-platform-tests/css/css-animations/historical-expected.txt:
  • web-platform-tests/css/css-transitions/historical-expected.txt:

Source/WebCore:

Remove all files related to these interfaces and fix some missing header includes
revealed by a change in unified sources.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.in:
  • dom/EventTarget.cpp:
  • dom/WebKitAnimationEvent.cpp: Removed.
  • dom/WebKitAnimationEvent.h: Removed.
  • dom/WebKitAnimationEvent.idl: Removed.
  • dom/WebKitTransitionEvent.cpp: Removed.
  • dom/WebKitTransitionEvent.h: Removed.
  • dom/WebKitTransitionEvent.idl: Removed.
  • dom/mac/ImageControlsMac.cpp:
  • dom/mac/ImageControlsMac.h:

LayoutTests:

Remove some tests specific to those two interfaces.

  • animations/animation-events-create-expected.txt: Removed.
  • animations/animation-events-create.html: Removed.
  • fast/events/constructors/webkit-animation-event-constructor-expected.txt: Removed.
  • fast/events/constructors/webkit-animation-event-constructor.html: Removed.
  • fast/events/constructors/webkit-transition-event-constructor-expected.txt: Removed.
  • fast/events/constructors/webkit-transition-event-constructor.html: Removed.
  • js/dom/constructor-length.html:
  • platform/glib/js/dom/constructor-length-expected.txt:
  • platform/ios/js/dom/constructor-length-expected.txt:
  • platform/mac/js/dom/constructor-length-expected.txt:
  • platform/win/TestExpectations:
  • platform/win/js/dom/constructor-length-expected.txt:
  • platform/wincairo/js/dom/constructor-length-expected.txt:
  • transitions/transition-end-event-create-expected.txt: Removed.
  • transitions/transition-end-event-create.html: Removed.
8:47 AM Changeset in webkit [287924] by graouts@webkit.org
  • 53 edits
    1 copy
    1 move
    116 adds
    1 delete in trunk/LayoutTests

Update WPT for css/css-animations, css/css-transitions and web-animations
​https://bugs.webkit.org/show_bug.cgi?id=235111

Unreviewed WPT import.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-animations/animation-common-ref.html: Added.
  • web-platform-tests/css/css-animations/animation-important-002-ref.html: Added.
  • web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time-ref.html: Added.
  • web-platform-tests/css/css-animations/animation-pseudo-dynamic-001-ref.html: Added.
  • web-platform-tests/css/css-animations/animation-transform-pause-and-set-time-ref.html: Added.
  • web-platform-tests/css/css-animations/flip-running-animation-via-variable-expected.html: Added.
  • web-platform-tests/css/css-animations/flip-running-animation-via-variable-ref.html: Added.
  • web-platform-tests/css/css-animations/flip-running-animation-via-variable.html: Added.
  • web-platform-tests/css/css-animations/keyframes-unrelated-custom-property-expected.txt: Added.
  • web-platform-tests/css/css-animations/keyframes-unrelated-custom-property.html: Added.
  • web-platform-tests/css/css-animations/nested-scale-animations-ref.html: Added.
  • web-platform-tests/css/css-animations/simultaneous-animations-crash.html: Added.
  • web-platform-tests/css/css-animations/svg-transform-animation-ref.html: Added.
  • web-platform-tests/css/css-animations/transform-animation-under-large-scale-ref.html: Added.
  • web-platform-tests/css/css-animations/translation-animation-subpixel-offset-ref.html: Added.
  • web-platform-tests/css/css-animations/w3c-import.log:
  • web-platform-tests/css/css-transitions/animations/change-duration-during-transition-expected.txt: Added.
  • web-platform-tests/css/css-transitions/animations/change-duration-during-transition.html: Added.
  • web-platform-tests/css/css-transitions/animations/color-transition-premultiplied-expected.txt: Added.
  • web-platform-tests/css/css-transitions/animations/color-transition-premultiplied.html: Added.
  • web-platform-tests/css/css-transitions/animations/move-after-transition-expected.txt: Added.
  • web-platform-tests/css/css-transitions/animations/move-after-transition.html: Added.
  • web-platform-tests/css/css-transitions/animations/text-shadow-composition-expected.txt:
  • web-platform-tests/css/css-transitions/animations/text-shadow-composition.html:
  • web-platform-tests/css/css-transitions/animations/text-shadow-interpolation-expected.txt:
  • web-platform-tests/css/css-transitions/animations/text-shadow-interpolation.html:
  • web-platform-tests/css/css-transitions/animations/transition-end-event-shorthands-expected.txt: Added.
  • web-platform-tests/css/css-transitions/animations/transition-end-event-shorthands.html: Added.
  • web-platform-tests/css/css-transitions/animations/transition-timing-function-expected.txt: Added.
  • web-platform-tests/css/css-transitions/animations/transition-timing-function.html: Added.
  • web-platform-tests/css/css-transitions/animations/w3c-import.log:
  • web-platform-tests/css/css-transitions/changing-while-transition-004-expected.txt: Added.
  • web-platform-tests/css/css-transitions/changing-while-transition-004.html: Added.
  • web-platform-tests/css/css-transitions/crashtests/transition-large-word-spacing-001.html: Added.
  • web-platform-tests/css/css-transitions/crashtests/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/w3c-import.log.
  • web-platform-tests/css/css-transitions/event-dispatch.tentative.html:
  • web-platform-tests/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet-ref.html: Added.
  • web-platform-tests/css/css-transitions/retargetted-transition-with-box-sizing-expected.txt: Added.
  • web-platform-tests/css/css-transitions/retargetted-transition-with-box-sizing.html: Added.
  • web-platform-tests/css/css-transitions/root-color-transition-ref.html: Added.
  • web-platform-tests/css/css-transitions/transition-after-animation-001-expected.txt: Added.
  • web-platform-tests/css/css-transitions/transition-after-animation-001.html: Added.
  • web-platform-tests/css/css-transitions/transition-delay-001.html:
  • web-platform-tests/css/css-transitions/transition-duration-001.html:
  • web-platform-tests/css/css-transitions/transition-duration-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-transitions/transition-duration-shorthand.html: Added.
  • web-platform-tests/css/css-transitions/w3c-import.log:
  • web-platform-tests/web-animations/META.yml:
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
  • web-platform-tests/web-animations/animation-model/animation-types/property-types.js:

(const.transformListType.testInterpolation):

  • web-platform-tests/web-animations/idlharness.window-expected.txt:
  • web-platform-tests/web-animations/idlharness.window.js:
  • web-platform-tests/web-animations/interfaces/Animatable/getAnimations-iframe-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/Animatable/getAnimations-iframe.html: Added.
  • web-platform-tests/web-animations/interfaces/Animatable/w3c-import.log:
  • web-platform-tests/web-animations/interfaces/Animation/commitStyles-crash.html: Added.
  • web-platform-tests/web-animations/interfaces/Animation/constructor.html:
  • web-platform-tests/web-animations/interfaces/Animation/onfinish.html:
  • web-platform-tests/web-animations/interfaces/Animation/onremove.html:
  • web-platform-tests/web-animations/interfaces/Animation/w3c-import.log:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html:
  • web-platform-tests/web-animations/responsive/assorted-lengths-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/assorted-lengths.html: Added.
  • web-platform-tests/web-animations/responsive/backgroundPosition-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/backgroundPosition.html: Added.
  • web-platform-tests/web-animations/responsive/backgroundSize-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/backgroundSize.html: Added.
  • web-platform-tests/web-animations/responsive/baselineShift-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/baselineShift.html: Added.
  • web-platform-tests/web-animations/responsive/borderImageWidth-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/borderImageWidth.html: Added.
  • web-platform-tests/web-animations/responsive/borderRadius-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/borderRadius.html: Added.
  • web-platform-tests/web-animations/responsive/borderWidth-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/borderWidth.html: Added.
  • web-platform-tests/web-animations/responsive/boxShadow-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/boxShadow.html: Added.
  • web-platform-tests/web-animations/responsive/clip-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/clip.html: Added.
  • web-platform-tests/web-animations/responsive/columnCount-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/columnCount.html: Added.
  • web-platform-tests/web-animations/responsive/columnGap-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/columnGap.html: Added.
  • web-platform-tests/web-animations/responsive/d-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/d.html: Added.
  • web-platform-tests/web-animations/responsive/font-size-adjust-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/font-size-adjust.html: Added.
  • web-platform-tests/web-animations/responsive/fontSize-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/fontSize.html: Added.
  • web-platform-tests/web-animations/responsive/fontWeight-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/fontWeight.html: Added.
  • web-platform-tests/web-animations/responsive/lineHeight-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/lineHeight.html: Added.
  • web-platform-tests/web-animations/responsive/minHeight-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/minHeight.html: Added.
  • web-platform-tests/web-animations/responsive/offset-path-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/offset-path.html: Added.
  • web-platform-tests/web-animations/responsive/offsetDistance-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/offsetDistance.html: Added.
  • web-platform-tests/web-animations/responsive/offsetRotate-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/offsetRotate.html: Added.
  • web-platform-tests/web-animations/responsive/opacity-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/opacity.html: Added.
  • web-platform-tests/web-animations/responsive/perspective-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/perspective.html: Added.
  • web-platform-tests/web-animations/responsive/rotate-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/rotate.html: Added.
  • web-platform-tests/web-animations/responsive/rowGap-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/rowGap.html: Added.
  • web-platform-tests/web-animations/responsive/shapeMargin-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/shapeMargin.html: Added.
  • web-platform-tests/web-animations/responsive/shapeOutside-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/shapeOutside.html: Added.
  • web-platform-tests/web-animations/responsive/strokeDasharray-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/strokeDasharray.html: Added.
  • web-platform-tests/web-animations/responsive/text-size-adjust-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/text-size-adjust.html: Added.
  • web-platform-tests/web-animations/responsive/textIndent-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/textIndent.html: Added.
  • web-platform-tests/web-animations/responsive/to-color-change-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/to-color-change.html: Added.
  • web-platform-tests/web-animations/responsive/to-inherited-change-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/to-inherited-change.html: Added.
  • web-platform-tests/web-animations/responsive/to-style-change-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/to-style-change.html: Added.
  • web-platform-tests/web-animations/responsive/transform-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/transform.html: Added.
  • web-platform-tests/web-animations/responsive/translate-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/translate.html: Added.
  • web-platform-tests/web-animations/responsive/verticalAlign-expected.txt: Added.
  • web-platform-tests/web-animations/responsive/verticalAlign.html: Added.
  • web-platform-tests/web-animations/responsive/w3c-import.log: Added.
  • web-platform-tests/web-animations/testcommon.js:

(window.assert_time_greater_than_equal.window.assert_time_greater_than_equal):

  • web-platform-tests/web-animations/timing-model/animations/finishing-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/infinite-duration-animation-ref.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/reverse-running-animation-expected.html:
  • web-platform-tests/web-animations/timing-model/animations/reverse-running-animation-ref.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/reverse-running-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/setting-the-timeline-of-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/setting-the-timeline-of-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/sync-start-times-ref.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/sync-start-times.html:
  • web-platform-tests/web-animations/timing-model/animations/update-playback-rate-fast-expected.html:
  • web-platform-tests/web-animations/timing-model/animations/update-playback-rate-fast-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/update-playback-rate-slow-expected.html.
  • web-platform-tests/web-animations/timing-model/animations/update-playback-rate-fast.html:
  • web-platform-tests/web-animations/timing-model/animations/update-playback-rate-slow.html: Removed.
  • web-platform-tests/web-animations/timing-model/animations/update-playback-rate-zero-expected.html:
  • web-platform-tests/web-animations/timing-model/animations/update-playback-rate-zero-ref.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/update-playback-rate-zero.html:
  • web-platform-tests/web-animations/timing-model/animations/w3c-import.log:
  • web-platform-tests/web-animations/timing-model/timelines/document-timelines.html:
  • web-platform-tests/web-animations/timing-model/timelines/timelines-expected.txt:
  • web-platform-tests/web-animations/timing-model/timelines/timelines.html:
  • web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html:

LayoutTests:

7:04 AM Changeset in webkit [287923] by Chris Lord
  • 4 edits in trunk

[WPE] Fix building WebXR with ANGLE enabled
​https://bugs.webkit.org/show_bug.cgi?id=235108

Reviewed by Alejandro G. Castro.

.:

Remove conflict between WebXR and ANGLE WebGL for WPE.

  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

Fix building both ANGLE WebGL and WebXR simultaneously when GLES is
being used.

  • Modules/webxr/WebXROpaqueFramebuffer.cpp:

(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):

6:37 AM Changeset in webkit [287922] by Alan Bujtas
  • 7 edits
    2 adds in trunk

[LFC][IFC] Incorrect negative margin handling (both left/right) with RTL inline base direction
​https://bugs.webkit.org/show_bug.cgi?id=235095

Reviewed by Antti Koivisto.

Source/WebCore:

The simplified negative margin handling on inline boxes does not work well with RTL inline base direction.
With LTR direction, we could just treat the negative left margin value (which pulls content to the left)
as part the "logical width" (may resulting in negative width values) and let this shorter width pull
the the adjoining content.
However this setup produces incorrect box positions when the inline base direction is RTL.
In this patch, we switch over to a more correct inline box positioning where the negative margin
affects the logical left while it does not make the run shorter anymore.

Test: fast/inline/rtl-negative-margins.html

  • layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::appendNonReplacedInlineLevelBox):

  • layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):

  • layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):

  • layout/formattingContexts/inline/InlineLineBuilder.h:
  • layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:

(WebCore::Layout::InlineDisplayLineBuilder::build const):

LayoutTests:

  • fast/inline/rtl-negative-margins-expected.html: Added.
  • fast/inline/rtl-negative-margins.html: Added.
5:05 AM Changeset in webkit [287921] by Nikolas Zimmermann
  • 11 edits
    2 adds in trunk/Source/WebCore

[LBSE] Begin layer-aware RenderSVGContainer implementation
​https://bugs.webkit.org/show_bug.cgi?id=235100

Reviewed by Rob Buis.

Create RenderSVGContainer based on the downstream LBSE implementation.

This patch does not yet enable the creation of RenderSVGContainer
renderers if LBSE is enabled, since the derived classes, such as
RenderSVGHiddenContainer / RenderSVGViewportContainer / ..., are still
missing in LBSE.

Covered by existing tests, no change in behaviour.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGContainer const):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/svg/RenderSVGContainer.cpp: Added.

(WebCore::RenderSVGContainer::RenderSVGContainer):
(WebCore::RenderSVGContainer::layout):
(WebCore::RenderSVGContainer::calculateViewport):
(WebCore::RenderSVGContainer::layoutChildren):
(WebCore::RenderSVGContainer::styleDidChange):
(WebCore::RenderSVGContainer::selfWillPaint):
(WebCore::RenderSVGContainer::paint):
(WebCore::RenderSVGContainer::nodeAtPoint):

  • rendering/svg/RenderSVGContainer.h: Added.

(WebCore::RenderSVGContainer::isObjectBoundingBoxValid const):
(WebCore::RenderSVGContainer::updateLayerInformation):
(WebCore::RenderSVGContainer::pointIsInsideViewportClip):

  • rendering/svg/SVGBoundingBoxComputation.cpp:

(WebCore::SVGBoundingBoxComputation::computeDecoratedBoundingBox const):
(WebCore::SVGBoundingBoxComputation::handleRootOrContainer const):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGContainer):

  • rendering/svg/SVGRenderTreeAsText.h:
  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::attachInternal):
(WebCore::RenderTreeBuilder::detach):

  • rendering/updating/RenderTreeBuilderSVG.cpp:

(WebCore::RenderTreeBuilder::SVG::attach):
(WebCore::RenderTreeBuilder::SVG::detach):

  • rendering/updating/RenderTreeBuilderSVG.h:
5:02 AM Changeset in webkit [287920] by Chris Lord
  • 7 edits in trunk

[WPE] Enable WebGL ANGLE support
​https://bugs.webkit.org/show_bug.cgi?id=235064

Reviewed by Alejandro G. Castro.

.:

Add the USE_ANGLE_WEBGL option for WPE. This is currently incompatible
with WebXR as there isn't an ANGLE GL context code-path there.

  • Source/cmake/OptionsWPE.cmake:

Source/ThirdParty/ANGLE:

Enable building on WPE (mostly copying the GTK build file).

  • PlatformWPE.cmake:

Source/WebCore:

Enable ANGLE WebGL support when building the WPE port.

  • platform/graphics/angle/ANGLEHeaders.h:
  • platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:

(Nicosia::GCGLLayer::swapBuffersIfNeeded):

4:25 AM Changeset in webkit [287919] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[WTF] Exclude any Linux-based platform in DisallowCType.h
​https://bugs.webkit.org/show_bug.cgi?id=235104

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2022-01-12
Reviewed by Adrian Perez de Castro.

  • wtf/DisallowCType.h: Exclude any Linux target from deploying macros

that prevent use of locale-dependent ctype functions in combination with
the glibc C library and a non-libc++ C++ library. This should thus also
cover the JSCOnly port when built on Linux.

4:02 AM Changeset in webkit [287918] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebCore

[GTK][a11y] Defer the emission of AddAccessible signal with ATSPI
​https://bugs.webkit.org/show_bug.cgi?id=234740

Reviewed by Adrian Perez de Castro.

In case of node added and removed quickly, we just avoid the emission of the signal.

  • accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::attachWrapper): Notify the root about its new child earlier to ensure the isolated tree
is created as soon as possible.
(WebCore::AXObjectCache::platformPerformDeferredCacheUpdate): Remove the root case from here.

  • accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::parentChanged): Ensure object is cached before emitting the signal.
(WebCore::AccessibilityAtspi::childrenChanged): Ditto.
(WebCore::AccessibilityAtspi::stateChanged): Ditto.
(WebCore::AccessibilityAtspi::textChanged): Ditto.
(WebCore::AccessibilityAtspi::textAttributesChanged): Ditto.
(WebCore::AccessibilityAtspi::textCaretMoved): Ditto.
(WebCore::AccessibilityAtspi::textSelectionChanged): Ditto.
(WebCore::AccessibilityAtspi::valueChanged): Ditto.
(WebCore::AccessibilityAtspi::selectionChanged): Ditto.
(WebCore::AccessibilityAtspi::loadEvent): Ditto.
(WebCore::AccessibilityAtspi::addToCacheIfNeeded): Helper to add an object to the cache and emit AddAccessible signal.
(WebCore::AccessibilityAtspi::cacheUpdateTimerFired): Update the cache with pending adds.
(WebCore::AccessibilityAtspi::scheduleCacheUpdate): Create the update cache timer if needed and schedule an
update if there isn't a pending one already.
(WebCore::AccessibilityAtspi::addAccessible): Add object to the list and schedule a cache update.
(WebCore::AccessibilityAtspi::removeAccessible): Return early if the object is in the update cache list.

  • accessibility/atspi/AccessibilityAtspi.h:
  • accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::registerObject): Remove the call to AccessibilityRootAtspi::child() when an
object is registered before being attached to the isolated object.

  • accessibility/atspi/AccessibilityRootAtspi.cpp:

(WebCore::AccessibilityRootAtspi::child const): Set m_isInChild.
(WebCore::AccessibilityRootAtspi::childAdded): Return early if the given child is not the current one or called
from child().

  • accessibility/atspi/AccessibilityRootAtspi.h:
3:40 AM Changeset in webkit [287917] by Martin Robinson
  • 5 edits in trunk

Interpolation during animation of two empty transform lists should always yield "none"
​https://bugs.webkit.org/show_bug.cgi?id=235069

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-transforms/animation/list-interpolation-expected.txt: Update to show passes.

Source/WebCore:

No new tests. This is covered by an existing WPT test.

  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::checkForMatchingTransformFunctionLists): When all keyframes have "transform: none"
they transform function lists should match. This allows TransformOperations::blend to avoid doing
matrix interpolation to generate the interpolated transform.

2:29 AM Changeset in webkit [287916] by Nikolas Zimmermann
  • 21 edits
    2 moves in trunk/Source/WebCore

[LBSE] Rename RenderSVGContainer -> LegacyRenderSVGContainer
​https://bugs.webkit.org/show_bug.cgi?id=235099

Reviewed by Rob Buis.

Following the established procedure: rename RenderSVGContainer -> LegacyRenderSVGContainer.
In a follow-up patch RenderSVGContainer will be reintroduced for LBSE, inheriting from
RenderSVGModelObject instead of LegacyRenderSVGModelObject.

Covered by existing tests, no change in behaviour.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isLegacySVGContainer const):
(WebCore::RenderObject::isSVGContainer const): Deleted.

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/svg/LegacyRenderSVGContainer.cpp: Renamed from Source/WebCore/rendering/svg/RenderSVGContainer.cpp.

(WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer):
(WebCore::LegacyRenderSVGContainer::layout):
(WebCore::LegacyRenderSVGContainer::selfWillPaint):
(WebCore::LegacyRenderSVGContainer::paint):
(WebCore::LegacyRenderSVGContainer::addFocusRingRects):
(WebCore::LegacyRenderSVGContainer::updateCachedBoundaries):
(WebCore::LegacyRenderSVGContainer::nodeAtFloatPoint):

  • rendering/svg/LegacyRenderSVGContainer.h: Renamed from Source/WebCore/rendering/svg/RenderSVGContainer.h.

(WebCore::LegacyRenderSVGContainer::didTransformToRootUpdate):
(WebCore::LegacyRenderSVGContainer::isObjectBoundingBoxValid const):
(WebCore::LegacyRenderSVGContainer::calculateLocalTransform):
(WebCore::LegacyRenderSVGContainer::calcViewport):
(WebCore::LegacyRenderSVGContainer::applyViewportClip):
(WebCore::LegacyRenderSVGContainer::pointIsInsideViewportClip):
(WebCore::LegacyRenderSVGContainer::determineIfLayoutSizeChanged):

  • rendering/svg/LegacyRenderSVGShape.h:
  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer):

  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::layout):
(WebCore::RenderSVGResourceMarker::markerBoundaries const):
(WebCore::RenderSVGResourceMarker::draw):

  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::graphicsElement):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::svgSVGElement const):
(WebCore::RenderSVGViewportContainer::paint):

  • rendering/svg/RenderSVGViewportContainer.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore::updateObjectBoundingBox):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGContainer):

  • rendering/svg/SVGRenderTreeAsText.h:
  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::attachInternal):
(WebCore::RenderTreeBuilder::detach):

  • rendering/updating/RenderTreeBuilderSVG.cpp:

(WebCore::RenderTreeBuilder::SVG::attach):
(WebCore::RenderTreeBuilder::SVG::detach):

  • rendering/updating/RenderTreeBuilderSVG.h:
  • svg/SVGPatternElement.cpp:
1:44 AM Changeset in webkit [287915] by youenn@apple.com
  • 9 edits in trunk

New service worker API 'FetchEvent.handled' needs to be supported
​https://bugs.webkit.org/show_bug.cgi?id=208185
<rdar://problem/59808975>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-event-handled.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-event-handled.https.html:
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-handled-worker.js:

(try.event.handled.then):
(catch):
(send_message_to_client): Deleted.

Source/WebCore:

Expose FetchEvent.handled and resolve/reject it as per specification.

Covered by test that we update to not rely on clientIds that we do not support very well.

  • workers/service/FetchEvent.cpp:

(WebCore::FetchEvent::createForTesting):
(WebCore::retrieveHandledPromise):
(WebCore::FetchEvent::FetchEvent):

  • workers/service/FetchEvent.h:
  • workers/service/FetchEvent.idl:
  • workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::processResponse):
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

12:51 AM Changeset in webkit [287914] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Protect DocumentLoader when a reference to its members is used.
​https://bugs.webkit.org/show_bug.cgi?id=233464

Patch by Frédéric Wang <​fwang@igalia.com> on 2022-01-12
Reviewed by Brady Eidson.

Source/WebCore:

No new tests, due to our infra (bug 127676).

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ensure that DocumentLoader loader
remains alive while DocumentLoader::m_mainDocumentError is used.

Source/WebKit:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFinishLoadForFrame): If the navigationID is obsolete, skip update
of the page load state to avoid failure of debug ASSERT.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad): Ensure that DocumentLoader loader
remains alive while DocumentLoader::m_request is used.

Note: See TracTimeline for information about the timeline view.