Context Navigation

← Previous Period
Next Period →

Timeline

Jan 14, 2022:

11:30 PM Changeset in webkit [288053] by Peng Liu

3 edits in trunk/Source/WebCore

Unable to playback portrait videos on HTML canvas elements
https://bugs.webkit.org/show_bug.cgi?id=235238

Reviewed by Jer Noble.

We need to make sure the destination pixel buffer is IOSurface-backed.
Otherwise, VTImageRotationSession cannot rotate a pixel buffer with
a compressed pixel format.

Manually tested.

Layout tests for this exist, but unless they run on an iPhone 12 or
later HW, they won't fail. For example:

media/video-orientation-canvas.html

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastPixelBuffer):

platform/graphics/cv/ImageRotationSessionVT.mm:

(WebCore::ImageRotationSessionVT::rotate):

11:00 PM Changeset in webkit [288052] by commit-queue@webkit.org

4 edits
3 adds in trunk

null ptr deref in WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor()
https://bugs.webkit.org/show_bug.cgi?id=233463

Patch by Frederic Wang <fwang@igalia.com> on 2022-01-14
Reviewed by Wenson Hsieh.

Source/WebCore:

One line of ReplaceSelectionCommand::moveNodeOutOfAncestor() assumes that the pointer
ancestor.parentNode() is non-null. However, the call to removeNode(node) just before can
lead to arbitrary tree mutations that leaves the ancestor orphan, causing a nullptr deref.
This patch mitigates that issue by exiting early if that situation happens.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor): Exit early if the ancestor
is no longer connected.

LayoutTests:

Add non-regression test.

editing/execCommand/paste-as-quotation-disconnected-paragraph-ancestor-crash-expected.txt: Added.
editing/execCommand/paste-as-quotation-disconnected-paragraph-ancestor-crash.html: Added.
editing/execCommand/resources/paste-as-quotation-disconnected-paragraph-ancestor-crash-iframe.html: Added.
platform/win/TestExpectations: Skip test on windows, as the test seems to shift expectations with text output

of other execCommand tests.

8:16 PM Changeset in webkit [288051] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

[macOS WK1] fast/canvas/large-getImageData.html is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=235169

Unreviewed.

This test gets very close to the canvas memory limit. Because
JSC has no guarantees about when objects are collected, this test
has to be run in its own process, which means it requires WK2 and
.

TestExpectations:
platform/wk2/TestExpectations:

7:14 PM Changeset in webkit [288050] by Mikhail R. Gadelha

11 edits in trunk

[JSC] Fix Linux 64bit compilation
https://bugs.webkit.org/show_bug.cgi?id=235232

Reviewed by Saam Barati.

Source/cmake/OptionsCommon.cmake:

Source/bmalloc:

Add new pas_lenient_compact_ptr related files to CMakeLists.txt too.

CMakeLists.txt:
bmalloc/BPlatform.h:
bmalloc/Gigacage.cpp:
bmalloc/IsoHeap.cpp:
bmalloc/IsoHeap.h:
bmalloc/bmalloc.h:

Source/JavaScriptCore:

Define PAS_BMALLOC in all projects since JavaScriptCore includes some files which can require this macro variable.
Previously, JSDollarVM.cpp includes these files first, then at that time, we can define PAS_BMALLOC.
However, after enabling jit-heap, these files are included before JSDollarVM.cpp and include pas_config.h without
PAS_BMALLOC definition, which later causes the problem when including pas_lock.h since non PAS_BMALLOC libpas requires
darwin specific locking.

Since defining PAS_BMALLOC does not matter to whether using libpas or not, this patch just defines it globally.
And for Apple ports, we define this when we define BENABLE_LIBPAS.

tools/JSDollarVM.cpp:

7:11 PM Changeset in webkit [288049] by ysuzuki@apple.com

31 edits
21 copies
6 moves
61 adds
9 deletes in trunk

[JSC] Fix WebAssembly.Global's typename for "anyfunc"
https://bugs.webkit.org/show_bug.cgi?id=235105

Reviewed by Keith Miller.

LayoutTests/imported/w3c:

Update wpt/wasm which includes "anyfunc" tests.

web-platform-tests/wasm/jsapi/assertions.js:

(assert_exported_function):

web-platform-tests/wasm/jsapi/constructor/toStringTag.any.js:
web-platform-tests/wasm/jsapi/exception/basic.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/basic.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/exception/basic.tentative.any.js: Added.

(assert_throws_wasm):
(promise_test.async const):
(promise_test):

web-platform-tests/wasm/jsapi/exception/basic.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/basic.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/exception/constructor.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/constructor.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/exception/constructor.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/exception/constructor.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/constructor.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/exception/getArg.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/getArg.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/exception/getArg.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/exception/getArg.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/getArg.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/exception/is.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/is.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/exception/is.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/exception/is.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/is.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/exception/toString.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/toString.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/exception/toString.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/exception/toString.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/toString.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/exception/type.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/type.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/exception/type.tentative.any.js: Added.

(assert_type):
(test):

web-platform-tests/wasm/jsapi/exception/type.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/exception/type.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/exception/w3c-import.log: Added.
web-platform-tests/wasm/jsapi/function/call.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/call.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/function/call.tentative.any.js: Added.

(addxy):
(test):
(string_appeared_here.test):

web-platform-tests/wasm/jsapi/function/call.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/call.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/function/constructor.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/constructor.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/function/constructor.tentative.any.js: Added.

(addxy):
(test):
(string_appeared_here.test):

web-platform-tests/wasm/jsapi/function/constructor.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/constructor.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/function/table.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/table.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/function/table.tentative.any.js: Added.

(testfunc):
(test):

web-platform-tests/wasm/jsapi/function/table.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/table.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/function/type.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/type.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/function/type.tentative.any.js: Added.

(addNumbers):
(doNothing):
(assert_function):
(test):
(string_appeared_here.test):

web-platform-tests/wasm/jsapi/function/type.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/function/type.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/function/w3c-import.log: Added.
web-platform-tests/wasm/jsapi/global/type.tentative.any-expected.txt:
web-platform-tests/wasm/jsapi/global/type.tentative.any.js:

(test):
(string_appeared_here.test):

web-platform-tests/wasm/jsapi/global/type.tentative.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/proto-from-ctor-realm.html:
web-platform-tests/wasm/jsapi/table/constructor-reftypes.tentative.any-expected.txt:
web-platform-tests/wasm/jsapi/table/constructor-reftypes.tentative.any.js: Removed.
web-platform-tests/wasm/jsapi/table/constructor-reftypes.tentative.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/table/constructor.any-expected.txt:
web-platform-tests/wasm/jsapi/table/constructor.any.js:

(test.get assert_array_equals):
(test):

web-platform-tests/wasm/jsapi/table/constructor.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/table/get-set.any-expected.txt:
web-platform-tests/wasm/jsapi/table/get-set.any.js:

(test):

web-platform-tests/wasm/jsapi/table/get-set.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/table/grow-reftypes.tentative.any-expected.txt:
web-platform-tests/wasm/jsapi/table/grow-reftypes.tentative.any.js: Removed.
web-platform-tests/wasm/jsapi/table/grow-reftypes.tentative.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/table/grow.any-expected.txt:
web-platform-tests/wasm/jsapi/table/grow.any.js:

(test):

web-platform-tests/wasm/jsapi/table/grow.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any-expected.txt:
web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any.js: Removed.
web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/table/type.tentative.any-expected.txt:
web-platform-tests/wasm/jsapi/table/type.tentative.any.js:

(test):

web-platform-tests/wasm/jsapi/table/type.tentative.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/table/type.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/table/w3c-import.log:
web-platform-tests/wasm/jsapi/tag/constructor.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/tag/constructor.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/tag/constructor.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/tag/constructor.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/tag/constructor.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/tag/toString.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/tag/toString.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/tag/toString.tentative.any.js: Added.

(test):

web-platform-tests/wasm/jsapi/tag/toString.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/tag/toString.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/tag/type.tentative.any-expected.txt: Added.
web-platform-tests/wasm/jsapi/tag/type.tentative.any.html: Added.
web-platform-tests/wasm/jsapi/tag/type.tentative.any.js: Added.

(assert_type):
(test):

web-platform-tests/wasm/jsapi/tag/type.tentative.any.worker-expected.txt: Added.
web-platform-tests/wasm/jsapi/tag/type.tentative.any.worker.html: Added.
web-platform-tests/wasm/jsapi/tag/w3c-import.log: Added.
web-platform-tests/wasm/jsapi/wasm-module-builder.js:

(WasmModuleBuilder.prototype.addTable):
(WasmModuleBuilder.prototype.toBuffer):

web-platform-tests/wasm/serialization/module/cross-origin-module-sharing-fails-expected.txt: Added.
web-platform-tests/wasm/serialization/module/cross-origin-module-sharing-fails.html: Added.
web-platform-tests/wasm/serialization/module/resources/incrementer-iframe-failure.html: Added.
web-platform-tests/wasm/serialization/module/resources/w3c-import.log:
web-platform-tests/wasm/serialization/module/share-module-cross-origin-fails.sub-expected.txt: Added.
web-platform-tests/wasm/serialization/module/share-module-cross-origin-fails.sub.html: Added.
web-platform-tests/wasm/serialization/module/w3c-import.log:
web-platform-tests/wasm/webapi/contenttype.any-expected.txt:
web-platform-tests/wasm/webapi/contenttype.any.js:
web-platform-tests/wasm/webapi/contenttype.any.worker-expected.txt:
web-platform-tests/wasm/webapi/resources/incrementer.no_mime_type.wasm: Added.
web-platform-tests/wasm/webapi/resources/incrementer.wasm: Added.
web-platform-tests/wasm/webapi/resources/incrementer.wasm.headers: Added.
web-platform-tests/wasm/webapi/resources/incrementer.wrong_mime_type.wasm: Added.
web-platform-tests/wasm/webapi/resources/incrementer.wrong_mime_type.wasm.headers: Added.
web-platform-tests/wasm/webapi/resources/w3c-import.log: Added.
web-platform-tests/wasm/webapi/w3c-import.log:
web-platform-tests/wasm/webapi/wasm_stream_compile_test-expected.txt: Added.
web-platform-tests/wasm/webapi/wasm_stream_compile_test.html: Added.
web-platform-tests/wasm/webapi/wasm_stream_instantiate_test-expected.txt: Added.
web-platform-tests/wasm/webapi/wasm_stream_instantiate_test.html: Added.

Source/JavaScriptCore:

We should return "anyfunc" string instead of "funcref" according to the spec[1,2].

[1]: https://webassembly.github.io/spec/js-api/#globals
[2]: https://webassembly.github.io/spec/js-api/#tables

wasm/js/JSWebAssemblyGlobal.cpp:

(JSC::JSWebAssemblyGlobal::type):

wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::type):

6:11 PM Changeset in webkit [288048] by Russell Epstein

1 copy in tags/Safari-613.1.14

Tag Safari-613.1.14.

6:04 PM Changeset in webkit [288047] by Russell Epstein

1 copy in tags/Safari-613.1.12.1.9

Tag Safari-613.1.12.1.9.

5:50 PM Changeset in webkit [288046] by Russell Epstein

2 edits in branches/safari-613-branch/Source/ThirdParty/ANGLE

Cherry-pick r288041. rdar://problem/87627318

ANGLE: Supports32BitFloatFiltering is not supported on TVOS
https://bugs.webkit.org/show_bug.cgi?id=235239

Reviewed by Darin Adler.

<rdar://86457081>
Broke an internal build. Caused by https://trac.webkit.org/changeset/286323/webkit

src/libANGLE/renderer/metal/DisplayMtl.mm: (rx::DisplayMtl::supports32BitFloatFiltering const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:49 PM Changeset in webkit [288045] by Russell Epstein

9 edits in branches/safari-613-branch/Source

Versioning.

WebKit-7613.1.14

5:47 PM Changeset in webkit [288044] by Russell Epstein

2 edits in branches/safari-613.1.12.1-branch/Source/ThirdParty/ANGLE

Cherry-pick r288041. rdar://problem/86457081

ANGLE: Supports32BitFloatFiltering is not supported on TVOS
https://bugs.webkit.org/show_bug.cgi?id=235239

Reviewed by Darin Adler.

<rdar://86457081>
Broke an internal build. Caused by https://trac.webkit.org/changeset/286323/webkit

src/libANGLE/renderer/metal/DisplayMtl.mm: (rx::DisplayMtl::supports32BitFloatFiltering const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:37 PM Changeset in webkit [288043] by Jonathan Bedard

3 edits in trunk/Tools

[EWS] Only trigger builds for open and synchronize events
https://bugs.webkit.org/show_bug.cgi?id=235249
<rdar://problem/87615392>

Reviewed by Aakash Jain.

Tools/CISupport/ews-build/events.py:

(Events.stopService):
(GitHubEventHandlerNoEdits):
(GitHubEventHandlerNoEdits.handle_pull_request):

Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/246068@main

5:26 PM Changeset in webkit [288042] by Russell Epstein

9 edits in branches/safari-613.1.12.1-branch/Source

Versioning.

WebKit-7613.1.12.1.9

5:16 PM Changeset in webkit [288041] by Kyle Piddington

2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE: Supports32BitFloatFiltering is not supported on TVOS
https://bugs.webkit.org/show_bug.cgi?id=235239

Reviewed by Darin Adler.

<rdar://86457081>
Broke an internal build. Caused by https://trac.webkit.org/changeset/286323/webkit

src/libANGLE/renderer/metal/DisplayMtl.mm:

(rx::DisplayMtl::supports32BitFloatFiltering const):

5:11 PM Changeset in webkit [288040] by Jonathan Bedard

3 edits in trunk/Tools

[EWS] ShowIdentifier should support pull-requests
https://bugs.webkit.org/show_bug.cgi?id=235252
<rdar://problem/87618736>

Reviewed by Aakash Jain.

Tools/CISupport/ews-build/steps.py:

(ShowIdentifier.start): Extract revision from diverse set of properties.
(ShowIdentifier.evaluateCommand):

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/246066@main

4:56 PM Changeset in webkit [288039] by Wenson Hsieh

4 edits in trunk

[iOS] Occasional crash under -[UITargetedPreview initWithView:parameters:target:] when focusing form controls
https://bugs.webkit.org/show_bug.cgi?id=235248
rdar://79220540

Reviewed by Tim Horton and Aditya Keerthi.

Source/WebKit:

It's possible for -resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets: to return a nil snapshot
view in the case where a screen update has not been performed yet (among other scenarios). In the case where
UIKit returns nil when we're creating the targeted preview for the context menu when focusing a select element
or file input, we'll crash due to an Objective-C exception in the initializer of UITargetedPreview. Mitigate
this by falling back to an empty UIView after requesting the snapshot view to make our code robust against this
scenario.

Test: KeyboardInputTests.DoNotCrashWhenFocusingSelectWithoutViewSnapshot

UIProcess/ios/WKContentViewInteraction.mm:

(createFallbackTargetedPreview):

Tools:

Add an API test that exercises the crash by forcing -resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:
to return nil via swizzling.

TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(TestWebKitAPI::nilResizableSnapshotViewFromRect):
(TestWebKitAPI::TEST):

4:48 PM Changeset in webkit [288038] by Jonathan Bedard

8 edits
3 adds in trunk/Tools

[webkitbugspy] Support radar as issue tracker type
https://bugs.webkit.org/show_bug.cgi?id=234993
<rdar://problem/87276178>

Reviewed by Stephanie Lewis.

Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/init.py:
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/base.py:

(Base): Radar mock should not inherit from mocks.Requests.

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py:

(Bugzilla): Inherit from both Base and mocks.Requests.

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py:

(GitHub): Inherit from both Base and mocks.Requests.

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py: Added.

(AppleDirectoryUserEntry): Mock AppleDirectoryUserEntry from radarclient.
(AppleDirectoryQuery): Mock AppleDirectoryQuery from radarclient.
(RadarModel): Mock various Model objects from radarclient.
(RadarClient): Mock RadarClient from radarclient.
(Radar): Mock radarclient library.
(NoRadar): Mock unavailable radarclient library.

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py: Added.

(Tracker):
(Tracker.radarclient): Optionally import radarclient.
(Tracker.init):
(Tracker.authentication): Determine which authentication strategy to use.
(Tracker.from_string): Construct issue given Radar string
(Tracker.user): Find user given name, DSID or email.
(Tracker.issue): Construct issue given Radar ID.
(Tracker.populate): Populate Issue arguments.

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py: Added.

(TestGitHub):
(TestGitHub.test_no_radar):
(TestGitHub.test_users):
(TestGitHub.test_link):
(TestGitHub.test_title):
(TestGitHub.test_timestamp):
(TestGitHub.test_creator):
(TestGitHub.test_description):
(TestGitHub.test_assignee):
(TestGitHub.test_comments):
(TestGitHub.test_watchers):
(TestGitHub.test_references):
(TestGitHub.test_reference_parse):

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py:

(Tracker): Match single integer issue URLs.

Canonical link: https://commits.webkit.org/246064@main

4:44 PM Changeset in webkit [288037] by mark.lam@apple.com

3 edits
1 add in trunk

JSStringJoiner's constructor should take a size_t length.
https://bugs.webkit.org/show_bug.cgi?id=235217
rdar://87538657

Reviewed by Yusuke Suzuki.

JSTests:

stress/max-typed-array-length-toString.js: Added.

Source/JavaScriptCore:

Also removed an unnecessary exception check in JSStringJoiner::append().
This is because appendWithoutSideEffects() cannot throw any exceptions.

runtime/JSStringJoiner.h:

(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

3:48 PM Changeset in webkit [288036] by commit-queue@webkit.org

4 edits in trunk

JSArray::fastSlice() should not convert the source from CoW
https://bugs.webkit.org/show_bug.cgi?id=234990

Patch by Alexey Shvayka <ashvayka@apple.com> on 2022-01-14
Reviewed by Yusuke Suzuki.

JSTests:

stress/array-slice-cow.js:

Source/JavaScriptCore:

Since we aren't modifying the source array in fastSlice() nor its slow path,
there is no reason to convert it from CopyOnWrite.

runtime/JSArray.cpp:

(JSC::JSArray::fastSlice):

3:24 PM Changeset in webkit [288035] by Alan Bujtas

2 edits in trunk/Source/WebCore

[Cleanup] Remove redundant (and incorrect) RenderStyle::isDisplayReplacedType
https://bugs.webkit.org/show_bug.cgi?id=235250

Reviewed by Simon Fraser.

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::isDisplayInlineType): display types do not make a box replaced.
(WebCore::RenderStyle::isDisplayReplacedType): Deleted.

2:58 PM Changeset in webkit [288034] by dino@apple.com

4 edits in trunk/Source/WebKit

REGRESSION: ARKit example loads a page full of random symbols instead of a 3D model
https://bugs.webkit.org/show_bug.cgi?id=235254

Reviewed by Tim Horton.

When we enabled the ModelDocument support, we disabled the ContentProvider path.
This was a mistake - it has to be a runtime check.

UIProcess/API/Cocoa/WKPreferences.mm: Expose the ModelDocumentEnabled WebPreference so that

it can be read from a WKWebViewConfiguration.
(-[WKPreferences _setModelDocumentEnabled:]):
(-[WKPreferences _modelDocumentEnabled]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:
UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Rather than the compile-time test, check the

WebPreferences to see if ModelDocument is disabled.
(-[WKWebViewContentProviderRegistry initWithConfiguration:]):

2:46 PM Changeset in webkit [288033] by Chris Dumez

4 edits in trunk/Source/WebCore

Clarify / Optimize <select> logic given that deeply nested <option> or <optgroup> are not supported
https://bugs.webkit.org/show_bug.cgi?id=235247

Reviewed by Geoffrey Garen.

Clarify / Optimize <select> logic given that deeply nested <option> or <optgroup> are not supported, as per the
specification.

An <option> is only associated with a <select> element if it is either a child of the <select> or a child of an
<optgroup> that is itself a child of the <select>:

https://html.spec.whatwg.org/multipage/form-elements.html#concept-select-option-list

As a result, an <optgroup> is only associated with a <select> element if it is a child of that <select>.

No new tests, no Web-facing behavior change.

html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement const):
(WebCore::HTMLOptGroupElement::accessKeyAction):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):
(WebCore::HTMLOptionElement::accessKeyAction):
(WebCore::HTMLOptionElement::index const):
(WebCore::HTMLOptionElement::selected const):
(WebCore::HTMLOptionElement::setSelected):
(WebCore::HTMLOptionElement::childrenChanged):
(WebCore::HTMLOptionElement::ownerSelectElement const):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel const):
(WebCore::HTMLOptionElement::insertedIntoAncestor):
(WebCore::HTMLOptionElement::collectOptionInnerText const):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems const):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

2:23 PM Changeset in webkit [288032] by Wenson Hsieh

8 edits in trunk

Avoid redundant text analysis requests when long pressing inside an image that contains Live Text
https://bugs.webkit.org/show_bug.cgi?id=235129
rdar://87366539

Reviewed by Tim Horton.

Source/WebKit:

When long pressing over a non-Live-Text part of an image that otherwise contains Live Text, we currently trigger
Live Text analysis on the image a second time and re-inject the same text recognition results into the image
element. In addition to being unnecessary, this extra text analysis operation causes regular Live Text results
to be injected into images that already contain "block"-style recognized text results, replacing the blocks in
the process.

Address this by adding an optimization to avoid this unnecessary Live Text analysis and injection. See below for
more details.

Test: ImageAnalysisTests.AvoidRedundantTextRecognitionRequests

Shared/ios/InteractionInformationAtPosition.h:
Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Add a new elementContainsImageOverlay bit to position information.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView imageAnalysisGestureDidBegin:]):

In the case where the image already contains an overlay, short-circuit logic to perform text analysis and inject
the results into the image, and instead directly call into the new helper method below to compute visual look up
results and invoke pending context menu completion handler blocks. We pass YES for hasTextResults here
because we know that the image already contains recognized text, due to the elementContainsImageOverlay being
set.

(-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):

Factor out logic for requesting visual look up results on the image into a separate helper method.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::videoPositionInformation):
(WebKit::imagePositionInformation):

Set the elementContainsImageOverlay bit (see above).

Tools:

Add a new API test and refactor some existing tests.

TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(swizzledLocationInView):
(-[TestWKWebView simulateImageAnalysisGesture:]):

Add a helper method to simulate the image analysis gesture recognizer being activated on iOS, and wait for image
analysis to finish.

(TestWebKitAPI::swizzledProcessRequestWithResults):
(TestWebKitAPI::TEST):

Add a new API test to verify that we make at most one extra VKImageAnalyzer request when invoking a non-Live-
Text part of the image a second time. Additionally, adjust an existing test (HandleImageAnalyzerErrors) to
verify that we invoke VKImageAnalyzer a total of two times during the course of one image analysis gesture (once
for Live Text recognition, and another for visual look up). This test currently passes with only a single check
because it ends too early (i.e. after only one round trip to the web process and back).

(TestWebKitAPI::swizzledLocationInView): Deleted.

TestWebKitAPI/cocoa/ImageAnalysisTestingUtilities.mm:

(-[TestVKImageAnalysis hasResultsForAnalysisTypes:]):

Implement this method stub to avoid an unrecognized selector crash.

1:58 PM Changeset in webkit [288031] by jer.noble@apple.com

12 edits
6 adds in trunk

[Cocoa] rVFC() isn't called for initial video load
https://bugs.webkit.org/show_bug.cgi?id=235006

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/request-video-frame-loadstart.html

media/request-video-frame-seek.html

Add a new utility class, QueuedVideoOutput, which will pull pixel buffers out of an AVPlayerItemVideoOutput
pre-emptively. Once those pixel buffers are enqueued locally, their associated timing information can be used to
fire a callback for that buffer's display time.

Previously, paints were blocked from pulling new pixel buffers from the video output. With the QueuedVideoOutput
class, this is no longer necessary. The QueuedVideoOutput will notify its client when the image for currentTime
changes, and other clients can freely ask for the currentTime's image.

To curb runaway memory growth, frames are purged as soon as a new image for the current time is available, and when
the video output signals that its own queues were purged.

WebCore.xcodeproj/project.pbxproj:
html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::cancelVideoFrameCallback):
(WebCore::HTMLVideoElement::serviceRequestVideoFrameCallbacks):

html/HTMLVideoElement.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoFullscreenInlineImage):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::startVideoFrameMetadataGathering):
(WebCore::MediaPlayerPrivateAVFoundationObjC::checkNewVideoFrameMetadata):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastPixelBuffer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::videoOutputHasAvailableFrame):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::pixelBufferForCurrentTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::nativeImageForCurrentTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::colorSpace):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::globalPullDelegateQueue): Deleted.
(WebCore::MediaPlayerPrivateAVFoundationObjC::waitForVideoOutputMediaDataWillChange): Deleted.
(-[WebCoreAVFPullDelegate initWithPlayer:]): Deleted.
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]): Deleted.
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]): Deleted.

platform/graphics/avfoundation/objc/QueuedVideoOutput.h: Added.
platform/graphics/avfoundation/objc/QueuedVideoOutput.mm: Added.

(-[WebQueuedVideoOutputDelegate initWithParent:]):
(-[WebQueuedVideoOutputDelegate outputMediaDataWillChange:]):
(-[WebQueuedVideoOutputDelegate outputSequenceWasFlushed:]):
(-[WebQueuedVideoOutputDelegate observeValueForKeyPath:ofObject:change:context:]):
(WebCore::globalOutputDelegateQueue):
(WebCore::QueuedVideoOutput::create):
(WebCore::QueuedVideoOutput::QueuedVideoOutput):
(WebCore::QueuedVideoOutput::~QueuedVideoOutput):
(WebCore::QueuedVideoOutput::invalidate):
(WebCore::decltype):
(WebCore::QueuedVideoOutput::hasImageForTime const):
(WebCore::QueuedVideoOutput::takeVideoFrameEntryForTime):
(WebCore::QueuedVideoOutput::addCurrentImageChangedObserver):
(WebCore::QueuedVideoOutput::configureNextImageObserver):
(WebCore::QueuedVideoOutput::imageForCurrentTimeChanged):
(WebCore::QueuedVideoOutput::addVideoFrameEntries):
(WebCore::QueuedVideoOutput::purgeVideoFrameEntries):
(WebCore::QueuedVideoOutput::purgeImagesBeforeTime):
(WebCore::QueuedVideoOutput::rateChanged):

Source/WebCore/PAL:

pal/spi/cocoa/AVFoundationSPI.h:

LayoutTests:

media/request-video-frame-loadstart-expected.txt: Added.
media/request-video-frame-loadstart.html: Added.
media/request-video-frame-seek-expected.txt: Added.
media/request-video-frame-seek.html: Added.
platform/ios-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:

1:47 PM Changeset in webkit [288030] by Devin Rousso

11 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: cannot copy grouping of blackboxed call frames
https://bugs.webkit.org/show_bug.cgi?id=234615
<rdar://problem/86989248>

Reviewed by Patrick Angle.

UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype.handleCopyEvent):
(WI.SourcesNavigationSidebarPanel.prototype.handleCopyEvent.addCallFrame): Added.
Include every WI.CallFrame managed by any selected WI.BlackboxedGroupTreeElement when
copying. Also make sure that any async boundaries are taken into account.

UserInterface/Views/BlackboxedGroupTreeElement.js:

(WI.BlackboxedGroupTreeElement):
(WI.BlackboxedGroupTreeElement.prototype.get callFrames): Added.
(WI.BlackboxedGroupTreeElement.prototype.get expandable): Added.
(WI.BlackboxedGroupTreeElement.prototype.onenter): Added.
(WI.BlackboxedGroupTreeElement.prototype.onspace): Added.
Make WI.BlackboxedGroupTreeElement selectable, and add extra action handlers for expansion.

UserInterface/Views/BlackboxedGroupTreeElement.css:

(.tree-outline .item.blackboxed-group):
(.tree-outline .item.blackboxed-group:not(.selected) > *, .tree-outline:not(:focus-within) .item.blackboxed-group.selected > *, body:is(.window-inactive, .window-docked-inactive) .tree-outline .item.blackboxed-group.selected > *): Added.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.blackboxed-group.selected .icon): Added.
Only make the content more transparent if not .selected (when the window/tree has focus).

UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.get expandable): Added.
(WI.TreeElement.treeElementToggled):
Allow toggleOnClick to be used when selectable too. This allows WI.BlackboxedGroupTreeElement
to expand on click while also being able to be selected (e.g. shift-up, command-A, etc.).
All other uses of toggleOnClick set this.selectable = false; anyways, so this will have
no effect to other clients.

UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.insertChild):
(WI.TreeOutline.prototype._treeKeyDown):

UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.update):
Add a helper get expandable instead of assuming it from get hasChildren. This allows
WI.BlackboxedGroupTreeElement to override it and always be true, since there is no
situation where we would disallow expansion (which shows the grouped blackboxed call frames).

UserInterface/Models/CallFrame.js:

(WI.CallFrame.prototype.get displayName): Added.

UserInterface/Views/CallFrameView.js:

(WI.CallFrameView):

UserInterface/Views/CallFrameTreeElement.js:

(WI.CallFrameTreeElement):

UserInterface/Views/ConsoleMessageView.js:

(WI.ConsoleMessageView.prototype.toClipboardString):
Add a helper get displayName to avoid repeated specialized logic.

1:34 PM Changeset in webkit [288029] by Devin Rousso

4 edits in trunk/Source/WebInspectorUI

Web Inspector: add a contextmenu item to create a URL Breakpoint for resources initiated by script
https://bugs.webkit.org/show_bug.cgi?id=235216

Reviewed by Dean Jackson.

UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):
Since URL Breakpoints only work with XHR/fetch, only offer to create a URL Breakpoint if
the WI.SourceCode has initiatorCallFrames, meaning it was triggered by JS. We could
offer this contextmenu item for _all_ resources, but there are many different resource types
that are unlikely (if ever) to be loaded via XHR/fetch (e.g. favicons, manifests, fonts,
initial JS/CSS files, etc.) that it would likely add clutter and possibly confuse developers
into thinking that URL Breakpoints can somehow pause things other than JS. Plus, this can
always be changed in a followup, so better to do something minimal first.

UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager.prototype.urlBreakpointsMatchingURL): Added.
Helper method to find all WI.URLBreakpoint that match a given URL, sorted by how exact
they would match (e.g. a regex match is less exact than ===).

Localizations/en.lproj/localizedStrings.js:

1:07 PM Changeset in webkit [288028] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

Make isJITPC fast
https://bugs.webkit.org/show_bug.cgi?id=235241

Reviewed by Yusuke Suzuki.

Make it an inlined function, and stop tagging g_jscConfig.startExecutableMemory
and g_jscConfig.endExecutableMemory, since they're in the Config page, and
not mutable after it's frozen.

jit/ExecutableAllocator.cpp:

(JSC::initializeJITPageReservation):
(JSC::isJITPC): Deleted.

jit/ExecutableAllocator.h:

(JSC::isJITPC):

1:04 PM Changeset in webkit [288027] by Tyler Wilcock

5 edits in trunk/Source/WebCore

AX: AXIsolatedObject::initializeAttributeData should compute AXAncestorFlags if they are unexpectedly uninitialized
https://bugs.webkit.org/show_bug.cgi?id=235189

Reviewed by Andres Gonzalez.

Currently in AXIsolatedObject::initializeAttributeData, we don't store
any ancestor flags if they are unexpectedly uninitialized (i.e. we're
asked to initialize an isolated object for a live AX object that has
not been added to the live AX tree).

Rather than not storing flags and thus creating an isolated object
with incorrect properties, we should do a single traversal to initialize them.
We should have to do this very rarely since we generally expect to be
given live AX objects with initialized flags here (and debug ASSERT that this is the case).

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::computeAncestorFlagsWithTraversal const):
Added.

accessibility/AccessibilityObject.h:
accessibility/AccessibilityObjectInterface.h:

(WebCore::Accessibility::enumerateAncestors):
Added.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
Compute ancestor flags with a single traversal if they are unexpected uninitialized.

12:43 PM Changeset in webkit [288026] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

MediaPlayerPrivateMediaStreamAVFObjC::m_videoTransform is redundant
https://bugs.webkit.org/show_bug.cgi?id=235181

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-01-14
Reviewed by Youenn Fablet.

The video sample transform was stored as a member variable during video sample
enqueuing. However, this is just a normal video sample property, and
does not need to be handled specially. The member variable anyway ended up being assigned
during use. Calculating the transform is not a heavy operation, since it
is accessed once per video paint.

This simplifies the future code where the underlying video frame would be
used as-is by WebGL, as there we need to have the correct transform.

No new tests, refactor.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoSampleAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::processNewVideoSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateRenderingMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext):

12:41 PM Changeset in webkit [288025] by commit-queue@webkit.org

4 edits
2 adds in trunk

gl.texImage2D upload of getUserMedia streams via <video> element fails
https://bugs.webkit.org/show_bug.cgi?id=230617
<rdar://problem/83407577>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-01-14
Reviewed by Youenn Fablet.

Source/WebCore:

Fix MSE camera to WebGL texture uploads.
Partially revert r280963 for Cocoa MediaPlayer implementatations
that do not have nativeImageForCurrentTime / pixelBufferForCurrentTime.
Turns out MSE does not have these implemented, so currently fall back
to the painting path.

Test: fast/mediastream/getUserMedia-to-canvas.html

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::videoFrameToImage):

LayoutTests:

fast/mediastream/getUserMedia-to-canvas-expected.txt: Added.
fast/mediastream/getUserMedia-to-canvas.html: Added.

Add a test to test getting video frame to 2DContext and
WebGL canvas elements.

webrtc/routines.js:

Add a function to assert that ImageData contains
the simulated mock camera image. This is useful
in verifying that the image is exactly as
expected. The test tests only the default orientation.
Later changes will update the test to address the
camera rotation.

12:07 PM Changeset in webkit [288024] by Chris Dumez

21 edits in trunk

Regression(r281520) 3 subtests started failing on dom/traversal/TreeWalker-acceptNode-filter-cross-realm.html WPT test
https://bugs.webkit.org/show_bug.cgi?id=235153
<rdar://problem/87485756>

Unreviewed, revert r281520 since it regressed dom/traversal/TreeWalker-acceptNode-filter-cross-realm.html WPT test.

LayoutTests/imported/w3c:

web-platform-tests/geolocation-API/non-fully-active.https-expected.txt:

Source/WebCore:

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):

Modules/web-locks/WebLockManager.cpp:

(WebCore::WebLockManager::didCompleteLockRequest):
Covered by "Removed Frame as lock is granted" test in imported/w3c/web-platform-tests/web-locks/frames.tentative.https.html.
Before this change, WebLockGrantedCallback was using incumbent global object (main frame in test) to create a promise instead
of lexical (removed frame in test), causing the test to be false-passing.

bindings/js/JSDOMConvertCallbacks.h:

(WebCore::Converter<IDLCallbackFunction<T>>::convert):
(WebCore::Converter<IDLCallbackInterface<T>>::convert):

dom/TaskSource.h:

LayoutTests:

TestExpectations:
fast/dom/Geolocation/callback-to-deleted-context-expected.txt:
fast/dom/Geolocation/callback-to-deleted-context.html:
fast/dom/Geolocation/disconnected-frame-already-expected.txt:
fast/dom/Geolocation/disconnected-frame-already.html:
fast/dom/Geolocation/disconnected-frame-expected.txt:
fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
fast/dom/Geolocation/disconnected-frame-permission-denied.html:
fast/dom/Geolocation/disconnected-frame.html:
fast/dom/Geolocation/resources/callback-to-deleted-context-inner1.html:
fast/events/detached-svg-parent-window-events-expected.txt:
fast/events/detached-svg-parent-window-events.html:

12:05 PM Changeset in webkit [288023] by sbarati@apple.com

4 edits in trunk/Source/JavaScriptCore

Use IRC for Wasm, and Briggs for JS on ARM64
https://bugs.webkit.org/show_bug.cgi?id=235235
<rdar://87090631>

Reviewed by Yusuke Suzuki and Robin Morisset.

When I turned on IRC for everything in r287218, we saw some
regressions on iOS on JetStream2. So, this patch makes it so
JS code on arm64 goes back to using Briggs, and Wasm will
use IRC.

b3/air/AirAllocateRegistersByGraphColoring.cpp:
b3/air/AirCode.h:

(JSC::B3::Air::Code::setForceIRCRegisterAllocation):
(JSC::B3::Air::Code::forceIRCRegisterAllocation):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompileB3):

11:57 AM Changeset in webkit [288022] by Justin Michaud

3 edits in trunk/JSTests

Update libWABT
https://bugs.webkit.org/show_bug.cgi?id=235050

Update libWabt to support new simd instructions, and add stubs so that the
wasm test runner can run in v8.

Reviewed by Yusuke Suzuki.

wasm/assert.js:
wasm/libwabt.js:

(WabtModule):
(set get if):

11:37 AM Changeset in webkit [288021] by Jonathan Bedard

5 edits in trunk/Tools

[EWS] Support pull-requests in ValidateChange
https://bugs.webkit.org/show_bug.cgi?id=234861
<rdar://problem/87114299>

Reviewed by Aakash Jain.

Tools/CISupport/ews-build/factories.py:

(Factory.init): Rename ValidatePatch to ValidateChange.
(StyleFactory.init): Ditto.
(WatchListFactory.init): Ditto.
(WindowsFactory.init): Ditto.
(CommitQueueFactory.init): Ditto.

Tools/CISupport/ews-build/factories_unittest.py:

(TestExpectedBuildSteps): Step name changed from validate-patch to validate-change.

Tools/CISupport/ews-build/steps.py:

(GitHub.pr_url): Add missing /.
(GitHub.api_url): Convert a repository URL to the API url for that repository.
(GitHub.credentials): Access GitHub credentials from passwords.json.
(GitHubMixin):
(GitHubMixin.fetch_data_from_url_with_authentication):
(GitHubMixin.get_pr_json):
(GitHubMixin._is_pr_closed): Check if a pull-request is closed.
(GitHubMixin._is_pr_obsolete): Check if a pull-request is obsolete.
(ValidateChange): Renamed from ValidatePatch.
(ValidateChange.getResultSummary):
(ValidateChange.start): Invoke validate_bugzilla or validate_github.
(ValidateChange.validate_bugzilla): Check a bugzilla patch.
(ValidateChange.validate_github): Check a GitHub pull-request.
(CompileWebKit.evaluateCommand): Rename ValidatePatch to ValidateChange.
(RunJavaScriptCoreTests.evaluateCommand): Ditto.
(RunWebKitTests.evaluateCommand): Ditto.
(ReRunWebKitTests.evaluateCommand): Ditto.
(RunWebKitTestsRedTree.evaluateCommand): Ditto.
(RunWebKitTestsRepeatFailuresRedTree.evaluateCommand): Ditto.
(RunAPITests.evaluateCommand): Ditto.
(ReRunAPITests.evaluateCommand): Ditto.
(ValidatePatch): Renamed to ValidateChange.

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/246047@main

10:10 AM Changeset in webkit [288020] by ysuzuki@apple.com

3 edits in trunk/Source/WTF

Fix WTF::UUID's potential collision with empty and deleted values
https://bugs.webkit.org/show_bug.cgi?id=235177

Reviewed by Chris Dumez.

Since cryptographicallyRandomValues generates random values, it is possible that it produces 0 or 1.
In that case, it conflicts with empty and deleted values of UUID for hash table. When it is generated
and used, it can break hash tables. This patch avoids that by picking 2 when we generate 0 or 1.

We also avoid using UInt128Impl and instead using UInt128. UInt128Impl is implementation, so we should
always use UInt128. UInt128 can be native uint128_t when it is supported by the compiler: clang and
GCC on 64bit support it.

In this patch, we do not use strict UUID v4. This patch focuses on fixing the existing hash table corruption
bug, and we defer discussion about UUID v4 since it reduces usable bits from 128 to 122, which we need to
investigate the existing usage of UUID (and UUID string) in our tree.

wtf/UUID.cpp:

(WTF::UUID::UUID):

wtf/UUID.h:

(WTF::UUID::UUID):
(WTF::UUID::isHashTableDeletedValue const):
(WTF::UUID::encode const):
(WTF::UUID::decode):

9:10 AM Changeset in webkit [288019] by pvollan@apple.com

5 edits in trunk/Source/WebKit

Inject Launch Services database before NSApplication is initialized
https://bugs.webkit.org/show_bug.cgi?id=235186
<rdar://87468788>

Reviewed by Chris Dumez and Simon Fraser.

To avoid the main thread getting stuck, the Launch Services database should be injected before NSApplication
is initialized, since the initialization now depends on the database.

WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::platformDidReceiveLoadParameters):

WebProcess/cocoa/LaunchServicesDatabaseManager.h:
WebProcess/cocoa/LaunchServicesDatabaseManager.mm:

(WebKit::LaunchServicesDatabaseManager::waitForDatabaseUpdate):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

8:40 AM Changeset in webkit [288018] by Tyler Wilcock

5 edits in trunk/Source/WebCore

AX: Move methods that are unnecessarily in AccessibilityRenderObject to AccessibilityNodeObject (part 1 of n)
https://bugs.webkit.org/show_bug.cgi?id=235204

Reviewed by Chris Fleizach.

Many methods in AccessibilityRenderObject don't actually do anything renderer-specific,
and thus should be in the base class AccessibilityNodeObject. This will help improve our support
for AX objects that normally have renderers, but don't because of CSS or ARIA markup (e.g. display: contents).

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isFileUploadButton const):
(WebCore::AccessibilityNodeObject::correspondingControlForLabelElement const):
(WebCore::AccessibilityNodeObject::correspondingLabelForControlElement const):
(WebCore::AccessibilityNodeObject::labelElementContainer const):
(WebCore::AccessibilityNodeObject::exposesTitleUIElement const):
(WebCore::AccessibilityNodeObject::hasTextAlternative const):

accessibility/AccessibilityNodeObject.h:

Add all of the above methods from AccessibilityRenderObject.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineDropEffects const):
(WebCore::AccessibilityRenderObject::isFileUploadButton const):
(WebCore::AccessibilityRenderObject::labelElementContainer const):
(WebCore::AccessibilityRenderObject::hasTextAlternative const):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement const):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement const):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement const):

accessibility/AccessibilityRenderObject.h:

Move all of the above methods to AccessibilityNodeObject.

7:23 AM Changeset in webkit [288017] by graouts@webkit.org

4 edits in trunk/Source/WebCore

Reduce use of KeyframeEffect::targetElementOrPseudoElement()
https://bugs.webkit.org/show_bug.cgi?id=235228

Reviewed by Antti Koivisto.

The KeyframeEffect::targetElementOrPseudoElement() method is one of the few remaining places
in animation-related code where we deal with PseudoElement objects. As it turns out, a lot of
its remaning call sites are not actually making any use of PseudoElement and should just use
the simple target() method.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::invalidate):

dom/Document.cpp:

(WebCore::Document::matchingAnimations):

dom/Element.cpp:

(WebCore::Element::getAnimations):

7:21 AM Changeset in webkit [288016] by graouts@webkit.org

3 edits in trunk/Source/WebCore

Stop forcing the creation of PseudoElement in KeyframeEffect
https://bugs.webkit.org/show_bug.cgi?id=235225

Reviewed by Antti Koivisto.

At the time we started supporting targeting pseudo-elements using the Web Animations API,
we resorted to some hack-ish code to enforce the creation of a PseudoElement should the
target of the animation be a ::before or ::after pseudo-element.

This isn't necessary, and was due to some incorrect code in
RenderTreeUpdater::GeneratedContent::updatePseudoElement() which this patch corrects.
Indeed, if there are animations targeting the pseudo-element in question, we should not
be removing the pseudo-element and exiting this method.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::didChangeTargetStyleable):
(WebCore::elementOrPseudoElementForStyleable): Deleted.

rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):

5:40 AM Changeset in webkit [288015] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][IFC] Incorrect root inline box position when non-empty atomic inline level child box has height: 0px
https://bugs.webkit.org/show_bug.cgi?id=235218
<rdar://84617690>

Reviewed by Antti Koivisto.

Source/WebCore:

Even if the atomic inline level box itself does not stetch the line box, it may still affect the root inline box position
through baseline "syncing" (This is mostly the case with 0 tall boxes as (non-empty) atomic inline boxes in general stretch the line box).

Test: fast/block/line-layout/non-empty-inline-block-with-zero-height.html

layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:

(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const):

LayoutTests:

fast/block/line-layout/non-empty-inline-block-with-zero-height-expected.html: Added.
fast/block/line-layout/non-empty-inline-block-with-zero-height.html: Added.

4:55 AM Changeset in webkit [288014] by Chris Lord

8 edits
2 moves
1 add in trunk/Source/WebCore

[GTK][WPE] Share code between NicosiaGCGLLayer+ANGLE and NicosiaImageBufferPipe
https://bugs.webkit.org/show_bug.cgi?id=235182

Reviewed by Alejandro G. Castro.

Rename NicosiaGCGLANGLELayer to NicosiaGCGLANGLEPipe and have it
inherit from NicosiaImageBufferPipe instead of NicosiaGCGLLayer.

No new tests, no change in behaviour.

platform/TextureMapper.cmake:
platform/graphics/angle/GraphicsContextGLANGLE.h:
platform/graphics/nicosia/NicosiaImageBufferPipe.cpp:

(Nicosia::NicosiaImageBufferPipe::NicosiaImageBufferPipe):
(Nicosia::NicosiaImageBufferPipe::source const):
(Nicosia::NicosiaImageBufferPipe::layerContentsDisplayDelegate):
(): Deleted.
(Nicosia::WebCore::NicosiaImageBufferPipeSource::NicosiaImageBufferPipeSource): Deleted.
(Nicosia::WebCore::NicosiaImageBufferPipeSource::~NicosiaImageBufferPipeSource): Deleted.
(Nicosia::WebCore::NicosiaImageBufferPipeSource::handle): Deleted.
(Nicosia::WebCore::NicosiaImageBufferPipeSource::swapBuffersIfNeeded): Deleted.

platform/graphics/nicosia/NicosiaImageBufferPipe.h: Added.

(Nicosia::NicosiaImageBufferPipeSource::platformLayer const):

platform/graphics/nicosia/texmap/NicosiaGCGLANGLEPipe.cpp: Renamed from Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp.
platform/graphics/nicosia/texmap/NicosiaGCGLANGLEPipe.h: Renamed from Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h.
platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:

(Nicosia::GCGLLayer::GCGLLayer):
(Nicosia::GCGLLayer::swapBuffersIfNeeded):

platform/graphics/nicosia/texmap/NicosiaGCGLLayer.h:
platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLTextureMapper::GraphicsContextGLTextureMapper):

platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLANGLE::platformDisplay const):
(WebCore::GraphicsContextGLANGLE::platformConfig const):
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):

4:08 AM Changeset in webkit [288013] by Carlos Garcia Campos

7 edits in trunk/Source/WebCore

[GTK][a11y] Unregister objects and clear cache when last client disconnect with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234781

Reviewed by Adrian Perez de Castro.

We currently register objects when there are clients asking for cached items or connect event listeners. We
could unregister the objects and clear the cache if all the clients are disconnected. This patch adds a low
priority timer to clear the cache and unregister the objects if there aren't new clients after 10 seconds
since the last client disconnected.

accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::initializeRegistry): Remove the calls to registerTrees(), since it's now done by
addClient() when the first client is added.
(WebCore::AccessibilityAtspi::addEventListener): Call addClient().
(WebCore::AccessibilityAtspi::addClient): Register the trees if this is the first client. Add the client to the
map and subscribe to NameOwnerChanged to remove the client when it's disconnected.
(WebCore::AccessibilityAtspi::removeClient): Remove the client and start the clear cache timer if the clients
map is empty.
(WebCore::AccessibilityAtspi::cacheClearTimerFired): Unregister all the objects and clear the cache.
(WebCore::AccessibilityAtspi::registerTrees const): Deleted.

accessibility/atspi/AccessibilityAtspi.h:

(WebCore::AccessibilityAtspi::hasClients const): Return whether there are clients connected.
(WebCore::AccessibilityAtspi::hasEventListeners const): Deleted.

accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::didUnregisterObject): Object was unregistered by the clear cache timer,
reset the path and isRegistered members.

accessibility/atspi/AccessibilityObjectAtspi.h:
accessibility/atspi/AccessibilityRootAtspi.cpp:

(WebCore::AccessibilityRootAtspi::registerTree): Return early if already registered.
(WebCore::AccessibilityRootAtspi::didUnregisterTree): Tree was unregistered by the clear caceh timer, reset the
treeIsRegistered member.
(WebCore::AccessibilityRootAtspi::embedded): Check if there are clients.

accessibility/atspi/AccessibilityRootAtspi.h:

3:56 AM Changeset in webkit [288012] by Antti Koivisto

8 edits
2 adds in trunk

[:has() pseudo-class] Avoid O(n^{2) in style invalidation with repeated DOM mutations

https://bugs.webkit.org/show_bug.cgi?id=234842

<rdar://problem/87397176>}

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

web-platform-tests/css/selectors/invalidation/has-complexity-expected.txt: Added.
web-platform-tests/css/selectors/invalidation/has-complexity.html: Added.

Source/WebCore:

Use invalidation selectors to check if a given mutation needs :has() invalidation.

Test: imported/w3c/web-platform-tests/css/selectors/invalidation/has-complexity.html

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

css/SelectorChecker.h:
style/ChildChangeInvalidation.cpp:

(WebCore::Style::ChildChangeInvalidation::invalidateForChangedElement):

Invalidate only if the invalidation ruleset has an invalidation selector that matches
the added/removed element. Even in that case we only need to invalidate if that selector
has not already matched within this parent.

As we don't have persistent state that would remember what already matched accross multiple
mutations, approximate this by checking if the closest sibling matched.

(WebCore::Style::ChildChangeInvalidation::invalidateForHasBeforeMutation):
(WebCore::Style::ChildChangeInvalidation::invalidateForHasAfterMutation):

style/ChildChangeInvalidation.h:

LayoutTests:

TestExpectations:

1:42 AM Changeset in webkit [288011] by Nikolas Zimmermann

6 edits
2 adds in trunk/Source/WebCore

[LBSE] Introduce SVGContainerLayout
https://bugs.webkit.org/show_bug.cgi?id=235101

Reviewed by Rob Buis.

Upstream SVGContainerLayout, a utility class centralizing
the "layout children in SVG render tree" algorithm. The legacy
engines relies on various helper methods in SVGRenderingSupport -- for
LBSE it's all in one place: SVGContainerLayout.

The actual two-pass algorithm is described in the technical document
covering LBSE. It's identical to the LBSE downstream version, which
used to pass all layout tests.

Currently the functionality is not observable, as we don't create
LBSE renderers yet.

Covered by existing tests, no change in behaviour.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
rendering/RenderObject.h:

(WebCore::RenderObject::isSVGLayerAwareRenderer const):

rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layoutChildren):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

rendering/svg/SVGContainerLayout.cpp: Added.

(WebCore::SVGContainerLayout::SVGContainerLayout):
(WebCore::SVGContainerLayout::layoutChildren):
(WebCore::layoutLocationFromRenderer):
(WebCore::setLayoutLocationForRenderer):
(WebCore::SVGContainerLayout::positionChildrenRelativeToContainer):
(WebCore::SVGContainerLayout::verifyLayoutLocationConsistency):
(WebCore::SVGContainerLayout::layoutDifferentRootIfNeeded):
(WebCore::SVGContainerLayout::invalidateResourcesOfChildren):
(WebCore::SVGContainerLayout::layoutSizeOfNearestViewportChanged const):
(WebCore::SVGContainerLayout::transformToRootChanged):

rendering/svg/SVGContainerLayout.h: Added.

12:02 AM Changeset in webkit [288010] by J Pascoe

5 edits in trunk

Expose way to encode CTAP commands with only the hash of ClientDataJSON
https://bugs.webkit.org/show_bug.cgi?id=235191
<rdar://problem/87557846>

Reviewed by Brent Fulgham.

Source/WebKit:

CTAP command encoding covered by existing tests (see CtapRequestTest) and the SPI
in new API tests.

UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(+[_WKWebAuthenticationPanel encodeMakeCredentialCommandWithClientDataHash:options:userVerificationAvailability:]):
(+[_WKWebAuthenticationPanel encodeGetAssertionCommandWithClientDataHash:options:userVerificationAvailability:]):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):
Tests for new SPIs.

Jan 13, 2022:

11:51 PM Changeset in webkit [288009] by graouts@webkit.org

55 edits
13 copies
13 moves
172 adds
6 deletes in trunk/LayoutTests

Update WPT for css/css-pseudo
https://bugs.webkit.org/show_bug.cgi?id=235197

Unreviewed WPT import.

LayoutTests/imported/w3c:

resources/resource-files.json:
web-platform-tests/css/css-pseudo/README.md:
web-platform-tests/css/css-pseudo/active-selection-011.html:
web-platform-tests/css/css-pseudo/active-selection-012-expected.html:
web-platform-tests/css/css-pseudo/active-selection-012.html:
web-platform-tests/css/css-pseudo/active-selection-016.html:
web-platform-tests/css/css-pseudo/active-selection-018.html:
web-platform-tests/css/css-pseudo/active-selection-021.html:
web-platform-tests/css/css-pseudo/active-selection-025.html:
web-platform-tests/css/css-pseudo/active-selection-027.html:
web-platform-tests/css/css-pseudo/active-selection-031.html:
web-platform-tests/css/css-pseudo/active-selection-041-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-041-expected.html.
web-platform-tests/css/css-pseudo/active-selection-043.html:
web-platform-tests/css/css-pseudo/active-selection-045.html:
web-platform-tests/css/css-pseudo/active-selection-051-ref.html: Added.
web-platform-tests/css/css-pseudo/active-selection-056.html:
web-platform-tests/css/css-pseudo/active-selection-057.html:
web-platform-tests/css/css-pseudo/active-selection-063.html:
web-platform-tests/css/css-pseudo/backdrop-animate-002-ref.html: Added.
web-platform-tests/css/css-pseudo/before-after-dynamic-custom-property-001-ref.html: Added.
web-platform-tests/css/css-pseudo/cascade-highlight-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012-expected.html.
web-platform-tests/css/css-pseudo/cascade-highlight-001.html:
web-platform-tests/css/css-pseudo/cascade-highlight-002.html:
web-platform-tests/css/css-pseudo/cascade-highlight-004-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012-expected.html.
web-platform-tests/css/css-pseudo/cascade-highlight-004.html:
web-platform-tests/css/css-pseudo/cascade-highlight-005-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012-expected.html.
web-platform-tests/css/css-pseudo/cascade-highlight-005.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/cascade-highlight-004.html.
web-platform-tests/css/css-pseudo/file-selector-button-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-001-expected.html.
web-platform-tests/css/css-pseudo/file-selector-button-after-part-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-after-part-expected.html.
web-platform-tests/css/css-pseudo/file-selector-button-inherit-expected.txt: Added.
web-platform-tests/css/css-pseudo/file-selector-button-inherit.html: Added.
web-platform-tests/css/css-pseudo/first-letter-001-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-001.html:
web-platform-tests/css/css-pseudo/first-letter-002.html:
web-platform-tests/css/css-pseudo/first-letter-003.html:
web-platform-tests/css/css-pseudo/first-letter-004-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-004.html:
web-platform-tests/css/css-pseudo/first-letter-005-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-and-whitespace-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-background-image-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-block-to-inline-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-exclude-block-child-marker-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-exclude-inline-child-marker-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-exclude-inline-marker-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-hi-001-expected.html: Added.
web-platform-tests/css/css-pseudo/first-letter-hi-001-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-hi-001.html: Added.
web-platform-tests/css/css-pseudo/first-letter-hi-002-expected.html: Added.
web-platform-tests/css/css-pseudo/first-letter-hi-002-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-hi-002.html: Added.
web-platform-tests/css/css-pseudo/first-letter-list-item-dynamic-001-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-of-html-root-crash-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-opacity-001-not-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-opacity-001-ref-expected.html.
web-platform-tests/css/css-pseudo/first-letter-opacity-001-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-opacity-001-ref-expected.html.
web-platform-tests/css/css-pseudo/first-letter-opacity-float-001-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-punctuation-and-space-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-punctuation-and-space.html:
web-platform-tests/css/css-pseudo/first-letter-punctuation-dynamic-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-skip-empty-span-nested-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-skip-empty-span-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-skip-marker-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-width-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-with-quote-ref.html: Added.
web-platform-tests/css/css-pseudo/first-letter-with-span-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-and-marker-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-and-placeholder-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-change-inline-color-nested-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-change-inline-color-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-line-height-001-expected.html: Added.
web-platform-tests/css/css-pseudo/first-line-line-height-001-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-line-height-001.html: Added.
web-platform-tests/css/css-pseudo/first-line-line-height-002-expected.html: Added.
web-platform-tests/css/css-pseudo/first-line-line-height-002-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-line-height-002.html: Added.
web-platform-tests/css/css-pseudo/first-line-on-ancestor-block-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-opacity-001-not-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-opacity-001-ref-expected.html.
web-platform-tests/css/css-pseudo/first-line-opacity-001-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-opacity-001-ref-expected.html.
web-platform-tests/css/css-pseudo/first-line-replaced-001-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-with-before-after-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-with-inline-block-before-ref.html: Added.
web-platform-tests/css/css-pseudo/first-line-with-out-of-flow-ref.html: Added.
web-platform-tests/css/css-pseudo/grammar-error-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/grammar-error-001.html.
web-platform-tests/css/css-pseudo/grammar-error-001.html:
web-platform-tests/css/css-pseudo/grammar-spelling-errors-001.html:
web-platform-tests/css/css-pseudo/grammar-spelling-errors-002.html:
web-platform-tests/css/css-pseudo/highlight-cascade-001-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-001-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-001.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-002-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-002-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-002.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-003-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-003-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-003.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-004-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-004-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-cascade-004.html: Added.
web-platform-tests/css/css-pseudo/highlight-painting-001-expected.html:
web-platform-tests/css/css-pseudo/highlight-painting-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-001-expected.html.
web-platform-tests/css/css-pseudo/highlight-painting-001.html:
web-platform-tests/css/css-pseudo/highlight-painting-002-expected.html:
web-platform-tests/css/css-pseudo/highlight-painting-002-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-002-expected.html.
web-platform-tests/css/css-pseudo/highlight-painting-002.html:
web-platform-tests/css/css-pseudo/highlight-painting-003-expected.html:
web-platform-tests/css/css-pseudo/highlight-painting-003-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003-expected.html.
web-platform-tests/css/css-pseudo/highlight-painting-003.html:
web-platform-tests/css/css-pseudo/highlight-painting-004-expected.html:
web-platform-tests/css/css-pseudo/highlight-painting-004-ref1.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-004-expected.html.
web-platform-tests/css/css-pseudo/highlight-painting-004-ref2.html: Added.
web-platform-tests/css/css-pseudo/highlight-painting-004-ref3.html: Added.
web-platform-tests/css/css-pseudo/highlight-painting-004.html:
web-platform-tests/css/css-pseudo/highlight-paired-cascade-001-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-001-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-001.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-002-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-002-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-002.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-003-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-003-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-003.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-004-notref.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.tentative-expected-mismatch.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.tentative.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-005-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-005.tentative-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-005.tentative.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-006-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-006-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-paired-cascade-006.html: Added.
web-platform-tests/css/css-pseudo/highlight-styling-001-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-styling-001-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-styling-001.html: Added.
web-platform-tests/css/css-pseudo/highlight-styling-002-expected.html: Added.
web-platform-tests/css/css-pseudo/highlight-styling-002-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-styling-002.html: Added.
web-platform-tests/css/css-pseudo/highlight-z-index-001-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-z-index-001.html:
web-platform-tests/css/css-pseudo/highlight-z-index-002-ref.html: Added.
web-platform-tests/css/css-pseudo/highlight-z-index-002.html:
web-platform-tests/css/css-pseudo/marker-and-other-pseudo-elements-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-animate-002-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-color-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-001-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-002-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-003-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-004-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-005-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-006-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-007-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-008-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-009-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-011-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-012-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-013-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-014-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-015-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-016-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-017-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-018-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-019-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-020-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-021-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-022-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-023-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-content-024-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-font-properties-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-font-variant-numeric-default-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-font-variant-numeric-default-ref-expected.html.
web-platform-tests/css/css-pseudo/marker-font-variant-numeric-normal-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-font-variant-numeric-normal-ref-expected.html.
web-platform-tests/css/css-pseudo/marker-hyphens-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-inherit-line-height-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-inherit-values-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-intrinsic-contribution-002-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-line-break-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-line-height-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-tab-size-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-text-align-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-text-combine-upright-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-text-decoration-skip-ink-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-text-emphasis-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-text-shadow-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-text-transform-default-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-text-transform-uppercase-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-unicode-bidi-default-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-unicode-bidi-default-ref-expected.html.
web-platform-tests/css/css-pseudo/marker-unicode-bidi-normal-ref-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-unicode-bidi-normal-ref-expected.html.
web-platform-tests/css/css-pseudo/marker-word-break-ref.html: Added.
web-platform-tests/css/css-pseudo/marker-word-spacing-ref.html: Added.
web-platform-tests/css/css-pseudo/outside-marker-paint-order-ref.html: Added.
web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation.html:
web-platform-tests/css/css-pseudo/parsing/marker-supported-properties.html:
web-platform-tests/css/css-pseudo/placeholder-inherit-expected.txt: Added.
web-platform-tests/css/css-pseudo/placeholder-inherit.html: Added.
web-platform-tests/css/css-pseudo/placeholder-input-number-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/placeholder-input-number-expected.html.
web-platform-tests/css/css-pseudo/selection-background-painting-order-expected.html: Added.
web-platform-tests/css/css-pseudo/selection-background-painting-order-ref1.html: Added.
web-platform-tests/css/css-pseudo/selection-background-painting-order-ref2.html: Added.
web-platform-tests/css/css-pseudo/selection-background-painting-order.html: Added.
web-platform-tests/css/css-pseudo/selection-contenteditable-011.html:
web-platform-tests/css/css-pseudo/selection-decoration-p1-expected.html: Removed.
web-platform-tests/css/css-pseudo/selection-decoration-p2-expected.html: Removed.
web-platform-tests/css/css-pseudo/selection-decoration-p2.html: Removed.
web-platform-tests/css/css-pseudo/selection-decoration-p3-expected.html: Removed.
web-platform-tests/css/css-pseudo/selection-decoration-p4-expected.html: Removed.
web-platform-tests/css/css-pseudo/selection-decoration-p4.html: Removed.
web-platform-tests/css/css-pseudo/selection-input-011.html:
web-platform-tests/css/css-pseudo/selection-originating-decoration-color-expected.html: Added.
web-platform-tests/css/css-pseudo/selection-originating-decoration-color-ref.html: Added.
web-platform-tests/css/css-pseudo/selection-originating-decoration-color.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/selection-decoration-p3.html.
web-platform-tests/css/css-pseudo/selection-originating-strikethrough-order-expected.html: Added.
web-platform-tests/css/css-pseudo/selection-originating-strikethrough-order-ref.html: Added.
web-platform-tests/css/css-pseudo/selection-originating-strikethrough-order.html: Added.
web-platform-tests/css/css-pseudo/selection-originating-underline-order-expected.html: Added.
web-platform-tests/css/css-pseudo/selection-originating-underline-order-ref.html: Added.
web-platform-tests/css/css-pseudo/selection-originating-underline-order.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/selection-decoration-p1.html.
web-platform-tests/css/css-pseudo/selection-overlay-and-grammar-001.html:
web-platform-tests/css/css-pseudo/selection-overlay-and-spelling-001.html:
web-platform-tests/css/css-pseudo/selection-paint-image-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/selection-paint-image-expected.html.
web-platform-tests/css/css-pseudo/selection-textarea-011.html:
web-platform-tests/css/css-pseudo/spelling-error-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/spelling-error-001.html.
web-platform-tests/css/css-pseudo/spelling-error-001.html:
web-platform-tests/css/css-pseudo/target-text-001-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-001.html: Added.
web-platform-tests/css/css-pseudo/target-text-002-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-002.html: Added.
web-platform-tests/css/css-pseudo/target-text-003-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-003.html: Added.
web-platform-tests/css/css-pseudo/target-text-004-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-004.html: Added.
web-platform-tests/css/css-pseudo/target-text-005-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-005.html: Added.
web-platform-tests/css/css-pseudo/target-text-006-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-006.html: Added.
web-platform-tests/css/css-pseudo/target-text-007-expected.txt: Added.
web-platform-tests/css/css-pseudo/target-text-007.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-001-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-001-ref.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-001.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-002-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-002.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-003-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-003.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-004-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-dynamic-004.html: Added.
web-platform-tests/css/css-pseudo/target-text-lime-green-ref.html: Added.
web-platform-tests/css/css-pseudo/target-text-lime-ref.html: Added.
web-platform-tests/css/css-pseudo/target-text-text-decoration-001-expected.html: Added.
web-platform-tests/css/css-pseudo/target-text-text-decoration-001-ref.html: Added.
web-platform-tests/css/css-pseudo/target-text-text-decoration-001.html: Added.
web-platform-tests/css/css-pseudo/target-text-two-words-ref.html: Added.
web-platform-tests/css/css-pseudo/textpath-selection-011-expected.html:
web-platform-tests/css/css-pseudo/textpath-selection-011-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/textpath-selection-011-expected.html.
web-platform-tests/css/css-pseudo/textpath-selection-011.html:
web-platform-tests/css/css-pseudo/w3c-import.log:

LayoutTests:

TestExpectations:
platform/gtk/TestExpectations:
platform/ios/TestExpectations:

10:15 PM Changeset in webkit [288008] by Simon Fraser

6 edits in trunk/Source/WebCore

Don't call invalidateRectsForAllMarkers() for every layer in the updateLayerPositions() traversal
https://bugs.webkit.org/show_bug.cgi?id=235211

Reviewed by Alan Bujtas.

RenderLayer::updateLayerPositions() called renderer().document().markers().invalidateRectsForAllMarkers()
but that is called on every layer in the recursive updateLayerPositions() traveral. Yet it only needs
to be called once.

So differentiate the entry points for layer traversal from the recursive traversal functions
by using "recursive" in the naming of the latter, and move two of those entrypoints from
RenderLayerScrollableArea back to RenderLayer so everything is in the same file.

Now the entrypoints can call willUpdateLayerPositions() which does the invalidateRectsForAllMarkers().

page/FrameView.cpp:

(WebCore::FrameView::updateLayerPositionsAfterScrolling):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::willUpdateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterStyleChange):
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::recursiveUpdateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll):
(WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll):
(WebCore::RenderLayer::recursiveUpdateLayerPositionsAfterScroll):
(WebCore::RenderLayer::updateLayerPositions): Deleted.
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Deleted.

rendering/RenderLayer.h:

(WebCore::RenderLayer::recursiveUpdateLayerPositionsAfterScroll):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Deleted.

rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::scrollTo):
(WebCore::RenderLayerScrollableArea::updateLayerPositionsAfterDocumentScroll): Deleted.
(WebCore::RenderLayerScrollableArea::updateLayerPositionsAfterOverflowScroll): Deleted.

rendering/RenderLayerScrollableArea.h:

8:37 PM Changeset in webkit [288007] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[RISCV64] riscv64 backend should lower offlineasm instructions
https://bugs.webkit.org/show_bug.cgi?id=234952
<rdar://problem/87440612>

Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-01-13
Reviewed by Yusuke Suzuki.

In the riscv64 offlineasm backend, instead of handling higher-level
offlineasm instructions with different operand combinations and manually
juggling temp registers, use the approach of aggressively lowering these
opcodes into sequences of RISC-V instructions.

Addresses and immediate values are lowered into usable forms where
necessary. Different lowering phases handle any offlineasm instruction
so that the resulting opcodes can be, with accompanying operands, used
trivially to construct the RISC-V assembly.

Lowered RISC-V opcodes use the 'rv_' prefix so that they can be easily
diassociated from any offlineasm opcode that might share the same name.
The prefix is removed when the assembly is finally generated.

offlineasm/riscv64.rb:

7:25 PM Changeset in webkit [288006] by Alan Bujtas

2 edits in trunk/Source/WebCore

[Cleanup] Line::selectionState logic is slightly confusing and redundant
https://bugs.webkit.org/show_bug.cgi?id=235187

Reviewed by Antti Koivisto.

Go from a seemingly random set of conditions to a incremental state change (None -> Start -> Inside -> End).

(This also removes redundant code like "if (state == None

((boxState == Start

boxState == End) && (state == None

state == Inside)))"

and clears up what "state" here actually means.)

layout/integration/InlineIteratorLine.cpp:

(WebCore::InlineIterator::Line::selectionState const):

7:14 PM Changeset in webkit [288005] by Chris Dumez

9 edits in trunk

Unable to have new lines in HTMLTextArea's placeholder text
https://bugs.webkit.org/show_bug.cgi?id=235205

Reviewed by Wenson Hsieh.

Source/WebCore:

Unlike the placeholder for HTMLInputElement, the placeholder for HTMLTextAreaElement needs
to allow new lines as per:

https://html.spec.whatwg.org/multipage/form-elements.html#attr-textarea-placeholder

This aligns our behavior with Blink and Gecko.

No new tests, unskipped existing WPT tests.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::placeholder const):

html/HTMLInputElement.h:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder const): Deleted.

html/HTMLTextFormControlElement.h:
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):

LayoutTests:

Unskip WPT tests that are no longer failing.

TestExpectations:

7:06 PM Changeset in webkit [288004] by Chris Dumez

6 edits in trunk

html/semantics/scripting-1/the-script-element/script-type-and-language-empty.html WPT test is failing
https://bugs.webkit.org/show_bug.cgi?id=235202

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

web-platform-tests/html/semantics/scripting-1/the-script-element/script-type-and-language-empty-expected.txt:

Source/WebCore:

Per https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script (step 8), we should assume
the type is "text/javascript" if the type attribute is present and its value is the empty string.
Our logic in ScriptElement::determineScriptType() was slightly wrong and didn't get this case right
because it was doing an isEmpty() check which could mean both that the attribute is missing or present
with a value that is the empty string.

No new tests, rebaselined existing test.

dom/ScriptElement.cpp:

(WebCore::ScriptElement::determineScriptType const):

6:53 PM Changeset in webkit [288003] by Cameron McCormack

3 edits
2 adds in trunk

Only apply automatic minimum block-size aspect-ratio rules to non-replaced elements
https://bugs.webkit.org/show_bug.cgi?id=235058
<rdar://85505101>

Reviewed by Alan Bujtas.

Source/WebCore:

The rules in https://www.w3.org/TR/css-sizing-4/#aspect-ratio-minimum
that define the automatic minimum size of an element subject to an
aspect-ratio only apply if the element is non-replaced.

In constrainLogicalHeightByMinMax specifically, when min-height is
auto, after applying the aspect-ratio to produce an automatic minimum
height, we bump it up to the content height if the element has
children. This, presumably, is to account for the way the height of a
block is computed in CSS 2.2. (As CSS 2.2 doesn't have an auto value
for min-height, and a CSS Block Layout module has not been written in
terms of CSS Sizing concepts, there is no clear definition of
automatic minimum sizing for blocks at the moment.) If we erroneously
apply this to a replaced element, such as an image or video, it can
get a computed min-height equal to the intrinsic height of the image,
which may be much larger than expected.

This commit adds an is<RenderReplaced>() check for both automatic
minimum logical width and height calculations, although I was unable to
produce a test to exercise the logical width case (which does not take
the intrinsic size into account when computing the automatic minimum).

Test: fast/css/aspect-ratio-min-height-replaced.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
(WebCore::RenderBox::constrainLogicalHeightByMinMax const):

LayoutTests:

Test that replaced elements with child content (in this case, a
<video> element's controls in the UA shadow tree) don't influence the
automatic minimum size calculation.

fast/css/aspect-ratio-min-height-replaced-expected.html: Added.
fast/css/aspect-ratio-min-height-replaced.html: Added.

6:40 PM Changeset in webkit [288002] by sbarati@apple.com

4 edits in trunk/Source/JavaScriptCore

Link Wasm code on the same thread that JITs
https://bugs.webkit.org/show_bug.cgi?id=235201

Reviewed by Yusuke Suzuki and Mark Lam.

This is preparing us for the changes that'll be needed by
https://bugs.webkit.org/show_bug.cgi?id=235192.

It should also be a small perf improvement, as we're now linking
in parallel instead of doing it after all compilations have finished.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompileB3):

wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::prepareImpl):
(JSC::Wasm::BBQPlan::compileFunction):
(JSC::Wasm::BBQPlan::didCompleteCompilation):
(JSC::Wasm::BBQPlan::initializeCallees):

wasm/WasmBBQPlan.h:

5:57 PM Changeset in webkit [288001] by Russell Epstein

1 copy in tags/Safari-613.1.13

Tag Safari-613.1.13.

5:15 PM Changeset in webkit [288000] by Simon Fraser

3 edits in trunk/Source/WebCore

Move the code that computes layer content visibility into its own function
https://bugs.webkit.org/show_bug.cgi?id=235195

Reviewed by Alan Bujtas.

Just move into its own function the code with the odd-looking RenderObject walk that looks
for visibility:visible non-layer children in a visibility:hidden ancestor.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateDescendantDependentFlags):
(WebCore::RenderLayer::computeHasVisibleContent const):

rendering/RenderLayer.h:

5:01 PM Changeset in webkit [287999] by commit-queue@webkit.org

23 edits in trunk/Source

[XCBuild] Add "product dependencies" which influence workspace build order
https://bugs.webkit.org/show_bug.cgi?id=235094

Source/JavaScriptCore:

Some ancillary targets (e.g. script-only targets like Derived Sources) do not have implicit
dependencies visible to Xcode. In workspace builds, we need to give XCBuild additional
information to ensure that they always run after their dependencies.

This patch adds "Product Dependencies" phases, which are Copy Files phases that copy the
_product_ of another dependency. The product names are also added to
EXCLUDED_SOURCE_FILE_NAMES, making the actual copy a no-op, but these phases give XCBuild
enough metadata to infer the relationship between targets.

For example, JavaScriptCore's "Generate Unified Sources" target depends on headers from WTF,
so it lists libWTF.a in its Product Dependencies. Xcode sees the relationship between the
target doing the copy (Generate Unified Sources) and the target which produces the product
(WTF) and schedules them accordingly.

Because these dependencies are _implicit_ and the copy phases are no-ops, they do not
influence command-line or production builds where each project is built separately.