Context Navigation

← Previous Period
Next Period →

Timeline

Jan 30, 2022:

9:47 PM Changeset in webkit [288806] by commit-queue@webkit.org

194 edits
1 delete in trunk/LayoutTests

Update LayoutTests/resources/testharness.js to 2021-6-24 version
https://bugs.webkit.org/show_bug.cgi?id=235398
<rdar://problem/88126222>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-01-30
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update tests to accommodate the API change:

assert_throws_js check that the exception is of a particular JS exception type
assert_throws_dom check that the exception is of a particular DOMException type from a particular global object.
assert_throws_exactly check that the exception is a specific object.

IndexedDB-private-browsing/close-in-upgradeneeded.html:
IndexedDB-private-browsing/idbcursor-advance-invalid.html:
IndexedDB-private-browsing/idbcursor_advance_index2.html:
IndexedDB-private-browsing/idbcursor_advance_index3.html:
IndexedDB-private-browsing/idbcursor_advance_index6.html:
IndexedDB-private-browsing/idbcursor_advance_index7.html:
IndexedDB-private-browsing/idbcursor_advance_index8.html:
IndexedDB-private-browsing/idbcursor_advance_index9.html:
IndexedDB-private-browsing/idbcursor_advance_objectstore2.html:
IndexedDB-private-browsing/idbcursor_advance_objectstore3.html:
IndexedDB-private-browsing/idbcursor_advance_objectstore4.html:
IndexedDB-private-browsing/idbcursor_advance_objectstore5.html:
IndexedDB-private-browsing/idbcursor_continue_index2.html:
IndexedDB-private-browsing/idbcursor_continue_index3.html:
IndexedDB-private-browsing/idbcursor_continue_index4.html:
IndexedDB-private-browsing/idbcursor_continue_index7.html:
IndexedDB-private-browsing/idbcursor_continue_index8.html:
IndexedDB-private-browsing/idbcursor_continue_invalid.html:
IndexedDB-private-browsing/idbcursor_continue_objectstore2.html:
IndexedDB-private-browsing/idbcursor_continue_objectstore3.html:
IndexedDB-private-browsing/idbcursor_continue_objectstore4.html:
IndexedDB-private-browsing/idbcursor_continue_objectstore5.html:
IndexedDB-private-browsing/idbcursor_continue_objectstore6.html:
IndexedDB-private-browsing/idbcursor_delete_index2.html:
IndexedDB-private-browsing/idbcursor_delete_index3.html:
IndexedDB-private-browsing/idbcursor_delete_index4.html:
IndexedDB-private-browsing/idbcursor_delete_index5.html:
IndexedDB-private-browsing/idbcursor_delete_objectstore2.html:
IndexedDB-private-browsing/idbcursor_delete_objectstore3.html:
IndexedDB-private-browsing/idbcursor_delete_objectstore4.html:
IndexedDB-private-browsing/idbcursor_delete_objectstore5.html:
IndexedDB-private-browsing/idbcursor_update_index2.html:
IndexedDB-private-browsing/idbcursor_update_index3.html:
IndexedDB-private-browsing/idbcursor_update_index4.html:
IndexedDB-private-browsing/idbcursor_update_index5.html:
IndexedDB-private-browsing/idbcursor_update_index6.html:
IndexedDB-private-browsing/idbcursor_update_index7.html:
IndexedDB-private-browsing/idbcursor_update_objectstore2.html:
IndexedDB-private-browsing/idbcursor_update_objectstore3.html:
IndexedDB-private-browsing/idbcursor_update_objectstore5.html:
IndexedDB-private-browsing/idbcursor_update_objectstore6.html:
IndexedDB-private-browsing/idbcursor_update_objectstore7.html:
IndexedDB-private-browsing/idbcursor_update_objectstore8.html:
IndexedDB-private-browsing/idbdatabase_createObjectStore11.html:
IndexedDB-private-browsing/idbdatabase_createObjectStore3.html:
IndexedDB-private-browsing/idbdatabase_createObjectStore4.html:
IndexedDB-private-browsing/idbdatabase_createObjectStore6.html:
IndexedDB-private-browsing/idbdatabase_createObjectStore9-invalidparameters.html:
IndexedDB-private-browsing/idbdatabase_deleteObjectStore2.html:
IndexedDB-private-browsing/idbdatabase_deleteObjectStore3.html:
IndexedDB-private-browsing/idbdatabase_deleteObjectStore4-not_reused.html:
IndexedDB-private-browsing/idbdatabase_transaction.html:
IndexedDB-private-browsing/idbdatabase_transaction3.html:
IndexedDB-private-browsing/idbdatabase_transaction4.html:
IndexedDB-private-browsing/idbdatabase_transaction5.html:
IndexedDB-private-browsing/idbfactory_cmp2.html:
IndexedDB-private-browsing/idbfactory_open9.html:
IndexedDB-private-browsing/idbindex-multientry-arraykeypath.html:
IndexedDB-private-browsing/idbindex_count4.html:
IndexedDB-private-browsing/idbindex_get5.html:
IndexedDB-private-browsing/idbindex_get6.html:
IndexedDB-private-browsing/idbindex_get7.html:
IndexedDB-private-browsing/idbindex_getKey5.html:
IndexedDB-private-browsing/idbindex_getKey6.html:
IndexedDB-private-browsing/idbindex_getKey7.html:
IndexedDB-private-browsing/idbindex_openCursor.html:
IndexedDB-private-browsing/idbindex_openCursor2.html:
IndexedDB-private-browsing/idbindex_openKeyCursor.html:
IndexedDB-private-browsing/idbindex_openKeyCursor2.html:
IndexedDB-private-browsing/idbindex_openKeyCursor3.html:
IndexedDB-private-browsing/idbkeyrange_incorrect.html:
IndexedDB-private-browsing/idbobjectstore_add10.html:
IndexedDB-private-browsing/idbobjectstore_add11.html:
IndexedDB-private-browsing/idbobjectstore_add12.html:
IndexedDB-private-browsing/idbobjectstore_add13.html:
IndexedDB-private-browsing/idbobjectstore_add15.html:
IndexedDB-private-browsing/idbobjectstore_add16.html:
IndexedDB-private-browsing/idbobjectstore_add9.html:
IndexedDB-private-browsing/idbobjectstore_clear3.html:
IndexedDB-private-browsing/idbobjectstore_clear4.html:
IndexedDB-private-browsing/idbobjectstore_count4.html:
IndexedDB-private-browsing/idbobjectstore_createIndex10.html:
IndexedDB-private-browsing/idbobjectstore_createIndex11.html:
IndexedDB-private-browsing/idbobjectstore_createIndex12.html:
IndexedDB-private-browsing/idbobjectstore_createIndex13.html:
IndexedDB-private-browsing/idbobjectstore_delete6.html:
IndexedDB-private-browsing/idbobjectstore_delete7.html:
IndexedDB-private-browsing/idbobjectstore_deleteIndex.html:
IndexedDB-private-browsing/idbobjectstore_deleted.html:
IndexedDB-private-browsing/idbobjectstore_get6.html:
IndexedDB-private-browsing/idbobjectstore_get7.html:
IndexedDB-private-browsing/idbobjectstore_openCursor_invalid.html:
IndexedDB-private-browsing/idbobjectstore_put10.html:
IndexedDB-private-browsing/idbobjectstore_put11.html:
IndexedDB-private-browsing/idbobjectstore_put12.html:
IndexedDB-private-browsing/idbobjectstore_put13.html:
IndexedDB-private-browsing/idbobjectstore_put15.html:
IndexedDB-private-browsing/idbobjectstore_put16.html:
IndexedDB-private-browsing/idbobjectstore_put9.html:
IndexedDB-private-browsing/key_invalid.html:
IndexedDB-private-browsing/keypath_invalid.html:
IndexedDB-private-browsing/transaction-create_in_versionchange.html:

LayoutTests:

Copy testharness.js from imported/w3c/web-platform-tests

Copy idlharness.js from imported/w3c/web-platform-tests because it uses
the new testharness.js APIs.

Copy webidl2.js from imported/w3c/web-platform-tests to resources/WebIDLParser.js
because idlharness uses new webidl2.js logic.

Delete testharness.css, it is now bundled in testharness.js.

Update tests to accommodate the API change:

assert_throws_js check that the exception is of a particular JS exception type
assert_throws_dom check that the exception is of a particular DOMException type from a particular global object.
assert_throws_exactly check that the exception is a specific object.

Previously assert_throws was used and it hid unexpected exception errors.

Same for promise_rejects_*

async_test(f) now warns if f is not a normal function.

Singl page tests need a setup function.

animations/animation-direction-normal.html:
animations/animation-direction-reverse.html:
animations/change-keyframes-name.html:
animations/play-state-paused.html:

async_test(async function {...}) is incorrect (async test expects normal
function that has asynchronous logic, not a function returning a promise.
Use correct form:
promise_test(async function { ... });

css-custom-properties-api/registerProperty.html:

Update exception expectation functions.

editing/pasteboard/datatransfer-idl-expected.txt:
editing/pasteboard/datatransfer-idl.html:

Update the datatransfer related idls from source, otherwise
tests fail (harness now tests for constructor).
Update the results.

editing/text-iterator/count-matches-in-frames.html:
editing/text-iterator/hidden-textarea-selection-quirk.html:
fast/canvas/webgl/webgl2/bindings.html:
fast/custom-elements/defined-pseudo-class.html:
fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html:
fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html:
fast/dom/document-all.html:
fast/dom/elementFromPoint-parameters.html:
fast/dom/replaceable-setter-throws-if-defineownproperty-fails.html:
fast/dom/window-opener-setter-throws-if-defineownproperty-fails-1.html:
fast/dom/window-opener-setter-throws-if-defineownproperty-fails-2.html:
fast/events/clipboard-event-constructor.html:
fast/files/workers/resources/worker-file-reader-sync-bad-parameter.js:
fast/files/xhr-blob-request.html:
fast/mediacapturefromelement/CanvasCaptureMediaStream-exceptions.html:
fast/mediasession/metadata/artworkdownload.html:
fast/mediastream/screencapture-user-gesture.html:
fetch/fetch-url-serialization.html:
http/tests/fetch/fetching-same-resource-with-different-options.html:
http/tests/fetch/redirectmode-and-preload.html:
http/tests/navigation/pushstate-at-unique-origin-denied.py:
http/tests/notifications/notification.html:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:
http/tests/paymentrequest/payment-is-showing.https.html:
http/tests/paymentrequest/payment-request-abort-method.https.html:
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
http/tests/paymentrequest/payment-request-merchant-validation.https.html:
http/tests/paymentrequest/payment-request-show-method.https.html:
http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html:
http/tests/paymentrequest/payment-response-retry-method.https.html:
http/tests/paymentrequest/rejects_if_not_active.https.html:
http/tests/paymentrequest/updateWith-method-pmi-handling.https.html:
http/tests/security/bypassing-cors-checks-for-extension-urls.html:
http/tests/security/clean-origin-css-exposed-resource-timing.html:
http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-xfo.html:
http/tests/security/contentSecurityPolicy/1.1/scripthash-default-src.html:
http/tests/security/contentSecurityPolicy/1.1/stylehash-default-src.html:
http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html:
http/tests/security/cross-origin-clean-css-resource-timing.html:
http/tests/security/cross-origin-css-resource-timing.html:
http/tests/subresource-integrity/sri-fetch.js:
http/tests/workers/service/service-worker-crossorigin-fetch.html:
http/tests/xmlhttprequest/set-bad-headervalue.html:
intersection-observer/intersection-observer-interface.html:
js/dom/dom-getters-type-check.html:
js/dom/legacy-platform-object-defineOwnProperty.html:
js/dom/post-message-symbol.html:
js/dom/queue-microtask-window.html:
media/track/opera/interfaces/TextTrackCue/vertical.html:
media/track/opera/resources/idlharness.js:
media/track/texttrackcue/texttrackcue-constructor.html:
media/track/w3c/interfaces/TextTrackCue/align.html:
pointerevents/ios/pointer-events-implicit-capture-release-exception.html:
pointerevents/ios/pointer-events-set-pointer-capture-exceptions.html:
pointerevents/pointer-id-crash.html:
resources/WebIDLParser.js:
resources/idlharness.js:

Update from wpt.

resources/testharness.css: Removed.
resources/testharness.js:

Update from wpt.

storage/websql/openDatabase-deprecation.html:
streams/readable-byte-stream-controller.js:
streams/readable-stream-byob-reader.js:
streams/readable-stream-byob-request.js:
streams/readable-stream-getReader.html:
streams/reference-implementation/bad-strategies.html:
streams/reference-implementation/bad-underlying-sinks.html:
streams/reference-implementation/transform-stream-expected.txt:
streams/reference-implementation/transform-stream.html:
webanimations/accelerated-animation-single-keyframe.html:
webanimations/frame-rate/animation-frame-rate.html:
webanimations/scheduling-of-animation-with-steps-timing-function-on-effect.html:
webanimations/scheduling-of-animation-with-steps-timing-function-on-keyframe.html:
webanimations/scheduling-of-css-animation-with-explicit-steps-timing-function-on-some-keyframes.html:
webanimations/scheduling-of-css-animation-with-implicit-steps-timing-function.html:
webaudio/webaudio-gc.html:
webrtc/calling-peerconnection-once-closed.html:
webrtc/certificates-indexeddb.html:
webrtc/datachannel/creation.html:
webrtc/datachannel/datachannel-event.html:
webrtc/datachannel/getStats-no-prflx-remote-candidate.html:
webrtc/disable-encryption.html:
webrtc/legacy-api-expected.txt:
webrtc/pc-detached-document.html:
webrtc/stun-server-filtering.html:

8:19 PM Changeset in webkit [288805] by Diego Pino Garcia

2 edits in trunk/Source/WTF

[WinCairo] 'fileSystemRepresentation' identifier not found in URL.cpp
https://bugs.webkit.org/show_bug.cgi?id=235875

Unreviewed build fix.

Add missing header include.

wtf/URL.cpp:

(WTF::URL::fileSystemPath const):

7:58 PM Changeset in webkit [288804] by rniwa@webkit.org

123 edits
20 deletes in trunk

Source/WebCore:
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto and Darin Adler.

Deleted most of code for keygen since it has been always disabled for a while but preserve
the HTML tree builder behavior for compatibility purposes as required by the HTML5 specification.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h: Also remove the entry for HTMLSlotElement which is no longer

used since the runtime flag for enabling shadow DOM had been removed.

css/html.css:
css/legacyFormControlsIOS.css:
css/themeWin.css:
editing/MarkupAccumulator.cpp:

(WebCore::elementCannotHaveEndTag):

html/HTMLKeygenElement.cpp: Removed.
html/HTMLKeygenElement.h: Removed.
html/HTMLKeygenElement.idl: Removed.
html/HTMLTagNames.in:
html/shadow/ShadowPseudoIds.cpp:

(WebCore::ShadowPseudoIds::webkitKeygenSelect): Deleted.

html/shadow/ShadowPseudoIds.h:
mathml/MathMLPresentationElement.cpp:

(WebCore::MathMLPresentationElement::isPhrasingContent):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setKeygenElementEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::keygenElementEnabled const): Deleted.

Source/WebKit:
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto and Darin Adler.

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRequestVideoFrameCallbackEnabled):
(WKPreferencesGetRequestVideoFrameCallbackEnabled):
(WKPreferencesSetKeygenElementEnabled):
(WKPreferencesGetKeygenElementEnabled):
(WKPreferencesGetXSSAuditorEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:
UIProcess/Automation/atoms/ElementAttribute.js:

(isBooleanAttribute):

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLPrivate.cpp:

Source/WebKitLegacy/mac:
Delete runtime preference for enabling keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

WebView/WebPreferences.mm:

(-[WebPreferences keygenElementEnabled]):
(-[WebPreferences setKeygenElementEnabled:]):

WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:
Delete runtime preference for enabling keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::keygenElementEnabled):
(WebPreferences::setKeygenElementEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

Deleted the relevant keygen tests and rebaselined other tests.

Most of the tests that happens to test keygen elements along side other form control elements
have been updated to expect keygen to behave like HTMLUnknownElement as expected.

accessibility/content-changed-notification-causes-crash.html:
accessibility/contenteditable-table-check-causes-crash.html:
accessibility/duplicate-axrenderobject-crash-expected.txt:
accessibility/duplicate-axrenderobject-crash.html:
fast/block/float/float-not-removed-from-first-letter-expected.txt:
fast/block/float/float-not-removed-from-first-letter.html:
fast/block/float/split-inline-sibling-of-float-crash.html:
fast/css/pseudo-required-optional-unapplied.html:
fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html:
fast/dom/HTMLKeygenElement/keygen-expected.txt: Removed.
fast/dom/HTMLKeygenElement/keygen-keytype-expected.txt: Removed.
fast/dom/HTMLKeygenElement/keygen-keytype.html: Removed.
fast/dom/HTMLKeygenElement/keygen.html: Removed.
fast/dom/adopt-node-crash-2-expected.txt:
fast/dom/adopt-node-crash-2.html:
fast/dom/attribute-set-before-element-in-tree.html:
fast/dom/domstring-attribute-reflection-expected.txt:
fast/dom/domstring-attribute-reflection.html:
fast/dom/set-custom-validity-with-too-few-arguments-expected.txt:
fast/dom/set-custom-validity-with-too-few-arguments.html:
fast/dom/tabindex-defaults-expected.txt:
fast/dom/tabindex-defaults.html:
fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html:
fast/dynamic/insertAdjacentHTML-allowed-parents.html:
fast/flexbox/crash-button-keygen.html:
fast/forms/ValidityState-001-expected.txt:
fast/forms/ValidityState-001.html:
fast/forms/autofocus-keygen-expected.txt: Removed.
fast/forms/autofocus-keygen.html: Removed.
fast/forms/checkValidity-001-expected.txt:
fast/forms/checkValidity-001.html:
fast/forms/fieldset/fieldset-elements-expected.txt:
fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt:
fast/forms/fieldset/fieldset-elements-htmlcollection.html:
fast/forms/fieldset/fieldset-elements.html:
fast/forms/form-associated-element-crash3.html:
fast/forms/form-attribute-expected.txt:
fast/forms/form-attribute.html:
fast/forms/form-collection-elements-expected.txt:
fast/forms/form-collection-elements-order-expected.txt:
fast/forms/form-collection-elements-order.html:
fast/forms/form-collection-elements.html:
fast/forms/form-collection-radio-node-list-expected.txt:
fast/forms/form-collection-radio-node-list.html:
fast/forms/label/labelable-elements-expected.txt:
fast/forms/label/labelable-elements.html:
fast/forms/label/labels-add-htmlFor-label-expected.txt:
fast/forms/label/labels-add-htmlFor-label.html:
fast/forms/label/labels-add-parent-label-expected.txt:
fast/forms/label/labels-add-parent-label.html:
fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
fast/forms/label/labels-change-htmlFor-attribute.html:
fast/forms/label/labels-multiple-sibling-labels-expected.txt:
fast/forms/label/labels-multiple-sibling-labels.html:
fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
fast/forms/label/labels-parent-and-sibling-labels.html:
fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
fast/forms/label/labels-remove-htmlFor-attribute.html:
fast/forms/label/labels-remove-htmlFor-label-expected.txt:
fast/forms/label/labels-remove-htmlFor-label.html:
fast/forms/label/labels-remove-parent-label-expected.txt:
fast/forms/label/labels-remove-parent-label.html:
fast/forms/large-parts.html:
fast/forms/resources/common.js:

(createFormControlDataSet): Removed keygen form the list of form control elements.

fast/forms/scrollheight-with-mutation-crash.html:
fast/forms/setCustomValidity-arguments-expected.txt:
fast/forms/setCustomValidity-arguments.html:
fast/forms/setCustomValidity-existence-expected.txt:
fast/forms/setCustomValidity-existence.html:
fast/forms/setCustomValidity-null-parameter-expected.txt:
fast/forms/setCustomValidity-null-parameter.html:
fast/forms/state-restore-skip-stateless.html:
fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html:
fast/forms/validationMessage-expected.txt:
fast/forms/validationMessage.html:
fast/forms/willvalidate-expected.txt:
fast/forms/willvalidate.html:
fast/html/clone-keygen-expected.txt: Removed.
fast/html/clone-keygen.html: Removed.
fast/html/keygen.html: Removed.
fast/html/marquee-reparent-check.html:
fast/invalid/residual-style-expected.html:
fast/invalid/residual-style.html:
fast/multicol/span/positioned-child-not-removed-crash-expected.txt:
fast/multicol/span/positioned-child-not-removed-crash.html:
fast/ruby/float-object-doesnt-crash.html:
fast/shadow-dom/keygen-shadow-manipulation-expected.txt:
fast/shadow-dom/keygen-shadow-manipulation.html:
fast/table/crash-splitColumn-2.html:
fast/table/multiple-captions-crash3-expected.html:
fast/table/multiple-captions-crash3.html:
http/tests/misc/resources/check-keygen-post.py: Removed.
http/tests/misc/submit-post-keygen-expected.txt: Removed.
http/tests/misc/submit-post-keygen.html: Removed.
imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html: Removed.
imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html: Removed.
imported/blink/fast/text/international-iteration-simple-text.html:
platform/glib/fast/html/keygen-expected.txt: Removed.
platform/gtk/fast/forms/label/labelable-elements-expected.txt:
platform/gtk/fast/html/keygen-expected.png: Removed.
platform/ios-wk2/TestExpectations:
platform/ios-wk2/fast/forms/label/labelable-elements-expected.txt:
platform/ios/fast/html/keygen-expected.txt: Removed.
platform/mac-wk2/fast/forms/label/labelable-elements-expected.txt:
platform/mac/fast/html/keygen-expected.png: Removed.
platform/mac/fast/html/keygen-expected.txt: Removed.
platform/win/TestExpectations:
platform/wincairo/fast/html/keygen-expected.txt: Removed.
svg/dom/css-animate-input-foucs-crash-expected.txt:
svg/dom/css-animate-input-foucs-crash.html:

3:24 PM Changeset in webkit [288803] by rniwa@webkit.org

34 edits in trunk

Delete runtime preference for enabling input events
https://bugs.webkit.org/show_bug.cgi?id=235864

Reviewed by Wenson Hsieh.

Source/WebCore:

dom/InputEvent.idl:
editing/Editor.cpp:

Source/WTF:

Scripts/Preferences/WebPreferences.yaml:

LayoutTests:

Updated the tests.

fast/events/before-input-delete-empty-list-target-ranges.html:
fast/events/before-input-delete-text-target-ranges.html:
fast/events/before-input-events-different-start-end-elements.html:
fast/events/before-input-events-prevent-block-text-direction.html:
fast/events/before-input-events-prevent-default-in-textfield.html:
fast/events/before-input-events-prevent-default.html:
fast/events/before-input-events-prevent-drag-and-drop.html:
fast/events/before-input-events-prevent-insert-composition.html:
fast/events/before-input-events-prevent-recomposition.html:
fast/events/before-input-prevent-biu.html:
fast/events/before-input-prevent-cut.html:
fast/events/before-input-prevent-paste.html:
fast/events/before-input-prevent-typing.html:
fast/events/before-input-prevent-undo.html:
fast/events/before-input-replace-text-target-ranges.html:
fast/events/input-event-insert-link.html:
fast/events/input-events-drag-and-drop.html:
fast/events/input-events-fired-when-typing.html:
fast/events/input-events-forecolor-data.html:
fast/events/input-events-ime-composition.html:
fast/events/input-events-ime-recomposition.html:
fast/events/input-events-insert-by-drop.html:
fast/events/input-events-paste-data.html:
fast/events/input-events-paste-rich-datatransfer.html:
fast/events/input-events-selection-forecolor-data.html:
fast/events/input-events-spell-checking-datatransfer.html:
fast/events/input-events-typing-data.html:
fast/events/ios/input-events-fired-when-typing-in-contenteditable.html:

8:57 AM Changeset in webkit [288802] by commit-queue@webkit.org

4 edits
1 move
1 add in trunk/LayoutTests

[GLIB] Update Test expectations and baselines. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=235826

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-01-30

platform/glib/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Renamed from LayoutTests/platform/wpe/tables/mozilla/bugs/adforce_imgis_com-expected.txt.
platform/gtk/accessibility/math-multiscript-attributes-expected.txt:
platform/gtk/css2.1/t1508-c527-font-08-b-expected.txt: Added.
platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt:
platform/wpe/accessibility/math-multiscript-attributes-expected.txt:

8:11 AM Changeset in webkit [288801] by Alan Bujtas

8 edits
2 adds in trunk

(REGRESSION)[IFC][RTL] wpt/css/css-text/white-space/trailing-space-and-text-alignment-rtl-003.html
https://bugs.webkit.org/show_bug.cgi?id=235823
<rdar://problem/88186663>

Reviewed by Antti Koivisto.

Source/WebCore:

Reset the trailing whitespace bidi level before handing them over to visual reordering.
see https://unicode.org/reports/tr9/#L1
"L1. On each line, reset the embedding level of the following characters to the paragraph embedding level:

...
Any sequence of whitespace characters ... at the end of the line."

It ensures that

<div style="width: 2ch; direction: rtl">AB C</div>

and

<div style="direction: rtl">AB </div>

both have the trailing whitespace positioned _visually_ as trailing (and not leading) content.

After the bidi paragraph processing "AB C" gets a uniform bidi level of 2, while "AB " is split into "AB" and " "
with bidi levels of 2 and 1 respectively.
In the latter case, the difference in bidi levels makes the runs flip visually at reordering.
It makes the trailing whitespace "pushed" to the left side of the "AB" making it _visually_ trailing (the content renders as " AB").
However in case of "AB C" with the line breaking position after " ", we would end up with a single run of "AB " with the bidi level of 2.
This run would render as "AB " turning the trailing whitespace into a _visually_ leading whitespace.

In this patch we ensure that the trailing (non-collapsible) whitespace runs

are detached from their adjoining non-whitespace text runs and
they get their bidi levels reset

Test: fast/text/rtl-pre-wrap-hanging-offset.html

layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:

(WebCore::Layout::InlineDisplayLineBuilder::build const):

LayoutTests:

fast/text/rtl-pre-wrap-hanging-offset-expected.html: Added.
fast/text/rtl-pre-wrap-hanging-offset.html: Added.

7:58 AM Changeset in webkit [288800] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][IFC] Do not break content at an inline box boundary
https://bugs.webkit.org/show_bug.cgi?id=235868

Reviewed by Antti Koivisto.

Source/WebCore:

Handle nested inline boxes, when the breaking position is between at an inline box boundary.
e.g.

<div style="width: 1px"><span><span><span>this_content_overflow</span></span></span></div>

while the breaking position is between the 3rd <span> and the letter 't', we should not let the first
line have all the <span><span><span> content only, but instead find a more reasonable breaking position by
looking at the previous runs.
This patch expands "findTrailingRunIndex" to find multiple, subsequent (nested) inline boxes.

Test: fast/inline/nested-inline-box-with-word-break.html

layout/formattingContexts/inline/InlineContentBreaker.cpp:

(WebCore::Layout::findTrailingRunIndex):

LayoutTests:

fast/inline/nested-inline-box-with-word-break-expected.html: Added.
fast/inline/nested-inline-box-with-word-break.html: Added.

5:19 AM Changeset in webkit [288799] by commit-queue@webkit.org

5 edits in trunk

[GStreamer] GstStructure to JSON serialization
https://bugs.webkit.org/show_bug.cgi?id=235760

Patch by Philippe Normand <pnormand@igalia.com> on 2022-01-30
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

For GstWebRTC stats logging purposes JSON is a good payload format. As the stats are
initially notified via GstStructures we need a way to export those to JSON, using a new API
in GStreamerCommon.

Covered by API tests.

platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::structureValueToJSON):
(WebCore::parseStructureValue):
(WebCore::structureToJSON):
(WebCore::structureToJSONString):

platform/graphics/gstreamer/GStreamerCommon.h:

Tools:

TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:

(TestWebKitAPI::TEST_F):

Jan 29, 2022:

10:47 PM Changeset in webkit [288798] by Kocsen Chung

9 edits in branches/safari-613-branch/Source

Versioning.

WebKit-7613.1.17

9:58 PM Changeset in webkit [288797] by rniwa@webkit.org

18 edits in trunk/Source

Delete runtime preference for enabling request animation frame
https://bugs.webkit.org/show_bug.cgi?id=235866

Reviewed by Darin Adler.

Source/WebCore:

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceRequestAnimationFrameCallbacks):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::requestAnimationFrameEnabled const): Deleted.

dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::clearDocumentPointer):

workers/WorkerAnimationController.cpp:

(WebCore::WorkerAnimationController::scheduleAnimation):
(WebCore::WorkerAnimationController::serviceRequestAnimationFrameCallbacks):

Source/WebKit:

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRequestAnimationFrameEnabled):
(WKPreferencesGetRequestAnimationFrameEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:
UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setRequestAnimationFrameEnabled:]):
(-[WKPreferences _requestAnimationFrameEnabled]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WebKitLegacy/mac:

WebView/WebPreferences.mm:

(-[WebPreferences requestAnimationFrameEnabled]):
(-[WebPreferences setRequestAnimationFrameEnabled:]):

WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setRequestAnimationFrameEnabled):
(WebPreferences::requestAnimationFrameEnabled):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:

Scripts/Preferences/WebPreferences.yaml:

9:21 PM Changeset in webkit [288796] by Ben Nham

2 edits
1 add in trunk/Tools

Add web push message decryption routines
https://bugs.webkit.org/show_bug.cgi?id=233903

Reviewed by Brady Eidson.

Somehow the unit tests were left out of the original patch that was landed. Adding them back
in this patch.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebCore/PushMessageCrypto.cpp: Added.

(TestWebKitAPI::mustBase64URLDecode):
(TestWebKitAPI::makeAES128GCMClientKeys):
(TestWebKitAPI::TEST):
(TestWebKitAPI::makeAESGCMClientKeys):

7:26 PM Changeset in webkit [288795] by commit-queue@webkit.org

8 edits
2 adds in trunk

[WebIDL] Add a sensible error message for a primitive non-null EventListener
https://bugs.webkit.org/show_bug.cgi?id=235863

Patch by Alexey Shvayka <ashvayka@apple.com> on 2022-01-29
Reviewed by Darin Adler.

Source/WebCore:

This patch moves isObject() check to JSEventListener converter, aligning it with
callback interface converter and removing now unused create() overload, and makes
code generator pass an exception thrower with a user-friendly TypeError message.

Since JSEventListener is quite different from other callback interfaces, we can't
make IsCallbackInterface() recognize it just yet, thus the type name has to be
hard-coded if we want the error message to be consistent with other generated ones.

Test: fast/events/event-listener-not-an-object.html

bindings/js/JSDOMConvertEventListener.h:

(WebCore::Converter<IDLEventListener<T>>::convert):

bindings/js/JSEventListener.cpp:
bindings/js/JSEventListener.h:
bindings/scripts/CodeGeneratorJS.pm:

(GetArgumentExceptionFunction):

bindings/scripts/test/JS/*: Updated.
dom/EventTarget.idl:

Rename EventListener parameter to "listener" to match MDN / Chrome DevTools / matchMedia().

LayoutTests:

fast/events/event-listener-not-an-object-expected.txt: Added.
fast/events/event-listener-not-an-object.html: Added.

3:15 PM Changeset in webkit [288794] by rniwa@webkit.org

6 edits
1 delete in trunk/Source/WebCore

Delete EventQueue.h
https://bugs.webkit.org/show_bug.cgi?id=235862

Reviewed by Wenson Hsieh.

Deleted the useless header file.

Headers.cmake:
Modules/indexeddb/IDBDatabase.cpp:
Modules/indexeddb/IDBRequest.cpp:
Modules/indexeddb/IDBTransaction.cpp:
WebCore.xcodeproj/project.pbxproj:
dom/EventQueue.h: Removed.

1:00 PM Changeset in webkit [288793] by rniwa@webkit.org

27 edits
3 deletes in trunk/Source/WebCore

Delete most code for beforeload event
https://bugs.webkit.org/show_bug.cgi?id=234804

Reviewed by Antti Koivisto.

Delete code for beforeload event as the event has been disabled successfully in r261946.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/BeforeLoadEvent.cpp: Removed.
dom/BeforeLoadEvent.h: Removed.
dom/BeforeLoadEvent.idl: Removed.
dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded):

dom/Document.h:
dom/EventNames.in:
dom/Node.cpp:

(WebCore::Node::dispatchBeforeLoadEvent): Deleted.

dom/Node.h:
dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet): m_isHandlingBeforeLoad is never true.

dom/ProcessingInstruction.h:
dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestClassicScript): dispatchBeforeLoadEvent always returned true
when beforeload event is disabled, and the element is always connected here.
(WebCore::ScriptElement::requestModuleScript): Ditto.

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Deleted the no-op code.

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::shouldLoadLink):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::selectNextSourceChild):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent): Deleted.
(WebCore::HTMLPlugInElement::pluginWidget const): m_inBeforeLoadEventHandler is never true.

html/HTMLPlugInElement.h:
html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::canLoadURL):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadWithDocumentLoader): Deleted the no-op code.

loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Document will never have beforeload event listener
but keep the call to dispatchPendingBeforeLoadEvent since we depend on it updating renderer.
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): Keep the only side effect left which is
to update the renderer.

loader/ImageLoader.h:
page/Settings.yaml: Deleted the option to enable beforeload event.

11:27 AM Changeset in webkit [288792] by Patrick Griffis

14 edits in trunk

CSP: Properly block image content in object elements
https://bugs.webkit.org/show_bug.cgi?id=235837

Reviewed by Kate Cheney.

LayoutTests/imported/w3c:

Update expectations with more passes.

web-platform-tests/content-security-policy/object-src/object-src-url-blocked-expected.txt:
web-platform-tests/content-security-policy/object-src/object-src-url-embed-blocked-expected.txt:
web-platform-tests/content-security-policy/object-src/object-src-url-redirect-blocked.sub-expected.txt:

Source/WebCore:

When an image is loaded through an object element it now passes through
the object-src directive check as the spec documents:
https://www.w3.org/TR/CSP3/#directive-object-src

loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

loader/ResourceLoaderOptions.h:

(WebCore::ResourceLoaderOptions::loadedFromPluginElement):
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
(WebCore::ResourceLoaderOptions::loadedFromOpaqueSource): Deleted.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allowObjectFromSource const):

page/csp/ContentSecurityPolicy.h:

LayoutTests:

http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2-expected.txt:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked3-expected.txt:

8:43 AM Changeset in webkit [288791] by Tyler Wilcock

5 edits
2 adds in trunk

AX: Isolated tree objects don't update their AXPropertyName::ElementRect or AXPropertyName::BoundingBoxRect in response to dynamic page changes
https://bugs.webkit.org/show_bug.cgi?id=235833

Reviewed by Chris Fleizach.

Source/WebCore:

Because isolated tree objects don't update their
AXPropertyName::ElementRect or AXPropertyName::BoundingBoxRect
anytime after AXIsolatedObject::initializeAttributeData,
any dynamic page change that causes the element to move or change
size will result in the isolated AX object holding out-of-date values
for these properties.

This patch remedies this deferring to the live, main-thread AX object
when serving elementRect and boundingBoxRect.

Test: accessibility/dynamic-changes-update-position.html

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
Stop caching the now removed properties AXPropertyName::ElementRect and AXPropertyName::BoundingBoxRect.
(WebCore::AXIsolatedObject::boundingBoxRect const):
(WebCore::AXIsolatedObject::elementRect const):
Retrieve these values from the main-thread instead of the now removed
AXPropertyName::ElementRect and AXPropertyName::BoundingBoxRect.

accessibility/isolatedtree/AXIsolatedObject.h:
accessibility/isolatedtree/AXIsolatedTree.h:

Remove AXPropertyName::ElementRect and AXPropertyName::BoundingBoxRect.

LayoutTests:

Add test reproducing this issue.

accessibility/dynamic-changes-update-position-expected.txt: Added.
accessibility/dynamic-changes-update-position.html: Added.

6:43 AM Changeset in webkit [288790] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[LibWebRTC] ifdef cleanups
https://bugs.webkit.org/show_bug.cgi?id=235858

Patch by Philippe Normand <pnormand@igalia.com> on 2022-01-29
Reviewed by Youenn Fablet.

ENABLE(WEB_RTC) does not necessarily imply USE(LIBWEBRTC), so guard libwebrtc-specific files
with explicit USE(LIBWEBRTC) ifdefs.

Modules/mediastream/STUNMessageParsing.cpp:
Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.h:
Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.h:
Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.h:
platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.cpp:
platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.h:

3:49 AM Changeset in webkit [288789] by commit-queue@webkit.org

12 edits
2 adds in trunk

Capturing WebGL canvas through peer connection shows the image flipped
https://bugs.webkit.org/show_bug.cgi?id=235600
<rdar://problem/88043325>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-01-29
Reviewed by Dean Jackson.

Source/WebCore:

Mirror and rotate the WebGL image at the source since WebRTC
does not support mirroring.

Test: webrtc/canvas-to-peer-connection.html

platform/graphics/cocoa/GraphicsContextGLCocoa.h:
platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLCocoa::paintCompositedResultsToMediaSample):

platform/graphics/cocoa/IOSurface.h:
platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::setOwnershipIdentity):

platform/graphics/cv/CVUtilities.h:
platform/graphics/cv/CVUtilities.mm:

(WebCore::setOwnershipIdentityForCVPixelBuffer):

LayoutTests:

Test sending WebGL image through a peer connection to a local video
and assert that the image is as drawn.

platform/glib/TestExpectations:
webrtc/canvas-to-peer-connection-expected.txt: Added.
webrtc/canvas-to-peer-connection.html: Added.
webrtc/routines.js:
webrtc/video-replace-track.html:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed