Timeline

Feb 14, 2022:

11:34 PM Changeset in webkit [289790] by commit-queue@webkit.org

• 87 edits
  3 deletes in trunk

ExtensionsGL is not useful class, it should be removed
​https://bugs.webkit.org/show_bug.cgi?id=236490

Source/WebCore:

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-02-14
Reviewed by Dean Jackson.

Remove ExtensionsGL. It is not a useful class, it does not abstract anything.
It has similar functions to GraphicsContextGL subclass, and needs and uses GraphicsContextGL subclass
underneath.
It is a problematic class as it is obtained through a virtual function, but that
virtual function override is being called during construction of the GraphicsContextGL subclass
instance.
Also the ExtensionsGL will neccessarily call back to GraphicsContextGL subclass instance being
constructed.
Current getExtensions() virtual function override calls are expected to go
where the C++ defines them going during construction.
Current calls back to the GraphicsContextGL subclass instance during construction *should*
access state that is already initialized, but it is quite error-prone and hard to
analyze.

Move ExtensionsGL functions to GraphicsContextGL. Make call-sites call the context instead of the
extension helper. Rename the functions with pattern "isSupported" -> "isExtensionSupported".
Remove GraphicsContextGL::getExtensions() virtual function call.

For legacy contexts GraphicsContextGLOpenGL, GraphicsContextGLOpenGLES preserve their
ExtensionGLCommon subclasses. Accessing it happens from a normal function from legacy call sites
that know that they're calling GraphicsContextGLOpenGL.

For GraphicsContextGLANGLE, move context initialization code to GraphicsContextGLANGLE::initialize()
instead of the constructor. This way the initialization code can call virtual functions and the calls
are delivered normally to the last overrider.

RemoteGraphicsContextGLProxyBase can now be removed, as it is unneeded anyway and its added virtual
functions would cause inconvenient naming duplication.

No new tests, a refactor.

• CMakeLists.txt:
• Headers.cmake:
• Modules/webxr/WebXROpaqueFramebuffer.cpp:

(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):

• Sources.txt:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):
(WebCore::ANGLEInstancedArrays::supported):

• html/canvas/ANGLEInstancedArrays.h:
• html/canvas/EXTColorBufferFloat.cpp:

(WebCore::EXTColorBufferFloat::EXTColorBufferFloat):
(WebCore::EXTColorBufferFloat::supported):

• html/canvas/EXTColorBufferFloat.h:
• html/canvas/EXTColorBufferHalfFloat.cpp:

(WebCore::EXTColorBufferHalfFloat::EXTColorBufferHalfFloat):
(WebCore::EXTColorBufferHalfFloat::supported):

• html/canvas/EXTColorBufferHalfFloat.h:
• html/canvas/EXTFloatBlend.cpp:

(WebCore::EXTFloatBlend::EXTFloatBlend):
(WebCore::EXTFloatBlend::supported):

• html/canvas/EXTFloatBlend.h:
• html/canvas/EXTTextureCompressionRGTC.cpp:

(WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):

• html/canvas/KHRParallelShaderCompile.cpp:

(WebCore::KHRParallelShaderCompile::KHRParallelShaderCompile):
(WebCore::KHRParallelShaderCompile::supported):

• html/canvas/KHRParallelShaderCompile.h:
• html/canvas/OESFBORenderMipmap.cpp:

(WebCore::OESFBORenderMipmap::OESFBORenderMipmap):
(WebCore::OESFBORenderMipmap::supported):

• html/canvas/OESFBORenderMipmap.h:
• html/canvas/OESTextureFloat.cpp:

(WebCore::OESTextureFloat::OESTextureFloat):
(WebCore::OESTextureFloat::supported):

• html/canvas/OESTextureFloat.h:
• html/canvas/OESTextureHalfFloat.cpp:

(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::supported):

• html/canvas/OESTextureHalfFloat.h:
• html/canvas/OESVertexArrayObject.cpp:
• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::initializeShaderExtensions):
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

• html/canvas/WebGLColorBufferFloat.cpp:

(WebCore::WebGLColorBufferFloat::WebGLColorBufferFloat):
(WebCore::WebGLColorBufferFloat::supported):

• html/canvas/WebGLColorBufferFloat.h:
• html/canvas/WebGLCompressedTextureASTC.cpp:

(WebCore::WebGLCompressedTextureASTC::WebGLCompressedTextureASTC):
(WebCore::WebGLCompressedTextureASTC::supported):

• html/canvas/WebGLCompressedTextureASTC.h:
• html/canvas/WebGLCompressedTextureATC.cpp:

(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::supported):

• html/canvas/WebGLCompressedTextureATC.h:
• html/canvas/WebGLCompressedTextureETC.cpp:

(WebCore::WebGLCompressedTextureETC::WebGLCompressedTextureETC):
(WebCore::WebGLCompressedTextureETC::supported):

• html/canvas/WebGLCompressedTextureETC.h:
• html/canvas/WebGLCompressedTextureETC1.cpp:

(WebCore::WebGLCompressedTextureETC1::WebGLCompressedTextureETC1):
(WebCore::WebGLCompressedTextureETC1::supported):

• html/canvas/WebGLCompressedTextureETC1.h:
• html/canvas/WebGLCompressedTexturePVRTC.cpp:

(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::supported):

• html/canvas/WebGLCompressedTexturePVRTC.h:
• html/canvas/WebGLCompressedTextureS3TC.cpp:

(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::supported):

• html/canvas/WebGLCompressedTextureS3TC.h:
• html/canvas/WebGLCompressedTextureS3TCsRGB.cpp:

(WebCore::WebGLCompressedTextureS3TCsRGB::WebGLCompressedTextureS3TCsRGB):
(WebCore::WebGLCompressedTextureS3TCsRGB::supported):

• html/canvas/WebGLCompressedTextureS3TCsRGB.h:
• html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::WebGLDebugShaders):
(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

• html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::WebGLDepthTexture):
(WebCore::WebGLDepthTexture::supported):

• html/canvas/WebGLDrawBuffers.cpp:

(WebCore::WebGLDrawBuffers::WebGLDrawBuffers):
(WebCore::WebGLDrawBuffers::supported):
(WebCore::WebGLDrawBuffers::drawBuffersWEBGL):
(WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):

• html/canvas/WebGLFramebuffer.cpp:

(WebCore::getClearBitsByAttachmentType):
(WebCore::getClearBitsByFormat):
(WebCore::WebGLFramebuffer::checkStatus const):
(WebCore::WebGLFramebuffer::drawBuffersIfNecessary):
(WebCore::WebGLFramebuffer::getDrawBuffer):

• html/canvas/WebGLMultiDraw.cpp:

(WebCore::WebGLMultiDraw::WebGLMultiDraw):
(WebCore::WebGLMultiDraw::supported):

• html/canvas/WebGLMultiDraw.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getMaxDrawBuffers):
(WebCore::WebGLRenderingContext::getMaxColorAttachments):
(WebCore::WebGLRenderingContext::validateBlendEquation):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::getChannelBitsByFormat):
(WebCore::possibleFormatAndTypeForInternalFormat):
(WebCore::WebGLRenderingContextBase::setupFlags):
(WebCore::WebGLRenderingContextBase::getParameter):
(WebCore::WebGLRenderingContextBase::getProgramParameter):
(WebCore::WebGLRenderingContextBase::getShaderParameter):
(WebCore::WebGLRenderingContextBase::getTexParameter):
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::hint):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::renderbufferStorageImpl):
(WebCore::WebGLRenderingContextBase::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContextBase::texParameter):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::getMaxDrawBuffers):
(WebCore::WebGLRenderingContextBase::getMaxColorAttachments):
(WebCore::WebGLRenderingContextBase::enableSupportedExtension):

• html/canvas/WebGLVertexArrayObjectOES.cpp:
• loader/FrameLoaderClient.h:
• platform/graphics/ExtensionsGL.h: Removed.
• platform/graphics/GraphicsContextGL.cpp:

(WebCore::GraphicsContextGL::computeFormatAndTypeParameters):

• platform/graphics/GraphicsContextGL.h:
• platform/graphics/RemoteGraphicsContextGLProxyBase.cpp:
• platform/graphics/RemoteGraphicsContextGLProxyBase.h:
• platform/graphics/angle/ExtensionsGLANGLE.cpp: Removed.
• platform/graphics/angle/ExtensionsGLANGLE.h: Removed.
• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::initialize):
(WebCore::GraphicsContextGLANGLE::platformInitializeContext):
(WebCore::GraphicsContextGLANGLE::platformInitialize):
(WebCore::GraphicsContextGLANGLE::texImage2D):
(WebCore::GraphicsContextGLANGLE::validateDepthStencil):
(WebCore::GraphicsContextGLANGLE::supportsExtension):
(WebCore::GraphicsContextGLANGLE::ensureExtensionEnabled):
(WebCore::GraphicsContextGLANGLE::isExtensionEnabled):
(WebCore::GraphicsContextGLANGLE::getGraphicsResetStatusARB):
(WebCore::GraphicsContextGLANGLE::getTranslatedShaderSourceANGLE):
(WebCore::GraphicsContextGLANGLE::drawBuffersEXT):
(WebCore::GraphicsContextGLANGLE::adjustWebGL1TextureInternalFormat):

• platform/graphics/angle/GraphicsContextGLANGLE.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/cocoa/GraphicsContextGLCocoa.h:
• platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLCocoa::create):
(WebCore::GraphicsContextGLCocoa::GraphicsContextGLCocoa):
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLCocoa::platformInitializeContext):
(WebCore::GraphicsContextGLCocoa::platformInitialize):
(WebCore::GraphicsContextGLCocoa::reshapeDisplayBufferBacking):
(WebCore::GraphicsContextGLCocoa::allocateAndBindDisplayBufferBacking):
(WebCore::GraphicsContextGLCocoa::bindDisplayBufferBacking):
(WebCore::GraphicsContextGLCocoa::prepareForDisplay):

• platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm:

(WebCore::createWebProcessGraphicsContextGL):

• platform/graphics/opengl/ExtensionsGLOpenGL.cpp:

(WebCore::ExtensionsGLOpenGL::platformSupportsExtension):

• platform/graphics/opengl/ExtensionsGLOpenGL.h:
• platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:

(WebCore::ExtensionsGLOpenGLCommon::supports):
(WebCore::ExtensionsGLOpenGLCommon::ensureEnabled):

• platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:
• platform/graphics/opengl/ExtensionsGLOpenGLES.cpp:

(WebCore::ExtensionsGLOpenGLES::isEnabled):
(WebCore::ExtensionsGLOpenGLES::getGraphicsResetStatusARB):
(WebCore::ExtensionsGLOpenGLES::platformSupportsExtension):

• platform/graphics/opengl/ExtensionsGLOpenGLES.h:
• platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::getExtensions):
(WebCore::GraphicsContextGLOpenGL::validateDepthStencil):
(WebCore::GraphicsContextGLOpenGL::supportsExtension):
(WebCore::GraphicsContextGLOpenGL::ensureExtensionEnabled):
(WebCore::GraphicsContextGLOpenGL::isExtensionEnabled):
(WebCore::GraphicsContextGLOpenGL::getGraphicsResetStatusARB):
(WebCore::GraphicsContextGLOpenGL::drawBuffersEXT):
(WebCore::GraphicsContextGLOpenGL::getTranslatedShaderSourceANGLE):

• platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

(WebCore::GraphicsContextGLOpenGL::texImage2D):
(WebCore::GraphicsContextGLOpenGL::getExtensions):

• platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
(WebCore::GraphicsContextGLOpenGL::validateAttributes):
(WebCore::GraphicsContextGLOpenGL::getExtensions):

• platform/graphics/texmap/BitmapTextureGL.cpp:
• platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLTextureMapper::create):
(WebCore::createWebProcessGraphicsContextGL):

• platform/graphics/texmap/GraphicsContextGLTextureMapper.h:
• platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLTextureMapper::prepareForDisplay):
(WebCore::GraphicsContextGLTextureMapper::reshapeDisplayBufferBacking):

• platform/graphics/texmap/TextureMapperGL.cpp:

Source/WebKit:

Move the RemoteGraphicsContextGLProxyBase functions to
RemoteGraphicsContextGL. The ..Base can now be removed
as ExtensionGL is removed.

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-02-14
Reviewed by Dean Jackson.

• GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::workQueueInitialize):
(WebKit::RemoteGraphicsContextGL::ensureExtensionEnabled):
(WebKit::RemoteGraphicsContextGL::markContextChanged):

• GPUProcess/graphics/RemoteGraphicsContextGL.h:
• GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
• GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:

(getGraphicsResetStatusARB):
(getTranslatedShaderSourceANGLE):
(drawBuffersEXT):

• WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:

(WebKit::RemoteGraphicsContextGLProxy::RemoteGraphicsContextGLProxy):
(WebKit::RemoteGraphicsContextGLProxy::setContextVisibility):
(WebKit::RemoteGraphicsContextGLProxy::isGLES2Compliant const):
(WebKit::RemoteGraphicsContextGLProxy::markContextChanged):
(WebKit::RemoteGraphicsContextGLProxy::supportsExtension):
(WebKit::RemoteGraphicsContextGLProxy::ensureExtensionEnabled):
(WebKit::RemoteGraphicsContextGLProxy::isExtensionEnabled):
(WebKit::RemoteGraphicsContextGLProxy::initialize):
(WebKit::RemoteGraphicsContextGLProxy::reshape):

• WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:

Tools:

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-02-14
Reviewed by Dean Jackson.

Update manually implemented functions.

• Scripts/generate-gpup-webgl:
• TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:

10:29 PM Changeset in webkit [289789] by Antti Koivisto

• 8 edits in trunk

[CSS Container Queries] Support range operators in size queries
​https://bugs.webkit.org/show_bug.cgi?id=236600

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-contain/container-queries/size-feature-evaluation-expected.txt:
• web-platform-tests/css/css-contain/container-queries/unsupported-axis-expected.txt:

Source/WebCore:

Support (width > 100px) and similar.

• css/ContainerQueryParser.cpp:

(WebCore::ContainerQueryParser::consumeSizeQuery):
(WebCore::ContainerQueryParser::consumeSizeFeature):

Factor into a function.
Add operator support. No reverse (100px < width) or full range (10px < width < 100px) yet.
The evaluator supports these already.

• css/ContainerQueryParser.h:

LayoutTests:

• TestExpectations:

7:55 PM Changeset in webkit [289788] by ysuzuki@apple.com

• 3 edits in trunk/Source/bmalloc

[libpas] compact pointers should load payload via memcpy
​https://bugs.webkit.org/show_bug.cgi?id=236621

Reviewed by Mark Lam.

ASan found that we are loading 8 bytes which can potentially be overflowed.
For example, we load this from a pointer to stack variable, which means that
we could cause stack overflow. Instead we should use memcpy.
Currently, we only support little endian code, but it is OK since libpas is not
enabled in non little endian architectures.

• libpas/src/libpas/pas_compact_ptr.h:
• libpas/src/libpas/pas_compact_tagged_ptr.h:

6:16 PM Changeset in webkit [289787] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION (r288804): fast/forms/visual-hebrew-text-field.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=236325

Reviewed by Dean Jackson.

The test failure is caused by pre-existing inter-test dependencies.
Workaround whatever the underlying cause for the test failure by forcing
the use of ephemeral session for now.

• fast/forms/visual-hebrew-text-field.html:

5:47 PM Changeset in webkit [289786] by jonlee@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed gardening.

Expand pixel range.

• css3/color-filters/color-filter-color-text-decorations.html:

5:34 PM Changeset in webkit [289785] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Direct touches don't trigger other gesture recognizers if WKMouseGestureRecognizer sees them first
​https://bugs.webkit.org/show_bug.cgi?id=236617

Reviewed by Wenson Hsieh.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
WKMouseGestureRecognizer should only completely steal touches of type
UITouchTypeIndirectPointer. Other touch types (e.g. synthetic direct touches)
still need to trigger other WKContentViewInteraction gesture recognizers
(like long-press and double-tap) despite WKMouseGestureRecognizer
seeing their touches. So, check the touch type before early-returning.

5:05 PM Changeset in webkit [289784] by Jonathan Bedard

• 2 edits in trunk/Tools

[EWS] Support PRs when sending build failure emails
​https://bugs.webkit.org/show_bug.cgi?id=235926
<rdar://problem/88302122>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(GitHub.email_for_owners): Convert list of owners to an email address.
(GitHubMixin.should_send_email_for_pr): Check if the tested sha is outdated.
(BugzillaMixin.should_send_email_for_patch): Renamed from should_send_email.
(BugzillaMixin.should_send_email): Renamed to should_send_email_for_patch.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Draft different
email for failed patch than failed pull request build.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):

Canonical link: ​https://commits.webkit.org/247249@main

5:00 PM Changeset in webkit [289783] by Kocsen Chung

• 1 copy in tags/Safari-613.1.17.0.2

Tag Safari-613.1.17.0.2.

4:59 PM Changeset in webkit [289782] by Kocsen Chung

• 1 copy in tags/Safari-613.1.17.1.2

Tag Safari-613.1.17.1.2.

4:14 PM Changeset in webkit [289781] by Russell Epstein

• 6 edits in branches/safari-614.1.3-branch/Source

Cherry-pick r289592. rdar://problem/88323950

tryReserveUncommittedAligned should explicitly take the alignment requested
​https://bugs.webkit.org/show_bug.cgi?id=236460

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

When reducing the size of VA space reserved for Structures, we
didn't take care to ensure the alignment matched the required
alignment for our bit mask. To fix this we need to pass the
original alignment to the allocator as a new parameter.

• heap/StructureAlignedMemoryAllocator.cpp: (JSC::StructureMemoryManager::StructureMemoryManager):

Source/WTF:

This patch adds a new ifdef for Unix flavors that support the
MAP_ALIGNED macro/parameter to mmap.

Also, fix a bug where on windows we wouldn't request enough
space to guarantee that allocation is aligned.

• wtf/OSAllocator.h:
• wtf/posix/OSAllocatorPOSIX.cpp: (WTF::OSAllocator::tryReserveUncommittedAligned):
• wtf/win/OSAllocatorWin.cpp: (WTF::OSAllocator::tryReserveUncommittedAligned):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:14 PM Changeset in webkit [289780] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

Array#{ groupBy, groupByToMap } should throw a TypeError when this is null or undefined
​https://bugs.webkit.org/show_bug.cgi?id=236541

Reviewed by Alexey Shvayka.

JSTests:

• stress/array-group-by-null-or-undefined.js: Added.

(shouldThrow):

Source/JavaScriptCore:

While we are correctly using @toObject, these functions missed "use strict", which enforces a function
to change a non object |this| to an object (in this case, global object). This patch adds "use strict",
to make these function strict code.

• builtins/ArrayPrototype.js:

(groupBy):
(groupByToMap):

4:09 PM Changeset in webkit [289779] by don.olmstead@sony.com

• 4 edits in trunk/Source/JavaScriptCore

[CMake] Remove uses of add_definitions in JavaScriptCore build
​https://bugs.webkit.org/show_bug.cgi?id=236605

Reviewed by Michael Catanzaro.

Use target specific definitions when building JavaScriptCore. In the current cases the
definitions don't need to propagate to targets using JavaScriptCore so
JavaScriptCore_PRIVATE_DEFINITIONS is used.

• PlatformGTK.cmake:
• PlatformPlayStation.cmake:
• PlatformWPE.cmake:

4:05 PM Changeset in webkit [289778] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Move PDFDocument.cpp/h in correct position in WebCore.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=236529

Patch by Dan Glastonbury <​djg@apple.com> on 2022-02-14
Reviewed by Tim Nguyen.

• WebCore.xcodeproj/project.pbxproj:

3:59 PM Changeset in webkit [289777] by Cameron McCormack

• 2 edits in trunk/Source/WebCore

Consistenly use hasTagName instead of is<> in HTMLStackItem testing functions
​https://bugs.webkit.org/show_bug.cgi?id=236571

Reviewed by Sam Weinig.

No reason to use is<> for a couple of element names but hasTagName for
all others.

• html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):

3:33 PM Changeset in webkit [289776] by Simon Fraser

• 3 edits
  2 adds in trunk

Fix crash with deeply nested async overflow scroll
​https://bugs.webkit.org/show_bug.cgi?id=236599
Source/WebCore:

rdar://88656665

Reviewed by Alan Bujtas.

mergeClippingScopesRecursive() already does the append of the rects; doing so
before calling recursing triggers double appends, hence exponentially growing
rect lists.

Test: compositing/layer-creation/clipping-scope/deeply-nested-overflow.html

• rendering/LayerOverlapMap.cpp:

(WebCore::OverlapMapContainer::mergeClippingScopesRecursive):

LayoutTests:

Reviewed by Alan Bujtas.

• compositing/layer-creation/clipping-scope/deeply-nested-overflow-expected.txt: Added.
• compositing/layer-creation/clipping-scope/deeply-nested-overflow.html: Added.

3:33 PM Changeset in webkit [289775] by Adrian Perez de Castro

• 3 edits in releases/WebKitGTK/webkit-2.34/Source/WebCore

Merge r288539 - Expand RefPtr / Ref use in FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=235551
rdar://87986840

Reviewed by Mark Lam.

Apply Ref / RefPtr instead of taking SerializedScriptValue*.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):

• loader/FrameLoader.h:

3:26 PM Changeset in webkit [289774] by Russell Epstein

• 1 copy in tags/Safari-614.1.2.2

Tag Safari-614.1.2.2.

3:19 PM Changeset in webkit [289773] by Dewei Zhu

• 17 edits in trunk/Tools/Scripts

Update shebang for run-benchmark scripts.

Reviewed by Jonathan Bedard.

Use python3 in shebang for run-benchmark.
Remove shebang from modules in benchmark_runner.

• Tools/Scripts/run-benchmark:
• Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
• Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
• Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
• Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
• Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
• Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
• Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
• Tools/Scripts/webkitpy/benchmark_runner/generic_factory.py:
• Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
• Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
• Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
• Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
• Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
• Tools/Scripts/webkitpy/benchmark_runner/utils.py:
• Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
• Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:

Canonical link: ​https://commits.webkit.org/247243@main

3:13 PM Changeset in webkit [289772] by Russell Epstein

• 6 edits in branches/safari-614.1.2-branch/Source

Cherry-pick r289592. rdar://problem/88323950

tryReserveUncommittedAligned should explicitly take the alignment requested
​https://bugs.webkit.org/show_bug.cgi?id=236460

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

When reducing the size of VA space reserved for Structures, we
didn't take care to ensure the alignment matched the required
alignment for our bit mask. To fix this we need to pass the
original alignment to the allocator as a new parameter.

• heap/StructureAlignedMemoryAllocator.cpp: (JSC::StructureMemoryManager::StructureMemoryManager):

Source/WTF:

This patch adds a new ifdef for Unix flavors that support the
MAP_ALIGNED macro/parameter to mmap.

Also, fix a bug where on windows we wouldn't request enough
space to guarantee that allocation is aligned.

• wtf/OSAllocator.h:
• wtf/posix/OSAllocatorPOSIX.cpp: (WTF::OSAllocator::tryReserveUncommittedAligned):
• wtf/win/OSAllocatorWin.cpp: (WTF::OSAllocator::tryReserveUncommittedAligned):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:12 PM Changeset in webkit [289771] by Russell Epstein

• 9 edits in branches/safari-614.1.2-branch/Source

Versioning.

WebKit-7614.1.2.2

2:59 PM Changeset in webkit [289770] by jonlee@apple.com

• 4 edits in trunk

Enable accelerated drawing in the iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=231828
rdar://problem/84315491

Reviewed by Simon Fraser.

Tools:

• WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::defaults):

LayoutTests:

• platform/ios/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt:

2:59 PM Changeset in webkit [289769] by Patrick Angle

• 6 edits
  2 adds in trunk/Source/WebCore

Web Inspector: Element tooltips in overlays should use same encodable/decodable Label type as grid overlays
​https://bugs.webkit.org/show_bug.cgi?id=235422

Reviewed by Devin Rousso.

The tooltip for elements previously used its own slightly different labels from those used for grid overlays,
which are implemented in such a way to support being sent to the UI process for iOS overlay support. This patch
adds support for the setting different colors for different runs of text along with multi-line labels to allow
the same label to be used for both Grid overlays as well as element tooltips.

The existing WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label was moved to
WebCore::InspectorOverlayLabel as it is no longer exclusively used for grids.

With that support, we can now use InspectorOverlayLabel for element tooltips without needing duplicated layout
and drawing code. Additionally, the font used in the tooltip is now consistent with grid labels, where as
previously we used different font families for the grid and element labels.

• Headers.cmake:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawElementTitle):
(WebCore::InspectorOverlay::drawGridOverlay):
(WebCore::InspectorOverlay::buildGridOverlay):
(WebCore::fontForLayoutLabel): Moved to InspectorOverlayLabel.cpp as systemFont.
(WebCore::backgroundPathForLayoutLabel): Moved to InspectorOverlayLabel.cpp as backgroundPath.
(WebCore::expectedSizeForLayoutLabel): Moved to InspectorOverlayLabel.cpp as expectedSize.
(WebCore::drawLayoutLabel): Moved to InspectorOverlayLabel.cpp as draw.
(WebCore::buildLabel): Deleted.

• inspector/InspectorOverlay.h:

(WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label::encode const): Deleted.
(WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label::decode): Deleted.

• inspector/InspectorOverlayLabel.cpp: Added.

(WebCore::InspectorOverlayLabel::InspectorOverlayLabel):
(WebCore::systemFont):
(WebCore::backgroundPath):
(WebCore::InspectorOverlayLabel::draw):

• Updated logic to handle multiple strings, including strings containing newlines. Strings are now each

converted to a TextRun, or multiple text runs for multi-line text, each of which is measured to determine the
overall height and width of the label, as well as to later in the drawing code give us the information necessary
to actually draw these strings in the proper locations.

• Use the width of the longest line for drawing the background of the label.
• Iterate through the computed TextRuns and draw the _{moving to the next line for each index that we had}

previously computed to be the start of a new line.
(WebCore::InspectorOverlayLabel::expectedSize):

• Similar to InspectorOverlayLabel::draw we need to take in to account multi-line strings, but do not need to

keep the computed TextRuns or their widths, only the width of the longest line and the total number of lines, to
compute the expected size of the contents in a label.

• inspector/InspectorOverlayLabel.h: Added.

(WebCore::InspectorOverlayLabel::Arrow::Arrow):
(WebCore::InspectorOverlayLabel::encode const):
(WebCore::InspectorOverlayLabel::decode):
(WebCore::InspectorOverlayLabel::Arrow::encode const):
(WebCore::InspectorOverlayLabel::Arrow::decode):
(WebCore::InspectorOverlayLabel::Content::encode const):
(WebCore::InspectorOverlayLabel::Content::decode):

2:56 PM Changeset in webkit [289768] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[macOS] Check feature flag before using screen/window picker
​https://bugs.webkit.org/show_bug.cgi?id=236596
<rdar://problem/88909015>

Reviewed by Jer Noble.

Tested manually.

• platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm:

(WebCore::screenCaptureKitPickerFeatureEnabled): Check feature flag.
(WebCore::ScreenCaptureKitSharingSessionManager::isAvailable):

2:48 PM Changeset in webkit [289767] by Said Abou-Hallawa

• 4 edits in trunk/Source/WebCore

[GPU Process] Implement GraphicsContext::drawLineForText() in terms of GraphicsContext::drawLinesForText()
​https://bugs.webkit.org/show_bug.cgi?id=236464

Reviewed by Simon Fraser.

Make GraphicsContext::drawLineForText() non virtual and delete all the
super classes' implementations for this function since it calls the virtual
function drawLinesForText().

• platform/graphics/GraphicsContext.h:
• platform/graphics/NullGraphicsContext.h:
• platform/graphics/displaylists/DisplayListRecorder.h:

2:46 PM Changeset in webkit [289766] by Said Abou-Hallawa

• 2 edits in trunk/Source/WebKit

[GPU Process] RemoteImageBufferProxy should not sink itself to an Image or a NativeImage though its backend
​https://bugs.webkit.org/show_bug.cgi?id=236484

Reviewed by Simon Fraser.

The purpose of sinkIntoImage() and sinkIntoNativeImage() is to reuse the
pixels of an ImageBuffer to be a NativeImage or an Image which encapsulates
a NativeImage.

But for RemoteImageBufferProxy these functions are meaningless because
the pixels (or the backend) can't be accessed in WebProcess.

So to keep the code in WebCore untouched, these two functions will be
overridden by RemoteImageBufferProxy to call the 'copy' methods. The
'copy' methods use the IPC messages to get a NativeImage from GPUProcess.

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

2:22 PM Changeset in webkit [289765] by Truitt Savell

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/xhr/send-timeout-events.htm as failing on iOS aftet the changes in r289540
​https://bugs.webkit.org/show_bug.cgi?id=231337

Unreviewed test gardening.

• platform/ios/TestExpectations:

2:22 PM WebKitGTK/2.34.x edited by Gustavo Noronha Silva

Propose 16k pages for the stable branch (diff)

2:18 PM Changeset in webkit [289764] by Russell Epstein

• 9 edits in trunk/Source

Versioning.

WebKit-7614.1.5

2:15 PM Changeset in webkit [289763] by Wenson Hsieh

• 12 edits
  1 copy in trunk/Source

[Live Text] Plumb platform image analysis objects to the web process
​https://bugs.webkit.org/show_bug.cgi?id=236535
rdar://88845367

Reviewed by Devin Rousso.

Source/WebCore:

Add a platformData member to TextRecognitionResult, which (when ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS) is
enabled) contains a pointer to VKCImageAnalysis. See WebKit/ChangeLog for more details.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/TextRecognitionResult.h:

Also add new WebKitAdditions extension points around TextRecognitionResult.

(WebCore::TextRecognitionResult::encode const):
(WebCore::TextRecognitionResult::decode):

• platform/cocoa/TextRecognitionResultCocoa.mm:

Source/WebCore/PAL:

Add soft-linking support for VKCImageAnalysis. See WebCore and WebKit ChangeLogs for more detail.

• pal/cocoa/AVFoundationSoftLink.h:

Avoid a build error after shifting around Cocoa unified sources, by removing an unused definition of
AVOutputContextOutputDevicesDidChangeNotification. This definition causes the unified build to break downstream,
when other media-related source files end up importing AVKit headers that try to reference this symbol
(AVOutputContextOutputDevicesDidChangeNotification) but end up expanding the WebKit soft-linking macro instead.

• pal/cocoa/VisionKitCoreSoftLink.h:
• pal/cocoa/VisionKitCoreSoftLink.mm:

Source/WebKit:

Plumb the platform text recognition results object (VKCImageAnalysis) through TextRecognitionResults to the
web process when computing text recognition results for Live Text, and add a few new WebKitAdditions extension
points. In a subsequent patch, we'll use this VKCImageAnalysis on TextRecognitionResults to refactor how we
write Live Text to the system pasteboard when copying.

• Platform/cocoa/TextRecognitionUtilities.mm:

(WebKit::makeTextRecognitionResult):

Set platformData.

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<RetainPtr<VKCImageAnalysis>>::encode):
(IPC::ArgumentCoder<RetainPtr<VKCImageAnalysis>>::decode):

• Shared/WebCoreArgumentCoders.h:

1:51 PM Changeset in webkit [289762] by Devin Rousso

• 2 edits in trunk/Source/WebCore

REGRESSION(r286560): MediaElement's getStartDate returning an incorrect time
​https://bugs.webkit.org/show_bug.cgi?id=236360
<rdar://problem/88786989>

Reviewed by Eric Carlson.

r286560 changed IDL Date to use WallTime instead of a raw double, meaning that
HTMLMediaElement::getStartDate now did extra processing of the MediaTime returned by
MediaPlayer::getStartDate.

Unfortunately, MediaPlayerPrivateAVFoundationObjC::getStartDate returned a MediaTime
represented in milliseconds (due to two * 1000), even though MediaTime is supposed to be
seconds-based.

As a result, the changes in r286560 inadvertently caused two * 1000 on the same time value.

Covered by existing test (LayoutTests/http/tests/media/hls/video-controller-getStartDate.html).
Note that the test was marked as [Pass Failure] before r286560.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::getStartDate const):

1:12 PM Changeset in webkit [289761] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[Linux/aarch64] Move page size ceiling to 16k
​https://bugs.webkit.org/show_bug.cgi?id=236564

Patch by Gustavo Noronha Silva <​gustavo@noronha.dev.br> on 2022-02-14
Reviewed by Yusuke Suzuki.

On Apple Silicon, Linux needs to use 16k pages to be as fast as possible. This change has no
visible impact on binary size for release builds, so apply it to all of aarch64 Linux.

• wtf/PageBlock.h:

1:10 PM Changeset in webkit [289760] by J Pascoe

• 7 edits in trunk

[WebAuthn] Access group not set in add query for importLocalAuthenticatorCredential
​https://bugs.webkit.org/show_bug.cgi?id=236469
rdar://problem/88783447

Reviewed by Brent Fulgham.

Source/WebKit:

In Bug 236311 we added support setting accessGroup, but did not properly set it
on the addQuery. This patch fixes that.

Updated API test to use non-standard accessGroup.

• UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):

Tools:

Updated API test to use non-standard access group.

• TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
• TestWebKitAPI/Configurations/TestWebKitAPI-macOS-internal.entitlements:
• TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

1:09 PM Changeset in webkit [289759] by Russell Epstein

• 9 edits in branches/safari-614.1.3-branch/Source

Versioning.

WebKit-7614.1.3.1

1:09 PM Changeset in webkit [289758] by commit-queue@webkit.org

• 4 edits
  3 copies
  1 move
  8 adds
  1 delete in trunk/LayoutTests

[GLIB] Update test expectations and baselines. Unreviewed test gardening.
​https://bugs.webkit.org/show_bug.cgi?id=236597

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-02-14

• platform/glib/TestExpectations:
• platform/glib/imported/w3c/web-platform-tests/css/css-contain/container-queries/counters-flex-circular-expected.txt: Added.
• platform/glib/imported/w3c/web-platform-tests/css/filter-effects/feimage-circular-reference-foreign-object-crash-expected.txt: Added.
• platform/glib/imported/w3c/web-platform-tests/css/filter-effects/feimage-reference-foreign-object-crash-expected.txt: Added.
• platform/gtk/TestExpectations:
• platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt: Copied from LayoutTests/platform/glib/fast/text/international/bidi-layout-across-linebreak-expected.txt.
• platform/gtk/fast/text/international/bidi-override-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Copied from LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt.
• platform/wpe/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/glib/fast/text/international/bidi-layout-across-linebreak-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Renamed from LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt.

1:05 PM Changeset in webkit [289757] by Razvan Caliman

• 5 edits
  1 copy
  2 moves
  1 add in trunk/Source/WebInspectorUI

Web Inspector: [Flexbox] List flex containers in Layout sidebar
​https://bugs.webkit.org/show_bug.cgi?id=235647
<rdar://87886241>

Reviewed by Patrick Angle.

The representation in the Layout details sidebar of the list of flex containers on the page is very similar to the one for grid containers:
a list of nodes identified by selector, with adjacent checkboxes that synchronize state with the visibility of a page overlay, interactive
color swatches to decorate the corresponding overlay, and a button to jump to the node in the DOM Tree view.

Therefore, it makes sense to generalize the code for CSS Grid and reuse it for Flexbox.

This patch extracts a generic WI.NodeOverlayListSection from WI.CSSGridNodeOverlayListSection.
This is subclassed by WI.CSSGridNodeOverlayListSection and WI.CSSFlexboxSection.
The two rely on the abstract implementations to show/hide overlays, get/set overlay colors, interrogate overlay visibility, and listen to generic overlay show events.

Which particular type of overlay is the target of each panel is determined in WI.OverlayManager
by the value of WI.DomNode.layoutContextType, either "flex" or "grid". A node cannot have more than one layout context type.

Where the subclasses differ:

• each section has its own label (obviously).
• the layout for WI.CSSGridNodeOverlayListSection includes a section with settings for the CSS Grid overlay.

• Localizations/en.lproj/localizedStrings.js:

We've received feedback that the latter is more common in web developers' vocabulary when
refering to CSS grids. Adopted the same for the flexbox section empty message.

• UserInterface/Main.html:

• UserInterface/Views/CSSFlexNodeOverlayListSection.js: Added.

(WI.CSSFlexNodeOverlayListSection.prototype.get sectionLabel):
(WI.CSSFlexNodeOverlayListSection):

• UserInterface/Views/CSSGridNodeOverlayListSection.js: Renamed from Source/WebInspectorUI/UserInterface/Views/CSSGridSection.js.

(WI.CSSGridNodeOverlayListSection.prototype.get sectionLabel):
(WI.CSSGridNodeOverlayListSection.prototype.initialLayout):
(WI.CSSGridNodeOverlayListSection):
The layout of WI.CSSFlexNodeOverlayListSection includes a set of options to configure the CSS Grid overlay.

• UserInterface/Views/LayoutDetailsSidebarPanel.css:

(.details-section:is(.layout-css-flexbox, .layout-css-grid):not(.collapsed) > .content,):
(.details-section.layout-css-grid > .content > .group > .row > .css-grid-section): Deleted.
(.details-section.layout-css-grid:not(.collapsed) > .content,): Deleted.

• UserInterface/Views/LayoutDetailsSidebarPanel.js:

(WI.LayoutDetailsSidebarPanel):
(WI.LayoutDetailsSidebarPanel.prototype.attached):
(WI.LayoutDetailsSidebarPanel.prototype.initialLayout):
(WI.LayoutDetailsSidebarPanel.prototype.layout):
(WI.LayoutDetailsSidebarPanel.prototype._handleLayoutContextTypeChanged):
(WI.LayoutDetailsSidebarPanel.prototype._refreshNodeSets):
(WI.LayoutDetailsSidebarPanel.prototype._refreshGridNodeSet): Deleted.
Added Flexbox section to Layout details sidebar.

• UserInterface/Views/NodeOverlayListSection.css: Renamed from Source/WebInspectorUI/UserInterface/Views/CSSGridSection.css.

(.node-overlay-list-section):
(.node-overlay-list-section > .node-overlay-list):
(.node-overlay-list-section > .node-overlay-list > li > .node-overlay-list-item-container):
(.node-overlay-list-section > .node-overlay-list > li > .node-overlay-list-item-container > label):
(.node-overlay-list-section > .node-overlay-list > li > .node-overlay-list-item-container > label > .node-display-name):
(.node-overlay-list-section > .node-overlay-list > li > .node-overlay-list-item-container > :is(.go-to-arrow, .inline-swatch)):
(.node-overlay-list-section > .node-overlay-list > li > .node-overlay-list-item-container:not(:hover) > .go-to-arrow):
(.node-overlay-list-section > .heading,):
(.node-overlay-list-section > .heading > label > .toggle-all):
(.node-overlay-list-section :is(.setting-editor, .node-overlay-list-item-container, .heading) input[type="checkbox"]):
A full-on replacement of .css-grid-section with .node-overlay-list-section since the two sections share the same styles.

• UserInterface/Views/NodeOverlayListSection.js: Copied from Source/WebInspectorUI/UserInterface/Views/CSSGridSection.js.

(WI.NodeOverlayListSection):
(WI.NodeOverlayListSection.prototype.set nodeSet):
(WI.NodeOverlayListSection.prototype.get sectionLabel):
(WI.NodeOverlayListSection.prototype.attached):
(WI.NodeOverlayListSection.prototype.detached):
(WI.NodeOverlayListSection.prototype.initialLayout):
(WI.NodeOverlayListSection.prototype.layout):
(WI.NodeOverlayListSection.prototype._handleOverlayStateChanged):
(WI.NodeOverlayListSection.prototype._handleToggleAllCheckboxChanged):
(WI.NodeOverlayListSection.prototype._updateToggleAllCheckbox):
Removed all the specific implementations for CSS Grid after generalizing them into WI.NodeOverlayListSection.

12:57 PM Changeset in webkit [289756] by Jonathan Bedard

• 3 edits in trunk/Tools

[EWS] Rebase PRs on tip of branch (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=236389
<rdar://problem/88705147>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(CleanGitRepo.run): Squash git rebase --abort errors.

• CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/247229@main

12:49 PM Changeset in webkit [289755] by Russell Epstein

• 4 edits
  2 adds in branches/safari-613-branch

Cherry-pick r289686. rdar://problem/88689388

contain:content breaks fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=236470
<rdar://88689388>

Reviewed by Simon Fraser.

Source/WebCore:

Paint/layout containment forms a containing block for fixed positioned block boxes. It makes all fixed
positioned descendants anchored (contained) to this layout container.
This patch enables fullscreen boxes break out of this non-ICB based layout scope (this is similar to what we
do for other, "layout scope changing" properties, see canContainFixedPositionObjects).

Test: fullscreen/fullscreen-prevented-by-containment.html

• css/fullscreen.css: (:-webkit-full-screen-ancestor:not(iframe)):
• css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext):

LayoutTests:

• fullscreen/fullscreen-prevented-by-containment-expected.txt: Added.
• fullscreen/fullscreen-prevented-by-containment.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:49 PM Changeset in webkit [289754] by Russell Epstein

• 5 edits
  4 deletes in branches/safari-613-branch

Cherry-pick r289682. rdar://problem/88843567

Unreviewed, reverting r289498.
​https://bugs.webkit.org/show_bug.cgi?id=236534

Speedometer2 2% regression

Reverted changeset:

"Dialog element only animates once"
​https://bugs.webkit.org/show_bug.cgi?id=236274
​https://commits.webkit.org/r289498

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:49 PM Changeset in webkit [289753] by Russell Epstein

• 5 edits in branches/safari-613-branch/Source

Cherry-pick r289658. rdar://problem/88678598

Regression(r287684) Microsoft teams meeting URLs fail to open the app
​https://bugs.webkit.org/show_bug.cgi?id=236516
<rdar://88678598>

Reviewed by Geoffrey Garen.

Add a quirk for Microsoft teams.

Source/WebCore:

• page/Quirks.cpp: (WebCore::Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture):
• page/Quirks.h:

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:29 PM Changeset in webkit [289752] by Fujii Hironori

• 2 edits in trunk/Tools

run-jsc-stress-tests reports "in `<module:URI>': uninitialized class variable @@schemes in URI (NameError)" with Ruby 3.1
​https://bugs.webkit.org/show_bug.cgi?id=236281

Reviewed by Yusuke Suzuki.

Ruby 3.1.0 removed @@schemes and added URI.register_scheme.

• Scripts/run-jsc-stress-tests: Added register_scheme class

method if not exists. Use the register_scheme method for ssh.

12:12 PM Changeset in webkit [289751] by Peng Liu

• 2 edits in trunk/Source/WebCore

Add a centerControlsBar in InlineMediaControls
​https://bugs.webkit.org/show_bug.cgi?id=236575

Reviewed by Jer Noble.

When a subclass of InlineMediaControls implements _centerContainerButtons()
to return a list of elements, a control bar will be added as a child of the
media-controls element.

No behavior change so far.

• Modules/modern-media-controls/controls/inline-media-controls.js:

(InlineMediaControls):
(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype._centerContainerButtons):

11:57 AM Changeset in webkit [289750] by Russell Epstein

• 5 edits
  4 deletes in branches/safari-613.1.17.1-branch

Cherry-pick r289682. rdar://problem/88843567

Unreviewed, reverting r289498.
​https://bugs.webkit.org/show_bug.cgi?id=236534

Speedometer2 2% regression

Reverted changeset:

"Dialog element only animates once"
​https://bugs.webkit.org/show_bug.cgi?id=236274
​https://commits.webkit.org/r289498

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:57 AM Changeset in webkit [289749] by Russell Epstein

• 4 edits
  2 adds in branches/safari-613.1.17.1-branch

Cherry-pick r289686. rdar://problem/88689388

contain:content breaks fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=236470
<rdar://88689388>

Reviewed by Simon Fraser.

Source/WebCore:

Paint/layout containment forms a containing block for fixed positioned block boxes. It makes all fixed
positioned descendants anchored (contained) to this layout container.
This patch enables fullscreen boxes break out of this non-ICB based layout scope (this is similar to what we
do for other, "layout scope changing" properties, see canContainFixedPositionObjects).

Test: fullscreen/fullscreen-prevented-by-containment.html

• css/fullscreen.css: (:-webkit-full-screen-ancestor:not(iframe)):
• css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext):

LayoutTests:

• fullscreen/fullscreen-prevented-by-containment-expected.txt: Added.
• fullscreen/fullscreen-prevented-by-containment.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:57 AM Changeset in webkit [289748] by Russell Epstein

• 5 edits
  4 deletes in branches/safari-613.1.17.0-branch

Cherry-pick r289682. rdar://problem/88843567

Unreviewed, reverting r289498.
​https://bugs.webkit.org/show_bug.cgi?id=236534

Speedometer2 2% regression

Reverted changeset:

"Dialog element only animates once"
​https://bugs.webkit.org/show_bug.cgi?id=236274
​https://commits.webkit.org/r289498

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:57 AM Changeset in webkit [289747] by Russell Epstein

• 5 edits in branches/safari-613.1.17.1-branch/Source

Cherry-pick r289658. rdar://problem/88678598

Regression(r287684) Microsoft teams meeting URLs fail to open the app
​https://bugs.webkit.org/show_bug.cgi?id=236516
<rdar://88678598>

Reviewed by Geoffrey Garen.

Add a quirk for Microsoft teams.

Source/WebCore:

• page/Quirks.cpp: (WebCore::Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture):
• page/Quirks.h:

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:57 AM Changeset in webkit [289746] by Russell Epstein

• 4 edits
  2 adds in branches/safari-613.1.17.0-branch

Cherry-pick r289686. rdar://problem/88689388

contain:content breaks fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=236470
<rdar://88689388>

Reviewed by Simon Fraser.

Source/WebCore:

Paint/layout containment forms a containing block for fixed positioned block boxes. It makes all fixed
positioned descendants anchored (contained) to this layout container.
This patch enables fullscreen boxes break out of this non-ICB based layout scope (this is similar to what we
do for other, "layout scope changing" properties, see canContainFixedPositionObjects).

Test: fullscreen/fullscreen-prevented-by-containment.html

• css/fullscreen.css: (:-webkit-full-screen-ancestor:not(iframe)):
• css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext):

LayoutTests:

• fullscreen/fullscreen-prevented-by-containment-expected.txt: Added.
• fullscreen/fullscreen-prevented-by-containment.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:57 AM Changeset in webkit [289745] by Russell Epstein

• 5 edits in branches/safari-613.1.17.0-branch/Source

Cherry-pick r289658. rdar://problem/88678598

Regression(r287684) Microsoft teams meeting URLs fail to open the app
​https://bugs.webkit.org/show_bug.cgi?id=236516
<rdar://88678598>

Reviewed by Geoffrey Garen.

Add a quirk for Microsoft teams.

Source/WebCore:

• page/Quirks.cpp: (WebCore::Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture):
• page/Quirks.h:

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:48 AM Changeset in webkit [289744] by Russell Epstein

• 9 edits in branches/safari-613.1.17.1-branch/Source

Versioning.

WebKit-7613.1.17.1.2

11:29 AM Changeset in webkit [289743] by Russell Epstein

• 9 edits in branches/safari-613.1.17.0-branch/Source

Versioning.

WebKit-7613.1.17.0.2

11:05 AM Changeset in webkit [289742] by Antti Koivisto

• 16 edits
  1 copy
  1 add in trunk

[CSS Container Queries] Implement full query parser and evaluator
​https://bugs.webkit.org/show_bug.cgi?id=236580

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:
• web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.tentative-expected.txt:
• web-platform-tests/css/css-contain/container-queries/container-type-invalidation-expected.txt:
• web-platform-tests/css/css-contain/container-queries/query-evaluation-expected.txt:
• web-platform-tests/css/css-contain/container-queries/size-feature-evaluation-expected.txt:

Source/WebCore:

So far we have been using the media query parser to parse container queries.
It does not support nesting and other necessary features. Also the produced data
structures are awkward to evaluate.

​https://drafts.csswg.org/css-contain-3/#container-rule

This patch supports size queries but not style queries. It supports both the current spec
size query syntax "size(foo)" (used in WPTs), and the non-function POR syntax from
​https://github.com/w3c/csswg-drafts/issues/6870#issuecomment-1022430911.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/ContainerQuery.h:
• css/ContainerQueryParser.cpp: Added.

(WebCore::ContainerQueryParser::parse):
(WebCore::ContainerQueryParser::consumeContainerQuery):
(WebCore::ContainerQueryParser::consumeCondition):
(WebCore::ContainerQueryParser::consumeSizeQuery):

No support for range operators ('<' etc) yet.

• css/ContainerQueryParser.h: Copied from Source/WebCore/css/ContainerQuery.h.

(WebCore::ContainerQueryParser::ContainerQueryParser):

• css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeContainerRule):

• style/ContainerQueryEvaluator.cpp:

(WebCore::Style::computeSize):
(WebCore::Style::ContainerQueryEvaluator::evaluate const):
(WebCore::Style::ContainerQueryEvaluator::evaluateQuery const):
(WebCore::Style::ContainerQueryEvaluator::evaluateCondition const):
(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):

Just 'width' and 'height' for now, no new size features yet.

• style/ContainerQueryEvaluator.h:

LayoutTests:

• TestExpectations:

10:47 AM Changeset in webkit [289741] by Russell Epstein

• 1 copy in branches/safari-614.1.4-branch

New branch.

10:39 AM Changeset in webkit [289740] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

CallLinkInfo::emitFastPathImpl() should avoid external scratch register use on RISCV64
​https://bugs.webkit.org/show_bug.cgi?id=236064

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2022-02-14
Reviewed by Yusuke Suzuki.

Avoid external scratch register usage in CallLinkInfo::emitFastPathImpl()
for RISCV64 since the scratch register ends up having to be used in the
branchTestPtr implementation of RISCV64's MacroAssembler.

The RISCV64-specific alternative is to suffer resolving and loading from
the callee address for both branching operations. Other platforms
continue to operate with the external scratch register as they either
use a wider set of scratch registers or don't even have to use scratch
registers for the load and branching operations used here.

• assembler/CPU.h: Add isRISCV64(). Also impose a more sensible order.

(JSC::isMIPS):
(JSC::isRISCV64):

• bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::emitFastPathImpl):

9:58 AM Changeset in webkit [289739] by J Pascoe

• 7 edits in trunk/Source

[WebAuthn] Modify _WKWebAuthenticationAssertionResponse according to internal needs
​https://bugs.webkit.org/show_bug.cgi?id=236369
rdar://88585811

Reviewed by Brent Fulgham.

Source/WebCore:

This patch modifies AuthenticatorAssertionResponse with additional
fields and populates them according to internal needs.

• Modules/webauthn/AuthenticatorAssertionResponse.h:

(WebCore::AuthenticatorAssertionResponse::group const):
(WebCore::AuthenticatorAssertionResponse::synchronizable const):
(WebCore::AuthenticatorAssertionResponse::setGroup):
(WebCore::AuthenticatorAssertionResponse::setSynchronizable):

Source/WebKit:

This patch modifies the _WKWebAuthenticationAssertionResponse API object with additional
fields and populates them according to internal needs.

• UIProcess/API/APIWebAuthenticationAssertionResponse.h:
• UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.h:
• UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.mm:

(-[_WKWebAuthenticationAssertionResponse synchronizable]):
(-[_WKWebAuthenticationAssertionResponse group]):

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(groupForAttributes):
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):

9:07 AM Changeset in webkit [289738] by ntim@apple.com

• 7 edits in trunk

Don't perform layout in WKBundlePagePostSynchronousMessageForTesting
​https://bugs.webkit.org/show_bug.cgi?id=236579

Reviewed by Brady Eidson.

This turned out to be a problem for bug 22722, which introduced the WithLayout::No workaround.

r188793 introduced this layoutIfNeeded call specifically for UI event messages, so only perform the
layout in that specific case. Also remove the workaround introduced in bug 22722.

Source/WebKit:

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePagePostSynchronousMessageForTesting):
(WKBundlePageLayoutIfNeeded):
(WKBundlePagePostSynchronousMessageForTestingWithoutLayout): Deleted.

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Tools:

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::postSynchronousPageMessage):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::postSynchronousPageMessageWithReturnValue):
(WTR::TestRunner::grantWebNotificationPermission):
(WTR::TestRunner::denyWebNotificationPermission):

7:28 AM Changeset in webkit [289737] by Jonathan Bedard

• 3 edits in trunk/Tools

[EWS] Re-enable build retry for PRs
​https://bugs.webkit.org/show_bug.cgi?id=236300
<rdar://problem/88628832>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.analyzeResults): Enable retry for PRs with failing builds.
(CleanGitRepo.run): Abort any failed rebases.

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/247222@main

7:19 AM Changeset in webkit [289736] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Nullptr crash in CompositeEditCommand::splitTreeToNode via InsertParagraphSeparatorCommand::doApply
​https://bugs.webkit.org/show_bug.cgi?id=229283

Patch by Frédéric Wang <​fwang@igalia.com> on 2022-02-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Position::upstream handles edge cases like tables specially which can lead to
InsertParagraphSeparatorCommand::doApply incorrectly expecting a next sibling after a text
node at last position in order to perform a split. This patch works around that by ignoring
the split in that case.

Test: editing/inserting/insert-paragraph-separator-with-inline-table-bold-crash.html

• editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Only try and remove remaining nodes if
splitTo is not null. moveRemainingSiblingsToNewParent will be a no-op when n is null. Also
switch from raw pointers to RefPtr<Node>.

LayoutTests:

Add regression test.

• editing/inserting/insert-paragraph-separator-with-inline-table-bold-crash-expected.txt: Added.
• editing/inserting/insert-paragraph-separator-with-inline-table-bold-crash.html: Added.

6:42 AM Changeset in webkit [289735] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html
​https://bugs.webkit.org/show_bug.cgi?id=236572

Reviewed by Antti Koivisto.

adjustVisualGeometryForDisplayBox needs the line's logical top (which is turned into visual inside
at (lineBoxLogicalTop + logicalRect.top())).

• layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

• layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:

6:37 AM Changeset in webkit [289734] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/block/float/float-with-fractional-height-vertical-lr.html
​https://bugs.webkit.org/show_bug.cgi?id=236576

Reviewed by Antti Koivisto.

Let's translate the incoming float boxes' visual coordinates to logical for line layout.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::prepareFloatingState):

6:06 AM Changeset in webkit [289733] by graouts@webkit.org

• 4 edits
  2 adds in trunk/LayoutTests

[model] refactor model document tests to use a shared testing function
​https://bugs.webkit.org/show_bug.cgi?id=236578

Reviewed by Dean Jackson.

Add a new model_document_test function that both model document tests can use
to get the document loaded inside the iframe.

• http/tests/model/model-document-interactive-expected.txt:
• http/tests/model/model-document-interactive.html:
• http/tests/model/model-document.html:
• http/tests/model/resources/model-document.js: Added.

(const.model_document_test):

6:03 AM Changeset in webkit [289732] by Martin Robinson

• 13 edits in trunk

Animation from "scale()" to "scale() translate()" does not yield the expected result
​https://bugs.webkit.org/show_bug.cgi?id=222595
<rdar://problem/74926700>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-transforms/animation/list-interpolation-expected.txt: Mark tests as passing.
• web-platform-tests/css/css-transforms/animation/transform-interpolation-001-expected.txt:
• web-platform-tests/css/css-transforms/animation/transform-interpolation-003-expected.txt:

Source/WebCore:

No new tests. This is covered by existing WPT tests.

When blending two transform lists, where one list is longer than the other, extending the
shorter list with identity transform functions. This is the behavior specified in the
CSS Transforms Module Level 2 specification.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::checkForMatchingTransformFunctionLists): Instead of checking each frame
against the first keyframe, collect a list of shared transform primitives and check that each
list has the same number of compatible primitives or a prefix of compatible primitives and is
shorter.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::getSharedPrimitivesForTransformKeyframes): When the transform operation
lists have different sizes, don't always return false. Instead check that the parts that do exist
have matching primitives.

• platform/graphics/transforms/TransformOperations.cpp:

(WebCore::TransformOperations::operationsMatch const): Only check the transformations in
the shared list size.
(WebCore::TransformOperations::blendByMatchingOperations const): Properly handle when one of the
two operations is null instead of just the toOperation.

LayoutTests:

• compositing/layer-creation/multiple-keyframes-animation-overlap-expected.txt:
• compositing/layer-creation/translate-scale-animation-overlap-expected.txt:

5:04 AM Changeset in webkit [289731] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK][WPE] Avoid mapping attributes when the vector is empty in createImage
​https://bugs.webkit.org/show_bug.cgi?id=236521

Patch by Alejandro G. Castro <​alex@igalia.com> on 2022-02-14
Reviewed by Žan Doberšek.

We are just refactoring the function to avoid calling the map of
the original vector in case it is empty. Also we changed a double
negative in the isEmpty condition to make it clearer.

No new tests, there are tests checking this code.

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createImage const):

4:20 AM Changeset in webkit [289730] by eocanha@igalia.com

• 2 edits in trunk/Source/WebCore

Don't throw exception when controls are removed
​https://bugs.webkit.org/show_bug.cgi?id=236456

Reviewed by Xabier Rodriguez-Calvar.

In mediaControlsBase.js, when media controls are removed, calling controlsAreHidden() can cause
an exception because the panel has no parentElement.

This patch is authored by Eugene Mutavchi <​Ievgen_Mutavchi@comcast.com>
See: ​https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/775

• Modules/mediacontrols/mediaControlsBase.js: Return false if there's no parent.

3:29 AM Changeset in webkit [289729] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[GTK] [WPE] Fix problem when the buffer object is released before we try to send it to the compositor
​https://bugs.webkit.org/show_bug.cgi?id=236520

Patch by Alejandro G. Castro <​alex@igalia.com> on 2022-02-14
Reviewed by Žan Doberšek.

There is a layout test failing because the buffer object was
released before the swap buffers method was called and we were
calling the construction of the TextureMapperPlatformLayerDmabuf
with wrong data.

Fixes webgl/1.0.3/conformance/context/context-release-with-workers.html.

• platform/graphics/angle/GraphicsContextGLANGLE.h: Add the

isReleased function to the EGLImageBacking class.

• platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp: Ditto.

(Nicosia::GCGLANGLELayer::swapBuffersIfNeeded):

• platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::EGLImageBacking::isReleased):
Bail out when the image backing was released.

3:20 AM Changeset in webkit [289728] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

[ATSPI] Reduce the size of dbus objects Vectors
​https://bugs.webkit.org/show_bug.cgi?id=236581

Reviewed by Adrian Perez de Castro.

Use 3 for root, 1 for hyperlink and 7 for object.

• accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::registerObject):

• accessibility/atspi/AccessibilityAtspi.h:

Feb 13, 2022:

11:30 PM Changeset in webkit [289727] by Fujii Hironori

• 5 edits
  2 deletes in trunk/LayoutTests

Delete fast/animation/request-animation-frame-disabled.html after RequestAnimationFrameEnabled setting is deleted
​https://bugs.webkit.org/show_bug.cgi?id=236569

Reviewed by Ryosuke Niwa.

r288797 (Bug 235866) deleted RequestAnimationFrameEnabled setting.
We no longer need fast/animation/request-animation-frame-disabled.html
which tests disabling the setting.

• fast/animation/request-animation-frame-disabled-expected.txt: Removed.
• fast/animation/request-animation-frame-disabled.html: Removed.
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

10:22 PM Changeset in webkit [289726] by Lauro Moura

• 9 edits in trunk/Source

Unreviewed, non-unified build fixes
​https://bugs.webkit.org/show_bug.cgi?id=236577

Source/JavaScriptCore:

• heap/StructureAlignedMemoryAllocator.cpp: Add missing include.

Source/WebCore:

• Modules/notifications/NotificationEvent.cpp: Missing include.
• platform/graphics/ContentTypeUtilities.cpp: Namespace function.

(WebCore::contentTypeMeetsContainerAndCodecTypeRequirements):

• workers/service/ServiceWorkerGlobalScope.cpp: Missing include.

Source/WebKit:

• UIProcess/Notifications/ServiceWorkerNotificationHandler.h: Forward

declare.

• UIProcess/WebProcessProxy.cpp: Missing include.

9:22 PM Changeset in webkit [289725] by ysuzuki@apple.com

• 2 edits in trunk/Source/bmalloc

Unreviewed, fix Linux build of libpas part 2
​https://bugs.webkit.org/show_bug.cgi?id=235347

• libpas/src/libpas/pas_thread_local_cache.c:

(stop_allocator):

9:14 PM Changeset in webkit [289724] by ysuzuki@apple.com

• 7 edits in trunk/Source/bmalloc

Unreviewed, fix Linux build of libpas
​https://bugs.webkit.org/show_bug.cgi?id=235347

• libpas/src/libpas/pas_committed_pages_vector.c:

(pas_committed_pages_vector_construct):

• libpas/src/libpas/pas_committed_pages_vector.h:

(pas_committed_pages_vector_is_committed):

• libpas/src/libpas/pas_local_view_cache.h:

(pas_local_view_cache_prepare_to_pop):

• libpas/src/libpas/pas_segregated_heap.c:

(pas_segregated_heap_ensure_allocator_index):

• libpas/src/libpas/pas_thread_local_cache.c:

(stop_allocator):

• libpas/src/libpas/pas_try_allocate_primitive.h:

(pas_try_allocate_primitive_impl_casual_case):

7:49 PM Changeset in webkit [289723] by Andres Gonzalez

• 4 edits in trunk/Source/WebCore

Decouple AXObjectCache handleChildrenChanged and postNotification.
​https://bugs.webkit.org/show_bug.cgi?id=234059
<rdar://problem/86247404>

Reviewed by Chris Fleizach.

This fixes ~7 accessibility tests in isolated tree mode.
Also fixes flakiness in accessibility/dialog-showModal.html.

AXObjectCache::handleChildrenChanged was posting an AXChildrenChanged
notification (postNotification), which causes a double deferral of these
notifications, instead of actually handling the notification.
ChildrenChanged notifications should be handled before many other
notifications of property changes since they are DOM mutations, objects
added or removed, before properties in the resulting objects may be
updated. This patch fixes this problem by making handleChildrenChanged
to actually handle the notifications and update the isolated tree.
In addition, handling of the "open" attribute for <dialog> elements now
updates children, which fixes the flakiness observed in the
dialog-showModal.html test.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::deferModalChange):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::performCacheUpdateTimerFired):

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
Removed alternative fix where we were processing the pending
ChildrenChanged Notifications before updating the isolated tree.

• accessibility/isolatedtree/AXIsolatedTree.h:

5:52 PM Changeset in webkit [289722] by commit-queue@webkit.org

• 25 edits
  4 adds
  2 deletes in trunk

Add support for parsing 'subgrid' in grid-template-columns/row
​https://bugs.webkit.org/show_bug.cgi?id=236054

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-13
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Imported lastest subgrid tests.

• web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid-expected.txt:
• web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid.html:
• web-platform-tests/css/css-grid/subgrid/grid-template-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/subgrid/grid-template-invalid.html:
• web-platform-tests/css/css-grid/subgrid/grid-template-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/subgrid/grid-template-valid.html:

Source/WebCore:

Adds support for parsing the 'subgrid' keyword followed by a list of line names for
grid-template-columns/rows.
Adds a new CSSSubgridValue wrapper around CSSValueList to represent this.
Also adds support for converting this into style data in StyleBuilderConverter, and serializing
the specified value for computed value (used when the element specified subgrid but doesn't
have an appropriate grid parent).

Tests: imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-template-invalid.html

imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-template-valid.html

• Headers.cmake:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::OrderedNamedLinesCollector::namedGridLineCount const):
(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::populateSubgridLineNameList):
(WebCore::valueForGridTrackList):

• css/CSSSubgridValue.cpp: Added.

(WebCore::CSSSubgridValue::customCSSText const):
(WebCore::CSSSubgridValue::CSSSubgridValue):

• css/CSSSubgridValue.h: Added.
• css/CSSValue.cpp:

(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):

• css/CSSValue.h:

(WebCore::CSSValue::isSubgridValue const):

• css/CSSValueKeywords.in:
• css/parser/CSSParserContext.cpp:

(WebCore::operator==):
(WebCore::add):

• css/parser/CSSParserContext.h:
• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeGridLineNames):
(WebCore::consumeSubgridNameRepeatFunction):
(WebCore::consumeGridTrackList):
(WebCore::consumeGridTemplatesRowsOrColumns):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::consumeGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSPropertyParser::consumeGridTemplateShorthand):
(WebCore::CSSPropertyParser::consumeGridShorthand):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::gridSubgridRows const):
(WebCore::RenderStyle::gridSubgridColumns const):
(WebCore::RenderStyle::setGridSubgridRows):
(WebCore::RenderStyle::setGridSubgridColumns):

• rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

• rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator== const):

• style/StyleBuilderConverter.h:

(WebCore::Style::createGridLineNamesList):
(WebCore::Style::BuilderConverter::createGridTrackList):

• style/StyleBuilderCustom.h:

Source/WTF:

Adds a new experimental preference for subgrid support, disabled by default.

• Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

Updated TestExpectations to list all the subgrid tests individually, now that we pass a few.

• TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid-expected.txt: Removed.

5:09 PM Changeset in webkit [289721] by beidson@apple.com

• 72 edits
  1 copy
  6 adds in trunk

Implement ServiceWorkerRegistration.showNotification()
​https://bugs.webkit.org/show_bug.cgi?id=22722

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/notifications/idlharness.https.any-expected.txt:
• web-platform-tests/notifications/idlharness.https.any.serviceworker-expected.txt:

Source/WebCore:

Tests: http/tests/workers/service/shownotification-allowed.html

http/tests/workers/service/shownotification-denied.html

Previously ServiceWorkerRegistration.showNotification(), NotificationEvent, and onnotificationclicked/closed were stubbed out.
This patch hooks them up.

It's largely a plumbing patch, doing the following:

• Making sure calls to-and-from NotificationClient happen on the correct threads
• Making sure Notification related classes now understand how to cope with not having an associated WebPage(Proxy)
• Making sure all of the relevant IPC machinery is in place to handle pageless notifications
• Adds super useful logging

• Modules/notifications/Notification.cpp:

(WebCore::Notification::show):
(WebCore::Notification::dispatchShowEvent):
(WebCore::Notification::dispatchClickEvent):
(WebCore::Notification::dispatchCloseEvent):

• Modules/notifications/NotificationEvent.cpp:

(WebCore::NotificationEvent::create):
(WebCore::NotificationEvent::NotificationEvent):

• Modules/notifications/NotificationEvent.h:

• dom/EmptyScriptExecutionContext.h:
• dom/ScriptExecutionContext.h:

• page/RuntimeEnabledFeatures.h:

• workers/WorkerOrWorkletGlobalScope.h:

• workers/WorkerThread.h:

• workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope):
(WebCore::ServiceWorkerGlobalScope::postTaskToFireNotificationEvent):

• workers/service/ServiceWorkerGlobalScope.h:

• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::showNotification):
(WebCore::ServiceWorkerRegistration::getNotifications):

• workers/service/context/SWContextManager.h:

• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::start):

• workers/service/context/ServiceWorkerThreadProxy.h:

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::registrationStoreDatabaseFailedToOpen):
(WebCore::SWServer::addRegistrationFromStore):
(WebCore::SWServer::addRegistration):
(WebCore::SWServer::processPushMessage):

Source/WebKit:

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::getPendingPushMessages):
(WebKit::NetworkProcess::processPushMessage):

• NetworkProcess/Notifications/NetworkNotificationManager.cpp:

(WebKit::NetworkNotificationManager::getPendingPushMessages):
(WebKit::NetworkNotificationManager::showNotification):

• NetworkProcess/Notifications/NetworkNotificationManager.h:

• Platform/Logging.h:

• Shared/Notifications/NotificationManagerMessageHandler.h:
• Shared/Notifications/NotificationManagerMessageHandler.messages.in:

• Sources.txt:

• UIProcess/API/APINotificationProvider.h:

(API::NotificationProvider::show):

• UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerGetSharedServiceWorkerNotificationManager):

• UIProcess/API/C/WKNotificationManager.h:

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore _sharedServiceWorkerNotificationManager]):
(-[WKWebsiteDataStore _getPendingPushMessages:]):
(-[WKWebsiteDataStore _processPushMessage:completionHandler:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

• UIProcess/API/glib/WebKitNotificationProvider.cpp:

(WebKitNotificationProvider::show):

• UIProcess/API/glib/WebKitNotificationProvider.h:

• UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp: Added.

(WebKit::ServiceWorkerNotificationHandler::singleton):
(WebKit::ServiceWorkerNotificationHandler::ServiceWorkerNotificationHandler):
(WebKit::ServiceWorkerNotificationHandler::requestSystemNotificationPermission):
(WebKit::ServiceWorkerNotificationHandler::dataStoreForNotificationID):
(WebKit::ServiceWorkerNotificationHandler::showNotification):
(WebKit::ServiceWorkerNotificationHandler::cancelNotification):
(WebKit::ServiceWorkerNotificationHandler::clearNotifications):
(WebKit::ServiceWorkerNotificationHandler::didDestroyNotification):

• UIProcess/Notifications/ServiceWorkerNotificationHandler.h: Copied from Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h.

• UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

• UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):
(WebKit::WebNotification::sourceConnection const):

• UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:

(WebKit::WebNotificationManagerMessageHandler::showNotification):

• UIProcess/Notifications/WebNotificationManagerMessageHandler.h:

• UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::sharedServiceWorkerManager):
(WebKit::identifierForPagePointer):
(WebKit::WebNotificationManagerProxy::show):
(WebKit::WebNotificationManagerProxy::cancel):
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
(WebKit::WebNotificationManagerProxy::clearNotifications):
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::dispatchDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):
(WebKit::pageIDsMatch): Deleted.
(WebKit::pageAndNotificationIDsMatch): Deleted.

• UIProcess/Notifications/WebNotificationManagerProxy.h:

• UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::show):

• UIProcess/Notifications/WebNotificationProvider.h:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

• UIProcess/WebPageProxy.h:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess):

• UIProcess/WebProcessPool.h:

(WebKit::WebProcessPool::sendToAllRemoteWorkerProcesses):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disableRemoteWorkers):
(WebKit::WebProcessProxy::enableRemoteWorkers):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::showServiceWorkerNotification):
(WebKit::WebsiteDataStore::cancelServiceWorkerNotification):
(WebKit::WebsiteDataStore::clearServiceWorkerNotification):
(WebKit::WebsiteDataStore::didDestroyServiceWorkerNotification):

• UIProcess/WebsiteData/WebsiteDataStore.h:

• WebKit.xcodeproj/project.pbxproj:

• WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::sendNotificationMessage):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):
(WebKit::sendNotificationMessage): Deleted.

• WebProcess/Notifications/WebNotificationManager.h:

• WebProcess/Storage/WebSWContextManagerConnection.h:

• WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::WebNotificationClient):
(WebKit::WebNotificationClient::~WebNotificationClient):
(WebKit::WebNotificationClient::show):
(WebKit::WebNotificationClient::cancel):
(WebKit::WebNotificationClient::notificationObjectDestroyed):
(WebKit::WebNotificationClient::notificationControllerDestroyed):
(WebKit::WebNotificationClient::requestPermission):
(WebKit::WebNotificationClient::checkPermission):

Source/WTF:

• Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

To reliably support testing ServiceWorker notifications, TestRunner needed to actually grant/deny permissions in the UI process
like a proper NotificationProvider would.

It also has to understand showing a notification without an associated WKPage.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::postSimulateWebNotificationClickForServiceWorkerNotifications):

• WebKitTestRunner/InjectedBundle/InjectedBundle.h:

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::grantWebNotificationPermission):
(WTR::TestRunner::denyWebNotificationPermission):
(WTR::TestRunner::simulateWebNotificationClickForServiceWorkerNotifications):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):
(WTR::TestController::grantNotificationPermission):
(WTR::TestController::denyNotificationPermission):
(WTR::TestController::simulateWebNotificationClickForServiceWorkerNotifications):

• WebKitTestRunner/TestController.h:

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

• WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::WebNotificationProvider):
(WTR::notificationManagerForPage):
(WTR::WebNotificationProvider::showWebNotification):
(WTR::WebNotificationProvider::addNotificationManager):
(WTR::WebNotificationProvider::notificationPermissions):
(WTR::WebNotificationProvider::setPermission):
(WTR::WebNotificationProvider::simulateWebNotificationClickForServiceWorkerNotifications):
(WTR::WebNotificationProvider::reset):

• WebKitTestRunner/WebNotificationProvider.h:

LayoutTests:

Test a ServiceWorker showing a notification both when it's allowed and when it's denied.

• http/tests/workers/service/resources/shownotification-worker.js: Added.

(async const):
(let.messageClients):
(async event):

• http/tests/workers/service/shownotification-allowed-expected.txt: Added.
• http/tests/workers/service/shownotification-allowed.html: Added.
• http/tests/workers/service/shownotification-denied-expected.txt: Added.
• http/tests/workers/service/shownotification-denied.html: Added.

1:07 PM Changeset in webkit [289720] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

Unreviewed, fix the internal macOS build

Add some missing WebCore namespaces (which are presumably now necessary due to changes in unified source
groupings).

• UIProcess/mac/DisplayCaptureSessionManager.mm:

(WebKit::alertForWindowSelection):
(WebKit::DisplayCaptureSessionManager::deviceSelectedForTesting):
(WebKit::DisplayCaptureSessionManager::showWindowPicker):
(WebKit::DisplayCaptureSessionManager::showScreenPicker):
(WebKit::DisplayCaptureSessionManager::isAvailable):

12:48 PM Changeset in webkit [289719] by Andres Gonzalez

• 5 edits in trunk/LayoutTests

Fix for accessibility/image-map1.html in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=236565
<rdar://problem/88874467>

Reviewed by Darin Adler.

Don't use focus manipulation just to retrieve an accessible element,
instead use accessibilityElementById. Updated the outdated code in this
test.

• accessibility/image-map1-expected.txt:
• accessibility/image-map1.html:
• platform/glib/accessibility/image-map1-expected.txt:
• platform/win/accessibility/image-map1-expected.txt:

12:26 PM Changeset in webkit [289718] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Add comment on how StructureMemoryManager grows the free list when there are no free blocks.
​https://bugs.webkit.org/show_bug.cgi?id=236568

Reviewed by Saam Barati.

Also, use uint8_t* rather than rely on the fact that sizeof(MarkedBlock) == 1.

• heap/StructureAlignedMemoryAllocator.cpp:

(JSC::StructureMemoryManager::tryMallocStructureBlock):

12:22 PM Changeset in webkit [289717] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make StructureMemoryManager alignment assert a RELEASE_ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=236567

Reviewed by Saam Barati.

Also, check the structure base pointer is non-zero.

• heap/StructureAlignedMemoryAllocator.cpp:

(JSC::StructureMemoryManager::StructureMemoryManager):

10:06 AM Changeset in webkit [289716] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Not all atomic inline level boxes need ideographic baseline when in vertical writing mode
​https://bugs.webkit.org/show_bug.cgi?id=236556

Reviewed by Antti Koivisto.

Replaced boxes and orthogonal inline-block containers should use ideographic type of baseline.
(e.g. can't sync baselines coming from orthogonal inline-blocks.)

• layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::LineBoxBuilder::adjustIdeographicBaselineIfApplicable):

9:53 AM Changeset in webkit [289715] by Lauro Moura

• 2 edits in trunk/Source/WebCore

Unreviewed, gtk buildfix after r289706
​https://bugs.webkit.org/show_bug.cgi?id=236563

• Headers.cmake:

9:41 AM Changeset in webkit [289714] by Alan Bujtas

• 5 edits in trunk

[LFC][IFC] Take writing direction into account when setting up the root geometry
​https://bugs.webkit.org/show_bug.cgi?id=236548

Reviewed by Antti Koivisto.

Source/WebCore:

This fixes cases when the root block container itself is in a vertical writing context.
<div style="writing-mode: vertical-rl">

<div style="display: inline-block; padding: 10px">vertical content</div>

</div>

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateFormattingRootGeometryAndInvalidate):

LayoutTests:

• platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt: Progressions.
• platform/mac/fast/text/international/bidi-override-expected.txt:

8:00 AM Changeset in webkit [289713] by Andres Gonzalez

• 6 edits
  2 adds in trunk

Expose the correct role, subrole and role description properties for the <dialog> element.
​https://bugs.webkit.org/show_bug.cgi?id=236359

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/dialog-properties.html

Elements with role="dialog" are exposed to accessibility clients with
role AXGroup, subrole AXApplicationDialog and role description
"web dialog". This patch implements this behavior for the <dialog>
element.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::defaultObjectInclusion const):

LayoutTests:

Tests that these AX properties have the expected values both when the
dialog is shown modal or modeless.

• accessibility/dialog-properties-expected.txt: Added.
• accessibility/dialog-properties.html: Added.

6:56 AM Changeset in webkit [289712] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][Integration] Introduce Box::ElementType::IntegrationInlineBlock
​https://bugs.webkit.org/show_bug.cgi?id=236554

Reviewed by Antti Koivisto.

This is in preparation for adding vertical baseline support for inline-block boxes with alphabetic baseline.
The integration tree builder constructs Replaced layout boxes for both inline-block and replaced types.
In LineBoxBuilder we need to be able to tell whether a particular inline level box is really a replaced
box or just an inline-block in order to assign the correct type of baseline (alphabetic/ideographic).

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::BoxTree):
(WebCore::LayoutIntegration::BoxTree::buildTree):

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::Box): Let's use the ElementType for the integration root too.

• layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isIntegrationBlockContainer const):
(WebCore::Layout::Box::isIntegrationInlineBlock const):
(WebCore::Layout::Box::setIsAnonymous):
(WebCore::Layout::Box::setIsIntegrationBlockContainer): Deleted.

6:55 AM Changeset in webkit [289711] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Pass in the correct LineDirectionMode value to RenderBoxModelObject::baselinePosition
​https://bugs.webkit.org/show_bug.cgi?id=236552

Reviewed by Antti Koivisto.

This is when setting up the BoxGeometry for the atomic inline level boxes.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):

6:53 AM Changeset in webkit [289710] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Add missing bidi vertical adjustment when writing mode is not horizontal
​https://bugs.webkit.org/show_bug.cgi?id=236551

Reviewed by Antti Koivisto.

Last 2 missing vertical adjustments.

• layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

6:48 AM Changeset in webkit [289709] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Baseline value is always logical
​https://bugs.webkit.org/show_bug.cgi?id=236549

Reviewed by Antti Koivisto.

Callers expect the baseline value to be always logical.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):

6:39 AM Changeset in webkit [289708] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, fix build when ATSPI is disabled

• platform/graphics/PlatformDisplay.cpp: The ATK code also makes use of GUniqueOutPtr, so

include the corresponding header.

6:38 AM Changeset in webkit [289707] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Take writing mode value into account setting vertical margin
​https://bugs.webkit.org/show_bug.cgi?id=236538

Reviewed by Antti Koivisto.

Line layout works with logical values.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::horizontalLogicalMargin):
(WebCore::LayoutIntegration::verticalLogicalMargin):
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::updateInlineBoxDimensions):
(WebCore::LayoutIntegration::logicalMargin): Deleted.

4:21 AM Changeset in webkit [289706] by Antti Koivisto

• 10 edits
  1 add in trunk/Source/WebCore

[CSS Container Queries] Add separate ContainerQuery and FilteredContainerQuery types
​https://bugs.webkit.org/show_bug.cgi?id=236515

Reviewed by Alan Bujtas.

ContainerQuery is just a type alias to MediaQuerySet for now.
FilteredContainerQuery is a ContainerQuery plus name filter (type filter coming later).

• WebCore.xcodeproj/project.pbxproj:
• css/ContainerQuery.h: Added.

Move to a file of its own.

• css/StyleRule.cpp:

(WebCore::StyleRuleContainer::StyleRuleContainer):
(WebCore::StyleRuleContainer::create):

• css/StyleRule.h:
• style/ContainerQueryEvaluator.cpp:

(WebCore::Style::ContainerQueryEvaluator::evaluate const):

• style/ContainerQueryEvaluator.h:
• style/ElementRuleCollector.cpp:

(WebCore::Style::ElementRuleCollector::containerQueryMatches):

• style/ElementRuleCollector.h:
• style/RuleSet.h:

(WebCore::Style::RuleSet::containerQueryFor const):

• style/RuleSetBuilder.cpp:

(WebCore::Style::RuleSetBuilder::addChildRules):