⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 25, 2022:

10:26 PM Changeset in webkit [291933] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Simplify / Optimize JSNodeOwner::isReachableFromOpaqueRoots()
​https://bugs.webkit.org/show_bug.cgi?id=238380

Reviewed by Geoffrey Garen.

Drop checks specific to HTMLAudioElement and HTMLImageElement from
JSNodeOwner::isReachableFromOpaqueRoots() so that other Node wrappers
that are not audio or image elements do not have to pay the cost.

In the HTMLAudioElement case, HTMLAudioElement already subclasses HTMLMediaElement which
is an ActiveDOMObject and HTMLMediaElement::virtualHasPendingActivity() already takes
care of keeping the JS wrapper alive is there is audio playing.

For HTMLImageElement, I made it subclass ActiveDOMObject so that the JSHTMLImageElement
wrapper is now calling HTMLImageElement::hasPendingActivity() instead of every JS Node
wrapper via JSNodeOwner::isReachableFromOpaqueRoots().

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::create):
(WebCore::HTMLImageElement::createForLegacyFactoryFunction):
(WebCore::HTMLImageElement::activeDOMObjectName const):
(WebCore::HTMLImageElement::virtualHasPendingActivity const):
(WebCore::HTMLImageElement::hasPendingActivity const): Deleted.

  • html/HTMLImageElement.h:
  • html/HTMLImageElement.idl:
  • html/ImageDocument.cpp:

(WebCore::ImageDocumentElement::create):

9:30 PM Changeset in webkit [291932] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Clean up DataIC polymorphic call code for OptimizingCallLinkInfo
​https://bugs.webkit.org/show_bug.cgi?id=238395

Reviewed by Saam Barati.

When using DataIC, return address is already appropriate in non-tail call case
in polymorphic call stub code. This patch cleans up the code to align it to
DataIC BaselineCallLinkInfo.

  • bytecode/Repatch.cpp:

(JSC::linkPolymorphicCall):

8:29 PM Changeset in webkit [291931] by Simon Fraser
  • 2 edits in trunk/Source/WebKit

Temporarily disable assertion in MessageReceiveQueueMap::addImpl()
​https://bugs.webkit.org/show_bug.cgi?id=238397

Unreviewed followup: similarly change the assertion in remove() into a log.

  • Platform/IPC/MessageReceiveQueueMap.cpp:

(IPC::MessageReceiveQueueMap::remove):

8:05 PM Changeset in webkit [291930] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Unreviewed, reverting r291884.
​https://bugs.webkit.org/show_bug.cgi?id=238405

Broke the internal iOS build

Reverted changeset:

"Add Captive Portal alert to WKWebView"
​https://bugs.webkit.org/show_bug.cgi?id=238326
​https://commits.webkit.org/r291884

7:03 PM Changeset in webkit [291929] by Simon Fraser
  • 2 edits in trunk/Source/WebKit

Temporarily disable assertion in MessageReceiveQueueMap::addImpl()
​https://bugs.webkit.org/show_bug.cgi?id=238397

Reviewed by Wenson Hsieh.

Enabling DOM Rendering in the GPU Process has exposed an issue (webkit.org/b/237674, webkit.org/b/238391).
Temporarily convert this assertion to logging to reduce test failures.

  • Platform/IPC/MessageReceiveQueueMap.cpp:

(IPC::MessageReceiveQueueMap::addImpl):

6:58 PM Changeset in webkit [291928] by Alan Coon
  • 301 edits
    8 adds
    4 deletes in branches/safari-613-branch/Source/ThirdParty/ANGLE

Apply patch. rdar://problem/90639134

6:57 PM Changeset in webkit [291927] by Alan Coon
  • 2 edits in branches/safari-613-branch/Source/ThirdParty/ANGLE

Apply patch. rdar://problem/89963372

6:57 PM Changeset in webkit [291926] by Alan Coon
  • 487 edits
    1 copy
    3 moves
    17 adds
    18 deletes in branches/safari-613-branch/Source/ThirdParty/ANGLE

Apply patch. rdar://problem/88464021

6:52 PM Changeset in webkit [291925] by Alan Coon
  • 12 edits in branches/safari-613-branch

Revert r285998. rdar://problem/85612240

6:51 PM Changeset in webkit [291924] by Alan Coon
  • 2 edits in branches/safari-613-branch/Source/WebKit

Cherry-pick r291057. rdar://problem/89291566

File System Access: disallows names that are not permitted by underlying file system
​https://bugs.webkit.org/show_bug.cgi?id=237635
rdar://89291566

We use FileSystem::fileSystemRepresentation to convert input name to a name that is permitted in current file
system. This patch makes File System Access API to throw error if the input name does not match the converted
name.

Reviewed by Youenn Fablet.

  • NetworkProcess/storage/FileSystemStorageHandle.cpp: (WebKit::isValidFileName): (WebKit::FileSystemStorageHandle::requestCreateHandle): (WebKit::FileSystemStorageHandle::removeEntry): (WebKit::FileSystemStorageHandle::move):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291923] by Alan Coon
  • 45 edits
    2 adds in branches/safari-613-branch

Cherry-pick r290985. rdar://problem/78421282

Add a preference to mute video capture in case audio capture gets interrupted
​https://bugs.webkit.org/show_bug.cgi?id=237524
<rdar://78421282>

Reviewed by Eric Carlson.

Source/WebCore:

In case we detect that a microphone track source gets muted due to interruption, we mute
capture video tracks based if allowed by the new MuteCameraOnMicrophoneInterruptionEnabled setting.

Add support for mock microphone interruption and remove previous in process internals API.

Test: fast/mediastream/media-stream-video-track-interrupted-from-audio.html

  • Modules/mediastream/MediaStreamTrack.cpp:
  • Modules/mediastream/MediaStreamTrack.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:
  • platform/mediastream/mac/CoreAudioCaptureSource.h:
  • platform/mock/MockRealtimeAudioSource.cpp: (WebCore::MockRealtimeAudioSource::setIsInterrupted):
  • platform/mock/MockRealtimeAudioSource.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp: (WebCore::MockRealtimeMediaSourceCenter::setMockCaptureDevicesInterrupted): (WebCore::MockRealtimeMediaSourceCenter::setMockCameraIsInterrupted): Deleted.
  • platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit:

Add support for interrupt mock microphone devices.
Send to WebProcess sources whether sources are interrupted each time the source muted value changes.
Store that value in remote sources.

  • GPUProcess/GPUProcess.cpp:
  • GPUProcess/GPUProcess.h:
  • GPUProcess/GPUProcess.messages.in:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
  • UIProcess/GPU/GPUProcessProxy.cpp:
  • UIProcess/GPU/GPUProcessProxy.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/cocoa/RemoteRealtimeAudioSource.h:
  • WebProcess/cocoa/RemoteRealtimeDisplaySource.h:
  • WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
  • WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
  • WebProcess/cocoa/RemoteRealtimeVideoSource.h:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:
  • WebProcess/cocoa/UserMediaCaptureManager.h:
  • WebProcess/cocoa/UserMediaCaptureManager.messages.in:

Source/WTF:

  • Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

Add support for interrupt mock microphone devices.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

LayoutTests:

  • fast/mediastream/media-stream-video-track-interrupted-from-audio-expected.txt: Added.
  • fast/mediastream/media-stream-video-track-interrupted-from-audio.html: Added.
  • fast/mediastream/media-stream-video-track-interrupted.html: Migrated to testRunner API.
  • fast/mediastream/track-ended-while-muted.html:
  • platform/glib/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291922] by Alan Coon
  • 4 edits in branches/safari-613-branch

Cherry-pick r290978. rdar://problem/89901536

Add early return for empty path in makeAllDirectories
​https://bugs.webkit.org/show_bug.cgi?id=237540
rdar://89901536

Reviewed by Chris Dumez.

Source/WTF:

  • wtf/posix/FileSystemPOSIX.cpp: (WTF::FileSystemImpl::makeAllDirectories):

Tools:

  • TestWebKitAPI/Tests/WTF/FileSystem.cpp: (TestWebKitAPI::TEST_F):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291921] by Alan Coon
  • 5 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r290837. rdar://problem/80407863

[Cocoa] Crash in MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL
​https://bugs.webkit.org/show_bug.cgi?id=237456
rdar://80407863

Reviewed by Jer Noble.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::enableInheritURIQueryComponent const): Create and use a static, never destroyed, AtomString instead of creating one every time a AVURLAsset is created. New method used by both AVF media players.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::MediaPlayerPrivateAVFoundationCF::createAVAssetForURL): Call enableInheritURIQueryComponent.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291920] by Alan Coon
  • 4 edits
    2 adds in branches/safari-613-branch/LayoutTests

Cherry-pick r290745. rdar://problem/80335706

[Cocoa] The behavior of navigator-language-ru changed in Monterey / iOS 15
​https://bugs.webkit.org/show_bug.cgi?id=237384
<rdar://problem/80335706>

Unreviewed test gardening.

Add a new test for the new behavior, but keep the old one too for older OSes.

  • fast/text/international/system-language/navigator-language/navigator-language-ru-2-expected.txt: Added.
  • fast/text/international/system-language/navigator-language/navigator-language-ru-2.html: Added.
  • platform/ios-14/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291919] by Alan Coon
  • 10 edits in branches/safari-613-branch

Cherry-pick r290564. rdar://problem/89524668

Force -webkit-user-modify used style to readonly for inert nodes
​https://bugs.webkit.org/show_bug.cgi?id=237244

Reviewed by Darin Adler.

This disallows programmatic edition of contenteditable inert nodes. Edition via user-input is
already prevented by forcing pointer-events style to none.

We create a seperate effectiveUserModify, similar to effectiveUserSelect/effectivePointerEvents,
to avoid changing the computed style.

This behaviour also matches Blink & Gecko.

LayoutTests/imported/w3c:

  • web-platform-tests/inert/inert-and-contenteditable.tentative-expected.txt:

Source/WebCore:

Test: imported/w3c/web-platform-tests/inert/inert-and-contenteditable.tentative.html

  • dom/Node.cpp: (WebCore::computeEditabilityFromComputedStyle):
  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • rendering/EventRegion.cpp: (WebCore::EventRegion::unite):
  • rendering/RenderElement.cpp: (WebCore::RenderElement::styleWillChange):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::effectiveUserModify const):
  • style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291918] by Alan Coon
  • 15 edits in branches/safari-613-branch

Cherry-pick r290550. rdar://problem/88675827

Update CSP handling of javascript URLs
​https://bugs.webkit.org/show_bug.cgi?id=236351
<rdar://problem/88675827>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

  • web-platform-tests/content-security-policy/navigation/to-javascript-parent-initiated-parent-csp-disallow-expected.txt:
  • web-platform-tests/content-security-policy/navigation/to-javascript-url-script-src-expected.txt:

Source/WebCore:

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeJavaScriptURL):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::createWindow):
  • loader/SubframeLoader.cpp: (WebCore::FrameLoader::SubframeLoader::requestFrame):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation):
  • page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowJavaScriptURLs const):
  • page/csp/ContentSecurityPolicy.h:

LayoutTests:

  • TestExpectations:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-by-default-src-star-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291917] by Alan Coon
  • 32 edits in branches/safari-613-branch

Cherry-pick r290443. rdar://problem/89322580

Update CSP console logging
​https://bugs.webkit.org/show_bug.cgi?id=232216
<rdar://problem/89322580>

Reviewed by Brent Fulgham.

Source/WebCore:

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willSendRequestInternal): (WebCore::SubresourceLoader::originalHeaders const):
  • page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowResourceFromSource const): (WebCore::ContentSecurityPolicy::allowWorkerFromSource const): (WebCore::ContentSecurityPolicy::allowScriptFromSource const): (WebCore::ContentSecurityPolicy::allowStyleFromSource const):

Source/WebKit:

  • NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::check): (WebKit::NetworkLoadChecker::checkRedirection): (WebKit::NetworkLoadChecker::checkRequest): (WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy):
  • NetworkProcess/NetworkLoadChecker.h:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/audio-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/font-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/font-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/image-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/image-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-after-multiple-redirects-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/stylesheet-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/stylesheet-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/svg-font-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/svg-font-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/svg-image-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/svg-image-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/track-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/video-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/xsl-redirect-blocked-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291916] by Alan Coon
  • 4 edits in branches/safari-613-branch

Cherry-pick r290367. rdar://problem/88567612

Fix GPUP WebGL generator script wrt uninitialised sized span
​https://bugs.webkit.org/show_bug.cgi?id=235889

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-02-23
Reviewed by Antti Koivisto.
Source/WebKit:

Regenerated.

  • WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp: (WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):

Tools:

Fix the generator. The r290328 only edited the generated files.
Add a other hunk missing from r290175.

  • Scripts/generate-gpup-webgl:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291915] by Alan Coon
  • 14 edits in branches/safari-613-branch

Cherry-pick r288792. rdar://problem/88227274

CSP: Properly block image content in object elements
​https://bugs.webkit.org/show_bug.cgi?id=235837

Reviewed by Kate Cheney.

LayoutTests/imported/w3c:

Update expectations with more passes.

  • web-platform-tests/content-security-policy/object-src/object-src-url-blocked-expected.txt:
  • web-platform-tests/content-security-policy/object-src/object-src-url-embed-blocked-expected.txt:
  • web-platform-tests/content-security-policy/object-src/object-src-url-redirect-blocked.sub-expected.txt:

Source/WebCore:

When an image is loaded through an object element it now passes through
the object-src directive check as the spec documents:
​https://www.w3.org/TR/CSP3/#directive-object-src

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/ResourceLoaderOptions.h: (WebCore::ResourceLoaderOptions::loadedFromPluginElement): (WebCore::ResourceLoaderOptions::ResourceLoaderOptions): (WebCore::ResourceLoaderOptions::loadedFromOpaqueSource): Deleted.
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
  • page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowObjectFromSource const):
  • page/csp/ContentSecurityPolicy.h:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2-expected.txt:
  • http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked3-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@288792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [291914] by Alan Coon
  • 12 edits in branches/safari-613-branch/Source/WebKit

Revert r289292. rdar://problem/90113314

6:50 PM Changeset in webkit [291913] by Alan Coon
  • 14 edits
    2 adds in branches/safari-613-branch

Revert r290708. rdar://problem/90113314

6:46 PM Changeset in webkit [291912] by Alan Coon
  • 2 edits in branches/safari-613-branch/Source/JavaScriptCore

Cherry-pick r291891. rdar://problem/90838071

AI should not set the structure for ObjectCreate
​https://bugs.webkit.org/show_bug.cgi?id=238349

Patch by Justin Michaud <Justin Michaud> on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.

The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.

  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:45 PM Changeset in webkit [291911] by Nikos Mouchtaris
  • 6 edits
    2 adds in trunk

Incorrect handling of NaN inside calc() for top-level calculation
​https://bugs.webkit.org/show_bug.cgi?id=234176

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt: Added.
  • web-platform-tests/css/css-values/calc-infinity-nan-computed.html: Added.
  • web-platform-tests/css/css-values/round-function-expected.txt:
  • web-platform-tests/css/css-values/round-function.html:

Source/WebCore:

Add function to convert any top level NaN values to infinity values as per the spec.
This only affects the computed value of the calc expression, not its serialization.

Test: imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-computed.html

  • css/calc/CSSCalcOperationNode.cpp:

(WebCore::CSSCalcOperationNode::combineChildren):
(WebCore::convertToTopLevelValue):
(WebCore::CSSCalcOperationNode::evaluateOperator):

  • css/calc/CSSCalcOperationNode.h:
6:38 PM Changeset in webkit [291910] by Alan Coon
  • 9 edits in branches/safari-613-branch/Source

Versioning.

WebKit-7613.2.5

5:57 PM Changeset in webkit [291909] by sihui_liu@apple.com
  • 6 edits in trunk/Source/WebKit

Disable custom storage paths for IndexedDB and LocalStorage by default
​https://bugs.webkit.org/show_bug.cgi?id=236977

Reviewed by Geoffrey Garen.
<rdar://problem/89559929>

  • FeatureFlags/WebKit-appletvos.plist:
  • FeatureFlags/WebKit-ios.plist:
  • FeatureFlags/WebKit-macos.plist:
  • FeatureFlags/WebKit-watchos.plist:
  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultShouldUseCustomStoragePaths):

5:55 PM Changeset in webkit [291908] by Alan Coon
  • 1 copy in tags/Safari-613.2.4

Tag Safari-613.2.4.

5:53 PM Changeset in webkit [291907] by Said Abou-Hallawa
  • 5 edits in trunk/Source/WebKit

[GPU Process] [iOS] Enable GPU Process for DOM rendering on iOS
​https://bugs.webkit.org/show_bug.cgi?id=236508
rdar://83437844

Reviewed by Jon Lee.

  • FeatureFlags/WebKit-appletvos.plist:
  • FeatureFlags/WebKit-ios.plist:
  • FeatureFlags/WebKit-watchos.plist:
  • Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):

5:02 PM Changeset in webkit [291906] by Alan Coon
  • 1 copy in tags/Safari-613.1.17.1.13

Tag Safari-613.1.17.1.13.

5:02 PM Changeset in webkit [291905] by Alan Coon
  • 1 copy in tags/Safari-613.1.17.0.8

Tag Safari-613.1.17.0.8.

4:58 PM Changeset in webkit [291904] by achristensen@apple.com
  • 2 edits in branches/safari-613-branch/Source/WebKit

Cherry pick r289026
rdar://90860743

​http://trac.webkit.org/r289026 wasn't merged to the safari-613-branch, which caused excessive unnecessary logging.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

4:46 PM Changeset in webkit [291903] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r291745.
​https://bugs.webkit.org/show_bug.cgi?id=238399

JSC debug test failures

Reverted changeset:

"[JSC] Add DoNotHaveTagRegisters mode to unboxDouble"
​https://bugs.webkit.org/show_bug.cgi?id=238018
​https://commits.webkit.org/r291745

4:42 PM Changeset in webkit [291902] by Chris Dumez
  • 23 edits in trunk/Source

Use StringView::split() instead of String::split() in more places
​https://bugs.webkit.org/show_bug.cgi?id=238362

Reviewed by Geoffrey Garen.

Use StringView::split() instead of String::split() where suitable and more efficient.

Source/WebCore:

  • Modules/applepay/cocoa/PaymentContactCocoa.mm:

(WebCore::convert):

  • html/HTMLInputElement.cpp:

(WebCore::isValidMIMEType):
(WebCore::isValidFileExtension):
(WebCore::parseAcceptAttribute):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::compileShader):

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForPath):

  • page/WindowFeatures.cpp:

(WebCore::parseDisabledAdaptations):
(WebCore::parseDialogFeatures):
(WebCore::parseDialogFeaturesMap):

  • page/WindowFeatures.h:
  • platform/network/CacheValidation.cpp:

(WebCore::collectVaryingRequestHeadersInternal):

  • platform/network/HTTPParsers.cpp:

(WebCore::filenameFromHTTPContentDisposition):
(WebCore::parseXFrameOptionsHeader):

  • platform/network/HTTPParsers.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::isAttachmentWithFilename const):

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendOS2Table):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseOffsetValue):
(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::parseCondition):
(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::parseAttribute):

  • svg/animation/SVGSMILElement.h:

Source/WebKit:

  • Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::parseOSVersion):
(WebKit::populateSandboxInitializationParameters):

  • UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:

(WebKit::RemoteGraphicsContextGLProxy::initialize):

Source/WTF:

  • wtf/Assertions.cpp:
  • wtf/text/StringView.cpp:

(WTF::StringView::stripWhiteSpace const):

  • wtf/text/StringView.h:

(WTF::StringView::toDouble const):
(WTF::StringView::stripLeadingAndTrailingMatchedCharacters const):
(WTF::StringView::stripLeadingAndTrailingMatchedCharacters): Deleted.

4:14 PM Changeset in webkit [291901] by Alexander Mikhaylenko
  • 189 edits
    3 adds in trunk

[GTK][WPE] Update widget style to match libadwaita
​https://bugs.webkit.org/show_bug.cgi?id=235884

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Update Adwaita widgets style to be closer to their Libadwaita versions instead of GTK3.

  • Use new colors
  • Opacity for disabled states instead of separate colors
  • Translucent text selection, grey for inactive state
  • Translucent borders, so the widgets don't get blurry depending on the page background
  • Light borders for dark variant for visibility
  • Update sliders and progress bars, as they can't really work with translucent borders as is
  • Use grey selection for listboxes

Since text selection and accent are different colors now, move activeSelectionBackgroundColor()
etc out of ThemeAdwaita and expose a function for getting the accent color instead.

Update scrollbars to closely match libadwaita - update colors and dimensions, have a visible
trough in overlay mode. Reverse how borders are done - make sure the trough in regular and
overlay mode has the same size and draw borders around it rather than making borders a part
of the trough size.

  • platform/adwaita/ScrollbarThemeAdwaita.cpp:

(WebCore::ScrollbarThemeAdwaita::paint):
(WebCore::ScrollbarThemeAdwaita::paintScrollCorner):

  • platform/adwaita/ThemeAdwaita.cpp:

(WebCore::ThemeAdwaita::paintCheckbox):
(WebCore::ThemeAdwaita::paintRadio):
(WebCore::ThemeAdwaita::paintButton):
(WebCore::ThemeAdwaita::accentColor):
(WebCore::ThemeAdwaita::activeSelectionForegroundColor const): Deleted.
(WebCore::ThemeAdwaita::activeSelectionBackgroundColor const): Deleted.
(WebCore::ThemeAdwaita::inactiveSelectionForegroundColor const): Deleted.
(WebCore::ThemeAdwaita::inactiveSelectionBackgroundColor const): Deleted.

  • platform/adwaita/ThemeAdwaita.h:
  • rendering/RenderThemeAdwaita.cpp:

(WebCore::getAccentColor):
(WebCore::RenderThemeAdwaita::platformActiveSelectionBackgroundColor const):
(WebCore::RenderThemeAdwaita::platformInactiveSelectionBackgroundColor const):
(WebCore::RenderThemeAdwaita::platformActiveSelectionForegroundColor const):
(WebCore::RenderThemeAdwaita::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeAdwaita::platformActiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeAdwaita::platformInactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeAdwaita::platformActiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeAdwaita::platformInactiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeAdwaita::paintTextField):
(WebCore::RenderThemeAdwaita::paintProgressBar):
(WebCore::RenderThemeAdwaita::paintSliderTrack):
(WebCore::RenderThemeAdwaita::paintSliderThumb):

  • rendering/RenderThemeAdwaita.h:

LayoutTests:

Update test expectations to account for the changed widget and selection styles.

Remove [Pass] for text selection styles that was only set for glib/.

  • platform/glib/TestExpectations:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/gtk/css3/flexbox/button-expected.png:
  • platform/gtk/css3/flexbox/button-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.png:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.png:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.png:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4397952-expected.png:
  • platform/gtk/editing/selection/4397952-expected.txt:
  • platform/gtk/editing/selection/5240265-expected.png:
  • platform/gtk/editing/selection/5240265-expected.txt:
  • platform/gtk/editing/selection/selection-button-text-expected.png:
  • platform/gtk/editing/selection/selection-button-text-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/float/float-avoidance-expected.txt:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/gtk/fast/box-sizing/percentage-height-expected.png:
  • platform/gtk/fast/box-sizing/percentage-height-expected.txt: Added.
  • platform/gtk/fast/css/continuationCrash-expected.png:
  • platform/gtk/fast/css/continuationCrash-expected.txt:
  • platform/gtk/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/gtk/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/gtk/fast/dynamic/positioned-movement-with-positioned-children-expected.png:
  • platform/gtk/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/basic-buttons-expected.png:
  • platform/gtk/fast/forms/basic-buttons-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/blankbuttons-expected.png:
  • platform/gtk/fast/forms/blankbuttons-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-align-expected.png:
  • platform/gtk/fast/forms/button-align-expected.txt:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.png:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/gtk/fast/forms/button-default-title-expected.png:
  • platform/gtk/fast/forms/button-default-title-expected.txt:
  • platform/gtk/fast/forms/button-generated-content-expected.png:
  • platform/gtk/fast/forms/button-generated-content-expected.txt:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.png:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/gtk/fast/forms/button-positioned-expected.png:
  • platform/gtk/fast/forms/button-positioned-expected.txt:
  • platform/gtk/fast/forms/button-sizes-expected.png:
  • platform/gtk/fast/forms/button-sizes-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.png:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/button-table-styles-expected.png:
  • platform/gtk/fast/forms/button-table-styles-expected.txt:
  • platform/gtk/fast/forms/button-text-transform-expected.png:
  • platform/gtk/fast/forms/button-text-transform-expected.txt:
  • platform/gtk/fast/forms/button-white-space-expected.png:
  • platform/gtk/fast/forms/button-white-space-expected.txt:
  • platform/gtk/fast/forms/control-clip-expected.png:
  • platform/gtk/fast/forms/control-clip-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/file/file-input-direction-expected.png:
  • platform/gtk/fast/forms/file/file-input-direction-expected.txt:
  • platform/gtk/fast/forms/file/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove3-expected.png:
  • platform/gtk/fast/forms/formmove3-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.png:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:
  • platform/gtk/fast/forms/input-first-letter-expected.png:
  • platform/gtk/fast/forms/input-first-letter-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.png:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/html/details-replace-summary-child-expected.png:
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.png:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.png:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/width100percent-button-expected.png:
  • platform/gtk/fast/replaced/width100percent-button-expected.txt:
  • platform/gtk/fast/table/append-cells2-expected.png:
  • platform/gtk/fast/table/append-cells2-expected.txt:
  • platform/gtk/fast/table/remove-td-display-none-expected.png:
  • platform/gtk/fast/table/remove-td-display-none-expected.txt:
  • platform/gtk/fast/text/international/hindi-spacing-expected.png:
  • platform/gtk/fast/text/international/hindi-spacing-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/svg/custom/foreign-object-skew-expected.png:
  • platform/gtk/svg/custom/foreign-object-skew-expected.txt: Added.
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51727-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug52505-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug52506-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug68912-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla/other/move_row-expected.png:
  • platform/gtk/tables/mozilla/other/move_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
3:55 PM Changeset in webkit [291900] by Elliott Williams
  • 2 edits in trunk/Source/WebKit

[Big Sur] WK2 failing to build with error: reference to 'WebDocumentView' is ambiguous
​https://bugs.webkit.org/show_bug.cgi?id=238384

Reviewed by Alexey Proskuryakov.

Build fix, see rdar://90844690.

Create forwarding headers in WebKit's temporary directory which cause imports of any
migrated header to be imported using WebKit's header map. For example,

#import <WebKit/WebDocument.h>
#import <WebKitLegacy/WebDocument.h>

...both resolve to the same header.

Also, clean up project file references to files which were deleted in r291809.

  • WebKit.xcodeproj/project.pbxproj:
3:53 PM Changeset in webkit [291899] by Adrian Perez de Castro
  • 1 copy in releases/WPE WebKit/webkit-2.36.0

WPE WebKit 2.36.0

3:52 PM Changeset in webkit [291898] by Adrian Perez de Castro
  • 4 edits in releases/WebKitGTK/webkit-2.36

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.0 release

.:

  • Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

  • wpe/NEWS: Add release notes for 2.36.0.
3:52 PM Changeset in webkit [291897] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.36/Tools

[WPE][GTK] Dist/distcheck targets fail due to Python error
​https://bugs.webkit.org/show_bug.cgi?id=238394

Unreviewed build fix.

  • Scripts/make-dist:

(Directory.list_files_in_version_control): Ensure that data read from pipes is converted to
strings by specifying text="ascii", as it seems safe to assume that files listed by Git will
not contain non-ASCII characters. While at it, make the function return a set to speed up
lookups.

3:25 PM Changeset in webkit [291896] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

FontCascade::widthForSimpleText needs the glyph only
​https://bugs.webkit.org/show_bug.cgi?id=238385

Reviewed by Antti Koivisto.

widthForSimpleText operates on primary font only so let's just call PrimaryFont.glyphForCharacter() directly.
(This should provide a slight perf gain on text heavy pages. e.g. wikipedia over 50 page loads ->

w/o: widthForSimpleText: 266286 calls, mean duration: 0.000201ms, total duration: 53.403753ms, max duration 0.016750ms

w: widthForSimpleText: 266274 calls, mean duration: 0.000176ms, total duration: 46.949579ms, max duration 0.016917ms)

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthForSimpleText const):

3:11 PM Changeset in webkit [291895] by Alan Coon
  • 2 edits in branches/safari-613.1.17.0-branch/Source/JavaScriptCore

Cherry-pick r291891. rdar://problem/90838071

AI should not set the structure for ObjectCreate
​https://bugs.webkit.org/show_bug.cgi?id=238349

Patch by Justin Michaud <Justin Michaud> on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.

The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.

  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:09 PM Changeset in webkit [291894] by Alan Coon
  • 9 edits in branches/safari-613.1.17.0-branch/Source

Versioning.

WebKit-7613.1.17.0.8

3:07 PM Changeset in webkit [291893] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, update DerivedSources-output.xcfilelist to fix build.

  • DerivedSources-output.xcfilelist:
3:05 PM Changeset in webkit [291892] by Alan Coon
  • 2 edits in branches/safari-613.1.17.1-branch/Source/JavaScriptCore

Cherry-pick r291891. rdar://problem/90838071

AI should not set the structure for ObjectCreate
​https://bugs.webkit.org/show_bug.cgi?id=238349

Patch by Justin Michaud <Justin Michaud> on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.

The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.

  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:51 PM Changeset in webkit [291891] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

AI should not set the structure for ObjectCreate
​https://bugs.webkit.org/show_bug.cgi?id=238349

Patch by Justin Michaud <Justin Michaud> on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.

The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

2:46 PM Changeset in webkit [291890] by mmaxfield@apple.com
  • 4 edits in trunk/Source/WebGPU

[WebGPU] Remove default: from switch statements, in favor of exhaustively listing all cases
​https://bugs.webkit.org/show_bug.cgi?id=238305

Reviewed by Darin Adler.

This will indicate places that need fixing when new values are added.

  • WebGPU/BindGroupLayout.mm:

(WebGPU::createArgumentDescriptor):

  • WebGPU/Buffer.mm:

(WebGPU::Buffer::mapAsync):

  • WebGPU/Instance.mm:

(WebGPU::sortedDevices):

  • WebGPU/Queue.mm:

(WebGPU::Queue::writeBuffer):

2:37 PM Changeset in webkit [291889] by Wenson Hsieh
  • 13 edits
    2 adds in trunk

Enable PGO when building for release and production
​https://bugs.webkit.org/show_bug.cgi?id=238119
rdar://90182309

Reviewed by Alexey Proskuryakov and Geoff Garen.

Source/JavaScriptCore:

See WebCore/ChangeLog for more information.

  • Configurations/Base.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

Attempt to re-land support for compiling against profiling data, after it was reverted due to the profiling data
files being too large. We mitigate this by instead storing sparse profdata files as compressed files in
WebKitAdditions through git lfs, such that they don't cause the repo to grow significantly each time we update
profiling data.

At build time, we then introduce new build phase scripts to the JavaScriptCore, WebCore and WebKit builds to
decompress their respective .profdata.compressed files into .profdata files in the build, using
compression_tool. We compile against these profdata files when building for release and production
configurations, via the -fprofile-instr-use flag.

In the case where the *.profdata.compressed files are non-existent or haven't been downloaded yet, we instead
fall back to using an empty profiling data file, but only on non-production builds; this allows us to continue
passing in the -fprofile-instr-use flag, without running into build failures.

Note that we intentionally require production builds to use the (real) profiling data, and explicitly fail the
build with a specific error message in the case where the profiles are missing.

Additionally, note that in order to check for and deal with the case where the *.profdata.compressed files are
only undownloaded git-lfs stubs, we not only check whether or not the profdata.compressed file exists, but
also whether or not the file size is at least an arbitrary cutoff of 4 KB (which should already be an order of
magnitude larger than the git-lfs stub). While mostly arbitrary, I chose this cutoff due to the fact that it's
very close to the size of the Empty.profdata placeholder file in Tools; in practice, we should expect the
profiles for WebKit, WebCore and JavaScriptCore to be much, much larger than this empty file.

  • Configurations/Base.xcconfig:
  • Configurations/WebCore.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

See WebCore/ChangeLog for more information.

  • Configurations/Base.xcconfig:
  • Configurations/BaseTarget.xcconfig:
  • WebKit.xcodeproj/project.pbxproj:

Tools:

Add an empty profiling data file that can be used as a fallback only for release (non-production) builds, when
the JavaScriptCore, WebCore or WebKit profiling data hasn't been locally downloaded.

  • Profiling/Empty.profdata: Added.
2:19 PM Changeset in webkit [291888] by youenn@apple.com
  • 19 edits
    3 adds in trunk

Add support for focused and visible ServiceWorkerWindowClient states
​https://bugs.webkit.org/show_bug.cgi?id=238372

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/clients-get.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/clients-matchall-exact-controller.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/clients-matchall.https-expected.txt:

Source/WebCore:

Add visible and focused to ServiceWorkerClientData.
In case document visibility or focused state changes, we push the corresponding ServiceWorkerClientData to network process.

Test: http/wpt/service-workers/client-properties.https.html

  • dom/Document.cpp:
  • dom/Document.h:
  • page/FocusController.cpp:
  • workers/service/ServiceWorkerClient.h:
  • workers/service/ServiceWorkerClientData.cpp:
  • workers/service/ServiceWorkerClientData.h:
  • workers/service/ServiceWorkerClients.cpp:
  • workers/service/ServiceWorkerWindowClient.cpp:
  • workers/service/ServiceWorkerWindowClient.h:

LayoutTests:

  • http/wpt/service-workers/client-properties-worker.js: Added.
  • http/wpt/service-workers/client-properties.https-expected.txt: Added.
  • http/wpt/service-workers/client-properties.https.html: Added.
2:02 PM Changeset in webkit [291887] by zhifei_fang@apple.com
  • 1 edit in trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py

[results-safari] filter out None in automatically generated bug title
​https://bugs.webkit.org/show_bug.cgi?id=238360
rdar://90809419

Reviewed by Dewei Zhu and Jonathan Bedard.

  • Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py:

(translate_selected_dots_to_bug_title_and_description):

Canonical link: ​https://commits.webkit.org/248886@main

1:54 PM Changeset in webkit [291886] by Devin Rousso
  • 15 edits
    1 copy
    3 adds in trunk

PointerEvent.movementX always 0 (breaks ​https://noisecraft.app/)
​https://bugs.webkit.org/show_bug.cgi?id=220194
<rdar://problem/72814440>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/pointerevents/pointerlock/pointerevent_movementxy_with_pointerlock-expected.txt:

This change causes the test to progress further than before, but there still appear to be
other issues elsewhere, so adjust the expected output to reflect that.

Source/WebCore:

Test: pointer-lock/pointermove-movement-delta.html

  • dom/PointerEvent.cpp:

(WebCore::PointerEvent::PointerEvent):
Also pass along the movement delta in the constructor that takes a MouseEvent.

  • dom/MouseEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
Require that all constructors that aren't invoked from JS always provide a movement delta.

  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX const):
(WebCore::MouseRelatedEvent::movementY const):
Expose these methods even when !ENABLE(POINTER_LOCK) so that they can be called without
the callsite having to also have a #if.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
Pass along the movement delta even when !ENABLE(POINTER_LOCK).

Tools:

  • DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController mouseMoveToX:Y:]):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseMoveTo):
On macOS, the screen's origin is the bottom-left corner, so we need to flip the deltaY.

LayoutTests:

  • pointer-lock/pointermove-movement-delta.html: Added.
  • pointer-lock/pointermove-movement-delta-expected.txt: Added.
  • pointer-lock/mouse-event-delivery-expected.txt: Added.

On macOS, the screen's origin is the bottom-left corner, so we need to flip the deltaY.

  • platform/gtk/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_movementxy_with_pointerlock-expected.txt: Added.

This change causes the test to progress further than before, but there still appear to be
other issues elsewhere, so adjust the expected output to reflect that.

  • platform/mac-wk1/TestExpectations:
1:51 PM Changeset in webkit [291885] by Simon Fraser
  • 2 edits in trunk/Source/WebKit

Add some generated sources to the WebKit project
​https://bugs.webkit.org/show_bug.cgi?id=238363

Reviewed by Alexey Proskuryakov.

There are many generated files which haven't been added to the project (they get built via
Sources.txt). Here, I add a few that I like to be able to find code in, particularly
MessageNames.h.

com.apple.WebKit.plugin-common.sb was deleted so is removed from the project.

  • WebKit.xcodeproj/project.pbxproj:
1:47 PM Changeset in webkit [291884] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Add Captive Portal alert to WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=238326

Patch by C Lopez <​clopez1@apple.com> on 2022-03-25
Reviewed by Geoffrey Garen.

When WkWebView on iOS is initialized, we call _presentCaptivePortalModeAlertIfNeeded which checks whether an alert needs to be presented or not.

  • UIProcess/API/ios/WKWebViewIOS.h:
  • UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _presentCaptivePortalModeAlertIfNeeded]):
(-[WKWebView didMoveToWindow]):

1:32 PM Changeset in webkit [291883] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop duplicate isFiringEventListeners check in Node wrappers' isReachableFromOpaqueRoots()
​https://bugs.webkit.org/show_bug.cgi?id=238376

Reviewed by Geoffrey Garen.

Drop duplicate isFiringEventListeners check in Node wrappers' isReachableFromOpaqueRoots().
Those wrappers already call JSNodeOwner::isReachableFromOpaqueRoots() which already takes care
of checking the isFiringEventListeners flag.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

1:16 PM Changeset in webkit [291882] by J Pascoe
  • 8 edits in trunk

[WebAuthn] Maintain last modification time separate from last used time for platform credentials
​https://bugs.webkit.org/show_bug.cgi?id=238293
rdar://90655676

Reviewed by Brent Fulgham.

This patch splits a key returned from [_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials...],
_WKLocalAuthenticatorCredentialLastModificationDateKey, which previously signified the last time a
credential was modified or used in an assertion, to just the last time the credential was modified.

A new key, _WKLocalAuthenticatorCredentialLastUsedDateKey represents the old definition, the last
time a key was used or modified.

Source/WebCore:

  • Modules/webauthn/WebAuthenticationConstants.h:

Source/WebKit:

  • UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
  • UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(getAllLocalAuthenticatorCredentialsImpl):
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithGroupAndID:credential:username:]):

  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):

Tools:

Updated API test to verify differences between _WKLocalAuthenticatorCredentialLastModificationDateKey
and _WKLocalAuthenticatorCredentialLastModificationDateKey.

  • TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

1:07 PM Changeset in webkit [291881] by Said Abou-Hallawa
  • 2 edits in trunk/Source/WebKit

[GPU Process] RemoteRenderingBackend::stopListeningForIPC() should not change the RemoteResourceCache on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=238298
rdar://90731372

Reviewed by Simon Fraser.

To release the RemoteResourceCache and the rendering resource request on
the WorkQueue thread, RemoteRenderingBackend::stopListeningForIPC() dispatches
an empty lambda to its WorkQueue but m_renderingResourcesRequest and
m_remoteResourceCache are captured by-move to initializers to this lambda.

But this means m_remoteResourceCache is changed on the main thread while
the WorkQueue thread may be accessing it to get a cached remote resource.
The EWS crashes showed that, RemoteRenderingBackend::stopListeningForIPC()
on the main thread is waiting its WorkQueue to stop and complete all its
work including the dispatched empty lambda. And the WorkQueue thread is
getting wrong resource counters from the RemoteResourceCache. This would
happen if the HashMaps of RemoteResourceCache were emptied on the main
thread while the counters had outdated values.

To fix this thread safety issue, the RemoteResourceCache should not ever
be changed on the main thread. Since capturing by-move is kind of change,
we will capture m_renderingResourcesRequest and m_remoteResourceCache by
reference and we let the dispatched lambda explicitly releases them on
the WorkQueue thread.

  • GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::stopListeningForIPC):

12:34 PM Changeset in webkit [291880] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[macOS][WP] Remove unused sandbox extension rule
​https://bugs.webkit.org/show_bug.cgi?id=238377

Reviewed by Geoffrey Garen.

Remove unused sandbox extension rule for RootDomainUserClient.

  • WebProcess/com.apple.WebProcess.sb.in:
12:20 PM Changeset in webkit [291879] by Russell Epstein
  • 1 copy in tags/Safari-614.1.5.18

Tag Safari-614.1.5.18.

12:19 PM Changeset in webkit [291878] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[TextureMapper] Implement GraphicsContextGLTextureMapperANGLE::prepareForDisplay()
​https://bugs.webkit.org/show_bug.cgi?id=238322

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2022-03-25
Reviewed by Darin Adler.

Use GraphicsContextGLTextureMapperANGLE::prepareForDisplay() to handle
buffer/texture preparation during the composition state flush instead of
doing it in the platform layer integration class.

The virtual GraphicsContextGL::prepareForDisplay() method is called
during the composition state flush on every context-backed canvas that
was changed since the previous flush. It's the most optimal location to
handle content display preparation, and it simplifies the actual display
through the TextureMapper facilities. It's a simple matter of ensuring
a current context and invoking texture preparation.

In Nicosia::GCGLANGLELayer::swapBuffersIfNeeded(), there's no need to
bother with the state of layer composition, everything is already set
to be wrapped into a buffer and pushed into the composition engine.

Similarly in TextureMapperGCGLPlatformLayer::paintToTextureMapper(),
the texture is already prepared and can be painted immediately, with
no further need for GL context switching.

GraphicsContextGLANGLE::prepareTexture() is not really used anymore
so it can be removed, and prepareTextureImpl() can use that name.
The method is still virtual so that GraphicsContextGLTextureMapperANGLE
can provide a more focused override, but GraphicsContextGLCocoa should
at some point also use its own implementation, at which point the
method could just be rolled into each class's prepareForDisplay().

No new tests, covered by existing tests.

  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::prepareTexture):
(WebCore::GraphicsContextGLANGLE::prepareTextureImpl): Deleted.

  • platform/graphics/angle/GraphicsContextGLANGLE.h:
  • platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLCocoa::prepareForDisplay):

  • platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:

(Nicosia::GCGLANGLELayer::swapBuffersIfNeeded):

  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:

Remove unused prepareTextureImpl() method declaration.

  • platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLTextureMapperANGLE::prepareTexture):
(WebCore::GraphicsContextGLTextureMapperANGLE::prepareForDisplay):
(WebCore::GraphicsContextGLTextureMapperANGLE::prepareTextureImpl): Deleted.

  • platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:
  • platform/graphics/texmap/TextureMapperGCGLPlatformLayer.cpp:

(WebCore::TextureMapperGCGLPlatformLayer::paintToTextureMapper):

12:18 PM Changeset in webkit [291877] by Russell Epstein
  • 2 edits in branches/safari-614.1.7-branch/Source/WebKit

Cherry-pick r291869. rdar://problem/90848250

Unreviewed, fix the internal iOS build after r291814
rdar://90848250

Removed extraneous double quote (") in com.apple.WebKit.WebContent.sb.in.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:15 PM Changeset in webkit [291876] by Russell Epstein
  • 2 edits in branches/safari-614.1.5-branch/Source/WebKit

Cherry-pick r291869. rdar://problem/90848250

Unreviewed, fix the internal iOS build after r291814
rdar://90848250

Removed extraneous double quote (") in com.apple.WebKit.WebContent.sb.in.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:08 PM Changeset in webkit [291875] by ysuzuki@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

[JSC] Use Data CallIC in unlinked DFG
​https://bugs.webkit.org/show_bug.cgi?id=238176

Reviewed by Saam Barati.

This patch enables Data CallIC when Options::useDataICInOptimizingJIT() is true
to pave the way to introducing unlinked DFG.

The most complicated part is DFG tail call handling. We load CallLinkInfo in one
non-callee-save register, and we set up CallFrameShuffleData to keep this value
in the same register even after call frame shuffling for the tail call. This must
be non-callee-save register since callee-save registers are restored to values
of the one-level upper caller for the tail-call.

We also clean up CallLinkInfo code so that many functions work well with DataIC.
Currently, direct calls are not supported, and we will not emit direct calls when
unlinked DFG is used.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/CallLinkInfo.cpp:

(JSC::BaselineCallLinkInfo::initialize):
(JSC::OptimizingCallLinkInfo::emitFastPath):
(JSC::OptimizingCallLinkInfo::emitTailCallFastPath):
(JSC::OptimizingCallLinkInfo::slowPathStart):
(JSC::OptimizingCallLinkInfo::emitDirectFastPath):
(JSC::OptimizingCallLinkInfo::emitDirectTailCallFastPath):

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::isDataIC const):
(JSC::CallLinkInfo::useDataIC const):
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::setUsesDataICs): Deleted.

  • bytecode/Repatch.cpp:

(JSC::linkPolymorphicCall):

  • dfg/DFGCommonData.h:

(JSC::DFG::CommonData::addCallLinkInfo):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::prepareForTailCallSlow):

  • wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

12:00 PM Changeset in webkit [291874] by Russell Epstein
  • 1 copy in tags/Safari-614.1.5.5.3

Tag Safari-614.1.5.5.3.

11:59 AM Changeset in webkit [291873] by Russell Epstein
  • 2 edits in branches/safari-614.1.5.5-branch/Source/WebKit

Cherry-pick r291869. rdar://problem/90848250

Unreviewed, fix the internal iOS build after r291814
rdar://90848250

Removed extraneous double quote (") in com.apple.WebKit.WebContent.sb.in.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:54 AM Changeset in webkit [291872] by Russell Epstein
  • 9 edits in branches/safari-614.1.5.5-branch/Source

Versioning.

WebKit-7614.1.5.5.3

11:52 AM Changeset in webkit [291871] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused JITOperation, operationTryOSREnterAtCatch.
​https://bugs.webkit.org/show_bug.cgi?id=238379

Reviewed by Mark Lam.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
11:46 AM Changeset in webkit [291870] by Russell Epstein
  • 9 edits in branches/safari-614.1.5-branch/Source

Versioning.

WebKit-7614.1.5.18

11:39 AM Changeset in webkit [291869] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix the internal iOS build after r291814
rdar://90848250

Removed extraneous double quote (") in com.apple.WebKit.WebContent.sb.in.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
11:29 AM Changeset in webkit [291868] by graouts@webkit.org
  • 2 edits in trunk/Source/WTF

[web-animations] enable support for mutable timelines by default
​https://bugs.webkit.org/show_bug.cgi?id=237958
<rdar://problem/90370794>

Reviewed by Dean Jackson.

Both Chrome and Firefox have been shipping this feature for quite some time.
Our support for it is complete, we just need to turn it on by default.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
11:03 AM Changeset in webkit [291867] by commit-queue@webkit.org
  • 47 edits
    9 copies
    18 adds in trunk

Add css-typed-om color IDL skeletons
​https://bugs.webkit.org/show_bug.cgi?id=238208

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-03-25
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-typed-om/idlharness-expected.txt:
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssColorValue-expected.txt:
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL-expected.txt:
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRGB-expected.txt:

Source/WebCore:

This is an off-by-default experimental feature.
Covered by wpt tests.

  • DerivedSources-input.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • css/typedom/CSSKeywordValue.idl:
  • css/typedom/CSSNumericValue.h:
  • css/typedom/color/CSSColor.cpp: Added.

(WebCore::CSSColor::setColorSpace):
(WebCore::CSSColor::CSSColor):

  • css/typedom/color/CSSColor.h: Added.

(WebCore::CSSColor::create):
(WebCore::CSSColor::alpha const):
(WebCore::CSSColor::setAlpha):

  • css/typedom/color/CSSColor.idl:
  • css/typedom/color/CSSColorValue.h: Added.

(WebCore::CSSColorValue::colorSpace):
(WebCore::CSSColorValue::to):
(WebCore::CSSColorValue::parse):

  • css/typedom/color/CSSColorValue.idl:
  • css/typedom/color/CSSHSL.cpp: Added.

(WebCore::CSSHSL::CSSHSL):

  • css/typedom/color/CSSHSL.h: Added.

(WebCore::CSSHSL::create):
(WebCore::CSSHSL::h const):
(WebCore::CSSHSL::setH):
(WebCore::CSSHSL::s const):
(WebCore::CSSHSL::setS):
(WebCore::CSSHSL::l const):
(WebCore::CSSHSL::setL):
(WebCore::CSSHSL::alpha const):
(WebCore::CSSHSL::setAlpha):

  • css/typedom/color/CSSHSL.idl:
  • css/typedom/color/CSSHWB.cpp: Added.

(WebCore::CSSHWB::CSSHWB):

  • css/typedom/color/CSSHWB.h: Added.

(WebCore::CSSHWB::create):
(WebCore::CSSHWB::h const):
(WebCore::CSSHWB::setH):
(WebCore::CSSHWB::w const):
(WebCore::CSSHWB::setW):
(WebCore::CSSHWB::b const):
(WebCore::CSSHWB::setB):
(WebCore::CSSHWB::alpha const):
(WebCore::CSSHWB::setAlpha):

  • css/typedom/color/CSSHWB.idl:
  • css/typedom/color/CSSLCH.cpp: Added.

(WebCore::CSSLCH::CSSLCH):

  • css/typedom/color/CSSLCH.h: Added.

(WebCore::CSSLCH::create):
(WebCore::CSSLCH::l const):
(WebCore::CSSLCH::setL):
(WebCore::CSSLCH::c const):
(WebCore::CSSLCH::setC):
(WebCore::CSSLCH::h const):
(WebCore::CSSLCH::setH):
(WebCore::CSSLCH::alpha const):
(WebCore::CSSLCH::setAlpha):

  • css/typedom/color/CSSLCH.idl:
  • css/typedom/color/CSSLab.cpp: Added.

(WebCore::CSSLab::CSSLab):

  • css/typedom/color/CSSLab.h: Added.

(WebCore::CSSLab::create):
(WebCore::CSSLab::l const):
(WebCore::CSSLab::setL):
(WebCore::CSSLab::a const):
(WebCore::CSSLab::setA):
(WebCore::CSSLab::b const):
(WebCore::CSSLab::setB):
(WebCore::CSSLab::alpha const):
(WebCore::CSSLab::setAlpha):

  • css/typedom/color/CSSLab.idl:
  • css/typedom/color/CSSOKLCH.cpp: Added.

(WebCore::CSSOKLCH::CSSOKLCH):

  • css/typedom/color/CSSOKLCH.h: Added.

(WebCore::CSSOKLCH::create):
(WebCore::CSSOKLCH::l const):
(WebCore::CSSOKLCH::setL):
(WebCore::CSSOKLCH::c const):
(WebCore::CSSOKLCH::setC):
(WebCore::CSSOKLCH::h const):
(WebCore::CSSOKLCH::setH):
(WebCore::CSSOKLCH::alpha const):
(WebCore::CSSOKLCH::setAlpha):

  • css/typedom/color/CSSOKLCH.idl:
  • css/typedom/color/CSSOKLab.cpp: Added.

(WebCore::CSSOKLab::CSSOKLab):

  • css/typedom/color/CSSOKLab.h: Added.

(WebCore::CSSOKLab::create):
(WebCore::CSSOKLab::l const):
(WebCore::CSSOKLab::setL):
(WebCore::CSSOKLab::a const):
(WebCore::CSSOKLab::setA):
(WebCore::CSSOKLab::b const):
(WebCore::CSSOKLab::setB):
(WebCore::CSSOKLab::alpha const):
(WebCore::CSSOKLab::setAlpha):

  • css/typedom/color/CSSOKLab.idl:
  • css/typedom/color/CSSRGB.cpp: Added.

(WebCore::CSSRGB::CSSRGB):

  • css/typedom/color/CSSRGB.h: Added.

(WebCore::CSSRGB::create):
(WebCore::CSSRGB::r const):
(WebCore::CSSRGB::setR):
(WebCore::CSSRGB::g const):
(WebCore::CSSRGB::setG):
(WebCore::CSSRGB::b const):
(WebCore::CSSRGB::setB):
(WebCore::CSSRGB::alpha const):
(WebCore::CSSRGB::setAlpha):

  • css/typedom/color/CSSRGB.idl:
10:39 AM Changeset in webkit [291866] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Reduce EventListenerVector's minimum capacity from 16 to 2
​https://bugs.webkit.org/show_bug.cgi?id=238374

Reviewed by Geoffrey Garen.

Reduce EventListenerVector's minimum capacity from 16 to 2 to save memory and get a small speedup on Speedometer.
Very few event listeners are registered for a given type in the common case so eagerly allocating enough memory for 16 is wasteful.
This is a confirmed 0.4% progression on Speedometer according to A/B bots.

  • dom/EventListenerMap.h:
10:32 AM Changeset in webkit [291865] by Jonathan Bedard
  • 22 edits in trunk/Tools

[git-webkit] Handle no repository case
​https://bugs.webkit.org/show_bug.cgi?id=238383
<rdar://problem/90842476>

Reviewed by Aakash Jain.

  • Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py:

(main): Set repository to 'None' instead of raising an OSError.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/init.py:

(Canonicalize.main): If no repository is provided, exit the program.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:

(Checkout.main): Ditto.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:

(FilteredCommand.pager): Ditto.
(FilteredCommand.main): Ditto.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:

(Info.main): Ditto.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_git_lfs.py:

(InstallGitLFS.parser): configure depends on if a repository is provided.
(InstallGitLFS.main): Install git lfs when no repository is provided.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:

(Land.main): If no repository is provided, exit the program.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull.py:

(Pull.main): Ditto.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup_git_svn.py:

(SetupGitSvn.main): Ditto.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:

(TestBranch.test_basic_none):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/canonicalize_unittest.py:

(TestCanonicalize.test_invalid_svn): Renamed from test_invalid.
(TestCanonicalize.test_invalid_None):
(TestCanonicalize.test_invalid): Renamed to test_invalid_svn.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:

(TestCheckout.test_checkout_none):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:

(TestFind.test_none):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py:

(TestInstallGitLFS.test_no_repo):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:

(TestLand.test_none):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/log_unittest.py:
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_git_svn_unittest.py:

(TestSetupGitSvn.test_none):

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:

(TestSetup.test_none):

Canonical link: ​https://commits.webkit.org/248871@main

10:24 AM Changeset in webkit [291864] by Russell Epstein
  • 1 copy in tags/Safari-614.1.7.2

Tag Safari-614.1.7.2.

10:13 AM Changeset in webkit [291863] by Chris Dumez
  • 211 edits in trunk

Start preparing WebCore for making the String(const char*) constructor explicit
​https://bugs.webkit.org/show_bug.cgi?id=238336

Reviewed by Geoffrey Garen.

Start preparing WebCore for making the String(const char*) constructor explicit.
Making this constructor explicit helps catch at compile time cases where the ""_s
prefix is missing on String literals.

Source/JavaScriptCore:

  • API/JSValue.mm:

(createStructHandlerMap):
(handerForStructTag):

  • API/JSWrapperMap.mm:

(allocateConstructorForCustomClass):

  • inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

Source/WebCore:

  • Modules/applepay-ams-ui/ApplePayAMSUIPaymentHandler.cpp:

(WebCore::convertAndValidateApplePayAMSUIRequest):

  • Modules/applepay/ApplePayContactField.cpp:

(WebCore::convertAndValidate):

  • Modules/applepay/ApplePayMerchantCapability.cpp:

(WebCore::convertAndValidate):

  • Modules/applepay/ApplePayRequestBase.cpp:

(WebCore::convertAndValidate):

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::openPaymentSetup):
(WebCore::ApplePaySession::begin):

  • Modules/applepay/ApplePaySetup.cpp:

(WebCore::ApplePaySetup::begin):

  • Modules/applepay/PaymentInstallmentConfiguration.mm:

(WebCore::PaymentInstallmentConfiguration::create):

  • Modules/applepay/PaymentRequestValidator.mm:

(WebCore::PaymentRequestValidator::validateTotal):
(WebCore::validateCountryCode):
(WebCore::validateCurrencyCode):
(WebCore::validateMerchantCapabilities):
(WebCore::validateSupportedNetworks):
(WebCore::validateShippingMethod):

  • Modules/applepay/PaymentSession.cpp:

(WebCore::PaymentSession::canCreateSession):

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::convertAndValidateApplePayRequest):

  • Modules/applicationmanifest/ApplicationManifestParser.cpp:

(WebCore::ApplicationManifestParser::parseIcons):
(WebCore::ApplicationManifestParser::parseScope):

  • Modules/cache/WindowOrWorkerGlobalScopeCaches.cpp:
  • Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::sanitizeKeyids):

  • Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
(WebCore::validatePathIsExpectedType):

  • Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::packageFormData):

  • Modules/fetch/FetchHeaders.cpp:

(WebCore::fillHeaderMap):

  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::startLoadingBlobURL):

  • Modules/filesystemaccess/FileSystemFileHandle.cpp:

(WebCore::FileSystemFileHandle::getFile):
(WebCore::FileSystemFileHandle::createSyncAccessHandle):

  • Modules/filesystemaccess/FileSystemHandle.cpp:

(WebCore::FileSystemHandle::isSameEntry const):
(WebCore::FileSystemHandle::move):

  • Modules/indexeddb/IDBDatabaseIdentifier.h:
  • Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::encode const):
(WebCore::IDBKeyData::decode):

  • Modules/indexeddb/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::includes):

  • Modules/indexeddb/server/IDBSerialization.cpp:

(WebCore::serializeIDBKeyPath):
(WebCore::deserializeIDBKeyPath):

  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBServer::getOrigins const):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
(WebCore::IDBServer::removeAllDatabasesForFullOriginPath):
(WebCore::IDBServer::IDBServer::renameOrigin):
(WebCore::IDBServer::IDBServer::upgradeFilesIfNecessary):
(WebCore::IDBServer::IDBServer::upgradedDatabaseDirectory):

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::abortTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::commitTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::generateKeyNumber):

  • Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::v1RecordsTableSchema):
(WebCore::IDBServer::v1RecordsTableSchemaAlternate):
(WebCore::IDBServer::v2RecordsTableSchema):
(WebCore::IDBServer::v2RecordsTableSchemaAlternate):
(WebCore::IDBServer::v1IndexRecordsTableSchema):
(WebCore::IDBServer::v1IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::v2IndexRecordsTableSchema):
(WebCore::IDBServer::v2IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::SQLiteIDBBackingStore::encodeDatabaseName):
(WebCore::IDBServer::SQLiteIDBBackingStore::fullDatabasePathForDirectory):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndex):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAddAfterSpaceCheck):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::getAllRecords):
(WebCore::IDBServer::UniqueIDBDatabase::getCount):
(WebCore::IDBServer::UniqueIDBDatabase::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):

  • Modules/indexeddb/shared/IDBIndexInfo.cpp:

(WebCore::IDBIndexInfo::loggingString const):

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::layoutTraitsClassName const):

  • Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::create):

  • Modules/mediasource/MediaSource.cpp:

(WebCore::addVP9FullRangeVideoFlagToContentType):
(WebCore::MediaSource::isTypeSupported):

  • Modules/mediastream/MediaTrackConstraints.cpp:

(WebCore::set):
(WebCore::convertToInternalForm):

  • Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::iceServersFromConfiguration):
(WebCore::RTCPeerConnection::certificatesFromConfiguration):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):
(WebCore::RTCPeerConnection::chainOperation):

  • Modules/mediastream/RTCRtpSFrameTransformer.cpp:

(WebCore::RTCRtpSFrameTransformer::transform):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doCreateAnswer):

  • Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp:

(WebCore::toRtpCodecCapability):

  • Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::toException):
(WebCore::toRTCError):

  • Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm:

(WebCore::writeToTemporaryFile):

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::checkAndCanonicalizeDetails):
(WebCore::PaymentRequest::show):

  • Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:

(WebCore::HTMLVideoElementPictureInPicture::requestPictureInPicture):

  • Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::YouTubePluginReplacement::installReplacement):
(WebCore::processAndCreateYouTubeURL):

  • Modules/speech/SpeechRecognitionCaptureSourceImpl.cpp:

(WebCore::SpeechRecognitionCaptureSourceImpl::updateDataSource):
(WebCore::SpeechRecognitionCaptureSourceImpl::sourceStopped):
(WebCore::SpeechRecognitionCaptureSourceImpl::sourceMutedChanged):

  • Modules/speech/cocoa/WebSpeechRecognizerTaskMock.mm:

(-[WebSpeechRecognizerTaskMock audioSamplesAvailable:]):

  • Modules/storage/StorageManager.cpp:

(WebCore::connectionInfo):

  • Modules/web-locks/WebLockManager.cpp:

(WebCore::WebLockManager::signalToAbortTheRequest):

  • Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::setAutomationRate):

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::insertEvent):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::getFrequencyResponse):

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::create):
(WebCore::WaveShaperNode::setCurveForBindings):

  • Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinatorInternal::needsAppIdQuirks):

  • Modules/webauthn/WebAuthenticationUtils.cpp:

(WebCore::buildAttestationMap):

  • Modules/webauthn/fido/DeviceResponseConverter.cpp:

(fido::readCTAPMakeCredentialResponse):

  • Modules/webauthn/fido/Pin.cpp:

(fido::pin::KeyAgreementResponse::parseFromCOSE):
(fido::pin::TokenRequest::tryCreate):

  • Modules/webauthn/fido/U2fResponseConverter.cpp:

(fido::readU2fRegisterResponse):

  • Modules/webdatabase/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):

  • Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::runTransaction):

  • Modules/webdatabase/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::addAllowedFunctions):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::trackerDatabasePath const):
(WebCore::DatabaseTracker::openTrackerDatabase):

  • Modules/webdatabase/SQLStatement.cpp:

(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::setDatabaseDeletedError):
(WebCore::SQLStatement::setVersionMismatchedError):
(WebCore::SQLStatement::setFailureDueToQuota):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::callErrorCallbackDueToInterruption):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::postflightAndCommit):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::subprotocolSeparator):
(WebCore::WebSocket::close):
(WebCore::WebSocket::suspend):

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::inflate):

  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::processHeaderValue):

  • Modules/websockets/WebSocketFrame.cpp:

(WebCore::WebSocketFrame::parseFrame):

  • Modules/webxr/WebXRWebGLLayer.cpp:

(WebCore::createOpaqueFramebuffer):
(WebCore::WebXRWebGLLayer::create):

  • accessibility/AXImage.cpp:

(WebCore::AXImage::imageOverlayElements):

  • accessibility/AXLogger.cpp:

(WebCore::AXLogger::AXLogger):
(WebCore::AXLogger::log):
(WebCore::operator<<):

  • accessibility/AXLogger.h:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::isModalElement const):
(WebCore::createFromRenderer):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::textChanged):
(WebCore::AXObjectCache::handleMenuOpened):
(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::passwordNotificationPostTimerFired):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::selectedStateChanged):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::handleModalChange):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::updateIsolatedTree):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::readOnlyValue const):
(WebCore::AccessibilityObject::autoCompleteValue const):
(WebCore::AccessibilityObject::currentValue const):
(WebCore::AccessibilityObject::replaceTextInRange):
(WebCore::AccessibilityObject::computedRoleString const):
(WebCore::nodeHasPresentationRole):
(WebCore::AccessibilityObject::resolvedEditingStyles const):
(WebCore::Accessibility::isRadioButtonInDifferentAdhocGroup):
(WebCore::Accessibility::findMatchingObjects):

  • accessibility/AccessibilityObjectInterface.h:

(WebCore::accessibilityRoleToString):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderObjectIsObservable const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
(WebCore::AccessibilityRenderObject::liveRegionRelevant const):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored const):

  • accessibility/AccessibilityTree.cpp:

(WebCore::AccessibilityTree::nodeHasTreeItemChild const):
(WebCore::AccessibilityTree::isTreeValid const):

  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::classList const):

  • accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::AXIsolatedTree):
(WebCore::AXIsolatedTree::~AXIsolatedTree):
(WebCore::AXIsolatedTree::clear):
(WebCore::AXIsolatedTree::treeForID):
(WebCore::AXIsolatedTree::create):
(WebCore::AXIsolatedTree::removeTreeForPageID):
(WebCore::AXIsolatedTree::objectsForIDs const):
(WebCore::AXIsolatedTree::generateSubtree):
(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
(WebCore::AXIsolatedTree::updateNode):
(WebCore::AXIsolatedTree::updateNodeProperty):
(WebCore::AXIsolatedTree::updateChildren):
(WebCore::AXIsolatedTree::focusedNode):
(WebCore::AXIsolatedTree::rootNode):
(WebCore::AXIsolatedTree::setRootNode):
(WebCore::AXIsolatedTree::setFocusedNodeID):
(WebCore::AXIsolatedTree::updateLoadingProgress):
(WebCore::AXIsolatedTree::removeNode):
(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):
(WebCore::AXIsolatedTree::applyPendingChanges):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::subrolePlatformString const):
(WebCore::AccessibilityObject::rolePlatformDescription const):

  • animation/AnimationEffect.cpp:

(WebCore::AnimationEffect::getTiming const):

  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animate):

  • animation/EffectTiming.h:
  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::CSSPropertyIDToIDLAttributeName):
(WebCore::KeyframeEffect::getKeyframes):

  • bindings/js/GCController.cpp:

(WebCore::GCController::GCController):

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::upgradeElement):

  • bindings/js/JSDOMConvertNumbers.h:

(WebCore::Converter<IDLFloat>::convert):

  • bindings/js/JSExecStateInstrumentation.h:

(WebCore::JSExecState::instrumentFunction):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::callInWorld):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcArray::setValueAt const):
(JSC::Bindings::ObjcArray::valueAt const):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_object.cpp:

(JSC::Bindings::throwRuntimeObjectInvalidAccessError):

  • contentextensions/ContentExtensionActions.cpp:

(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::parse):
(WebCore::ContentExtensions::RedirectAction::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::QueryKeyValue::parse):

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getDomainList):
(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::loadAction):

  • contentextensions/SerializedNFA.cpp:

(WebCore::ContentExtensions::SerializedNFA::serialize):

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::URLFilterParser::statusString):

  • contentextensions/URLFilterParser.h:
  • crypto/SubtleCrypto.cpp:

(WebCore::SubtleCrypto::addAuthenticatedEncryptionWarningIfNecessary):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_CFB.h:
  • crypto/algorithms/CryptoAlgorithmAES_CTR.h:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmECDH.h:
  • crypto/algorithms/CryptoAlgorithmECDSA.h:
  • crypto/algorithms/CryptoAlgorithmHKDF.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmPBKDF2.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
  • crypto/algorithms/CryptoAlgorithmSHA1.h:
  • crypto/algorithms/CryptoAlgorithmSHA224.h:
  • crypto/algorithms/CryptoAlgorithmSHA256.h:
  • crypto/algorithms/CryptoAlgorithmSHA384.h:
  • crypto/algorithms/CryptoAlgorithmSHA512.h:
  • crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::exportJwk const):

  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::exportJwk const):

  • crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::exportJwk const):

  • crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::exportJwk const):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::isSupportedFormat const):

  • css/CSSGridTemplateAreasValue.cpp:

(WebCore::stringForPosition):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::unitTypeString):

  • css/CSSSubgridValue.cpp:

(WebCore::CSSSubgridValue::customCSSText const):

  • css/DOMCSSNamespace.cpp:

(WebCore::valueWithoutImportant):

  • css/DOMCSSRegisterCustomProperty.cpp:

(WebCore::DOMCSSRegisterCustomProperty::registerProperty):

  • css/DeprecatedCSSOMValue.cpp:

(WebCore::DeprecatedCSSOMValue::cssText const):

  • css/FontFace.cpp:

(WebCore::FontFace::unicodeRange const):

  • css/MediaQueryExpression.cpp:

(WebCore::MediaQueryExpression::serialize const):

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getLayeredShorthandValue const):
(WebCore::MutableStyleProperties::setCustomProperty):

  • css/makevalues.pl:
  • css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::skipUntilComma):
(WebCore::MediaQueryParser::parseInternal):

  • css/parser/SizesAttributeParser.cpp:

(WebCore::SizesAttributeParser::mediaConditionMatches):

  • css/typedom/CSSNumericFactory.h:
  • css/typedom/CSSNumericValue.cpp:

(WebCore::CSSNumericValue::multiplyInternal):
(WebCore::CSSNumericValue::to):
(WebCore::CSSNumericValue::parse):

  • css/typedom/CSSStyleValueFactory.cpp:

(WebCore::CSSStyleValueFactory::reifyValue):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::propertyValueForNode):
(HTMLConverter::_processElement):

  • editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForData):

  • loader/cocoa/BundleResourceLoader.mm:

(WebCore::BundleResourceLoader::loadResourceFromBundle):

  • loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):

  • page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::HistoricResourceUsageData::HistoricResourceUsageData):
(WebCore::drawCpuHistory):
(WebCore::drawGCHistory):
(WebCore::drawMemHistory):

  • page/cocoa/SettingsBaseCocoa.mm:

(WebCore::SettingsBase::initializeDefaultFontFamilies):

  • page/mac/PageMac.mm:

(WebCore::Page::platformInitialize):

  • platform/LocalizedStrings.cpp:

(WebCore::AXARIAContentGroupText):

  • platform/LocalizedStrings.h:
  • platform/Pasteboard.h:
  • platform/PasteboardCustomData.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo):

  • platform/cocoa/KeyEventCocoa.mm:

(WebCore::keyIdentifierForCharCode):

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::imageTypeToFakeFilename):
(WebCore::Pasteboard::read):

  • platform/cocoa/PasteboardCustomDataCocoa.mm:

(WebCore::PasteboardCustomData::cocoaType):

  • platform/graphics/FourCC.h:

(WTF::LogArgument<WebCore::FourCC>::toString):

  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::validateDepthStencil):

  • platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::parseKeySystem):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::storagePath const):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID):

  • platform/mac/DataDetectorHighlight.mm:

(WebCore::DataDetectorHighlight::fadeIn):
(WebCore::DataDetectorHighlight::fadeOut):

  • platform/mac/PasteboardMac.mm:
  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyIdentifierForKeyEvent):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):
(WebCore::createPasteboardItem):

  • platform/mac/StringUtilities.mm:

(WebCore::wildcardRegexPatternString):

  • platform/mac/ThreadCheck.mm:

(WebCoreReportThreadViolation):

  • platform/mac/UserAgentMac.mm:

(WebCore::standardUserAgentWithApplicationName):

  • platform/network/ResourceErrorBase.cpp:
  • platform/network/ResourceErrorBase.h:
  • platform/network/cocoa/RangeResponseGenerator.mm:

(WebCore::synthesizedResponseForRange):

  • rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):

  • rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGPathSegImpl.h:
  • svg/SVGRadialGradientElement.h:
  • svg/properties/SVGPropertyTraits.h:

(WebCore::SVGPropertyTraits<bool>::toString):

  • testing/MockContentFilterSettings.h:

(WebCore::MockContentFilterSettings::unblockURLHost):

  • xml/XPathValue.h:

(WebCore::XPath::Value::Value):

  • xml/XSLStyleSheet.h:

Source/WebGPU:

  • WGSL/Parser.cpp:

(WGSL::Parser<Lexer>::parseGlobalDecl):
(WGSL::Parser<Lexer>::parseAttribute):
(WGSL::Parser<Lexer>::parseTypeDecl):
(WGSL::Parser<Lexer>::parseStorageClass):
(WGSL::Parser<Lexer>::parseAccessMode):
(WGSL::Parser<Lexer>::parseStatement):
(WGSL::Parser<Lexer>::parsePrimaryExpression):
(WGSL::Parser<Lexer>::parseCoreLHSExpression):

  • WGSL/Token.cpp:

(WGSL::toString):

  • WebGPU/Adapter.mm:

(WebGPU::Adapter::requestDevice):

  • WebGPU/Buffer.mm:

(WebGPU::Buffer::mapAsync):
(WebGPU::Buffer::unmap):

  • WebGPU/CommandEncoder.mm:

(WebGPU::CommandEncoder::copyBufferToBuffer):
(WebGPU::CommandEncoder::clearBuffer):
(WebGPU::CommandEncoder::finish):

  • WebGPU/ComputePipeline.mm:

(WebGPU::createConstantValues):
(WebGPU::Device::createComputePipeline):

  • WebGPU/Queue.mm:

(WebGPU::Queue::submit):

  • WebGPU/Sampler.mm:

(WebGPU::Device::createSampler):

  • WebGPU/ShaderModule.mm:

(WebGPU::earlyCompileShaderModule):

Source/WebKit:

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setPromisedDataForImage):
(WebKit::WebViewImpl::requestDOMPasteAccess):

Source/WebKitLegacy/mac:

  • Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

Source/WTF:

  • wtf/text/TextStream.h:

(WTF::TextStream::dumpProperty):

Tools:

  • TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:

(TEST):

10:09 AM Changeset in webkit [291862] by Russell Epstein
  • 2 edits in branches/safari-614.1.7-branch/Source/WebKit

Cherry-pick r291828. rdar://problem/90794287

After r291814, we need to create the INSTALL_PATH for the iOS sandbox files
​https://bugs.webkit.org/show_bug.cgi?id=238351

Reviewed by Saam Barati.

We need to create the $(INSTALL_PATH) for the preprocessed iOS sandbox files.
Before r291814, the built-in Xcode copy step used ditto when copying the .sb
files thus creating $(INSTALL_PATH) and its intermediate directories.
That change set made it so that all WebKit iOS sandbox profile files are preprocessed
thus eliminating the Xcode copy step.

  • WebKit.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:09 AM Changeset in webkit [291861] by Russell Epstein
  • 10 edits
    4 moves in branches/safari-614.1.7-branch/Source/WebKit

Cherry-pick r291814. rdar://problem/90343926

Update Sandbox profiles for system content path
​https://bugs.webkit.org/show_bug.cgi?id=238255

Reviewed by Per Arne Vollan.

Updated WebKit sandbox profiles to include system content path rule files when building with the system content path.
Changed the iOS profiles to be preprocessed to make these changes.

  • DerivedSources-input.xcfilelist
  • DerivedSources-output.xcfilelist
  • DerivedSources.make:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.
  • Shared/Sandbox/preferences.sb:
  • WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:04 AM Changeset in webkit [291860] by Russell Epstein
  • 9 edits in branches/safari-614.1.7-branch/Source

Versioning.

WebKit-7614.1.7.2

9:58 AM Changeset in webkit [291859] by Russell Epstein
  • 1 copy in tags/Safari-614.1.7.1

Tag Safari-614.1.7.1.

9:58 AM Changeset in webkit [291858] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Unreviewed cleanup.

Fix some errors found by lint-test-expectations (which add noise to every test run).

  • platform/ios/TestExpectations:
  • platform/win/TestExpectations:
9:43 AM Changeset in webkit [291857] by Russell Epstein
  • 9 edits in branches/safari-614.1.7-branch/Source

Versioning.

WebKit-7614.1.7.1

9:28 AM Changeset in webkit [291856] by Diego Pino Garcia
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix non-unified build after r291779

  • wasm/WasmExceptionType.h:
9:07 AM Changeset in webkit [291855] by Tyler Wilcock
  • 3 edits in trunk/Source/WebCore

Include object IDs in logs and assert in AXIsolatedTree and WebAccessibilityObjectWrapperBase
​https://bugs.webkit.org/show_bug.cgi?id=238352

Reviewed by Chris Fleizach.

I've found this additional information to be useful in other branches I'm working on.

  • accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase detachIsolatedObject:]):

8:55 AM Changeset in webkit [291854] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix the internal iOS build after r291842
​https://bugs.webkit.org/show_bug.cgi?id=238344

Apply a similar adjustment to WKModelView.mm, as in ARKitInlinePreviewModelPlayerMac.mm, when generating a
usdz file path.

  • UIProcess/ios/WKModelView.mm:

(-[WKModelView createFileForModel:]):

8:52 AM Changeset in webkit [291853] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

media/auto-play-web-audio-in-about-blank-iframe.html is failing on EWS MacOS Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=238315

Reviewed by Eric Carlson.

Make sure to reset the state to foreground.
Speculative fix as I was not able to reproduce locally.

  • testing/Internals.cpp:
2:15 AM Changeset in webkit [291852] by commit-queue@webkit.org
  • 10 edits in trunk

Improve rebuilding of ruby subtrees
​https://bugs.webkit.org/show_bug.cgi?id=238365

Source/WebCore:

Patch by Frédéric Wang <​fwang@igalia.com> on 2022-03-25
Reviewed by Alan Bujtas.

Don't collapse generated Ruby subtree when tearing down children and take into account the
fact that anonymous before/after node can belong to a display: content child.

  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::destroyAndCleanUpAnonymousWrappers): Don't collapse.

  • rendering/updating/RenderTreeBuilderRuby.cpp:

(WebCore::lastRubyRun): Child can be also be an anonymous after content.
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForChild): When beforeChild is
an anonymous before/after, just fallback to appending to the last ruby run.

LayoutTests:

Patch by Frederic Wang <​fred.wang@free.fr> on 2022-03-25
Reviewed by Alan Bujtas.

Expectation for rubyDOM-remove-text2.html is updated now that we don't collapse anonymous
RenderRubyBase nodes.

  • platform/gtk/fast/ruby/rubyDOM-remove-text2-expected.txt: Updated.
  • platform/ios/fast/ruby/rubyDOM-remove-text2-expected.txt: Updated.
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt: Updated.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: Updated.
  • platform/wincairo/fast/ruby/rubyDOM-remove-text2-expected.txt: Updated.
  • platform/wpe/fast/ruby/rubyDOM-remove-text2-expected.txt: Updated.
1:54 AM Changeset in webkit [291851] by sihui_liu@apple.com
  • 22 edits in trunk

Introduce an SPI to get website data directory for origin and use it in API tests
​https://bugs.webkit.org/show_bug.cgi?id=238269

Reviewed by Alex Christensen.

Source/WebKit:

There are a few tests using hardcoded website data paths to check if files are correcly modified by API.
Everytime we migrate website data (for example, if we start using general storage directory for IndexedDB
storage), we need to update these tests with new paths, otherwise the tests will check the wrong paths. Let's
just add an SPI so these tests can get the paths in use dynamically, which would avoid test breakage when
we do website data migration.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::websiteDataOriginDirectoryForTesting):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/storage/NetworkStorageManager.cpp:

(WebKit::NetworkStorageManager::moveData):
(WebKit::NetworkStorageManager::getOriginDirectory):

  • NetworkProcess/storage/NetworkStorageManager.h:
  • NetworkProcess/storage/OriginStorageManager.cpp:

(WebKit::OriginStorageManager::StorageBucket::toStorageType const):
(WebKit::OriginStorageManager::StorageBucket::resolvedLocalStoragePath):
(WebKit::OriginStorageManager::StorageBucket::resolvedIDBStoragePath):
(WebKit::OriginStorageManager::StorageBucket::resolvedPath):
(WebKit::OriginStorageManager::resolvedPath):
(WebKit::OriginStorageManager::resolvedLocalStoragePath): Deleted.
(WebKit::OriginStorageManager::resolvedIDBStoragePath): Deleted.

  • NetworkProcess/storage/OriginStorageManager.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _originDirectoryForTesting:topOrigin:type:completionHandler:]):

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::websiteDataOriginDirectoryForTesting):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::originDirectoryForTesting):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:

(runMultipleIndicesTestWithDatabase):

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:

(runTest):
(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(runWebsiteDataStoreCustomPaths):

12:43 AM Changeset in webkit [291850] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WebCore

Mismatched forward declaration of GraphicsContextState
​https://bugs.webkit.org/show_bug.cgi?id=238359

Reviewed by Darin Adler.

Forward declaration should be for a class not a struct. Fixes a warning.

  • platform/graphics/cairo/CairoOperations.h:

Mar 24, 2022:

10:02 PM Changeset in webkit [291849] by don.olmstead@sony.com
  • 11 edits in trunk/Source

Non-unified build fixes, late March 2022 edition
​https://bugs.webkit.org/show_bug.cgi?id=238358

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

  • bytecode/ExitKind.cpp:
  • bytecode/ExitKind.h:
  • heap/RootMarkReason.cpp:
  • heap/RootMarkReason.h:
  • runtime/CallData.h:

Source/WebCore:

  • html/HTMLInputElement.cpp:

Source/WebKit:

  • GPUProcess/GPUProcess.cpp:
  • WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
9:21 PM Changeset in webkit [291848] by Chris Dumez
  • 7 edits in trunk/Source

String::split() should take in a StringView instead of a String
​https://bugs.webkit.org/show_bug.cgi?id=238355

Reviewed by Geoffrey Garen.

Source/WebCore:

  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::classList const):
Call the more efficient split(UChar) overload instead.

Source/WebKit:

  • UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp:

Optimize by calling StringView::split() instead of String::split().

Source/WTF:

String::split() should take in a StringView instead of a String, to avoid unnecessary construction
of Strings in some instances.

  • wtf/text/WTFString.cpp:

(WTF::String::splitInternal const):
(WTF::String::split const):
(WTF::String::splitAllowingEmptyEntries const):

  • wtf/text/WTFString.h:
9:14 PM Changeset in webkit [291847] by ysuzuki@apple.com
  • 1 edit
    1 add in trunk/JSTests

Add additional reported regression tests to ensure multiline token's column offset is reset
​https://bugs.webkit.org/show_bug.cgi?id=221548

Reviewed by Alexey Shvayka.

The bug is fixed and tested in ​https://github.com/WebKit/WebKit/commit/6d1e5d9498f24805988ad81ca3228588dd000a51.
But let's add reported regression tests to ensure that they will not reproduce.

  • stress/multiline-token-error-column.js: Added.

(shouldBe):
(throw.new.Error):

9:08 PM Changeset in webkit [291846] by mmaxfield@apple.com
  • 15 edits
    2 adds in trunk

[Cocoa] REGRESSION(r281291): When accessibility bold is enabled, font-family:system-ui is supposed to be bold
​https://bugs.webkit.org/show_bug.cgi?id=237817
<rdar://problem/88249241>

Reviewed by Alan Bujtas.

Source/WebCore:

Accessibility bold is supposed to cause the system font to be rendered as bold, even if the
value of the font-weight property is normal.

The way this is originally supposed to work is that, when accessibility bold is enabled and
software asks for the system font, the font reports to not be bold, but the metrics/contours
end up visually bold to the user. Font variations, however, are a lower-level interface to
the font, and don't abide by the facade. So, before r281291, we weren't applying font variations
to the system font, so the facade was maintained, but r281291 started applying variations to the
system font, thereby breaking this accessibility bold setting.

The solution is to re-implement accessibility bold when we apply font variations. At the point
where we apply the weight variation, we should determine if accessibility bold is in effect, and
if it is, artificially increase the weight of the created font according to the platform's
inflation amount. There are a few SPI functions which aid in this endeavor.

Test: fast/text/accessibility-bold.html

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::fontIsSystemFont):
(WebCore::normalizeGXWeight):
(WebCore::normalizeCTWeight):
(WebCore::denormalizeGXWeight):
(WebCore::denormalizeCTWeight):
(WebCore::overrideEnhanceTextLegibility):
(WebCore::setOverrideEnhanceTextLegibility):
(WebCore::shouldEnhanceTextLegibility):
(WebCore::preparePlatformFont):
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
(WebCore::FontCache::platformInit):
(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::normalizeWeight): Deleted.
(WebCore::denormalizeWeight): Deleted.

  • platform/graphics/cocoa/FontCacheCoreText.h:
  • testing/Internals.cpp:

(WebCore::Internals::setOverrideEnhanceTextLegibility):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebCore/PAL:

  • pal/spi/cf/CoreTextSPI.h:
  • pal/spi/cocoa/AccessibilitySupportSPI.h:

LayoutTests:

This test has <!-- webkit-test-runner [ runSingly=true ] --> so the testing
infrastructure for accessibility bold can be web-process-global.

  • fast/text/accessibility-bold-expected-mismatch.html: Added.
  • fast/text/accessibility-bold.html: Added.
  • platform/mac/TestExpectations: Because this test relies on a webkit-test-runner

header, skip it on WK1.

  • platform/ios/TestExpectations: Ditto.
  • platform/mac-wk2/TestExpectations: Mark as PASS.
  • platform/ios-wk2/TestExpectations: Ditto.
7:51 PM Changeset in webkit [291845] by Alan Coon
  • 9 edits in branches/safari-613.1.17.1-branch/Source

Versioning.

WebKit-7613.1.17.1.13

7:40 PM Changeset in webkit [291844] by Alan Coon
  • 1 copy in tags/Safari-613.1.17.1.12

Tag Safari-613.1.17.1.12.

7:07 PM Changeset in webkit [291843] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Require click-to-play for media in Captive Portals
​https://bugs.webkit.org/show_bug.cgi?id=238353
<rdar://90575996>

Reviewed by Chris Dumez.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::adjustSettingsForCaptivePortal): Disable auto-play for media for
Captive Portals.

7:05 PM Changeset in webkit [291842] by Chris Dumez
  • 31 edits in trunk

FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings
​https://bugs.webkit.org/show_bug.cgi?id=238344

Reviewed by Geoff Garen.

Source/JavaScriptCore:

  • jsc.cpp:

Source/WebCore:

  • Modules/indexeddb/IDBDatabaseIdentifier.cpp:

(WebCore::IDBDatabaseIdentifier::databaseDirectoryRelativeToRoot const):
(WebCore::IDBDatabaseIdentifier::databaseDirectoryRelativeToRoot):

  • Modules/indexeddb/IDBDatabaseIdentifier.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBServer::diskUsage):
(WebCore::IDBServer::IDBServer::upgradedDatabaseDirectory):

  • Modules/webdatabase/OriginLock.cpp:

(WebCore::lockFileNameForPath):

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):

  • platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::loadIndex):

Source/WebKit:

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):

  • NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:

(WebKit::PCM::Database::Database):

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::storagePath):
(WebKit::CacheStorage::Engine::initialize):

  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesListFilename):
(WebKit::CacheStorage::cachesOriginFilename):
(WebKit::CacheStorage::Caches::cachesSizeFilename):

  • NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::blobPathForHash const):

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::makeCachePath):

  • NetworkProcess/storage/IDBStorageManager.cpp:

(WebKit::IDBStorageManager::idbStorageOriginDirectory):

  • UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:

(WebKit::InspectorResourceURLSchemeHandler::platformStartTask):

Source/WebKitLegacy/mac:

  • Storage/WebDatabaseProvider.mm:

(WebDatabaseProvider::indexedDatabaseDirectoryPath):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WTF:

FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings, to avoid
unnecessary String constructor in many instances.

  • wtf/FileSystem.cpp:

(WTF::FileSystemImpl::pathByAppendingComponent):

  • wtf/FileSystem.h:
  • wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::pathByAppendingComponent):

Tools:

  • TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

6:03 PM Changeset in webkit [291841] by Nikos Mouchtaris
  • 5 edits in trunk

calc(): Handle finite value with infinite step in round()
​https://bugs.webkit.org/show_bug.cgi?id=238231

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-values/round-function-expected.txt:

Source/WebCore:

Add handling for finite value with infinite step in round().

  • css/calc/CSSCalcOperationNode.cpp:

(WebCore::CSSCalcOperationNode::evaluateOperator):

  • css/calc/CSSCalcPrimitiveValueNode.cpp:

(WebCore::CSSCalcPrimitiveValueNode::invert):

5:50 PM Changeset in webkit [291840] by Alan Coon
  • 1 edit in branches/safari-613-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm

Apply patch. rdar://problem/90792723

5:41 PM Changeset in webkit [291839] by Russell Epstein
  • 1 copy in tags/Safari-614.1.7

Tag Safari-614.1.7.

5:15 PM Changeset in webkit [291838] by Russell Epstein
  • 1 copy in tags/Safari-614.1.5.17

Tag Safari-614.1.5.17.

5:13 PM Changeset in webkit [291837] by Chris Dumez
  • 29 edits in trunk

String's startsWith() / endsWith() / replace() should take in a StringView instead of a String
​https://bugs.webkit.org/show_bug.cgi?id=238333

Reviewed by Geoff Garen.

Source/JavaScriptCore:

  • runtime/FileBasedFuzzerAgent.cpp:

(JSC::FileBasedFuzzerAgent::getPredictionInternal):

  • runtime/IntlRelativeTimeFormat.cpp:

(JSC::singularUnit):

  • runtime/TemporalObject.cpp:

(JSC::singularUnit):

Source/WebCore:

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::shouldIgnoreIceCandidate):

  • css/CSSImageValue.cpp:

(WebCore::ResolvedURL::isLocalURL const):

  • page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

  • page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::pathMatches const):

  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::getUnmangledInfoLog):

  • platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):

  • platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::supportsContainerType):
(WebCore::ImageDecoderGStreamer::canDecodeType):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::supportsType):

  • platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::checkVaryingsPacking const):

  • platform/network/ParsedRequestRange.cpp:

(WebCore::ParsedRequestRange::parse):

  • platform/network/curl/CookieJarDB.cpp:

(WebCore::checkSecureCookie):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::handleAcceptedCandidateWithSoftSpaces):

Source/WTF:

String's startsWith() / endsWith() / replace() should take in a StringView instead of a String,
to avoid unnecessary String creation in many instances.

  • wtf/text/AtomString.h:
  • wtf/text/StringCommon.h:

(WTF::startsWith): Deleted.
(WTF::startsWithIgnoringASCIICase): Deleted.
(WTF::endsWith): Deleted.
(WTF::endsWithIgnoringASCIICase): Deleted.

  • wtf/text/StringImpl.cpp:

(WTF::equalInner):
(WTF::StringImpl::startsWith const):
(WTF::StringImpl::startsWithIgnoringASCIICase const):
(WTF::StringImpl::hasInfixStartingAt const):
(WTF::StringImpl::endsWith):
(WTF::StringImpl::endsWithIgnoringASCIICase const):
(WTF::StringImpl::hasInfixEndingAt const):
(WTF::StringImpl::replace):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::startsWith const): Deleted.
(WTF::StringImpl::endsWith const): Deleted.

  • wtf/text/StringView.h:

(WTF::startsWith):
(WTF::startsWithIgnoringASCIICase):
(WTF::endsWith):
(WTF::endsWithIgnoringASCIICase):
(WTF::String::replace):
(WTF::String::startsWith const):
(WTF::String::startsWithIgnoringASCIICase const):
(WTF::String::endsWith const):
(WTF::String::endsWithIgnoringASCIICase const):
(WTF::String::hasInfixStartingAt const):
(WTF::String::hasInfixEndingAt const):
(WTF::AtomString::startsWith const):
(WTF::AtomString::startsWithIgnoringASCIICase const):
(WTF::AtomString::endsWith const):
(WTF::AtomString::endsWithIgnoringASCIICase const):

  • wtf/text/WTFString.h:
5:13 PM Changeset in webkit [291836] by Russell Epstein
  • 2 edits in branches/safari-614.1.5-branch/Source/WebKit

Cherry-pick r291828. rdar://problem/90794287

After r291814, we need to create the INSTALL_PATH for the iOS sandbox files
​https://bugs.webkit.org/show_bug.cgi?id=238351

Reviewed by Saam Barati.

We need to create the $(INSTALL_PATH) for the preprocessed iOS sandbox files.
Before r291814, the built-in Xcode copy step used ditto when copying the .sb
files thus creating $(INSTALL_PATH) and its intermediate directories.
That change set made it so that all WebKit iOS sandbox profile files are preprocessed
thus eliminating the Xcode copy step.

  • WebKit.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:08 PM Changeset in webkit [291835] by don.olmstead@sony.com
  • 6 edits in trunk/Source

[GLib] Add user directories to WTF::FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=238348

Reviewed by Adrian Perez de Castro.

Source/WebKit:

Use the new FileSystem APIs instead of calling glib directly.

  • UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::inspectorWebsiteDataStore):

  • UIProcess/glib/WebsiteDataStoreGLib.cpp:

(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

Source/WTF:

Add FileSystem::userCacheDirectory and FileSystem::userDataDirectory which call into
g_get_user_cache_dir and g_get_user_data_dir respectively.

  • wtf/FileSystem.h:
  • wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::userCacheDirectory):
(WTF::FileSystemImpl::userDataDirectory):

5:01 PM Changeset in webkit [291834] by Russell Epstein
  • 1 copy in tags/Safari-614.1.5.5.2

Tag Safari-614.1.5.5.2.

4:59 PM Changeset in webkit [291833] by Russell Epstein
  • 2 edits in branches/safari-614.1.5.5-branch/Source/WebKit

Cherry-pick r291828. rdar://problem/90794287

After r291814, we need to create the INSTALL_PATH for the iOS sandbox files
​https://bugs.webkit.org/show_bug.cgi?id=238351

Reviewed by Saam Barati.

We need to create the $(INSTALL_PATH) for the preprocessed iOS sandbox files.
Before r291814, the built-in Xcode copy step used ditto when copying the .sb
files thus creating $(INSTALL_PATH) and its intermediate directories.
That change set made it so that all WebKit iOS sandbox profile files are preprocessed
thus eliminating the Xcode copy step.

  • WebKit.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:57 PM Changeset in webkit [291832] by Devin Rousso
  • 6 edits in trunk/Source

[iOS] make WKMouseGestureRecognizer officially conform to _UIHoverEventRespondable
​https://bugs.webkit.org/show_bug.cgi?id=238242
<rdar://problem/88828903>

Reviewed by Tim Horton.

Source/WebKit:

  • UIProcess/ios/WKMouseGestureRecognizer.h:
  • UIProcess/ios/WKMouseGestureRecognizer.mm:
  • Platform/spi/ios/UIKitSPI.h:

Source/WTF:

  • wtf/PlatformHave.h:
4:56 PM Changeset in webkit [291831] by Russell Epstein
  • 9 edits in branches/safari-614.1.5.5-branch/Source

Versioning.

WebKit-7614.1.5.5.2

4:53 PM Changeset in webkit [291830] by Nikos Mouchtaris
  • 8 edits in trunk

Fix serialization of nan, infinity, -infinity for calc()
​https://bugs.webkit.org/show_bug.cgi?id=238288

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-values/calc-catch-divide-by-0-expected.txt:
  • web-platform-tests/css/css-values/calc-infinity-nan-serialize-angle-expected.txt:
  • web-platform-tests/css/css-values/calc-infinity-nan-serialize-length-expected.txt:
  • web-platform-tests/css/css-values/calc-infinity-nan-serialize-time-expected.txt:

Source/WebCore:

Update serializing of nan, infinity, -infinity to be in line with step 2 of:
​https://drafts.csswg.org/css-values/#calc-serialize.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberValue const):
(WebCore::CSSPrimitiveValue::formatIntegerValue const):

4:48 PM Changeset in webkit [291829] by Russell Epstein
  • 10 edits
    4 moves in branches/safari-614.1.5-branch/Source/WebKit

Cherry-pick r291814. rdar://problem/90343926

Update Sandbox profiles for system content path
​https://bugs.webkit.org/show_bug.cgi?id=238255

Reviewed by Per Arne Vollan.

Updated WebKit sandbox profiles to include system content path rule files when building with the system content path.
Changed the iOS profiles to be preprocessed to make these changes.

  • DerivedSources-input.xcfilelist
  • DerivedSources-output.xcfilelist
  • DerivedSources.make:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.
  • Shared/Sandbox/preferences.sb:
  • WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:38 PM Changeset in webkit [291828] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit

After r291814, we need to create the INSTALL_PATH for the iOS sandbox files
​https://bugs.webkit.org/show_bug.cgi?id=238351

Reviewed by Saam Barati.

We need to create the $(INSTALL_PATH) for the preprocessed iOS sandbox files.
Before r291814, the built-in Xcode copy step used ditto when copying the .sb
files thus creating $(INSTALL_PATH) and its intermediate directories.
That change set made it so that all WebKit iOS sandbox profile files are preprocessed
thus eliminating the Xcode copy step.

  • WebKit.xcodeproj/project.pbxproj:
4:38 PM Changeset in webkit [291827] by Russell Epstein
  • 1 copy in tags/Safari-614.1.5.5.1

Tag Safari-614.1.5.5.1.

4:37 PM Changeset in webkit [291826] by Russell Epstein
  • 10 edits
    4 moves in branches/safari-614.1.5.5-branch/Source/WebKit

Cherry-pick r291814. rdar://problem/90343926

Update Sandbox profiles for system content path
​https://bugs.webkit.org/show_bug.cgi?id=238255

Reviewed by Per Arne Vollan.

Updated WebKit sandbox profiles to include system content path rule files when building with the system content path.
Changed the iOS profiles to be preprocessed to make these changes.

  • DerivedSources-input.xcfilelist
  • DerivedSources-output.xcfilelist
  • DerivedSources.make:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.
  • Shared/Sandbox/preferences.sb:
  • WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:37 PM Changeset in webkit [291825] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] Set bug_title property appropriately
​https://bugs.webkit.org/show_bug.cgi?id=238342

Reviewed by Ryan Haddad.

  • CISupport/ews-build/steps.py:

(BugzillaMixin._is_bug_closed):

4:29 PM Changeset in webkit [291824] by Patrick Angle
  • 4 edits in trunk/Source/WebCore

Web Inspector: Blank inspector in a page with container queries
​https://bugs.webkit.org/show_bug.cgi?id=238338

Reviewed by Devin Rousso.

Because there is no CSSOM implementation for container queries, we are unable to inspect them currently.
However, we should be resilient to the absence of that implementation and expect that not all rules have a
matching CSSOM implementation, instead of just crashing when it happens. This patch only resolves crashes as the
result of the presence of container queries, and followup work will be done to actually plumb the correct
information to Web Inspector to show these rules.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::collectFlatRules):

  • inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::collectStyleSheets):

  • style/InspectorCSSOMWrappers.cpp:

(WebCore::Style::InspectorCSSOMWrappers::collect):

4:23 PM Changeset in webkit [291823] by Patrick Angle
  • 2 edits in trunk/Source/WebKit

REGRESSION(STP142): "A JavaScript exception occured: Can't find variable: utils" from SafariDriver
​https://bugs.webkit.org/show_bug.cgi?id=238335

Reviewed by Devin Rousso.

Following r289467, we can't just copy the WebDriver atom scripts to the build products, since they now need to
have utils.js in any script that uses the utils namespace. The WebKit.framework copy of these scripts are
later used while building safaridriver, so they need to include the scripts as well.

  • WebKit.xcodeproj/project.pbxproj:
4:22 PM Changeset in webkit [291822] by Russell Epstein
  • 9 edits in branches/safari-614.1.5.5-branch/Source

Versioning.

WebKit-7614.1.5.5.1

4:14 PM Changeset in webkit [291821] by pvollan@apple.com
  • 6 edits in trunk/Source/WebKit

REGRESSION(r286590): Links with URL schemes are not clickable in Mail
​https://bugs.webkit.org/show_bug.cgi?id=238262
<rdar://89145552>

Reviewed by Geoffrey Garen.

This feature requires access to the Launch Services daemon in Mail and other apps on iOS.
This patch is a partial revert of r286590.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::nonBrowserServices):
(WebKit::WebProcessPool::platformInitializeWebProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

4:09 PM Changeset in webkit [291820] by Russell Epstein
  • 1 copy in branches/safari-614.1.5.5-branch

New branch.

3:57 PM Changeset in webkit [291819] by Russell Epstein
  • 9 edits in branches/safari-614.1.5-branch/Source

Versioning.

WebKit-7614.1.5.17

3:43 PM Changeset in webkit [291818] by Brent Fulgham
  • 4 edits in trunk

Disable RTCRtpScriptTransform in CaptivePortal mode
​https://bugs.webkit.org/show_bug.cgi?id=238340
<rdar://87821636>

Reviewed by Chris Dumez.

Source/WebKit:

When displaying content in a captive portal, we should make sure we disable
WebRTCEncodedTransform.

Tests: TestWebKitAPI

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::adjustSettingsForCaptivePortal): Disable WebRTCEncodedTransform.

Tools:

Add a test that RTCRtpScriptTransform is properly disabled in
CaptivePortal mode.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3:27 PM Changeset in webkit [291817] by graouts@webkit.org
  • 15 edits
    3 adds in trunk

DOM GPUP: paintSystemPreviewBadge (AR QuickLook element badge)
​https://bugs.webkit.org/show_bug.cgi?id=238295
rdar://83580608

Reviewed by Dean Jackson.

Source/WebCore:

Add a new SystemImage subclass to deal with the ARKit badge, moving the custom drawing code under
RenderThemeIOS::paintSystemPreviewBadge() to ARKitBadgeSystemImage::draw().

To facilitate this, we must also have ARKitBadgeSystemImage wrap the input Image provided to
RenderThemeIOS::paintSystemPreviewBadge() so that the CoreImage filters are applied correctly.

Finally, we remove some use of using namespace WebCore in WebSpeechRecognizerTask and
WebSpeechRecognizerTaskMock since it caused some unified build failures.

  • Headers.cmake:
  • Modules/speech/cocoa/WebSpeechRecognizerTask.mm:

(-[WebSpeechRecognizerTaskImpl initWithIdentifier:locale:doMultipleRecognitions:reportInterimResults:maxAlternatives:delegateCallback:]):
(-[WebSpeechRecognizerTaskImpl callbackWithTranscriptions:isFinal:]):
(-[WebSpeechRecognizerTaskImpl sendSpeechStartIfNeeded]):
(-[WebSpeechRecognizerTaskImpl sendSpeechEndIfNeeded]):
(-[WebSpeechRecognizerTaskImpl sendEndIfNeeded]):
(-[WebSpeechRecognizerTaskImpl speechRecognizer:availabilityDidChange:]):
(-[WebSpeechRecognizerTaskImpl speechRecognitionTask:didFinishSuccessfully:]):
(-[WebSpeechRecognizerTask initWithIdentifier:locale:doMultipleRecognitions:reportInterimResults:maxAlternatives:delegateCallback:]):

  • Modules/speech/cocoa/WebSpeechRecognizerTaskMock.mm:

(-[WebSpeechRecognizerTaskMock initWithIdentifier:locale:doMultipleRecognitions:reportInterimResults:maxAlternatives:delegateCallback:]):
(-[WebSpeechRecognizerTaskMock audioSamplesAvailable:]):
(-[WebSpeechRecognizerTaskMock abort]):

  • Modules/system-preview/ARKitBadgeSystemImage.h: Added.

(WebCore::ARKitBadgeSystemImage::encode const):
(WebCore::ARKitBadgeSystemImage::decode):
(isType):

  • Modules/system-preview/ARKitBadgeSystemImage.mm: Added.

(WebCore::arKitBundle):
(WebCore::loadARKitPDFPage):
(WebCore::systemPreviewLogo):
(WebCore::ARKitBadgeSystemImage::draw const):

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/SystemImage.h:
  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawSystemImage):

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintSystemPreviewBadge):
(WebCore::arKitBundle): Deleted.
(WebCore::loadARKitPDFPage): Deleted.
(WebCore::systemPreviewLogo): Deleted.

Source/WebKit:

Make sure we restore the Image on the ARKitBadgeSystemImage before we attempt to draw it.

  • GPUProcess/graphics/RemoteDisplayListRecorder.cpp:

(WebKit::RemoteDisplayListRecorder::drawSystemImage):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Ref<SystemImage>>::encode):
(IPC::ArgumentCoder<Ref<SystemImage>>::decode):

LayoutTests:

The system-preview/badge.html test now passes reliably with DOM GPUP enabled,
which incidentally fixes bug 236922.

  • platform/ios-wk2/TestExpectations:
3:22 PM Changeset in webkit [291816] by Kate Cheney
  • 3 edits
    2 adds in trunk

REGRESSION (Safari 15.4): Nonce from link isn't used when loading style sheet
​https://bugs.webkit.org/show_bug.cgi?id=238014
<rdar://problem/90599352>

Reviewed by Brent Fulgham.

Source/WebCore:

In ​https://bugs.webkit.org/show_bug.cgi?id=179728 we implemented
nonce hiding from the DOM. It seems we missed once location
where we need to reference the element.nonce() instead of the
nonce attribute.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/stylesheet-allowed-with-nonce-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/stylesheet-allowed-with-nonce.py: Added.
2:55 PM WebKitGTK/2.36.x edited by Adrian Perez de Castro
(diff)
2:41 PM Changeset in webkit [291815] by ysuzuki@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] JSRemoteFunction thunk should materialize code-pointer
​https://bugs.webkit.org/show_bug.cgi?id=238313

Reviewed by Mark Lam.

When invoking a JSRemoteFunction, we must first wrap the arguments passed to it.
The wrapping operation may trigger a GC, and GC can jettison JIT code. As a result,
even though we know that the target JSFunction has JIT code that we want to execute,
the JIT code may be jettisoned (while wrapping the arguments for it) before we get
to the call. This resulted in occasional crashes on the JSTests/stress/shadow-realm-evaluate.js test.

This patch fixes this by doing a null check on the JIT code just before calling it,
and if null (i.e. the JIT code has been jettisoned), re-materializing the JIT code
first before making the call.

  • jit/JITOperations.cpp:

(JSC::JSC_DEFINE_JIT_OPERATION):

  • jit/JITOperations.h:
  • jit/ThunkGenerators.cpp:

(JSC::remoteFunctionCallGenerator):

2:39 PM Changeset in webkit [291814] by msaboff@apple.com
  • 10 edits
    4 moves in trunk/Source/WebKit

Update Sandbox profiles for system content path
​https://bugs.webkit.org/show_bug.cgi?id=238255

Reviewed by Per Arne Vollan.

Updated WebKit sandbox profiles to include system content path rule files when building with the system content path.
Changed the iOS profiles to be preprocessed to make these changes.

  • DerivedSources-input.xcfilelist
  • DerivedSources-output.xcfilelist
  • DerivedSources.make:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb: Removed.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: Copied from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.
  • Shared/Sandbox/preferences.sb:
  • WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/com.apple.WebProcess.sb.in:
1:59 PM WebKitGTK/2.36.x edited by Adrian Perez de Castro
(diff)
1:50 PM Changeset in webkit [291813] by Jean-Yves Avenard
  • 5 edits
    4 adds in trunk

Safari can't play video completely at bilibili.com
​https://bugs.webkit.org/show_bug.cgi?id=236440
rdar://88761053

Reviewed by Jer Noble.

Source/WebCore:

Video frames were incorrectly evicted during a call to appendBuffer
as the Source Buffer incorrectly assumed a discontinuity was present.

When appending data to a source buffer, the MSE specs describe a method
to detect discontinuities in the Coded Frame Processing algorithm
(​https://www.w3.org/TR/media-source/#sourcebuffer-coded-frame-processing)
step 6:
"

  • If last decode timestamp for track buffer is set and decode timestamp is less than last decode timestamp:

OR

  • If last decode timestamp for track buffer is set and the difference between decode timestamp and last decode timestamp is greater than 2 times last frame duration.

"
The issue being what defines the last frame duration.
Is it the frame last seen in the coded frame processing loop or the frame
whose presentation timestamp is just before the one we are currently
processing.

H264 and HEVC have a concept of b-frames: that is a frame that depends
on a future frame to be decoded.
Those frames are found in the container and can be identified by their
presentation timestamp higher than the frame following in decode order.
Those present a challenge as the frame prior the current one in
presentation order, may actually only be found several frames back in
decode order.
Bug 181891 attempted to fix a similar issue, and used the longest
"decode duration" as a workaround to detect discontinuity in the content.
It mentioned adopting the same technique as in Mozilla's MSE
implementation, but Mozilla also skip discontinuity detection within a
media segment (​https://www.w3.org/TR/media-source/#media-segment which for
fMP4 is a single moof box) an approach that can't be achieved with
CoreMedia's AVStreamDataParser.
As mentioned in bug 181891, CoreMedia ignore the decode timestamps' delta
and juggles with the sample's duration so that there's no discontinuity
in the demuxed samples' presentation time, causing false positive in the
gap detection algorithm.

Bilibili uses HEVC content, and uses an encoding that generate lots
of b-frames, with a very wide sliding window (seen up to 12 frames).
By using the longest frame duration found in either presentation or
decode duration as threshold to identify a discontinuity, we can
properly parse the content and not incorrectly evict appended frames.
(As a side note, the use of HEVC with B-Frames is peculiar as not all
hardware support it.)
It is difficult to identify here if the issue is within the bilibili's
content or CoreMedia's output, though the responsibility more than
likely lies with bilibili.

Test: media/media-source/media-mp4-hevc-bframes.html

  • platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::TrackBuffer::TrackBuffer):
(WebCore::SourceBufferPrivate::resetTrackBuffers):
(WebCore::SourceBufferPrivate::didReceiveSample):

  • platform/graphics/SourceBufferPrivate.h:

LayoutTests:

  • media/media-source/content/test-bframes-hevc-manifest.json: Added.
  • media/media-source/content/test-bframes-hevc.mp4: Added.
  • media/media-source/media-mp4-hevc-bframes-expected.txt: Added.
  • media/media-source/media-mp4-hevc-bframes.html: Added.
12:53 PM Changeset in webkit [291812] by Fujii Hironori
  • 2 edits in trunk/Source/WebKit

[WinCairo] WCTileGrid should create tiles only for the inside of layer area
​https://bugs.webkit.org/show_bug.cgi?id=238317

Reviewed by Don Olmstead.

The coverage rect returned by computeVisibleAndCoverageRect may be
bigger than the layer rect. Tiles should be paved only for the
intersection of the coverage rect and the layer rect.

  • WebProcess/WebPage/wc/WCTileGrid.cpp:

(WebKit::WCTileGrid::tileRectFromPixelRect): Take the intersection
with the layer rect. Return an empty rect if the intersection is
empty.

12:39 PM Changeset in webkit [291811] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Remove slow codepath matching arithmetics in FontCascade::widthForSimpleText
​https://bugs.webkit.org/show_bug.cgi?id=238306

Reviewed by Antti Koivisto.

By now if we measure some text using the fast codepath, we usually stay on this codepath for the rest
of the layout (i.e. preferred width computation uses the same fast codepath, and we also don't dynamically switch between modern and legacy).

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthForSimpleText const):

12:36 PM Changeset in webkit [291810] by pvollan@apple.com
  • 6 edits in trunk/Source/WebKit

[iOS] Disable unneeded code when content filtering is running in the Network process
​https://bugs.webkit.org/show_bug.cgi?id=238332

Reviewed by Geoffrey Garen.

  • Shared/Cocoa/LoadParametersCocoa.mm:

(WebKit::LoadParameters::platformEncode const):
(WebKit::LoadParameters::platformDecode):

  • Shared/LoadParameters.h:
  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::addPlatformLoadParameters):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::platformDidReceiveLoadParameters):

11:52 AM Changeset in webkit [291809] by Elliott Williams
  • 6 edits
    1 add
    2 deletes in trunk/Source/WebKit

[XCBuild] WebKit: Use native headers + build rules for migrated headers
​https://bugs.webkit.org/show_bug.cgi?id=238213
<rdar://problem/90172142>

Reviewed by Alexey Proskuryakov.

Replace the Make-based header migration script phase with a native project-based
representation in WebKit.xcodeproj.

The project now contains a 'Migrated Headers' group which lists the headers from
WebKitLegacy and WebCore that are copied to WebKit.framework during the build process. This
group must be kept in sync with the actual headers in WebKitLegacy, but since new headers
shouldn't really be added to WebKitLegacy this will be low-friction.

The preexisting postprocess-header-rule build rule is refactored to handle the
transformations needed for Migrated headers, which previous came from WebKitLegacy's
postprocess-header-rule script or from one of the MigrateHeaders*.make files.

  • Configurations/WebKit.xcconfig: Use EXCLUDED_SOURCE_FILE_NAMES to customize migrated

headers on mac vs. non-mac platforms.

  • Scripts/postprocess-header-rule: Refactored to incorporate WebKitLegacy's postprocessing

steps, and to do less disk I/O, now that it's always invoked as a build rule and can do less
in-place editing. Local testing shows a ~15% speedup.

  • Shared/API/Cocoa/WebKitLegacy.h: Added. Xcode's header maps forbid a header's name from

changing during the copy process, so we have to duplicate WebKitLegacy's umbrella header
instead of renaming it WebKit.h -> WebKitLegacy.h during the build.

  • WebKit.xcodeproj/project.pbxproj: Added 'Migrated Headers' group and build rule.

Configured headers to always copy using XCBuild. Removed legacy-only header script phases.

  • WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm: This file used unqualified

<HEADER.h> imports, which are not supported by Xcode's headermaps. Replaced with "HEADER.h".

  • mac/MigrateHeadersFromWebKitLegacy.make: Removed, logic now lives in

mingrate-headers-rule.sh.

  • mac/postprocess-framework-headers.sh: Removed.
  • mac/replace-webkit-additions-includes.py: Refactored to use stdin and stdout rather than

editing in-place. Corresponds to refactors in postprocess-header-rule.

11:50 AM Changeset in webkit [291808] by gnavamarino@apple.com
  • 3 edits in trunk/Source/WebCore

FormDataConsumer callback happens more than once with an exception
​https://bugs.webkit.org/show_bug.cgi?id=238091

In case of an error, it is not expected for the FormDataConsumer callback to happen
more than once with an exception. To avoid this, we introduce FormDataConsumer::didFail
which cancels/clears everything after reporting an error.

Reviewed by Youenn Fablet.

  • Modules/fetch/FormDataConsumer.cpp:

(WebCore::FormDataConsumer::read):
(WebCore::FormDataConsumer::consumeFile):
(WebCore::FormDataConsumer::consumeBlob):
(WebCore::FormDataConsumer::didFail):
(WebCore::FormDataConsumer::cancel):

  • Modules/fetch/FormDataConsumer.h:

(WebCore::FormDataConsumer::isCancelled):

11:16 AM Changeset in webkit [291807] by Matteo Flores
  • 36 edits
    4 deletes in trunk

Unreviewed, reverting r291789.

This revision caused 65+ new API failures on iOS debug

Reverted changeset:

"Release assert in Document::updateLayout() via
HTMLTextAreaElement::childrenChanged"
​https://bugs.webkit.org/show_bug.cgi?id=224471
​https://commits.webkit.org/r291789

11:15 AM Changeset in webkit [291806] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit

[macOS] Remove reports for some sandbox violations on process launch
​https://bugs.webkit.org/show_bug.cgi?id=238324

Reviewed by Geoffrey Garen.

Remove reports for some sandbox violations on process launch on macOS. These violations are not critical,
and are slowing down process launch. This patch also adds access to a mach syscall observed being in use.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
11:08 AM Changeset in webkit [291805] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebGPU

[WebGPU] Fix the watchOS build
​https://bugs.webkit.org/show_bug.cgi?id=238337

Unreviewed.

  • WebGPU/Texture.mm:

(WebGPU::Device::createTexture):

10:57 AM Changeset in webkit [291804] by Jonathan Bedard
  • 9 edits
    2 adds in trunk/Tools

[git-webkit] Install git-lfs
​https://bugs.webkit.org/show_bug.cgi?id=238270
<rdar://problem/90708032>

Reviewed by Aakash Jain and Wenson Hsieh.

  • Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
  • Tools/Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
  • Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py:

(Response.init): Accept binary content or text.
(Response.text): Decode binary content.

  • Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:

(Git): Add git lfs mocks.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:

(GitHub.init): Mock project release binaries.
(GitHub.request): Ditto.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py: Add InstallGitLFS.
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_git_lfs.py: Added.

(InstallGitLFS):
(InstallGitLFS.url): Return URL specific to the current platform.
(InstallGitLFS.install): Install git lfs globally on this machine.
(InstallGitLFS.parser): Install git lfs even if it is already installed.
(InstallGitLFS.main): Check git lfs version, install it if needed, and then run git lfs install.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py: Added.

(TestInstallGitLFS):
(TestInstallGitLFS.setUp):
(TestInstallGitLFS.test_svn):
(TestInstallGitLFS.test_remote_git):
(TestInstallGitLFS.test_url):
(TestInstallGitLFS.test_install):
(TestInstallGitLFS.test_configure):
(TestInstallGitLFS.test_no_op):

Canonical link: ​https://commits.webkit.org/248831@main

10:30 AM Changeset in webkit [291803] by Alan Coon
  • 1 edit in branches/safari-613-branch/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h

Unreviewed build fix. rdar://problem/89972004

10:20 AM Changeset in webkit [291802] by Ben Nham
  • 5 edits in trunk

PushAPI.firePushEventWithNoPagesTimeout fails in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=238309

Reviewed by Youenn Fablet.

Source/WebCore:

Export RegistrationDatabase::schemaVersion for tests to use.

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::databaseFilename):
(WebCore::cleanOldDatabases):

  • workers/service/server/RegistrationDatabase.h:

Tools:

This test was dying on an assertion in debug builds because we were calling
terminateNetworkProcessWhileRegistrationIsStored with a brand new WKWebsiteDataStore, which
wasn't associated with an active NetworkProcess connection since it was a brand new object.
Fix this by using the existing data store object instead.

Additionally, terminateNetworkProcessWhileRegistrationIsStored was waiting on the wrong
filename, so I changed the test to reference the correct filename.

  • TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
10:18 AM Changeset in webkit [291801] by jonlee@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk2/TestExpectations:
9:55 AM Changeset in webkit [291800] by Chris Dumez
  • 36 edits in trunk

String's find() / reverseFind() / replace() should take in a StringView instead of a String
​https://bugs.webkit.org/show_bug.cgi?id=238287

Reviewed by Darin Adler.

Source/WebCore:

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::decodeDatabaseName):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValueCommon):

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse):

  • platform/mediastream/CaptureDevice.h:

(WebCore::CaptureDevice::label const):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

Source/WebKitLegacy/win:

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

Source/WTF:

String's find() / reverseFind() / replace() should take in a StringView instead of a String
to avoid unnecessary String construction in many cases. We should probably do the same for
more String functions where we don't really need a String parameter, but those will be
addressed separately.

  • wtf/text/AtomString.h:
  • wtf/text/StringCommon.h:

(WTF::findCommon): Deleted.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringASCIICase const):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::replace):

  • wtf/text/StringImpl.h:
  • wtf/text/StringView.h:

(WTF::findCommon):
(WTF::findIgnoringASCIICase):
(WTF::String::find const):
(WTF::String::findIgnoringASCIICase const):
(WTF::String::reverseFind const):
(WTF::String::contains const):
(WTF::String::containsIgnoringASCIICase const):
(WTF::String::replace):
(WTF::AtomString::find const):
(WTF::AtomString::findIgnoringASCIICase const):
(WTF::AtomString::contains const):
(WTF::AtomString::containsIgnoringASCIICase const):

  • wtf/text/WTFString.h:
8:55 AM Changeset in webkit [291799] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Do not construct a TextRun for measuring a single whitespace when simplified content measuring can be used
​https://bugs.webkit.org/show_bug.cgi?id=238228

Reviewed by Antti Koivisto.

  • layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::computeInlineTextItemWidths): Just simply call TextUtil::width

  • layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::spaceWidth):
(WebCore::Layout::TextUtil::width):
(WebCore::Layout::TextUtil::spaceWidth): Deleted.

  • layout/formattingContexts/inline/text/TextUtil.h:
8:53 AM Changeset in webkit [291798] by Tyler Wilcock
  • 7 edits in trunk/Source/WebCore

AX: Remove firstChild, lastChild, previousSibling, nextSibling, nextSiblingUnignored, and previousSiblingUnignored from the AXCoreObject interface
​https://bugs.webkit.org/show_bug.cgi?id=238267

Reviewed by Andres Gonzalez.

All of these except nextSibling and previousSibling are ASSERT_NOT_REACHED no-ops
in AXIsolatedObject. We do compute next and previous sibling for isolated objects,
but they're only used in one place (appendChildrenToArray). Usage of these functions
in appendChildrenToArray doesn't make sense for isolated objects, as it would require
the isolated object to be ignored for them to be called, and we should never have created an
isolated object from an ignored live object.

Dovetailing from that, this patch also removes AXPropertyName::IsAccessibilityIgnored,
since this should always be false for isolated objects. ASSERTs have been added in a
few places to assure this is the case.

  • accessibility/AccessibilityObject.cpp:

(WebCore::Accessibility::appendChildrenToArray):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::firstChild const):
(WebCore::AccessibilityObject::lastChild const):
(WebCore::AccessibilityObject::previousSibling const):
(WebCore::AccessibilityObject::nextSibling const):

  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::firstChild const): Deleted.
(WebCore::AXIsolatedObject::lastChild const): Deleted.
(WebCore::AXIsolatedObject::nextSiblingUnignored const): Deleted.
(WebCore::AXIsolatedObject::previousSiblingUnignored const): Deleted.

  • accessibility/isolatedtree/AXIsolatedObject.h:
  • accessibility/isolatedtree/AXIsolatedTree.h:

Remove AXPropertyName::NextSibling, AXPropertyName::PreviousSibling,
AXPropertyName::IsAccessibilityIgnored.

8:50 AM Changeset in webkit [291797] by cathiechen
  • 16 edits
    2 copies
    40 adds in trunk/LayoutTests

Update css/css-sizing/contain-intrinsic-size tests from WPT
​https://bugs.webkit.org/show_bug.cgi?id=238312

Reviewed by Rob Buis.

LayoutTests/imported/w3c:

Update the contain-intrinsic-size tests to wpt commit: 7c61a4594a95682531367b6956d1c37f8b8fd486

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/animation/contain-intrinsic-size-interpolation-expected.txt:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/animation/contain-intrinsic-size-interpolation.html:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-001-expected.txt: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-001.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-002-expected.txt: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-002.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-003-expected.txt: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-003.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-004-expected.txt: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-004.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-005-expected.txt: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-005.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-001-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-002-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-003-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-004-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-005-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-006-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-007-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-008-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-010-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-011-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-012-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-013-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-014-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-015-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-016-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-017-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-018-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-019-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-020-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-021-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-022-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-023-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-024-ref.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-025-expected.html:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-025-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-025-expected.html.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-026-expected.html:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-026-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-026-expected.html.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-027-expected.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-027.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-001-expected.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-001.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-002-expected.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-002.html: Added.
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-computed-expected.txt:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-computed.html:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-invalid-expected.txt:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-invalid.html:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-valid-expected.txt:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-valid.html:
  • web-platform-tests/css/css-sizing/contain-intrinsic-size/w3c-import.log:

LayoutTests:

8:29 AM Changeset in webkit [291796] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

MatchedDeclarationCache key is already hashed
​https://bugs.webkit.org/show_bug.cgi?id=238321

Reviewed by Alan Bujtas.

  • style/MatchedDeclarationsCache.h:
8:03 AM Changeset in webkit [291795] by Chris Dumez
  • 2 edits in trunk/Tools

Unreviewed, update outdated comment after r291787.

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

7:15 AM Changeset in webkit [291794] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[IFC][Integration] RenderText::computeCanUseSimplifiedTextMeasuring should take first-line style into account
​https://bugs.webkit.org/show_bug.cgi?id=238243

Reviewed by Antti Koivisto.

This is in preparation for using the fast text measuring codepath for legacy line layout content.

  • layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const):

6:47 AM Changeset in webkit [291793] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

Devirtualize RenderText::width
​https://bugs.webkit.org/show_bug.cgi?id=238285

Reviewed by Antti Koivisto.

RenderCombineText handling is moved to RenderText (we already handle combine text in RenderText::widthFromCache).

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::combineTextIfNeeded): These are all non-text-combine callsites.
(WebCore::RenderCombineText::width const): Deleted.

  • rendering/RenderCombineText.h:
  • rendering/RenderText.cpp:

(WebCore::combineTextWidth): RenderCombineText::combinedTextWidth returns the same value as RenderCombineText::width.
(WebCore::RenderText::widthFromCache const):
(WebCore::RenderText::width const):

  • rendering/RenderText.h:
6:04 AM Changeset in webkit [291792] by Adrian Perez de Castro
  • 4 edits in trunk/Source/WebKit

[GTK] REGRESSION(r291613): Build broken with USE_GTK4 + ENABLE_ACCESSIBILITY
​https://bugs.webkit.org/show_bug.cgi?id=238320

Reviewed by Carlos Garcia Campos.

Guard remaning uses of ATK when building with GTK4, where ATK is not used at all.

  • UIProcess/API/glib/WebKitWebViewAccessible.cpp:
  • UIProcess/API/glib/WebKitWebViewAccessible.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDispose):

5:44 AM Changeset in webkit [291791] by commit-queue@webkit.org
  • 4 edits in trunk

REGRESSION (r287807): WEBGL_multi_draw validation rejecting valid arguments
​https://bugs.webkit.org/show_bug.cgi?id=238239

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-03-24
Reviewed by Darin Adler.

Source/WebCore:

Fix off-by-one error causing full buffer multidraws to be
marked as invalid.

Enable the newer WebGL conformance tests that test this.

  • html/canvas/WebGLMultiDraw.cpp:

(WebCore::WebGLMultiDraw::validateOffset):

LayoutTests:

Enable the newer WebGL conformance tests that test this, marked
Slow as they take a while to run.

5:18 AM Changeset in webkit [291790] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Allow styles with appearance in matched declaration cache
​https://bugs.webkit.org/show_bug.cgi?id=238247

Reviewed by Antoine Quint.

Improve cache efficiency by allowing styles with appearance (typically form controls) to be cached.

In Speedometer this improves the cache hit rate ~75% -> 94%.

  • style/MatchedDeclarationsCache.cpp:

(WebCore::Style::MatchedDeclarationsCache::isCacheable):

Remove appearance check.

(WebCore::Style::MatchedDeclarationsCache::add):

Also cache the UA style for styles with appearance.

(WebCore::Style::MatchedDeclarationsCache::remove):

  • style/MatchedDeclarationsCache.h:
  • style/StyleResolver.cpp:

(WebCore::Style::Resolver::applyMatchedProperties):

Also simplify the case where inherited properties affect resolution of other properties by
kicking out the existing entry. This also makes the second attempt cacheable.

  • style/StyleResolver.h:
1:33 AM Changeset in webkit [291789] by svillar@igalia.com
  • 36 edits
    1 copy
    4 adds in trunk

Release assert in Document::updateLayout() via HTMLTextAreaElement::childrenChanged
​https://bugs.webkit.org/show_bug.cgi?id=224471

Reviewed by Ryosuke Niwa.

Source/WebCore:

Executing some editing commands in a text area might force the recomputation of things
like caret or the visible selection position and extent. Under some circumstances (like
when the text area has no content and children) we might end up trying to update layout
when it is not safe as a side effect of updating the caret.

In order to fix that, we can switch to a model in which we update the selection asynchronously
in the case of having a non-user triggered change. That way we don't do it inside
a restricted layout scope.

The App Highlight restoration code had to be tuned as well (when restoring and scrolling to reveal
a Quick Note on iOS MacOS). It uses TemporarySelectionChange to select and scroll to reveal the highlight
range; the code assumed that this scrolling happens synchronously, since it reverts the selection to
the original range at the end of AppHighlightStorage::attemptToRestoreHighlightAndScroll when the
TemporarySelectionChange falls out of scope. That is however no longer the case. Actually no scrolling
happened after this patch because we end up only scheduling the appearance update timer before setting
the selection back to the original state with SelectionRevealMode::DoNotReveal. Since this only happens
when the user interacts in the Notes app, it seems sensible to consider it as a user triggered event.

  • Modules/highlight/AppHighlightStorage.cpp:

(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll): Consider the selection change
as user triggered so scrolling actually happens.

  • editing/Editor.cpp:

(WebCore::TemporarySelectionChange::setSelection): Check the UserTriggered flags for default options.

  • editing/Editor.h: Added a new UserTriggered flag.
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection): Call scheduleAppearanceUpdateAfterStyleChange() for
IsUserTriggered changes.
(WebCore::FrameSelection::updateSelectionAppearanceNow): Renamed from updateSelectionByUpdatingLayoutOrStyle.
It does not need the Document& attribute because it was always called with m_document.
(WebCore::FrameSelection::absoluteCaretBounds): Replaced updateSelectionByUpdatingLayoutOrStyle with
updateSelectionAppearanceNow().
(WebCore::FrameSelection::setCaretVisibility): Ditto.
(WebCore::FrameSelection::selectionBounds const): Ditto.
(WebCore::FrameSelection::revealSelection): Call updateSelectionAppearanceNow().

(WebCore::FrameSelection::updateAppearanceIfRevealingSelectionIsNeeded): New method.

(WebCore::updateSelectionByUpdatingLayoutOrStyle): Deleted.

  • editing/FrameSelection.h:
  • page/EventHandler.cpp:

(WebCore::setSelectionIfNeeded): Set the UserTriggered flag for calling setSelection().

  • page/Page.cpp:

(WebCore::Page::doAfterUpdateRendering): Call updateAppearanceAfterLayout().

LayoutTests:

Moved some tests out of the text-based-repaint.js model because selection is now updated
and revealed asynchronously in the case of non-user triggered changes. The problem is that
by the time the repaint rects are queried the update has not happened yet. That's why
the tests were modified so that we wait until the repaint happens.

Same situation for other tests that do not involve repaint rects but trigger accesibility
tree updates. We must ensure that we let the notification be thrown before checking whether or
not has been emited. As it's done asynchronously we must let the main thread run before checking.

Last but not least, some of the tests are using setTimeout() instead of requestAnimationFrame()
because the results with the latter were not as reliable under stress/debug conditions.

  • accessibility/mac/selection-boundary-userinfo.html:
  • accessibility/mac/selection-change-userinfo.html:
  • accessibility/mac/selection-value-changes-for-aria-textbox.html:
  • editing/selection-with-absolute-positioned-empty-content.html:
  • fast/forms/textarea-scrolled-endline-caret.html:
  • fast/repaint/selection-gap-absolute-child-expected.txt:
  • fast/repaint/selection-gap-absolute-child.html:
  • fast/repaint/selection-gap-flipped-absolute-child-expected.txt:
  • fast/repaint/selection-gap-flipped-absolute-child.html:
  • fast/repaint/selection-gap-transformed-absolute-child-expected.txt:
  • fast/repaint/selection-gap-transformed-absolute-child.html:
  • fast/repaint/selection-gap-transformed-fixed-child-expected.txt:
  • fast/repaint/selection-gap-transformed-fixed-child.html:
  • fast/repaint/selection-paint-invalidation-expected.txt:
  • fast/repaint/selection-ruby-rl-expected.txt:
  • fast/repaint/selection-ruby-rl.html:
  • fast/repaint/text-selection-overflow-hidden-expected.txt:
  • fast/repaint/text-selection-overflow-hidden.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/repaint/selection-ruby-rl-expected.txt: Copied from LayoutTests/fast/repaint/selection-ruby-rl-expected.txt.
  • platform/gtk/fast/repaint/text-selection-overflow-hidden-expected.txt:
  • platform/mac-catalina-wk1/fast/repaint/focus-setting-selection-syncronizing-not-clearing-expected.txt: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/fast/repaint/4776765-expected.txt: Added.
  • platform/mac-wk1/accessibility/mac/focus-setting-selection-syncronizing-not-clearing-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005-expected.txt:
  • platform/mac/TestExpectations:
  • platform/win/fast/repaint/4776765-expected.txt: Added.
  • platform/win/fast/repaint/selection-gap-fixed-child-expected.txt:
  • platform/win/fast/repaint/selection-ruby-rl-expected.txt:
  • platform/win/fast/repaint/text-selection-overflow-hidden-expected.txt:
Note: See TracTimeline for information about the timeline view.