Context Navigation

← Previous Period
Next Period →

Timeline

Apr 1, 2022:

11:33 PM Changeset in webkit [292261] by Wenson Hsieh

2 edits in trunk/Source/WebKit

[iOS] WKFullScreenWindowController's UIViewController leaks after entering element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=238684

Reviewed by Eric Carlson.

The window controller's _rootViewController is a RetainPtr, but we're missing an adoptNS when creating a
new view controller. Fix the leak by using adoptNS to prevent the redundant -retain when constructing
RetainPtr.

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController enterFullScreen]):

11:27 PM Changeset in webkit [292260] by Wenson Hsieh

2 edits in trunk/Source/WebKit

[iOS] Several tests in media/modern-media-controls crash in -[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]
https://bugs.webkit.org/show_bug.cgi?id=238687

Reviewed by Tim Horton.

Fixes several debug assertions that are hit when running layout tests in media/modern-media-controls, due to
exercising undefined behavior in the case where there is only one item. This is because we currently use
Vector's move assignment operator to set items to items[0].children; however, this move assignment operator
starts by calling the destructor on the contents of item, which puts the first item's vector of children in an
invalid state.

Instead, simply add a new temporary variable, and move into the temporary variable instead.

UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]):
(-[WKActionSheetAssistant showMediaControlsContextMenu:items:completionHandler:]):

11:10 PM Changeset in webkit [292259] by achristensen@apple.com

4 edits in trunk/Tools

Fix internal iOS build
https://bugs.webkit.org/show_bug.cgi?id=238032

This is what we get when we add files to unified builds.

TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
TestWebKitAPI/ios/UIKitSPI.h:

10:18 PM Changeset in webkit [292258] by msaboff@apple.com

16 edits in trunk/Source

Stop copying StagedFrameworks to the secondary path by default
https://bugs.webkit.org/show_bug.cgi?id=238688

Reviewed by Saam Barati.

Decoupled COPY_STAGED_FRAMEWORKS_TO_SECONDARY_PATH from USE_SYSTEM_CONTENT_PATH so we won't
always copy frameworks to the secondary path on macOS. Instead, the build configuration can set
COPY_STAGED_FRAMEWORKS_TO_SECONDARY_PATH as appropriate.

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/ANGLE-dynamic.xcconfig:

Source/ThirdParty/libwebrtc:

Configurations/libwebrtc.xcconfig:

Source/WebCore:

Configurations/WebCore.xcconfig:

Source/WebGPU:

Configurations/WebGPU.xcconfig:

Source/WebInspectorUI:

Configurations/WebInspectorUIFramework.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:

8:53 PM Changeset in webkit [292257] by Alan Bujtas

2 edits in trunk/LayoutTests

[CSS-contain] Update select element failures with bugzilla link.

Unreviewed.

TestExpectations:

8:46 PM Changeset in webkit [292256] by Diego Pino Garcia

2 edits in trunk/Source/WebKit

Unreviewed, fix non-unified build after r292225

Platform/IPC/unix/IPCSemaphoreUnix.cpp: Add poll.h and remove

duplicated Decoder.h and Encoder.h headers.

8:29 PM Changeset in webkit [292255] by sihui_liu@apple.com

5 edits in trunk

Avoid initializing default WKWebsiteDataStore in -[WKWebViewConfiguration copyWithZone]
https://bugs.webkit.org/show_bug.cgi?id=238531
rdar://90628101

Reviewed by Tim Horton.

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

8:04 PM Changeset in webkit [292254] by achristensen@apple.com

21 edits
3 adds in trunk

WKBundlePageUIClient console message support should include source URL, column number, and console messages with arguments
https://bugs.webkit.org/show_bug.cgi?id=238032

Patch by Jeff Miller <jeffm@apple.com> on 2022-04-01
Reviewed by Alex Christensen.

Source/JavaScriptCore:

Add a function to ScriptArguments to get a vector of argument strings. As we do in
ScriptArguments::getFirstArgumentAsString(), avoid triggering Proxy traps on a Proxy object when
generating the vector.

inspector/ScriptArguments.cpp:

(Inspector::ScriptArguments::getArgumentAtIndexAsString const):
Refactored from getFirstArgumentAsString().

(Inspector::ScriptArguments::getFirstArgumentAsString const):
Use getArgumentAtIndexAsString().

(Inspector::ScriptArguments::getArgumentsAsStrings const):

inspector/ScriptArguments.h:

Source/WebCore:

Add a new ChromeClient addMessageWithArgumentsToConsole() member function for adding a console
message that includes formatted arguments. I left the existing behavior of addMessageToConsole()
unchanged since layout tests expect to get the console message without these arguments.

New API test was added in TestWebKitAPI/Tests/WebKitCocoa/ConsoleMessageWithDetails.mm.

loader/EmptyClients.h:

Added addMessageWithArgumentsToConsole().

page/ChromeClient.h:

(WebCore::ChromeClient::addMessageWithArgumentsToConsole):
Added, subclasses can optionally override this.

page/PageConsoleClient.cpp:

(WebCore::additionalArgumentsFromArgumentsVector):
Added, pulls out any additional arguments beyond the initial message.

(WebCore::PageConsoleClient::addMessage):
Create a Span of any message arguments and include it when calling the new
addMessageWithArgumentsToConsole() function.

(WebCore::PageConsoleClient::messageWithTypeAndLevel):
Ditto.

Source/WebKit:

Shared/API/APIArray.cpp:

(API::Array::createStringArray):
Added, creates an array from a Span.

Shared/API/APIArray.h:
WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:

(API::InjectedBundle::PageUIClient::willAddMessageWithArgumentsToConsole):
Added.

WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:

Add WKBundlePageUIClientV5 with a new willAddMessageWithDetailsToConsole callback. This callback is
similar to the existing willAddMessageToConsole callback, but includes any message arguments, the
column number, and source URL.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::willAddMessageWithArgumentsToConsole):
Added, invokes the new willAddMessageWithDetailsToConsole callback.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

Add a new bundle page UI client version.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::addMessageWithArgumentsToConsole):
Added.

WebProcess/WebCoreSupport/WebChromeClient.h:

Added addMessageWithArgumentsToConsole().

Tools:

Add a test for the new willAddMessageWithDetailsToConsole callback in WKBundlePageUIClient. This
includes a new WKWebProcessPlugIn subclass, BundlePageConsoleMessageWithDetails, that implements
this callback and formats the message and arguments into a single string which it sends to the UI
process.

TestWebKitAPI/SourcesCocoa.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/BundlePageConsoleMessageWithDetails.mm: Added.

(willAddMessageWithDetailsToConsoleCallback):
(-[BundlePageConsoleMessageWithDetails webProcessPlugIn:didCreateBrowserContextController:]):

TestWebKitAPI/Tests/WebKitCocoa/ConsoleMessageWithDetails.mm: Added.

(TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/console-message-with-details.html: Added.

7:14 PM Changeset in webkit [292253] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Fix the WebGPU-less build
https://bugs.webkit.org/show_bug.cgi?id=238692

Reviewed by Myles Maxfield.

Configurations/WebCore.xcconfig:

7:09 PM Changeset in webkit [292252] by Wenson Hsieh

15 edits in trunk/Source

[iOS] [WK2] Add plumbing for extracting video frames in element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=238607
rdar://91102888

Reviewed by Eric Carlson.

Source/WebCore:

Add a helper function on HTMLMediaElement to return the identifier of its MediaPlayer. See WebKit ChangeLog for
more information.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playerIdentifier const):

html/HTMLMediaElement.h:

Source/WebKit:

Add WebKit2 client layer plumbing for triggering video extraction for the prominent video in element fullscreen.
See below for more details.

UIProcess/PageClient.h:

(WebKit::PageClient::beginElementFullscreenVideoExtraction):
(WebKit::PageClient::cancelElementFullscreenVideoExtraction):

Add new PageClient hooks to start and cancel video element extraction in element fullscreen. We only implement
these on iOS, for now.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::extractVideoInElementFullScreen):
(WebKit::WebPageProxy::cancelVideoExtractionInElementFullScreen):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

Add IPC plumbing from WebPage to WebPageProxy for starting and canceling video element extraction.

UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::beginElementFullscreenVideoExtraction):
(WebKit::PageClientImpl::cancelElementFullscreenVideoExtraction):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView beginElementFullscreenVideoExtraction:bounds:]):
(-[WKContentView cancelElementFullscreenVideoExtraction]):

Add method stubs for non-internal builds.

WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::mainVideoElementExtractionTimerFired):
(WebKit::WebFullScreenManager::endMainVideoElementExtractionIfNeeded):

Remove the FIXMEs and call into the new helper methods on WebPage to start and cancel video element extraction.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::extractVideoInElementFullScreen):
(WebKit::WebPage::cancelVideoExtractionInElementFullScreen):

WebProcess/WebPage/WebPage.h:

7:01 PM Changeset in webkit [292251] by Chris Dumez

93 edits in trunk/Tools

Prepare Tools/ for making the String(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=238530

Reviewed by Geoffrey Garen.

DumpRenderTree/TestRunner.cpp:

(TestRunner::setAccummulateLogsForChannel):

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentState):

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/JSONValue.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/URL.cpp:

(TestWebKitAPI::TEST_F):
(TestWebKitAPI::createURL):

TestWebKitAPI/Tests/WTF/URLParser.cpp:

(TestWebKitAPI::insertTabAtLocation):
(TestWebKitAPI::invalidParts):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::checkRelativeURLDifferences):
(TestWebKitAPI::shouldFail):
(TestWebKitAPI::testUserPassword):

TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:

(ApplicationManifestParserTest::SetUp):
(ApplicationManifestParserTest::testStartURL):
(ApplicationManifestParserTest::testDisplay):
(ApplicationManifestParserTest::testName):
(ApplicationManifestParserTest::testDescription):
(ApplicationManifestParserTest::testShortName):
(ApplicationManifestParserTest::testThemeColor):
(ApplicationManifestParserTest::testIconsSrc):
(ApplicationManifestParserTest::testIconsType):
(ApplicationManifestParserTest::testIconsSizes):
(ApplicationManifestParserTest::testIconsPurposes):
(TEST_F):

TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/CSSParser.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::mainDocumentRequest):
(TestWebKitAPI::subResourceRequest):
(TestWebKitAPI::requestInTopAndFrameURLs):
(TestWebKitAPI::makeBackend):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::actionsEqual):
(TestWebKitAPI::sequenceInstances):
(TestWebKitAPI::checkCompilerError):

TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/FidoTestData.h:
TestWebKitAPI/Tests/WebCore/GridPosition.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:

(TestWebKitAPI::testParseHTMLInteger):
(TestWebKitAPI::parseHTMLIntegerFails):
(TestWebKitAPI::testParseHTMLNonNegativeInteger):
(TestWebKitAPI::parseHTMLNonNegativeIntegerFails):

TestWebKitAPI/Tests/WebCore/HTTPHeaderField.cpp:

(TEST):

TestWebKitAPI/Tests/WebCore/HTTPHeaderMap.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::testSimpleValue):
(TestWebKitAPI::KeyedCodingTestObject::encode):
(TestWebKitAPI::KeyedCodingTestObject::decode):

TestWebKitAPI/Tests/WebCore/MIMETypeRegistry.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/NowPlayingInfoTests.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/PushDatabase.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/PushMessageCrypto.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/StringUtilities.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/StringWithDirection.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:

(TestWebKitAPI::constructMakeCredentialRequest):
(TestWebKitAPI::constructGetAssertionRequest):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:

(TestWebKitAPI::invalidParts):
(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:

(TestWebKitAPI::test):
(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm:

(TestWebKitAPI::MediaSessionCoordinatorTest::loadPageAndBecomeReady):
(TestWebKitAPI::MediaSessionCoordinatorTest::play):
(TestWebKitAPI::MediaSessionCoordinatorTest::pause):

TestWebKitAPI/Tests/WebKit/WebRTC.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit/XPCEndpoint.mm:
TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(TEST):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
(TestWebKitAPI::downloadAtRate):
(TEST):

TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:

(TestWebKitAPI::runBasicPCMTest):
(TestWebKitAPI::triggerAttributionWithSubresourceRedirect):
(TestWebKitAPI::signUnlinkableTokenAndSendSecretToken):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/FTP.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:
TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:

(TestWebKitAPI::hstsServer):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:

(runTest):
(createDirectories):

TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/MediaSession.mm:

(TestWebKitAPI::MediaSessionTest::loadPageAndBecomeNowPlaying):
(TestWebKitAPI::MediaSessionTest::runScriptWithUserGesture):
(TestWebKitAPI::MediaSessionTest::play):
(TestWebKitAPI::MediaSessionTest::pause):
(TestWebKitAPI::MediaSessionTest::eventListenerWasCalled):
(TestWebKitAPI::MediaSessionTest::waitForEventListenerToBeCalled):
(TestWebKitAPI::MediaSessionTest::sessionHandlerWasCalled):
(TestWebKitAPI::MediaSessionTest::waitForSessionHandlerToBeCalled):
(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:

(NowPlayingTest::loadPage):
(NowPlayingTest::runScriptWithUserGesture):
(NowPlayingTest::runScriptWithoutUserGesture):
(TEST_F):

TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:

(TEST_F):

TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/WebLocks.mm:

(TestWebKitAPI::runSnapshotAcrossPagesTest):
(TestWebKitAPI::runLockRequestWaitingOnAnotherPage):

TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

(TestWebKitAPI::TEST):
(TestWebKitAPI::WebPushDTest::loadRequest):

TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/cocoa/HTTPServer.h:
TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
(TestWebKitAPI::HTTPServer::respondWithOK):
(TestWebKitAPI::HTTPServer::request const):
(TestWebKitAPI::HTTPServer::requestWithLocalhost const):

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::outputText):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpPath):
(WTR::string):
(WTR::pathSuitableForTestResult):
(WTR::dumpErrorDescriptionSuitableForTestResult):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::findAndDumpWorldLeaks):
(WTR::TestController::didReceiveLiveDocumentsList):
(WTR::TestController::canAuthenticateAgainstProtectionSpace):
(WTR::TestController::didReceiveAuthenticationChallenge):
(WTR::TestController::downloadDidStart):
(WTR::TestController::decideDestinationWithSuggestedFilename):
(WTR::TestController::downloadDidFinish):

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::waitToDumpWatchdogTimerFired):
(WTR::TestInvocation::waitForPostDumpWatchdogTimerFired):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

7:00 PM Changeset in webkit [292250] by jonlee@apple.com

2 edits in trunk/LayoutTests

Unreviewed gardening.

platform/ios-wk2/TestExpectations: Forms test was flaky before turning GPUP on by default,

move it out of the section of GPUP-specific failures. Update WebGL failure with bugzilla link.

6:29 PM Changeset in webkit [292249] by Simon Fraser

19 edits in trunk

Hoist the IOSurfacePool out of IOSurface
https://bugs.webkit.org/show_bug.cgi?id=238675

Reviewed by Tim Horton.
Source/WebCore:

A future patch will break the assumption that there is a singleton IOSurfacePool per
process, so we can't have IOSurface::create() consult the pool internally. Instead,
pass the pool to the create() functions, and to the moveToPool() function.

Callers in the web process pass IOSurfacePool::sharedPool(); those in the UI process
pass nullptr to avoid pool creation there.

Modules/system-preview/ARKitBadgeSystemImage.mm:

(WebCore::ARKitBadgeSystemImage::draw const):

platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::addSurface):

platform/graphics/cg/IOSurfacePool.h:
platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::create):
(WebCore::ImageBufferIOSurfaceBackend::releaseBufferToPool):

platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLCocoa::allocateAndBindDisplayBufferBacking):

platform/graphics/cocoa/IOSurface.h: createFromImageBuffer() was unused; remove it.
platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::create):
(WebCore::IOSurface::createFromImage):
(WebCore::IOSurface::moveToPool):
(WebCore::IOSurface::surfaceFromPool): Deleted.

testing/WebFakeXRDevice.cpp:

(WebCore::SimulatedXRDevice::frameTimerFired):

Source/WebKit:

Callers in the web process pass IOSurfacePool::sharedPool(); those in the UI process
pass nullptr to avoid pool creation there.

GPUProcess/media/RemoteImageDecoderAVFProxy.cpp:

(WebKit::RemoteImageDecoderAVFProxy::createFrameImageAtIndex):

GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:

(WebKit::RemoteMediaPlayerProxy::nativeImageForCurrentTime):

Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _takeViewSnapshot]):
(-[WKWebView _snapshotRectAfterScreenUpdates:rectInViewCoordinates:intoImageOfWidth:completionHandler:]):

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::takeViewSnapshot):

WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):

Tools:

Callers in the web process pass IOSurfacePool::sharedPool(); those in the UI process
pass nullptr to avoid pool creation there.

DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):

6:18 PM Changeset in webkit [292248] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Fix build break after r292225 for Playstation.
https://bugs.webkit.org/show_bug.cgi?id=238683

Patch by Jigen Zhou <jigen.zhou@sony.com> on 2022-04-01
Reviewed by Don Olmstead.

Unreviewed build fix after 292225 for Playstation build.

Platform/IPC/unix/IPCSemaphoreUnix.cpp:

5:46 PM Changeset in webkit [292247] by zhifei_fang@apple.com

3 edits
1 add in trunk

Fix 'Error: too many values to unpack (expected 2)'
https://bugs.webkit.org/show_bug.cgi?id=238682

Reviewed by Jonathan Bedard.

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description_unittest.py: Added.

(MockCommit):
(MockCommit.init):
(MockCommitContext):
(MockCommitContext.init):
(MockCommitContext.find_commits_by_uuid):
(MockCommitContext.url):
(TestBugDescription):
(TestBugDescription.setUp):
(TestBugDescription.test_single_row_and_single_test_failure):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bugzilla.py:

(WebKitBugzilla.create_bug):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/run-tests:

Canonical link: https://commits.webkit.org/249145@main

5:43 PM Changeset in webkit [292246] by Ryan Haddad

3 edits in trunk/LayoutTests

REGRESSION(r292072): [ Mac iOS ] http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=238580

Unreviewed test gardening.

Remove expectations as cause has been reverted.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

5:41 PM Changeset in webkit [292245] by Ryan Haddad

7 edits
2 deletes in trunk

Unreviewed, reverting r292072.
https://bugs.webkit.org/show_bug.cgi?id=238690

Caused webAPIStatistics test failures

Reverted changeset:

"[Cocoa] Automatically relayout the page when new fonts are
installed"
https://bugs.webkit.org/show_bug.cgi?id=238483
https://commits.webkit.org/r292072

Patch by Commit Queue <commit-queue@webkit.org> on 2022-04-01

5:25 PM Changeset in webkit [292244] by Diego Pino Garcia

9 edits in trunk/Source

Source/WebCore:
Unreviewed, fix non-unified build after r292208

css/typedom/ComputedStylePropertyMapReadOnly.cpp:
css/typedom/StylePropertyMapReadOnly.cpp:
page/FrameSnapshotting.h:
page/InteractionRegion.cpp:
platform/graphics/gbm/GBMDevice.cpp:

Source/WebKit:
Unreviewed, fix non-unified build after r292218

Platform/IPC/unix/IPCSemaphoreUnix.cpp:
UIProcess/Notifications/WebNotificationManagerProxy.h:

5:23 PM Changeset in webkit [292243] by Matteo Flores

2 edits in trunk/LayoutTests

REGRESSION(r290822?): [ wk1 ] storage/websql/change-version.html is a flaky timeout

https://bugs.webkit.org/show_bug.cgi?id=238689

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

4:57 PM Changeset in webkit [292242] by ysuzuki@apple.com

6 edits in trunk

Change one-shot maxTimerNestingLevel from 5 to 10
https://bugs.webkit.org/show_bug.cgi?id=237168

Reviewed by Sam Weinig, Saam Barati, and Cameron McCormack .

Source/WebCore:

Recently, we found from Chromium change[1] that changing this from 5 to 10 offers 10% Speedometer2 improvement
because Speedometer2's setTimeout nesting level is typically 7-8. We discussed with folks including Chris, Maciej,
Saam, and Cameron and for now, we increase this from 5 to 10 to align to Blink's change to keep these kind of web
content fast. This is not aligned to the spec, and currently, we only apply it to one-shot timer.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/3473463

page/DOMTimer.cpp:

(WebCore::DOMTimer::intervalClampedToMinimum const):
(WebCore::DOMTimer::alignedFireTime const):

LayoutTests:

fast/dom/timer-increase-min-interval.html:
fast/dom/timer-throttling-hidden-page-expected.txt:
fast/dom/timer-throttling-hidden-page.html:

4:35 PM Changeset in webkit [292241] by Alan Coon

1 copy in tags/Safari-614.1.8.1

Tag Safari-614.1.8.1.

4:31 PM Changeset in webkit [292240] by Alan Coon

9 edits in branches/safari-614.1.8-branch/Source

Versioning.

WebKit-7614.1.8.1

4:04 PM Changeset in webkit [292239] by Alan Coon

9 edits in branches/safari-614.1.7-branch/Source

Versioning.

WebKit-7614.1.7.5

3:42 PM Changeset in webkit [292238] by Chris Dumez

2 edits in trunk/Source/WTF

Unreviewed, drop unnecessary WTF_EXPORT_PRIVATE on String(ASCIILiteral)

This constructor was recently inlined.

wtf/text/WTFString.h:

3:38 PM Changeset in webkit [292237] by jonlee@apple.com

5 edits in trunk/LayoutTests

Unreviewed gardening.

This is based on auditing the failing tests cited after turning DOM in GPUP on by default.

TestExpectations: One test was flaky on the bots before we turned on the flag.
platform/ios-simulator-wk2/TestExpectations: Some tests have fail/pass results only when the iOS sim is on an arm64 host.
platform/ios-wk2/TestExpectations: Lots of tests no longer fail.
platform/ios/TestExpectations:

2:38 PM Changeset in webkit [292236] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Expose WebKitWebView from WPEQtView
https://bugs.webkit.org/show_bug.cgi?id=236746

Patch by Tusooa Zhu <tusooa@kazv.moe> on 2022-04-01
Reviewed by Adrian Perez de Castro.

WPEQtView currently does not allow manipulating the underlying WebKitWebView.
This patch allows retrieving the WebKitWebView from the WPEQtView.

No tests needed, as this patch only adds a trivial getter.

UIProcess/API/wpe/qt/WPEQtView.cpp:

(WPEQtView::webView const):

UIProcess/API/wpe/qt/WPEQtView.h:

2:29 PM Changeset in webkit [292235] by Jonathan Bedard

3 edits in trunk/Tools

[Merge-Queue] Canonicalize commit without rebase
https://bugs.webkit.org/show_bug.cgi?id=238614
<rdar://problem/91113465>

Reviewed by Aakash Jain.

This is helpful immiediatly after landing a subversion commit
and allows us to bypass the 60 second sleep in PushCommitToWebKitRepo.

Tools/CISupport/ews-build/steps.py:

(Canonicalize.init): Allow caller to opt out of rebasing.
(Canonicalize.run): Ditto.

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/249136@main

2:21 PM Changeset in webkit [292234] by Alan Coon

1 copy in tags/Safari-613.2.5

Tag Safari-613.2.5.

2:18 PM Changeset in webkit [292233] by Matteo Flores

4 edits in trunk/LayoutTests

REGRESSION(r292072): [ wk1 ] fast/text/install-font-style-recalc.html is a constant text failure

https://bugs.webkit.org/show_bug.cgi?id=238641

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

1:47 PM Changeset in webkit [292232] by Ben Nham

12 edits in trunk

Add more push-related logging
https://bugs.webkit.org/show_bug.cgi?id=238591

Reviewed by Youenn Fablet.

Source/WebCore:

Add logging to help diagnose Push API errors. We currently log very little, which is making
it hard for us to diagnose bug reports.

Log if PushManager.subscribe fails the user gesture check. We log this to both syslog and the developer console. We do the latter to inform developers, and we already log an identical message from Notification.requestPermission when that fails in this manner.
Log if we can't fire a push event because the service worker registration went away.

Modules/push-api/PushManager.cpp:

(WebCore::PushManager::subscribe):

workers/service/server/SWServer.cpp:

(WebCore::SWServer::processPushMessage):

Source/WebKit:

Add logging to help diagnose Push API errors. We currently log very little, which is making
it hard for us to diagnose bug reports.

Log when we try to fetch or process push messages in NetworkProcess.
Log when we enqueue, start, and finish a PushServiceRequest. This helps catch issues such as a queued request never running because the OS push daemon never completing a request.
Log if we failed trying to wake up the browser to process a push message.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processPushMessage):

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _getPendingPushMessages:]):
(-[WKWebsiteDataStore _processPushMessage:completionHandler:]):

webpushd/PushService.mm:

(WebPushD::PushService::create):
(WebPushD::PushServiceRequestImpl::fulfill):
(WebPushD::PushServiceRequestImpl::reject):
(WebPushD::SubscribeRequest::startImpl):
(WebPushD::UnsubscribeRequest::startInternal):
(WebPushD::PushService::enqueuePushServiceRequest):
(WebPushD::PushService::incrementSilentPushCount):
(WebPushD::PushService::removeRecordsImpl):
(WebPushD::makeRawPushMessage):
(WebPushD::PushService::didReceivePushMessage):

webpushd/WebPushDaemon.mm:

(WebPushD::Daemon::injectEncryptedPushMessageForTesting):
(WebPushD::Daemon::notifyClientPushMessageIsAvailable):
(WebPushD::Daemon::getPendingPushMessages):

LayoutTests:

Modify test cases to check for user gesture error console message.

http/tests/push-api/subscribe-default-permissions-expected.txt:
http/tests/push-api/subscribe-default-permissions-iframe-same-origin-expected.txt:
http/tests/push-api/subscribe-deny-permissions-on-prompt-expected.txt:

12:53 PM Changeset in webkit [292231] by Matteo Flores

2 edits in trunk/LayoutTests

REGRESSION(r292072): [ wk1 ] fast/text/install-font-style-recalc.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=238641

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

12:30 PM Changeset in webkit [292230] by Chris Dumez

2 edits in trunk/Source/WebKit

REGRESSION(r292197): 3 TestWebKitAPI.ContentRuleList API tests are constant failures/timeout
https://bugs.webkit.org/show_bug.cgi?id=238678
<rdar://91173297>

Unreviewed, in r292197, I made a last minute mistake when applying some of Darin's review comments.
I converted a few calls to NSURL.absoluteURL.fileSystemRepresentation to
NSURL.absoluteString instead of NSURL.absoluteURL.path. As a result, the file://
prefix was still present and some characters may still be URL-encoded.

No new tests, covered by existing API tests failing on the bots.

UIProcess/API/Cocoa/WKContentRuleListStore.mm:

(+[WKContentRuleListStore storeWithURL:]):
(+[WKContentRuleListStore storeWithURLAndLegacyFilename:]):

12:26 PM Changeset in webkit [292229] by Kate Cheney

8 edits
5 adds in trunk

CSP: WASM fails to execute after window.open
https://bugs.webkit.org/show_bug.cgi?id=238562
<rdar://problem/90778752>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/allow-wasm-after-window-open.html

Reset WASM enabled value after a window.open() call. This patch simplifies
eval and wasm setters by removing the distinct enable/disable functions
and using one consistent setter.

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::setEvalEnabled):
(WebCore::ScriptController::setWebAssemblyEnabled):
(WebCore::ScriptController::enableEval): Deleted.
(WebCore::ScriptController::enableWebAssembly): Deleted.
(WebCore::ScriptController::disableEval): Deleted.
(WebCore::ScriptController::disableWebAssembly): Deleted.

bindings/js/ScriptController.h:
dom/Document.cpp:

(WebCore::Document::disableEval):
(WebCore::Document::disableWebAssembly):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::webAssemblyErrorMessage const):

LayoutTests:

Layout test coverage. Copy some wasm helper scripts into the http directory.

platform/win/TestExpectations:

We don't support wasm on win.

http/tests/security/contentSecurityPolicy/allow-wasm-after-window-open-expected.txt: Added.
http/tests/security/contentSecurityPolicy/allow-wasm-after-window-open.html: Added.
http/tests/security/contentSecurityPolicy/resources/load_wasm.js: Added.

(createWasmModule):

http/tests/security/contentSecurityPolicy/resources/run-web-assembly.html: Added.
http/tests/security/contentSecurityPolicy/resources/wasm-builder.js: Added.

(const._fail):
(const.isNotA.assert.isNotA):
(const):
(switch.typeof):
(Builder):
(Builder.prototype.setChecked):
(Builder.prototype.setPreamble):
(Builder.prototype._functionIndexSpaceKeyHash):
(Builder.prototype._registerFunctionToIndexSpace):
(Builder.prototype._getFunctionFromIndexSpace):
(Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):
(Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.const.codeBuilder.End.switch.case.string_appeared_here.e):
(Builder.prototype._registerSectionBuilders.this.Unknown):

12:23 PM Changeset in webkit [292228] by Alan Bujtas

2 edits in trunk/Source/WebCore

(REGRESSION r291992) showRenderTree fails to print the name of the renderer when "(" is present
https://bugs.webkit.org/show_bug.cgi?id=238666

Reviewed by Antti Koivisto.

rendering/RenderObject.cpp:

(WebCore::RenderObject::outputRenderObject const): with names like "RenderRubyBase (anonymous)" we print an address and not "RenderRubyBase"

12:03 PM Changeset in webkit [292227] by Alan Coon

1 copy in tags/Safari-614.1.8

Tag Safari-614.1.8.

11:41 AM Changeset in webkit [292226] by Alan Bujtas

7 edits
2 adds in trunk

[Ruby] Statically positioned out-of-flow block boxes are mispositioned
https://bugs.webkit.org/show_bug.cgi?id=238653

Reviewed by Antti Koivisto.

Source/WebCore:

A statically positioned out-of-flow ruby base e.g.

<div>A<ruby><rb style="position: absolute">B</rb></ruby></div>

and

<div>A<span style="position: absolute">B</span></div>

should match layout where <rb> box's top is aligned with current line box's top position
(as if <rb> was inflow, which then puts "A" and "B" (somewhat) next to each other vertically).

However since we wrap such content (<rb>) inside an inline-block type anonymous box (RenderRubyBase), in practice
we match instead this:

<div>A

<span style="display: inline-block">

<span style="position: absolute">B</span>

</span>

</div>

where <rb>'s top is now aligned with the top of the wrapper inline-block box's top.
But this inline-block box sits on the line box's baseline with the height of 0 (it's inflow empty)
which makes the <rb> aligned with the line box's baseline instead of its top (and now "B" in below "A" under the baseline).

This patch fixes this by making sure that the (inflow empty) inline-block box's baseline is computed as if it had inflow content.

Test: fast/ruby/ruby-with-out-of-flow-base-content.html

rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::isEmptyOrHasInFlowContent const):

rendering/RenderRubyBase.h:
rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::baselinePosition const):

rendering/RenderRubyRun.h:

LayoutTests:

TestExpectations:
fast/ruby/ruby-with-out-of-flow-base-content-expected.html: Added.
fast/ruby/ruby-with-out-of-flow-base-content.html: Added.

10:43 AM Changeset in webkit [292225] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

[Linux] Implement IPC::Semaphore
https://bugs.webkit.org/show_bug.cgi?id=238596

Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-04-01
Reviewed by Adrian Perez de Castro.

Provide a Linux implementation for IPC::Semaphore that's based on
eventfd mechanics.

The IPC::Semaphore class now has a UNIX-specific file descriptor member
variable. For Linux, this file descriptor is an eventfd with semaphore
semantics (eventfd being Linux-specific). Signalling and waiting on
such semaphore is done through the read() and write() functions.
Non-Linux platforms are expected to provide something equivalent, if
possible.

For encoding and decoding that's necessary to move these semaphores
across process boundaries, IPC::Attachment is used. For encoding the
eventfd is simply duplicated and pushed into the Attachment, and for
decoding the Attachment's file descriptor is taken and adopted by the
Semaphore object.

Platform/IPC/IPCSemaphore.h:

(IPC::Semaphore::operator bool const):

Platform/IPC/unix/IPCSemaphoreUnix.cpp:

(IPC::Semaphore::Semaphore):
(IPC::Semaphore::~Semaphore):
(IPC::Semaphore::operator=):
(IPC::Semaphore::signal):
(IPC::waitImpl):
(IPC::Semaphore::wait):
(IPC::Semaphore::waitFor):
(IPC::Semaphore::encode const):
(IPC::Semaphore::decode):
(IPC::Semaphore::destroy):

10:22 AM Changeset in webkit [292224] by Ryan Haddad

3 edits in trunk/LayoutTests

REGRESSION(r292072): [ Mac iOS ] http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=238580

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

9:42 AM Changeset in webkit [292223] by Andres Gonzalez

3 edits in trunk/Source/WebCore

Add AXObjectCache::treeData() to retrieve serialized representation of the AX trees.
https://bugs.webkit.org/show_bug.cgi?id=238561
<rdar://problem/91055027>

Reviewed by Chris Fleizach.

Added AXObjectCache::treeData() to retrieve a serialized representation
of both the live and isolated AX trees. The immediate application of
this will be log to file the trees from the browser. Other application
down the road may be to expose a text document-like representation of
the web page for AT clients.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::treeData):

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::treeData):

8:35 AM Changeset in webkit [292222] by ntim@apple.com

13 edits in trunk

[css-logical] Add support for block/inline CSS values for resize property
https://bugs.webkit.org/show_bug.cgi?id=218088

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Marked relevant WPT as passing.

web-platform-tests/css/css-logical/logical-values-resize-expected.txt:

Source/WebCore:

Tests:

Parsing: imported/w3c/web-platform-tests/css/css-logical/logical-values-resize.html
Functionality: fast/css/resize-single-axis.html

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator Resize const):

css/CSSProperties.json:
css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

rendering/style/RenderStyleConstants.h:
rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

Add tests for functionality.

fast/css/resize-single-axis-expected.txt:
fast/css/resize-single-axis.html:

7:45 AM Changeset in webkit [292221] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Add RenderGrid parameter to resolveGridPositionsFromStyle
https://bugs.webkit.org/show_bug.cgi?id=238660

Patch by Rob Buis <rbuis@igalia.com> on 2022-04-01
Reviewed by Javier Fernandez.

The containing block of an out of flow grid item does
not have to be of type RenderGrid. To obtain the correct
RenderGrid pass it at the time the RenderGrid calls
resolveGridPositionsFromStyle.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::populateExplicitGridAndOrderIterator const):
(WebCore::RenderGrid::computeGridPositionsForOutOfFlowChild const):

rendering/style/GridPositionsResolver.cpp:

(WebCore::GridPositionsResolver::resolveGridPositionsFromStyle):

rendering/style/GridPositionsResolver.h:

7:39 AM Changeset in webkit [292220] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, update DerivedSources-output.xcfilelist to fix build.

DerivedSources-output.xcfilelist:

7:11 AM Changeset in webkit [292219] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Abort formatBlock command on null start or end selections
https://bugs.webkit.org/show_bug.cgi?id=238657

Patch by Rob Buis <rbuis@igalia.com> on 2022-04-01
Reviewed by Wenson Hsieh.

Abort formatBlock command in case selectionForParagraphIteration
returns with a null start or end selection due to inline table specific
adjustments.

editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::doApply):

6:12 AM Changeset in webkit [292218] by youenn@apple.com

24 edits in trunk

ServiceWorkerRegistration.getNotifications should list all persistent notifications
https://bugs.webkit.org/show_bug.cgi?id=238544

Reviewed by Darin Adler.

Source/WebCore:

Remove context based notification list since the list is global.
Add creation time to notification data.
Instead of reading the list locally, use the SWClient connection to get it.

Covered by updated test.

Modules/notifications/Notification.cpp:
Modules/notifications/Notification.h:
Modules/notifications/NotificationData.h:
workers/service/SWClientConnection.h:
workers/service/ServiceWorkerContainer.cpp:
workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerRegistration.cpp:
workers/service/ServiceWorkerRegistration.h:
workers/service/ServiceWorkerRegistration.idl:
workers/service/WorkerSWClientConnection.cpp:
workers/service/WorkerSWClientConnection.h:

Source/WebKit:

Go from WebProcess to UIProcess to read the notification map through IPC messaging.
Filter out the notifications according tag, origin and session.
Sort the notifications according creationTime with UIProcess identifier as tie breaker.

UIProcess/Notifications/WebNotificationManagerProxy.cpp:
UIProcess/Notifications/WebNotificationManagerProxy.h:
UIProcess/WebProcessProxy.cpp:
UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
UIProcess/WebsiteData/WebsiteDataStore.cpp:
WebProcess/Notifications/WebNotificationManager.cpp:
WebProcess/Storage/WebSWClientConnection.cpp:
WebProcess/Storage/WebSWClientConnection.h:

LayoutTests:

http/tests/workers/service/getnotifications-expected.txt:
http/tests/workers/service/getnotifications.html:

5:08 AM Changeset in webkit [292217] by Angelos Oikonomopoulos

2 edits in trunk/JSTests

Skip flaky test on mips
https://bugs.webkit.org/show_bug.cgi?id=238656

Unreviewed gardening.

stress/new-largeish-contiguous-array-with-size.js:

4:48 AM Changeset in webkit [292216] by youenn@apple.com

9 edits in trunk

Notification should be exposed to ServiceWorker contexts
https://bugs.webkit.org/show_bug.cgi?id=238548

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/notifications/idlharness.https.any.serviceworker-expected.txt:

Source/WebCore:

Mark Notification as exposed in ServiceWorker (not yet Worker as it would not be functional).
Add a dedicated createForServiceWorker routine that takes a registration URL to create persistent permissions.
Throw an exception in case of calling Notification constructor directly in a ServiceWorkerGlobalScope, as per spec.

Covered by updated and existing tests.

Modules/notifications/Notification.cpp:
Modules/notifications/Notification.h:
Modules/notifications/Notification.idl:
workers/service/ServiceWorkerRegistration.cpp:

LayoutTests:

http/tests/workers/service/resources/shownotification-worker.js:

4:00 AM Changeset in webkit [292215] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] Improve RTP stats gathering
https://bugs.webkit.org/show_bug.cgi?id=238602

Patch by Philippe Normand <philn@igalia.com> on 2022-04-01
Reviewed by Xabier Rodriguez-Calvar.

Proxy a few more stats fields from GstWebRTC to the WebCore StatsCollector.

Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:

(WebCore::fillInboundRTPStreamStats):
(WebCore::fillOutboundRTPStreamStats):

3:49 AM Changeset in webkit [292214] by ntim@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, fix obsolete FIXME comments in CSSParserFastPaths.cpp

overflow-anchor is still not implemented, and the visible value has been removed from the spec.
text-combine-upright was implemented in r287487

css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

2:17 AM Changeset in webkit [292213] by Carlos Garcia Campos

3 edits in trunk

[GTK][WPE] Enable CSS Typed OM by default
https://bugs.webkit.org/show_bug.cgi?id=238659

Reviewed by Adrian Perez de Castro.

Always build with Typed OM enabled, it's handled by an off by default setting.

Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:

2:05 AM Changeset in webkit [292212] by Carlos Garcia Campos

1 edit
1 add in trunk/Source/WebCore/platform/gtk/po

Croatian translation for WebKitGTK
https://bugs.webkit.org/show_bug.cgi?id=238611

Patch by gogo <trebelnik2@gmail.com> on 2022-04-01
Rubber-stamped by Carlos Garcia Campos.

hr.po: Added.

2:00 AM Changeset in webkit [292211] by Carlos Garcia Campos

11 edits in trunk/Source

REGRESSION(r290360): [GLX] Crash on process exit
https://bugs.webkit.org/show_bug.cgi?id=238494

Reviewed by Michael Catanzaro.

Source/WebCore:

When creating a PlatformDisplay from a shared GdkDisplay, we need to keep a reference to the display and connect
to closed signal to release our display dependent resources. Closed signal is emitted right before the native
display is actually closed by GDK. We also need to make sure that the sharing GL context is released before the
PlatformDisplay is destroyed. This is always happening for EGL because the sharing GL context is cleared before
terminating the EGL display in the atexit handler, but that's not the case of GLX. Since X11 only allows one
PlatformDisplay, which is always the shared one, we can just install an atexit handler in the constructor to
clear the sharing context before the destructor is called.

platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::createPlatformDisplay):
(WebCore::PlatformDisplay::PlatformDisplay):
(WebCore::PlatformDisplay::sharedDisplayDidClose):
(WebCore::PlatformDisplay::~PlatformDisplay):
(WebCore::PlatformDisplay::clearSharingGLContext):
(WebCore::PlatformDisplay::terminateEGLDisplay):

platform/graphics/PlatformDisplay.h:
platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:

(WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE):

platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::create):
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::sharedDisplayDidClose):

platform/graphics/wayland/PlatformDisplayWayland.h:
platform/graphics/win/PlatformDisplayWin.h:
platform/graphics/x11/PlatformDisplayX11.cpp:

(WebCore::PlatformDisplayX11::create):
(WebCore::clearSharingGLContextAtExit):
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
(WebCore::PlatformDisplayX11::sharedDisplayDidClose):

platform/graphics/x11/PlatformDisplayX11.h:

Source/WebKit:

WebProcess/gtk/WaylandCompositorDisplay.cpp:

(WebKit::WaylandCompositorDisplay::WaylandCompositorDisplay):

1:29 AM Changeset in webkit [292210] by Carlos Garcia Campos

45 edits
1 copy
2 adds
1 delete in trunk

Add support for element.computedStyleMap()
https://bugs.webkit.org/show_bug.cgi?id=238375

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Update test expectations.

web-platform-tests/css/css-color/system-color-compute-expected.txt:
web-platform-tests/css/css-properties-values-api/at-property-typedom-expected.txt:
web-platform-tests/css/css-properties-values-api/property-cascade-expected.txt:
web-platform-tests/css/css-properties-values-api/typedom-expected.txt:
web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt:
web-platform-tests/css/css-typed-om/idlharness-expected.txt:
web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-cssom-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/computed.tentative-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-auto-min-size-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-invalid-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-position-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-shorthand-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/getAll-shorthand-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/getAll.tentative-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/has.tentative-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/iterable.tentative-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/getAll-shorthand-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/getAll.tentative-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/has.tentative-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/iterable.tentative-expected.txt:
web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-interpolated-expected.txt:

Source/WebCore:

Covered by existing w3c tests.

CMakeLists.txt:
Sources.txt:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Add PropertyValueType parameter to get either the computed or
resolved value.

css/CSSComputedStyleDeclaration.h:
css/typedom/CSSStyleValueFactory.cpp:

(WebCore::CSSStyleValueFactory::reifyValue): Handle more cases of custom property.

css/typedom/ComputedStylePropertyMapReadOnly.cpp: Added.

(WebCore::ComputedStylePropertyMapReadOnly::create):
(WebCore::ComputedStylePropertyMapReadOnly::ComputedStylePropertyMapReadOnly):
(WebCore::ComputedStylePropertyMapReadOnly::get const):
(WebCore::ComputedStylePropertyMapReadOnly::getAll const):
(WebCore::ComputedStylePropertyMapReadOnly::has const):
(WebCore::ComputedStylePropertyMapReadOnly::size const):
(WebCore::ComputedStylePropertyMapReadOnly::entries const):

css/typedom/ComputedStylePropertyMapReadOnly.h: Added.
css/typedom/StylePropertyMapReadOnly.cpp:

(WebCore::StylePropertyMapReadOnly::reifyValueToVector): Returns a Vector so in case of CSSValueList, every
value is added to the vector.
(WebCore::StylePropertyMapReadOnly::Iterator::Iterator): Add iterator implementation, since this is now iterable.
(WebCore::StylePropertyMapReadOnly::Iterator::next): Ditto.

css/typedom/StylePropertyMapReadOnly.h:

(WebCore::StylePropertyMapReadOnly::createIterator):

css/typedom/StylePropertyMapReadOnly.idl:
dom/Element+ComputedStyleMap.idl: Added.
dom/Element.cpp:

(WebCore::Element::computedStyleMap): Get or create the computed style map.

dom/Element.h:
dom/ElementRareData.cpp:
dom/ElementRareData.h:

(WebCore::ElementRareData::computedStyleMap):
(WebCore::ElementRareData::setComputedStyleMap):
(WebCore::ElementRareData::useTypes const):

dom/NodeRareData.h:
dom/StyledElement.cpp:
html/CustomPaintImage.cpp:

LayoutTests:

Update test expectations.

platform/glib/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt:
platform/glib/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt:

1:26 AM Changeset in webkit [292209] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit

Translated applications cannot use remote methods with BOOL arguments
https://bugs.webkit.org/show_bug.cgi?id=238651
<rdar://90509457>

Reviewed by Geoffrey Garen.

Propagate the fix from r261155 to WKRemoteObjectCoder's method-signature-equality test as well,
so that BOOL arguments correctly compare as equal between a Rosetta application and its
native ARM Web Content process.

Shared/API/Cocoa/WKRemoteObjectCoder.h:
Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(WebKit::methodSignaturesAreCompatible):
(decodeInvocation):
Relax argument signature validation slightly, considering signed char and BOOL,
which are equivalent and sometimes substituted for each other, to be equal.

Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:

(-[_WKRemoteObjectRegistry _invokeMethod:]):
(blockSignaturesAreCompatible): Deleted.

1:17 AM Changeset in webkit [292208] by timothy_horton@apple.com

29 edits
2 adds in trunk

Add a debug overlay for interaction regions
https://bugs.webkit.org/show_bug.cgi?id=238187

Reviewed by Wenson Hsieh.

Source/WebCore:

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Node.cpp:

(WebCore::Node::willRespondToTouchEvents):

dom/Node.h:

Expose willRespondToTouchEvents, similar to willRespondToMouseMoveEvents.

page/DebugOverlayRegions.h:
page/DebugPageOverlays.cpp:

(WebCore::InteractionRegionOverlay::updateRegion):
(WebCore::pathsForRegion):
(WebCore::InteractionRegionOverlay::activeRegion):
(WebCore::drawCheckbox):
(WebCore::InteractionRegionOverlay::rectForSettingAtIndex):
(WebCore::InteractionRegionOverlay::valueForSetting):
(WebCore::InteractionRegionOverlay::drawSettings):
(WebCore::InteractionRegionOverlay::drawRect):
(WebCore::InteractionRegionOverlay::mouseEvent):
(WebCore::RegionOverlay::create):
(WebCore::DebugPageOverlays::updateOverlayRegionVisibility):

page/DebugPageOverlays.h:

(WebCore::DebugPageOverlays::didLayout):
(WebCore::DebugPageOverlays::didChangeEventHandlers):
(WebCore::DebugPageOverlays::doAfterUpdateRendering):
Add an overlay for indicating interaction regions.

page/FrameSnapshotting.cpp:

(WebCore::styleContainsComplexBackground):
(WebCore::estimatedBackgroundColorForRange):

page/FrameSnapshotting.h:
page/TextIndicator.cpp:

(WebCore::styleContainsComplexBackground): Deleted.
(WebCore::estimatedBackgroundColorForRange): Deleted.
Move estimatedBackgroundColorForRange from TextIndicator to
FrameSnapshotting for ease of reuse.

page/InteractionRegion.cpp: Added.

(WebCore::absoluteBoundingRectForRange):
(WebCore::regionForElement):
(WebCore::cursorTypeForElement):
(WebCore::interactionRegions):

page/InteractionRegion.h: Added.

(WebCore::InteractionRegion::encode const):
(WebCore::InteractionRegion::decode):
Add InteractionRegion, which keeps track of the location of and metadata
about interaction regions.

platform/graphics/LayoutSize.h:

(WebCore::LayoutSize::minDimension const):
(WebCore::LayoutSize::maxDimension const):

platform/graphics/RoundedRect.h:

(WebCore::RoundedRect::Radii::minimumRadius const):
Add minimumRadius() to Radii.

Source/WebKit:

Shared/mac/MediaFormatReader/MediaFormatReader.cpp:

Unified source fixes.

UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Add plumbing for a new debug overlay.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::interactionRegions):
(WebKit::WebPageProxy::interactableRegionsInRootViewCoordinates): Deleted.

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView interactionRegionsForHoverPlatter:inRect:completionHandler:]):
(-[WKContentView interactableRegionsForHoverPlatter:inRect:completionHandler:]): Deleted.

UIProcess/ios/WKHoverPlatter.h:
UIProcess/ios/WKHoverPlatter.mm:

(-[WKHoverPlatter updateDebugIndicator]):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::interactionRegions):
Move interactionRegions() from WebPage to WebCore::InteractionRegion.

(WebKit::WebPage::interactableRegionsInRootViewCoordinates): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

MiniBrowser/mac/SettingsController.h:
MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController interactionRegionOverlayVisible]):
(-[SettingsController preferenceKeyForRegionOverlayTag:]):

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]):
Add a switch for the new debug overlay in MiniBrowser.

1:03 AM Changeset in webkit [292207] by youenn@apple.com

8 edits
2 adds in trunk

Persistent notifications should work in document scopes as well as service worker global scopes
https://bugs.webkit.org/show_bug.cgi?id=238601

Reviewed by Brady Eidson.

Source/WebCore:

Add a m_serviceWorkerRegistrationURL in Notification to identify whether a notfication is persistent or not.
Set that field when creating a notification from NotificationData or from ServiceWorkerRegistration::showNotification.

Test: http/tests/workers/service/shownotification-allowed-document.html

Modules/notifications/Notification.cpp:

(WebCore::Notification::create):
(WebCore::Notification::data const):

Modules/notifications/Notification.h:
workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::showNotification):

Source/WebKit:

In case of notification message coming from a WebPage, check whether the notification is persistent or not.
If persistent, go to ServiceWorkerNotificationHandler, otherwise use the current code path through WebPageProxy.

UIProcess/Notifications/ServiceWorkerNotificationHandler.h:
UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:

(WebKit::WebNotificationManagerMessageHandler::showNotification):
(WebKit::WebNotificationManagerMessageHandler::cancelNotification):
(WebKit::WebNotificationManagerMessageHandler::clearNotifications):
(WebKit::WebNotificationManagerMessageHandler::didDestroyNotification):

LayoutTests:

http/tests/workers/service/shownotification-allowed-document-expected.txt: Added.
http/tests/workers/service/shownotification-allowed-document.html: Added.

12:11 AM Changeset in webkit [292206] by Diego Pino Garcia

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix non-unified build after r292191

runtime/ScriptExecutableInlines.h:

Mar 31, 2022:

10:52 PM Changeset in webkit [292205] by Wenson Hsieh

6 edits in trunk/Source

Add a heuristic to identify and extract the prominent video element in element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=238579

Reviewed by Jer Noble.

Source/WebCore:

Mark a couple of methods as WEBCORE_EXPORT so that they can be invoked from the WebKit layer.
No change in behavior (yet).

dom/Element.h:
html/HTMLMediaElement.h:

Drive-by-fix: also remove an (unused) function declaration with no implementation
(updatePlaybackControlsManager()).

Source/WebKit:

Add a heuristic to WebFullScreenManager that identifies and keeps track of the largest, rendered video element
in element fullscreen mode (that is, the video element with the largest area that's inside of the subtree of the
fullscreen container element). We couple this with a mechanism to detect when such a video has been paused for a
short (250 ms) delay.

These mechanisms will be used in a future patch to support "video extraction" in element fullscreen. See below
for more details.

WebProcess/FullScreen/WebFullScreenManager.cpp:

Turn WebFullScreenManager into an EventListener subclass, so that we can observe the "playing", "pause", and
"seeking" events on the main video element (if it exists). See handleEvent below for more information.

(WebKit::WebFullScreenManager::WebFullScreenManager):
(WebKit::WebFullScreenManager::exitFullScreenForElement):

Clear out the main video element upon exiting fullscreen.

(WebKit::WebFullScreenManager::didEnterFullScreen):

After we've finished entering element fullsreen, traverse the DOM in search of the largest video element (area-
wise). If the container for element fullscreen is, itself, a video element, then automatically treat that
element as the main video.

(WebKit::WebFullScreenManager::mainVideoElementExtractionTimerFired):
(WebKit::WebFullScreenManager::scheduleMainVideoElementExtraction):
(WebKit::WebFullScreenManager::endMainVideoElementExtractionIfNeeded):

For now, these are essentially no-ops; add FIXME's to call into WebPage to begin or cancel video extraction.
These will be implemented in an upcoming patch, that connects this element fullscreen code to a more generic
fullscreen video extraction mechanism implemented entirely in the client layer.

(WebKit::WebFullScreenManager::setMainVideoElement):

Add a helper method to set the main video element, adding or removing event listeners as needed.

(WebKit::WebFullScreenManager::handleEvent):

When observing any of the "playing", "pause", and "seeking" events, update the main video extraction timer;
that is, if the main video element is paused, restart the timer; otherwise, stop it entirely.

WebProcess/FullScreen/WebFullScreenManager.h:

10:23 PM Changeset in webkit [292204] by mmaxfield@apple.com

9 edits in trunk/Source/WebGPU

[WebGPU] There's no need to sprinkle std::optionals everywhere just for _Force32 enum values
https://bugs.webkit.org/show_bug.cgi?id=238434

For ABI compatibility, the shared header uses this pattern:

enum Foo {

Foo_AValue = 1,
Foo_AnotherValue = 2,
Foo_SomeOtherValue = 3,
Foo_Force32 = 0x7FFFFFFF

};

This is so that more values can be added to the enum without making it wider.

However, this means that if you want to switch over the values of Foo, you have to have
a dummy _Force32 case. These cases will never actually occur, and we have ASSERTs() for
them.

Originally, I made some functions return a std::optional<> so that there was some "empty"
value that could be returned in these case statements. That means that every caller of
any function that switches over any enum has to check the return value for nullopt. This
is pretty yucky.

And, indeed, it's all for nothing - the client calling into WebGPU can happily cast any
aribtrary integer to a Foo can call our functions, so the cases for the _Force32 values
should be no different. Therefore, we can just say "in order to call WebGPU functions,
it's illegal to pass in the _Force32 values (just as it would be illegal to pass in
unassigned values)." This means we can clean up the code a bit, and remove a bunch of
nullopt checks.

Reviewed by Dean Jackson.

WebGPU/BindGroupLayout.mm:

(WebGPU::createArgumentDescriptor):

WebGPU/Buffer.mm:

(WebGPU::Buffer::mapAsync):

WebGPU/CommandEncoder.mm:

(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::copyTextureToBuffer):

WebGPU/Instance.mm:

(WebGPU::sortedDevices):

WebGPU/Queue.mm:

(WebGPU::Queue::writeTexture):

WebGPU/Sampler.mm:

(WebGPU::addressMode):
(WebGPU::minMagFilter):
(WebGPU::mipFilter):
(WebGPU::compareFunction):
(WebGPU::Device::createSampler):

WebGPU/Texture.h:
WebGPU/Texture.mm:

(WebGPU::featureRequirementForFormat):
(WebGPU::isCompressedFormat):
(WebGPU::stencilSpecificFormat):
(WebGPU::Texture::texelBlockWidth):
(WebGPU::Texture::texelBlockHeight):
(WebGPU::isRenderableFormat):
(WebGPU::supportsMultisampling):
(WebGPU::maximumMiplevelCount):
(WebGPU::hasStorageBindingCapability):
(WebGPU::Device::validateCreateTexture):
(WebGPU::pixelFormat):
(WebGPU::depthOnlyAspectMetalFormat):
(WebGPU::stencilOnlyAspectMetalFormat):
(WebGPU::Device::createTexture):
(WebGPU::Texture::resolveTextureViewDescriptorDefaults const):
(WebGPU::Texture::validateCreateView const):
(WebGPU::Texture::createView):
(WebGPU::Texture::refersToSingleAspect):

10:09 PM Changeset in webkit [292203] by mmaxfield@apple.com

2 edits in trunk/Source/WebGPU

[WebGPU] etc2-rgba8unorm and etc2-rgba8unorm-srgb are not handled
https://bugs.webkit.org/show_bug.cgi?id=238435

Reviewed by Dean Jackson.

They map to MTLPixelFormatEAC_RGBA8 and MTLPixelFormatEAC_RGBA8_sRGB.

WebGPU/Texture.mm:

(WebGPU::pixelFormat):
(WebGPU::Device::createTexture):

10:04 PM Changeset in webkit [292202] by mmaxfield@apple.com

2 edits in trunk/Source/WebGPU

[WebGPU] 2 texture formats need to be guarded behind optional extensions
https://bugs.webkit.org/show_bug.cgi?id=238433

Reviewed by Dean Jackson.

WGPUTextureFormat_Depth24UnormStencil8 needs to be guarded behind WGPUFeatureName_Depth24UnormStencil8
and WGPUTextureFormat_Depth32FloatStencil8 needs to be guarded behind WGPUFeatureName_Depth32FloatStencil8.

WebGPU/Texture.mm:

(WebGPU::featureRequirementForFormat):

10:00 PM Changeset in webkit [292201] by mmaxfield@apple.com

2 edits in trunk/Source/WebGPU

[WebGPU] Implement Queue::writeTexture() according to the spec
https://bugs.webkit.org/show_bug.cgi?id=238432

Reviewed by Dean Jackson.

This implements Queue::writeTexture() according to the spec.
It re-uses many of the helper functions added in
https://bugs.webkit.org/show_bug.cgi?id=238428. There are links and quotes from
the spec where appropriate.

WebGPU/Queue.mm:

(WebGPU::Queue::writeBuffer):
(WebGPU::validateWriteTexture):
(WebGPU::Queue::writeTexture):

9:50 PM Changeset in webkit [292200] by mmaxfield@apple.com

2 edits in trunk/Source/WebGPU

[WebGPU] Implement CommandEncoder::copyTextureToTexture() according to the spec
https://bugs.webkit.org/show_bug.cgi?id=238431

Reviewed by Dean Jackson.

This implements CommandEncoder::copyTextureToBuffer() according to the spec.
It re-uses many of the helper functions added in
https://bugs.webkit.org/show_bug.cgi?id=238428. There are links and quotes from
the spec where appropriate.

WebGPU/CommandEncoder.mm:

(WebGPU::refersToAllAspects):
(WebGPU::isSRGBCompatible):
(WebGPU::areCopyCompatible):
(WebGPU::validateCopyTextureToTexture):
(WebGPU::CommandEncoder::copyTextureToTexture):

9:48 PM Changeset in webkit [292199] by mmaxfield@apple.com

4 edits in trunk/Source/WebGPU

[WebGPU] Implement CommandEncoder::copyTextureToBuffer() according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=238430

Reviewed by Dean Jackson.

WebGPU/CommandEncoder.mm:

(WebGPU::validateCopyTextureToBuffer):
(WebGPU::CommandEncoder::copyTextureToBuffer):

WebGPU/Texture.h:
WebGPU/Texture.mm:

(WebGPU::Texture::isValidImageCopySource):

8:39 PM Changeset in webkit [292198] by Said Abou-Hallawa

5 edits in trunk

[GPU Process] [iOS] Vertical text is incorrectly displaced
https://bugs.webkit.org/show_bug.cgi?id=232917
rdar://85483031

Reviewed by Myles C. Maxfield.

Source/WebCore:

DrawGlyphsRecorder calls FontCascade::drawGlyphs() which calls CoreText
to draw the vertical text to its internal context. This internal context
is setup to be called back for every single run. When CoreText calls
DrawGlyphsRecorder::recordDrawGlyphs(), it records drawing the glyph runs
into the owner recorder. The problem is CoreText passes the transformed
positions to recordDrawGlyphs(). To call drawGlyphsAndCacheFont() in the
recorder we have to pass the un-transformed anchor point. To get this anchor
point, we have to apply the inverse of fillVectorWithVerticalGlyphPositions()
to the first transformed position.

platform/graphics/GraphicsContext.h:
platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:

(WebCore::DrawGlyphsRecorder::recordDrawGlyphs):

LayoutTests:

Unskip failed vertical text layout tests.

platform/ios-wk2/TestExpectations:

7:49 PM Changeset in webkit [292197] by Chris Dumez

171 edits
1 copy in trunk

Prepare WebKit/ & WebKitLegacy/ for making the String(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=238525

Reviewed by Darin Adler.

Source/WebCore:

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::createOrMigrateRecordsTableIfNecessary):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidBlobTables):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsRecordIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidObjectStoreInfoTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameAndVersionFromFile):

Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm:

(WebCore::writeToTemporaryFile):

Modules/webdatabase/Database.cpp:

(WebCore::Database::performOpenAndVerify):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::trackerDatabasePath const):
(WebCore::DatabaseTracker::openTrackerDatabase):

bindings/js/GCController.cpp:

(WebCore::GCController::dumpHeap):

contentextensions/SerializedNFA.cpp:

(WebCore::ContentExtensions::SerializedNFA::serialize):

contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::URLFilterParser::addPattern):

contentextensions/URLFilterParser.h:
loader/ResourceLoadStatistics.cpp:

(WebCore::appendBoolean):

page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::fromDatabaseIdentifier):

page/SecurityOriginData.h:
platform/graphics/cg/ImageUtilitiesCG.cpp:

(WebCore::transcodeImage):

platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFilesForIndexedDB):

platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::tableExists):
(WebCore::SQLiteDatabase::tableSQL):
(WebCore::SQLiteDatabase::indexSQL):
(WebCore::SQLiteDatabase::inMemoryPath): Deleted.

platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::inMemoryPath):

platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::appendDatabaseFileNameToPath):
(WebCore::SQLiteFileSystem::computeHashForFileName):

platform/sql/SQLiteFileSystem.h:

Source/WebKit:

GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::workQueueInitialize):

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::appendBoolean):
(WebKit::ResourceLoadStatisticsDatabaseStore::getSubStatisticStatement const):
(WebKit::ResourceLoadStatisticsDatabaseStore::appendSubStatisticList const):
(WebKit::ResourceLoadStatisticsDatabaseStore::resourceToString const):

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):

NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deletePushAndNotificationRegistration):

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::logCookieInformation const):
(WebKit::logBlockedCookieInformation):
(WebKit::logCookieInformationInternal):
(WebKit::NetworkResourceLoader::logCookieInformation):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:

(WebKit::PCM::Database::clearPrivateClickMeasurement):
(WebKit::PCM::Database::addDestinationTokenColumnsIfNecessary):
(WebKit::PCM::Database::columnsForTable):
(WebKit::PCM::Database::addMissingColumnToTable):

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h:
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp:

(WebKit::PrivateClickMeasurementManager::getSignedUnlinkableTokenForDestination):
(WebKit::PrivateClickMeasurementManager::handleAttribution):

NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databasePath const):

NetworkProcess/WebStorage/LocalStorageDatabaseTracker.h:
NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::get):

NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::mapFile):

NetworkProcess/cache/NetworkCacheData.h:
NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:

(WebKit::LaunchServicesDatabaseObserver::handleEvent):

NetworkProcess/storage/SQLiteStorageArea.cpp:

(WebKit::SQLiteStorageArea::createTableIfNecessary):

Platform/IPC/JSIPCBinding.cpp:

(IPC::jsValueForDecodedArgumentValue):

Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb:
Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb:
Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject):

Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:

(-[_WKRemoteObjectRegistry _sendInvocation:interface:]):
(replyBlockSignature):
(-[_WKRemoteObjectRegistry _invokeMethod:]):

Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::stringByResolvingSymlinksInPath):
(WebKit::resolveAndCreateReadWriteDirectoryForSandboxExtension):
(WebKit::resolvePathForSandboxExtension):
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandle):
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
(WebKit::SandboxExtension::createHandleForTemporaryFile):
(WebKit::SandboxExtension::createHandleForReadByAuditToken):

Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getClientIdentifier):
(WebKit::XPCServiceInitializerDelegate::getClientBundleIdentifier):
(WebKit::XPCServiceInitializerDelegate::getClientProcessName):
(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):

Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceMain):

Shared/IPCTester.cpp:

(WebKit::messageTestDriver):

Shared/InspectorExtensionTypes.cpp:

(Inspector::extensionErrorToString):

Shared/SandboxExtension.h:

(WebKit::SandboxExtension::createHandle):
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
(WebKit::SandboxExtension::createHandleForTemporaryFile):
(WebKit::stringByResolvingSymlinksInPath):
(WebKit::resolvePathForSandboxExtension):
(WebKit::resolveAndCreateReadWriteDirectoryForSandboxExtension):

Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::sandboxDataVaultParentDirectory):
(WebKit::getUserDirectorySuffix):
(WebKit::populateSandboxInitializationParameters):

Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent):

UIProcess/API/APIContentRuleListStore.cpp:

(API::openAndMapContentRuleList):

UIProcess/API/C/WKDownloadRef.cpp:

(WKDownloadSetClient):

UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionHistoryURLValueType):
(WKPageGetSessionBackForwardListItemValueType):
(WKPageSetPageUIClient):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):

UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:

(API::ContentRuleListStore::defaultStorePath):

UIProcess/API/Cocoa/WKContentRuleListStore.mm:

(+[WKContentRuleListStore storeWithURL:]):
(+[WKContentRuleListStore storeWithURLAndLegacyFilename:]):

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):

UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::getLaunchOptions):

UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm:

(WebKit::SubFrameSOAuthorizationSession::loadRequestToFrame):

UIProcess/Cocoa/WebKitSwiftSoftLink.mm:

(WebKit::WebKitSwiftLibrary):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):

UIProcess/Cocoa/WebViewImpl.mm:

(-[WKTextTouchBarItemController _wkChangeTextStyle:]):
(-[WKTextTouchBarItemController _wkChangeTextAlignment:]):
(-[WKTextTouchBarItemController _wkChangeColor:]):
(WebKit::WebViewImpl::insertText):

UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::getSecurityOriginData):
(WebKit::DeviceIdHashSaltStorage::getDataFromDecoder const):
(WebKit::DeviceIdHashSaltStorage::createEncoderFromData const):

UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:

(WebKit::ProcessLauncher::launchProcess):

UIProcess/Network/NetworkProcessProxyCocoa.mm:

(WebKit::NetworkProcessProxy::XPCEventHandler::handleXPCEvent const):

UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):

UIProcess/ViewGestureController.cpp:

(WebKit::ViewGestureController::SnapshotRemovalTracker::log const):
(WebKit::ViewGestureController::SnapshotRemovalTracker::reset):
(WebKit::ViewGestureController::SnapshotRemovalTracker::stopWaitingForEvent):
(WebKit::ViewGestureController::SnapshotRemovalTracker::eventOccurred):
(WebKit::ViewGestureController::SnapshotRemovalTracker::cancelOutstandingEvent):
(WebKit::ViewGestureController::SnapshotRemovalTracker::fireRemovalCallbackIfPossible):
(WebKit::stopWaitingForEvent): Deleted.

UIProcess/ViewGestureController.h:
UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.mm:

(WebKit::base64PrivateKey):

UIProcess/WebAuthentication/Virtual/VirtualHidConnection.cpp:

(WebKit::VirtualHidConnection::parseRequest):

UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:

(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):

UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::WebPageGroup):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createRealtimeMediaSourceForSpeechRecognition):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::didReceiveInvalidMessage):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::notifyPageStatisticsAndDataRecordsProcessed):
(WebKit::WebProcessProxy::notifyWebsiteDataScanForRegistrableDomainsFinished):
(WebKit::WebProcessProxy::notifyWebsiteDataDeletionForRegistrableDomainsFinished):
(WebKit::WebProcessProxy::createSpeechRecognitionServer):

UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultApplicationCacheDirectory):
(WebKit::WebsiteDataStore::defaultCacheStorageDirectory):
(WebKit::WebsiteDataStore::defaultGeneralStorageDirectory):
(WebKit::WebsiteDataStore::defaultNetworkCacheDirectory):
(WebKit::WebsiteDataStore::defaultAlternativeServicesDirectory):
(WebKit::WebsiteDataStore::defaultMediaCacheDirectory):
(WebKit::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::defaultLocalStorageDirectory):
(WebKit::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(WebKit::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(WebKit::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):
(WebKit::WebsiteDataStore::defaultModelElementCacheDirectory):
(WebKit::WebsiteDataStore::tempDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):

WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::formatNameFromWebRTCCodecType):

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetComposition):

WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::increaseBufferedAmount):

WebProcess/Network/WebSocketStream.cpp:

(WebKit::WebSocketStream::networkProcessCrashed):

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel):
(WebKit::PDFPlugin::threadEntry):
(WebKit::PDFPlugin::adoptBackgroundThreadDocument):
(WebKit::PDFPlugin::pluginInfo):
(WebKit::PDFPlugin::addArchiveResource):
(WebKit::PDFPlugin::setSuggestedFilename):
(WebKit::PDFPlugin::initialize):

WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::cssAlignmentValueForNSTextAlignment):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:

(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):

WebProcess/WebCoreSupport/WebFileSystemStorageConnection.cpp:

(WebKit::WebFileSystemStorageConnection::isSameEntry):
(WebKit::WebFileSystemStorageConnection::getFileHandle):
(WebKit::WebFileSystemStorageConnection::getDirectoryHandle):
(WebKit::WebFileSystemStorageConnection::removeEntry):
(WebKit::WebFileSystemStorageConnection::resolve):
(WebKit::WebFileSystemStorageConnection::getFile):
(WebKit::WebFileSystemStorageConnection::createSyncAccessHandle):
(WebKit::WebFileSystemStorageConnection::closeSyncAccessHandle):
(WebKit::WebFileSystemStorageConnection::getHandleNames):
(WebKit::WebFileSystemStorageConnection::getHandle):
(WebKit::WebFileSystemStorageConnection::move):

WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:

(WebKit::WebSpeechSynthesisClient::speak):

WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::changeWordCase):

WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder):
(IPC::jsValueForDecodedArgumentValue):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::layerTreeAsText const):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::transientZoomSnapAnimationForKeyPath):
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):

WebProcess/cocoa/LaunchServicesDatabaseManager.mm:

(WebKit::LaunchServicesDatabaseManager::handleEvent):

webpushd/AppBundleRequest.mm:

(WebPushD::AppBundleDeletionRequest::didDeleteExistingBundleWithError):

webpushd/PushClientConnection.h:
webpushd/PushClientConnection.mm:

(WebPushD::ClientConnection::broadcastDebugMessage):
(WebPushD::ClientConnection::sendDebugMessage):

webpushd/WebPushDaemon.h:
webpushd/WebPushDaemon.mm:

(WebPushD::Daemon::broadcastDebugMessage):
(WebPushD::Daemon::deletePushAndNotificationRegistration):

webpushd/WebPushDaemonMain.mm:

(WebKit::WebPushDaemonMain):

Source/WebKitLegacy:

Storage/StorageTracker.cpp:

(WebKit::StorageTracker::tracker):

Source/WebKitLegacy/cf:

WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::setInspectorAttachDisabled):
(WebInspectorClient::setInspectorStartsAttached):

Source/WebKitLegacy/mac:

History/HistoryPropertyList.mm:

(HistoryPropertyListWriter::writeObjects):

WebCoreSupport/WebApplicationCache.mm:

(webApplicationCacheStorage):

WebCoreSupport/WebSecurityOrigin.mm:

(WebCore::SecurityOriginData::fromDatabaseIdentifier):

WebView/WebHTMLView.mm:

(createSelectorExceptionMap):
(-[WebHTMLView coreCommandByName:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView insertText:]):

WebView/WebView.mm:

(+[WebView _decodeData:]):

Source/WTF:

wtf/FileSystem.h: