⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 3, 2022:

11:18 PM Changeset in webkit [292279] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

Make it hard to add a new CSS property to WebKit wihtout adding animation support
​https://bugs.webkit.org/show_bug.cgi?id=238447

Reviewed by Dean Jackson.

It's easy to add a new CSS property to WebKit without thinking about animation support.
Down the line, it would be better to add support to the script dealing with CSSProperties.json
to automatically generate animation support where possible, but to get started we now
ASSERT() whether all properties have been found to have animated support, except those
known not to be animatable.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

7:35 PM Changeset in webkit [292278] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Standardize naming of WK_NETWORK_EXTENSION_LDFLAGS (from LD_FLAGS)
​https://bugs.webkit.org/show_bug.cgi?id=238717

Reviewed by Wenson Hsieh.

No new tests, just a style fix.

  • Configurations/WebCore.xcconfig:
6:14 PM Changeset in webkit [292277] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Document::addListenerTypeIfNeeded should not call pthread_get_specific 14 times
​https://bugs.webkit.org/show_bug.cgi?id=238702

Reviewed by Cameron McCormack.

Document::addListenerTypeIfNeeded => pthread_get_specific showed up in
a profile of Preact-TodoMVC, and I verified by disassembly that the
generated code really does call pthread_get_specific 14x, along with
related inefficiencies.

Only worth about 0.5%, so I didn't A/B test it.

You could imagine lots of other ways to speed up this function /
functionality, but why don't we start with 14x and see where that takes
us.

  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded): Use a local variable
because, like, come on.

12:51 PM Changeset in webkit [292276] by Tyler Wilcock
  • 2 edits in trunk/Source/WebCore

-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:] should fail fast if the given parameter wrapper has no backing object
​https://bugs.webkit.org/show_bug.cgi?id=238635

Reviewed by Chris Fleizach.

If this method is called with a parameter wrapper object that has lost
its backing object, we should return early to avoid dereferencing a
null pointer.

This could happen in rare split-second transition states where a wrapper
has lost its backing object but has not yet been cleaned up by a notification.
This could also happen if WebKit is vending detached objects (e.g. via AXChildren)
in a similar transition state.

No test added because I haven't been able to find any scenario reproducing
this issue either in our existing layout tests or on real webpages.

rdar://90925399

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

1:04 AM Changeset in webkit [292275] by timothy_horton@apple.com
  • 6 edits in trunk/Source

_WKDataTask doesn't work in macCatalyst
​https://bugs.webkit.org/show_bug.cgi?id=238655

Reviewed by Alexey Proskuryakov.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]): Deleted.

Source/WTF:

  • wtf/PlatformHave.h:

Enable HAVE(NSURLSESSION_TASK_DELEGATE) on macCatalyst.
Drive-by enable a few other things on macCatalyst.
Remove and simplify some always-true version checks.
Leave some comments about ones I'm not sure about.

Apr 2, 2022:

10:39 PM Changeset in webkit [292274] by mmaxfield@apple.com
  • 13 edits
    2 adds in trunk

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

  • page/Page.cpp:

(WebCore::m_contentSecurityPolicyModeForExtension):
(WebCore::Page::firstTimeInitialization):

  • page/Page.h:
  • platform/graphics/FontCache.cpp:

(WebCore::Function<void):
(WebCore::FontCache::registerFontCacheInvalidationCallback):
(WebCore::FontCache::invalidateAllFontCaches):

  • platform/graphics/FontCache.h:

Tools:

Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::clearResourceLoadStatistics):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::dumpResourceLoadStatistics):

LayoutTests:

  • TestExpectations:
  • fast/text/install-font-style-recalc-expected.txt: Added.
  • fast/text/install-font-style-recalc.html: Added.
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
10:24 PM Changeset in webkit [292273] by Simon Fraser
  • 24 edits in trunk/Source

Plumb the IOSurfacePool through to ImageBufferBackend creation via ImageBuffer::CreationContext
​https://bugs.webkit.org/show_bug.cgi?id=238695

Reviewed by Said Abou-Hallawa.

Wrap the existing HostWindow* and a new IOSurfacePool* pointers into a ImageBuffer::CreationContext
struct, and replace the HostWindow* argument with it in buffer creation functions.

RemoteLayerBackingStoreCollection::allocateBufferForBackingStore() passes the singleton IOSurfacePool
which is thus used in the non-GPU Process code path (DOM rendering disabled).

Source/WebCore:

  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

  • platform/graphics/ConcreteImageBuffer.h:

(WebCore::ConcreteImageBuffer::create):

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::create):

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::CreationContext::CreationContext):
(WebCore::ImageBuffer::create):

  • platform/graphics/ImageBufferBackend.h:
  • platform/graphics/PlatformImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::create):

  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.h:
  • platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::poolStatistics const):

  • platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:

(WebCore::ImageBufferCGBitmapBackend::create):

  • platform/graphics/cg/ImageBufferCGBitmapBackend.h:
  • platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::create):

  • platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
  • platform/graphics/displaylists/DisplayListImageBuffer.h:

Source/WebKit:

  • Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:

(WebKit::CGDisplayListImageBufferBackend::create):

  • Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureFrontBuffer):

  • Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:

(WebKit::RemoteLayerBackingStoreCollection::allocateBufferForBackingStore):

  • WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::create):

  • WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
  • WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):

  • WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.h:
8:56 PM Changeset in webkit [292272] by Chris Dumez
  • 43 edits in trunk/Source

Add default constructor to ASCIILiteral
​https://bugs.webkit.org/show_bug.cgi?id=238700

Reviewed by Geoffrey Garen.

Add default constructor to ASCIILiteral, to replace the more verbose ASCIILiteral::null().

Source/JavaScriptCore:

  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
  • Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
  • Scripts/wkbuiltins/builtins_model.py:

(BuiltinFunction.fromString):

  • runtime/ArrayBufferSharingMode.h:

(JSC::arrayBufferSharingModeName):

  • runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::usageString):
(JSC::IntlCollator::sensitivityString):
(JSC::IntlCollator::caseFirstString):

  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::hourCycleString):
(JSC::IntlDateTimeFormat::weekdayString):
(JSC::IntlDateTimeFormat::eraString):
(JSC::IntlDateTimeFormat::yearString):
(JSC::IntlDateTimeFormat::monthString):
(JSC::IntlDateTimeFormat::dayString):
(JSC::IntlDateTimeFormat::dayPeriodString):
(JSC::IntlDateTimeFormat::hourString):
(JSC::IntlDateTimeFormat::minuteString):
(JSC::IntlDateTimeFormat::secondString):
(JSC::IntlDateTimeFormat::timeZoneNameString):
(JSC::IntlDateTimeFormat::formatStyleString):

  • runtime/IntlDisplayNames.cpp:

(JSC::IntlDisplayNames::styleString):
(JSC::IntlDisplayNames::typeString):
(JSC::IntlDisplayNames::fallbackString):
(JSC::IntlDisplayNames::languageDisplayString):

  • runtime/IntlListFormat.cpp:

(JSC::IntlListFormat::styleString):
(JSC::IntlListFormat::typeString):

  • runtime/IntlLocale.cpp:

(JSC::IntlLocale::initializeLocale):

  • runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::styleString):
(JSC::IntlNumberFormat::currencyDisplayString):
(JSC::IntlNumberFormat::notationString):
(JSC::IntlNumberFormat::currencySignString):
(JSC::IntlNumberFormat::unitDisplayString):
(JSC::IntlNumberFormat::compactDisplayString):
(JSC::IntlNumberFormat::signDisplayString):
(JSC::IntlNumberFormat::roundingModeString):
(JSC::IntlNumberFormat::trailingZeroDisplayString):
(JSC::IntlNumberFormat::roundingPriorityString):

  • runtime/IntlObject.cpp:

(JSC::relevantExtensionKeyString):

  • runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):
(JSC::IntlRelativeTimeFormat::styleString):

  • runtime/IntlSegmenter.cpp:

(JSC::IntlSegmenter::granularityString):

  • runtime/JSObjectInlines.h:

(JSC::JSObject::putDirectInternal):

  • runtime/TemporalDuration.cpp:

(JSC::TemporalDuration::total const):

  • runtime/TemporalObject.cpp:

(JSC::temporalLargestUnit):
(JSC::temporalSmallestUnit):

  • yarr/YarrErrorCode.cpp:

(JSC::Yarr::errorMessage):

Source/WebCore:

  • css/makevalues.pl:
  • dom/DOMException.cpp:

(WebCore::DOMException::description const):

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::imageTypeToFakeFilename):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::propertyIdToString):

Source/WebKit:

  • NetworkProcess/WebStorage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::migrateItemTableIfNeeded):

  • UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::sendMessage):

  • WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::setDockSide):

Source/WebKitLegacy:

  • Storage/StorageAreaSync.cpp:

(WebKit::StorageAreaSync::migrateItemTableIfNeeded):

Source/WTF:

  • wtf/cocoa/ResourceUsageCocoa.cpp:

(WTF::displayNameForVMTag):

  • wtf/text/ASCIILiteral.h:
2:52 PM Changeset in webkit [292271] by Andres Gonzalez
  • 3 edits in trunk/Tools

Add to MiniBrowser the ability to log a textual representation of the AX trees for the current page.
​https://bugs.webkit.org/show_bug.cgi?id=238566
<rdar://problem/91059308>

Reviewed by Chris Fleizach and Simon Fraser.

MiniBrowser can now log a textual representation of the AX trees via
Debug > Log Accessibility Trees menu item, or pressing the keystroke
Cmd Opt A.

  • MiniBrowser/mac/MainMenu.xib:
  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController logAccessibilityTrees:]):

2:03 PM Changeset in webkit [292270] by Alan Bujtas
  • 21 edits in trunk

[Ruby] Remove incorrect implicit integral floor in RenderRubyText::adjustInlineDirectionLineBounds
​https://bugs.webkit.org/show_bug.cgi?id=238671

Reviewed by Simon Fraser.

Source/WebCore:

In case of a fractional width value, the unintended integral flooring makes us believe we've got content overflow and we apply
a fractional inset which slightly moves the content in the inline direction.

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::adjustInlineDirectionLineBounds const):

LayoutTests:

  • TestExpectations:
  • fast/ruby/bopomofo-mixed-expected.txt:
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/mac/fast/ruby/bopomofo-expected.txt:
  • platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt:
  • platform/mac/fast/ruby/bopomofo-rl-expected.txt:
  • platform/mac/fast/ruby/ruby-run-break-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/mac/fast/ruby/ruby-text-before-after-content-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
1:36 PM Changeset in webkit [292269] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

AI should do int32 optimization in ValueRep
​https://bugs.webkit.org/show_bug.cgi?id=238699

Reviewed by Saam Barati.

When constant folding an int52 into a ValueRep AI doesn't
do our normal int32 boxing optimization. I'm not sure if
it matters since I couldn't find a test but it probably
doesn't hurt.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

11:38 AM Changeset in webkit [292268] by Ziran Sun
  • 8 edits in trunk

[css-ui] Only apply 'overflow:visible' to elements that support menulist appearance
​https://bugs.webkit.org/show_bug.cgi?id=238501

Reviewed by Tim Nguyen.

Source/WebCore:

This CL adds support to alias appearance <compat-auto> keywords to 'auto' for menulist.
When an element supports '-webkit-appearance: menulist' or 'appearance: menulist' appearance,
we will apply 'overflow: visible'. The existing code, though, apply 'overflow: visible' before
the 'menulist' appearance is workable. This patch corrects it.

It is an import of chromium CL at
​https://chromium.googlesource.com/chromium/src.git/+/1635202d8979f4d42b96021d8386278261e52768

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustAppearanceForElement const):
(WebCore::RenderTheme::adjustMenuListStyle const):

  • rendering/RenderThemeAdwaita.cpp:

(WebCore::RenderThemeAdwaita::adjustMenuListStyle const):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustMenuListStyle const):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustMenuListStyle const):

  • style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

LayoutTests:

Unskip the tests that are now passing.

9:36 AM Changeset in webkit [292267] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit

[Cocoa] semaphore_timedwait() can return KERN_ABORTED
​https://bugs.webkit.org/show_bug.cgi?id=238694

Reviewed by Geoffrey Garen.

I was hitting this assert while debugging WebKit today.

  • Platform/IPC/darwin/IPCSemaphoreDarwin.cpp:

(IPC::Semaphore::waitFor):

9:22 AM Changeset in webkit [292266] by Patrick Griffis
  • 8 edits in trunk

CSP: Improve compatibility of source matching
​https://bugs.webkit.org/show_bug.cgi?id=235873

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update expectation as passing.

  • web-platform-tests/content-security-policy/connect-src/connect-src-websocket-self.sub-expected.txt:

Source/WebCore:

  • Improved handling of protocol changes:
    • For host and self sources direct upgrades are allowed (ws->wss) (http->https already worked).
    • For self sources side grades are now allowed (http->ws).
    • For self sources upgrades are always allowed (*->https, *->wss).

This is documented here: ​https://www.w3.org/TR/CSP3/#match-url-to-source-expression

I also included some minor cleanups and adding of comments.

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::updateSourceSelf):
(WebCore::ContentSecurityPolicy::protocolMatchesSelf const): Deleted.

  • page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::selfProtocol const):

  • page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::ContentSecurityPolicySource):
(WebCore::ContentSecurityPolicySource::matches const):
(WebCore::ContentSecurityPolicySource::schemeMatches const):
(WebCore::ContentSecurityPolicySource::portMatches const):

  • page/csp/ContentSecurityPolicySource.h:
  • page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::ContentSecurityPolicySourceList::isProtocolAllowedByStar const):
(WebCore::ContentSecurityPolicySourceList::parse):

8:59 AM Changeset in webkit [292265] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit

GTK doesn't compile with ENABLE_ACCESSIBILITY=0
​https://bugs.webkit.org/show_bug.cgi?id=238669

Reviewed by Michael Catanzaro.

Fix GTK compilation with ENABLE_ACCESSIBILITY=0

No new tests.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDispose):
(webkit_web_view_base_class_init):

6:35 AM Changeset in webkit [292264] by Andres Gonzalez
  • 11 edits in trunk/Source

Expose AXObjectCache::treeData to the UI process.
​https://bugs.webkit.org/show_bug.cgi?id=238563
<rdar://problem/91057915>

Reviewed by Chris Fleizach.

Source/WebCore:

Added Page::accessibilityTreeData so that it can be invoked from the UI
process. This will be used to log a textual representation of the AX
trees from the browser process.

  • page/Page.cpp:

(WebCore::Page::accessibilityTreeData const):

  • page/Page.h:

Source/WebKit:

Exposed Page::accessibilityTreeData so that it can be invoked from the UI
process. This will be used to log a textual representation of the AX
trees from the browser process.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView retrieveAccessibilityTreeData:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getAccessibilityTreeData):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getAccessibilityTreeData):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
3:57 AM Changeset in webkit [292263] by Adrian Perez de Castro
  • 198 edits
    7 adds
    9 deletes in trunk

[GTK] Replace gtk-doc with gi-docgen
​https://bugs.webkit.org/show_bug.cgi?id=226662

Reviewed by Michael Catanzaro.

Import two new CMake modules which define commands to easy setup of GObject-Introspection
and gi-docgen. These in turn allow to remove a bunch of duplicated CMake code, reuse
the same for both the WPE and GTK ports, and remove the gnarly DocBook templates and
other auxiliary files previously used by gtk-doc (which amount to a sizeable amount of
code).

While at it, do a quick pass to fix the most egregious issues reported by gi-docgen's
linting mode and that all public symbols end up with at least some documentation in
the generated output. Follow-up patches will be needed to keep adapting to the style
encouraged by gi-docgen, fix linking between documented entities, make code examples
display properly, and a few other things.

.:

  • Source/PlatformGTK.cmake: Adapted to use the new CMake modules.
  • Source/PlatformWPE.cmake: Ditto.
  • Source/cmake/FindGI.cmake: Added.
  • Source/cmake/FindGIDocgen.cmake: Added.
  • Source/cmake/FindGObjectIntrospection.cmake: Removed.
  • Source/cmake/OptionsGTK.cmake: Adapted to use the new CMake modules.
  • Source/cmake/OptionsWPE.cmake: Ditto.

Source/JavaScriptCore:

  • API/glib/JSCClass.cpp: Fix documentation comments.
  • API/glib/JSCContext.cpp: Ditto.
  • API/glib/JSCDefines.h: Ditto.
  • API/glib/JSCException.cpp: Ditto.
  • API/glib/JSCValue.cpp: Ditto.
  • API/glib/JSCVersion.cpp: Ditto.
  • API/glib/JSCVersion.h.in: Ditto.
  • API/glib/JSCVirtualMachine.cpp: Ditto.
  • API/glib/JSCWeakValue.cpp: Ditto.
  • API/glib/docs/jsc-glib-4.0-sections.txt: Removed.
  • API/glib/docs/jsc-glib-4.0.types: Removed.
  • API/glib/docs/jsc-glib-docs.sgml: Removed.
  • API/glib/docs/jsc.toml.in: Added.
  • PlatformGTK.cmake: Adapt to use the new CMake modules.

Source/WebKit:

  • PlatformGTK.cmake: Adapt to use the new CMake modules.
  • PlatformWPE.cmake: Ditto.
  • Shared/API/glib/WebKitContextMenu.cpp: Fix documentation comments.
  • Shared/API/glib/WebKitContextMenuItem.cpp: Ditto.
  • Shared/API/glib/WebKitHitTestResult.cpp: Ditto.
  • Shared/API/glib/WebKitURIRequest.cpp: Ditto.
  • Shared/API/glib/WebKitURIResponse.cpp: Ditto.
  • Shared/API/glib/WebKitUserMessage.cpp: Ditto.
  • UIProcess/API/glib/WebKitApplicationInfo.cpp: Ditto.
  • UIProcess/API/glib/WebKitAuthenticationRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitAutomationSession.cpp: Ditto.
  • UIProcess/API/glib/WebKitBackForwardList.cpp: Ditto.
  • UIProcess/API/glib/WebKitBackForwardListItem.cpp: Ditto.
  • UIProcess/API/glib/WebKitCookieManager.cpp: Ditto.
  • UIProcess/API/glib/WebKitCredential.cpp: Ditto.
  • UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitDownload.cpp: Ditto.
  • UIProcess/API/glib/WebKitEditorState.cpp: Ditto.
  • UIProcess/API/glib/WebKitError.cpp: Ditto.
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp: Ditto.
  • UIProcess/API/glib/WebKitFileChooserRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitFindController.cpp: Ditto.
  • UIProcess/API/glib/WebKitFormSubmissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitGeolocationManager.cpp: Ditto.
  • UIProcess/API/glib/WebKitGeolocationPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitInputMethodContext.cpp: Ditto.

(webkit_input_method_context_class_init): Ditto.

  • UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitJavascriptResult.cpp: Ditto.
  • UIProcess/API/glib/WebKitMediaKeySystemPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitMemoryPressureSettings.cpp: Ditto.
  • UIProcess/API/glib/WebKitMimeInfo.cpp: Ditto.
  • UIProcess/API/glib/WebKitNavigationAction.cpp: Ditto.
  • UIProcess/API/glib/WebKitNavigationPolicyDecision.cpp: Ditto.
  • UIProcess/API/glib/WebKitNetworkProxySettings.cpp: Ditto.
  • UIProcess/API/glib/WebKitNotification.cpp: Ditto.
  • UIProcess/API/glib/WebKitNotificationPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitOptionMenu.cpp: Ditto.
  • UIProcess/API/glib/WebKitOptionMenuItem.cpp: Ditto.
  • UIProcess/API/glib/WebKitPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitPlugin.cpp: Ditto.
  • UIProcess/API/glib/WebKitPointerLockPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitPolicyDecision.cpp: Ditto.
  • UIProcess/API/glib/WebKitResponsePolicyDecision.cpp: Ditto.
  • UIProcess/API/glib/WebKitScriptDialog.cpp: Ditto.
  • UIProcess/API/glib/WebKitSecurityManager.cpp: Ditto.
  • UIProcess/API/glib/WebKitSecurityOrigin.cpp: Ditto.
  • UIProcess/API/glib/WebKitSettings.cpp: Ditto.
  • UIProcess/API/glib/WebKitURISchemeRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitURISchemeResponse.cpp: Ditto.

(webkit_uri_scheme_response_class_init): Ditto.

  • UIProcess/API/glib/WebKitURIUtilities.cpp: Ditto.
  • UIProcess/API/glib/WebKitUserContent.cpp: Ditto.
  • UIProcess/API/glib/WebKitUserContentFilterStore.cpp: Ditto.
  • UIProcess/API/glib/WebKitUserContentManager.cpp: Ditto.
  • UIProcess/API/glib/WebKitUserMediaPermissionRequest.cpp: Ditto.

(webkit_user_media_permission_request_class_init): Ditto.

  • UIProcess/API/glib/WebKitVersion.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebContext.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebResource.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebView.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebViewSessionState.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebsiteData.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebsiteDataAccessPermissionRequest.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebsiteDataManager.cpp: Ditto.
  • UIProcess/API/glib/WebKitWebsitePolicies.cpp: Ditto.
  • UIProcess/API/glib/WebKitWindowProperties.cpp: Ditto.

(webkit_window_properties_class_init): Ditto.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.h: Ditto.
  • UIProcess/API/gtk/WebKitAuthenticationRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitAutomationSession.h: Ditto.
  • UIProcess/API/gtk/WebKitBackForwardList.h: Ditto.
  • UIProcess/API/gtk/WebKitBackForwardListItem.h: Ditto.
  • UIProcess/API/gtk/WebKitColorChooserRequest.cpp: Ditto.

(webkit_color_chooser_request_class_init): Ditto.

  • UIProcess/API/gtk/WebKitContextMenu.h: Ditto.
  • UIProcess/API/gtk/WebKitCookieManager.h: Ditto.
  • UIProcess/API/gtk/WebKitDefines.h: Ditto.
  • UIProcess/API/gtk/WebKitDeviceInfoPermissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitDownload.h: Ditto.
  • UIProcess/API/gtk/WebKitEditorState.h: Ditto.
  • UIProcess/API/gtk/WebKitError.h: Ditto.
  • UIProcess/API/gtk/WebKitFaviconDatabase.h: Ditto.
  • UIProcess/API/gtk/WebKitFileChooserRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitFindController.h: Ditto.
  • UIProcess/API/gtk/WebKitFormSubmissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitGeolocationManager.h: Ditto.
  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitHitTestResult.h: Ditto.
  • UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitMediaKeySystemPermissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitNavigationPolicyDecision.h: Ditto.
  • UIProcess/API/gtk/WebKitNotification.h: Ditto.
  • UIProcess/API/gtk/WebKitOptionMenu.h: Ditto.
  • UIProcess/API/gtk/WebKitPlugin.h: Ditto.
  • UIProcess/API/gtk/WebKitPointerLockPermissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitPolicyDecision.h: Ditto.
  • UIProcess/API/gtk/WebKitPrintCustomWidget.cpp: Ditto.
  • UIProcess/API/gtk/WebKitPrintCustomWidget.h: Ditto.
  • UIProcess/API/gtk/WebKitPrintOperation.cpp: Ditto.
  • UIProcess/API/gtk/WebKitPrintOperation.h: Ditto.
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Ditto.
  • UIProcess/API/gtk/WebKitSecurityManager.h: Ditto.
  • UIProcess/API/gtk/WebKitSettings.h: Ditto.
  • UIProcess/API/gtk/WebKitURIRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitURIResponse.h: Ditto.
  • UIProcess/API/gtk/WebKitURISchemeRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitURISchemeResponse.h: Ditto.
  • UIProcess/API/gtk/WebKitUserContentFilterStore.h: Ditto.
  • UIProcess/API/gtk/WebKitUserContentManager.h: Ditto.
  • UIProcess/API/gtk/WebKitUserMediaPermissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitUserMessage.h: Ditto.
  • UIProcess/API/gtk/WebKitVersion.h.in: Ditto.
  • UIProcess/API/gtk/WebKitWebContext.h: Ditto.
  • UIProcess/API/gtk/WebKitWebInspector.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWebInspector.h: Ditto.
  • UIProcess/API/gtk/WebKitWebResource.h: Ditto.
  • UIProcess/API/gtk/WebKitWebView.h: Ditto.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWebViewDialog.h: Ditto.
  • UIProcess/API/gtk/WebKitWebsiteDataAccessPermissionRequest.h: Ditto.
  • UIProcess/API/gtk/WebKitWebsiteDataManager.h: Ditto.
  • UIProcess/API/gtk/WebKitWebsitePolicies.h: Ditto.
  • UIProcess/API/gtk/WebKitWindowProperties.h: Ditto.
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Removed.
  • UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Removed.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Removed.
  • UIProcess/API/wpe/WebKitAuthenticationRequest.h: Fix documentation comments.
  • UIProcess/API/wpe/WebKitAutomationSession.h: Ditto.
  • UIProcess/API/wpe/WebKitBackForwardList.h: Ditto.
  • UIProcess/API/wpe/WebKitBackForwardListItem.h: Ditto.
  • UIProcess/API/wpe/WebKitColor.cpp: Ditto.
  • UIProcess/API/wpe/WebKitColor.h: Ditto.
  • UIProcess/API/wpe/WebKitContextMenu.h: Ditto.
  • UIProcess/API/wpe/WebKitContextMenuItem.h: Ditto.
  • UIProcess/API/wpe/WebKitCookieManager.h: Ditto.
  • UIProcess/API/wpe/WebKitDefines.h: Ditto.
  • UIProcess/API/wpe/WebKitDeviceInfoPermissionRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitDownload.h: Ditto.
  • UIProcess/API/wpe/WebKitEditorState.h: Ditto.
  • UIProcess/API/wpe/WebKitError.h: Ditto.
  • UIProcess/API/wpe/WebKitFaviconDatabase.h: Ditto.
  • UIProcess/API/wpe/WebKitFileChooserRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitFindController.h: Ditto.
  • UIProcess/API/wpe/WebKitFormSubmissionRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitGeolocationManager.h: Ditto.
  • UIProcess/API/wpe/WebKitGeolocationPermissionRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitHitTestResult.h: Ditto.
  • UIProcess/API/wpe/WebKitInputMethodContext.h: Ditto.
  • UIProcess/API/wpe/WebKitInstallMissingMediaPluginsPermissionRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitMediaKeySystemPermissionRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitNavigationPolicyDecision.h: Ditto.
  • UIProcess/API/wpe/WebKitNotification.h: Ditto.
  • UIProcess/API/wpe/WebKitOptionMenu.h: Ditto.
  • UIProcess/API/wpe/WebKitPlugin.h: Ditto.
  • UIProcess/API/wpe/WebKitPolicyDecision.h: Ditto.
  • UIProcess/API/wpe/WebKitRectangle.cpp: Ditto.
  • UIProcess/API/wpe/WebKitRectangle.h: Ditto.
  • UIProcess/API/wpe/WebKitResponsePolicyDecision.h: Ditto.
  • UIProcess/API/wpe/WebKitSecurityManager.h: Ditto.
  • UIProcess/API/wpe/WebKitSettings.h: Ditto.
  • UIProcess/API/wpe/WebKitURIRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitURIResponse.h: Ditto.
  • UIProcess/API/wpe/WebKitURISchemeRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitURISchemeResponse.h: Ditto.
  • UIProcess/API/wpe/WebKitUserContentFilterStore.h: Ditto.
  • UIProcess/API/wpe/WebKitUserContentManager.h: Ditto.
  • UIProcess/API/wpe/WebKitUserMediaPermissionRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitUserMessage.h: Ditto.
  • UIProcess/API/wpe/WebKitVersion.h.in: Ditto.
  • UIProcess/API/wpe/WebKitWebContext.h: Ditto.
  • UIProcess/API/wpe/WebKitWebResource.h: Ditto.
  • UIProcess/API/wpe/WebKitWebView.h: Ditto.
  • UIProcess/API/wpe/WebKitWebViewBackend.cpp: Ditto.
  • UIProcess/API/wpe/WebKitWebViewWPE.cpp: Ditto.
  • UIProcess/API/wpe/WebKitWebsiteDataAccessPermissionRequest.h: Ditto.
  • UIProcess/API/wpe/WebKitWebsiteDataManager.h: Ditto.
  • UIProcess/API/wpe/WebKitWebsitePolicies.h: Ditto.
  • UIProcess/API/wpe/WebKitWindowProperties.h: Ditto.
  • UIProcess/API/wpe/docs/wpe-1.0-sections.txt: Removed.
  • UIProcess/API/wpe/docs/wpe-docs.sgml: Removed.
  • WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp: Fix documentation comments.
  • WebProcess/InjectedBundle/API/glib/WebKitWebEditor.cpp: Ditto.
  • WebProcess/InjectedBundle/API/glib/WebKitWebExtension.cpp: Ditto.
  • WebProcess/InjectedBundle/API/glib/WebKitWebHitTestResult.cpp: Ditto.
  • WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: Ditto.
  • WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt: Removed.
  • WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-docs.sgml: Removed.
  • WebProcess/InjectedBundle/API/gtk/WebKitFrame.h: Fix documentation comments.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Ditto.
  • WebProcess/InjectedBundle/API/wpe/WebKitFrame.h: Ditto.
  • WebProcess/InjectedBundle/API/wpe/WebKitWebPage.h: Ditto.
  • WebProcess/InjectedBundle/API/wpe/docs/wpe-webextensions-1.0-sections.txt: Removed.
  • WebProcess/InjectedBundle/API/wpe/docs/wpe-webextensions-docs.sgml: Removed.
  • gtk/webkit2gtk-webextension.toml.in: Added.
  • gtk/webkit2gtk.toml.in: Added.
  • wpe/wpewebextension.toml.in: Added.
  • wpe/wpewebkit.toml.in: Added.

Tools:

  • gtkdoc/generate-gtkdoc: Removed.
  • gtkdoc/gtkdoc.py: Removed.

(GTKDoc): Deleted.
(GTKDoc.init): Deleted.
(GTKDoc.generate): Deleted.
(GTKDoc._delete_file_if_exists): Deleted.
(GTKDoc._create_directory_if_nonexistent): Deleted.
(GTKDoc._raise_exception_if_file_inaccessible): Deleted.
(GTKDoc._output_has_warnings): Deleted.
(GTKDoc._ask_yes_or_no_question): Deleted.
(GTKDoc._run_command): Deleted.
(GTKDoc._copy_doc_files_to_output_dir): Deleted.
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing): Deleted.
(GTKDoc._copy_doc_files_to_output_dir.copy_all_files_in_directory): Deleted.
(GTKDoc._write_version_xml): Deleted.
(GTKDoc._ignored_files_basenames): Deleted.
(GTKDoc._run_gtkdoc_scan): Deleted.
(GTKDoc._run_gtkdoc_scangobj): Deleted.
(GTKDoc._run_gtkdoc_mkdb): Deleted.
(GTKDoc._run_gtkdoc_mkhtml): Deleted.
(GTKDoc._run_gtkdoc_fixxref): Deleted.
(GTKDoc.rebase_installed_docs): Deleted.
(GTKDoc.api_missing_documentation): Deleted.
(PkgConfigGTKDoc): Deleted.
(PkgConfigGTKDoc.init): Deleted.

12:20 AM Changeset in webkit [292262] by youenn@apple.com
  • 5 edits
    3 adds in trunk

Remove notifications from notification list when notification gets closed
​https://bugs.webkit.org/show_bug.cgi?id=238665

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/workers/service/getnotifications-stop.html

  • Modules/notifications/Notification.cpp:

(WebCore::Notification::stop):
Do not destroy persistent permissions when the JS object gets stopped.

Source/WebKit:

Cancelling a notification should trigger the close steps, which means removing the notification from the notification list.

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::cancel):
(WebKit::WebNotificationManagerProxy::didDestroyNotification):

LayoutTests:

  • http/tests/workers/service/getnotifications-stop-expected.txt: Added.
  • http/tests/workers/service/getnotifications-stop.html: Added.
  • http/tests/workers/service/resources/getNotifications-iframe.html: Added.
Note: See TracTimeline for information about the timeline view.