Timeline
Apr 6, 2022:
- 9:29 PM Changeset in webkit [292523] by
-
- 4 edits in trunk
[:has() pseudo-class] Support invalidation for :placeholder-shown
https://bugs.webkit.org/show_bug.cgi?id=238894
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html
Use same pattern as other input pseudo classes.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
- 7:44 PM Changeset in webkit [292522] by
-
- 4 edits4 adds in trunk
NBSP characters drawn in fonts that don't support the space character turn into boxes
https://bugs.webkit.org/show_bug.cgi?id=238836
<rdar://problem/91130503>
Reviewed by Alan Bujtas.
Source/WebCore:
We have some historical code in WebKit where we swap out the non-breaking space glyph
for the space glyphs when rendering. This is not what the other browsers do; they will
faithfully render the non-breaking space glyph. This patch aligns with the other
browsers.
This patch also fixes a similar problem with tab characters. Other browsers never
render any visible tab glyphs, even if the font has a visible glyph for the tab
character. This patch implements this.
This patch also only clobbers the glyphs used for carriageReturn and newlineCharacter
if the replacement glyph exists.
Test: fast/text/nbsp-no-space.html
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyCSSVisibilityRules):
LayoutTests:
- fast/text/nbsp-no-space-expected.html: Added.
- fast/text/nbsp-no-space.html: Added.
- fast/text/resources/Ahem-nbsp-no-space.ttf: Added. Supports NBSP but not space.
- fast/text/resources/Ahem-visible-tab-and-space.ttf: Added. Has visible glyphs for tab and space.
- 7:18 PM Changeset in webkit [292521] by
-
- 2 edits in trunk/LayoutTests
REBASLINE: [ Monterey ] fast/text/khmer-lao-font.html is a constant text failure
Unreviewed test rebasline.
- platform/mac/fast/text/khmer-lao-font-expected.txt:
- 6:21 PM Changeset in webkit [292520] by
-
- 7 edits in trunk
[ Mac ] accessibility/mac/expanded-notification.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=238830
rdar://91313419
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/mac/expanded-notification.html
This patch fixes the flackiness of this test and also fixes this test
in isolated tree mode that was timing out.
Instead of AXIsolatedTree::updateChildren on the AXExpandedChanged
notification, we now update the ISExpanded property in the target object.
If new children are added or removed from the tree as the result of an
element's expanded state change, those tree mutations should generate
separate AXChildrenChanged notifications.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperty):
LayoutTests:
Fixes the flakiness by checking the number of notifications received in
the same async block where the changes are occuring. This now passes
with no flakiness in both isolated tree mode on and off.
- accessibility/mac/expanded-notification-expected.txt:
- accessibility/mac/expanded-notification.html:
- platform/mac/TestExpectations:
- 6:08 PM Changeset in webkit [292519] by
-
- 2 edits in trunk/Tools
Use 'open' command on macOS to launch URL should pass Safari app bundle instead of binary
https://bugs.webkit.org/show_bug.cgi?id=238915
<rdar://91384008>
Reviewed by Stephanie Lewis.
Pass 'Safari.app' instead of 'Safari.app/Contents/MacOS/Safari' when launching URL via 'open' command.
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launch_url):
Canonical link: https://commits.webkit.org/249357@main
- 6:06 PM Changeset in webkit [292518] by
-
- 1 copy in tags/Safari-613.2.4.1.3
Tag Safari-613.2.4.1.3.
- 5:54 PM Changeset in webkit [292517] by
-
- 9 edits in branches/safari-613.2.4.1-branch/Source
Versioning.
WebKit-7613.2.4.1.3
- 5:49 PM Changeset in webkit [292516] by
-
- 1 copy in tags/Safari-614.1.7.7
Tag Safari-614.1.7.7.
- 5:47 PM Changeset in webkit [292515] by
-
- 9 edits in branches/safari-614.1.7-branch/Source
Versioning.
WebKit-7614.1.7.7
- 4:35 PM Changeset in webkit [292514] by
-
- 15 edits1 move769 adds in trunk/PerformanceTests
Add versions of Speedometer2.0 and 2.1 in PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=238906
Rubber stamped by Yusuke Suzuki.
After this change, we'll end up with PerformanceTests/Speedometer2.0 and
PerformanceTests/Speedometer2.1.
- 3:47 PM Changeset in webkit [292513] by
-
- 5 edits in trunk/Source/bmalloc
[libpas] Run TLC decommit rarely
https://bugs.webkit.org/show_bug.cgi?id=238855
Reviewed by Saam Barati.
We were running libpas TLC decommit every time. But it is too frequent. We should capture IsoHeap allocation pattern
with much more longer period, and perform TLC decommit in such a low-frequency rate.
This patch changes it so that we run it only once a 128 scavenger run. It is roughly once a 13 seconds.
- libpas/src/libpas/pas_scavenger.c:
(scavenger_thread_main):
(pas_scavenger_clear_all_caches):
- libpas/src/libpas/pas_thread_local_cache.c:
(pas_thread_local_cache_for_all):
- libpas/src/libpas/pas_thread_local_cache.h:
- libpas/src/test/TLCDecommitTests.cpp:
(std::testTLCDecommit):
(std::testTLCDecommitThenDestroyImpl):
(std::testTLCDecommitThenDeallocate):
- 3:41 PM Changeset in webkit [292512] by
-
- 58 edits in trunk/Source/WebCore
[GPU Process] Make SVGFEImageElement::filterEffect() create an ImageBuffer compatible with the destination GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=236573
rdar://89209695
Reviewed by Simon Fraser.
Pass a GraphicsContext to CSSFilter::create() and SVGFilter::create().
If there is no GraphicsContext available, like the call we make in
CSSFilterImageValue::image(), pass a NullGraphicsContext(). This will
create a local ImageBuffer. And this is exactly what we want.
The GraphicsContext will be passed from SVGFilter::buildFilterExpression()
to all the overridden filterEffect(). SVGFEImageElement::filterEffect()
is the only one that is going to use it. It calls GraphicsContext::
createImageBuffer() to create an ImageBuffer for drawing the SVGElement.
In preparation to remove SVGFilterBuilder:
-- Pass an SVGFilter instead of SVGFilterBuilder to all the overridden
filterEffect() and all the overridden lightSource().
-- Make SVGFilterBuilder::calculateFilterOutsets() a static method.
-- Remove the members: SVGFilterBuilder::m_tragetBoundingBox and
SVGFilterBuilder::m_primitiveUnits since they exist in SVGFilter.
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
- page/FrameView.cpp:
(WebCore::FrameView::adjustPageHeightDeprecated):
- platform/graphics/NullGraphicsContext.h:
- rendering/CSSFilter.cpp:
(WebCore::CSSFilter::create):
(WebCore::calculateReferenceFilterOutsets):
(WebCore::createReferenceFilter):
(WebCore::CSSFilter::buildFilterFunctions):
- rendering/CSSFilter.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
- rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::beginFilterEffect):
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::filterEffect const):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::filterEffect const):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::filterEffect const):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::filterEffect const):
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::filterEffect const):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::filterEffect const):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::filterEffect const):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDistantLightElement.cpp:
(WebCore::SVGFEDistantLightElement::lightSource const):
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::filterEffect const):
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::filterEffect const):
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::filterEffect const):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::imageBufferForEffect const):
(WebCore::SVGFEImageElement::filterEffect const):
(WebCore::scaledImageBufferRect): Deleted.
(WebCore::clampingScaleForImageBufferSize): Deleted.
(WebCore::createImageBuffer): Deleted.
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::filterEffect const):
- svg/SVGFEMergeElement.h:
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::filterEffect const):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::filterEffect const):
- svg/SVGFEOffsetElement.h:
- svg/SVGFEPointLightElement.cpp:
(WebCore::SVGFEPointLightElement::lightSource const):
- svg/SVGFEPointLightElement.h:
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::filterEffect const):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpotLightElement.cpp:
(WebCore::SVGFESpotLightElement::lightSource const):
- svg/SVGFESpotLightElement.h:
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::filterEffect const):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::filterEffect const):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/graphics/filters/SVGFilter.cpp:
(WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h:
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::buildFilterExpression):
(WebCore::SVGFilterBuilder::calculateFilterOutsets):
(WebCore::SVGFilterBuilder::SVGFilterBuilder): Deleted.
- svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::targetBoundingBox const): Deleted.
(WebCore::SVGFilterBuilder::primitiveUnits const): Deleted.
(): Deleted.
- 3:21 PM Changeset in webkit [292511] by
-
- 2 edits in trunk/Source/WebCore
FilterImage::imageBufferFromPixelBuffer() can trigger accelerated buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=238848
Unreviewed.
Remove an icorrect FIXME comment now that I've verified that the issue does not occur.
- platform/graphics/filters/FilterImage.cpp:
(WebCore::FilterImage::imageBufferFromPixelBuffer):
- 3:15 PM Changeset in webkit [292510] by
-
- 9 edits in branches/safari-614.1.9-branch/Source
Versioning.
WebKit-7614.1.9.1
- 3:10 PM Changeset in webkit [292509] by
-
- 5 edits in trunk/Tools
[Merge-Queue] Run
git svn fetch
https://bugs.webkit.org/show_bug.cgi?id=238759
<rdar://problem/91258277>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/factories.py:
(MergeQueueFactory.init): Add GitSvnFetch step.
- Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps): Ditto.
- Tools/CISupport/ews-build/steps.py:
(UpdatePullRequest.hideStepIf):
(GitSvnFetch):
(GitSvnFetch.init):git svn fetchwill have a non-zero exit code if the Subversion
record of changes does not match the git one, which will happen imiediately after committing.
(GitSvnFetch.getResultSummary):
(GitSvnFetch.evaluateCommand): Support expected failure.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249352@main
- 2:57 PM Changeset in webkit [292508] by
-
- 5 edits in trunk
Fix expected, actual links for variant-based imported wpt tests
https://bugs.webkit.org/show_bug.cgi?id=238832
rdar://problem/91313891
Reviewed by Brent Fulgham.
Tools:
Ensure that the workaround involving "len(fs.splitext(output_basename)[1]) - 1 > 5"
does not affect imported templated wpt tests that may match that condition, such as
".../pbkdf2.https.any.worker.html."
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.output_filename):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_output_filename):
(TestResultWriterTest):
(TestResultWriterTest.test_output_filename_variant):
LayoutTests:
The changes to LayoutTests/fast/harness/results.html were wiped when
preparing https://bugs.webkit.org/show_bug.cgi?id=231544, causing the
links not to match. This patch fixes it.
- fast/harness/results.html:
- 2:49 PM Changeset in webkit [292507] by
-
- 3 edits in trunk/LayoutTests
[ Mac , iOS Debug ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/resource-popup.https.html is a flaky failure.
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:Fixed typo
- platform/mac-wk2/TestExpectations:Fixed typo
- 2:29 PM Changeset in webkit [292506] by
-
- 18 edits in trunk/Source
Drop unnecessary ExceptionOr<> return types
https://bugs.webkit.org/show_bug.cgi?id=238876
Reviewed by Alex Christensen.
Drop unnecessary ExceptionOr<> return types as they may cause unnecessary branching at runtime.
Source/WebCore:
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create):
- animation/KeyframeEffect.h:
- css/MediaList.cpp:
(WebCore::MediaList::setMediaText):
- css/MediaList.h:
- html/CustomPaintCanvas.cpp:
(WebCore::CustomPaintCanvas::getContext):
- html/CustomPaintCanvas.h:
- html/CustomPaintImage.cpp:
(WebCore::CustomPaintImage::doCustomPaint):
Source/WebKitLegacy/mac:
- DOM/DOMMediaList.mm:
(-[DOMMediaList setMediaText:]):
- 2:26 PM Changeset in webkit [292505] by
-
- 4 edits in trunk/LayoutTests
Remove Mojave references in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=238890
<rdar://problem/91375011>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk1/TestExpectations: Remove Mojave references.
- LayoutTests/platform/mac-wk2/TestExpectations: Ditto.
- LayoutTests/platform/mac/TestExpectations: Ditto.
Canonical link: https://commits.webkit.org/249348@main
- 2:01 PM Changeset in webkit [292504] by
-
- 2 edits in trunk/Source/WebCore
Stop using the shared IOSurfacePool for WebGL
https://bugs.webkit.org/show_bug.cgi?id=238835
Reviewed by Kimmo Kinnunen.
Opt WebGL out of using the IOSurfacePool for its buffers; this would have almost never
used a surface from the pool, because only RemoteLayerBackingStore put surfaces in the
pool so it would be rare for the size to match. In addition, the pool has insufficient
guarantees about surface state.
- platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::allocateAndBindDisplayBufferBacking):
- 1:50 PM Changeset in webkit [292503] by
-
- 1 copy in tags/Safari-614.1.9
Tag Safari-614.1.9.
- 1:50 PM Changeset in webkit [292502] by
-
- 4 edits in trunk/LayoutTests
Remove Catalina references in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=238886
<rdar://problem/91373532>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk1/TestExpectations: Remove Catalina references.
- LayoutTests/platform/mac-wk2/TestExpectations: Ditto.
- LayoutTests/platform/mac/TestExpectations: Ditto.
Canonical link: https://commits.webkit.org/249346@main
- 1:50 PM Changeset in webkit [292501] by
-
- 1 delete in tags/Safari-614.1.9
Remove tag.
- 1:47 PM Changeset in webkit [292500] by
-
- 1 edit in branches/safari-614.1.9-branch/Source/WebKit/ChangeLog
Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
- 1:47 PM Changeset in webkit [292499] by
-
- 2 edits in branches/safari-614.1.9-branch/Source/WebKit
Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
- 1:47 PM Changeset in webkit [292498] by
-
- 2 edits in branches/safari-614.1.9-branch/Source/WebKit
Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build
https://bugs.webkit.org/show_bug.cgi?id=238783
Unreviewed build fix.
ConcreteImageBuffer<>::create() needs a default CreationContext argument.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::ensureFrontBuffer):
- 1:23 PM Changeset in webkit [292497] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion in CSSPropertyAnimationWrapperMap constructor
https://bugs.webkit.org/show_bug.cgi?id=238884
Patch by Ada Chan <adachan@apple.com> on 2022-04-06
Reviewed by Antoine Quint.
Add more non-animatable properties to the switch statement.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 1:10 PM Changeset in webkit [292496] by
-
- 3 edits in trunk/Tools
[Merge-Queue] Use rebase over merge when canonicalizing commit
https://bugs.webkit.org/show_bug.cgi?id=238877
<rdar://problem/91363334>
Reviewed by Ryan Haddad and Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(Canonicalize.run): Specify rebase workflow instead of merge workflow.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249344@main
- 12:44 PM Changeset in webkit [292495] by
-
- 3 edits in trunk/LayoutTests
pbkdf2.https.any.worker.html fails on WPE, GTK2 ports
https://bugs.webkit.org/show_bug.cgi?id=238885
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 12:40 PM Changeset in webkit [292494] by
-
- 3 edits in trunk/Tools
[Flatpak SDK] Avoid termination if gdbus is not installed after 249303@main
https://bugs.webkit.org/show_bug.cgi?id=238878
Reviewed by Philippe Normand.
Instead of bailing out, just disable a11y bus forwarding. Also hide
some debug messages.
- flatpak/flatpakutils.py:
(WebkitFlatpak.setup_a11y_proxy):
- glib/dependencies/apt: Add libglib2.0-bin
- 12:35 PM Changeset in webkit [292493] by
-
- 21 edits in trunk/Source/JavaScriptCore
Call Structure::get instead of Structure::getConcurrently on the mutator thread
https://bugs.webkit.org/show_bug.cgi?id=238823
Reviewed by Yusuke Suzuki.
We try to call Structure::get instead of Structure::getConcurrently when
we know for sure we're on the main thread. This is because getConcurrently
is slower than get.
- bytecode/AccessCase.cpp:
(JSC::AccessCase::couldStillSucceed const):
(JSC::AccessCase::generateImpl):
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:
(JSC::AdaptiveInferredPropertyValueWatchpointBase::install):
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::install):
- bytecode/ObjectPropertyCondition.cpp:
(JSC::ObjectPropertyCondition::structureEnsuresValidityAssumingImpurePropertyWatchpoint const):
(JSC::ObjectPropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::ObjectPropertyCondition::isStillValid const):
(JSC::ObjectPropertyCondition::structureEnsuresValidity const):
- bytecode/ObjectPropertyCondition.h:
- bytecode/ObjectPropertyConditionSet.cpp:
(JSC::ObjectPropertyConditionSet::structuresEnsureValidity const):
(JSC::generateConditionsForPropertyMiss):
(JSC::generateConditionsForPropertySetterMiss):
(JSC::generateConditionsForPrototypePropertyHit):
(JSC::generateConditionsForPrototypePropertyHitCustom):
(JSC::generateConditionsForPrototypeEquivalenceConcurrently):
(JSC::generateConditionsForPropertyMissConcurrently):
(JSC::generateConditionsForPropertySetterMissConcurrently):
(JSC::generateConditionForSelfEquivalence):
(JSC::ObjectPropertyConditionSet::structuresEnsureValidityAssumingImpurePropertyWatchpoint const): Deleted.
(JSC::ObjectPropertyConditionSet::isValidAndWatchable const): Deleted.
- bytecode/ObjectPropertyConditionSet.h:
- bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::watchabilityToConcurrency):
(JSC::PropertyCondition::isStillValid const):
(JSC::PropertyCondition::isWatchableWhenValid const):
(JSC::PropertyCondition::isWatchableAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::isWatchable const):
- bytecode/PropertyCondition.h:
- dfg/DFGAdaptiveStructureWatchpoint.cpp:
(JSC::DFG::AdaptiveStructureWatchpoint::install):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::check):
(JSC::DFG::ByteCodeParser::planLoad):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::tryFoldAsPutByOffset):
- dfg/DFGDesiredWatchpoints.h:
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::hasBeenInvalidated):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::watchCondition):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setupGetByIdPrototypeCache):
- runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.cpp:
(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::install):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::tryInstallSpeciesWatchpoint):
- runtime/JSObject.h:
(JSC::JSObject::getDirect const):
- runtime/Structure.h:
(JSC::Structure::get):
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::cacheSpecialPropertySlow):
- 12:33 PM Changeset in webkit [292492] by
-
- 1 copy in tags/Safari-614.1.9
Tag Safari-614.1.9.
- 12:32 PM Changeset in webkit [292491] by
-
- 2 edits in branches/safari-614.1.9-branch/Source/WebGPU
Cherry-pick r292479. rdar://problem/91351306
[WebGPU] Fix the tvOS build
https://bugs.webkit.org/show_bug.cgi?id=238881
<rdar://problem/91351306>
Unreviewed.
MTLTextureType2DMultisampleArray is not available on tvOS.
- WebGPU/Texture.mm: (WebGPU::Device::createTexture): (WebGPU::Texture::createView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:13 PM Changeset in webkit [292490] by
-
- 7 edits1 add in trunk/Tools
[git-webkit] Provide https credentialing program
https://bugs.webkit.org/show_bug.cgi?id=238679
<rdar://problem/91177114>
Reviewed by Stephanie Lewis and Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py: Add Credentials program.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/credentials.py: Added.
(Credentials.main): Return credentials for remote.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Set credential helper if remote is an http remote.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.credentials): Stub function to be replace by child classes.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
Canonical link: https://commits.webkit.org/249340@main
- 12:09 PM Changeset in webkit [292489] by
-
- 5 edits in trunk/Source/bmalloc
Unreviewed, reverting r292450.
https://bugs.webkit.org/show_bug.cgi?id=238883
Membuster regression
Reverted changeset:
"[libpas] Run TLC decommit rarely"
https://bugs.webkit.org/show_bug.cgi?id=238855
https://commits.webkit.org/r292450
- 12:06 PM Changeset in webkit [292488] by
-
- 2 edits in trunk/Source/WebCore
Avoid calling IOSurfaceAlignProperty in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=238870
<rdar://91252359>
Reviewed by Geoffrey Garen.
Use cached values for bytes per row alignment.
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::calculateBytesPerRow):
- 12:05 PM Changeset in webkit [292487] by
-
- 92 edits in trunk/Source
Start replacing String(const char*) constructor with a String::fromLatin1(const char*) function
https://bugs.webkit.org/show_bug.cgi?id=238701
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- API/JSValue.mm:
(createStructHandlerMap):
(handerForStructTag):
- API/JSWrapperMap.mm:
(allocateConstructorForCustomClass):
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunctionImpl::name):
- API/glib/JSCContext.cpp:
(jsc_context_check_syntax):
- b3/air/testair.cpp:
- bindings/ScriptFunctionCall.cpp:
(Deprecated::ScriptCallArgumentHandler::appendArgument):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName const):
- heap/HeapSnapshotBuilder.cpp:
(JSC::HeapSnapshotBuilder::json):
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::sendMessageToBackend):
- jit/ExecutableAllocator.cpp:
(JSC::dumpJITMemory):
- jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
(runWithOptions):
(CommandLine::parseArguments):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parsePrimaryExpression):
- parser/Parser.h:
(JSC::Parser::updateErrorMessage):
- parser/SourceProvider.h:
- runtime/BytecodeCacheError.cpp:
(JSC::BytecodeCacheError::StandardError::message const):
- runtime/IntlLocale.cpp:
(JSC::IntlLocale::keywordValue const):
(JSC::IntlLocale::numberingSystems):
- runtime/IntlObject.cpp:
(JSC::numberingSystemsForLocale):
- runtime/NumberPrototype.cpp:
(JSC::toStringWithRadix):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::numberToStringInternal):
(JSC::int52ToString):
- runtime/Options.cpp:
(JSC::Options::overrideAliasedOptionWithHeuristic):
(JSC::Options::setAliasedOption):
- runtime/RegExpPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::displayName):
- runtime/StringPrototype.cpp:
(JSC::toLocaleCase):
- testRegExp.cpp:
(parseArguments):
- tools/CompilerTimingScope.cpp:
- tools/FunctionAllowlist.cpp:
(JSC::FunctionAllowlist::FunctionAllowlist):
- wasm/js/WebAssemblyModuleConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
Source/WebCore:
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionFailed):
(WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionFailed):
(WebCore::LibWebRTCMediaEndpoint::setRemoteSessionDescriptionFailed):
(WebCore::RTCStatsLogger::toJSONString const):
- Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::toException):
(WebCore::toRTCError):
- Modules/webauthn/WebAuthenticationUtils.cpp:
(WebCore::buildAttestationMap):
- Modules/webauthn/cbor/CBORValue.cpp:
(cbor::CBORValue::CBORValue):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::getVersionFromDatabase):
(WebCore::Database::setVersionInDatabase):
- animation/KeyframeEffect.cpp:
(WebCore::processPropertyIndexedKeyframes):
- animation/KeyframeEffect.h:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
- contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::getDomainList):
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
- crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
- crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
- crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
- crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
- crypto/algorithms/CryptoAlgorithmECDSA.cpp:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
- crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
- crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
- crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
- css/DOMCSSCustomPropertyDescriptor.h:
- css/makeprop.pl:
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::types const):
- dom/TextDecoder.cpp:
(WebCore::TextDecoder::encoding const):
- editing/ApplyStyleCommand.cpp:
(WebCore::styleSpanClassString):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isInterchangeNewlineNode):
(WebCore::isInterchangeConvertedSpaceSpan):
- editing/TextInsertionBaseCommand.cpp:
(WebCore::canAppendNewLineFeedToSelection):
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::appendFormData const):
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getSupportedExtensions):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::testPreloadScannerViewportSupport):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResource::responseReceived):
- loader/cache/CachedApplicationManifest.cpp:
(WebCore::CachedApplicationManifest::encoding const):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::encoding const):
(WebCore::CachedCSSStyleSheet::checkNotify):
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::encoding const):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::encoding const):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::encoding const):
- page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::threadInfos):
- platform/cocoa/PasteboardCocoa.mm:
(WebCore::Pasteboard::read):
- platform/gamepad/GamepadConstants.cpp:
(WebCore::standardGamepadMappingString):
(WebCore::xrStandardGamepadMappingString):
- platform/graphics/FourCC.h:
(WTF::LogArgument<WebCore::FourCC>::toString):
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::initialize):
(WebCore::GraphicsContextGLANGLE::getString):
- platform/mac/ThreadCheck.mm:
(WebCoreReportThreadViolation):
- platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::hashStringWithSalt):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::initializeVoiceList):
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::authorizerFunction):
- platform/text/cocoa/LocaleCocoa.mm:
(WebCore::LocaleCocoa::monthLabels):
(WebCore::LocaleCocoa::shortMonthLabels):
- testing/Internals.cpp:
(WebCore::Internals::testDictionaryLogging):
- xml/XPathValue.h:
(WebCore::XPath::Value::Value):
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::parseErrorFunc):
(WebCore::docLoaderFunc):
(WebCore::XSLTProcessor::transformToString):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::openFunc):
Source/WebCore/PAL:
- pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:
(PAL::WebGPU::adapterName):
- pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
(PAL::WebGPU::DeviceImpl::popErrorScope):
Source/WebGPU:
- WebGPU/APIConversions.h:
(WebGPU::fromAPI):
- WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
- WebGPU/ComputePipeline.mm:
(WebGPU::createConstantValues):
(WebGPU::Device::createComputePipeline):
- WebGPU/ShaderModule.mm:
(WebGPU::earlyCompileShaderModule):
(WebGPU::Device::createShaderModule):
Source/WTF:
- wtf/Logger.h:
(WTF::LogArgument::toString):
- wtf/text/WTFString.cpp:
(string):
- wtf/text/WTFString.h:
- 12:04 PM Changeset in webkit [292486] by
-
- 5 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r292417. rdar://problem/91311691
Implement faster lookup of HTML tags in the HTML parser
https://bugs.webkit.org/show_bug.cgi?id=238804
Reviewed by Geoffrey Garen.
Implement faster lookup of HTML tags in the HTML parser by having make_names.pl generate
a findHTMLTag function that returns very efficient well-known HTML tag names.
It is a little more efficient that our current HTMLNameCache (0.4% progression on
Speedometer on MacBookAir 10,1, neutral on iMac20,1). Unlike the HTMLNameCache, It doesn't
require any hashing or additional storage since the set of well-known HTML tags is known
at compile time.
- dom/make_names.pl: (printNamesHeaderFile): (findMaxTagLength): (tagsWithLength): (generateFindTagForLength): (printNamesCppFile):
- html/parser/AtomHTMLToken.h: (WebCore::AtomHTMLToken::AtomHTMLToken):
- html/parser/HTMLNameCache.cpp: (WebCore::HTMLNameCache::atomStringCache):
- html/parser/HTMLNameCache.h: (WebCore::HTMLNameCache::makeAttributeValue): (WebCore::HTMLNameCache::clear): (WebCore::HTMLNameCache::makeAtomString): (WebCore::HTMLNameCache::atomStringCacheSlot): (WebCore::HTMLNameCache::makeTagName): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 AM Changeset in webkit [292485] by
-
- 6 edits1 add in trunk/Tools
[git-webkit] Add automation to assist in branch cleanup
https://bugs.webkit.org/show_bug.cgi?id=238637
<rdar://problem/91127828>
Reviewed by Stephanie Lewis and Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Add branch deletion and reset mocks.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:
(Svn.init): Add
svn revertmock.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:
(Clean):
(Clean.parser): Allow caller to specify branch or pull request.
(Clean.cleanup): Delete a branch or branches associated with a pull request.
(Clean.main): Differentiate calls with branches and pull requests specified from those without.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clean_unittest.py: Added.
(TestClean):
(TestClean.setUp):
(TestClean.test_checkout_none):
(TestClean.test_clean_git):
(TestClean.test_clean_svn):
(TestClean.test_clean_branch):
(TestClean.test_clean_pr):
Canonical link: https://commits.webkit.org/249336@main
- 11:48 AM Changeset in webkit [292484] by
-
- 4 edits1 add in trunk
[JSC] Substring resolving should check 8bit / 16bit again
https://bugs.webkit.org/show_bug.cgi?id=236775
<rdar://problem/89253391>
Reviewed by Saam Barati.
JSTests:
- stress/8bit-16bit-atomize-conversion.js: Added.
(main.v64):
(main):
Source/JavaScriptCore:
Substring JSString is wrapping JSString. Thus it is possible that underlying JSString's 8Bit / 16Bit status
becomes different from substring JSString wrapper's bit. We should not assume they are the same.
- runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeInternal const):
(JSC::JSRopeString::resolveRopeToAtomString const):
(JSC::JSRopeString::resolveRopeToExistingAtomString const):
(JSC::JSRopeString::resolveRopeInternal8 const): Deleted.
(JSC::JSRopeString::resolveRopeInternal16 const): Deleted.
- runtime/JSString.h:
- 11:29 AM Changeset in webkit [292483] by
-
- 2 edits in trunk/Source/WebKit
Improve API::SerializedScriptValue::deserialize to not allocate a new JSContext every second
https://bugs.webkit.org/show_bug.cgi?id=210920
Reviewed by Geoffrey Garen.
Instead of forcing the lifetime of the shared JSContext to 1 second, we now use a hysteresis
logic so that it can stay alive as long as it is used at least every 10 seconds.
- UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
(API::SharedJSContext::SharedJSContext):
(API::SharedJSContext::ensureContext):
(API::SharedJSContext::releaseContextIfNecessary):
(API::SharedJSContext::releaseContext): Deleted.
- 11:22 AM Changeset in webkit [292482] by
-
- 2 edits in trunk/Source/WebCore
Check for document page in WorkerMessagingProxy::createCacheStorageConnection
https://bugs.webkit.org/show_bug.cgi?id=238872
Reviewed by Chris Dumez.
Add a check to the document page, similarily to how it is currently done in
WorkerMessagingProxy::createRTCDataChannelRemoteHandlerConnection.
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::createCacheStorageConnection):
- 11:21 AM Changeset in webkit [292481] by
-
- 3 edits in trunk/JSTests
ICU was recently updated to use type="long" format if there is {month: "long"}
https://bugs.webkit.org/show_bug.cgi?id=238852
<rdar://90462186>
Reviewed by Saam Barati.
Since this update [1] is not yet released, we can't set expectations based on major / minor
ICU version, this patch loosens the tests to accept either of the format types.
[1]: https://github.com/unicode-org/icu/commit/23081486ffec0973b01e66e2cbad93a1a7dec267
- stress/date-toLocaleString.js:
- stress/intl-datetimeformat.js:
- 11:20 AM Changeset in webkit [292480] by
-
- 2 edits in trunk/LayoutTests
[ Monterey wk2 Release ] imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-012.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=238880
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Marked expectations as [ Pass ImageOnlyFailure ] while test is reviewed.
- 11:08 AM Changeset in webkit [292479] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] Fix the tvOS build
https://bugs.webkit.org/show_bug.cgi?id=238881
<rdar://problem/91351306>
Unreviewed.
MTLTextureType2DMultisampleArray is not available on tvOS.
- WebGPU/Texture.mm:
(WebGPU::Device::createTexture):
(WebGPU::Texture::createView):
- 10:57 AM Changeset in webkit [292478] by
-
- 5 edits in trunk
[GPU Process] Text filled with pattern sometimes draw with incorrect color
https://bugs.webkit.org/show_bug.cgi?id=236924
rdar://89196811
Reviewed by Myles C. Maxfield.
Source/WebCore:
applyFillPattern() and applyStrokePattern() have to explicitly called
for the GraphicsContext or the DisplayList::Recorder before drawing
with the pattern. But this is not happening for the DrawGlyphsRecorder
internalContext. When CoreText calls DrawGlyphsRecorder::recordDrawGlyphs()
back, it applies the CGGState fill color to the DisplayList::Recorder so
it overrides what applyFillPattern() did before recording the glyphs.
- platform/graphics/DrawGlyphsRecorder.h:
- platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
(WebCore::DrawGlyphsRecorder::populateInternalContext):
(WebCore::DrawGlyphsRecorder::updateFillColor):
(WebCore::DrawGlyphsRecorder::updateStrokeColor):
(WebCore::DrawGlyphsRecorder::recordDrawGlyphs):
LayoutTests:
- platform/ios-wk2/TestExpectations:
- 10:48 AM Changeset in webkit [292477] by
-
- 58 edits in trunk/Source
Reduce number of conversions from StringView to String
https://bugs.webkit.org/show_bug.cgi?id=238841
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- runtime/RegExp.h:
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
Source/WebCore:
- Modules/cache/DOMCacheEngine.cpp:
(WebCore::DOMCacheEngine::queryCacheMatch):
- dom/ViewportArguments.cpp:
(WebCore::viewportErrorMessage):
- inspector/agents/page/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
- loader/CrossOriginAccessControl.cpp:
(WebCore::validateCrossOriginRedirectionURL):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::disallowWebArchive const):
(WebCore::DocumentLoader::maybeLoadEmpty):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::checkURLSchemeAsCORSEnabled):
- loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::representationExistsForURLScheme const):
(WebCore::EmptyFrameLoaderClient::generatedMIMETypeForURLScheme const):
- loader/EmptyFrameLoaderClient.h:
- loader/FrameLoaderClient.h:
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime const):
- loader/soup/ResourceLoaderSoup.cpp:
(WebCore::ResourceLoader::loadGResource):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::allowsLoadFromURL const):
- page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin):
(WebCore::shouldTreatAsPotentiallyTrustworthy):
(WebCore::SecurityOrigin::isSecure):
(WebCore::SecurityOrigin::canDisplay const):
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowObjectFromSource const):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource const):
(WebCore::ContentSecurityPolicy::allowResourceFromSource const):
(WebCore::ContentSecurityPolicy::allowWorkerFromSource const):
(WebCore::ContentSecurityPolicy::allowScriptFromSource const):
(WebCore::ContentSecurityPolicy::allowStyleFromSource const):
(WebCore::ContentSecurityPolicy::allowConnectToSource const):
(WebCore::ContentSecurityPolicy::allowBaseURI const):
- page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::schemeIsInHttpFamily):
(WebCore::ContentSecurityPolicySourceList::isValidSourceForExtensionMode):
- platform/LegacySchemeRegistry.cpp:
(WebCore::LegacySchemeRegistry::schemeIsHandledBySchemeHandler):
(WebCore::LegacySchemeRegistry::shouldTreatURLSchemeAsLocal):
(WebCore::LegacySchemeRegistry::shouldTreatURLSchemeAsNoAccess):
(WebCore::LegacySchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
(WebCore::LegacySchemeRegistry::shouldTreatURLSchemeAsSecure):
(WebCore::LegacySchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
(WebCore::LegacySchemeRegistry::canDisplayOnlyIfCanRequest):
(WebCore::LegacySchemeRegistry::shouldTreatURLSchemeAsCORSEnabled):
(WebCore::LegacySchemeRegistry::schemeShouldBypassContentSecurityPolicy):
(WebCore::LegacySchemeRegistry::shouldAlwaysRevalidateURLScheme):
(WebCore::LegacySchemeRegistry::isUserExtensionScheme):
- platform/LegacySchemeRegistry.h:
- platform/PublicSuffix.h:
- platform/mac/PublicSuffixMac.mm:
(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::getBlobDataFromURL const):
- platform/network/CacheValidation.cpp:
(WebCore::headerValueForVary):
(WebCore::collectVaryingRequestHeadersInternal):
(WebCore::collectVaryingRequestHeaders):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::get const):
(WebCore::HTTPHeaderMap::getUncommonHeader const):
- platform/network/HTTPHeaderMap.h:
- platform/network/HTTPParsers.cpp:
(WebCore::isCrossOriginSafeHeader):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::httpHeaderField const):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingToTainting):
(WebCore::ResourceResponseBase::httpHeaderField const):
- platform/network/ResourceResponseBase.h:
- platform/network/curl/PublicSuffixCurl.cpp:
(WebCore::isPublicSuffix):
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::checkTLSErrors):
- platform/soup/PublicSuffixSoup.cpp:
(WebCore::isPublicSuffix):
Source/WebKit:
- NetworkProcess/NetworkSchemeRegistry.cpp:
(WebKit::NetworkSchemeRegistry::shouldTreatURLSchemeAsCORSEnabled):
- NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::updateVaryInformation):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::proxyDictionary):
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::shouldAllowHSTSPolicySetting const):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::tryLoadingSynchronouslyUsingURLSchemeHandler):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::representationExistsForURLScheme const):
(WebKit::WebFrameLoaderClient::generatedMIMETypeForURLScheme const):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::cookiesForDOM):
(WebKit::WebCookieCache::setCookiesFromDOM):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canHandleRequest):
(WebKit::WebPage::urlSchemeHandlerForScheme):
- WebProcess/WebPage/WebPage.h:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::representationExistsForURLScheme const):
(WebFrameLoaderClient::generatedMIMETypeForURLScheme const):
Source/WebKitLegacy/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::representationExistsForURLScheme const):
(WebFrameLoaderClient::generatedMIMETypeForURLScheme const):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WTF:
- wtf/URL.cpp:
(WTF::defaultPortForProtocol):
- wtf/text/StringHash.h:
(WTF::StringViewHashTranslator::hash):
(WTF::StringViewHashTranslator::equal):
- 10:46 AM Changeset in webkit [292476] by
-
- 2 edits in trunk/Source/WebCore
Further clean-ups for features.json
https://bugs.webkit.org/show_bug.cgi?id=238769
Reviewed by Tim Nguyen.
While editing the Features file, I noticed two things:
- A number of APIs that we do not support were missing.
- A number of APIs were included in the "Features" section, rather than the "Standards" section.
This patch corrects both issues.
- features.json:
- 10:05 AM Changeset in webkit [292475] by
-
- 9 edits in trunk/Source/JavaScriptCore
CSE should be more careful with values that have WritesPinned, ExitsSideways, or are of different sizes
https://bugs.webkit.org/show_bug.cgi?id=238302
Reviewed by Saam Barati.
1) CSE for WasmAddressValue searches for any nodes marked with WritesPinned between all paths from the redundant
WasmAddressValue to the replacement that dominates it. For a switch construct, we might miss some paths while
performing this DFS of predecessor blocks because the termination condition was a break instead of a continue.
2) The CSE phase looks for a pattern it calls a store after clobber. That is, two stores to the same location where
the first store is not observable. It searches for reads and writes that overlap with the store and its clobber, and
bails if it finds them. When we add in CSE for WasmAddressValue, we expose the fact that WasmBoundsCheck has ExitSideways
but does not claim to read top, even though the code it exits to totally can. This can cause us to eliminate an observable store.
3) The store after clobber phase does not check that the size of the clobber is the same as the size of the store. Again,
this is usually hidden by JavaScript because the sizes are usually the same. Also, when WASM fast memory is enabled, this
bug is hidden because the loads/stores say that they may trap. That is why the unity test case only failed on iOS (although
it does fail on mac with XPC_JSC_useWebAssemblyFastMemory=0).
- b3/B3EliminateCommonSubexpressions.cpp:
- b3/testb3.h:
- b3/testb3_8.cpp:
(testWasmAddressDoesNotCSE):
(addCopyTests):
- 9:36 AM Changeset in webkit [292474] by
-
- 9 edits in trunk/Tools
[git-webkit] Apply labels based on tracker
https://bugs.webkit.org/show_bug.cgi?id=238640
<rdar://problem/91135356>
Reviewed by Stephanie Lewis.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py:
(GitHub._issue): Handle case where empty assignee can be resolved.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
(GitHub.init): Pass issues, projects and labels to base class.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.main): If we have an associated issue and can apply labels to our pull request,
apply the issue's component and version labels to our pull request.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
Canonical link: https://commits.webkit.org/249325@main
- 9:16 AM Changeset in webkit [292473] by
-
- 9 edits in trunk/Source
[Cocoa] Use GCD webrtc task queue
https://bugs.webkit.org/show_bug.cgi?id=238861
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
- Source/webrtc/api/create_peerconnection_factory.cc:
- Source/webrtc/api/create_peerconnection_factory.h:
- libwebrtc.xcodeproj/project.pbxproj:
Source/WebCore:
Covered by existing tests.
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::createPeerConnectionFactory):
- 9:02 AM Changeset in webkit [292472] by
-
- 2 edits in trunk/Tools
Remove test ResourceLoadStatistics.RemoveSessionID
https://bugs.webkit.org/show_bug.cgi?id=238815
Reviewed by Youenn Fablet.
This test should be removed because:
- The use case it wanted to examine no longer exists: this test was added in r246449 to verify that
WebResourceLoadStatisticsStore does not access storage session after a NetworkSession is removed in network
process. This could happen because NetworkSession was refcounted and it could stay alive after it's removed from
the map of NetworkProcess. NetworkSession is no longer refcounted after r247831.
- Session removal, which the test wants to check, is not happening during this test: simply put, a download can
hold WebsiteDataStore alive, and the test does not wait for the download to finish. (This can be easily verified
by checking if ~WebsiteDataStore() is invoked.)
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
- 9:00 AM Changeset in webkit [292471] by
-
- 4 edits in trunk/Source/WebKit
ServiceWorkerDownloadTask starts listening for IPC in constructor
https://bugs.webkit.org/show_bug.cgi?id=238860
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-06
Reviewed by Youenn Fablet.
IPC messages will start to be delivered after connection->addThreadMessageReceiver(..., this, ..) from
the message receive queue. This function cannot be called in the constructor, since the
virtual function table of thethisobject has not been constructed fully yet. This means
that if a message arrives during the constructor, it is dispatched via incorrect virtual function pointer.
Initiate the listening from a separate function that is called from ServiceWorkerDownloadTask::create().
No new tests, not testable.
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:
(WebKit::ServiceWorkerDownloadTask::startListeningForIPC):
(WebKit::ServiceWorkerDownloadTask::close):
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:
(WebKit::ServiceWorkerDownloadTask::create):
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::registerDownload):
(WebKit::WebSWServerToContextConnection::unregisterDownload):
- 8:40 AM Changeset in webkit [292470] by
-
- 2 edits in trunk/Source/WebCore/PAL
Support PKShippingMethods on iOS
https://bugs.webkit.org/show_bug.cgi?id=238845
<rdar://problem/91320467>
Reviewed by Devin Rousso.
- Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h: Move PKShippingMethods SPI declarations out of MacOS specific #ifdefs.
Canonical link: https://commits.webkit.org/249321@main
- 8:22 AM Changeset in webkit [292469] by
-
- 35 edits in trunk
Unify the two ImageBuffer::create() functions, passing RenderingPurpose everywhere
https://bugs.webkit.org/show_bug.cgi?id=238851
Reviewed by Said Abou-Hallawa.
I need to extend RenderingPurpose flags to distinguish layer backing store buffers from
other kinds of buffers. Before doing so, collapse the two ImageBuffer::create() functions
together by combining RenderingMode and ShouldUseDisplayList into OptionSet<ImageBufferOptions>,
and passing RenderingPurpose everywhere.
Always passing RenderingPurpose is revealing, because it finds call sites in the
web process that can trigger accelerated buffers (e.g. webkit.org/b/238846).
Source/WebCore:
- Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNeeded):
- Modules/mediasession/MediaMetadata.cpp:
(WebCore::ArtworkImageLoader::notifyFinished):
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
- html/CustomPaintCanvas.cpp:
(WebCore::CustomPaintCanvas::copiedImage const):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer const):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::createBufferForPainting const):
- html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createImageBuffer):
- html/canvas/ImageBitmapRenderingContext.cpp:
(WebCore::ImageBitmapRenderingContext::setOutputBitmap):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):
- html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::indexForData):
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRectWithClip):
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::screenshot):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::preTransformedNativeImageForCurrentFrame):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createImageBuffer const):
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::create):
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
- platform/graphics/RenderingMode.h:
- platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::WTF_REQUIRES_LOCK):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawShadowLayer):
- platform/graphics/SourceImage.cpp:
(WebCore::SourceImage::imageBuffer const):
- platform/graphics/filters/FilterImage.cpp:
(WebCore::FilterImage::imageBufferFromPixelBuffer):
(WebCore::getConvertedPixelBuffer):
- platform/graphics/filters/software/FETileSoftwareApplier.cpp:
(WebCore::FETileSoftwareApplier::apply const):
- platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:
(Nicosia::GCGLANGLELayer::swapBuffersIfNeeded):
- platform/graphics/texmap/BitmapTexture.cpp:
(WebCore::BitmapTexture::updateContents):
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::imageBuffer const):
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- svg/SVGFEImageElement.cpp:
(WebCore::createImageBuffer):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImage):
Source/WebKitLegacy/mac:
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::imageForCurrentSharingServicePickerItem):
Tools:
- TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:
(TestWebKitAPI::TEST):
- 8:20 AM Changeset in webkit [292468] by
-
- 10 edits in trunk
In case of COOP-based process swap, we need to make sure the document gets controlled by its matching service worker registration
https://bugs.webkit.org/show_bug.cgi?id=238800
<rdar://problem/91288849>
Reviewed by Chris Dumez.
Source/WebKit:
Make sure in case loader is transferred to call controlClient in the new WebProcess.
To do so, we also update page and frame IDs.
Covered by API test.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkLoadParameters.h:
- NetworkProcess/NetworkResourceLoadParameters.h:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- 8:11 AM Changeset in webkit [292467] by
-
- 42 edits4 adds in trunk
[css] Turn -webkit-border-image into a shorthand
https://bugs.webkit.org/show_bug.cgi?id=237487
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Update tests to take into account that '-webkit-border-image' is a shorthand.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
Source/WebCore:
The '-webkit-border-image' property was considered to be a longhand,
sharing computed values with the various 'border-image-*'.
This patch turns it into a shorthand of 'border-image-*'.
Tests: fast/borders/border-image-legacy.html
fast/css/border-image-style-length.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/image-set-parsing.html
fast/css/uri-token-parsing.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
svg/css/getComputedStyle-basic.xhtml
- Sources.txt:
Add the new file CSSBorderImageWidthValue.cpp.
- WebCore.xcodeproj/project.pbxproj:
Add the new files CSSBorderImageWidthValue.h and
CSSBorderImageWidthValue.cpp.
- animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
When animating border-image-width, take into account that it can come
from -webkit-border-image, and thus override border widths.
Do not interpolate a value a does override border widths with another
value that does not.
Even if border-image-width accepts <length-percentage>, when overriding
border widths do not interpolate between a <length-percentage> and a
plain <length>, since only the latter are valid border widths.
- css/CSSBorderImageWidthValue.cpp: Added.
(WebCore::CSSBorderImageWidthValue::CSSBorderImageWidthValue):
(WebCore::CSSBorderImageWidthValue::customCSSText const):
(WebCore::CSSBorderImageWidthValue::equals const):
- css/CSSBorderImageWidthValue.h: Added.
Add CSSBorderImageWidthValue class, based on CSSBorderImageSliceValue.
It's a wrapper for a CSS_QUAD CSSPrimitiveValue, but with a bool that
indicates if the value will override border widths.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImage):
(WebCore::valueForReflection):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
Serialize border-image-width as empty string if it overrides border
widths, since its grammar doesn't allow this.
Serialize border-image as empty string if border-image-width overrides
border widths, since its grammar doesn't allow this.
Handle serialization of -webkit-border-image.
- css/CSSProperties.json:
Turn -webkit-border-image into a shorthand of border-image-source,
border-image-slice, border-image-width, border-image-outset and
border-image-repeat.
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapNinePieceImage):
(WebCore::CSSToStyleMap::mapNinePieceImageWidth):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
- css/CSSToStyleMap.h:
Handle CSSBorderImageWidthValue values.
Remove old way of handling -webkit-border-image.
- css/CSSValue.cpp:
(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isBorderImageWidthValue const):
Handle new CSSBorderImageWidthValue value.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::borderImagePropertyValue const):
(WebCore::StyleProperties::asText const):
- css/StyleProperties.h:
Serialize border-image as empty string if border-image-width overrides
border widths, since its grammar doesn't allow this.
Handle serialization of -webkit-border-image.
Make cssText choose the right shorthand between border-image and
-webkit-border-image. Prefer the former if both are suitable.
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeBorderImageWidth):
(WebCore::consumeBorderImageComponents):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::consumeBorderImage):
(WebCore::CSSPropertyParser::parseShorthand):
Parse border-image-width as a CSSBorderImageWidthValue.
Parse -webkit-border-image as a shorthand.
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
Take into account that border widths may be overridden.
- rendering/style/BorderData.h:
(WebCore::BorderData::borderLeftWidth const):
(WebCore::BorderData::borderRightWidth const):
(WebCore::BorderData::borderTopWidth const):
(WebCore::BorderData::borderBottomWidth const):
Add logic for overriding border widths. Same approach as 'border-style'
set to 'none' making the border widths compute to '0px'.
- rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::Data::Data):
(WebCore::NinePieceImage::Data::create):
(WebCore::NinePieceImage::Data::operator== const):
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::overridesBorderWidths const):
(WebCore::NinePieceImage::setOverridesBorderWidths):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
Add flag for overriding border widths.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setBorderImageWidthOverridesBorderWidths):
- rendering/style/RenderStyle.h:
Add method for setting flag to override border widths.
- style/PropertyCascade.cpp:
(WebCore::Style::shouldApplyPropertyInParseOrder):
Stop deferring border image properties. That was previously needed since
-webkit-border-image was a longhand sharing a computed value with the
border-image longhands. No longer needed since -webkit-border-image is
now a horthand.
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertBorderMask):
(WebCore::Style::BuilderConverter::convertReflection):
(WebCore::Style::BuilderConverter::convertBorderImage): Deleted.
Remove code no longer needed.
- style/StyleBuilderCustom.h:
(WebCore::Style::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::Style::ApplyPropertyBorderImageModifier::applyValue):
Handle border-image-width as a CSSBorderImageWidthValue.
LayoutTests:
Update tests to take into account that '-webkit-border-image' is a shorthand.
- fast/borders/border-image-legacy-expected.txt: Added.
- fast/borders/border-image-legacy.html: Added.
- fast/css/border-image-style-length-expected.txt:
- fast/css/border-image-style-length.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- fast/css/image-set-parsing-expected.txt:
- fast/css/image-set-parsing.html:
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html:
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 8:07 AM Changeset in webkit [292466] by
-
- 6 edits in trunk
[:has() pseudo-class] Support invalidation for more input pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=238451
Reviewed by Antti Koivisto.
- :indeterminate
- :read-only
- :read-write
- :required
- :optional
LayoutTests/imported/w3c:
Split the test in multiple subtests.
- web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt:
- web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html:
Source/WebCore:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseAttribute):
(WebCore::HTMLFormControlElement::readOnlyStateChanged):
(WebCore::HTMLFormControlElement::requiredStateChanged):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setIndeterminate):
- 8:02 AM Changeset in webkit [292465] by
-
- 6 edits in trunk
[CSS-Contain] Grid layout should take "contain: inline-size" into account when computing the grid item's logical width
https://bugs.webkit.org/show_bug.cgi?id=238850
Reviewed by Antti Koivisto.
Source/WebCore:
Ignore grid item's logical width when "contain: inline-size" is present (i.e. ignore descendant content in inline direction when sizing).
- rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::computeGridContainerIntrinsicSizes):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minLogicalSizeForChild const):
(WebCore::GridTrackSizingAlgorithm::advanceNextState):
- rendering/GridTrackSizingAlgorithm.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeEmptyTracksForAutoRepeat const):
LayoutTests:
- 7:33 AM Changeset in webkit [292464] by
-
- 3 edits in trunk/Tools
REGRESSION(r292308): links to results is wrong for some tests
https://bugs.webkit.org/show_bug.cgi?id=238862
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-04-06
Reviewed by Youenn Fablet.
Since r292308 we generate the wrong links in the results for the tests that end with .https.html. This is because
the output_filename is expected to have the extension, that is removed before renturing the value. Since
r292308, the extension is removed first, so .https is considered the extension and removed too.
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.output_filename):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image):
(TestResultWriterTest):
(TestResultWriterTest.test_output_filename):
- 7:19 AM Changeset in webkit [292463] by
-
- 14 edits in trunk
[css] Turn -webkit-text-orientation into a legacy shorthand
https://bugs.webkit.org/show_bug.cgi?id=238356
Reviewed by Antti Koivisto.
Source/WebCore:
-webkit-text-orientationandtext-orientationwere both implemented
as longhands, just with arelated-propertyflag so that declaration
blocks with both of them would use the one appearing last.
However, the logic for
related-propertywasn't always working well.
In bug 238350 I plan to merge it with shouldApplyPropertyInParseOrder(),
which has the same purpose and works better. But it's not suitable for
high priority properties liketext-orientation.
So this patch turns
-webkit-text-orientationinto a shorthand that
expands intotext-orientation.
-webkit-text-orientationcontinues accepting the legacy value
sideways-right, which is now mapped intosidewaysat parse time.
Previously this happened at computed-value time, but it implied that
serializingtext-decorationcould yield an invalid value.
Tests: fast/text/text-orientation-parse-competition.html
fast/text/text-orientation-parse-stylesheet.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextOrientation const):
Remove mapping ofsideways-rightintosideways, this is now
done at parse time. Also remove mapping ofvertical-rightintomixed
sincevertical-rightis a remnant of the past which has not been
considered valid syntax for years.
- css/CSSProperties.json:
Turn
-webkit-text-orientationinto a shorthand oftext-orientation.
Remove theirrelated-propertyflags and a remnant ofvertical-right.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
Add code for serializing the-webkit-text-orientationshorthand.
- css/makeprop.pl:
Avoid a compile warning in getRelatedPropertyId() when no property has
therelated-propertyflag.
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
Remove-webkit-text-orientationfrom code which is only relevant for
longhands.
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeLegacyTextOrientation):
(WebCore::CSSPropertyParser::parseShorthand):
Add parsing logic for-webkit-text-orientationas a shorthand.
- css/parser/CSSPropertyParser.h:
Add parsing logic for
-webkit-text-orientationas a shorthand.
- style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueWebkitTextOrientation): Deleted.
Remove-webkit-text-orientationfrom code which is only relevant for
longhands.
LayoutTests:
- fast/text/text-orientation-parse-competition-expected.txt:
- fast/text/text-orientation-parse-competition.html:
Check that if a stylesheet specifies both -webkit-text-orientation and
text-orientation for the same element, the last specified one wins.
- fast/text/text-orientation-parse-stylesheet-expected.txt:
- fast/text/text-orientation-parse-stylesheet.html:
Check that only -webkit-text-orientation accepts
sideways-right, and
that it's mapped tosidewaysat parse time.
- 6:33 AM Changeset in webkit [292462] by
-
- 2 edits in trunk/Source/WebCore
[TextureMapper] Clean up the GraphicsContextGLTextureMapperANGLE header
https://bugs.webkit.org/show_bug.cgi?id=238864
Reviewed by Carlos Garcia Campos.
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:
Remove two unused libgbm declarations and mark the class destructor as
virtual, which it is due to its inheritance.
- 6:29 AM Changeset in webkit [292461] by
-
- 9 edits in trunk/Source/WebKit
Media and WebRTC code uses ThreadMessageReceiverRefCounted with WorkQueues
https://bugs.webkit.org/show_bug.cgi?id=238858
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-06
Reviewed by Youenn Fablet.
Media and WebRTC code uses IPC::Connection::ThreadMessageReceiverRefCounted
to submit work to a WorkQueue. For this use-case, IPC::Connection has
IPC::Connection::WorkQueueMessageReceiver, which does the same.
This is work towards simplifying IPC::Connection by removing
ThreadMessageReceiverRefCounted.
No new tests, refactor.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
(WebKit::LibWebRTCCodecsProxy::initialize):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::startListeningForIPC):
(WebKit::RemoteSampleBufferDisplayLayerManager::close):
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
(WebKit::RemoteSampleBufferDisplayLayerManager::releaseLayer):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::LibWebRTCCodecs::ensureGPUProcessConnectionOnMainThreadWithLock):
(WebKit::LibWebRTCCodecs::ensureGPUProcessConnectionAndDispatchToThread):
(WebKit::LibWebRTCCodecs::gpuProcessConnectionDidClose):
- WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
(WebKit::RemoteCaptureSampleManager::stopListeningForIPC):
(WebKit::RemoteCaptureSampleManager::setConnection):
- WebProcess/cocoa/RemoteCaptureSampleManager.h:
- 5:36 AM Changeset in webkit [292460] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Fix GTK build after r292458
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::hostFileDescriptor):
- 4:17 AM Changeset in webkit [292459] by
-
- 35 edits3 adds1 delete in trunk
Implement ServiceWorkerWindowClient.navigate
https://bugs.webkit.org/show_bug.cgi?id=238738
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/windowclient-navigate.https-expected.txt:
Source/WebCore:
Introduce a routine to navigate a Document.
Send FrameIdentifier as part of ServiceWorkerClientData.
Implement ServiceWorkerWindowClient::navigate by sending IPC to network process.
Test: http/wpt/service-workers/navigate-iframes-window-client.https.html
- dom/Document.cpp:
- dom/Document.h:
- loader/FrameLoader.cpp:
- workers/service/ServiceWorkerClientData.cpp:
- workers/service/ServiceWorkerClientData.h:
- workers/service/ServiceWorkerWindowClient.cpp:
- workers/service/context/SWContextManager.h:
- workers/service/server/SWServer.cpp:
- workers/service/server/SWServer.h:
- workers/service/server/SWServerWorker.cpp:
- workers/service/server/SWServerWorker.h:
Source/WebKit:
When receiving a request to navigate a client, send message to UIProcess.
UIProcess locates the WebFrameProxy which will send an IPC message to the WebProcess to do navigation.
We keep track of the navigation within WebFrameProxy.
In case of process swapping, we make sure to transfer the WebFrameProxy callback.
In case of policy decision to stop loads, we resolve the promise with an empty client.
A follow-up patch may reject the promise once the expected behavior will be clarified.
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
- UIProcess/Network/NetworkProcessProxy.cpp:
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/ProvisionalPageProxy.cpp:
- UIProcess/WebFrameProxy.cpp:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
LayoutTests:
- http/wpt/service-workers/navigate-iframes-window-client.https-expected.txt: Added.
- http/wpt/service-workers/navigate-iframes-window-client.https.html: Added.
- http/wpt/service-workers/navigate-window-client-worker.js: Added.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- 4:16 AM Changeset in webkit [292458] by
-
- 14 edits in trunk/Source/WebKit
[Unix] Adopt UnixFileDescriptor in IPC::Attachment
https://bugs.webkit.org/show_bug.cgi?id=238801
Reviewed by Carlos Garcia Campos.
Adopt WTF::UnixFileDescriptor for usage in IPC::Attachment, in place of
a raw integer value. This simplifies move operations and destruction of
this value.
The two relevant constructors are changed to expect a UnixFileDescriptor
rvalue, and they're also made explicit. The file descriptor object is
accessible through both a const and a non-const getter, which allows the
user to read or release the file descriptor contained there. There's
also a release method that returns the contained UnixFileDescriptor.
The releaseFileDescriptor() and fileDescriptor() methods, previously
releasing or returning the contained integer value of the descriptor.
Call sites for these methods as well as the old-form constructors are
adjusted to the new variants.
- Platform/IPC/Attachment.h:
(IPC::Attachment::isNull const):
(IPC::Attachment::fd const):
(IPC::Attachment::release):
(IPC::Attachment::releaseFileDescriptor): Deleted.
(IPC::Attachment::fileDescriptor const): Deleted.
- Platform/IPC/unix/AttachmentUnix.cpp:
(IPC::Attachment::Attachment):
(IPC::Attachment::operator=):
(IPC::Attachment::~Attachment): Deleted.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):
(IPC::Connection::sendOutputMessage):
(IPC::Connection::createConnectionIdentifierPair):
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::isNull const):
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::createHandle):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<UnixFileDescriptor>::encode):
(IPC::ArgumentCoder<UnixFileDescriptor>::decode):
- Shared/glib/UserMessage.cpp:
(WebKit::UserMessage::encode const):
(WebKit::UserMessage::decode):
- UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::hostFileDescriptor):
- UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/GPU/GPUProcessConnectionInfo.h:
(WebKit::GPUProcessConnectionInfo::identifier const):
(WebKit::GPUProcessConnectionInfo::releaseIdentifier):
- WebProcess/Inspector/WebInspector.cpp:
(WebKit::WebInspector::setFrontendConnection):
- WebProcess/Network/NetworkProcessConnectionInfo.h:
(WebKit::NetworkProcessConnectionInfo::identifier const):
(WebKit::NetworkProcessConnectionInfo::releaseIdentifier):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::hostFileDescriptor const):
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- 3:13 AM Changeset in webkit [292457] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] Add DoNotHaveTagRegisters mode to unboxDouble
https://bugs.webkit.org/show_bug.cgi?id=238018
Patch by Xan Lopez <Xan Lopez> on 2022-04-06
Reviewed by Yusuke Suzuki.
Wasm cannot use unboxDouble as-is because
GPRInfo::numberTagRegister is not available. Add a
DoNotHaveTagRegister mode so we can get rid of some duplicated
code.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::unboxDoubleWithoutAssertions):
(JSC::AssemblyHelpers::unboxDouble):
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
- 3:05 AM Changeset in webkit [292456] by
-
- 15 edits in trunk
ServiceWorkerClients.openWindow should not need to get all clients asynchronously to resolve its promise
https://bugs.webkit.org/show_bug.cgi?id=238503
Reviewed by Chris Dumez.
Source/WebCore:
Move matching client in openWindow in network process as an optimization.
This also prevents some race conditions where the opened page could quickly navigate to another page.
Also have a code path that rejects the openWindow promise, and trigger that code path in case of internal error.
Covered by existing and API test.
- workers/WorkerGlobalScope.h:
- workers/service/ServiceWorkerClients.cpp:
- workers/service/context/SWContextManager.h:
- workers/service/server/SWServer.cpp:
- workers/service/server/SWServer.h:
- workers/service/server/SWServerToContextConnection.h:
Source/WebKit:
Add logic to get the client from its page ID.
In case of internal error case, trigger promise rejection instead of promise resolution with null.
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
- WebProcess/Storage/WebSWContextManagerConnection.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- 2:16 AM Changeset in webkit [292455] by
-
- 5 edits in trunk/Source/WebCore
Remove some @apply leftover code
https://bugs.webkit.org/show_bug.cgi?id=238857
Reviewed by Tim Nguyen.
@apply is not a thing.
- css/CSSVariableData.h:
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeAtRule):
(WebCore::CSSParserImpl::consumeDeclarationList):
- css/parser/CSSParserImpl.h:
- css/parser/CSSVariableParser.cpp:
(WebCore::classifyBlock):
(WebCore::isValidVariableReference):
(WebCore::isValidConstantReference):
(WebCore::classifyVariableRange):
(WebCore::CSSVariableParser::containsValidVariableReferences):
(WebCore::CSSVariableParser::parseDeclarationValue):
- 2:04 AM Changeset in webkit [292454] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Nested includes do not change offlineasm hash output
https://bugs.webkit.org/show_bug.cgi?id=237779
Reviewed by Mark Lam.
The Ruby tooling around offlineasm can produce on their output a line containing a
checksum which depends on the input files processed. This is used to avoid redoing
in case the source files have not been changed since the last run. While there is
code to scan the "include" directives in the main input file and take the included
files into account for checksum calculation, included files themselves were not being
further processed for the second or additional levels of "include:. This adds the
missing recursive processing of "include" directives in order to take nested includes
into account.
- offlineasm/parser.rb: Process nested includes recursively for checksum calculation.
- 1:52 AM Changeset in webkit [292453] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC]Squash alignment warning
https://bugs.webkit.org/show_bug.cgi?id=238670
Unreviewed gardening.
Squash a "cast increases required alignment of target type" due to
poiner arithmetic via char*
Patch by Geza Lore <Geza Lore> on 2022-04-06
- wasm/WasmSignature.h:
(JSC::Wasm::Signature::storage):
- 12:48 AM Changeset in webkit [292452] by
-
- 4 edits in trunk/Tools
[Flatpak SDK][AT-SPI] Use xdg-dbus-proxy to expose the a11y bus
https://bugs.webkit.org/show_bug.cgi?id=238856
Reviewed by Carlos Garcia Campos.
Expose the host at-spi socket with xdg-dbus-proxy to avoid at-spi
bailing out by not being able to connect to the a11y bus.
Also add the exported address to the environement of the tests.
Based on the original patch by Patrick Griffis with minor updates.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):
- flatpak/flatpakutils.py:
(WebkitFlatpak.setup_a11y_proxy):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak.get_user_runtime_dir): Deleted.
- 12:05 AM Changeset in webkit [292451] by
-
- 6 edits in trunk/Source
Remove Notification::m_relatedNotificationIdentifier
https://bugs.webkit.org/show_bug.cgi?id=238603
Reviewed by Brady Eidson.
Source/WebCore:
m_relatedNotificationIdentifier was added as a temporary workaround for persistent notifications that are recreated in other contexts.
To directly support this case, Notification is no longer a Identified<UUID> and instead has a m_identifier.
When created from JS, Notification::m_identifier is generated.
When created from NotificationData, Notification::m_identifier is copied from NotificationData.
Covered by existing tests.
- Modules/notifications/Notification.cpp:
- Modules/notifications/Notification.h:
Source/WebKit:
Directly use identifier now that we correctly reuse them when needed.
We no longer store persistent notifications in the map since we do not use the map for click/close events.
- WebProcess/Notifications/WebNotificationManager.cpp:
- WebProcess/Notifications/WebNotificationManager.h:
Apr 5, 2022:
- 11:06 PM Changeset in webkit [292450] by
-
- 5 edits in trunk/Source/bmalloc
[libpas] Run TLC decommit rarely
https://bugs.webkit.org/show_bug.cgi?id=238855
Reviewed by Saam Barati.
We were running libpas TLC decommit every time. But it is too frequent. We should capture IsoHeap allocation pattern
with much more longer period, and perform TLC decommit in such a low-frequency rate.
This patch changes it so that we run it only once a 128 scavenger run. It is roughly once a 13 seconds.
- libpas/src/libpas/pas_scavenger.c:
(scavenger_thread_main):
(pas_scavenger_clear_all_caches):
- libpas/src/libpas/pas_thread_local_cache.c:
(pas_thread_local_cache_for_all):
- libpas/src/libpas/pas_thread_local_cache.h:
- libpas/src/test/TLCDecommitTests.cpp:
(std::testTLCDecommit):
(std::testTLCDecommitThenDestroyImpl):
(std::testTLCDecommitThenDeallocate):
- 10:30 PM Changeset in webkit [292449] by
-
- 17 edits2 adds in trunk
[WebXR] Add a new enum type to represent session features
https://bugs.webkit.org/show_bug.cgi?id=238837
Patch by Ada Chan <adachan@apple.com> on 2022-04-05
Reviewed by Dean Jackson.
Source/WebCore:
Test: http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https.html
Add a new enum type, PlatformXR::SessionFeature, to represent session features.
It includes the ReferenceSpaceTypes and the hand-tracking feature for now.
Fix the algorithm to resolve the requested features to recognize hand-tracking
as a feature that requires explicit consent.
- Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::referenceSpaceIsSupported const):
Convert the XRReferenceSpaceType to PlatformXR::SessionFeature first before
checking against the feature list.
- Modules/webxr/WebXRSystem.cpp:
(WebCore::WebXRSystem::inlineSessionRequestIsAllowedForGlobalObject const):
Use PlatformXR::parseSessionFeatureDescriptor() to parse the feature string.
(WebCore::featureRequiresExplicitConsent):
Returns true for the hand tracking feature.
(WebCore::WebXRSystem::isFeatureSupported const):
Check whether the device supports the feature. For hand-tracking, make sure
the hand input module setting is enabled.
(WebCore::WebXRSystem::resolveRequestedFeatures const):
Update the string conversion between JS and WTF::String now that features cannot
be parsed as XRReferenceSpaceType enum. If the feature requires explicit consent
and it's not already in the granted list, add it to consentRequired or consentOptional
depending on whether it's specified as required.
(WebCore::WebXRSystem::resolveFeaturePermissions const):
If a feature is required but not given a clear signal of user intent, the session
should not be created.
(WebCore::WebXRSystem::DummyInlineDevice::DummyInlineDevice):
Updated to use PlatformXR::SessionFeature.
- Modules/webxr/WebXRSystem.h:
- platform/xr/PlatformXR.h:
(PlatformXR::sessionFeatureFromReferenceSpaceType):
(PlatformXR::parseSessionFeatureDescriptor):
Parse feature string to return PlatformXR::SessionFeature.
(PlatformXR::sessionFeatureDescriptor):
Return feature string from PlatformXR::SessionFeature.
(PlatformXR::Device::supports const):
Read from the m_supportedFeaturesMap.
(PlatformXR::Device::setSupportedFeatures):
Write to the m_supportedFeaturesMap.
(PlatformXR::Device::supportedFeatures const):
Read from the m_supportedFeaturesMap.
- platform/xr/openxr/PlatformXROpenXR.cpp:
(PlatformXR::OpenXRDevice::collectSupportedFeatures const):
Updated to use PlatformXR::SessionFeature.
- testing/WebXRTest.cpp:
(WebCore::WebXRTest::simulateDeviceConnection):
Updated to parse feature string to PlatformXR::SessionFeature.
Source/WebKit:
Add a new _WKXRSessionFeatureFlags entry for hand-tracking.
- Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
- Shared/XR/XRDeviceProxy.cpp:
(WebKit::XRDeviceProxy::XRDeviceProxy):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::toWKXRSessionFeatureFlags):
(WebKit::toPlatformXRFeatures):
- UIProcess/XR/PlatformXRSystem.cpp:
(WebKit::PlatformXRSystem::requestPermissionOnSessionFeatures):
- UIProcess/XR/PlatformXRSystem.h:
- UIProcess/XR/PlatformXRSystem.messages.in:
LayoutTests:
Test listing "hand-tracking" as an optional feature while the device does not
support it allows the session to be created.
Test listing "hand-tracking" as a required feature while the device does not
support it would not create the session.
- http/wpt/webxr/resources/webxr_test_constants_single_view.js:
- http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https-expected.txt: Added.
- http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https.html: Added.
- 9:07 PM Changeset in webkit [292448] by
-
- 3 edits in trunk/Source/WebKit
[iOS] Update the context menu item glyph for visual look up
https://bugs.webkit.org/show_bug.cgi?id=238853
Reviewed by Devin Rousso.
Switch from
info.circleto the (private) symbolinfo.circle.and.sparkles, for the icon next to the Look Up
item when long pressing images that have visual look up results.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction imageForElementActionType:]):
- 8:41 PM Changeset in webkit [292447] by
-
- 10 edits in trunk/Source/JavaScriptCore
[JSC] Use inlined assertion for CodeBlock type
https://bugs.webkit.org/show_bug.cgi?id=238849
Reviewed by Michael Saboff.
We introduced probeDebug-based CodeBlock assertion, but it is too slow and causing timeout on Debug JSC tests.
Instead, we use inlined assertion which is much faster to prevent these Debug build timeout.
- assembler/AbortReason.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):
- jit/JIT.cpp:
(JSC::JIT::compileAndLinkWithoutFinalizing):
- jit/JITCode.h:
(JSC::JITCode::offsetOfJITType):
- 8:27 PM Changeset in webkit [292446] by
-
- 2 edits in trunk/Source/WebCore
Eliminate delays for processing live regions and modal notifications.
https://bugs.webkit.org/show_bug.cgi?id=238833
<rdar://problem/91314023>
Reviewed by Chris Fleizach.
We had arbitrary delays to process notifications for live regions and
modal elements. This is no longer necessary and may cause problems
updating the isolated tree that depends on these notifications being
processed in a timely manner.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::AXObjectCache::postLiveRegionChangeNotification):
(WebCore::AXObjectCache::focusModalNode):
- 5:54 PM Changeset in webkit [292445] by
-
- 20 edits in trunk/Source/JavaScriptCore
[JSC] Strictly annotate pointers with TrustedImmPtr in CCallHelpers
https://bugs.webkit.org/show_bug.cgi?id=238827
Reviewed by Mark Lam.
This allows us to detect pointer use in DFG easy. This is important in unlinked DFG development.
We also consistently use m_graph instead of m_jit.graph() in DFG::SpeculativeJIT.
We also purge CodeBlock* embedding in DFG code completely. Now we load it from the cfr
instead (compileLogShadowChickenTail and callOperationWithCallFrameRollbackOnException).
- dfg/DFGArrayifySlowPathGenerator.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
- dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::osrWriteBarrier):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitGetCallee):
(JSC::DFG::SpeculativeJIT::emitOSRExitFuzzCheck):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compileGetById):
(JSC::DFG::SpeculativeJIT::compileGetByIdFlush):
(JSC::DFG::SpeculativeJIT::compileDeleteById):
(JSC::DFG::SpeculativeJIT::compileDeleteByVal):
(JSC::DFG::SpeculativeJIT::compileInById):
(JSC::DFG::SpeculativeJIT::compileInByVal):
(JSC::DFG::SpeculativeJIT::compileHasPrivate):
(JSC::DFG::SpeculativeJIT::compileStringSlice):
(JSC::DFG::SpeculativeJIT::compileLoopHint):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileCheckTraps):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compilePutByVal):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::compileClampDoubleToByte):
(JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::nextBlock):
(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::callOperationWithCallFrameRollbackOnException):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther):
(JSC::DFG::SpeculativeJIT::compileToBoolean):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::fillSpeculateBigInt32):
(JSC::DFG::SpeculativeJIT::compileCompareEqPtr):
(JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther):
(JSC::DFG::SpeculativeJIT::compileToBoolean):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitUntypedBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
(JSC::DFG::SpeculativeJIT::compileNewTypedArrayWithInt52Size):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
(JSC::DFG::SpeculativeJIT::compileDateGet):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileUnaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::getPrivateName):
(JSC::FTL::DFG::LowerDFGToB3::compilePrivateBrandAccess):
(JSC::FTL::DFG::LowerDFGToB3::compilePutPrivateName):
(JSC::FTL::DFG::LowerDFGToB3::cachedPutById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValImpl):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDelBy):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::FTL::DFG::LowerDFGToB3::compileNewStringObject):
(JSC::FTL::DFG::LowerDFGToB3::emitNewTypedArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileNotifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- jit/CCallHelpers.cpp:
- jit/CCallHelpers.h:
(JSC::CCallHelpers::std::is_pointer<CURRENT_ARGUMENT_TYPE>::value): Deleted.
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JITArithmetic.cpp:
(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::op_enter_handlerGenerator):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_new_regexp):
(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_profile_type):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter_by_id):
(JSC::JIT::emitWriteBarrier):
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
- 5:24 PM Changeset in webkit [292444] by
-
- 3 edits in trunk/Source/WebCore/PAL
[XCBuild] PAL: Add headers-only dependency on WebGPU
https://bugs.webkit.org/show_bug.cgi?id=238646
Reviewed by Alexey Proskuryakov.
Lots of includes of WebGPU in pal/graphics/WebGPU/Impl, so the build system needs to know to
copy its headers before building PAL.
Clean up a file reference to a header that was removed in
https://commits.webkit.org/247364@main
- PAL.xcodeproj/project.pbxproj:
- 5:08 PM Changeset in webkit [292443] by
-
- 2 edits in branches/safari-614.1.9-branch/Source/WebCore
Cherry-pick r292430. rdar://problem/91293025
[Cocoa] Video is sometimes not visible after r292049
https://bugs.webkit.org/show_bug.cgi?id=238826
Reviewed by Jer Noble.
RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false), the page visibility has not changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:08 PM Changeset in webkit [292442] by
-
- 3 edits in branches/safari-614.1.9-branch/Source/WebKit
Cherry-pick r292426. rdar://problem/90808910
Verify generalStorageDirectory is not in use when creating WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=238686
rdar://90808910
Reviewed by Chris Dumez.
In r290739, we added assertion to verify that no two sessions share the same general storage directory. The
assertion is hit on macOS as shown in rdar://90808910. However, because we checked the directories when
launching new network process, not when creating WebsiteDataStore, the backtraces do not give much information
about when the problematic WebsiteDataStore (using the generalStorageDirectory that's already used by another
WebsiteDataStore) is created. To help debug the issue, let's move the assertion to the constructor of
WebsiteDataStore.
- UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
- UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::activeGeneralStorageDirectories): (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::~WebsiteDataStore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:52 PM Changeset in webkit [292441] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Regression(r291729) The result of logging $0 to the console shows overlapping
$0and$[n]after the node
https://bugs.webkit.org/show_bug.cgi?id=238843
Reviewed by Devin Rousso.
r291729 was missing a check that the
DOMTreeOutlineis actually supposed to show an indicator for the
inspected node, which means other uses ofDOMTreeOutline(the console, the sources tab, etc.) were showing the
$0 indicator as well.
- UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline.prototype.update):
- 4:28 PM Changeset in webkit [292440] by
-
- 6 edits in trunk/Source
[PlayStation[ Fix build break after r292408
https://bugs.webkit.org/show_bug.cgi?id=238840
Unreviewed build fix.
Source/WebCore:
- platform/LocalizedStrings.cpp:
- platform/network/playstation/CurlSSLHandlePlayStation.cpp:
- platform/playstation/UserAgentPlayStation.cpp:
Source/WebKit:
- UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
- 4:19 PM Changeset in webkit [292439] by
-
- 1 copy in tags/Safari-613.2.5.0.1
Tag Safari-613.2.5.0.1.
- 4:18 PM Changeset in webkit [292438] by
-
- 3 edits in branches/safari-613.2.5.0-branch/Source/WebKit
Cherry-pick r292431. rdar://problem/90677955
Revert r291598
https://bugs.webkit.org/show_bug.cgi?id=238842
<rdar://90677955>
Reviewed by Geoff Garen.
It caused some problems and needs further analysis.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::createWebSocketTask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:16 PM Changeset in webkit [292437] by
-
- 9 edits in branches/safari-613.2.5.0-branch/Source
Versioning.
WebKit-7613.2.5.0.1
- 4:05 PM Changeset in webkit [292436] by
-
- 1 copy in tags/Safari-614.1.8.4
Tag Safari-614.1.8.4.
- 4:02 PM Changeset in webkit [292435] by
-
- 3 edits in branches/safari-614.1.8-branch/Source/WebKit
Cherry-pick r292431. rdar://problem/91320393
Revert r291598
https://bugs.webkit.org/show_bug.cgi?id=238842
<rdar://90677955>
Reviewed by Geoff Garen.
It caused some problems and needs further analysis.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::createWebSocketTask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:00 PM Changeset in webkit [292434] by
-
- 1 copy in branches/safari-613.2.5.0-branch
New branch.
- 3:33 PM Changeset in webkit [292433] by
-
- 2 edits in trunk/Source/WebKitLegacy
Fix STP build error "no such file or directory: 'Technology'"
https://bugs.webkit.org/show_bug.cgi?id=238834
<rdar://91271288>
Reviewed by Alexey Proskuryakov.
- scripts/migrate-header-rule: Don't generate an export list when
building for Mac. We won't use it, and this script does not support
paths in FRAMEWORK_SEARCH_PATHS containing spaces.
- 3:31 PM Changeset in webkit [292432] by
-
- 9 edits in trunk
Support transitions/animations on grid-template-columns|rows
https://bugs.webkit.org/show_bug.cgi?id=204580
LayoutTests/imported/w3c:
Reviewed by Antoine Quint.
Update expectation files for newly passing tests.
- web-platform-tests/css/css-grid/animation/grid-template-columns-interpolation-expected.txt:
- web-platform-tests/css/css-grid/animation/grid-template-rows-interpolation-expected.txt:
Source/WebCore:
Reviewed by Antoine Quint.
- animation/CSSPropertyAnimation.cpp:
(WebCore::canInterpolate):
(WebCore::blendFunc):
GridTrackLists can be interpolated if they are the same length, and if any repeat() functions
have the same length and count/type.
Adds function for determining if two GridTrackLists can be interpolated, and function for interpolating
per-entry if so.
Adds blending helpers for GridTrackSize and GridLength.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackList):
Remove empty line name sets from the serialized computed style in order to satisfy the shortest equivalent
serialization principle.
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::createGridTrackList):
Ensures computed track lists are stored in the canonical format (alternating between line name sets
and track sizes, starting and ending with a line name set), in order to make the interpolation
code simpler.
LayoutTests:
Reviewed by Antoine Quint.
- 3:16 PM Changeset in webkit [292431] by
-
- 3 edits in trunk/Source/WebKit
Revert r291598
https://bugs.webkit.org/show_bug.cgi?id=238842
<rdar://90677955>
Reviewed by Geoff Garen.
It caused some problems and needs further analysis.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
- 2:56 PM Changeset in webkit [292430] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Video is sometimes not visible after r292049
https://bugs.webkit.org/show_bug.cgi?id=238826
Reviewed by Jer Noble.
RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false),
the page visibility has not changed.
- 2:52 PM Changeset in webkit [292429] by
-
- 6 edits in trunk/Source/WebKit
Unreviewed, reverting r291821.
https://bugs.webkit.org/show_bug.cgi?id=238839
Invalid fix.
Reverted changeset:
"REGRESSION(r286590): Links with URL schemes are not clickable
in Mail"
https://bugs.webkit.org/show_bug.cgi?id=238262
https://commits.webkit.org/r291821
- 2:48 PM Changeset in webkit [292428] by
-
- 2 edits in trunk/Source/JavaScriptCore
Avoid unnecessary String constructions in IdentifiersFactory.cpp
https://bugs.webkit.org/show_bug.cgi?id=238819
Reviewed by Geoffrey Garen.
- inspector/IdentifiersFactory.cpp:
(Inspector::addPrefixToIdentifier):
(Inspector::IdentifiersFactory::createIdentifier):
(Inspector::IdentifiersFactory::requestId):
- 2:38 PM Changeset in webkit [292427] by
-
- 1 copy in tags/Safari-614.1.7.6
Tag Safari-614.1.7.6.
- 2:38 PM Changeset in webkit [292426] by
-
- 3 edits in trunk/Source/WebKit
Verify generalStorageDirectory is not in use when creating WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=238686
rdar://90808910
Reviewed by Chris Dumez.
In r290739, we added assertion to verify that no two sessions share the same general storage directory. The
assertion is hit on macOS as shown in rdar://90808910. However, because we checked the directories when
launching new network process, not when creating WebsiteDataStore, the backtraces do not give much information
about when the problematic WebsiteDataStore (using the generalStorageDirectory that's already used by another
WebsiteDataStore) is created. To help debug the issue, let's move the assertion to the constructor of
WebsiteDataStore.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::activeGeneralStorageDirectories):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
- 2:37 PM Changeset in webkit [292425] by
-
- 9 edits in branches/safari-614.1.8-branch/Source
Versioning.
WebKit-7614.1.8.4
- 2:32 PM Changeset in webkit [292424] by
-
- 2 edits in branches/safari-614.1.7-branch/Source/WebKit
Cherry-pick r291823. rdar://problem/91315158
REGRESSION(STP142): "A JavaScript exception occured: Can't find variable: utils" from SafariDriver
https://bugs.webkit.org/show_bug.cgi?id=238335
Reviewed by Devin Rousso.
Following r289467, we can't just copy the WebDriver atom scripts to the build products, since they now need to
haveutils.jsin any script that uses theutilsnamespace. TheWebKit.frameworkcopy of these scripts are
later used while building safaridriver, so they need to include the scripts as well.
- WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:30 PM Changeset in webkit [292423] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed GTK build fix after r292408.
- Platform/unix/LoggingUnix.cpp:
(WebKit::logLevelString):
- 2:27 PM Changeset in webkit [292422] by
-
- 2 edits in trunk/Source/WebCore
Make subtrees collapsible in the output of the AXLogger streamSubtree.
https://bugs.webkit.org/show_bug.cgi?id=238829
<rdar://problem/91310566>
Reviewed by Chris Fleizach.
Moved the TextStream::GroupScope from the method logging an individual
object to the method logging the hierarchy. This allows to collapse the
entire subtree rooted at a given object.
- accessibility/AXLogger.cpp:
(WebCore::streamAXCoreObject):
(WebCore::streamSubtree):
- 2:21 PM Changeset in webkit [292421] by
-
- 9 edits in branches/safari-614.1.7-branch/Source
Versioning.
WebKit-7614.1.7.6
- 2:10 PM Changeset in webkit [292420] by
-
- 2 edits in trunk/LayoutTests
[ Mac ] accessibility/mac/expanded-notification.html is a flaky text failure
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:45 PM Changeset in webkit [292419] by
-
- 153 edits4 copies24 moves74 adds in trunk/LayoutTests
Re-import css/selectors WPT
https://bugs.webkit.org/show_bug.cgi?id=238820
Reviewed by Simon Fraser.
Upstream commit: https://github.com/web-platform-tests/wpt/commit/ef2b67e4a79e8f8d37556533e6dc715d2c692a78
LayoutTests/imported/w3c:
- resources/resource-files.json:
- web-platform-tests/css/selectors/any-link-dynamic-001-ref.html: Added.
- web-platform-tests/css/selectors/child-indexed-no-parent-expected.html: Added.
- web-platform-tests/css/selectors/child-indexed-no-parent-ref.html: Added.
- web-platform-tests/css/selectors/child-indexed-no-parent.html: Added.
- web-platform-tests/css/selectors/dir-selector-auto-direction-change-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001-expected.xht.
- web-platform-tests/css/selectors/dir-selector-auto-direction-change-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001.html.
- web-platform-tests/css/selectors/dir-selector-auto-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto-expected.txt.
- web-platform-tests/css/selectors/dir-selector-auto.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto.html.
- web-platform-tests/css/selectors/dir-selector-change-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001-expected.html.
- web-platform-tests/css/selectors/dir-selector-change-001-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-003-expected.html.
- web-platform-tests/css/selectors/dir-selector-change-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001.html.
- web-platform-tests/css/selectors/dir-selector-change-002-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-002-expected.xht.
- web-platform-tests/css/selectors/dir-selector-change-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-002.html.
- web-platform-tests/css/selectors/dir-selector-change-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001-expected.html.
- web-platform-tests/css/selectors/dir-selector-change-003-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001-expected.html.
- web-platform-tests/css/selectors/dir-selector-change-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-003.html.
- web-platform-tests/css/selectors/dir-selector-change-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-004-expected.html.
- web-platform-tests/css/selectors/dir-selector-change-004-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-004-expected.html.
- web-platform-tests/css/selectors/dir-selector-change-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-004.html.
- web-platform-tests/css/selectors/dir-selector-ltr-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-001-expected.xht.
- web-platform-tests/css/selectors/dir-selector-ltr-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-001.html.
- web-platform-tests/css/selectors/dir-selector-ltr-002-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-002-expected.xht.
- web-platform-tests/css/selectors/dir-selector-ltr-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-002.html.
- web-platform-tests/css/selectors/dir-selector-ltr-003-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-003-expected.xht.
- web-platform-tests/css/selectors/dir-selector-ltr-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-003.html.
- web-platform-tests/css/selectors/dir-selector-querySelector-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-querySelector-expected.txt.
- web-platform-tests/css/selectors/dir-selector-querySelector.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-querySelector.html.
- web-platform-tests/css/selectors/dir-selector-rtl-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-rtl-001-expected.xht.
- web-platform-tests/css/selectors/dir-selector-rtl-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-rtl-001.html.
- web-platform-tests/css/selectors/dir-selector-white-space-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-white-space-001-expected.html.
- web-platform-tests/css/selectors/dir-selector-white-space-001-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-white-space-001-expected.html.
- web-platform-tests/css/selectors/dir-selector-white-space-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-white-space-001.html.
- web-platform-tests/css/selectors/dir-style-01-ref.html: Added.
- web-platform-tests/css/selectors/dir-style-01a-expected.html: Added.
- web-platform-tests/css/selectors/dir-style-01a.html: Added.
- web-platform-tests/css/selectors/dir-style-01b-expected.html: Added.
- web-platform-tests/css/selectors/dir-style-01b.html: Added.
- web-platform-tests/css/selectors/dir-style-02-ref.html: Added.
- web-platform-tests/css/selectors/dir-style-02a-expected.html: Added.
- web-platform-tests/css/selectors/dir-style-02a.html: Added.
- web-platform-tests/css/selectors/dir-style-02b-expected.html: Added.
- web-platform-tests/css/selectors/dir-style-02b.html: Added.
- web-platform-tests/css/selectors/dir-style-03-ref.html: Added.
- web-platform-tests/css/selectors/dir-style-03a-expected.html: Added.
- web-platform-tests/css/selectors/dir-style-03a.html: Added.
- web-platform-tests/css/selectors/dir-style-03b-expected.html: Added.
- web-platform-tests/css/selectors/dir-style-03b.html: Added.
- web-platform-tests/css/selectors/dir-style-04-expected.html: Added.
- web-platform-tests/css/selectors/dir-style-04-ref.html: Added.
- web-platform-tests/css/selectors/dir-style-04.html: Added.
- web-platform-tests/css/selectors/first-letter-flag-001-ref.html: Added.
- web-platform-tests/css/selectors/first-line-bidi-001-ref.html: Added.
- web-platform-tests/css/selectors/first-line-bidi-002-ref.html: Added.
- web-platform-tests/css/selectors/floating-first-letter-ref.html: Added.
- web-platform-tests/css/selectors/focus-display-none-001.html:
- web-platform-tests/css/selectors/focus-within-001-ref.html: Added.
- web-platform-tests/css/selectors/focus-within-006-ref.html: Added.
- web-platform-tests/css/selectors/focus-within-007-ref.html: Added.
- web-platform-tests/css/selectors/focus-within-011-expected.html: Added.
- web-platform-tests/css/selectors/focus-within-011-ref.html: Added.
- web-platform-tests/css/selectors/focus-within-011.html: Added.
- web-platform-tests/css/selectors/focus-within-012-expected.html: Added.
- web-platform-tests/css/selectors/focus-within-012-ref.html: Added.
- web-platform-tests/css/selectors/focus-within-012.html: Added.
- web-platform-tests/css/selectors/focus-within-013-expected.html: Added.
- web-platform-tests/css/selectors/focus-within-013-ref.html: Added.
- web-platform-tests/css/selectors/focus-within-013.html: Added.
- web-platform-tests/css/selectors/focus-within-display-none-001.html:
- web-platform-tests/css/selectors/focus-within-shadow-001-ref.html: Added.
- web-platform-tests/css/selectors/invalidation/class-id-attr-expected.html: Added.
- web-platform-tests/css/selectors/invalidation/class-id-attr-ref.html: Added.
- web-platform-tests/css/selectors/invalidation/class-id-attr.html: Added.
- web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html: Added.
- web-platform-tests/css/selectors/invalidation/location-pseudo-classes-in-has-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/location-pseudo-classes-in-has.html: Added.
- web-platform-tests/css/selectors/invalidation/sheet-going-away-002-ref.html: Added.
- web-platform-tests/css/selectors/invalidation/user-action-pseudo-classes-in-has-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/user-action-pseudo-classes-in-has.html: Added.
- web-platform-tests/css/selectors/invalidation/w3c-import.log:
- web-platform-tests/css/selectors/is-where-pseudo-elements-ref.html: Added.
- web-platform-tests/css/selectors/is-where-visited-ref.html: Added.
- web-platform-tests/css/selectors/nesting-ref.html: Added.
- web-platform-tests/css/selectors/not-links-ref.html: Added.
- web-platform-tests/css/selectors/of-type-selectors-ref.xhtml: Added.
- web-platform-tests/css/selectors/old-tests/css3-modsel-1.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-10.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-11.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-13.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-14.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-144.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-148.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-149.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-149b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-14b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-14c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-14d.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-14e.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-15.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-150.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-151.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-152.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-154.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-155.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-155a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-155b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-155c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-155d.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-156.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-156b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-156c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-157.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-158.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-15b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-160.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-166.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-166a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-167.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-167a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-168.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-168a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-169.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-169a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-170.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-170a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-170b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-170c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-170d.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-175a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-175b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-175c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-176.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-177b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-178.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-179.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-179a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-180a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-181.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-183.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-184-ref.xht: Added.
- web-platform-tests/css/selectors/old-tests/css3-modsel-184a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-184b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-184c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-184d.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-184e.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-184f.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-2.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-21b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-21c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-22.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-25.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-27.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-27a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-27b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-28.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-28b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-29.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-29b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-30.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-31.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-32.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-33.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-34.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-35.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-36.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-37.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-38.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-39.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-39a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-39b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-39c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-3a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-4.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-41.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-41a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-42.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-42a.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-43.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-43b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-44.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-44b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-44c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-44d.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-45.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-45b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-45c.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-46.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-46b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-5.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-54.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-55.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-56.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-59.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-6.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-60.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-66b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-67.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-7.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-70.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-72.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-72b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-73.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-73b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-74.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-74b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-75.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-75b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-76.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-76b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-77.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-77b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-78.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-78b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-79.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-7b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-8.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-80.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-81.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-81b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-82.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-82b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-83-ref.xml: Added.
- web-platform-tests/css/selectors/old-tests/css3-modsel-86.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-87.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-87b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-88.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-88b.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-89.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-9.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-90.xml:
- web-platform-tests/css/selectors/old-tests/css3-modsel-90b.xml:
- web-platform-tests/css/selectors/old-tests/w3c-import.log:
- web-platform-tests/css/selectors/remove-hovered-element-ref.html: Added.
- web-platform-tests/css/selectors/selector-placeholder-shown-type-change-001-ref.html: Added.
- web-platform-tests/css/selectors/selector-placeholder-shown-type-change-002-ref.html: Added.
- web-platform-tests/css/selectors/selector-placeholder-shown-type-change-003-ref.html: Added.
- web-platform-tests/css/selectors/selector-read-write-type-change-001-ref.html: Added.
- web-platform-tests/css/selectors/selector-read-write-type-change-002-ref.html: Added.
- web-platform-tests/css/selectors/selector-required-ref.html: Added.
- web-platform-tests/css/selectors/selector-required-type-change-001-ref.html: Added.
- web-platform-tests/css/selectors/selector-required-type-change-002-ref.html: Added.
- web-platform-tests/css/selectors/selector-structural-pseudo-root-ref.html: Added.
- web-platform-tests/css/selectors/selectors-attr-white-space-001-ref.html: Added.
- web-platform-tests/css/selectors/selectors-empty-001-ref.xml: Added.
- web-platform-tests/css/selectors/selectors-namespace-001-ref.xml: Added.
- web-platform-tests/css/selectors/sharing-in-svg-use-ref.html: Added.
- web-platform-tests/css/selectors/visited-inheritance-expected.html: Added.
- web-platform-tests/css/selectors/visited-inheritance-ref.html: Added.
- web-platform-tests/css/selectors/visited-inheritance.html: Added.
- web-platform-tests/css/selectors/w3c-import.log:
- web-platform-tests/css/selectors/xml-class-selector-ref.xml: Added.
LayoutTests:
- 1:24 PM Changeset in webkit [292418] by
-
- 2 edits in trunk/Source/WebCore
Avoid unnecessary traversal when updating list markers
https://bugs.webkit.org/show_bug.cgi?id=238795
Reviewed by Anders Carlsson.
This code could use a full rewrite but there are also some simple optimizations that can be done.
- rendering/RenderListItem.cpp:
(WebCore::nextListItemHelper):
Don't advance into non-rendered subtrees. We won't find any renderers there.
- 1:16 PM Changeset in webkit [292417] by
-
- 5 edits in trunk/Source/WebCore
Implement faster lookup of HTML tags in the HTML parser
https://bugs.webkit.org/show_bug.cgi?id=238804
Reviewed by Geoffrey Garen.
Implement faster lookup of HTML tags in the HTML parser by having make_names.pl generate
a findHTMLTag function that returns very efficient well-known HTML tag names.
It is a little more efficient that our current HTMLNameCache (0.4% progression on
Speedometer on MacBookAir 10,1, neutral on iMac20,1). Unlike the HTMLNameCache, It doesn't
require any hashing or additional storage since the set of well-known HTML tags is known
at compile time.
- dom/make_names.pl:
(printNamesHeaderFile):
(findMaxTagLength):
(tagsWithLength):
(generateFindTagForLength):
(printNamesCppFile):
- html/parser/AtomHTMLToken.h:
(WebCore::AtomHTMLToken::AtomHTMLToken):
- html/parser/HTMLNameCache.cpp:
(WebCore::HTMLNameCache::atomStringCache):
- html/parser/HTMLNameCache.h:
(WebCore::HTMLNameCache::makeAttributeValue):
(WebCore::HTMLNameCache::clear):
(WebCore::HTMLNameCache::makeAtomString):
(WebCore::HTMLNameCache::atomStringCacheSlot):
(WebCore::HTMLNameCache::makeTagName): Deleted.
- 1:11 PM Changeset in webkit [292416] by
-
- 4 edits in trunk
[CSS-Contain] Flex layout should take "contain: inline-size" into account when computing the flex item's logical width
https://bugs.webkit.org/show_bug.cgi?id=238805
Reviewed by Antti Koivisto.
Source/WebCore:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths const):
LayoutTests:
- 1:02 PM Changeset in webkit [292415] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
Unreviewed WinCairo build fix after r292408.
- WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::initialize):
- 1:01 PM Changeset in webkit [292414] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] Set svn:ignore on WebGPU.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=238828
Reviewed by Alexey Proskuryakov.
For people who use pure SVN, building causes some spurious files to be created.
Other WebKit projects solve this by setting svn:ignore on .xcodeproj directories.
This does the same.
% svn propget svn:ignore WebGPU.xcodeproj
*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata
%
- WebGPU.xcodeproj: Set svn:ignore.
- 12:54 PM Changeset in webkit [292413] by
-
- 5 edits in trunk/Source
Unreviewed WinCairo build fix after r292408.
Source/WebCore:
- platform/win/GDIObjectCounter.cpp:
(WebCore::GDIObjectCounter::GDIObjectCounter):
- platform/win/GDIObjectCounter.h:
Source/WebKitLegacy/win:
- WebView.cpp:
(imeNotificationName):
(imeRequestName):
- 12:47 PM Changeset in webkit [292412] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows debug build fix after r292279.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 12:46 PM Changeset in webkit [292411] by
-
- 4 edits1 add in trunk/Source/ThirdParty/libwebrtc
Reland "[XCBuild] libwebrtc's headers are copied via rsync and do not emit task outputs"
https://bugs.webkit.org/show_bug.cgi?id=237112
Reviewed by Alexey Proskuryakov.
r291239 did not add all the headers needed for absl. In particular, some "internal" headers
which are included by public absl headers needed to be added. This omission was masked on
EWS by incremental build data, and on engineering builds by SDK content.
Add the missing headers. Additionally, commit a sorted version of the project (via
sort-Xcode-project-file) to reduce the scope of the diff and clean up the project for
future changes.
- Configurations/Base.xcconfig: Same as before.
- Configurations/libabsl.xcconfig: Same as before.
- Configurations/libwebrtc.xcconfig: Same as before.
- libwebrtc.xcodeproj/project.pbxproj: Headers added, project sorted.
- 12:42 PM Changeset in webkit [292410] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r292408.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::removeNetworkWebsiteData):
- 11:54 AM Changeset in webkit [292409] by
-
- 3 edits in trunk/LayoutTests
[ iOS Mac ] http/tests/workers/service/openwindow-from-notification-click.html is a flaky text failure
Unreviewed test gardening.
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 11:54 AM Changeset in webkit [292408] by
-
- 247 edits in trunk
Mark String(const char*) constructor as explicit
https://bugs.webkit.org/show_bug.cgi?id=238693
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- API/glib/JSCContext.cpp:
(jsc_context_check_syntax):
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::startAutomationSession):
- tools/JSDollarVM.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION_WITH_ATTRIBUTES):
Source/WebCore:
- Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::fetchDescription):
(WebCore::GStreamerMediaEndpoint::storeRemoteMLineInfo):
(WebCore::GStreamerMediaEndpoint::addIceCandidate):
(WebCore::GStreamerMediaEndpoint::createSessionDescriptionSucceeded):
(WebCore::GStreamerMediaEndpoint::createSessionDescriptionFailed):
(WebCore::GStreamerMediaEndpoint::collectTransceivers):
- Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::gstreamerRtpCapatiblities):
(WebCore::GStreamerPeerConnectionBackend::doCreateAnswer):
- Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp:
(WebCore::GStreamerRtpTransceiverBackend::mid):
- Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::fillRTCStats):
(WebCore::fillRTCRTPStreamStats):
(WebCore::fillOutboundRTPStreamStats):
- Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:
(WebCore::toRTCError):
(WebCore::toRTCEncodingParameters):
- Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
- accessibility/AXObjectCache.h:
- accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::attributes const):
(WebCore::AccessibilityObjectAtspi::effectiveRoleName const):
(WebCore::AccessibilityObjectAtspi::roleName const):
- accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::textAttributes const):
- accessibility/atspi/AccessibilityRootAtspi.cpp:
(WebCore::AccessibilityRootAtspi::embedded):
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::notificationPlatformName):
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityScroll:]):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
- editing/gtk/WebContentReaderGtk.cpp:
(WebCore::WebContentReader::readFilePath):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::removeUnchangeableStyles):
- editing/libwpe/EditorLibWPE.cpp:
(WebCore::createFragmentFromPasteboardData):
- html/HTMLMediaElement.cpp:
(WTF::LogArgument<URL>::toString):
- html/OffscreenCanvas.h:
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::indexForData):
- loader/soup/ResourceLoaderSoup.cpp:
(WebCore::ResourceLoader::loadGResource):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/DebugPageOverlays.cpp:
(WebCore::InteractionRegionOverlay::valueForSetting):
(WebCore::InteractionRegionOverlay::drawRect):
(WebCore::InteractionRegionOverlay::mouseEvent):
- page/cocoa/SettingsBaseCocoa.mm:
(WebCore::SettingsBase::initializeDefaultFontFamilies):
- platform/PasteboardCustomData.h:
(WebCore::PasteboardCustomData::gtkType):
- platform/UserAgent.h:
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
- platform/glib/UserAgentGLib.cpp:
(WebCore::platformVersionForUAString):
(WebCore::standardUserAgent):
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::compileShaderSource):
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::validateDepthStencil):
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(printColor):
(printLayer):
- platform/graphics/cairo/ImageBufferCairoBackend.cpp:
(WebCore::ImageBufferCairoBackend::toDataURL const):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::getFamilyNameStringFromFamily):
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps):
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::parseGstStructureValue):
- platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType const):
(WebCore::GStreamerRegistryScanner::initializeDecoders):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
(WebCore::MediaPlayerPrivateGStreamer::configureDownloadBuffer):
(WebCore::MediaPlayerPrivateGStreamer::downloadBufferFileCreatedCallback):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::parseInitDataFromProtectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleProtectionEvent):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::getLanguageCode):
(WebCore::TrackPrivateBaseGStreamer::getTag):
- platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:
(webkitGstTraceProcessingTimeForElement):
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcSetExtraHeader):
(webKitWebSrcMakeRequest):
(convertPlaybinURI):
- platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
- platform/graphics/opengl/ExtensionsGLOpenGL.cpp:
(WebCore::ExtensionsGLOpenGL::platformSupportsExtension):
(WebCore::ExtensionsGLOpenGL::isVertexArrayObjectSupported):
- platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:
(WebCore::ExtensionsGLOpenGLCommon::getTranslatedShaderSourceANGLE):
- platform/graphics/opengl/ExtensionsGLOpenGLES.cpp:
(WebCore::ExtensionsGLOpenGLES::platformSupportsExtension):
- platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::validateDepthStencil):
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
(WebCore::GraphicsContextGLOpenGL::validateAttributes):
(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
- platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:
(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
(WebCore::GraphicsContextGLOpenGL::validateAttributes):
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLTextureMapperANGLE::platformInitialize):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
- platform/graphics/texmap/TextureMapperFPSCounter.cpp:
(WebCore::TextureMapperFPSCounter::TextureMapperFPSCounter):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
(WebCore::CoordinatedGraphicsLayer::dumpAdditionalProperties const):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createForGlobalSelection):
- platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode):
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::nameOfDragPasteboard):
- platform/ios/UserAgentIOS.mm:
(WebCore::osNameForUserAgent):
- platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::~VideoFullscreenInterfaceAVKit):
- platform/libwpe/PasteboardLibWPE.cpp:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::write):
(WebCore::Pasteboard::writePlainText):
- platform/libwpe/PlatformKeyboardEventLibWPE.cpp:
(WebCore::PlatformKeyboardEvent::keyIdentifierForWPEKeyCode):
- platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp:
(WebCore::MediaRecorderPrivateGStreamer::containerProfile):
- platform/network/MIMEHeader.cpp:
(WebCore::MIMEHeader::parseHeader):
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::ResourceError):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- platform/network/curl/CertificateInfoCurl.cpp:
(WebCore::CertificateInfo::verificationErrorDescription const):
- platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::searchCookies):
- platform/network/curl/CookieUtil.cpp:
(WebCore::CookieUtil::defaultPathForURL):
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::CurlCacheEntry):
(WebCore::CurlCacheEntry::saveResponseHeaders):
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::setCacheDirectory):
(WebCore::CurlCacheManager::saveIndex):
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::appendRequestHeader):
(WebCore::CurlHandle::removeRequestHeader):
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::willSendRequest):
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupPUT):
(WebCore::CurlRequest::setupSendData):
- platform/network/curl/CurlResourceHandleDelegate.cpp:
(WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse):
- platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::defaultCookieJarPath):
- platform/network/curl/OpenSSLHelper.cpp:
(OpenSSL::tlsVersion):
(OpenSSL::tlsCipherName):
- platform/network/curl/PublicSuffixCurl.cpp:
(WebCore::topPrivatelyControlledDomainInternal):
- platform/network/curl/ResourceError.h:
- platform/network/curl/ResourceErrorCurl.cpp:
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::willSendRequest):
- platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::ResourceResponse):
- platform/network/ios/LegacyPreviewLoaderClient.h:
(WebCore::LegacyPreviewLoaderClient::didRequestPassword):
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::hasCookies const):
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::transportError):
(WebCore::ResourceError::authenticationError):
(WebCore::ResourceError::genericGError):
(WebCore::ResourceError::tlsError):
(WebCore::ResourceError::timeoutError):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::ResourceResponse):
- platform/text/hyphen/HyphenationLibHyphen.cpp:
(WebCore::scanDirectoryForDictionaries):
- platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::initializeLocaleData):
- platform/win/KeyEventWin.cpp:
(WebCore::keyIdentifierForWindowsKeyCode):
- platform/win/LocalizedStringsWin.cpp:
(WebCore::uploadFileText):
(WebCore::allFilesText):
- platform/win/MIMETypeRegistryWin.cpp:
(WebCore::MIMETypeRegistry::mimeTypeForExtension):
- platform/win/PasteboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::Pasteboard::typesSafeForBindings):
(WebCore::Pasteboard::readString):
(WebCore::writeURL):
(WebCore::Pasteboard::writeURLToDataObject):
(WebCore::Pasteboard::write):
(WebCore::Pasteboard::read):
(WebCore::createGlobalImageFileDescriptor):
(WebCore::Pasteboard::writeMarkup):
- platform/win/SystemInfo.cpp:
(WebCore::osVersionForUAString):
(WebCore::architectureTokenForUAString):
- platform/xr/openxr/OpenXRInputMappings.h:
(PlatformXR::buttonTypeToString):
(PlatformXR::axisTypetoString):
- platform/xr/openxr/OpenXRUtils.h:
(PlatformXR::handenessToString):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
Source/WebCore/PAL:
- pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:
(PAL::WebGPU::adapterName):
- pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
(PAL::WebGPU::DeviceImpl::popErrorScope):
Source/WebDriver:
- CommandResult.cpp:
(WebDriver::CommandResult::CommandResult):
- Session.cpp:
(WebDriver::Session::handleUserPrompts):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::setWindowRect):
(WebDriver::Session::elementIsFileUpload):
(WebDriver::Session::elementIsEditable):
(WebDriver::Session::elementSendKeys):
(WebDriver::builtAutomationCookie):
(WebDriver::automationSourceType):
(WebDriver::automationOriginType):
- WebDriverService.cpp:
(WebDriver::WebDriverService::run):
(WebDriver::deserializeProxy):
(WebDriver::WebDriverService::createSession):
- socket/CapabilitiesSocket.cpp:
(WebDriver::CapabilitiesSocket::parseCapabilities):
- socket/HTTPServerSocket.cpp:
(WebDriver::HTTPRequestHandler::didReceive):
Source/WebGPU:
- WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::copyTextureToBuffer):
(WebGPU::CommandEncoder::copyTextureToTexture):
Source/WebKit:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(stringForSSLProtocol):
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
(WebKit::NetworkDataTaskSoup::readCallback):
(WebKit::NetworkDataTaskSoup::didRequestNextPart):
(WebKit::NetworkDataTaskSoup::download):
(WebKit::NetworkDataTaskSoup::writeDownloadCallback):
(WebKit::NetworkDataTaskSoup::didFinishDownload):
(WebKit::NetworkDataTaskSoup::didGetFileInfo):
(WebKit::NetworkDataTaskSoup::readFileCallback):
(WebKit::NetworkDataTaskSoup::enumerateFileChildrenCallback):
- NetworkProcess/soup/WebSocketTaskSoup.cpp:
(WebKit::WebSocketTask::didConnect):
- Shared/API/Cocoa/WKRemoteObjectCoder.h:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(WebKit::methodSignaturesAreCompatible):
(decodeInvocation):
- Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(replyBlockSignature):
(-[_WKRemoteObjectRegistry _invokeMethod:]):
- Shared/API/glib/WebKitURIRequest.cpp:
(webkit_uri_request_set_uri):
- Shared/gtk/WebErrorsGtk.cpp:
(WebKit::printerNotFoundError):
(WebKit::invalidPageRangeToPrint):
- UIProcess/API/glib/WebKitAutomationSession.cpp:
(webkitAutomationSessionGetBrowserName):
- UIProcess/API/glib/WebKitCredential.cpp:
(webkit_credential_new_for_certificate_pin):
- UIProcess/API/glib/WebKitInjectedBundleClient.cpp:
- UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleRequest):
- UIProcess/API/glib/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate):
(webkit_settings_set_user_agent):
- UIProcess/API/glib/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish_error):
- UIProcess/API/gtk/DragSourceGtk4.cpp:
(WebKit::DragSource::begin):
- UIProcess/API/gtk/DropTargetGtk3.cpp:
(WebKit::DropTarget::DropTarget):
- UIProcess/API/gtk/DropTargetGtk4.cpp:
(WebKit::DropTarget::DropTarget):
- UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::~RemoteInspectorProtocolHandler):
(WebKit::RemoteInspectorProtocolHandler::handleRequest):
(WebKit::RemoteInspectorProtocolHandler::targetListChanged):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseEnterFullScreen):
- UIProcess/API/wpe/WebKitColor.cpp:
(webkit_color_parse):
- UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:
(WebKit::malwareDetailsBase):
(WebKit::reportAnErrorBase):
- UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
- UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:
(WebKit::RemoteWebInspectorUIProxy::platformCreateFrontendPageAndWindow):
(WebKit::remoteFileReplaceContentsCallback):
- UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:
(WebKit::WebInspectorUIProxy::platformCreateFrontendPage):
(WebKit::fileReplaceContentsCallback):
- UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::platformStartTask):
- UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:
(WebKit::RemoteWebInspectorUIProxy::platformCreateFrontendPageAndWindow):
- UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:
(WebKit::WebInspectorUIProxy::platformCreateFrontendPage):
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindSymlinksRealPath):
(WebKit::bubblewrapSpawn):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
- UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- UIProcess/glib/WebsiteDataStoreGLib.cpp:
- UIProcess/gtk/ClipboardGtk3.cpp:
(WebKit::Clipboard::write):
- UIProcess/gtk/ClipboardGtk4.cpp:
(WebKit::Clipboard::write):
- UIProcess/gtk/KeyBindingTranslator.cpp:
- UIProcess/win/WebProcessPoolWin.cpp:
(WebKit::backendCommandsPath):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
- WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(webkitWebPageDidReceiveMessage):
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
(webkit_dom_document_get_visibility_state):
- WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:
(WebKit::handleKeyPress):
(WebKit::handleKeyDown):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScript):
- WebProcess/WebPage/glib/WebPageGLib.cpp:
(WebKit::WebPage::getPlatformEditorState const):
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::generateSyntheticEditingCommand):
(WebKit::WebPage::platformUserAgent const):
- WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::handleEditingKeyboardEvent):
- webpushd/PushClientConnection.mm:
(WebPushD::ClientConnection::hostAppCodeSigningIdentifier):
Source/WebKitLegacy/mac:
- DOM/DOM.mm:
(-[DOMHTMLLinkElement _mediaQueryMatches]):
- WebCoreSupport/WebEditorClient.h:
(WebEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- WebView/WebDataSource.mm:
(-[WebDataSource _setOverrideTextEncodingName:]):
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKitLegacy/win:
- AccessibleBase.cpp:
(AccessibleBase::AccessibleBase):
(AccessibleBase::~AccessibleBase):
- CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::CFDictionaryPropertyBag):
(CFDictionaryPropertyBag::~CFDictionaryPropertyBag):
- DefaultDownloadDelegate.cpp:
(DefaultDownloadDelegate::DefaultDownloadDelegate):
(DefaultDownloadDelegate::~DefaultDownloadDelegate):
- DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::DefaultPolicyDelegate):
(DefaultPolicyDelegate::~DefaultPolicyDelegate):
- MemoryStream.cpp:
(MemoryStream::MemoryStream):
(MemoryStream::~MemoryStream):
- WebActionPropertyBag.cpp:
(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::~WebActionPropertyBag):
- WebApplicationCache.cpp:
(WebApplicationCache::WebApplicationCache):
(WebApplicationCache::~WebApplicationCache):
(WebApplicationCache::storage):
- WebArchive.cpp:
(WebArchive::WebArchive):
(WebArchive::~WebArchive):
- WebBackForwardList.cpp:
(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::~WebBackForwardList):
- WebCache.cpp:
(WebCache::WebCache):
(WebCache::~WebCache):
- WebCoreStatistics.cpp:
(WebCoreStatistics::WebCoreStatistics):
(WebCoreStatistics::~WebCoreStatistics):
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
(WebCoreStatistics::javaScriptObjectTypeCounts):
(WebCoreStatistics::memoryStatistics):
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::doTextFieldCommandFromEvent):
- WebDataSource.cpp:
(WebDataSource::~WebDataSource):
- WebDatabaseManager.cpp:
(WebDatabaseManager::WebDatabaseManager):
(WebDatabaseManager::~WebDatabaseManager):
- WebDocumentLoader.cpp:
(WebDocumentLoader::WebDocumentLoader):
(WebDocumentLoader::~WebDocumentLoader):
- WebDownload.cpp:
(WebDownload::WebDownload):
(WebDownload::~WebDownload):
- WebDownloadCFNet.cpp:
(WebDownload::cancelAuthenticationChallenge):
- WebDropSource.cpp:
(WebDropSource::WebDropSource):
(WebDropSource::~WebDropSource):
- WebElementPropertyBag.cpp:
(WebElementPropertyBag::WebElementPropertyBag):
(WebElementPropertyBag::~WebElementPropertyBag):
- WebError.cpp:
(WebError::WebError):
(WebError::~WebError):
- WebFrame.cpp:
(WebFrame::WebFrame):
(WebFrame::~WebFrame):
(WebFrame::loadData):
(WebFrame::selectAll):
- WebFramePolicyListener.cpp:
(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::~WebFramePolicyListener):
- WebGeolocationPolicyListener.cpp:
(WebGeolocationPolicyListener::WebGeolocationPolicyListener):
(WebGeolocationPolicyListener::~WebGeolocationPolicyListener):
- WebGeolocationPosition.cpp:
(WebGeolocationPosition::WebGeolocationPosition):
(WebGeolocationPosition::~WebGeolocationPosition):
- WebHTMLRepresentation.cpp:
(WebHTMLRepresentation::WebHTMLRepresentation):
(WebHTMLRepresentation::~WebHTMLRepresentation):
- WebHistory.cpp:
(WebHistory::WebHistory):
(WebHistory::~WebHistory):
- WebHistoryItem.cpp:
(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::~WebHistoryItem):
- WebInspector.cpp:
(WebInspector::WebInspector):
(WebInspector::~WebInspector):
- WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::WebJavaScriptCollector):
(WebJavaScriptCollector::~WebJavaScriptCollector):
- WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory):
(WebKitClassFactory::~WebKitClassFactory):
- WebKitMessageLoop.cpp:
(WebKitMessageLoop::WebKitMessageLoop):
(WebKitMessageLoop::~WebKitMessageLoop):
- WebKitStatistics.cpp:
(WebKitStatistics::WebKitStatistics):
(WebKitStatistics::~WebKitStatistics):
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::WebMutableURLRequest):
(WebMutableURLRequest::~WebMutableURLRequest):
- WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
- WebNotification.cpp:
(WebNotification::WebNotification):
(WebNotification::~WebNotification):
- WebNotificationCenter.cpp:
(WebNotificationCenter::WebNotificationCenter):
(WebNotificationCenter::~WebNotificationCenter):
- WebPreferences.cpp:
(WebPreferences::WebPreferences):
(WebPreferences::~WebPreferences):
- WebResource.cpp:
(WebResource::WebResource):
(WebResource::~WebResource):
- WebScriptObject.cpp:
(WebScriptObject::WebScriptObject):
(WebScriptObject::~WebScriptObject):
- WebScriptWorld.cpp:
(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):
- WebSecurityOrigin.cpp:
(WebSecurityOrigin::WebSecurityOrigin):
(WebSecurityOrigin::~WebSecurityOrigin):
- WebSerializedJSValue.cpp:
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
- WebTextRenderer.cpp:
(WebTextRenderer::WebTextRenderer):
(WebTextRenderer::~WebTextRenderer):
- WebURLAuthenticationChallenge.cpp:
(WebURLAuthenticationChallenge::WebURLAuthenticationChallenge):
(WebURLAuthenticationChallenge::~WebURLAuthenticationChallenge):
- WebURLAuthenticationChallengeSender.cpp:
(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::~WebURLAuthenticationChallengeSender):
- WebURLCredential.cpp:
(WebURLCredential::WebURLCredential):
(WebURLCredential::~WebURLCredential):
- WebURLProtectionSpace.cpp:
(WebURLProtectionSpace::WebURLProtectionSpace):
(WebURLProtectionSpace::~WebURLProtectionSpace):
- WebURLResponse.cpp:
(WebURLResponse::WebURLResponse):
(WebURLResponse::~WebURLResponse):
(WebURLResponse::createInstance):
- WebUserContentURLPattern.cpp:
(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):
- WebView.cpp:
(WebView::WebView):
(WebView::~WebView):
(WebView::execCommand):
(WebView::handleEditingKeyboardEvent):
(WebView::copy):
(WebView::cut):
(WebView::paste):
(WebView::copyURL):
(WebView::delete_):
- WebWorkersPrivate.cpp:
(WebWorkersPrivate::WebWorkersPrivate):
(WebWorkersPrivate::~WebWorkersPrivate):
Source/WTF:
- wtf/FileSystem.cpp:
(WTF::FileSystemImpl::filesHaveSameVolume):
- wtf/FileSystem.h:
- wtf/glib/FileSystemGlib.cpp:
(WTF::FileSystemImpl::getFileDeviceId):
- wtf/posix/FileSystemPOSIX.cpp:
(WTF::FileSystemImpl::getFileDeviceId):
- wtf/text/WTFString.h:
- wtf/unix/LoggingUnix.cpp:
(WTF::logLevelString):
- wtf/win/FileSystemWin.cpp:
(WTF::FileSystemImpl::getFileDeviceId):
- wtf/win/LanguageWin.cpp:
(WTF::platformLanguage):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback):
- TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
(TestWebKitAPI::readAllChunks):
(TestWebKitAPI::TEST_F):
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
(TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
(TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
(TestWebKitAPI::assertUserAgentForURLHasEmptyQuirk):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
(TestWebKitAPI::Curl::TEST_F):
- TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
- TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(cleanUpInAppBrowserPrivacyTestSettings):
(initializeInAppBrowserPrivacyTestSettings):
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
- TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
- TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
(testWebViewWindowProperties):
- TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebExtensionPageID):
- TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
(WebKitTestServer::addWebSocketHandler):
(WebKitTestServer::getWebSocketURIForPath const):
(WebKitTestServer::getURIForPath const):
- TestWebKitAPI/ios/PreferredContentMode.mm:
(TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
(TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
(TestWebKitAPI::TEST):
- WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::currentStateValue const):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::xmlRoleValueString):
(WTR::roleValueToString):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::computedRoleString):
(WTR::AccessibilityUIElement::intValue const):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::hierarchicalLevel const):
(WTR::AccessibilityUIElement::ariaIsGrabbed const):
(WTR::AccessibilityUIElement::ariaDropEffects const):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
- WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
(WTR::toJSONObject):
- lldb/lldbWebKitTester/main.cpp:
(testSummaryProviders):
- 11:45 AM Changeset in webkit [292407] by
-
- 11 edits in trunk/Source/bmalloc
[PlayStation] Enable libpas.
https://bugs.webkit.org/show_bug.cgi?id=238753
Reviewed by Yusuke Suzuki.
PlayStation platform is ready to enable it finally.
- PlatformPlayStation.cmake:
- bmalloc/BPlatform.h:
- libpas/src/libpas/pas_config.h:
- libpas/src/libpas/pas_page_malloc.c:
(pas_page_malloc_try_allocate_without_deallocating_padding):
(commit_impl):
- libpas/src/libpas/pas_platform.h:
- libpas/src/libpas/pas_thread_local_cache.c:
- 11:25 AM Changeset in webkit [292406] by
-
- 2 edits in trunk/Source/WTF
[PlayStation] Build fix after r292389
https://bugs.webkit.org/show_bug.cgi?id=238816
Unreviewed build fix
Add UnixFileDescriptor.h to PlatformPlayStation.cmake
as per the changes to PlatformGTK and PlatformWPE.
- wtf/PlatformPlayStation.cmake:
- 11:05 AM Changeset in webkit [292405] by
-
- 3 edits in trunk/Tools
[Merge-Queue] Extract bug_id when updating pull-request
https://bugs.webkit.org/show_bug.cgi?id=238772
<rdar://problem/91263398>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(LeaveComment.start): Leave comment on both bugzilla and pull request.
(LeaveComment.getResultSummary): Ditto.
(UpdatePullRequest):
(UpdatePullRequest.bug_id_from_log): Extract bug_id from commit message.
(UpdatePullRequest.evaluateCommand): Set bug_id property
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249267@main
- 11:04 AM Changeset in webkit [292404] by
-
- 2 edits in trunk/Source/WebKit
Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
- 10:58 AM Changeset in webkit [292403] by
-
- 4 edits in trunk
Do not create network process in ~WebsiteDataStore destructor
https://bugs.webkit.org/show_bug.cgi?id=238570
Reviewed by Chris Dumez.
Source/WebKit:
Check if m_networkProcess is initialized before removing session
from it instead, otherwise WebsiteDataStore::networkProcess() lazily
creates the process and it will keep running after WebsiteDataStore
is destroyed.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
Tools:
The test is written by Chris Dumez.
- TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(TEST): Test that creating and destroying ephemer WebsiteDataStore doesn't initialize
default network process.
- 10:57 AM Changeset in webkit [292402] by
-
- 6 edits in trunk/Tools
[Merge-Queue] Add author to commit message
https://bugs.webkit.org/show_bug.cgi?id=238752
<rdar://problem/91254339>
Reviewed by Aakash Jain.
svn.webkit.org will attribute a change to a specific author
if "Patch by" is in the commit message.
- Tools/CISupport/ews-build/factories.py:
(MergeQueueFactory.init): Add AddAuthorToCommitMessage step.
- Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps): Ditto.
- Tools/CISupport/ews-build/master.cfg: Determine commit author from github.head.user.login.
- Tools/CISupport/ews-build/steps.py:
(AddAuthorToCommitMessage):
(AddAuthorToCommitMessage.init):
(AddAuthorToCommitMessage.author): Return commit author's name and email, falling back
to the committers name and email if those cannot be determined.
(AddAuthorToCommitMessage.start): Insert "Patch by" into commit message.
(AddAuthorToCommitMessage.getResultSummary):
(AddAuthorToCommitMessage.doStepIf): Only do step if the author can be determined.
(AddAuthorToCommitMessage.hideStepIf): Hide step if skipped.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249265@main
- 10:38 AM Changeset in webkit [292401] by
-
- 5 edits in trunk
5 Media API tests are flakily timing out on iOS14
https://bugs.webkit.org/show_bug.cgi?id=230321
<rdar://problem/83168970>
Reviewed by Jer Noble.
Source/WebKit:
Un-skipped API test WKWebViewPausePlayingAudioTests.OutOfWindow
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationWillEnterForegroundForMedia): Log the correct name.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationDidEnterBackgroundForMedia): Call PlatformMediaSessionManager.
(WebKit::WebPage::applicationWillEnterForegroundForMedia): Ditto.
Tools:
- TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
(TestWebKitAPI::TEST):
- 10:04 AM Changeset in webkit [292400] by
-
- 4 edits2 adds in trunk
[macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button)
https://bugs.webkit.org/show_bug.cgi?id=236782
<rdar://problem/89382543>
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Add specific test for <button> element.
- web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html: Added.
Source/WebCore:
Document::m_latestFocusTrigger was not being updated after clicking on a button (or other form controls)
on platforms different than GTK and WPE.
This is because HTMLFormControlElement::isMouseFocusable() returns false on such platforms.
This issue is causing problems with :focus-visible, as the button is not actually focused via mouse click,
if you move the focus via script afterwards, the new focused element always match :focus-visible.
This patch is a workaround to solve that issue, by updating m_latestFocusTrigger on Document
even if the element is not actually focused.
That way :focus-visible doesn't match if there's a script focus afterwards.
Fix :focus-visible after clicking on a button on Mac
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html
- dom/Document.h:
(WebCore::Document::setLatestFocusTrigger):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
- 9:57 AM Changeset in webkit [292399] by
-
- 1 edit in trunk/Source/WebCore/features.json
Correct additional malformed entries in 'specifications' section.
- 9:44 AM Changeset in webkit [292398] by
-
- 8 edits in trunk/Source
Pass an IOSurfacePool to ImageBuffer::releaseBufferToPool()
https://bugs.webkit.org/show_bug.cgi?id=238768
Reviewed by Said Abou-Hallawa.
In order to move away from a singleton IOSurfacePool, we need to pass the pool
which the IOSurface will be added to.
Source/WebCore:
- platform/graphics/ConcreteImageBuffer.h:
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::CreationContext::CreationContext):
- platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::releaseBufferToPool):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::releaseBufferToPool):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Source/WebKit:
For RemoteLayerBackingStore, pass the singleton WebProcess pool
(this is the non-GPU Process code path).
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::Buffer::discard):
- 9:32 AM Changeset in webkit [292397] by
-
- 1 copy in tags/Safari-614.1.8.3
Tag Safari-614.1.8.3.
- 9:30 AM Changeset in webkit [292396] by
-
- 9 edits in branches/safari-614.1.8-branch/Source
Versioning.
WebKit-7614.1.8.3
- 9:15 AM Changeset in webkit [292395] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the internal iOS build after r292370
Remove an extraneous opening parenthesis.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
- 8:44 AM Changeset in webkit [292394] by
-
- 11 edits in trunk
[CSS-Contain] Add support for contain: inline-size
https://bugs.webkit.org/show_bug.cgi?id=238787
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt:
- web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt:
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeContain):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths const):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths const):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::establishesIndependentFormattingContext const):
- rendering/RenderBox.h:
- style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueContain):
LayoutTests:
- 6:50 AM Changeset in webkit [292393] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] GstCapsForeachFunc returns a gboolean
https://bugs.webkit.org/show_bug.cgi?id=238799
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-04-05
Reviewed by Adrian Perez de Castro.
- platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::RealtimeOutgoingVideoSourceGStreamer):
- 6:37 AM Changeset in webkit [292392] by
-
- 6 edits1 delete in trunk
ANGLE changes.diff contains differences that are from stale files or unneeded
https://bugs.webkit.org/show_bug.cgi?id=238798
Unreviewed, verifiable by running the script.
Source/ThirdParty/ANGLE:
Unneeded changes in changes.diff should be excluded:
- ChangeLog files
- WebKit specific build scripts
- Diff to removed .jar files
Stale changes should be updated from the upstream, should be synced from upstream:
- .gitignore entry from some old path
- Wrong file names in DEQP test expectations, renamed in upstream
- Unused EnvironmentVariable.h that is not present in upstream anymore
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-05
- .gitignore:
- ANGLE.xcodeproj/project.pbxproj:
- changes.diff:
- src/compiler/translator/TranslatorMetalDirect/EnvironmentVariable.h: Removed.
- src/tests/deqp_support/deqp_egl_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_egl_TestExpectations.
- src/tests/deqp_support/deqp_gles2_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles2_TestExpectations.
- src/tests/deqp_support/deqp_gles31_rotate_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles31_rotate_TestExpectations.
- src/tests/deqp_support/deqp_gles31_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles31_TestExpectations.
- src/tests/deqp_support/deqp_gles3_rotate_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles3_rotate_TestExpectations.
- src/tests/deqp_support/deqp_gles3_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles3_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles2_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles2_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles31_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles31_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles32_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles32_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles3_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles3_TestExpectations.
Tools:
Exclude WebKit ChangeLog entries from changes.diff
Exclude WebKit build script copy-frameworks-to-secondary-path.sh
Exclude a file that is not needed downstream custom_d8.jar
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-05
- Scripts/update-angle:
- 4:30 AM Changeset in webkit [292391] by
-
- 7 edits in trunk/Source/WebCore
[GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag
https://bugs.webkit.org/show_bug.cgi?id=238733
Reviewed by Adrian Perez de Castro.
Replace integer values for file descriptors in the DMABufObject and
DMABufReleaseFlag structs with UnixFileDescriptors. This enables
simply defaulting the destructors and the move constructors and
assignment operatos for the two types since the fd wrapper takes care
of these operations.
Additionally, when constructing the UnixFileDescriptor objects from
file descriptors coming from different sources, we can more easily
adapt to the need for either adoption or duplication of the passed-in
file descriptor right there in the constructor invocation.
- platform/graphics/gbm/DMABufObject.h:
(WebCore::DMABufObject::~DMABufObject): Deleted.
(WebCore::DMABufObject::operator=): Deleted.
- platform/graphics/gbm/DMABufReleaseFlag.h:
(WebCore::DMABufReleaseFlag::DMABufReleaseFlag):
(WebCore::DMABufReleaseFlag::dup const):
(WebCore::DMABufReleaseFlag::released const):
(WebCore::DMABufReleaseFlag::release):
(WebCore::DMABufReleaseFlag::~DMABufReleaseFlag): Deleted.
(WebCore::DMABufReleaseFlag::operator=): Deleted.
- platform/graphics/gbm/GBMBufferSwapchain.cpp:
(WebCore::GBMBufferSwapchain::Buffer::createDMABufObject const):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
- platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:
(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::createEGLImageData):
- 4:17 AM WebKitFlatpakSDK edited by
- (diff)
- 4:15 AM WebKitFlatpakSDK/GstBuild edited by
- (diff)
- 4:10 AM WebKitFlatpakSDK/LocalProjects edited by
- (diff)
- 4:07 AM WebKitFlatpakSDK/LocalProjects edited by
- (diff)
- 4:05 AM WebKitFlatpakSDK/LocalProjects edited by
- (diff)
- 4:05 AM WebKitFlatpakSDK/LocalProjects created by
- 3:59 AM WebKitFlatpakSDK/GstBuild edited by
- (diff)
- 3:58 AM WebKitFlatpakSDK edited by
- (diff)
- 3:55 AM Changeset in webkit [292390] by
-
- 2 edits6 adds in trunk/Tools
[Flatpak SDK] Local dependencies override support
https://bugs.webkit.org/show_bug.cgi?id=238452
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-05
Reviewed by Adrian Perez de Castro.
When the environment variable WEBKIT_SDK_LOCAL_DEPS is set at compile-time and runtime, some
dependencies (currently only libsoup and GStreamer) will be picked up from local git
checkouts located in Tools/flatpak/. If no checkout is present, one will be made based on
the corresponding .wrap file.
Example: WEBKIT_SDK_LOCAL_DEPS=libsoup,gstreamer-full build-webkit --wpe ...
Additional Meson options can be supplied with WEBKIT_SDK_LOCAL_DEPS_OPTIONS. Nested
subprojects configuration is supported as well, for example:
export WEBKIT_SDK_LOCAL_DEPS_OPTIONS="-Dgstreamer-full:introspection=disabled -Dgst-plugins-good:soup=disabled"
This setup replaces the previous one that was specific to GStreamer.
- flatpak/flatpakutils.py:
(WebkitFlatpak.load_from_args):
(WebkitFlatpak.init):
(WebkitFlatpak.setup_local_deps):
(WebkitFlatpak._merge_env_variables):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak.setup_dev_env):
(WebkitFlatpak.setup_gstbuild): Deleted.
- flatpak/local-projects/meson.build: Added.
- flatpak/local-projects/subprojects/gstreamer-full.wrap: Added.
- flatpak/local-projects/subprojects/libsoup.wrap: Added.
- 3:48 AM Changeset in webkit [292389] by
-
- 8 edits1 add in trunk/Source
[Unix] Add UnixFileDescriptor, use it in IPC::Semaphore
https://bugs.webkit.org/show_bug.cgi?id=238726
Reviewed by Carlos Garcia Campos.
Source/WebKit:
Use WTF::UnixFileDescriptor in IPC::Semaphore in place of a raw integer
value. This also simplifies other things, e.g. the move constructor and
assignment operator can now both be defaulted.
The IPC encoding and decoding of the semaphore object is also simpler,
leaning into the custom ArgumentCoder specialization for objects of the
WTF::UnixFileDescriptor type. The encoding and decoding is done by
chaperoning the file descriptor through IPC::Attachment.
- Platform/IPC/IPCSemaphore.h:
(IPC::Semaphore::operator bool const):
- Platform/IPC/unix/IPCSemaphoreUnix.cpp:
(IPC::Semaphore::Semaphore):
(IPC::Semaphore::signal):
(IPC::Semaphore::wait):
(IPC::Semaphore::waitFor):
(IPC::Semaphore::encode const):
(IPC::Semaphore::decode):
(IPC::Semaphore::destroy):
(IPC::Semaphore::operator=): Deleted.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<WTF::UnixFileDescriptor>::encode):
(IPC::ArgumentCoder<WTF::UnixFileDescriptor>::decode):
- Shared/WebCoreArgumentCoders.h:
Source/WTF:
Add the UnixFileDescriptor class, intended as a wrapper for a file
descriptor integer. Construction is a matter of adopting or duplicating
the passed-in file descriptor value. UnixFileDescriptor objects can be
moved around and explicitly duplicated, and the contained fd value can
be released.
The wrapper class makes it easier to handle file descriptor values when
embedded into other types as member variables. It also allows to specify
custom encoding and decoding in the WebKit IPC infrastructure.
- wtf/PlatformGTK.cmake:
- wtf/PlatformWPE.cmake:
- wtf/unix/UnixFileDescriptor.h: Added.
(WTF::UnixFileDescriptor::UnixFileDescriptor):
(WTF::UnixFileDescriptor::operator=):
(WTF::UnixFileDescriptor::~UnixFileDescriptor):
(WTF::UnixFileDescriptor::operator bool const):
(WTF::UnixFileDescriptor::value const):
(WTF::UnixFileDescriptor::duplicate const):
- 2:40 AM Changeset in webkit [292388] by
-
- 4 edits in trunk
update-angle output varies unpredictably due to blob hash abbreviation
https://bugs.webkit.org/show_bug.cgi?id=238793
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-05
Reviewed by Antti Koivisto.
Source/ThirdParty/ANGLE:
Update the diff to contain unabbreviated blob hash values. These are more
predictable for all developers.
- changes.diff:
Tools:
Add --full-index to diff to get the unabbreviated blob hash.
- Scripts/update-angle:
- 2:11 AM Changeset in webkit [292387] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] gst_video_format_info_component not defined in GStreamer <1.18
https://bugs.webkit.org/show_bug.cgi?id=238685
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::webkitGstVideoFormatInfoComponent):
- platform/graphics/gstreamer/GStreamerCommon.h:
- 1:50 AM Changeset in webkit [292386] by
-
- 3 edits in trunk/LayoutTests
Skip editing-word-with-marker-1.html
https://bugs.webkit.org/show_bug.cgi?id=238767
Unreviewed test gardening.
- 1:36 AM Changeset in webkit [292385] by
-
- 2 edits in trunk/Source/WebKit
Expand autocorrect context for more accurate results.
https://bugs.webkit.org/show_bug.cgi?id=237990
Reviewed by Wenson Hsieh.
Covered by existing tests.
Expand autocorrect context to at least 10 words instead of 3, and with a min/max length of 40/100
instead of 12/30 and start context at the beginning of sentences to help with having more accurate
autocorrect suggestions.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::autocorrectionContext):
- 1:21 AM Changeset in webkit [292384] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Update ANGLE changes.diff after "Roll ANGLE to 2022-03-31 (fe28a4295af087ee82b8f629b67176b95019af6d)"
https://bugs.webkit.org/show_bug.cgi?id=238794
Unreviewed, verifiable by running the script.
Update the diff, turns out it was not up-to-date.
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-05
- changes.diff:
- 1:19 AM Changeset in webkit [292383] by
-
- 8 edits1 delete in trunk/Source
Remove system feature flags implementation
https://bugs.webkit.org/show_bug.cgi?id=238791
Reviewed by Megan Gardner.
Source/WebKit:
- Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::isFeatureFlagEnabled): Deleted.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::isFeatureFlagEnabled): Deleted.
- Shared/WebPreferencesDefaultValues.h:
- Shared/win/WebPreferencesDefaultValuesWin.cpp: Removed.
Source/WebKitLegacy/mac:
- WebView/WebPreferencesDefaultValues.h:
- WebView/WebPreferencesDefaultValues.mm:
(WebKit::isFeatureFlagEnabled): Deleted.
- 1:03 AM Changeset in webkit [292382] by
-
- 7 edits7 adds in trunk
Support rendering url(), CSS basic shapes other than path(), and coord-box for offset-path
https://bugs.webkit.org/show_bug.cgi?id=233382
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/motion/offset-path-shape-expected.html: Added.
- web-platform-tests/css/motion/offset-path-shape.html: Added.
- web-platform-tests/css/motion/offset-path-url-expected.html: Added.
- web-platform-tests/css/motion/offset-path-url.html: Added.
Source/WebCore:
Introduce support for url(), CSS basic shapes, and coord-box. Url() allows references to SVG
shapes, so we check for either an SVGPathElement or SVGGeometryElement (which includes
circles, polygons, etc.). We can then get a Path object for that particular SVGElement
using pathFromGraphicsElement(). For coord-box, we check the value for the BoxPathOperation
(if it exists) in updateTransform(), and choose the corresponding reference box to the
referenceBox() value of the BoxPathOperation.
Tests: imported/w3c/web-platform-tests/css/motion/offset-path-shape.html
imported/w3c/web-platform-tests/css/motion/offset-path-url.html
- Sources.txt:
- rendering/PathOperation.cpp: Added.
(WebCore::ReferencePathOperation::create):
(WebCore::ReferencePathOperation::ReferencePathOperation):
(WebCore::ReferencePathOperation::element const):
- rendering/PathOperation.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateTransform):
- rendering/style/RenderStyle.cpp:
(WebCore::getPathFromPathOperation):
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPathOperation):
- 1:01 AM Changeset in webkit [292381] by
-
- 4 edits4 adds in trunk
Moving forwards and backwards by sentences across a table results in different breaks in each direction.
https://bugs.webkit.org/show_bug.cgi?id=238621
Reviewed by Darin Adler.
Tests: editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity.html
editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity.html
We need to emit tabs even in a simplified backwards text iterator because otherwise traversing a table by
sentence granularity results in not having the same behavior backwards and forwards.
- editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):
- 12:32 AM Changeset in webkit [292380] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, reverting r292377.
The depended-on patch hasn't landed yet
Reverted changeset:
"[GTK][WPE] Use UnixFileDescriptor in DMABufObject,
DMABufReleaseFlag"
https://bugs.webkit.org/show_bug.cgi?id=238733
https://commits.webkit.org/r292377
- 12:28 AM Changeset in webkit [292379] by
-
- 2 edits in trunk/Source/WebKit
[WPE] Mark "backend" parameters of web view constructors not nullable
https://bugs.webkit.org/show_bug.cgi?id=238734
Reviewed by Martin Robinson.
No new tests needed.
- UIProcess/API/wpe/WebKitWebViewWPE.cpp: Annotate web view constructors with (not nullable)
and while at it, fix documentation links, and improve the wording to better follow gi-docgen
copywriting style. Remove the mentions to the single process model, which is deprecated anyway.
- 12:09 AM Changeset in webkit [292378] by
-
- 1 edit1 add in trunk/LayoutTests
[iOS] Add timeout expectations for focus-after-close.html WPT
Unreviewed test gardening.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt: Added.
